[U-Boot] [PATCH] powerpc/mpc83xx: set TXEQA/TXEQE value for mpc837XE sata
From: Jerry Huang In the current u-boot code, the value of these fields are the reserved value (0b100), through the signal integrity measurement on freescale's board with these reserved setting, the signal eye is out of the recommended spec for non-transition amplitude at 500mV nominal. According to the errata for MPC8379E, we should make a change to the recommended setting from essentially nothing at this time to 0b001 for SATA. Signed-off-by: Jerry Huang CC: Kim Phillips --- arch/powerpc/cpu/mpc83xx/serdes.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/serdes.c b/arch/powerpc/cpu/mpc83xx/serdes.c index fecfc80..13b2fd1 100644 --- a/arch/powerpc/cpu/mpc83xx/serdes.c +++ b/arch/powerpc/cpu/mpc83xx/serdes.c @@ -1,7 +1,7 @@ /* * Freescale SerDes initialization routine * - * Copyright (C) 2007 Freescale Semicondutor, Inc. + * Copyright (C) 2007,2011 Freescale Semicondutor, Inc. * Copyright (C) 2008 MontaVista Software, Inc. * * Author: Li Yang @@ -20,6 +20,10 @@ /* SerDes registers */ #define FSL_SRDSCR0_OFFS 0x0 #define FSL_SRDSCR0_DPP_1V20x8800 +#define FSL_SRDSCR0_TXEQA_MASK 0x7000 +#define FSL_SRDSCR0_TXEQA_SATA 0x1000 +#define FSL_SRDSCR0_TXEQE_MASK 0x0700 +#define FSL_SRDSCR0_TXEQE_SATA 0x0100 #define FSL_SRDSCR1_OFFS 0x4 #define FSL_SRDSCR1_PLLBW 0x0040 #define FSL_SRDSCR2_OFFS 0x8 @@ -71,6 +75,14 @@ void fsl_setup_serdes(u32 offset, char proto, u32 rfcks, char vdd) tmp &= ~FSL_SRDSRSTCTL_SATA_RESET; out_be32(regs + FSL_SRDSRSTCTL_OFFS, tmp); + /* Configure SRDSCR0 */ + tmp = in_be32(regs + FSL_SRDSCR0_OFFS); + tmp &= ~FSL_SRDSCR0_TXEQA_MASK; + tmp |= FSL_SRDSCR0_TXEQA_SATA; + tmp &= ~FSL_SRDSCR0_TXEQE_MASK; + tmp |= FSL_SRDSCR0_TXEQE_SATA; + out_be32(regs + FSL_SRDSCR0_OFFS, tmp); + /* Configure SRDSCR1 */ tmp = in_be32(regs + FSL_SRDSCR1_OFFS); tmp &= ~FSL_SRDSCR1_PLLBW; -- 1.6.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] mpc83xx: km83xx_i2c - fix gcc 4.6 compiler warning
Configuring for kmeter1 board...
km83xx_i2c.c: In function 'i2c_make_abort':
km83xx_i2c.c:44:8: warning: variable 'dummy' set but not used
[-Wunused-but-set-variable]
Signed-off-by: Kim Phillips
---
board/keymile/km83xx/km83xx_i2c.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/board/keymile/km83xx/km83xx_i2c.c
b/board/keymile/km83xx/km83xx_i2c.c
index be17775..8df92d8 100644
--- a/board/keymile/km83xx/km83xx_i2c.c
+++ b/board/keymile/km83xx/km83xx_i2c.c
@@ -41,7 +41,6 @@ int i2c_make_abort(void)
{
struct fsl_i2c *dev;
dev = (struct fsl_i2c *) (CONFIG_SYS_IMMR + CONFIG_SYS_I2C_OFFSET);
- uchar dummy;
uchar last;
int nbr_read = 0;
int i = 0;
@@ -52,7 +51,7 @@ int i2c_make_abort(void)
udelay(DELAY_ABORT_SEQ);
out_8(&dev->cr, (I2C_CR_MEN | I2C_CR_MSTA));
udelay(DELAY_ABORT_SEQ);
- dummy = in_8(&dev->dr);
+ in_8(&dev->dr);
udelay(DELAY_ABORT_SEQ);
last = in_8(&dev->dr);
nbr_read++;
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] mpc83xx: spd_sdram - fix gcc 4.6 compiler warning
Configuring for sbc8349 board... spd_sdram.c: In function 'spd_sdram': spd_sdram.c:152:41: warning: variable 'trfc_high' set but not used [-Wunused-but-set-variable] Signed-off-by: Kim Phillips --- arch/powerpc/cpu/mpc83xx/spd_sdram.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/spd_sdram.c b/arch/powerpc/cpu/mpc83xx/spd_sdram.c index 3855bfd..04d519a 100644 --- a/arch/powerpc/cpu/mpc83xx/spd_sdram.c +++ b/arch/powerpc/cpu/mpc83xx/spd_sdram.c @@ -149,7 +149,7 @@ long int spd_sdram() unsigned int memsize; unsigned int law_size; unsigned char caslat, caslat_ctrl; - unsigned int trfc, trfc_clk, trfc_low, trfc_high; + unsigned int trfc, trfc_clk, trfc_low; unsigned int trcd_clk, trtp_clk; unsigned char cke_min_clk; unsigned char add_lat, wr_lat; @@ -542,7 +542,6 @@ long int spd_sdram() * so preadjust it down 8 first before splitting it up. */ trfc_low = (trfc_clk - 8) & 0xf; - trfc_high = ((trfc_clk - 8) >> 4) & 0x3; ddr->timing_cfg_1 = (((picos_to_clk(spd.trp * 250) & 0x07) << 28 ) |/* PRETOACT */ -- 1.7.7.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] mpc83xx: mpc8360emds - fix gcc 4.6 compiler warning
Configuring for MPC8360EMDS_66_HOST_33 - Board: MPC8360EMDS, Options:
CLKIN_66MHZ,PCI,PCI_33M,PQ_MDS_PIB=1
mpc8360emds.c: In function 'board_eth_init':
mpc8360emds.c:178:12: warning: array subscript is above array bounds
[-Warray-bounds]
Signed-off-by: Kim Phillips
---
board/freescale/mpc8360emds/mpc8360emds.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/board/freescale/mpc8360emds/mpc8360emds.c
b/board/freescale/mpc8360emds/mpc8360emds.c
index be76774..bdd1293 100644
--- a/board/freescale/mpc8360emds/mpc8360emds.c
+++ b/board/freescale/mpc8360emds/mpc8360emds.c
@@ -172,10 +172,11 @@ int board_eth_init(bd_t *bd)
if (board_handle_erratum2()) {
int i;
- for (i = 0; i < ARRAY_SIZE(uec_info); i++)
+ for (i = 0; i < ARRAY_SIZE(uec_info); i++) {
uec_info[i].enet_interface_type =
PHY_INTERFACE_MODE_RGMII_RXID;
uec_info[i].speed = SPEED_1000;
+ }
}
return uec_eth_init(bd, uec_info, ARRAY_SIZE(uec_info));
}
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] common: tsi148 - fix gcc 4.6 compiler warning
Configuring for vme8349 board...
cmd_tsi148.c: In function 'tsi148_init':
cmd_tsi148.c:56:17: warning: variable 'lastError' set but not used
[-Wunused-but-set-variable]
Signed-off-by: Kim Phillips
---
common/cmd_tsi148.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/common/cmd_tsi148.c b/common/cmd_tsi148.c
index 6dc9dab..7f48ea2 100644
--- a/common/cmd_tsi148.c
+++ b/common/cmd_tsi148.c
@@ -53,7 +53,7 @@ static TSI148_DEV *dev;
int tsi148_init(void)
{
- int j, result, lastError = 0;
+ int j, result;
pci_dev_t busdevfn;
unsigned int val;
@@ -69,8 +69,7 @@ int tsi148_init(void)
dev = malloc(sizeof(*dev));
if (NULL == dev) {
puts("Tsi148: No memory!\n");
- result = -1;
- goto break_20;
+ return -1;
}
memset(dev, 0, sizeof(*dev));
@@ -139,8 +138,6 @@ int tsi148_init(void)
break_30:
free(dev);
dev = NULL;
- break_20:
- lastError = result;
return result;
}
--
1.7.7.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] mpc83xx: km83xx_i2c - fix gcc 4.6 compiler warning
Hello Kim, Kim Phillips wrote: > Configuring for kmeter1 board... > km83xx_i2c.c: In function 'i2c_make_abort': > km83xx_i2c.c:44:8: warning: variable 'dummy' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Kim Phillips > --- > board/keymile/km83xx/km83xx_i2c.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Thanks for fixing, Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/mpc83xx: set TXEQA/TXEQE value for mpc837XE sata
On Wed, 16 Nov 2011 15:36:25 +0800 wrote: > From: Jerry Huang > > In the current u-boot code, the value of these fields are the reserved > value (0b100), through the signal integrity measurement on freescale's > board with these reserved setting, the signal eye is out of the recommended > spec for non-transition amplitude at 500mV nominal. > According to the errata for MPC8379E, we should make a change to the > recommended setting from essentially nothing at this time to 0b001 for SATA. what erratum #? How am I supposed to know this won't break the 8308 boards that share this file? > + /* Configure SRDSCR0 */ > + tmp = in_be32(regs + FSL_SRDSCR0_OFFS); > + tmp &= ~FSL_SRDSCR0_TXEQA_MASK; > + tmp |= FSL_SRDSCR0_TXEQA_SATA; > + tmp &= ~FSL_SRDSCR0_TXEQE_MASK; > + tmp |= FSL_SRDSCR0_TXEQE_SATA; > + out_be32(regs + FSL_SRDSCR0_OFFS, tmp); > + use clrsetbits_be32 Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] netspace_v2: Read Ethernet MAC address from EEPROM
Hi Prafulla,
On Tue, Nov 08, 2011 at 10:31:14PM +0100, Simon Guinot wrote:
> From: Simon Guinot
>
> Signed-off-by: Simon Guinot
> ---
>
> Changes in v2:
> - fix asm-offsets.s removal
> - make MAC address setup conditional to CONFIG_SYS_I2C_EEPROM_ADDR
>
> board/LaCie/netspace_v2/netspace_v2.c | 43
> +
> include/configs/netspace_v2.h |1 +
> 2 files changed, 44 insertions(+), 0 deletions(-)
Do you want me for some other modifications on this patch ?
Regards,
Simon
>
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c
> b/board/LaCie/netspace_v2/netspace_v2.c
> index 7c4b15e..6938a43 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -89,6 +90,48 @@ int board_init(void)
> return 0;
> }
>
> +int misc_init_r(void)
> +{
> +#if defined(CONFIG_CMD_I2C) && defined(CONFIG_SYS_I2C_EEPROM_ADDR)
> + if (!getenv("ethaddr")) {
> + ushort version;
> + uchar mac[6];
> + int ret;
> +
> + /* I2C-0 for on-board EEPROM */
> + i2c_set_bus_num(0);
> +
> + /* Check layout version for EEPROM data */
> + ret = i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, 0,
> + CONFIG_SYS_I2C_EEPROM_ADDR_LEN,
> + (uchar *) &version, 2);
> + if (ret != 0) {
> + printf("Error: failed to read I2C EEPROM @%02x\n",
> + CONFIG_SYS_I2C_EEPROM_ADDR);
> + return ret;
> + }
> + version = be16_to_cpu(version);
> + if (version < 1 || version > 3) {
> + printf("Error: unknown version %d for EEPROM data\n",
> + version);
> + return -1;
> + }
> +
> + /* Read Ethernet MAC address from EEPROM */
> + ret = i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, 2,
> + CONFIG_SYS_I2C_EEPROM_ADDR_LEN, mac, 6);
> + if (ret != 0) {
> + printf("Error: failed to read I2C EEPROM @%02x\n",
> + CONFIG_SYS_I2C_EEPROM_ADDR);
> + return ret;
> + }
> + eth_setenv_enetaddr("ethaddr", mac);
> + }
> +#endif /* CONFIG_CMD_I2C && CONFIG_SYS_I2C_EEPROM_ADDR */
> +
> + return 0;
> +}
> +
> void mv_phy_88e1116_init(char *name)
> {
> u16 reg;
> diff --git a/include/configs/netspace_v2.h b/include/configs/netspace_v2.h
> index bb27ed7..1ddf4b4 100644
> --- a/include/configs/netspace_v2.h
> +++ b/include/configs/netspace_v2.h
> @@ -87,6 +87,7 @@
> * Ethernet Driver configuration
> */
> #ifdef CONFIG_CMD_NET
> +#define CONFIG_MISC_INIT_R /* Call misc_init_r() to initialize MAC address */
> #define CONFIG_MVGBE_PORTS {1, 0} /* enable port 0 only */
> #define CONFIG_NETCONSOLE
> #endif
> --
> 1.7.5.1
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] AT91: pio: Add PIO3 features
This patch adds the support for new PIO controller introduced by some
AT91 SoCs.
New features include
* More peripheral multiplexing
* Pull-down, Schmitt trigger, Debouncer
* More irq trigger mode (may be not interesting in U-Boot)
Signed-off-by: Hong Xu
---
Change for v3
* CONFIG_CPU_HAS_PIO3 -> ATMEL_CPU_HAS_PIO3
PIO3 is a feature of CPU, not a configuration item
arch/arm/include/asm/arch-at91/at91_pio.h | 48 ++-
drivers/gpio/at91_gpio.c | 130 +++-
2 files changed, 171 insertions(+), 7 deletions(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h
b/arch/arm/include/asm/arch-at91/at91_pio.h
index 416cabf..069368d 100644
--- a/arch/arm/include/asm/arch-at91/at91_pio.h
+++ b/arch/arm/include/asm/arch-at91/at91_pio.h
@@ -4,6 +4,7 @@
* Copyright (C) 2005 Ivan Kokshaysky
* Copyright (C) SAN People
* Copyright (C) 2009 Jens Scharsig (js_at...@scharsoft.de)
+ * Copyright (C) 2011 Hong Xu (hong...@atmel.com)
*
* Parallel I/O Controller (PIO) - System peripherals registers.
* Based on AT91RM9200 datasheet revision E.
@@ -17,7 +18,6 @@
#ifndef AT91_PIO_H
#define AT91_PIO_H
-
#define AT91_ASM_PIO_RANGE 0x200
#define AT91_ASM_PIOC_ASR \
(ATMEL_BASE_PIO + AT91_PIO_PORTC * AT91_ASM_PIO_RANGE + 0x70)
@@ -66,14 +66,51 @@ typedef struct at91_port {
u32 puer; /* 0x64 Pull-up Enable Register */
u32 pusr; /* 0x68 Pad Pull-up Status Register */
u32 reserved4;
+#if defined(ATMEL_CPU_HAS_PIO3)
+ u32 abcdsr1;/* 0x70 Peripheral ABCD Select Register 1 */
+ u32 abcdsr2;/* 0x74 Peripheral ABCD Select Register 2 */
+ u32 reserved5[2];
+ u32 ifscdr; /* 0x80 Input Filter SCLK Disable Register */
+ u32 ifscer; /* 0x84 Input Filter SCLK Enable Register */
+ u32 ifscsr; /* 0x88 Input Filter SCLK Status Register */
+ u32 scdr; /* 0x8C SCLK Divider Debouncing Register */
+#define PIO_SCDR_DIV_MASK (0x3fff << 0) /* Slow Clock Divider Mask */
+ u32 ppddr; /* 0x90 Pad Pull-down Disable Register */
+ u32 ppder; /* 0x94 Pad Pull-down Enable Register */
+ u32 ppdsr; /* 0x98 Pad Pull-down Status Register */
+ u32 reserved6;
+#else
u32 asr;/* 0x70 Select A Register */
u32 bsr;/* 0x74 Select B Register */
u32 absr; /* 0x78 AB Select Status Register */
u32 reserved5[9]; /* */
+#endif
u32 ower; /* 0xA0 Output Write Enable Register */
u32 owdr; /* 0xA4 Output Write Disable Register */
- u32 owsr; /* OxA8 utput Write Status Register */
+ u32 owsr; /* OxA8 Output Write Status Register */
+#if defined(ATMEL_CPU_HAS_PIO3)
+ u32 reserved7; /* */
+ u32 aimer; /* Additional Interrupt Modes Enable Register*/
+ u32 aimdr; /* Additional Interrupt Modes Disable Register*/
+ u32 aimmr; /* Additional Intterupt Modes Mask Register */
+ u32 reserved8; /* */
+ u32 esr;/* 0xC0 Edge Select Register */
+ u32 lsr;/* 0xC4 Level Select Register */
+ u32 elsr; /* 0xC8 Edge/Level Status Register */
+ u32 reserved9; /* 0xCC */
+ u32 fellsr; /* 0xD0 Falling Edge/Low Level Select Register*/
+ u32 rehlsr; /* 0xD4 Rising Edge/High Level Select Register*/
+ u32 frlhsr; /* 0xD8 Fall/Rise - Low/High Status Register */
+ u32 reserved10; /* */
+ u32 locksr; /* 0xE0 Lock Status */
+ u32 wpmr; /* 0xE4 Write Protect Mode Register */
+ u32 wpsr; /* 0xE4 Write Protect Status Register */
+ u32 reserved11[5]; /* */
+ u32 schmitt;/* 0x100 Schmitt Trigger Register */
+ u32 reserved12[63];
+#else
u32 reserved6[85];
+#endif
} at91_port_t;
typedef union at91_pio {
@@ -94,6 +131,13 @@ typedef union at91_pio {
#ifdef CONFIG_AT91_GPIO
int at91_set_a_periph(unsigned port, unsigned pin, int use_pullup);
int at91_set_b_periph(unsigned port, unsigned pin, int use_pullup);
+#if defined(ATMEL_CPU_HAS_PIO3)
+int at91_set_c_periph(unsigned port, unsigned pin, int use_pullup);
+int at91_set_d_periph(unsigned port, unsigned pin, int use_pullup);
+int at91_set_pio_debounce(unsigned port, unsigned pin, int is_on, int div);
+int at91_set_pio_pulldown(unsigned port, unsigned pin, int is_on);
+int at91_set_pio_disable_schmitt_trig(unsigned port, unsigned pin);
+#endif
int at91_set_pio_input(unsigned port, unsigned pin, int use_pullup);
int at91_set_pio_multi_drive(unsigned port, unsigned pin, int is_on);
int at91_set_pio_output(unsigned port, unsign
Re: [U-Boot] [PATCH 6/6] i.mx: i.mx6q: Add the initial support for i.mx6q ARM2 board
On 12.11.2011 11:36, Jason Liu wrote:
> Add the initial support for Freescale i.MX6Q Armadillo2 board
> Support: MMC boot from slot 0/1, debug UART(UART4), usdhc.
...
> diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h
> new file mode 100644
> index 000..a4c7b31
> --- /dev/null
> +++ b/include/configs/mx6qarm2.h
...
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> + "script=boot.scr\0" \
> + "uimage=uImage\0" \
> + "mmcdev=0\0" \
> + "mmcpart=2\0" \
> + "mmcroot=/dev/mmcblk0p3 rw\0" \
> + "mmcrootfstype=ext3 rootwait\0" \
> + "mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
> + "root=${mmcroot} " \
> + "rootfstype=${mmcrootfstype}\0" \
> + "loadbootscript=" \
> + "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> + "bootscript=echo Running bootscript from mmc ...; " \
> + "source\0" \
> + "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0"
> \
> + "mmcboot=echo Booting from mmc ...; " \
> + "run mmcargs; " \
> + "bootm\0" \
> + "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
> + "root=/dev/nfs " \
> + "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
> + "netboot=echo Booting from net ...; " \
> + "run netargs; " \
> + "dhcp ${uimage}; bootm\0" \
> +
> +#define CONFIG_BOOTCOMMAND \
> + "if mmc rescan ${mmcdev}; then " \
> + "if run loadbootscript; then " \
> + "run bootscript; " \
> + "else " \
> + "if run loaduimage; then " \
> + "run mmcboot; " \
> + "else run netboot; " \
> + "fi; " \
> + "fi; " \
> + "else run netboot; fi"
Testing this with the latest mainline kernel and a Linaro developer
rootfs I'd like to propose the following changes to these settings [1]:
* Introduce a ${console} variable to centralize the console configuration
* The recent mainline kernel uses ttymxc3 instead of ttymxc0 for the
console. I.e. switch from ttymxc0 to ttymxc3
* Add a 'mmc dev ${mmcdev}' command to be able to switch between the SD
slots
* Use the SD card slot at the CPU board by default. Instead the one on
the expansion base board. I.e. switch from mmcdev=0 to mmcdev=1
* The Linaro rootfs uses EXT4. For this, remove the hard coded
rootfstype=ext3 and let the kernel auto detect the rootfs type.
Best regards
Dirk
[1]
---
include/configs/mx6qarm2.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Index: a/include/configs/mx6qarm2.h
===
--- a/include/configs/mx6qarm2.h
+++ b/include/configs/mx6qarm2.h
@@ -78,13 +78,12 @@
#define CONFIG_EXTRA_ENV_SETTINGS \
"script=boot.scr\0" \
"uimage=uImage\0" \
- "mmcdev=0\0" \
+ "mmcdev=1\0" \
+ "console=ttymxc3\0" \
"mmcpart=2\0" \
- "mmcroot=/dev/mmcblk0p3 rw\0" \
- "mmcrootfstype=ext3 rootwait\0" \
- "mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
- "root=${mmcroot} " \
- "rootfstype=${mmcrootfstype}\0" \
+ "mmcroot=/dev/mmcblk0p3 rootwait rw\0" \
+ "mmcargs=setenv bootargs console=${console},${baudrate} " \
+ "root=${mmcroot}\0" \
"loadbootscript=" \
"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
"bootscript=echo Running bootscript from mmc ...; " \
@@ -93,7 +92,7 @@
"mmcboot=echo Booting from mmc ...; " \
"run mmcargs; " \
"bootm\0" \
- "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
+ "netargs=setenv bootargs console=${console},${baudrate} " \
"root=/dev/nfs " \
"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
"netboot=echo Booting from net ...; " \
@@ -101,6 +100,7 @@
"dhcp ${uimage}; bootm\0" \
#define CONFIG_BOOTCOMMAND \
+ "mmc dev ${mmcdev};" \
"if mmc rescan ${mmcdev}; then " \
"if run loadbootscript; then " \
"run bootscript; " \
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/6] i.mx: add the initial i.mx6q core/board support
On 12.11.2011 11:36, Jason Liu wrote:
> This patch-set add the initial support for freescale i.mx6q support.
> freescale i.mx6q is a quad core built on arm cortex_a9 complex.
With the mx6qarm2 config changes proposed some minutes ago:
Tested-by: Dirk Behme
Thanks
Dirk
> The patch-set has been tested ok on freescale i.mx6q Armadillo2 board and also
> make sure it does not break i.mx5 support
>
> Jason Liu (6):
> i.mx: i.mx5: Move some files to imx-common folder
> i.mx: Add the initial support for freescale i.MX6Q processor
> i.mx: mxc_gpio: add the i.mx6q support
> i.mx: serial_mxc: add the i.mx6q support
> i.mx: fsl_esdhc: add the i.mx6q support
> i.mx: i.mx6q: Add the initial support for i.mx6q ARM2 board
>
> MAINTAINERS|1 +
> Makefile |7 +
> arch/arm/cpu/armv7/imx-common/Makefile | 47 +
> arch/arm/cpu/armv7/imx-common/cpu_info.c | 108 ++
> arch/arm/cpu/armv7/{mx5 => imx-common}/speed.c |0
> arch/arm/cpu/armv7/{mx5 => imx-common}/timer.c | 17 +-
> arch/arm/cpu/armv7/mx5/Makefile|2 +-
> arch/arm/cpu/armv7/mx5/soc.c | 77 -
> arch/arm/cpu/armv7/mx6/Makefile| 48 +
> arch/arm/cpu/armv7/mx6/clock.c | 388 +
> arch/arm/cpu/armv7/mx6/iomux-v3.c | 76 +
> arch/arm/cpu/armv7/mx6/lowlevel_init.S | 60 +
> arch/arm/cpu/armv7/{mx5/speed.c => mx6/soc.c} | 40 +-
> arch/arm/include/asm/arch-mx6/ccm_regs.h | 894 +++
> .../mx5/speed.c => include/asm/arch-mx6/clock.h} | 45 +-
> .../mx5/speed.c => include/asm/arch-mx6/gpio.h}| 28 +-
> arch/arm/include/asm/arch-mx6/imx-regs.h | 233 +++
> arch/arm/include/asm/arch-mx6/iomux-v3.h | 104 ++
> arch/arm/include/asm/arch-mx6/mx6x_pins.h | 1683
>
> .../speed.c => include/asm/arch-mx6/sys_proto.h} | 31 +-
> board/freescale/mx6qarm2/Makefile | 48 +
> board/freescale/mx6qarm2/imximage.cfg | 167 ++
> board/freescale/mx6qarm2/mx6qarm2.c| 163 ++
> boards.cfg |1 +
> drivers/gpio/mxc_gpio.c|4 +-
> drivers/mmc/fsl_esdhc.c| 14 +-
> drivers/serial/serial_mxc.c| 10 +-
> include/configs/mx6qarm2.h | 163 ++
> 28 files changed, 4303 insertions(+), 156 deletions(-)
> create mode 100644 arch/arm/cpu/armv7/imx-common/Makefile
> create mode 100644 arch/arm/cpu/armv7/imx-common/cpu_info.c
> copy arch/arm/cpu/armv7/{mx5 => imx-common}/speed.c (100%)
> rename arch/arm/cpu/armv7/{mx5 => imx-common}/timer.c (84%)
> mode change 100644 => 100755
> create mode 100644 arch/arm/cpu/armv7/mx6/Makefile
> create mode 100644 arch/arm/cpu/armv7/mx6/clock.c
> create mode 100644 arch/arm/cpu/armv7/mx6/iomux-v3.c
> create mode 100644 arch/arm/cpu/armv7/mx6/lowlevel_init.S
> copy arch/arm/cpu/armv7/{mx5/speed.c => mx6/soc.c} (57%)
> create mode 100644 arch/arm/include/asm/arch-mx6/ccm_regs.h
> copy arch/arm/{cpu/armv7/mx5/speed.c => include/asm/arch-mx6/clock.h} (59%)
> copy arch/arm/{cpu/armv7/mx5/speed.c => include/asm/arch-mx6/gpio.h} (65%)
> create mode 100644 arch/arm/include/asm/arch-mx6/imx-regs.h
> create mode 100644 arch/arm/include/asm/arch-mx6/iomux-v3.h
> create mode 100644 arch/arm/include/asm/arch-mx6/mx6x_pins.h
> rename arch/arm/{cpu/armv7/mx5/speed.c => include/asm/arch-mx6/sys_proto.h}
> (65%)
> create mode 100644 board/freescale/mx6qarm2/Makefile
> create mode 100644 board/freescale/mx6qarm2/imximage.cfg
> create mode 100644 board/freescale/mx6qarm2/mx6qarm2.c
> create mode 100644 include/configs/mx6qarm2.h
>
--
==
Dirk Behme Robert Bosch Car Multimedia GmbH
CM-AI/PJ-CF32
Phone: +49 5121 49-3274 Dirk Behme
Fax: +49 711 811 5053274 PO Box 77 77 77
mailto:dirk.be...@de.bosch.com D-31132 Hildesheim - Germany
Bosch Group, Car Multimedia (CM)
Automotive Navigation and Infotainment Systems (AI)
ProJect - CoreFunctions (PJ-CF)
Robert Bosch Car Multimedia GmbH - Ein Unternehmen der Bosch Gruppe
Sitz: Hildesheim
Registergericht: Amtsgericht Hildesheim HRB 201334
Aufsichtsratsvorsitzender: Volkmar Denner
Geschäftsführung: Uwe Thomas, Michael Bolle, Robby Drave, Egbert Hellwig
==
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] i.mx: i.mx6q: Add the initial support for i.mx6q ARM2 board
On Wed, Nov 16, 2011 at 7:34 PM, Dirk Behme wrote:
> On 12.11.2011 11:36, Jason Liu wrote:
>>
>> Add the initial support for Freescale i.MX6Q Armadillo2 board
>> Support: MMC boot from slot 0/1, debug UART(UART4), usdhc.
>
> ...
>>
>> diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h
>> new file mode 100644
>> index 000..a4c7b31
>> --- /dev/null
>> +++ b/include/configs/mx6qarm2.h
>
> ...
>>
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> + "script=boot.scr\0" \
>> + "uimage=uImage\0" \
>> + "mmcdev=0\0" \
>> + "mmcpart=2\0" \
>> + "mmcroot=/dev/mmcblk0p3 rw\0" \
>> + "mmcrootfstype=ext3 rootwait\0" \
>> + "mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
>> + "root=${mmcroot} " \
>> + "rootfstype=${mmcrootfstype}\0" \
>> + "loadbootscript=" \
>> + "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
>> ${script};\0" \
>> + "bootscript=echo Running bootscript from mmc ...; " \
>> + "source\0" \
>> + "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
>> ${uimage}\0" \
>> + "mmcboot=echo Booting from mmc ...; " \
>> + "run mmcargs; " \
>> + "bootm\0" \
>> + "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
>> + "root=/dev/nfs " \
>> + "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
>> + "netboot=echo Booting from net ...; " \
>> + "run netargs; " \
>> + "dhcp ${uimage}; bootm\0" \
>> +
>> +#define CONFIG_BOOTCOMMAND \
>> + "if mmc rescan ${mmcdev}; then " \
>> + "if run loadbootscript; then " \
>> + "run bootscript; " \
>> + "else " \
>> + "if run loaduimage; then " \
>> + "run mmcboot; " \
>> + "else run netboot; " \
>> + "fi; " \
>> + "fi; " \
>> + "else run netboot; fi"
>
> Testing this with the latest mainline kernel and a Linaro developer rootfs
> I'd like to propose the following changes to these settings [1]:
>
> * Introduce a ${console} variable to centralize the console configuration
> * The recent mainline kernel uses ttymxc3 instead of ttymxc0 for the
> console. I.e. switch from ttymxc0 to ttymxc3
> * Add a 'mmc dev ${mmcdev}' command to be able to switch between the SD
> slots
> * Use the SD card slot at the CPU board by default. Instead the one on the
> expansion base board. I.e. switch from mmcdev=0 to mmcdev=1
> * The Linaro rootfs uses EXT4. For this, remove the hard coded
> rootfstype=ext3 and let the kernel auto detect the rootfs type.
>
> Best regards
>
> Dirk
>
> [1]
>
> ---
> include/configs/mx6qarm2.h | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Index: a/include/configs/mx6qarm2.h
> ===
> --- a/include/configs/mx6qarm2.h
> +++ b/include/configs/mx6qarm2.h
> @@ -78,13 +78,12 @@
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "script=boot.scr\0" \
> "uimage=uImage\0" \
> - "mmcdev=0\0" \
> + "mmcdev=1\0" \
> + "console=ttymxc3\0" \
> "mmcpart=2\0" \
> - "mmcroot=/dev/mmcblk0p3 rw\0" \
> - "mmcrootfstype=ext3 rootwait\0" \
> - "mmcargs=setenv bootargs console=ttymxc0,${baudrate} " \
> - "root=${mmcroot} " \
> - "rootfstype=${mmcrootfstype}\0" \
> + "mmcroot=/dev/mmcblk0p3 rootwait rw\0" \
> + "mmcargs=setenv bootargs console=${console},${baudrate} " \
> + "root=${mmcroot}\0" \
> "loadbootscript=" \
> "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> "bootscript=echo Running bootscript from mmc ...; " \
> @@ -93,7 +92,7 @@
> "mmcboot=echo Booting from mmc ...; " \
> "run mmcargs; " \
> "bootm\0" \
> - "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
> + "netargs=setenv bootargs console=${console},${baudrate} " \
> "root=/dev/nfs " \
> "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
> "netboot=echo Booting from net ...; " \
> @@ -101,6 +100,7 @@
> "dhcp ${uimage}; bootm\0" \
>
> #define CONFIG_BOOTCOMMAND \
> + "mmc dev ${mmcdev};" \
> "if mmc rescan ${mmcdev}; then " \
> "if run loadbootscript; then " \
> "run bootscript; " \
>
Thanks for the testing and the suggestion for config file change. I
will pull it in the
v2 version and put a test-by you into the commit log.
Jason Liu
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] netspace_v2: Read Ethernet MAC address from EEPROM
> -Original Message- > From: Simon Guinot [mailto:si...@sequanux.org] > Sent: Wednesday, November 16, 2011 4:02 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH v2] netspace_v2: Read Ethernet MAC > address from EEPROM > > Hi Prafulla, > > On Tue, Nov 08, 2011 at 10:31:14PM +0100, Simon Guinot wrote: > > From: Simon Guinot > > > > Signed-off-by: Simon Guinot > > --- > > > > Changes in v2: > > - fix asm-offsets.s removal > > - make MAC address setup conditional to > CONFIG_SYS_I2C_EEPROM_ADDR > > > > board/LaCie/netspace_v2/netspace_v2.c | 43 > + > > include/configs/netspace_v2.h |1 + > > 2 files changed, 44 insertions(+), 0 deletions(-) > > Do you want me for some other modifications on this patch ? No I will pull it. Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Possible fix for dns command
Hello, I'm currently using u-boot on a TI DM816x evaluation board (u-boot as included in TI's EZSDK 5.02). I manually enabled CONFIG_CMD_DNS. However, running dhcp followed by dns only gave timeouts. I found (using #define DEBUG) that DNS UDP queries are being sent to the MAC of the DHCP server -- which is not equal to the DNS server, hence the timeouts. Forcing ARP queries before DNS fixed this (see patch below). I copyied that line from net/tftp.c (which works out of the box). However, as I'm quite new to u-boot I'm not sure whether that behaviour is intended or if my patch breaks other things? Patch (against plain u-boot-2011.09): --- net/dns.c 2011-09-29 21:11:15.0 +0200 +++ ../ti-ezsdk_dm816x-evm_5_02_02_60/board-support/u-boot-2010.06-psp04.00.00.12/net/dns.c 2011-11-16 10:35:38.335903630 +0100 @@ -206,5 +206,8 @@ NetSetTimeout(DNS_TIMEOUT, DnsTimeout); NetSetHandler(DnsHandler); + /* zero out server ether in case the server ip has changed */ + memset(NetServerEther, 0, 6); + DnsSend(); } Regards, Mathias Adam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH 4/8] arm: printf() is not available in the SPL
On Wed, Nov 16, 2011 at 12:37 AM, Christian Riesch
wrote:
> Hi Tom,
> thanks for your comments!
>
> On Tue, Nov 15, 2011 at 6:50 PM, Tom Rini wrote:
>> On Tue, Nov 15, 2011 at 3:37 AM, Christian Riesch
>> wrote:
>>>
>>> Signed-off-by: Christian Riesch
>>> Cc: Wolfgang Denk
>>> ---
>>> arch/arm/lib/eabi_compat.c | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
>>> index eb3e26d..2d49a28 100644
>>> --- a/arch/arm/lib/eabi_compat.c
>>> +++ b/arch/arm/lib/eabi_compat.c
>>> @@ -13,10 +13,13 @@
>>>
>>> int raise (int signum)
>>> {
>>> +#ifndef CONFIG_SPL_BUILD
>>> printf("raise: Signal # %d caught\n", signum);
>>> +#endif
>>> return 0;
>>> }
>>>
>>> +
>>> /* Dummy function to avoid linker complaints */
>>> void __aeabi_unwind_cpp_pr0(void)
>>> {
>>
>> printf exists for omap3 SPL.
>
> Ok, I guess I should make this something like #if
> !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT).
If that fixes the link error, yes :)
>> But perhaps the question is, why isn't
>> this code being gc'd away in your SPL?
>
> I must admit that I have absolutely no idea what this function is used
> for. I only see a linker error due to the missing printf.
> Any ideas?
Not off-hand, but you can always run a for o in `find objdir -name
*.o`;do echo $o ; arm-linux-gnueabi-nm $o | grep raise;done or so and
see where it's coming from :)
--
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ti/master
The following changes since commit 75acc4d7c1c9081e06d1197c6da01361cf1bce92: Heiko Schocher (1): arm, davinci: add DAVINCI_MMC_CLKID are available in the git repository at: git://git.denx.de/u-boot-ti.git master Sanjeev Premi (2): part_efi: Fix compile errors omap3evm: Add support for EFI partitions disk/part_efi.c |6 +++--- include/configs/omap3_evm.h |1 + 2 files changed, 4 insertions(+), 3 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/12] drivers/i2c/davinci_i2c.c: Fix GCC 4.6 warning
On Tue, Nov 15, 2011 at 4:21 PM, Anatolij Gustschin wrote:
> Fix:
> davinci_i2c.c: In function 'flush_rx':
> davinci_i2c.c:81:6: warning: variable 'dummy' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Anatolij Gustschin
> Cc: Heiko Schocher
> ---
> drivers/i2c/davinci_i2c.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/davinci_i2c.c b/drivers/i2c/davinci_i2c.c
> index 5e3406d..a09dc76 100644
> --- a/drivers/i2c/davinci_i2c.c
> +++ b/drivers/i2c/davinci_i2c.c
> @@ -78,13 +78,11 @@ static int poll_i2c_irq(int mask)
>
> void flush_rx(void)
> {
> - int dummy;
> -
> while (1) {
> if (!(REG(I2C_STAT) & I2C_STAT_RRDY))
> break;
>
> - dummy = REG(I2C_DRR);
> + (void)REG(I2C_DRR);
This becomes:
(void)(*(volatile unsigned int *)(I2C_DDR))
So we don't need that cast. Also, can we at get a comment about what
/ why we're doing this?
--
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/12] drivers/net/enc28j60.c: Fix GCC 4.6 warnings
On Tuesday 15 November 2011 18:20:55 Anatolij Gustschin wrote: > - eir_reg = enc_r8(enc, CTL_REG_EIR); > + (void)enc_r8(enc, CTL_REG_EIR); is that (void) actually necessary ? last i looked, gcc didn't actually care. which means you should drop the (void). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] __bss_end__ and the like
On Wednesday 16 November 2011 01:02:50 Simon Glass wrote: > grep -rs __bss_end__ * |wc > 2151011 11552 > grep -rs "__bss_end " * |wc > 39 1952175 > > I think we should standardise on one or other of these. To me it feels > like __bss_end is correct, since we have __bss_start and none of the > other symbols have a __ at the end. > > Comments? If no objections then I will do a patch. i'm not sure it'll make a difference, but "__bss_end" is the correct symbol imo -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] Fix warnings in arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
On Tuesday 15 November 2011 23:17:06 Simon Glass wrote:
> --- a/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
> +++ b/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
>
> - __u32 datab[4];
> - __u8 *data_buf = (__u8 *) datab;
> + union {
> + __u32 word[4];
> + __u16 hword[8];
> + __u8 byte[16];
> + } datab;
> + __u8 *data_buf = datab.byte;
i thought someone posted this fix to the list before. but maybe it was for a
different controller. perhaps this code has been copied/pasted all over ...
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/3] tegra2: Add Avionic Design Plutux support.
Thierry Reding wrote at Wednesday, November 16, 2011 12:14 AM: > * Thierry Reding wrote: > > * Simon Glass wrote: > [...] > > > > > > If you are not implementing MMC, just remove it and all the MMC code > > > below. > > > > > > > I don't understand. What makes you think I don't want MMC? Both the Plutux > > and the Medcom boot from MMC. If you are referring to the CD being > > hard-coded, then that is just because I copied from Harmony. You are right > > though that I should probably fill the implementation. I'm not really sure > > about the best way to do this, though. The struct mmc passed into > > board_mmc_getcd() doesn't contain enough information to decide which GPIO to > > check. I could assume it is always SD4 since that is the only controller > > that > > is initialized, but would that be acceptable? > > I was going to implement proper card-detection (it's quite trivial) but then > I saw that board_mmc_getcd() is never called in the Tegra2 MMC driver so I > guess that should be implemented as well. Did anybody work on that already or > would you like me to prepare a patch? I noticed that too, but adding CD support to the Tegra driver itself didn't seem right; surely it should be added to the MMC core? Anyway, if you're looking at hacking on Tegra MMC, please do be aware of a few patches I posted re: Tegra boards and MMC changes: tegra2: Move board_mmc_init into board files http://patchwork.ozlabs.org/patch/118143/ tegra2: Modify MMC driver to handle power and cd GPIOs http://patchwork.ozlabs.org/patch/118142/ tegra2: Add support for Ventana http://patchwork.ozlabs.org/patch/118144/ I hope these will be merged soon, but IIRC they haven't received any feedback either way from Albert. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra2: Change CONFIG_SYS_TEXT_BASE to 0x00108000.
Thierry Reding wrote at Tuesday, November 15, 2011 11:49 PM: > * PGP Signed by an unknown key > > * Stephen Warren wrote: > > Thierry Reding wrote at Tuesday, November 15, 2011 12:19 AM: > > > NVIDIA's flashing tools assume that the bootloader is loaded at address > > > 0x00108000. Instead of requiring non-standard builds of those tools > > > which allow a load address of 0x00E08000, this commit just switches all > > > Tegra2 boards to use the standard load address. > > > > > Note that to successfully boot a standalone U-Boot with this load > > > address, U-Boot needs to be built with USE_PRIVATE_LIBGCC=yes. > > > > Isn't that true irrespective of TEXT_BASE? That's certainly been my > > experience. > > Yes, but the emphasis is on "standalone" since you can run mainline U-Boot as > second stage for quickboot/fastboot and 0x00E08000 as load address without > building with USE_PRIVATE_LIBGCC=yes. OK. I think it's more just "standalone U-Boot" that "standalone U-Boot with this load address" then. I think the difference is that when running as a second stage under fastboot, U-Boot might get loaded on the A9 rather than the AVP, so the ARM ISA of the AVP doesn't come into play, and Tom Warren said he thought that USE_PRIVATE_LIBGCC=yes was only needed due to the AVP's ARM ISA difference. > The reason for including this in the > commit message was that it isn't documented anywhere else and I wanted to > avoid a situation where this question needs to be answered over and over. > > Perhaps the commit message is not the best place, but I would still like to > have this documented somewhere. Any suggestions? Can this option be selected by include/configs/tegra2-common.h? I suspect not since it's more of a make variable. Perhaps it can be forced on by a Tegra-specific makefile such as arch/arm/cpu/armv7/tegra2/config.mk or arch/arm/cpu/armv7/tegra2/Makefile? Then it wouldn't need to be documented; it'd be automatic. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/3] tegra2: Add Avionic Design Plutux support.
Thierry, -Original Message- From: Thierry Reding [mailto:thierry.red...@avionic-design.de] Sent: Wednesday, November 16, 2011 12:14 AM To: Simon Glass Cc: u-boot@lists.denx.de; Tom Warren Subject: Re: [U-Boot] [PATCH v2 2/3] tegra2: Add Avionic Design Plutux support. * PGP Signed by an unknown key * Thierry Reding wrote: > * Simon Glass wrote: [...] > > > > If you are not implementing MMC, just remove it and all the MMC code below. > > > > I don't understand. What makes you think I don't want MMC? Both the > Plutux and the Medcom boot from MMC. If you are referring to the CD > being hard-coded, then that is just because I copied from Harmony. You > are right though that I should probably fill the implementation. I'm > not really sure about the best way to do this, though. The struct mmc > passed into > board_mmc_getcd() doesn't contain enough information to decide which > GPIO to check. I could assume it is always SD4 since that is the only > controller that is initialized, but would that be acceptable? I was going to implement proper card-detection (it's quite trivial) but then I saw that board_mmc_getcd() is never called in the Tegra2 MMC driver so I guess that should be implemented as well. Did anybody work on that already or would you like me to prepare a patch? I was going to get around to this eventually, but haven't had the BW. Please feel free to submit a patch. If you need to know the GPIOs used, and don't have all the schematics, let me know and I can look 'em up. Tom Thierry * Unknown Key * 0xA2E3269F --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tegra2: Change CONFIG_SYS_TEXT_BASE to 0x00108000.
* Stephen Warren wrote: > Thierry Reding wrote at Tuesday, November 15, 2011 11:49 PM: > > * PGP Signed by an unknown key > > > > * Stephen Warren wrote: > > > Thierry Reding wrote at Tuesday, November 15, 2011 12:19 AM: > > > > NVIDIA's flashing tools assume that the bootloader is loaded at address > > > > 0x00108000. Instead of requiring non-standard builds of those tools > > > > which allow a load address of 0x00E08000, this commit just switches all > > > > Tegra2 boards to use the standard load address. > > > > > > > Note that to successfully boot a standalone U-Boot with this load > > > > address, U-Boot needs to be built with USE_PRIVATE_LIBGCC=yes. > > > > > > Isn't that true irrespective of TEXT_BASE? That's certainly been my > > > experience. > > > > Yes, but the emphasis is on "standalone" since you can run mainline U-Boot > > as > > second stage for quickboot/fastboot and 0x00E08000 as load address without > > building with USE_PRIVATE_LIBGCC=yes. > > OK. I think it's more just "standalone U-Boot" that "standalone U-Boot > with this load address" then. I think the difference is that when running > as a second stage under fastboot, U-Boot might get loaded on the A9 rather > than the AVP, so the ARM ISA of the AVP doesn't come into play, and Tom > Warren said he thought that USE_PRIVATE_LIBGCC=yes was only needed due > to the AVP's ARM ISA difference. > > > The reason for including this in the > > commit message was that it isn't documented anywhere else and I wanted to > > avoid a situation where this question needs to be answered over and over. > > > > Perhaps the commit message is not the best place, but I would still like to > > have this documented somewhere. Any suggestions? > > Can this option be selected by include/configs/tegra2-common.h? I suspect > not since it's more of a make variable. Perhaps it can be forced on by a > Tegra-specific makefile such as arch/arm/cpu/armv7/tegra2/config.mk or > arch/arm/cpu/armv7/tegra2/Makefile? Then it wouldn't need to be documented; > it'd be automatic. Yes it can: arch/arm/cpu/armv7/tegra2/config.mk is included by the build system. The build output looks okay but I'll double-check if the resulting u-boot.bin actually boots in the morning when I have access to the hardware. I'll add both the CONFIG_SYS_TEXT_BASE (with the comment omitted) and this patch to a series and resend. Thierry pgpEnP1K4aUjm.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/3] tegra2: Add Avionic Design Plutux support.
* Stephen Warren wrote: > Thierry Reding wrote at Wednesday, November 16, 2011 12:14 AM: > > * Thierry Reding wrote: > > > * Simon Glass wrote: > > [...] > > > > > > > > If you are not implementing MMC, just remove it and all the MMC code > > > > below. > > > > > > > > > > I don't understand. What makes you think I don't want MMC? Both the Plutux > > > and the Medcom boot from MMC. If you are referring to the CD being > > > hard-coded, then that is just because I copied from Harmony. You are right > > > though that I should probably fill the implementation. I'm not really sure > > > about the best way to do this, though. The struct mmc passed into > > > board_mmc_getcd() doesn't contain enough information to decide which GPIO > > > to > > > check. I could assume it is always SD4 since that is the only controller > > > that > > > is initialized, but would that be acceptable? > > > > I was going to implement proper card-detection (it's quite trivial) but then > > I saw that board_mmc_getcd() is never called in the Tegra2 MMC driver so I > > guess that should be implemented as well. Did anybody work on that already > > or > > would you like me to prepare a patch? > > I noticed that too, but adding CD support to the Tegra driver itself didn't > seem right; surely it should be added to the MMC core? Yeah, that would make more sense. I need to investigate some more what exactly this involves to make sure no boards are broken. From a quick look the only driver that currently implements CD is fsl_esdhc. I guess this will start to involve many people and boards, which I was hoping could be avoided. But if you'd rather like to see this go into the core (I agree that it is the best place to do this) then I'll take a look. I'm rather short on time, though, so it may take some time. > Anyway, if you're looking at hacking on Tegra MMC, please do be aware of > a few patches I posted re: Tegra boards and MMC changes: > > tegra2: Move board_mmc_init into board files > http://patchwork.ozlabs.org/patch/118143/ > > tegra2: Modify MMC driver to handle power and cd GPIOs > http://patchwork.ozlabs.org/patch/118142/ > > tegra2: Add support for Ventana > http://patchwork.ozlabs.org/patch/118144/ > > I hope these will be merged soon, but IIRC they haven't received any > feedback either way from Albert. I assume that these will eventually be merged, so I'll make sure to base any further work on them. Thierry pgpNjFSw6m7bP.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [STATUS] Custodians - please lend a hand
Hm... it seems a subject as "Help needed - urgently" ends in too many spam filters, so I'm reposting. This is actually serious. In message <2015150119.1f8e41689...@gemini.denx.de> I wrote: > > Hello all, > > I guess most of you will already have noticed that my activity on the > mailing list has significantly declined recently. I'm sorry for that, > but I find myself in a situation where I have even less time > available for U-Boot than usually. In the result, the number of > unapplied (and sometimes unreviewed) patches is growing and growing. > > I need your help. we need to find a way to distribute the workload > for "general" patches (i. e. those that don't fall obviously into the > responsibility of a specific custodian) across more shoulders than > just mine. Pressure on me has been building up already for some time, > and now we've reached the point where we need to find a solution. > > > One possible approach has been suggested before: > > > >> Maybe the load can be spread here - maintainers can put these in > > >> designated > > >> branches in their repositories. I know this will cause the odd > > >> conflict, > > > > > > If you script this (based on pwapply) you can bail out early if the > > > patch is no longer in state "New". > > > > > >> but we (the maintainers) could also periodically sync between each > > >> other. > > >> Another alternative is to create a new repo that all the > > >> custodians have > > >> access to... > > > > > > That would be easy to do... > > > > Maybe that's what we do - Once a patch reaches maturity (a revision > > with an Ack and maybe a Tested-by) any maintainer can just put it in > > the 'next' repo - You can always veto it and not pull it into > > mainline anyway, but at least it gives everyone a semi-stable > > platform to base patches for the next merge window > > I would like to try this out now, taking effect immediately. > > I have created a new repository "u-boot-staging", where all current > custodians (should) have write access to. > > My proposal is as follows (please feel free to comment): > > - Any custodian is able (and encouraged) to pick up unapplied patches > that have "reached maturity" (ideally an Ack and maybe a > Tested-by), but at least no negative feedback on the mailing list, > and re-review these. If they are considered OK and do not cause any > new build issues, they can be applied. Please don't forget to > update the entries in Patchwork. > > - To ensure quality, no custodian should apply his own patches. > > - After reviewing and build testing (MAKEALL for at least two > different architectures) the stuff can be pushed into a _branch_ of > the "u-boot-staging" repository. I suggest to use the custodian's > e-mail address as branch name. > > - After that, the custodian can send a pull request to me. > > > Please let's try if this works. If you have any suggestions how to > help better, please don't hesitate to tell us. > > Thanks. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > The important thing about being a leader is not being right or wrong, > but being *certain*.- Terry Pratchett, _Truckers_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-mmc.git
Dear Andy Fleming, In message <1321134885-20735-1-git-send-email-aflem...@freescale.com> you wrote: > The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45: > > Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08 > 07:44:52 +0100) > > are available in the git repository at: > > git://www.denx.de/git/u-boot-mmc.git master > > Anton staaf (4): > Tegra2: mmc: define register field values in tegra2_mmc.h > Tegra2: mmc: Support DMA restarts at buffer boundaries > Tegra2: mmc: Add data transfer completion timeout > Tegra2: mmc: Factor out mmc_wait_inhibit functionality > > Jon Medhurst (Tixy) (1): > MMC: PL180: Fix infinite loop with VExpress extended fifo implementation > > drivers/mmc/arm_pl180_mmci.c | 26 > drivers/mmc/tegra2_mmc.c | 130 +++-- > drivers/mmc/tegra2_mmc.h | 49 > 3 files changed, 134 insertions(+), 71 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de GUIs are virtually useless. Learn tools. They're configurable, scriptable, automatable, cron-able, interoperable, etc. We don't need no brain-dead winslurping monolithic claptrap. -- Tom Christiansen in 371140df@csnews ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [i2c] Pull request
Dear Heiko Schocher,
In message <4eba1018.9030...@denx.de> you wrote:
> Hello Wolfgang,
>
> The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45:
>
> Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08
> 07:44:52 +0100)
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-i2c.git master
>
> Kumar Gala (1):
> fsl_i2c: Fix compile warning
>
> drivers/i2c/fsl_i2c.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A man either lives life as it happens to him, meets it head-on and
licks it, or he turns his back on it and starts to wither away.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-nds32
Dear Macpaul Lin, In message you wrote: > Dear Wolfgang, > > Could you please pull these 5 patches to your tree. > > Thanks, > Macpaul > > > The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45: > > Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx > (2011-11-08 07:44:52 +0100) > > are available in the git repository at: > > git://git.denx.de/u-boot-nds32.git master > > Macpaul Lin (5): > andes_pcu.h: header file of andes_pcu power control unit > dwcddr21mctl: Synopsys DWC DDR2/1 Memory Controller > nds32: fix data section of linker script > adp-ag101p: Add SoC and board support of ag101p > adp-ag101p: add product into MAINTAINERS list > > MAINTAINERS |1 + > arch/nds32/cpu/n1213/u-boot.lds |2 +- > arch/nds32/include/asm/mach-types.h | 14 ++ > board/AndesTech/adp-ag101p/Makefile | 44 > board/AndesTech/adp-ag101p/adp-ag101p.c | 89 +++ > boards.cfg |1 + > include/andestech/andes_pcu.h | 367 + > include/configs/adp-ag101p.h| 383 > +++ > include/synopsys/dwcddr21mctl.h | 337 +++ > 9 files changed, 1237 insertions(+), 1 deletions(-) > create mode 100644 board/AndesTech/adp-ag101p/Makefile > create mode 100644 board/AndesTech/adp-ag101p/adp-ag101p.c > create mode 100644 include/andestech/andes_pcu.h > create mode 100644 include/configs/adp-ag101p.h > create mode 100644 include/synopsys/dwcddr21mctl.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I had the rare misfortune of being one of the first people to try and implement a PL/1 compiler. -- T. Cheatham ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Auto insurance (11/16/2011)
Hello, Our company represents an online platform of over 36.4 million people, most of which are located in the US and Canada. What we do allows us to present our online platform with a first choice when they search for anything on any of the major search engines. We seek a preferred source to send our users on the major search engines for auto insurance in Milwaukee and surrounding markets. Please feel free to contact me at your convenience. I’m in the office Monday-Friday from 9:00 AM to 5:00 PM Pacific time. Yours truly, Dave Gilmore IFP Specialist, SPS Phone: (888) 415-8251, ext. 1678 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git
Dear Kumar Gala, In message you wrote: > The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45: > > Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08 > 07:44:52 +0100) > > are available in the git repository at: > > git://git.denx.de/u-boot-mpc85xx.git master > > Jerry Huang (2): > powerpc/mpc85xx: Set SYSCLK to the required frequency > powerpc/85xx: Set max alloc length to 10MB on P1022DS > > Kumar Gala (20): > powerpc/85xx: Add support for Book-E MMU Arch v2.0 > powerpc/85xx: Fix MPC8572DS NAND build > powerpc/85xx: Fix NAND SPL support > arch/powerpc/cpu/mpc85xx/cpu_init.c: Fix GCC 4.6 build warning > arch/powerpc/cpu/mpc85xx/tlb.c: Fix GCC 4.6 build warning > arch/powerpc/cpu/mpc8xxx/fsl_lbc.c: Fix GCC 4.6 build warning > board/freescale/common/cds_pci_ft.c: Fix GCC 4.6 build warning > board/freescale/common/pixis.c: Fix GCC 4.6 build warning > board/freescale/mpc8548cds/mpc8548cds.c: Fix GCC 4.6 build warning > board/freescale/mpc8568mds/mpc8568mds.c: Fix GCC 4.6 build warning > board/freescale/mpc8569mds/mpc8569mds.c: Fix GCC 4.6 build warning > board/sbc8548/sbc8548.c: Fix GCC 4.6 build warning > board/sbc8560/sbc8560.c: Fix GCC 4.6 build warning > drivers/net/fm/fm.c: Fix GCC 4.6 build warning > drivers/usb/host/ehci-fsl.c: Fix GCC 4.6 build warning > drivers/qe/uec.c: Fix GCC 4.6 build warning > arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning > arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c: Fix GCC 4.6 build warning > arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning > powerpc/85xx: Fix builds of P1020/P2020RDB-PC_36BIT_NAND > > Poonam Aggrwal (1): > fsl_ifc: Fixed a bug in the erratum handling code for IFC_A003399 > > Ramneek Mehresh (2): > powerpc/85xx: Fix warning for USB device-fixup > powerpc/85xx: Make inclusion of USB device fixup conditional > > Roy Zang (1): > powerpc/QorIQ: fix network frame manager TBI PHY address settings > > Timur Tabi (5): > powerpc/85xx: fix definition of MAS register macros > powerpc/85xx: fix some comments in the CCSR relocation code > powerpc/85xx: add some missing sync instructions in the CCSR relocation > code > powerpc/85xx: verify the current address of CCSR before relocating it > powerpc/85xx: resize the boot page TLB before relocating CCSR > > Xie Xiaobo (1): > phylib: Enable AR8021 phy support > > chenhui zhao (2): > powerpc/mpc8548: Add workaround for erratum NMG_eTSEC129 > powerpc/mpc8548cds: Fix network initialization > > arch/powerpc/cpu/mpc85xx/cmd_errata.c |4 + > arch/powerpc/cpu/mpc85xx/cpu_init.c |3 +- > arch/powerpc/cpu/mpc85xx/cpu_init_early.c |4 +- > arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c |7 ++- > arch/powerpc/cpu/mpc85xx/start.S | 84 ++- > arch/powerpc/cpu/mpc85xx/tlb.c| 17 +++-- > arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c |7 +-- > arch/powerpc/cpu/mpc8xxx/ddr/options.c|4 + > arch/powerpc/cpu/mpc8xxx/fdt.c| 24 --- > arch/powerpc/cpu/mpc8xxx/fsl_lbc.c|4 +- > arch/powerpc/include/asm/config_mpc85xx.h |1 + > arch/powerpc/include/asm/mmu.h| 10 ++-- > arch/powerpc/include/asm/processor.h |6 ++ > board/freescale/common/cds_pci_ft.c |3 +- > board/freescale/common/ics307_clk.c | 69 ++ > board/freescale/common/ics307_clk.h |4 +- > board/freescale/common/ngpixis.c | 27 +++ > board/freescale/common/pixis.c|4 +- > board/freescale/corenet_ds/eth_hydra.c|8 -- > board/freescale/corenet_ds/eth_p4080.c|8 -- > board/freescale/mpc8548cds/mpc8548cds.c | 69 +++--- > board/freescale/mpc8568mds/mpc8568mds.c |3 +- > board/freescale/mpc8569mds/mpc8569mds.c |2 - > board/freescale/mpc8572ds/tlb.c |2 + > board/freescale/p1010rdb/p1010rdb.c |2 + > board/freescale/p1_p2_rdb/p1_p2_rdb.c |2 + > board/freescale/p1_p2_rdb_pc/law.c| 10 ++- > board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c |3 + > board/freescale/p2041rdb/eth.c|8 -- > board/sbc8548/sbc8548.c |2 - > board/sbc8560/sbc8560.c |3 +- > drivers/net/fm/fm.c |3 +- > drivers/net/tsec.c| 93 > + > drivers/qe/uec.c |7 -- > drivers/usb/host/ehci-fsl.c |4 +- > include/config_phylib_all_drivers.h |1 + > include/configs/MPC8536DS.h |2 +- > include
Re: [U-Boot] Pull request: u-boot-fdt
Dear Jerry Van Baren, In message <4ebff810.6080...@cideas.com> you wrote: > Dear Wolfgang, > > Please pull the bugfixes from the following changes since commit > 5721385b187b3154c7768e6c182501022f4e2e45: > >Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08 > 07:44:52 +0100) > > are available in the git repository at: > >git://git.denx.de/u-boot-fdt.git master > > Gabe Black (2): >Add some missing endian conversions in fdt_support.c >Fix constness of the fdt void pointer in fdt_getprop_u32_default > > common/fdt_support.c |8 > include/fdt_support.h |4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de No one wants war. -- Kirk, "Errand of Mercy", stardate 3201.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
Dear Simon Glass, In message you wrote: > > We have built up quite a large number of patches which are currently > sitting in the Chromium tree - something like 200. If we continue to > dribble these out at 10-20 a month it will take a while. Current > mainline U-Boot support for Tegra is pretty basic, but with these > patches it is pretty slick. It would be great to take advantage of the > oppty at the moment to upstream this material. Tegra 30 is already > starting to get into the kernel and I feel U-Boot is behind! We are > the boot loader. We need to be ahead :-) Then let's try out this new u-boot-staging thing [1]. I suggest somebody (not the original poster, of course) reviews and pushes the stuff into a branch in this repo, and sends then a pull request to Albert. Either it works better, or else not much is lost either. [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117084 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You could end up being oddly sad and full of a strange, diffuse com- passion which would lead you to believe that it might be a good idea to wipe out the whole human race and start again with amoebas. - Terry Pratchett, _Guards! Guards!_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc/85xx: verify the localbus device tree address before booting the OS
The localbus controller node in the device tree is typically a root node,
even though the controller is part of CCSR. If we were to put the lbc
node under the SOC node, then the 'ranges' property in the lbc node would
translate through the 'ranges' property of the parent SOC node, and we
don't want that.
Since the lbc is a separate node, it's possible for the 'reg' property to
be wrong. This happened with the original version of p1022ds.dts, which
used a 32-bit value in the 'reg' address, instead of a 36-bit address.
Signed-off-by: Timur Tabi
---
arch/powerpc/cpu/mpc85xx/fdt.c | 48 ---
1 files changed, 39 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 9d31568..2fcd8c3 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -677,6 +677,12 @@ void ft_cpu_setup(void *blob, bd_t *bd)
#define CCSR_VIRT_TO_PHYS(x) \
(CONFIG_SYS_CCSRBAR_PHYS + ((x) - CONFIG_SYS_CCSRBAR))
+static void msg(const char *name, uint64_t uaddr, uint64_t daddr)
+{
+ printf("Warning: U-Boot configured %s at address %llx,\n"
+ "but the device tree has it at %llx\n", name, uaddr, daddr);
+}
+
/*
* Verify the device tree
*
@@ -692,33 +698,32 @@ void ft_cpu_setup(void *blob, bd_t *bd)
*/
int ft_verify_fdt(void *fdt)
{
- uint64_t ccsr = 0;
+ uint64_t addr = 0;
int aliases;
int off;
/* First check the CCSR base address */
off = fdt_node_offset_by_prop_value(fdt, -1, "device_type", "soc", 4);
if (off > 0)
- ccsr = fdt_get_base_address(fdt, off);
+ addr = fdt_get_base_address(fdt, off);
- if (!ccsr) {
+ if (!addr) {
printf("Warning: could not determine base CCSR address in "
"device tree\n");
/* No point in checking anything else */
return 0;
}
- if (ccsr != CONFIG_SYS_CCSRBAR_PHYS) {
- printf("Warning: U-Boot configured CCSR at address %llx,\n"
- "but the device tree has it at %llx\n",
- (uint64_t) CONFIG_SYS_CCSRBAR_PHYS, ccsr);
+ if (addr != CONFIG_SYS_CCSRBAR_PHYS) {
+ msg("CCSR", CONFIG_SYS_CCSRBAR_PHYS, addr);
/* No point in checking anything else */
return 0;
}
/*
-* Get the 'aliases' node. If there isn't one, then there's nothing
-* left to do.
+* Check some nodes via aliases. We assume that U-Boot and the device
+* tree enumerate the devices equally. E.g. the first serial port in
+* U-Boot is the same as "serial0" in the device tree.
*/
aliases = fdt_path_offset(fdt, "/aliases");
if (aliases > 0) {
@@ -735,5 +740,30 @@ int ft_verify_fdt(void *fdt)
#endif
}
+ /*
+* The localbus node is typically a root node, even though the lbc
+* controller is part of CCSR. If we were to put the lbc node under
+* the SOC node, then the 'ranges' property in the lbc node would
+* translate through the 'ranges' property of the parent SOC node, and
+* we don't want that. Since it's a separate node, it's possible for
+* the 'reg' property to be wrong, so check it here. For now, we
+* only check for "fsl,elbc" nodes.
+*/
+#ifdef CONFIG_SYS_LBC_ADDR
+ off = fdt_node_offset_by_compatible(fdt, -1, "fsl,elbc");
+ if (off > 0) {
+ const u32 *reg = fdt_getprop(fdt, off, "reg", NULL);
+ if (reg) {
+ uint64_t uaddr = CCSR_VIRT_TO_PHYS(CONFIG_SYS_LBC_ADDR);
+
+ addr = fdt_translate_address(fdt, off, reg);
+ if (uaddr != addr) {
+ msg("the localbus", uaddr, addr);
+ return 0;
+ }
+ }
+ }
+#endif
+
return 1;
}
--
1.7.3.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Custodians - please lend a hand
On 11/16/2011 07:51 PM, Wolfgang Denk wrote: Wolfgang, >> >> Please let's try if this works. If you have any suggestions how to >> help better, please don't hesitate to tell us. I have tried with a couple of patches (network related), and then I wanted to test if push works. As u-boot-staging should be open for all custodians, I was expecting I should use the same mechanism, and then I tried with: git push ssh://gu-...@git.denx.de/u-boot-staging sba...@denx.de ...but the new branch sba...@denx.de is now part of u-boot-imx, not u-boot-staging ! Where is the mistake ? Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
Dear Albert ARIBAUD, In message <4ec2d979.6090...@aribaud.net> you wrote: > Hi Wolfgang, > > The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45: > >Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08 > 07:44:52 +0100) > > are available in the git repository at: > >git://git.denx.de/u-boot-arm.git master > > Alexander Holler (1): >BeagleBoard: config: Switch to ttyO2 > > Asen Dimov (1): >ARM: define CONFIG_MACH_TYPE for all ronetix boards > > Christian Riesch (3): >arm, davinci: Rename AM1808 lowlevel functions to DA850 >arm, davinci: Remove the duplication of LPSC functions >arm, davinci: Fix setting of the SDRAM configuration register > > David M�ller (ELSOFT AG) (2): >ARM: re-add MACH_TYPE_XX for VCMA9 board and add CONFIG_MACH_TYPE >ARM: remove superfluous setting of arch_number in board specific > code. > > Fabio Estevam (5): >qong: Use generic function for configuring GPR register >mx31: Remove duplicate definition for GPR register >mx31: Use proper IO accessor for GPR register >mx31: Fix checkpatch warnings in generic.c >m28evk: Fix comment about the number of RAM banks > > Heiko Schocher (3): >arm, davinci: da850/dm365 lowlevel cleanup >arm, davinci_emac: fix driver bug if more then 3 PHYs are detected >arm, davinci: add DAVINCI_MMC_CLKID > > Linus Walleij (7): >integrator: do not test first part of the memory >integrator: pass configs for core modules >integrator: move text offset to config >integrator: use io-accessors for board init >integrator: make flash writeable on boot >integrator: add system controller header >integrator: enable Vpp and disable flash protection > > Manjunath Hadli (2): >dm646x: add new configuration for dm6467T >dm646x: pass board revision info to kernel > > Marek Vasut (27): >SPL: Allow ARM926EJS to avoid compiling in the CPU support code >iMX28: Initial support for iMX28 CPU >iMX28: Add SSP MMC driver >FEC: Add support for iMX28 quirks >iMX28: Add PINMUX control >iMX28: Add I2C bus driver >iMX28: Add GPIO control >iMX28: Add SPI driver >iMX28: Add APBH DMA driver >iMX28: Add GPMI NAND driver >iMX28: Add driver for internal RTC >iMX28: Add image header generator tool >iMX28: Add u-boot.sb target to Makefile >iMX28: Add support for DENX M28EVK board >M28: Add MMC SPL >M28: Add doc/README.m28 documentation >iMX28: Fix ARM vector handling >M28: Add memory detection into SPL >iMX28: Add USB and USB PHY register definitions >iMX28: Add USB HOST driver >M28EVK: Enable USB HOST support >PXA: Drop csb226 and innokom boards (unmaintained) >PXA: Cleanup serial_pxa >PXA: vpac270: Enable the new generic MMC driver >OneNAND: Add simple OneNAND SPL >GCC4.6: Fix common/usb.c on xscale >GCC4.6: Squash warnings in onenand_base.c > > Nagabhushana Netagunte (1): >da850: add new config file for AM18xx > > Po-Yu Chuang (1): >arm: a320: fix broken timer > > Prabhakar Lad (1): >da8xxevm: fix build error > > Sricharan (7): >omap4: make omap4 code common for future reuse >omap: Checkpatch fixes >omap5: Add minimal support for omap5430. >omap5: clocks: Add clocks support for omap5 platform. >omap5: emif: Add emif/ddr configurations required for omap5 evm >omap4/5: Add support for booting with CH. >omap5: Add omap5_evm board build support. > > Stefano Babic (1): >MX25: zmx25: GCC4.6 fix build warnings > > Tom Rini (2): >devkit8000: Fix NAND SPL on boards with 256MB NAND >OMAP3: Change omap3_evm maintainer > > .gitignore |1 + > MAINTAINERS| 15 +- > Makefile | 14 +- > README |6 + > arch/arm/cpu/arm1136/mx31/generic.c| 11 +- > arch/arm/cpu/arm920t/a320/timer.c | 134 +-- > arch/arm/cpu/arm926ejs/Makefile|6 + > arch/arm/cpu/arm926ejs/davinci/Makefile|2 +- > arch/arm/cpu/arm926ejs/davinci/am1808_lowlevel.c | 428 --- > arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c| 311 + > arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c| 73 +- > .../arm/cpu/arm926ejs/mx28}/Makefile | 11 +- > arch/arm/cpu/arm926ejs/mx28/clock.c| 355 ++ > arch/arm/cpu/arm926ejs/mx28/iomux.c| 109 ++ > arch/arm/cpu/arm926ejs/mx28/mx28.c | 221 > arch/arm/cpu/arm926ejs/mx28/timer.c
Re: [U-Boot] Pull request: u-boot-video/master
Dear Anatolij Gustschin, In message <2016000607.43a91f9b@wker> you wrote: > Hello Wolfgang, > > The following changes since commit 5721385b187b3154c7768e6c182501022f4e2e45: > > Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx (2011-11-08 > 07:44:52 +0100) > > are available in the git repository at: > > git://git.denx.de/u-boot-video.git master > > Che-Liang Chiou (4): > lcd: add clear and draw bitmap declaration > tools: logo: split bmp arrays from bmp_logo.h > font: split font data from video_font.h > api: export LCD device to external apps > > Jerry Huang (1): > Powerpc/DIU: Fixed the 800x600 and 1024x768 resolution bug > > Stefano Babic (1): > VIDEO: mx3fb: GCC4.6 fix build warnings > > Makefile|1 + > api/Makefile|3 +- > api/api.c | 47 + > api/api_display.c | 74 + > api/api_private.h |4 + > arch/powerpc/cpu/mpc8xx/video.c |1 + > board/mcc200/lcd.c |4 +- > common/cmd_bmp.c|4 +- > common/lcd.c| 18 +- > drivers/video/cfb_console.c |2 + > drivers/video/fsl_diu_fb.c |2 + > drivers/video/mx3fb.c |3 +- > drivers/video/sed156x.c |1 + > examples/api/demo.c | 31 + > examples/api/glue.c | 31 + > examples/api/glue.h |5 + > include/.gitignore |1 + > include/api_public.h| 16 + > include/lcd.h |2 + > include/video_font.h| 4614 > +-- > include/video_font_data.h | 4639 > +++ > tools/Makefile |8 +- > tools/bmp_logo.c| 80 +- > 23 files changed, 4944 insertions(+), 4647 deletions(-) > create mode 100644 api/api_display.c > create mode 100644 include/video_font_data.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never underestimate the power of human stupidity when it comes to using technology they don't understand. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Custodians - please lend a hand
Dear Stefano Babic, In message <4ec4102d.2020...@denx.de> you wrote: > > I have tried with a couple of patches (network related), and then I > wanted to test if push works. As u-boot-staging should be open for all > custodians, I was expecting I should use the same mechanism, and then I > tried with: > > > git push ssh://gu-...@git.denx.de/u-boot-staging sba...@denx.de > > ...but the new branch sba...@denx.de is now part of u-boot-imx, not > u-boot-staging ! Where is the mistake ? The command did actually work? Hm... Please try instead pushign as user "gu-staging", i. e. git push ssh://gu-stag...@git.denx.de/u-boot-staging :sba...@denx.de And _thanks_ !!! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Disc space - the final frontier! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] FPGA: drivers/fpga/ivm_core.c: GCC4.6 fix build warnings
Dear Stefano Babic, In message <1320576159-1921-1-git-send-email-sba...@denx.de> you wrote: > Fix: > ivm_core.c: In function 'ispVMLCOUNT': > ivm_core.c:2105:16: warning: unused variable 'usByte' > > Signed-off-by: Stefano Babic > CC: Wolfgang Denk > --- > drivers/fpga/ivm_core.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Look! There! Evil!.. pure and simple, total evil from the Eighth Dimension!" - Buckaroo Banzai ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] davinci, mmc: fix gcc 4.6 build warnings
Dear Heiko Schocher, In message <1320038153-24364-1-git-send-email...@denx.de> you wrote: > Fix: > davinci_mmc.c: In function 'dmmc_wait_fifo_status': > davinci_mmc.c:72:7: warning: variable 'mmcstatus1' set but not used > [-Wunused-but-set-variable] > davinci_mmc.c: In function 'dmmc_busy_wait': > davinci_mmc.c:89:7: warning: variable 'mmcstatus1' set but not used > [-Wunused-but-set-variable] > > Delete the unused variable. > > Signed-off-by: Heiko Schocher > Cc: Sandeep Paulraj > Cc: Albert ARIBAUD > --- > drivers/mmc/davinci_mmc.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Sandeep, Albert: hope this is OK with you. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are three ways to get something done: (1) Do it yourself. (2) Hire someone to do it for you. (3) Forbid your kids to do it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] drivers/block/ahci.c: Fix GCC 4.6 build warning
Dear Kumar Gala, In message <1320855670-7289-1-git-send-email-ga...@kernel.crashing.org> you wrote: > Fix: > > ahci.c: In function 'ata_scsiop_read10': > ahci.c:564:6: warning: variable 'lba' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Kumar Gala > --- > drivers/block/ahci.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Teenagers are people who express a burning desire to be different by dressing exactly alike. There are some strings. They're just not attached. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH] powerpc/85xx: verify the localbus device tree address before booting the OS
> ... it's possible for the 'reg' property to be wrong. Instead of all this, why doesn't u-boot just fix it? I have the same annoyance with ccsrbar. U-boot controls the ccsrbar address via a user configured #define. So instead of having different dts's based on the u-boot ccsrbar, why can't u-boot update the device tree? -Ed ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] drivers/bios_emulator/x86emu/ops.c: Fix GCC 4.6 build warning
Dear Kumar Gala, In message <1320855670-7289-2-git-send-email-ga...@kernel.crashing.org> you wrote: > Fix: > > x86emu/ops.c: In function 'x86emuOp_int3': > x86emu/ops.c:3521:9: warning: variable 'tmp' set but not used > [-Wunused-but-set-variable] > x86emu/ops.c: In function 'x86emuOp_int_IMM': > x86emu/ops.c:3549:9: warning: variable 'tmp' set but not used > [-Wunused-but-set-variable] > x86emu/ops.c: In function 'x86emuOp_into': > x86emu/ops.c:3579:9: warning: variable 'tmp' set but not used > [-Wunused-but-set-variable] > x86emu/ops.c: In function 'x86emuOp_aad': > x86emu/ops.c:3993:8: warning: variable 'a' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Kumar Gala > --- > drivers/bios_emulator/x86emu/ops.c | 15 --- > 1 files changed, 4 insertions(+), 11 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I have a very small mind and must live with it.-- Edsger Dijkstra ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH] powerpc/85xx: verify the localbus device tree address before booting the OS
Swarthout Edward L-SWARTHOU wrote: >> ... it's possible for the 'reg' property to be wrong. > > Instead of all this, why doesn't u-boot just fix it? > > I have the same annoyance with ccsrbar. > > U-boot controls the ccsrbar address via a user configured #define. > So instead of having different dts's based on the u-boot ccsrbar, > why can't u-boot update the device tree? Because we can't just relocate the devices that we know about and ignore the rest. If CCSR is at the wrong address, then maybe the PCI memory ranges are wrong, too? Who's to say what else is wrong? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] drivers/block/sata_sil3114.c: Fix GCC 4.6 build warning
Dear Kumar Gala, In message <1320855670-7289-3-git-send-email-ga...@kernel.crashing.org> you wrote: > Fix: > > sata_sil3114.c: In function 'scan_sata': > sata_sil3114.c:793:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:794:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:795:39: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:795:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:797:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:800:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:801:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:802:39: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:802:7: warning: array subscript is above array bounds > [-Warray-bounds] > sata_sil3114.c:804:7: warning: array subscript is above array bounds > [-Warray-bounds] > > Signed-off-by: Kumar Gala > --- > drivers/block/sata_sil3114.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Don't tell me how hard you work. Tell me how much you get done. -- James J. Ling ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/13] drivers/block/sym53c8xx.c: Fix GCC 4.6 build warning
Dear Wolfgang Denk, In message <1320866946-28235-1-git-send-email...@denx.de> you wrote: > Fix: > sym53c8xx.c: In function 'scsi_write_dsp': > sym53c8xx.c:456:16: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > drivers/block/sym53c8xx.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de That said, there may be good reasons for what you did beyond obsequi- ous sycophantic parody. Perhaps you might be so kind as to elucidate. -- Tom Christiansen in <5ldjbm$jtk$1...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/13] board/evb64260/i2c.c: Coding Style cleanup
Dear Heiko Schocher, In message <4ebb6ff4.5060...@denx.de> you wrote: > > > Make checkpatch-clean ... > > - unsigned int actualFreq, actualN=0, actualM=0; > > + unsigned int actualFreq, actualN = 0, actualM = 0; > > Hmm.. we don't use Upper and Lower case mixed for variable names. > This should be cleanuped too. Yes, you are right. I didn't have time to do that. Patches welcome. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Research is what I'm doing when I don't know what I'm doing. -- Wernher von Braun ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/13] board/evb64260/i2c.c: Coding Style cleanup
Dear Wolfgang Denk, In message <1320866946-28235-2-git-send-email...@denx.de> you wrote: > Make checkpatch-clean > > Signed-off-by: Wolfgang Denk > Cc: Eran Man > --- > board/evb64260/i2c.c | 48 ++-- > 1 files changed, 22 insertions(+), 26 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Buy land. They've stopped making it." - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH] powerpc/85xx: verify the localbus device tree address before booting the OS
On 11/16/2011 01:58 PM, Swarthout Edward L-SWARTHOU wrote: >> ... it's possible for the 'reg' property to be wrong. > > Instead of all this, why doesn't u-boot just fix it? > > I have the same annoyance with ccsrbar. > > U-boot controls the ccsrbar address via a user configured #define. > So instead of having different dts's based on the u-boot ccsrbar, > why can't u-boot update the device tree? That will require that U-Boot know where every instance of CCSRBAR is within the tree, which seems fragile. Do we have any instances yet of updating unit addresses from U-Boot? What about aliases that reference said unit addresses? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/13] board/evb64260/i2c.c: Fix GCC 4.6 build warnings
Dear Wolfgang Denk, In message <1320866946-28235-3-git-send-email...@denx.de> you wrote: > Fix: > i2c.c: In function 'i2c_init': > i2c.c:23:15: warning: variable 'actualFreq' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Eran Man > --- > board/evb64260/i2c.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A little suffering is good for the soul. -- Kirk, "The Corbomite Maneuver", stardate 1514.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/13] board/evb64260/evb64260.c: Fix GC 4.6 build warning
Dear Wolfgang Denk, In message <1320866946-28235-4-git-send-email...@denx.de> you wrote: > Fix: > evb64260.c: In function 'debug_led': > evb64260.c:363:6: warning: variable 'dummy' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > board/evb64260/evb64260.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Unser Kopf ist rund, damit das Denken die Richtung wechseln kann. -- Francis Picabia ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/13] board/evb64260/eth.c: Fix GCC 4.6 build warning
Dear Wolfgang Denk, In message <1320866946-28235-5-git-send-email...@denx.de> you wrote: > Fix: > eth.c: In function 'gt6426x_handle_SMI': > eth.c:130:15: warning: variable 'psr' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > board/evb64260/eth.c | 37 +++-- > 1 files changed, 19 insertions(+), 18 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Absolute: Independent, irresponsible. An absolute monarchy is one in which the sovereign does as he pleases so long as he pleases the assassins. Not many absolute monarchies are left, most of them having been replaced by limited monarchies, where the soverign's power for evil (and for good) is greatly curtailed, and by republics, which are governed by chance. - Ambrose Bierce ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/13] board/evb64260/sdram_init.c: Fix GCC 4.6 build warnings
Dear Wolfgang Denk, In message <1320866946-28235-6-git-send-email...@denx.de> you wrote: > Fix: > sdram_init.c: In function 'setup_sdram_common': > sdram_init.c:333:49: warning: variable 'ecc' set but not used > [-Wunused-but-set-variable] > sdram_init.c: In function 'setup_sdram': > sdram_init.c:410:13: warning: variable 'check' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > board/evb64260/sdram_init.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe contains any amount of horrible ways to be woken up, such as the noise of the mob breaking down the front door, the scream of fire engines, or the realization that today is the Monday which on Friday night was a comfortably long way off. - Terry Pratchett, _Moving Pictures_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/13] board/evb64260/zuma_pbb_mbox.c: CodingStyle cleanup
Dear Wolfgang Denk, In message <1320866946-28235-7-git-send-email...@denx.de> you wrote: > Make (mostly) checkpatch-clean > > Signed-off-by: Wolfgang Denk > --- > board/evb64260/zuma_pbb_mbox.c | 256 > +--- > 1 files changed, 132 insertions(+), 124 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de All programmers are optimists. Perhaps this modern sorcery especially attracts those who believe in happy endings and fairy godmothers. Perhaps the hundreds of nitty frustrations drive away all but those who habitually focus on the end goal. Perhaps it is merely that com- puters are young, programmers are younger, and the young are always optimists. But however the selection process works, the result is indisputable: "This time it will surely run," or "I just found the last bug." -- Frederick Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/13] board/evb64260/zuma_pbb_mbox.c: Fix GCC 4.6 build warnings
Dear Wolfgang Denk, In message <1320866946-28235-8-git-send-email...@denx.de> you wrote: > Fix: > zuma_pbb_mbox.c: In function 'zuma_mbox_dump': > zuma_pbb_mbox.c:115:2: warning: dereferencing type-punned pointer will > break strict-aliasing rules [-Wstrict-aliasing] > zuma_pbb_mbox.c:117:2: warning: dereferencing type-punned pointer will > break strict-aliasing rules [-Wstrict-aliasing] > > Signed-off-by: Wolfgang Denk > --- > board/evb64260/zuma_pbb_mbox.c | 25 ++--- > 1 files changed, 18 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de As far as the laws of mathematics refer to reality, they are not cer- tain, and as far as they are certain, they do not refer to reality. -- Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/13] common/cmd_fdc.c: Fix GCC 4.6 build warnings
Dear Wolfgang Denk, In message <1320866946-28235-9-git-send-email...@denx.de> you wrote: > Fix: > cmd_fdc.c: In function 'fdc_read_data': > cmd_fdc.c:435:6: warning: variable 'flags' set but not used > [-Wunused-but-set-variable] > cmd_fdc.c:432:16: warning: variable 'pcn' set but not used > [-Wunused-but-set-variable] > cmd_fdc.c:431:20: warning: variable 'lastblk' set but not used > [-Wunused-but-set-variable] > > Note: no attempts were made to otherwise cleanup the code. > > Signed-off-by: Wolfgang Denk > --- > common/cmd_fdc.c | 29 + > 1 files changed, 17 insertions(+), 12 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many hardware guys does it take to change a light bulb? "Well the diagnostics say it's fine buddy, so it's a software problem." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/13] common/cmd_universe.c: Fix GCC 4.6 build warning
Dear Wolfgang Denk, In message <1320866946-28235-10-git-send-email...@denx.de> you wrote: > Fix: > cmd_universe.c: In function 'universe_init': > cmd_universe.c:49:17: warning: variable 'lastError' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > common/cmd_universe.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There were meetings. There were always meetings. And they were dull, which is part of the reason they were meetings. Dull likes company. - Terry Pratchett, _Making_Money_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC 4.6 build warning
Dear Wolfgang Denk, In message <1320866946-28235-11-git-send-email...@denx.de> you wrote: > Convert custom debug code to use standard debug() facility. > This also fixes these build warning: > ct69000.c: In function 'FindAndSetPllParamIntoXrRegs': > ct69000.c:706:28: warning: variable 'new_pixclock' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > --- > drivers/video/ct69000.c | 12 +++- > 1 files changed, 7 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de People with narrow minds usually have broad tongues. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/13] board/esd/cpci750/cpci750.c: Fix error handling
Dear Wolfgang Denk, In message <1320866946-28235-12-git-send-email...@denx.de> you wrote: > ThE code recorded error conditions but did not pass these on to the > higher level caller. Fixing this fixes also this build warning: > cpci750.c: In function 'do_loadpci': > cpci750.c:569:6: warning: variable 'status' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Reinhard Arlt > --- > board/esd/cpci750/cpci750.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Little known fact about Middle Earth: The Hobbits had a very sophi- sticated computer network! It was a Tolkien Ring... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/13] board/esd/cpci750/sdram_init.c: Fix GCC 4.6 build warnings
Dear Mike Frysinger,
In message <20091545.07892.vap...@gentoo.org> you wrote:
> > static int check_dimm (uchar slot, AUX_MEM_DIMM_INFO * dimmInfo)
> > {
> > +#if 0
> > unsigned long spd_checksum;
> > -
> > +#endif
>
> forgot to just delete ?
Indeed. Will do in commit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
- Terry Pratchett, _The Dark Side of the Sun_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/13] board/esd/cpci750/sdram_init.c: Fix GCC 4.6 build warnings
Dear Wolfgang Denk, In message <1320866946-28235-13-git-send-email...@denx.de> you wrote: > Fix: > sdram_init.c: In function 'check_dimm': > sdram_init.c:267:50: warning: variable 'trrd_clocks' set but not used > [-Wunused-but-set-variable] > sdram_init.c:267:37: warning: variable 'tras_clocks' set but not used > [-Wunused-but-set-variable] > sdram_init.c:267:24: warning: variable 'trcd_clocks' set but not used > [-Wunused-but-set-variable] > sdram_init.c:267:8: warning: variable 'trp_clocks' set but not used > [-Wunused-but-set-variable] > sdram_init.c:253:16: warning: variable 'spd_checksum' set but not used > [-Wunused-but-set-variable] > sdram_init.c: In function 'initdram': > sdram_init.c:1693:14: warning: variable 's1' set but not used > [-Wunused-but-set-variable] > sdram_init.c:1693:6: warning: variable 's0' set but not used > [-Wunused-but-set-variable] > > Biggest part o the fix is converting the custom debug code to standard > debug(). > > No attempts were made to cleanup the code. > > Signed-off-by: Wolfgang Denk > Cc: Reinhard Arlt > --- > board/esd/cpci750/sdram_init.c | 508 > +++- > 1 files changed, 195 insertions(+), 313 deletions(-) Applied, thanks. [Also removed the useless "#if 0" / "#endif" part.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "What if" is a trademark of Hewlett Packard, so stop using it in your sentences without permission, or risk being sued. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arch/powerpc/cpu/mpc512x/pci.c: Fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1320963704-568-1-git-send-email-ag...@denx.de> you wrote: > Fix: > pci.c: In function 'pci_init_board': > pci.c:55:26: warning: variable 'pci_conf' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > arch/powerpc/cpu/mpc512x/pci.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Lots of folks confuse bad management with destiny. -- Frank Hubbard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Re
Dear beneficiary, This is to re-notify you of the $600,000.00 USD that was deposited here in the western union office in your favour is available for pickup. Contact us via email for your M.T.C.N Numbers. Contact Person: Mr.David Churchill Tel. +44 703 186 0768 Tel. +44 703 596 3267 Email: ( davidchurchil...@gmail.com ) DISCLAIMER AND CONFIDENTIALITY NOTICE The information contained in this e-mail, including those in its attachments, is confidential and intended only for the person(s) or entity(ies) to which it is addressed. If you are not an intended recipient, you must not read, copy, store, disclose, distribute this message, or act in reliance upon the information contained in it. If you received this e-mail in error, please contact the sender and delete the material from any computer or system. Any views expressed in this message are those of the individual sender and may not necessarily reflect the views of De La Salle University. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] arch/powerpc/cpu/mpc512x/i2c.c: Fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1320963704-568-2-git-send-email-ag...@denx.de> you wrote: > Fix: > i2c.c: In function 'wait_for_bb': > i2c.c:81:16: warning: variable 'temp' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > arch/powerpc/cpu/mpc512x/i2c.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Of all the things I've lost, I miss my mind the most. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/19] usb_ohci.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380105-6159-1-git-send-email...@denx.de> you wrote: > Fix: > usb_ohci.c: In function 'dl_transfer_length': > usb_ohci.c:756:8: warning: variable 'tdINFO' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/usb_ohci.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Include the success of others in your dreams for your own success. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/19] 4xx_enet.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380118-6257-1-git-send-email...@denx.de> you wrote: > Fix: > 4xx_enet.c: In function 'ppc_4xx_eth_init': > 4xx_enet.c:875:6: warning: variable 'ethgroup' set but not used > [-Wunused-but-set-variable] > > I used "__maybe_unused" here intentionally, since all other > alternatives to fix this compilation warning would result in more > ifdef's. > > Signed-off-by: Stefan Roese > --- > drivers/net/4xx_enet.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If A equals success, then the formula is A = X + Y + Z. X is work. Y is play. Z is keep your mouth shut. - Albert Einstein ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/19] 4xx_pcie.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380124-6304-1-git-send-email...@denx.de> you wrote: > Fix: > 4xx_pcie.c: In function 'pcie_read_config': > 4xx_pcie.c:230:6: warning: variable 'address' set but not used > [-Wunused-but-set-variable] > 4xx_pcie.c: In function 'pcie_write_config': > 4xx_pcie.c:290:6: warning: variable 'address' set but not used > [-Wunused-but-set-variable] > 4xx_pcie.c: In function 'ppc4xx_setup_pcie_rootpoint': > 4xx_pcie.c:1066:17: warning: variable 'rmbase' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/4xx_pcie.c | 11 ++- > 1 files changed, 2 insertions(+), 9 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Beware of programmers carrying screwdrivers." - Chip Salzenberg ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/19] 4xx_ibm_ddr2_autocalib.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380131-6351-1-git-send-email...@denx.de> you wrote: > Fix: > 4xx_ibm_ddr2_autocalib.c: In function 'get_membase': > 4xx_ibm_ddr2_autocalib.c:157:8: warning: variable 'bxcf' set but not used > [-Wunused-but-set-variable] > 4xx_ibm_ddr2_autocalib.c: In function 'DQS_calibration_methodB': > 4xx_ibm_ddr2_autocalib.c:722:8: warning: variable 'rffd' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/4xx_ibm_ddr2_autocalib.c | 15 +-- > 1 files changed, 9 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In a business, marketroids, salespukes, and lawyers have different goals from those who actually do work and produce something. Usually, is is the former who triumph over the latter, due to the simple rule that those who print the money make the rules. -- Tom Christiansen in <5jdcls$b04$2...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/19] cmd_ecctest.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380138-6398-1-git-send-email...@denx.de> you wrote: > Fix: > cmd_ecctest.c: In function 'inject_ecc_error': > cmd_ecctest.c:116:6: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > cmd_ecctest.c: In function 'rewrite_ecc_parity': > cmd_ecctest.c:154:6: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/cmd_ecctest.c |9 +++-- > 1 files changed, 3 insertions(+), 6 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Actual war is a very messy business. Very, very messy business. -- Kirk, "A Taste of Armageddon", stardate 3193.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver
Hi Wolfgang, Am Donnerstag 10 November 2011, 12:44:26 schrieb Wolfgang Denk: > Dear Prafulla, > > In message <48935aa530a6457b76b9915a1fe7faf9.squir...@ssl.serverraum.org> Michael Walle wrote: > > >> So was there any conclusion, now? Never touch mvgbe.c anymore? > > > > > > Let's remove this broken code. > > > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of > > ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed > > by Prafulla. > > Could you please revise your assessment? I would really appreciate if > we could clean this up. Regarding Prafulla's NAK? Let me sum up this thread once again: - consens is found that the driver should be cleaned up (removing the randomization code) - at least the keymile boards are ok with that. but there may be plenty of other boards which rely on this (broken?) behaviour. - besides the fact that a driver must not touch the environment, the mvgbe driver also fails to do this correctly for boards which has only the second port enabled. - Prafulla NAKed because only removing the code will leave some boards in a non-working state. i'm willing make a patch to move the randomization functionality to some generic place, but only if it is not NAKed by you beforehand. i dont have any time to waste ;) -- Michael ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/19] 44x_spd_ddr.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380144-6445-1-git-send-email...@denx.de> you wrote: > Fix: > 44x_spd_ddr.c: In function 'program_cfg0': > 44x_spd_ddr.c:384:16: warning: variable 'dimm_64bit' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr.c:383:16: warning: variable 'dimm_32bit' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/44x_spd_ddr.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A student of probability soon realizes that by its nature the billion-to-one chance crops up nine times out of ten, and that the greatest odds boil down to a double-sided statement: it will happen, or it will not. - Terry Pratchett, _The Dark Side of the Sun_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/19] 44x_spd_ddr2.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380150-6492-1-git-send-email...@denx.de> you wrote: > 44x_spd_ddr2.c: In function 'initdram': > 44x_spd_ddr2.c:450:17: warning: variable 'dimm_spd' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c: In function 'program_copt1': > 44x_spd_ddr2.c:1003:16: warning: variable 'ddrtype' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c: In function 'DQS_calibration_process': > 44x_spd_ddr2.c:2498:7: warning: variable 'window_found' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c:2497:16: warning: variable 'end_rffd' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c:2496:16: warning: variable 'end_rqfd' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c:2495:16: warning: variable 'begin_rffd' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c:2494:16: warning: variable 'begin_rqfd' set but not used > [-Wunused-but-set-variable] > 44x_spd_ddr2.c:2493:7: warning: variable 'min_end' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c | 32 > +--- > 1 files changed, 1 insertions(+), 31 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Do not simplify the design of a program if a way can be found to make it complex and wonderful. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/19] 40x_spd_sdram.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380157-6539-1-git-send-email...@denx.de> you wrote: > Fix: > 40x_spd_sdram.c: In function 'spd_sdram': > 40x_spd_sdram.c:137:6: warning: variable 'sdram0_b3cr' set but not used > [-Wunused-but-set-variable] > 40x_spd_sdram.c:136:6: warning: variable 'sdram0_b2cr' set but not used > [-Wunused-but-set-variable] > 40x_spd_sdram.c:129:6: warning: variable 'sdram0_ecccfg' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/40x_spd_sdram.c | 20 ++-- > 1 files changed, 10 insertions(+), 10 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is easier to write an incorrect program than understand a correct one. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/19] 20001122-1.c: Fix GCC 4.6 build warning
Dear Stefan Roese, In message <1321380163-6587-1-git-send-email...@denx.de> you wrote: > Fix: > 20001122-1.c: In function 'fpu_post_test_math1': > 20001122-1.c:37:22: warning: variable 'p' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > post/lib_powerpc/fpu/20001122-1.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe, they said, depended for its operation on the balance of four forces which they identified as charm, persuasion, uncertainty and bloody-mindedness. -- Terry Pratchett, "The Light Fantastic" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 11/19] sata_dwc.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380169-6634-1-git-send-email...@denx.de> you wrote: > Fix: > sata_dwc.c: In function 'sata_dwc_softreset': > sata_dwc.c:444:5: warning: variable 'status' set but not used > [-Wunused-but-set-variable] > sata_dwc.c:443:6: warning: variable 'serror' set but not used > [-Wunused-but-set-variable] > sata_dwc.c: In function 'scan_sata': > sata_dwc.c:654:16: warning: variable 'lba_desc' set but not used > [-Wunused-but-set-variable] > sata_dwc.c:538:16: warning: variable 'xfer_mask' set but not used > [-Wunused-but-set-variable] > sata_dwc.c: In function 'ata_dev_read_id': > sata_dwc.c:747:14: warning: variable 'reason' set but not used > [-Wunused-but-set-variable] > sata_dwc.c: In function 'ata_dev_read_sectors': > sata_dwc.c:1810:6: warning: variable 'rc' set but not used > [-Wunused-but-set-variable] > sata_dwc.c: In function 'ata_dev_write_sectors': > sata_dwc.c:1994:6: warning: variable 'rc' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > drivers/block/sata_dwc.c | 35 +++ > 1 files changed, 3 insertions(+), 32 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I have yet to add the ESP-driver to the kernel to read the mind of the user... - Linus Torvalds in ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/19] nand_boot.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380174-6687-1-git-send-email...@denx.de> you wrote: > Fix: > nand_boot.c: In function 'nand_read_page': > nand_boot.c:190:6: warning: variable 'stat' set but not used > [-Wunused-but-set-variable] > nand_boot.c: In function 'nand_boot': > nand_boot.c:271:6: warning: variable 'ret' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > nand_spl/nand_boot.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Cogito cogito ergo cogito sum - "I think that I think, therefore I think that I am." - Ambrose Bierce, "The Devil's Dictionary" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/19] dlvision-10g.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380180-6735-1-git-send-email...@denx.de> you wrote: > Fix: > dlvision-10g.c: In function 'print_fpga_info': > dlvision-10g.c:90:11: warning: variable 'feature_compression' set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/gdsys/405ep/dlvision-10g.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Keep your head and your heart going in the right direction and you will not have to worry about your feet. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 14/19] cmd_pci405.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380186-6782-1-git-send-email...@denx.de> you wrote: > Fix: > cmd_pci405.c: In function 'do_loadpci': > cmd_pci405.c:45:6: warning: variable 'status' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/esd/pci405/cmd_pci405.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The explanation requiring the fewest assumptions is the most likely to be correct.-- William of Occam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/19] cmd_dasa_sim.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380200-6833-1-git-send-email...@denx.de> you wrote: > Fix: > cmd_dasa_sim.c: In function 'updatePci9054': > cmd_dasa_sim.c:135:6: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > cmd_dasa_sim.c: In function 'clearPci9054': > cmd_dasa_sim.c:189:6: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/esd/dasa_sim/cmd_dasa_sim.c | 52 > + > 1 files changed, 24 insertions(+), 28 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Quantum particles: The dreams that stuff is made of. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 16/19] iop480_uart.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380207-6889-1-git-send-email...@denx.de> you wrote: > Fix: > iop480_uart.c: In function 'serial_init': > iop480_uart.c:137:16: warning: variable 'val' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > arch/powerpc/cpu/ppc4xx/iop480_uart.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The face of war has never changed. Surely it is more logical to heal than to kill. -- Surak of Vulcan, "The Savage Curtain", stardate 5906.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 17/19] auto_update.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380213-6938-1-git-send-email...@denx.de> you wrote: > Fix: > ../common/auto_update.c: In function 'au_check_header_valid': > ../common/auto_update.c:94:16: warning: variable 'checksum' set but not used > [-Wunused-but-set-variable] > ../common/auto_update.c: In function 'do_auto_update': > ../common/auto_update.c:400:30: warning: variable 'got_ctrlc' set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/esd/common/auto_update.c |8 +--- > 1 files changed, 1 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Never underestimate the power of human stupidity when it comes to using technology they don't understand. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/19] mip405.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380219-6986-1-git-send-email...@denx.de> you wrote: > Fix: > mip405.c: In function 'init_sdram': > mip405.c:250:4: warning: variable 'tctp_clocks' set but not used > [-Wunused-but-set-variable] > mip405.c: In function 'initdram': > mip405.c:629:9: warning: variable 'ds' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/mpl/mip405/mip405.c | 10 +++--- > 1 files changed, 3 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The joys of love made her human and the agonies of love destroyed her. -- Spock, "Requiem for Methuselah", stardate 5842.8 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 19/19] pip405.c: Fix GCC 4.6 build warnings
Dear Stefan Roese, In message <1321380225-7033-1-git-send-email...@denx.de> you wrote: > Fix: > pip405.c: In function 'board_early_init_f': > pip405.c:192:16: warning: variable 'tctp_clocks' set but not used > [-Wunused-but-set-variable] > pip405.c:182:16: warning: variable 'dataout' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Stefan Roese > --- > board/mpl/pip405/pip405.c | 11 +++ > 1 files changed, 7 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de O Staat! Wie tief dir alle Besten fluchen! Du bist kein Ziel. Der Mensch muß weiter suchen. - Christian Morgenstern ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver
Dear Michael Walle, In message <20162115.0.mich...@walle.cc> you wrote: > > > Could you please revise your assessment? I would really appreciate if > > we could clean this up. > Regarding Prafulla's NAK? Yes - I'd really appreciate if Prafulla woudl withdraw his NAK, and agree on a cleanup. But he remains silent for a week or so... > Let me sum up this thread once again: > - consens is found that the driver should be cleaned up (removing the >randomization code) > - at least the keymile boards are ok with that. but there may be plenty of >other boards which rely on this (broken?) behaviour. The problem is this "may be". We don't know it, and we will never find out. And even if we find such configurations, we have no information if any user actually needs this feature. The only way to really find out is by removing this stuff now. If anybody complains then, we can discuss with him approaches to fix this again, in a clean way. > - besides the fact that a driver must not touch the environment, the mvgbe >driver also fails to do this correctly for boards which has only the second >port enabled. > - Prafulla NAKed because only removing the code will leave some boards in a >non-working state. > > i'm willing make a patch to move the randomization functionality to some > generic place, but only if it is not NAKed by you beforehand. i dont have any > time to waste ;) Please don't move the broken code around. Let's remove it. Let's give Prafulla another 2 or 3 days time to respond. If we don;t hear from him, we go ahead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Be careful what you wish for. You never know who will be listening. - Terry Pratchett, _Soul Music_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/12] drivers/spi/atmel_spi.c: Fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-2-git-send-email-ag...@denx.de> you wrote: > Fix: > atmel_spi.c: In function 'spi_xfer': > atmel_spi.c:139:7: warning: variable 'ret' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/spi/atmel_spi.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Who is the oldest inhabitant of this village?" "We haven't got one; we had one, but he died three weeks ago." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/12] drivers/mtd/dataflash.c: Fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-3-git-send-email-ag...@denx.de> you wrote: > Fix: > dataflash.c: In function 'AT91F_DataflashInit': > dataflash.c:42:6: warning: variable 'last_part' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/mtd/dataflash.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Perfection is reached, not when there is no longer anything to add, but when there is no longer anything to take away. - Antoine de Saint-Exupery ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/12] drivers/net/at91_emac.c: Fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-4-git-send-email-ag...@denx.de> you wrote: > Fix: > at91_emac.c: In function 'at91emac_write_hwaddr': > at91_emac.c:477:15: warning: variable 'dev' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/net/at91_emac.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ... The things love can drive a man to -- the ecstasies, the mise- ries, the broken rules, the desperate chances, the glorious failures and the glorious victories. -- McCoy, "Requiem for Methuselah", stardate 5843.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 3/4] tegra2: Modify MMC driver to handle power and cd GPIOs
* Stephen Warren wrote: > Pass the GPIO numbers for power and card detect to tegra2_mmc_init(), and > modify that function to perform all required GPIO initialization. This > removes the need for board files to perform these operations. > > Move board_mmc_getcd() into tegra2_mmc.c now that the driver knows which > GPIOs to use. > > Update affected call-sites in seaboard.c and harmony.c. Note that this > change should make all SD ports work on Harmony, since the required GPIO > setup is now being performed. > > v4: Fix prototype of tegra2_mmc_init() in board.h to match driver change. > Remove prototype of gpio_config_mmc() from board.h > > Signed-off-by: Stephen Warren > Tested-by: Simon Glass > --- > board/nvidia/common/board.h |3 +- > board/nvidia/harmony/harmony.c | 27 ++- > board/nvidia/seaboard/seaboard.c | 33 + > drivers/mmc/tegra2_mmc.c | 42 - > drivers/mmc/tegra2_mmc.h |4 ++- > 5 files changed, 45 insertions(+), 64 deletions(-) > > diff --git a/board/nvidia/common/board.h b/board/nvidia/common/board.h > index 344e702..35acbca 100644 > --- a/board/nvidia/common/board.h > +++ b/board/nvidia/common/board.h > @@ -26,7 +26,6 @@ > > void tegra2_start(void); > void gpio_config_uart(void); > -void gpio_config_mmc(void); > -int tegra2_mmc_init(int dev_index, int bus_width); > +int tegra2_mmc_init(int dev_index, int bus_width, int pwr_gpio, int cd_gpio); [...] Can we move tegra2_start() and tegra2_mmc_init() into a common Tegra2 header instead of a board-specific one, please? Both functions are not implemented below board/nvidia/common, so there is no need to make their prototype only visible for board/nvidia. Otherwise other boards will have to duplicate this prototype and need to keep it in sync. tegra2_start() can probably go into arch/arm/include/asm/arch-tegra2/tegra2.h and tegra2_mmc_init() could for example go into a new mmc.h in the same directory. Thierry pgpEGrSX4DtHI.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/12] drivers/net/enc28j60.c: Fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1321399263-13826-5-git-send-email-ag...@denx.de> you wrote: > Fix: > enc28j60.c: In function 'enc_receive': > enc28j60.c:435:5: warning: variable 'eir_reg' set but not used > [-Wunused-but-set-variable] > enc28j60.c: In function 'enc_poll': > enc28j60.c:503:5: warning: variable 'estat_reg' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/net/enc28j60.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Business is like a wheelbarrow. Nothing ever happens until you start pushing. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/12] drivers/net/enc28j60.c: Fix GCC 4.6 warnings
Dear Mike Frysinger, In message <20161058.57150.vap...@gentoo.org> you wrote: > > On Tuesday 15 November 2011 18:20:55 Anatolij Gustschin wrote: > > - eir_reg = enc_r8(enc, CTL_REG_EIR); > > + (void)enc_r8(enc, CTL_REG_EIR); > > is that (void) actually necessary ? last i looked, gcc didn't actually care. > > which means you should drop the (void). It's not really necessary, but always a good indication to the reader that we intentionally ignore the return code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It all seemed, he thought, to be rather a lot of trouble to go to just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] unsubscribe
___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/12] board/cm41xx/flash.c: Fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1321399263-13826-6-git-send-email-ag...@denx.de> you wrote: > Fix: > flash.c: In function 'flash_erase': > flash.c:209:6: warning: variable 'flag' set but not used > [-Wunused-but-set-variable] > flash.c: In function 'write_data': > flash.c:373:6: warning: variable 'flag' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > board/cm41xx/flash.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de What about WRITING it first and rationalizing it afterwords? :-) - Larry Wall in <8...@jpl-devvax.jpl.nasa.gov> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/12] board/cm4008/flash.c: Fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1321399263-13826-7-git-send-email-ag...@denx.de> you wrote: > Fix: > flash.c: In function 'flash_erase': > flash.c:209:6: warning: variable 'flag' set but not used > [-Wunused-but-set-variable] > flash.c: In function 'write_data': > flash.c:373:6: warning: variable 'flag' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > board/cm4008/flash.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To know how another being, another creature feels - that is impos- sible. - Terry Pratchett, _The Dark Side of the Sun_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/12] drivers/video/da8xx-fb.c: Fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-8-git-send-email-ag...@denx.de> you wrote: > Fix: > da8xx-fb.c: In function 'video_hw_init': > da8xx-fb.c:688:6: warning: variable 'ret' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/video/da8xx-fb.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A consultant is a person who borrows your watch, tells you what time it is, pockets the watch, and sends you a bill for it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/12] drivers/video/bus_vcxk.c: Fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-9-git-send-email-ag...@denx.de> you wrote: > Fix: > bus_vcxk.c: In function 'vcxk_display_bitmap': > bus_vcxk.c:396:16: warning: variable 'compression' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/video/bus_vcxk.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Our OS who art in CPU, UNIX be thy name. Thy programs run, thy syscalls done, In kernel as it is in user! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/12] arch/arm/cpu/armv7/s5p-common/pwm.c: fix GCC 4.6 warning
Dear Anatolij Gustschin, In message <1321399263-13826-11-git-send-email-ag...@denx.de> you wrote: > Fix: > pwm.c: In function 'pwm_config': > pwm.c:85:16: warning: variable 'timer_rate_hz' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > arch/arm/cpu/armv7/s5p-common/pwm.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The world is no nursery. - Sigmund Freud ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 11/12] fs/yaffs2/yaffs_guts.c: Fix some GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1321399263-13826-12-git-send-email-ag...@denx.de> you wrote: > Fix: > yaffs_guts.c: In function 'yaffs_CheckChunkErased': > yaffs_guts.c:854:6: warning: variable 'result' set but not used > yaffs_guts.c: In function 'yaffs_UpdateObjectHeader': > yaffs_guts.c:3463:6: warning: variable 'result' set but not used > yaffs_guts.c: In function 'yaffs_GrabChunkCache': > yaffs_guts.c:3774:6: warning: variable 'pushout' set but not used > yaffs_guts.c: In function 'yaffs_Scan': > yaffs_guts.c:5237:6: warning: variable 'result' set but not used > yaffs_guts.c: In function 'yaffs_CheckObjectDetailsLoaded': > yaffs_guts.c:5748:6: warning: variable 'alloc_failed' set but not used > yaffs_guts.c:5747:6: warning: variable 'result' set but not used > yaffs_guts.c: In function 'yaffs_ScanBackwards': > yaffs_guts.c:5808:6: warning: variable 'deleted' set but not used > yaffs_guts.c:5806:6: warning: variable 'result' set but not used > yaffs_guts.c: In function 'yaffs_GetObjectName': > yaffs_guts.c:6657:7: warning: variable 'result' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > fs/yaffs2/yaffs_guts.c | 32 +--- > 1 files changed, 9 insertions(+), 23 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Reader, suppose you were an idiot. And suppose you were a member of Congress. But I repeat myself. - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/12] drivers/rtc/s3c24x0_rtc.c: fix GCC 4.6 warnings
Dear Anatolij Gustschin, In message <1321399263-13826-13-git-send-email-ag...@denx.de> you wrote: > Fix: > s3c24x0_rtc.c: In function 'rtc_get': > s3c24x0_rtc.c:67:53: warning: variable 'a_armed' set but not used > s3c24x0_rtc.c:67:45: warning: variable 'a_year' set but not used > s3c24x0_rtc.c:67:38: warning: variable 'a_mon' set but not used > s3c24x0_rtc.c:67:30: warning: variable 'a_date' set but not used > s3c24x0_rtc.c:67:22: warning: variable 'a_hour' set but not used > s3c24x0_rtc.c:67:15: warning: variable 'a_min' set but not used > s3c24x0_rtc.c:67:8: warning: variable 'a_sec' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- > drivers/rtc/s3c24x0_rtc.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I read part of it all the way through. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Help needed - urgently
On Nov 15, 2011, at 9:01 AM, Wolfgang Denk wrote: > Hello all, > > I guess most of you will already have noticed that my activity on the > mailing list has significantly declined recently. I'm sorry for that, > but I find myself in a situation where I have even less time > available for U-Boot than usually. In the result, the number of > unapplied (and sometimes unreviewed) patches is growing and growing. > > I need your help. we need to find a way to distribute the workload > for "general" patches (i. e. those that don't fall obviously into the > responsibility of a specific custodian) across more shoulders than > just mine. Pressure on me has been building up already for some time, > and now we've reached the point where we need to find a solution. > > > One possible approach has been suggested before: > Maybe the load can be spread here - maintainers can put these in designated branches in their repositories. I know this will cause the odd conflict, >>> >>> If you script this (based on pwapply) you can bail out early if the >>> patch is no longer in state "New". >>> but we (the maintainers) could also periodically sync between each other. Another alternative is to create a new repo that all the custodians have access to... >>> >>> That would be easy to do... >> >> Maybe that's what we do - Once a patch reaches maturity (a revision >> with an Ack and maybe a Tested-by) any maintainer can just put it in >> the 'next' repo - You can always veto it and not pull it into >> mainline anyway, but at least it gives everyone a semi-stable >> platform to base patches for the next merge window > > I would like to try this out now, taking effect immediately. > > I have created a new repository "u-boot-staging", where all current > custodians (should) have write access to. > > My proposal is as follows (please feel free to comment): > > - Any custodian is able (and encouraged) to pick up unapplied patches > that have "reached maturity" (ideally an Ack and maybe a > Tested-by), but at least no negative feedback on the mailing list, > and re-review these. If they are considered OK and do not cause any > new build issues, they can be applied. Please don't forget to > update the entries in Patchwork. > > - To ensure quality, no custodian should apply his own patches. > > - After reviewing and build testing (MAKEALL for at least two > different architectures) the stuff can be pushed into a _branch_ of > the "u-boot-staging" repository. I suggest to use the custodian's > e-mail address as branch name. > > - After that, the custodian can send a pull request to me. > > > Please let's try if this works. If you have any suggestions how to > help better, please don't hesitate to tell us. On suggestion I'd have is we improve our use of patchworks. Right now there is way too much 'stale' on patchworks so its difficult to extract what needs to be looked at from what might be owned by existing maintainers. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Fix warnings in yaffs
Dear Simon Glass, In message <1321417027-5639-2-git-send-email-...@chromium.org> you wrote: > Sorry if this is already fixed somewhere - I could not find it. > > This fixes the warnings show below. > > yaffs_tagscompat.c: In function > 'yaffs_TagsCompatabilityReadChunkWithTagsFromNAND': > yaffs_tagscompat.c:151: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:150: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:149: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:148: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:147: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:146: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:145: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:144: warning: dereferencing pointer 'tu' does break > strict-aliasing rules > yaffs_tagscompat.c:141: note: initialized from here > > Signed-off-by: Simon Glass > --- > fs/yaffs2/yaffs_tagscompat.c | 15 +++ > 1 files changed, 7 insertions(+), 8 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de But the only way of discovering the limits of the possible is to venture a little way past them into the impossible. - _Profiles of the Future_ (1962; rev. 1973) ``Hazards of Prophecy: The Failure of Imagination'' ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
