Re: [U-Boot] A bit about board.c, board.c
Dear Simon Glass, In message you wrote: > > My suggestion was: > > CONFIG_ARCH_GENERIC_BOARD - you get lib/board.c > not CONFIG_ARCH_GENERIC_BOARD - you get arch/xxx/lib/board.c If we do something like this, then the other way round. There should never be any #defines needed for the standard case - i. e. for using lib/board.c, Also, "ARCH_GENERIC_BOARD" is not a good name as it does not really tell the reader that you are referencing to a specific source file here - most people will think you are referring to some hardware properties. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "My name is Linus Torvalds, you messed with my kernel, prepare to die" - Linus Torvalds in ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Dear Graeme Russ, In message <4ea34086.4030...@gmail.com> you wrote: > > One problem I see with XON/XOFF is that if we don't send XOFF at the right > time, we run the risk of entering a busy loop (any reasonable timeout delay > for example) and loosing input. So in theory, we would need to send XOFF > after every getc() ... That's not true. I am not aware of any significant delays that take place while receiving characters that belong to a single line. If we had any of these, we would lose characters all the time - but we don't. It should be sufficient to send XOFF after receiving a newline character. > Maybe we need disable/enable flow control functions for when we know we > will be entering a busy loop the consumes serial input (ymodem and kermit > transfers and readline for example) This should not be necessary. Actually the implementation should not need to know about such special cases. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Compassion -- that's the one things no machine ever had. Maybe it's the one thing that keeps men ahead of them. -- McCoy, "The Ultimate Computer", stardate 4731.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions
Dear Simon Glass, In message you wrote: > > > Can you please #ifdef it so it doesn't get added for the non-debug > > case, too? > > Well I could, but then if someone defines DEBUG in a file they will > get a link error I think. Or are you thinking of adding a new CONFIG > which *permits* people to use DEBUG? I don't understand what you mean. __assert_fail() only ever gets used (and thus needs to be compiled in) if DEBUG is defined, right? SO why cannot you wrap the code in a "#ifdef DEBUG" ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "There's only one kind of woman ..." "Or man, for that matter. You either believe in yourself or you don't." -- Kirk and Harry Mudd, "Mudd's Women", stardate 1330.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] fdt: Add new fdt_set_node_status & fdt_set_status_by_alias helpers
Dear Kumar Gala, In message <1318619444-2059-1-git-send-email-ga...@kernel.crashing.org> you wrote: > From: Shengzhou Liu > > Add common function fdt_set_node_status() to assist in various locations > that we set a nodes status. This function utilizes the status values > that are part of the EPAPR spec (on power.org). > > fdt_set_status_by_alias() is based on fdt_set_node_status() but uses an > alias string to identify the node to update. > > We also add some shortcut functions to help the common cases of setting > "okay" and "disabled": > > fdt_status_okay() > fdt_status_disabled() > fdt_status_okay_by_alias() > fdt_status_disabled_by_alias() > > Finally, we fixup the corenet_ds ethernet code which previously had > a function by the same name that can be replaced with the new helpers. > > Signed-off-by: Shengzhou Liu > Signed-off-by: Kumar Gala This patch breaks a number of boards by growing the code size even for boards which never make use of this new stuff. Affected boards: TQM8555 TQM8541 [Building with ELDK 4.2]: + ./MAKEALL TQM8555 Configuring for TQM8555 - Board: TQM85xx, Options: MPC8555,TQM8555=y,HOSTNAME=tqm8555,BOARDNAME="TQM8555" ppc_6xx-ld: warning: dot moved backwards before `.bss' ppc_6xx-ld: warning: dot moved backwards before `.bss' ppc_6xx-ld: u-boot: section .text lma 0xfffc overlaps previous sections ppc_6xx-ld: u-boot: section .rodata lma 0xfffef388 overlaps previous sections ppc_6xx-ld: u-boot: section .reloc lma 0xa400 overlaps previous sections ppc_6xx-ld: u-boot: section .data lma 0xcd3c overlaps previous sections ppc_6xx-ld: u-boot: section .u_boot_cmd lma 0xea68 overlaps previous sections ppc_6xx-ld: u-boot: section .bootpg lma 0xf0dc overlaps previous sections Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Each honest calling, each walk of life, has its own elite, its own aristocracy based on excellence of performance. - James Bryant Conant ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] serial: uartlite: Fix compilation warnings
Dear Michal Simek, In message <131890-17883-2-git-send-email-mon...@monstr.eu> you wrote: > Do not setup userial_ports array as const because > in uartlite_serial_putc is out_be32 which can't write > to tx_fifo if is const. > > Warning log: > serial_xuartlite.c: In function 'uartlite_serial_putc': > serial_xuartlite.c:60: warning: initialization discards qualifiers from > pointer target type > serial_xuartlite.c: In function 'uartlite_serial_getc': > serial_xuartlite.c:78: warning: initialization discards qualifiers from > pointer target type > serial_xuartlite.c: In function 'uartlite_serial_tstc': > serial_xuartlite.c:87: warning: initialization discards qualifiers from > pointer target type > > Signed-off-by: Michal Simek > > --- > There are several approach how to solve it in uartlite_serial_putc. > 1. add retype to out_be32 function > 2. retype in assignment > 3. do not define userial_ports as const - used solution Wouldn't 1. and 2. actually be wrong? If you need to write to the struct, you must not declare it as constant? > --- > drivers/serial/serial_xuartlite.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de God made the integers; all else is the work of Man. - Kronecker ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 6/7] powerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver
Dear Kumar Gala, In message <2a6300e8-a874-49ac-84cb-be681af1b...@freescale.com> you wrote: > > On Aug 26, 2011, at 1:32 PM, York Sun wrote: > > > Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c. > > The unified driver can initialize data using DDR controller. No need to > > use DMA if just to initialze for ECC. > > > > Signed-off-by: York Sun > > Signed-off-by: Kim Phillips > > --- > > board/freescale/mpc8349emds/Makefile |1 + > > board/freescale/mpc8349emds/ddr.c | 107 > > + > > board/freescale/mpc8349emds/mpc8349emds.c | 26 --- > > include/configs/MPC8349EMDS.h | 16 > > 4 files changed, 139 insertions(+), 11 deletions(-) > > create mode 100644 board/freescale/mpc8349emds/ddr.c > > applied to 85xx 'next' Did you test it??? This patch breaks out-of-tree building of the MPC8349EMDS board: + MAKEALL_LOGDIR=/work/wd/tmp-ppc-LOG + BUILD_DIR=/work/wd/tmp-ppc + ./MAKEALL MPC8349EMDS Configuring for MPC8349EMDS board... make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend.ddr-gen2', needed by `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend'. Stop. make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend.ddr-gen2', needed by `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend'. Stop. make: *** [depend] Error 2 [Local building works.] Note also that "make distclean" still leaves a file arch/powerpc/cpu/mpc83xx/ddr-gen2.c Please fix this, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Overflow on /dev/null, please empty the bit bucket. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions
On Sun, Oct 23, 2011 at 04:35, Wolfgang Denk wrote: > Simon Glass wrote: >> > Can you please #ifdef it so it doesn't get added for the non-debug >> > case, too? >> >> Well I could, but then if someone defines DEBUG in a file they will >> get a link error I think. Or are you thinking of adding a new CONFIG >> which *permits* people to use DEBUG? > > I don't understand what you mean. > > __assert_fail() only ever gets used (and thus needs to be compiled in) > if DEBUG is defined, right? SO why cannot you wrap the code in a > "#ifdef DEBUG" ? people often enable DEBUG on a per file basis. so if i'm debugging drivers/spi/bfin_spi.c, i put "#define DEBUG" at the top of it. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Hi Wolgang, On Oct 23, 2011 7:20 PM, "Wolfgang Denk" wrote: > > Dear Graeme Russ, > > In message <4ea34086.4030...@gmail.com> you wrote: > > > > One problem I see with XON/XOFF is that if we don't send XOFF at the right > > time, we run the risk of entering a busy loop (any reasonable timeout delay > > for example) and loosing input. So in theory, we would need to send XOFF > > after every getc() ... > > That's not true. I am not aware of any significant delays that take > place while receiving characters that belong to a single line. If we > had any of these, we would lose characters all the time - but we > don't. > > It should be sufficient to send XOFF after receiving a newline > character. And, ergo, we send an XON when entering the readline function Hmm, should we move readline() into console.c > > Maybe we need disable/enable flow control functions for when we know we > > will be entering a busy loop the consumes serial input (ymodem and kermit > > transfers and readline for example) > > This should not be necessary. Actually the implementation should not > need to know about such special cases. So how does kermit/ymodem send the XON after the user has entered the receive command and we have sent the XOFF after the newline? Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Update s3c24x0 timer implementation
I have been doing some work to get U-Boot running on a samsung S3C2440
based SBC (QQ2440). I experienced several issues getting the board
running including "raise: Signal # 8 caught" errors being printed to
the console. After a bit of debugging with a JTAG debugger I found
the problems were due to arch/arm/cpu/arm920t/s3c24x0/timer.c using
several global variables prior to relocation to RAM. I noticed that
the global variable .bss section is shared with the .rel.text section.
Since the .rel.text section is required by the relocation code, I
assume that .bss global variables cannot be used until after
relocation?
After studying several other timer.c files I developed the following
patch which uses the global data struct to store the global variables.
I also restructured some of the code based on structure of the other
timer.c files. I have confirmed it works correctly on the SBC I have.
Regards
Mark Norman
The s3c24x0 timer has been updated to use the global_data struct.
Restructured code based on other timer.c files.
Updated comments and several parameters.
Signed-off-by: Mark Norman
---
arch/arm/cpu/arm920t/s3c24x0/timer.c | 158 +
arch/arm/include/asm/global_data.h | 12 +--
2 files changed, 66 insertions(+), 104 deletions(-)
diff --git a/arch/arm/cpu/arm920t/s3c24x0/timer.c
b/arch/arm/cpu/arm920t/s3c24x0/timer.c
index 9571870..1552345 100644
--- a/arch/arm/cpu/arm920t/s3c24x0/timer.c
+++ b/arch/arm/cpu/arm920t/s3c24x0/timer.c
@@ -35,146 +35,112 @@
#include
#include
-int timer_load_val = 0;
-static ulong timer_clk;
+DECLARE_GLOBAL_DATA_PTR;
-/* macro to read the 16 bit timer */
-static inline ulong READ_TIMER(void)
+/* Read the 16 bit timer */
+static inline ulong read_timer(void)
{
struct s3c24x0_timers *timers = s3c24x0_get_base_timers();
-
return readl(&timers->tcnto4) & 0x;
}
-static ulong timestamp;
-static ulong lastdec;
-
int timer_init(void)
{
struct s3c24x0_timers *timers = s3c24x0_get_base_timers();
ulong tmr;
- /* use PWM Timer 4 because it has no output */
- /* prescaler for Timer 4 is 16 */
- writel(0x0f00, &timers->tcfg0);
- if (timer_load_val == 0) {
- /*
-* for 10 ms clock period @ PCLK with 4 bit divider = 1/2
-* (default) and prescaler = 16. Should be 10390
-* @33.25MHz and 15625 @ 50 MHz
-*/
- timer_load_val = get_PCLK() / (2 * 16 * 100);
- timer_clk = get_PCLK() / (2 * 16);
- }
- /* load value for 10 ms timeout */
- lastdec = timer_load_val;
- writel(timer_load_val, &timers->tcntb4);
- /* auto load, manual update of timer 4 */
+ /* Use PWM Timer 4 because it has no output.
+* Prescaler is hard fixed at 250, divider at 2.
+* This generates a Timer clock frequency of 100kHz (@PCLK=50MHz) and
+* therefore 10us timer ticks.
+*/
+
+ /* Prescaler for Timer 4 is 250 */
+ const ulong prescaler = 250;
+ writel((prescaler-1) << 8, &timers->tcfg0);
+
+ /* Calculate timer freq, approx 100kHz @ PCLK=50MHz. */
+ gd->timer_rate_hz = get_PCLK() / (2 * prescaler);
+
+ /* Set timer for 0.5s timeout (5 ticks @ 10us ticks). */
+ gd->timer_reset_value = 5;
+ writel(gd->timer_reset_value, &timers->tcntb4);
+ gd->lastdec = gd->timer_reset_value;
+
+ /* Load the initial timer 4 count value using the manual update bit. */
tmr = (readl(&timers->tcon) & ~0x070) | 0x060;
writel(tmr, &timers->tcon);
- /* auto load, start timer 4 */
+
+ /* Configure timer 4 for auto reload and start it. */
tmr = (tmr & ~0x070) | 0x050;
writel(tmr, &timers->tcon);
- timestamp = 0;
+
+ gd->timestamp = 0;
return (0);
}
/*
- * timer without interrupts
+ * Get the number of ticks (in CONFIG_SYS_HZ resolution)
*/
-ulong get_timer(ulong base)
+unsigned long long get_ticks(void)
{
- return get_timer_masked() - base;
+ return get_timer(0);
}
-void __udelay (unsigned long usec)
+unsigned long get_timer_raw(void)
{
- ulong tmo;
- ulong start = get_ticks();
+ ulong now = read_timer();
- tmo = usec / 1000;
- tmo *= (timer_load_val * 100);
- tmo /= 1000;
+ if (gd->lastdec >= now) {
+ /* normal mode */
+ gd->timestamp += gd->lastdec - now;
+ } else {
+ /* we have an overflow ... */
+ gd->timestamp += gd->lastdec + gd->timer_reset_value - now;
+ }
+ gd->lastdec = now;
- while ((ulong) (get_ticks() - start) < tmo)
- /*NOP*/;
+ return gd->timestamp;
}
-ulong get_timer_masked(void)
+/*
+ * This function is derived from PowerPC code (timebase clock frequency).
+ * On ARM it returns the number of timer ticks per second.
+ */
+ulong get_tbclk(void)
[U-Boot] debugX macro
Hi, I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt. The following do use it: ./board/spc1920/hpi.c ./drivers/mtd/nand/s3c2410_nand.c Opinions? Thanks, Cheers! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] MPC85xx: remove broken "mpq101" board
The board stopped building some time ago, and the board maintainer
agrtees to drop it - see
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/112674
Signed-off-by: Wolfgang Denk
Cc: Alex Dubov
Cc: Andy Fleming
Cc: Kumar Gala
---
MAINTAINERS |4 -
board/mercury/mpq101/Makefile | 47 --
board/mercury/mpq101/law.c | 52 ---
board/mercury/mpq101/mpq101.c | 129 --
board/mercury/mpq101/tlb.c | 82
board/mercury/mpq101/u-boot.lds | 132 ---
boards.cfg |1 -
doc/README.scrapyard|1 +
8 files changed, 1 insertions(+), 447 deletions(-)
delete mode 100644 board/mercury/mpq101/Makefile
delete mode 100644 board/mercury/mpq101/law.c
delete mode 100644 board/mercury/mpq101/mpq101.c
delete mode 100644 board/mercury/mpq101/tlb.c
delete mode 100644 board/mercury/mpq101/u-boot.lds
diff --git a/MAINTAINERS b/MAINTAINERS
index e648ccf..f5168b0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -134,10 +134,6 @@ Wolfgang Denk
PCIPPC2 MPC750
PCIPPC6 MPC750
-Alex Dubov
-
- mpq101 MPC8548
-
Phil Edworthy
rsk7264 SH7264
diff --git a/board/mercury/mpq101/Makefile b/board/mercury/mpq101/Makefile
deleted file mode 100644
index f9a07cc..000
--- a/board/mercury/mpq101/Makefile
+++ /dev/null
@@ -1,47 +0,0 @@
-#
-# Copyright 2007 Freescale Semiconductor, Inc.
-# (C) Copyright 2001-2006
-# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-include $(TOPDIR)/config.mk
-
-LIB= $(obj)lib$(BOARD).o
-
-COBJS-y+= $(BOARD).o
-COBJS-y+= law.o
-COBJS-y+= tlb.o
-
-SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
-OBJS := $(addprefix $(obj),$(COBJS-y))
-SOBJS := $(addprefix $(obj),$(SOBJS))
-
-$(LIB):$(obj).depend $(OBJS) $(SOBJS)
- $(call cmd_link_o_target, $(OBJS))
-
-#
-
-# defines $(obj).depend target
-include $(SRCTREE)/rules.mk
-
-sinclude $(obj).depend
-
-#
diff --git a/board/mercury/mpq101/law.c b/board/mercury/mpq101/law.c
deleted file mode 100644
index 0e23a6a..000
--- a/board/mercury/mpq101/law.c
+++ /dev/null
@@ -1,52 +0,0 @@
-/*
- * Copyright 2008 Freescale Semiconductor, Inc.
- *
- * (C) Copyright 2000
- * Wolfgang Denk, DENX Software Engineering, w...@denx.de.
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#include
-#include
-#include
-
-/*
- * LAW(Local Access Window) configuration:
- *
- * 0x_ 0x1fff_ DDR SYS_SDRAM_SIZE
- * 0xc000_ 0xdfff_ RapidIO (set elsewhere) 512M
- * 0xe000_ 0xe000_ CCSR(set elsewhere) 1M
- * 0xf000_ 0x_ LBC options + FLASH 256M
- *
- * Notes:
- *CCSRBAR and L2-as-SRAM don't need a configured Local Access Window.
- *If flash is 8M at default position (last 8M), no LAW needed.
- *
- * LAW 0 is reserved for boot mapping
- */
-
-struct law_entry law_table[] = {
- SET_LAW(CONFIG_SYS_SDRAM_BASE, CONFIG_SYS_SDRAM_SIZE_LOG - 1,
- LAW_TRGT_IF_DDR_1),
- SET_LAW(CONFIG_SYS_LBC_OPTION_BASE_PHYS, LAW_SIZE_256M,
- LAW_TRGT_IF_LBC)
-};
-
-int num_law_entr
Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions
Dear Mike Frysinger,
In message
you wrote:
>
> >> +void __assert_fail(const char *assertion, const char *file, unsigned line,
> >> +const char *function)
> >> +{
> >> + /* This will not return */
> >> + panic("%s:%u: %s: Assertion `%s' failed.", file, line, function,
> >> + assertion);
> >> +}
> >
> > Can you please #ifdef it so it doesn't get added for the non-debug
> > case, too?
>
> most arches are building with --gc-sections now which means there is
> no overhead added for them. should we look at fixing the few holdouts
> rather than adding #ifdefs ?
I think Power does use --gc-sections, still I see code size growing.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
All your people must learn before you can reach for the stars.
-- Kirk, "The Gamesters of Triskelion", stardate 3259.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/39] DEBUG: Fix debug macros
Dear Mike Frysinger, In message you wrote: > > > +#define debugX(level, fmt, args...)\ > > + debug_cond((_DEBUG && DEBUG >=3D (level)), fmt, ##args) > > i thought we were just going to punt debugX() ? Yes, please do! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I have never understood the female capacity to avoid a direct answer to any question. -- Spock, "This Side of Paradise", stardate 3417.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions
Dear Mike Frysinger, In message you wrote: > > > __assert_fail() only ever gets used (and thus needs to be compiled in) > > if DEBUG is defined, right? =A0SO why cannot you wrap the code in a > > "#ifdef DEBUG" ? > > people often enable DEBUG on a per file basis. so if i'm debugging > drivers/spi/bfin_spi.c, i put "#define DEBUG" at the top of it. Right you are. I missed that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Landing: a controlled mid-air collision with a planet. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Dear Graeme Russ, In message you wrote: > > > It should be sufficient to send XOFF after receiving a newline > > character. > > And, ergo, we send an XON when entering the readline function This is probably not sufficient, as some commands take direct input. I think both getc() and tstc() should check the XON/XOFF state and send a XON if XOFF was sent before. > Hmm, should we move readline() into console.c Makes sense. > > This should not be necessary. Actually the implementation should not > > need to know about such special cases. > > So how does kermit/ymodem send the XON after the user has entered the > receive command and we have sent the XOFF after the newline? Upon the first getc() that follows? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Marriage is the sole cause of divorce. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Update s3c24x0 timer implementation
Dear Mark Norman,
In message
you wrote:
>
> Since the .rel.text section is required by the relocation code, I
> assume that .bss global variables cannot be used until after
> relocation?
Why do you have to make such assumptions? That's documented
behaviour. Didn't you RTFM?
> After studying several other timer.c files I developed the following
> patch which uses the global data struct to store the global variables.
> I also restructured some of the code based on structure of the other
> timer.c files. I have confirmed it works correctly on the SBC I have.
Then please submit a proper patch - these introductury comments don;lt
belong intot he commit message and shouldbemoved into the comment
section (below the "---" line).
...
> + /* Use PWM Timer 4 because it has no output.
> + * Prescaler is hard fixed at 250, divider at 2.
> + * This generates a Timer clock frequency of 100kHz (@PCLK=50MHz) and
> + * therefore 10us timer ticks.
> + */
Incorrect multiline comment format; please fix globally.
> + /* Prescaler for Timer 4 is 250 */
> + const ulong prescaler = 250;
> + writel((prescaler-1) << 8, &timers->tcfg0);
Please move declarations up. Don't split declarations by comment
lines. Add a blank line between declarations and code.
...
> --- a/arch/arm/include/asm/global_data.h
> +++ b/arch/arm/include/asm/global_data.h
> @@ -38,9 +38,6 @@ typedef struct global_data {
> unsigned long flags;
> unsigned long baudrate;
> unsigned long have_console; /* serial_init() was called */
> -#ifdef CONFIG_PRE_CONSOLE_BUFFER
> - unsigned long precon_buf_idx; /* Pre-Console buffer index */
> -#endif
Make sure not to add such unrelated, incorrect changes!
> -#if defined(CONFIG_POST) || defined(CONFIG_LOGBUFFER)
> - unsigned long post_log_word; /* Record POST activities */
> - unsigned long post_log_res; /* success of POST test */
> - unsigned long post_init_f_time; /* When post_init_f started */
> -#endif
Ditto.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I think there's a world market for about five computers.
-- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] debugX macro
Dear Marek Vasut, In message <201110231646.59439.marek.va...@gmail.com> you wrote: > > I've been doing the debug() cleanup and found the debugX() macro is used only > in > very few patches. Maybe punting it altogether won't hurt. > > The following do use it: > ./board/spc1920/hpi.c > ./drivers/mtd/nand/s3c2410_nand.c > > Opinions? Dump it! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Beware of programmers carrying screwdrivers." - Chip Salzenberg ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Dear Simon Glass, In message <1318742050-2201-2-git-send-email-...@chromium.org> you wrote: > From: Scott Wood > > From: Scott Wood > > This improves the performance of U-Boot when accepting rapid input, > such as pasting a sequence of commands. > > Without this patch, on P4080DS I see a maximum of around 5 lines can > be pasted. With this patch, it handles around 70 lines before lossage, > long enough for most things you'd paste. > > With it enabled, on ppc it's an extra 396 bytes of image size, and 1056 > bytes of BSS. > > ARM note from Simon Glass - ARM code size goes from > 212 to 484 bytes (extra 272 bytes), BSS to 1056 bytes. > > Signed-off-by: Scott Wood I've made up my mind. The reasons why you want to add such code are well understood, but the unsolved and unsolvable issues with this approach are so severe that I don't want to raise false hopes in innocent users. Sorry, but I reject this patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Nature is very un-American. Nature never hurries." - William George Jordan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 1/2] NS16550: trivial code clean for checkpatch
Dear Simon Glass, In message <1318742050-2201-1-git-send-email-...@chromium.org> you wrote: > This removes most checkpatch warnings from the ns16550 driver and its > header. > > Signed-off-by: Simon Glass > --- > drivers/serial/ns16550.c | 37 - > include/ns16550.h| 16 > 2 files changed, 28 insertions(+), 25 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Don't put off for tomorrow what you can do today, because if you enjoy it today you can do it again tomorrow. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] nand_spl_simple: Add omap3 DMA usage to SPL
Dear Simon Schwarz,
In message <1318759804-18688-2-git-send-email-simonschwarz...@gmail.com> you
wrote:
> This adds DMA copy for the nand spl implementation. If CONFIG_SPL_DMA_SUPPORT
> is defined the DMA is used.
>
> Based on DMA driver patch:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/109744/focus=109747
>
> Signed-off-by: Simon Schwarz
> Cc: scottw...@freescale.com
> Cc: s-paul...@ti.com
> ---
> drivers/mtd/nand/nand_spl_simple.c | 185
> ++--
> 1 files changed, 176 insertions(+), 9 deletions(-)
...
> + for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
> + res += omap3_dma_conf_transfer(0, nand_chip.IO_ADDR_R,
> + (uint32_t *)p, CONFIG_SYS_NAND_ECCSIZE/4);
IIUC, drivers/mtd/nand/nand_spl_simple.c is a global, architecture
independent file. However, you are adding OMAP3 specific code here.
If we did the same for all other potentially supported architectures
and SoCs, we'd soon have a serious mess.
Please move architecture / SoC specific code out of such global
files.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There are always alternatives.
-- Spock, "The Galileo Seven", stardate 2822.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress()
Dear Simon Glass, In message <1318790446-24792-3-git-send-email-...@chromium.org> you wrote: > This changes the number 15 as used in boot_stage_progress() to use the > new name provided for it, > > Signed-off-by: Simon Glass ... > - show_boot_progress (15); > + show_boot_progress(BOOTSTAGE_ID_RUN_OS); To maintain consistent operation of the show_boot_progress() implementation, you should also replace all ocurrances of show_boot_progress(-15); with show_boot_progress(-BOOTSTAGE_ID_RUN_OS); Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I was playing poker the other night... with Tarot cards. I got a full house and 4 people died. - Steven Wright ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port
Dear Dirk Eibach, In message <1319101940-780-1-git-send-email-eib...@gdsys.de> you wrote: > Signed-off-by: Dirk Eibach > --- > drivers/gpio/Makefile |1 + > drivers/gpio/pca9698.c | 143 > > include/pca9698.h | 34 +++ > 3 files changed, 178 insertions(+), 0 deletions(-) > create mode 100644 drivers/gpio/pca9698.c > create mode 100644 include/pca9698.h is this some v3 of the patch? If so, where is the change log? What has been changes? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There is is no reason for any individual to have a computer in their home. -- Ken Olsen (President of Digital Equipment Corporation), Convention of the World Future Society, in Boston, 1977 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code
Dear Roy Zang, In message <1319178713-12472-1-git-send-email-tie-fei.z...@freescale.com> you wrote: > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > So remove the duplicate code on platform Ethernet code. > > Signed-off-by: Roy Zang > Cc: Andy Fleming > Cc: Kumar Gala Please change the Subject: so everybody understands what you are doing. "powerpc/fm" is not exactly clear to everybody, and neither is TBIPA. Nor is clear which processors / processor families / boards are affected. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de People are always a lot more complicated than you think. It's very important to remember that. - Terry Pratchett, _Truckers_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E1111 phy config function based on kernel code
Dear Roy Zang, In message <1319178713-12472-2-git-send-email-tie-fei.z...@freescale.com> you wrote: > The original m88es_config() does not do the SGMII mode > initialization and is buggy. Rewrite the function according to > 3.0.6 kernel function m88e_config_init() in drivers/net/phy/marvell.c > > Signed-off-by: Roy Zang > Acked-by: Andy Fleming > Cc: Kumar Gala ... > + /* soft reset */ > + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET); > + do > + reg = phy_read(phydev, MDIO_DEVAD_NONE, MII_BMCR); > + while (reg & BMCR_RESET); ... > + /* soft reset */ > + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET); > + do > + reg = phy_read(phydev, MDIO_DEVAD_NONE, MII_BMCR); > + while (reg & BMCR_RESET); Do we really need this double reset? Also, I dislike the potentially infinite loop here - please add a timeout and an error exit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A supercomputer is a machine that runs an endless loop in 2 seconds. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] spi/eon: add support for new EON spi flash EN25Q32B
Dear Shaohui Xie, In message <1317122494-13562-1-git-send-email-shaohui@freescale.com> you wrote: > Signed-off-by: Shaohui Xie > --- > drivers/mtd/spi/eon.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Certain old men prefer to rise at dawn, taking a cold bath and a long walk with an empty stomach and otherwise mortifying the flesh. They then point with pride to these practices as the cause of their sturdy health and ripe years; the truth being that they are hearty and old, not because of their habits, but in spite of them. The reason we find only robust persons doing this thing is that it has killed all the others who have tried it. - Ambrose Bierce, "The Devil's Dictionary" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000
Dear Heiko Schocher, In message <1317969600-32496-1-git-send-email...@denx.de> you wrote: > commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post > memory support for sdram base != 0x. Fix this. > > Signed-off-by: Heiko Schocher > Cc: Valentin Longchamp > Cc: Holger Brunck > --- > $ /home/git/linux-denx/scripts/checkpatch.pl > 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch > total: 0 errors, 0 warnings, 14 lines checked > > 0001-arm-post-memory-fix-bug-if-sdram-base-0x.patch has no obvious > style problems and is ready for submission. > > post/drivers/memory.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The History of every major Galactic Civilization tends to pass through three distinct and recognizable phases, those of Survival, Inquiry and Sophistication, otherwise known as the How, Why and Where phases. "For instance, the first phase is characterized by the question 'How can we eat?' the second by the question 'Why do we eat?' and the third by the question 'Where shall we have lunch?'" - Hitchhiker's Guide to the Galaxy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3 v2] net: emaclite: Use unsigned long for baseaddr
Dear Michal Simek, In message <1318497803-21874-2-git-send-email-mon...@monstr.eu> you wrote: > Baseaddr should be unsigned long. > > Signed-off-by: Michal Simek > > --- > v2: Fix merge confict - no function change > --- > drivers/net/xilinx_emaclite.c |4 ++-- > include/netdev.h |2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Do not simplify the design of a program if a way can be found to make it complex and wonderful. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3 v2] net: emaclite: Move RX/TX ping pong initialization to
Dear Michal Simek, In message <1318497803-21874-3-git-send-email-mon...@monstr.eu> you wrote: > Init RX/TX ping pong directly from board not in the driver. > > Signed-off-by: Michal Simek > > --- > v2: Fix merge confict - no function change > --- > .../xilinx/microblaze-generic/microblaze-generic.c | 18 -- > drivers/net/xilinx_emaclite.c | 11 --- > include/netdev.h |3 ++- > 3 files changed, 18 insertions(+), 14 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I have never understood the female capacity to avoid a direct answer to any question. -- Spock, "This Side of Paradise", stardate 3417.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Hi Wolfgang, On Oct 24, 2011 4:15 AM, "Wolfgang Denk" wrote: > > Dear Graeme Russ, > > In message < calbutcleg6c30en3n4ljpv1wojjfxwkekhvqymojy8+mgsz...@mail.gmail.com> you wrote: > > [snip] > > > This should not be necessary. Actually the implementation should not > > > need to know about such special cases. > > > > So how does kermit/ymodem send the XON after the user has entered the > > receive command and we have sent the XOFF after the newline? > > Upon the first getc() that follows? And as there will be no corresponding newline, when do we send XOFF? Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] common: fix missing function pointer relocation in fixup_cmdtable()
Dear Daniel Schwierzeck, In message <1318972342-3801-1-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > In commit fa28bd2eef588ec2048ccafedb2b384d5a355858 patch v1 was applied > instead of v2. This is an incremental patch to update that commit > to version 2. > > Signed-off-by: Daniel Schwierzeck > --- > changes for v2: > use correct type cast > > changes for v3: > rebased against current master > incremental patch from v1 to v2 > > one checkpatch.pl warning: > WARNING: line over 80 characters > #38: FILE: common/command.c:483: > + (int (*)(int, char * const [], char, int, char > * []))addr; > > common/command.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The people of Gideon have always believed that life is sacred. That the love of life is the greatest gift ... We are incapable of destroying or interfering with the creation of that which we love so deeply -- life in every form from fetus to developed being. -- Hodin of Gideon, "The Mark of Gideon", stardate 5423.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv10] new tool mkenvimage: generates an env image from an arbitrary config file
Dear David Wagner,
In message <1318612616-16799-1-git-send-email-david.wag...@free-electrons.com>
you wrote:
> This tool takes a key=value configuration file (same as would a `printenv'
> show)
> and generates the corresponding environment image, ready to be flashed.
>
> use case: flash the environment with an external tool
This patch fails to build when I try to run a plain "make
tools/mkenvimage":
tools/mkenvimage.c:35:22: fatal error: compiler.h: No such file or directory
tools/mkenvimage.c:39:24: fatal error: u-boot/crc.h: No such file or
directory
...
> + /* Parse the cmdline */
> + while ((option = getopt(argc, argv, "s:o:rbp:h")) != -1) {
> + switch (option) {
> + case 's':
> + datasize = strtol(optarg, NULL, 0);
...
> + padbyte = strtol(optarg, NULL, 0);
Please add error checking for invalid input formats here.
> + if (datasize == 0) {
> + fprintf(stderr,
> + "Please specify the size of the envrionnment "
> + "partition.\n");
Please don't split that string, and fix the "envrionment" typo.
> + dataptr = malloc(datasize * sizeof(*dataptr));
> + if (!dataptr) {
> + fprintf(stderr, "Can't alloc dataptr.\n");
It might be helpful to know how many bytes you were trying to
allocate.
> + /*
> + * envptr points to the beginning of the actual environment (after the
> + * crc and possible `redundant' bit
s/bit/byte/
> + /* Open the input file ... */
> + if (optind >= argc) {
> + fprintf(stderr, "Please specify an input filename\n");
> + return EXIT_FAILURE;
> + }
Please also allow to use stdin as input when no "" arg is
given.
> + int readlen = sizeof(*envptr) * 2048;
> + txt_fd = STDIN_FILENO;
> +
> + do {
> + filebuf = realloc(filebuf, readlen);
> + readbytes = read(txt_fd, filebuf + filesize, readlen);
> + filesize += readbytes;
> + } while (readbytes == readlen);
This is pretty much inefficient. Consider a size increment of
something like min(readlen, 4096).
Also, realloc() can fail - add error handling.
And read() can fail, too - add error handling.
> + filesize = txt_file_stat.st_size;
> + /* Read the raw input file and transform it */
Why don't you just use mmap() here?
> + if (filesize >= envsize) {
> + fprintf(stderr, "The input file is larger than the "
> + "envrionnment partition size\n");
Please don't split such strings. See CodingStyle:
"However, never break user-visible strings such as printk
messages, because that breaks the ability to grep for them."
Please fix globally.
> + } else if (filebuf[fp] == '#') {
> + if (fp != 0 && filebuf[fp-1] == '\n') {
> + /* This line is a comment, let's skip it */
> + while (fp < txt_file_stat.st_size &&
> +filebuf[fp] != '\n')
> + fp++;
> + } else {
> + envptr[ep++] = filebuf[fp];
> + }
printenv output does not contain any such "comments".
And - aren't you also catching embedded hashes here, like in "serial#"
for example?
...
> +
> + /* Computes the CRC and put it at the beginning of the data */
> + crc = crc32(0, envptr, envsize);
> + targetendian_crc = bigendian ? cpu_to_be32(crc) : cpu_to_le32(crc);
> +
> + memcpy(dataptr, &targetendian_crc, sizeof(uint32_t));
I fail to see where you set the redundant flag?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I am more bored than you could ever possibly be. Go back to work.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] debugX macro
On Sunday, October 23, 2011 07:23:26 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201110231646.59439.marek.va...@gmail.com> you wrote: > > I've been doing the debug() cleanup and found the debugX() macro is used > > only in very few patches. Maybe punting it altogether won't hurt. > > > > The following do use it: > > ./board/spc1920/hpi.c > > ./drivers/mtd/nand/s3c2410_nand.c > > > > Opinions? > > Dump it! Dumped on next iteration of the GCC4.6 cleanups! Cheers ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 01/10] Add getenv_ulong() to read an integer from an environment variable
Dear Simon Glass, In message <1318634718-10548-1-git-send-email-...@chromium.org> you wrote: > This is not an uncommon operation in U-Boot, so let's put it in a common > function. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Fix commit title from getenv_int() to getenv_ulong() > > Changes in v3: > - Move getenv_ulong() function comment into C file > - Add special code for early environment access > > Changes in v4: > - Change getenv_ulong() implementation back to version 2 > - Add a comment as to why this is ok > > common/cmd_nvedit.c | 20 > include/common.h|1 + > 2 files changed, 21 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It must be remembered that there is nothing more difficult to plan, more doubtful of success, nor more dangerous to manage, than the creation of a new system. For the initiator has the enmity of all who would profit by the preservation of the old institutions and merely lukewarm defenders in those who would gain by the new ones. - Machiavelli ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insertions(+), 25 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "There's only one way to have a happy marriage and as soon as I learn what it is I'll get married again." - Clint Eastwood ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/10] avr32: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-4-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/avr32/lib/board.c | 16 +++- > 1 files changed, 3 insertions(+), 13 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Here's a fish hangs in the net like a poor man's right in the law. 'Twill hardly come out." - Shakespeare, Pericles, Act II, Scene 1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/10] blackfin: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-5-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/blackfin/lib/board.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many seconds are there in a year? If I tell you there are 3.155 x 10^7, you won't even try to remember it. On the other hand, who could forget that, to within half a percent, pi seconds is a nanocentury. -- Tom Duff, Bell Labs ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/10] m68k: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-6-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/m68k/lib/board.c | 33 - > 1 files changed, 8 insertions(+), 25 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe does not have laws - it has habits, and habits can be broken. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/10] microblaze: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-7-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/microblaze/lib/board.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de This was an amazing creation using small squares of compressed vegetable matter on which letters were made by means of small carbon particles from a stylus, giving an effect similar to the traditional word-processor screen. It seemed amazingly portable and I never once saw him have to change the batteries. - Terry Pratchett & Stephen Briggs, _The Discworld Companion_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/10] mips: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-8-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/mips/lib/board.c | 14 +++--- > 1 files changed, 3 insertions(+), 11 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Any sufficiently advanced bug is indistinguishable from a feature. - Rich Kulawiec ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/10] powerpc: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-9-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/powerpc/lib/board.c | 33 - > 1 files changed, 8 insertions(+), 25 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The universe is all a spin-off of the Big Bang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/10] sparc: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-10-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/sparc/lib/board.c | 13 +++-- > 1 files changed, 3 insertions(+), 10 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You're dead, Jim. -- McCoy, "Amok Time", stardate 3372.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/10] x86: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-11-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/x86/lib/board.c | 14 +++--- > 1 files changed, 3 insertions(+), 11 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Successful and fortunate crime is called virtue. - Seneca ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)
Dear Simon Glass, is there going to be an updated version of this patch series? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The algorithm to do that is extremely nasty. You might want to mug someone with it." - M. Devine, Computer Science 340 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net/dns.c: Fix endian conversion for big-endian in dns command
Dear Bernhard Kaindl, In message <1318759162-10523-1-git-send-email-bernhard.kai...@gmx.net> you wrote: > From: Bernhard Kaindl > > net/dns.c used endian conversion macros wrongly (shorts in reply > were put swapped into CPU, and then ntohs() was used to swap it > back, which broke on big-endian). > > Fix this by using the correct linux conversion macro for reading > a unaligned short in network byte order: get_unaligned_be16() > Thanks to Mike Frysinger pointing at the best macro to use. > > Tested on big and little endian qemu boards (mips and versatile) > > Signed-off-by: Bernhard Kaindl > Cc: Pieter Voorthuijsen > Cc: Robin Getz > --- > net/dns.c | 20 > 1 files changed, 8 insertions(+), 12 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The Wright Bothers weren't the first to fly. They were just the first not to crash. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/lib/board.c: Call run_post(POST_ROM) before relocating
Dear Bernhard Kaindl, In message <1318759628-10668-1-git-send-email-bernhard.kai...@gmx.net> you wrote: > From: Bernhard Kaindl > > The call to run_post(POST_ROM) which can run the POST memory test > is currently called too late when gd has already been copied to DRAM. > > This results in failure to boot Linux after a POST_ROM memory test > tested all RAM while gd was already relocated to DRAM due to gd being > overwritten by the POST_ROM memory test. > > Support this by moving the call to run_post(POST_ROM) to run earlier, > before U-Boot has started to move data to DRAM (from late board_init_f > to early board_init_f) where DRAM is initialized, but not used yet. > > This allows that an POST memory test can test the whole DRAM, > including the area where the board info struct is located. > > Signed-off-by: Bernhard Kaindl > Cc: Pieter Voorthuijsen > --- > arch/powerpc/lib/board.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Totally illogical, there was no chance. -- Spock, "The Galileo Seven", stardate 2822.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] net: enc28j60_lpc2292: drop unused !NET_MULTI driver
Dear Mike Frysinger, In message <1318795453-18090-2-git-send-email-vap...@gentoo.org> you wrote: > Everyone seems to have converted to the new enc28j60 driver, so drop > this older one which isn't used and doesn't support NET_MULTI. > > Signed-off-by: Mike Frysinger > --- > drivers/net/Makefile |1 - > drivers/net/enc28j60_lpc2292.c | 983 > > 2 files changed, 0 insertions(+), 984 deletions(-) > delete mode 100644 drivers/net/enc28j60_lpc2292.c Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de As a general rule, the freedom of any people can be judged by the volume of their laughter. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/5] net: ns9750: drop !NET_MULTI driver
Dear Mike Frysinger, In message <1318795453-18090-3-git-send-email-vap...@gentoo.org> you wrote: > Only one board uses this driver (ns9750dev), but the board doesn't seem > to have an entry to actually build it in the Makefile/boards.cfg, so just > delete net support from its board config. > > Signed-off-by: Mike Frysinger > --- > drivers/net/Makefile|1 - > drivers/net/ns9750_eth.c| 789 > --- > include/configs/ns9750dev.h |2 - > include/ns9750_eth.h| 298 > 4 files changed, 0 insertions(+), 1090 deletions(-) > delete mode 100644 drivers/net/ns9750_eth.c > delete mode 100644 include/ns9750_eth.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'm frequently appalled by the low regard you Earthmen have for life. -- Spock, "The Galileo Seven", stardate 2822.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] net: s3c4510b_eth: drop unused !NET_MULTI driver
Dear Mike Frysinger, In message <1318795453-18090-4-git-send-email-vap...@gentoo.org> you wrote: > No boards appear to use this driver, and it doesn't support NET_MULTI, > so punt the old driver. > > Signed-off-by: Mike Frysinger > --- > drivers/net/Makefile |1 - > drivers/net/s3c4510b_eth.c | 241 --- > drivers/net/s3c4510b_eth.h | 302 > > 3 files changed, 0 insertions(+), 544 deletions(-) > delete mode 100644 drivers/net/s3c4510b_eth.c > delete mode 100644 drivers/net/s3c4510b_eth.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You see things; and you say ``Why?'' But I dream things that never were; and I say ``Why not?'' - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] net: sc589: drop unused !NET_MULTI driver
Dear Mike Frysinger, In message <1318795453-18090-5-git-send-email-vap...@gentoo.org> you wrote: > No boards appear to use this driver, and it doesn't support NET_MULTI, > so punt the old driver. > > Signed-off-by: Mike Frysinger > --- > drivers/net/3c589.c | 517 > -- > drivers/net/3c589.h | 435 -- > drivers/net/Makefile |1 - > 3 files changed, 0 insertions(+), 953 deletions(-) > delete mode 100644 drivers/net/3c589.c > delete mode 100644 drivers/net/3c589.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Any technology distinguishable from magic is insufficiently advanced. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/5] net: xilinx_enet: drop unused !NET_MULTI driver
Dear Mike Frysinger, In message <1318795453-18090-6-git-send-email-vap...@gentoo.org> you wrote: > This driver doesn't support the NET_MULTI framework, and I can't find > any boards/configs/files that reference this subdir, so punt it all. > > Signed-off-by: Mike Frysinger > --- > board/xilinx/xilinx_enet/emac_adapter.c | 165 > board/xilinx/xilinx_enet/xemac.c | 844 -- > board/xilinx/xilinx_enet/xemac.h | 673 --- > board/xilinx/xilinx_enet/xemac_g.c| 60 -- > board/xilinx/xilinx_enet/xemac_i.h| 207 - > board/xilinx/xilinx_enet/xemac_intr.c | 402 - > board/xilinx/xilinx_enet/xemac_intr_dma.c | 1344 > - > board/xilinx/xilinx_enet/xemac_l.h| 462 -- > board/xilinx/xilinx_enet/xemac_options.c | 318 --- > board/xilinx/xilinx_enet/xemac_polled.c | 482 --- > 10 files changed, 0 insertions(+), 4957 deletions(-) > delete mode 100644 board/xilinx/xilinx_enet/emac_adapter.c > delete mode 100644 board/xilinx/xilinx_enet/xemac.c > delete mode 100644 board/xilinx/xilinx_enet/xemac.h > delete mode 100644 board/xilinx/xilinx_enet/xemac_g.c > delete mode 100644 board/xilinx/xilinx_enet/xemac_i.h > delete mode 100644 board/xilinx/xilinx_enet/xemac_intr.c > delete mode 100644 board/xilinx/xilinx_enet/xemac_intr_dma.c > delete mode 100644 board/xilinx/xilinx_enet/xemac_l.h > delete mode 100644 board/xilinx/xilinx_enet/xemac_options.c > delete mode 100644 board/xilinx/xilinx_enet/xemac_polled.c Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Man is the best computer we can put aboard a spacecraft ... and the only one that can be mass produced with unskilled labor. - Wernher von Braun ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 3/3] mkimage: adding support for Davinci AIS image
Dear Stefano Babic, In message <1318846063-9496-1-git-send-email-sba...@denx.de> you wrote: > Some Davinci processors supports the Application > Image Script (AIS) boot process. The patch adds the generation > of the AIS image inside the mkimage tool to make possible > to generate a bootable U-boot without external tools > (TI Davinci AIS Generator). > > Signed-off-by: Stefano Babic > CC: Wolfgang Denk > --- > > Changes since V2: > - rebased on mainline and sort uimage_type list (Wolfgang Denk) > > Changes since V1: > - removed warning in gcc 4.6 iwhen -Wunused-but-set-variable is set > - drop remained warnings raised by checkpatch > > > common/image.c |9 +- > include/image.h |1 + > tools/Makefile |4 +- > tools/aisimage.c | 451 > ++ > tools/aisimage.h | 97 > tools/mkimage.c |2 + > tools/mkimage.h |1 + > 7 files changed, 560 insertions(+), 5 deletions(-) > create mode 100644 tools/aisimage.c > create mode 100644 tools/aisimage.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Plan to throw one away. You will anyway." - Fred Brooks, "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 10/10] arm, davinci: add cam_enc_4xx support
On 10/21/2011 08:32 AM, Heiko Schocher wrote: > - DM368 SOC > - booting with spl not with UBL from TI > - before loading u-boot from NAND into RAM, test > the RAM with the post memory test. If error > is found, switch all LEDs on and halt system. > - SPI Flash > Dataflash Typ: M25PE80 > - Ethernet DM9161BI > - MMC > - USB > > Signed-off-by: Heiko Schocher > Cc: Sandeep Paulraj > Cc: Albert ARIBAUD > --- > changes for v2: > - rebase to TOT > - adapted to new spl framework > - add USB support > - MDIO Clk only 1MHz > - LED: set LED in spl code, and clear them after 1 second > - add "bdinfo" command > - add nandrbl board specific command for switching > between rbl and uboot ecc calculation algorithm > > changes for v3: > - add CONFIG_SYS_NAND_HW_ECC_OOBFIRST > > MAINTAINERS |1 + > board/ait/cam_enc_4xx/Makefile | 52 > board/ait/cam_enc_4xx/cam_enc_4xx.c | 455 > ++ > board/ait/cam_enc_4xx/config.mk | 13 + > board/ait/cam_enc_4xx/u-boot-spl.lds | 73 ++ > board/ait/cam_enc_4xx/ublimage.cfg | 48 > boards.cfg |1 + > doc/README.davinci.nand_spl | 141 +++ > include/configs/cam_enc_4xx.h| 450 + > 9 files changed, 1234 insertions(+), 0 deletions(-) > create mode 100644 board/ait/cam_enc_4xx/Makefile > create mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c > create mode 100644 board/ait/cam_enc_4xx/config.mk > create mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds > create mode 100644 board/ait/cam_enc_4xx/ublimage.cfg > create mode 100644 doc/README.davinci.nand_spl > create mode 100644 include/configs/cam_enc_4xx.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index bb95e6d..3fe6ade 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -417,6 +417,7 @@ Georg Schardt > > Heiko Schocher > > + cam_enc_4xx davinci/ARM926EJS > charon MPC5200 > ids8247 MPC8247 > jupiter MPC5200 > diff --git a/board/ait/cam_enc_4xx/Makefile b/board/ait/cam_enc_4xx/Makefile > new file mode 100644 > index 000..4804597 > --- /dev/null > +++ b/board/ait/cam_enc_4xx/Makefile > @@ -0,0 +1,52 @@ > +# > +# (C) Copyright 2000, 2001, 2002 > +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. > +# > +# Copyright (C) 2007 Sergey Kubushyn > +# > +# See file CREDITS for list of people who contributed to this > +# project. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation; either version 2 of > +# the License, or (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write to the Free Software > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, > +# MA 02111-1307 USA > +# > + > +include $(TOPDIR)/config.mk > + > +LIB = $(obj)lib$(BOARD).o > + > +COBJS:= $(BOARD).o > +SOBJS:= > + > +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > +OBJS := $(addprefix $(obj),$(COBJS)) > +SOBJS:= $(addprefix $(obj),$(SOBJS)) > + > +$(LIB): $(obj).depend $(OBJS) $(SOBJS) > + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) > + > +clean: > + rm -f $(SOBJS) $(OBJS) > + > +distclean: clean > + rm -f $(LIB) core *.bak $(obj).depend I don't think you should be adding this. Please, see the commit 464c79207c89f247f97b344495924eabb0c9738e (punt unused clean/distclean targets) by Mike. > + > +# > +# This is for $(obj).depend target > +include $(SRCTREE)/rules.mk > + > +sinclude $(obj).depend > + > +# > diff --git a/board/ait/cam_enc_4xx/cam_enc_4xx.c > b/board/ait/cam_enc_4xx/cam_enc_4xx.c > new file mode 100644 > index 000..059a08a > --- /dev/null > +++ b/board/ait/cam_enc_4xx/cam_enc_4xx.c > @@ -0,0 +1,455 @@ > +/* > + * Copyright (C) 2009 Texas Instruments Incorporated > + * > + * Copyright (C) 2011 > + * Heiko Schocher, DENX Software Engineering, h...@denx.de. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads
Dear Graeme Russ, In message you wrote: > > > > So how does kermit/ymodem send the XON after the user has entered the > > > receive command and we have sent the XOFF after the newline? > > > > Upon the first getc() that follows? > > And as there will be no corresponding newline, when do we send XOFF? Never? Note that kermit / ymodem / S-record download etc. all don't have any issues with sendign characters back-to-back at line speed. Problems happen only with multi-line input, so it is perfectly fine to handle just that - at the root cause, i. e. when input turns into multi-line input. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Include the success of others in your dreams for your own success. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] NS16550: buffer reads
Hi Wolfgang, On Monday, October 24, 2011, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message you wrote: >> >> > > So how does kermit/ymodem send the XON after the user has entered the >> > > receive command and we have sent the XOFF after the newline? >> > >> > Upon the first getc() that follows? >> >> And as there will be no corresponding newline, when do we send XOFF? > > Never? Note that kermit / ymodem / S-record download etc. all don't > have any issues with sendign characters back-to-back at line speed. > > Problems happen only with multi-line input, so it is perfectly fine > to handle just that - at the root cause, i. e. when input turns into > multi-line input. Can the U-Boot command line handle multiple commands per line (delimited by ; for example) If so, could it not be possible that a Kermit/ymodem command followed by a time consuming command on the same line cause lost input? Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insertions(+), 25 deletions(-) Urgh... This breaks almost all ARM boards like this: Configuring for a320evb board... board.c: In function 'board_init_r': board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.) make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1 make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2 Didn't you run MAKELL? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ADVISORY: There is an Extremely Small but Nonzero Chance That, Through a Process Know as "Tunneling," This Product May Spontaneously Disappear from Its Present Location and Reappear at Any Random Place in the Universe, Including Your Neighbor's Domicile. The Manufacturer Will Not Be Responsible for Any Damages or Inconvenience That May Result. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arch/arm/lib/board.c: fix build error
Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" introduced a build error for all ARM boards with network support: board.c: In function 'board_init_r': board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported only once board.c:569: error: for each function it appears in.) Fix it. Signed-off-by: Wolfgang Denk --- arch/arm/lib/board.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index c764844..367cf6b 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -441,6 +441,9 @@ void board_init_r(gd_t *id, ulong dest_addr) #if !defined(CONFIG_SYS_NO_FLASH) ulong flash_size; #endif +#if defined(CONFIG_CMD_NET) + char *s; +#endif gd = id; -- 1.7.6.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning
Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(),
strtoul" instroduced a build warning for some PPC systems:
board.c: In function 'board_init_r':
board.c:626: warning: unused variable 's'
Fix it.
Signed-off-by: Wolfgang Denk
---
arch/powerpc/lib/board.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c
index 6cb0ed6..aff1a0c 100644
--- a/arch/powerpc/lib/board.c
+++ b/arch/powerpc/lib/board.c
@@ -623,10 +623,11 @@ void board_init_f (ulong bootflag)
*/
void board_init_r (gd_t *id, ulong dest_addr)
{
- char *s;
bd_t *bd;
ulong malloc_start;
-
+#if defined(CONFIG_SYS_FLASH_CHECKSUM) || defined(CONFIG_CMD_NET)
+ char *s;
+#endif
#ifndef CONFIG_SYS_NO_FLASH
ulong flash_size;
#endif
--
1.7.6.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 14/17 V4] M28: Add MMC SPL
Hi Marek, On Sat, Oct 22, 2011 at 12:44:23AM +0200, Marek Vasut wrote: > board/denx/m28evk/power_init.c | 913 > ++ Shouldn't the power library functions go into arch/arm/cpu/arm926ejs/mx28/? They are not m28evk specific and should be re-usable by other MX28 boards. rsc -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] NS16550: buffer reads
Dear Graeme Russ, In message you wrote: > > > Problems happen only with multi-line input, so it is perfectly fine > > to handle just that - at the root cause, i. e. when input turns into > > multi-line input. > > Can the U-Boot command line handle multiple commands per line (delimited by > ; for example) Yes, it can. > If so, could it not be possible that a Kermit/ymodem command followed by a > time consuming command on the same line cause lost input? I don't think so. All serial transfers use a protocol - and when the transfer is complete, it does not matter any more, because no more data are flowing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de History tends to exaggerate. -- Col. Green, "The Savage Curtain", stardate 5906.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] arm926ejs: add NXP LPC32x0 cpu series support
Hi Albert, On 22.10.2011 02:31, Albert ARIBAUD wrote: > Hi Vladimir, > > Le 18/10/2011 17:55, Vladimir Zapolskiy a écrit : >> This change adds initial support for NXP LPC32x0 SoC series. >> >> Signed-off-by: Vladimir Zapolskiy >> --- >> Changes from v2 to v3: >> * checkpatch.pl reports zero errors and warnings >> >> Changes from v1 to v2: >> * BIT(n) and SBF(s, v) macro are not used anymore >> * removed NS16550 and 14-clock UART definitions from uart.h >> * added devices.c file, which contains standard UART preinitialization >> routine >> * added get_serial_clock() function, it returns actual frequency of >> UART clock >> * __udelay() realization is simplified, no need of interrupt handling > > As it stands, this is dead code until some board uses it; I imagine you > have board waiting for this support. Can you submit the SoC and board > code as a patch set? This way, it will be obvious for all that the SoC > code in this patch has actual use. you're right, I have a board to make support for. However I presume that U-boot maintainers won't be happy to include a board with CONFIG_ENV_IS_NOWHERE, and unfortunately flash driver isn't yet ready for publishing. I'd like to get an advice, if you think that weakly supported but working U-boot on the board has chances to be included to arm-next I can send the patchset right now for review, otherwise I'll spend some time (one week approximately) to finish NAND driver. -- With best wishes, Vladimir ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] (no subject)
ELOAN FINANCE is a consulting group for international debt and equity project finance in addition to commercial mortgage finance in the WORLDWIDE market. We are certified loan lender and offer secured loans to individuals and companies at 2% low interest.We are focused on attempting to fill the void that exists where there are limited options for suitable funding of major corporate and real estate projects, and especially where the request is large. If you are interested in our offer please state briefly the following information to the management FIRST INFORMATION NEEDED ARE: Full Name:... Location(Address):. Marital status:... Contact Phone numbers: Amount Needed:. Contact E-mail:. Occupation:.. Loan Duration Annual Income .. Brief Self Description... Loan Purpose Contact us with this Email:eloan_agency...@live.co.uk Best Regards Mr.Benson Smith General Consultant Email: eloan_agency...@live.co.uk___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] NS16550: buffer reads
Hi Wolfgang, On Monday, October 24, 2011, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message < calbutcjh8bvzfvh14d83wr2jov89o9jvjo9vzzb7r_zgkzz...@mail.gmail.com> you wrote: >> >> > Problems happen only with multi-line input, so it is perfectly fine >> > to handle just that - at the root cause, i. e. when input turns into >> > multi-line input. >> >> Can the U-Boot command line handle multiple commands per line (delimited by >> ; for example) > > Yes, it can. > >> If so, could it not be possible that a Kermit/ymodem command followed by a >> time consuming command on the same line cause lost input? > > I don't think so. All serial transfers use a protocol - and when the > transfer is complete, it does not matter any more, because no more > data are flowing. My point is that the transfer turns off flow control - When the transfer completes, flow control will be off when the next command begins to run. If the next command is one which takes a long time to execute and it is on the same line as the transfer command (i.e. no \r to send XOFF) and the user types something then that input can be lost. I think the solution is fairly trivial though - During the processing of commands entered via readline(), cause an XOFF to be sent each time (i.e. immediately before) the command string is dispatched a to the command processor just in case the previous command called getc() (and thus caused an XON to be sent) Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arm: Correct build error introduced by getenv_ulong() patch
Commit dc8bbea removed a local variable that is used in most ARM boards.
Since we want to avoid an 'unused variable' warning with later compilers,
and the #ifdef logic of whether this variable is required is bit painful,
this declares the variable local to the block of code that needs it.
Signed-off-by: Simon Glass
---
arch/arm/lib/board.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index c764844..3c147d1 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -477,6 +477,8 @@ void board_init_r(gd_t *id, ulong dest_addr)
flash_size = flash_init();
if (flash_size > 0) {
# ifdef CONFIG_SYS_FLASH_CHECKSUM
+ char *s;
+
print_size(flash_size, "");
/*
* Compute and print flash CRC if flashchecksum is set to 'y'
@@ -566,9 +568,13 @@ void board_init_r(gd_t *id, ulong dest_addr)
/* Initialize from environment */
load_addr = getenv_ulong("loadaddr", 16, load_addr);
#if defined(CONFIG_CMD_NET)
- s = getenv("bootfile");
- if (s != NULL)
- copy_filename(BootFile, s, sizeof(BootFile));
+ {
+ char *s;
+
+ s = getenv("bootfile");
+ if (s != NULL)
+ copy_filename(BootFile, s, sizeof(BootFile));
+ }
#endif
#ifdef BOARD_LATE_INIT
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:49 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: >> This changes the board code to use the new getenv_ulong() function. >> >> Signed-off-by: Simon Glass >> --- >> arch/arm/lib/board.c | 36 +++- >> 1 files changed, 11 insertions(+), 25 deletions(-) > > Urgh... > > This breaks almost all ARM boards like this: > > Configuring for a320evb board... > board.c: In function 'board_init_r': > board.c:569: error: 's' undeclared (first use in this function) > board.c:569: error: (Each undeclared identifier is reported only once > board.c:569: error: for each function it appears in.) > make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1 > make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2 Sorry, I have sent a patch for this. > > > Didn't you run MAKELL? No these pre-date my getting that running (with Mike's help) and I didn't think to go back to this series. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > ADVISORY: There is an Extremely Small but Nonzero Chance That, > Through a Process Know as "Tunneling," This Product May Spontaneously > Disappear from Its Present Location and Reappear at Any Random Place > in the Universe, Including Your Neighbor's Domicile. The Manufacturer > Will Not Be Responsible for Any Damages or Inconvenience That May > Result. > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/arm/lib/board.c: fix build error
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:51 PM, Wolfgang Denk wrote: > Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" > introduced a build error for all ARM boards with network support: > > board.c: In function 'board_init_r': > board.c:569: error: 's' undeclared (first use in this function) > board.c:569: error: (Each undeclared identifier is reported only once > board.c:569: error: for each function it appears in.) > > Fix it. This might fix all boards if they have both net and flash, or neither. But I sent a patch which tries to handle the case where we have one but not the other. (I suspect the PPC warning might be similar, but will wait until I have done a MAKEALL before commenting on that) Regards, Simon > > Signed-off-by: Wolfgang Denk > --- > arch/arm/lib/board.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c > index c764844..367cf6b 100644 > --- a/arch/arm/lib/board.c > +++ b/arch/arm/lib/board.c > @@ -441,6 +441,9 @@ void board_init_r(gd_t *id, ulong dest_addr) > #if !defined(CONFIG_SYS_NO_FLASH) > ulong flash_size; > #endif > +#if defined(CONFIG_CMD_NET) > + char *s; > +#endif > > gd = id; > > -- > 1.7.6.2 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress()
Hi Wolfgang, On Sun, Oct 23, 2011 at 11:44 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318790446-24792-3-git-send-email-...@chromium.org> you wrote: >> This changes the number 15 as used in boot_stage_progress() to use the >> new name provided for it, >> >> Signed-off-by: Simon Glass > ... > >> - show_boot_progress (15); >> + show_boot_progress(BOOTSTAGE_ID_RUN_OS); > > To maintain consistent operation of the show_boot_progress() > implementation, you should also replace all ocurrances of > > show_boot_progress(-15); > with > show_boot_progress(-BOOTSTAGE_ID_RUN_OS); I couldn't find any of those - perhaps I should chosen a better example since I did mean to ask about those -ve numbers. IMHO we would be better off with a function call like show_boot_error(BOOTSTAGE_ID_RUN_OS); even if this is a macro. It is more explicit about the fact that we are reporting an error. Does that sound ok? Regards, Simon > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > I was playing poker the other night... with Tarot cards. I got a full > house and 4 people died. - Steven Wright > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)
Hi Wolfgang, On Sun, Oct 23, 2011 at 1:56 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > is there going to be an updated version of this patch series? There was a request to move the check_fdt function into the fdtdec library, and I think it makes sense. So I will do that and send an update. I don't have any other changes ATM. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > "The algorithm to do that is extremely nasty. You might want to mug > someone with it." - M. Devine, Computer Science 340 > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E1111 phy config function based on kernel code
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 3:42 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Kumar Gala > Subject: Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E phy config > function based on kernel code > > Dear Roy Zang, > > In message <1319178713-12472-2-git-send-email-tie-fei.z...@freescale.com> you > wrote: > > The original m88es_config() does not do the SGMII mode > > initialization and is buggy. Rewrite the function according to > > 3.0.6 kernel function m88e_config_init() in drivers/net/phy/marvell.c > > > > Signed-off-by: Roy Zang > > Acked-by: Andy Fleming > > Cc: Kumar Gala > ... > > + /* soft reset */ > > + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET); > > + do > > + reg = phy_read(phydev, MDIO_DEVAD_NONE, MII_BMCR); > > + while (reg & BMCR_RESET); > ... > > + /* soft reset */ > > + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET); > > + do > > + reg = phy_read(phydev, MDIO_DEVAD_NONE, MII_BMCR); > > + while (reg & BMCR_RESET); > > Do we really need this double reset? The MV88E user manual requests "any changes to HWCFG_MODE of Extended PHY Specific Status Register must be followed by software reset to take effect" >From the code flow, double reset is only for RTBI mode, which really doubly >changes the HWCFG_MODE bits. > > Also, I dislike the potentially infinite loop here - please add a > timeout and an error exit. This makes sense. Will update and resend. Thanks. Roy > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > A supercomputer is a machine that runs an endless loop in 2 seconds. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 3:37 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Roy Zang, > > In message <1319178713-12472-1-git-send-email-tie-fei.z...@freescale.com> you > wrote: > > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > > > So remove the duplicate code on platform Ethernet code. > > > > Signed-off-by: Roy Zang > > Cc: Andy Fleming > > Cc: Kumar Gala > > Please change the Subject: so everybody understands what you are > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > TBIPA. > > Nor is clear which processors / processor families / boards are > affected. Per my understand, subject is a summary of the patch. poweper/fm and TBIPA should almost be OK for the subject. I can point out that the code is about the network code in subject. for example, Subject: powerpc/fm: remove the TBIPA setting on platform network related code Then I add more in the patch description to explain fm, TBIPA, processors, processor families/boards affected. Thanks. Roy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] Flatten and solidify block_dev_desc layout
Dear Wolfgang Denk, I guess I have to put this patchset on hold. I will get you back if we could proceed with this patchset. Regards, Che-Liang On Sat, Oct 22, 2011 at 3:09 AM, Wolfgang Denk wrote: > Dear Che-Liang Chiou, > > In message <1319178708-10881-2-git-send-email-clch...@chromium.org> you wrote: >> The block_dev_desc struct has #ifdef on lba48 and variable-size on lba >> and so its layout varies from config to config. At least part_efi.c has >> partially complained about this. >> >> This patch makes lba48 be always defined and lba be fixed to largest >> size that an LBA would need so that the block_dev_desc layout would be >> an invariant with respect to configurations. >> >> Doing so would waste a few extra bytes per struct block_dev_desc, which >> I believe is not critical. > > How much exactly is "a few bytes"? > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > As long as we're going to reinvent the wheel again, we might as well > try making it round this time. - Mike Dennison > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] api: extend accessible set of block device attributes
Hi Detlev, Oops, I did not know it is intentionally to keep the external apps API as it is now. I am working on an open source secure bootloader based on U-Boot. Mostly I wrote boot logic (by boot logic I mean prompting user and listing available devices sort of things). If you see U-Boot as a platform, you can think of my project as an application running on top of U-Boot, except that my application is statically linked with U-Boot. The boot logic is running on ARM and x86. Through the project I have learned that certain APIs would be helpful, such as enumerating all available block device and drawing bitmaps on screen regardless of which driver (video or LCD) you are using. It was probably a misleading finding when I searched the code base: I saw only the external apps API implemented an API for enumerating available block device. So I thought improving the external apps API was the right place to go. Alternatively (if not go the external apps API), we could have like common/cmd_enum_block_dev.c that does what I am planning to do, and I am happy to do this. What do you think? Regards, Che-Liang On Sat, Oct 22, 2011 at 12:06 AM, Detlev Zundel wrote: > Hi, > >> struct device_info in api_public.h defined its own subset of attributes >> of block_dev_desc, which limits the capability of external apps. >> >> This patch set let external apps access the same set of block device >> attributes as U-Boot. > > Generally speaking, we are intentionally limiting our API to external > applications. It should be easier to extend U-Boot itself (and > everybody will profit from the new code under a free license) rather > than writing proprietary applications. > > Can you pleas tell us what the intention of the extension is? We surely > will not accept patches gradually exposing all of the U-Boot internals > through the API and paving the way for proprietary applications. So > every extension has to be balanced and discussed. > > Thanks > Detlev > > -- > Insider comment on Microsoft releasing Linux Hyper-V driver code under GPLv2: > "It looks like hell just froze over." > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc: Correct build warning introduced by getenv_ulong() patch
Commit 1272592 introduced a warning since the variable 's' is no longer
always used, depending on the CONFIG options.
Signed-off-by: Simon Glass
---
arch/powerpc/lib/board.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c
index 6cb0ed6..508075f 100644
--- a/arch/powerpc/lib/board.c
+++ b/arch/powerpc/lib/board.c
@@ -623,7 +623,6 @@ void board_init_f (ulong bootflag)
*/
void board_init_r (gd_t *id, ulong dest_addr)
{
- char *s;
bd_t *bd;
ulong malloc_start;
@@ -727,6 +726,8 @@ void board_init_r (gd_t *id, ulong dest_addr)
flash_size = 0;
} else if ((flash_size = flash_init ()) > 0) {
# ifdef CONFIG_SYS_FLASH_CHECKSUM
+ char *s;
+
print_size (flash_size, "");
/*
* Compute and print flash CRC if flashchecksum is set to 'y'
@@ -927,8 +928,11 @@ void board_init_r (gd_t *id, ulong dest_addr)
/* Initialize from environment */
load_addr = getenv_ulong("loadaddr", 16, load_addr);
#if defined(CONFIG_CMD_NET)
- if ((s = getenv ("bootfile")) != NULL) {
- copy_filename (BootFile, s, sizeof (BootFile));
+ {
+ char *s = getenv("bootfile");
+
+ if (s != NULL)
+ copy_filename(BootFile, s, sizeof(BootFile));
}
#endif
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch
Commit dc8bbea removed a local variable that is used in most ARM boards.
Since we want to avoid an 'unused variable' warning with later compilers,
and the #ifdef logic of whether this variable is required is bit painful,
this declares the variable local to the block of code that needs it.
Signed-off-by: Simon Glass
---
Changes in v2:
- Tidy up to call getenv() in declaration
arch/arm/lib/board.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index c764844..7434b34 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -477,13 +477,14 @@ void board_init_r(gd_t *id, ulong dest_addr)
flash_size = flash_init();
if (flash_size > 0) {
# ifdef CONFIG_SYS_FLASH_CHECKSUM
+ char *s = getenv("flashchecksum");
+
print_size(flash_size, "");
/*
* Compute and print flash CRC if flashchecksum is set to 'y'
*
* NOTE: Maybe we should add some WATCHDOG_RESET()? XXX
*/
- s = getenv("flashchecksum");
if (s && (*s == 'y')) {
printf(" CRC: %08X", crc32(0,
(const unsigned char *) CONFIG_SYS_FLASH_BASE,
@@ -566,9 +567,12 @@ void board_init_r(gd_t *id, ulong dest_addr)
/* Initialize from environment */
load_addr = getenv_ulong("loadaddr", 16, load_addr);
#if defined(CONFIG_CMD_NET)
- s = getenv("bootfile");
- if (s != NULL)
- copy_filename(BootFile, s, sizeof(BootFile));
+ {
+ char *s = getenv("bootfile");
+
+ if (s != NULL)
+ copy_filename(BootFile, s, sizeof(BootFile));
+ }
#endif
#ifdef BOARD_LATE_INIT
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning
Hi Wolfgang,
On Sun, Oct 23, 2011 at 2:58 PM, Wolfgang Denk wrote:
> Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(),
> strtoul" instroduced a build warning for some PPC systems:
>
> board.c: In function 'board_init_r':
> board.c:626: warning: unused variable 's'
>
> Fix it.
>
> Signed-off-by: Wolfgang Denk
I sent an alternative to this but they are roughly equivalent so:
Acked-by: Simon Glass
Thanks for fixing this.
Regards,
Simon
> ---
> arch/powerpc/lib/board.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/lib/board.c
> index 6cb0ed6..aff1a0c 100644
> --- a/arch/powerpc/lib/board.c
> +++ b/arch/powerpc/lib/board.c
> @@ -623,10 +623,11 @@ void board_init_f (ulong bootflag)
> */
> void board_init_r (gd_t *id, ulong dest_addr)
> {
> - char *s;
> bd_t *bd;
> ulong malloc_start;
> -
> +#if defined(CONFIG_SYS_FLASH_CHECKSUM) || defined(CONFIG_CMD_NET)
> + char *s;
> +#endif
> #ifndef CONFIG_SYS_NO_FLASH
> ulong flash_size;
> #endif
> --
> 1.7.6.2
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] Add tftpput command for uploading files over network
Hi Albert, On Sat, Oct 22, 2011 at 9:15 AM, Simon Glass wrote: > Hi Albert, > > On Sat, Oct 22, 2011 at 1:21 AM, Albert ARIBAUD > wrote: >> Le 22/10/2011 06:51, Simon Glass a écrit : >>> >>> The tftpboot command permits reading of files over a network interface >>> using the Trivial FTP protocol. This patch series adds the ability to >>> transfer files the other way. >>> >>> Why is this useful? >>> >>> - Uploading boot time data to a server >>> - Uploading profiling information >>> - Uploading large mounts of data for comparison / checking on a host >>> (e.g. use tftpput and ghex2 instead of the 'md' command) >> >> Especially I find it interesting for backing up things like MTD and small >> disk files (not partitions, though). Most of my work currently is trying to >> bring mainline U-Boot support to existing boards with bad U-Boot >> implementations, and being able to backup things from U-Boot (as opposed to >> having to set up NFS root and Linux boot) would definitely be a plus. >> >>> Mostly the existing code can be re-used and I have tried to avoid too >>> much refactoring or cleaning up. >> >> :) >> >>> The feature is activated by the CONFIG_CMD_TFTPPUT option. >>> >>> This has been very lightly tested on a Seaboard with a USB network >>> adaptor. I don't think it handles block number overflow. >> >> What size does this limit transfers to? > > I think about 1468 * 65535 - around 95MB - it's fairly easy to fix > just by copying out the existing tftp get wrap code. I put it in the > commit message so it wouldn't get lost. > >> >>> Simon Glass (8): >>> Move simple_itoa to vsprintf >>> Add setenv_uint() and setenv_addr() >>> tftpput: Rename TFTP to TFTPGET >>> tftpput: move common code into separate functions >>> tftpput: support selecting get/put for tftp >>> tftpput: add save_addr and save_size global variables >>> tftpput: implement tftp logic >>> tftpput: add tftpput command >> >> Many U-Boot environments use 'tftp' as a shorthand to tftpboot. Did you >> verify that this is not broken by the introduction of 'tftpput'? >> >> Also, I'd be happy to test this if a branch exists that already holds these >> commits. > > I will see if I can organise one at Denx. Thanks to Wolfgang I have something you can try: git clone git://git.denx.de/u-boot-simonglass git checkout us-tftp Regards, Simon > > Regards, > Simon > >> >> Amicalement, >> -- >> Albert. >> > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/39] DEBUG: Fix debug macros
Hi Marek,
On Fri, Oct 21, 2011 at 5:16 PM, Marek Vasut wrote:
> The current implementation of debug doesn't play well with GCC4.6.
> This implementation also fixes GCC4.6 complaints about unused variables
> while maintaining code size.
>
> Signed-off-by: Mike Frysinger
> Signed-off-by: Marek Vasut
> Cc: Wolfgang Denk
> Cc: Simon Glass
> ---
> include/common.h | 20
> 1 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/include/common.h b/include/common.h
> index eb19a44..c3b23551 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -116,20 +116,24 @@ typedef volatile unsigned char vu_char;
> #include
> #include
>
> -#ifdef DEBUG
> -#define debug(fmt,args...) printf (fmt ,##args)
> -#define debugX(level,fmt,args...) if (DEBUG>=level) printf(fmt,##args);
> -#else
> -#define debug(fmt,args...)
> -#define debugX(level,fmt,args...)
> -#endif /* DEBUG */
> -
> #ifdef DEBUG
> # define _DEBUG 1
> #else
> # define _DEBUG 0
> #endif
>
> +#define debug_cond(cond, fmt, args...) \
Yes this is much nicer. Could perhaps add a little comment about how
to use this and to avoid putting debug() inside #ifdef?
> + do { \
> + if (cond) \
> + printf(fmt, ##args); \
> + } while (0)
> +
> +#define debug(fmt, args...) \
> + debug_cond(_DEBUG, fmt, ##args)
> +
> +#define debugX(level, fmt, args...) \
> + debug_cond((_DEBUG && DEBUG >= (level)), fmt, ##args)
> +
> /*
> * An assertion is run-time check done in debug mode only. If DEBUG is not
> * defined then it is skipped. If DEBUG is defined and the assertion fails,
> --
> 1.7.6.3
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] NS16550: buffer reads
Hi, On Sun, Oct 23, 2011 at 4:30 PM, Graeme Russ wrote: > Hi Wolfgang, > > On Monday, October 24, 2011, Wolfgang Denk wrote: >> Dear Graeme Russ, >> >> In message < > calbutcjh8bvzfvh14d83wr2jov89o9jvjo9vzzb7r_zgkzz...@mail.gmail.com> you > wrote: >>> >>> > Problems happen only with multi-line input, so it is perfectly fine >>> > to handle just that - at the root cause, i. e. when input turns into >>> > multi-line input. >>> >>> Can the U-Boot command line handle multiple commands per line (delimited > by >>> ; for example) >> >> Yes, it can. >> >>> If so, could it not be possible that a Kermit/ymodem command followed by > a >>> time consuming command on the same line cause lost input? >> >> I don't think so. All serial transfers use a protocol - and when the >> transfer is complete, it does not matter any more, because no more >> data are flowing. > > My point is that the transfer turns off flow control - When the transfer > completes, flow control will be off when the next command begins to run. > If the next command is one which takes a long time to execute and it is on > the same line as the transfer command (i.e. no \r to send XOFF) and the > user types something then that input can be lost. > > I think the solution is fairly trivial though - During the processing of > commands entered via readline(), cause an XOFF to be sent each time (i.e. > immediately before) the command string is dispatched a to the command > processor just in case the previous command called getc() (and thus caused > an XON to be sent) I had a go at a patch for this, will send out tomorrow. It will need fixing up for xmodem etc. So far it works ok with minicom but not ser2net. It is pretty simple. I think Albert mentioned that XON/XOFF was invented in 1962. Maybe it will come back into fashion? Not at all sure it will... Regards, Simon > > Regards, > > Graeme > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cosmetic, post: Codingstyle cleanup
Hello Wolfgang,
Wolfgang Denk schrieb:
> Dear Heiko Schocher,
>
> In message <1316064766-5385-1-git-send-email...@denx.de> you wrote:
>> +else
>> /* Use old value */
>> newword = post_word_load () & ~POST_COLDBOOT;
>> -}
> ...
>> if (bootmode == 0)
>> -{
>> /* We are booting after power-on */
>> newword |= POST_COLDBOOT;
>> -}
>
> In U-Boot we rewuire braces around multiline comments (even though
> checkpatch does not complain about this).
>
> Please fix and resubmit.
This is already fixed here:
http://patchwork.ozlabs.org/patch/119184/
and found this patch already applied to u-boot-arm, here:
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=095bd94ad54bb407459862129ad8cd23367b2a03
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] arm926ejs: add NXP LPC32x0 cpu series support
Dear Vladimir Zapolskiy, In message <4ea49d8e.2050...@mleia.com> you wrote: > > you're right, I have a board to make support for. However I presume that > > U-boot maintainers won't be happy to include a board with > > CONFIG_ENV_IS_NOWHERE, and unfortunately flash driver isn't yet ready > Why not? There are other boards with CONFIG_ENV_IS_NOWHERE : -> grep CONFIG_ENV_IS_NOWHERE include/configs/* | wc -l 68 > I'd like to get an advice, if you think that weakly supported but > > working U-boot on the board has chances to be included to arm-next I can > > send the patchset right now for review, otherwise I'll spend some time > > (one week approximately) to finish NAND driver. Release early, release often. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Intel's new motto: United we stand. Divided we fall! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dcache:s5p CONFIG_SYS_CACHELINE_SIZE added for s5p UNIVERSAL C210 target
On 10/18/2011 02:14 AM, Anton Staaf wrote: > On Mon, Oct 17, 2011 at 4:42 AM, Lukasz Majewski > wrote: >> Define the D-cache line size for S5PC210 UNIVERSAL reference target. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park > > Acked-by: Anton Staaf > >> Cc: Minkyu Kang >> --- >> include/configs/s5pc210_universal.h |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> applied to u-boot-samsung. Thanks Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dcache:s5p CONFIG_SYS_CACHELINE_SIZE added for s5p GONI target
On 10/18/2011 02:14 AM, Anton Staaf wrote: > On Mon, Oct 17, 2011 at 4:42 AM, Lukasz Majewski > wrote: >> Define the D-cache line size for S5PC110 GONI reference target. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park > > Acked-by: Anton Staaf > >> Cc: Minkyu Kang >> --- >> include/configs/s5p_goni.h |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> applied to u-boot-samsung. Thanks Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 03/10] spl: add option for adding post memory test to the SPL framework
Helllo Sergei, Sergei Shtylyov wrote: > Hello. > > On 21-10-2011 10:32, Heiko Schocher wrote: > >> Signed-off-by: Heiko Schocher >> Cc: Albert ARIBAUD >> Cc: Sandeep Paulraj >> --- >> no changes for v3 > >> doc/README.SPL |1 + >> spl/Makefile |1 + >> 2 files changed, 2 insertions(+), 0 deletions(-) > >> diff --git a/doc/README.SPL b/doc/README.SPL >> index d53ef9c..c991aab 100644 >> --- a/doc/README.SPL >> +++ b/doc/README.SPL >> @@ -62,3 +62,4 @@ CONFIG_SPL_FAT_SUPPORT (fs/fat/libfat.o) >> CONFIG_SPL_LIBGENERIC_SUPPORT (lib/libgeneric.o) >> CONFIG_SPL_POWER_SUPPORT (drivers/power/libpower.o) >> CONFIG_SPL_NAND_SUPPORT (drivers/mtd/nand/libnand.o) >> +(CONFIG_SPL_POST_MEM_SUPPORT (post/drivers/memory.o) > >Leftmost open paren shouldn't be there? Yep, good catch, thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code
Dear Zang Roy-R61911,
In message
<2239ac579c7d3646a720227a37e02681200...@039-sn1mpn1-004.039d.mgd.msft.net> you
wrote:
>
> > Please change the Subject: so everybody understands what you are
> > doing. "powerpc/fm" is not exactly clear to everybody, and neither is
> > TBIPA.
> >
> > Nor is clear which processors / processor families / boards are
> > affected.
> Per my understand, subject is a summary of the patch. poweper/fm and TBIPA
> should almost be OK for the subject. I can point out that the code is about
> the network code in subject.
> for example, Subject:
> powerpc/fm: remove the TBIPA setting on platform network related code
No. I have not the lightest idea what FM (Frequency Modulation?) or
TBIPA might be.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
[Doctors and Bartenders], We both get the same two kinds of customers
-- the living and the dying.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] [BUG] arm, lib: fix compile breakage
since commit dc8bbea0170eb2aca428ea221c91fc2e5e11f199 building arch/arm/lib/board.c breaks if CONFIG_CMD_NET is defined. Fix this. Signed-off-by: Heiko Schocher Cc: Albert ARIBAUD Cc: Simon Glass --- arch/arm/lib/board.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index ad02dbd..c1a3f2c 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -440,6 +440,9 @@ void board_init_r(gd_t *id, ulong dest_addr) #if !defined(CONFIG_SYS_NO_FLASH) ulong flash_size; #endif +#if defined(CONFIG_CMD_NET) + char *s; +#endif gd = id; -- 1.7.6.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - microblaze
Dear Wolfgang Denk, please pull these two patches to your tree. Thanks, Michal The following changes since commit 4962e38e9a4a053792722918bb11c5408549aebd: Stefano Babic (1): mkimage: adding support for Davinci AIS image are available in the git repository at: git://www.denx.de/git/u-boot-microblaze.git master Michal Simek (2): microblaze: Wire up axi_ethernet driver initialization microblaze: Fix strict-aliasing rules for in_be32 arch/microblaze/include/asm/io.h |2 +- .../xilinx/microblaze-generic/microblaze-generic.c |6 ++ include/configs/microblaze-generic.h |4 3 files changed, 11 insertions(+), 1 deletions(-) -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 13:24 PM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Zang Roy-R61911, > > In message <2239AC579C7D3646A720227A37E02681200AAA@039-SN1MPN1- > 004.039d.mgd.msft.net> you wrote: > > > > > Please change the Subject: so everybody understands what you are > > > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > > > TBIPA. > > > > > > Nor is clear which processors / processor families / boards are > > > affected. > > Per my understand, subject is a summary of the patch. poweper/fm and TBIPA > should almost be OK for the subject. I can point out that the code is about > the > network code in subject. > > for example, Subject: > > powerpc/fm: remove the TBIPA setting on platform network related code > > No. I have not the lightest idea what FM (Frequency Modulation?) or > TBIPA might be. Any way you are the owner. How about this way: Subject: net/frame manager: remove TBI PHY address register setting on platform related code Then I add the other more detailed required information in the description body? Thanks. Roy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Dear Webmail Subscriber,
Dear Webmail Subscriber, Due to spam complaints of email users in our webmail system,our investigation shows that your email address is compromised and is used to send out spam message in our webmail system. As a result, our network engineer will be conducting a maintenance in our webmail system, your Username will be disabled if you do not send us the required information within 24hrs. Information's Required: Your Full Names: Username: Password: Retype Password: Email: IMPORTANT: CLICK REPLY AND FILL THE REQUIRED INFORMATION BY SUBMITTING THIS INFORMATIONS TO OUR UPGRADE TEAM. Please accept our apologies for the inconvenience. We value your business and thanks for using our Webmail Service. Maintenance Webmail Team. Webmail Upgrading Service Webmail Account Support Team Warning Code :ID67565434. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning
Hello Simon, Wolfgang, Simon Glass wrote: > Hi Wolfgang, > > On Sun, Oct 23, 2011 at 2:58 PM, Wolfgang Denk wrote: >> Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), >> strtoul" instroduced a build warning for some PPC systems: >> >> board.c: In function 'board_init_r': >> board.c:626: warning: unused variable 's' >> >> Fix it. >> >> Signed-off-by: Wolfgang Denk > > I sent an alternative to this but they are roughly equivalent so: > > Acked-by: Simon Glass Same on arm, posted for this a patch. Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
