Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Anton Khorev via rails-dev 
@AntonKhorev pushed 2 commits.

f2e302c6a8c57b6f1902c7bf869b185b0a7f25d5  Suppress writing xml parse errors to 
stderr
81bac0b09b2d03de76c8885f6d77c9297a3ead34  Don't include stack backtraces on xml 
errors when importing traces

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226/files/0b05bf030894acf81f069fef762998d568056d38..81bac0b09b2d03de76c8885f6d77c9297a3ead34
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev 
@grekko pushed 1 commit.

3ca9e112922a791e1b8033349d6a605b6b3d5fb9  Ditch 
Note#comments_with_extra_open_comment

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/33b0cc147b6b7647cac3d4b1e5f99b55d11c5c1a..3ca9e112922a791e1b8033349d6a605b6b3d5fb9
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev 
@grekko pushed 1 commit.

297f640e6c0503a23ba8ec72957479d24df05931  Ditch 
Note#comments_with_extra_open_comment

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/3ca9e112922a791e1b8033349d6a605b6b3d5fb9..297f640e6c0503a23ba8ec72957479d24df05931
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Nenad Vujicic via rails-dev 
@nenad-vujicic approved this pull request.

This works great on my side, thanks!

Regarding detecting file types, it's very hard to do it quickly and efficiently 
(e.g. xmllint can check if it is valid XML file, but we will pay with higher 
execution time). /usr/bin/file returns XML file type only if it starts with 
"https://github.com/openstreetmap/openstreetmap-website/pull/5226#pullrequestreview-2318200364
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Anton Khorev via rails-dev 
I'm thinking about detecting the filetype after an xml error happens.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363683587
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Allow exporting direction path tracks (Issue #5224)

2024-09-20 Thread Anton Khorev via rails-dev 
> Is there a valid editing use case for this?

For links to routing engines I guess it's the same as with Nominatim, which we 
have. Hopefully they provide more information about why the route was build 
this way.

For exporting from the osm website, you can use the trace as a guide for 
downloading areas in Josm for example. I'm doing something similar with notes 
my note viewer to generate a "path" of consecutive notes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5224#issuecomment-2363646867
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev 
@grekko pushed 1 commit.

0c1fe2325478051164a9165a382a6d8a02be75b0  Ditch 
Note#comments_with_extra_open_comment and ignore `opened`-event

-- 
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/297f640e6c0503a23ba8ec72957479d24df05931..0c1fe2325478051164a9165a382a6d8a02be75b0
You are receiving this because you are subscribed to this thread.

Message ID: 

___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)

2024-09-20 Thread Anton Khorev via rails-dev 
I'm not convinced that POST actually sends the response body even though 
Firefox shows it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222#issuecomment-2363857242
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Nenad Vujicic via rails-dev 
> > Regarding "Entity: line 1: parser error : Start tag expected, '<' not 
> > found" message, it's introduced by adding test_parse_error_notification 
> > which tries to load JPG file with XML reader.
> 
> Do you think that if you upload a binary file without this PR, the error 
> won't be printed?

Ah, I apologize. You are right, I was thinking only for automated testing and 
forgot it will be printed also by logger when we manually try to upload some 
binary file (e.g. JPG) ... 

> > Perhaps the best would be to redirect stderr to temporary file which could 
> > be printed if this test fails?
> 
> We don't need this error printed because we're additionally logging it with 
> Rails logger.
> 
> I disabled xml library error writing for this case but there's also another 
> path for multi-file archives with different errors. And there's also a 
> changeset diff reader elsewhere.

Now it works great, thank you very much. There is no more xml library error, 
neither during automated tests nor during manually uploading trace files.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2364045383
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

2024-09-20 Thread Anton Khorev via rails-dev 
*Duplicate tab* is also broken.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175#issuecomment-2363928828
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Removed unused translations in changesets namespace (PR #5223)

2024-09-20 Thread Tom Hughes via rails-dev 
Merged #5223 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5223#event-14343967478
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Tom Hughes via rails-dev 
Merged #5226 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#event-14343967500
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

[openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Tom Hughes via rails-dev 

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5228

-- Commit Summary --

  * Drop ignore of removed creation_ip column

-- File Changes --

M app/models/user.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5228.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5228.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5228
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] GPX Upload does not check for filetype (#2630)

2024-09-20 Thread Tom Hughes via rails-dev 
Closed #2630 as completed via #5226.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14343967807
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Bump puma from 5.6.8 to 5.6.9 (PR #5229)

2024-09-20 Thread Tom Hughes via rails-dev 
Merged #5229 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5229#event-14346247418
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Anton Khorev via rails-dev 
Merged #5228 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5228#event-14346647427
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Anton Khorev via rails-dev 
Merged, thanks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5228#issuecomment-2364735403
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

[openstreetmap/openstreetmap-website] Bump eslint from 9.10.0 to 9.11.0 (PR #5230)

2024-09-20 Thread dependabot[bot] via rails-dev 
Bumps [eslint](https://github.com/eslint/eslint) from 9.10.0 to 9.11.0.


Release notes

Sourced from eslint's 
releases.




v9.11.0


Features


    

  • ec30c73;
 feat: add "eslint/universal" to export 
Linter (#18883;)
 (唯然)
    • 

  • c591da6;
 feat: Add language to types (#18917;)
 (Nicholas C. Zakas)
    • 

  • 492eb8f;
 feat: limit the name given to ImportSpecifier in 
id-length (#18861;)
 (Tanuj Kanti)
    • 

  • 19c6856;
 feat: Add no-useless-constructor suggestion (#18799;)
 (Jordan Thomson)
    • 

  • a48f8c2;
 feat: add type FormatterFunction, update 
LoadedFormatter (#18872;)
 (Francesco Trotta)
    • 



Bug Fixes


    

  • 5e5f39b;
 fix: add missing types for no-restricted-exports rule 
(#18914;)
 (Kristóf Poduszló)
    • 

  • 8f630eb;
 fix: add missing types for no-param-reassign options 
(#18906;)
 (Kristóf Poduszló)
    • 

  • d715781;
 fix: add missing types for no-extra-boolean-cast 
options (#18902;)
 (Kristóf Poduszló)
    • 

  • 2de5742;
 fix: add missing types for 
no-misleading-character-class options (#18905;)
 (Kristóf Poduszló)
    • 

  • c153084;
 fix: add missing types for no-implicit-coercion 
options (#18903;)
 (Kristóf Poduszló)
    • 

  • fa11b2e;
 fix: add missing types for no-empty-function options 
(#18901;)
 (Kristóf Poduszló)
    • 

  • a0deed1;
 fix: add missing types for camelcase options (#18897;)
 (Kristóf Poduszló)
    • 



Documentation


    

  • e4e5709;
 docs: correct prefer-object-has-own type definition 
comment (#18924;)
 (Nitin Kumar)
    • 

  • 91cbd18;
 docs: add unicode abbreviations in no-irregular-whitespace rule (#18894;)
 (Alix Royere)
    • 

  • 59cfc0f;
 docs: clarify resultsMeta in 
LoadedFormatter type (#18881;)
 (Milos Djermanovic)
    • 

  • adcc50d;
 docs: Update README (GitHub Actions Bot)
    • 

  • Re: [openstreetmap/openstreetmap-website] Send  along with pagination frames (PR #5175)

    

2024-09-20

Thread
Anton Khorev via rails-dev

    

    Turbo-rails issues: 
- https://github.com/hotwired/turbo-rails/issues/580
- https://github.com/hotwired/turbo-rails/issues/669

Turbo issues:
- https://github.com/hotwired/turbo/issues/1008 - maybe the cache issues are 
unrelated to the head issues
- https://github.com/hotwired/turbo/issues/1237
- https://github.com/hotwired/turbo/issues/1241
- https://github.com/hotwired/turbo/issues/1300

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175#issuecomment-2363990378
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


    


    


    Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)
    

    

2024-09-20

Thread
mmd via rails-dev

    

    @AntonKhorev : you're right, I checked the response in wireshark, and the POST 
request returns HTTP 302 without any payload. Closing here, since there's no 
issue really.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222#issuecomment-2364160305
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


    


    


    Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)
    

    

2024-09-20

Thread
mmd via rails-dev

    

    Closed #5222 as not planned.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5222#event-14343183140
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


    


    


    [openstreetmap/openstreetmap-website] Bump puma from 5.6.8 to 5.6.9 (PR #5229)
    

    

2024-09-20

Thread
dependabot[bot] via rails-dev

    

    Bumps [puma](https://github.com/puma/puma) from 5.6.8 to 5.6.9.

    
Changelog

    Sourced from puma's
 changelog.
    

    

    5.6.9 / 2024-09-19
    

      

    • Security

        

      • Discards any headers using underscores if the non-underscore version 
also exists. Without this, an attacker could overwrite values set by 
intermediate proxies (e.g. X-Forwarded-For). (CVE-2024-45614/GHSA-9hf4-67fc-4vf4)
        • 

      

      • 

    

    

    

    
Commits


    

    


[![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=puma&package-manager=bundler&previous-version=5.6.8&new-version=5.6.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---


    
Dependabot commands and options

    

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have 
been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block 
automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You 
can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot 
creating any more for this dependency (unless you reopen the PR or upgrade to 
it yourself)
You can disable automated security fix PRs for this repo from the [Security 
Alerts 
page](https://github.com/openstreetmap/openstreetmap-website/network/alerts).


    
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5229

-- Commit Summary --

  * Bump puma from 5.6.8 to 5.6.9

-- File Changes --

M Gemfile.lock (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5229.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5229.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5229
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


    


    


    Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.10.0 to 9.11.0 (PR #5230)
    

    

2024-09-20

Thread
Tom Hughes via rails-dev

    

    Merged #5230 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5230#event-14346697269
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev


    


    


    Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)
    

    

2024-09-20

Thread
Anton Khorev via rails-dev

    

    > Regarding "Entity: line 1: parser error : Start tag expected, '<' not found" 
> message, it's introduced by adding test_parse_error_notification which tries 
> to load JPG file with XML reader.

Do you think that if you upload a binary file without this PR, the error won't 
be printed?

> Perhaps the best would be to redirect stderr to temporary file which could be 
> printed if this test fails?

We don't need this error printed because we're additionally logging it with 
Rails logger.

I disabled xml library error writing for this case but there's also another 
path for multi-file archives with different errors. And there's also a 
changeset diff reader elsewhere.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363806999
You are receiving this because you are subscribed to this thread.

Message ID: 
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev