Re: [OpenWrt-Devel] target rb532 / routerboard / PCI issues

[Roman Yeryomin]

On 4 July 2014 09:35, John Crispin  wrote:
> applied in r41505
>

Thanks!
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [RFC] BCM63XX SMP: assign interrupts to one cpu rather than both

[José Vázquez]

Found this comment in a Broadcom source code that has an interesting
comment; in addition, danitool, testing different kernel command lines
found that forcing all the interrupts to CPUx the network throughput
was increased more than a 15% (as far i remember).

Any comment will be welcome.

Pepe

 .depth = 1,
 .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock),
 #ifdef CONFIG_SMP
+#if defined(CONFIG_MIPS_BRCM)
+   /* We don't have an interrupt controller to distribute 
interrupts, so
+   initially assign all interrupts to one cpu, then make explicit
adjustments if needed */
+   .affinity = CPU_MASK_CPU0
+#else
.affinity = CPU_MASK_ALL
 #endif
+#endif
}
 };
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [brcm2708] Use uci-defaults for network config

[Álvaro Fernández Rojas]

By using uci-defaults force_link is enabled, which fixes some link issues if 
ethernet cable isn't connected when LAN is initialized.

Signed-off-by: Álvaro Fernández Rojas 
---
diff --git a/target/linux/brcm2708/base-files/etc/config/network 
b/target/linux/brcm2708/base-files/etc/config/network
deleted file mode 100644
index 1d5ded3..000
--- a/target/linux/brcm2708/base-files/etc/config/network
+++ /dev/null
@@ -1,13 +0,0 @@
-# Copyright (C) 2006 OpenWrt.org
-
-config interface loopback
-   option ifname   lo
-   option protostatic
-   option ipaddr   127.0.0.1
-   option netmask  255.0.0.0
-
-config interface lan
-   option ifname   eth0
-   option protostatic
-   option ipaddr   192.168.1.1
-   option netmask  255.255.255.0
diff --git a/target/linux/brcm2708/base-files/etc/uci-defaults/02_network 
b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
new file mode 100644
index 000..588fff3
--- /dev/null
+++ b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
@@ -0,0 +1,11 @@
+#!/bin/sh
+# Copyright (C) 2014 OpenWrt.org
+
+. /lib/functions/uci-defaults.sh
+
+ucidef_set_interface_loopback
+ucidef_set_interface_lan "eth0"
+
+uci commit network
+
+exit 0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [brcm2708] Use uci-defaults for network config

[Jonas Gorski]

Hi,

On Fri, Jul 4, 2014 at 1:33 PM, Álvaro Fernández Rojas
 wrote:
> By using uci-defaults force_link is enabled, which fixes some link issues if 
> ethernet cable isn't connected when LAN is initialized.
>
> Signed-off-by: Álvaro Fernández Rojas 
> ---
(snip)
> diff --git a/target/linux/brcm2708/base-files/etc/uci-defaults/02_network 
> b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
> new file mode 100644
> index 000..588fff3
> --- /dev/null
> +++ b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
> @@ -0,0 +1,11 @@
> +#!/bin/sh
> +# Copyright (C) 2014 OpenWrt.org
> +
> +. /lib/functions/uci-defaults.sh
> +
> +ucidef_set_interface_loopback
> +ucidef_set_interface_lan "eth0"
> +
> +uci commit network

This will break for sysupgrade with existing configs (if it were
supported) or images with custom network config from files/; your
first action should be

[ -e /etc/config/network ] && exit 0

like it is done on other targets.


Jonas
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [RFC] BCM63XX SMP: assign interrupts to one cpu rather than both

[Jonas Gorski]

On Fri, Jul 4, 2014 at 12:46 PM, José Vázquez  wrote:
> Found this comment in a Broadcom source code that has an interesting
> comment; in addition, danitool, testing different kernel command lines
> found that forcing all the interrupts to CPUx the network throughput
> was increased more than a 15% (as far i remember).
>
> Any comment will be welcome.

I don't mind doing that if it increases network throughput. I have a
patch lying around for doing it in a somewhat cleaner way, so I will
commit that soonish.


Jonas
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH V2][brcm2708] Use uci-defaults for network config

[Álvaro Fernández Rojas]

By using uci-defaults force_link is enabled, which fixes some link issues if 
ethernet cable isn't connected when LAN is initialized.

Signed-off-by: Álvaro Fernández Rojas 
---
v2: check for existing network config as Jonas suggested.

diff --git a/target/linux/brcm2708/base-files/etc/config/network 
b/target/linux/brcm2708/base-files/etc/config/network
deleted file mode 100644
index 1d5ded3..000
--- a/target/linux/brcm2708/base-files/etc/config/network
+++ /dev/null
@@ -1,13 +0,0 @@
-# Copyright (C) 2006 OpenWrt.org
-
-config interface loopback
-   option ifname   lo
-   option protostatic
-   option ipaddr   127.0.0.1
-   option netmask  255.0.0.0
-
-config interface lan
-   option ifname   eth0
-   option protostatic
-   option ipaddr   192.168.1.1
-   option netmask  255.255.255.0
diff --git a/target/linux/brcm2708/base-files/etc/uci-defaults/02_network 
b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
new file mode 100644
index 000..e7e35c5
--- /dev/null
+++ b/target/linux/brcm2708/base-files/etc/uci-defaults/02_network
@@ -0,0 +1,15 @@
+#!/bin/sh
+# Copyright (C) 2014 OpenWrt.org
+
+[ -e /etc/config/network ] && exit 0
+
+touch /etc/config/network
+
+. /lib/functions/uci-defaults.sh
+
+ucidef_set_interface_loopback
+ucidef_set_interface_lan "eth0"
+
+uci commit network
+
+exit 0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] lantiq: generate /tmp/sysinfo/lantiq_board_name if missing

[Ben Mulvihill]

Run lantiq_board_detect from lantiq_board_name and lantiq_board_model.

This was the one thing missing from r41474 for sysupgrade board
detection to work properly. 

Sysupgrade on the BTHOMEHUBV2B falls down later on in the process
I'm afraid, but I still have to investigate why.

Ben

Signed-off-by: Ben Mulvihill 
---

--- a/target/linux/lantiq/base-files/lib/functions/lantiq.sh2014-07-04 
14:21:28.777178976 +0200
+++ b/target/linux/lantiq/base-files/lib/functions/lantiq.sh2014-07-04 
14:17:23.451467131 +0200
@@ -13,6 +13,7 @@ lantiq_board_detect() {
 lantiq_board_model() {
local model
 
+   [ -f /tmp/sysinfo/model ] || lantiq_board_detect
[ -f /tmp/sysinfo/model ] && model=$(cat /tmp/sysinfo/model)
[ -z "$model" ] && model="unknown"
 
@@ -22,6 +23,7 @@ lantiq_board_model() {
 lantiq_board_name() {
local name
 
+   [ -f /tmp/sysinfo/board_name ] || lantiq_board_detect
[ -f /tmp/sysinfo/board_name ] && name=$(cat /tmp/sysinfo/board_name)
[ -z "$name" ] && name="unknown"
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] IEEE 802.11 TDMA mode support in OpenWRT

[Fernando Frediani]

Hi Ben,

TDMA doesn't require synchronization between the radios. This would be 
Ubiquiti's AirSync technology and that's for another usage. When you 
have two or mode radios colocated in a tower receiving and transmitting 
at the same time so it avoids them do it at the same time and 
synchronizes Receive and Transmit.


TDMA is more to be used in PtMP environments where you have multiple 
customers talking to the AP and they don't see each other, so the AP is 
able to organize more correctlly the time each one sends data. That's 
probably why it was only implements on proprietary systems usede by 
WISPs with different names.


Regards,

Fernando

On 03/07/2014 19:59, Ben West wrote:
In an old thread on the Battlemesh listserv about strategies for 
dealing with a mix of strong / weak clients for PtMP, someone offered 
this pointer for JaldMAC, an open 802.11 polling implementation in ath9k:


http://matthias.vallentin.net/papers/nsdr10.pdf
https://github.com/shaddi/jaldimac/commits/master

Unfortunately, that repo has sat idle for over 2 years, and I believe 
it it was more a proof of concept rather than a usable implementation.


Also, i believe TDMA requires very tight synchronization between all 
radios, hence the inclusion of GPS modules on proprietary implementations.




On Thu, Jul 3, 2014 at 11:02 AM, Fernando Frediani 
mailto:fhfredi...@gmail.com>> wrote:


Hi all,

Is anyone aware of any implementation of TDMA mode support in
OpenWRT (similar to Ubiquiti's AirMAX, Deliberant's iPoll or
MikroTik's NV2, etc)

Would that have to be implemented having in mind the radio driver
or could it possible also be implemented in any router ?
This is certanlly something significant for more throughput
demanding and crowded environments.

Best regards,

Fernando
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org

https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel




--
Ben West
http://gowasabi.net
b...@gowasabi.net 
314-246-9434


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Status of DFS in OpenWrt -> ath9k

[Jacek Kikiewicz]

Hello,

I have CONFIG_PACKAGE_ATH_DFS=y and still cannot use this... any idea how / 
what should be debugged?

Jacek


On 03.07.2014 18:14, Martin Garbe wrote:
> The command "iw phy ..." only shows hardware capabilities. For DFS
> hardware AND software support is needed. In OpenWRT you need hostapd to
> support DFS too. The config parameter CONFIG_PACKAGE_ATH_DFS explicitely
> activates DFS in hostapd. This parameter is not set by default.
> For more information see also the patch with comment in git:
> http://git.openwrt.org/?p=openwrt.git;a=commitdiff;h=5fd90c893f86e88150ea81be7afd337ac1b802aa
> 
> Regards,
> Martin
> 
> 
>> > Jacek
>> > 
>> > On 07/02/14 22:50, Martin Garbe wrote:
>>> >> On 7/1/14, 10:04 AM, Jacek Kikiewicz wrote:
 >>> Hello,
 >>>
 >>> I have few APs that are using ath9k driver, I've read that now DFS is
 >>> supported on that driver,
 >>> so I compiled latest revision (yesterday: 41415), and started
 >>> playing, basically when as per
 >>> manual / howto I run 'iw phy phy1 info' I can see DFS channels,
 >>> exactly like in howto on a wiki, problem is however
 >>> that I cannot make it work on those channels (I've tried 52,56,100,
 >>> 104), after changing config and restarting wifi
 >>> I saw in dmesg 'interface wlan1 entered disabled mode) - I tried with
 >>> HT20 for the beginning.
 >>> So, question here is, should this work in current state or is there
 >>> still some support missing?
 >>> I can pull any logs  / settings that are of interest.
>>> >> Have you elected
>>> >>   CONFIG_PACKAGE_ATH_DFS=y
>>> >> when compiling the driver? This way you agree to the fact that your
>>> >> hardware supports DFS. After that DFS channels can be selected.
>>> >>
>>> >>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [RFC] BCM63XX SMP: assign interrupts to one cpu rather than both

[José Vázquez]

I have sent it if it could help. The most the information the better the
choice.
danitool made the mentioned tests so ask him about the details.

Regards:

Pepe

El viernes, 4 de julio de 2014, Jonas Gorski  escribió:

> On Fri, Jul 4, 2014 at 12:46 PM, José Vázquez  > wrote:
> > Found this comment in a Broadcom source code that has an interesting
> > comment; in addition, danitool, testing different kernel command lines
> > found that forcing all the interrupts to CPUx the network throughput
> > was increased more than a 15% (as far i remember).
> >
> > Any comment will be welcome.
>
> I don't mind doing that if it increases network throughput. I have a
> patch lying around for doing it in a somewhat cleaner way, so I will
> commit that soonish.
>
>
> Jonas
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 1/4] [rb532] fix jffs2 images

[Roman Yeryomin]

Signed-off-by: Roman Yeryomin 
---
 target/linux/rb532/image/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/rb532/image/Makefile 
b/target/linux/rb532/image/Makefile
index 65ef919..3cc7bce 100644
--- a/target/linux/rb532/image/Makefile
+++ b/target/linux/rb532/image/Makefile
@@ -44,11 +44,11 @@ endif
 endef
 
 define Image/cmdline/jffs2-64k
-block2mtd.block2mtd=/dev/sda2,65536 root=/dev/mtdblock0 rootfstype=jffs2
+block2mtd.block2mtd=/dev/sda2,65536 root=/dev/mtdblock2 rootfstype=jffs2
 endef
 
 define Image/cmdline/jffs2-128k
-block2mtd.block2mtd=/dev/sda2,131072 root=/dev/mtdblock0 rootfstype=jffs2
+block2mtd.block2mtd=/dev/sda2,131072 root=/dev/mtdblock2 rootfstype=jffs2
 endef
 
 define Image/cmdline/ext4
-- 
1.9.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 0/4] fix rb532 support

[Roman Yeryomin]

This patch set fully fixes rb532 support and removes broken mark.

Roman Yeryomin (4):
  [rb532] fix jffs2 images
  [rb532] change default package set
  [rb532] add wan interface
  [rb532] remove broken mark

 target/linux/rb532/Makefile  | 4 ++--
 target/linux/rb532/base-files/etc/config/network | 4 
 target/linux/rb532/image/Makefile| 4 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)

-- 
1.9.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 4/4] [rb532] remove broken mark

[Roman Yeryomin]

Signed-off-by: Roman Yeryomin 
---
 target/linux/rb532/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/rb532/Makefile b/target/linux/rb532/Makefile
index 97f5312..dfbdcf0 100644
--- a/target/linux/rb532/Makefile
+++ b/target/linux/rb532/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 ARCH:=mipsel
 BOARD:=rb532
 BOARDNAME:=Mikrotik RouterBoard 532
-FEATURES:=pci targz broken
+FEATURES:=pci targz
 
 LINUX_VERSION:=3.10.44
 
-- 
1.9.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 2/4] [rb532] change default package set

[Roman Yeryomin]

There could be no wireless interfaces but ethernets are on board.

Signed-off-by: Roman Yeryomin 
---
 target/linux/rb532/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/rb532/Makefile b/target/linux/rb532/Makefile
index 3f64703..97f5312 100644
--- a/target/linux/rb532/Makefile
+++ b/target/linux/rb532/Makefile
@@ -14,6 +14,6 @@ FEATURES:=pci targz broken
 LINUX_VERSION:=3.10.44
 
 include $(INCLUDE_DIR)/target.mk
-DEFAULT_PACKAGES += wpad-mini kmod-madwifi kmod-input-rb532
+DEFAULT_PACKAGES += kmod-input-rb532 kmod-via-rhine
 
 $(eval $(call BuildTarget))
-- 
1.9.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 3/4] [rb532] add wan interface

[Roman Yeryomin]

Signed-off-by: Roman Yeryomin 
---
 target/linux/rb532/base-files/etc/config/network | 4 
 1 file changed, 4 insertions(+)

diff --git a/target/linux/rb532/base-files/etc/config/network 
b/target/linux/rb532/base-files/etc/config/network
index 3a8c8f3..1153799 100644
--- a/target/linux/rb532/base-files/etc/config/network
+++ b/target/linux/rb532/base-files/etc/config/network
@@ -6,6 +6,10 @@ config interface loopback
option ipaddr   127.0.0.1
option netmask  255.0.0.0
 
+config interface wan
+   option ifname   eth0
+   option protodhcp
+
 config interface lan
option ifname   eth2
option protostatic
-- 
1.9.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] ramips: add support for WR8305RT board

[Jorge Vargas]

Signed-off-by: Jorge Vargas 
---
 target/linux/ramips/base-files/etc/diag.sh |   3 +
 .../etc/hotplug.d/firmware/10-rt2x00-eeprom|   1 +
 .../ramips/base-files/etc/uci-defaults/01_leds |   5 +
 .../ramips/base-files/etc/uci-defaults/02_network  |  12 +++
 .../ramips/base-files/lib/preinit/06_set_iface_mac |   3 +-
 target/linux/ramips/base-files/lib/ramips.sh   |   3 +
 .../ramips/base-files/lib/upgrade/platform.sh  |   1 +
 target/linux/ramips/dts/WR8305RT.dts   | 108 +
 target/linux/ramips/image/Makefile |   2 +
 9 files changed, 137 insertions(+), 1 deletion(-)
 create mode 100644 target/linux/ramips/dts/WR8305RT.dts

diff --git a/target/linux/ramips/base-files/etc/diag.sh 
b/target/linux/ramips/base-files/etc/diag.sh
index 14d630e..908547e 100755
--- a/target/linux/ramips/base-files/etc/diag.sh
+++ b/target/linux/ramips/base-files/etc/diag.sh
@@ -152,6 +152,9 @@ get_status_led() {
wr512-3gn)
status_led="wr512:green:wps"
;;
+   wr8305rt)
+   status_led="wr8305rt:sys"
+   ;;
wnce2001)
status_led="netgear:green:power"
;;
diff --git 
a/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom 
b/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
index b56fb63..e958899 100644
--- a/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
+++ b/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
@@ -120,6 +120,7 @@ case "$FIRMWARE" in
wnce2001 | \
wr512-3gn | \
wr6202 | \
+   wr8305rt | \
wrtnode | \
mzk-w300nh2 | \
ur-326n4g | \
diff --git a/target/linux/ramips/base-files/etc/uci-defaults/01_leds 
b/target/linux/ramips/base-files/etc/uci-defaults/01_leds
index c2f768b..c3ae832 100755
--- a/target/linux/ramips/base-files/etc/uci-defaults/01_leds
+++ b/target/linux/ramips/base-files/etc/uci-defaults/01_leds
@@ -181,6 +181,11 @@ case $board in
ucidef_set_led_default "power" "power" "buffalo:green:power" "1"
ucidef_set_led_default "router" "router" "buffalo:green:router" 
"1"
;;
+   wr8305rt)
+   ucidef_set_led_default "power" "power" "wr8305rt:sys" "1"
+   set_usb_led "wr8305rt:usb"
+   set_wifi_led "wr8305rt:wifi"
+   ;;
 esac
 
 ucidef_commit_leds
diff --git a/target/linux/ramips/base-files/etc/uci-defaults/02_network 
b/target/linux/ramips/base-files/etc/uci-defaults/02_network
index 4eef735..a71ba18 100755
--- a/target/linux/ramips/base-files/etc/uci-defaults/02_network
+++ b/target/linux/ramips/base-files/etc/uci-defaults/02_network
@@ -162,6 +162,13 @@ ramips_setup_interfaces()
ucidef_add_switch_vlan "switch0" "2" "6t"
;;
 
+   wr8305rt)
+   ucidef_set_interfaces_lan_wan "eth0.1" "eth0.2"
+   ucidef_add_switch "switch0" "1" "1"
+   ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 4 6t"
+   ucidef_add_switch_vlan "switch0" "2" "4 6t"
+   ;;
+
d105 | \
na930 | \
omni-emb-hpm|\
@@ -244,6 +251,11 @@ ramips_setup_macs()
wan_mac=$(macaddr_add "$lan_mac" 1)
;;
 
+   wr8305rt)
+   lan_mac=$(mtd_get_mac_binary factory 4)
+   wan_mac=$(macaddr_add "$lan_mac" 1)
+   ;;
+
*)
wan_mac=$(macaddr_add "$lan_mac" 1)
;;
diff --git a/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac 
b/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
index 8538c13..2a0a4fd 100644
--- a/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
+++ b/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
@@ -17,7 +17,8 @@ preinit_set_mac_address() {
w150m | \
mzk-w300nh2 |\
wl-330n |\
-   wl-330n3g)
+   wl-330n3g |\
+   wr8305rt)
mac=$(mtd_get_mac_binary factory 4)
ifconfig eth0 hw ether $mac 2>/dev/null
;;
diff --git a/target/linux/ramips/base-files/lib/ramips.sh 
b/target/linux/ramips/base-files/lib/ramips.sh
index ca339b3..f398275 100755
--- a/target/linux/ramips/base-files/lib/ramips.sh
+++ b/target/linux/ramips/base-files/lib/ramips.sh
@@ -307,6 +307,9 @@ ramips_board_detect() {
*"Sercomm NA930")
name="na930"
;;
+   *"ZBT WR8305RT")
+   name="wr8305rt"
+   ;;
*)
name="generic"
;;
diff --git a/target/linux/ramips/base-files/lib/upgrade/platform.sh 
b/target/linux/ramips/base-files/lib/upgrade/platform.sh
index a39c433..c1eee00 100755
--- a/target/linux/ramips/base-files/lib/upgrade/platform.sh
+++ b/target/linux/ramips/base-files/lib/upgrade/platform.sh
@@ -89,6 +89,7 @@ platform_check_image() {