Re: [opensource-dev] Review Request: VWR-26393 /me emote doubles name in chat history

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/
---

(Updated Aug. 15, 2011, 7:19 a.m.)


Review request for Viewer.


Summary (updated)
---

As a resident of Second Life I find the displaying an emoter's name twice in 
nearby chat history rather unnecessary.  Please lay eyes on this proposed code 
change and let me know what you think.

I took care to remove the unlinked sender name instead of the linked one.


This addresses bug VWR-26393.
http://jira.secondlife.com/browse/VWR-26393


Diffs
-

  indra/newview/llchathistory.cpp 2f9a87538ca1 

Diff: http://codereview.secondlife.com/r/419/diff


Testing
---

Tell a crowd what you are testing and many will start talking to you prefixed 
with /me, if they are good sports.  I have been using this change for 3 days 
now and have not noticed any ill effects.  Please note: This changest is not 
intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
toasts or IM log files.


Thanks,

ardy.lay

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mercurial hook checking for well-formed XML

[Vadim Savchuk]

On Sat, Aug 13, 2011 at 12:18 AM, Oz Linden (Scott Lawrence) <
o...@lindenlab.com> wrote:

>
> We've had a spate of errors lately that would have been detected by
> checking whether or not some XML file was well formed, so I've written a
> mercurial hook to check.  It is written in python such that it runs within
> your existing hg commands without spawning another process; I don't believe
> that it significantly affects performance.
>
Thanks Oz! Installed and tested. Works like a charm.

-- 
Vadim
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-782 Unnecessary 'Compress snapshots to disk' menu item is presented in Advanced menu

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/440/
---

Review request for Viewer.


Summary
---

Removed the useless 'Compress snapshots to disk' item from the Advanced menu.

Removing the corresponding setting as well because it's not used anywhere.


This addresses bug STORM-782.
http://jira.secondlife.com/browse/STORM-782


Diffs
-

  indra/newview/app_settings/settings.xml 87fe21031c46 
  indra/newview/skins/default/xui/da/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/de/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/en/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/es/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/fr/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/it/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/ja/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/pl/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/pt/menu_viewer.xml 87fe21031c46 
  indra/newview/skins/default/xui/zh/menu_viewer.xml 87fe21031c46 

Diff: http://codereview.secondlife.com/r/440/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] OS X Lion

[Lee ponzu]

How much attention is being paid to Lion?   I think the natives are starting
to get restless.

ponzu
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-782 Unnecessary 'Compress snapshots to disk' menu item is presented in Advanced menu

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/440/#review977
---

Ship it!


Indeed unused, so removal is fine.

- Boroondas


On Aug. 15, 2011, 9:06 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/440/
> ---
> 
> (Updated Aug. 15, 2011, 9:06 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Removed the useless 'Compress snapshots to disk' item from the Advanced menu.
> 
> Removing the corresponding setting as well because it's not used anywhere.
> 
> 
> This addresses bug STORM-782.
> http://jira.secondlife.com/browse/STORM-782
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 87fe21031c46 
>   indra/newview/skins/default/xui/da/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/de/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/es/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/fr/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/it/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/ja/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/pl/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/pt/menu_viewer.xml 87fe21031c46 
>   indra/newview/skins/default/xui/zh/menu_viewer.xml 87fe21031c46 
> 
> Diff: http://codereview.secondlife.com/r/440/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1041 Removed clothes come back to haunt me

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/441/
---

Review request for Viewer and Nyx Linden.


Summary
---

The "Remove all clothes" item of the avatar menu didn't actually remove all 
clothes.

I haven't investigated what the problem was, I've just rewritten the (ancient?) 
removal code
in the way we take off items in other places, i.e. by removing them from the 
Current Outfit forder.

What I'm not sure about is whether we need to call updateAppearanceFromCOF() 
afterwards. Nyx?


This addresses bug STORM-1041.
http://jira.secondlife.com/browse/STORM-1041


Diffs
-

  indra/newview/llagentwearables.h 87fe21031c46 
  indra/newview/llagentwearables.cpp 87fe21031c46 
  indra/newview/llinventorybridge.cpp 87fe21031c46 

Diff: http://codereview.secondlife.com/r/441/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OS X Lion

[Mimika Oh]

On 2011-08-15, at 17:57, Lee ponzu wrote:

> How much attention is being paid to Lion?   I think the natives are starting 
> to get restless.

If you only wish to build on Mac OS X Lion with Xcode 4 you could look at 

 which "works for me".

We also try to figure out some backward compatibility issues with this patch at 
.

The viewer seems to build fine with Mac OS X 10.6 SDK but not with 10.7 because 
it is using some very old library calls.

It would be very nice to make a nice Cocoa window especially with Lion's new 
"full screen" option.

What other attention do you have in mind?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OS X Lion

[Francesco "Sythos" Rabbi]

> On 2011-08-15, at 17:57, Lee ponzu wrote:
>
>> How much attention is being paid to Lion?   I think the natives are starting 
>> to get restless.
>
> If you only wish to build on Mac OS X Lion with Xcode 4 you could look at 
> 
>  which "works for me".
>
> We also try to figure out some backward compatibility issues with this patch 
> at .
>
> The viewer seems to build fine with Mac OS X 10.6 SDK but not with 10.7 
> because it is using some very old library calls.
>
> It would be very nice to make a nice Cocoa window especially with Lion's new 
> "full screen" option.
>
> What other attention do you have in mind?
>

Well, lion use OpenGL 3.3, may be nice update all shader to use the
more advanced feagments and features for shaders (actually on version
120, mean OpenGL 2.1). But this mean drop snowleopard and previous...



-- 
Sent by iPhone
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OS X Lion

[Yoz Grahame]

 Not speaking for the team here (especially because I'm not in viewer 
development), just myself as a Lion user (Mid-2009 MBP, NVidia):  

There are only two major Lion-specific bugs that have bitten my own use so far. 
 

One is Freaky Polygons, which was quickly eased by turning off OpenGL vertex 
buffer objects (VBOs) in the Graphics->Hardware settings. There's a fix of some 
kind in the pipeline.
The other is a weird problem with certain web views (such as Profiles) showing 
up with no CSS or JS; this turned out to be SSL cert related, and there's a fix 
for this one in the pipeline too.

Apart from those two bugs, the viewer Works On My Machine™. I hope it also 
answers the overall question: yes, attention is being paid.

-- Yoz


On Monday, August 15, 2011 at 9:57 AM, Lee ponzu wrote:

> How much attention is being paid to Lion?  I think the natives are starting 
> to get restless.
>  
> ponzu  
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OS X Lion

[Laurent Bechir]

Le 15 août 2011 à 23:56, Mimika Oh a écrit :

> 
> If you only wish to build on Mac OS X Lion with Xcode 4 you could look at 
> 
>  which "works for me".

Hello,

How have you succeded with your build with XCode 4 ? I have XCode 4.1, I have 
downloaded the sources you mention, I have used "autobuild -c ReleaseOS", and 
Xcode don't want to build the viewer :

The scheme 'PROJECT_secondlife-bin_TEST_llworldmap' contains no buildables that 
can be built for the SDKs supported by the run destination My Mac 64-bit. Make 
sure your targets all specify SDKs that are supported by this version of Xcode.


Thank you___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges