Re: Haiku port
Hello FYI Le Wed, 02 Jul 2014 15:16:30 +0200, Stephan Bergmann a écrit: On 07/02/2014 02:35 PM, Kacper Kasper wrote: I am hacking on LibreOffice Haiku port and I have two questions: ...whatever that Haiku is... BeOS inspired OS: https://www.haiku-os.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Fix for Gerrit Daily Digest
Hello I submitted https://gerrit.libreoffice.org/10097 to fix the gerrit digest about freshers. I found some freshers were not. I first thought it was them not being on master, but they were. I decided to go into it this evening and find my fetch was only fetching (!!) and not forwarding indexes. This will solve the issue. Regards, Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Review] Lionss: Website for string search
Hello An old thread started in l10n list about improving translations. This lead to a cross-post to the dev ML [0], where I said I will implement a web interface to search for GUI strings, find their usage and opengrok them. Some time later, I eventually did (apart of) the job [1], which is reachable through [2]. With the kind comment of Michael M in [3], I decided to push to gerrit [4]. Next steps are: * Review :) * Finding a server to host that thing. It needs python 2.7+ and a wsgi-enabled web server, and preferably an already available and regularly (daily or more) updated core repository. At least the space for it, ~2GB in its bare format. Forwarding master branch in core could be consuming, even in bare, so I did not implemented it in web pages. [0] http://lists.freedesktop.org/archives/libreoffice/2013-December/058149.html [1] http://lists.freedesktop.org/archives/libreoffice/2014-May/061286.html [2] http://lionss-codeornot.rhcloud.com/ [3] https://bugs.freedesktop.org/show_bug.cgi?id=39439#c11 [4] https://gerrit.libreoffice.org/10096 Regards Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Fix for Gerrit Daily Digest
Hello Le Sun, 06 Jul 2014 01:35:59 +0200, Mat M a écrit: Hello I submitted https://gerrit.libreoffice.org/10097 to fix the gerrit digest about freshers. This will solve the issue. Since it has been reviewed, could someone update the production version on gerritbot account, please ? Regards Mat PS: the gerrit-test machine is unreachable; Could someon poke infra team to check or is it normal ? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: l10n process, en_US version, Help files
Hello Old thread revival ! Le Fri, 13 Dec 2013 10:01:05 +0100, Sophie a écrit: * And... fixing ! Easy hacks or l10n sessions to fix that are both valid choices. We may want to automate finding occurrences of text in the code. We began with fdo#39439, but further steps are required. did you submit your work, is it now integrated? So... I started with hrc and src files to end with .ui files, so it took longer than expected. I managed to deliver the small site to openshift. It was painful but learning as well. So you can test it here: http://lionss-codeornot.rhcloud.com/ Because of all the changes and the inital request, I am not sure this is what you expect. Don't mind to provide use cases so I can improve my work. Best, Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Sort and copy results
Hello, Le Thu, 05 Jun 2014 19:33:13 +0200, Kohei Yoshida a écrit: In Calc, you can go to Data -> Sort, and choose to copy the sorted results to someplace else, rather than the default option of sorting in place. I'm just wondering if anyone would miss this feature if it got removed. The UI is a bit awkward, and not clear what the associated two fields (left drop-down and right input fields) are supposed to take. Also, handling this option internally would require quite some extra effort, which, when one is trying to fix issues associted with this, would pose a greater risk of breaking things. Any objections for removing this? Kohei Could we (well, huh, you ?) just copy the data first, then sort them in-place ? It will preserve the feature without causing effort to maintain. And we may even soften the UI by adding some labels to boxes. My 2 cents Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice Gerrit News for core on 2014-05-01
Hello Le Thu, 01 May 2014 08:00:01 +0200, a écrit: Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Fix wrong value of 2 table-border styles in model.xml in https://gerrit.libreoffice.org/9213 from Adam CloudOn about module writerfilter End of freshness Just to say that Adam appears as a fresher because previous commits were registered as "Adam Co". :) But he's not the only one which has many identities in git. Lots of under-cover agents here :D Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#63315: sign windows binaries during build
Hello See https://bugs.freedesktop.org/show_bug.cgi?id=63315 From the Cloph's comment it seems the issue is fixed but with room for improvement. Should we close it or not ? Kind regards Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: need help with shell / configure
Hello am the culprit. I did not check that arrays were not posix :-( Since we have no spaces in vars and file names, it is simple to provide a POSIX workaround still allowing us to use the for loops. Will do that sometimes between tomorrow and next Sunday. Sorry for the inconvenience. Regards -- Mat M Le Fri, 15 Mar 2013 23:22:45 +0100, Matúš Kukan a écrit: On 15 March 2013 22:53, Stephan Bergmann wrote: <http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d16259c3428c3badfe7d156546be05ab0796a9c> "Consolidated branding in configure" introduced the use of the bash-specific array extension into configure.ac, which is likely not a good idea. Thanks, so - changing #! /bin/sh -> #! /bin/bash in generated configure helps to make it work for me but no idea how to really solve this. -- Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: need help with shell / configure
Hello
When working on it, I found that:
AC_PATH_PROG(BASH, bash)
if test -z "$BASH"; then
AC_MSG_ERROR([bash not found in \$PATH])
fi
AC_SUBST(BASH)
and then,
$ git grep BASH
bin/bash-completion.in:@BASH_COMPLETION_SUFFIXES_CHECKS@
bin/bash-completion.in:@BASH_COMPLETION_OOO_APPS@
bin/generate-bash-completion:if ($line =~
m/\@BASH_COMPLETION_SUFFIXES_CHECKS\@/) {
bin/generate-bash-completion:} elsif ($line =~
m/\@BASH_COMPLETION_OOO_APPS\@/) {
config_host.mk.in:export OOO_SHELL=@BASH@
configure.ac:AC_PATH_PROG(BASH, bash)
configure.ac:if test -z "$BASH"; then
configure.ac:AC_SUBST(BASH)
and
$ git grep OOO_SHELL
config_host.mk.in:export OOO_SHELL=@BASH@
So, is it still useful or could we remove BASH check and OOO_SHELL as well
?
I'll wait for your reply before submitting.
--
Mat M
Le Thu, 21 Mar 2013 00:35:57 +0100, Mat M a écrit:
Hello
am the culprit.
I did not check that arrays were not posix :-(
Since we have no spaces in vars and file names, it is simple to provide
a POSIX workaround still allowing us to use the for loops.
Will do that sometimes between tomorrow and next Sunday.
Sorry for the inconvenience.
Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reworking the MSVC-related build options
Hello Tor, Le Wed, 28 Nov 2012 20:23:09 +0100, Tor Lillqvist a écrit: Our current set of configure options related to the MSVC build tool-chain is quite messy and illogical. I think we should clean that up. Currently we have at least: --with-cl-home --with-mspdb-path --with-midl-path --with-csc-path --with-dotnet-framework-home --with-windows-sdk-home --with-directx-home [...] Ideally, I think what we need is just one option: --with-vs=2008/2010/2012. And that option would be necessary only if you have several Visual Studio versions installed and want to use a non-default one. What should the default be then in such a case? My vote would be for the newest... +1 Limiting options is a nice goal, but some will need some deep rework in configure. Yes, *-path and *-home are set for various reasons (not so logical sometimes, as you pointed out), but handling all side effects may be tricky, and some will be kept, I think. Also, you will need to provide special handling for VS express versions, since they miss some features, and each release a different set (Microsoft, king of tricks ;)) The newest SDK installed that works with the selected Visual Studio should be automatically chosen. Some nice decision tree needed here :) I also think we should get rid of the oowintool script. Not because it is Perl;) (I like Perl), but because it doesn't do anything that would be especially complicated to do directly in configure instead, Splitting similar logic into two places is always bad. And much of what oowintool currently does can is presumably obsolete and can be simplified anyway. Yes, absolutely. I like perl, too, but oowintool is used only in configure and download (for testing, which could be handled by configure variables). It will /just/ be a new set of functions. Now, the problem with implementing this idea is just that testing it for all relevant combinations might take a lot of time... But if I try to make it work the best I can on my machine, and then let other Windows builders try other combinations... I have all three Visual Studios, but I am not sure if some of my SDKs are incomplete or broken. I can help on this side, too. --tml -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Le Thu, 29 Nov 2012 18:20:45 +0100, Lionel Elie Mamane a écrit: On Thu, Nov 29, 2012 at 04:45:57PM +, Michael Meeks wrote: * Release Engineering update (Petr) + 4.0 timeline: Monday: feature-freeze ... + please let Petr know if you're late Well, as stated in [1], I could be either late or unstable, whichever you prefer First goal is to be on-time and /maybe/ unstable. PS: And I might be late *and* unstable, but that will be unfortunate :) -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Hello Petr, Le Fri, 30 Nov 2012 17:53:30 +0100, Petr Mladek a écrit: Mat M píše v Pá 30. 11. 2012 v 01:42 +0100: Le Thu, 29 Nov 2012 18:20:45 +0100, Lionel Elie Mamane a écrit: > On Thu, Nov 29, 2012 at 04:45:57PM +, Michael Meeks wrote: > >> * Release Engineering update (Petr) >>+ 4.0 timeline: Monday: feature-freeze ... >>+ please let Petr know if you're late > Well, as stated in [1], I could be either late or unstable, whichever you prefer First goal is to be on-time and /maybe/ unstable. Heh, shame on me, I do not know what feature you are working on :-) What You do not know what every LO contributor is currently working on ?! What a shame! :-D Well, actually, I put a nice [1] for reference, but not the link, so: https://bugs.freedesktop.org/show_bug.cgi?id=56902#c1 We want an usable beta1 so that people could test it. Hence, if your feature affects only limited functionality, do not be afraid to get it beta1 even when it has bugs. If it affects some core functionality and is there a risk that some bug could affect most users => break testing, I would prefer to leave it for beta2. If you leave it for beta2, please commit it as soon as possible and ask for testing on the libreoffice...@lists.freedesktop.org mailing list. They will be able to use daily builds and catch problems even before beta2. ok, will try ty -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reworking the MSVC-related build options
Le Mon, 03 Dec 2012 10:06:46 +0100, Tor Lillqvist a écrit: Below is what have so far, not finished yet, still bugs in the changes, and I probably want to get rid of the remaining uses of oowintool, and then before committing I need to verify carefully that it produces an equivalent config_host.mk as the old one (and that it builds, of course) for all three compilers (2008, 2010, 2012), including VS Express 2008. Does anybody use VS Express 2010? Me, me, me !!! :-) Although it is sometimes not handy (missing merge module is a pain, you know.) BTW, just to make sure, am I correct in assuming that nobody is intentionally, and out of *real* need, using any of these options: --with-cl-home (in the case where you only have one Visual C++/Visual Studio installed anyway) --with-al-home --mspdb-path --midl-path --csc-path --dotnet-framework-home This one, because /lib/mscoree.lib is not where you expect it (In my case, in an SDK 6 subfolder) --windows-sdk-home This one was required to use latest SDK with not latest VS, like VS2008 (which comes with SDK 6) and SDK 7.1 --directx-home Well, you can find it in registry, but there is no standard variable that points to it. So you either add a bunch of registry lookup or ask for the path. --asm-home If you do use some of those, please verify that it really is needed, i.e. check what happens if you remove the option: compare the generated config_host.mk, and compare what happens when you build an affected module, thanks! Then report back here. Without the ones I used, configure just exits with an error and config_host.mk is not generated, so... I know, I am a killjoy :) --tml AC_ARG_WITH(mozilla-build, AS_HELP_STRING([--with-mozilla-build], -[For Windows users, please supply the path to the Mozilla build tools.]) +[Specify the path to the Mozilla build tools.]) [ Usage: --with-mozilla-build=path to Mozilla build tools> I disagree here. this argument (which I renamed in a pending work), is used only for Windows. Other Oses provides tools in their system. HTH -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reworking the MSVC-related build options
Good evening Tor, all Le Tue, 04 Dec 2012 07:24:18 +0100, Tor Lillqvist a écrit: Does anybody use VS Express 2010? Me, me, me !!! :-) OK, will have to test with that, too, then... I could if you push a branch somewhere --dotnet-framework-home This one, because /lib/mscoree.lib is not where you expect it (In my case, in an SDK 6 subfolder) OK, still that should be automateable, I hope. Yes. I think it resolves to check for mscoree.lib in current Win SDK, then search in the other WinSDKs. --windows-sdk-home This one was required to use latest SDK with not latest VS, like VS2008 (which comes with SDK 6) and SDK 7.1 OK. But does one actually win anything by using a newer SDK than the one that cvame with the compiler, *when building LibreOffice*? (I used to have the 7.1 one myself, too, can't remember why. Anyway, it caused horrible problems when uninstalling and re-installing VS2010...) Well, as soon as you have more than one version of SDK, it could be a pain. --directx-home Well, you can find it in registry, but there is no standard variable that points to it. But oowintool manages to find it, so it can't be impossible? Or is that just some versions of the DirectX SDK? As the latest DirectX SDK seems to be the June 2010 one, isn't it, could one assume that everybody should have that by now? (Is that really the latest? Has that technology then been merged into something else SDK-wise?) oowintool provides nothing to this regard currently. We define the argument for it. I tried to find a way to find it, but found none. HTH -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Reworking the MSVC-related build options
Le Wed, 05 Dec 2012 16:56:23 +0100, Norbert Thiebaud a écrit: On Wed, Dec 5, 2012 at 9:43 AM, Tor Lillqvist wrote: to be able to reproduce a scenario: build using the same config than the one that broke ? Hmm, but there are tons of stuff that can break in various ways, should we have options permanently in there to intentionally reproduce all of them? if something _is_ optional then both way should 'work' (that is not abend/cpu-loop/eat-you-document if one try to use a feature that require that 'option' for instance' And therefore it is usefull to be able to force that options on build. As stated by [1], "Remove DirectX implementation for the new XCanvas interface." As came from blame, option was added in 2004 [3]: "2004/05/08 04:44:48 waratah 1.63.8.6: #i26548# Change directx default to on and allow disable" Since 2004, we can assume we only need to disable in special cases (since it is the default, and fallback may deprecate anytime from now). I am in favor of removing --disable-directx and --with-directx-home, warning that we did not found DXSDK_DIR and it needs to be set if desired. DXSDK_DIR seems to be provided by installer, so we can complain about not finding it. and Directx SDK is part of prerequisites [2].If you ever need to disable it, just unset DXSDK_DIR. I'm agreeing completely with you that in the absence of any user input, autogen should pick up the mos recent VS available and DirectX if available etc.. I also strongly agree that a single argument to select the VS version when one has more than one is desirable to select a consistent/coherent set of values but still the ability to override is still desirable in corner case... that may not have to be via argument from the command line.. that can also be like for CC, if the value is set in the env, then honor it, otherwise find a best effort value. Norbert PS: if there are combination of options that are not supported, autogen _should_ ideally block them. for instance if system-python is incompatible with internal-openssl, then that should be detected and blocked at configure time. we agree [1] http://wiki.documentfoundation.org/Development/How_to_build/Configure_options [2] http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies [3] http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c01781236a2ea76217f6cad300dfbdfe5ce5ba4 -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Gerrit - issue submitting a patch
Hello I have an issue: It rejected my submission with the following message: mm@FAUCON /cygdrive/d/src/libo10 $ git log -n 1 commit 40acf39922f6cada7c724751a7b819c1950e7b38 Author: Mathias Michel Date: Sat Dec 8 18:19:20 2012 +0100 configure VS dll from system for express version Change-Id: Ia79bf2e8afc9413f3ff26412a0d16f71b28e10ea mm@FAUCON /cygdrive/d/src/libo10 $ ./logerrit submit master Enter passphrase for key '/home/mm/.ssh/id_dsa': Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 616 bytes, done. Total 4 (delta 2), reused 0 (delta 0) remote: Resolving deltas: 100% (2/2) remote: Processing changes: refs: 1, done remote: ERROR: missing Change-Id in commit message remote: Suggestion for commit message: remote: Merge branch 'master', remote-tracking branch 'origin/master' remote: remote: Change-Id: If4d880d9f00115d789d0957d886faba797a19ef8 To ssh://logerrit/core ! [remote rejected] HEAD -> refs/for/master (missing Change-Id in commit message) error: failed to push some refs to 'ssh://logerrit/core' As the first command exhibits, I do have a Change-Id. Could it be related that this is a linked workdir and not a plain workdir of a repo ? Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Gerrit - issue submitting a patch
Hello I also cannot submit it from the main workdir, just beside the repo. That's annoying. Will try another branch later. Le Sat, 08 Dec 2012 18:35:52 +0100, Mat M a écrit: Hello I have an issue: It rejected my submission with the following message: mm@FAUCON /cygdrive/d/src/libo10 $ git log -n 1 commit 40acf39922f6cada7c724751a7b819c1950e7b38 Author: Mathias Michel Date: Sat Dec 8 18:19:20 2012 +0100 configure VS dll from system for express version Change-Id: Ia79bf2e8afc9413f3ff26412a0d16f71b28e10ea mm@FAUCON /cygdrive/d/src/libo10 $ ./logerrit submit master Enter passphrase for key '/home/mm/.ssh/id_dsa': Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 616 bytes, done. Total 4 (delta 2), reused 0 (delta 0) remote: Resolving deltas: 100% (2/2) remote: Processing changes: refs: 1, done remote: ERROR: missing Change-Id in commit message remote: Suggestion for commit message: remote: Merge branch 'master', remote-tracking branch 'origin/master' remote: remote: Change-Id: If4d880d9f00115d789d0957d886faba797a19ef8 To ssh://logerrit/core ! [remote rejected] HEAD -> refs/for/master (missing Change-Id in commit message) error: failed to push some refs to 'ssh://logerrit/core' As the first command exhibits, I do have a Change-Id. Could it be related that this is a linked workdir and not a plain workdir of a repo ? Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question about sc/source/core/data/colorscale.cxx
Hello Markus
Le Sat, 15 Dec 2012 15:39:26 +0100, Markus Mohrhard
a écrit:
Hey,
I noticed these lines in file sc/source/core/data/colorscale.cxx
(because cppcheck report indicates that bNeedUpdate is reassigned
before to
be used line 641)
637 void ScDataBarFormat::DataChanged(const ScRange& rRange)
638 {
639 bool bNeedUpdate = false;
640
641 bNeedUpdate = NeedUpdate(mpFormatData->mpUpperLimit.get());
642 bNeedUpdate &= NeedUpdate(mpFormatData->mpLowerLimit.get());
643
644 bNeedUpdate &= GetRange().Intersects(rRange);
645
646 if(bNeedUpdate)
647 {
648 mpDoc->RepaintRange(GetRange());
649 }
650 }
First I wonder if we shouldn't avoid to bitwise and and logical and. But
above all, shouldn't it be logical OR?
Only for the first one. For the second one the OR is totally wrong and
will force always a repainting which is a preformance nightmare.
So I would rather put:
if( (NeedUpdate(mpFormatData->mpUpperLimit.get()))
|| (NeedUpdate(mpFormatData->mpLowerLimit.get())) ||
(GetRange().Intersects(rRange)) )
{
mpDoc->RepaintRange(GetRange());
}
What do you think?
Implemented a correct version with
4f901a2f451a552853c1dd38309dd55b22616fdd.
Sorry but what I see in 4f901a2f45 is the same thing as Julien pasted in
his mail.
It rollback the good version:
$ git diff
4f901a2f451a552853c1dd38309dd55b22616fdd..4f901a2f451a552853c1dd38309dd55b22616fdd^
diff --git a/sc/source/core/data/colorscale.cxx
b/sc/source/core/data/colorscale.cxx
index f5d23c1..2adf507 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -636,8 +636,10 @@ bool NeedUpdate(ScColorScaleEntry* pEntry)
void ScDataBarFormat::DataChanged(const ScRange& rRange)
{
-bool bNeedUpdate = NeedUpdate(mpFormatData->mpUpperLimit.get());
-bNeedUpdate |= NeedUpdate(mpFormatData->mpLowerLimit.get());
+bool bNeedUpdate = false;
+
+bNeedUpdate = NeedUpdate(mpFormatData->mpUpperLimit.get());
+bNeedUpdate &= NeedUpdate(mpFormatData->mpLowerLimit.get());
bNeedUpdate &= GetRange().Intersects(rRange);
Could you check if I missed something ?
Regards
--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question about sc/source/core/data/colorscale.cxx
Le Sat, 15 Dec 2012 21:43:41 +0100, Markus Mohrhard a écrit: Hey Mat, [...] Maybe your confusion comes from using ^ at the wrong place. Try git diff 4f901a2f451a552853c1dd38309dd55b22616fdd^..4f901a2f451a552853c1dd38309dd55b22616fdd Dammit! Git should know it and fix it by himself! :) Regards, Markus Thanks for clarification of my fuzzy brain -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Configure.ac questions
Hello When reviewing Bjoern's change, I stumble upon two wierd-to-me things: Since lcms2 is a dependency of libcdr, can't we bind the build option of lcms2 to libcdr one ? I mean if we use sytem's libcdr, also use lcms2 from system, no ? I need enlightment: in configure, we define WPS_CFLAGS (MS Works import lib). It is used in RepositoryExternal.mk, in gb_LinkTarget__use_wps when I git grep this function, I found it nowhere else. A recursive grep on a not-clean repo did not give more impact. Does it imply that it is not used anymore or is ther an hidden feature somewhere ? ty for input :) Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Gbuild explanation
Hello, Le Thu, 16 May 2013 06:07:32 +0200, David Tardon a écrit: Hi, On Thu, May 16, 2013 at 01:22:10AM +0200, Mat M wrote: Hello I have a GNU make question, actually: How this should be read ? $(dir $(call gb_AutoInstallLibs_get_target,%)).dir : $(if $(wildcard $(dir $@)),,mkdir -p $(dir $@)) We use rules to automatically create directory hierarchies for file targets in gbuild. This is the rule for creating the top-level directory of the AutoInstallLibs class in $(WORKDIR). There is a line like So I was right in my reading, ty. $(call gb_AutoInstallLibs_get_target,$(1)) :| $(dir $(call gb_AutoInstallLibs_get_target,$(1))).dir elsewhere in the makefile, that creates the (order-only) dependency. Note that $(dir $(call gb_AutoInstallLibs_get_target,%)).dir expands to $(WORKDIR)/AutoInstallLibs/.dir , so this is not a pattern rule. If there were any hierarchy needed in the directory, the rule would be accompanied by $(dir $(call gb_AutoInstallLibs_get_target,%))%/.dir : $(if $(wildcard $(dir $@)),,mkdir -p $(dir $@)) Then what is the purpose of the % in the $(call and the $(1) btw, since get_target already knows until AIL ? Is it just so all get_target vars are built in the same way ? Even if this is the case the % is a mystery for me. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Dropping support for Visual Studio 2008 in master branch
Hello Or, as mentioned on the wiki [1], you can download the Driver Development Kit [2], which still includes ATL & MFC headers, at least in v7.1. And the EULA does not mark them as unusable or not distributable. 1: https://wiki.documentfoundation.org/Development/BuildingOnWindows#Getting_ATL_work_with_Visual_Studio_Express 2: http://msdn.microsoft.com/en-us/library/windows/hardware/gg454508.aspx Le Wed, 29 May 2013 18:12:57 +0200, Thomas Arnhold a écrit: Hi Regina, On 29.05.2013 16:28, Regina Henschel wrote: Is a build possible with the Express version, on Windows 7, so that it includes ATL? No, the Express version doesn't include ATL. "The only legal way to do this is to purchase a retail version of Visual Studio C++ and install it on the same machine as Visual Studio C++ Express. You can then copy the appropriate ATL headers from the retail version to the express version." http://social.msdn.microsoft.com/Forums/en-US/Vsexpressvc/thread/f1bd57fb-ef09-480d-b367-2e9fb2a1383d/ Thomas -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Dropping support for Visual Studio 2008 in master branch
Hello all Le Fri, 31 May 2013 23:30:34 +0200, Michael Stahl a écrit: On 29/05/13 16:28, Regina Henschel wrote: Hi Tor, Tor Lillqvist schrieb: Unless somebody can give a *really* good reason, I plan to explicitly drop support for building the master branch with MSVS 2008 soon. It might be that this support was already unintentionally broken earlier today or yesterday, and it would be easiest to just follow up and do it completely. Note that already the TDF 4.0 build has been built with MSVS 2010. Is a build possible with the Express version, on Windows 7, so that it includes ATL? most likely nobody here has tried if the trick with the DDK works with MSVC 2010 or 2012 as well - other replies indicate not many are aware that it was even possible. but chances are good since presumably it's just some headers and .lib files that just need to be put on compiler's search path. I tried on VS2010 and it worked. just had another issue related to msvcrt merge module which does not come with it but seems mandatory to LO for the msi. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Cygwin] [Master] failure when compiling liblangtag
Hello it was already like that yesterday, and to day too, with commit 7f101a29e12ce6ca After a failure of a "standard make", I did: make liblangtag.clean && make verbose=t liblangtag which told me cd D:/src/libo/liblangtag && /opt/lo/bin/make -j 4 -rsr clean And here is the end of the log == Build Information == CFLAGS: -g LDFLAGS: make[2]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' /opt/lo/bin/make all-recursive make[3]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' Making all in liblangtag make[4]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' /opt/lo/bin/make all-recursive make[5]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' make[6]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' CC liblangtag_la-lt-database.lo CC liblangtag_la-lt-error.lo CC liblangtag_la-lt-ext-module.lo CC liblangtag_la-lt-ext-module-data.lo cl : Command line error D8003 : missing source filename cl : Command line error D8003 : missing source filename cl : Command line error D8003 : missing source filename cl : Command line error D8003 : missing source filename make[6]: *** [liblangtag_la-lt-ext-module.lo] Error 1 make[6]: *** Waiting for unfinished jobs make[6]: *** [liblangtag_la-lt-database.lo] Error 1 make[6]: *** [liblangtag_la-lt-error.lo] Error 1 make[6]: *** [liblangtag_la-lt-ext-module-data.lo] Error 1 make[6]: Leaving directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' make[5]: *** [all-recursive] Error 1 make[5]: Leaving directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' make[4]: *** [all] Error 2 make[4]: Leaving directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' make[2]: *** [all] Error 2 make[2]: Leaving directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' make[1]: *** [D:/src/libo/workdir/wntmsci13.pro/ExternalProject/langtag/build] Error 2 make[1]: Leaving directory `/cygdrive/d/src/libo/liblangtag' make: *** [liblangtag] Error 2 Win7 x64, VS2010 Any help welcomed. -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Cygwin] [Master] failure when compiling liblangtag
Le Fri, 12 Apr 2013 13:30:55 +0200, Michael Stahl a écrit: On 11/04/13 00:29, Mat M wrote: Hello it was already like that yesterday, and to day too, with commit 7f101a29e12ce6ca After a failure of a "standard make", I did: make liblangtag.clean && make verbose=t liblangtag which told me cd D:/src/libo/liblangtag && /opt/lo/bin/make -j 4 -rsr clean looks like the GCC wrapper that is used on windows is doing something wrong... please edit solenv/gcc-wrapper/wrapper.cxx around line 151 there is a commented out printing of the arguments that are passed to cl.exe; i hope you should be able to find out what is going wrong going backwards from there. Thank you Michael Command is : C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-database.c So SRCDIR stops at langtag, but lt-database.c is in liblangtag, but we also see make entering liblangtag subdir. The langtag Makefile needs a fix ? Full log from liblangtag make: == Build Information == CFLAGS: -g LDFLAGS: make[2]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' /opt/lo/bin/make all-recursive make[3]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag' Making all in liblangtag make[4]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' /opt/lo/bin/make all-recursive make[5]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' make[6]: Entering directory `/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag/liblangtag' CC liblangtag_la-lt-database.lo CC liblangtag_la-lt-error.lo CC liblangtag_la-lt-ext-module.lo CC liblangtag_la-lt-ext-module-data.lo CMD= C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-error.c CMD= C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-database.c CMD= C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-ext-module.c CMD= C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-
Make recipes
Hello Since ~2 weeks, I have some warnings from Makefile about: $ make Makefile:423: warning: overriding recipe for target `translations' Makefile:94: warning: ignoring old recipe for target `translations' /opt/lo/bin/make -j 4 -rsr -f D:/src/libo/Makefile.gbuild /cygdrive/d/src/libo/pyuno/Library_pyuno.mk:27: warning: overriding recipe for target `D:/src/libo/workdir/wntmsci13.pro/LinkTarget/Library/pyuno.pyd' /cygdrive/d/src/libo/pyuno/Library_pyuno.mk:27: warning: ignoring old recipe for target `D:/src/libo/workdir/wntmsci13.pro/LinkTarget/Library/pyuno.pyd' Do you have the same thing under linux ? I attached my makefile just in case. -- Mat M Makefile Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Master branch now requires liborcus 0.5.0 or higher.
Le Mon, 22 Apr 2013 19:55:55 +0200, Bjoern Michaelsen a écrit: [Big snip of stuff that flies way over my head :-)] > Finally, let me encourage you to become/stay a 'build expert' yourself at least > to the point that you can judge if adding yet another feature/scenario to the > build system will introduce new complexity(*). meh... we can't demand everybody become a build expert :) I dont think having everyone tweaking on it would be a good thing even, but enough of an idea about it to have a basic opinion on what to do and what not is a good think IMHO. One of the main tool for that is documentation. Although we have long command names, it is not obvious for everyone what each function is supposed to do (means, at least what it returns, what will be fed by the eval). A glossary of the functions and a pointer to a Good Use(tm) of it in an existing makefile may help a lot. My 2 cents -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Cygwin] [Master] failure when compiling liblangtag
Hi Eike & Peter Le Tue, 16 Apr 2013 15:44:28 +0200, Eike Rathke a écrit: Hi Mat, Cc'ing Peter Foley who did the gcc-wrapper. On Friday, 2013-04-12 23:49:16 +0200, Mat M wrote: Command is : C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci13.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci13.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-database.c So SRCDIR stops at langtag, but lt-database.c is in liblangtag, but we also see make entering liblangtag subdir. The langtag Makefile needs a fix ? The SRCDIR looks correct, SRCDIR here specifies the top directory where the entire source package is located, not it's various subdirectories. Does the wrapper actually execute the command in that then current subdirectory? I added an output of the CWD and get: PWD= D:\src\libo\workdir\wntmsci14.pro\UnpackedTarball\langtag\liblangtag CMD= C:\cygwin\opt\lo\bin\ccache.exe cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci14.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci14.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci14.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-database.c cl : Command line error D8003 : missing source filename When I go to the directory, set the PATH according to the one from config_host.mk, I get : mm@FAUCON /cygdrive/d/src/libo/workdir/wntmsci14.pro/UnpackedTarball/langtag/liblangtag $ /cygdrive/c/PROGRA~2/MICROS~1.0/VC/bin/cl.exe -nologo -EHsc -MD -Gy -Zc:wchar_t- -Ob1 -Oxs -Oy- -DHAVE_CONFIG_H -I. -I.. -I../liblangtag/ -I.. -I../liblangtag/ -I.. -D__LANGTAG_COMPILATION -DBUILDDIR=\"/cygdrive/d/src/libo/workdir/wntmsci14.pro/UnpackedTarball/langtag\" -DSRCDIR=\"/cygdrive/d/src/libo/workdir/wntmsci14.pro/UnpackedTarball/langtag\" -DREGDATADIR=\"/usr/local/share/liblangtag\" -DLANGTAG_EXT_MODULE_PATH=\"/usr/local/lib/liblangtag\" -ID:/src/libo/workdir/wntmsci14.pro/UnpackedTarball/xml2/include -DG_LOG_DOMAIN=\"LangTag\" -Zi -c -showIncludes lt-database.c lt-database.c Note: including file: D:\src\libo\workdir\wntmsci14.pro\UnpackedTarball\langtag\config.h lt-database.c(17) : fatal error C1083: Cannot open include file: 'string.h': No such file or directory Which is a different error. I get the D8003 when I try to run that in another directory, which makes me think that although getcwd retrieves the current dir, it may not be the one use as for launching the command. But CreateProcess should use the same since the parameter is set to NULL [1]. SO really no clue there. This error cl : Command line error D8003 : missing source filename is not accidentally caused by the -c option being followed by the -showIncludes option? Nope. I tried both to remove any doubt. However, what also looks suspicious to me is that the renaming of the object file does not occur anywhere on that command line, apparently the target should be CC liblangtag_la-lt-database.lo make[6]: *** [liblangtag_la-lt-database.lo] Error 1 so there should be some -o option followed by the output filename if I'm not mistaken. And, last but not least, why does this fail only for Mat? My tree is on 29dcdf6b56f8dbc1b7d, and I did a git clean -fxd before make. Seeing wntmsci13.pro in the workdir path suggests this is MSVC 2010, correct? Maybe that simply works different.. Well, as we tend to support VS 2008, 2010 & 2012 in build setup, we should have them also supported in gcc-wrapper. BTW, moved to VS2012 no-express meanwhile [1] http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build warning in pyuno
Hello I don't know how to fix this, but with cygwin on Win7-x64, I have the following warning when starting tail_build: gbuild module /cygdrive/d/src/libo/tail_build: /opt/lo/bin/make -f Makefile -j4 -rs all slowcheck /cygdrive/d/src/libo/pyuno/Library_pyuno.mk:27: warning: overriding recipe for target `D:/src/libo/workdir/wntmsci13.pro/LinkTarget/Library/pyuno.pyd' /cygdrive/d/src/libo/pyuno/Library_pyuno.mk:27: warning: ignoring old recipe for target `D:/src/libo/workdir/wntmsci13.pro/LinkTarget/Library/pyuno.pyd' I am not sure if it is meaningful neither... Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] new upstream release liblangtag-0.5.1
Le Tue, 30 Apr 2013 22:21:33 +0200, Eike Rathke (via Code Review) a écrit: Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3676 Approvals: LibreOffice gerrit bot: Verified Eike Rathke: Verified; Looks good to me, approved Thanks for that, Eike. I began to try fixing 0.4.0, but was not so easy. ccache disabled for now, will try to introduce it back later on. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Killing the gerrit to dev-list spam ...
Hello, Le Wed, 01 May 2013 21:33:49 +0200, Bjoern Michaelsen a écrit: Hi, Looking at: http://nabble.documentfoundation.org/Dev-f1639786.html depending on time of day you find 50-90% patch mails on there. As the writer of mail forward I have been repeatedly asked if we can kill this spam. I fully agree with this sentiment -- the dev-list should be taylored to be inviting to a wide audience of volunteer contributors and not only to those hardcore contributors who are full-time sponsored developers. I dont think the ESC is the right place to decide this as it is overwhelmingly filled with the second. So, is there anyone who is _not_ a sponsored developer opposing to kill the mail spammage? If so: As a non-sponsored(!) developer (?), I am not opposed to kill the gerrit mail flow. - could this be mitigated by a separate gerrit-patches mailing list? - could this be mitigated by a daily digest of "gerrit news"? - could this be mitigated by other means? Yes, IMO, the goal is to have an overview of what was commited, so a daily digest of *pushed* patches should be enough. Although this kind of thing will narrow the reviewers list to commiters & aked-for-review, which is almost the ESC & sponsored developers list. So after small thinking, a daily digest with 2 parts: pushed patches and yet-to-review patches, trying to increase peer reviewing by other devs. I think the drowning of the list with automated patch mail is really hurting us (as did the patch mails before). Note that this does: [SNIP] +1, note included :) I was forced to do the mail forward thingie to accomodate migration of antiquiated workflows -- I was never very happy with it and really embarrased to defend it when I would have never done it like that myself. Opinions? Done Best, Not sur these are the best opnions, but, well, YMMV ;-) Regards Bjoern -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Killing the gerrit to dev-list spam ...
Hello all, Le Thu, 02 May 2013 10:28:57 +0200, Lionel Elie Mamane a écrit: On Wed, May 01, 2013 at 10:01:12PM +0200, Mat M wrote: Yes, IMO, the goal is to have an overview of what was commited, IMO, no, it is not. It is about seeing what is proposed to come in Well, actually, IMO meant from my side... Sorry for misspelling *before* it does. To see stuff "after the fact" we have *another* mailing list, namely http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits I always forget it. TY for the reminder :) gerrit ML (if done) and lo-commits should be mentioned, maybe in ESC reports and/ or in tags & branches announcements. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Master branch now requires liborcus 0.5.0 or higher.
Le Tue, 23 Apr 2013 11:59:39 +0200, Bjoern Michaelsen a écrit: Hi, On Mon, Apr 22, 2013 at 10:14:50PM +0200, Mat M wrote: A glossary of the functions and a pointer to a Good Use(tm) of it in an existing makefile may help a lot. Looking at the replies we seem to actually have quite a bit of docs, they are just distributed all over the net and some might be a bit outdated. Are you maybe interested in updating: https://wiki.documentfoundation.org/Development/Build_System to link and collect them all? Best, Bjoern I started doing it. Check https://wiki.documentfoundation.org/Development/Build_System to be sure you see it without looking to page history :) If I have questions about gbuild (and be sure I will :) ), what is the preferred way: - Asking the list through a dedicated thread - Private mails to gbuild experts (Volunteers, one step ahead) - Asking list + CCing gbuild experts - TOBECONFIRMED tags in the wiki - any other mean I did not thought about which is still convenient for akser and answerer :) I am CEST timed and could not reach IRC during work hours, alas. BTW, I am not sure it will be the best way. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Makefile and SHELL
Hello In Makefile.in, we enforce bash with SHELL=/usr/bin/env bash, but we state that the build should be posix enabled (at least I was told that :)) , so why not SHELL=/usr/bin/env sh or SHELL=/bin/sh (or nothing, since latter is default) ? I understand that some scripts still need bash, but they have the right shebang line and SHELL will be the default shell used by $(shell...) command, no ? Moreover, in Makefile.gbuild we have : ifdef gb_SHELL SHELL := $(gb_SHELL) else SHELL := /bin/sh endif So SHELL in global makefile is only used for sources.ver from tarball and to echo the version to sed, so we can : - remove the SHELL assignment in Makefile.in - remove the else part of the ifdef in Makefile.gbuild regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Bugzilla question
Hello When looking at https://bugs.freedesktop.org/show_bug.cgi?id=64298, I realized that it is possible for a bug to be in ASSIGNED state with no actual login set in the "Assigned" field. Is it an expected behaviour or a missing chekpoint ? Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Gbuild explanation
Hello I have a GNU make question, actually: How this should be read ? $(dir $(call gb_AutoInstallLibs_get_target,%)).dir : $(if $(wildcard $(dir $@)),,mkdir -p $(dir $@)) What I understand: the $(call retrieves the variable content and pass the list of files in the current module directory as arguments. The first one is kept (from TargetLocations.mk, which says gb_AutoInstallLibs_get_target = $(WORKDIR)/AutoInstallLibs/$(1) ) We append a ".dir" to be sur to have a filename to give to $(dir, which will go up one level. $@ will be the result of $(dir (something like $WORKDIR/AutoInstallLibs/ ?) wildcard will test if the parent $WORKDIR exists, else we mkdir. I know it seems silly to test $WORKDIR, so presumably I miss something in the $(call part, but I don't see what. Thanks for the input Best regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Get rid of nsinstall hackery
Hi Peter, Two caveats I want to submit : what happens if --disable-python is here ? And this thread [1] has never come to a solution about ssl API, but your change may conflict with one of the scenarios if the python version is not enough. [1] http://lists.freedesktop.org/archives/libreoffice/2012-May/031198.html -- Regards Mat M Le Thu, 03 Jan 2013 00:25:21 +0100, Peter Foley (via Code Review) a écrit: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1534/1 Get rid of nsinstall hackery This removes the need for using NSS Build Tools on windows. It also removes the nees to build nss for the build system while cross compiling. Change-Id: I13c9fdb575223f2940d3e4eda00e77ba9158f2b7 --- M Makefile.in M config_host.mk.in M configure.ac M nss/ExternalProject_nss.mk M nss/Module_nss.mk M nss/nsinstall.py 6 files changed, 9 insertions(+), 35 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2a56db0..0b54e3b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -298,13 +298,6 @@ $(GNUMAKE) gb_Side=build icu # cd cross_toolset && $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -# -ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) -ifneq (WNT,$(OS)) -# We need to build nss for nsinstall... See NSINSTALL=... in nss/makefile.mk - $(GNUMAKE) gb_Side=build nss -endif -endif # # Install diff --git a/config_host.mk.in b/config_host.mk.in index 70f8c4e..1c98744 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -411,7 +411,6 @@ export NSS_PATCH=@NSS_PATCH@ export NSS_CFLAGS=$(gb_SPACE)@NSS_CFLAGS@ export NSS_LIBS=$(gb_SPACE)@NSS_LIBS@ -export NSSBUILDTOOLS=@NSSBUILDTOOLS@ export NUMBERTEXT_EXTENSION_PACK=@NUMBERTEXT_EXTENSION_PACK@ @x_OBJCFLAGS@ export OBJCFLAGS=@OBJCFLAGS@ @x_OBJCXXFLAGS@ export OBJCXXFLAGS=@OBJCXXFLAGS@ diff --git a/configure.ac b/configure.ac index c60ae01..4b32e6b 100644 --- a/configure.ac +++ b/configure.ac @@ -8281,22 +8281,6 @@ NSS_PATCH="5" BUILD_TYPE="$BUILD_TYPE NSS" AC_MSG_RESULT([internal]) -if test "$build_os" = "cygwin"; then -AC_MSG_CHECKING([for nss build tooling]) # coming from mozilla -if test -z "$NSSBUILDTOOLS"; then -AC_MSG_ERROR([nss build tooling not provided -Use the --with-nss-build-tools option after installing the tools obtained -from http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32]) -else -if test \( "$WITH_MINGW" = "yes" -a ! -d "$NSSBUILDTOOLS" \) \ --o ! -d "$NSSBUILDTOOLS/moztools" \ --o ! -d "$NSSBUILDTOOLS/msys" ; then -AC_MSG_ERROR([nss build tooling incomplete!]) -else -AC_MSG_RESULT([ok]) -fi -fi -fi fi # system nss AC_SUBST(SYSTEM_NSS) AC_SUBST(NSS_MAJOR) @@ -8304,7 +8288,6 @@ AC_SUBST(NSS_PATCH) AC_SUBST(NSS_CFLAGS) AC_SUBST(NSS_LIBS) -AC_SUBST(NSSBUILDTOOLS) AC_SUBST(MINGW_SMIME3_DLL) dnl === diff --git a/nss/ExternalProject_nss.mk b/nss/ExternalProject_nss.mk index 330a6e6..7ddbcae 100644 --- a/nss/ExternalProject_nss.mk +++ b/nss/ExternalProject_nss.mk @@ -34,15 +34,15 @@ ifeq ($(OS),WNT) ifeq ($(COM),MSC) -$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) +$(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject_get_state_target,nss,configure) $(call gb_ExternalExecutable_get_dependencies,python) cd $(EXTERNAL_WORKDIR)/mozilla/security/nss \ && $(if $(debug),,BUILD_OPT=1) \ MOZ_MSVCVERSION=9 OS_TARGET=WIN95 \ - PATH="$(NSSBUILDTOOLS)/msys/bin:$(NSSBUILDTOOLS)/moztools/bin:$(PATH)" \ $(if $(filter X,$(CPU)),USE_64=1) \ LIB="$(ILIB)" \ XCFLAGS="$(SOLARINC)" \ $(MAKE) -j1 nss_build_all RC="rc.exe $(SOLARINC)" \ + NSINSTALL='$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/nss/nsinstall.py' \ && touch $@ @@ -53,7 +53,7 @@ CXX="$(CXX) $(if $(filter YES,$(MINGW_SHARED_GCCLIB)),-shared-libgcc)" \ OS_LIBS="-ladvapi32 -lws2_32 -lmwsock -lwinm $(if $(filter YES,$(MINGW_SHARED_GXXLIB)),$(MINGW_SHARED_LIBSTDCPP))" \ OS_TARGET=WINNT RC="$(WINDRES)" OS_RELEASE="5.0" \ - PATH="$(NSSBUILDTOOLS)/bin:$(PATH)" IMPORT_LIB_SUFFIX=dll.a \ + IMPORT_LIB_SUFFIX=dll.a \ NSPR_CONFIGURE_OPTS="--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) --enable-shared --disable-static" \ NSINSTALL="$(PYTHON_FOR_BUILD) $(SRCDIR)/nss/nsinstall.py" \ $(MAKE) -j1 nss_build_all \ @@
[master] installer issue in Windows
Hi everybody, Trying to build from 484bb96aa975, I got an error when doing install sets. Here is the short error message from instsetoo_native: ERROR: The following files could not be found: ERROR: File not found: emserlo.dll ERROR: File not found: oleautobridge.uno.dll ERROR: File not found: so_activex.dll ERROR: Failure in installer.pm ERROR: ERROR: Missing files at D:/src/libo/solenv/bin/modules/installer/scriptitems.pm line 1280 I kept the script log (log_OOO410_en-US.log) if anyone needs it. My autogen.lastrun is: --disable-directx --disable-odk --disable-build-mozab --with-nss-build-tools=/cygdrive/c/data/mozilla-build --with-ant-home=/ant --with-visual-studio=2010 --without-junit --without-doxygen --without-help --disable-atl --disable-activex I am building with VC2010 Express (so disabled activex & atl) on Win7 x64. It seems all the mentioned files are relatied to activeX and ole, which may miss because of activex & atl. Is there a way to circumvent that fromscripts ? If not, there is always the WinDDK option to get atl & ùfc files needed anyway. But that means we lose the easy "express" option for MSVC*, though. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [master] installer issue in Windows
Hi Michael Le Mon, 14 Jan 2013 11:15:50 +0100, Michael Meeks a écrit: Hi Mat, On Sun, 2013-01-13 at 01:53 +0100, Mat M wrote: Trying to build from 484bb96aa975, I got an error when doing install sets. Here is the short error message from instsetoo_native: Ah - that is annoying. This means that your setup_osl.bin that should be in the solver/ mentions these things but they have not been built. Perhaps you changed your configure options after building 'scp2' ? try: make scp2.clean make scp2 make scp2.deliver or somesuch. Failing that - manually hack the setup_osl.bin to remove these files (the references to them don't matter so much though). You're nearly there :-) Actually, I was missing a --disable-activex-scripting configure flag, which was unknown to me and I found it by git grepping activex when digging in the code. Thanks for your pointers anyway, it could help in the future :) Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [master] installer issue in Windows
Re Le Mon, 14 Jan 2013 20:15:24 +0100, Mat M a écrit: Le Mon, 14 Jan 2013 11:15:50 +0100, Michael Meeks a écrit: On Sun, 2013-01-13 at 01:53 +0100, Mat M wrote: Trying to build from 484bb96aa975, I got an error when doing install sets. Here is the short error message from instsetoo_native: Ah - that is annoying. This means that your setup_osl.bin that should be in the solver/ mentions these things but they have not been built. [...] You're nearly there :-) Actually, I was missing a --disable-activex-scripting configure flag, which was unknown to me and I found it by git grepping activex when digging in the code. Thanks for your pointers anyway, it could help in the future :) Actually your pointers were right, because: I kinda "forgot" I did a make clean The above mention was deprecated and thus ignored by configure :) More to follow on another thread :) Good night -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Consolidated branding in configure
Hello This is a proposal with many goals: 1- lessen configure options 2- consolidate default values locations 3- consolidate data origin 1- This patch will remove --with-intro*,--with-startcenter*,--with-about-background-svg,--with-flat-logo-svg and will expand --with-branding to this regard 2- In configure.ac, we set default settings for PROGRESSBARCOLOR PROGRESSSIZE PROGRESSPOSITION PROGRESSFRAMECOLOR PROGRESSTEXTCOLOR PROGRESSTEXTBASELINE. The 4 first are also defined with Globals in instsetoo_native/util/openoffice.lst, but with different values. Since configure values only purpose is to override the ones in openoffice.lst, I moved PROGRESSTEXTCOLOR PROGRESSTEXTBASELINE to it, and remove default values from configure 3- The rationale here is that all these options are mostly related. Moving some settings to a text file could look weird but is sensible in the way they are often (> 99%) related to the delivery of alternate pictures. So all pictures and progress bar settings go in the same directory and that's it. I am conscious there may be some work for distros-maintainers, but i think it is a good trade-off. And more, if this is accepted, there may be some consolidation in the scripts that handle filenames since they all are standardized with this patch. Regards Le Wed, 16 Jan 2013 00:43:59 +0100, Mathias M (via Code Review) a écrit: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1704 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1704/1 Consolidated branding in configure Removed individual options (intro* and startcenter* + images) in favor of a folder with graceful fallback. Grouped progress bar intro settings in a text file into the branding folder Change-Id: Ib56b80e43c474a944ac79c0a842d66487e9f91d5 --- M configure.ac M instsetoo_native/util/openoffice.lst.in 2 files changed, 81 insertions(+), 303 deletions(-) -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Install/package : going to internals
Hello When playing with fdo#39632 [1], I faced a strange issue: the file finals_instsetoo.txt was not found by the installer. The error raise from installer.pm, line 513, with the call to installer::windows::update::readdatabase. The reference is defined by openoffice.lst, in the Globals. The reference file is stored in setup_native\source\packinfo. My expectation is that finals_instsetoo.txt would be a dependency of instsetoo_native, but I found no link between both and git grep found nothing more, so I have no clue about which process should do the copy. I think the searched version should be in solver\wntmsci13.pro\bin (as I see it from another clone). Thank you for any enlightenment provided. [1] https://bugs.freedesktop.org/show_bug.cgi?id=39632 -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Bugzilla Migration: Abbreviation to replace fdo#12345
Hello Robinson, * Le Fri, 06 Dec 2013 07:54:07 +0100, Robinson Tryon a écrit: On Fri, Dec 6, 2013 at 12:05 AM, Norbert Thiebaud wrote: but by a wide margin the only 4-char abbreviation in the list has taken an early lead. Sure, but if you were to ask that question on the dev-ml rather than here.. I'd bet you you'd get many more vote for lo# true. I'd always like to have more devs listening-in on what we talk about on the QA list... ;-) You should have cross-posted the vote announcement on all concerned lists, then you'd been more votes. PS: btw I don't see the appeal to want to stick characters in there to re-inforce the idea that it is a bugzilla number... the # in it is sufficient enough to make that clear so the b/bz stuff is not only a waste of space.. but also completely redundant. it is like climbing up or descending down... Fair, fair. One other thing: The abbreviation has a secondary purpose: to be used as shorthand for the bugtracker. Using our two highest-profile options: "Joel, go take a look at regressions on FDO" => "Joel, go take a look at regressions on LO" "Joel, go take a look at regressions on FDO" => "Joel, go take a look at regressions on LOBZ" Well, if you want to mimic fdo, abbrev should be loo (libreoffice.org instead of freedesktop.org) loo is a good trade-off : more than 2, but less than 4; different of the standard lo we use to shortcut LibreOffice BTW, I vote also for lo# if loo# has no access to the vote list ;) Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Bugzilla Migration: Abbreviation to replace fdo#12345
Le Fri, 06 Dec 2013 22:31:53 +0100, Robinson Tryon a écrit: On Fri, Dec 6, 2013 at 3:19 PM, Mat M wrote: You should have cross-posted the vote announcement on all concerned lists, then you'd been more votes. What are the 'concerned lists'? i10n? projects? website? Lots of people interact with the bugtracker, chief among them, the QA team. Well, I second on Norbert thoughts, and I was just saying, that, if you go for a vote, an announcement to the whole bunch of lists might have brought people in, like enlightning Norbert's views. For me, the abbreviation is just one small part of the bigger Bugzilla migration plan: https://wiki.documentfoundation.org/QA/Bugzilla/LibreOffice_Bugzilla_Proposal The reason we're having a vote now is because Nov 8 - I mentioned abbreviation in the proposal Nov 10/11 - Discussed abbrevs on the QA list Nov 18 - QA Meeting decided to ask ESC for input Nov 21 - ESC offered suggestions; said "the guys doing the work should choose." Nov 21 - Looked for consensus on QA list Dec 1 - Saw no consensus; Moving to vote on the QA list I felt like I was working hard to go through appropriate channels. Perhaps if I'd spent more time I could've gotten more input from other groups, but at this point I feel like I've already spent a ton of time on just this one little piece. You worked hard, and that was appreciated, don't misunderstand me. But if you don't find a consensus on the QA list, you might ask for wider audience, so my remark. Not a critic in any way. You did your best and we ackowledge that. FWIW, I also appreciate all the bug metrics and follow-up QA provides, it is very nice and useful. Well, if you want to mimic fdo, abbrev should be loo (libreoffice.org instead of freedesktop.org) loo is a good trade-off : more than 2, but less than 4; different of the standard lo we use to shortcut LibreOffice IIRC, in en-GB 'loo' == toilet Well, I didn't check and that was more of a friday's troll than a real proposal. (not that there aren't any piss-poor bug reports in FDO right now...) ;-) BTW, I vote also for lo# ok -- vote recorded. If the devs really want lo#, just send in enough people to vote and the outcome will be certain. --R brace yourselves, lo# is coming Mat --- Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active. http://www.avast.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice Gerrit News for core on 2013-12-09
Le Mon, 09 Dec 2013 15:23:06 +0100, Stephan Bergmann
a écrit:
On 12/09/2013 02:32 PM, bjoern wrote:
Of course, patches are welcome! ;)
No, they are apparently not, as long as they linger in git and don't get
put into production. ;)
Well, at least now, they got pushed in an email to the list :-P
BTW, I sent an off-list mail to Bjoern on the 04th, but well...
So I republish to a wider audience, who knows :)
I saw the issue but could not reproduce either on Linux Mint nor on cygwin
under win.
I join what I got from my linux mint call to gerrit at 9:45pm GMT+1 on the
4th
David O & Matus are neatly identified as elders.
Could someone log into the machine running the script, then go to the git
repo folder, launch an interactive python, then try the following lines
import subprocess
all_users = subprocess.check_output(['git','shortlog','-s'])
'David Ostrovsky' in all_users
=> should return true
If still return true and still not exclude elders, we may need to test
(also changing the msg_to target )
by adding this patch
diff --git a/gerritbot/send-daily-digest b/gerritbot/send-daily-digest
index 6786db3..9be7c1f 100755
--- a/gerritbot/send-daily-digest
+++ b/gerritbot/send-daily-digest
@@ -36,6 +36,8 @@ def get_digest(query):
if do_fresh:
all_users = init_freshers()
+with open ('/var/tmp/ausers.log', 'a') as f:
+f.write (all_users)
do_module = ['--files', '--patch-sets']
for line in subprocess.check_output(['ssh', args['gerrit'], 'gerrit',
'query'] + do_module +
so we can scan the all_users list. I attach mine if it helps
if you don't have time for this, may I require a ssh access to the server
launching the command so I can test almost live ?
Best,
Mat
---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce
que la protection avast! Antivirus est active.
http://www.avast.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: l10n process, en_US version, Help files
Hi all My grain of salt there. I strongly believe we need to cross-talk, so I go on cross-posting. Le Thu, 12 Dec 2013 13:54:05 +0100, Sophie a écrit: Hi Andras, all, Le 12/12/2013 11:18, Andras Timar a écrit : On 2013.12.11. 17:19, Sophie wrote: *About the en_US overall quality Further discussed - but that doesn't solve the several typos that already exist and that are overlooked by the l10n team (e.g in the Character > Font Effect dialog, there is Overline _c_olor and Underline _C_olor and this is the same for several dialogs) [...] Not sure, as Khaled said, it may be because the load of work on translation is enough to not take care of other things. We have three steps here: - Seeing the typo / obvious inconsistency - Marking the typo - Fixing the typo * See : With a en-US ui, you can catch some during normal work Else, you are in a chase for them (QA, l10n, someone ? ). * Next step is to mark them. When you are in a chase, you can organize stuff to avoid duplicate work and jot all references to, say, a wiki page or an etherpad, whatever fits When you catch one on LO: what will make you go further ? Easiness. We need a simple process to submit. The counterpart is that we may have many false positives, so more filtering to do. Conclusion : either we provide a simple way to report a miss in the text because it may provide useful input, or we consider not having enough people to filter, and we limit ourselves to chases. * And... fixing ! Easy hacks or l10n sessions to fix that are both valid choices. We may want to automate finding occurrences of text in the code. We began with fdo#39439, but further steps are required. * About the help files - I always wonder why there is a Help button on a new dialog when no help file is appended ;) Probably it is prescribed by some rule, e.g. Gnome HIG, that every dialog must have a Help button. So dialog creator application puts it there, and the developer leaves it there thinking that someone may write a help page for it later. Well, may be, but unfortunately the help page is never created. And who is this someone ? BTW, I don't really know the workflow to provide some help content, but I think the developer creating a help button should at list input some draft so people have a start to improve (like we had some lengthy comments on usage in code before). We may have a script to parse the code and find help links without targets, but to fight against obsolescence, we need people involved and scanning the help, or like typos an easy way to report. We are more in a typewriting & review process than a l10n one, so maybe we need doc@ here. - more and more functions are undocumented or their help is obsolete. I always think that an undocumented function is lost for the user and a sad thing for a developer because his function will not be used as expected. As I wrote above, many functions/new dialogs are self-describing. I hated to translate Gnome help 10 years ago, which was full of sentences like this: "Click on Close button to close the dialog." So we need to limit the scope here. It would be good, if you could give examples, what needs further clarification in help. They may be self describing for you, but not for most of our users. I've collected some issues where the help needs to be amended or is missing, but it would be better to have a general process and try to include more people in it. If I admit your example is quite useless, Andras, we have many not-at-all savvy users which actually needs the help, and the basic one, not the expert one. That is the hard stuff. I don't want to dive into tutorials in help, but a good explanantion and an example may help people figure how to use something or to determine if this something is what they are searching for. Remember that we have many facilities in LibreOffice, and we don't know them all. So at one point you have to search for them. And here goes the help system. May be, but I don't know how heavy it would be for developers, the solution would be to open an issue with a special tag like NF for each new feature, with three lines about what the feature is supposed to do. Searching on BZ with this special tag would allow to involve more people in the loop to test it and document it. The problem is that you cannot enforce any rule to developers. You can [...] That I know :) But I have an idea. What about prolonging the string freeze date of help until the first bug fix release? That would [...] That's a good idea, but we still need help authors. I'm sure some people will jump in, even earlier, if they only know where, hence the proposal for a dedicated issue. As I said in another mail, I don't want to add more processes, rules, etc. But there is some areas that impact more than one team where it would be good to have some worflows. We can have a start saying all contributore to libreoffice are nice :) Then, we can ask
Re: l10n process, en_US version, Help files
Hi Sophie Le Fri, 13 Dec 2013 10:01:05 +0100, Sophie a écrit: Hi Mat, Le 12/12/2013 22:56, Mat M a écrit : Hi all My grain of salt there. I strongly believe we need to cross-talk, so I go on cross-posting. Thanks a lot for your input, jumping to my question: [...] * And... fixing ! Easy hacks or l10n sessions to fix that are both valid choices. We may want to automate finding occurrences of text in the code. We began with fdo#39439, but further steps are required. did you submit your work, is it now integrated? I already sent the first draft to Michael Meeks, but we have to find a server to host it. So submitted but not integrated. Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Hello Florian, in [1], asked for an SSH key so I can get access to the script machine. I sent a mail in early 11th of Dec with my public key to David O, Norbert, Florian and CCed Bjoern. I don't mind having my access after holiday break, but I would like to have a feedback, so I don't check my mails anxiously, seeing all those not-so-new committers day after day :) Regards, Mat Season's Greetings ! [1] http://nabble.documentfoundation.org/LibreOffice-Gerrit-News-for-core-on-2013-12-09-tp4087321p4087591.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] dev-tools patch for gerrit script (was Re: gerrit daily )
Hello all Le Thu, 06 Jun 2013 19:34:03 +0200, Bjoern Michaelsen a écrit: On Thu, Jun 06, 2013 at 04:48:52PM +0100, Michael Meeks wrote: + get the gerrit / mail digest bits setup (Bjoern) [ in progress, scripts in dev-tools ] The script is now in a usable state IMHO, but of cause can always be improved (like e.g. using Pythons mail-foo to construct the body, which might make sure getting the encodings right for every client etc.). Below is the example mail this would send for "right now". Best, Bjoern Example output: From: ger...@libreoffice.org To: libreoffice@lists.freedesktop.org Date: 2013-06-06 19:32:00.740745 Subject: LibreOffice Gerrit news 2013-06-06 Reply-To: libreoffice@lists.freedesktop.org X-Mailer: LibreOfficeGerritDigestMailer 1.0 Moin! open changes on master for project core changed in the last 25 hours: https://gerrit.libreoffice.org/4176 "Sidebar conversion to .ui for sidebar-number-format" prashant3.yi...@gmail.com https://gerrit.libreoffice.org/4169 fdo#63866 Hid useless checkboxesjsnhu...@gmail.com https://gerrit.libreoffice.org/4165 fdo#46808, Convert xml::crypto services to new stylenoelgran...@gmail.com merged changes on master for project core changed in the last 25 hours: https://gerrit.libreoffice.org/4174 Prevent out-of-range values coming from ListBox GetSelectEntryPos. javier@gmail.com https://gerrit.libreoffice.org/4170 Remove RTL_CONSTASCII_(U)STRINGPARAM (sd) chrrossman...@web.de https://gerrit.libreoffice.org/4151 fdo#41226 Add error handling of recursed GetCaseCorrectPathNameEx() saturda...@gmail.com https://gerrit.libreoffice.org/4153 fdo#60924 autoinstall - gbuild/scp2: add base modulemarcos.souza@gmail.com https://gerrit.libreoffice.org/4171 Fix memory leak in Exif::processExif. Delete aExifData when done. m...@klomp.org https://gerrit.libreoffice.org/4167 fdo#64350: fix for DOCX export of border space rattles2...@gmail.com abandoned changes on master for project core changed in the last 25 hours: None Open changes needing tweaks, but being untouched for more than a week: https://gerrit.libreoffice.org/3663 replaced compareTo with == p...@nevitus.com Best, Your friendly LibreOffice Gerrit Digest Mailer my patch is this: Sanitize the age query parameters with -- Improve layout of mail like: -8<--- Moin! * Open changes on master for project core changed in the last 25 hours: Rework code after OUString'ification in https://gerrit.libreoffice.org/4214 from Matteo Casalin Simplify SwPaM::GetTxt in https://gerrit.libreoffice.org/4213 from Matteo Casalin groupdialog.ui widget in https://gerrit.libreoffice.org/4208 from Manal Alhassoun fdo#64977 Adding Tibetan Language Support in https://gerrit.libreoffice.org/4197 from Élie Roux ... --->8- without going beyond 75 chars and with no wrap neither. Since urls have fixed-length, I put them at start to ahve ~aligned things. Attached is the patch, because dev-tools does not have the Change-Id hook (apparently). HTH Mathias -- Mat M 0001-Improve-mail-formatting-fix-query-parsing.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
MSI process
Hello, I'm tackling back to fdo#39632 [1]. But I have a question about current implementation. I started my work with checkdirectory.cxx[2] , which is called 2 times during a typical install. I just added the two last message boxes defined there to check it is called. I created a non-empty file where it says the sSetupIniPath will be, but did not manage to trigger the directory non empty error, which seems weird. When converting handle of the should-have-been-found to string, I get a -1. looking at &data content, I get some rubbish - if convert from tchar to tstring is ok -, so file seems not found. Moreover, even if we find the file, nothing is done, so this could be removed, no ? Side question: is there a make target to just trigger the MSI generation, if I want to avoid the "build" one ? Best regards [1]:https://bugs.freedesktop.org/show_bug.cgi?id=39632 [2]:http://cgit.freedesktop.org/libreoffice/core/tree/setup_native/source/win32/customactions/shellextensions/checkdirectory.cxx -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MSI process
Le Sun, 16 Jun 2013 09:29:37 +0200, Andras Timar a écrit: Hi Mat, On Sun, Jun 16, 2013 at 1:15 AM, Mat M wrote: Hello, I'm tackling back to fdo#39632 [1]. But I have a question about current implementation. I started my work with checkdirectory.cxx[2] , which is called 2 times during a typical install. [...] Moreover, even if we find the file, nothing is done, so this could be removed, no ? Well, MSI_ERROR_DIRECTORY_NOT_EMPTY is set, and we can check for it in the install log. But it is true, that we don't handle this in installer code. I have a feeling that consolidating this module will be in fact deleting most of the custom actions at the end of the day. :) Please check file history and old OOo bugzilla, why a custom action was introduced in the first place, and if you think that it is useless, remove it. Hello, CAs (Custom Action) outside shellextensions are fine. About shellextensions ones, here is my status: * checkdirectory.cxx : was like this from start. So always useless :) => to be removed * completeinstallpath.cxx : handle the first level directories : // This CustomAction is necessary for updates from OOo 3.0, OOo 3.1 and OOo 3.2 to versions // OOo 3.3 or later. This is caused by a change of INSTALLLOCATION, that starting with OOo 3.3 // contains the name of the product again (instead of only "c:\program files"). Unfortunately // this causes in an update installation, that INSTALLLOCATION is set to "c:\program files", // so that in an OOo 3.3 or later, the directory "program" or "share" are directly created // below "c:\program files". => Shall we remove it ? * vistaspecial.cxx: i#94560 . => To keep. * startmenuicon.cxx: was used to have a special icon on start menu folder. Disabled since vista. => to be removed * upgrade.cxx: i#43855 [1]. Not sure we want to reproduce use case from comment 6. => to confirm * checkpatches.cxx: used for upgrades (differential msi). Check if previous patches have been applied. => to keep, hoping for the return of .msp :) * layerlinks.cxx: handle creation of a ure-link file at root. this file is used to abstract URE path in code (mainly installation related, though). My question is: could we create this file during instsetoo and add it as a simple file in the MSI, so CustomAction could be removed ? => to keep for now * migrateinstallpath.cxx: used to emulate upgrade pahse with 2 MSI with no upgradecode inside. => to keep for now. If no voice raise, I will proceed accordingly before tackling back to fdo#39632. Best Regards [1]:https://issues.apache.org/ooo/show_bug.cgi?id=43855#c6 -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice Gerrit News 2013-06-17
Hi all, Le Mon, 17 Jun 2013 14:37:28 +0200, Tommy a écrit: On Mon, 17 Jun 2013 13:52:05 +0200, Khaled Hosny wrote: I'm not sure if it is only me, but those messages are hard to read, can we have new lines between different items (i.e. after the "in https://"; line)? or any other way to make it easier to tell which line belongs to which description? Regards, Khaled I agree.. could be that list be formatted from actual: fontsizedialog.ui widget in https://gerrit.libreoffice.org/4312 from Manal Alhassoun Migrate CheckFields unit test to python in https://gerrit.libreoffice.org/4294 from David Ostrovsky replace ShapeList::getNextShape with STL like iterator. in https://gerrit.libreoffice.org/4191 from mhofmann etc. etc to something like this: fontsizedialog.ui widget in https://gerrit.libreoffice.org/4312 from Manal Alhassoun Migrate CheckFields unit test to python in https://gerrit.libreoffice.org/4294 from David Ostrovsky replace ShapeList::getNextShape with STL like iterator. in https://gerrit.libreoffice.org/4191 from mhofmann etc. etc To avoid having still more lines to scroll, could we get a consensus on itemizing ? Something like + fontsizedialog.ui widget in https://gerrit.libreoffice.org/4312 from Manal Alhassoun + Migrate CheckFields unit test to python in https://gerrit.libreoffice.org/4294 from David Ostrovsky + replace ShapeList::getNextShape with STL like iterator. in https://gerrit.libreoffice.org/4191 from mhofmann which cancels doubt of block start and keep us on a not so long mail. IMHO some kind of separators would help readability of such long lists We could have separator for categories, btw. I t will help separating full mail into major blocks. HTH -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MSI process
Le Mon, 17 Jun 2013 12:36:48 +0200, Andras Timar a écrit: On Mon, Jun 17, 2013 at 12:35 AM, Mat M wrote: CAs (Custom Action) outside shellextensions are fine. Well, the job of regactivex/regpatchactivex should be done by normal actions, custom action is for this is a hack. OK, but I only can try on Win7. regpatchactivex just remove the CLSID from the base mimetype => I will check if it is ok without that. regactivex was for Win98/ME,so it should be fine. I may need help for the MSI changes, though. About shellextensions ones, here is my status: * completeinstallpath.cxx : handle the first level directories : I don't think we upgrade OOo 3.0, OOo 3.1 or OOo 3.2 , so this is useless, but please test it, before removing. * vistaspecial.cxx: i#94560 . => To keep. This is a dirty hack. I wonder if the original bug that it solves, is reproducible with our installer. If not, remove it. I cannot check. Anyone with a vista computer ? * startmenuicon.cxx: was used to have a special icon on start menu folder. Disabled since vista. => to be removed Please keep it, we still support Windows XP. Well, it is not about supporting XP, it is about setting a custom icon for the folder in the Start Menu which holds the LibreOffice icons. * upgrade.cxx: i#43855 [1]. Not sure we want to reproduce use case from comment 6. => to confirm User installation (as opposed to system wide installation) is generally unsupported. I mean it may not work at all, and IMHO it makes little sense. => so we remove it. :) * checkpatches.cxx: used for upgrades (differential msi). Check if previous patches have been applied. => to keep, hoping for the return of .msp :) You can keep it, however, I don't know how it is supposed to work. Well, you are right, this should be handled by the msi itself, so removal is ok :) * layerlinks.cxx: handle creation of a ure-link file at root. this file is used to abstract URE path in code (mainly installation related, though). My question is: could we create this file during instsetoo and add it as a simple file in the MSI, so CustomAction could be removed ? => to keep for now See Stephan's mail. Yes. I may try ti include the file as is, but still may need help for that. * migrateinstallpath.cxx: used to emulate upgrade pahse with 2 MSI with no upgradecode inside. => to keep for now. OK. Thanks, Andras Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MSI process
Le Mon, 17 Jun 2013 19:10:33 +0200, Andras Timar a écrit: On Mon, Jun 17, 2013 at 7:04 PM, Mat M wrote: * startmenuicon.cxx: was used to have a special icon on start menu folder. Disabled since vista. => to be removed Please keep it, we still support Windows XP. Well, it is not about supporting XP, it is about setting a custom icon for the folder in the Start Menu which holds the LibreOffice icons. Yes, and after you remove it, folder icon will not be there in Windows XP start menu. Yes, but folder will still be there, with the same look as Vista, 7 & 8. Do we agree ? Regards, Andras Best wishes -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Improve digest [was: LibreOffice Gerrit News 2013-06-17]
Hello all Le Mon, 17 Jun 2013 18:08:13 +0200, Tommy a écrit: On Mon, 17 Jun 2013 17:54:37 +0200, Mat M wrote: To avoid having still more lines to scroll, could we get a consensus on itemizing ? Something like + fontsizedialog.ui widget in https://gerrit.libreoffice.org/4312 from Manal Alhassoun + Migrate CheckFields unit test to python in https://gerrit.libreoffice.org/4294 from David Ostrovsky + replace ShapeList::getNextShape with STL like iterator. in https://gerrit.libreoffice.org/4191 from mhofmann which cancels doubt of block start and keep us on a not so long mail. that "+" solution would be good for me Patch provided :) IMHO some kind of separators would help readability of such long lists We could have separator for categories, btw. I t will help separating full mail into major blocks. HTH I agree. Tell me what you think, but with +, I find blank lines are enough. Regards -- Mat M 0001-Update-itemization-s-output.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit daily digest active, please add yourself to watched projects, gerrit firehose ends 2013-06-17 0000UTC
Hi Bjoern Le Wed, 19 Jun 2013 08:59:02 +0200, Bjoern Michaelsen a écrit: Hi, On Thu, Jun 13, 2013 at 04:39:01PM +0200, Bjoern Michaelsen wrote: so the gerrit firehose will end on Monday 2013-06-17 UTC -- plus/minus a bit for me fumbling around with it. this is done now. Best, Bjoern Mind to merge my patch, please ? http://nabble.documentfoundation.org/LibreOffice-Gerrit-News-2013-06-17-tp4061810p4062117.html Thank you :) -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit daily digest active, please add yourself to watched projects, gerrit firehose ends 2013-06-17 0000UTC
Hello Le Fri, 21 Jun 2013 10:50:42 +0200, Bjoern Michaelsen a écrit: Hi Mat, On Thu, Jun 20, 2013 at 11:46:51PM +0200, Mat M wrote: Mind to merge my patch, please ? http://nabble.documentfoundation.org/LibreOffice-Gerrit-News-2013-06-17-tp4061810p4062117.html Thank you :) That patch doesnt apply cleanly as you created it against an outdated version: Sorry! I git-pulled before doing the changes and started from commit 073e1c2f3ae from Lubos. Maybe my workdir was not clean. Applying: Update itemization's output error: patch failed: gerritbot/send-daily-digest:27 error: gerritbot/send-daily-digest: patch does not apply Patch failed at 0001 Update itemization's output The copy of the patch that failed is found in: /home/bjoern/checkouts/dev-tools/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". PLEASE: Next time, instead of attaching a plain patch to a mail, please just push to gerrit, as that saves a lot of such avoidable trouble, esp. when patches do not cleanly apply on master. h! Still forgot gerrit is also working for dev-tools. Sincere apologies ! Anyway, pushed and deployed as: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=commit;h=ef48d775c8baa039e2f16ef7da928d99c2c27994 (which accidentally added a compiled pyc file as I had to manually merge and apply that one) Best, Bjoern -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#39439 : Web search for UI strings
Le Sun, 15 Sep 2013 18:35:22 +0200, Mat M a écrit: Le Fri, 13 Sep 2013 12:24:43 +0200, Michael Meeks a écrit: On Thu, 2013-09-12 at 00:09 +0200, Mat M wrote: > Not really a patch. As discussed in the issue, it is a python webapp to Ok :-) do you have a live demo on-line we can play with ? Nope, I have no online sevrer which can host a python program. But code will come, don't worry. I tried with openshift.com, but I have an issue with submodules for now, so it is not working. >Do you have some code I can read ? :-) it's by far the best to share > your python app by posting it to the dev list - please do CC me, I'd > love to review (and/or use that). I will, as soon as the glade question is solved. Ok - you're working on that ? :-) Code is working, but i will refactor it a bit to be more consistent. >If it's a python app - perhaps we can also include a command-line Well, request was for a web site, forwarding to opengrok. I think in a In the zip, there is louish, the CLI version, which is stricter but should match the CLI usage. >Do you support the glade format as well as the res format ? Done, finally. I'd love to read the code & get it into git somehow. If it's a Will provide both when glade stuff is done (Hopefully by the end of the week). The week was long :P For the webapp (all files but louish), you will need the packages pylev & web.py Script was tested with LinuxMint bash, Webapp with apache+mod_wsgi, ran by python 2.7. Have a look and tell me Regards, Mat pylons.tar.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice DRAW - Flowcharting automation with scripting language
Le Tue, 26 Nov 2013 01:08:40 +0100, Robinson Tryon
a écrit:
On Mon, Nov 25, 2013 at 6:51 PM, - wrote:
Flowcharting automation process in Draw (creating flowcharts
automatically,
without effort) Scripting language
...
THE PROBLEM: When you want to create a flowchart, basically you have to
...
[HEAD BEGIN: geometry: Rectangle, color: blue, rotation: 0, radious: 0,
angle: 0, connector: normal, geometry-thickness: 2pt,
connector-thickness:
2pt, shadow orientation:right-down, shadow color: grey, font-type-size:
Calibri, 2pt, font-alignment: center, center]
Differential geometry > differential calculus
Differential geometry > integral calculus
Differential geometry > linear algebra
Differential geometry > multilinear algebra
[:HEAD END]
Have you looked at the DOT language?
https://en.wikipedia.org/wiki/DOT_(graph_description_language)
digraph graphname {
a -> b -> c;
b -> d;
}
There are a few others:
https://en.wikipedia.org/wiki/Category:Graph_description_languages
Hello
DOT is handled by graphviz, which can export to SVG, that could be
imported into Draw. Job's done ! :)
yEd handles TGF and can also export to SVG.
So basically, what is needed here is find a suitable Graph language
(please don't create another one), make it create an SVG, then import in
draw.
Or use Dia, which does not seem to read graph langs, but has a nice
interface to play with flowcharts
Under professional Windows, I use mostly Visio to do flows and copy/paste
into impress^W powerpoint. You can do the same with Dia & Impress. IMHO,
creating a new import module for a graph lang to dia is more valuable, but
being able to draw flows in Draw could be fun as well.
My 5 cents :)
Mat
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: OpenDocument text (Flat XML) .fodt
Hello Le Thu, 02 Jan 2014 16:04:22 +0100, John Robson a écrit: Thank you, but not solve, the lines continue large. But, this is not a bug, is just a good feature. As I said before, break lines in smaller columns will improve the versioning results when you work in a collaborative way. On 01/02/2014 10:50 AM, Eike Rathke wrote: Unchecking the "Size optimization for ODF format" option under Tools->Options->Load/Save->General should do that. I understand your need, but could you explain, even if a little off-topic, what keeps you away from Edit - Changes - Record (see https://help.libreoffice.org/Common/Comparing_Versions_of_a_Document) ? And what do you call "the lines continue large" ? Regards Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: remaining core gerrit spam
Hello Le Tue, 16 Jul 2013 18:09:12 +0200, Bjoern Michaelsen a écrit: If someone volunteers, it would be great to have the daily digest include those changes too then: https://bugs.freedesktop.org/show_bug.cgi?id=66968 Best, Bjoern Got it :) I asked some questions in the comments, I write them back here: Targeted repos: core translations dictionaries help Should we target more (contrib/dev-tools, contrib/buildbot) ? I suppose we set them in different mails ? Or do you want one mail for core, one for the submodules, and one for the contrib ones ? Regards Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#39439 : Web search for UI strings
Hello I eventually reach a usable step in this issue [1]. I don't know where to ask for my gerrit review. Looking at libreoffice/website repo[2], you see recent activities on update, tinderbox and master branches. Recent means after the obsolescence notice [3] which is from 2012-07-20. So should I push my patch to dev-tools, website, github.com/tdf ? I didn't include website ML in this message because I thought it was too early. Feel free to add them if it should help Thanks [1] https://bugs.freedesktop.org/show_bug.cgi?id=39439 [2] http://cgit.freedesktop.org/libreoffice/website/ [3] http://cgit.freedesktop.org/libreoffice/website/tree/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#39439 : Web search for UI strings
Hello Caolan Le Thu, 29 Aug 2013 12:30:47 +0200, Caolán McNamara a écrit: On Sun, 2013-08-25 at 01:40 +0200, Mat M wrote: Hello I eventually reach a usable step in this issue [1]. I don't know where to ask for my gerrit review. Looking at libreoffice/website repo[2], you see recent activities on update, tinderbox and master branches. Recent means after the obsolescence notice [3] which is from 2012-07-20. So should I push my patch to dev-tools, website, github.com/tdf ? So, what is your patch against ? I mean what does it patch, is it e.g. a patch against opengrok or a command line search utility or something else. Not really a patch. As discussed in the issue, it is a python webapp to be setup on a webserver. it just need a readable local bare repo to work. I'd love to commit a patch in opengrok, but I'm afraid my Java score is not enough :) Regards [1] https://bugs.freedesktop.org/show_bug.cgi?id=39439 [2] http://cgit.freedesktop.org/libreoffice/website/ [3] http://cgit.freedesktop.org/libreoffice/website/tree/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#39439 : Web search for UI strings
Hello Adding the parallel reply of Michael and my answer. Le Fri, 30 Aug 2013 00:33:43 +0200, Mat M a écrit: Hello Caolan Le Thu, 29 Aug 2013 12:30:47 +0200, Caolán McNamara a écrit: On Sun, 2013-08-25 at 01:40 +0200, Mat M wrote: Hello I eventually reach a usable step in this issue [1]. I don't know where to ask for my gerrit review. Looking at libreoffice/website repo[2], you see recent activities on update, tinderbox and master branches. Recent means after the obsolescence notice [3] which is from 2012-07-20. So should I push my patch to dev-tools, website, github.com/tdf ? So, what is your patch against ? I mean what does it patch, is it e.g. a patch against opengrok or a command line search utility or something else. Not really a patch. As discussed in the issue, it is a python webapp to be setup on a webserver. it just need a readable local bare repo to work. I'd love to commit a patch in opengrok, but I'm afraid my Java score is not enough :) Regards [1] https://bugs.freedesktop.org/show_bug.cgi?id=39439 [2] http://cgit.freedesktop.org/libreoffice/website/ [3] http://cgit.freedesktop.org/libreoffice/website/tree/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE Le Mon, 09 Sep 2013 21:47:45 +0200, Michael Meeks a écrit: On Sun, Sep 08, 2013 at 11:55:31PM +0200, Mat M wrote: > I am waiting for your answers on those 2 threads in the dev ML. > http://nabble.documentfoundation.org/fdo-39439-Web-search-for-UI-strings-tt4071502.html For that one, Id suggest you talk to Michael Meeks (in CC), who created that EasyHack in the first place (I ony copied that over from the wiki to bugzilla). Do you have some code I can read ? :-) it's by far the best to share your python app by posting it to the dev list - please do CC me, I'd love to review (and/or use that). I will, as soon as the glade question is solved. If it's a python app - perhaps we can also include a command-line version for users to use to search the git repository with - which would be ideal. Well, request was for a web site, forwarding to opengrok. I think in a CLI, you may want a different output. Adding some specs, so ? Do you support the glade format as well as the res format ? Hem... The original goal wasd to search in *.[hs]rc to find en-US ref strings and where they are used in the code. I don't manage to bind that with your question. Basically, all codes in.ui are stored in a .po file, under the same folder structure in the translations repo. Have I missed something ? If you could give a use case, it may become clearer to me. Best regards, Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#39439 : Web search for UI strings
Le Fri, 13 Sep 2013 12:24:43 +0200, Michael Meeks a écrit: Hi Mat, On Thu, 2013-09-12 at 00:09 +0200, Mat M wrote: > Not really a patch. As discussed in the issue, it is a python webapp to > be setup on a webserver. it just need a readable local bare repo to work. > I'd love to commit a patch in opengrok, but I'm afraid my Java score is > not enough :) Ok :-) do you have a live demo on-line we can play with ? Nope, I have no online sevrer which can host a python program. But code will come, don't worry. >Do you have some code I can read ? :-) it's by far the best to share > your python app by posting it to the dev list - please do CC me, I'd > love to review (and/or use that). I will, as soon as the glade question is solved. Ok - you're working on that ? :-) Yes. I read the move-to-glade things on the ML, but missed the link between this and that :) >If it's a python app - perhaps we can also include a command-line Well, request was for a web site, forwarding to opengrok. I think in a Oh - sure; but if it's a nice standalone python thing then having a command-line version would be awesome: developers would use that a lot for lookups I think. Since I used it to exercise my python skills, no standalone thing :) But i will certainly come up with one (python or bash, I don't know), since it is easy to build. >Do you support the glade format as well as the res format ? Hem... The original goal wasd to search in *.[hs]rc to find en-US ref [...] something ? If you could give a use case, it may become clearer to me. Right - so; that is so; but I guess we'd want to avoid the translation/ repository since it's -so- huge :-) Instead I'd just grep for the strings inside the .ui files. That will map to a filename (at minimum) eg. [...] Hopefully that is easy enough ? perhaps easier than all the old-style src/hrc pieces ? Yes, Missed the filenames part, since I didn't how how it was referenced from code. Thank you. I'd love to read the code & get it into git somehow. If it's a standalone thing then getting developers to use it on the commandline would be a great (and trivial) 1st start before enabling it on some web infrastructure I think. Will provide both when glade stuff is done (Hopefully by the end of the week). Anyhow - thanks -so- much for your work - this sounds really exciting; are you coming to the conference in Milan[1] ? if so - a lightning talk on this would be great :-) Nope for Milan. My work load does not allow it for now. Best, Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Fix for Gerrit Daily Digest
Le Tue, 15 Jul 2014 02:15:52 +0200, Mat M a écrit: Hello Le Sun, 06 Jul 2014 01:35:59 +0200, Mat M a écrit: Hello I submitted https://gerrit.libreoffice.org/10097 to fix the gerrit digest about freshers. This will solve the issue. Since it has been reviewed, could someone update the production version on gerritbot account, please ? Still not done. Anyone willing to help, now that holidays are over ? ;-) Thank you Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Google shuts down the OpenID 2.0 on April 20, 2015
Le Tue, 11 Nov 2014 10:37:45 +0100, Bjoern Michaelsen a écrit: On Tue, Nov 11, 2014 at 08:26:19AM +0200, Tor Lillqvist wrote: There is a list: http://openid.net/get-an-openid/ and chances you already have one of those (including lots of smaller providers like wordpress.com, livejournal). Also note that everyone who ever filed a bug against Ubuntu has an OpenID as launchpad offers one. FTR, stackexchange, editor of many websites (stackoverflow, askubuntu,...) is also providing an OpenID 2.0 service [0], if you deigned to create a login on them :) Regards Mat M [0] https://openid.stackexchange.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ESC call Thursday 16:00 central European time ...
Le Wed, 08 Oct 2014 14:10:53 +0200, Bjoern Michaelsen a écrit: [1] E.g. someone volunteering to tweak the daily gerrit digest to: - work on release branches - do a weekly? digest - sorted by the source code module (so some could watch Writer, some Calc, etc.) Could allow QA/supporter guys to have more early visibility of what is happening. Then again, this would need people to actually _read_ that regularly. If anyone volunteers to invest (both in writing/setting up the tooling and creating a group using it) here, it might be worth a few experiments. Well, I could do the technical part, but will do iff someone would deliver the last update to production machine (so we have a real update for newcomer names) :-P And seeing the small part that read the current digest, I doubt it will be useful unless some QA people take the point on spying the release digest. My 2 cents Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Writing MS Visio Format
Le Mon, 07 Apr 2014 10:24:51 +0200, David Tardon a écrit: Hi, On Sat, Apr 05, 2014 at 08:52:45PM +0200, John Smith wrote: Hi, I know LibreOffice can open/read Visio .vsd files, but are there any plans to add exporting/saving to visio .vsd format ? No, there are not. Producing correct binary files is much harder task than reading them: IIRC MS Visio refuses to open a .vsd file if one flips a single bit in it... .vsdx (Visio XML format) could be a solution. There are some links with more or less extensive description of the format [0]. Would it fit your purpose ? And AFAIK, Visio ocul dimport svg, that Draw is able to export. It could be a workaround. HTH Mat [0]: http://download.microsoft.com/download/8/5/8/858F2155-D48D-4C68-9205-29460FD7698F/[MS-VSDX].pdf ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Hello Le Thu, 18 Dec 2014 16:39:53 +0100, Michael Meeks a écrit: * gerrit daily digest AWOL (Bjoern) + seems to have died 2x weeks ago - any ideas ? + migration to new server in that time-frame (Michael) + would love to have that back on the dev-list Yeah, this would bring the new version pushed 2 months ago ;-) Nice Xmas present for me. + ran 'git gc' on the send / E-mail copy + 60Gb -> ~1ish Gb. + and setup an auto-gc. I suppose you are talking about the core repo used to identify committers ? we can enforce a git gc right after the update, daily, weekly, or monthly. BTW, I am surprised by the volume since the repo is bare (or supposed to be, at least) Regards Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Le Sun, 21 Dec 2014 23:46:58 +0100, Mat M a écrit: Hello Le Thu, 18 Dec 2014 16:39:53 +0100, Michael Meeks a écrit: * gerrit daily digest AWOL (Bjoern) + seems to have died 2x weeks ago - any ideas ? + migration to new server in that time-frame (Michael) + would love to have that back on the dev-list Yeah, this would bring the new version pushed 2 months ago ;-) Nice Xmas present for me. Well, seeing the week-end mails, I think this is not the last version. Could someone check if tools repo is up-to-date and gerritbot/send-daily-digest has line 75 like: subprocess.call(['git','fetch','origin','master:master']) If confirmed, I need to dig more about updates (Douglas Mencken and Michael Weghorn are *not* fresh committers), so would be pleased with a small fix on gerrit VM, because, with my account, I got a bash: gerrit: command not found when I tried to query gerrit through ssh . + ran 'git gc' on the send / E-mail copy + 60Gb -> ~1ish Gb. + and setup an auto-gc. I suppose you are talking about the core repo used to identify committers ? we can enforce a git gc right after the update, daily, weekly, or monthly. BTW, I am surprised by the volume since the repo is bare (or supposed to be, at least) OK, you are doing so many changes... Keep up the good work ! Mat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: internal error 2503
Hello I suggest you write an email to us...@fr.libreoffice.org with a french message giving details on how you installed and launched (run as admin or not, batch, default shortcut , ...) Libreoffice. Some users may have the same setup you have and may help you better than this developers list, which targets coding into libreoffice rather than supporting installation issues. Hope this helps Best regards Mat M Le Sat, 01 Feb 2014 21:15:25 +0100, charenton a écrit: when installing Libre Office, any 'version 4.1.4 or 4.2.0 Windows 8.1, 64bits -- View this message in context: http://nabble.documentfoundation.org/internal-error-2503-tp4095026.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Gerrit OpenID authentication
Hello My account (matm) is bound to my blogspot url which does not support openId 2.0 but only 1.1 (See the nice error I got: error:No openid.mode ns:http://specs.openid.net/auth/2.0) Neither I can login, nor can I bind another openid url providing 2.0 level. What is the solution ? Thanks for your help ! Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Autogen options page!
Le Tue, 11 Feb 2014 12:04:00 +0100, Ahmad Hussein Al-Harthi a écrit: Hi, The link for autogen options description page is linked to #Autogen? I couldn't find the related page on the wiki? Can anyone fix this? I didn't find the previous page. I think it was removed. It came from old build system and options are quickly changing. Best way is to go into your libreoffice repo, and run a ./configure --help As the format is quite consistent, you may build a quick parser to format that in any readable form you prefer. (Well, I may be wrong) Kind regards Mat M Place: https://wiki.documentfoundation.org/Development/How_to_build/Configure_options#Autogen Link to be fixed for: "page describing the options" Ahmad ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] locking semantics ...
Le Mon, 14 Nov 2011 15:39:12 +0100, Michael Meeks a écrit: On Mon, 2011-11-14 at 15:23 +0200, Tor Lillqvist wrote: In both cases, just knowing *who* is holding the document open would be enough. 'Who' is of course something that we can get incredibly quickly from the operating-system, and is already in the file. Of course, this doesn't deal with the hacker use-case of having dozens of LibO open on lots of different systems, and forgetting where you left them all but ... ;-) [ hopefully that is a minority use-case ]. We already have the user name + account in the .~lock file I guess; but we could prolly do quite a lot better here: * detecting whether the file is on a network file-system; if not - warning about other users using it is pretty lame ;-) + the downer being that reliably detecting file-system type is quite 'fun' - but we do dozens of lstat walks down the file-system already anyway so ... Bad idea: Citrix and remote desktops to server allow you to open a local file multiple times. Use case: We maintain a spreadsheet with a history of jobs that ran on a server. The spreadsheet is stored on the server since this one is backuped ;-) and the jobs ran locally too. Using remote desktop, we can be up to 3 (without cost overhead) to look in the file, and maybe edit it. Other use case: in a small company, someone share a document from his machine for other to review. So please keep the lock file for local filesystems. TY Mathias M * storing the of the relevant process in the .lock file, such that if the system-names match we can verify if indeed the .lock file is just stale * removing .lock files when we select to open a copy, so they don't sit around indefinately causing grief when created. * silently deleting lock files if thy are > a week old (and file remains un-touched for that time) + where 'week' is customiseable by the paranoid Or is that highly controversial ? :-) if not, I'll create an 'easy' hack or two I guess. ATB, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Registry keys for Windows compilation
Le Sat, 19 Nov 2011 19:02:56 +0100, julien2412 a écrit: Hello, I'm trying to compile on Windows Vista (usually I compile without pb on a Debian testing) and had error messages : checking the Perl version... checked (perl 5) checking for required Perl modules... all modules found checking for a friendly Microsoft C/C++ compiler installation path... Can't find MS Visual Studio / VC++ at ./oowintool line 188. cygpath: can't convert empty path cygpath: can't convert empty path checking for mspdb80.dll... no checking for mspdb100.dll... no checking the Microsoft C/C++ Compiler... checking for cl.exe... no cygpath: can't convert empty path cygpath: can't convert empty path configure: error: Microsoft C/C++ Compiler not found. Use --with-cl-home or set path to cl.exe. Error running configure at ./autogen.sh line 157. I took a look at oowintool, the pb is cygwin doesn't map all the /proc/registry. For example, there's nothing there : /proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress If you use Express 2010, the key is in HKEY_CURRENT_USER. I don't know for Vista 32, but seven 64 has no shortnames for Program files paths with spaces (default install), so it is a pity. Either reinstall Express in a non-spaced dir, or prepare to hack the autogen/configure/oowintool chain. Providing paths with space event on the autogen/configure commands does not help, since stuff in there is not set to handle spaces. I am currently working on it but it is not that simple and time is very hard to get for now. And there's nothing cause permissions aren't ok : ls -l /proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/ d- 1 400401 0 Nov 19 18:53 VBExpress d- 1 400401 0 Nov 19 18:53 VCExpress d- 1 400401 0 Nov 19 18:53 VCSExpress But I can't succeed in adding +rx on these directories. When I look at authorizations on Windows registry, it's the same as Mediaplayer which appears like this on Cygwin : dr-x-- 3 SYSTEM SYSTEM 0 Sep 2 2009 MediaPlayer Weird. Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Registry keys for Windows compilation
Hello Le Sun, 20 Nov 2011 09:42:04 +0100, julien2412 a écrit: Hello Denis and Matm (I had already answered to Jonathan :-) ) Thanks about your answer. Between the moment I had posted on this thread and your answer, I was trying another way. On this thread http://nabble.documentfoundation.org/REVIEW-try-to-improve-automatic-detection-for-Windows-building-tp3522110p3522110.html I put 2 simple patches to review. In oowinbuild, I added a hook to search directly in Windows registry if the value is not found on mapped Windows registry provided by Cygwin (/proc/registry). Julien. You should check for ANT_HOME reality before assigning it. I know many installs of Windows ant which do not have the env var set by default. So after checking in SOLAR_JAVA and fail, if ANT_HOME exists, use it, else use the command-line-provided path. My 2 cents Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Registry keys for Windows compilation
Le Sat, 19 Nov 2011 22:37:25 +0100, Mat M a écrit: Le Sat, 19 Nov 2011 19:02:56 +0100, julien2412 a écrit: Hello, I'm trying to compile on Windows Vista (usually I compile without pb on a Debian testing) and had error messages : checking the Perl version... checked (perl 5) checking for required Perl modules... all modules found checking for a friendly Microsoft C/C++ compiler installation path... Can't find MS Visual Studio / VC++ at ./oowintool line 188. cygpath: can't convert empty path cygpath: can't convert empty path checking for mspdb80.dll... no checking for mspdb100.dll... no checking the Microsoft C/C++ Compiler... checking for cl.exe... no cygpath: can't convert empty path cygpath: can't convert empty path configure: error: Microsoft C/C++ Compiler not found. Use --with-cl-home or set path to cl.exe. Error running configure at ./autogen.sh line 157. I took a look at oowintool, the pb is cygwin doesn't map all the /proc/registry. For example, there's nothing there : /proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress If you use Express 2010, the key is in HKEY_CURRENT_USER. Answer to myself: no, it is in HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node in the real x64 registry. And cygwin seems to map it to /proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE. Wow. Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] About build libo on Windows
Hello all Le Fri, 02 Dec 2011 12:13:29 +0100, Alex Sandro Fagundes a écrit: I forget of put on email but I put on command. I think that I'm doing correct, but not work. tried several forms: --with-jdk="/cygdrive/c/Program Files/Java/jdk1.6.0_25" --with-jdk="C:\Program Files\Java\jdk1.6.0_25" --with-jdk="C:\DXSDK" Does not work or one! I think you have some problems with spaces in the path. On my side, but not confirmed since I worked incrementally, I needed to add \" before and after for JAVA_HOME in Env.host.sh, a fortiori because it is used to build LIB parameters. So mine is like that: JAVA_HOME="\"C:/Program Files (x86)/Java/JDK16~1.0_2\"" I wanted to but did not track back to update autogen.sh accordingly. HTH Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build Libo - Error when execute ./autogen.sh
Hello Le Mon, 05 Dec 2011 12:07:45 +0100, Alex Sandro Fagundes a écrit: Hi, I'm tried build libo, but I'm with problems how showed on annex. I tried several forms, but not work. I tried: --with-jdk-home=/cygdrive/c/Program Files/Java/jdk1.6.0_25 --with-jdk-home="C:\DXSDK" --with-jdk-home="C:\Program Files\Microsoft SDKs\Windows\v6.0A" Your settings should be --with-jdk-home=/cygdrive/c/Program Files/Java/jdk1.6.0_25 --with-directx-home="C:\DXSDK" --with-windows-sdk-home="C:\Program Files\Microsoft SDKs\Windows\v6.0A" Could you confirm this is a typo in your email ? Regards Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc : add carriage return via Ctrl+Enter in the "Formula bar"
Hello Noel, Le Mon, 12 Dec 2011 16:27:29 +0100, Noel Power a écrit: On 12/12/11 14:39, Maxime de Roucy wrote: Hi I checked with a recent master build on Archlinux and it works perfectly :-). I also checked with the 3.5 beta on Windows XP but the behaviour of Ctrl +Enter changed. Now it switch the auto-wrap mode. I don't know if it's normal or not ... It is intentional, since now it displays multiple lines ( even if there is only space for 1 ) It is not related. Auto-wrap tells the text to not overlap the next cell on the right. I may want to have multiple lines in my cell and still want to overlap next cells rather than having it wrapping. I think once 3.5 is release, some issue will be raised for this. My 2 cents. Mathias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)
Hello
Le Sat, 14 Jan 2012 16:00:31 +0100, julien2412 a
écrit:
Hello,
cppcheck reported this :
core/vcl/generic/fontmanager/fontconfig.cxx
196 duplicateExpression style Same expression on both sides of '-'
class SortFont : public ::std::binary_function< const FcPattern*,
const
FcPattern*, bool >
{
public:
bool operator()(const FcPattern *a, const FcPattern *b)
{
int comp = compareFontNames(a, b);
if (comp != 0)
return comp < 0;
int nVersionA=0, nVersionB=0;
bool bHaveA = FcPatternGetInteger(a, FC_FONTVERSION, 0,
&nVersionA) == FcResultMatch;
bool bHaveB = FcPatternGetInteger(b, FC_FONTVERSION, 0,
&nVersionB) == FcResultMatch;
if (bHaveA && bHaveB)
return nVersionA > nVersionB;
196: return bHaveA - bHaveA;<--- Same expression on both
sides of
'-'.
}
};
If we follow the same logic as the function compareFontNames defined some
lines above in the same file :
int compareFontNames(const FcPattern *a, const FcPattern *b)
{
FcChar8 *pNameA=NULL, *pNameB=NULL;
bool bHaveA = FcPatternGetString(a, FC_FAMILY, 0, &pNameA) ==
FcResultMatch;
bool bHaveB = FcPatternGetString(b, FC_FAMILY, 0, &pNameB) ==
FcResultMatch;
if (bHaveA && bHaveB)
return strcmp((const char*)pNameA, (const char*)pNameB);
return bHaveA - bHaveB;
}
it seems it should be :
return bHaveA - bHaveB;
Any idea ?
Subtracting booleans ??? Is there some magic here ?
Moreover, if we state that boolean difference returns a boolean, is there
an automatic cast, as the function should return an int ?
IF we can state that doing the subtract, true = 1, false = 0 and operation
will send back an integer, then your proposal is ok. Still, not trivial.
Regards
--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)
Le Sun, 15 Jan 2012 06:48:28 +0100, Ivan Timofeev
a écrit:
Hi Mat,
cppcheck reported this :
core/vcl/generic/fontmanager/fontconfig.cxx
196 duplicateExpression style Same expression on both sides of '-'
class SortFont : public ::std::binary_function< const FcPattern*, const
FcPattern*, bool >
{
public:
bool operator()(const FcPattern *a, const FcPattern *b)
{
int comp = compareFontNames(a, b);
if (comp != 0)
return comp < 0;
int nVersionA=0, nVersionB=0;
bool bHaveA = FcPatternGetInteger(a, FC_FONTVERSION, 0,
&nVersionA) == FcResultMatch;
bool bHaveB = FcPatternGetInteger(b, FC_FONTVERSION, 0,
&nVersionB) == FcResultMatch;
if (bHaveA && bHaveB)
return nVersionA > nVersionB;
196: return bHaveA - bHaveA;<--- Same expression on both sides of
'-'.
}
};
it seems it should be :
return bHaveA - bHaveB;
Any idea ?
Subtracting booleans ??? Is there some magic here ?
Moreover, if we state that boolean difference returns a boolean, is
there an automatic cast, as the function should return an int ?
AFAIK in arithmetic bools are concerted to int so that true->1 and
false->0.
Then, the result is converted back to bool (because the function returns
bool) so that 0->false and 'any other value'->true.
So "return bool1 - bool2" can be replaced with not-so-magic "return
bool1 != bool2", right?
For operator(), absolutely. I was actually talking about compareFontNames.
But knowing that C++ does "on-the-fly" cast explains all.
By the way, the author of the code is Caolan, let's ask him. :)
Ivan
Mat
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problems with mozilla build-tools on WindowsXP
Hi Makoto Le Thu, 24 Nov 2011 02:46:53 +0100, Makoto Takizawa a écrit: hi I just success build on windows and wrote a note on wiki. https://wiki.documentfoundation.org/User:Foral/Build_Win Glad you succeed ! I ma still a bit surprised by the fact you had no issue with (x86) in your paths with default autogen.sh & configure.in. I tried from master and need to tweak variables in Env.host.sh to go further. could you confirm you had no prob with that ? Thanks Mathias around Mozilla, needed to download a lot of stuffs. (2011/11/24 8:10), Rob Snelders wrote: Hi All, I have followed [1] as a guide to build LO on windows. But when I run autogen it comes with "Mozilla build tooling incomplete". I run autogen with the options --with-mozilla-build='/cygwin/c/mozilla-build and --disable-build-mozilla. I have also downloaded the prebuild mozilla modules and set them in moz/zipped When it failed I downloaded the moztools-static.zip from the mozilla-buildtools-ftp and put that in the buildtools-directory. But that also didn't help. Does anybody knows why this error is given? [1] http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc
Hello Le Tue, 31 Jan 2012 21:48:30 +0100, Noel Power a écrit: On 31/01/12 20:29, Kohei Yoshida wrote: Well, that's rather hard to do with the Options dialog, since you can freely switch between different option pages and we then would have to check the validity of all the option tab pages upon dismissal of the whole Options dialog... you're correct, just staring at that single page in isolation without regard for the behaviour of the rest of the Option thingy, forget my mumblings :-/ looks indeed like processing the entered characters dynamically is needed Couldn't we imagine to do the check when leaving the tab, and keep it with popup if test fails ? Noel Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] R: R: Fatal error building Windows release (Cygwin)
Hi Noel Could you confirm you needed to update Env.host.sh before launching it ? At least *I* needed, since CC="/cygdrive/c/Program Files (x86)/MICROS~2.0/VC/bin/cl.exe" is not the kind of path make likes (spaces & parens). TY Mathias M Le Wed, 01 Feb 2012 17:22:58 +0100, Noel Grandin a écrit: I managed to get a successful Windows build. I'm running 64-bit Windows7, and my configure looks like: --with-max-jobs=6 --with-num-cpus=6 --without-junit --without-java --with-ant-home=/cygdrive/c/libreoffice/apache-ant-1.8.2 --disable-build-mozilla --disable-atl --disable-activex --with-windows-sdk-home=/cygdrive/c/Program Files/Microsoft SDKs/Windows/v7.1 --with-mozilla-build=/cygdrive/c/mozilla-build On 2012-01-31 16:37, walter wrote: The suggestion doesn't solve the problem. Regards Walter >>> cd xmlreader rm -Rf wntmsci12.pro build Disclaimer: http://www.peralex.com/disclaimer.html -- Utilisant le logiciel de courrier révolutionnaire d'Opera : http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-4] Couple of wiki-help related patches
Hello Kendy How NL translators are warned about changes in WikiHelp system ? Is there an automatic process, or just a mail is pushed to L10n list ? Regards Mat M Le Wed, 08 Feb 2012 17:36:27 +0100, Jan Holesovsky a écrit: Hi, I'm about to upload the new version of the 3.4 wikihelp. These are the patches I am using to generate that, would be great to get them in the repository :-) - can anybody sign-off & push them for me? They are all against the help repository. Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Android design?
Hello all, why not gather best of both worlds. Warmful users are used to the icons B U I, so let them have it. Underneath, use fuzzy logic and apply styles: If selection is empty or the selection looks like a paragraph, use a block style, else a char style. My 2 cents. Mat M -- _If there is no solution, there is no problem._ Le Wed, 08 Feb 2012 16:24:14 +0100, Christophe Strobbe a écrit: Hi, At 15:55 8-2-2012, Michael Meeks wrote: On Wed, 2012-02-08 at 13:43 +0100, Stefan Knorr (Astron) wrote: > Hehe. Take a look at the amazing mock-up and ideas that Mirek has been > working on for a while now: > http://clickortap.wordpress.com/frivl/ They look nice :-) > (No, none of this is perfectly specced out yet, but there's some > pretty cool stuff there.) So - one thing that I (personally) rather dislike is this "bold / italic / underline" meme that still lurks heavily in new UI designs. IMHO these need to be firmly held underwater until they expire ;-) Thanks a lot for highlighting this Michael. I also wish this wicked witch were dead. Good mockups around making styles more visible and manageable, creating (and customizing) new styles [ which can indeed include the bold/italic/underline elements ;-] much appreciated for that. Last month there was a short thread on the LibreOffice-design list about how the UI of LibreOffice could be modified to encourage the correct use of styles (as opposed to ad-hoc styling). (The thread started at <http://listarchives.libreoffice.org/global/design/msg03586.html>.) We should continue thinking about this. Otherwise, some good ideas there. Do we have excitable people wanting to do UI work in Java - that we can plug together with the core in due course ? it'd be great to parallelise that work. Best regards, Christophe -- Utilisant le logiciel de courrier révolutionnaire d'Opera : http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GNU make version
Hello Could someone point to archive on choosing gnumake ? I am surprised cmake was not elected, since the C means cross-platform, and that is one basic of LO. regards Mat M Le Wed, 07 Mar 2012 00:13:11 +0100, Matúš Kukan a écrit: On 6 March 2012 19:56, Michael Stahl wrote: On 06/03/12 18:12, Michael Meeks wrote: On Tue, 2012-03-06 at 19:08 +0200, Noel Grandin wrote: Don't see why we shouldn't maintain our own patched copy of gmake the same way we maintain patched copies of other components. There was a long discussion about this at the ESC :-) and I disagree with the decision, am still suffering slower builds from it on all my machines, but don't much feel like re-opening it personally. uhm, wasn't one of the reasons for picking GNU make that "it's standard, and available everywhere, and we won't get stuck in the situation where we have to maintain our own build tool" ? That could be a reason but when now turns out that also GNU make sucks, why we couldn't change our mind ? From what I read here on the dev ML I understood it's ~impossible to get our patches upstream so there is no other option than build again our own make. It's small and builds nicely (I think), so hopefully that's easy. The problem with patched 3.81 being faster than 3.82 can be hopefully also solved. Of course there can be also real disadvantages, I just can't see them. Anyway, don't take me too much seriously, just my 2 cents. All the best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Utilisant le logiciel de courrier révolutionnaire d'Opera : http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: CMake (Re: GNU make version)
Good evening! So I can't let my mailbox for the day without you stiffing it with mails :-) I will answer -almpost- all mails because I liked the discussions and some need my right of reply. Le Wed, 07 Mar 2012 14:03:16 +0100, Michael Stahl a écrit: On 07/03/12 12:57, Lubos Lunak wrote: On Wednesday 07 of March 2012, David Tardon wrote: On Wed, Mar 07, 2012 at 01:28:05AM +0100, Mat M wrote: Hello Could someone point to archive on choosing gnumake ? I am surprised cmake was not elected, since the C means cross-platform, and that is one basic of LO. indeed, and AFAIK most of the platforms are supported by CMake by way of the (GNU) make backend. what was your point again? oh, GNU stands for GNU's not UNIX, but we actually found that GNU make also works on UNIX as well :) Funny, my first insight was more about Microsoft OSes... Sigh, life would not be complete without enthusiasts telling us we should switch to cmake (or Qt) every few months. So, please, go read http://wiki.services.openoffice.org/wiki/Build_System_Analysis for the basics and http://openoffice.2283327.n4.nabble.com/New-build-system-td2928559.html for more questions and answers. Thank you for providing the links I asked for. It seems OOo still a reference to understand what's up now. My second sentence was not to troll and/or rant (So you should not sigh ;)). I just wanted to expose my gut feelings about Cmake, and also had the "having more Windows devs" rant in mind; I didn't talked about: - Cmake roughly seems more active than gnu make. Not that it is a pledge of quality, but fixing might be easier. - Cmake also allows to build under Visual Studio (Don't feel obliged to answer ;)) I will dive into links to understand. That comparison appears to be seriously biased towards gbuild (referred to as 'GNU Make' in the document). I'm not build system expert, but judging from my CMake experience in KDE, the information and conclusions for CMake are either outdated or just plain wrong (given the document dating to the time when KDE SC 4.4 had been released, thus CMake having been used for more than 2 years by that time, I assume it's the the latter). In particular: most of the people doing the comparison weren't build system experts either, they just had a list of requirements that the current dmake/build.pl system could not fulfill. then they sought input from build system experts on the tools@ooo mailing list, and the CMake maintainer actually showed up there to discuss things. [...] So I have now a fresh view of what happened 2 years ago :) TY Le Wed, 07 Mar 2012 13:28:09 +0100, Bjoern Michaelsen a écrit: Lets just finish this migration and kill of dmake and build.pl instead. I totally agree Best regards to you all enthusiasts Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
OpenGrok updates ?
Hello, I am not sure if OpenGrok is still refreshing. It references a core/icon-themes folder i don't have [1]. Under 3.5 branch, the files exposed are in default_images and ooo_custom_images. Regards [1] : http://opengrok.libreoffice.org/s?n=25&start=150&path=lc_bold.png&sort=fullpath&project=core, -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][REVIEW 3-5] fdo#46809 incomplete formula in formulabar
Hello Since Patchtool is around, marking thread :) Mat M Le Fri, 16 Mar 2012 21:29:10 +0100, Kohei Yoshida a écrit: On Fri, 2012-03-16 at 08:37 -0600, Noel Power wrote: please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b1592165d0513e90e28dfee92bc9db032fa221 Yes. We already discussed this & did a thorough test yesterday on IRC. I confirm that this change resolves the out-of-sync range input with mouse between the cell and the input bar, and also does not re-introduce a crash when typing Japanese via scim (which was the reason for the change which introduced the regression). Pushed to 3-5 with my sign off. Kohei -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build failed on cairo (Win32)
Good evening all, Since 3 days, my environment does not build fully (it did last week). Win7 x64, building Win32 with msvc 2008 Express under Cygwin. It stops when building libcairo. I tried to relaunch with: /opt/lo/bin/make cairo.clean cairo which lead to the command: cl -MD -O2 -MD -LD -Ferelease/cairo.dll ../../../../lib/pixman-1.lib release/cairo-analysis-surface.obj release/cairo-arc.obj release/cairo-array.obj release/cairo-atomic.obj release/cairo-base64-stream.obj [SNIP] whose end of output is : Creating library release/cairo.lib and object release/cairo.exp LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library cairo-deflate-stream.obj : error LNK2019: unresolved external symbol _deflate referenced in function _cairo_deflate_stream_deflate cairo-deflate-stream.obj : error LNK2019: unresolved external symbol _deflateEnd referenced in function __cairo_deflate_stream_close cairo-deflate-stream.obj : error LNK2019: unresolved external symbol _deflateInit_ referenced in function __cairo_deflate_stream_create release/cairo.dll : fatal error LNK1120: 3 unresolved externals The warning seems to come from parameters conflicts but am not sure whether it has an impact on the error just after. Since I am the only one complaining (and tinderboxes do not report it neither), and nothing has changed there since December, I am in the dark about what is the source. My autogen.lastrun is: --with-max-jobs=3 --with-num-cpus=3 --disable-directx --disable-binfilter --without-junit --disable-build-mozilla --with-mozilla-build=/cygdrive/c/data/mozilla-build --with-ant-home=/ant --disable-odk --with-windows-sdk-home=/cygdrive/C/Program Files/Microsoft SDKs/Windows/v7.1 --disable-activex Thanks for any help/insight/mentoring. Regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failed on cairo (Win32)
Hi already got the commits. Make clean was necessary. TY Mat M Le Sat, 07 Apr 2012 18:23:28 +0200, julien2412 a écrit: Hi, If you talk about master repository, there have been some commits recently which could help : http://cgit.freedesktop.org/libreoffice/core/commit/?id=6219ff898a8c3ae6b7abe4272b4b68cc986093e4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=e20fa170160e1bb1953ad171e092edfb3de531af I would do a make clean && make to compile from scratch but perhaps there's another way to avoid this. Julien. -- View this message in context: http://nabble.documentfoundation.org/Build-failed-on-cairo-Win32-tp3891535p3892975.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Configure.in tweaking for windows
Good evening all, I am checking for usefulness of adding another option for Win builders in configure.in . In configure.in, I saw that around line 2750 : # Check for 64-bit (cross-)compiler to use to build the 64-bit # version of the Explorer extension (and maybe other small [SNIP] AC_MSG_CHECKING([for a x64 compiler and libraries for 64bit ActiveX component]) if test "$CL_X64" = "" -a -f "$with_cl_home/atlmfc/lib/amd64/atls.lib"; then This test occurs after checking if we enabled ATL and/or activex. If I understand well, LO does not need Activex to build 64-bit shell extension, so why searching for atls.lib there (it seems to come from Kendy on ee03eb213fa31efb6d5fea16edbeb64dd8b38a9f ) ? If ATL is needed (only for ?) ActiveX, why do we have 2 options for that ?either is disabled, we should not even try to search for the compiler, no ? Thanks for the reply. -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Configure.in tweaking for windows
Hello Late reply Le Tue, 10 Apr 2012 15:26:02 +0200, Tor Lillqvist a écrit: # Prefer native x64 compiler to cross-compiler, in case we are running # the build on a 64-bit OS. To clarify: this is related to the build of a 64-bit Explorer extension while building LibreOffice itself in a normal 32-bit fashion. It is not related to building a 64-bit LibreOffice. --tml Sure, but why do you check for atls.lib file ? CL_X64 is enough for the purpose, isn't it ? Explorer extension is not an ActiveX, is it ? -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build Failure on Cygwin Windows
Hello Under windows native (don't know about cygwin), there is one limit at 250 characters, depending on the way you store the path (seen with an old version of sqlite dll). This kind of error is more prone when you have a long series of folder, like java components etc. HTH regards Le Sat, 14 Apr 2012 09:42:16 +0200, Lubos Lunak a écrit: On Friday 13 of April 2012, Matúš Kukan wrote: On 12 April 2012 13:38, Caolán McNamara wrote: > On Thu, 2012-04-12 at 12:57 +0200, Michael Stahl wrote: >> rumor has it that putting the source in Cygwin home has never ever >> worked, but i have no idea why. Heh, so I may be the first person in the world who have done that ? :-) ... Anyway with this patch I was able to build in /home, install and also write some text in Draw. Hopefully it will work also for others (for all ?). Could someone, please, try ? Works for me too. I have changed the Win-x86_6-fast tinderbox to build in ~/libreoffice , so this should not go unnoticed the next time. I think we could remove new warning from http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies I wonder about the part about the length of the path. (c:/cygwin)/home/tinderbox/libreoffice is not that short, but the build has finished successfully, the resulting .msi installed without problems, and I didn't notice any problems when running it. Has that been fixed somehow as well? -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Windows - Embed Server et al.
Hello, I am trying to decrypt some of the Windows bits of LO, namely OLE & ActiveX parts. If I read correctly http://en.wikipedia.org/wiki/Object_Linking_and_Embedding, it says that OLE is an interface, mainly used in Windows, but which could be implemented everywhere. When doing Insert/Object/OLE Object in LibO, we can see all our components here. IIUC, LibO uses it to incorporate data coming from LibO components in another LibO component (same type or not). And it works under Windows & under Linux, which is smart. So now, I have a full load of questions :) 1. Why the OLE components are not visible from other OLE-capable Windows apps like Wordpad ? Is it only an internal implementation which is only compatible to itself ? 2. When browsing the sources I found : - extensions/source/ole : what does it do ? - extensions/source/activex : it should provide an activex of LibO. The README.txt states we should have a so_activex.dll we need to register but I don't find any dll in 3.5.2 which seems related to that. Is it still delivered ? 3. I tried to detect components in my system: - In DCOM config, I only see a LibreOffice Service Manager 1.0, which is related to soffice.exe. - From VC++2008Express, no .Net or COM component is detected. Is it normal ? 4. extensions/source/ole, extensions/source/activex & embedserv all require atl & mfc from Microsoft. How do you handle that under non-Windows OSes ? Thanks in advance to the people who will answer :) Best regards -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Windows - Embed Server et al.
Le Thu, 19 Apr 2012 10:03:04 +0200, Noel Grandin a écrit: OOh, I really hope you're planning on working on: https://bugs.freedesktop.org/show_bug.cgi?id=38808 That would make setting up windows build machines much easier. Nope. I am not a so-skilled developer, alas. shmget already found a solution for ATL, and I plan to add an option --with-atl-path to configure for that. ActiveX/OLE is not compiled into LO on platforms other than Windows. And what about EmbedServ ? It is needed for OLE Object embedding featured under *nix & BSD etc, no ? Le Thu, 19 Apr 2012 12:28:46 +0200, Michael Meeks a écrit: On Thu, 2012-04-19 at 11:26 +0300, Tor Lillqvist wrote: > It looks like the ActiveX control was intended to allow embedding of LO > inside InternetExplorer. And *my* opinion is that such embedding opens up a horrible Pandora's box of potential problems that we don't really have enough people to It is also used in Groupwise for editing mail. One item in the I was afraid of that. A real use case of the ActiveX ;) Pandora's box is that 'framework' insists on storing your toolbar state and applying it to all windows. So if the user turns the gallery on in their top-level document window, it busts the E-mail editor :-) The E-mail editor tries to hide ~all the formatting toolbars, which busts the top-level document editing. It'd be really wonderful to have a fix for that - to make the ActiveX control independent of the framework madness trying to serialize it's settings everywhere. I am not enough skilled in C/C++ for that, and I think it is far from an EasyHack anyway, so ... I don't really see removing it as an option though. Of course. HTH, Yes, it helps :) Michael. -- Mat M ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
