Le Mon, 17 Jun 2013 12:36:48 +0200, Andras Timar <tima...@gmail.com> a écrit:

On Mon, Jun 17, 2013 at 12:35 AM, Mat M <m...@gmx.fr> wrote:
CAs (Custom Action) outside shellextensions are fine.

Well, the job of regactivex/regpatchactivex should be done by normal
actions, custom action is for this is a hack.
OK, but I only can try on Win7.
regpatchactivex just remove the CLSID from the base mimetype => I will check if it is ok without that. regactivex was for Win98/ME,so it should be fine. I may need help for the MSI changes, though.


About shellextensions ones, here is my status:


* completeinstallpath.cxx : handle the first level directories :

I don't think we upgrade OOo 3.0, OOo 3.1 or OOo 3.2 , so this is
useless, but please test it, before removing.

* vistaspecial.cxx: i#94560 .
        => To keep.

This is a dirty hack. I wonder if the original bug that it solves, is
reproducible with our installer. If not, remove it.

I cannot check. Anyone with a vista computer ?


* startmenuicon.cxx: was used to have a special icon on start menu folder.
Disabled since vista.
        => to be removed

Please keep it, we still support Windows XP.

Well, it is not about supporting XP, it is about setting a custom icon for the folder in the Start Menu which holds the LibreOffice icons.


* upgrade.cxx: i#43855 [1]. Not sure we want to reproduce use case from
comment 6.
        => to confirm

User installation (as opposed to system wide installation) is
generally unsupported. I mean it may not work at all, and IMHO it
makes little sense.

=> so we remove it. :)

* checkpatches.cxx: used for upgrades (differential msi). Check if previous
patches have been applied.
        => to keep, hoping for the return of .msp :)

You can keep it, however, I don't know how it is supposed to work.
Well, you are right, this should be handled by the msi itself, so removal is ok :)


* layerlinks.cxx: handle creation of a ure-link file at root. this file is used to abstract URE path in code (mainly installation related, though). My
question is: could we create this file during instsetoo and add it as a
simple file in the MSI, so CustomAction could be removed ?
        => to keep for now

See Stephan's mail.
Yes. I may try ti include the file as is, but still may need help for that.

* migrateinstallpath.cxx: used to emulate upgrade pahse with 2 MSI with no
upgradecode inside.
        => to keep for now.
OK.

Thanks,
Andras

Regards
--
Mat M
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to