[kdevelop] [Bug 486932] Background parser crash C++ source
https://bugs.kde.org/show_bug.cgi?id=486932 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #10 from Dan Leinir Turthra Jensen --- Just adding my two eurocents to the thing, to say that i also got this while adding an #include. It does not happen fully consistently, but maybe every other time i try and add one (feels like more regularly than that, but that's probably more because i only really notice when i have to restart the program). Backtrace: Application: KDevelop (kdevelop), signal: Segmentation fault [KCrash Handler] #4 llvm::support::endian::read(void const*, llvm::endianness) (endian=llvm::endianness::little, memory=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/include/llvm/Support/Endian.h:61 #5 llvm::support::endian::readNext(unsigned char const*&, llvm::endianness) (endian=llvm::endianness::little, memory=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/include/llvm/Support/Endian.h:78 #6 llvm::support::endian::readNext(unsigned char const*&) (memory=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/include/llvm/Support/Endian.h:86 #7 llvm::OnDiskChainedHashTable::find_hashed(clang::serialization::DeclarationNameKey const&, unsigned int, clang::serialization::reader::ASTDeclContextNameLookupTrait*) (this=0x7f481a5a1c28, IKey=..., KeyHash=2629119989, InfoPtr=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/include/llvm/Support/OnDiskHashTable.h:363 #8 clang::serialization::MultiOnDiskHashTable::find(clang::DeclarationName const&) (this=, EKey=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/Serialization/MultiOnDiskHashTable.h:252 #9 clang::ASTReader::FindExternalVisibleDeclsByName(clang::DeclContext const*, clang::DeclarationName) (this=0x7f48a77b79d0, DC=0x7f481bd42e08, Name=...) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/Serialization/ASTReader.cpp:7972 #10 0x7f4aec96a0d9 in clang::DeclContext::lookup(clang::DeclarationName) const (this=0x7f481bd42e08, Name=...) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/AST/DeclBase.cpp:1822 #11 0x7f4aee6b6f0a in clang::ASTReader::CompleteRedeclChain(clang::Decl const*) (this=0x7f48a77b79d0, D=0x7f47cbe7c748) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/Serialization/ASTReader.cpp:7535 #12 0x7f4aec94de2d in clang::LazyGenerationalUpdatePtr::get(clang::Decl const*) (O=0x7f47cbe7c748, this=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/include/clang/AST/ExternalASTSource.h:449 #13 clang::Redeclarable::DeclLink::getPrevious(clang::FunctionDecl const*) const (this=0x7f47cbe7c7b0, D=0x7f47cbe7c748) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/include/clang/AST/Redeclarable.h:134 #14 clang::Redeclarable::getNextRedeclaration() const (this=0x7f47cbe7c7b0) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/include/clang/AST/Redeclarable.h:190 #15 clang::Redeclarable::redecl_iterator::operator++() (this=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/include/clang/AST/Redeclarable.h:273 #16 clang::FunctionDecl::hasBody(clang::FunctionDecl const*&) const (this=0x7f47cbe7c748, Definition=@0x7f4b1c9fe150: 0x0) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/AST/Decl.cpp:3112 #17 0x7f4aec94e1cf in clang::FunctionDecl::getBody(clang::FunctionDecl const*&) const (this=0x7f4b1c9fdbc0, Definition=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/lib/AST/Decl.cpp:3192 #18 0x7f4b2a8b0ae6 in clang_getCursorDefinition(CXCursor) (C=...) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/tools/libclang/CIndex.cpp:6911 #19 0x7f4b2a981f44 in () at /lib64/libKDevClangPrivate.so.514 #20 0x7f4b2a8a23a7 in clang::cxcursor::CursorVisitor::Visit(CXCursor, bool) (this=0x7f4b1c9fe658, Cursor=..., CheckedRegionOfInterest=true) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/tools/libclang/CIndex.cpp:225 #21 clang::cxcursor::CursorVisitor::handleDeclForVisitation(clang::Decl const*) (this=0x7f4b1c9fe658, D=) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/tools/libclang/CIndex.cpp:694 #22 0x7f4b2a8a24f8 in clang::cxcursor::CursorVisitor::VisitDeclContext(clang::DeclContext*) (this=0x7f4b1c9fe658, DC=0x7f481bd42e08) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/tools/libclang/CIndex.cpp:655 #23 0x7f4b2a8a100e in clang::declvisitor::Base::Visit(clang::Decl*) (this=0x7f4b1c9fe658, D=0x7f481bd42dc8) at tools/clang/include/clang/AST/DeclNodes.inc:414 #24 clang::cxcursor::CursorVisitor::VisitChildren(CXCursor) (this=0x7f4b1c9fe658, Cursor=...) at /home/abuild/rpmbuild/BUILD/llvm-18.1.6.src/tools/clang/tools/libclang/CIndex.cpp:514 #25 0x7f4b2a8aca20 in clang_visitChildren(CXCursor, CXCursorVisitor, CXClientData) (pare
[plasmashell] [Bug 485588] New: Application Dashboard: Can't run searched commands using keyboard
https://bugs.kde.org/show_bug.cgi?id=485588 Bug ID: 485588 Summary: Application Dashboard: Can't run searched commands using keyboard Classification: Plasma Product: plasmashell Version: 6.0.3 Platform: openSUSE OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: plasma-b...@kde.org Reporter: ad...@leinir.dk CC: k...@davidedmundson.co.uk Target Milestone: 1.0 SUMMARY In Plasma 5's Application Dashboard, it was possible to use it effectively as one would use krunner. This is no longer possible, and you end up having to use either mouse or touch screen to activate results from a search (pressing enter does not work, and neither tab nor arrow keys will move focus around) STEPS TO REPRODUCE 1. Open Application Dashboard 2. Type some search term (for example "kons") 3. Attempt to launch the first result in the list by pressing the enter key OBSERVED RESULT Nothing happens (at least it doesn't for e.g. close the overlay or whatnot, which is certainly nice) EXPECTED RESULT The first result is activated (in the case of the example, konsole would be launched and the overlay closed) Versions and such as per selections (openSUSE Tumbleweed current as of 2024/04/15) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 447281] Download New never finishes loading when proxy configuration available
https://bugs.kde.org/show_bug.cgi?id=447281 --- Comment #8 from Dan Leinir Turthra Jensen --- The reason for not using KIO is pretty simple: While KNewStuff3 (the widgets bit) can pull in widget dependencies without issue, KNSCore and KNSQuick should not, and including KIO ends up pulling in a requirement on KXMLGui. At least, that was the case when we originally made this decision (and wrote that code) a couple of years ago. If KIO's core "just get me this file" is now available without pulling in the huge dependency chain, then sure, there's no problem. Perhaps this changed with the recent KIO Workers, ehrm, work? But, in short: KIO isn't the problem, introducing a hard dependency on qwidgets to a qtquick module is. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 447281] Download New never finishes loading when proxy configuration available
https://bugs.kde.org/show_bug.cgi?id=447281 --- Comment #10 from Dan Leinir Turthra Jensen --- An update here, i had a chat with Harald and David earlier, who suggested that yes, the purposes we have for this code /should/ now be possible using KIO Workers, by simply telling the function to just not do any UI things (which we don't support anyway with the current code, so no regressions), which would allow us to only require KIOCore, and then not need any of the widget stuff at all for distributing or launching any applications (which is the main issue, since we can't sensibly introduce widget dependencies in pure qml apps). So, in short: It should be possible to get rid of the current implementation, in favour of KIO Workers, given a bit of effort. -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 442583] New: Crash when returning from a file listing
https://bugs.kde.org/show_bug.cgi?id=442583 Bug ID: 442583 Summary: Crash when returning from a file listing Product: amarok Version: 2.9.71 Platform: openSUSE RPMs OS: Linux Status: REPORTED Keywords: drkonqi Severity: crash Priority: NOR Component: general Assignee: amarok-bugs-d...@kde.org Reporter: ad...@leinir.dk Target Milestone: kf5 Application: amarok (2.9.71) Qt Version: 5.15.2 Frameworks Version: 5.85.0 Operating System: Linux 5.14.1-1-default x86_64 Windowing System: X11 Drkonqi Version: 5.22.5 Distribution: "openSUSE Tumbleweed" -- Information about the crash: - What I was doing when the application crashed: Attempted to navigate back in the sidebar from a file listing, and any of the options (either the home icon, >, or Files, causes a crash. I noticed that the breadcrumbs only show "[home] > Files", and not the path shown in the file browser (not sure if related, but probably best to mention it). The crash can be reproduced every time. -- Backtrace: Application: Amarok (amarok), signal: Segmentation fault Content of s_kcrashErrorMessage: [Current thread is 1 (Thread 0x7fa09d2adfc0 (LWP 21928))] [KCrash Handler] #6 std::__atomic_base::load(std::memory_order) const (__m=std::memory_order_acquire, this=0x6c) at /usr/include/c++/11/bits/atomic_base.h:836 #7 std::atomic::load(std::memory_order) const (__m=std::memory_order_acquire, this=0x6c) at /usr/include/c++/11/atomic:570 #8 QAtomicOps::loadAcquire(std::atomic const&) (_q_value=...) at ../../include/QtCore/../../src/corelib/thread/qatomic_cxx11.h:251 #9 QBasicAtomicPointer::loadAcquire() const (this=0x6c) at ../../include/QtCore/../../src/corelib/thread/qbasicatomic.h:255 #10 QCoreApplicationPrivate::lockThreadPostEventList(QObject*) (object=) at kernel/qcoreapplication.cpp:1494 #11 0x7fa0a84d0f49 in QCoreApplication::postEvent(QObject*, QEvent*, int) (receiver=0x3316ab0, event=0x3eb1c60, priority=0) at kernel/qcoreapplication.cpp:1546 #12 0x7fa0a9a30b05 in BrowserCategory::clearAdditionalItems() (this=0x3229640) at /home/leinir/projects/amarok/src/browsers/BrowserCategory.cpp:168 #13 0x7fa0a9a31d3f in BrowserCategoryList::home() (this=0x2a75680) at /home/leinir/projects/amarok/src/browsers/BrowserCategoryList.cpp:120 #14 0x7fa0a9a2e8f5 in QtPrivate::FunctorCall, QtPrivate::List<>, void, void (BrowserCategoryList::*)()>::call(void (BrowserCategoryList::*)(), BrowserCategoryList*, void**) (f=(void (BrowserCategoryList::*)(class BrowserCategoryList * const)) 0x7fa0a9a31cc8 , o=0x2a75680, arg=0x7fffdf5ed370) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #15 0x7fa0a9a2e678 in QtPrivate::FunctionPointer::call, void>(void (BrowserCategoryList::*)(), BrowserCategoryList*, void**) (f=(void (BrowserCategoryList::*)(class BrowserCategoryList * const)) 0x7fa0a9a31cc8 , o=0x2a75680, arg=0x7fffdf5ed370) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #16 0x7fa0a9a2e2ba in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x4005620, r=0x2a75680, a=0x7fffdf5ed370, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #17 0x7fa0a8504033 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7fffdf5ed370, r=0x2a75680, this=0x4005620) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 #18 doActivate(QObject*, int, void**) (sender=0x3c539e0, signal_index=9, argv=0x7fffdf5ed370) at kernel/qobject.cpp:3886 #19 0x7fa0a84fd4ff in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=sender@entry=0x3c539e0, m=m@entry=0x7fa0a95964e0 , local_signal_index=local_signal_index@entry=2, argv=argv@entry=0x7fffdf5ed370) at kernel/qobject.cpp:3946 #20 0x7fa0a916b9f2 in QAbstractButton::clicked(bool) (this=this@entry=0x3c539e0, _t1=) at .moc/moc_qabstractbutton.cpp:308 #21 0x7fa0a916bc6a in QAbstractButtonPrivate::emitClicked() (this=0x4007bf0) at widgets/qabstractbutton.cpp:415 #22 0x7fa0a916d830 in QAbstractButtonPrivate::click() (this=0x4007bf0) at widgets/qabstractbutton.cpp:408 #23 0x7fa0a916da53 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) (this=0x3c539e0, e=0x7fffdf5ed910) at widgets/qabstractbutton.cpp:1044 #24 0x7fa0a90ba76e in QWidget::event(QEvent*) (this=0x3c539e0, event=0x7fffdf5ed910) at kernel/qwidget.cpp:9020 #25 0x7fa0a9078a7f in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x1fb2da0, receiver=receiver@entry=0x3c539e0, e=e@entry=0x7fffdf5ed910) at kernel/qapplication.cpp:3632 #26 0x7fa0a9080584 in QApplication::notify(QObject*, QEvent*) (this=0x7fffdf5ed630, receiver=0x3c539e0, e=0x7fffdf5ed910) at kernel/qapplication.cpp:3076 #27 0x7fa0a84cd9ea in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x3c539e0, event=0x7fffdf5ed910) at kernel/qcoreapplication.cpp:1064 #28 0x7fa0a907f093
[amarok] [Bug 442583] Crash when returning from a file listing
https://bugs.kde.org/show_bug.cgi?id=442583 --- Comment #1 from Dan Leinir Turthra Jensen --- Created attachment 141641 --> https://bugs.kde.org/attachment.cgi?id=141641&action=edit Stuck like this - any click on the circled controls causes the crash -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 442583] Crash when returning from a file listing
https://bugs.kde.org/show_bug.cgi?id=442583 --- Comment #2 from Dan Leinir Turthra Jensen --- It seems like this is likely related (i see something about updating breadcrumbs in the backtrace). This happens on quit, though, not while using the app in general. Application: Amarok (amarok), signal: Segmentation fault Content of s_kcrashErrorMessage: [Current thread is 1 (Thread 0x7fd46a81ffc0 (LWP 6893))] [KCrash Handler] #6 0x7fd47662e5a4 in QWidget::setParent(QWidget*) (this=0x196b1e0, parent=0x10cd370) at kernel/qwidget.cpp:10339 #7 0x7fd476fa12c3 in BrowserBreadcrumbWidget::addBreadCrumbItem(BrowserBreadcrumbItem*) (this=0x10cad10, item=0x196b1e0) at /home/leinir/projects/amarok/src/browsers/BrowserBreadcrumbWidget.cpp:171 #8 0x7fd476fa0edf in BrowserBreadcrumbWidget::addLevel(BrowserCategoryList*) (this=0x10cad10, list=0x10a3650) at /home/leinir/projects/amarok/src/browsers/BrowserBreadcrumbWidget.cpp:120 #9 0x7fd476fa0d34 in BrowserBreadcrumbWidget::updateBreadcrumbs() (this=0x10cad10) at /home/leinir/projects/amarok/src/browsers/BrowserBreadcrumbWidget.cpp:84 #10 0x7fd476fa2216 in QtPrivate::FunctorCall, QtPrivate::List<>, void, void (BrowserBreadcrumbWidget::*)()>::call(void (BrowserBreadcrumbWidget::*)(), BrowserBreadcrumbWidget*, void**) (f=(void (BrowserBreadcrumbWidget::*)(class BrowserBreadcrumbWidget * const)) 0x7fd476fa0cf8 , o=0x10cad10, arg=0x7ffdc58bce30) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #11 0x7fd476fa20c2 in QtPrivate::FunctionPointer::call, void>(void (BrowserBreadcrumbWidget::*)(), BrowserBreadcrumbWidget*, void**) (f=(void (BrowserBreadcrumbWidget::*)(class BrowserBreadcrumbWidget * const)) 0x7fd476fa0cf8 , o=0x10cad10, arg=0x7ffdc58bce30) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #12 0x7fd476fa1ddc in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x1039420, r=0x10cad10, a=0x7ffdc58bce30, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #13 0x7fd475a76033 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7ffdc58bce30, r=0x10cad10, this=0x1039420) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 #14 doActivate(QObject*, int, void**) (sender=0x10a3650, signal_index=7, argv=0x7ffdc58bce30) at kernel/qobject.cpp:3886 #15 0x7fd476f0217f in BrowserCategoryList::viewChanged() (this=0x10a3650) at /home/leinir/projects/amarok/build/src/amaroklib_autogen/H7W3GF2ISY/moc_BrowserCategoryList.cpp:198 #16 0x7fd476fa4280 in BrowserCategoryList::childViewChanged() (this=0x10a3650) at /home/leinir/projects/amarok/src/browsers/BrowserCategoryList.cpp:230 #17 0x7fd476fa08f5 in QtPrivate::FunctorCall, QtPrivate::List<>, void, void (BrowserCategoryList::*)()>::call(void (BrowserCategoryList::*)(), BrowserCategoryList*, void**) (f=(void (BrowserCategoryList::*)(class BrowserCategoryList * const)) 0x7fd476fa4252 , o=0x10a3650, arg=0x7ffdc58bd020) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:152 #18 0x7fd476fa0678 in QtPrivate::FunctionPointer::call, void>(void (BrowserCategoryList::*)(), BrowserCategoryList*, void**) (f=(void (BrowserCategoryList::*)(class BrowserCategoryList * const)) 0x7fd476fa4252 , o=0x10a3650, arg=0x7ffdc58bd020) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:185 #19 0x7fd476fa02ba in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x1095d30, r=0x10a3650, a=0x7ffdc58bd020, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:418 #20 0x7fd475a76033 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7ffdc58bd020, r=0x10a3650, this=0x1095d30) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 #21 doActivate(QObject*, int, void**) (sender=0xf331e0, signal_index=7, argv=0x7ffdc58bd020) at kernel/qobject.cpp:3886 #22 0x7fd476f0217f in BrowserCategoryList::viewChanged() (this=0xf331e0) at /home/leinir/projects/amarok/build/src/amaroklib_autogen/H7W3GF2ISY/moc_BrowserCategoryList.cpp:198 #23 0x7fd476fa408e in BrowserCategoryList::removeCategory(BrowserCategory*) (this=0xf331e0, category=0x25944a0) at /home/leinir/projects/amarok/src/browsers/BrowserCategoryList.cpp:182 #24 0x7fd476f9436b in ScriptableServiceManager::removeRunningScript(QString const&) (this=0x1933b20, name=...) at /home/leinir/projects/amarok/src/services/scriptable/ScriptableServiceManager.cpp:111 #25 0x7fd477374c3e in ScriptItem::pause() (this=0x19cd710) at /home/leinir/projects/amarok/src/scripting/scriptmanager/ScriptItem.cpp:148 #26 0x7fd477375fe5 in ScriptItem::stop() (this=0x19cd710) at /home/leinir/projects/amarok/src/scripting/scriptmanager/ScriptItem.cpp:326 #27 0x7fd47737616c in ScriptItem::~ScriptItem() (this=0x19cd710, __in_chrg=) at /home/leinir/projects/amarok/src/scripting/scriptmanager/ScriptItem.cpp:355 #28 0x7fd477376224 in ScriptItem::~ScriptItem() (this=0x19
[frameworks-knewstuff] [Bug 442879] KStars crashes when clicking on Download New Data due to KNewStuff 5.86.0
https://bugs.kde.org/show_bug.cgi?id=442879 --- Comment #11 from Dan Leinir Turthra Jensen --- Well, heck... Yeah, that's my fault, sorry about that. As i said elsewhere, this is what happens when you write a bit of code, and then go "well, but what if some obscure compiler doesn't know how to scoping good" and then you change a thing in one place and forget it in the other (that is, both the member var and function parameter used to be q, but i then decided that they should be slightly more clear, and then... didn't do all of it). So, yeah, really sorry about that - and no blame on the reviewers of the original patch either, super awkward thing to spot. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 451165] Error message when clicking "Get new icons..." in system settings
https://bugs.kde.org/show_bug.cgi?id=451165 --- Comment #6 from Dan Leinir Turthra Jensen --- i mean, apart from the remote host refusing to serve us seeming like it has to be a service side issue, i'm really not sure... Especially given how this code just hasn't changed on our side for ages, and it's suddenly broken... Maybe something with the new caching setup causes it to fail if there's a language set in the request header? (which we don't do ourselves, but i expect it gets sent along by qnam, not really sure). A quick test just trying to manually set the accept-language header to fr seems to just result in a correctly returned list of categories, though, so i'm really not sure what's going on here. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 443032] Kate crashes while trying to download new snippets using Snippets plugin
https://bugs.kde.org/show_bug.cgi?id=443032 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- Thanks for reporting - it's already fixed in frameworks, and backports have been requested with the distros :) *** This bug has been marked as a duplicate of bug 442879 *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 442879] KStars crashes when clicking on Download New Data due to KNewStuff 5.86.0
https://bugs.kde.org/show_bug.cgi?id=442879 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||arpan...@gmail.com --- Comment #12 from Dan Leinir Turthra Jensen --- *** Bug 443032 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443852] New: Cannot scroll timeline horizontally
https://bugs.kde.org/show_bug.cgi?id=443852 Bug ID: 443852 Summary: Cannot scroll timeline horizontally Product: krita Version: 5.0.0-beta2 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: Animation Assignee: krita-bugs-n...@kde.org Reporter: ad...@leinir.dk Target Milestone: --- When setting the length of an animation to kind-of-long (in my case 1440 frames, for a minute of animation at the default speed), you end up in a situation where if you zoom out as far as the timeline will go, you cannot get to the frames past 220 on a 4K display (the scrollbars on the timeline seem to just be 1:1, but you /can/ scroll vertically with two-finger scrolling on a touchpad, but horizontal seems to not work). i did try and restart, to see if it was just the UI not updating, and that didn't work. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 432665] Cannot update all updateable stuff by one click only need to do it one by one
https://bugs.kde.org/show_bug.cgi?id=432665 Dan Leinir Turthra Jensen changed: What|Removed |Added Severity|normal |wishlist Priority|NOR |LO Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Dan Leinir Turthra Jensen --- This is basically what Discover is for - updating your entire system to the freshest bits everywhere :) That said, having the ability to update all the updateable things for a specific knsrc file would probably be nice to have. It's not going to be a very high priority, i'm afraid, but certainly it'd be useful functionality. Resetting priorities and whatnot, and marking as confirmed :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 432888] Impossible to install two or more variants of an addon from KDE Store
https://bugs.kde.org/show_bug.cgi?id=432888 Dan Leinir Turthra Jensen changed: What|Removed |Added Severity|normal |wishlist Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Dan Leinir Turthra Jensen --- Entirely correct, and i do want to make it possible to co-install multiple things. However, it is annoyingly not a straightforward problem, as we cannot simply assume that co-installability is a given for all types of content. But, it's something that definitely wants to be possible, so i'll mark this as a wishlist item and confirmed. Also, in case you think you remember that this used to be possible with the old dialog - yes, it was possible to pick a new thing in the UI, but what would in reality happen is that knewstuff would leave a pile of stuff on your system that it no longer knew about, and which was then no longer managed by something on the system. Littering systems with unmanaged data isn't really an acceptable thing to do, so we didn't implement that particular misfeature in the qtquick components :) -- You are receiving this mail because: You are watching all bug changes.
[peruse] [Bug 426598] Several QML errors with latest master.
https://bugs.kde.org/show_bug.cgi?id=426598 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Dan Leinir Turthra Jensen --- The warnings and errors here are in a couple of different categories... First one is that silly thing where someone decided that deprecating something and making it impossible to hide the warning that produces was a reasonable choice in a product that is expected to be backwards compatible (that is, the Connections syntax deprecation where the new syntax is not implementable in a backwards compatible fashion)... The binding loops for contentHeight are being worked on as a side effect of porting the gridview components, which are being ported to Layouts rather than anchors. Finally the binding loop for actions should be workable (though it's something in Kirigami, i suspect it's something in Peruse anyway, and i'll take a look at that one). And as always, thank you :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427201] Package won't update
https://bugs.kde.org/show_bug.cgi?id=427201 Dan Leinir Turthra Jensen changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/ad9 ||212d983041e200bd2c4f0539cca ||6c364c9f71 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- Git commit ad9212d983041e200bd2c4f0539cca6c364c9f71 by Dan Leinir Turthra Jensen. Committed on 01/10/2020 at 11:33. Pushed by leinir into branch 'master'. Update versions for "fake" kpackage updates We will occasionally be asked to update a kpackage which is not, in fact, an update. This would result in the package not getting the new version and release date set, which in turn would result in the package being reported as updateable again on next updates check. M +8-1src/core/installation.cpp https://invent.kde.org/frameworks/knewstuff/commit/ad9212d983041e200bd2c4f0539cca6c364c9f71 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 426410] Discover crashed in KNSCore::KPackageJob::~KPackageJob() when I canceled the password dialog to authorize update twice
https://bugs.kde.org/show_bug.cgi?id=426410 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Version Fixed In||5.75 --- Comment #2 from Dan Leinir Turthra Jensen --- This should be fixed by https://invent.kde.org/frameworks/knewstuff/-/merge_requests/60, and consequently in 5.75. If you can still reproduce this, please reopen with a new backtrace (as the old one's invalidated by the above changes) :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 426750] Discover crashes when updating plasma themes
https://bugs.kde.org/show_bug.cgi?id=426750 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Version Fixed In||5.75 --- Comment #4 from Dan Leinir Turthra Jensen --- If i'm reading the backtrace here correctly, this should be fixed in 5.75 through one or the other of https://invent.kde.org/frameworks/knewstuff/-/merge_requests/60 or https://invent.kde.org/frameworks/knewstuff/-/merge_requests/59 - if you're still able to reproduce the bug after upgrading to Frameworks 5.75, please reopen with a new backtrace (as the old one is now invalidated due to the changes in those two MRs). Thanks! :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 441760] Installer allows installing only one file in multi-file GHNS items
https://bugs.kde.org/show_bug.cgi?id=441760 --- Comment #2 from Dan Leinir Turthra Jensen --- The reason this seems like a regression from the old dialog is that it used to be possible to lose track of installed items by explicitly installing another item from an entry which had been previously installed. Basically, this ability was a bug, and so we end up in this situation. This is not to say the ability is not desirable, but it is just annoyingly not quite as straightforward as it might seem on the surface. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 438582] Removing global theme fails to erase all related files
https://bugs.kde.org/show_bug.cgi?id=438582 Dan Leinir Turthra Jensen changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Dan Leinir Turthra Jensen --- Thanks, and yes, that's confirmed. Now, of course, the super annoying part of my response: This is a non-trivial issue. Basically, we've no good way to determine whether things should be removed again automatically. It's akin to what happens with package managers, where there's no good way to detect whether something is still desired by the user. We /can/ detect whether something is still required by another specific thing on the system (that is, knewstuff can't, but kpackage (the bit that does the cross-origin bits) can do this, or at least be taught how to), and we can detect whether something is in use and refuse to remove it, but what we can't detect is whether the user wants to get rid of the main thing, but still wants to use something. That final bit, though, is arguably something where we just have to ask the user whether that's what they want to do, probably with the things that we know are safe to remove pre-checked, and the others not selected, with a description of why they're not selected (required by something else), or not available for removal (because they're in active use). But, yeah, in short, not a trivial issue, but one that we do want to try and work out how to deal with properly. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 439430] XML Provider does not find payload url if email attribute is set in the author tag
https://bugs.kde.org/show_bug.cgi?id=439430 --- Comment #2 from Dan Leinir Turthra Jensen --- Could i get you to upload the knsregistry for each of these as well? (as you've identified, that's the kstars.knsregistry file in ~/.local/share/knewstuff3/) Looking at the code, it seems sane enough to me at least, but that just means i'm missing something, so... more info would be good to try and narrow it down a bit :) -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 431876] Can't update themes using Discover on OpenSUSE Tumbleweed
https://bugs.kde.org/show_bug.cgi?id=431876 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC||ad...@leinir.dk Status|REPORTED|NEEDSINFO --- Comment #2 from Dan Leinir Turthra Jensen --- At the very least /some/ of this should be fixed now... There's multiple issues at play here, so i'll leave this one open to track the ones that are still open. One situation that would occur is the situation where there is one option to pick from, which it turns out has potentially been broken for a while (see https://invent.kde.org/frameworks/knewstuff/-/merge_requests/133 for a description of the problem). We still have that problem where Discover doesn't know how to forward queries to the user (specifically in this case the choice between a bunch of different options for downloads, where one can't be deduced automatically). As it works right now in Discover, any we can't work out just get aborted, and you should expect to end up with /some/ entries that aren't updated, but also that you should now be given an actionable error message about what you need to do to work around it in the meantime. Finally, being a bit wonky on the ol' German, we've got what feels to me like probably a server side issue, with that internal server error. Can you confirm whether or not this error exact error still exists today? The server side stuff has recently had a massive overhaul done to it, and it seems like that might have had an effect. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 439103] Discover crashed searching for DICOM
https://bugs.kde.org/show_bug.cgi?id=439103 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #3 from Dan Leinir Turthra Jensen --- Trying to work out why this would crash (and that's what the linked patch aims to solve). As to the search for DICOM returning a hit on GNOME Terminal, i can confirm, and also report that it's happening due to a partial match on the keywords in the appstream data, which are all in a long list, and translated to a bunch of different languages. There's not a whole lot we (or indeed the appstream folks, or the gnome terminal developers who supply the data to appstream) can reasonably do about that (this is what freetext searching is kind of supposed to do, even if it might seem a little odd). Thanks for the report, though :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 423719] system settings crash
https://bugs.kde.org/show_bug.cgi?id=423719 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.75 Status|REPORTED|RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- Yes, that is fixed in 5.75 :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 424644] Application: Systeeminstellingen (systemsettings5), signal: Segmentation fault
https://bugs.kde.org/show_bug.cgi?id=424644 Dan Leinir Turthra Jensen changed: What|Removed |Added Version Fixed In||5.75 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #3 from Dan Leinir Turthra Jensen --- Yup, that was fixed in 5.75 :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 427974] Crashed in Attica::ProviderManager::fileFinished() when trying to update
https://bugs.kde.org/show_bug.cgi?id=427974 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Dan Leinir Turthra Jensen --- Looking at this code, it's got to be something changed somewhere not in Attica, because that code hasn't changed since 2018... But, it /does/ crash in Attica, and the code is fairly obviously a bit dangerous, so whatever the cause for this suddenly showing up, the fix goes in Attica. MR coming momentarily :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427910] System Settings crashes in KNSCore::KPackageJob::~KPackageJob() when installing new themes
https://bugs.kde.org/show_bug.cgi?id=427910 --- Comment #5 from Dan Leinir Turthra Jensen --- Indeed... i am discovering new and exciting things, and a patch is arriving shortly which i would greatly appreciate if someone who can reproduce the crash would be so kind as to test out for me :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427910] System Settings crashes in KNSCore::KPackageJob::~KPackageJob() when installing new themes
https://bugs.kde.org/show_bug.cgi?id=427910 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/e19 ||17b6a3bc876ef852ef22769fde0 ||7943ea3847 Status|ASSIGNED|RESOLVED --- Comment #8 from Dan Leinir Turthra Jensen --- Git commit e1917b6a3bc876ef852ef22769fde07943ea3847 by Dan Leinir Turthra Jensen. Committed on 21/10/2020 at 14:24. Pushed by leinir into branch 'master'. Fix double-delete crash in kpackagejob Don't hang onto a pointer that's already been deleted, as QScopedPointer will just delete that for us. The semantics of KPackage::PackageStructures is that someone else /might/ own it, while the semantics of KPackage::Package is that we definitely own it, so we need to track the one we don't really know about. M +2-0src/core/jobs/kpackagejob.cpp https://invent.kde.org/frameworks/knewstuff/commit/e1917b6a3bc876ef852ef22769fde07943ea3847 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427910] System Settings crashes in KNSCore::KPackageJob::~KPackageJob() when installing new themes
https://bugs.kde.org/show_bug.cgi?id=427910 Dan Leinir Turthra Jensen changed: What|Removed |Added Version Fixed In||5.76 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427910] System Settings crashes in KNSCore::KPackageJob::~KPackageJob() when installing new themes
https://bugs.kde.org/show_bug.cgi?id=427910 --- Comment #12 from Dan Leinir Turthra Jensen --- It was pointed out to me that the logic i assumed QScopedPointer was using was not incorrect. On Saturday afternoon EU time, i pushed https://invent.kde.org/frameworks/knewstuff/commit/a95e5037b79b648f663f8db7ded6800ec6e49c75 which should hopefully sort it. If it doesn't, i guess we'll just have to leak that pointer and trust KPackage to clean up after itself. Thank you also to everybody who's been testing this out, since as it happens i have nothing to hand that provokes this crash... (if that sounds like frustration, it's because it kind of is - it's no fun watching something you spent this long on crashing left and right, but it is heartening to have people helping out with the testing of fixes, and seeing the neon dev testing branch working as intended for that purpose!) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 427910] System Settings crashes in KNSCore::KPackageJob::~KPackageJob() when installing new themes
https://bugs.kde.org/show_bug.cgi?id=427910 --- Comment #13 from Dan Leinir Turthra Jensen --- (In reply to Dan Leinir Turthra Jensen from comment #12) > It was pointed out to me that the logic i assumed QScopedPointer was using > was not incorrect. (also i can grammar, honest, double negative unintended, though i imagine that's clear from the context anyway ;) ) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kpackage] [Bug 428061] Discover crashed while updating in KPackage::Package::setPath()
https://bugs.kde.org/show_bug.cgi?id=428061 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC||ad...@leinir.dk Resolution|--- |WAITINGFORINFO --- Comment #4 from Dan Leinir Turthra Jensen --- For those who can reproduce this, please install the KPackage debug package and try and provoke the crash again. In openSuse this is the kpackage-debuginfo package, for Neon it'll be something like libkf5package-debug or libkf5pkacpage-dbg. The reason is, i'm going to need more information to be able to work out what in the world's happening here. Right now all i can see is that it fails somewhere in setPath, but not where, and it's very much not a trivial bit of code. Thanks in advance! -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 435084] Add button or automatic trigger to search field
https://bugs.kde.org/show_bug.cgi?id=435084 Dan Leinir Turthra Jensen changed: What|Removed |Added Ever confirmed|0 |1 CC||notm...@gmail.com Status|REPORTED|CONFIRMED --- Comment #3 from Dan Leinir Turthra Jensen --- (In reply to David Edmundson from comment #1) > It should be constantly updating the filter as you type That's a good point yes - it can't just fire it all the time (it's an expensive internetty sort of operation), but having a timer that does the searching in a slightly postponed sort of manner would definitely be good. Hmm, on which note... this seems like perhaps the sort of thing that Kirigami's search field might actually usefully do for us. KNewStuff's not the only place where this would be a useful sort of thing to do, and having it in that component, it would suddenly become available in a consistent manner to any consumer of that component. Marking as confirmed and tagging in Marco for a comment on whether he would support that (i'll offer to write the patch, just to make sure it won't be vetoed outright) :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 435084] Add button or automatic trigger to search field
https://bugs.kde.org/show_bug.cgi?id=435084 Dan Leinir Turthra Jensen changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kirigami/commit/b735 ||312ae714fad828e399ec73b8cdd ||4b0c03061 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #6 from Dan Leinir Turthra Jensen --- Git commit b735312ae714fad828e399ec73b8cdd4b0c03061 by Dan Leinir Turthra Jensen. Committed on 31/03/2021 at 09:17. Pushed by leinir into branch 'master'. Auto fire SearchField's accepted, with optional extra delay Without this, the SearchField requires the user to press either enter or return to signify that a search should happen. This change ensures that the search will happen if the user just inputs search terms into the field, the way search fields seem expected to function today. M +49 -0src/controls/SearchField.qml https://invent.kde.org/frameworks/kirigami/commit/b735312ae714fad828e399ec73b8cdd4b0c03061 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 435198] Discover crashes while calculating available updates after selecting updates notification in system tray
https://bugs.kde.org/show_bug.cgi?id=435198 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED CC||ad...@leinir.dk --- Comment #1 from Dan Leinir Turthra Jensen --- Thank you for reporting it - it's a duplicate, but the extra backtrace gave some more context to the investigation, which is always useful :) *** This bug has been marked as a duplicate of bug 433807 *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 433807] crashes after clicking on the button in the notification
https://bugs.kde.org/show_bug.cgi?id=433807 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||dequ...@mykolab.com --- Comment #3 from Dan Leinir Turthra Jensen --- *** Bug 435198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 434325] Discover intermittently crashes in KNSCore::Engine::addProvider() when opening the Settings view
https://bugs.kde.org/show_bug.cgi?id=434325 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Dan Leinir Turthra Jensen --- Thanks for the report! While you describe arriving at the issue differently to the one of which i'm marking this down as a duplicate, the backtrace is the same, which tells us it's the same base cause - thank you for checking first, even if you didn't find the other report, it's very much appreciated :) *** This bug has been marked as a duplicate of bug 433807 *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 433807] crashes after clicking on the button in the notification
https://bugs.kde.org/show_bug.cgi?id=433807 --- Comment #4 from Dan Leinir Turthra Jensen --- *** Bug 434325 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 420971] Provide nicer alternative to "No Application back-ends found..." welcome page
https://bugs.kde.org/show_bug.cgi?id=420971 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #7 from Dan Leinir Turthra Jensen --- On the topic of knewstuff-tool (which is the sort of... semi-planned name for it), there isn't yet, but, as that paranthesis suggests, building one is kind of planned :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #3 from Dan Leinir Turthra Jensen --- This is partly what the intention of the functionality that clears the cache for KPackage things was intended to help with. I guess we probably want to actually have a setting in knsrc to enable that for things which don't use KPackage as well (see core/engine.cpp:186) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 424456] Symbol package offers to install screen recording (mp4)
https://bugs.kde.org/show_bug.cgi?id=424456 --- Comment #1 from Dan Leinir Turthra Jensen --- You're correct it's not, but it's more a problem that KNewStuff doesn't really have much in the way of a concept of content types. We could arguably begin filtering out download entries from the list which aren't supported, but we would need a heuristic that makes sense for literally any type of content you can conceive of. The tag filtering may well work for this purpose, but in the meantime, please report this to the author of that entry (who I guess hasn't quite understood what the uploaded data gets used for). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #5 from Dan Leinir Turthra Jensen --- Sure, it wouldn't work for things where there is more knowledge required than a file disappearing, but it /would/ fix it for those situations where that's the problem. Since the former would require massive interventions throughout the stack, i feel like a smaller patch to fix a bunch of situations would be time well spent :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 385858] GHNS dialog has weird use function
https://bugs.kde.org/show_bug.cgi?id=385858 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.63 Status|REPORTED|RESOLVED CC||ad...@leinir.dk --- Comment #3 from Dan Leinir Turthra Jensen --- This is indeed a very old thing that has been fixed since, by using the QtQuick bits in place of the old widget based stuff. Since the widget stuff is effectively on life support, and how much work it'd take to rejig this in the widget dialog, i'm calling this one fixed (especially since the icons kcm specifically has been switched to the qtquick components). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 424724] Global themes settings download spinner show behind teaser image
https://bugs.kde.org/show_bug.cgi?id=424724 Dan Leinir Turthra Jensen changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 421924] Discover doesn't find updates for plasma addons unless I open their respective "Get new " windows in system settings before
https://bugs.kde.org/show_bug.cgi?id=421924 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/discover/commit/41b790f6 ||d1aa22a59bb5bcb643f94776e6e ||aa839 --- Comment #3 from Dan Leinir Turthra Jensen --- Git commit 41b790f6d1aa22a59bb5bcb643f94776e6eaa839 by Dan Leinir Turthra Jensen. Committed on 31/07/2020 at 12:26. Pushed by leinir into branch 'master'. Load the KNewStuff updates information on Discover startup Without this, Discover only loads the installed items, but does not also check whether there are updates available. This is cached by the KNSCore::Engine, so we don't need the throttling in Discover itself, but also if this is not done during the initialisation step, the updates information will simply not be available. Related: bug 417987 M +12 -0libdiscover/backends/KNSBackend/KNSBackend.cpp https://invent.kde.org/plasma/discover/commit/41b790f6d1aa22a59bb5bcb643f94776e6eaa839 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 417987] Discover should update addons installed via GHNS windows
https://bugs.kde.org/show_bug.cgi?id=417987 Dan Leinir Turthra Jensen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/discover/commit/41b790f6 ||d1aa22a59bb5bcb643f94776e6e ||aa839 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from Dan Leinir Turthra Jensen --- Git commit 41b790f6d1aa22a59bb5bcb643f94776e6eaa839 by Dan Leinir Turthra Jensen. Committed on 31/07/2020 at 12:26. Pushed by leinir into branch 'master'. Load the KNewStuff updates information on Discover startup Without this, Discover only loads the installed items, but does not also check whether there are updates available. This is cached by the KNSCore::Engine, so we don't need the throttling in Discover itself, but also if this is not done during the initialisation step, the updates information will simply not be available. Related: bug 421924 M +12 -0libdiscover/backends/KNSBackend/KNSBackend.cpp https://invent.kde.org/plasma/discover/commit/41b790f6d1aa22a59bb5bcb643f94776e6eaa839 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 418091] notifier does not notify about updates from KDE Store
https://bugs.kde.org/show_bug.cgi?id=418091 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Dan Leinir Turthra Jensen --- This was fixed through https://invent.kde.org/plasma/discover/-/merge_requests/17 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 424864] GHNS windows: detailed view of a non installed addon shows both "Install" and "Uninstall" buttons
https://bugs.kde.org/show_bug.cgi?id=424864 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #1 from Dan Leinir Turthra Jensen --- While i can see the bug in your screenshot, and it has been confirmed by others... i can't seem to provoke this at all. I have a suspicion that this was fixed (very recently) by a refactor of the action toolbar component in Kirigami, which is what's used to display those actions. Once that becomes available to you, could you try and check, and reconfirm if it still happens? If it does, something is extremely broken somewhere, and given the logic for these actions being visible, i am hesitant to accept that it is in KNewStuff... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 424864] GHNS windows: detailed view of a non installed addon shows both "Install" and "Uninstall" buttons
https://bugs.kde.org/show_bug.cgi?id=424864 --- Comment #3 from Dan Leinir Turthra Jensen --- Sweet, thank you! :D -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #6 from Dan Leinir Turthra Jensen --- Just opened two relevant merge requests (as mentioned in comments above): https://invent.kde.org/frameworks/knewstuff/-/merge_requests/23 which exposes an option to turn on the cleanup for any knsrc which wants that functionality https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/190 which uses said option to clean up icons (as described in #c0) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #7 from Dan Leinir Turthra Jensen --- Git commit c83c377ff82aab27172699cdc7da5d4e28d54d27 by Dan Leinir Turthra Jensen. Committed on 06/08/2020 at 08:02. Pushed by leinir into branch 'master'. Add a RemoveDeadEntries option for knsrc files If you set RemoveDeadEntries=true, entries whose installed files have all been deleted without going through KNewStuff will be removed from the cache. The removal will happen if, and only if, all listed files were removed, which means that if, for example, an entry was installed from archive, which was decompressed to yield multiple installed files, if even one of those files remains, the entry will remain marked as installed. This is to help work around people deleting files from underneath KNewStuff, which turns out to happen a lot with e.g. wallpapers and icons. Only CCBUGing this one, as it is an imcomplete fix for the issue, and requires intervention in the icons.knsrc file for the fix to be applied to the issue mentioned in that bug. M +8-0src/core/engine.cpp M +9-0src/downloaddialog.h https://invent.kde.org/frameworks/knewstuff/commit/c83c377ff82aab27172699cdc7da5d4e28d54d27 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 417985] Addons from KDE Store removed via KCMs are still listed as installed in respective GHNS window
https://bugs.kde.org/show_bug.cgi?id=417985 --- Comment #8 from Dan Leinir Turthra Jensen --- Git commit 84401e094669bf9322659f4423a8d8972c9de52b by Dan Leinir Turthra Jensen. Committed on 06/08/2020 at 08:04. Pushed by leinir into branch 'master'. Request that KNS cleans up its cache if there are dead entries This requires (though not hard) the code found in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/23 and the idea behind this is to clean up KNewStuff's knowledge of entries which have been deleted without telling KNewStuff about it first. This is a further step towards fixing the bug below. M +1-0kcms/icons/icons.knsrc https://invent.kde.org/plasma/plasma-workspace/commit/84401e094669bf9322659f4423a8d8972c9de52b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 390875] Plasma Widgets from KDE Store can not be uninstalled via Widget Explorer
https://bugs.kde.org/show_bug.cgi?id=390875 --- Comment #8 from Dan Leinir Turthra Jensen --- (In reply to Alexander Lohnau from comment #7) > Without having any specific plan on how to implement this let me propose an > alternative concept: > When deleting an entry we move the file on disk to a temporary location and > write in a variable that we can restore this entry. This variable in only in > memory, meaning that when we restart the session we can't restore the entry. > And whenever we start a new session we clean the temporary location. It strikes me that we even have such a location already - the xdg trash seems like precisely that sort of location :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 425245] System settings crash in KJob::errorText()
https://bugs.kde.org/show_bug.cgi?id=425245 --- Comment #3 from Dan Leinir Turthra Jensen --- Hmm... i think that code is a little dangerous anyway, i'll whip up a quick patch, it's sort of roundabout anyway the way it's working now :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 418034] "Details..." button should remain hidden until addon installation is completed
https://bugs.kde.org/show_bug.cgi?id=418034 --- Comment #10 from Dan Leinir Turthra Jensen --- i can't help worry about the discoverability of it, but sure, i'm basically fine with getting rid of the [Details...] buttons if people have particularly strong feelings about it. -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422190] Unreadable row under account details when Breeze Dark global theme is used
https://bugs.kde.org/show_bug.cgi?id=422190 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/netw ||ork/kaccounts-integration/c ||ommit/6affdf9d5c406ac9cb17a ||fb91c0278c9893c4e80 --- Comment #4 from Dan Leinir Turthra Jensen --- Git commit 6affdf9d5c406ac9cb17afb91c0278c9893c4e80 by Dan Leinir Turthra Jensen. Committed on 14/08/2020 at 09:10. Pushed by leinir into branch 'master'. Fix account details page (especially on dark themes) Not setting the colour of a rectangle yields a white one, never mind what colorSet you set on it. Explicitly set the background colour to the theme's background colour, so we don't end up with that nasty white rectangle with some near-white text on top on dark themes. M +1-0src/kcm/package/contents/ui/AccountDetails.qml https://invent.kde.org/network/kaccounts-integration/commit/6affdf9d5c406ac9cb17afb91c0278c9893c4e80 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 427974] Crashed in Attica::ProviderManager::fileFinished() when trying to update
https://bugs.kde.org/show_bug.cgi?id=427974 --- Comment #4 from Dan Leinir Turthra Jensen --- *** Bug 428930 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 428930] Discover notifier crach
https://bugs.kde.org/show_bug.cgi?id=428930 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|RESOLVED CC||ad...@leinir.dk Resolution|--- |DUPLICATE --- Comment #1 from Dan Leinir Turthra Jensen --- *** This bug has been marked as a duplicate of bug 427974 *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 427974] Crashed in Attica::ProviderManager::fileFinished() when trying to update
https://bugs.kde.org/show_bug.cgi?id=427974 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/attica/commit/6671bc ||539d42d8e3736190a5fa30203e3 ||e850f2a --- Comment #5 from Dan Leinir Turthra Jensen --- Git commit 6671bc539d42d8e3736190a5fa30203e3e850f2a by Dan Leinir Turthra Jensen. Committed on 10/11/2020 at 17:01. Pushed by leinir into branch 'master'. Fix crash in provider loading by checking reply pointer before deref This code has been working for ages, but somehow has started crashing pretty hard. Consequently, time for a fix! Thanks to Mohammed for spotting this. M +9-5src/providermanager.cpp https://invent.kde.org/frameworks/attica/commit/6671bc539d42d8e3736190a5fa30203e3e850f2a -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 430961] Widgets, Themes, and anything downloaded from it are not recognized by it
https://bugs.kde.org/show_bug.cgi?id=430961 --- Comment #5 from Dan Leinir Turthra Jensen --- When you say that you've downloaded a bunch, when did you do this? I ask this, because i'm afraid the old method was broken in such a way as to make it impossible to verify things as having been installed, which means that if you installed these items prior to earlier this year, they will not be shown as installed in KNewStuff. It is a distinctly suboptimal situation, but i'm afraid there really was no sensible way to get around that problem... If you installed them recently, however, then that of course isn't the issue here (which is why i'm asking). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 431568] GridView scrolls up when I open/close a "Get hot new " window
https://bugs.kde.org/show_bug.cgi?id=431568 --- Comment #1 from Dan Leinir Turthra Jensen --- This is an artefact of how the KCM is implemented (they reload everything rather than change the model in-place). Basically this is a bug in each of the KCMs, not in KNewStuff... which also means i'm not entirely sure where to point this, because this is all in widely different products... -- You are receiving this mail because: You are watching all bug changes.
[peruse] [Bug 431067] Crash using latest master in generating book previews.
https://bugs.kde.org/show_bug.cgi?id=431067 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED Status|NEEDSINFO |RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- As far as i can tell, this should be fixed as of https://invent.kde.org/graphics/peruse/commit/d21dc367a9dd29fda1bbe5857b7896b7bf523d5b, but testing would be appreciated :) I'm going to close it for now, at least, i can't provoke this crash any longer (getting another one very occasionally, but that's in the pdf generator, which... not sure what's going on there) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 431568] GridView scrolls up when I open/close a "Get hot new " window
https://bugs.kde.org/show_bug.cgi?id=431568 --- Comment #3 from Dan Leinir Turthra Jensen --- (In reply to Nate Graham from comment #2) > Well that's weird. Can confirm. Not really weird - i explained above why it happens (and also why it, somewhat annoyingly, is both not a knewstuff bug, and also not at all easy to reassign, because it'd have to be assigned to a whole pile of products which all have the problem, because they all just reload their data when the kns dialog is closed rather than changing the model in-place) -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 430812] Installation of "stuff" which has sub-packages, where one need to be select, made that update of system is stopped
https://bugs.kde.org/show_bug.cgi?id=430812 Dan Leinir Turthra Jensen changed: What|Removed |Added Ever confirmed|0 |1 CC||ad...@leinir.dk Status|REPORTED|CONFIRMED --- Comment #4 from Dan Leinir Turthra Jensen --- Right, thanks for spotting this. This is due to Discover not currently allowing users to make that decision you noticed the KNewStuff dialog asking about. I'll mark this as confirmed, and then poke at trying to sort it out :) The view refreshing magically (like you noticed) is because we try and make sure the views in different applications onto the same KNewStuff entries are kept in sync, which... frankly has been a little undertested perhaps, so thanks for confirming that that bit works ;) -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 430812] Installation of "stuff" which has sub-packages, where one need to be select, made that update of system is stopped
https://bugs.kde.org/show_bug.cgi?id=430812 --- Comment #5 from Dan Leinir Turthra Jensen --- This MR is a partial fix - https://invent.kde.org/frameworks/knewstuff/-/merge_requests/90 It doesn't quite fix the underlying problem of not letting you pick which thing to actually do the update with and ends up with you having un-updateable entries in Discover, but it does result in Discover not having that never-ending update sat in tasks. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 431568] GridView scrolls up when I open/close a "Get hot new " window
https://bugs.kde.org/show_bug.cgi?id=431568 --- Comment #5 from Dan Leinir Turthra Jensen --- i'm afraid so... Basically, KNS sends out entry changed notifications for each changed entry, but the way most of these places handles that is to just reload their entire model, rather than identify what changed and only change that item in their model... Because, i guess, it's just easier and nobody posted a bug like this before ;) -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 430812] Installation of "stuff" which has sub-packages, where one need to be select, made that update of system is stopped
https://bugs.kde.org/show_bug.cgi?id=430812 --- Comment #6 from Dan Leinir Turthra Jensen --- Git commit 5e288f617f94fa29097ba12d2b020279e98d8bc8 by Dan Leinir Turthra Jensen. Committed on 17/01/2021 at 14:17. Pushed by leinir into branch 'master'. Reset entry to updateable when no payload is identified for updating As identified by Piotr in the bug mentioned below, Discover simply returns an invalid response for any Question forwarded to it. The result is that any update which fails to identify an update automatically will fail due to not having payload which should be used for updating identified. This patch fixes part of the issue, by resetting the entry for which no payload could be identified to Updateable rather than leaving it in limbo as Updating. This does not fix the bug in Discover, but it does at least alleviate the issue (it still leaves entries in Discover, rather than updating them, but without having a way to forward that question to the user, there's not a lot to be done about that other than output an error message with instructions to use the GHNS dialog to do that particular update, which of course is not exactly up to par... so, not closing the bug with this, the issue in Discover still needs sorting out... somehow). M +4-0src/core/engine.cpp M +1-1src/core/errorcode.h https://invent.kde.org/frameworks/knewstuff/commit/5e288f617f94fa29097ba12d2b020279e98d8bc8 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 430812] Installation of "stuff" which has sub-packages, where one need to be select, made that update of system is stopped
https://bugs.kde.org/show_bug.cgi?id=430812 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/discover/commit/44e73b4e ||eab2bf0222ad93349d03b72f181 ||7a61a Resolution|--- |FIXED --- Comment #8 from Dan Leinir Turthra Jensen --- Git commit 44e73b4eeab2bf0222ad93349d03b72f1817a61a by Dan Leinir Turthra Jensen. Committed on 19/01/2021 at 13:21. Pushed by leinir into branch 'master'. Forward installer update error (so user is informed of their options) As discovered by Piotr, attempting to update some KNewStuff originated packages in Discover results in the update not in fact being updated, without anything happening in Discover apart from the update just staying around in the UI. This patch forwards an error from KNSCore::Engine which gives some further information as to what the user can do to perform this update. This is a half-solution to the problem, as the TODO added in here suggests, but it seems to me better to be explicit about the problem to our users, rather than just not doing anything, and informing them how they can fix it themselves. Until we have a full query system for Discover's transactions, this seems likely to be the best we can do (and actually implementing that system will take some time to get right, and we don't want to just ignore the problem until them). M +18 -1libdiscover/backends/KNSBackend/KNSBackend.cpp https://invent.kde.org/plasma/discover/commit/44e73b4eeab2bf0222ad93349d03b72f1817a61a -- You are receiving this mail because: You are watching all bug changes.
[peruse] [Bug 426598] Several QML errors with latest master.
https://bugs.kde.org/show_bug.cgi?id=426598 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Dan Leinir Turthra Jensen --- Right, that's most of the warnings gone (at least the ones we can control from Peruse), so... i'm closing this one. Of course, warnings should be decreased whenever possible, so our debug output is actually useful, but this is about as far as i can get it for now. -- You are receiving this mail because: You are watching all bug changes.
[peruse] [Bug 431934] Assert while searching.
https://bugs.kde.org/show_bug.cgi?id=431934 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/peruse/commit/54720d51 ||8d25cf38f8fd861b367be9fec1b ||ebaf6 Status|REPORTED|RESOLVED --- Comment #1 from Dan Leinir Turthra Jensen --- Git commit 54720d518d25cf38f8fd861b367be9fec1bebaf6 by Dan Leinir Turthra Jensen. Committed on 22/01/2021 at 15:31. Pushed by leinir into branch 'master'. Fix an out of bounds fetch from a list M +2-5src/qtquick/CategoryEntriesModel.cpp https://invent.kde.org/graphics/peruse/commit/54720d518d25cf38f8fd861b367be9fec1bebaf6 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 430812] Installation of "stuff" which has sub-packages, where one need to be select, made that update of system is stopped
https://bugs.kde.org/show_bug.cgi?id=430812 --- Comment #9 from Dan Leinir Turthra Jensen --- Git commit 365191346f0fd2d235fb33828056a48e7f3161ae by Dan Leinir Turthra Jensen. Committed on 26/01/2021 at 09:20. Pushed by leinir into branch 'master'. Add support for kns:/ urls to the knewstuff-dialog tool This adds in support for the kns URLs used in e.g. kpackagetool to canonically reference a specific entry found on a knewstuff provider. The result is that by passing in such a URL to the knewstuff-dialog tool, we interpret this as wanting to show the details for that specific entry. The origin of this functionality was a short discussion on https://invent.kde.org/plasma/discover/-/merge_requests/63 where the need for such functionality became obvious. M +24 -0src/core/engine.cpp M +22 -2src/core/engine.h M +12 -0src/qtquick/qml/Button.qml M +12 -0src/qtquick/qml/Dialog.qml M +12 -0src/qtquick/qml/DialogContent.qml M +67 -0src/qtquick/qml/Page.qml M +20 -0src/qtquick/quickitemsmodel.cpp M +10 -0src/qtquick/quickitemsmodel.h M +19 -1src/tools/knewstuff-dialog/main.cpp M +4-1src/tools/knewstuff-dialog/qml/dialog.qml https://invent.kde.org/frameworks/knewstuff/commit/365191346f0fd2d235fb33828056a48e7f3161ae -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 432162] New: Message list column headers resize on their own
https://bugs.kde.org/show_bug.cgi?id=432162 Bug ID: 432162 Summary: Message list column headers resize on their own Product: kmail2 Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: message list Assignee: kdepim-b...@kde.org Reporter: ad...@leinir.dk Target Milestone: --- After setting the header sizes for the columns in the message list view, and using the app for a while, over time they will resize in a way that ends up with the second-rightmost column having a not particularly useful size. Please see the attached screenshot for how things look after a while (the very narrow column ends up entirely squeezed to no width eventually, but i thought this shows the effect just as well). -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 432162] Message list column headers resize on their own
https://bugs.kde.org/show_bug.cgi?id=432162 --- Comment #1 from Dan Leinir Turthra Jensen --- Created attachment 135210 --> https://bugs.kde.org/attachment.cgi?id=135210&action=edit KMail message list column headers after a while -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 431568] GridView scrolls up when I open/close a "Get hot new " window
https://bugs.kde.org/show_bug.cgi?id=431568 --- Comment #7 from Dan Leinir Turthra Jensen --- (In reply to Nate Graham from comment #6) > Could you follow up on that and submit MRs to fix them? Hmm... This feels like something which might just be a good JJ type opportunity... There's a bunch of places it needs doing, but they're all self-contained, so... maybe a chance to grab some people who aren't super involved? :) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 449272] Use in-page style for GHNS dialogs, rather than separate windows
https://bugs.kde.org/show_bug.cgi?id=449272 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk --- Comment #4 from Dan Leinir Turthra Jensen --- Just to weigh in on my own here, this is actually the intention for the medium/long term - basically, when i originally built all this, both the KNSQuick Button and Dialog controls were always intended effectively as porting aides, since that method of interaction (as this report also suggests) basically just doesn't fit into what our UI is evolving into. So, from my point of view: Yes please, definitely do that :) (as Nate says, of course, this wouldn't work everywhere, but in the places where it /would/ work, definitely what we want to try to go for) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 425245] System settings crash in KJob::errorText()
https://bugs.kde.org/show_bug.cgi?id=425245 --- Comment #5 from Dan Leinir Turthra Jensen --- If people are able to test out the patch in the comment above, i'd appreciate it :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 425245] System settings crash in KJob::errorText()
https://bugs.kde.org/show_bug.cgi?id=425245 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/c75 ||457e0054cabd1a0b9ed10faeca6 ||d7649bcb8c Status|ASSIGNED|RESOLVED --- Comment #6 from Dan Leinir Turthra Jensen --- Git commit c75457e0054cabd1a0b9ed10faeca6d7649bcb8c by Dan Leinir Turthra Jensen. Committed on 17/08/2020 at 08:50. Pushed by leinir into branch 'master'. Fix a sometimes-crash with the KPackageJob task This ensures that we're not trying to reference a job that is no longer around (and also owned by a separate thread and handled by a separate event loop, meaning it may very well have been deleted by the time it reaches that old codepath). M +4-7src/core/jobs/kpackagejob.cpp https://invent.kde.org/frameworks/knewstuff/commit/c75457e0054cabd1a0b9ed10faeca6d7649bcb8c -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 425811] Crash when clicking update button the moment it becomes enabled
https://bugs.kde.org/show_bug.cgi?id=425811 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/edd ||790b9d7c18a468ab2fbe76cb116 ||94b1c336dd Status|ASSIGNED|RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- Git commit edd790b9d7c18a468ab2fbe76cb11694b1c336dd by Dan Leinir Turthra Jensen. Committed on 28/08/2020 at 18:07. Pushed by leinir into branch 'master'. Make the internal kpackage job task less fragile This is done to ensure we don't end up emitting things on an already-deleted object, which breaks. We cannot simply swap the existing code out for a connection that's queued, as we may end up not emitting the result, which would be a problem in itself. Also clean up the error reporting a touch while we're at it. M +41 -19 src/core/jobs/kpackagejob.cpp https://invent.kde.org/frameworks/knewstuff/commit/edd790b9d7c18a468ab2fbe76cb11694b1c336dd -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 437144] SDDM theme from reinstalled global theme is not available for selection in SDDM KCM despite it is marked as installed
https://bugs.kde.org/show_bug.cgi?id=437144 --- Comment #4 from Dan Leinir Turthra Jensen --- For clarification, is step 4 done from the KCM or from the GHNS window? (i am guessing from the KCM, but just want to be sure so we can work out where to start looking) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 436139] Unnecessary network error when searching for Plasma themes
https://bugs.kde.org/show_bug.cgi?id=436139 --- Comment #5 from Dan Leinir Turthra Jensen --- The problem we've got here is that it is not entirely obvious whether something was in fact cancelled for some sensible reason (such as aborting an ongoing search to replace it with another), or whether it was cancelled somewhere in the stack by something the user did not ask for. However, specifically this one, it ought to be something we can deal with. And yeah, this obviously just looks weird. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 437144] SDDM theme from reinstalled global theme is not available for selection in SDDM KCM despite it is marked as installed
https://bugs.kde.org/show_bug.cgi?id=437144 --- Comment #6 from Dan Leinir Turthra Jensen --- Thank you - i've got a suspicion i might know what's going on, and that matches that suspicion, thanks :) In short, i suspect that knewstuff still thinks it's installed, since it's removed from the kcm, and that the list of installed entries in the cache doesn't get stale entries removed when using the kpackagetool's kns integration thing - couple of places it could be going wrong, but if we're super lucky, it /should/ be as simple as adding RemoveDeadEntries=true to the sddmtheme.knsrc file, which you can check at your end as well just by editing that file (usually /usr/share/knsrcfiles/sddmtheme.knsrc) :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 437144] SDDM theme from reinstalled global theme is not available for selection in SDDM KCM despite it is marked as installed
https://bugs.kde.org/show_bug.cgi?id=437144 --- Comment #8 from Dan Leinir Turthra Jensen --- (In reply to Patrick Silva from comment #7) > RemoveDeadEntries=true is already present in sddmtheme.knsrc file. Well damn, there goes that theory... Alright, i'll have to look closer, then. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[plasma-systemmonitor] [Bug 437961] GHNS window opens in a new column rather than a new window
https://bugs.kde.org/show_bug.cgi?id=437961 Dan Leinir Turthra Jensen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-systemmonitor/com ||mit/768f8ad5aab7698f550d601 ||c36a4b922637231e4 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Dan Leinir Turthra Jensen --- Git commit 768f8ad5aab7698f550d601c36a4b922637231e4 by Dan Leinir Turthra Jensen. Committed on 08/06/2021 at 10:07. Pushed by leinir into branch 'master'. Push NewStuff pages to layers, not the stack The NewStuff.Action component will simply call the push function on whatever object it is given to work with as a page stack, and since the Kirigami pagestack layers also has one such, we can just switch to that. nb: The functionality is explicitly designed to work this way, to allow for things like the kcm pagestack to work as well as the more featureful Kirigami one. M +1-1src/main.qml M +2-2src/page/FaceConfigurationPage.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/768f8ad5aab7698f550d601c36a4b922637231e4 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 427974] Crashed in Attica::ProviderManager::fileFinished() when trying to update
https://bugs.kde.org/show_bug.cgi?id=427974 --- Comment #6 from Dan Leinir Turthra Jensen --- *** Bug 429856 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 429856] Discover always crashes in Attica::ProviderManager::fileFinished()
https://bugs.kde.org/show_bug.cgi?id=429856 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED --- Comment #2 from Dan Leinir Turthra Jensen --- Thanks for the report, but i'm afraid it's the same one you already reported elsewhere, and while the fix was released with 5.77, you're still running Frameworks 5.76 :) *** This bug has been marked as a duplicate of bug 427974 *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 429939] System Settings crashed while attempting to download a theme
https://bugs.kde.org/show_bug.cgi?id=429939 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Dan Leinir Turthra Jensen --- At any rate, i can confirm this happens. Now i just need to work out what in the world is actually the cause, because this is a mightily confusing backtrace... Thanks for spotting it :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 429939] System Settings crashed while attempting to download a theme
https://bugs.kde.org/show_bug.cgi?id=429939 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|REOPENED --- Comment #3 from Dan Leinir Turthra Jensen --- This is unfortunately not the same bug as 427974, but luckily i've got a patch submitted to fix it :) https://invent.kde.org/frameworks/attica/-/merge_requests/6 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 429442] Calling app crashes in KNSCore::Engine::signalEntryChanged() when trying to download KNS content
https://bugs.kde.org/show_bug.cgi?id=429442 --- Comment #14 from Dan Leinir Turthra Jensen --- Getting the attached patch tested by those of you who are both able to reproduce the problem and able to build the patch would be... very good, thanks :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 429442] Calling app crashes in KNSCore::Engine::signalEntryChanged() when trying to download KNS content
https://bugs.kde.org/show_bug.cgi?id=429442 --- Comment #16 from Dan Leinir Turthra Jensen --- (In reply to Patrick Silva from comment #15) > Hi Dan > I have applied your patch to neon unstable and since then > my bug 428065 marked as duplicate is no longer reproducible. :) Awesome, thank you so much for testing that out! :) If i get one more of those i'll call it confirmed fixed :) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 429442] Calling app crashes in KNSCore::Engine::signalEntryChanged() when trying to download KNS content
https://bugs.kde.org/show_bug.cgi?id=429442 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/243 ||ea6155b28457c8b1441fee8ab10 ||37828d21ba Resolution|--- |FIXED Version Fixed In||5.78 --- Comment #17 from Dan Leinir Turthra Jensen --- Git commit 243ea6155b28457c8b1441fee8ab1037828d21ba by Dan Leinir Turthra Jensen. Committed on 14/12/2020 at 21:11. Pushed by leinir into branch 'master'. Add a dptr to Cache, and move the throttle timer there to fix crash Previously, the throttle timer was a raw static, but it was also a parented qobject, which means that when the cache was deleted, so was the timer, but the variable was not reset. Consequently, things would crash left and right later on. So, to alleviate this, and hopefully avoid future issues, introduce a dptr, stick the timer there, and move the logic to that private class as well. FIXED-IN:5.78 M +30 -11 src/core/cache.cpp M +5-2src/core/cache.h https://invent.kde.org/frameworks/knewstuff/commit/243ea6155b28457c8b1441fee8ab1037828d21ba -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 429939] System Settings crashed while attempting to download a theme
https://bugs.kde.org/show_bug.cgi?id=429939 Dan Leinir Turthra Jensen changed: What|Removed |Added Component|general |general Assignee|ad...@leinir.dk |gladh...@kde.org Version|unspecified |5.77.0 Product|frameworks-knewstuff|frameworks-attica --- Comment #4 from Dan Leinir Turthra Jensen --- Reassigning to the correct product (also please test the patch ;) ) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 429939] System Settings crashed while attempting to download a theme
https://bugs.kde.org/show_bug.cgi?id=429939 Dan Leinir Turthra Jensen changed: What|Removed |Added Assignee|gladh...@kde.org|ad...@leinir.dk CC||ad...@leinir.dk --- Comment #5 from Dan Leinir Turthra Jensen --- (also this reassigned the assignee, sorry about the noise) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 434371] Uninstall widget shows wrong label progression and takes forever to finish
https://bugs.kde.org/show_bug.cgi?id=434371 --- Comment #4 from Dan Leinir Turthra Jensen --- This basically is two bugs, but still, thank you for the report :) The label being weird - there's no distinction between the various installer actions, so what it should say is "Working..." not "Installing..." (at least until we implement a system that spits out progress type messages about what the installer is doing) The eternal spinner when you uninstall a widget is entirely unrelated to that label being wrong, though. What happens is that during uninstallation, knewstuff will attempt to delete a file, and this then causes the uninstallation to fail silently (and the end result is what you are seeing there). i'll treat this report as primarily about that issue, as it's the more critical one. The fact that the spinner remains when you close and reopen the dialog is because once you've already opened the dialog, the data remains when you reopen it (which you can see by how it doesn't reinitialise the dialog's contents when you reopen it, it just shows what it's downloaded already). Basically, that bit's a feature, not a bug, it just happens to show that other bug ;) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 434371] Uninstall widget shows wrong label progression and takes forever to finish
https://bugs.kde.org/show_bug.cgi?id=434371 Dan Leinir Turthra Jensen changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/257 ||97117583ea288152ddf042938cd ||5e1b6bfa19 --- Comment #6 from Dan Leinir Turthra Jensen --- Git commit 25797117583ea288152ddf042938cd5e1b6bfa19 by Dan Leinir Turthra Jensen. Committed on 17/03/2021 at 15:37. Pushed by leinir into branch 'master'. Less risk of infinite spinner on uninstalling KPackage based things Prior to this patch, the uninstallation function would attempt to work out if the installed item was a directory by checking for a backslash at the end of the installed files. Since we have QFileInfo, which we're already using further down in this function anyway, we might as well use the ability of that to tell us whether or not the item is a directory. The end result is that we no longer have an infinite spinner after (successfully, as it happens) uninstalling KPackage based entries, such as Plasmoids. The symptom was most easily visible in the Plasmoid installer, which retains its engine across the entirety of a Plasma session (since the dialogue lived inside the Plasma process, and consequently never was destructed, meaning the weird state was retained). This patch further rewords the text shown when uninstalling entries, which since it is also the text shown when installing them must be more generic. They now say some variant of "Working", to show that the entry is being worked on, which is sufficiently generic to not involve awkward formulations such as long winded "Installing or Uninstalling", or even worse "(Un)installing". At a later point in time, introducing a more full feedback system for the installation progress would be advantageous, but for a rapid fix to the immediate issue, this works. M +24 -0autotests/core/installationtest.cpp M +14 -7src/core/installation.cpp M +1-1src/qtquick/qml/EntryDetails.qml M +2-1src/qtquick/qml/NewStuffItem.qml M +1-1src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml https://invent.kde.org/frameworks/knewstuff/commit/25797117583ea288152ddf042938cd5e1b6bfa19 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-attica] [Bug 429939] System Settings crashed while attempting to download a theme
https://bugs.kde.org/show_bug.cgi?id=429939 Dan Leinir Turthra Jensen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/attica/commit/6156b2 ||a968664c4e08efbc72e5acea9f1 ||e2ffa22 Status|REOPENED|RESOLVED Version Fixed In||5.78 --- Comment #6 from Dan Leinir Turthra Jensen --- Git commit 6156b2a968664c4e08efbc72e5acea9f1e2ffa22 by Dan Leinir Turthra Jensen. Committed on 18/12/2020 at 09:10. Pushed by leinir into branch 'master'. Honour the job being aborted immediately Occasionally, a job will be started and then immediately cancelled. This can cause the job to end up still attempting to run while it is in the process of being destructed, which in turn leads to accessing bits of data which are no longer available, and in the end a crash. This fixes that problem by ensuring we actually honour abort calls internally as well. Also adds a little test for listing content, and for switching the sort order. FIXED-IN:5.78 M +60 -2autotests/providertest.cpp M +5-0src/atticabasejob.cpp https://invent.kde.org/frameworks/attica/commit/6156b2a968664c4e08efbc72e5acea9f1e2ffa22 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kirigami] [Bug 433472] New: InlineMessage does not support icon.name
https://bugs.kde.org/show_bug.cgi?id=433472 Bug ID: 433472 Summary: InlineMessage does not support icon.name Product: frameworks-kirigami Version: Master Platform: Other OS: All Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: notm...@gmail.com Reporter: ad...@leinir.dk Target Milestone: Not decided Attempting to use Kirigami.InlineMessage and assigning an icon by name fails (and requires that it is done by icon.source instead), which is inconsistent with how the rest of our APIs tend to do things, and leads to odd looking code, where the InlineMessage itself needs icon.source to be set, while the actions use icon.name. A cursory glance suggests this is due to the custom IconPropertiesGroup, which only has source, but a fix to introduce a more expected API might be as simple as an alias between source and name, but also it seems unintended and thought a bug might be useful. For example: file:///usr/lib64/qt5/qml/org/kde/kirigami.2/PageRow.qml:575: Error: Error while loading page: qrc:/qml/BrowsingPage.qml:89 Cannot assign to non-existent property "name" -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 433535] Icon of updateable addon is cut off
https://bugs.kde.org/show_bug.cgi?id=433535 Dan Leinir Turthra Jensen changed: What|Removed |Added Version Fixed In||5.80 Latest Commit||https://invent.kde.org/fram ||eworks/knewstuff/commit/5d1 ||c300640ba62cff1d2be748625f2 ||dcce1156ce Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from Dan Leinir Turthra Jensen --- Git commit 5d1c300640ba62cff1d2be748625f2dcce1156ce by Dan Leinir Turthra Jensen. Committed on 26/02/2021 at 11:16. Pushed by ngraham into branch 'master'. Fix preview delegate's update badge being cut off As the subject suggests, this fixes the icon being cut off due to overflow being clipped. This was caused by an inconsistency in the layout (the installed badge does not have the margin) FIXED-IN:5.80 M +0-1 src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml https://invent.kde.org/frameworks/knewstuff/commit/5d1c300640ba62cff1d2be748625f2dcce1156ce -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knewstuff] [Bug 408716] Subsequent "Get New" things in System Settings display items from the first search.
https://bugs.kde.org/show_bug.cgi?id=408716 Dan Leinir Turthra Jensen changed: What|Removed |Added Latest Commit||https://commits.kde.org/kne ||wstuff/8977627cab850815e0d1 ||dbfd0eab50dd9d4a3ddc Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Dan Leinir Turthra Jensen --- Git commit 8977627cab850815e0d1dbfd0eab50dd9d4a3ddc by Dan Leinir Turthra Jensen. Committed on 21/10/2019 at 08:08. Pushed by leinir into branch 'master'. Fix KNSCore::Cache fetching when initialising Engine Summary: During the moving-around of the config files, the Cache was left behind unfixed, and we ended up with all caches being the same, because we attempted to request a cache for a config file which was not found, and consequently resulted in the requested cache being named "", which consequently failed rather badly. Reviewers: rikmills, #frameworks, #knewstuff Reviewed By: rikmills Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24754 M +4-1src/core/engine.cpp https://commits.kde.org/knewstuff/8977627cab850815e0d1dbfd0eab50dd9d4a3ddc -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 413370] openSUSE Tumbleweed: Installing one app while there are available updates also installs the updates without telling you!
https://bugs.kde.org/show_bug.cgi?id=413370
Dan Leinir Turthra Jensen changed:
What|Removed |Added
CC||ad...@leinir.dk
--- Comment #3 from Dan Leinir Turthra Jensen ---
The behaviour is indeed the same with pkcon, and is more general than just
during installation of new software. Here is what happened when i (in a desire
to test out installing something and not having anything to install thought i'd
get rid of something first) did pkcon remove matrix-quaternion:
leinir@copernicus:~> pkcon remove matrix-quaternion
Resolving [=]
Querying [=]
Testing changes [=]
Finished [ ] (0%)
The following packages have to be obsoleted:
kernel-firmware-20190909-1.1.noarchLinux kernel firmware files
libldb1-1.5.5-1.2.x86_64 An LDAP-like embedded database
The following packages have to be removed:
matrix-quaternion-0.0.9.4-7.10.x86_64 QT Matrix client
matrix-quaternion-lang-0.0.9.4-7.10.noarch Translations for package
matrix-quaternion
The following packages have to be updated:
MozillaFirefox-69.0.2-1.1.x86_64 Mozilla Firefox Web Browser
NetworkManager-1.18.2-1.1.x86_64 Network Link Manager and user
applications for it
NetworkManager-branding-openSUSE-42.1-4.15.noarch Default
${branding_name} branding for /etc/NetworkManager/NetworkManager.conf
(...ad nauseum)
So, yup, definitely a thing somewhere not in Discover
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-knewstuff] [Bug 413436] QtQuick dialog: "i" icon in corner looks unnecessary
https://bugs.kde.org/show_bug.cgi?id=413436 Dan Leinir Turthra Jensen changed: What|Removed |Added CC||ad...@leinir.dk, ||andrew.be...@jasp.com --- Comment #1 from Dan Leinir Turthra Jensen --- Tagging in Andy here, who is the one that came up with this particular design :) -- You are receiving this mail because: You are watching all bug changes.
