https://bugs.kde.org/show_bug.cgi?id=434371
Dan Leinir Turthra Jensen <ad...@leinir.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/knewstuff/commit/257
| |97117583ea288152ddf042938cd
| |5e1b6bfa19
--- Comment #6 from Dan Leinir Turthra Jensen <ad...@leinir.dk> ---
Git commit 25797117583ea288152ddf042938cd5e1b6bfa19 by Dan Leinir Turthra
Jensen.
Committed on 17/03/2021 at 15:37.
Pushed by leinir into branch 'master'.
Less risk of infinite spinner on uninstalling KPackage based things
Prior to this patch, the uninstallation function would attempt to work out if
the installed item was a directory by checking for a backslash at the end of
the installed files. Since we have QFileInfo, which we're already using further
down in this function anyway, we might as well use the ability of that to tell
us whether or not the item is a directory.
The end result is that we no longer have an infinite spinner after
(successfully, as it happens) uninstalling KPackage based entries, such as
Plasmoids. The symptom was most easily visible in the Plasmoid installer, which
retains its engine across the entirety of a Plasma session (since the dialogue
lived inside the Plasma process, and consequently never was destructed, meaning
the weird state was retained).
This patch further rewords the text shown when uninstalling entries, which
since it is also the text shown when installing them must be more generic. They
now say some variant of "Working", to show that the entry is being worked on,
which is sufficiently generic to not involve awkward formulations such as long
winded "Installing or Uninstalling", or even worse "(Un)installing". At a later
point in time, introducing a more full feedback system for the installation
progress would be advantageous, but for a rapid fix to the immediate issue,
this works.
M +24 -0 autotests/core/installationtest.cpp
M +14 -7 src/core/installation.cpp
M +1 -1 src/qtquick/qml/EntryDetails.qml
M +2 -1 src/qtquick/qml/NewStuffItem.qml
M +1 -1 src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
https://invent.kde.org/frameworks/knewstuff/commit/25797117583ea288152ddf042938cd5e1b6bfa19
--
You are receiving this mail because:
You are watching all bug changes.
