Re: [PR] Update dependency com.google.re2j:re2j to v1.8 [solr]
solrbot commented on PR #2986: URL: https://github.com/apache/solr/pull/2986#issuecomment-2579437820 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks com.google.re2j:re2j FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is n
[PR] Update dependency com.google.re2j:re2j to v1.8 [solr]
solrbot opened a new pull request, #2986: URL: https://github.com/apache/solr/pull/2986 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.re2j:re2j](https://redirect.github.com/google/re2j) | dependencies | minor | `1.7` -> `1.8` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v2.46 [solr]
solrbot opened a new pull request, #2988: URL: https://github.com/apache/solr/pull/2988 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jersey.containers:jersey-container-jetty-http](https://projects.eclipse.org/projects/ee4j.jersey) ([source](https://redirect.github.com/eclipse-ee4j/jersey)) | dependencies | minor | `2.39.1` -> `2.46` | --- ### Release Notes eclipse-ee4j/jersey (org.glassfish.jersey.containers:jersey-container-jetty-http) ### [`v2.46`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.46) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.45...2.46) [Pull 5749] - Jersey update from 3.1.3 to 3.1.4 slows down our external service res… [Pull 5750] - Use Skipping Analyzer always [Pull 5751] - test(flaky): fix paramter type assert in testBothAnnotatedConstructor test case [Pull 5754] - test(flaky): Sorting headers for deterministic order [Pull 5755] - Netty connector hang up after repeated buffer overflow errors when writing data #5753 [Pull 5758] - Bump commons-io:commons-io from 2.11.0 to 2.14.0 in /tools/jersey-release-notes-maven-plugin [Pull 5759] - Added test for JerseyChunkedInputStreamClose [Pull 5760] - Adopt ASM 9.7.1 (JDK 24) [Pull 5761] - Adopt Jackson 2.18.0 [Pull 5768] - fixed flaky test in testDisabledModule() [Pull 5784] - Jersey 3.1.9: java.lang.NoSuchMethodException: jakarta.inject.Inject.value() #5782 [Pull 5788] - Wrapping all methods of the EntityInputStream [Pull 5792] - [2.x] ParamConverterProvider constructors are now protected to allow extensibility [Pull 5800] - NettyConnector - HOST header contains port & 307 works with buffered post [Pull 5801] - Set correct HOST header for Netty & POST [Pull 5809] - Fixed memory leak in Micrometer code when exceptions are returned from the method [Pull 5813] - Fix memory leak when client does not use HK2 [Pull 5816] - Allow to configure Jackson's JaxRSFeature on Jersey DefaultJacksonJaxbJsonProvider [Pull 5819] - Build & run with JDK 24 ### [`v2.45`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.45) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.44...2.45) [Pull 5715] - Release a reference to threadlocal on shutdown [Pull 5731] - Allow to disable JSON-B using System properties ### [`v2.44`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.44) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.43...2.44) [Pull 5636] - Allow long content length in the JDK connector [Pull 5639] - Allow having multiple annotations for multipart endpoint with @FormDataParam in any order [Pull 5642] - Remove synchronized from Apache stream wrappers [Pull 5643] - Document Multipart Configuration. [Pull 5644] - Refactoring Maven build process [Pull 5648] - Support for Virtual Threads in Executor Services [Pull 5649] - MAX_HEADER_SIZE for the Netty connector [Pull 5652] - Unify the SniConfigurator with other branches [Pull 5664] - More release checks [Pull 5665] - update Jackson to 2.17.1 [Pull 5666] - [2.x] mvn build improvements [Pull 5669] - prevent calling ServletRequest#getInputStream if FILTER_FORWARD_ON_404 [Pull 5673] - Support missing Content-Length header [Pull 5677] - Prevent blowing connections number for reoccurring SSLContextFatories [Pull 5685] - Better explanation of missing jersey-hk2 module consequences. [Pull 5688] - Wrap call of deprecated HttpServletResponse#setStatus into try catch [Pull 5689] - Support Multipart with Buffered Entity and Netty Connector [Pull 5690] - Prevent NPE in micrometer when there is no response & 404 [Pull 5698] - Last-Modified header is garbled when accessing wadl document on Japanese locale [Pull 5705] - Allow ChunkedInput#close to close the underlying stream [Pull 5706] - Propagate WebApplicationException from SseEventSource to provided error handler [Pull 5707] - Fix intermittent failure in BroadcasterExecutorTest ### [`v2.43`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.43) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.42...2.43) [Pull 5574] - Backing up CI/CD jobs into the Jersey project [Pull 5580] - Adopt ASM 9.7 [Pull 5592] - Micrometer - Add missing metrics for cases of client errors [Pull 5604] - Prevent Jackson failing while loading Modules (classloader issues) [Pull 5605] - Cleaning redundant plugins from plugin management [Pull 5606] - clean CI/CD scripts from the main project [Pull 5608] - ObjectMapper.findModules throws Error [Pull 5613] - Allow the internal package to be a part of the Jersey APIDoc [Pull 5614] - Adde
[PR] Update dependency org.openapi.generator to v7.10.0 [solr]
solrbot opened a new pull request, #2989: URL: https://github.com/apache/solr/pull/2989 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.openapi.generator | plugin | minor | `7.6.0` -> `7.10.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.semver4j:semver4j to v5.5.0 [solr]
solrbot opened a new pull request, #2992:
URL: https://github.com/apache/solr/pull/2992
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.semver4j:semver4j](https://redirect.github.com/semver4j/semver4j) |
dependencies | minor | `5.3.0` -> `5.5.0` |
---
### Release Notes
semver4j/semver4j (org.semver4j:semver4j)
###
[`v5.5.0`](https://redirect.github.com/semver4j/semver4j/releases/tag/v5.5.0)
What's Changed
🚀 Features
-
([#313](https://redirect.github.com/semver4j/semver4j/issues/313))
Update Maven Wrapper by [@mk868](https://redirect.github.com/mk868)
-
([#309](https://redirect.github.com/semver4j/semver4j/issues/309))
Replace nullness annotations with JSpecify by
[@mk868](https://redirect.github.com/mk868)
📦 Dependency Updates
8 changes
-
([#315](https://redirect.github.com/semver4j/semver4j/issues/315)) Bump
peter-evans/create-pull-request from 7.0.5 to 7.0.6 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#314](https://redirect.github.com/semver4j/semver4j/issues/314)) Bump
org.assertj:assertj-core from 3.26.3 to 3.27.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#311](https://redirect.github.com/semver4j/semver4j/issues/311)) Bump
org.junit.jupiter:junit-jupiter from 5.11.3 to 5.11.4 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#310](https://redirect.github.com/semver4j/semver4j/issues/310)) Bump
org.apache.maven.plugins:maven-javadoc-plugin from 3.11.1 to 3.11.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#305](https://redirect.github.com/semver4j/semver4j/issues/305)) Bump
org.apache.maven.plugins:maven-javadoc-plugin from 3.10.1 to 3.11.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#306](https://redirect.github.com/semver4j/semver4j/issues/306)) Bump
org.apache.maven.plugins:maven-surefire-plugin from 3.5.1 to 3.5.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#304](https://redirect.github.com/semver4j/semver4j/issues/304)) Bump
org.apache.maven.plugins:maven-checkstyle-plugin from 3.5.0 to 3.6.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#303](https://redirect.github.com/semver4j/semver4j/issues/303)) Bump
org.junit.jupiter:junit-jupiter from 5.11.2 to 5.11.3 by
[@dependabot](https://redirect.github.com/dependabot)
###
[`v5.4.1`](https://redirect.github.com/semver4j/semver4j/releases/tag/v5.4.1)
What's Changed
🪳 Bug Fixes
-
([#293](https://redirect.github.com/semver4j/semver4j/issues/293)) Fix
OOBE, update README by
[@WarningImHack3r](https://redirect.github.com/WarningImHack3r)
🧹 Housekeeping
-
([#294](https://redirect.github.com/semver4j/semver4j/issues/294)) Add
Java 21 by [@piotrooo](https://redirect.github.com/piotrooo)
📦 Dependency Updates
15 changes
-
([#301](https://redirect.github.com/semver4j/semver4j/issues/301)) Bump
org.mockito:mockito-core from 5.14.1 to 5.14.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#300](https://redirect.github.com/semver4j/semver4j/issues/300)) Bump
org.jetbrains:annotations from 26.0.0 to 26.0.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#298](https://redirect.github.com/semver4j/semver4j/issues/298)) Bump
org.jetbrains:annotations from 25.0.0 to 26.0.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#296](https://redirect.github.com/semver4j/semver4j/issues/296)) Bump
de.thetaphi:forbiddenapis from 3.7 to 3.8 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#297](https://redirect.github.com/semver4j/semver4j/issues/297)) Bump
org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#295](https://redirect.github.com/semver4j/semver4j/issues/295)) Bump
org.junit.jupiter:junit-jupiter from 5.11.1 to 5.11.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#292](https://redirect.github.com/semver4j/semver4j/issues/292)) Bump
org.apache.maven.plugins:maven-javadoc-plugin from 3.10.0 to 3.10.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#291](https://redirect.github.com/semver4j/semver4j/issues/291)) Bump
org.mockito:mockito-core from 5.14.0 to 5.14.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#289](https://redirect.github.com/semver4j/semver4j/issues/289)) Bump
org.mockito:mockito-core from 5.13.0 to 5.14.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#288](https://redirect.github.com/semver4j/semver4j/issues/288)) Bump
org.apache.maven.plugins:maven-gpg-plugin from 3.2.6 to 3.2.7 by
[@dependabot](https://
[PR] Update dependency org.ow2.asm:asm to v9.7.1 [solr]
solrbot opened a new pull request, #2990: URL: https://github.com/apache/solr/pull/2990 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.ow2.asm:asm](http://asm.ow2.io/) ([source](https://gitlab.ow2.org/asm/asm/)) | dependencies | minor | `9.3` -> `9.7.1` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.eclipse.jgit:org.eclipse.jgit to v6.10.0.202406032230-r [solr]
solrbot opened a new pull request, #2987: URL: https://github.com/apache/solr/pull/2987 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jgit:org.eclipse.jgit](https://eclipse.gerrithub.io/plugins/gitiles/eclipse-jgit/jgit) | dependencies | minor | `6.7.0.202309050840-r` -> `6.10.0.202406032230-r` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update google.errorprone to v2.36.0 [solr]
solrbot opened a new pull request, #2995: URL: https://github.com/apache/solr/pull/2995 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.31.0` -> `2.36.0` | | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.31.0` -> `2.36.0` | --- ### Release Notes google/error-prone (com.google.errorprone:error_prone_core) ### [`v2.36.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.36.0): Error Prone 2.36.0 Changes: - Add new matcher interfaces to `ErrorProneScanner` for AST nodes introduced after Java 11 ([`e5fd194`](https://redirect.github.com/google/error-prone/commit/e5fd194fa21ef9a01e8d4c72489906247aad81c8)) - Fix compatibility with latest JDK 24 EA builds (https://github.com/google/error-prone/commit/d67bc156b737d13ac693d73a403a11a97804423f) - Check that `--should-stop=ifError=FLOW` is set when using the `-Xplugin` integration ([`e71db1f`](https://redirect.github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd)) New checks: - [`DuplicateBranches`](https://errorprone.info/bugpattern/DuplicateBranches): Discourage conditional expressions and if statements where both branches are the same - [`RedundantControlFlow`](https://errorprone.info/bugpattern/RedundantControlFlow): Reports redundant `continue` statements. Closed issues: [#4633](https://redirect.github.com/google/error-prone/issues/4633), [#4646](https://redirect.github.com/google/error-prone/issues/4646) Full changelog: https://github.com/google/error-prone/compare/v2.35.1...v2.36.0 ### [`v2.35.1`](https://redirect.github.com/google/error-prone/releases/tag/v2.35.1): Error Prone 2.35.1 Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release. Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also [#4584](https://redirect.github.com/google/error-prone/issues/4584) and [#4634](https://redirect.github.com/google/error-prone/issues/4634). Future versions of Error Prone will upgrade back to protobuf 4.x. Full changelog: https://github.com/google/error-prone/compare/v2.35.0...v2.35.1 ### [`v2.35.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.35.0): Error Prone 2.35.0 Changes: - Fix handling of `\s` before the trailing delimiter in [`MisleadingEscapedSpace`](https://errorprone.info/bugpattern/MisleadingEscapedSpace) - [`TimeUnitMismatch`](https://errorprone.info/bugpattern/TimeUnitMismatch) improvements: handle binary trees, consider trees like `fooSeconds * 1000` to have units of millis New checks: - [`JavaDurationGetSecondsToToSeconds`](https://errorprone.info/bugpattern/JavaDurationGetSecondsToToSeconds): Prefer `duration.toSeconds()` over `duration.getSeconds()` Full changelog: https://github.com/google/error-prone/compare/v2.34.0...v2.35.0 ### [`v2.34.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.34.0): Error Prone 2.34.0 Changes: - Passing the javac flag `--should-stop=ifError=FLOW` is now required when running Error Prone ([#4595](https://redirect.github.com/google/error-prone/issues/4595)) - The `MemberName` check was renamed to [`IdentifierName`](https://errorprone.info/bugpattern/IdentifierName) New checks: - [`FutureTransformAsync`](https://errorprone.info/bugpattern/FutureTransformAsync): The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures. - [`MisformattedTestData`](https://errorprone.info/bugpattern/MisformattedTestData): Reformats Java source code inside Error Prone test cases. - [`MisleadingEscapedSpace`](https://errorprone.info/bugpattern/MisleadingEscapedSpace): Using `\s` anywhere except at the end of a line in a text block is potentially misleading. - [`ThrowIfUncheckedKnownUnchecked`](https://errorprone.info/bugpattern/ThrowIfUncheckedKnownUnchecked): `throwIfUnchecked(knownUnchecked)` is equivalent to `throw knownUnchecked`. Closed issues: [#4595](https://redirect.github.com/google/error-prone/issues/4595), [#4598](https://redirect.github.com/google/error-prone/issues/4598), [#4620](https://redirect.github.com/google/error-prone/issues/4620) Full changelog: https://github.com/google/error-prone/compare/v2.33.0...v2.34.0 ### [`v2.33.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.33.0): Error Prone 2.33.0 Similar to release
[PR] Update google.auth to v1.30.1 [solr]
solrbot opened a new pull request, #2994: URL: https://github.com/apache/solr/pull/2994 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.auth:google-auth-library-oauth2-http](https://redirect.github.com/googleapis/google-auth-library-java) | dependencies | minor | `1.19.0` -> `1.30.1` | | [com.google.auth:google-auth-library-credentials](https://redirect.github.com/googleapis/google-auth-library-java) | dependencies | minor | `1.19.0` -> `1.30.1` | --- ### Release Notes googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http) ### [`v1.30.1`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1301-2024-12-11) # Bug Fixes - JSON parsing of S2A addresses. ([#1589](https://redirect.github.com/googleapis/google-auth-library-java/issues/1589)) ([9d5ebfe](https://redirect.github.com/googleapis/google-auth-library-java/commit/9d5ebfe8870a11d27af3a7c7f3fd9930ab207162)) ### [`v1.30.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1300-2024-11-08) # Features - Support querying S2A Addresses from MDS ([#1400](https://redirect.github.com/googleapis/google-auth-library-java/issues/1400)) ([df06bd1](https://redirect.github.com/googleapis/google-auth-library-java/commit/df06bd1f94d03c4f8807c2adf42d25d29b731531)) # Bug Fixes - Make it explicit that there is a network call to MDS to get SecureSessionAgentConfig ([#1573](https://redirect.github.com/googleapis/google-auth-library-java/issues/1573)) ([18020fe](https://redirect.github.com/googleapis/google-auth-library-java/commit/18020fedb855742ee27b6558f5de58d3818c6b48)) ### [`v1.29.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1290-2024-10-22) # Features - Service sccount to service account impersonation to support universe domain ([#1528](https://redirect.github.com/googleapis/google-auth-library-java/issues/1528)) ([c498ccf](https://redirect.github.com/googleapis/google-auth-library-java/commit/c498ccf67755c6ec619cb37962c2c86ae3ec9d4c)) # Bug Fixes - Make some enum fields final ([#1526](https://redirect.github.com/googleapis/google-auth-library-java/issues/1526)) ([8920155](https://redirect.github.com/googleapis/google-auth-library-java/commit/89201558db913d9a71b3acccbab8eb0045ada6de)) ### [`v1.28.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1280-2024-10-02) # Features - Add metric headers ([#1503](https://redirect.github.com/googleapis/google-auth-library-java/issues/1503)) ([7f0c1d3](https://redirect.github.com/googleapis/google-auth-library-java/commit/7f0c1d31176f9e634fac3b2c6b06f880a51b5fa6)) ### [`v1.27.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1270-2024-09-20) # Features - Add api key credential as client library authorization type ([#1483](https://redirect.github.com/googleapis/google-auth-library-java/issues/1483)) ([6401e51](https://redirect.github.com/googleapis/google-auth-library-java/commit/6401e51c04fa6bd819e8dff98a62b7f079608a43)) ### [`v1.26.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1260-2024-09-18) # Features - Updates UserAuthorizer to support retrieving token response directly with different client auth types ([#1486](https://redirect.github.com/googleapis/google-auth-library-java/issues/1486)) ([1651006](https://redirect.github.com/googleapis/google-auth-library-java/commit/16510064e861868f649b6bc8fdc54b8a39890812)) ### [`v1.25.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1250-2024-09-03) # Features - Support retrieving ID Token from IAM endpoint for ServiceAccountCredentials ([#1433](https://redirect.github.com/googleapis/google-auth-library-java/issues/1433)) ([4fcf83e](https://redirect.github.com/googleapis/google-auth-library-java/commit/4fcf83e0f96de0e6323b85b9a47119a257b37e90)) # Bug Fixes - ComputeEngineCredentials.createScoped should invalidate existing AccessToken ([#1428](https://redirect.github.com/googleapis/google-auth-library-java/issues/1428)) ([079a065](https://redirect.github.com/googleapis/google-auth-library-java/commit/079a06563114e359b74694b78aec687601a2f628)) - Invalidate the SA's AccessToken when createScoped() is called ([#1489](https://redirect.github.com/googleapis/google-auth-library-java/issues/1489)) ([f26fee7](https://redirect.github.com/googleapis/google-auth-library-java/commit/f26fee78d69fce1aaa00dbd5548f3e0266ee6441)) ### [`v1.24.1`](https://redirect.github.com/
[PR] Update dependency org.threeten:threetenbp to v1.7.0 [solr]
solrbot opened a new pull request, #2993: URL: https://github.com/apache/solr/pull/2993 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.threeten:threetenbp](https://www.threeten.org/threetenbp) ([source](https://redirect.github.com/ThreeTen/threetenbp)) | dependencies | minor | `1.6.8` -> `1.7.0` | --- ### Release Notes ThreeTen/threetenbp (org.threeten:threetenbp) ### [`v1.7.0`](https://redirect.github.com/ThreeTen/threetenbp/releases/tag/v1.7.0) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. ### [`v1.6.9`](https://redirect.github.com/ThreeTen/threetenbp/releases/tag/v1.6.9) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17556: Fix smokeTest to use films as example for slim distribution [solr]
HoustonPutman opened a new pull request, #3020: URL: https://github.com/apache/solr/pull/3020 fixes for - [SOLR-17556](https://issues.apache.org/jira/browse/SOLR-17556) (cherry picked from commit 80dfe11fe4c8f123f56ec2f85870d12b7e086e9e) The initial commit fixed the smoke test script to not use the techproducts example for the slim distribution. In main the `test_utf8` script was already removed, so I removed that here as well. I also removed the data, which required changing a few tests to fit the 1 less document. More important, I also added the ability to set the solr home directory for examples. this is important for testing, but is much better than modifying the server directory in solr. Will forward port the differences from the original commit to main if it's approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17334: Enable coordinator nodes to handle requests other than `/select` [solr]
github-actions[bot] closed pull request #2527: SOLR-17334: Enable coordinator nodes to handle requests other than `/select` URL: https://github.com/apache/solr/pull/2527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17334: Enable coordinator nodes to handle requests other than `/select` [solr]
github-actions[bot] commented on PR #2527: URL: https://github.com/apache/solr/pull/2527#issuecomment-2581473338 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17611) SolrJ should pass Solr version in the user-agent
[ https://issues.apache.org/jira/browse/SOLR-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911709#comment-17911709 ] David Smiley commented on SOLR-17611: - In SOLR-17582, this would be useful to safely allow us to switch from a NamedList to a Map in our response structures. Ideally we would also have real backwards compatibility tests (via Docker) so that we'd be able to actually verify the compatibility that we make theoretical assessments about. > SolrJ should pass Solr version in the user-agent > > > Key: SOLR-17611 > URL: https://issues.apache.org/jira/browse/SOLR-17611 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > SolrJ clients should pass an HTTP User-Agent header that includes the version > of Solr. This way, the Solr server may vary its behavior or response format > based on the version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17587) Prometheus Writer duplicate TYPE information in exposition format
[
https://issues.apache.org/jira/browse/SOLR-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17587.
-
Fix Version/s: 9.9
Resolution: Fixed
Thanks for the contribution Mathew!
> Prometheus Writer duplicate TYPE information in exposition format
> -
>
> Key: SOLR-17587
> URL: https://issues.apache.org/jira/browse/SOLR-17587
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.7
>Reporter: Matthew Biscocho
>Priority: Minor
> Labels: pull-request-available
> Fix For: 9.9
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Solr's Prometheus writer duplicates `# TYPE type>` in it's exposition format for core registry metrics.
> For example this appears twice in it's output:
> {code:java}
> # TYPE solr_metrics_core_average_request_time gauge
> solr_metrics_core_average_request_time{category="ADMIN",collection="foo",core="core_foo_shard9_replica_t351",handler="/admin/file",replica="replica_t351",shard="shard9"}
> 0.0
> ...
> # TYPE solr_metrics_core_average_request_time gauge{code}
> This is technically not allowed per [Prometheus Exposition
> format|https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#:~:text=Only%20one%20TYPE%20line%20may%20exist%20for%20a%20given%20metric%20name.]
> This happens because each Dropwizard registry is per core, but for Prometheus
> compatible exposition format upon exporting, it needs to be 1 registry for
> all cores on a single host, otherwise there will be duplicate `TYPE` formats
> even though all metrics are unique for its tags/attributes.
> Funnily enough, prometheus upstream collector does not do this verification
> and accepts the metrics anyways just fine Solr -> Prometheus -> Grafana.
> But depending on the technologies prometheus exposition verification, this
> will fail. For example
> [Telegraf|https://github.com/influxdata/telegraf/blob/master/plugins/inputs/prometheus/README.md]:
> {code:java}
> -12-09T16:56:01Z E! [inputs.prometheus] Error in plugin: error reading
> metrics for "http://127.0.0.1:8983/solr/admin/metrics?wt=prometheus":
> decoding response failed: text format parsing error in line 568: second TYPE
> line for metric name "solr_metrics_core_average_request_time", or TYPE
> reported after samples {code}
> This shouldn't be a blocker if you are pushing metrics to prometheus
> collector directly.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Add security context config to SOLR containers [solr-operator]
bentastic27 commented on PR #702: URL: https://github.com/apache/solr-operator/pull/702#issuecomment-2581542210 Hey @gerlowskija sorry I must of missed that other comment. This was a bit back and I ended up using the bitnami chart in the meantime. It's been a while, but I did test it. I'm just not going to be able to drive much on testing this in the future and it looks your other PR checks all the boxes. Basically just needed a way of at least setting them. https://github.com/apache/solr-operator/pull/743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update google.protobuf to v4 (major) [solr]
solrbot commented on PR #3022: URL: https://github.com/apache/solr/pull/3022#issuecomment-2581725353 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks com.google.protobuf:protobuf-java-util,com.google.protobuf:protobuf-java FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task
Re: [PR] Update dependency org.owasp.dependencycheck to v11 [solr]
solrbot commented on PR #3021: URL: https://github.com/apache/solr/pull/3021#issuecomment-2581723339 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.owasp.dependencycheck:org.owasp.dependencycheck.gradle.plugin FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to wr
[PR] Update google.protobuf to v4 (major) [solr]
solrbot opened a new pull request, #3022: URL: https://github.com/apache/solr/pull/3022 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://redirect.github.com/protocolbuffers/protobuf)) | dependencies | major | `3.25.3` -> `4.29.3` | | [com.google.protobuf:protobuf-java](https://developers.google.com/protocol-buffers/) ([source](https://redirect.github.com/protocolbuffers/protobuf)) | dependencies | major | `3.25.3` -> `4.29.3` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.owasp.dependencycheck to v11 [solr]
solrbot opened a new pull request, #3021: URL: https://github.com/apache/solr/pull/3021 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.owasp.dependencycheck | plugin | major | `9.0.8` -> `11.1.1` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Fix rarely flaky DeleteInactiveReplicaTest. [solr]
psalagnac merged PR #3012: URL: https://github.com/apache/solr/pull/3012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Fix smokeTest to use films as example for slim distribution [solr]
HoustonPutman commented on PR #3020: URL: https://github.com/apache/solr/pull/3020#issuecomment-2581359494 Yeah , I guess we could do that with the examples-dir option. Originally i had removed the examples when adding the slim distribution, but left it in to not disrupt the testing methodology too much -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17611 SolrJ User-Agent, pass Solr version [solr]
jdyer1 commented on PR #2927: URL: https://github.com/apache/solr/pull/2927#issuecomment-2581363581 There are asserts in the unit tests for the user-agent, so changing it will cause failures I think. See `HttpSolrClientTestBase#expectedUserAgent`. If we put the specification version in a `protected static` variable, the unit test can easily override it, which might be adequate enough of a unit testing strategy? I was looking around and maybe ByteBuddy's `PackageDefinitionStrategy` could be used to mock this? Even if possible (I have no idea) I guess that would be more effort than it is worth! I agree something in the smoke tester would be the best way to verify correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17611 SolrJ User-Agent, pass Solr version [solr]
jdyer1 commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1909541445
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -106,11 +106,15 @@
*
*/
public class Http2SolrClient extends HttpSolrClientBase {
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static final String REQ_PRINCIPAL_KEY = "solr-req-principal";
+ private static final String USER_AGENT =
+ "Solr["
Review Comment:
Could this go in the superclass so it doesn't have to exist twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Fix smokeTest to use films as example for slim distribution [solr]
HoustonPutman commented on PR #3020: URL: https://github.com/apache/solr/pull/3020#issuecomment-2581408277 For 9x we shouldnt remove it though. Just for 10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17556) Examples should run with the standard & recommended Solr process
[ https://issues.apache.org/jira/browse/SOLR-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911599#comment-17911599 ] ASF subversion and git services commented on SOLR-17556: Commit 80dfe11fe4c8f123f56ec2f85870d12b7e086e9e in solr's branch refs/heads/main from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=80dfe11fe4c ] SOLR-17556: Fix smokeTest to use films as example for slim distribution > Examples should run with the standard & recommended Solr process > > > Key: SOLR-17556 > URL: https://issues.apache.org/jira/browse/SOLR-17556 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: examples >Reporter: Houston Putman >Assignee: Eric Pugh >Priority: Major > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 1h > Remaining Estimate: 0h > > Right now, there is a lot of special logic around how examples are started. > However we should get to a place where examples are merely data (+ > configSets) added to the generic Solr install. For the cloud example, it > should still start a number of Solr processes. > Also these examples can use modules via directives in the configSet. We > should move away from this, and have the Solr processes be started with > "-Dsolr.modules", as is recommended in the refGuide. (The directives > will also be removed in 10.0, so this is important to change before that > happens.) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908872833
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else {
rsp.add(STATUS, STATUS_FAILURE);
}
- log.info("Responding encryption state={} success={} for keyId={}",
- encryptionState, success, keyId);
- rsp.add(ENCRYPTION_STATE, encryptionState);
+ rsp.add(ENCRYPTION_STATE, state.value);
+ long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+ log.info("Responding encryption state={} success={} for keyId={}
timeMs={}",
+ state.value, success, keyId, timeMs);
}
}
+ private void distributeRequest(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId, long startTimeNs) {
+boolean success = false;
+String collectionName = null;
+State collectionState = null;
+long timeAllowedMs = req.getParams().getLong(TIME_ALLOWED, 0);
+long maxTimeNs = timeAllowedMs <= 0 ? Long.MAX_VALUE : startTimeNs +
timeAllowedMs;
+try {
+ collectionName = req.getCore().getCoreDescriptor().getCollectionName();
+ if (collectionName == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " can only be used in Solr Cloud mode.");
+ }
+ log.debug("Encrypt request distributed for keyId={} collection={}",
keyId, collectionName);
+ DocCollection docCollection =
req.getCore().getCoreContainer().getZkController().getZkStateReader().getCollection(collectionName);
+ if (docCollection == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " present but collection '" + collectionName + "' not
found.");
+ }
+ try (SolrClientHolder solrClient = getHttpSolrClient(req)) {
+ModifiableSolrParams params = createDistributedRequestParams(req, rsp,
keyId);
+for (Slice slice : docCollection.getActiveSlices()) {
Review Comment:
Good point. I modified to use the ExecutorService to send the request in
parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] Replica recovery fails after using Solr Encryption Plugin in multi-sharded Solr collection [solr-sandbox]
bruno-roustant commented on issue #114: URL: https://github.com/apache/solr-sandbox/issues/114#issuecomment-2580311570 Thanks for this issue. I will try to write a test to reproduce and then fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]
mlbiscoc commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2580393753 > If you haven't started; I will. It's just slightly more work in my IDE as I'm set up for the change. No worries, I got it. I'll push a PR to 9x soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17587: (9x backport) wt=prometheus fix duplicate TYPE information [solr]
mlbiscoc opened a new pull request, #3006: URL: https://github.com/apache/solr/pull/3006 https://issues.apache.org/jira/browse/SOLR-17587 # Description Solr's Prometheus writer duplicates `# TYPE ` in it's exposition format for `core`registry metrics. This is an illegal format and depending on the technologies prometheus exposition verification for example `Telegraf`, this will fail. For Prometheus server itself, this still passes and collects the metrics just fine for some reason. This is because the Prometheus Writer takes Dropwizard registries and exports them to Prometheus Registries to expose them in Prometheus format. Solr creates Dropwizard registry for every `core` and differentiates the metrics that way even though they have the same metric names. For prometheus, this creates an issue in that metrics should be differentiated in it's attributes and tags. So when the metrics are output with the Prometheus response writer, it duplicates the `TYPE` information because it is a registry for every `core` and doesn't know that the other `core` registries have the same metric name and results in duplicate `TYPE` information. # Solution When metrics are going to be exported for prometheus, we merge all the `core` Dropwizard metric registries into a single registry and export that registry into prometheus. Duplicate metric names in a registry is not allowed in prometheus, so we will also append the core name to the Dropwizard metric to differentiate which metric belongs to what core and parse the labels accordingly. This also allowed to clean up and simply some of the `SolrPrometheusCoreFormatter` code. # Tests Updated the test accordingly with the coreName existing in the Dropwizard metric names and it's parsing. Also added an assert in `testPrometheusStructureOutput` to confirm there is no duplicate `TYPE` information in prometheus output. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]
mlbiscoc commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2580472548 [PR](https://github.com/apache/solr/pull/3006) for 9x backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17587: (9x backport) wt=prometheus fix duplicate TYPE information [solr]
mlbiscoc commented on code in PR #3006:
URL: https://github.com/apache/solr/pull/3006#discussion_r1908950933
##
solr/core/src/java/org/apache/solr/metrics/prometheus/core/SolrCoreMetric.java:
##
@@ -29,7 +30,8 @@ public abstract class SolrCoreMetric extends SolrMetric {
Pattern.compile(
"(?^core_(?.*)_(?shard[0-9]+)_(?replica_.[0-9]+)).(.*)$");
public static Pattern STANDALONE_CORE_PATTERN =
Pattern.compile("^core_(?.*?)\\.(.*)$");
-
+ public static List CLOUD_LABEL_KEYS = List.of("core", "collection",
"shard", "replica");
+ public static List STANDALONE_LABEL_KEYS = List.of("core");
Review Comment:
I did a static List of the keys for each regex expression instead of the Map
and looped through these to add the labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Use separate nodeProjectDir for each subproject [solr]
epugh commented on PR #2680: URL: https://github.com/apache/solr/pull/2680#issuecomment-2580490017 Thanks @dsmiley ...I guess I was thinking as developer of Solr versus a user of Solr! And Changes.txt is meant for the user primarily! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.owasp.dependencycheck to v9.2.0 [solr]
solrbot opened a new pull request, #2991: URL: https://github.com/apache/solr/pull/2991 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.owasp.dependencycheck | plugin | minor | `9.0.8` -> `9.2.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908468426
##
encryption/src/test/java/org/apache/solr/encryption/EncryptionTestUtil.java:
##
@@ -130,13 +143,29 @@ public EncryptionStatus encrypt(String keyId) throws
Exception {
params.set(PARAM_KEY_ID, keyId);
params.set(PARAM_TENANT_ID, TENANT_ID);
params.set(PARAM_ENCRYPTION_KEY_BLOB, generateKeyBlob(keyId));
+if (shouldDistributeEncryptRequest()) {
+ return encryptDistrib(params);
+}
GenericSolrRequest encryptRequest = new
GenericSolrRequest(SolrRequest.METHOD.GET, "/admin/encrypt", params);
EncryptionStatus encryptionStatus = new EncryptionStatus();
forAllReplicas(replica -> {
NamedList response = requestCore(encryptRequest, replica);
+ EncryptionRequestHandler.State state =
EncryptionRequestHandler.State.fromValue(response.get(ENCRYPTION_STATE).toString());
encryptionStatus.success &= response.get(STATUS).equals(STATUS_SUCCESS);
- encryptionStatus.complete &=
response.get(ENCRYPTION_STATE).equals(STATE_COMPLETE);
-});
+ encryptionStatus.complete &= state ==
EncryptionRequestHandler.State.COMPLETE;
+}, false);
+return encryptionStatus;
+ }
+
+ private EncryptionStatus encryptDistrib(ModifiableSolrParams params) throws
SolrServerException, IOException {
+params.set(DISTRIB, "true");
Review Comment:
Thanks, I didn't know the SolrParams.wrapDefaults technique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update grpc to v1.69.0 [solr]
solrbot opened a new pull request, #2996: URL: https://github.com/apache/solr/pull/2996 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.grpc:grpc-util](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-stub](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-protobuf-lite](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-protobuf](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-netty](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-core](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-context](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-bom](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | | [io.grpc:grpc-api](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.69.0` | --- ### Release Notes grpc/grpc-java (io.grpc:grpc-util) ### [`v1.69.0`](https://redirect.github.com/grpc/grpc-java/releases/tag/v1.69.0) **v1.69.0** New Features - api: Allow `LoadBalancer`s to specify an authority per-RPC.([#11631](https://redirect.github.com/grpc/grpc-java/issues/11631)) ([`c167ead`](https://redirect.github.com/grpc/grpc-java/commit/c167ead85)) CallOptions.withAuthority() has higher precedence. - netty: Add soft Metadata size limit enforcement. ([#11603](https://redirect.github.com/grpc/grpc-java/issues/11603)) ([`735b3f3`](https://redirect.github.com/grpc/grpc-java/commit/735b3f3fe)) The soft limit is a lower size limit that fails an increasing percentage of RPCs as the Metadata size approaches the upper limit. This can be used as an “early warning” that the Metadata size is growing too large - alts: support altsCallCredentials in `GoogleDefaultChannelCredentials` ([#11634](https://redirect.github.com/grpc/grpc-java/issues/11634)) ([`ba8ab79`](https://redirect.github.com/grpc/grpc-java/commit/ba8ab796e)) - xds: Add grpc.xds_client metrics, as documented by [OpenTelemetry Metrics](https://grpc.io/docs/guides/opentelemetry-metrics/#xdsclient-instruments) ([#11661](https://redirect.github.com/grpc/grpc-java/issues/11661)) ([`20d09ce`](https://redirect.github.com/grpc/grpc-java/commit/20d09cee5)). `grpc.xds.authority` is not yet available Bug Fixes - api: When forwarding from `Listener` onAddresses to `Listener2` continue to use onResult ([#11666](https://redirect.github.com/grpc/grpc-java/issues/11666)) ([`dae078c`](https://redirect.github.com/grpc/grpc-java/commit/dae078c0a)). This fixes a 1.68.1 "IllegalStateException: Not called from the SynchronizationContext" regression ([#11662](https://redirect.github.com/grpc/grpc-java/issues/11662)) that could be seen in certain custom NameResolvers - okhttp: If the frame handler thread is null do not schedule it on the executor ([`ef1fe87`](https://redirect.github.com/grpc/grpc-java/commit/ef1fe8737)). This fixes a 1.68.1 NullPointerException regression when a custom transportExecutor was provided to the channel and it did not have enough threads to run new tasks Improvements - api: Add `java.time.Duration` overloads to `CallOptions`, `AbstractStub` methods that take TimeUnit and a time value ([#11562](https://redirect.github.com/grpc/grpc-java/issues/11562)) ([`766b923`](https://redirect.github.com/grpc/grpc-java/commit/766b92379)) - core: Make timestamp usage in Channelz use nanos from Java.time.Instant when available ([#11604](https://redirect.github.com/grpc/grpc-java/issues/11604)) ([`9176b55`](https://redirect.github.com/grpc/grpc-java/commit/9176b5528)). This increases the timestamp precision from milliseconds - okhttp: Fix for ipv6 link local with scope ([#11725](https://redirect.github.com/grpc/grpc-java/issues/11725)[) (e98e7445b)](https://redirect.github.com/grpc/grpc-java/commit/e98e7445be6209ed4300724d6c2769635ceef5e4) - binder: Let `AndroidComponentAddress` specify a target UserHandle ([#11670](https://redirect.github.com/grpc/grpc-java/issues/11670)) ([`e58c998`](https://redirect.github.com/grpc/grpc-java/commit/e58c998a4)) - servlet: Deframe failures should be logged on the server as warnings ([#11645](https://redirect.github.com/grpc/grpc-java/issues/11645)) ([`a5db67d`](https://redirect.github.com/grpc/grpc-java/commit/a5db67d0c)) - s2a: Rename the Bazel target s2av2\_credentials to s2a ([`29dd9ba`](https://redirect.github.com/grpc/grpc-java/commit/29dd9bad3)). The target s2a had been referenced
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908759447
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else {
rsp.add(STATUS, STATUS_FAILURE);
}
- log.info("Responding encryption state={} success={} for keyId={}",
- encryptionState, success, keyId);
- rsp.add(ENCRYPTION_STATE, encryptionState);
+ rsp.add(ENCRYPTION_STATE, state.value);
+ long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+ log.info("Responding encryption state={} success={} for keyId={}
timeMs={}",
+ state.value, success, keyId, timeMs);
}
}
+ private void distributeRequest(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId, long startTimeNs) {
+boolean success = false;
+String collectionName = null;
+State collectionState = null;
+long timeAllowedMs = req.getParams().getLong(TIME_ALLOWED, 0);
+long maxTimeNs = timeAllowedMs <= 0 ? Long.MAX_VALUE : startTimeNs +
timeAllowedMs;
+try {
+ collectionName = req.getCore().getCoreDescriptor().getCollectionName();
+ if (collectionName == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " can only be used in Solr Cloud mode.");
+ }
+ log.debug("Encrypt request distributed for keyId={} collection={}",
keyId, collectionName);
+ DocCollection docCollection =
req.getCore().getCoreContainer().getZkController().getZkStateReader().getCollection(collectionName);
+ if (docCollection == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " present but collection '" + collectionName + "' not
found.");
+ }
+ try (SolrClientHolder solrClient = getHttpSolrClient(req)) {
+ModifiableSolrParams params = createDistributedRequestParams(req, rsp,
keyId);
+for (Slice slice : docCollection.getActiveSlices()) {
+ if (isTimeout(maxTimeNs)) {
+log.warn("Timeout distributing encryption request for keyId={}
collection={}", keyId, collectionName);
+if (collectionState == null || State.TIMEOUT.priority >
collectionState.priority) {
+ collectionState = State.TIMEOUT;
+}
+break;
+ }
+ Replica replica = slice.getLeader();
+ if (replica == null) {
+log.error("No leader found for shard {}", slice.getName());
+collectionState = State.ERROR;
+continue;
+ }
+ State state = sendEncryptionRequestWithRetry(replica, params,
solrClient.getClient(), keyId, collectionName);
+ if (collectionState == null || state.priority >
collectionState.priority) {
+collectionState = state;
+ }
+}
+success = collectionState == null || collectionState.isSuccess();
+ }
+} finally {
+ if (success) {
+rsp.add(STATUS, STATUS_SUCCESS);
+ } else {
+rsp.add(STATUS, STATUS_FAILURE);
+ }
+ if (collectionState != null) {
+rsp.add(ENCRYPTION_STATE, collectionState.value);
+ }
+ if (log.isInfoEnabled()) {
+long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+log.info("Responding encryption distributed state={} success={} for
keyId={} collection={} timeMs={}",
+(collectionState == null ? null : collectionState.value), success,
keyId, collectionName, timeMs);
+ }
+}
+ }
+
+ private SolrClientHolder getHttpSolrClient(SolrQueryRequest req) {
+CoreContainer coreContainer = req.getCore().getCoreContainer();
+CloudSolrClient cloudSolrClient =
coreContainer.getSolrClientCache().getCloudSolrClient(coreContainer.getZkController().getZkClient().getZkServerAddress());
+if (cloudSolrClient instanceof CloudHttp2SolrClient) {
+ return new SolrClientHolder(((CloudHttp2SolrClient)
cloudSolrClient).getHttpClient(), false);
+}
+return new SolrClientHolder(new Http2SolrClient.Builder().build(), true);
+ }
+
+ protected ModifiableSolrParams
createDistributedRequestParams(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId) {
+ModifiableSolrParams params = new ModifiableSolrParams();
+params.set(PARAM_KEY_ID, keyId == null ? NO_KEY_ID : keyId);
+return params;
+ }
+
+ boolean isTimeout(long maxTimeNs) {
+return System.nanoTime() > maxTimeNs;
+ }
+
+ private State sendEncryptionRequestWithRetry(Replica replica,
ModifiableSolrParams params, Http2SolrClient httpSolrClient, String keyId,
String collection) {
+for (int numAttempts = 0; numAttempts < DISTRIBUTION_MAX_ATTEMPTS;
numAttempts++) {
+ try {
+NamedList response = sendEncryptionRequest(replica, param
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908750260
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else {
rsp.add(STATUS, STATUS_FAILURE);
}
- log.info("Responding encryption state={} success={} for keyId={}",
- encryptionState, success, keyId);
- rsp.add(ENCRYPTION_STATE, encryptionState);
+ rsp.add(ENCRYPTION_STATE, state.value);
+ long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+ log.info("Responding encryption state={} success={} for keyId={}
timeMs={}",
+ state.value, success, keyId, timeMs);
}
}
+ private void distributeRequest(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId, long startTimeNs) {
+boolean success = false;
+String collectionName = null;
+State collectionState = null;
+long timeAllowedMs = req.getParams().getLong(TIME_ALLOWED, 0);
+long maxTimeNs = timeAllowedMs <= 0 ? Long.MAX_VALUE : startTimeNs +
timeAllowedMs;
+try {
+ collectionName = req.getCore().getCoreDescriptor().getCollectionName();
+ if (collectionName == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " can only be used in Solr Cloud mode.");
+ }
+ log.debug("Encrypt request distributed for keyId={} collection={}",
keyId, collectionName);
+ DocCollection docCollection =
req.getCore().getCoreContainer().getZkController().getZkStateReader().getCollection(collectionName);
+ if (docCollection == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " present but collection '" + collectionName + "' not
found.");
+ }
+ try (SolrClientHolder solrClient = getHttpSolrClient(req)) {
+ModifiableSolrParams params = createDistributedRequestParams(req, rsp,
keyId);
+for (Slice slice : docCollection.getActiveSlices()) {
+ if (isTimeout(maxTimeNs)) {
+log.warn("Timeout distributing encryption request for keyId={}
collection={}", keyId, collectionName);
+if (collectionState == null || State.TIMEOUT.priority >
collectionState.priority) {
+ collectionState = State.TIMEOUT;
+}
+break;
+ }
+ Replica replica = slice.getLeader();
+ if (replica == null) {
+log.error("No leader found for shard {}", slice.getName());
+collectionState = State.ERROR;
+continue;
+ }
+ State state = sendEncryptionRequestWithRetry(replica, params,
solrClient.getClient(), keyId, collectionName);
+ if (collectionState == null || state.priority >
collectionState.priority) {
+collectionState = state;
+ }
+}
+success = collectionState == null || collectionState.isSuccess();
+ }
+} finally {
+ if (success) {
+rsp.add(STATUS, STATUS_SUCCESS);
+ } else {
+rsp.add(STATUS, STATUS_FAILURE);
+ }
+ if (collectionState != null) {
+rsp.add(ENCRYPTION_STATE, collectionState.value);
+ }
+ if (log.isInfoEnabled()) {
+long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+log.info("Responding encryption distributed state={} success={} for
keyId={} collection={} timeMs={}",
+(collectionState == null ? null : collectionState.value), success,
keyId, collectionName, timeMs);
+ }
+}
+ }
+
+ private SolrClientHolder getHttpSolrClient(SolrQueryRequest req) {
Review Comment:
It is not available in Solr 9.6, the Solr version used here. I propose to
let this code for now, and replace it when I upgrade to 9.8 (I need to upgrade
anyway to fix an issue with commit metadata transfer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908728875
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -194,15 +258,22 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else if (keyId.equals(NO_KEY_ID)) {
keyId = null;
}
+// Check the defined DirectoryFactory instance.
EncryptionDirectoryFactory.getFactory(req.getCore());
+
+if (req.getParams().getBool(DISTRIB, false)) {
Review Comment:
I don't see this metadata. The collection name is present in the
CloudSolrClient.request call, but not passed to the inner LBSolrClient.request
call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update mockito to v5.15.2 [solr]
solrbot opened a new pull request, #2998: URL: https://github.com/apache/solr/pull/2998 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.mockito:mockito-subclass](https://redirect.github.com/mockito/mockito) | dependencies | minor | `5.12.0` -> `5.15.2` | | [org.mockito:mockito-core](https://redirect.github.com/mockito/mockito) | dependencies | minor | `5.12.0` -> `5.15.2` | --- ### Release Notes mockito/mockito (org.mockito:mockito-subclass) ### [`v5.15.2`](https://redirect.github.com/mockito/mockito/releases/tag/v5.15.2) *Changelog generated by [Shipkit Changelog Gradle Plugin](https://redirect.github.com/shipkit/shipkit-changelog)* # 5.15.2 - 2025-01-02 - [2 commit(s)](https://redirect.github.com/mockito/mockito/compare/v5.15.1...v5.15.2) by Brice Dutheil, dependabot\[bot] - Fix javadoc publication [(#3561)](https://redirect.github.com/mockito/mockito/pull/3561) - Bump org.assertj:assertj-core from 3.27.0 to 3.27.1 [(#3560)](https://redirect.github.com/mockito/mockito/pull/3560) - The release job is failed again [(#3542)](https://redirect.github.com/mockito/mockito/issues/3542) ### [`v5.14.2`](https://redirect.github.com/mockito/mockito/releases/tag/v5.14.2) *Changelog generated by [Shipkit Changelog Gradle Plugin](https://redirect.github.com/shipkit/shipkit-changelog)* # 5.14.2 - 2024-10-15 - [12 commit(s)](https://redirect.github.com/mockito/mockito/compare/v5.14.1...v5.14.2) by Brice Dutheil, Rafael Winterhalter, dependabot\[bot] - Fix [#3466](https://redirect.github.com/mockito/mockito/issues/3466) nexus publishing configuration [(#3470)](https://redirect.github.com/mockito/mockito/pull/3470) - Bump org.jetbrains.kotlin:kotlin-stdlib from 2.0.20 to 2.0.21 [(#3468)](https://redirect.github.com/mockito/mockito/pull/3468) - Bump bytebuddy from 1.15.3 to 1.15.4 [(#3467)](https://redirect.github.com/mockito/mockito/pull/3467) - Missing 5.14.2 release [(#3466)](https://redirect.github.com/mockito/mockito/issues/3466) - chore: Tests whether JVM warnings / messages on dynamic attach [(#3462)](https://redirect.github.com/mockito/mockito/pull/3462) - Bump junit-jupiter from 5.11.1 to 5.11.2 [(#3461)](https://redirect.github.com/mockito/mockito/pull/3461) - Renames extension modules with `mockito-` prefix [(#3460)](https://redirect.github.com/mockito/mockito/pull/3460) - Avoid attach warning if Byte Buddy is configured for command-line attach. [(#3459)](https://redirect.github.com/mockito/mockito/pull/3459) - Bump org.shipkit:shipkit-auto-version from 2.0.10 to 2.0.11 [(#3458)](https://redirect.github.com/mockito/mockito/pull/3458) - Bump junit-jupiter from 5.11.0 to 5.11.1 [(#3455)](https://redirect.github.com/mockito/mockito/pull/3455) - Move root project to dedicated core folder [(#3444)](https://redirect.github.com/mockito/mockito/issues/3444) - Bump biz.aQute.bnd:biz.aQute.bnd.gradle from 6.4.0 to 7.0.0 [(#3136)](https://redirect.github.com/mockito/mockito/pull/3136) ### [`v5.14.1`](https://redirect.github.com/mockito/mockito/releases/tag/v5.14.1) *Changelog generated by [Shipkit Changelog Gradle Plugin](https://redirect.github.com/shipkit/shipkit-changelog)* # 5.14.1 - 2024-09-30 - [2 commit(s)](https://redirect.github.com/mockito/mockito/compare/v5.14.0...v5.14.1) by Brice Dutheil, dependabot\[bot] - fix: gradle mockitoAgent configuration should not be transitive [(#3454)](https://redirect.github.com/mockito/mockito/pull/3454) - Bump bytebuddy from 1.15.2 to 1.15.3 [(#3452)](https://redirect.github.com/mockito/mockito/pull/3452) - Allow for installing a Java agent within the Mockito jar, without exposing Byte Buddy's attach mechanism. [(#3437)](https://redirect.github.com/mockito/mockito/pull/3437) ### [`v5.14.0`](https://redirect.github.com/mockito/mockito/releases/tag/v5.14.0) *Changelog generated by [Shipkit Changelog Gradle Plugin](https://redirect.github.com/shipkit/shipkit-changelog)* # 5.14.0 - 2024-09-27 - [9 commit(s)](https://redirect.github.com/mockito/mockito/compare/v5.13.0...v5.14.0) by Ali-Hassan, Brice Dutheil, David Saff, Rafael Winterhalter, dependabot\[bot] - Bump org.junit.platform:junit-platform-launcher from 1.11.0 to 1.11.1 [(#3451)](https://redirect.github.com/mockito/mockito/pull/3451) - Bump bytebuddy from 1.15.1 to 1.15.2 [(#3450)](https://redirect.github.com/mockito/mockito/pull/3450) - Update Documentation of ArgumentCaptor.java [(#3448)](https://redirect.github.com/mockito/mockito/pull/3448) - Split subprojects [(#3447)](https://redirect.github.com/mockito/mockito/pull/3447) - Separate extensions from integration tests [(#3443)](https://redirect.github.com/mocki
[PR] Update org.apache.calcite to v1.38.0 [solr]
solrbot opened a new pull request, #3000: URL: https://github.com/apache/solr/pull/3000 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.calcite:calcite-linq4j](https://calcite.apache.org) ([source](https://redirect.github.com/apache/calcite)) | dependencies | minor | `1.37.0` -> `1.38.0` | | [org.apache.calcite:calcite-core](https://calcite.apache.org) ([source](https://redirect.github.com/apache/calcite)) | dependencies | minor | `1.37.0` -> `1.38.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update langchain4j to v0.36.2 [solr]
solrbot opened a new pull request, #2997: URL: https://github.com/apache/solr/pull/2997 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dev.langchain4j:langchain4j-open-ai](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-mistral-ai](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-hugging-face](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-core](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-cohere](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | --- ### Release Notes langchain4j/langchain4j (dev.langchain4j:langchain4j-open-ai) ### [`v0.36.2`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.2) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.36.1...0.36.2) # What's Changed - Fix [#2133](https://redirect.github.com/langchain4j/langchain4j/issues/2133) Spring boot starter breaks configuration classes by [@qing-wq](https://redirect.github.com/qing-wq) in [https://github.com/langchain4j/langchain4j-spring/pull/79](https://redirect.github.com/langchain4j/langchain4j-spring/pull/79) ### [`v0.36.1`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.1) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.36.0...0.36.1) # Fixes - [Fixed](https://redirect.github.com/langchain4j/langchain4j/commit/8a1d755196a2c4ccac805ed0f04972c68befdf26#diff-12719e04c48f3263f90134aa98b8f63c2dcac5ffc06b2877baaf36e29f0ab4c1R30) [https://github.com/langchain4j/langchain4j/issues/2117](https://redirect.github.com/langchain4j/langchain4j/issues/2117) - [Fixed](https://redirect.github.com/langchain4j/langchain4j-embeddings/commit/5b1fc1dd9871222851b1742e648a99298b64d3a1) [https://github.com/langchain4j/langchain4j/issues/2117](https://redirect.github.com/langchain4j/langchain4j/issues/2117) # What's Changed - fix(deps): update dependency org.junit.platform:junit-platform-commons to v1.11.3 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2099](https://redirect.github.com/langchain4j/langchain4j/pull/2099) - fix(deps): update dependency org.jetbrains.kotlin:kotlin-stdlib-jdk8 to v1.9.25 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2097](https://redirect.github.com/langchain4j/langchain4j/pull/2097) - fix(deps): update dependency org.awaitility:awaitility to v4.2.2 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2096](https://redirect.github.com/langchain4j/langchain4j/pull/2096) - [#1636](https://redirect.github.com/langchain4j/langchain4j/issues/1636) add lombok annotation processor by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2105](https://redirect.github.com/langchain4j/langchain4j/pull/2105) - Remove Lombok in langchain4j module by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2063](https://redirect.github.com/langchain4j/langchain4j/pull/2063) - Remove Lombok in LC4J-open-ai by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2064](https://redirect.github.com/langchain4j/langchain4j/pull/2064) - add EmbeddingStoreIT metadata assert closeTo by [@Martin7-1](https://redirect.github.com/Martin7-1) in [https://github.com/langchain4j/langchain4j/pull/2140](https://redirect.github.com/langchain4j/langchain4j/pull/2140) - langchain4j-onnx-scoring: [updated onnxruntime to 1.20.0 and djl to 0.30.0](https://redirect.github.com/langchain4j/langchain4j/commit/8a1d755196a2c4ccac805ed0f04972c68befdf26#diff-cc143402ec507219364406c7ca6776dad87829e4bbf47911641cabd3090dfb20R15) - Release 0.36.1 by [@langchain4j](https://redirect.github.com/langchain4j) in [https://github.com/langchain4j/langchain4j/pull/2149](https://redirect.github.com/langchain4j/langchain4j/pull/2149) **Full Changelog**: https://github.com/langchain4j/langchain4j/compare/0.36.0...0.36.1 ### [`v0.36.0`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.0) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.35.0...0.36.0) # Core Features/Updates - Java 17 baseline by [@kpavlov](https://redirect.g
[PR] Update adobe.testing.s3mock to v3 (major) [solr]
solrbot opened a new pull request, #3002: URL: https://github.com/apache/solr/pull/3002 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.adobe.testing:s3mock-testsupport-common](https://redirect.github.com/adobe/S3Mock) | dependencies | major | `2.17.0` -> `3.12.0` | | [com.adobe.testing:s3mock-junit4](https://redirect.github.com/adobe/S3Mock) | dependencies | major | `2.17.0` -> `3.12.0` | --- ### Release Notes adobe/S3Mock (com.adobe.testing:s3mock-testsupport-common) ### [`v3.12.0`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3120) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.11.0...3.12.0) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - none - Refactorings - none - Version updates (deliverable dependencies) - Bump aws-v2.version from 2.28.11 to 2.29.29 - Bump aws.version from 1.12.772 to 1.12.779 - Bump kotlin.version from 2.0.20 to 2.1.0 - Bump com.fasterxml.jackson:jackson-bom from 2.18.0 to 2.18.2 - Bump commons-io:commons-io from 2.17.0 to 2.18.0 - Bump testcontainers.version from 1.20.1 to 1.20.4 - Bump alpine from 3.20.3 to 3.21.0 in /docker - Version updates (build dependencies) - Bump io.fabric8:docker-maven-plugin from 0.45.0 to 0.45.1 - Bump com.puppycrawl.tools:checkstyle from 10.18.1 to 10.20.2 - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.10.0 to 3.11.2 - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.2 - Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.5.0 to 3.5.2 - Bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.0 to 3.8.1 - Bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.5.0 to 3.6.0 - Bump org.codehaus.mojo:exec-maven-plugin from 3.4.1 to 3.5.0 - Bump actions/dependency-review-action from 4.3.4 to 4.5.0 - Bump actions/setup-java from 4.4.0 to 4.5.0 - Bump actions/upload-artifact from 3.1.0 to 4.4.3 - Bump actions/checkout from 4.2.0 to 4.2.2 - Bump github/codeql-action from 3.26.9 to 3.27.6 - Bump advanced-security/maven-dependency-submission-action from 3.0.3 to 4.1.1 - Bump step-security/harden-runner from 2.10.1 to 2.10.2 ### [`v3.11.0`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3110) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.3...3.11.0) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - none - Version updates (deliverable dependencies) - Bump aws-v2.version from 2.26.25 to 2.28.11 - Bump aws.version from 1.12.765 to 1.12.772 - Bump spring-boot.version from 3.3.2 to 3.3.3 - Bump commons-io:commons-io from 2.16.1 to 2.17.0 - Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 - Bump testcontainers.version from 1.20.0 to 1.20.1 - Bump alpine from 3.20.2 to 3.20.3 in /docker - Bump kotlin.version from 2.0.0 to 2.0.20 ### [`v3.10.3`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3103) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.2...3.10.3) Test release that incremented the patch version number. Please refer / update to version 3.11.0, thanks. ### [`v3.10.2`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3102) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.1...3.10.2) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - Let CopyObject overwrite store headers (fixes [#2005](https://redirect.github.com/adobe/S3Mock/issues/2005)) - Version updates (build dependencies) - Bump org.apache.maven.plugins:maven-deploy-plugin from 3.1.2 to 3.1.3 - Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.8.0 to 3.10.0 - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.6 to 3.2.7 - Bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.4.0 to 3.5.0 - Bump license-maven-plugin-git.version from 4.5 to 4.6 - Bump com.puppycrawl.tools:checkstyle from 10.17.0 to 10.18.1 - Bump actions/checkout from 4.1.7 to 4.2.0 - Bump github/codeql-action from 3.26.7 to 3.26.9 - Bump actions/setup-java from 4.3.0 to 4.4.0 ### [`v3.10.1`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3101) [Compare Source](https://
[PR] Update opentelemetry to v1.45.0 [solr]
solrbot opened a new pull request, #2999: URL: https://github.com/apache/solr/pull/2999 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.opentelemetry:opentelemetry-sdk-trace](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-sdk-testing](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-sdk-extension-autoconfigure](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-sdk](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-exporter-otlp](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-context](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-bom](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | | [io.opentelemetry:opentelemetry-api](https://redirect.github.com/open-telemetry/opentelemetry-java) | dependencies | minor | `1.40.0` -> `1.45.0` | --- ### Release Notes open-telemetry/opentelemetry-java (io.opentelemetry:opentelemetry-sdk-trace) ### [`v1.45.0`](https://redirect.github.com/open-telemetry/opentelemetry-java/blob/HEAD/CHANGELOG.md#Version-1450-2024-12-06) # API - Add convenience method `setAttribute(Attribute, int)` to SpanBuilder (matching the existing convenience method in Span) ([#6884](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6884)) - Extends TextMapGetter with experimental GetAll() method, implement usage in W3CBaggagePropagator ([#6852](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6852)) # SDK # Traces - Add synchronization to SimpleSpanProcessor to ensure thread-safe export of spans ([#6885](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6885)) # Metrics - Lazily initialize ReservoirCells ([#6851](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6851)) # Logs - Add synchronization to SimpleLogRecordProcessor to ensure thread-safe export of logs ([#6885](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6885)) # Exporters - OTLP: Update opentelementry-proto to 1.4 ([#6906](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6906)) - OTLP: Rename internal Marshaler#writeJsonToGenerator method to allow jackson runtimeOnly dependency ([#6896](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6896)) - OTLP: Fix repeated string serialization for JSON. ([#6888](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6888)) - OTLP: Fix missing unsafe available check ([#6920](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6920)) # Extensions - Declarative config: Don't require empty objects when referencing custom components ([#6891](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6891)) # Tooling - Add javadoc boilerplate internal comment v2 for experimental classes ([#6886](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6886)) - Update develocity configuration ([#6903](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6903)) ### [`v1.44.1`](https://redirect.github.com/open-telemetry/opentelemetry-java/blob/HEAD/CHANGELOG.md#Version-1441-2024-11-10) # SDK # Traces - Fix regression in event attributes ([#6865](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6865)) ### [`v1.44.0`](https://redirect.github.com/open-telemetry/opentelemetry-java/blob/HEAD/CHANGELOG.md#Version-1440-2024-11-08) # API - Fix ConfigUtil#getString ConcurrentModificationException ([#6841](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6841)) # SDK # Traces - Stabilize ExceptionEventData ([#6795](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6795)) # Metrics - Stabilize metric cardinality limits ([#6794](https://redirect.github.com/open-telemetry/opentelemetry-java/pull/6794)) - Refactor metrics internals to remove MeterSharedState ([#6845]
[PR] Update apache.tika to v3 (major) [solr]
solrbot opened a new pull request, #3003: URL: https://github.com/apache/solr/pull/3003 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.tika:tika-parsers](https://tika.apache.org/) ([source](https://redirect.github.com/apache/tika)) | dependencies | major | `1.28.5` -> `3.0.0` | | [org.apache.tika:tika-core](https://tika.apache.org/) ([source](https://redirect.github.com/apache/tika)) | dependencies | major | `1.28.5` -> `3.0.0` | --- ### Release Notes apache/tika (org.apache.tika:tika-parsers) ### [`v3.0.0`](https://redirect.github.com/apache/tika/compare/2.9.2...3.0.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.2...3.0.0) ### [`v2.9.2`](https://redirect.github.com/apache/tika/compare/2.9.1...2.9.2) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.1...2.9.2) ### [`v2.9.1`](https://redirect.github.com/apache/tika/compare/2.9.0...2.9.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.0...2.9.1) ### [`v2.9.0`](https://redirect.github.com/apache/tika/compare/2.8.0...2.9.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.8.0...2.9.0) ### [`v2.8.0`](https://redirect.github.com/apache/tika/compare/2.7.0...2.8.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.7.0...2.8.0) ### [`v2.7.0`](https://redirect.github.com/apache/tika/compare/2.6.0...2.7.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.6.0...2.7.0) ### [`v2.6.0`](https://redirect.github.com/apache/tika/compare/2.5.0...2.6.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.5.0...2.6.0) ### [`v2.5.0`](https://redirect.github.com/apache/tika/compare/2.4.1...2.5.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.4.1...2.5.0) ### [`v2.4.1`](https://redirect.github.com/apache/tika/compare/2.4.0...2.4.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.4.0...2.4.1) ### [`v2.4.0`](https://redirect.github.com/apache/tika/compare/2.3.0...2.4.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.3.0...2.4.0) ### [`v2.3.0`](https://redirect.github.com/apache/tika/compare/2.2.1...2.3.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.2.1...2.3.0) ### [`v2.2.1`](https://redirect.github.com/apache/tika/compare/2.2.0...2.2.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.2.0...2.2.1) ### [`v2.2.0`](https://redirect.github.com/apache/tika/compare/2.1.0...2.2.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.1.0...2.2.0) ### [`v2.1.0`](https://redirect.github.com/apache/tika/compare/2.0.0...2.1.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.0.0...2.1.0) ### [`v2.0.0`](https://redirect.github.com/apache/tika/compare/1.28.5...2.0.0) [Compare Source](https://redirect.github.com/apache/tika/compare/1.28.5...2.0.0) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency biz.aQute.bnd:biz.aQute.bnd.annotation to v7 [solr]
solrbot opened a new pull request, #3004: URL: https://github.com/apache/solr/pull/3004 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [biz.aQute.bnd:biz.aQute.bnd.annotation](https://bnd.bndtools.org/) ([source](https://redirect.github.com/bndtools/bnd)) | dependencies | major | `6.4.1` -> `7.1.0` | --- ### Release Notes bndtools/bnd (biz.aQute.bnd:biz.aQute.bnd.annotation) ### [`v7.1.0`](https://redirect.github.com/bndtools/bnd/releases/tag/7.1.0): Bnd/Bndtools 7.1.0 [Compare Source](https://redirect.github.com/bndtools/bnd/compare/7.0.0...7.1.0) See [Release Notes](https://redirect.github.com/bndtools/bnd/wiki/Changes-in-7.1.0). ### [`v7.0.0`](https://redirect.github.com/bndtools/bnd/releases/tag/7.0.0): Bnd/Bndtools 7.0.0 [Compare Source](https://redirect.github.com/bndtools/bnd/compare/6.4.1...7.0.0) This is the first release on Java 17. See [Release Notes](https://redirect.github.com/bndtools/bnd/wiki/Changes-in-7.0.0). --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency com.diffplug.spotless to v7 [solr]
solrbot opened a new pull request, #3005: URL: https://github.com/apache/solr/pull/3005 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | com.diffplug.spotless | plugin | major | `6.5.2` -> `7.0.1` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update prometheus.metrics to v1.3.5 [solr]
solrbot opened a new pull request, #3001: URL: https://github.com/apache/solr/pull/3001 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.prometheus:prometheus-metrics-model](https://redirect.github.com/prometheus/client_java) | dependencies | minor | `1.1.0` -> `1.3.5` | | [io.prometheus:prometheus-metrics-exposition-formats](https://redirect.github.com/prometheus/client_java) | dependencies | minor | `1.1.0` -> `1.3.5` | --- ### Release Notes prometheus/client_java (io.prometheus:prometheus-metrics-model) ### [`v1.3.5`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.5) # What's Changed - Bump com.google.protobuf:protobuf-java from 4.28.3 to 4.29.1 by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1222](https://redirect.github.com/prometheus/client_java/pull/1222) - Add support for dw-metrics 4.x by [@kingster](https://redirect.github.com/kingster) in [https://github.com/prometheus/client_java/pull/1228](https://redirect.github.com/prometheus/client_java/pull/1228) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.4...v1.3.5 ### [`v1.3.4`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.4) # What's Changed - Add instrumentation for Guava & Caffeine to BOM by [@der-eismann](https://redirect.github.com/der-eismann) in [https://github.com/prometheus/client_java/pull/1175](https://redirect.github.com/prometheus/client_java/pull/1175) - fix register part of documentation for caffeine & guava instrumentati… by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1203](https://redirect.github.com/prometheus/client_java/pull/1203) - \[prometheus-metrics-instrumentation-caffeine] implement getPrometheus… by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1206](https://redirect.github.com/prometheus/client_java/pull/1206) - \[prometheus-metrics-instrumentation-guava] implement getPrometheusNames by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1211](https://redirect.github.com/prometheus/client_java/pull/1211) - [make Protobuf optional](https://prometheus.github.io/client_java/exporters/formats/#exclude-protobuf-exposition-format) by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1190](https://redirect.github.com/prometheus/client_java/pull/1190) # New Contributors - [@der-eismann](https://redirect.github.com/der-eismann) made their first contribution in [https://github.com/prometheus/client_java/pull/1175](https://redirect.github.com/prometheus/client_java/pull/1175) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.3...v1.3.4 ### [`v1.3.3`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.3) # What's Changed - Bump com.google.protobuf:protobuf-java from 4.28.2 to 4.28.3 by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1178](https://redirect.github.com/prometheus/client_java/pull/1178) - Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.8.0-alpha to 2.9.0-alpha by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1164](https://redirect.github.com/prometheus/client_java/pull/1164) - avoid ConcurrentModificationException by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1191](https://redirect.github.com/prometheus/client_java/pull/1191) - revert incompatible api change by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1192](https://redirect.github.com/prometheus/client_java/pull/1192) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.2...v1.3.3 ### [`v1.3.2`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.2) # What's Changed - Simple MetricsSnapshot performance change by [@dhoard](https://redirect.github.com/dhoard) in [https://github.com/prometheus/client_java/pull/963](https://redirect.github.com/prometheus/client_java/pull/963) - feat: add bearerToken builder to pushgateway exporter by [@FUSAKLA](https://redirect.github.com/FUSAKLA) in [https://github.com/prometheus/client_java/pull/968](https://redirect.github.com/prometheus/client_java/pull/968) - Fix UnknownDataPointSnapshot constructor by [@mimaison](https://redirect.github.com/mimaison) in [https://github.com/prometheus/client_jav
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908733212
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else {
rsp.add(STATUS, STATUS_FAILURE);
}
- log.info("Responding encryption state={} success={} for keyId={}",
- encryptionState, success, keyId);
- rsp.add(ENCRYPTION_STATE, encryptionState);
+ rsp.add(ENCRYPTION_STATE, state.value);
+ long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+ log.info("Responding encryption state={} success={} for keyId={}
timeMs={}",
+ state.value, success, keyId, timeMs);
}
}
+ private void distributeRequest(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId, long startTimeNs) {
+boolean success = false;
+String collectionName = null;
+State collectionState = null;
+long timeAllowedMs = req.getParams().getLong(TIME_ALLOWED, 0);
+long maxTimeNs = timeAllowedMs <= 0 ? Long.MAX_VALUE : startTimeNs +
timeAllowedMs;
+try {
+ collectionName = req.getCore().getCoreDescriptor().getCollectionName();
+ if (collectionName == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " can only be used in Solr Cloud mode.");
+ }
+ log.debug("Encrypt request distributed for keyId={} collection={}",
keyId, collectionName);
+ DocCollection docCollection =
req.getCore().getCoreContainer().getZkController().getZkStateReader().getCollection(collectionName);
+ if (docCollection == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " present but collection '" + collectionName + "' not
found.");
+ }
+ try (SolrClientHolder solrClient = getHttpSolrClient(req)) {
+ModifiableSolrParams params = createDistributedRequestParams(req, rsp,
keyId);
+for (Slice slice : docCollection.getActiveSlices()) {
+ if (isTimeout(maxTimeNs)) {
+log.warn("Timeout distributing encryption request for keyId={}
collection={}", keyId, collectionName);
+if (collectionState == null || State.TIMEOUT.priority >
collectionState.priority) {
+ collectionState = State.TIMEOUT;
+}
+break;
+ }
+ Replica replica = slice.getLeader();
+ if (replica == null) {
+log.error("No leader found for shard {}", slice.getName());
+collectionState = State.ERROR;
+continue;
+ }
+ State state = sendEncryptionRequestWithRetry(replica, params,
solrClient.getClient(), keyId, collectionName);
+ if (collectionState == null || state.priority >
collectionState.priority) {
+collectionState = state;
+ }
+}
+success = collectionState == null || collectionState.isSuccess();
+ }
+} finally {
+ if (success) {
+rsp.add(STATUS, STATUS_SUCCESS);
+ } else {
+rsp.add(STATUS, STATUS_FAILURE);
+ }
+ if (collectionState != null) {
+rsp.add(ENCRYPTION_STATE, collectionState.value);
+ }
+ if (log.isInfoEnabled()) {
Review Comment:
I added this check to not call System.nanoTime() if info is not enabled. Do
you mean it is not worth the check and call nanoTime() every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]
bruno-roustant commented on code in PR #115:
URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1908737059
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##
@@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
} else {
rsp.add(STATUS, STATUS_FAILURE);
}
- log.info("Responding encryption state={} success={} for keyId={}",
- encryptionState, success, keyId);
- rsp.add(ENCRYPTION_STATE, encryptionState);
+ rsp.add(ENCRYPTION_STATE, state.value);
+ long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+ log.info("Responding encryption state={} success={} for keyId={}
timeMs={}",
+ state.value, success, keyId, timeMs);
}
}
+ private void distributeRequest(SolrQueryRequest req, SolrQueryResponse rsp,
String keyId, long startTimeNs) {
+boolean success = false;
+String collectionName = null;
+State collectionState = null;
+long timeAllowedMs = req.getParams().getLong(TIME_ALLOWED, 0);
+long maxTimeNs = timeAllowedMs <= 0 ? Long.MAX_VALUE : startTimeNs +
timeAllowedMs;
+try {
+ collectionName = req.getCore().getCoreDescriptor().getCollectionName();
+ if (collectionName == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " can only be used in Solr Cloud mode.");
+ }
+ log.debug("Encrypt request distributed for keyId={} collection={}",
keyId, collectionName);
+ DocCollection docCollection =
req.getCore().getCoreContainer().getZkController().getZkStateReader().getCollection(collectionName);
+ if (docCollection == null) {
+throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Parameter " + DISTRIB + " present but collection '" + collectionName + "' not
found.");
+ }
+ try (SolrClientHolder solrClient = getHttpSolrClient(req)) {
+ModifiableSolrParams params = createDistributedRequestParams(req, rsp,
keyId);
+for (Slice slice : docCollection.getActiveSlices()) {
+ if (isTimeout(maxTimeNs)) {
+log.warn("Timeout distributing encryption request for keyId={}
collection={}", keyId, collectionName);
+if (collectionState == null || State.TIMEOUT.priority >
collectionState.priority) {
+ collectionState = State.TIMEOUT;
+}
+break;
+ }
+ Replica replica = slice.getLeader();
+ if (replica == null) {
+log.error("No leader found for shard {}", slice.getName());
+collectionState = State.ERROR;
+continue;
+ }
+ State state = sendEncryptionRequestWithRetry(replica, params,
solrClient.getClient(), keyId, collectionName);
+ if (collectionState == null || state.priority >
collectionState.priority) {
+collectionState = state;
+ }
+}
+success = collectionState == null || collectionState.isSuccess();
+ }
+} finally {
+ if (success) {
+rsp.add(STATUS, STATUS_SUCCESS);
+ } else {
+rsp.add(STATUS, STATUS_FAILURE);
+ }
+ if (collectionState != null) {
+rsp.add(ENCRYPTION_STATE, collectionState.value);
+ }
+ if (log.isInfoEnabled()) {
+long timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startTimeNs);
+log.info("Responding encryption distributed state={} success={} for
keyId={} collection={} timeMs={}",
Review Comment:
How MDC knows the collection if it is not passed to the inner
LBSolrClient.request by the CloudSolrClient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]
dsmiley commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2580373844 If you haven't started; I will. It's just slightly more work in my IDE as I'm set up for the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency com.lmax:disruptor to v4 [solr]
solrbot opened a new pull request, #3008: URL: https://github.com/apache/solr/pull/3008 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.lmax:disruptor](https://lmax-exchange.github.io/disruptor) ([source](https://redirect.github.com/LMAX-Exchange/disruptor)) | dependencies | major | `3.4.4` -> `4.0.0` | --- ### Release Notes LMAX-Exchange/disruptor (com.lmax:disruptor) ### [`v4.0.0`](https://redirect.github.com/LMAX-Exchange/disruptor/releases/tag/4.0.0) [Compare Source](https://redirect.github.com/LMAX-Exchange/disruptor/compare/3.4.4...4.0.0) - Minimum Java version now 11 - Issue [#323](https://redirect.github.com/LMAX-Exchange/disruptor/issues/323) - `WorkerPool` and `WorkProcessor` have been removed, no more `Disruptor::handleEventsWithWorkerPool` - `Disruptor` constructors using `Executor` have been removed. Use `ThreadFactory` instead. - Rolled up event handling extension interfaces on to `EventHandler`: - `BatchStartAware` - `LifecycleAware` - `SequenceReportingEventHandler` - `FatalExceptionHandler` and `IgnoreExceptionHandler` now use the JDK 9 Platform Logging API, i.e. `System.Logger` - Add rewind batch feature to the `BatchEventProcessor` - Add a maximum batch size argument to `BatchEventProcessor` - `EventHandler::onBatchStart` now gets both the `batchSize` as well as `queueDepth` (previously it had `batchSize` which reported queue depth) - Added documentation to `EventPoller` - `Util::log2` throws if passed a non-positive argument - Deprecations - Deprecated `ThreadHints.onSpinWait()` - Deprecated `Disruptor.handleExceptionsWith()` - this had been javadoc deprecated since 2015 but not in the code - Removed previously deprecated methods - `Ringbuffer.resetTo()` - `ConsumerRepository.getLastSequenceInChain()` --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency com.nimbusds:nimbus-jose-jwt to v10 [solr]
solrbot opened a new pull request, #3009: URL: https://github.com/apache/solr/pull/3009 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) | dependencies | major | `9.30.2` -> `10.0.1` | --- ### Release Notes connect2id/nimbus-jose-jwt (com.nimbusds:nimbus-jose-jwt) ### [`v10.0.1`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1%0D10.0) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1%0D10.0) ### [`v10.0`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0%0D9.48) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0%0D9.48) ### [`v9.48`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.48%0D9.47) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.48%0D9.47) ### [`v9.47`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.47%0D9.46) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.47%0D9.46) ### [`v9.46`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.46%0D9.45) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.46%0D9.45) ### [`v9.45`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.45%0D9.44) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.45%0D9.44) ### [`v9.44`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.44%0D9.43) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.44%0D9.43) ### [`v9.43`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.43%0D9.42) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.43%0D9.42) ### [`v9.41.1`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.41.1%0D9.41) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.41.1%0D9.41) ### [`v9.41`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.41%0D9.40) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.41%0D9.40) ### [`v9.40`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.40%0D9.39.3) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.40%0D9.39.3) ### [`v9.39.3`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.3%0D9.39.2) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.3%0D9.39.2) ### [`v9.39.2`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.2%0D9.39.1) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.2%0D9.39.1) ### [`v9.39.1`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.1%0D9.39) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39.1%0D9.39) ### [`v9.39`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39%0D9.38) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.39%0D9.38) ### [`v9.38`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.38%0D9.37.3) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.38%0D9.37.3) ### [`v9.37.3`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.3%0D9.37.2) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.3%0D9.37.2) ### [`v9.37.2`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2%0D9.37.1) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2%0D9.37.1) ### [`v9.37.1`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.1%0D9.37) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.1%0D9.37) ### [`v9.37`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37%0D9.36) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37%0D9.36) ### [`v9.36`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.36%0D9.35) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.36%0D9.35) ### [`v9.35`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.35%0D9.34) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branche
Re: [I] Ability to mount EFS volume on solr pods [solr-operator]
HoustonPutman closed issue #742: Ability to mount EFS volume on solr pods URL: https://github.com/apache/solr-operator/issues/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v4 [solr]
solrbot opened a new pull request, #3011: URL: https://github.com/apache/solr/pull/3011 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jakarta.ws.rs:jakarta.ws.rs-api](https://redirect.github.com/jakartaee/rest) | dependencies | major | `3.1.0` -> `4.0.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency jakarta.annotation:jakarta.annotation-api to v3 [solr]
solrbot opened a new pull request, #3010: URL: https://github.com/apache/solr/pull/3010 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jakarta.annotation:jakarta.annotation-api](https://projects.eclipse.org/projects/ee4j.ca) ([source](https://redirect.github.com/jakartaee/common-annotations-api)) | dependencies | major | `2.1.1` -> `3.0.0` | --- ### Release Notes jakartaee/common-annotations-api (jakarta.annotation:jakarta.annotation-api) ### [`v3.0.0`](https://redirect.github.com/jakartaee/common-annotations-api/compare/2.1.1...3.0.0) [Compare Source](https://redirect.github.com/jakartaee/common-annotations-api/compare/2.1.1...3.0.0) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency com.ibm.icu:icu4j to v76 [solr]
solrbot opened a new pull request, #3007: URL: https://github.com/apache/solr/pull/3007 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.ibm.icu:icu4j](https://icu.unicode.org/) ([source](https://redirect.github.com/unicode-org/icu)) | dependencies | major | `74.2` -> `76.1` | --- ### Release Notes unicode-org/icu (com.ibm.icu:icu4j) ### [`v76.1`](https://redirect.github.com/unicode-org/icu/compare/release-75-1...release-76-1) [Compare Source](https://redirect.github.com/unicode-org/icu/compare/release-75-1...release-76-1) ### [`v75.1`](https://redirect.github.com/unicode-org/icu/compare/release-74-2...release-75-1) [Compare Source](https://redirect.github.com/unicode-org/icu/compare/release-74-2...release-75-1) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Allow users to configure Solr container's SecurityContext [solr-operator]
HoustonPutman commented on code in PR #743:
URL: https://github.com/apache/solr-operator/pull/743#discussion_r1909174239
##
controllers/solrcloud_controller_test.go:
##
@@ -38,6 +39,11 @@ func newBoolPtr(value bool) *bool {
return &newBool
}
+func newIntPtr(value int64) *int64 {
Review Comment:
You should be able to use `pointer.Int64(...)` for this. (The pointer
library being "k8s.io/utils/pointer")
##
controllers/solrcloud_controller_test.go:
##
@@ -38,6 +39,11 @@ func newBoolPtr(value bool) *bool {
return &newBool
}
+func newIntPtr(value int64) *int64 {
Review Comment:
I see the I probably added the methods above that do the same thing. So we
can always go and remove them independently, but let's not add another one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17615) facets exclusion does not exclude dense vector search prefilters
[
https://issues.apache.org/jira/browse/SOLR-17615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911394#comment-17911394
]
Alessandro Benedetti commented on SOLR-17615:
-
I was thinking more on this issue, can't you just use the excludeTags parameter
of knn query parser?
I think this is exactly the use case it was designed for (isn't this right
[~hossman])
I'm probably missing your point on why that's not useful.
https://solr.apache.org/guide/solr/latest/query-guide/dense-vector-search.html#implicit-pre-filtering
excludeTags
Optional
Default: none
Indicates that fq filters with the specified tag should be excluded from
consideration for implicit Pre-Filtering. Must not be combined with preFilter.
> facets exclusion does not exclude dense vector search prefilters
>
>
> Key: SOLR-17615
> URL: https://issues.apache.org/jira/browse/SOLR-17615
> Project: Solr
> Issue Type: Bug
> Components: faceting
>Reporter: Yue Yu
>Priority: Major
>
> Vector search adds all fqs as implicit pre-filters by default:
> [https://solr.apache.org/guide/solr/latest/query-guide/dense-vector-search.html#implicit-pre-filtering]
> for example:
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true {code}
> where both "category" and "instock" fq are added as the main knn query's
> pre-filters.
>
> However, for the facet multi-select use case, we want to exclude these fqs in
> the facet request so that the facet shows other values
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true
> &facet.field={!ex="category" key="category"}category
> &facet.field={!ex="instock" key="instock"}inStock{code}
> This is done by
> [SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
> who recalculates the DocSet using the main query and all fqs except the
> excluded one:
> {code:java}
>for (String excludeTag : excludeTagList) {
> Object olst = tagMap.get(excludeTag);
> // tagMap has entries of List>, but subject to
> change in the future
> if (!(olst instanceof Collection)) continue;
> for (Object o : (Collection) olst) {
> if (!(o instanceof QParser qp)) continue;
> excludeSet.put(qp.getQuery(), Boolean.TRUE);
> }
> }
> if (excludeSet.size() == 0) return baseDocSet;
>
> List qlist = new ArrayList<>();
> // add the base query
> if (!excludeSet.containsKey(rb.getQuery())) {
> qlist.add(rb.getQuery());
> }
> // add the filters
> if (rb.getFilters() != null) {
> for (Query q : rb.getFilters()) {
> if (!excludeSet.containsKey(q)) {
> qlist.add(q);
> }
> }
> }
> // get the new base docset for this facet
> DocSet base = searcher.getDocSet(qlist); {code}
> This works fine for non-knn main queries as they don't have any pre-filters.
> For knn main queries, the base query *rb.getQuery()* added to the *qlist*
> contains all the fqs as pre-filters, so this facet exclusion logic has no
> effect.
>
> In the example above, the facet values for "category" will only have AAA and
> "instock" will only have inStock.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] Ability to mount EFS volume on solr pods [solr-operator]
Joshuaariolu commented on issue #742: URL: https://github.com/apache/solr-operator/issues/742#issuecomment-2580168024 Thanks @HoustonPutman works perfectly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Fix rarely flaky DeleteInactiveReplicaTest. [solr]
psalagnac opened a new pull request, #3012: URL: https://github.com/apache/solr/pull/3012 # Description The test was retrieving a replica from cluster state using core name instead of correct replica name. The test is rarely failing because of this, it may happen. # Solution Fix the test, just replace `getCoreName()` by `getName()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17615) facets exclusion does not exclude dense vector search prefilters
[
https://issues.apache.org/jira/browse/SOLR-17615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911626#comment-17911626
]
Alessandro Benedetti commented on SOLR-17615:
-
I linked the specific documentation in the original solr-user mail thread that
precedes this issue creation.
[~yy147379138] can you tell us what's missing in the feature/documentation?
We'll be happy to think more about this!
> facets exclusion does not exclude dense vector search prefilters
>
>
> Key: SOLR-17615
> URL: https://issues.apache.org/jira/browse/SOLR-17615
> Project: Solr
> Issue Type: Bug
> Components: faceting
>Reporter: Yue Yu
>Priority: Major
>
> Vector search adds all fqs as implicit pre-filters by default:
> [https://solr.apache.org/guide/solr/latest/query-guide/dense-vector-search.html#implicit-pre-filtering]
> for example:
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true {code}
> where both "category" and "instock" fq are added as the main knn query's
> pre-filters.
>
> However, for the facet multi-select use case, we want to exclude these fqs in
> the facet request so that the facet shows other values
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true
> &facet.field={!ex="category" key="category"}category
> &facet.field={!ex="instock" key="instock"}inStock{code}
> This is done by
> [SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
> who recalculates the DocSet using the main query and all fqs except the
> excluded one:
> {code:java}
>for (String excludeTag : excludeTagList) {
> Object olst = tagMap.get(excludeTag);
> // tagMap has entries of List>, but subject to
> change in the future
> if (!(olst instanceof Collection)) continue;
> for (Object o : (Collection) olst) {
> if (!(o instanceof QParser qp)) continue;
> excludeSet.put(qp.getQuery(), Boolean.TRUE);
> }
> }
> if (excludeSet.size() == 0) return baseDocSet;
>
> List qlist = new ArrayList<>();
> // add the base query
> if (!excludeSet.containsKey(rb.getQuery())) {
> qlist.add(rb.getQuery());
> }
> // add the filters
> if (rb.getFilters() != null) {
> for (Query q : rb.getFilters()) {
> if (!excludeSet.containsKey(q)) {
> qlist.add(q);
> }
> }
> }
> // get the new base docset for this facet
> DocSet base = searcher.getDocSet(qlist); {code}
> This works fine for non-knn main queries as they don't have any pre-filters.
> For knn main queries, the base query *rb.getQuery()* added to the *qlist*
> contains all the fqs as pre-filters, so this facet exclusion logic has no
> effect.
>
> In the example above, the facet values for "category" will only have AAA and
> "instock" will only have inStock.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2581070892 > Overall this makes sense to me. Thanks for the nice contribution! I'd prefer if @gus-asf could take a look at some aspects since he worked on cpuAllowed recently. BTW it's clear you need to run `./gradlew tidy` Addressed. > > I suggest renaming the param "maxHitsPerShard" to simply "maxHits" or "maxHitsTerminateEarly" and document that it's per-shard and best-effort; that more hits may ultimately be detected in aggregate. But maybe others disagree. > Renamed to maxHits > It'd be good to consider interference with other features. Maybe it works with cursorMark? Does it count _after_ PostFilter (e.g. CollapseQParser) or before? Sorry, I am not aware of cursorMark. This will count while the collector runs over the posting list so it is not a post filter. Not sure if I understood your question correctly, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17587) Prometheus Writer duplicate TYPE information in exposition format
[
https://issues.apache.org/jira/browse/SOLR-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911637#comment-17911637
]
ASF subversion and git services commented on SOLR-17587:
Commit 13ba24eab0eec81cb7e6d99961da1144a4a0c44e in solr's branch
refs/heads/branch_9x from Matthew Biscocho
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=13ba24eab0e ]
SOLR-17587: wt=prometheus fix duplicate TYPE information (#3006)
Metrics: Prometheus response writer fix for non-compliant exposition format
containing duplicate TYPE lines
9x backport of main:
* SOLR-17587: wt=prometheus fix duplicate TYPE information (#2902)
> Prometheus Writer duplicate TYPE information in exposition format
> -
>
> Key: SOLR-17587
> URL: https://issues.apache.org/jira/browse/SOLR-17587
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.7
>Reporter: Matthew Biscocho
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Solr's Prometheus writer duplicates `# TYPE type>` in it's exposition format for core registry metrics.
> For example this appears twice in it's output:
> {code:java}
> # TYPE solr_metrics_core_average_request_time gauge
> solr_metrics_core_average_request_time{category="ADMIN",collection="foo",core="core_foo_shard9_replica_t351",handler="/admin/file",replica="replica_t351",shard="shard9"}
> 0.0
> ...
> # TYPE solr_metrics_core_average_request_time gauge{code}
> This is technically not allowed per [Prometheus Exposition
> format|https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#:~:text=Only%20one%20TYPE%20line%20may%20exist%20for%20a%20given%20metric%20name.]
> This happens because each Dropwizard registry is per core, but for Prometheus
> compatible exposition format upon exporting, it needs to be 1 registry for
> all cores on a single host, otherwise there will be duplicate `TYPE` formats
> even though all metrics are unique for its tags/attributes.
> Funnily enough, prometheus upstream collector does not do this verification
> and accepts the metrics anyways just fine Solr -> Prometheus -> Grafana.
> But depending on the technologies prometheus exposition verification, this
> will fail. For example
> [Telegraf|https://github.com/influxdata/telegraf/blob/master/plugins/inputs/prometheus/README.md]:
> {code:java}
> -12-09T16:56:01Z E! [inputs.prometheus] Error in plugin: error reading
> metrics for "http://127.0.0.1:8983/solr/admin/metrics?wt=prometheus":
> decoding response failed: text format parsing error in line 568: second TYPE
> line for metric name "solr_metrics_core_average_request_time", or TYPE
> reported after samples {code}
> This shouldn't be a blocker if you are pushing metrics to prometheus
> collector directly.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] reusing empty NamedList rather than recreating a new empty NamedList … [solr]
dsmiley commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909380627
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +70,8 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return new SimpleOrderedMap<>(newList);
}
+
+ public static SimpleOrderedMap emptySimpleOrderedMap() {
Review Comment:
Using `of` opens the door for some more static methods for more, which you
could add now if it makes `of` more attractive to you. Just a single pair
would be fine and perhaps useful. I look to the JDK for inspiration on data
structure conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17615) facets exclusion does not exclude dense vector search prefilters
[
https://issues.apache.org/jira/browse/SOLR-17615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911641#comment-17911641
]
Yue Yu commented on SOLR-17615:
---
[~abenedetti] [~hossman] Thanks for the respond.
Yes I'm aware the {{excludeTags}} support was added to the {{knn}} Qparser. And
currently it's the workaround to get facet exclusion to work with vector search
query.
However I'd say it's a tradeoff where we'll lose all the benefit of adding fqs
as knn query's prefilter, especially for the vector search recall when topk is
small and several fqs are added as post-filters.
Would it be fair to say that "as of now, there is a limitation that for facet
exclusion to work with knn query, ALL fqs to be excluded by the facet request
MUST ALSO be excluded from the knn query's pre-filters" ? I'm wondering could
we fix the facet exclusion logic in
[SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
so that we can remove this limitation?
Looking at the computeDocSet function in
[SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
, the logic was working perfectly fine until some special Query (knn query)
comes with pre-filters. It feels natural to update this function's logic to
accommodate Query with pre-filters.
The fix seems not trivial. We can use the similar idea in computeDocSet
function to reconstruct and update knn query's pre-filters, but the challenging
part is how to find all the knn queries in the base query {*}rb.getQuery(){*}.
Anyway if you guys think this is worth fixing, we can discuss further.
> facets exclusion does not exclude dense vector search prefilters
>
>
> Key: SOLR-17615
> URL: https://issues.apache.org/jira/browse/SOLR-17615
> Project: Solr
> Issue Type: Bug
> Components: faceting
>Reporter: Yue Yu
>Priority: Major
>
> Vector search adds all fqs as implicit pre-filters by default:
> [https://solr.apache.org/guide/solr/latest/query-guide/dense-vector-search.html#implicit-pre-filtering]
> for example:
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true {code}
> where both "category" and "instock" fq are added as the main knn query's
> pre-filters.
>
> However, for the facet multi-select use case, we want to exclude these fqs in
> the facet request so that the facet shows other values
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true
> &facet.field={!ex="category" key="category"}category
> &facet.field={!ex="instock" key="instock"}inStock{code}
> This is done by
> [SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
> who recalculates the DocSet using the main query and all fqs except the
> excluded one:
> {code:java}
>for (String excludeTag : excludeTagList) {
> Object olst = tagMap.get(excludeTag);
> // tagMap has entries of List>, but subject to
> change in the future
> if (!(olst instanceof Collection)) continue;
> for (Object o : (Collection) olst) {
> if (!(o instanceof QParser qp)) continue;
> excludeSet.put(qp.getQuery(), Boolean.TRUE);
> }
> }
> if (excludeSet.size() == 0) return baseDocSet;
>
> List qlist = new ArrayList<>();
> // add the base query
> if (!excludeSet.containsKey(rb.getQuery())) {
> qlist.add(rb.getQuery());
> }
> // add the filters
> if (rb.getFilters() != null) {
> for (Query q : rb.getFilters()) {
> if (!excludeSet.containsKey(q)) {
> qlist.add(q);
> }
> }
> }
> // get the new base docset for this facet
> DocSet base = searcher.getDocSet(qlist); {code}
> This works fine for non-knn main queries as they don't have any pre-filters.
> For knn main queries, the base query *rb.getQuery()* added to the *qlist*
> contains all the fqs as pre-filters, so this facet exclusion logic has no
> effect.
>
> In the example above, the facet values for "category" will only have AAA and
> "instock" will only have inStock.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency net.ltgt.errorprone to v4 [solr]
solrbot commented on PR #3013: URL: https://github.com/apache/solr/pull/3013#issuecomment-2581192825 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks net.ltgt.errorprone:net.ltgt.errorprone.gradle.plugin FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock
[PR] Update dependency net.ltgt.errorprone to v4 [solr]
solrbot opened a new pull request, #3013: URL: https://github.com/apache/solr/pull/3013 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | net.ltgt.errorprone | plugin | major | `3.1.0` -> `4.1.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency net.thisptr:jackson-jq to v1 [solr]
solrbot commented on PR #3014: URL: https://github.com/apache/solr/pull/3014#issuecomment-2581195634 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks net.thisptr:jackson-jq FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is n
[PR] Update dependency net.thisptr:jackson-jq to v1 [solr]
solrbot opened a new pull request, #3014: URL: https://github.com/apache/solr/pull/3014 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [net.thisptr:jackson-jq](https://redirect.github.com/eiiches/jackson-jq) ([source](https://redirect.github.com/juven/git-demo)) | dependencies | major | `0.0.13` -> `1.2.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency no.nav.security:mock-oauth2-server to v2 [solr]
solrbot opened a new pull request, #3015:
URL: https://github.com/apache/solr/pull/3015
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[no.nav.security:mock-oauth2-server](https://redirect.github.com/navikt/mock-oauth2-server)
| dependencies | major | `0.5.10` -> `2.1.10` |
---
### Release Notes
navikt/mock-oauth2-server
(no.nav.security:mock-oauth2-server)
###
[`v2.1.10`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.10)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.9...2.1.10)
What's Changed
- fix(logback): set logback severity back to INFO
([#753](https://redirect.github.com/navikt/mock-oauth2-server/issues/753))
[@jenspav](https://redirect.github.com/jenspav)
- fix(readme): replace scope with code
([#754](https://redirect.github.com/navikt/mock-oauth2-server/issues/754))
[@jenspav](https://redirect.github.com/jenspav)
- feat: support custom TimeProvider when validating tokens (introspect,
userinfo)
([#730](https://redirect.github.com/navikt/mock-oauth2-server/issues/730))
[@tommytroen](https://redirect.github.com/tommytroen)
⬆️ Dependency upgrades
- chore(deps): bump the github group with 7 updates
([#734](https://redirect.github.com/navikt/mock-oauth2-server/issues/734))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump the github group across 1 directory with 2 updates
([#733](https://redirect.github.com/navikt/mock-oauth2-server/issues/733))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.9`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.9)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.8...2.1.9)
What's Changed
- chore(build): netty-all with netty-codec-http
([#723](https://redirect.github.com/navikt/mock-oauth2-server/issues/723))
[@ybelMekk](https://redirect.github.com/ybelMekk)
- Fix/704 response types
([#710](https://redirect.github.com/navikt/mock-oauth2-server/issues/710))
[@pniederlag](https://redirect.github.com/pniederlag)
⬆️ Dependency upgrades
- chore(deps): bump the github group across 1 directory with 5 updates
([#726](https://redirect.github.com/navikt/mock-oauth2-server/issues/726))
[@dependabot](https://redirect.github.com/dependabot)
- chore: bumped gradle wrapper to 8.9
([#724](https://redirect.github.com/navikt/mock-oauth2-server/issues/724))
[@MikAoJk](https://redirect.github.com/MikAoJk)
- chore(deps): bump the github group across 1 directory with 17 updates
([#722](https://redirect.github.com/navikt/mock-oauth2-server/issues/722))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump the github group across 1 directory with 2 updates
([#715](https://redirect.github.com/navikt/mock-oauth2-server/issues/715))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.8`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.8)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.7...2.1.8)
What's Changed
🐛 Bug Fixes
- fix: extend wellknown return values
([#704](https://redirect.github.com/navikt/mock-oauth2-server/issues/704))
([#706](https://redirect.github.com/navikt/mock-oauth2-server/issues/706))
[@pniederlag](https://redirect.github.com/pniederlag)
⬆️ Dependency upgrades
- chore(deps): bump the github group across 1 directory with 20 updates
([#709](https://redirect.github.com/navikt/mock-oauth2-server/issues/709))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump org.jetbrains.kotlinx:kotlinx-serialization-json from
1.6.3 to 1.7.0 in the github group
([#702](https://redirect.github.com/navikt/mock-oauth2-server/issues/702))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.7`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.7)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.6...2.1.7)
What's Changed
🚀 Features
- feat: support objects and lists in request mapping claims
([#699](https://redirect.github.com/navikt/mock-oauth2-server/issues/699))
[@tommytroen](https://redirect.github.com/tommytroen)
###
[`v2.1.6`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.6)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.5...2.1.6)
What's Changed
-
[#691](https://redirect.github.com/navikt/mock-oauth2-server/issues/691)
`OAuth2TokenProvider` should allow dynamic `systemTime`
([#693](https://redirect.github.com/navikt/mock-oauth2-ser
Re: [PR] Update dependency no.nav.security:mock-oauth2-server to v2 [solr]
solrbot commented on PR #3015: URL: https://github.com/apache/solr/pull/3015#issuecomment-2581198679 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks no.nav.security:mock-oauth2-server FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks'
Re: [PR] Update dependency org.apache.opennlp:opennlp-tools to v2 [solr]
solrbot commented on PR #3016: URL: https://github.com/apache/solr/pull/3016#issuecomment-2581201944 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.apache.opennlp:opennlp-tools FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' a
[PR] Update dependency org.apache.opennlp:opennlp-tools to v2 [solr]
solrbot opened a new pull request, #3016: URL: https://github.com/apache/solr/pull/3016 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.opennlp:opennlp-tools](https://www.apache.org/) ([source](https://redirect.github.com/apache/opennlp)) | dependencies | major | `1.9.4` -> `2.5.2` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17615) facets exclusion does not exclude dense vector search prefilters
[
https://issues.apache.org/jira/browse/SOLR-17615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911620#comment-17911620
]
Chris M. Hostetter commented on SOLR-17615:
---
Yup, facet drill downs are exactly why {{excludeTags}} support was added to the
{{knn}} Qparser
We even have a nice test specifically of multi-select facet usecases...
[https://github.com/apache/solr/blob/80dfe11fe4c8f123f56ec2f85870d12b7e086e9e/solr/core/src/test/org/apache/solr/search/neural/KnnQParserTest.java#L831]
(perhaps the bug reporter just wasn't aware of it in recent solr versions?)
> facets exclusion does not exclude dense vector search prefilters
>
>
> Key: SOLR-17615
> URL: https://issues.apache.org/jira/browse/SOLR-17615
> Project: Solr
> Issue Type: Bug
> Components: faceting
>Reporter: Yue Yu
>Priority: Major
>
> Vector search adds all fqs as implicit pre-filters by default:
> [https://solr.apache.org/guide/solr/latest/query-guide/dense-vector-search.html#implicit-pre-filtering]
> for example:
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true {code}
> where both "category" and "instock" fq are added as the main knn query's
> pre-filters.
>
> However, for the facet multi-select use case, we want to exclude these fqs in
> the facet request so that the facet shows other values
> {code:java}
> ?q={!knn f=vector topK=10}[1.0, 2.0, 3.0, 4.0]
> &fq={!tag="category"}category:AAA
> &fq={!tag="instock"}inStock:true
> &facet.field={!ex="category" key="category"}category
> &facet.field={!ex="instock" key="instock"}inStock{code}
> This is done by
> [SimpleFacets.java|https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/request/SimpleFacets.java#L223]
> who recalculates the DocSet using the main query and all fqs except the
> excluded one:
> {code:java}
>for (String excludeTag : excludeTagList) {
> Object olst = tagMap.get(excludeTag);
> // tagMap has entries of List>, but subject to
> change in the future
> if (!(olst instanceof Collection)) continue;
> for (Object o : (Collection) olst) {
> if (!(o instanceof QParser qp)) continue;
> excludeSet.put(qp.getQuery(), Boolean.TRUE);
> }
> }
> if (excludeSet.size() == 0) return baseDocSet;
>
> List qlist = new ArrayList<>();
> // add the base query
> if (!excludeSet.containsKey(rb.getQuery())) {
> qlist.add(rb.getQuery());
> }
> // add the filters
> if (rb.getFilters() != null) {
> for (Query q : rb.getFilters()) {
> if (!excludeSet.containsKey(q)) {
> qlist.add(q);
> }
> }
> }
> // get the new base docset for this facet
> DocSet base = searcher.getDocSet(qlist); {code}
> This works fine for non-knn main queries as they don't have any pre-filters.
> For knn main queries, the base query *rb.getQuery()* added to the *qlist*
> contains all the fqs as pre-filters, so this facet exclusion logic has no
> effect.
>
> In the example above, the facet values for "category" will only have AAA and
> "instock" will only have inStock.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] reusing empty NamedList rather than recreating a new empty NamedList … [solr]
renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909314089
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -67,4 +70,8 @@ public SimpleOrderedMap clone() {
newList.addAll(nvPairs);
return new SimpleOrderedMap<>(newList);
}
+
+ public static SimpleOrderedMap emptySimpleOrderedMap() {
Review Comment:
The method name of() is implying, at least to me, that something can be
passed in and and creates something else out of it. Like when you do
List.of("String"). Maybe empty() would be the better option. What do you thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] reusing empty NamedList rather than recreating a new empty NamedList … [solr]
renatoh commented on code in PR #2932:
URL: https://github.com/apache/solr/pull/2932#discussion_r1909315295
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -34,6 +35,8 @@
* serialized. It aims to minimize overhead and to be efficient at adding new
elements.
*/
public class SimpleOrderedMap extends NamedList {
+
+ private static final SimpleOrderedMap emptySimpleOrderedMap = new
SimpleOrderedMap<>(Collections.emptyList());
Review Comment:
" and doesn't import another class." Never thought of that advantages of
List.of over Collections.empty(). Good point, will adjust it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17587: (9x backport) wt=prometheus fix duplicate TYPE information [solr]
dsmiley merged PR #3006: URL: https://github.com/apache/solr/pull/3006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency org.eclipse.jgit:org.eclipse.jgit to v7 [solr]
solrbot commented on PR #3017: URL: https://github.com/apache/solr/pull/3017#issuecomment-2581205123 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.eclipse.jgit:org.eclipse.jgit FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks
[PR] Update dependency org.eclipse.jgit:org.eclipse.jgit to v7 [solr]
solrbot opened a new pull request, #3017: URL: https://github.com/apache/solr/pull/3017 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jgit:org.eclipse.jgit](https://eclipse.gerrithub.io/plugins/gitiles/eclipse-jgit/jgit) | dependencies | major | `6.7.0.202309050840-r` -> `7.1.0.202411261347-r` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Update dependency org.glassfish.jaxb:jaxb-runtime to v4 [solr]
solrbot opened a new pull request, #3018: URL: https://github.com/apache/solr/pull/3018 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jaxb:jaxb-runtime](https://eclipse-ee4j.github.io/jaxb-ri/) ([source](https://redirect.github.com/eclipse-ee4j/jaxb-ri)) | dependencies | major | `2.3.8` -> `4.0.5` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency org.glassfish.jaxb:jaxb-runtime to v4 [solr]
solrbot commented on PR #3018: URL: https://github.com/apache/solr/pull/3018#issuecomment-2581208169 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.glassfish.jaxb:jaxb-runtime FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks'
[PR] Update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v3 [solr]
solrbot opened a new pull request, #3019: URL: https://github.com/apache/solr/pull/3019 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jersey.containers:jersey-container-jetty-http](https://projects.eclipse.org/projects/ee4j.jersey) ([source](https://redirect.github.com/eclipse-ee4j/jersey)) | dependencies | major | `2.39.1` -> `3.1.10` | --- ### Release Notes eclipse-ee4j/jersey (org.glassfish.jersey.containers:jersey-container-jetty-http) ### [`v3.1.10`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/3.1.10) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/3.1.9...3.1.10) # What's Changed - Keep only 2 builds with artifacts and disable concurrent builds by [@fredg02](https://redirect.github.com/fredg02) in [https://github.com/eclipse-ee4j/jersey/pull/5752](https://redirect.github.com/eclipse-ee4j/jersey/pull/5752) - test(flaky): fix paramter type assert in testBothAnnotatedConstructor test case by [@varsha-cl](https://redirect.github.com/varsha-cl) in [https://github.com/eclipse-ee4j/jersey/pull/5751](https://redirect.github.com/eclipse-ee4j/jersey/pull/5751) - test(flaky): Sorting headers for deterministic order by [@mumbler6](https://redirect.github.com/mumbler6) in [https://github.com/eclipse-ee4j/jersey/pull/5754](https://redirect.github.com/eclipse-ee4j/jersey/pull/5754) - Netty connector hang up after repeated buffer overflow errors when writing data [#5753](https://redirect.github.com/eclipse-ee4j/jersey/issues/5753) by [@jbescos](https://redirect.github.com/jbescos) in [https://github.com/eclipse-ee4j/jersey/pull/5755](https://redirect.github.com/eclipse-ee4j/jersey/pull/5755) - Adopt ASM 9.7.1 (JDK 24) by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5760](https://redirect.github.com/eclipse-ee4j/jersey/pull/5760) - Bump commons-io:commons-io from 2.11.0 to 2.14.0 in /tools/jersey-release-notes-maven-plugin by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/eclipse-ee4j/jersey/pull/5758](https://redirect.github.com/eclipse-ee4j/jersey/pull/5758) - Added test for JerseyChunkedInputStreamClose by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5759](https://redirect.github.com/eclipse-ee4j/jersey/pull/5759) - Adopt Jackson 2.18.0 by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5761](https://redirect.github.com/eclipse-ee4j/jersey/pull/5761) - merge of the actual 2.x into the 3.0 by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5762](https://redirect.github.com/eclipse-ee4j/jersey/pull/5762) - Technical merge of released branch 3.0.16-BRANCH by [@jersey-bot](https://redirect.github.com/jersey-bot) in [https://github.com/eclipse-ee4j/jersey/pull/5770](https://redirect.github.com/eclipse-ee4j/jersey/pull/5770) - merge of the actual 3.0 into the 3.1 by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5769](https://redirect.github.com/eclipse-ee4j/jersey/pull/5769) - Fix flaky 2 by [@mumbler6](https://redirect.github.com/mumbler6) in [https://github.com/eclipse-ee4j/jersey/pull/5775](https://redirect.github.com/eclipse-ee4j/jersey/pull/5775) - Technical merge of released branch 3.1.9-BRANCH by [@jersey-bot](https://redirect.github.com/jersey-bot) in [https://github.com/eclipse-ee4j/jersey/pull/5771](https://redirect.github.com/eclipse-ee4j/jersey/pull/5771) - Fixed typo: Class>?< should be Class\ by [@mkarg](https://redirect.github.com/mkarg) in [https://github.com/eclipse-ee4j/jersey/pull/5785](https://redirect.github.com/eclipse-ee4j/jersey/pull/5785) - Broken pipe Exception from Jersey layer while closing response in ServerRuntime.writeResponse() not handled or re-thrown [#5783](https://redirect.github.com/eclipse-ee4j/jersey/issues/5783) by [@jbescos](https://redirect.github.com/jbescos) in [https://github.com/eclipse-ee4j/jersey/pull/5786](https://redirect.github.com/eclipse-ee4j/jersey/pull/5786) - \[2.x] ParamConverterProvider constructors are now protected to allow extensibility by [@Spikhalskiy](https://redirect.github.com/Spikhalskiy) in [https://github.com/eclipse-ee4j/jersey/pull/5792](https://redirect.github.com/eclipse-ee4j/jersey/pull/5792) - Wrapping all methods of the EntityInputStream by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5788](https://redirect.github.com/eclipse-ee4j/jersey/pull/5788) - Jersey 3.1.9: java.lang.NoSuchMethodException: jakarta.inject.Inject.value() [#5782](https://redirect.github.com/eclipse-ee4j/jersey/is
Re: [PR] Update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v3 [solr]
solrbot commented on PR #3019: URL: https://github.com/apache/solr/pull/3019#issuecomment-2581211135 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: gradle/libs.versions.toml ``` Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules :ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.glassfish.jersey.containers:jersey-container-jetty-http FAILURE: Build failed with an exception. * What went wrong: Failed to notify task execution graph listener. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient. > Use the ':writeLocks' task to write the
