HoustonPutman commented on code in PR #743:
URL: https://github.com/apache/solr-operator/pull/743#discussion_r1909174239
##########
controllers/solrcloud_controller_test.go:
##########
@@ -38,6 +39,11 @@ func newBoolPtr(value bool) *bool {
return &newBool
}
+func newIntPtr(value int64) *int64 {
Review Comment:
You should be able to use `pointer.Int64(...)` for this. (The pointer
library being "k8s.io/utils/pointer")
##########
controllers/solrcloud_controller_test.go:
##########
@@ -38,6 +39,11 @@ func newBoolPtr(value bool) *bool {
return &newBool
}
+func newIntPtr(value int64) *int64 {
Review Comment:
I see the I probably added the methods above that do the same thing. So we
can always go and remove them independently, but let's not add another one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
