Re: [PR] User Behavior Insights implementation for Apache Solr [solr]
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2480693921 Making progressI've added some tasks to do, and then I think I'm going to flip it from Draft to Ready for Review and email the community. I'd like to demo it at a upcoming community meeting. BTW, UBI now has an actual website! https://www.ubisearch.dev/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]
dsmiley commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1845101285
##
settings.gradle:
##
@@ -48,6 +48,7 @@ include "solr:modules:hadoop-auth"
include "solr:modules:hdfs"
include "solr:modules:jwt-auth"
include "solr:modules:langid"
+include "solr:modules:llm"
Review Comment:
Is LLM the best name for this package? Will it expand to other LLM stuff?
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.llm.embedding;
+
+import dev.langchain4j.data.embedding.Embedding;
+import dev.langchain4j.model.embedding.EmbeddingModel;
+import java.lang.reflect.Method;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Map;
+import java.util.Objects;
+import org.apache.lucene.util.Accountable;
+import org.apache.lucene.util.RamUsageEstimator;
+import org.apache.solr.llm.store.EmbeddingModelException;
+
+public class SolrEmbeddingModel implements Accountable {
+ private static final long BASE_RAM_BYTES =
+ RamUsageEstimator.shallowSizeOfInstance(SolrEmbeddingModel.class);
+ private static final String TIMEOUT_PARAM = "timeout";
+ private static final String MAX_SEGMENTS_PER_BATCH_PARAM =
"maxSegmentsPerBatch";
+ private static final String MAX_RETRIES_PARAM = "maxRetries";
+
+ private final String name;
+ private final Map params;
+ private final EmbeddingModel embedder;
+ private final Integer hashCode;
+
+ public static SolrEmbeddingModel getInstance(
+ String className, String name, Map params) throws
EmbeddingModelException {
+try {
+ EmbeddingModel embedder;
+ Class modelClass = Class.forName(className);
+ var builder = modelClass.getMethod("builder").invoke(null);
+ if (params != null) {
+for (String paramName : params.keySet()) {
+ switch (paramName) {
+case TIMEOUT_PARAM:
+ Duration timeOut = Duration.ofSeconds((Long)
params.get(paramName));
+ builder.getClass().getMethod(paramName,
Duration.class).invoke(builder, timeOut);
+ break;
+case MAX_SEGMENTS_PER_BATCH_PARAM:
+ builder
+ .getClass()
+ .getMethod(paramName, Integer.class)
+ .invoke(builder, ((Long) params.get(paramName)).intValue());
+ break;
+case MAX_RETRIES_PARAM:
+ builder
+ .getClass()
+ .getMethod(paramName, Integer.class)
+ .invoke(builder, ((Long) params.get(paramName)).intValue());
+ break;
+default:
+ ArrayList methods = new ArrayList<>();
Review Comment:
a comment would be useful explaining
##
solr/modules/llm/src/java/org/apache/solr/llm/store/rest/ManagedEmbeddingModelStore.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.llm.store.rest;
+
+import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.util.NamedList;
+import org.apache.solr.core.SolrCore;
+import org.apache.solr.core.SolrResourceLoader;
+import org.apache.solr.llm.embedding.SolrEmbeddingMod
[jira] [Resolved] (SOLR-9615) NamedList:asMap method is no converted NamedList in List
[
https://issues.apache.org/jira/browse/SOLR-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-9615.
Resolution: Won't Fix
asMap without args is inherited via SimpleMap and that's going away in Solr 10.
Marking as Won't-Fix.
> NamedList:asMap method is no converted NamedList in List
>
>
> Key: SOLR-9615
> URL: https://issues.apache.org/jira/browse/SOLR-9615
> Project: Solr
> Issue Type: Bug
>Affects Versions: 5.5.1
>Reporter: HYUNCHANG LEE
>Priority: Major
>
> When a NamedList is organized as follows, the innermost NamedList is not
> converted into a map by calling the asMap() method of the outmost NamedList.
> {noformat}
> NamedList
> - List
>- NamedList
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]
dsmiley commented on code in PR #2856:
URL: https://github.com/apache/solr/pull/2856#discussion_r1839376359
##
solr/core/src/java/org/apache/solr/util/DataConfigNode.java:
##
@@ -54,31 +53,17 @@ public DataConfigNode(ConfigNode root) {
e.setValue(List.copyOf(e.getValue()));
}
}
-this.kids = kids.isEmpty() ? EMPTY : new
WrappedSimpleMap<>(Map.copyOf(kids));
+this.kids = Map.copyOf(kids);
}
- public String subtituteVal(String s) {
+ private static String substituteVal(String s) {
return PropertiesUtil.substitute(s, SUBSTITUTES.get());
Review Comment:
Okay; I'll file a pair of JIRA issues tomorrow if you don't first:
* Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign
* Rename NamedList.asMap to something like toMapRecursively
##
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##
@@ -167,10 +166,9 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
String coreRootDirectory; // usually same as solr home, but not always
-Map systemInfo =
-solrClient
-.request(new GenericSolrRequest(SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH))
-.asMap();
Review Comment:
needless asMap call. @epugh you added this code a year ago, maybe because
you don't like NamedList?
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -98,7 +98,7 @@ protected String callGet(String url, String credentials)
throws Exception {
NamedList response = solrClient.request(req);
// pretty-print the response to stdout
CharArr arr = new CharArr();
- new JSONWriter(arr, 2).write(response.asMap());
+ new JSONWriter(arr, 2).write(response.asShallowMap());
Review Comment:
I'll change this back with another or two. I now understand that asMap
recursively does Map conversion, which is required for JSON conversion which
doesn't know how to process a NamedList inside. Granted we could use Jackson
and register a converter but that's out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign
[ https://issues.apache.org/jira/browse/SOLR-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17566: Labels: newdev (was: ) > Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign > -- > > Key: SOLR-17566 > URL: https://issues.apache.org/jira/browse/SOLR-17566 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Minor > Labels: newdev > > The design of ConfigNode's substitution rules is really concerning. > Basically, the observed state of the ConfigNode might vary based on which > thread is looking at it! The use of a ThreadLocal named SUBSTITUTES should > be reconsidered. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign
David Smiley created SOLR-17566: --- Summary: Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign Key: SOLR-17566 URL: https://issues.apache.org/jira/browse/SOLR-17566 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Reporter: David Smiley The design of ConfigNode's substitution rules is really concerning. Basically, the observed state of the ConfigNode might vary based on which thread is looking at it! The use of a ThreadLocal named SUBSTITUTES should be reconsidered. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14680: Remove SimpleMap (affects NamedList) [solr]
dsmiley commented on PR #2856: URL: https://github.com/apache/solr/pull/2856#issuecomment-2480968084 If I should break this up, or file another JIRA, let me know. The SimpleMap part feels kind of separate, especially since it impacts the ubiquitous NamedList. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17566) Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign
[ https://issues.apache.org/jira/browse/SOLR-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17566: Affects Version/s: 8.8 > Replace ConfigNode.SUBSTITUTES (ThreadLocal); redesign > -- > > Key: SOLR-17566 > URL: https://issues.apache.org/jira/browse/SOLR-17566 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.8 >Reporter: David Smiley >Priority: Minor > Labels: newdev > > The design of ConfigNode's substitution rules is really concerning. > Basically, the observed state of the ConfigNode might vary based on which > thread is looking at it! The use of a ThreadLocal named SUBSTITUTES should > be reconsidered. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]
malliaridis commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480816742 > i expected the link to the /compose to work from old admin, but didn't see it... The old UI only links to the new UI if you go to "Java Properties". The idea is to have a button only in places where a migration in the new UI is available. The URL the new UI is running is right now `http://localhost:8983/solr/compose`. Alternatively you can always run `gradlew :solr:compose-ui:run` to launch the desktop client... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]
malliaridis commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2480818067 With `hadoop-auth` gone, we have only one more blocker (s3) before migrating to jetty12. :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Solr 12276 angularjs to angular migration [solr]
malliaridis commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2480897920 > > The current state of the PR seems to not integrate the Angular project into the current "deployment", resulting in CORS issues when running with `npm start`. Do you have any instructions on how to run it so that we can see the UI in action? > 3. That's correct, I didn't invest enough time to merge to two different approaches to work under same server, usually for that is responsible app server in our case, it must be done via web.xml + might be require additional filter or something changes in the java app itself to consume and work with two approaches. Thanks. So that would still be an open TODO in case we decide to proceed with this one. > > A short feedback about improving the quality of your PR: [...] > > Okay, I'll try to revert most of the changes related to the current solution back that it won't affect PR. This now way easier to review, thanks a lot. > > I would also like to have a documentation that provide resources for further reading or basic ideas behind things like project structure (of the frontend of course). I think this would give our current community an easier start for both reviewing and working with the code. > > Well, I'm not sure what do you mean under the documentation with this. If you're speaking about the documentation such as README file then I will add one how to start local environment, until we'll have complete integration with backend solution, it won't help. I hope I correctly understood you. Yes, what I (and probably others as well) would like to see is how it would integrate into the current project (which is as described above an open TODO), how someone would work and test the code base (like running the UI with `npm ng serve`), and where the webapp can be accessed / seen (like at `localhost:3000`). I believe the module's / angular project's README file is the best place to tell other developers how to get started with this sub-project. Angular already provides some basic information, this could be extended. > > Starting and testing the current UI seems also not to be working in this PR, which would be necessary for other reviewers to form an opinion. > > [...] > If you're speaking about the way how to start and poke review it. Then I do everything from `package.json` until we integrated it with current backend solution. I meant starting and poking around, yes. So there is no state yet that makes request to a Solr backend, is that correct? I think you removed a few too manyfiles in your latest updates. The environment files under `/src/environments` are missing and causing an error when launching the app with `ng serve`. And one last tip, it's fine and also recommended to include `package-lock.json` in the VCS, as it ensures reproducable states of the project. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16427) Evaluate and fix errorprone rules
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16427: -- Labels: pull-request-available (was: ) > Evaluate and fix errorprone rules > - > > Key: SOLR-16427 > URL: https://issues.apache.org/jira/browse/SOLR-16427 > Project: Solr > Issue Type: Task > Components: Build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Time Spent: 9h 40m > Remaining Estimate: 0h > > Errorprone has many rules and there are a bunch that are disabled in Solr. > Some make sense to leave disabled. Others are just disabled because they > weren't evaluated. > See > https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle > This was previously done for some rules in SOLR-15908 and SOLR-15613. This > relates to SOLR-16364 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-16427: Enable error-prone PatternMatchingInstanceof rule [solr]
malliaridis opened a new pull request, #2867: URL: https://github.com/apache/solr/pull/2867 https://issues.apache.org/jira/browse/SOLR-16427 # Description With the new errorprone rules and starting from 16+ we can use pattern-matching for `instanceof`. # Solution This PR enables `PatternMatchingInstanceof` and applies auto-refactoring from IntelliJ for pattern-matching cases. Note that **these changes are not backwards compatible** (branch_9x) as the refactored code makes use of a JDK 16 feature. # Tests No tests were added or removed. Tests with pattern-matching improvements were refactored accordingly. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Solr 12276 angularjs to angular migration [solr]
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1845274026
##
solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class DateConverter {
+ private static pattern: string = '/.* (?\d{4}-\d{2}-\d{2}) .*/';
Review Comment:
Makes sense and I agree with you here. We may consider not touching this
value though, as it is part of a "version code" that may be used in bug
reporting (date localization would not make much sense I think). But that is
only a minor opinionated "improvement". :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] forbidden-apis: Don't need java.solr.txt file [solr]
dsmiley commented on code in PR #2866:
URL: https://github.com/apache/solr/pull/2866#discussion_r1845189541
##
gradle/validation/forbidden-apis.gradle:
##
@@ -99,7 +99,6 @@ allprojects { prj ->
"**.SuppressForbidden"
]
- doFirst dynamicSignatures.curry(configurations.toolsCompileClasspath,
"lucene")
Review Comment:
I don't quite understand this line but the reference to "lucene" probably
matches nothing.
##
gradle/validation/forbidden-apis.gradle:
##
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
-// Configure solr-specific rules.
Review Comment:
the whole configuration overall is for Solr
##
gradle/validation/forbidden-apis.gradle:
##
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
-// Configure solr-specific rules.
-if (prj.path.startsWith(":solr")) {
- forbiddenApisMain {
-doFirst dynamicSignatures.curry(configurations.compileClasspath,
"solr")
-signaturesFiles += files(file("${resources}/java.solr.txt"))
- }
-
- forbiddenApisTest {
-doFirst dynamicSignatures.curry(configurations.testCompileClasspath,
"solr")
Review Comment:
Maybe I should have kept this line? I'm not sure what it accomplishes.
##
gradle/validation/forbidden-apis.gradle:
##
@@ -113,18 +112,6 @@ allprojects { prj ->
]
}
-// Configure solr-specific rules.
-if (prj.path.startsWith(":solr")) {
- forbiddenApisMain {
-doFirst dynamicSignatures.curry(configurations.compileClasspath,
"solr")
Review Comment:
Maybe I should have kept this line? I'm not sure what it accomplishes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17490) Don't require perl to run gradlew dev task
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898872#comment-17898872 ] ASF subversion and git services commented on SOLR-17490: Commit 586ed007925cfb3a52f791fa1e3facc1b75fe397 in solr's branch refs/heads/main from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=586ed007925 ] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist (#2753) > Don't require perl to run gradlew dev task > -- > > Key: SOLR-17490 > URL: https://issues.apache.org/jira/browse/SOLR-17490 > Project: Solr > Issue Type: Improvement > Components: Build >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > I am sitting with Patrick at C/C and he is learning how to build Solr on his > windows box. Of course, we run into the fact he doesn't have perl. > > We should not require perl to run the dev build. It's only used for > changes.txt. > > It's a blocker for every new user, and we don't tell them what to do. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]
epugh commented on PR #2753: URL: https://github.com/apache/solr/pull/2753#issuecomment-2480554027 No Changes.txt needed, this is not user facing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist [solr]
epugh merged PR #2753: URL: https://github.com/apache/solr/pull/2753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17490) Don't require perl to run gradlew dev task
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898874#comment-17898874 ] ASF subversion and git services commented on SOLR-17490: Commit cb93f63c16e61de02f9c278b9ae64c272ad4954b in solr's branch refs/heads/branch_9x from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=cb93f63c16e ] SOLR-17490: Check for existence of perl executable and skip if it doesnt exist (#2753) > Don't require perl to run gradlew dev task > -- > > Key: SOLR-17490 > URL: https://issues.apache.org/jira/browse/SOLR-17490 > Project: Solr > Issue Type: Improvement > Components: Build >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > I am sitting with Patrick at C/C and he is learning how to build Solr on his > windows box. Of course, we run into the fact he doesn't have perl. > > We should not require perl to run the dev build. It's only used for > changes.txt. > > It's a blocker for every new user, and we don't tell them what to do. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17490) Don't require perl to run gradlew dev task
[ https://issues.apache.org/jira/browse/SOLR-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17490. -- Fix Version/s: 9.8 Resolution: Fixed > Don't require perl to run gradlew dev task > -- > > Key: SOLR-17490 > URL: https://issues.apache.org/jira/browse/SOLR-17490 > Project: Solr > Issue Type: Improvement > Components: Build >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 1.5h > Remaining Estimate: 0h > > I am sitting with Patrick at C/C and he is learning how to build Solr on his > windows box. Of course, we run into the fact he doesn't have perl. > > We should not require perl to run the dev build. It's only used for > changes.txt. > > It's a blocker for every new user, and we don't tell them what to do. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1844907292 ## solr/licenses/raleway-OFL.txt: ## @@ -0,0 +1,93 @@ +Copyright 2010 The Raleway Project Authors (impall...@gmail.com), with Reserved Font Name "Raleway". + +This Font Software is licensed under the SIL Open Font License, Version 1.1. +This license is copied below, and is also available with a FAQ at: +https://openfontlicense.org + + +--- +SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 Review Comment: This license is according to the website attribution free under certain circumstances. But we still can make use of such fonts. I believe that in the long run it is better to include the license, even if it could be optional. However, for now I have removed the font files to avoid versioning binary files. It should be fine with built-in fonts for the first versions and we may consider using a library for that in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]
epugh commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480589176 Checking code out... I got a ``` task :solr:compose-ui:compileProductionExecutableKotlinWasmJs FAILED e: java.lang.OutOfMemoryError: GC overhead limit exceeded at org.jetbrains.kotlin.wasm.ir.convertors.WasmIrToBinary.appendInstr(WasmIrToBinary.kt:256) at org.jetbrains.kotlin.wasm.ir.convertors.WasmIrToBinary.appendExpr(WasmIrToBinary.kt:477) ``` with the suggestion ``` Not enough memory to run compilation. Try to increase it via 'gradle.properties': kotlin.daemon.jvmargs=-Xmx ``` bumping to 2G worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]
epugh commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2480592397 i expected the link to the `/compose` to work from old admin, but didn't see it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2480560616 @malliaridis any chance you could look at this with me? I believe the `versions.lock` and `version.props` are actually the same because I copied from `main` over into my branch the files. I don't quite know how to tell it that `hadoop-auth/build.gradle` is actually gone~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update org.apache.tika:* to v3 (major) - autoclosed [solr]
solrbot closed pull request #2583: chore(deps): update org.apache.tika:* to v3 (major) - autoclosed URL: https://github.com/apache/solr/pull/2583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
