Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
I see a few outputs - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core and Search - JBoss Logging 3.1.0.Beta3 will be binary compatible with 3.1.0.Final and we go for a Core and Search release with Logging Beta3 - we wait for JBoss Logging to go final but that means delaying Core, Search etc and many people on the product side will be impacted David, James, can you give your insight to help us chose a way? Emmanuel On 8 nov. 2011, at 18:24, Strong Liu wrote: > if jboss-logging 3.1.0 final would compatible with 3.1.0.Beta3, then i would > vote for releasing 4.0 Final today > hope AS7 could cut off a CR release with jboss-logging 3.1.0.Beta3 or Final > soon > |--- > or we wait for jboss-logging goes final and --` > > shade plugin is not always a good choice and i don't know if there is an > alternative can be used in gradle > > > > On Nov 8, 2011, at 6:12 PM, Hardy Ferentschik wrote: > >> On Tue, 08 Nov 2011 00:33:23 +0100, David M. Lloyd >> wrote: >> I don't think the shade approach is the way to go; it wouldn't work in AS 7.1, which is our final goal. >>> >>> Yeah, it would actually. It would just put a copy of that base class in >>> your JAR somewhere, and then your generated classes would extend that >>> class instead of the one which is missing in 3.0, thus your program >>> would function normally. >> >> Even though this solution seems of the table, I just thought that the >> productization >> team cannot use the shade plugin (don't ask me why). For that reasons they >> actually >> have to remove the shade plugin from the pom and patch the build in other >> ways. >> >> --Hardy >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > ___ > jboss-as7-dev mailing list > jboss-as7-...@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Maybe instead of "shading in" the removed class you could just add it back to the JBoss Logging codebase? On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: > I see a few outputs > > - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core > and Search > - JBoss Logging 3.1.0.Beta3 will be binary compatible with 3.1.0.Final and we > go for a Core and Search release with Logging Beta3 > - we wait for JBoss Logging to go final but that means delaying Core, Search > etc and many people on the product side will be impacted > > David, James, can you give your insight to help us chose a way? > > Emmanuel > > On 8 nov. 2011, at 18:24, Strong Liu wrote: > >> if jboss-logging 3.1.0 final would compatible with 3.1.0.Beta3, then i would >> vote for releasing 4.0 Final today >> hope AS7 could cut off a CR release with jboss-logging 3.1.0.Beta3 or Final >> soon >> |--- >> or we wait for jboss-logging goes final and --` >> >> shade plugin is not always a good choice and i don't know if there is an >> alternative can be used in gradle >> >> >> >> On Nov 8, 2011, at 6:12 PM, Hardy Ferentschik wrote: >> >>> On Tue, 08 Nov 2011 00:33:23 +0100, David M. Lloyd >>> wrote: >>> > I don't think the shade approach is the way to go; it wouldn't work in > AS 7.1, which is our final goal. Yeah, it would actually. It would just put a copy of that base class in your JAR somewhere, and then your generated classes would extend that class instead of the one which is missing in 3.0, thus your program would function normally. >>> >>> Even though this solution seems of the table, I just thought that the >>> productization >>> team cannot use the shade plugin (don't ask me why). For that reasons they >>> actually >>> have to remove the shade plugin from the pom and patch the build in other >>> ways. >>> >>> --Hardy >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> >> ___ >> jboss-as7-dev mailing list >> jboss-as7-...@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole wrote: > Maybe instead of "shading in" the removed class you could just add it > back to the JBoss Logging codebase? Right, why can we not do that? > On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >> I see a few outputs >> >> - JBoss Logging 3.1.0.Final is released in the next 24h and we use it >> in Core and Search What's stopping a 3.1.0.Final release? ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: > On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole > wrote: > >> Maybe instead of "shading in" the removed class you could just add it >> back to the JBoss Logging codebase? > > Right, why can we not do that? You have it backwards. We didn't *remove* a class, we *added* one - which makes it not present in 3.0.x. >> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >>> I see a few outputs >>> >>> - JBoss Logging 3.1.0.Final is released in the next 24h and we use it >>> in Core and Search > > What's stopping a 3.1.0.Final release? Trying to resolve this issue for you guys. -- - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Ok, I am totally confused then. I thought this was a discussion about BasicLogger. But we have been using that afaik way before our recent upgrade to 3.1 On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: > On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: >> On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole >> wrote: >> >>> Maybe instead of "shading in" the removed class you could just add it >>> back to the JBoss Logging codebase? >> >> Right, why can we not do that? > > You have it backwards. We didn't *remove* a class, we *added* one - > which makes it not present in 3.0.x. > >>> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: I see a few outputs - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core and Search >> >> What's stopping a 3.1.0.Final release? > > Trying to resolve this issue for you guys. > > -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Yeah, the problem was that to *implement* BasicLogger we had switched to using a base class (bundled in 3.1) to implement the multitude of methods, due to problems associated with generating all the implementations in every class. On 11/09/2011 08:39 AM, Steve Ebersole wrote: > Ok, I am totally confused then. I thought this was a discussion about > BasicLogger. But we have been using that afaik way before our recent > upgrade to 3.1 > > On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: >> On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: >>> On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole >>> wrote: >>> Maybe instead of "shading in" the removed class you could just add it back to the JBoss Logging codebase? >>> >>> Right, why can we not do that? >> >> You have it backwards. We didn't *remove* a class, we *added* one - >> which makes it not present in 3.0.x. >> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: > I see a few outputs > > - JBoss Logging 3.1.0.Final is released in the next 24h and we use it > in Core and Search >>> >>> What's stopping a 3.1.0.Final release? >> >> Trying to resolve this issue for you guys. >> >> > -- - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
OK folks. I've pushed out jboss-logging 3.1.0.CR1 and jboss-logging-tools 1.0.0.CR4. Here's what you need to do. 0. Update your dep versions (obviously) 1. Add the following switch to your annotation processing step (or to javac if it's combined): -AloggingVersion=3.0 2. Build your artifacts against jboss-logging 3.1.0.CR1. 3. When you publish the POMs for artifacts built this way, you may specify jboss-logging 3.0.0.GA as the required version, and it will be compatible with such. Basically what you're doing with the -AloggingVersion=3.0 flag is generating larger classes in exchange for backwards compatibility. If you develop other frameworks which are not expected to be supported on AS 7.0 (for example), you do not need this flag (logging version 3.1 is required in this case). If this doesn't solve your issues please let me know right away. On 11/09/2011 08:47 AM, David M. Lloyd wrote: > Yeah, the problem was that to *implement* BasicLogger we had switched to > using a base class (bundled in 3.1) to implement the multitude of > methods, due to problems associated with generating all the > implementations in every class. > > On 11/09/2011 08:39 AM, Steve Ebersole wrote: >> Ok, I am totally confused then. I thought this was a discussion about >> BasicLogger. But we have been using that afaik way before our recent >> upgrade to 3.1 >> >> On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: >>> On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole wrote: > Maybe instead of "shading in" the removed class you could just add it > back to the JBoss Logging codebase? Right, why can we not do that? >>> >>> You have it backwards. We didn't *remove* a class, we *added* one - >>> which makes it not present in 3.0.x. >>> > On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >> I see a few outputs >> >> - JBoss Logging 3.1.0.Final is released in the next 24h and we use it >> in Core and Search What's stopping a 3.1.0.Final release? >>> >>> Trying to resolve this issue for you guys. >>> >>> >> > > -- - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Thanks David! Just to make sure I understand. Doing the steps above will allow the built artifact to run in either AS 7.0 or 7.1. Correct? I thought we had said on IRC that Hibernate could really get away with (1) and (2) and that JBoss AS 7.0 could specify to use JBoss Logging 3.0 via dep-mgmt in its pom(s) rather than allowing Hibernate (or others) to pull in Logging 3.1. On Wed 09 Nov 2011 02:32:11 PM CST, David M. Lloyd wrote: > OK folks. I've pushed out jboss-logging 3.1.0.CR1 and > jboss-logging-tools 1.0.0.CR4. > > Here's what you need to do. > > 0. Update your dep versions (obviously) > 1. Add the following switch to your annotation processing step (or to > javac if it's combined): -AloggingVersion=3.0 > 2. Build your artifacts against jboss-logging 3.1.0.CR1. > 3. When you publish the POMs for artifacts built this way, you may > specify jboss-logging 3.0.0.GA as the required version, and it will be > compatible with such. > > Basically what you're doing with the -AloggingVersion=3.0 flag is > generating larger classes in exchange for backwards compatibility. If > you develop other frameworks which are not expected to be supported on > AS 7.0 (for example), you do not need this flag (logging version 3.1 > is required in this case). > > If this doesn't solve your issues please let me know right away. > > On 11/09/2011 08:47 AM, David M. Lloyd wrote: >> Yeah, the problem was that to *implement* BasicLogger we had switched to >> using a base class (bundled in 3.1) to implement the multitude of >> methods, due to problems associated with generating all the >> implementations in every class. >> >> On 11/09/2011 08:39 AM, Steve Ebersole wrote: >>> Ok, I am totally confused then. I thought this was a discussion about >>> BasicLogger. But we have been using that afaik way before our recent >>> upgrade to 3.1 >>> >>> On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: > On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole > > wrote: > >> Maybe instead of "shading in" the removed class you could just >> add it >> back to the JBoss Logging codebase? > > Right, why can we not do that? You have it backwards. We didn't *remove* a class, we *added* one - which makes it not present in 3.0.x. >> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >>> I see a few outputs >>> >>> - JBoss Logging 3.1.0.Final is released in the next 24h and we >>> use it >>> in Core and Search > > What's stopping a 3.1.0.Final release? Trying to resolve this issue for you guys. >>> >> >> > > -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Yup, that's correct. And yeah #3 is optional which is why I said "may". On 11/09/2011 02:38 PM, Steve Ebersole wrote: > Thanks David! > > Just to make sure I understand. Doing the steps above will allow the > built artifact to run in either AS 7.0 or 7.1. Correct? > > I thought we had said on IRC that Hibernate could really get away with > (1) and (2) and that JBoss AS 7.0 could specify to use JBoss Logging 3.0 > via dep-mgmt in its pom(s) rather than allowing Hibernate (or others) to > pull in Logging 3.1. > > On Wed 09 Nov 2011 02:32:11 PM CST, David M. Lloyd wrote: >> OK folks. I've pushed out jboss-logging 3.1.0.CR1 and >> jboss-logging-tools 1.0.0.CR4. >> >> Here's what you need to do. >> >> 0. Update your dep versions (obviously) >> 1. Add the following switch to your annotation processing step (or to >> javac if it's combined): -AloggingVersion=3.0 >> 2. Build your artifacts against jboss-logging 3.1.0.CR1. >> 3. When you publish the POMs for artifacts built this way, you may >> specify jboss-logging 3.0.0.GA as the required version, and it will be >> compatible with such. >> >> Basically what you're doing with the -AloggingVersion=3.0 flag is >> generating larger classes in exchange for backwards compatibility. If >> you develop other frameworks which are not expected to be supported on >> AS 7.0 (for example), you do not need this flag (logging version 3.1 >> is required in this case). >> >> If this doesn't solve your issues please let me know right away. >> >> On 11/09/2011 08:47 AM, David M. Lloyd wrote: >>> Yeah, the problem was that to *implement* BasicLogger we had switched to >>> using a base class (bundled in 3.1) to implement the multitude of >>> methods, due to problems associated with generating all the >>> implementations in every class. >>> >>> On 11/09/2011 08:39 AM, Steve Ebersole wrote: Ok, I am totally confused then. I thought this was a discussion about BasicLogger. But we have been using that afaik way before our recent upgrade to 3.1 On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: > On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: >> On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole >> >> wrote: >> >>> Maybe instead of "shading in" the removed class you could just >>> add it >>> back to the JBoss Logging codebase? >> >> Right, why can we not do that? > > You have it backwards. We didn't *remove* a class, we *added* one - > which makes it not present in 3.0.x. > >>> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: I see a few outputs - JBoss Logging 3.1.0.Final is released in the next 24h and we use it in Core and Search >> >> What's stopping a 3.1.0.Final release? > > Trying to resolve this issue for you guys. > > >>> >>> >> >> > -- - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Chill out man :) Just making sure everyone know the ramifications and intentions. On Wed 09 Nov 2011 02:43:43 PM CST, David M. Lloyd wrote: > Yup, that's correct. And yeah #3 is optional which is why I said "may". > > On 11/09/2011 02:38 PM, Steve Ebersole wrote: >> Thanks David! >> >> Just to make sure I understand. Doing the steps above will allow the >> built artifact to run in either AS 7.0 or 7.1. Correct? >> >> I thought we had said on IRC that Hibernate could really get away with >> (1) and (2) and that JBoss AS 7.0 could specify to use JBoss Logging 3.0 >> via dep-mgmt in its pom(s) rather than allowing Hibernate (or others) to >> pull in Logging 3.1. >> >> On Wed 09 Nov 2011 02:32:11 PM CST, David M. Lloyd wrote: >>> OK folks. I've pushed out jboss-logging 3.1.0.CR1 and >>> jboss-logging-tools 1.0.0.CR4. >>> >>> Here's what you need to do. >>> >>> 0. Update your dep versions (obviously) >>> 1. Add the following switch to your annotation processing step (or to >>> javac if it's combined): -AloggingVersion=3.0 >>> 2. Build your artifacts against jboss-logging 3.1.0.CR1. >>> 3. When you publish the POMs for artifacts built this way, you may >>> specify jboss-logging 3.0.0.GA as the required version, and it will be >>> compatible with such. >>> >>> Basically what you're doing with the -AloggingVersion=3.0 flag is >>> generating larger classes in exchange for backwards compatibility. If >>> you develop other frameworks which are not expected to be supported on >>> AS 7.0 (for example), you do not need this flag (logging version 3.1 >>> is required in this case). >>> >>> If this doesn't solve your issues please let me know right away. >>> >>> On 11/09/2011 08:47 AM, David M. Lloyd wrote: Yeah, the problem was that to *implement* BasicLogger we had switched to using a base class (bundled in 3.1) to implement the multitude of methods, due to problems associated with generating all the implementations in every class. On 11/09/2011 08:39 AM, Steve Ebersole wrote: > Ok, I am totally confused then. I thought this was a discussion about > BasicLogger. But we have been using that afaik way before our recent > upgrade to 3.1 > > On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: >> On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: >>> On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole >>> >>> wrote: >>> Maybe instead of "shading in" the removed class you could just add it back to the JBoss Logging codebase? >>> >>> Right, why can we not do that? >> >> You have it backwards. We didn't *remove* a class, we *added* one - >> which makes it not present in 3.0.x. >> On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: > I see a few outputs > > - JBoss Logging 3.1.0.Final is released in the next 24h and we > use it > in Core and Search >>> >>> What's stopping a 3.1.0.Final release? >> >> Trying to resolve this issue for you guys. >> >> > >>> >>> >> > > -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [jboss-as7-dev] Which JBoss Logging version to use in AS and Hibernate Core
Awesome! just verified on both Hibernate Search and Infinispan, no issues spotted ! thanks a lot, Sanne On 9 November 2011 21:29, Steve Ebersole wrote: > Chill out man :) > > Just making sure everyone know the ramifications and intentions. > > On Wed 09 Nov 2011 02:43:43 PM CST, David M. Lloyd wrote: >> Yup, that's correct. And yeah #3 is optional which is why I said "may". >> >> On 11/09/2011 02:38 PM, Steve Ebersole wrote: >>> Thanks David! >>> >>> Just to make sure I understand. Doing the steps above will allow the >>> built artifact to run in either AS 7.0 or 7.1. Correct? >>> >>> I thought we had said on IRC that Hibernate could really get away with >>> (1) and (2) and that JBoss AS 7.0 could specify to use JBoss Logging 3.0 >>> via dep-mgmt in its pom(s) rather than allowing Hibernate (or others) to >>> pull in Logging 3.1. >>> >>> On Wed 09 Nov 2011 02:32:11 PM CST, David M. Lloyd wrote: OK folks. I've pushed out jboss-logging 3.1.0.CR1 and jboss-logging-tools 1.0.0.CR4. Here's what you need to do. 0. Update your dep versions (obviously) 1. Add the following switch to your annotation processing step (or to javac if it's combined): -AloggingVersion=3.0 2. Build your artifacts against jboss-logging 3.1.0.CR1. 3. When you publish the POMs for artifacts built this way, you may specify jboss-logging 3.0.0.GA as the required version, and it will be compatible with such. Basically what you're doing with the -AloggingVersion=3.0 flag is generating larger classes in exchange for backwards compatibility. If you develop other frameworks which are not expected to be supported on AS 7.0 (for example), you do not need this flag (logging version 3.1 is required in this case). If this doesn't solve your issues please let me know right away. On 11/09/2011 08:47 AM, David M. Lloyd wrote: > Yeah, the problem was that to *implement* BasicLogger we had > switched to > using a base class (bundled in 3.1) to implement the multitude of > methods, due to problems associated with generating all the > implementations in every class. > > On 11/09/2011 08:39 AM, Steve Ebersole wrote: >> Ok, I am totally confused then. I thought this was a discussion about >> BasicLogger. But we have been using that afaik way before our recent >> upgrade to 3.1 >> >> On Wed 09 Nov 2011 08:23:33 AM CST, David M. Lloyd wrote: >>> On 11/09/2011 08:22 AM, Hardy Ferentschik wrote: On Wed, 09 Nov 2011 15:00:07 +0100, Steve Ebersole wrote: > Maybe instead of "shading in" the removed class you could just > add it > back to the JBoss Logging codebase? Right, why can we not do that? >>> >>> You have it backwards. We didn't *remove* a class, we *added* one - >>> which makes it not present in 3.0.x. >>> > On 11/09/2011 04:48 AM, Emmanuel Bernard wrote: >> I see a few outputs >> >> - JBoss Logging 3.1.0.Final is released in the next 24h and we >> use it >> in Core and Search What's stopping a 3.1.0.Final release? >>> >>> Trying to resolve this issue for you guys. >>> >>> >> > > >>> >> >> > > -- > st...@hibernate.org > http://hibernate.org > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
