[GitHub] [pulsar-test-infra] mangoGoForward commented on pull request #75: feat: add action of check-pr-title to ensure PR title matches Naming Convention Guide
mangoGoForward commented on PR #75: URL: https://github.com/apache/pulsar-test-infra/pull/75#issuecomment-1260653955 > Got~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-dotpulsar] kandersen82 opened a new pull request, #109: Interface for enqueueing
kandersen82 opened a new pull request, #109: URL: https://github.com/apache/pulsar-dotpulsar/pull/109 WIP Added User API method, and rearranged interface dependencies for more flexibility in SubProducer TODO: Implement queue in SubProducer Add configuration option for queue size Implement Flush functionality Support partition resizing Implement convenience Enqueue extension methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-manager] sumingsoftware opened a new issue, #489: apache-pulsar-manager-0.3.0 Management menu always return 404
sumingsoftware opened a new issue, #489: URL: https://github.com/apache/pulsar-manager/issues/489 **Describtion:** When I click the Management menu on the top Management menu , It always return 404 page. **environment:** 1. apache-pulsar-manager version is 0.3.0, 2. JDK openjdk version "11.0.2" 2019-01-15 OpenJDK Runtime Environment 18.9 (build 11.0.2+9) 3. OS: Red Hat 8.2.1-3 **scenario:**  then always direct to this url, http://ip:7750/ui/index.html#/404  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories
+1 Zixuan Liu 于2022年9月26日周一 23:42写道： > +1 > > Thanks, > Zixuan > > Anon Hxy 于2022年9月26日周一 17:52写道： > > > +1 LGTM > > > > Thanks, > > Xiaoyu Hou > > > > Enrico Olivelli 于2022年9月26日周一 17:39写道： > > > > > +100 to this ! > > > > > > Thanks for this proposal > > > > > > Enrico > > > > > > Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang > ha > > > scritto: > > > > > > > > +1. Looks good to me. > > > > > > > > Do we need to move the `Apache Pulsar / Multi Clients` Github project > > > > to the corresponding repos? > > > > > > > > Thanks, > > > > Zike Yang > > > > > > > > Zike Yang > > > > > > > > > > > > On Fri, Sep 23, 2022 at 7:22 AM Matteo Merli > > > > wrote: > > > > > > > > > > -- > > > > > Matteo Merli > > > > > > > > > > > > > > > On Tue, Sep 20, 2022 at 8:14 PM Michael Marshall < > > mmarsh...@apache.org> > > > wrote: > > > > > > > > > > > > Great proposal, thanks Matteo. > > > > > > > > > > > > I think I agree with splitting out the client into two repos. One > > > > > > issue is that new C++ features will lag in the python client > > because > > > > > > the C++ client will first need to be released. Quick releases > will > > > > > > likely help there. > > > > > > > > > > Yes, decoupling Java, C++ and Python releases will make each of > them > > > > > much easier. > > > > > > > > > > We'll be able to do patch releases with a tenth of the manual work > > > involved. > > > > > > > > > > > > The client <--> broker compatibility is in general always > > > guaranteed. > > > > > > > > > > > > I think we should make this more visible in our Pulsar > > documentation. > > > > > > It's a fantastic feature, and I get the sense that it is not well > > > > > > known. > > > > > > > > > > Agree, it's something that still surprises a lot of people. > > > > > > -- BR, Qiang Huang
Re: [DISCUSS] Apache Pulsar 2.11.0 Release
I've found another release blocker about client compatibility with jdk8/11, please review https://github.com/apache/pulsar/pull/17873 Nicolò Boschi Il giorno ven 16 set 2022 alle ore 10:54 Nicolò Boschi ha scritto: > Actually Yong found the root cause of the issue, see > https://lists.apache.org/thread/d9gm50kysgjcpbq448s2sy822kho6z6k - > https://github.com/apache/bookkeeper/pull/3480 > The issue only appears if "numReadWorkerThreads" is set to zero, which is > a non-sense config in a production environment. > > > But I found another release blocker here: > https://github.com/apache/pulsar/pull/17690 > > After that, I think we should go forward and continue with the release. > Pulsar 2.11 will contain awesome features and we already have held it too > much based on the release schedule. > > Regards, > Nicolò Boschi > > > Il giorno mar 13 set 2022 alle ore 10:02 Nicolò Boschi < > boschi1...@gmail.com> ha scritto: > >> The only blocker now should be >> https://github.com/apache/pulsar/issues/17520 >> The description says that reverting BK to 4.15.0, the issue seems >> resolved. >> >> If so, I think we should revert the BK upgrade and then go forward with >> Pulsar 2.11.0. >> >> I know that there are some suspects of a regression in BK 4.15.0 raised >> by the Pravega team (https://github.com/apache/bookkeeper/issues/3466) >> but we can't wait for them. >> We don't know if the same issue applies to Pulsar and the time for: find >> the issue - fix it - cut a release may be weeks or months. >> >> >> Nicolò Boschi >> >> >> Il giorno lun 5 set 2022 alle ore 14:03 Enrico Olivelli < >> eolive...@gmail.com> ha scritto: >> >>> Got it >>> thanks fro the update and also thanks for being so careful in >>> following the issues >>> and we are finding on Pulsar >>> >>> Il giorno lun 5 set 2022 alle ore 13:00 guo jiwei >>> ha scritto: >>> > >>> > Hi dev, >>> > We find two new issues[1] that block the release. >>> > After the two issues are resolved, I will start the release. >>> > >>> > [1] : https://github.com/apache/pulsar/pull/17474 >>> >https://github.com/apache/bookkeeper/issues/3466 >>> >>> This is a BookKeeper bug, so it will take much time to see it fixed >>> and released in order to be >>> consumed by Pulsar. >>> >>> The issue was reported on Pravega, that uses BK in a very different way. >>> I am not sure that we have to hold off this release waiting for >>> feedback on that issue >>> >>> The 2.11 release was due to August, before PulsarSummit >>> >>> any other opinions from the community ? >>> >>> >>> Enrico >>> >>> > >>> > Regards >>> > Jiwei Guo (Tboy) >>> > >>> > >>> > On Fri, Aug 26, 2022 at 10:02 AM guo jiwei >>> wrote: >>> > >>> > > Hi Anon >>> > >After we cut the branch, the code freezed. >>> > > >>> > > >>> > > Regards >>> > > Jiwei Guo (Tboy) >>> > > >>> > > >>> > > On Thu, Aug 25, 2022 at 9:45 PM Anon Hxy >>> wrote: >>> > > >>> > >> Hi jiwei >>> > >> >>> > >> Sorry for late reply. I'd like to add PIP189 to 2.11.0, is it >>> possible >>> > >> now >>> > >> >>> > >> - PIP 189: No batching if only one message in batch. >>> > >> https://github.com/apache/pulsar/pull/16605 >>> > >> >>> > >> Thanks, >>> > >> Xiaoyu Hou >>> > >> >>> > >> guo jiwei 于2022年8月24日周三 10:16写道： >>> > >> >>> > >> > Hi all, >>> > >> >We have merged all the blocker patches, and I decide to start >>> the >>> > >> > release. >>> > >> >The release note[1] for 2.11.0 is available for review, please >>> help >>> > >> > review it and feel free to leave comments. >>> > >> > >>> > >> > >>> > >> > [1] https://github.com/apache/pulsar-site/pull/167 >>> > >> > >>> > >> > >>> > >> > Regards >>> > >> > Jiwei Guo (Tboy) >>> > >> > >>> > >> > >>> > >> > On Wed, Aug 17, 2022 at 10:43 PM Enrico Olivelli < >>> eolive...@gmail.com> >>> > >> > wrote: >>> > >> > >>> > >> > > This test is blocking all the PRs and so it is blocking the >>> release: >>> > >> > > Error: Tests run: 9, Failures: 2, Errors: 0, Skipped: 3, Time >>> elapsed: >>> > >> > > 21.724 s <<< FAILURE! - in >>> > >> > > org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest >>> > >> > > 3681 Error: >>> > >> > > >>> > >> > >>> > >> >>> testParallelSubscribeAsync(org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest) >>> > >> > > Time elapsed: 5.05 s <<< FAILURE! >>> > >> > > org.testng.internal.thread.ThreadTimeoutException: Method >>> > >> > > >>> > >> > > >>> > >> > >>> > >> >>> org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest.testParallelSubscribeAsync() >>> > >> > > didn't finish within the time-out 5000 >>> > >> > > >>> > >> > > >>> > >> > > Enrico >>> > >> > > >>> > >> > > Il giorno mer 17 ago 2022 alle ore 14:40 Nicolò Boschi >>> > >> > > ha scritto: >>> > >> > > > >>> > >> > > > This is another blocker for 2.11.0 for a regression about >>> streaming >>> > >> > > > dispatch that I found in the 2.11 branch >>> > >> > > > https://github.com/apache/pulsar/pull/17143 >>> > >> > > > >>> > >> > > > Nicolò Boschi >>> > >> > > > >>> > >> > >
Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories
+1 (binding) Sent from my iPhone > On Sep 26, 2022, at 2:38 AM, Enrico Olivelli wrote: > > +100 to this ! > > Thanks for this proposal > > Enrico > >> Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang ha >> scritto: >> >> +1. Looks good to me. >> >> Do we need to move the `Apache Pulsar / Multi Clients` Github project >> to the corresponding repos? >> >> Thanks, >> Zike Yang >> >> Zike Yang >> >> >>> On Fri, Sep 23, 2022 at 7:22 AM Matteo Merli wrote: >>> >>> -- >>> Matteo Merli >>> >>> >>> On Tue, Sep 20, 2022 at 8:14 PM Michael Marshall >>> wrote: Great proposal, thanks Matteo. I think I agree with splitting out the client into two repos. One issue is that new C++ features will lag in the python client because the C++ client will first need to be released. Quick releases will likely help there. >>> >>> Yes, decoupling Java, C++ and Python releases will make each of them >>> much easier. >>> >>> We'll be able to do patch releases with a tenth of the manual work involved. >>> > The client <--> broker compatibility is in general always guaranteed. I think we should make this more visible in our Pulsar documentation. It's a fantastic feature, and I get the sense that it is not well known. >>> >>> Agree, it's something that still surprises a lot of people.
[GitHub] [pulsar-manager] merlimat opened a new pull request, #490: Redirect notifications to the commits@ list instead of dev
merlimat opened a new pull request, #490: URL: https://github.com/apache/pulsar-manager/pull/490 ### Motivation Redirect notifications to the commits@ list instead of dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Pulsar Release 2.10.2 Candidate 1
+1 (non binding) - Checksum and signatures - Apache Rat check passes - Compile from source w JDK11 - Build docker image from source - Run Pulsar standalone and produce-consume from CLI - Tested a couple of connectors (ElasticSink, JDBC sink) in K8S env Nicolò Boschi Il giorno lun 26 set 2022 alle ore 13:42 Haiting Jiang < jianghait...@gmail.com> ha scritto: > This is the first release candidate for Apache Pulsar, version 2.10.2. > > This release contains 244 commits by 57 contributors. > https://github.com/apache/pulsar/compare/v2.10.1...v2.10.2-candidate-1 > > Full CI on this release: > https://github.com/Jason918/pulsar/pull/8 > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.2-candidate-1/ > > SHA-512 checksums: > > fc7ed1947bf737b92ab097dc0eb500567668a6f64ed6e88af9d1f5bf9c266f77e50d3ea28944856f39afb0140232747693d61836b99eb22b7580e8a6cad4ce7d > ./apache-pulsar-2.10.2-bin.tar.gz > > cab39ab5c24e2d01074d9169b641cdb80a59609462b664f6892905d6e995a72b02ab48cc8456cf90883a810af6085465cc8371df5e498bc1e13700ad0864d6af > ./apache-pulsar-2.10.2-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1179/ > > The tag to be voted upon: > v2.10.2-candidate-1 (ddd642e77deacc42ad2542df39cbb22ef5217b25) > https://github.com/apache/pulsar/releases/tag/v2.10.2-candidate-1 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > Docker images: > > https://hub.docker.com/layers/jason918/pulsar/2.10.2/images/sha256-2a6543a6f6b40af34760418ff199a771f91d85539e2cac692a524f3056d2226e > > https://hub.docker.com/layers/jason918/pulsar-all/2.10.2/images/sha256-f9dc9b9ce224c69ab3616e7b3bbceafcb27504c81c791e2410115454a48c7837 > > Please download the source package, and follow the > release-candidate-validation doc to build > and run the Pulsar standalone service. > > https://github.com/apache/pulsar/blob/master/wiki/release/release-candidate-validation.md > > Thanks, > Haiting >
[GitHub] [pulsar-manager] rdhabalia merged pull request #490: Redirect notifications to the commits@ list instead of dev
rdhabalia merged PR #490: URL: https://github.com/apache/pulsar-manager/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-dotpulsar] aintJoshinya opened a new pull request, #110: modified the "hello world" to fix first run issue
aintJoshinya opened a new pull request, #110:
URL: https://github.com/apache/pulsar-dotpulsar/pull/110
the current "hello world" will not show a consumed message the very first
time it is run. On subsequent runs, it will work, but it isn't entirely clear
from the code alone why it works on subsequent runs.
I don't entirely understand why the order matters here, but I believe it
isn't showing the consumed message on the first run because the subscription is
created after the producer sends a message. It seems that by default, a new
subscription will not consume messages that are created before it.
An alternative solution would be to create the consumer with the
"InitialPosition" option set to Earliest
(".InitialPosition(SubscriptionInitialPosition.Earliest"), but I think it's
preferable to minimize optional configuration in a hello world like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] PIP-209: Separate C++/Python clients to own repositories
+1 (binding) Penghui On Tue, Sep 27, 2022 at 5:17 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Mar 27 Set 2022, 11:13 Max Xu ha scritto: > > > +1 (non-binding) > > > > Best, > > Max Xu > > > > > > On Tue, Sep 27, 2022 at 4:50 PM Anon Hxy wrote: > > > > > +1 (non binding) > > > > > > Thanks, > > > Xiaoyu Hou > > > > > > Nicolò Boschi 于2022年9月27日周二 16:39写道： > > > > > > > +1 (non binding) > > > > Nicolò Boschi > > > > > > > > > > > > Il giorno mar 27 set 2022 alle ore 10:17 Qiang Huang < > > > > qiang.huang1...@gmail.com> ha scritto: > > > > > > > > > +1 (non-binding) > > > > > > > > > > Yunze Xu 于2022年9月27日周二 11:35写道： > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Thanks, > > > > > > Yunze > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sep 27, 2022, at 11:11, Zixuan Liu > wrote: > > > > > > > > > > > > > > +1(non-binding) > > > > > > > > > > > > > > Thanks, > > > > > > > Zixuan > > > > > > > > > > > > > > Haiting Jiang 于2022年9月27日周二 09:56写道： > > > > > > > > > > > > > >> +1 (non) > > > > > > >> > > > > > > >> Haiting > > > > > > >> > > > > > > >> On Tue, Sep 27, 2022 at 9:30 AM Zike Yang > > > wrote: > > > > > > >>> > > > > > > >>> +1 (non-binding) > > > > > > >>> > > > > > > >>> > > > > > > >>> Zike Yang > > > > > > >>> > > > > > > >>> On Tue, Sep 27, 2022 at 9:24 AM Kai Wang < > > > > wangkai744567...@gmail.com > > > > > > > > > > > > >> wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Thanks, > > > > > > Kai > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > -- > > > > > BR, > > > > > Qiang Huang > > > > > > > > > > > > > > >
Re: [VOTE] PIP-209: Separate C++/Python clients to own repositories
+1 (binding) Regards Jiwei Guo (Tboy) On Thu, Sep 29, 2022 at 8:38 AM PengHui Li wrote: > +1 (binding) > > Penghui > > On Tue, Sep 27, 2022 at 5:17 PM Enrico Olivelli > wrote: > > > +1 (binding) > > > > Enrico > > > > Il Mar 27 Set 2022, 11:13 Max Xu ha scritto: > > > > > +1 (non-binding) > > > > > > Best, > > > Max Xu > > > > > > > > > On Tue, Sep 27, 2022 at 4:50 PM Anon Hxy wrote: > > > > > > > +1 (non binding) > > > > > > > > Thanks, > > > > Xiaoyu Hou > > > > > > > > Nicolò Boschi 于2022年9月27日周二 16:39写道： > > > > > > > > > +1 (non binding) > > > > > Nicolò Boschi > > > > > > > > > > > > > > > Il giorno mar 27 set 2022 alle ore 10:17 Qiang Huang < > > > > > qiang.huang1...@gmail.com> ha scritto: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Yunze Xu 于2022年9月27日周二 11:35写道： > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > Thanks, > > > > > > > Yunze > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sep 27, 2022, at 11:11, Zixuan Liu > > wrote: > > > > > > > > > > > > > > > > +1(non-binding) > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Zixuan > > > > > > > > > > > > > > > > Haiting Jiang 于2022年9月27日周二 > 09:56写道： > > > > > > > > > > > > > > > >> +1 (non) > > > > > > > >> > > > > > > > >> Haiting > > > > > > > >> > > > > > > > >> On Tue, Sep 27, 2022 at 9:30 AM Zike Yang > > > > wrote: > > > > > > > >>> > > > > > > > >>> +1 (non-binding) > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> Zike Yang > > > > > > > >>> > > > > > > > >>> On Tue, Sep 27, 2022 at 9:24 AM Kai Wang < > > > > > wangkai744567...@gmail.com > > > > > > > > > > > > > > >> wrote: > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > Thanks, > > > > > > > Kai > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > BR, > > > > > > Qiang Huang > > > > > > > > > > > > > > > > > > > > >
Re: [VOTE] PIP-209: Separate C++/Python clients to own repositories
Thanks everyone for voting on this proposal. I'm closing the vote with 4 binding +1s and 11 non-binding +1s. Binding: * Matteo * Enrico * PengHui * Jiwei Non-Binding: * Baodi * Tison * Kai * Zike * Haiting * Zixuan * Yunze * Qiang * Nicolò * Xiaoyu * Max -- Matteo Merli On Wed, Sep 28, 2022 at 6:05 PM guo jiwei wrote: > > +1 (binding) > > Regards > Jiwei Guo (Tboy) > > > On Thu, Sep 29, 2022 at 8:38 AM PengHui Li wrote: > > > +1 (binding) > > > > Penghui > > > > On Tue, Sep 27, 2022 at 5:17 PM Enrico Olivelli > > wrote: > > > > > +1 (binding) > > > > > > Enrico > > > > > > Il Mar 27 Set 2022, 11:13 Max Xu ha scritto: > > > > > > > +1 (non-binding) > > > > > > > > Best, > > > > Max Xu > > > > > > > > > > > > On Tue, Sep 27, 2022 at 4:50 PM Anon Hxy wrote: > > > > > > > > > +1 (non binding) > > > > > > > > > > Thanks, > > > > > Xiaoyu Hou > > > > > > > > > > Nicolò Boschi 于2022年9月27日周二 16:39写道： > > > > > > > > > > > +1 (non binding) > > > > > > Nicolò Boschi > > > > > > > > > > > > > > > > > > Il giorno mar 27 set 2022 alle ore 10:17 Qiang Huang < > > > > > > qiang.huang1...@gmail.com> ha scritto: > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > Yunze Xu 于2022年9月27日周二 11:35写道： > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Yunze > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sep 27, 2022, at 11:11, Zixuan Liu > > > wrote: > > > > > > > > > > > > > > > > > > +1(non-binding) > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Zixuan > > > > > > > > > > > > > > > > > > Haiting Jiang 于2022年9月27日周二 > > 09:56写道： > > > > > > > > > > > > > > > > > >> +1 (non) > > > > > > > > >> > > > > > > > > >> Haiting > > > > > > > > >> > > > > > > > > >> On Tue, Sep 27, 2022 at 9:30 AM Zike Yang > > > > > wrote: > > > > > > > > >>> > > > > > > > > >>> +1 (non-binding) > > > > > > > > >>> > > > > > > > > >>> > > > > > > > > >>> Zike Yang > > > > > > > > >>> > > > > > > > > >>> On Tue, Sep 27, 2022 at 9:24 AM Kai Wang < > > > > > > wangkai744567...@gmail.com > > > > > > > > > > > > > > > > >> wrote: > > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Kai > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > BR, > > > > > > > Qiang Huang > > > > > > > > > > > > > > > > > > > > > > > > > > >
[GitHub] [pulsar] tisonkun added a comment to the discussion: [Doc] Repurpose the Kubernetes chapter with IA improvements
GitHub user tisonkun added a comment to the discussion: [Doc] Repurpose the Kubernetes chapter with IA improvements Related issue: https://github.com/apache/pulsar/issues/17774. GitHub link: https://github.com/apache/pulsar/discussions/17866#discussioncomment-3758068 This is an automatically sent email for dev@pulsar.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org
[DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16
Hello everyone: In the current version of pulsar-go-client, we do not support embedding the version information of pulsar-go-client into Client Command to send to the Broker. Now the hard code is fixed to 0.1.0. This makes it impossible for us to determine which version of pulsar-go-client the current user is using through the version information. To support this feature, the more clumsy method is described using https://github.com/apache/pulsar-client-go/pull/820. However, Go 1.16 officially supports the feature of embed ( https://pkg.go.dev/embed), which supports reading the specified file directly, which seems to be a more elegant way, but this requires Go 1.16 version. Yes, the current minimum version supported by our pulsar-go-client is Go 1.15, which requires us to change the minimum version of pulsar-go-client from Go 1.15 to Go 1.16. So here we start a discussion within the community to see if we can make this change. -- Thanks Xiaolong Ran
Re: [VOTE] Pulsar Release 2.10.2 Candidate 1
+1 (binding) - Checksum and signatures - Apache Rat check passes - Compile from source with JDK11 - Validate Pub/Sub and Java functions - Validate Connectors - Validate Stateful functions Regards Jiwei Guo (Tboy) On Thu, Sep 29, 2022 at 12:26 AM Nicolò Boschi wrote: > +1 (non binding) > > > - Checksum and signatures > > - Apache Rat check passes > > - Compile from source w JDK11 > > - Build docker image from source > > - Run Pulsar standalone and produce-consume from CLI > > - Tested a couple of connectors (ElasticSink, JDBC sink) in K8S env > > Nicolò Boschi > > > Il giorno lun 26 set 2022 alle ore 13:42 Haiting Jiang < > jianghait...@gmail.com> ha scritto: > > > This is the first release candidate for Apache Pulsar, version 2.10.2. > > > > This release contains 244 commits by 57 contributors. > > https://github.com/apache/pulsar/compare/v2.10.1...v2.10.2-candidate-1 > > > > Full CI on this release: > > https://github.com/Jason918/pulsar/pull/8 > > > > *** Please download, test and vote on this release. This vote will stay > > open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.2-candidate-1/ > > > > SHA-512 checksums: > > > > > fc7ed1947bf737b92ab097dc0eb500567668a6f64ed6e88af9d1f5bf9c266f77e50d3ea28944856f39afb0140232747693d61836b99eb22b7580e8a6cad4ce7d > > ./apache-pulsar-2.10.2-bin.tar.gz > > > > > cab39ab5c24e2d01074d9169b641cdb80a59609462b664f6892905d6e995a72b02ab48cc8456cf90883a810af6085465cc8371df5e498bc1e13700ad0864d6af > > ./apache-pulsar-2.10.2-src.tar.gz > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachepulsar-1179/ > > > > The tag to be voted upon: > > v2.10.2-candidate-1 (ddd642e77deacc42ad2542df39cbb22ef5217b25) > > https://github.com/apache/pulsar/releases/tag/v2.10.2-candidate-1 > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > Docker images: > > > > > https://hub.docker.com/layers/jason918/pulsar/2.10.2/images/sha256-2a6543a6f6b40af34760418ff199a771f91d85539e2cac692a524f3056d2226e > > > > > https://hub.docker.com/layers/jason918/pulsar-all/2.10.2/images/sha256-f9dc9b9ce224c69ab3616e7b3bbceafcb27504c81c791e2410115454a48c7837 > > > > Please download the source package, and follow the > > release-candidate-validation doc to build > > and run the Pulsar standalone service. > > > > > https://github.com/apache/pulsar/blob/master/wiki/release/release-candidate-validation.md > > > > Thanks, > > Haiting > > >
Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16
+1 pulsar-go-client from Go 1.15 to Go 1.16 Thanks r...@apache.org 于2022年9月29日周四 11:11写道： > Hello everyone: > > In the current version of pulsar-go-client, we do not support embedding the > version information of pulsar-go-client into > Client Command to send to the Broker. Now the hard code is fixed to 0.1.0. > This makes it impossible for us to determine > which version of pulsar-go-client the current user is using through the > version information. > > To support this feature, the more clumsy method is described using > https://github.com/apache/pulsar-client-go/pull/820. > However, Go 1.16 officially supports the feature of embed ( > https://pkg.go.dev/embed), which supports reading the > specified file directly, which seems to be a more elegant way, but this > requires Go 1.16 version. Yes, the current minimum > version supported by our pulsar-go-client is Go 1.15, which requires us to > change the minimum version of > pulsar-go-client from Go 1.15 to Go 1.16. > > So here we start a discussion within the community to see if we can make > this change. > > -- > Thanks > Xiaolong Ran >
Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16
+1 It would be good to determine and document a compatibility policy to state which versions are going to be supported and for how long. On Wed, Sep 28, 2022 at 8:31 PM 沈家琦 wrote: > +1 > pulsar-go-client from Go 1.15 to Go 1.16 > > Thanks > > r...@apache.org 于2022年9月29日周四 11:11写道： > > > Hello everyone: > > > > In the current version of pulsar-go-client, we do not support embedding > the > > version information of pulsar-go-client into > > Client Command to send to the Broker. Now the hard code is fixed to > 0.1.0. > > This makes it impossible for us to determine > > which version of pulsar-go-client the current user is using through the > > version information. > > > > To support this feature, the more clumsy method is described using > > https://github.com/apache/pulsar-client-go/pull/820. > > However, Go 1.16 officially supports the feature of embed ( > > https://pkg.go.dev/embed), which supports reading the > > specified file directly, which seems to be a more elegant way, but this > > requires Go 1.16 version. Yes, the current minimum > > version supported by our pulsar-go-client is Go 1.15, which requires us > to > > change the minimum version of > > pulsar-go-client from Go 1.15 to Go 1.16. > > > > So here we start a discussion within the community to see if we can make > > this change. > > > > -- > > Thanks > > Xiaolong Ran > > > -- -- Matteo Merli
Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16
+1, according to https://go.dev/doc/devel/release#policy (quoted below), the current live supported go version should be 1.19, 1.18 and 1.17, so I think it should be fine if we move the pulsar-client-go with 1.16 as the minimum Go SDK version. > quote_type > > Release Policy > Each major Go release is supported until there are two newer major releases. > For example, Go 1.5 was supported until the Go 1.7 release, and Go 1.6 was > supported until the Go 1.8 release. We fix critical problems, including > critical security problems, in supported releases as needed by issuing minor > revisions (for example, Go 1.6.1, Go 1.6.2, and so on). Best, Rui Fu 在 2022年9月29日 +0800 11:33，Matteo Merli ，写道： > +1 > > It would be good to determine and document a compatibility policy to state > which versions are going to be supported and for how long. > > On Wed, Sep 28, 2022 at 8:31 PM 沈家琦 wrote: > > > +1 > > pulsar-go-client from Go 1.15 to Go 1.16 > > > > Thanks > > > > r...@apache.org 于2022年9月29日周四 11:11写道： > > > > > Hello everyone: > > > > > > In the current version of pulsar-go-client, we do not support embedding > > the > > > version information of pulsar-go-client into > > > Client Command to send to the Broker. Now the hard code is fixed to > > 0.1.0. > > > This makes it impossible for us to determine > > > which version of pulsar-go-client the current user is using through the > > > version information. > > > > > > To support this feature, the more clumsy method is described using > > > https://github.com/apache/pulsar-client-go/pull/820. > > > However, Go 1.16 officially supports the feature of embed ( > > > https://pkg.go.dev/embed), which supports reading the > > > specified file directly, which seems to be a more elegant way, but this > > > requires Go 1.16 version. Yes, the current minimum > > > version supported by our pulsar-go-client is Go 1.15, which requires us > > to > > > change the minimum version of > > > pulsar-go-client from Go 1.15 to Go 1.16. > > > > > > So here we start a discussion within the community to see if we can make > > > this change. > > > > > > -- > > > Thanks > > > Xiaolong Ran > > > > > > -- > -- > Matteo Merli >
Re: [VOTE] Pulsar Client Go Release 0.9.0 Candidate 1
-1 In https://github.com/apache/pulsar-client-go/pull/777 we introduce the function of AckResponse, but the modification of this function blocks the original unit test, so this piece of logic needs to be refactored. At present, the problem has been fixed, I will close the current Vote and re-launch the voting process for 0.9.0 Candidate 2. Guangning E 于2022年9月26日周一 16:07写道： > +1(non-binding) > - Check sha 512 value for source code > - Check go build > > Thanks, > Guangning > > Rui Fu 于2022年7月7日周四 10:58写道： > > > Hi everyone, > > > > Please review and vote on the release candidate #1 for the version 0.9.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > This is the first release candidate for Apache Pulsar Go client, > > version 0.9.0. > > > > It fixes the following issues: > > https://github.com/apache/pulsar-client-go/milestone/10?closed=1 > > > > Pulsar Client Go's KEYS file contains PGP keys we used to sign this > > release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > Please download these packages and review this release candidate: > > - Review release notes > https://github.com/apache/pulsar-client-go/pull/804 > > - Download the source package (verify shasum, and asc) and follow the > > README.md to build and run the pulsar-client-go. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Source file: > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.9.0-candidate-1/ > > > > The tag to be voted upon: > > v0.9.0 > > > https://github.com/apache/pulsar-client-go/releases/tag/v0.9.0-candidate-1 > > > > SHA-512 checksums: > > > 79b4b86e35d5aa16c8e8361a9f3f2532075efe93fc79c7f49424b708e31b6716194d3c053af5f8432a52573bb12e5fc1144a2529243066861f692c4c0743a807 > > apache-pulsar-client-go-0.9.0-src.tar.gz > > > > Best, > > > > Rui Fu > > >
[VOTE] Pulsar Client Go Release 0.9.0 Candidate 2
Hi everyone, Please review and vote on the release candidate #2 for the version 0.9.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the second release candidate for Apache Pulsar Go client, version 0.9.0. It fixes the following issues: https://github.com/apache/pulsar-client-go/milestone/10?closed=1 Pulsar Client Go's KEYS file contains PGP keys we used to sign this release: https://dist.apache.org/repos/dist/dev/pulsar/KEYS Please download these packages and review this release candidate: - Review release notes https://github.com/apache/pulsar-client-go/pull/804 - Download the source package (verify shasum, and asc) and follow the README.md to build and run the pulsar-client-go. The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Source file: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.9.0-candidate-2/ The tag to be voted upon: v0.9.0 https://github.com/apache/pulsar-client-go/releases/tag/v0.9.0-candidate-2 SHA-512 checksums: 9731d6a0615288e77feb4b73fedbbdf6d275ebefeee3cee5fc4e849f38789863f0532c7e8b93eb1e601bd98f9bb21d50a714fcf87fac9987a745a052bbe23ca3 apache-pulsar-client-go-0.9.0-candidate-2-src.tar.gz Best, Xiaolong Ran
Re: [DISCUSS] Changed pulsar-go-client minimum Go SDK version from 1.15 to 1.16
Hello Matteo: Considering that some users are still using the Go 1.15 version, in the 0.9.0 release, we still use the form of hard code and set the form of pulsar-go-client to the version of 0.9.0. In order to ensure that the 0.9.0 release maintains backward compatibility, we may continue to do this for a while. When we scrap Go 1.15, we will use the official Go embed to dynamically configure pulsar Version information for -client-go. -- Thanks Xiaolong Ran Matteo Merli 于2022年9月29日周四 11:33写道： > +1 > > It would be good to determine and document a compatibility policy to state > which versions are going to be supported and for how long. > > On Wed, Sep 28, 2022 at 8:31 PM 沈家琦 wrote: > > > +1 > > pulsar-go-client from Go 1.15 to Go 1.16 > > > > Thanks > > > > r...@apache.org 于2022年9月29日周四 11:11写道： > > > > > Hello everyone: > > > > > > In the current version of pulsar-go-client, we do not support embedding > > the > > > version information of pulsar-go-client into > > > Client Command to send to the Broker. Now the hard code is fixed to > > 0.1.0. > > > This makes it impossible for us to determine > > > which version of pulsar-go-client the current user is using through the > > > version information. > > > > > > To support this feature, the more clumsy method is described using > > > https://github.com/apache/pulsar-client-go/pull/820. > > > However, Go 1.16 officially supports the feature of embed ( > > > https://pkg.go.dev/embed), which supports reading the > > > specified file directly, which seems to be a more elegant way, but this > > > requires Go 1.16 version. Yes, the current minimum > > > version supported by our pulsar-go-client is Go 1.15, which requires us > > to > > > change the minimum version of > > > pulsar-go-client from Go 1.15 to Go 1.16. > > > > > > So here we start a discussion within the community to see if we can > make > > > this change. > > > > > > -- > > > Thanks > > > Xiaolong Ran > > > > > > -- > -- > Matteo Merli > >
Re: [VOTE] Pulsar Client Go Release 0.9.0 Candidate 2
+1(non-binding) - Check sha 512 value for source code - Check go build producer example Thanks, Guangning r...@apache.org 于2022年9月29日周四 14:35写道： > Hi everyone, > > Please review and vote on the release candidate #2 for the version 0.9.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > This is the second release candidate for Apache Pulsar Go client, > version 0.9.0. > > It fixes the following issues: > https://github.com/apache/pulsar-client-go/milestone/10?closed=1 > > Pulsar Client Go's KEYS file contains PGP keys we used to sign this > release: > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > Please download these packages and review this release candidate: > - Review release notes https://github.com/apache/pulsar-client-go/pull/804 > - Download the source package (verify shasum, and asc) and follow the > README.md to build and run the pulsar-client-go. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Source file: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.9.0-candidate-2/ > > The tag to be voted upon: > v0.9.0 > https://github.com/apache/pulsar-client-go/releases/tag/v0.9.0-candidate-2 > > SHA-512 checksums: > > 9731d6a0615288e77feb4b73fedbbdf6d275ebefeee3cee5fc4e849f38789863f0532c7e8b93eb1e601bd98f9bb21d50a714fcf87fac9987a745a052bbe23ca3 > apache-pulsar-client-go-0.9.0-candidate-2-src.tar.gz > > Best, > > Xiaolong Ran >
