-1 In https://github.com/apache/pulsar-client-go/pull/777 we introduce the function of AckResponse, but the modification of this function blocks the original unit test, so this piece of logic needs to be refactored.
At present, the problem has been fixed, I will close the current Vote and re-launch the voting process for 0.9.0 Candidate 2. Guangning E <eguangn...@gmail.com> 于2022年9月26日周一 16:07写道： > +1(non-binding) > - Check sha 512 value for source code > - Check go build > > Thanks, > Guangning > > Rui Fu <r...@apache.org> 于2022年7月7日周四 10:58写道： > > > Hi everyone, > > > > Please review and vote on the release candidate #1 for the version 0.9.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > This is the first release candidate for Apache Pulsar Go client, > > version 0.9.0. > > > > It fixes the following issues: > > https://github.com/apache/pulsar-client-go/milestone/10?closed=1 > > > > Pulsar Client Go's KEYS file contains PGP keys we used to sign this > > release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > Please download these packages and review this release candidate: > > - Review release notes > https://github.com/apache/pulsar-client-go/pull/804 > > - Download the source package (verify shasum, and asc) and follow the > > README.md to build and run the pulsar-client-go. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Source file: > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.9.0-candidate-1/ > > > > The tag to be voted upon: > > v0.9.0 > > > https://github.com/apache/pulsar-client-go/releases/tag/v0.9.0-candidate-1 > > > > SHA-512 checksums: > > > 79b4b86e35d5aa16c8e8361a9f3f2532075efe93fc79c7f49424b708e31b6716194d3c053af5f8432a52573bb12e5fc1144a2529243066861f692c4c0743a807 > > apache-pulsar-client-go-0.9.0-src.tar.gz > > > > Best, > > > > Rui Fu > > >
