[PATCH] net/mana: use mana_local_data for tracking usage data for primary process

[longli]

From: Long Li 

The driver uses mana_shared_data for tracking usage count for primary
process. This is not correct as the mana_shared_data is allocated
by the primary and is meant to track usage of secondary process by the
primary process. And it creates a race condition when the device is
removed because the counter is no longer available if this shared
memory is being freed.

Move the usage count tracking to mana_local_data and fix the race
condition in mana_pci_remove().

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
Cc: sta...@dpdk.org
Signed-off-by: Long Li 
---
 drivers/net/mana/mana.c | 76 ++---
 1 file changed, 48 insertions(+), 28 deletions(-)

diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
index c37c4e3444..da4a54144f 100644
--- a/drivers/net/mana/mana.c
+++ b/drivers/net/mana/mana.c
@@ -1167,8 +1167,12 @@ mana_init_shared_data(void)
rte_spinlock_lock(&mana_shared_data_lock);
 
/* Skip if shared data is already initialized */
-   if (mana_shared_data)
+   if (mana_shared_data) {
+   DRV_LOG(INFO, "shared data is already initialized");
goto exit;
+   }
+
+   memset(&mana_local_data, 0, sizeof(mana_local_data));
 
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
mana_shared_mz = rte_memzone_reserve(MZ_MANA_SHARED_DATA,
@@ -1192,7 +1196,6 @@ mana_init_shared_data(void)
}
 
mana_shared_data = secondary_mz->addr;
-   memset(&mana_local_data, 0, sizeof(mana_local_data));
}
 
 exit:
@@ -1213,11 +1216,11 @@ mana_init_once(void)
if (ret)
return ret;
 
-   rte_spinlock_lock(&mana_shared_data->lock);
+   rte_spinlock_lock(&mana_shared_data_lock);
 
switch (rte_eal_process_type()) {
case RTE_PROC_PRIMARY:
-   if (mana_shared_data->init_done)
+   if (mana_local_data.init_done)
break;
 
ret = mana_mp_init_primary();
@@ -1225,7 +1228,7 @@ mana_init_once(void)
break;
DRV_LOG(ERR, "MP INIT PRIMARY");
 
-   mana_shared_data->init_done = 1;
+   mana_local_data.init_done = 1;
break;
 
case RTE_PROC_SECONDARY:
@@ -1248,7 +1251,7 @@ mana_init_once(void)
break;
}
 
-   rte_spinlock_unlock(&mana_shared_data->lock);
+   rte_spinlock_unlock(&mana_shared_data_lock);
 
return ret;
 }
@@ -1319,11 +1322,6 @@ mana_probe_port(struct ibv_device *ibdev, struct 
ibv_device_attr_ex *dev_attr,
eth_dev->tx_pkt_burst = mana_tx_burst;
eth_dev->rx_pkt_burst = mana_rx_burst;
 
-   rte_spinlock_lock(&mana_shared_data->lock);
-   mana_shared_data->secondary_cnt++;
-   mana_local_data.secondary_cnt++;
-   rte_spinlock_unlock(&mana_shared_data->lock);
-
rte_eth_copy_pci_info(eth_dev, pci_dev);
rte_eth_dev_probing_finish(eth_dev);
 
@@ -1406,10 +1404,6 @@ mana_probe_port(struct ibv_device *ibdev, struct 
ibv_device_attr_ex *dev_attr,
goto failed;
}
 
-   rte_spinlock_lock(&mana_shared_data->lock);
-   mana_shared_data->primary_cnt++;
-   rte_spinlock_unlock(&mana_shared_data->lock);
-
eth_dev->device = &pci_dev->device;
 
DRV_LOG(INFO, "device %s at port %u", name, eth_dev->data->port_id);
@@ -1552,13 +1546,42 @@ mana_pci_probe(struct rte_pci_driver *pci_drv 
__rte_unused,
count = mana_pci_probe_mac(pci_dev, NULL);
}
 
+   /* If no device is found, clean up resources if this is the last one */
if (!count) {
-   rte_memzone_free(mana_shared_mz);
-   mana_shared_mz = NULL;
-   ret = -ENODEV;
+   rte_spinlock_lock(&mana_shared_data_lock);
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+   if (!mana_local_data.primary_cnt) {
+   mana_mp_uninit_primary();
+   rte_memzone_free(mana_shared_mz);
+   mana_shared_mz = NULL;
+   mana_shared_data = NULL;
+   }
+   } else {
+   if (!mana_local_data.secondary_cnt) {
+   mana_mp_uninit_secondary();
+   mana_shared_data = NULL;
+   }
+   }
+   rte_spinlock_unlock(&mana_shared_data_lock);
+   return -ENODEV;
}
 
-   return ret;
+   /* At least one eth_dev is probed, init shared data */
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+   rte_spinlock_lock(&mana_shared_data_lock);
+   mana_local_data.primary_cnt++;
+   rte_spinlock_unlock(&mana_share

[PATCH v7 04/28] net/rnp: support mailbox basic operate

[Wenbo Cao]

This patch adds support for mailbox of rnp PMD driver,
mailbox is used for communication between pf with fw
and vf driver.

Signed-off-by: Wenbo Cao 
Reviewed-by: Stephen Hemminger 
---
 drivers/net/rnp/base/meson.build |  22 ++
 drivers/net/rnp/base/rnp_hw.h|  76 ++
 drivers/net/rnp/base/rnp_mbx.c   | 512 +++
 drivers/net/rnp/base/rnp_mbx.h   |  58 +
 drivers/net/rnp/base/rnp_osdep.h |  53 
 drivers/net/rnp/meson.build  |   5 +
 drivers/net/rnp/rnp.h|  19 ++
 7 files changed, 745 insertions(+)
 create mode 100644 drivers/net/rnp/base/meson.build
 create mode 100644 drivers/net/rnp/base/rnp_hw.h
 create mode 100644 drivers/net/rnp/base/rnp_mbx.c
 create mode 100644 drivers/net/rnp/base/rnp_mbx.h
 create mode 100644 drivers/net/rnp/base/rnp_osdep.h

diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
new file mode 100644
index 000..9ea88c3
--- /dev/null
+++ b/drivers/net/rnp/base/meson.build
@@ -0,0 +1,22 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(C) 2023 Mucse IC Design Ltd.
+
+sources = [
+'rnp_mbx.c',
+]
+
+error_cflags = ['-Wno-unused-value',
+'-Wno-unused-but-set-variable',
+'-Wno-unused-parameter',
+]
+c_args = cflags
+foreach flag: error_cflags
+if cc.has_argument(flag)
+c_args += flag
+endif
+endforeach
+
+base_lib = static_library('rnp_base', sources,
+dependencies: [static_rte_eal, static_rte_net, static_rte_ethdev],
+c_args: c_args)
+base_objs = base_lib.extract_all_objects(recursive: true)
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
new file mode 100644
index 000..959b4c3
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -0,0 +1,76 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_HW_H__
+#define __RNP_HW_H__
+
+#include "rnp_osdep.h"
+
+struct rnp_hw;
+/* Mailbox Operate Info */
+enum RNP_MBX_ID {
+   RNP_MBX_PF = 0,
+   RNP_MBX_VF,
+   RNP_MBX_FW = 64,
+};
+
+struct rnp_mbx_ops {
+   int (*read)(struct rnp_hw *hw,
+   u32 *msg,
+   u16 size,
+   enum RNP_MBX_ID);
+   int (*write)(struct rnp_hw *hw,
+   u32 *msg,
+   u16 size,
+   enum RNP_MBX_ID);
+   int (*read_posted)(struct rnp_hw *hw,
+   u32 *msg,
+   u16 size,
+   enum RNP_MBX_ID);
+   int (*write_posted)(struct rnp_hw *hw,
+   u32 *msg,
+   u16 size,
+   enum RNP_MBX_ID);
+   int (*check_for_msg)(struct rnp_hw *hw, enum RNP_MBX_ID);
+   int (*check_for_ack)(struct rnp_hw *hw, enum RNP_MBX_ID);
+   int (*check_for_rst)(struct rnp_hw *hw, enum RNP_MBX_ID);
+};
+
+struct rnp_mbx_sync {
+   u16 req;
+   u16 ack;
+};
+
+struct rnp_mbx_info {
+   const struct rnp_mbx_ops *ops;
+   u32 usec_delay; /* retry interval delay time */
+   u32 timeout;/* retry ops timeout limit */
+   u16 size;   /* data buffer size*/
+   u16 vf_num; /* Virtual Function num */
+   u16 pf_num; /* Physical Function num */
+   u16 sriov_st;   /* Sriov state */
+   u16 en_vfs; /* user enabled vf num */
+   bool is_pf;
+
+   struct rnp_mbx_sync syncs[RNP_MBX_FW];
+};
+
+struct rnp_eth_adapter;
+
+/* hw device description */
+struct rnp_hw {
+   struct rnp_eth_adapter *back;   /* backup to the adapter handle */
+   void __iomem *e_ctrl;   /* ethernet control bar */
+   void __iomem *c_ctrl;   /* crypto control bar */
+   u32 c_blen; /* crypto bar size */
+
+   /* pci device info */
+   u16 device_id;
+   u16 vendor_id;
+   u16 max_vfs;/* device max support vf */
+
+   u16 pf_vf_num;
+   struct rnp_mbx_info mbx;
+};
+
+#endif /* __RNP_H__*/
diff --git a/drivers/net/rnp/base/rnp_mbx.c b/drivers/net/rnp/base/rnp_mbx.c
new file mode 100644
index 000..a53404a
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_mbx.c
@@ -0,0 +1,512 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include 
+
+#include "rnp_hw.h"
+#include "rnp_mbx.h"
+#include "../rnp.h"
+
+/PF MBX OPS/
+static inline u16
+rnp_mbx_get_req(struct rnp_hw *hw, enum RNP_MBX_ID mbx_id)
+{
+   u32 reg = 0;
+
+   if (mbx_id == RNP_MBX_FW)
+   reg = RNP_FW2PF_SYNC;
+   else
+   reg = RNP_VF2PF_SYNC(mbx_id);
+   mb();
+
+   return RNP_E_REG_RD(hw, reg) & RNP_MBX_SYNC_REQ_MASK;
+}
+
+static inline u16
+rnp_mbx_get_ack(struct rnp_hw *hw, enum RNP_MBX_ID mbx_id)
+{
+   u32 reg = 0;
+   u32 v = 0;
+
+   if (mbx_

[PATCH v7 06/28] net/rnp: add get device information operation

[Wenbo Cao]

add get device hardware capability function

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |   1 +
 drivers/net/rnp/base/rnp_fw_cmd.c |  20 +++
 drivers/net/rnp/base/rnp_fw_cmd.h |  80 +++
 drivers/net/rnp/base/rnp_mbx_fw.c |  58 +++
 drivers/net/rnp/base/rnp_mbx_fw.h |   1 +
 drivers/net/rnp/rnp.h |  73 +++-
 drivers/net/rnp/rnp_ethdev.c  | 113 +-
 7 files changed, 344 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 2ad04ee..6766130 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -4,5 +4,6 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
+Speed capabilities   = Y
 Linux= Y
 x86-64   = Y
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index 064ba9e..34a88a1 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -51,6 +51,23 @@
arg->pfvf_num = req_arg->param1;
 }
 
+static inline void
+rnp_build_get_lane_status_req(struct rnp_mbx_fw_cmd_req *req,
+ struct rnp_fw_req_arg *req_arg,
+ void *cookie)
+{
+   struct rnp_get_lane_st_req *arg = (struct rnp_get_lane_st_req 
*)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_GET_LANE_STATUS;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -67,6 +84,9 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_GET_MAC_ADDRESS:
rnp_build_get_macaddress_req(req, arg, cookie);
break;
+   case RNP_GET_LANE_STATUS:
+   rnp_build_get_lane_status_req(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index fb7a0af..c34fc5c 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -129,6 +129,80 @@ struct rnp_mac_addr_rep {
u32 pcode;
 };
 
+#define RNP_SPEED_CAP_UNKNOWN(0)
+#define RNP_SPEED_CAP_10M_FULL   RTE_BIT32(2)
+#define RNP_SPEED_CAP_100M_FULL  RTE_BIT32(3)
+#define RNP_SPEED_CAP_1GB_FULL   RTE_BIT32(4)
+#define RNP_SPEED_CAP_10GB_FULL  RTE_BIT32(5)
+#define RNP_SPEED_CAP_40GB_FULL  RTE_BIT32(6)
+#define RNP_SPEED_CAP_25GB_FULL  RTE_BIT32(7)
+#define RNP_SPEED_CAP_50GB_FULL  RTE_BIT32(8)
+#define RNP_SPEED_CAP_100GB_FULL RTE_BIT32(9)
+#define RNP_SPEED_CAP_10M_HALF   RTE_BIT32(10)
+#define RNP_SPEED_CAP_100M_HALF  RTE_BIT32(11)
+#define RNP_SPEED_CAP_1GB_HALF   RTE_BIT32(12)
+
+enum rnp_pma_phy_type {
+   RNP_PHY_TYPE_NONE = 0,
+   RNP_PHY_TYPE_1G_BASE_KX,
+   RNP_PHY_TYPE_SGMII,
+   RNP_PHY_TYPE_10G_BASE_KR,
+   RNP_PHY_TYPE_25G_BASE_KR,
+   RNP_PHY_TYPE_40G_BASE_KR4,
+   RNP_PHY_TYPE_10G_BASE_SR,
+   RNP_PHY_TYPE_40G_BASE_SR4,
+   RNP_PHY_TYPE_40G_BASE_CR4,
+   RNP_PHY_TYPE_40G_BASE_LR4,
+   RNP_PHY_TYPE_10G_BASE_LR,
+   RNP_PHY_TYPE_10G_BASE_ER,
+   RNP_PHY_TYPE_10G_TP,
+};
+
+struct rnp_lane_stat_rep {
+   u8 nr_lane; /* 0-3 cur port correspond with hw lane */
+   u8 pci_gen  : 4; /* nic cur pci speed genX: 1,2,3 */
+   u8 pci_lanes: 4; /* nic cur pci x1 x2 x4 x8 x16 */
+   u8 pma_type;
+   u8 phy_type;/* interface media type */
+
+   u16 linkup  : 1; /* cur port link state */
+   u16 duplex  : 1; /* duplex state only RJ45 valid */
+   u16 autoneg : 1; /* autoneg state */
+   u16 fec : 1; /* fec state */
+   u16 rev_an  : 1;
+   u16 link_traing : 1; /* link-traing state */
+   u16 media_availble  : 1;
+   u16 is_sgmii: 1; /* 1: Twisted Pair 0: FIBRE */
+   u16 link_fault  : 4;
+#define RNP_LINK_LINK_FAULTRTE_BIT32(0)
+#define RNP_LINK_TX_FAULT  RTE_BIT32(1)
+#define RNP_LINK_RX_FAULT  RTE_BIT32(2)
+#define RNP_LINK_REMOTE_FAULT  RTE_BIT32(3)
+   u16 is_backplane: 1;   /* Backplane Mode */
+   u16 is_speed_10G_1G_auto_switch_enabled : 1;
+   u16 rsvd0   : 2;
+   union {
+   u8 phy_addr;/* Phy MDIO address */
+   struct {
+   u8 mod_abs : 1;
+   u8 fault   : 1;
+   u8 tx_dis  : 1;
+   u8 los : 1;
+   u8 rsvd1   : 4;
+   } sfp;
+   };
+   u8 sfp_connector;
+  

[PATCH v7 01/28] net/rnp: add skeleton

[Wenbo Cao]

Add basic PMD library and doc build infrastructure
Update maintainers file to claim responsibility.

Signed-off-by: Wenbo Cao 
Reviewed-by: Thomas Monjalon 
---
 MAINTAINERS  |  6 +++
 doc/guides/nics/features/rnp.ini |  8 
 doc/guides/nics/index.rst|  1 +
 doc/guides/nics/rnp.rst  | 82 
 drivers/net/meson.build  |  1 +
 5 files changed, 98 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index 812463f..cf4806e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -974,6 +974,12 @@ F: drivers/net/qede/
 F: doc/guides/nics/qede.rst
 F: doc/guides/nics/features/qede*.ini
 
+Mucse rnp
+M: Wenbo Cao 
+F: drivers/net/rnp
+F: doc/guides/nics/rnp.rst
+F: doc/guides/nics/features/rnp.ini
+
 Solarflare sfc_efx
 M: Andrew Rybchenko 
 F: drivers/common/sfc_efx/
diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
new file mode 100644
index 000..2ad04ee
--- /dev/null
+++ b/doc/guides/nics/features/rnp.ini
@@ -0,0 +1,8 @@
+;
+; Supported features of the 'rnp' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux= Y
+x86-64   = Y
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index c14bc79..b12f409 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -60,6 +60,7 @@ Network Interface Controller Drivers
 pcap_ring
 pfe
 qede
+rnp
 sfc_efx
 softnic
 tap
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
new file mode 100644
index 000..618baa8
--- /dev/null
+++ b/doc/guides/nics/rnp.rst
@@ -0,0 +1,82 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2023 Mucse IC Design Ltd.
+
+RNP Poll Mode driver
+
+
+The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev
+driver support for the inbuilt network device found in the **Mucse RNP**
+
+Prerequisites
+-
+More information can be found at `Mucse, Official Website
+`_.
+For English version you can download the below pdf.
+``
+
+Supported Chipsets and NICs
+---
+
+- MUCSE Ethernet Controller N10 Series for 10GbE or 40GbE (Dual-port)
+
+Chip Basic Overview
+---
+N10 isn't normal with traditional PCIe network card, The chip only have two 
pcie physical function.
+The Chip max can support eight ports.
+
+.. code-block:: console
+
+  ++
+  |  OS|
+  |   PCIE (PF0)   |
+  ||||||
+  +||||+
+   ||||
+ +-||||-+
+ |Extend Mac|
+ |  VLAN/Unicast/multicast  |
+ | Promisc Mode  Ctrl   |
+ |  |
+ +-||||-+
+   ||||
+   +---|---++---|---++---|---++---|---+
+   |   ||   ||   ||   |
+   | MAC 0 || MAC 1 || MAC 2 || MAC 3 |
+   |   ||   ||   ||   |
+   +---|---++---|---++---|---++---|---+
+   ||||
+   +---|---++---|---++---|---++---|---+
+   |   ||   ||   ||   |
+   | PORT 0|| PORT 1|| PORT 2|| PORT 3|
+   |   ||   ||   ||   |
+   +---++---++---++---+
+
+  ++
+  |   OS   |
+  |   PCIE (PF1)   |
+  ||||||
+  +||||+
+   ||||
+ +-||||-+
+ |Extend Mac|
+ |   VLAN/Unicast/multicast |
+ | Promisc Mode  Ctrl   |
+ |  |
+ +-||||-+
+   ||||
+   +---|---++---|---++---|---++---|---+
+   |   ||   ||   ||   |
+   | MAC 4 || MAC 5 || MAC 6 || MAC 7 |
+   |   ||   ||   ||   |
+   +---|---++---|---++---|---++---|---+
+   ||||
+   +---|---++---|--

[PATCH v7 00/28] [v6]drivers/net Add Support mucse N10 Pmd Driver

[Wenbo Cao]

For This patchset just to support the basic chip init work
and user can just found the eth_dev, but can't control more.
For Now just support 2*10g nic,the chip can support
2*10g,4*10g,4*1g,8*1g,8*10g.
The Feature rx side can support rx-cksum-offload,rss,vlan-filter
flow_clow,uncast_filter,mcast_filter,1588,Jumbo-frame
The Feature tx side can supprt tx-cksum-offload,tso,vxlan-tso 
flow director base on ntuple pattern of tcp/udp/ip/ eth_hdr->type
for sriov is also support.

Because of the chip desgin defect, for multiple-port mode
one pci-bdf will have multiple-port (max can have four ports)
so this code must be care of one bdf init multiple-port.

v7:
  * add suport nic basic feature such as rss vlan strip/filter,
  * mtu-change recv/send scater-recv/mutltiple-send.
  * fixed code rationality, adviced by Ferruh Yigit.
v6:
  * fixed the doc(rst) format problem advise by Thomas Monjalon

v5:
  * fixed the symbol name require by the style documentation

v4:
  * one patch has been forgot to upload :(

v3:
  * fixed http://dpdk.org/patch/129830 FreeBSD 13 compile Issue
  * change iobar type to void suggest by Stephen Hemminger
  * add KMOD_DEP support for vfio-pci
  * change run-cmd argument parse check for invalid extra_args

v2:
  * fixed MAINTAIN maillist fullname format
  * fixed driver/net/meson the order issue of new driver to driver list
  * improve virtual point function usage suggest by Stephen Hemminger


Wenbo Cao (28):
  net/rnp: add skeleton
  net/rnp: add ethdev probe and remove
  net/rnp: add log
  net/rnp: support mailbox basic operate
  net/rnp: add device init and uninit
  net/rnp: add get device information operation
  net/rnp: add support mac promisc mode
  net/rnp: add queue setup and release operations
  net/rnp: add queue stop and start operations
  net/rnp: add support device start stop operations
  net/rnp: add RSS support operations
  net/rnp: add support link update operations.
  net/rnp: add support link setup operations
  net/rnp: add Rx burst simple support
  net/rnp: add Tx burst simple support
  net/rnp: add MTU set operation
  net/rnp: add Rx scatter segment version
  net/rnp: add Tx multiple segment version
  net/rnp: add support basic stats operation
  net/rnp: add support xstats operation
  net/rnp: add unicast MAC filter operation
  net/rnp: add supported packet types
  net/rnp: add support Rx checksum offload
  net/rnp: add support Tx TSO offload
  net/rnp: support VLAN offloads.
  net/rnp: add support VLAN filters operations.
  net/rnp: add queue info operation.
  net/rnp: support Rx/Tx burst mode info

 MAINTAINERS |6 +
 doc/guides/nics/features/rnp.ini|   33 +
 doc/guides/nics/index.rst   |1 +
 doc/guides/nics/rnp.rst |  100 ++
 drivers/net/meson.build |1 +
 drivers/net/rnp/base/meson.build|   28 +
 drivers/net/rnp/base/rnp_bdq_if.c   |  397 
 drivers/net/rnp/base/rnp_bdq_if.h   |  154 +++
 drivers/net/rnp/base/rnp_bitrev.h   |   64 ++
 drivers/net/rnp/base/rnp_common.c   |  103 ++
 drivers/net/rnp/base/rnp_common.h   |   17 +
 drivers/net/rnp/base/rnp_crc32.c|   37 +
 drivers/net/rnp/base/rnp_crc32.h|   10 +
 drivers/net/rnp/base/rnp_dma_regs.h |   68 ++
 drivers/net/rnp/base/rnp_eth_regs.h |   90 ++
 drivers/net/rnp/base/rnp_fw_cmd.c   |  162 
 drivers/net/rnp/base/rnp_fw_cmd.h   |  358 +++
 drivers/net/rnp/base/rnp_hw.h   |  136 +++
 drivers/net/rnp/base/rnp_mac.c  |  367 +++
 drivers/net/rnp/base/rnp_mac.h  |   34 +
 drivers/net/rnp/base/rnp_mac_regs.h |  207 
 drivers/net/rnp/base/rnp_mbx.c  |  512 ++
 drivers/net/rnp/base/rnp_mbx.h  |   58 ++
 drivers/net/rnp/base/rnp_mbx_fw.c   |  499 ++
 drivers/net/rnp/base/rnp_mbx_fw.h   |   24 +
 drivers/net/rnp/base/rnp_osdep.h|  174 
 drivers/net/rnp/meson.build |   20 +
 drivers/net/rnp/rnp.h   |  258 +
 drivers/net/rnp/rnp_ethdev.c| 1827 +++
 drivers/net/rnp/rnp_link.c  |  439 +
 drivers/net/rnp/rnp_link.h  |   38 +
 drivers/net/rnp/rnp_logs.h  |   37 +
 drivers/net/rnp/rnp_rss.c   |  367 +++
 drivers/net/rnp/rnp_rss.h   |   43 +
 drivers/net/rnp/rnp_rxtx.c  | 1820 ++
 drivers/net/rnp/rnp_rxtx.h  |  162 
 36 files changed, 8651 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst
 create mode 100644 drivers/net/rnp/base/meson.build
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.c
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.h
 create mode 100644 drivers/net/rnp/base/rnp_bitrev.h
 create mode 100644 drivers/net/rnp/base/rnp_common.c
 create mode 100644 drivers/net/rnp/base/rnp_common.h
 create mode 100644 drivers/net/rnp/base/rnp_crc32.c
 create mode 100644 drivers/net/rnp/base/rnp_crc32.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs

[PATCH v7 02/28] net/rnp: add ethdev probe and remove

[Wenbo Cao]

Add basic PCIe ethdev probe and remove.

Signed-off-by: Wenbo Cao 
Reviewed-by: Stephen Hemminger 
---
 drivers/net/rnp/meson.build  | 11 +++
 drivers/net/rnp/rnp.h| 13 
 drivers/net/rnp/rnp_ethdev.c | 77 
 3 files changed, 101 insertions(+)
 create mode 100644 drivers/net/rnp/meson.build
 create mode 100644 drivers/net/rnp/rnp.h
 create mode 100644 drivers/net/rnp/rnp_ethdev.c

diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
new file mode 100644
index 000..4f37c6b
--- /dev/null
+++ b/drivers/net/rnp/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(C) 2023 Mucse IC Design Ltd.
+#
+if not is_linux
+build = false
+reason = 'only supported on Linux'
+endif
+
+sources = files(
+   'rnp_ethdev.c',
+)
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
new file mode 100644
index 000..6cd717a
--- /dev/null
+++ b/drivers/net/rnp/rnp.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_H__
+#define __RNP_H__
+
+#define PCI_VENDOR_ID_MUCSE(0x8848)
+#define RNP_DEV_ID_N10G(0x1000)
+
+struct rnp_eth_port {
+};
+
+#endif /* __RNP_H__ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
new file mode 100644
index 000..2f34f88
--- /dev/null
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -0,0 +1,77 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include 
+#include 
+#include 
+
+#include "rnp.h"
+
+static int
+rnp_eth_dev_init(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_eth_dev_uninit(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_pci_remove(struct rte_pci_device *pci_dev)
+{
+   struct rte_eth_dev *eth_dev;
+   int rc;
+
+   eth_dev = rte_eth_dev_allocated(pci_dev->device.name);
+
+   if (eth_dev) {
+   /* Cleanup eth dev */
+   rc = rte_eth_dev_pci_generic_remove(pci_dev,
+   rnp_eth_dev_uninit);
+   if (rc)
+   return rc;
+   }
+
+   return 0;
+}
+
+static int
+rnp_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
+{
+   int rc;
+
+   RTE_SET_USED(pci_drv);
+
+   rc = rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct rnp_eth_port),
+  rnp_eth_dev_init);
+
+   return rc;
+}
+
+static const struct rte_pci_id pci_id_rnp_map[] = {
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_MUCSE, RNP_DEV_ID_N10G)
+   },
+   {
+   .vendor_id = 0,
+   },
+};
+
+static struct rte_pci_driver rte_rnp_pmd = {
+   .id_table = pci_id_rnp_map,
+   .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
+   .probe = rnp_pci_probe,
+   .remove = rnp_pci_remove,
+};
+
+RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd);
+RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map);
+RTE_PMD_REGISTER_KMOD_DEP(net_rnp, "igb_uio | uio_pci_generic | vfio-pci");
-- 
1.8.3.1

[PATCH v7 03/28] net/rnp: add log

[Wenbo Cao]

add log function for trace or debug

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_logs.h   | 37 +
 2 files changed, 39 insertions(+)
 create mode 100644 drivers/net/rnp/rnp_logs.h

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 2f34f88..389c6ad 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -72,6 +72,8 @@
.remove = rnp_pci_remove,
 };
 
+RTE_LOG_REGISTER_SUFFIX(rnp_init_logtype, init, NOTICE);
+
 RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_rnp, "igb_uio | uio_pci_generic | vfio-pci");
diff --git a/drivers/net/rnp/rnp_logs.h b/drivers/net/rnp/rnp_logs.h
new file mode 100644
index 000..078c752
--- /dev/null
+++ b/drivers/net/rnp/rnp_logs.h
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#ifndef __RNP_LOGS_H__
+#define __RNP_LOGS_H__
+
+#include 
+
+extern int rnp_init_logtype;
+
+#define RNP_PMD_INIT_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, rnp_init_logtype, "%s(): " fmt "\n", \
+ __func__, ##args)
+#define PMD_INIT_FUNC_TRACE() RNP_PMD_INIT_LOG(DEBUG, " >>")
+#define RNP_PMD_DRV_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_##level, rnp_init_logtype, \
+   "%s() " fmt "\n", __func__, ##args)
+#define RNP_PMD_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_##level, rnp_init_logtype, \
+   "rnp_net: (%d) " fmt "\n", __LINE__, ##args)
+#define RNP_PMD_ERR(fmt, args...) \
+   RNP_PMD_LOG(ERR, fmt, ## args)
+#define RNP_PMD_WARN(fmt, args...) \
+   RNP_PMD_LOG(WARNING, fmt, ## args)
+#define RNP_PMD_INFO(fmt, args...) \
+   RNP_PMD_LOG(INFO, fmt, ## args)
+
+#ifdef RTE_LIBRTE_RNP_REG_DEBUG
+#define RNP_PMD_REG_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, rnp_init_logtype, \
+   "%s(): " fmt "\n", __func__, ##args)
+#else
+#define RNP_PMD_REG_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#endif /* __RNP_LOGS_H__ */
-- 
1.8.3.1

[PATCH v7 10/28] net/rnp: add support device start stop operations

[Wenbo Cao]

add basic support for device to start/stop function

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_common.c   |  22 +++
 drivers/net/rnp/base/rnp_common.h   |   1 +
 drivers/net/rnp/base/rnp_dma_regs.h |  10 ++
 drivers/net/rnp/base/rnp_eth_regs.h |   5 +
 drivers/net/rnp/base/rnp_hw.h   |   1 +
 drivers/net/rnp/base/rnp_mac.h  |  14 ++
 drivers/net/rnp/base/rnp_mac_regs.h |  42 ++
 drivers/net/rnp/rnp.h   |   3 +
 drivers/net/rnp/rnp_ethdev.c| 274 +++-
 9 files changed, 371 insertions(+), 1 deletion(-)

diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 7d1f96c..38a3f55 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -79,3 +79,25 @@ int rnp_init_hw(struct rnp_hw *hw)
 
return 0;
 }
+
+int rnp_clock_valid_check(struct rnp_hw *hw, u16 nr_lane)
+{
+   uint16_t timeout = 0;
+
+   do {
+   RNP_E_REG_WR(hw, RNP_RSS_REDIR_TB(nr_lane, 0), 0x7f);
+   udelay(10);
+   timeout++;
+   if (timeout >= 1000)
+   break;
+   } while (RNP_E_REG_RD(hw, RNP_RSS_REDIR_TB(nr_lane, 0)) != 0x7f);
+
+   if (timeout >= 1000) {
+   RNP_PMD_ERR("ethernet[%d] eth reg can't be write", nr_lane);
+   return -EPERM;
+   }
+   /* clear the dirty value */
+   RNP_E_REG_WR(hw, RNP_RSS_REDIR_TB(nr_lane, 0), 0);
+
+   return 0;
+}
diff --git a/drivers/net/rnp/base/rnp_common.h 
b/drivers/net/rnp/base/rnp_common.h
index bd00708..958fcb6 100644
--- a/drivers/net/rnp/base/rnp_common.h
+++ b/drivers/net/rnp/base/rnp_common.h
@@ -12,5 +12,6 @@
 ((macaddr[4] << 8)) | (macaddr[5]))
 int rnp_init_hw(struct rnp_hw *hw);
 int rnp_setup_common_ops(struct rnp_hw *hw);
+int rnp_clock_valid_check(struct rnp_hw *hw, u16 nr_lane);
 
 #endif /* _RNP_COMMON_H_ */
diff --git a/drivers/net/rnp/base/rnp_dma_regs.h 
b/drivers/net/rnp/base/rnp_dma_regs.h
index 3664c0a..32e738a 100644
--- a/drivers/net/rnp/base/rnp_dma_regs.h
+++ b/drivers/net/rnp/base/rnp_dma_regs.h
@@ -6,9 +6,19 @@
 #define _RNP_DMA_REGS_H_
 
 #define RNP_DMA_VERSION(0)
+#define RNP_DMA_CTRL   (0x4)
+/* 1bit <-> 16 bytes dma addr size */
+#define RNP_DMA_SCATTER_MEM_MASK   RTE_GENMASK32(31, 16)
+#define RNP_DMA_SCATTER_MEN_S  (16)
+#define RNP_DMA_RX_MEM_PAD_EN  RTE_BIT32(8)
+#define RTE_DMA_VEB_BYPASS RTE_BIT32(4)
+#define RNP_DMA_TXRX_LOOP  RTE_BIT32(1)
+#define RNP_DMA_TXMRX_LOOP RTE_BIT32(0)
+
 #define RNP_DMA_HW_EN  (0x10)
 #define RNP_DMA_EN_ALL (0b)
 #define RNP_DMA_HW_STATE   (0x14)
+
 /* --- queue register --- */
 /* queue enable */
 #define RNP_RXQ_START(qid) _RING_(0x0010 + 0x100 * (qid))
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 10e3d95..60766d2 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -10,6 +10,9 @@
 #define RNP_E_FILTER_EN_ETH_(0x801c)
 #define RNP_E_REDIR_EN _ETH_(0x8030)
 
+#define RNP_RX_ETH_F_CTRL(n)   _ETH_(0x8070 + ((n) * 0x8))
+#define RNP_RX_ETH_F_OFF   (0x7ff)
+#define RNP_RX_ETH_F_ON(0x270)
 /* rx queue flow ctrl */
 #define RNP_RX_FC_ENABLE   _ETH_(0x8520)
 #define RNP_RING_FC_EN(n)  _ETH_(0x8524 + ((0x4) * ((n) / 32)))
@@ -28,6 +31,8 @@
 #define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+/* rss function ctrl */
+#define RNP_RSS_REDIR_TB(n, id) _ETH_(0xe000 + ((n) * 0x200) + ((id) * 0x4))
 
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
 
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 4f5a73e..ed1e7eb 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -120,6 +120,7 @@ struct rnp_hw {
bool lane_is_sgmii[RNP_MAX_PORT_OF_PF];
struct rnp_mbx_info mbx;
struct rnp_fw_info fw_info;
+   u16 min_dma_size;
 
spinlock_t rxq_reset_lock;
spinlock_t txq_reset_lock;
diff --git a/drivers/net/rnp/base/rnp_mac.h b/drivers/net/rnp/base/rnp_mac.h
index 57cbd9e..1dac903 100644
--- a/drivers/net/rnp/base/rnp_mac.h
+++ b/drivers/net/rnp/base/rnp_mac.h
@@ -7,6 +7,20 @@
 
 #include "rnp_osdep.h"
 #include "rnp_hw.h"
+#include "rnp_eth_regs.h"
+
+#define RNP_RX_ETH_DISABLE(hw, nr_lane) do { \
+   wmb(); \
+   RNP_E_REG_WR(hw, RNP_RX_ETH_F_CTRL(nr_lane), \
+   RNP_RX_ETH_F_OFF); \
+} while (0)
+
+#define RNP_RX_ETH_ENABLE(hw, nr_lane) do { \
+   wmb(); \
+   RNP_E_REG_WR(hw, RNP_RX_ETH_F_CTRL(nr_lane), \
+   RNP_RX_ETH_F_ON); \
+} while (0)
+
 
 void rnp_mac_ops_init(struct rnp_hw *hw);
 int rnp_get_mac_addr(struct rnp_eth_port *port, u8 *mac);
diff --g

[PATCH v7 09/28] net/rnp: add queue stop and start operations

[Wenbo Cao]

support rx/tx queue stop/start,for rx queue stop
need to reset a queue,must stop all rx queue
durring reset this queue.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |   1 +
 drivers/net/rnp/base/rnp_common.c |   3 +
 drivers/net/rnp/rnp_link.c| 340 ++
 drivers/net/rnp/rnp_link.h|  36 
 drivers/net/rnp/rnp_rxtx.c| 167 +++
 drivers/net/rnp/rnp_rxtx.h|   9 +
 6 files changed, 556 insertions(+)
 create mode 100644 drivers/net/rnp/rnp_link.c
 create mode 100644 drivers/net/rnp/rnp_link.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 65f1ed3..fd7d4b9 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
 Linux= Y
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 3fa2a49..7d1f96c 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -65,6 +65,9 @@ int rnp_init_hw(struct rnp_hw *hw)
/* setup mac resiger ctrl base */
for (idx = 0; idx < hw->max_port_num; idx++)
hw->mac_base[idx] = (u8 *)hw->e_ctrl + RNP_MAC_BASE_OFFSET(idx);
+   /* tx all hw queue must be started */
+   for (idx = 0; idx < RNP_MAX_RX_QUEUE_NUM; idx++)
+   RNP_E_REG_WR(hw, RNP_TXQ_START(idx), true);
 
return 0;
 }
diff --git a/drivers/net/rnp/rnp_link.c b/drivers/net/rnp/rnp_link.c
new file mode 100644
index 000..2f94397
--- /dev/null
+++ b/drivers/net/rnp/rnp_link.c
@@ -0,0 +1,340 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include 
+
+#include "base/rnp_mac_regs.h"
+#include "base/rnp_dma_regs.h"
+#include "base/rnp_mac.h"
+#include "base/rnp_fw_cmd.h"
+#include "base/rnp_mbx_fw.h"
+
+#include "rnp.h"
+#include "rnp_rxtx.h"
+#include "rnp_link.h"
+
+static void
+rnp_link_flow_setup(struct rnp_eth_port *port)
+{
+   struct rnp_hw *hw = port->hw;
+   u32 ctrl = 0;
+   u16 lane = 0;
+
+   lane = port->attr.nr_lane;
+   rte_spinlock_lock(&port->rx_mac_lock);
+   ctrl = RNP_MAC_REG_RD(hw, lane, RNP_MAC_RX_CFG);
+   if (port->attr.link_ready) {
+   ctrl &= ~RNP_MAC_LM;
+   RNP_RX_ETH_ENABLE(hw, lane);
+   } else {
+   RNP_RX_ETH_DISABLE(hw, lane);
+   ctrl |= RNP_MAC_LM;
+   }
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_RX_CFG, ctrl);
+   rte_spinlock_unlock(&port->rx_mac_lock);
+}
+
+static uint64_t
+rnp_parse_speed_code(uint32_t speed_code)
+{
+   uint32_t speed = 0;
+
+   switch (speed_code) {
+   case RNP_LANE_SPEED_10M:
+   speed = RTE_ETH_SPEED_NUM_10M;
+   break;
+   case RNP_LANE_SPEED_100M:
+   speed = RTE_ETH_SPEED_NUM_100M;
+   break;
+   case RNP_LANE_SPEED_1G:
+   speed = RTE_ETH_SPEED_NUM_1G;
+   break;
+   case RNP_LANE_SPEED_10G:
+   speed = RTE_ETH_SPEED_NUM_10G;
+   break;
+   case RNP_LANE_SPEED_25G:
+   speed = RTE_ETH_SPEED_NUM_25G;
+   break;
+   case RNP_LANE_SPEED_40G:
+   speed = RTE_ETH_SPEED_NUM_40G;
+   break;
+   default:
+   speed = RTE_ETH_SPEED_NUM_UNKNOWN;
+   }
+
+   return speed;
+}
+
+static bool
+rnp_update_speed_changed(struct rnp_eth_port *port)
+{
+   struct rnp_hw *hw = port->hw;
+   uint32_t speed_code = 0;
+   bool speed_changed = 0;
+   bool duplex = false;
+   uint32_t magic = 0;
+   uint32_t linkstate;
+   uint64_t speed = 0;
+   uint16_t lane = 0;
+
+   lane = port->attr.nr_lane;
+   linkstate = RNP_E_REG_RD(hw, RNP_DEVICE_LINK_EX);
+   magic = linkstate & 0xF000;
+   /* check if speed is changed. even if link is not changed */
+   if (RNP_SPEED_META_VALID(magic) &&
+   (linkstate & RNP_LINK_STATE(lane))) {
+   speed_code = RNP_LINK_SPEED_CODE(linkstate, lane);
+   speed = rnp_parse_speed_code(speed_code);
+   if (speed != port->attr.speed) {
+   duplex = RNP_LINK_DUPLEX_STATE(linkstate, lane);
+   port->attr.phy_meta.link_duplex = duplex;
+   port->attr.speed = speed;
+   speed_changed = 1;
+   }
+   }
+
+   return speed_changed;
+}
+
+static bool
+rnp_update_link_changed(struct rnp_eth_port *port,
+   struct rnp_link_stat_req *link)
+{
+   uint16_t lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   uint32_t link_up_bit = 0;
+   bool link_changed = 0;
+   uint32_t sync_bit = 0;
+   bool duplex = 0;
+
+   link_up_bit = link->lane_status & RTE_

[PATCH v7 05/28] net/rnp: add device init and uninit

[Wenbo Cao]

add firmware communic method and basic device
init, uninit and close resource function.

Signed-off-by: Wenbo Cao 
Reviewed-by: Ferruh Yigit 
---
 drivers/net/rnp/base/meson.build|   4 +
 drivers/net/rnp/base/rnp_common.c   |  73 
 drivers/net/rnp/base/rnp_common.h   |  12 ++
 drivers/net/rnp/base/rnp_dma_regs.h |  13 ++
 drivers/net/rnp/base/rnp_eth_regs.h |  15 ++
 drivers/net/rnp/base/rnp_fw_cmd.c   |  75 
 drivers/net/rnp/base/rnp_fw_cmd.h   | 216 +++
 drivers/net/rnp/base/rnp_hw.h   |  39 +
 drivers/net/rnp/base/rnp_mac.c  |  28 +++
 drivers/net/rnp/base/rnp_mac.h  |  14 ++
 drivers/net/rnp/base/rnp_mbx_fw.c   | 338 
 drivers/net/rnp/base/rnp_mbx_fw.h   |  18 ++
 drivers/net/rnp/base/rnp_osdep.h| 100 ++-
 drivers/net/rnp/meson.build |   1 +
 drivers/net/rnp/rnp.h   |  40 +
 drivers/net/rnp/rnp_ethdev.c| 317 -
 16 files changed, 1290 insertions(+), 13 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_common.c
 create mode 100644 drivers/net/rnp/base/rnp_common.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_fw_cmd.c
 create mode 100644 drivers/net/rnp/base/rnp_fw_cmd.h
 create mode 100644 drivers/net/rnp/base/rnp_mac.c
 create mode 100644 drivers/net/rnp/base/rnp_mac.h
 create mode 100644 drivers/net/rnp/base/rnp_mbx_fw.c
 create mode 100644 drivers/net/rnp/base/rnp_mbx_fw.h

diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index 9ea88c3..b9db033 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -3,6 +3,10 @@
 
 sources = [
 'rnp_mbx.c',
+'rnp_fw_cmd.c',
+'rnp_mbx_fw.c',
+'rnp_common.c',
+'rnp_mac.c',
 ]
 
 error_cflags = ['-Wno-unused-value',
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
new file mode 100644
index 000..47a979b
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -0,0 +1,73 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include "rnp_osdep.h"
+#include "rnp_hw.h"
+#include "rnp_eth_regs.h"
+#include "rnp_dma_regs.h"
+#include "rnp_common.h"
+#include "rnp_mbx_fw.h"
+#include "rnp_mac.h"
+#include "../rnp.h"
+
+static void
+rnp_hw_reset(struct rnp_hw *hw)
+{
+   PMD_INIT_FUNC_TRACE();
+
+   RNP_E_REG_WR(hw, RNP_NIC_RESET, 0);
+   /* hardware reset valid must be 0 -> 1 */
+   wmb();
+   RNP_E_REG_WR(hw, RNP_NIC_RESET, 1);
+   RNP_PMD_DRV_LOG(INFO, "PF[%d] reset nic finish\n", hw->mbx.pf_num);
+}
+
+int rnp_init_hw(struct rnp_hw *hw)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(hw->back->eth_dev);
+   u32 version = 0;
+   int ret = -1;
+   u32 state;
+
+   PMD_INIT_FUNC_TRACE();
+   version = RNP_E_REG_RD(hw, RNP_DMA_VERSION);
+   RNP_PMD_DRV_LOG(INFO, "nic hw version:0x%.2x\n", version);
+   rnp_fw_init(hw);
+   RNP_E_REG_WR(hw, RNP_DMA_HW_EN, FALSE);
+   do {
+   state = RNP_E_REG_RD(hw, RNP_DMA_HW_STATE);
+   } while (state == 0);
+   ret = rnp_mbx_fw_get_capability(port);
+   if (ret) {
+   RNP_PMD_ERR("mbx_get_capability error! errcode=%d\n", ret);
+   return ret;
+   }
+   rnp_hw_reset(hw);
+   rnp_mbx_fw_reset_phy(hw);
+   /* rx packet protocol engine bypass */
+   RNP_E_REG_WR(hw, RNP_E_ENG_BYPASS, FALSE);
+   /* enable host filter */
+   RNP_E_REG_WR(hw, RNP_E_FILTER_EN, TRUE);
+   /* enable vxlan parse */
+   RNP_E_REG_WR(hw, RNP_E_VXLAN_PARSE_EN, TRUE);
+   /* enable flow direct engine */
+   RNP_E_REG_WR(hw, RNP_E_REDIR_EN, TRUE);
+   /* enable dma engine */
+   RNP_E_REG_WR(hw, RNP_DMA_HW_EN, RNP_DMA_EN_ALL);
+#define RNP_TARGET_TC_PORT (2)
+#define RNP_PORT_OFF_QUEUE_NUM (2)
+   if (hw->nic_mode == RNP_DUAL_10G && hw->max_port_num == 2)
+   RNP_E_REG_WR(hw, RNP_TC_PORT_OFFSET(RNP_TARGET_TC_PORT),
+   RNP_PORT_OFF_QUEUE_NUM);
+
+   return 0;
+}
+
+int
+rnp_setup_common_ops(struct rnp_hw *hw)
+{
+   rnp_mac_ops_init(hw);
+
+   return 0;
+}
diff --git a/drivers/net/rnp/base/rnp_common.h 
b/drivers/net/rnp/base/rnp_common.h
new file mode 100644
index 000..aaf77a6
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_common.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#ifndef _RNP_COMMON_H_
+#define _RNP_COMMON_H_
+
+#define RNP_NIC_RESET  _NIC_(0x0010)
+int rnp_init_hw(struct rnp_hw *hw);
+int rnp_setup_common_ops(struct rnp_hw *hw);
+
+#endif /* _RNP_COMMON_H_ */
diff --git a/drivers/net/rnp/base/rnp_dma_regs.h 
b/drivers/net/rnp/base/rnp_dma_regs.h
new file mode 100644
index 000..

[PATCH v7 12/28] net/rnp: add support link update operations.

[Wenbo Cao]

add support poll/irq link get mode

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |   2 +
 doc/guides/nics/rnp.rst   |   1 +
 drivers/net/rnp/base/rnp_fw_cmd.c |  45 +++
 drivers/net/rnp/base/rnp_fw_cmd.h |  58 ++-
 drivers/net/rnp/base/rnp_hw.h |   1 +
 drivers/net/rnp/base/rnp_mbx_fw.c |  72 ++-
 drivers/net/rnp/base/rnp_mbx_fw.h |   4 ++
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  12 
 drivers/net/rnp/rnp_ethdev.c  | 116 --
 10 files changed, 304 insertions(+), 8 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 2fc94825f..695b9c0 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,6 +5,8 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link status  = Y
+Link status event= Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 8f9d38d..82dd2d8 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -15,6 +15,7 @@ Features
   Receiver Side Steering (RSS) on IPv4, IPv6, IPv4-TCP/UDP/SCTP, 
IPv6-TCP/UDP/SCTP
   Inner RSS is only support for vxlan/nvgre
 - Promiscuous mode
+- Link state information
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index 34a88a1..c5ae7b9 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -68,6 +68,45 @@
arg->nr_lane = req_arg->param0;
 }
 
+static void
+rnp_build_set_event_mask(struct rnp_mbx_fw_cmd_req *req,
+struct rnp_fw_req_arg *req_arg,
+void *cookie)
+{
+   struct rnp_set_pf_event_mask *arg =
+   (struct rnp_set_pf_event_mask *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_SET_EVENT_MASK;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->event_mask = req_arg->param0;
+   arg->event_en = req_arg->param1;
+}
+
+static void
+rnp_build_lane_evet_mask(struct rnp_mbx_fw_cmd_req *req,
+struct rnp_fw_req_arg *req_arg,
+void *cookie)
+{
+   struct rnp_set_lane_event_mask *arg =
+   (struct rnp_set_lane_event_mask *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_SET_LANE_EVENT_EN;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+   arg->event_mask = req_arg->param1;
+   arg->event_en = req_arg->param2;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -87,6 +126,12 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_GET_LANE_STATUS:
rnp_build_get_lane_status_req(req, arg, cookie);
break;
+   case RNP_SET_EVENT_MASK:
+   rnp_build_set_event_mask(req, arg, cookie);
+   break;
+   case RNP_SET_LANE_EVENT_EN:
+   rnp_build_lane_evet_mask(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index c34fc5c..c86a32a 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -6,8 +6,9 @@
 #define _RNP_FW_CMD_H_
 
 #include "rnp_osdep.h"
+#include "rnp_hw.h"
 
-#define RNP_FW_LINK_SYNC   _NIC_(0x000c)
+#define RNP_FW_LINK_SYNC   (0x000c)
 #define RNP_LINK_MAGIC_CODE(0xa5a4)
 #define RNP_LINK_MAGIC_MASKRTE_GENMASK32(31, 16)
 
@@ -73,6 +74,22 @@ enum RNP_GENERIC_CMD {
RNP_SET_DDR_CSL = 0xFF11,
 };
 
+struct rnp_port_stat {
+   u8 phy_addr; /* Phy MDIO address */
+
+   u8 duplex   : 1; /* FIBRE is always 1,Twisted Pair 1 or 0 */
+   u8 autoneg  : 1; /* autoned state */
+   u8 fec  : 1;
+   u8 an_rev   : 1;
+   u8 link_traing  : 1;
+   u8 is_sgmii : 1; /* avild fw >= 0.5.0.17 */
+   u8 rsvd0: 2;
+   u16 speed;   /* cur port linked speed */
+
+   u16 pause   : 4;
+   u16 rsvd1   : 12;
+} __packed;
+
 /* firmware -> driver reply */
 struct rnp_phy_abilities_rep {
u8 link_stat;
@@ -203,6 +220,19 @@ struct rnp_lane_stat_rep {
u32 rsvd;
 } _PACKED_ALIGN4;
 
+
+#define RNP_MBX_SYNC_MASK RTE_GENMASK32(15, 0)
+/* == flags == */
+#define RNP_FLAGS_DD  RTE_BIT32(0) /* driver clear 0, FW must set 1 */
+#define RNP_FLAGS_CMP RTE_BIT32(1) /* driver clear 0, FW mucst set */
+#define RNP_FLAGS_ERR RTE_BIT32(2) /* driver clear 0, FW must set only if i

[PATCH v7 13/28] net/rnp: add support link setup operations

[Wenbo Cao]

add set link_down/link_up implent

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_eth_regs.h |  3 ++
 drivers/net/rnp/base/rnp_fw_cmd.c   | 22 +
 drivers/net/rnp/base/rnp_fw_cmd.h   |  6 +++
 drivers/net/rnp/base/rnp_mbx_fw.c   | 33 +
 drivers/net/rnp/base/rnp_mbx_fw.h   |  1 +
 drivers/net/rnp/rnp_ethdev.c|  4 ++
 drivers/net/rnp/rnp_link.c  | 99 +
 drivers/net/rnp/rnp_link.h  |  2 +
 8 files changed, 170 insertions(+)

diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index be7ed5b..c74886e 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -5,6 +5,9 @@
 #ifndef _RNP_ETH_REGS_H
 #define _RNP_ETH_REGS_H
 
+#define RNP_ETH_TX_FIFO_STATE  _ETH_(0x0330)
+#define RNP_ETH_TX_FIFO_EMPT(lane) ((1 << (lane)) | (1 << ((lane) + 4)))
+
 #define RNP_E_ENG_BYPASS   _ETH_(0x8000)
 #define RNP_E_VXLAN_PARSE_EN   _ETH_(0x8004)
 #define RNP_E_FILTER_EN_ETH_(0x801c)
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index c5ae7b9..17d3bb2 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -107,6 +107,25 @@
arg->event_en = req_arg->param2;
 }
 
+static void
+rnp_build_ifup_down(struct rnp_mbx_fw_cmd_req *req,
+   struct rnp_fw_req_arg *req_arg,
+   void *cookie)
+{
+   struct rnp_ifup_down_req *arg =
+   (struct rnp_ifup_down_req *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_IFUP_DOWN;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+   arg->up = req_arg->param1;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -132,6 +151,9 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_SET_LANE_EVENT_EN:
rnp_build_lane_evet_mask(req, arg, cookie);
break;
+   case RNP_IFUP_DOWN:
+   rnp_build_ifup_down(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index c86a32a..6b34396 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -310,6 +310,12 @@ struct rnp_link_stat_req {
struct rnp_port_stat states[RNP_MAX_PORT_OF_PF];
 };
 
+struct rnp_ifup_down_req {
+   u32 nr_lane;
+   u32 up;
+   u8 rsvd[24];
+};
+
 struct rnp_mbx_fw_cmd_req {
u16 flags;
u16 opcode;
diff --git a/drivers/net/rnp/base/rnp_mbx_fw.c 
b/drivers/net/rnp/base/rnp_mbx_fw.c
index d15a639..8758437 100644
--- a/drivers/net/rnp/base/rnp_mbx_fw.c
+++ b/drivers/net/rnp/base/rnp_mbx_fw.c
@@ -464,3 +464,36 @@ int rnp_mbx_fw_reset_phy(struct rnp_hw *hw)
 
return 0;
 }
+
+static void rnp_link_stat_reset(struct rnp_hw *hw, u16 lane)
+{
+   u32 state;
+
+   spin_lock(&hw->link_sync);
+   state = RNP_E_REG_RD(hw, RNP_FW_LINK_SYNC);
+   state &= ~RNP_LINK_MAGIC_MASK;
+   state |= RNP_LINK_MAGIC_CODE;
+   state &= ~RTE_BIT32(lane);
+
+   RNP_E_REG_WR(hw, RNP_FW_LINK_SYNC, state);
+   rte_spinlock_unlock(&hw->link_sync);
+}
+
+int rnp_mbx_fw_ifup_down(struct rnp_eth_port *port, bool up)
+{
+   u16 nr_lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   struct rnp_fw_req_arg arg;
+   int err;
+
+   memset(&arg, 0, sizeof(arg));
+   arg.opcode = RNP_IFUP_DOWN;
+   arg.param0 = nr_lane;
+   arg.param1 = up;
+
+   err = rnp_fw_send_norep_cmd(port, &arg);
+   /* force firmware send irq event to dpdk */
+   if (!err && up)
+   rnp_link_stat_reset(hw, nr_lane);
+   return err;
+}
diff --git a/drivers/net/rnp/base/rnp_mbx_fw.h 
b/drivers/net/rnp/base/rnp_mbx_fw.h
index 159a023..397d2ec 100644
--- a/drivers/net/rnp/base/rnp_mbx_fw.h
+++ b/drivers/net/rnp/base/rnp_mbx_fw.h
@@ -19,5 +19,6 @@
 int rnp_rcv_msg_from_fw(struct rnp_eth_adapter *adapter, u32 *msgbuf);
 int rnp_fw_mbx_ifup_down(struct rnp_eth_port *port, int up);
 int rnp_mbx_fw_lane_link_event_en(struct rnp_eth_port *port, bool en);
+int rnp_mbx_fw_ifup_down(struct rnp_eth_port *port, bool up);
 
 #endif /* _RNP_MBX_FW_H_ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index a3b84db..e229b2e 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -326,6 +326,7 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
rnp_mbx_fw_lane_link_event_en(port, lsc);
if (!lsc)
rnp_run_link_poll_task(port);
+   rnp_dev_set_link_up(eth_dev);
/* enable eth rx flow */
RNP_RX_ETH_ENABLE(hw, lane);
  

[PATCH v7 07/28] net/rnp: add support mac promisc mode

[Wenbo Cao]

add support two method of mac unicast promisc
mulcast promisc broadcast promisc mode

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   2 +
 doc/guides/nics/rnp.rst |   5 ++
 drivers/net/rnp/base/rnp_common.c   |   5 ++
 drivers/net/rnp/base/rnp_eth_regs.h |  15 +
 drivers/net/rnp/base/rnp_hw.h   |  12 +++-
 drivers/net/rnp/base/rnp_mac.c  | 114 +++-
 drivers/net/rnp/base/rnp_mac.h  |   2 +
 drivers/net/rnp/base/rnp_mac_regs.h |  39 
 drivers/net/rnp/base/rnp_osdep.h|   5 ++
 drivers/net/rnp/rnp_ethdev.c|  43 ++
 10 files changed, 240 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 6766130..65f1ed3 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,5 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Promiscuous mode = Y
+Allmulticast mode= Y
 Linux= Y
 x86-64   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 618baa8..62585ac 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -7,6 +7,11 @@ RNP Poll Mode driver
 The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev
 driver support for the inbuilt network device found in the **Mucse RNP**
 
+Features
+
+
+- Promiscuous mode
+
 Prerequisites
 -
 More information can be found at `Mucse, Official Website
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 47a979b..3fa2a49 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -4,6 +4,7 @@
 
 #include "rnp_osdep.h"
 #include "rnp_hw.h"
+#include "rnp_mac_regs.h"
 #include "rnp_eth_regs.h"
 #include "rnp_dma_regs.h"
 #include "rnp_common.h"
@@ -28,6 +29,7 @@ int rnp_init_hw(struct rnp_hw *hw)
struct rnp_eth_port *port = RNP_DEV_TO_PORT(hw->back->eth_dev);
u32 version = 0;
int ret = -1;
+   u32 idx = 0;
u32 state;
 
PMD_INIT_FUNC_TRACE();
@@ -60,6 +62,9 @@ int rnp_init_hw(struct rnp_hw *hw)
if (hw->nic_mode == RNP_DUAL_10G && hw->max_port_num == 2)
RNP_E_REG_WR(hw, RNP_TC_PORT_OFFSET(RNP_TARGET_TC_PORT),
RNP_PORT_OFF_QUEUE_NUM);
+   /* setup mac resiger ctrl base */
+   for (idx = 0; idx < hw->max_port_num; idx++)
+   hw->mac_base[idx] = (u8 *)hw->e_ctrl + RNP_MAC_BASE_OFFSET(idx);
 
return 0;
 }
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 6957866..c4519ba 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -10,6 +10,21 @@
 #define RNP_E_FILTER_EN_ETH_(0x801c)
 #define RNP_E_REDIR_EN _ETH_(0x8030)
 
+/* Mac Host Filter  */
+#define RNP_MAC_FCTRL  _ETH_(0x9110)
+#define RNP_MAC_FCTRL_MPE  RTE_BIT32(8)  /* Multicast Promiscuous En */
+#define RNP_MAC_FCTRL_UPE  RTE_BIT32(9)  /* Unicast Promiscuous En */
+#define RNP_MAC_FCTRL_BAM  RTE_BIT32(10) /* Broadcast Accept Mode */
+#define RNP_MAC_FCTRL_BYPASS   (\
+   RNP_MAC_FCTRL_MPE | \
+   RNP_MAC_FCTRL_UPE | \
+   RNP_MAC_FCTRL_BAM)
+/* Mucast unicast mac hash filter ctrl */
+#define RNP_MAC_MCSTCTRL   _ETH_(0x9114)
+#define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
+#define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
+#define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
 
 #endif /* _RNP_ETH_REGS_H */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index e150543..1b31362 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -59,9 +59,18 @@ struct rnp_mbx_info {
 
 struct rnp_eth_port;
 /* mac operations */
+enum rnp_mpf_modes {
+   RNP_MPF_MODE_NONE = 0,
+   RNP_MPF_MODE_MULTI,/* Multitle Filter */
+   RNP_MPF_MODE_ALLMULTI, /* Multitle Promisc */
+   RNP_MPF_MODE_PROMISC,  /* Unicast Promisc */
+};
+
 struct rnp_mac_ops {
-   /* update mac packet filter mode */
+   /* get default mac address */
int (*get_macaddr)(struct rnp_eth_port *port, u8 *mac);
+   /* update mac packet filter mode */
+   int (*update_mpfm)(struct rnp_eth_port *port, u32 mode, bool en);
 };
 
 struct rnp_eth_adapter;
@@ -91,6 +100,7 @@ struct rnp_hw {
struct rnp_eth_adapter *back;   /* backup to the adapter handle */
void __iomem *e_ctrl;   /* ethernet control bar */
void __iomem *c_ctrl;   /* crypto control bar */
+   void __iomem *mac_base[RNP_MAX_PORT_OF_PF]; /* mac ctrl register base */
u32 c_blen; /* crypto bar size */
 
/* pci device info */
diff --git a/drivers/net/rnp/b

[PATCH v7 14/28] net/rnp: add Rx burst simple support

[Wenbo Cao]

add only support simple recv pkts.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |   7 +++
 drivers/net/rnp/rnp_rxtx.c   | 129 +++
 drivers/net/rnp/rnp_rxtx.h   |   5 ++
 3 files changed, 141 insertions(+)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index e229b2e..e5f984f 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -329,6 +329,8 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
rnp_dev_set_link_up(eth_dev);
/* enable eth rx flow */
RNP_RX_ETH_ENABLE(hw, lane);
+   rnp_rx_func_select(eth_dev);
+   rnp_tx_func_select(eth_dev);
port->port_stopped = 0;
 
return 0;
@@ -568,6 +570,11 @@ static int rnp_dev_infos_get(struct rte_eth_dev *eth_dev,
 
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_drop_en = 0,
+   .rx_thresh = {
+   .pthresh = RNP_RX_DESC_FETCH_TH,
+   .hthresh = RNP_RX_DESC_FETCH_BURST,
+   },
+   .rx_free_thresh = RNP_DEFAULT_RX_FREE_THRESH,
.offloads = 0,
};
 
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index 2b172c8..8553fbf 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -641,3 +641,132 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
 
return 0;
 }
+
+#define RNP_CACHE_FETCH_RX (4)
+static __rte_always_inline int
+rnp_refill_rx_ring(struct rnp_rx_queue *rxq)
+{
+   volatile struct rnp_rx_desc *rxbd;
+   struct rnp_rxsw_entry *rx_swbd;
+   struct rte_mbuf *mb;
+   uint16_t j, i;
+   uint16_t rx_id;
+   int ret;
+
+   rxbd = rxq->rx_bdr + rxq->rxrearm_start;
+   rx_swbd = &rxq->sw_ring[rxq->rxrearm_start];
+   ret = rte_mempool_get_bulk(rxq->mb_pool, (void *)rx_swbd,
+   rxq->rx_free_thresh);
+   if (unlikely(ret != 0)) {
+   if (rxq->rxrearm_nb + rxq->rx_free_thresh >= rxq->attr.nb_desc) 
{
+   for (i = 0; i < RNP_CACHE_FETCH_RX; i++) {
+   rx_swbd[i].mbuf = &rxq->fake_mbuf;
+   rxbd[i].d.pkt_addr = 0;
+   rxbd[i].d.cmd = 0;
+   }
+   }
+   rte_eth_devices[rxq->attr.port_id].data->rx_mbuf_alloc_failed +=
+   rxq->rx_free_thresh;
+   return 0;
+   }
+   for (j = 0; j < rxq->rx_free_thresh; ++j) {
+   mb = rx_swbd[j].mbuf;
+   rte_mbuf_refcnt_set(mb, 1);
+   mb->data_off = RTE_PKTMBUF_HEADROOM;
+   mb->port = rxq->attr.port_id;
+
+   rxbd[j].d.pkt_addr = rnp_get_dma_addr(&rxq->attr, mb);
+   rxbd[j].d.cmd = 0;
+   }
+   rxq->rxrearm_start += rxq->rx_free_thresh;
+   if (rxq->rxrearm_start >= rxq->attr.nb_desc - 1)
+   rxq->rxrearm_start = 0;
+   rxq->rxrearm_nb -= rxq->rx_free_thresh;
+
+   rx_id = (uint16_t)((rxq->rxrearm_start == 0) ?
+   (rxq->attr.nb_desc - 1) : (rxq->rxrearm_start - 1));
+   rte_wmb();
+   RNP_REG_WR(rxq->rx_tailreg, 0, rx_id);
+
+   return j;
+}
+
+static __rte_always_inline uint16_t
+rnp_recv_pkts(void *_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
+{
+   struct rnp_rx_queue *rxq = (struct rnp_rx_queue *)_rxq;
+   struct rnp_rxsw_entry *rx_swbd;
+   uint32_t state_cmd[RNP_CACHE_FETCH_RX];
+   uint32_t pkt_len[RNP_CACHE_FETCH_RX] = {0};
+   volatile struct rnp_rx_desc *rxbd;
+   struct rte_mbuf *nmb;
+   int nb_dd, nb_rx = 0;
+   int i, j;
+
+   if (unlikely(!rxq->rxq_started || !rxq->rx_link))
+   return 0;
+   nb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RNP_CACHE_FETCH_RX);
+   rxbd = &rxq->rx_bdr[rxq->rx_tail];
+   rte_prefetch0(rxbd);
+   if (rxq->rxrearm_nb > rxq->rx_free_thresh)
+   rnp_refill_rx_ring(rxq);
+
+   if (!(rxbd->wb.qword1.cmd & RNP_CMD_DD))
+   return 0;
+
+   rx_swbd = &rxq->sw_ring[rxq->rx_tail];
+   for (i = 0; i < nb_pkts;
+   i += RNP_CACHE_FETCH_RX, rxbd += RNP_CACHE_FETCH_RX,
+   rx_swbd += RNP_CACHE_FETCH_RX) {
+   for (j = 0; j < RNP_CACHE_FETCH_RX; j++)
+   state_cmd[j] = rxbd[j].wb.qword1.cmd;
+   rte_atomic_thread_fence(rte_memory_order_acquire);
+
+   for (nb_dd = 0; nb_dd < RNP_CACHE_FETCH_RX &&
+   (state_cmd[nb_dd] & 
rte_cpu_to_le_16(RNP_CMD_DD));
+   nb_dd++)
+   ;
+   for (j = 0; j < nb_dd; j++)
+   pkt_len[j] = rxbd[j].wb.qword1.lens;
+
+   for (j = 0; j < nb_dd; ++j) {
+   nmb = rx_swbd[j].mbuf;
+
+   nmb->data_off = 

[PATCH v7 11/28] net/rnp: add RSS support operations

[Wenbo Cao]

add support rss reta updata/qury rss hash update/get
dev_configure add rss conf check.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   4 +
 doc/guides/nics/rnp.rst |   3 +
 drivers/net/rnp/base/rnp_eth_regs.h |  16 ++
 drivers/net/rnp/meson.build |   1 +
 drivers/net/rnp/rnp.h   |   7 +
 drivers/net/rnp/rnp_ethdev.c|  23 +++
 drivers/net/rnp/rnp_rss.c   | 367 
 drivers/net/rnp/rnp_rss.h   |  43 +
 8 files changed, 464 insertions(+)
 create mode 100644 drivers/net/rnp/rnp_rss.c
 create mode 100644 drivers/net/rnp/rnp_rss.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index fd7d4b9..2fc94825f 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -8,5 +8,9 @@ Speed capabilities   = Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
+RSS hash = Y
+RSS key update   = Y
+RSS reta update  = Y
+Inner RSS= Y
 Linux= Y
 x86-64   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 5417593..8f9d38d 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -11,6 +11,9 @@ Features
 
 
 - Multiple queues for TX and RX
+- Receiver Side Steering (RSS)
+  Receiver Side Steering (RSS) on IPv4, IPv6, IPv4-TCP/UDP/SCTP, 
IPv6-TCP/UDP/SCTP
+  Inner RSS is only support for vxlan/nvgre
 - Promiscuous mode
 
 Prerequisites
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 60766d2..be7ed5b 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -32,7 +32,23 @@
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
 /* rss function ctrl */
+#define RNP_RSS_INNER_CTRL _ETH_(0x805c)
+#define RNP_INNER_RSS_EN   (1)
+#define RNP_INNER_RSS_DIS  (0)
 #define RNP_RSS_REDIR_TB(n, id) _ETH_(0xe000 + ((n) * 0x200) + ((id) * 0x4))
+#define RNP_RSS_MRQC_ADDR  _ETH_(0x92a0)
+/* RSS policy */
+#define RNP_RSS_HASH_CFG_MASK  (0x3F3)
+#define RNP_RSS_HASH_IPV4_TCP  RTE_BIT32(16)
+#define RNP_RSS_HASH_IPV4  RTE_BIT32(17)
+#define RNP_RSS_HASH_IPV6  RTE_BIT32(20)
+#define RNP_RSS_HASH_IPV6_TCP  RTE_BIT32(21)
+#define RNP_RSS_HASH_IPV4_UDP  RTE_BIT32(22)
+#define RNP_RSS_HASH_IPV6_UDP   RTE_BIT32(23)
+#define RNP_RSS_HASH_IPV4_SCTP  RTE_BIT32(24)
+#define RNP_RSS_HASH_IPV6_SCTP  RTE_BIT32(25)
+/* rss hash key */
+#define RNP_RSS_KEY_TABLE(idx) _ETH_(0x92d0 + ((idx) * 0x4))
 
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
 
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index ff3dc41..40b0139 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -15,4 +15,5 @@ includes += include_directories('base')
 sources = files(
'rnp_ethdev.c',
'rnp_rxtx.c',
+   'rnp_rss.c',
 )
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 086135a..e02de85 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -108,6 +108,13 @@ struct rnp_eth_port {
struct rnp_tx_queue *tx_queues[RNP_MAX_RX_QUEUE_NUM];
struct rnp_hw *hw;
 
+   struct rte_eth_rss_conf rss_conf;
+   uint16_t last_rx_num;
+   bool rxq_num_changed;
+   bool reta_has_cfg;
+   bool hw_rss_en;
+   uint32_t indirtbl[RNP_RSS_INDIR_SIZE];
+
rte_spinlock_t rx_mac_lock;
bool port_stopped;
 };
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 7b7ed8c..bd22034 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -17,6 +17,7 @@
 #include "base/rnp_dma_regs.h"
 #include "base/rnp_mac_regs.h"
 #include "rnp_rxtx.h"
+#include "rnp_rss.h"
 
 static struct rte_eth_dev *
 rnp_alloc_eth_port(struct rte_pci_device *pci, char *name)
@@ -234,6 +235,9 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
}
/* disable eth rx flow */
RNP_RX_ETH_DISABLE(hw, lane);
+   ret = rnp_dev_rss_configure(eth_dev);
+   if (ret)
+   return ret;
ret = rnp_rx_scattered_setup(eth_dev);
if (ret)
return ret;
@@ -301,6 +305,19 @@ static int rnp_disable_all_tx_queue(struct rte_eth_dev 
*dev)
return ret;
 }
 
+static int rnp_dev_configure(struct rte_eth_dev *eth_dev)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(eth_dev);
+
+   if (port->last_rx_num != eth_dev->data->nb_rx_queues)
+   port->rxq_num_changed = true;
+   else
+   port->rxq_num_changed = false;
+   port->last_rx_num = eth_dev->data->nb_rx_queues;
+
+   return 0;
+}
+
 static int rnp_dev_stop(struct rte_eth_dev *eth_dev)
 {
struct rnp_eth_port *port = RNP_DEV_TO_PORT(eth_dev);
@@ -497,6 +514,7 @@ static int rnp_allmulticast_disable(s

[PATCH v7 19/28] net/rnp: add support basic stats operation

[Wenbo Cao]

add support hw-missed rx/tx packets bytes.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   2 +
 doc/guides/nics/rnp.rst |   1 +
 drivers/net/rnp/base/rnp_eth_regs.h |   3 +
 drivers/net/rnp/rnp.h   |  10 ++-
 drivers/net/rnp/rnp_ethdev.c| 147 
 drivers/net/rnp/rnp_rxtx.c  |   9 +++
 drivers/net/rnp/rnp_rxtx.h  |  10 +++
 7 files changed, 181 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index c68d6fb..45dae3b 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -7,6 +7,8 @@
 Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
+Basic stats  = Y
+Stats per queue  = Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index db64104..ec6f3f9 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -19,6 +19,7 @@ Features
 - MTU update
 - Jumbo frames
 - Scatter-Gather IO support
+- Port hardware statistic
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 91a18dd..391688b 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -23,6 +23,9 @@
 #define RNP_RX_FC_ENABLE   _ETH_(0x8520)
 #define RNP_RING_FC_EN(n)  _ETH_(0x8524 + ((0x4) * ((n) / 32)))
 #define RNP_RING_FC_THRESH(n)  _ETH_(0x8a00 + ((0x4) * (n)))
+/* ETH Statistic */
+#define RNP_ETH_RXTRANS_DROP   _ETH_(0x8904)
+#define RNP_ETH_RXTRUNC_DROP   _ETH_(0x8928)
 /* Mac Host Filter  */
 #define RNP_MAC_FCTRL  _ETH_(0x9110)
 #define RNP_MAC_FCTRL_MPE  RTE_BIT32(8)  /* Multicast Promiscuous En */
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 054382e..b4f4f28 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -10,7 +10,7 @@
 #include "base/rnp_hw.h"
 
 #define PCI_VENDOR_ID_MUCSE(0x8848)
-#define RNP_DEV_ID_N10G(0x1000)
+#define RNP_DEV_ID_N10G(0x1020)
 #define RNP_MAX_VF_NUM (64)
 #define RNP_MISC_VEC_IDRTE_INTR_VEC_ZERO_OFFSET
 /* maximum frame size supported */
@@ -105,6 +105,11 @@ struct rnp_proc_priv {
const struct rnp_mbx_ops *mbx_ops;
 };
 
+struct rnp_hw_eth_stats {
+   uint64_t rx_trans_drop; /* rx eth to dma fifo full drop */
+   uint64_t rx_trunc_drop; /* rx mac to eth to host copy fifo full 
drop */
+};
+
 struct rnp_eth_port {
struct rnp_proc_priv *proc_priv;
struct rte_ether_addr mac_addr;
@@ -113,6 +118,9 @@ struct rnp_eth_port {
struct rnp_tx_queue *tx_queues[RNP_MAX_RX_QUEUE_NUM];
struct rnp_hw *hw;
 
+   struct rnp_hw_eth_stats eth_stats_old;
+   struct rnp_hw_eth_stats eth_stats;
+
struct rte_eth_rss_conf rss_conf;
uint16_t last_rx_num;
bool rxq_num_changed;
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 0fcb256..fa2617b 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -770,6 +770,150 @@ static int rnp_allmulticast_disable(struct rte_eth_dev 
*eth_dev)
return 0;
 }
 
+struct rte_rnp_xstats_name_off {
+   char name[RTE_ETH_XSTATS_NAME_SIZE];
+   uint32_t offset;
+   uint32_t reg_base;
+   bool hi_addr_en;
+};
+
+static const struct rte_rnp_xstats_name_off rte_rnp_rx_eth_stats_str[] = {
+   {"eth rx full drop", offsetof(struct rnp_hw_eth_stats,
+   rx_trans_drop), RNP_ETH_RXTRANS_DROP, false},
+   {"eth_rx_fifo_drop", offsetof(struct rnp_hw_eth_stats,
+   rx_trunc_drop), RNP_ETH_RXTRUNC_DROP, false},
+};
+#define RNP_NB_RX_HW_ETH_STATS (RTE_DIM(rte_rnp_rx_eth_stats_str))
+#define RNP_GET_E_HW_COUNT(stats, offset)\
+   ((uint64_t *)(((char *)stats) + (offset)))
+#define RNP_ADD_INCL_COUNT(stats, offset, val)   \
+   ((*(RNP_GET_E_HW_COUNT(stats, (offset += val)
+
+static inline void
+rnp_update_eth_stats_32bit(struct rnp_hw_eth_stats *new,
+  struct rnp_hw_eth_stats *old,
+  uint32_t offset, uint32_t val)
+{
+   uint64_t *last_count = NULL;
+
+   last_count = RNP_GET_E_HW_COUNT(old, offset);
+   if (val >= *last_count)
+   RNP_ADD_INCL_COUNT(new, offset, val - (*last_count));
+   else
+   RNP_ADD_INCL_COUNT(new, offset, val + UINT32_MAX);
+   *last_count = val;
+}
+
+static void rnp_get_eth_count(struct rnp_hw *hw,
+ uint16_t lane,
+ struct rnp_hw_eth_stats *new,
+ struct rnp_hw_eth_stats *old,
+ const struct rte_rnp_xstats_name_off *ptr)
+{
+   uint64_t val = 0;
+
+   if (ptr->reg_base) {
+   val = RNP_

[PATCH v7 17/28] net/rnp: add Rx scatter segment version

[Wenbo Cao]

add support scatter multi segment received.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini |   2 +
 doc/guides/nics/rnp.rst  |   2 +
 drivers/net/rnp/rnp_rxtx.c   | 131 ++-
 drivers/net/rnp/rnp_rxtx.h   |   2 +
 4 files changed, 135 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 6d13370..c68d6fb 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -15,5 +15,7 @@ RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
 Inner RSS= Y
+Jumbo frame  = Y
+Scattered Rx = Y
 Linux= Y
 x86-64   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 9fa7ad9..db64104 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -17,6 +17,8 @@ Features
 - Promiscuous mode
 - Link state information
 - MTU update
+- Jumbo frames
+- Scatter-Gather IO support
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index e8c1444..c80cc8b 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -830,7 +830,6 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
if (txq->tx_next_rs > txq->attr.nb_desc)
txq->tx_next_rs = txq->tx_rs_thresh - 1;
}
-
txq->tx_tail = i;
 
rte_wmb();
@@ -839,9 +838,137 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
return start;
 }
 
+static int
+rnp_rxq_bulk_alloc(struct rnp_rx_queue *rxq,
+  volatile struct rnp_rx_desc *rxbd,
+  struct rnp_rxsw_entry *rxe,
+  bool bulk_alloc)
+{
+   struct rte_mbuf *nmb = NULL;
+   uint16_t update_tail;
+
+   if (!bulk_alloc) {
+   nmb = rte_mbuf_raw_alloc(rxq->mb_pool);
+   if (unlikely(!nmb)) {
+   rte_eth_devices[rxq->attr.port_id].data->
+   rx_mbuf_alloc_failed++;
+   return -ENOMEM;
+   }
+   rxbd->d.pkt_addr = 0;
+   rxbd->d.cmd = 0;
+   rxe->mbuf = NULL;
+   rxe->mbuf = nmb;
+   rxbd->d.pkt_addr = rnp_get_dma_addr(&rxq->attr, nmb);
+   }
+   if (rxq->rxrearm_nb > rxq->rx_free_thresh) {
+   rxq->rxrearm_nb -= rxq->rx_free_thresh;
+   rxq->rxrearm_start += rxq->rx_free_thresh;
+   if (rxq->rxrearm_start >= rxq->attr.nb_desc)
+   rxq->rxrearm_start = 0;
+   update_tail = (uint16_t)((rxq->rxrearm_start == 0) ?
+   (rxq->attr.nb_desc - 1) : (rxq->rxrearm_start - 
1));
+   rte_io_wmb();
+   RNP_REG_WR(rxq->rx_tailreg, 0, update_tail);
+   }
+
+   return 0;
+}
+
+static __rte_always_inline uint16_t
+rnp_scattered_rx(void *rx_queue, struct rte_mbuf **rx_pkts,
+uint16_t nb_pkts)
+{
+   struct rnp_rx_queue *rxq = (struct rnp_rx_queue *)rx_queue;
+   volatile struct rnp_rx_desc *bd_ring = rxq->rx_bdr;
+   struct rte_mbuf *first_seg = rxq->pkt_first_seg;
+   struct rte_mbuf *last_seg = rxq->pkt_last_seg;
+   struct rnp_rxsw_entry *sw_ring = rxq->sw_ring;
+   volatile struct rnp_rx_desc *rxbd;
+   volatile struct rnp_rx_desc rxd;
+   struct rnp_rxsw_entry *rxe;
+   struct rte_mbuf *rxm;
+   uint16_t rx_pkt_len;
+   uint16_t nb_rx = 0;
+   uint16_t rx_status;
+   uint16_t rx_id;
+
+   if (unlikely(!rxq->rxq_started || !rxq->rx_link))
+   return 0;
+   rx_id = rxq->rx_tail;
+   while (nb_rx < nb_pkts) {
+   rxbd = &bd_ring[rx_id];
+   rx_status = rxbd->wb.qword1.cmd;
+   if (!(rx_status & rte_cpu_to_le_16(RNP_CMD_DD)))
+   break;
+   rte_atomic_thread_fence(rte_memory_order_acquire);
+   rxd = *rxbd;
+   rxe = &sw_ring[rx_id];
+   rxm = rxe->mbuf;
+   if (rnp_rxq_bulk_alloc(rxq, rxbd, rxe, false))
+   break;
+   rx_id = (rx_id + 1) & rxq->attr.nb_desc_mask;
+   rte_prefetch0(sw_ring[rx_id].mbuf);
+   if ((rx_id & 0x3) == 0) {
+   rte_prefetch0(&bd_ring[rx_id]);
+   rte_prefetch0(&sw_ring[rx_id]);
+   }
+   rx_pkt_len = rxd.wb.qword1.lens;
+   rxm->data_len = rx_pkt_len;
+   rxm->data_off = RTE_PKTMBUF_HEADROOM;
+   if (!first_seg) {
+   /* first segment pkt */
+   first_seg = rxm;
+   first_seg->nb_segs = 1;
+   first_seg->pkt_len = rx_pkt_len;
+   } else {
+   /* follow-up segment pkt */
+ 

[PATCH v7 23/28] net/rnp: add support Rx checksum offload

[Wenbo Cao]

Add support Rx l3/l4 checum and tunnel
inner l3/l4, out l3 chksum.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|  4 ++
 doc/guides/nics/rnp.rst |  1 +
 drivers/net/rnp/base/rnp_eth_regs.h | 13 +
 drivers/net/rnp/rnp.h   |  7 +++
 drivers/net/rnp/rnp_ethdev.c| 65 -
 drivers/net/rnp/rnp_rxtx.c  | 97 -
 6 files changed, 185 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index b81f11d..7e97da9 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -8,6 +8,10 @@ Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
 Packet type parsing  = Y
+L3 checksum offload  = P
+L4 checksum offload  = P
+Inner L3 checksum= P
+Inner L4 checksum= P
 Basic stats  = Y
 Stats per queue  = Y
 Extended stats   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 39ea2d1..8f667a4 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -22,6 +22,7 @@ Features
 - Scatter-Gather IO support
 - Port hardware statistic
 - Packet type parsing
+- Checksum offload
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 8a448b9..b0961a1 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -16,6 +16,19 @@
 #define RNP_RX_ETH_F_CTRL(n)   _ETH_(0x8070 + ((n) * 0x8))
 #define RNP_RX_ETH_F_OFF   (0x7ff)
 #define RNP_RX_ETH_F_ON(0x270)
+/* rx checksum ctrl */
+#define RNP_HW_SCTP_CKSUM_CTRL _ETH_(0x8038)
+#define RNP_HW_CHECK_ERR_CTRL  _ETH_(0x8060)
+#define RNP_HW_ERR_HDR_LEN RTE_BIT32(0)
+#define RNP_HW_ERR_PKTLEN  RTE_BIT32(1)
+#define RNP_HW_L3_CKSUM_ERRRTE_BIT32(2)
+#define RNP_HW_L4_CKSUM_ERRRTE_BIT32(3)
+#define RNP_HW_SCTP_CKSUM_ERR  RTE_BIT32(4)
+#define RNP_HW_INNER_L3_CKSUM_ERR  RTE_BIT32(5)
+#define RNP_HW_INNER_L4_CKSUM_ERR  RTE_BIT32(6)
+#define RNP_HW_CKSUM_ERR_MASK  RTE_GENMASK32(6, 2)
+#define RNP_HW_CHECK_ERR_MASK  RTE_GENMASK32(6, 0)
+#define RNP_HW_ERR_RX_ALL_MASK RTE_GENMASK32(1, 0)
 /* max/min pkts length receive limit ctrl */
 #define RNP_MIN_FRAME_CTRL _ETH_(0x80f0)
 #define RNP_MAX_FRAME_CTRL _ETH_(0x80f4)
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index eb9d44a..702bbd0 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -42,6 +42,13 @@
RTE_ETH_RSS_NONFRAG_IPV6_UDP | \
RTE_ETH_RSS_IPV6_UDP_EX | \
RTE_ETH_RSS_NONFRAG_IPV6_SCTP)
+/* rx checksum offload */
+#define RNP_RX_CHECKSUM_SUPPORT ( \
+   RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | \
+   RTE_ETH_RX_OFFLOAD_UDP_CKSUM | \
+   RTE_ETH_RX_OFFLOAD_TCP_CKSUM | \
+   RTE_ETH_RX_OFFLOAD_SCTP_CKSUM | \
+   RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM)
 /* Ring info special */
 #define RNP_MAX_BD_COUNT   (4096)
 #define RNP_MIN_BD_COUNT   (128)
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index f97d12f..5886894 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -405,6 +405,67 @@ static int rnp_disable_all_tx_queue(struct rte_eth_dev 
*dev)
return ret;
 }
 
+static void rnp_set_rx_cksum_offload(struct rte_eth_dev *dev)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+   struct rnp_hw *hw = port->hw;
+   uint32_t cksum_ctrl;
+   uint64_t offloads;
+
+   offloads = dev->data->dev_conf.rxmode.offloads;
+   cksum_ctrl = RNP_HW_CHECK_ERR_MASK;
+   /* enable rx checksum feature */
+   if (!rnp_pf_is_multiple_ports(hw->device_id)) {
+   if (offloads & RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM) {
+   /* Tunnel Option Cksum L4_Option */
+   cksum_ctrl &= ~RNP_HW_L4_CKSUM_ERR;
+   if (offloads & (RTE_ETH_RX_OFFLOAD_UDP_CKSUM |
+   RTE_ETH_RX_OFFLOAD_TCP_CKSUM))
+   cksum_ctrl &= ~RNP_HW_INNER_L4_CKSUM_ERR;
+   else
+   cksum_ctrl |= RNP_HW_INNER_L4_CKSUM_ERR;
+   } else {
+   /* no tunnel option cksum l4_option */
+   cksum_ctrl |= RNP_HW_INNER_L4_CKSUM_ERR;
+   if (offloads & (RTE_ETH_RX_OFFLOAD_UDP_CKSUM |
+   RTE_ETH_RX_OFFLOAD_TCP_CKSUM))
+   cksum_ctrl &= ~RNP_HW_L4_CKSUM_ERR;
+   else
+   cksum_ctrl |= RNP_HW_L4_CKSUM_ERR;
+   }
+   if (offloads & RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM) {
+   /* tunnel o

[PATCH v7 16/28] net/rnp: add MTU set operation

[Wenbo Cao]

add mtu update limit for multiple port mode.
multiple mode just used the max-mtu of ports
to limit receive.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   1 +
 doc/guides/nics/rnp.rst |   1 +
 drivers/net/rnp/base/rnp_eth_regs.h |   3 +
 drivers/net/rnp/rnp.h   |   3 +
 drivers/net/rnp/rnp_ethdev.c| 144 +++-
 5 files changed, 151 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 695b9c0..6d13370 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -10,6 +10,7 @@ Link status event= Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
+MTU update   = Y
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 82dd2d8..9fa7ad9 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -16,6 +16,7 @@ Features
   Inner RSS is only support for vxlan/nvgre
 - Promiscuous mode
 - Link state information
+- MTU update
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index c74886e..91a18dd 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -16,6 +16,9 @@
 #define RNP_RX_ETH_F_CTRL(n)   _ETH_(0x8070 + ((n) * 0x8))
 #define RNP_RX_ETH_F_OFF   (0x7ff)
 #define RNP_RX_ETH_F_ON(0x270)
+/* max/min pkts length receive limit ctrl */
+#define RNP_MIN_FRAME_CTRL _ETH_(0x80f0)
+#define RNP_MAX_FRAME_CTRL _ETH_(0x80f4)
 /* rx queue flow ctrl */
 #define RNP_RX_FC_ENABLE   _ETH_(0x8520)
 #define RNP_RING_FC_EN(n)  _ETH_(0x8524 + ((0x4) * ((n) / 32)))
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 97222f3..054382e 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -120,6 +120,9 @@ struct rnp_eth_port {
bool hw_rss_en;
uint32_t indirtbl[RNP_RSS_INDIR_SIZE];
 
+   uint16_t cur_mtu;
+   bool jumbo_en;
+
rte_spinlock_t rx_mac_lock;
bool port_stopped;
 };
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 11cf2eb..0fcb256 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -20,6 +20,7 @@
 #include "rnp_rss.h"
 #include "rnp_link.h"
 
+static int rnp_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static struct rte_eth_dev *
 rnp_alloc_eth_port(struct rte_pci_device *pci, char *name)
 {
@@ -140,6 +141,13 @@ static void rnp_mac_rx_enable(struct rte_eth_dev *dev)
mac_cfg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_RX_CFG);
mac_cfg |= RNP_MAC_RE;
 
+   if (port->jumbo_en) {
+   mac_cfg |= RNP_MAC_JE;
+   mac_cfg |= RNP_MAC_GPSLCE | RNP_MAC_WD;
+   } else {
+   mac_cfg &= ~RNP_MAC_JE;
+   mac_cfg &= ~RNP_MAC_WD;
+   }
mac_cfg &= ~RNP_MAC_GPSL_MASK;
mac_cfg |= (RNP_MAC_MAX_GPSL << RNP_MAC_CPSL_SHIFT);
RNP_MAC_REG_WR(hw, lane, RNP_MAC_RX_CFG, mac_cfg);
@@ -209,6 +217,7 @@ static void rnp_mac_init(struct rte_eth_dev *dev)
 {
uint16_t max_pkt_size =
dev->data->dev_conf.rxmode.mtu + RNP_ETH_OVERHEAD;
+   struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
struct rnp_hw *hw = port->hw;
struct rnp_rx_queue *rxq;
@@ -234,6 +243,12 @@ static void rnp_mac_init(struct rte_eth_dev *dev)
return -ENOTSUP;
}
dma_buf_size = hw->min_dma_size;
+   if (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_SCATTER ||
+   max_pkt_size > dma_buf_size ||
+   dev->data->mtu + RNP_ETH_OVERHEAD > dma_buf_size)
+   dev->data->scattered_rx = 1;
+   else
+   dev->data->scattered_rx = 0;
/* Setup max dma scatter engine split size */
dma_ctrl = RNP_E_REG_RD(hw,  RNP_DMA_CTRL);
if (max_pkt_size == dma_buf_size)
@@ -294,6 +309,7 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
 {
struct rnp_eth_port *port = RNP_DEV_TO_PORT(eth_dev);
struct rte_eth_dev_data *data = eth_dev->data;
+   uint16_t max_rx_pkt_len = eth_dev->data->mtu;
bool lsc = data->dev_conf.intr_conf.lsc;
struct rnp_hw *hw = port->hw;
uint16_t lane = 0;
@@ -316,6 +332,9 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
ret = rnp_rx_scattered_setup(eth_dev);
if (ret)
return ret;
+   ret = rnp_mtu_set(eth_dev, max_rx_pkt_len);
+   if (ret)
+   return ret;
ret = rnp_enable_all_tx_queue(eth_dev);
if (ret)
goto txq_start_failed;
@@ -628,6 +647,129 @@ static int rnp_allmulticast_disable(struct rte_eth_dev 
*eth_dev)
return rnp_update_mpfm(port, RNP_MPF_MODE_AL

[PATCH v7 15/28] net/rnp: add Tx burst simple support

[Wenbo Cao]

add only support simple send pkts.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |  6 
 drivers/net/rnp/rnp_rxtx.c   | 85 +++-
 drivers/net/rnp/rnp_rxtx.h   |  1 +
 3 files changed, 91 insertions(+), 1 deletion(-)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index e5f984f..11cf2eb 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -579,6 +579,12 @@ static int rnp_dev_infos_get(struct rte_eth_dev *eth_dev,
};
 
dev_info->default_txconf = (struct rte_eth_txconf) {
+   .tx_thresh = {
+   .pthresh = RNP_TX_DESC_FETCH_TH,
+   .hthresh = RNP_TX_DESC_FETCH_BURST,
+   },
+   .tx_free_thresh = RNP_DEFAULT_TX_FREE_THRESH,
+   .tx_rs_thresh = RNP_DEFAULT_TX_RS_THRESH,
.offloads = 0,
};
 
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index 8553fbf..e8c1444 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -756,6 +756,89 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
return nb_rx;
 }
 
+static  __rte_always_inline int
+rnp_clean_tx_ring(struct rnp_tx_queue *txq)
+{
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *tx_swbd;
+   struct rte_mbuf *m;
+   uint16_t next_dd;
+   uint16_t i;
+
+   txbd = &txq->tx_bdr[txq->tx_next_dd];
+   if (!(txbd->d.cmd & RNP_CMD_DD))
+   return 0;
+   *txbd = txq->zero_desc;
+   next_dd = txq->tx_next_dd - (txq->tx_free_thresh - 1);
+   tx_swbd = &txq->sw_ring[next_dd];
+
+   for (i = 0; i < txq->tx_rs_thresh; ++i, ++tx_swbd) {
+   if (tx_swbd->mbuf) {
+   m = tx_swbd->mbuf;
+   rte_pktmbuf_free_seg(m);
+   tx_swbd->mbuf = NULL;
+   }
+   }
+   txq->nb_tx_free = (txq->nb_tx_free + txq->tx_rs_thresh);
+   txq->tx_next_dd = (txq->tx_next_dd + txq->tx_rs_thresh) &
+   txq->attr.nb_desc_mask;
+
+   return 0;
+}
+
+static __rte_always_inline uint16_t
+rnp_xmit_simple(void *_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+{
+   struct rnp_tx_queue *txq = (struct rnp_tx_queue *)_txq;
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *tx_swbd;
+   uint64_t phy;
+   uint16_t start;
+   uint16_t i;
+
+   if (unlikely(!txq->txq_started || !txq->tx_link))
+   return 0;
+
+   if (txq->nb_tx_free < txq->tx_free_thresh)
+   rnp_clean_tx_ring(txq);
+
+   nb_pkts = RTE_MIN(txq->nb_tx_free, nb_pkts);
+   if (!nb_pkts)
+   return 0;
+   start = nb_pkts;
+   i = txq->tx_tail;
+
+   while (nb_pkts--) {
+   txbd = &txq->tx_bdr[i];
+   tx_swbd = &txq->sw_ring[i];
+   tx_swbd->mbuf = *tx_pkts++;
+   phy = rnp_get_dma_addr(&txq->attr, tx_swbd->mbuf);
+   txbd->d.addr = phy;
+   if (unlikely(tx_swbd->mbuf->data_len > RNP_MAC_MAXFRM_SIZE))
+   tx_swbd->mbuf->data_len = 0;
+   txbd->d.blen = tx_swbd->mbuf->data_len;
+   txbd->d.cmd = RNP_CMD_EOP;
+
+   i = (i + 1) & txq->attr.nb_desc_mask;
+   }
+   txq->nb_tx_free -= start;
+   if (txq->tx_tail + start > txq->tx_next_rs) {
+   txbd = &txq->tx_bdr[txq->tx_next_rs];
+   txbd->d.cmd |= RNP_CMD_RS;
+   txq->tx_next_rs = (txq->tx_next_rs + txq->tx_rs_thresh);
+
+   if (txq->tx_next_rs > txq->attr.nb_desc)
+   txq->tx_next_rs = txq->tx_rs_thresh - 1;
+   }
+
+   txq->tx_tail = i;
+
+   rte_wmb();
+   RNP_REG_WR(txq->tx_tailreg, 0, i);
+
+   return start;
+}
+
 int rnp_rx_func_select(struct rte_eth_dev *dev)
 {
dev->rx_pkt_burst = rnp_recv_pkts;
@@ -765,7 +848,7 @@ int rnp_rx_func_select(struct rte_eth_dev *dev)
 
 int rnp_tx_func_select(struct rte_eth_dev *dev)
 {
-   dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
+   dev->tx_pkt_burst = rnp_xmit_simple;
dev->tx_pkt_prepare = rte_eth_pkt_burst_dummy;
 
return 0;
diff --git a/drivers/net/rnp/rnp_rxtx.h b/drivers/net/rnp/rnp_rxtx.h
index 39e5184..a8fd8d0 100644
--- a/drivers/net/rnp/rnp_rxtx.h
+++ b/drivers/net/rnp/rnp_rxtx.h
@@ -89,6 +89,7 @@ struct rnp_tx_queue {
const struct rte_memzone *rz;
uint64_t ring_phys_addr; /* tx dma ring physical addr */
volatile struct rnp_tx_desc *tx_bdr; /* tx dma ring virtual addr */
+   volatile struct rnp_tx_desc zero_desc;
struct rnp_txsw_entry *sw_ring; /* tx software ring addr */
volatile void *tx_tailreg; /* hw desc tail register */
volatile void *tx_headreg; /* hw desc head register*/
-- 
1.8.3.1

[PATCH v7 18/28] net/rnp: add Tx multiple segment version

[Wenbo Cao]

add support multiple segs mbuf send.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_rxtx.c | 126 -
 drivers/net/rnp/rnp_rxtx.h |   3 +-
 2 files changed, 126 insertions(+), 3 deletions(-)

diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index c80cc8b..777ce7b 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -374,9 +374,11 @@ static int rnp_alloc_txbdr(struct rte_eth_dev *dev,
sw_ring[prev].next_id = idx;
prev = idx;
}
+   txq->last_desc_cleaned = txq->attr.nb_desc - 1;
txq->nb_tx_free = txq->attr.nb_desc - 1;
txq->tx_next_dd = txq->tx_rs_thresh - 1;
txq->tx_next_rs = txq->tx_rs_thresh - 1;
+   txq->nb_tx_used = 0;
txq->tx_tail = 0;
 
size = (txq->attr.nb_desc + RNP_TX_MAX_BURST_SIZE);
@@ -860,6 +862,7 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
rxe->mbuf = nmb;
rxbd->d.pkt_addr = rnp_get_dma_addr(&rxq->attr, nmb);
}
+   rxq->rxrearm_nb++;
if (rxq->rxrearm_nb > rxq->rx_free_thresh) {
rxq->rxrearm_nb -= rxq->rx_free_thresh;
rxq->rxrearm_start += rxq->rx_free_thresh;
@@ -927,7 +930,6 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
first_seg->nb_segs++;
last_seg->next = rxm;
}
-   rxq->rxrearm_nb++;
if (!(rx_status & rte_cpu_to_le_16(RNP_CMD_EOP))) {
last_seg = rxm;
continue;
@@ -950,6 +952,106 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
return nb_rx;
 }
 
+static __rte_always_inline uint16_t
+rnp_multiseg_clean_txq(struct rnp_tx_queue *txq)
+{
+   uint16_t last_desc_cleaned = txq->last_desc_cleaned;
+   struct rnp_txsw_entry *sw_ring = txq->sw_ring;
+   volatile struct rnp_tx_desc *txbd;
+   uint16_t desc_to_clean_to;
+   uint16_t nb_tx_to_clean;
+
+   desc_to_clean_to = (uint16_t)(last_desc_cleaned + txq->tx_rs_thresh);
+   desc_to_clean_to = desc_to_clean_to & (txq->attr.nb_desc - 1);
+
+   desc_to_clean_to = sw_ring[desc_to_clean_to].last_id;
+   txbd = &txq->tx_bdr[desc_to_clean_to];
+   if (!(txbd->d.cmd & RNP_CMD_DD))
+   return txq->nb_tx_free;
+
+   if (last_desc_cleaned > desc_to_clean_to)
+   nb_tx_to_clean = (uint16_t)((txq->attr.nb_desc -
+   last_desc_cleaned) + desc_to_clean_to);
+   else
+   nb_tx_to_clean = (uint16_t)(desc_to_clean_to -
+   last_desc_cleaned);
+
+   txbd->d.cmd = 0;
+
+   txq->last_desc_cleaned = desc_to_clean_to;
+   txq->nb_tx_free = (uint16_t)(txq->nb_tx_free + nb_tx_to_clean);
+
+   return txq->nb_tx_free;
+}
+
+static __rte_always_inline uint16_t
+rnp_multiseg_xmit_pkts(void *_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+{
+   struct rnp_tx_queue *txq = (struct rnp_tx_queue *)_txq;
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *txe, *txn;
+   struct rte_mbuf *tx_pkt, *m_seg;
+   uint16_t send_pkts = 0;
+   uint16_t nb_used_bd;
+   uint16_t tx_last;
+   uint16_t nb_tx;
+   uint16_t tx_id;
+
+   if (unlikely(!txq->txq_started || !txq->tx_link))
+   return 0;
+   if (txq->nb_tx_free < txq->tx_free_thresh)
+   rnp_multiseg_clean_txq(txq);
+   if (unlikely(txq->nb_tx_free == 0))
+   return 0;
+   tx_id = txq->tx_tail;
+   txbd = &txq->tx_bdr[tx_id];
+   txe = &txq->sw_ring[tx_id];
+   for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
+   tx_pkt = tx_pkts[nb_tx];
+   nb_used_bd = tx_pkt->nb_segs;
+   tx_last = (uint16_t)(tx_id + nb_used_bd - 1);
+   if (tx_last >= txq->attr.nb_desc)
+   tx_last = (uint16_t)(tx_last - txq->attr.nb_desc);
+   if (nb_used_bd > txq->nb_tx_free)
+   if (nb_used_bd > rnp_multiseg_clean_txq(txq))
+   break;
+   m_seg = tx_pkt;
+   do {
+   txbd = &txq->tx_bdr[tx_id];
+   txn = &txq->sw_ring[txe->next_id];
+   if (txe->mbuf) {
+   rte_pktmbuf_free_seg(txe->mbuf);
+   txe->mbuf = NULL;
+   }
+   txe->mbuf = m_seg;
+   txe->last_id = tx_last;
+   txbd->d.addr = rnp_get_dma_addr(&txq->attr, m_seg);
+   txbd->d.blen = rte_cpu_to_le_32(m_seg->data_len);
+   txbd->d.cmd &= ~RNP_CMD_EOP;
+   txbd->d.cmd |= RNP_DATA_DESC;
+   m_seg = m_seg->next;
+   tx_id = 

[PATCH v7 22/28] net/rnp: add supported packet types

[Wenbo Cao]

add support parse hw packet types result.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |  1 +
 doc/guides/nics/rnp.rst   |  1 +
 drivers/net/rnp/base/rnp_bdq_if.h |  4 
 drivers/net/rnp/rnp_rxtx.c| 45 +++
 4 files changed, 51 insertions(+)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index de7e72c..b81f11d 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -7,6 +7,7 @@
 Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
+Packet type parsing  = Y
 Basic stats  = Y
 Stats per queue  = Y
 Extended stats   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 3315ff7..39ea2d1 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -21,6 +21,7 @@ Features
 - Jumbo frames
 - Scatter-Gather IO support
 - Port hardware statistic
+- Packet type parsing
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_bdq_if.h 
b/drivers/net/rnp/base/rnp_bdq_if.h
index 61a3832..a7d27bd 100644
--- a/drivers/net/rnp/base/rnp_bdq_if.h
+++ b/drivers/net/rnp/base/rnp_bdq_if.h
@@ -73,6 +73,7 @@ struct rnp_tx_desc {
 #define RNP_RX_L3TYPE_IPV4 (0x00UL << RNP_RX_L3TYPE_S)
 #define RNP_RX_L3TYPE_IPV6 (0x01UL << RNP_RX_L3TYPE_S)
 #define RNP_RX_L4TYPE_S(6)
+#define RNP_RX_L4TYPE_MASK RTE_GENMASK32(7, 6)
 #define RNP_RX_L4TYPE_TCP  (0x01UL << RNP_RX_L4TYPE_S)
 #define RNP_RX_L4TYPE_SCTP (0x02UL << RNP_RX_L4TYPE_S)
 #define RNP_RX_L4TYPE_UDP  (0x03UL << RNP_RX_L4TYPE_S)
@@ -83,9 +84,12 @@ struct rnp_tx_desc {
 #define RNP_RX_IN_L3_ERR   RTE_BIT32(11)
 #define RNP_RX_IN_L4_ERR   RTE_BIT32(12)
 #define RNP_RX_TUNNEL_TYPE_S   (13)
+#define RNP_RX_TUNNEL_MASK RTE_GENMASK32(14, 13)
 #define RNP_RX_PTYPE_VXLAN (0x01UL << RNP_RX_TUNNEL_TYPE_S)
 #define RNP_RX_PTYPE_NVGRE (0x02UL << RNP_RX_TUNNEL_TYPE_S)
 #define RNP_RX_PTYPE_VLAN  RTE_BIT32(15)
+/* mark_data */
+#define RNP_RX_L3TYPE_VALIDRTE_BIT32(31)
 /* tx data cmd */
 #define RNP_TX_TSO_EN  RTE_BIT32(4)
 #define RNP_TX_L3TYPE_S(5)
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index c351fee..229c97f 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -644,6 +644,49 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
return 0;
 }
 
+static __rte_always_inline void
+rnp_dev_rx_parse(struct rnp_rx_queue *rxq __rte_unused,
+struct rte_mbuf *m,
+volatile struct rnp_rx_desc rxbd)
+{
+   uint32_t mark_data = rxbd.wb.qword0.mark_data;
+   uint16_t vlan_tci = rxbd.wb.qword1.vlan_tci;
+   uint32_t cmd = rxbd.wb.qword1.cmd;
+
+   /* clear mbuf packet_type and ol_flags */
+   m->packet_type = 0;
+   m->ol_flags = 0;
+   if (mark_data & RNP_RX_L3TYPE_VALID) {
+   if (cmd & RNP_RX_L3TYPE_IPV6)
+   m->packet_type |= RTE_PTYPE_L3_IPV6;
+   else
+   m->packet_type |= RTE_PTYPE_L3_IPV4;
+   }
+   if (vlan_tci)
+   m->packet_type |= RTE_PTYPE_L2_ETHER_VLAN;
+   switch (cmd & RNP_RX_L4TYPE_MASK) {
+   case RNP_RX_L4TYPE_UDP:
+   m->packet_type |= RTE_PTYPE_L4_UDP;
+   break;
+   case RNP_RX_L4TYPE_TCP:
+   m->packet_type |= RTE_PTYPE_L4_TCP;
+   break;
+   case RNP_RX_L4TYPE_SCTP:
+   m->packet_type |= RTE_PTYPE_L4_SCTP;
+   break;
+   }
+   switch (cmd & RNP_RX_TUNNEL_MASK) {
+   case RNP_RX_PTYPE_VXLAN:
+   m->packet_type |= RTE_PTYPE_TUNNEL_VXLAN;
+   break;
+   case RNP_RX_PTYPE_NVGRE:
+   m->packet_type |= RTE_PTYPE_TUNNEL_NVGRE;
+   break;
+   }
+   if (!(m->packet_type & RTE_PTYPE_L2_MASK))
+   m->packet_type |= RTE_PTYPE_L2_ETHER;
+}
+
 #define RNP_CACHE_FETCH_RX (4)
 static __rte_always_inline int
 rnp_refill_rx_ring(struct rnp_rx_queue *rxq)
@@ -742,6 +785,7 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
nmb->ol_flags = 0;
nmb->nb_segs = 1;
 
+   rnp_dev_rx_parse(rxq, nmb, rxbd[j]);
rxq->stats.ibytes += nmb->data_len;
}
for (j = 0; j < nb_dd; ++j) {
@@ -941,6 +985,7 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
}
rxm->next = NULL;
first_seg->port = rxq->attr.port_id;
+   rnp_dev_rx_parse(rxq, first_seg, rxd);
rxq->stats.ibytes += first_seg->pkt_len;
/* this the end of packet the large pkt has been recv finish */
rte_prefetch0(RTE_PTR_ADD(first_seg->buf_addr,
-- 
1.8.3.1

[PATCH v7 20/28] net/rnp: add support xstats operation

[Wenbo Cao]

add support mac eth rx tx hw xstats

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   1 +
 drivers/net/rnp/base/rnp_eth_regs.h |   3 +
 drivers/net/rnp/base/rnp_mac_regs.h |  80 
 drivers/net/rnp/rnp.h   |  51 
 drivers/net/rnp/rnp_ethdev.c| 243 
 5 files changed, 378 insertions(+)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 45dae3b..c782efe 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -9,6 +9,7 @@ Link status  = Y
 Link status event= Y
 Basic stats  = Y
 Stats per queue  = Y
+Extended stats   = Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 391688b..ada42be 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -25,6 +25,9 @@
 #define RNP_RING_FC_THRESH(n)  _ETH_(0x8a00 + ((0x4) * (n)))
 /* ETH Statistic */
 #define RNP_ETH_RXTRANS_DROP   _ETH_(0x8904)
+#define RNP_ETH_RXGLAN_DROP_ETH_(0x8918)
+#define RNP_ETH_RXIPH_E_DROP   _ETH_(0x891c)
+#define RNP_ETH_RXCKSUM_E_DROP _ETH_(0x8920)
 #define RNP_ETH_RXTRUNC_DROP   _ETH_(0x8928)
 /* Mac Host Filter  */
 #define RNP_MAC_FCTRL  _ETH_(0x9110)
diff --git a/drivers/net/rnp/base/rnp_mac_regs.h 
b/drivers/net/rnp/base/rnp_mac_regs.h
index 1ae8801..94aeba9 100644
--- a/drivers/net/rnp/base/rnp_mac_regs.h
+++ b/drivers/net/rnp/base/rnp_mac_regs.h
@@ -78,4 +78,84 @@
 /* PHY Link Status */
 #define RNP_MAC_PLSRTE_BIT32(17)
 
+/* Mac Manage Counts */
+#define RNP_MMC_CTRL   (0x0800)
+#define RNP_MMC_RSTONRDRTE_BIT32(2)
+/* Tx Good And Bad Bytes Base */
+#define RNP_MMC_TX_GBOCTGB (0x0814)
+/* Tx Good And Bad Frame Num Base */
+#define RNP_MMC_TX_GBFRMB  (0x081c)
+/* Tx Good Broadcast Frame Num Base */
+#define RNP_MMC_TX_BCASTB  (0x0824)
+/* Tx Good Multicast Frame Num Base */
+#define RNP_MMC_TX_MCASTB  (0x082c)
+/* Tx 64Bytes Frame Num */
+#define RNP_MMC_TX_64_BYTESB   (0x0834)
+#define RNP_MMC_TX_65TO127_BYTESB  (0x083c)
+#define RNP_MMC_TX_128TO255_BYTEB  (0x0844)
+#define RNP_MMC_TX_256TO511_BYTEB  (0x084c)
+#define RNP_MMC_TX_512TO1023_BYTEB (0x0854)
+#define RNP_MMC_TX_1024TOMAX_BYTEB (0x085c)
+/* Tx Good And Bad Unicast Frame Num Base */
+#define RNP_MMC_TX_GBUCASTB(0x0864)
+/* Tx Good And Bad Multicast Frame Num Base */
+#define RNP_MMC_TX_GBMCASTB(0x086c)
+/* Tx Good And Bad Broadcast Frame NUM Base */
+#define RNP_MMC_TX_GBBCASTB(0x0874)
+/* Tx Frame Underflow Error */
+#define RNP_MMC_TX_UNDRFLWB(0x087c)
+/* Tx Good Frame Bytes Base */
+#define RNP_MMC_TX_GBYTESB (0x0884)
+/* Tx Good Frame Num Base*/
+#define RNP_MMC_TX_GBRMB   (0x088c)
+/* Tx Good Pause Frame Num Base */
+#define RNP_MMC_TX_PAUSEB  (0x0894)
+/* Tx Good Vlan Frame Num Base */
+#define RNP_MMC_TX_VLANB   (0x089c)
+
+/* Rx Good And Bad Frames Num Base */
+#define RNP_MMC_RX_GBFRMB  (0x0900)
+/* Rx Good And Bad Frames Bytes Base */
+#define RNP_MMC_RX_GBOCTGB (0x0908)
+/* Rx Good Framse Bytes Base */
+#define RNP_MMC_RX_GOCTGB  (0x0910)
+/* Rx Good Broadcast Frames Num Base */
+#define RNP_MMC_RX_BCASTGB (0x0918)
+/* Rx Good Multicast Frames Num Base */
+#define RNP_MMC_RX_MCASTGB (0x0920)
+/* Rx Crc Error Frames Num Base */
+#define RNP_MMC_RX_CRCERB  (0x0928)
+/* Rx Less Than 64Byes with Crc Err Base*/
+#define RNP_MMC_RX_RUNTERB (0x0930)
+/* Receive Jumbo Frame Error */
+#define RNP_MMC_RX_JABBER_ERR  (0x0934)
+/* Shorter Than 64Bytes without Any Errora Base */
+#define RNP_MMC_RX_USIZEGB (0x0938)
+/* Len Oversize Than Support */
+#define RNP_MMC_RX_OSIZEGB (0x093c)
+/* Rx 64Byes Frame Num Base */
+#define RNP_MMC_RX_64_BYTESB   (0x0940)
+/* Rx 65Bytes To 127Bytes Frame Num Base */
+#define RNP_MMC_RX_65TO127_BYTESB  (0x0948)
+/* Rx 128Bytes To 255Bytes Frame Num Base */
+#define RNP_MMC_RX_128TO255_BYTESB (0x0950)
+/* Rx 256Bytes To 511Bytes Frame Num Base */
+#define RNP_MMC_RX_256TO511_BYTESB (0x0958)
+/* Rx 512Bytes To 1023Bytes Frame Num Base */
+#define RNP_MMC_RX_512TO1203_BYTESB(0x0960)
+/* Rx Len Bigger Than 1024Bytes Base */
+#define RNP_MMC_RX_1024TOMAX_BYTESB(0x0968)
+/* Rx Unicast Frame Good Num Base */
+#define RNP_MMC_RX_UCASTGB (0x0970)
+/* Rx Length Error Of Frame Part */
+#define RNP_MMC_RX_LENERRB (0x0978)
+/* Rx received with a Length field not equal to the valid frame size */
+#define RNP_MMC_RX_OUTOF_RANGE (0x0980)
+/* Rx Pause Frame Good Num Base */
+#define RNP_MMC_RX_PAUSEB  (0x0988)
+/* Rx Vlan Frame Good Num Base */
+#define RNP_MMC_RX_

[PATCH v7 26/28] net/rnp: add support VLAN filters operations.

[Wenbo Cao]

add support to update vid for vlan filter

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|  1 +
 doc/guides/nics/rnp.rst |  2 +-
 drivers/net/rnp/base/meson.build|  1 +
 drivers/net/rnp/base/rnp_bitrev.h   | 64 
 drivers/net/rnp/base/rnp_crc32.c| 37 
 drivers/net/rnp/base/rnp_crc32.h| 10 +
 drivers/net/rnp/base/rnp_eth_regs.h |  1 +
 drivers/net/rnp/base/rnp_hw.h   |  1 +
 drivers/net/rnp/base/rnp_mac.c  | 85 +
 drivers/net/rnp/base/rnp_mac.h  |  1 +
 drivers/net/rnp/base/rnp_mac_regs.h |  6 +++
 drivers/net/rnp/base/rnp_osdep.h| 13 ++
 drivers/net/rnp/rnp.h   | 11 +
 drivers/net/rnp/rnp_ethdev.c| 10 +
 14 files changed, 242 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/rnp/base/rnp_bitrev.h
 create mode 100644 drivers/net/rnp/base/rnp_crc32.c
 create mode 100644 drivers/net/rnp/base/rnp_crc32.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 18ec4bc..ce7381e 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -20,6 +20,7 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
 Unicast MAC filter   = Y
+VLAN filter  = Y
 VLAN offload = Y
 QinQ offload = Y
 RSS hash = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index febdaf8..f1d4a06 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -17,7 +17,7 @@ Features
 - Promiscuous mode
 - Link state information
 - MTU update
-- MAC filtering
+- MAC/VLAN filtering
 - Jumbo frames
 - Scatter-Gather IO support
 - Port hardware statistic
diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index c2ef0d0..6b78de8 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -8,6 +8,7 @@ sources = [
 'rnp_common.c',
 'rnp_mac.c',
'rnp_bdq_if.c',
+   'rnp_crc32.c',
 ]
 
 error_cflags = ['-Wno-unused-value',
diff --git a/drivers/net/rnp/base/rnp_bitrev.h 
b/drivers/net/rnp/base/rnp_bitrev.h
new file mode 100644
index 000..05c36ca
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_bitrev.h
@@ -0,0 +1,64 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#ifndef _RNP_BITREV_H_
+#define _RNP_BITREV_H_
+
+#include "rnp_osdep.h"
+
+static const u8 byte_rev_table[256] = {
+   0x00, 0x80, 0x40, 0xc0, 0x20, 0xa0, 0x60, 0xe0,
+   0x10, 0x90, 0x50, 0xd0, 0x30, 0xb0, 0x70, 0xf0,
+   0x08, 0x88, 0x48, 0xc8, 0x28, 0xa8, 0x68, 0xe8,
+   0x18, 0x98, 0x58, 0xd8, 0x38, 0xb8, 0x78, 0xf8,
+   0x04, 0x84, 0x44, 0xc4, 0x24, 0xa4, 0x64, 0xe4,
+   0x14, 0x94, 0x54, 0xd4, 0x34, 0xb4, 0x74, 0xf4,
+   0x0c, 0x8c, 0x4c, 0xcc, 0x2c, 0xac, 0x6c, 0xec,
+   0x1c, 0x9c, 0x5c, 0xdc, 0x3c, 0xbc, 0x7c, 0xfc,
+   0x02, 0x82, 0x42, 0xc2, 0x22, 0xa2, 0x62, 0xe2,
+   0x12, 0x92, 0x52, 0xd2, 0x32, 0xb2, 0x72, 0xf2,
+   0x0a, 0x8a, 0x4a, 0xca, 0x2a, 0xaa, 0x6a, 0xea,
+   0x1a, 0x9a, 0x5a, 0xda, 0x3a, 0xba, 0x7a, 0xfa,
+   0x06, 0x86, 0x46, 0xc6, 0x26, 0xa6, 0x66, 0xe6,
+   0x16, 0x96, 0x56, 0xd6, 0x36, 0xb6, 0x76, 0xf6,
+   0x0e, 0x8e, 0x4e, 0xce, 0x2e, 0xae, 0x6e, 0xee,
+   0x1e, 0x9e, 0x5e, 0xde, 0x3e, 0xbe, 0x7e, 0xfe,
+   0x01, 0x81, 0x41, 0xc1, 0x21, 0xa1, 0x61, 0xe1,
+   0x11, 0x91, 0x51, 0xd1, 0x31, 0xb1, 0x71, 0xf1,
+   0x09, 0x89, 0x49, 0xc9, 0x29, 0xa9, 0x69, 0xe9,
+   0x19, 0x99, 0x59, 0xd9, 0x39, 0xb9, 0x79, 0xf9,
+   0x05, 0x85, 0x45, 0xc5, 0x25, 0xa5, 0x65, 0xe5,
+   0x15, 0x95, 0x55, 0xd5, 0x35, 0xb5, 0x75, 0xf5,
+   0x0d, 0x8d, 0x4d, 0xcd, 0x2d, 0xad, 0x6d, 0xed,
+   0x1d, 0x9d, 0x5d, 0xdd, 0x3d, 0xbd, 0x7d, 0xfd,
+   0x03, 0x83, 0x43, 0xc3, 0x23, 0xa3, 0x63, 0xe3,
+   0x13, 0x93, 0x53, 0xd3, 0x33, 0xb3, 0x73, 0xf3,
+   0x0b, 0x8b, 0x4b, 0xcb, 0x2b, 0xab, 0x6b, 0xeb,
+   0x1b, 0x9b, 0x5b, 0xdb, 0x3b, 0xbb, 0x7b, 0xfb,
+   0x07, 0x87, 0x47, 0xc7, 0x27, 0xa7, 0x67, 0xe7,
+   0x17, 0x97, 0x57, 0xd7, 0x37, 0xb7, 0x77, 0xf7,
+   0x0f, 0x8f, 0x4f, 0xcf, 0x2f, 0xaf, 0x6f, 0xef,
+   0x1f, 0x9f, 0x5f, 0xdf, 0x3f, 0xbf, 0x7f, 0xff,
+};
+
+static inline u8 bitrev8(u8 byte)
+{
+   return byte_rev_table[byte];
+}
+
+static u16 bitrev16(u16 x)
+{
+   return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
+}
+
+/**
+ * bitrev32 - reverse the order of bits in a u32 value
+ * @x: value to be bit-reversed
+ */
+static u32 bitrev32(uint32_t x)
+{
+   return (bitrev16(x & 0x) << 16) | bitrev16(x >> 16);
+}
+
+#endif /* _RNP_BITREV_H */
diff --git a/drivers/net/rnp/base/rnp_crc32.c b/drivers/net/rnp/base/rnp_crc32.c
new file mode 100644
index 000..c287b35
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_crc32.c
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse I

[PATCH v7 28/28] net/rnp: support Rx/Tx burst mode info

[Wenbo Cao]

add plaform method for get rx/tx burst function select
by upload func name.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_rxtx.c   | 58 
 drivers/net/rnp/rnp_rxtx.h   |  6 +
 3 files changed, 66 insertions(+)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 4fdeb19..a4e8a00 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1467,6 +1467,8 @@ static void rnp_get_hw_stats(struct rte_eth_dev *dev)
.tx_queue_release = rnp_dev_tx_queue_release,
.rxq_info_get = rnp_rx_queue_info_get,
.txq_info_get = rnp_tx_queue_info_get,
+   .rx_burst_mode_get= rnp_rx_burst_mode_get,
+   .tx_burst_mode_get= rnp_tx_burst_mode_get,
/* rss impl */
.reta_update  = rnp_dev_rss_reta_update,
.reta_query   = rnp_dev_rss_reta_query,
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index 60a49c3..6fd5fe0 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -1760,3 +1760,61 @@ int rnp_tx_func_select(struct rte_eth_dev *dev)
qinfo->conf.tx_thresh.hthresh = txq->pburst;
qinfo->conf.offloads = txq->tx_offloads;
 }
+
+static const struct {
+   eth_rx_burst_t pkt_burst;
+   const char *info;
+} rnp_rx_burst_infos[] = {
+   { rnp_scattered_rx, "Scalar Scattered" },
+   { rnp_recv_pkts,"Scalar" },
+};
+
+static const struct {
+   eth_tx_burst_t pkt_burst;
+   const char *info;
+} rnp_tx_burst_infos[] = {
+   { rnp_xmit_simple,  "Scalar Simple" },
+   { rnp_multiseg_xmit_pkts,   "Scalar" },
+};
+
+int
+rnp_rx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode)
+{
+   eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
+   int ret = -EINVAL;
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(rnp_rx_burst_infos); ++i) {
+   if (pkt_burst == rnp_rx_burst_infos[i].pkt_burst) {
+   snprintf(mode->info, sizeof(mode->info), "%s",
+   rnp_rx_burst_infos[i].info);
+   ret = 0;
+   break;
+   }
+   }
+
+   return ret;
+}
+
+int
+rnp_tx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode)
+{
+   eth_tx_burst_t pkt_burst = dev->tx_pkt_burst;
+   int ret = -EINVAL;
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(rnp_tx_burst_infos); ++i) {
+   if (pkt_burst == rnp_tx_burst_infos[i].pkt_burst) {
+   snprintf(mode->info, sizeof(mode->info), "%s",
+   rnp_tx_burst_infos[i].info);
+   ret = 0;
+   break;
+   }
+   }
+
+   return ret;
+}
diff --git a/drivers/net/rnp/rnp_rxtx.h b/drivers/net/rnp/rnp_rxtx.h
index dc4a8ea..8639f08 100644
--- a/drivers/net/rnp/rnp_rxtx.h
+++ b/drivers/net/rnp/rnp_rxtx.h
@@ -152,5 +152,11 @@ void rnp_rx_queue_info_get(struct rte_eth_dev *dev, 
uint16_t queue_id,
   struct rte_eth_rxq_info *qinfo);
 void rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
   struct rte_eth_txq_info *qinfo);
+int rnp_rx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode);
+int rnp_tx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode);
 
 #endif /* _RNP_RXTX_H_ */
-- 
1.8.3.1

[PATCH v7 21/28] net/rnp: add unicast MAC filter operation

[Wenbo Cao]

add mac filter for single/multiple port.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|  1 +
 doc/guides/nics/rnp.rst |  1 +
 drivers/net/rnp/base/rnp_eth_regs.h |  4 ++
 drivers/net/rnp/base/rnp_hw.h   |  3 ++
 drivers/net/rnp/base/rnp_mac.c  | 91 +
 drivers/net/rnp/base/rnp_mac.h  |  2 +
 drivers/net/rnp/base/rnp_mac_regs.h |  5 +-
 drivers/net/rnp/rnp.h   |  4 ++
 drivers/net/rnp/rnp_ethdev.c| 62 ++---
 9 files changed, 166 insertions(+), 7 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index c782efe..de7e72c 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -14,6 +14,7 @@ Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
+Unicast MAC filter   = Y
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index ec6f3f9..3315ff7 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -17,6 +17,7 @@ Features
 - Promiscuous mode
 - Link state information
 - MTU update
+- MAC filtering
 - Jumbo frames
 - Scatter-Gather IO support
 - Port hardware statistic
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index ada42be..8a448b9 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -63,5 +63,9 @@
 #define RNP_RSS_KEY_TABLE(idx) _ETH_(0x92d0 + ((idx) * 0x4))
 
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
+/* host mac address filter */
+#define RNP_RAL_BASE_ADDR(n)   _ETH_(0xA000 + (0x04 * (n)))
+#define RNP_RAH_BASE_ADDR(n)   _ETH_(0xA400 + (0x04 * (n)))
+#define RNP_MAC_FILTER_EN  RTE_BIT32(31)
 
 #endif /* _RNP_ETH_REGS_H */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 00707b3..a1cf45a 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -71,6 +71,9 @@ struct rnp_mac_ops {
int (*get_macaddr)(struct rnp_eth_port *port, u8 *mac);
/* update mac packet filter mode */
int (*update_mpfm)(struct rnp_eth_port *port, u32 mode, bool en);
+   /* Receive Address Filter table */
+   int (*set_rafb)(struct rnp_eth_port *port, u8 *mac, u32 index);
+   int (*clear_rafb)(struct rnp_eth_port *port, u32 index);
 };
 
 struct rnp_eth_adapter;
diff --git a/drivers/net/rnp/base/rnp_mac.c b/drivers/net/rnp/base/rnp_mac.c
index 2c9499f..01929fd 100644
--- a/drivers/net/rnp/base/rnp_mac.c
+++ b/drivers/net/rnp/base/rnp_mac.c
@@ -102,14 +102,89 @@
return 0;
 }
 
+static int
+rnp_set_mac_addr_pf(struct rnp_eth_port *port,
+   u8 *addr, u32 index)
+{
+   struct rnp_hw *hw = port->hw;
+   u32 addr_hi = 0, addr_lo = 0;
+   u8 *mac = NULL;
+
+   mac = (u8 *)&addr_hi;
+   mac[0] = addr[1];
+   mac[1] = addr[0];
+   mac = (u8 *)&addr_lo;
+   mac[0] = addr[5];
+   mac[1] = addr[4];
+   mac[2] = addr[3];
+   mac[3] = addr[2];
+   addr_hi |= RNP_MAC_FILTER_EN;
+   RNP_E_REG_WR(hw, RNP_RAH_BASE_ADDR(index), addr_hi);
+   RNP_E_REG_WR(hw, RNP_RAL_BASE_ADDR(index), addr_lo);
+
+   return 0;
+}
+
+static int
+rnp_set_mac_addr_indep(struct rnp_eth_port *port,
+  u8 *addr, u32 index)
+{
+   u16 lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   u32 addr_hi = 0, addr_lo = 0;
+   u8 *mac = NULL;
+
+   mac = (u8 *)&addr_lo;
+   mac[0] = addr[0];
+   mac[1] = addr[1];
+   mac[2] = addr[2];
+   mac[3] = addr[3];
+   mac = (u8 *)&addr_hi;
+   mac[0] = addr[4];
+   mac[1] = addr[5];
+
+   addr_hi |= RNP_MAC_AE;
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_HI(index), addr_hi);
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_LO(index), addr_lo);
+
+   return 0;
+}
+
+static int
+rnp_clear_mac_pf(struct rnp_eth_port *port, u32 index)
+{
+   struct rnp_hw *hw = port->hw;
+
+   RNP_E_REG_WR(hw, RNP_RAL_BASE_ADDR(index), 0);
+   RNP_E_REG_WR(hw, RNP_RAH_BASE_ADDR(index), 0);
+
+   return 0;
+}
+
+static int
+rnp_clear_mac_indep(struct rnp_eth_port *port, u32 index)
+{
+   u16 lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_HI(index), 0);
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_LO(index), 0);
+
+   return 0;
+}
+
 const struct rnp_mac_ops rnp_mac_ops_pf = {
.get_macaddr = rnp_mbx_fw_get_macaddr,
.update_mpfm = rnp_update_mpfm_pf,
+   .set_rafb = rnp_set_mac_addr_pf,
+   .clear_rafb = rnp_clear_mac_pf
 };
 
 const struct rnp_mac_ops rnp_mac_ops_indep = {
.get_macaddr = rnp_mbx_fw_get_macaddr,
.update_mpfm = rnp_update_mpfm_indep,
+   .set_rafb = rnp_set_mac_addr_indep,
+   .clear_rafb = rnp_clear_m

[PATCH v7 27/28] net/rnp: add queue info operation.

[Wenbo Cao]

add support get queue configure info for user debug

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_rxtx.c   | 42 ++
 drivers/net/rnp/rnp_rxtx.h   |  4 
 3 files changed, 48 insertions(+)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 52693f4..4fdeb19 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1465,6 +1465,8 @@ static void rnp_get_hw_stats(struct rte_eth_dev *dev)
.rx_queue_release = rnp_dev_rx_queue_release,
.tx_queue_setup   = rnp_tx_queue_setup,
.tx_queue_release = rnp_dev_tx_queue_release,
+   .rxq_info_get = rnp_rx_queue_info_get,
+   .txq_info_get = rnp_tx_queue_info_get,
/* rss impl */
.reta_update  = rnp_dev_rss_reta_update,
.reta_query   = rnp_dev_rss_reta_query,
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index c021efa..60a49c3 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -1718,3 +1718,45 @@ int rnp_tx_func_select(struct rte_eth_dev *dev)
 
return 0;
 }
+
+void
+rnp_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+ struct rte_eth_rxq_info *qinfo)
+{
+   struct rnp_rx_queue *rxq;
+
+   rxq = dev->data->rx_queues[queue_id];
+   if (!rxq)
+   return;
+   qinfo->mp = rxq->mb_pool;
+   qinfo->scattered_rx = dev->data->scattered_rx;
+   qinfo->queue_state = rxq->rxq_started;
+   qinfo->nb_desc = rxq->attr.nb_desc;
+   qinfo->rx_buf_size = rxq->rx_buf_len;
+
+   qinfo->conf.rx_deferred_start = rxq->rx_deferred_start;
+   qinfo->conf.rx_free_thresh = rxq->rx_free_thresh;
+   qinfo->conf.rx_thresh.pthresh = rxq->pthresh;
+   qinfo->conf.rx_thresh.hthresh = rxq->pburst;
+   qinfo->conf.offloads = rxq->rx_offloads;
+}
+
+void
+rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+ struct rte_eth_txq_info *qinfo)
+{
+   struct rnp_tx_queue *txq;
+
+   txq = dev->data->tx_queues[queue_id];
+   if (!txq)
+   return;
+   qinfo->queue_state = txq->txq_started;
+   qinfo->nb_desc = txq->attr.nb_desc;
+
+   qinfo->conf.tx_deferred_start = txq->tx_deferred_start;
+   qinfo->conf.tx_free_thresh = txq->tx_free_thresh;
+   qinfo->conf.tx_rs_thresh = txq->tx_rs_thresh;
+   qinfo->conf.tx_thresh.pthresh = txq->pthresh;
+   qinfo->conf.tx_thresh.hthresh = txq->pburst;
+   qinfo->conf.offloads = txq->tx_offloads;
+}
diff --git a/drivers/net/rnp/rnp_rxtx.h b/drivers/net/rnp/rnp_rxtx.h
index 51e5d4b..dc4a8ea 100644
--- a/drivers/net/rnp/rnp_rxtx.h
+++ b/drivers/net/rnp/rnp_rxtx.h
@@ -148,5 +148,9 @@ int rnp_tx_queue_setup(struct rte_eth_dev *dev,
 int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qidx);
 int rnp_rx_func_select(struct rte_eth_dev *dev);
 int rnp_tx_func_select(struct rte_eth_dev *dev);
+void rnp_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+  struct rte_eth_rxq_info *qinfo);
+void rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+  struct rte_eth_txq_info *qinfo);
 
 #endif /* _RNP_RXTX_H_ */
-- 
1.8.3.1

RE: [EXTERNAL] [PATCH 1/4] net/netvsc: scan all net devices under the PCI device

[Long Li]

> Subject: [EXTERNAL] [PATCH 1/4] net/netvsc: scan all net devices under the PCI
> device
> 
> From: Long Li 
> 
> The current code has the wrong assumption that a PCI device can have only one
> Ethernet device. This is not correct as a PCI device can be multi functional 
> and
> have multiple Ethernet devices.
> 
> Fix this by scanning all the devices under a PCI device.
> 
> Fixes: a2a23a794b3a ("net/netvsc: support VF device hot add/remove")
> Cc: sta...@dpdk.org
> Signed-off-by: Long Li 
> ---
>  drivers/net/netvsc/hn_ethdev.c | 29 -
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 1736cb5d07..f848157b49 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -570,7 +570,7 @@ static void netvsc_hotplug_retry(void *args)
>   struct rte_devargs *d = &hot_ctx->da;
>   char buf[256];
> 
> - DIR *di;
> + DIR *di = NULL;
>   struct dirent *dir;
>   struct ifreq req;
>   struct rte_ether_addr eth_addr;
> @@ -590,7 +590,9 @@ static void netvsc_hotplug_retry(void *args)
>   if (!di) {
>   PMD_DRV_LOG(DEBUG, "%s: can't open directory %s, "
>   "retrying in 1 second", __func__, buf);
> - goto retry;
> + /* The device is still being initialized, retry after 1 second 
> */
> + rte_eal_alarm_set(100, netvsc_hotplug_retry, hot_ctx);
> + return;
>   }
> 
>   while ((dir = readdir(di))) {
> @@ -614,10 +616,9 @@ static void netvsc_hotplug_retry(void *args)
>   dir->d_name);
>   break;
>   }
> - if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) {
> - closedir(di);
> - goto free_hotadd_ctx;
> - }
> + if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER)
> + continue;
> +
>   memcpy(eth_addr.addr_bytes, req.ifr_hwaddr.sa_data,
>  RTE_DIM(eth_addr.addr_bytes));
> 
> @@ -636,22 +637,16 @@ static void netvsc_hotplug_retry(void *args)
>   PMD_DRV_LOG(ERR,
>   "Failed to add PCI device %s",
>   d->name);
> - break;
>   }
> +
> + break;
>   }
> - /* When the code reaches here, we either have already added
> -  * the device, or its MAC address did not match.
> -  */
> - closedir(di);
> - goto free_hotadd_ctx;
>   }
> - closedir(di);
> -retry:
> - /* The device is still being initialized, retry after 1 second */
> - rte_eal_alarm_set(100, netvsc_hotplug_retry, hot_ctx);
> - return;
> 
>  free_hotadd_ctx:
> + if (di)
> + closedir(di);
> +
>   rte_spinlock_lock(&hv->hotadd_lock);
>   LIST_REMOVE(hot_ctx, list);
>   rte_spinlock_unlock(&hv->hotadd_lock);
> --
> 2.34.1


Hi Stephen, Ferruh

I'm going to work an EAL patch to replace the 4th patch in the series as 
suggested by Stephen.

Is it okay to merge the first three patches of this series?

Thanks,
Long

Re: [PATCH v1 3/3] net/intel: add Tx time queue

[Stephen Hemminger]

On Fri,  7 Feb 2025 12:43:00 +
Soumyadeep Hore  wrote:

> diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
> index d9cf4474fc..f3777fa9e7 100644
> --- a/drivers/net/intel/common/tx.h
> +++ b/drivers/net/intel/common/tx.h
> @@ -35,6 +35,7 @@ struct ci_tx_queue {
>   volatile struct i40e_tx_desc *i40e_tx_ring;
>   volatile struct iavf_tx_desc *iavf_tx_ring;
>   volatile struct ice_tx_desc *ice_tx_ring;
> + volatile struct ice_ts_desc *ice_tstamp_ring;
>   volatile union ixgbe_adv_tx_desc *ixgbe_tx_ring;
>   };
>   volatile uint8_t *qtx_tail;   /* register address of tail */
> @@ -76,6 +77,10 @@ struct ci_tx_queue {

Why so heavy use of volatile here? Volatile generates worst case code is there 
something
odd about the hardware or driver?

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

[Stephen Hemminger]

On Fri,  7 Feb 2025 09:41:08 -0800
Andre Muezerie  wrote:

> This patch avoids warnings like the ones below emitted by MSVC:
> 
> 1)
> ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
> 
> 2)
> ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> signed/unsigned mismatch
> 
> The fix for (1) is to use 64-bit shifting when appropriate
> (according to what the result is used for).
> 
> The fix for (2) is to explicitly cast the variables used in the
> comparison.
> 
> v5:
>  * rebase
>  * use uint32_t instead of uint32, to better conform to DPDK standards
>  * rename variable rqID to rq_id to better conform to DPDK standards
>and avoid checkpatch warning
>  * use 2U instead of (uint32)2, which is shorter
>  * simplify expression in meson.build using compiler id "gcc"
> 
> Andre Muezerie (1):
>   drivers/net: use 64-bit shift and avoid signed/unsigned mismatch
> 
>  drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++---
>  drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
>  drivers/net/intel/iavf/iavf_rxtx.c |  2 +-
>  drivers/net/intel/iavf/iavf_vchnl.c|  2 +-
>  drivers/net/intel/ice/base/meson.build | 19 +--
>  drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
>  drivers/net/intel/ice/ice_ethdev.c |  4 ++--
>  drivers/net/intel/ice/ice_rxtx.c   |  2 +-
>  drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
>  9 files changed, 32 insertions(+), 25 deletions(-)

Okay, put this in next-net

[PATCH v5] net: add thread-safe crc api

[Arkadiusz Kusztal]

The current net CRC API is not thread-safe, this patch
solves this by adding another, thread-safe API functions.
This API is also safe to use across multiple processes,
yet with limitations on max-simd-bitwidth, which will be checked only by
the process that created the CRC context; all other processes
(that did not create the context) will use the highest possible
SIMD extension that was built with the binary, but no higher than the one
requested by the CRC context.

Since the change of the API at this point is an ABI break,
these API symbols are versioned with the _26 suffix.

Signed-off-by: Arkadiusz Kusztal 
---
v2:
- added multi-process safety
v3:
- made the crc context opaque
- versioned old APIs
v4:
- exported rte_net_crc_free symbol
v5:
- fixed unclear comments in release notes section
- aligned `fall-through` comments

 app/test/test_crc.c| 169 ++---
 doc/guides/rel_notes/release_25_03.rst |   5 +
 drivers/crypto/qat/qat_sym.h   |   6 +-
 drivers/crypto/qat/qat_sym_session.c   |   8 ++
 drivers/crypto/qat/qat_sym_session.h   |   2 +
 lib/net/meson.build|   2 +
 lib/net/net_crc.h  |  18 ++-
 lib/net/rte_net_crc.c  | 130 ++-
 lib/net/rte_net_crc.h  |  39 --
 lib/net/version.map|   6 +
 10 files changed, 268 insertions(+), 117 deletions(-)

diff --git a/app/test/test_crc.c b/app/test/test_crc.c
index b85fca35fe..d7a11e8025 100644
--- a/app/test/test_crc.c
+++ b/app/test/test_crc.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2017-2020 Intel Corporation
+ * Copyright(c) 2017-2025 Intel Corporation
  */
 
 #include "test.h"
@@ -44,131 +44,100 @@ static const uint32_t crc32_vec_res = 0xb491aab4;
 static const uint32_t crc32_vec1_res = 0xac54d294;
 static const uint32_t crc32_vec2_res = 0xefaae02f;
 static const uint32_t crc16_vec_res = 0x6bec;
-static const uint16_t crc16_vec1_res = 0x8cdd;
-static const uint16_t crc16_vec2_res = 0xec5b;
+static const uint32_t crc16_vec1_res = 0x8cdd;
+static const uint32_t crc16_vec2_res = 0xec5b;
 
 static int
-crc_calc(const uint8_t *vec,
-   uint32_t vec_len,
-   enum rte_net_crc_type type)
+crc_all_algs(const char *desc, enum rte_net_crc_type type,
+   const uint8_t *data, int data_len, uint32_t res)
 {
-   /* compute CRC */
-   uint32_t ret = rte_net_crc_calc(vec, vec_len, type);
+   struct rte_net_crc *ctx;
+   uint32_t crc;
+   int ret = TEST_SUCCESS;
+
+   ctx = rte_net_crc_set_alg(RTE_NET_CRC_SCALAR, type);
+   TEST_ASSERT_NOT_NULL(ctx, "cannot allocate the CRC context");
+   crc = rte_net_crc_calc(ctx, data, data_len);
+   if (crc != res) {
+   RTE_LOG(ERR, USER1, "TEST FAILED: %s SCALAR\n", desc);
+   debug_hexdump(stdout, "SCALAR", &crc, 4);
+   ret = TEST_FAILED;
+   }
+   rte_net_crc_free(ctx);
+
+   ctx = rte_net_crc_set_alg(RTE_NET_CRC_SSE42, type);
+   TEST_ASSERT_NOT_NULL(ctx, "cannot allocate the CRC context");
+   crc = rte_net_crc_calc(ctx, data, data_len);
+   if (crc != res) {
+   RTE_LOG(ERR, USER1, "TEST FAILED: %s SSE42\n", desc);
+   debug_hexdump(stdout, "SSE", &crc, 4);
+   ret = TEST_FAILED;
+   }
 
-   /* dump data on console */
-   debug_hexdump(stdout, NULL, vec, vec_len);
+   rte_net_crc_free(ctx);
+
+   ctx = rte_net_crc_set_alg(RTE_NET_CRC_AVX512, type);
+   TEST_ASSERT_NOT_NULL(ctx, "cannot allocate the CRC context");
+   crc = rte_net_crc_calc(ctx, data, data_len);
+   if (crc != res) {
+   RTE_LOG(ERR, USER1, "TEST FAILED: %s AVX512\n", desc);
+   debug_hexdump(stdout, "AVX512", &crc, 4);
+   ret = TEST_FAILED;
+   }
+   rte_net_crc_free(ctx);
+
+   ctx = rte_net_crc_set_alg(RTE_NET_CRC_NEON, type);
+   TEST_ASSERT_NOT_NULL(ctx, "cannot allocate the CRC context");
+   crc = rte_net_crc_calc(ctx, data, data_len);
+   if (crc != res) {
+   RTE_LOG(ERR, USER1, "TEST FAILED: %s NEON\n", desc);
+   debug_hexdump(stdout, "NEON", &crc, 4);
+   ret = TEST_FAILED;
+   }
+   rte_net_crc_free(ctx);
 
-   return  ret;
+   return ret;
 }
 
 static int
-test_crc_calc(void)
-{
+crc_autotest(void)
+{  uint8_t *test_data;
uint32_t i;
-   enum rte_net_crc_type type;
-   uint8_t *test_data;
-   uint32_t result;
-   int error;
+   int ret = TEST_SUCCESS;
 
/* 32-bit ethernet CRC: Test 1 */
-   type = RTE_NET_CRC32_ETH;
-
-   result = crc_calc(crc_vec, CRC_VEC_LEN, type);
-   if (result != crc32_vec_res)
-   return -1;
+   ret = crc_all_algs("32-bit ethernet CRC: Test 1", RTE_NET_CRC32_ETH, 
crc_vec,
+   sizeof(crc_vec), crc32_vec_res);
 
/* 32-bit ethernet CRC: Test 2 */
test_data = rte_

Re: [RFC PATCH 1/7] dts: add port topology configuration

[Nicholas Pratte]

Hi Luca, nice work! See comments below.


>
>
> +class LinkPortIdentifier(NamedTuple):
> +"""A tuple linking test run node type to port name."""
> +
> +node_type: Literal["sut", "tg"]
> +port_name: str
> +
> +
> +class PortLinkConfig(FrozenModel):
> +"""A link between the ports of the nodes.
> +
> +Can be represented as a string with the following notation:
> +
> +.. code::
> +
> +sut.PORT_0 <-> tg.PORT_0  # explicit node nomination
> +PORT_0 <-> PORT_0 # implicit node nomination. Left is SUT, 
> right is TG.

There are some additional comments below that relate to this piece of
documentation here. If a user is looking at this, maybe it would make
more sense for them to read something like "sut.{string name}" to
better indicate the flexibility they have in naming ports. It might be
possible that someone could get confused when they are reading these
exception messages as they are thrown.

> +"""
> +
> +#: The port at the left side of the link.
> +left: LinkPortIdentifier
> +#: The port at the right side of the link.
> +right: LinkPortIdentifier
> +
> +@cached_property
> +def sut_port(self) -> str:
> +"""Port name of the SUT node.
> +
> +Raises:
> +InternalError: If a misconfiguration has been allowed to happen.
> +"""
> +if self.left.node_type == "sut":
> +return self.left.port_name
> +if self.right.node_type == "sut":
> +return self.right.port_name
> +
> +raise InternalError("Unreachable state reached.")
> +
> +@cached_property
> +def tg_port(self) -> str:
> +"""Port name of the TG node.
> +
> +Raises:
> +InternalError: If a misconfiguration has been allowed to happen.
> +"""
> +if self.left.node_type == "tg":
> +return self.left.port_name
> +if self.right.node_type == "tg":
> +return self.right.port_name
> +
> +raise InternalError("Unreachable state reached.")
> +
> +@model_validator(mode="before")
> +@classmethod
> +def convert_from_string(cls, data: Any) -> Any:
> +"""Convert the string representation of the model into a valid 
> mapping."""
> +if isinstance(data, str):
> +m = re.match(REGEX_FOR_PORT_LINK, data, re.I)
> +assert m is not None, (
> +"The provided link is malformed. Please use the following "
> +"notation: sut.PORT_0 <-> tg.PORT_0"

Per the comment above, this is the exception message I am referring
to. If the example test_run.conf is going to have the default port
names be "Port 0" and "Port 1," just to be more consistent, it might
make more sense to remove the underscored from the exception message.
I could personally see myself making a silly error in misunderstanding
this small inconsistency as I quickly fix my configuration files; it's
happened many times before :D

> +)
> +
> +left = (m.group(1) or "sut").lower(), m.group(2)
> +right = (m.group(3) or "tg").lower(), m.group(4)
> +
> +return {"left": left, "right": right}
> +return data
> +
> +@model_validator(mode="after")
> +def verify_distinct_nodes(self) -> Self:
> +"""Verify that each side of the link has distinct nodes."""
> +assert (
> +self.left.node_type != self.right.node_type
> +), "Linking ports of the same node is unsupported."
> +return self
> +
> +
>  class TestRunConfiguration(FrozenModel):
>  """The configuration of a test run.
>
> @@ -298,6 +377,8 @@ class TestRunConfiguration(FrozenModel):
>  vdevs: list[str] = Field(default_factory=list)
>  #: The seed to use for pseudo-random generation.
>  random_seed: int | None = None
> +#: The port links between the specified nodes to use.
> +port_topology: list[PortLinkConfig] = Field(max_length=2)
>
>  fields_from_settings = model_validator(mode="before")(
>  load_fields_from_settings("test_suites", "random_seed")
> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index 9f9789cf49..60a885d8e6 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -54,7 +54,7 @@
>  TestSuiteWithCases,
>  )
>  from .test_suite import TestCase, TestSuite
> -from .testbed_model.topology import Topology
> +from .testbed_model.topology import PortLink, Topology
>
>
>  class DTSRunner:
> @@ -331,7 +331,13 @@ def _run_test_run(
>  test_run_result.update_setup(Result.FAIL, e)
>
>  else:
> -self._run_test_suites(sut_node, tg_node, test_run_result, 
> test_suites_with_cases)
> +topology = Topology(
> +PortLink(sut_node.ports_by_name[link.sut_port], 
> tg_node.ports_by_name[link.tg_port])
> +for link in test_run_config.port_topology
> +)
> +self._run_test_suites(
> +sut_node, tg

[PATCH] devtools: ignore .gitignore in SPDX check

[Stephen Hemminger]

New .gitignore file in dts was getting marked as error.
Change to ignore all .gitignore files.
Remove no longer use Kbuild pattern.

Signed-off-by: Stephen Hemminger 
---
 devtools/check-spdx-tag.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/devtools/check-spdx-tag.sh b/devtools/check-spdx-tag.sh
index b983268b1e..47bc9f7b60 100755
--- a/devtools/check-spdx-tag.sh
+++ b/devtools/check-spdx-tag.sh
@@ -22,9 +22,9 @@ check_spdx() {
 git grep -L SPDX-License-Identifier -- \
':^.git*' ':^.mailmap' ':^.ci/*' \
':^README' ':^MAINTAINERS' ':^VERSION' ':^ABI_VERSION' \
-   ':^*/Kbuild' ':^*/README*' \
+   ':^*/README*' ':^*/.gitignore' \
':^license/' ':^config/' ':^buildtools/' ':^*/poetry.lock' \
-   ':^kernel/linux/uapi/.gitignore' ':^kernel/linux/uapi/version' \
+   ':^kernel/linux/uapi/version' \
':^*.cocci' ':^*.abignore' \
':^*.map' ':^*.ini' ':^*.data' ':^*.json' ':^*.cfg' ':^*.txt' \
':^*.svg' ':^*.png' \
-- 
2.47.2

RE: [EXTERNAL] Re: [PATCH] net/mana: use mana_local_data for tracking usage data for primary process

[Long Li]

> On Fri,  7 Feb 2025 15:21:45 -0800
> lon...@linuxonhyperv.com wrote:
> 
> > +   /* At least one eth_dev is probed, init shared data */
> > +   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> > +   rte_spinlock_lock(&mana_shared_data_lock);
> > +   mana_local_data.primary_cnt++;
> > +   rte_spinlock_unlock(&mana_shared_data_lock);
> > +   } else {
> > +   rte_spinlock_lock(&mana_shared_data_lock);
> > +   mana_local_data.secondary_cnt++;
> > +   rte_spinlock_unlock(&mana_shared_data_lock);
> > +
> > +   rte_spinlock_lock(&mana_shared_data->lock);
> > +   mana_shared_data->secondary_cnt++;
> > +   rte_spinlock_unlock(&mana_shared_data->lock);
> 
> If all you are doing is wanting a MP safe counter, use atomic operations 
> instead of
> the overhead of a spin lock.

mana_shared_data_lock is also used to protect init_done, mana_shared_mz and 
mana_shared_data.  That's why I'm reusing it for primary_cnt and secondary_cnt 
as those values are initialized in locked context at the beginning for the 
local process. I think this will make the code look clean. 

I can remove mana_shared_data->lock and use atomic for 
mana_shared_data->secondary_cnt.

Will send v2.

Thanks,

Long

Re: [PATCH v4] net: add thread-safe crc api

[Stephen Hemminger]

On Fri,  7 Feb 2025 06:37:58 +
Arkadiusz Kusztal  wrote:

> +* net: A thread/process-safe API was introduced. Old and new APIs share the 
> same
> +  function names, but the old one is versioned. Replaced functions are:
> +  ``rte_net_crc_calc`` and ``rte_net_crc_set_alg``. The new one is 
> ``rte_net_crc_free``

The first sentence should be more specific, and avoid passive voice.
Follow the style of other release notes in other releases.
Also, should indicate that versioning is short term (until 25.11).

Something like:

* **Changed the API for CRC calculation to be thread safe.**

  An opaque context argument was introduced to the net CRC API containing
  the algorithim type and length. This argument is added to
  to ``rte_net_crc_calc``, ``rte_net_crc_set_alg`` and freed with 
``rte_net_crc_free``.
  These functions are versioned to retain binary compatiabilty until the next 
LTS release.

Re: [PATCH v3 36/36] net/e1000: update e1000 documentation

[Bruce Richardson]

On Fri, Feb 07, 2025 at 12:45:28PM +, Anatoly Burakov wrote:
> Now that the base code has been brought up to date, update the docs to
> call this out.
> 
> Signed-off-by: Anatoly Burakov 
> ---
>  doc/guides/rel_notes/release_25_03.rst | 1 +
>  drivers/net/intel/e1000/base/README| 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_25_03.rst 
> b/doc/guides/rel_notes/release_25_03.rst
> index 341fdb9a37..82d72714f1 100644
> --- a/doc/guides/rel_notes/release_25_03.rst
> +++ b/doc/guides/rel_notes/release_25_03.rst
> @@ -96,6 +96,7 @@ New Features
>  * **Updated Intel e1000 driver.**
>  
> * Added support for the Intel i225-series NICs (previously handled by 
> net/igc).
> +   * Updated base code to the latest version.
>  
>  Removed Items
>  -
> diff --git a/drivers/net/intel/e1000/base/README 
> b/drivers/net/intel/e1000/base/README
> index 5d083a0e48..2a0696f3c4 100644
> --- a/drivers/net/intel/e1000/base/README
> +++ b/drivers/net/intel/e1000/base/README
> @@ -2,9 +2,9 @@
>   * Copyright(c) 2010-2020 Intel Corporation
>   */
>  
> -This directory contains source code of FreeBSD em, igb, and igc drivers of 
> version
> -cid-gigabit.2020.06.05.tar.gz released by ND. The sub-directory of base/
> -contains the original source package.
> +This directory contains source code of FreeBSD em, igb, and igc drivers of
> +snapshot generated on 2025-01-24-09.44. The sub-directory of base/ contains 
> the
> +original source package.
>  

I'm going to reword this on apply to something more similar to the other
base driver READMEs, since a) it's no longer a driver from FreeBSD and b) this
README is already in the "base" subdirectory.

"This directory contains source code of the base driver code for em/igb/igc,
with this snapshot generated on 2025-01-24-09.44."

Regards,
/Bruce

Re: [PATCH v3 00/36] Merge Intel IGC and E1000 drivers, and update E1000 base code

[Bruce Richardson]

On Fri, Feb 07, 2025 at 12:44:52PM +, Anatoly Burakov wrote:
> Intel IGC and E1000 drivers are distinct, but they are actually generated
> from the same base code. This patchset will merge together all e1000-derived
> drivers into one common base, with three different ethdev driver
> frontends (EM, IGB, and IGC).
> 
> After the merge is done, base code is also updated to latest snapshot.
> 
> v2 -> v3:
> - Fixes to drivers were separated out as a separate patchset [1]
> - Fixed signoffs and authorship
> - Fixed check-git-log and check-meson warnings
> - Added libabigail ignore for the removed driver
> - Added release notes
> - Updated MAINTAINERS file
> 
> v1 -> v2:
> - igc code is now a direct copy from IGC rather than a rebuild-from-source
> - i225-related fixes are now separate, not squashed
> - removed unused args warning workaround
> 
Thanks for all the work, Anatoly.

Series-acked-by: Bruce Richardson 

Applied to dpdk-next-net-intel.

/Bruce

RE: [PATCH v4] net: add thread-safe crc api

[Kusztal, ArkadiuszX]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Friday, February 7, 2025 6:13 PM
> To: Kusztal, ArkadiuszX 
> Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley,
> Brian 
> Subject: Re: [PATCH v4] net: add thread-safe crc api
> 
> On Fri,  7 Feb 2025 06:37:58 +
> Arkadiusz Kusztal  wrote:
> 
> > +* net: A thread/process-safe API was introduced. Old and new APIs share the
> same
> > +  function names, but the old one is versioned. Replaced functions are:
> > +  ``rte_net_crc_calc`` and ``rte_net_crc_set_alg``. The new one is
> ``rte_net_crc_free``
> 
> The first sentence should be more specific, and avoid passive voice.
> Follow the style of other release notes in other releases.
> Also, should indicate that versioning is short term (until 25.11).
> 
> Something like:
> 
> * **Changed the API for CRC calculation to be thread safe.**

But this was added under the `API changes` which states "* sample: Add a short 
1-2 sentence description of the API change".
This header is from the `New Features`, so should I add it to the `New 
Features` then?
Otherwise I agree.

> 
>   An opaque context argument was introduced to the net CRC API containing
>   the algorithim type and length. This argument is added to
>   to ``rte_net_crc_calc``, ``rte_net_crc_set_alg`` and freed with
> ``rte_net_crc_free``.
>   These functions are versioned to retain binary compatiabilty until the next 
> LTS
> release.

[PATCH v5 1/1] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Andre Muezerie]

This patch avoids warnings like the ones below emitted by MSVC:

1)
../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

2)
../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
signed/unsigned mismatch

The fix for (1) is to use 64-bit shifting when appropriate
(according to what the result is used for).

The fix for (2) is to explicitly cast the variables used in the
comparison.

Signed-off-by: Andre Muezerie 
---
 drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++---
 drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
 drivers/net/intel/iavf/iavf_rxtx.c |  2 +-
 drivers/net/intel/iavf/iavf_vchnl.c|  2 +-
 drivers/net/intel/ice/base/meson.build | 19 +--
 drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
 drivers/net/intel/ice/ice_ethdev.c |  4 ++--
 drivers/net/intel/ice/ice_rxtx.c   |  2 +-
 drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
 9 files changed, 32 insertions(+), 25 deletions(-)

diff --git a/drivers/net/intel/i40e/i40e_ethdev.c 
b/drivers/net/intel/i40e/i40e_ethdev.c
index bf5560ccc8..7a962c239d 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -3094,7 +3094,7 @@ i40e_stat_update_48_in_64(struct i40e_hw *hw, uint32_t 
hireg,
/* enlarge the limitation when statistics counters overflowed */
if (offset_loaded) {
if (I40E_RXTX_BYTES_L_48_BIT(*prev_stat) > *stat)
-   *stat += (uint64_t)1 << I40E_48_BIT_WIDTH;
+   *stat += RTE_BIT64(I40E_48_BIT_WIDTH);
*stat += I40E_RXTX_BYTES_H_16_BIT(*prev_stat);
}
*prev_stat = *stat;
@@ -4494,7 +4494,7 @@ i40e_macaddr_remove(struct rte_eth_dev *dev, uint32_t 
index)
pool_sel = dev->data->mac_pool_sel[index];
 
for (i = 0; i < sizeof(pool_sel) * CHAR_BIT; i++) {
-   if (pool_sel & (1ULL << i)) {
+   if (pool_sel & RTE_BIT64(i)) {
if (i == 0)
vsi = pf->main_vsi;
else {
@@ -4630,7 +4630,7 @@ i40e_dev_rss_reta_update(struct rte_eth_dev *dev,
for (i = 0; i < reta_size; i++) {
idx = i / RTE_ETH_RETA_GROUP_SIZE;
shift = i % RTE_ETH_RETA_GROUP_SIZE;
-   if (reta_conf[idx].mask & (1ULL << shift))
+   if (reta_conf[idx].mask & RTE_BIT64(shift))
lut[i] = reta_conf[idx].reta[shift];
}
ret = i40e_set_rss_lut(pf->main_vsi, lut, reta_size);
@@ -4674,7 +4674,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,
for (i = 0; i < reta_size; i++) {
idx = i / RTE_ETH_RETA_GROUP_SIZE;
shift = i % RTE_ETH_RETA_GROUP_SIZE;
-   if (reta_conf[idx].mask & (1ULL << shift))
+   if (reta_conf[idx].mask & RTE_BIT64(shift))
reta_conf[idx].reta[shift] = lut[i];
}
 
@@ -6712,7 +6712,7 @@ i40e_vmdq_setup(struct rte_eth_dev *dev)
loop = sizeof(vmdq_conf->pool_map[0].pools) * CHAR_BIT;
for (i = 0; i < vmdq_conf->nb_pool_maps; i++) {
for (j = 0; j < loop && j < pf->nb_cfg_vmdq_vsi; j++) {
-   if (vmdq_conf->pool_map[i].pools & (1UL << j)) {
+   if (vmdq_conf->pool_map[i].pools & RTE_BIT64(j)) {
PMD_INIT_LOG(INFO, "Add vlan %u to vmdq pool 
%u",
vmdq_conf->pool_map[i].vlan_id, j);
 
@@ -6761,7 +6761,7 @@ i40e_stat_update_32(struct i40e_hw *hw,
*stat = (uint64_t)(new_data - *offset);
else
*stat = (uint64_t)((new_data +
-   ((uint64_t)1 << I40E_32_BIT_WIDTH)) - *offset);
+   RTE_BIT64(I40E_32_BIT_WIDTH)) - *offset);
 }
 
 static void
@@ -6789,7 +6789,7 @@ i40e_stat_update_48(struct i40e_hw *hw,
*stat = new_data - *offset;
else
*stat = (uint64_t)((new_data +
-   ((uint64_t)1 << I40E_48_BIT_WIDTH)) - *offset);
+   RTE_BIT64(I40E_48_BIT_WIDTH)) - *offset);
 
*stat &= I40E_48_BIT_MASK;
 }
@@ -7730,7 +7730,7 @@ i40e_config_hena(const struct i40e_adapter *adapter, 
uint64_t flags)
return hena;
 
for (i = RTE_ETH_FLOW_UNKNOWN + 1; i < I40E_FLOW_TYPE_MAX; i++) {
-   if (flags & (1ULL << i))
+   if (flags & RTE_BIT64(i))
hena |= adapter->pctypes_tbl[i];
}
 
@@ -7749,7 +7749,7 @@ i40e_parse_hena(const struct i40e_adapter *adapter, 
uint64_t flags)
 
for (i = RTE_ETH_FLOW_UNKNOWN + 1; i < I40E_FLOW_TYPE_MAX; i++) {
if (flags & adapter->pctypes_tbl[i])
-   rss_hf |= (1ULL << i);
+   rss_hf |= RTE_BIT64(i);
}
return rss_hf;
 }
@@ -10162,7 +1

[PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

[Andre Muezerie]

This patch avoids warnings like the ones below emitted by MSVC:

1)
../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

2)
../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
signed/unsigned mismatch

The fix for (1) is to use 64-bit shifting when appropriate
(according to what the result is used for).

The fix for (2) is to explicitly cast the variables used in the
comparison.

v5:
 * rebase
 * use uint32_t instead of uint32, to better conform to DPDK standards
 * rename variable rqID to rq_id to better conform to DPDK standards
   and avoid checkpatch warning
 * use 2U instead of (uint32)2, which is shorter
 * simplify expression in meson.build using compiler id "gcc"

Andre Muezerie (1):
  drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

 drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++---
 drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
 drivers/net/intel/iavf/iavf_rxtx.c |  2 +-
 drivers/net/intel/iavf/iavf_vchnl.c|  2 +-
 drivers/net/intel/ice/base/meson.build | 19 +--
 drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
 drivers/net/intel/ice/ice_ethdev.c |  4 ++--
 drivers/net/intel/ice/ice_rxtx.c   |  2 +-
 drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
 9 files changed, 32 insertions(+), 25 deletions(-)

--
2.47.2.vfs.0.1

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Andre Muezerie]

On Fri, Feb 07, 2025 at 03:56:42PM +, Bruce Richardson wrote:
> On Fri, Feb 07, 2025 at 07:46:03AM -0800, Andre Muezerie wrote:
> > On Thu, Feb 06, 2025 at 11:07:32AM +, Bruce Richardson wrote:
> > > On Wed, Feb 05, 2025 at 11:32:24AM -0800, Andre Muezerie wrote:
> > > > This patch avoids warnings like the ones below emitted by MSVC:
> > > > 
> > > > 1)
> > > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> > > > result of 32-bit shift implicitly converted to 64 bits
> > > > (was 64-bit shift intended?)
> > > > 
> > > > 2)
> > > > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> > > > signed/unsigned mismatch
> > > > 
> > > > The fix for (1) is to use 64-bit shifting when appropriate
> > > > (according to what the result is used for).
> > > > 
> > > > The fix for (2) is to explicitly cast the variables used in the
> > > > comparison.
> > > > 
> > > > Signed-off-by: Andre Muezerie 
> > > > ---
> > > >  drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++---
> > > >  drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
> > > >  drivers/net/intel/iavf/iavf_rxtx.c |  2 +-
> > > >  drivers/net/intel/iavf/iavf_vchnl.c|  2 +-
> > > >  drivers/net/intel/ice/base/meson.build | 19 +--
> > > >  drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
> > > >  drivers/net/intel/ice/ice_ethdev.c |  4 ++--
> > > >  drivers/net/intel/ice/ice_rxtx.c   |  2 +-
> > > >  drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
> > > >  drivers/net/vmxnet3/vmxnet3_ethdev.h   |  6 +++---
> > > >  10 files changed, 35 insertions(+), 28 deletions(-)
> > > > 
> 
> 
> 
> > > > diff --git a/drivers/net/intel/ice/base/meson.build 
> > > > b/drivers/net/intel/ice/base/meson.build
> > > > index addb922ac9..dc5956f92c 100644
> > > > --- a/drivers/net/intel/ice/base/meson.build
> > > > +++ b/drivers/net/intel/ice/base/meson.build
> > > > @@ -31,18 +31,25 @@ sources = [
> > > >  'ice_vf_mbx.c',
> > > >  ]
> > > >  
> > > > -error_cflags = [
> > > > -'-Wno-unused-but-set-variable',
> > > > -'-Wno-unused-variable',
> > > > -'-Wno-unused-parameter',
> > > > -]
> > > > +if is_ms_compiler
> > > > +error_cflags = [
> > > > +'/wd4101', # unreferenced local variable
> > > > +'/wd4334', # result of 32-bit shift implicitly converted 
> > > > to 64 bits
> > > > +]
> > > > +else
> > > > +error_cflags = [
> > > > +'-Wno-unused-but-set-variable',
> > > > +'-Wno-unused-variable',
> > > > +'-Wno-unused-parameter',
> > > > +]
> > > > +endif
> > > >  
> > > 
> > > Do we actually need these if-else blocks here? The way
> > > the code is structured is that we check if the flags work to the current
> > > compiler and use only those that are relevant. Therefore, we should just 
> > > be
> > > able to have a list of error flags and leave meson to filter out the
> > > incorrect ones.
> > 
> > Both approaches work. I personally find the if-else approach in this case a 
> > little more readable
> > as it makes clear to which compiler the flags apply (considering that there 
> > might be multiple
> > flags with the same purpose, one for each compiler). But I'm open to 
> > updating the patch following
> > your suggestion.
> > 
> 
> If you find it more readable, ok to keep as-is.

Ok. I'll keep this as-is then.

> 
> > > 
> > > >  # Bugzilla ID: 678
> > > >  if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> > > >  error_cflags += ['-Wno-array-bounds']
> > > >  endif
> > > >  
> > > > -if is_windows and cc.get_id() != 'clang'
> > > > +if is_windows and not is_ms_compiler and cc.get_id() != 'clang'
> > > 
> > > Are there other supported compiler options for windows other than MSVC and
> > > clang? For what compiler are we adding this flag?
> > 
> > Yes, MinGW-w64 is also supported on Windows, so effectively this flag 
> > applies to this compiler.
> > https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html
> > Note that this flag was already there. I just changed the expression so 
> > that it is not used with msvc.
> > 
> 
> Ok, thanks for clarifying.
> Do we have a flag or check for identifying MinGW, because if we do that may
> be clearer in the check.

I checked on my system and MinGW identifies as "gcc". We can probably rely on 
that, so I simplified the expression as suggested.

> 
> > > 
> > > >  cflags += ['-fno-asynchronous-unwind-tables']
> > > >  endif
> > > >  
> > > > diff --git a/drivers/net/intel/ice/ice_dcf_sched.c 
> > > > b/drivers/net/intel/ice/ice_dcf_sched.c
> > > > index 7967c35533..2832d223d1 100644
> > > > --- a/drivers/net/intel/ice/ice_dcf_sched.c
> > > > +++ b/drivers/net/intel/ice/ice_dcf_sched.c
> > > > @@ -174,7 +174,7 @@ ice_dcf_node_param_check(struct ice_dcf_hw *hw, 
> > > > uint32_t node_id,
> > > > }
> > > >  
> > > > /* for non-leaf node */
> > > > -   if (node_id >= 8 * hw->num_vfs) {
> > > > +   if (nod

Re: [PATCH] net: support Arista L2 headers

[Stephen Hemminger]

On Fri, 7 Feb 2025 09:07:57 +
"Denis  Davidoglu"  wrote:

> From: Thomas Monjalon 
> > I'm not familiar with these headers.
> > Are they standardized?
> > Is there a RFC?  
> 
> Arista Vendor Specific Protocol is not publicly disclosed yet. However, 
> Wireshark already includes a dissector implementetation and its source code 
> can serve for now as a reference:
> https://gitlab.com/wireshark/wireshark/-/blob/master/epan/dissectors/packet-avsp.c
> 
> > I'm not sure about adding vendor specific protocols.
> > What should be the policy here?  
> 
> Given the large number of registered EtherType™ assignments related to IEEE 
> 802.3™ (ISO/IEC 8802-3) standard, supporting vendor-specific protocols should 
> be considered. Though probably not in the way I organized it, mixing 
> RFC-standardized and proprietary protocols in the same files. ./lib/net can 
> have a new subdirectory for keeping them separate. 
> 
> Arista timestamp is particularly valuable for stock exchanges due to 
> efficiency. The timestamp extension is already in use at German Eurex 
> Exchange and it needs to undergo PoC trials at Borsa İstanbul, which utilizes 
> Nasdaq infrastructure. Some parts of it rely on DPDK and this patch will be 
> especially useful.


The rte_net_ptype() is intended to provide a software equivalent for the packet 
type
matching done in many smart NIC's. It is not meant to be a general purpose L2 
packet
parser.

If a user needs to do this kind of packet processing, it belongs in the 
application
and all the data and metadata is exposed to do this.

Re: [PATCH v4] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Stephen Hemminger]

On Wed,  5 Feb 2025 11:32:24 -0800
Andre Muezerie  wrote:

> This patch avoids warnings like the ones below emitted by MSVC:
> 
> 1)
> ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
> 
> 2)
> ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> signed/unsigned mismatch
> 
> The fix for (1) is to use 64-bit shifting when appropriate
> (according to what the result is used for).
> 
> The fix for (2) is to explicitly cast the variables used in the
> comparison.
> 
> Signed-off-by: Andre Muezerie 

Applied to next-net with some rewording of commit title.

Re: [PATCH] net/af_packet: fix socket close on device stop

[Stephen Hemminger]

On Tue,  4 Feb 2025 18:45:08 +0200
Tudor Cornea  wrote:

> Currently, if we call rte_eth_dev_stop(), the sockets are closed.
> If we attempt to start the port again, socket related operations
> will not work correctly.
> 
> This can be alleviated by closing the socket at the same place in
> which we currently free the memory, in eth_dev_close().
> 
> If an application calls rte_eth_dev_stop() on a port managed
> by the af_packet PMD, the port becomes unusable. This is in contrast
> with ports managed by other drivers (e.g virtio).
> 
> I also managed to reproduce the issue using testpmd.
> 
> sudo ip link add test-veth0 type veth peer name test-veth1
> 
> sudo ip link set test-veth0 up
> sudo ip link set test-veth1 up
> 
> AF_PACKET_ARGS=\
> "blocksz=4096,framesz=2048,framecnt=512,qpairs=1,qdisc_bypass=0"
> 
> sudo ./dpdk-testpmd \
> -l 0-3 \
> -m 1024 \
> --no-huge \
> --no-shconf \
> --no-pci \
> --vdev=net_af_packet0,iface=test-veth0,${AF_PACKET_ARGS} \
> --vdev=net_af_packet1,iface=test-veth1,${AF_PACKET_ARGS} \
> -- \
> -i
> 
> testpmd> start tx_first  
> 
> Forwarding will start, and we will see traffic on the interfaces.
> 
> testpmd> stop
> testpmd> port stop 0  
> Stopping ports...
> Checking link statuses...
> Done
> testpmd> port stop 1  
> Stopping ports...
> Checking link statuses...
> Done
> 
> testpmd> port start 0  
> AFPACKET: eth_dev_macaddr_set(): receive socket not found
> Port 0: CA:65:81:63:81:B2
> Checking link statuses...
> Done
> testpmd> port start 1  
> AFPACKET: eth_dev_macaddr_set(): receive socket not found
> Port 1: CA:12:D0:BE:93:3F
> Checking link statuses...
> Done
> 
> testpmd> start tx_first  
> 
> When we start forwarding again, we can see that there is no traffic
> on the interfaces. This does not happen when testing with other PMD
> drivers (e.g virtio).
> 
> With the patch, the port should re-initialize correctly.
> 
> testpmd> port start 0  
> Port 0: CA:65:81:63:81:B2
> Checking link statuses...
> Done
> 
> Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
> 
> Signed-off-by: Tudor Cornea 


Applied to next-net
Should this go to stable as well

Re: [PATCH] net/sxe: add base driver directory and doc

[Stephen Hemminger]

On Fri,  3 Jan 2025 00:29:09 -0800
Jie Liu  wrote:

> Adding a minimum maintainable directory structure for the
> network driver and request maintenance of the sxe driver.
> 
> Signed-off-by: Jie Liu 
> ---
>  MAINTAINERS |  6 +
>  doc/guides/nics/features/sxe.ini| 10 +++
>  doc/guides/nics/features/sxe_vf.ini | 10 +++
>  doc/guides/nics/index.rst   |  1 +
>  doc/guides/nics/sxe.rst | 41 +
>  drivers/net/sxe/meson.build |  9 +++
>  drivers/net/sxe/pf/sxe_ethdev.c |  3 +++
>  drivers/net/sxe/pf/sxe_ethdev.h |  3 +++
>  8 files changed, 83 insertions(+)
>  create mode 100644 doc/guides/nics/features/sxe.ini
>  create mode 100644 doc/guides/nics/features/sxe_vf.ini
>  create mode 100644 doc/guides/nics/sxe.rst
>  create mode 100644 drivers/net/sxe/meson.build
>  create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
>  create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h

Thank you for starting work on a new driver.
We only accept drivers that have enough implemented to be useful.
No templates or base only code.

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 60bdcce543..0af5b437db 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2039,3 +2039,9 @@ F: examples/vmdq/
>  F: doc/guides/sample_app_ug/vmdq_forwarding.rst
>  F: examples/vmdq_dcb/
>  F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
> +
> +Linkdata sxe
> +M: Jie Li 
> +F: drivers/net/sxe/
> +F: doc/guides/nics/sxe.rst
> +F: doc/guides/nics/features/sxe*.ini

The maintainers file has sections. There is one for Ethernet drivers.
You should add your new entry there and in alphabetical order.
That would put 'Linkdata sxe' after the last Intel driver 'Intel ip3nke'


> diff --git a/doc/guides/nics/sxe.rst b/doc/guides/nics/sxe.rst
> new file mode 100644
> index 00..0efb220595
> --- /dev/null
> +++ b/doc/guides/nics/sxe.rst
> @@ -0,0 +1,41 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +Copyright (C), 2022, Linkdata Technology Co., Ltd.
> +
> +SXE Poll Mode Driver
> +==
> +
> +The SXE PMD (librte_pmd_sxe) provides poll mode driver support
> +for Linkdata 1160-2X 10GE Ethernet Adapter.
> +
> +
> +Configuration
> +-
> +
> +Dynamic Logging Parameters
> +~~
> +
> +One may leverage EAL option "--log-level" to change default levels
> +for the log types supported by the driver. The option is used with
> +an argument typically consisting of two parts separated by a colon.

This is awkward sentence don't use passive voice.
Look at the recent NTNIC PMD (ntnic.rst) for better wording.


> +
> +SXE PMD provides the following log types available for control:
> +
> +- ``pmd.net.sxe.drv`` (default level is **DEBUG**)
> +
> +  Affects driver-wide messages unrelated to any particular devices.
> +
> +- ``pmd.net.sxe.init`` (default level is **DEBUG**)
> +
> +  Extra logging of the messages during PMD initialization.
> +
> +- ``pmd.net.sxe.rx`` (default level is **DEBUG**)
> +
> +  Affects rx-wide messages.
> +- ``pmd.net.sxe.tx`` (default level is **DEBUG**)

The default in the release should not be DEBUG.
That implies to me the driver is not tested and ready.


> +Refer to the document :ref:`compiling and testing a PMD for a NIC 
> `
> +for details.

That part is not necessary.


Please resubmit when more is ready.
See https://doc.dpdk.org/guides/contributing/new_driver.html

[PATCH v1 0/3] Implement TXPP Support in ICE PMD

[Soumyadeep Hore]

This patchset includes TXPP feature implementation in ICE PMD.

Paul Greenwalt (2):
  net/intel: add support for timestamp ring HW workaround
  net/intel: add E830 ETF offload timestamp resolution

Soumyadeep Hore (1):
  net/intel: add Tx time queue

 drivers/net/intel/common/tx.h  |   5 +
 drivers/net/intel/ice/base/ice_lan_tx_rx.h |   5 +
 drivers/net/intel/ice/ice_ethdev.h |   1 +
 drivers/net/intel/ice/ice_rxtx.c   | 174 +
 drivers/net/intel/ice/ice_rxtx.h   |   5 +
 5 files changed, 190 insertions(+)

-- 
2.43.0

[PATCH v1 1/3] net/intel: add support for timestamp ring HW workaround

[Soumyadeep Hore]

From: Paul Greenwalt 

Earliest TxTime First Offload traffic result in an MDD event and Tx hang
due to a HW issue where the TS descriptor fetch logic does not wrap around
the tstamp ring properly. This occurs when the tail wraps around the ring
but the head has not, causing HW to fetch descriptors less than the head,
leading to an MDD event.

To prevent this, the driver creates additional TS descriptors when wrapping
the tstamp ring, equal to the fetch TS descriptors value stored in the
GLTXTIME_FETCH_PROFILE register. The additional TS descriptors will
reference the same Tx descriptor and contain the same timestamp, and HW
will merge the TS descriptors with the same timestamp into a single
descriptor.

The tstamp ring length will be increased to account for the additional TS
descriptors. The tstamp ring length is calculated as the Tx ring length
plus the fetch TS descriptors value, ensuring the same number of available
descriptors for both the Tx and tstamp rings.

Signed-off-by: Soumyadeep Hore 
Signed-off-by: Paul Greenwalt 
---
 drivers/net/intel/ice/base/ice_lan_tx_rx.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/intel/ice/base/ice_lan_tx_rx.h 
b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
index f92382346f..15aabf321d 100644
--- a/drivers/net/intel/ice/base/ice_lan_tx_rx.h
+++ b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
@@ -1278,6 +1278,8 @@ struct ice_ts_desc {
 #define ICE_TXTIME_MAX_QUEUE   2047
 #define ICE_SET_TXTIME_MAX_Q_AMOUNT127
 #define ICE_OP_TXTIME_MAX_Q_AMOUNT 2047
+#define ICE_TXTIME_FETCH_TS_DESC_DFLT  8
+
 /* Tx Time queue context data
  *
  * The sizes of the variables may be larger than needed due to crossing byte
@@ -1303,6 +1305,7 @@ struct ice_txtime_ctx {
u8 drbell_mode_32;
 #define ICE_TXTIME_CTX_DRBELL_MODE_32  1
u8 ts_res;
+#define ICE_TXTIME_CTX_FETCH_PROF_ID_0 0
u8 ts_round_type;
u8 ts_pacing_slot;
u8 merging_ena;
-- 
2.43.0

[PATCH v1 3/3] net/intel: add Tx time queue

[Soumyadeep Hore]

Enabling Tx timestamp queue for supporting Tx time based
scheduling of packets.

Signed-off-by: Soumyadeep Hore 
---
 drivers/net/intel/common/tx.h  |   5 +
 drivers/net/intel/ice/base/ice_lan_tx_rx.h |   1 +
 drivers/net/intel/ice/ice_ethdev.h |   1 +
 drivers/net/intel/ice/ice_rxtx.c   | 174 +
 drivers/net/intel/ice/ice_rxtx.h   |   5 +
 5 files changed, 186 insertions(+)

diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..f3777fa9e7 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -35,6 +35,7 @@ struct ci_tx_queue {
volatile struct i40e_tx_desc *i40e_tx_ring;
volatile struct iavf_tx_desc *iavf_tx_ring;
volatile struct ice_tx_desc *ice_tx_ring;
+   volatile struct ice_ts_desc *ice_tstamp_ring;
volatile union ixgbe_adv_tx_desc *ixgbe_tx_ring;
};
volatile uint8_t *qtx_tail;   /* register address of tail */
@@ -76,6 +77,10 @@ struct ci_tx_queue {
union {
struct { /* ICE driver specific values */
uint32_t q_teid; /* TX schedule node id. */
+   uint16_t nb_tstamp_desc;/* number of Timestamp 
descriptors */
+   volatile uint8_t *tstamp_tail;  /* value of timestamp 
tail register */
+   rte_iova_t tstamp_ring_dma; /* Timestamp ring DMA 
address */
+   uint16_t next_tstamp_id;
};
struct { /* I40E driver specific values */
uint8_t dcb_tc;
diff --git a/drivers/net/intel/ice/base/ice_lan_tx_rx.h 
b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
index 940c6843d9..edd1137114 100644
--- a/drivers/net/intel/ice/base/ice_lan_tx_rx.h
+++ b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
@@ -1279,6 +1279,7 @@ struct ice_ts_desc {
 #define ICE_SET_TXTIME_MAX_Q_AMOUNT127
 #define ICE_OP_TXTIME_MAX_Q_AMOUNT 2047
 #define ICE_TXTIME_FETCH_TS_DESC_DFLT  8
+#define ICE_TXTIME_FETCH_PROFILE_CNT   16
 
 /* Tx Time queue context data
  *
diff --git a/drivers/net/intel/ice/ice_ethdev.h 
b/drivers/net/intel/ice/ice_ethdev.h
index afe8dae497..9649456771 100644
--- a/drivers/net/intel/ice/ice_ethdev.h
+++ b/drivers/net/intel/ice/ice_ethdev.h
@@ -299,6 +299,7 @@ struct ice_vsi {
uint8_t enabled_tc; /* The traffic class enabled */
uint8_t vlan_anti_spoof_on; /* The VLAN anti-spoofing enabled */
uint8_t vlan_filter_on; /* The VLAN filter enabled */
+   uint8_t enabled_txpp;   /* TXPP support enabled */
/* information about rss configuration */
u32 rss_key_size;
u32 rss_lut_size;
diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
index 8dd8644b16..f043ae3aa6 100644
--- a/drivers/net/intel/ice/ice_rxtx.c
+++ b/drivers/net/intel/ice/ice_rxtx.c
@@ -5,6 +5,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "ice_rxtx.h"
 #include "ice_rxtx_vec_common.h"
@@ -741,6 +742,87 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t 
rx_queue_id)
return 0;
 }
 
+/**
+ * ice_setup_txtime_ctx - setup a struct ice_txtime_ctx instance
+ * @ring: The tstamp ring to configure
+ * @txtime_ctx: Pointer to the Tx time queue context structure to be 
initialized
+ * @txtime_ena: Tx time enable flag, set to true if Tx time should be enabled
+ */
+static int
+ice_setup_txtime_ctx(struct ci_tx_queue *txq,
+struct ice_txtime_ctx *txtime_ctx, bool txtime_ena)
+{
+   struct ice_vsi *vsi = txq->ice_vsi;
+   struct ice_hw *hw;
+
+   hw = ICE_VSI_TO_HW(vsi);
+   txtime_ctx->base = txq->tstamp_ring_dma >> ICE_TX_CMPLTNQ_CTX_BASE_S;
+
+   /* Tx time Queue Length */
+   txtime_ctx->qlen = txq->nb_tstamp_desc;
+
+   if (txtime_ena)
+   txtime_ctx->txtime_ena_q = 1;
+
+   /* PF number */
+   txtime_ctx->pf_num = hw->pf_id;
+
+   switch (vsi->type) {
+   case ICE_VSI_LB:
+   case ICE_VSI_CTRL:
+   case ICE_VSI_ADI:
+   case ICE_VSI_PF:
+   txtime_ctx->vmvf_type = ICE_TLAN_CTX_VMVF_TYPE_PF;
+   break;
+   default:
+   PMD_DRV_LOG(ERR, "Unable to set VMVF type for VSI type %d",
+   vsi->type);
+   return -EINVAL;
+   }
+
+   /* make sure the context is associated with the right VSI */
+   txtime_ctx->src_vsi = ice_get_hw_vsi_num(hw, vsi->idx);
+
+
+   txtime_ctx->ts_res = ICE_TXTIME_CTX_RESOLUTION_128NS;
+   txtime_ctx->drbell_mode_32 = ICE_TXTIME_CTX_DRBELL_MODE_32;
+   txtime_ctx->ts_fetch_prof_id = ICE_TXTIME_CTX_FETCH_PROF_ID_0;
+
+   return 0;
+}
+
+/**
+ * ice_calc_ts_ring_count - Calculate the number of timestamp descriptors
+ * @hw: pointer to the hardware structure
+ * @tx_desc_count: number of Tx descriptors in the ring
+ *
+ * Return: the number of timestamp descr

[PATCH v1 2/3] net/intel: add E830 ETF offload timestamp resolution

[Soumyadeep Hore]

From: Paul Greenwalt 

Update E830 ETF offload time stamp resolution to 128ns.

Signed-off-by: Soumyadeep Hore 
Signed-off-by: Paul Greenwalt 
---
 drivers/net/intel/ice/base/ice_lan_tx_rx.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/intel/ice/base/ice_lan_tx_rx.h 
b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
index 15aabf321d..940c6843d9 100644
--- a/drivers/net/intel/ice/base/ice_lan_tx_rx.h
+++ b/drivers/net/intel/ice/base/ice_lan_tx_rx.h
@@ -1306,6 +1306,7 @@ struct ice_txtime_ctx {
 #define ICE_TXTIME_CTX_DRBELL_MODE_32  1
u8 ts_res;
 #define ICE_TXTIME_CTX_FETCH_PROF_ID_0 0
+#define ICE_TXTIME_CTX_RESOLUTION_128NS 7
u8 ts_round_type;
u8 ts_pacing_slot;
u8 merging_ena;
-- 
2.43.0

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

[Stephen Hemminger]

On Fri,  7 Feb 2025 09:41:08 -0800
Andre Muezerie  wrote:

> This patch avoids warnings like the ones below emitted by MSVC:
> 
> 1)
> ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
> 
> 2)
> ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> signed/unsigned mismatch
> 
> The fix for (1) is to use 64-bit shifting when appropriate
> (according to what the result is used for).
> 
> The fix for (2) is to explicitly cast the variables used in the
> comparison.
> 
> v5:
>  * rebase
>  * use uint32_t instead of uint32, to better conform to DPDK standards
>  * rename variable rqID to rq_id to better conform to DPDK standards
>and avoid checkpatch warning
>  * use 2U instead of (uint32)2, which is shorter
>  * simplify expression in meson.build using compiler id "gcc"
> 
> Andre Muezerie (1):
>   drivers/net: use 64-bit shift and avoid signed/unsigned mismatch
> 
>  drivers/net/intel/i40e/i40e_ethdev.c   | 22 +++---
>  drivers/net/intel/iavf/iavf_ethdev.c   |  2 +-
>  drivers/net/intel/iavf/iavf_rxtx.c |  2 +-
>  drivers/net/intel/iavf/iavf_vchnl.c|  2 +-
>  drivers/net/intel/ice/base/meson.build | 19 +--
>  drivers/net/intel/ice/ice_dcf_sched.c  |  2 +-
>  drivers/net/intel/ice/ice_ethdev.c |  4 ++--
>  drivers/net/intel/ice/ice_rxtx.c   |  2 +-
>  drivers/net/intel/ixgbe/ixgbe_ethdev.c |  2 +-
>  9 files changed, 32 insertions(+), 25 deletions(-)


Since all intel, this should get picked up by next-intel

[PATCH v7 25/28] net/rnp: support VLAN offloads.

[Wenbo Cao]

add support rx vlan strip,filter, tx vlan/qinq insert.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   2 +
 doc/guides/nics/rnp.rst |   1 +
 drivers/net/rnp/base/rnp_bdq_if.h   |   2 +-
 drivers/net/rnp/base/rnp_eth_regs.h |   5 +
 drivers/net/rnp/base/rnp_hw.h   |   2 +
 drivers/net/rnp/base/rnp_mac.c  |  53 ++-
 drivers/net/rnp/base/rnp_mac.h  |   1 +
 drivers/net/rnp/base/rnp_mac_regs.h |  41 -
 drivers/net/rnp/rnp.h   |   7 ++
 drivers/net/rnp/rnp_ethdev.c| 177 +++-
 drivers/net/rnp/rnp_rxtx.c  |  22 -
 11 files changed, 306 insertions(+), 7 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 7e97da9..18ec4bc 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -20,6 +20,8 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
 Unicast MAC filter   = Y
+VLAN offload = Y
+QinQ offload = Y
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 8f667a4..febdaf8 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -23,6 +23,7 @@ Features
 - Port hardware statistic
 - Packet type parsing
 - Checksum offload
+- VLAN stripping and VLAN/QINQ insertion
 
 Prerequisites
 -
diff --git a/drivers/net/rnp/base/rnp_bdq_if.h 
b/drivers/net/rnp/base/rnp_bdq_if.h
index 7a6d0b2..182a8a7 100644
--- a/drivers/net/rnp/base/rnp_bdq_if.h
+++ b/drivers/net/rnp/base/rnp_bdq_if.h
@@ -87,7 +87,7 @@ struct rnp_tx_desc {
 #define RNP_RX_TUNNEL_MASK RTE_GENMASK32(14, 13)
 #define RNP_RX_PTYPE_VXLAN (0x01UL << RNP_RX_TUNNEL_TYPE_S)
 #define RNP_RX_PTYPE_NVGRE (0x02UL << RNP_RX_TUNNEL_TYPE_S)
-#define RNP_RX_PTYPE_VLAN  RTE_BIT32(15)
+#define RNP_RX_STRIP_VLAN  RTE_BIT32(15)
 /* mark_data */
 #define RNP_RX_L3TYPE_VALIDRTE_BIT32(31)
 /* tx data cmd */
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index b0961a1..802a127 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -56,6 +56,11 @@
 #define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+/* vlan strip ctrl */
+#define RNP_VLAN_Q_STRIP_CTRL(n)   _ETH_(0x8040 + 0x4 * ((n) / 32))
+/* vlan filter ctrl */
+#define RNP_VLAN_FILTER_CTRL   _ETH_(0x9118)
+#define RNP_VLAN_FILTER_EN RTE_BIT32(30)
 /* rss function ctrl */
 #define RNP_RSS_INNER_CTRL _ETH_(0x805c)
 #define RNP_INNER_RSS_EN   (1)
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index a1cf45a..6d07480 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -74,6 +74,8 @@ struct rnp_mac_ops {
/* Receive Address Filter table */
int (*set_rafb)(struct rnp_eth_port *port, u8 *mac, u32 index);
int (*clear_rafb)(struct rnp_eth_port *port, u32 index);
+   /* receive vlan filter */
+   int (*vlan_f_en)(struct rnp_eth_port *port, bool en);
 };
 
 struct rnp_eth_adapter;
diff --git a/drivers/net/rnp/base/rnp_mac.c b/drivers/net/rnp/base/rnp_mac.c
index 01929fd..ddf2a36 100644
--- a/drivers/net/rnp/base/rnp_mac.c
+++ b/drivers/net/rnp/base/rnp_mac.c
@@ -173,11 +173,53 @@
return 0;
 }
 
+static int
+rnp_en_vlan_filter_pf(struct rnp_eth_port *port, bool en)
+{
+   struct rnp_hw *hw = port->hw;
+   u32 ctrl;
+
+   /* enable/disable all vlan filter configuration */
+   ctrl = RNP_E_REG_RD(hw, RNP_VLAN_FILTER_CTRL);
+   if (en)
+   ctrl |= RNP_VLAN_FILTER_EN;
+   else
+   ctrl &= ~RNP_VLAN_FILTER_EN;
+   RNP_E_REG_WR(hw, RNP_VLAN_FILTER_CTRL, ctrl);
+
+   return 0;
+}
+
+static int
+rnp_en_vlan_filter_indep(struct rnp_eth_port *port, bool en)
+{
+   u16 lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   u32 flt_reg, vlan_reg;
+
+   flt_reg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_PKT_FLT_CTRL);
+   vlan_reg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_VLAN_TAG);
+   if (en) {
+   flt_reg |= RNP_MAC_VTFE;
+   vlan_reg |= (RNP_MAC_VLAN_VTHM | RNP_MAC_VLAN_ETV);
+   vlan_reg |= RNP_MAC_VLAN_HASH_EN;
+   } else {
+   flt_reg &= ~RNP_MAC_VTFE;
+   vlan_reg &= ~(RNP_MAC_VLAN_VTHM | RNP_MAC_VLAN_ETV);
+   vlan_reg &= ~RNP_MAC_VLAN_HASH_EN;
+   }
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_PKT_FLT_CTRL, flt_reg);
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_VLAN_TAG, vlan_reg);
+
+   return 0;
+}
+
 const struct rnp_mac_ops rnp_mac_ops_pf = {
.get_macaddr = rnp_mbx_fw_get_macaddr,
.update_mpfm = rnp_update_mpfm_pf,
.set_rafb = rnp_set_mac_addr_pf,
-   .clear_rafb = rnp_clear_mac_pf
+ 

[PATCH v7 24/28] net/rnp: add support Tx TSO offload

[Wenbo Cao]

Add support tx tso and tunnel tso.
for tunnel just support vxlan/nvgre

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_bdq_if.h |   1 +
 drivers/net/rnp/rnp.h |   2 +-
 drivers/net/rnp/rnp_ethdev.c  |  16 ++
 drivers/net/rnp/rnp_rxtx.c| 457 +-
 drivers/net/rnp/rnp_rxtx.h|   1 +
 5 files changed, 471 insertions(+), 6 deletions(-)

diff --git a/drivers/net/rnp/base/rnp_bdq_if.h 
b/drivers/net/rnp/base/rnp_bdq_if.h
index a7d27bd..7a6d0b2 100644
--- a/drivers/net/rnp/base/rnp_bdq_if.h
+++ b/drivers/net/rnp/base/rnp_bdq_if.h
@@ -111,6 +111,7 @@ struct rnp_tx_desc {
 #define RNP_TX_VLAN_VALID  RTE_BIT32(15)
 /* tx data mac_ip len */
 #define RNP_TX_MAC_LEN_S   (9)
+#define RNP_TX_MAC_LEN_MASKRTE_GENMASK32(15, 9)
 /* tx ctrl cmd */
 #define RNP_TX_LEN_PAD_S   (8)
 #define RNP_TX_OFF_MAC_PAD (0x01UL << RNP_TX_LEN_PAD_S)
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 702bbd0..d0afef3 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -17,7 +17,7 @@
 #define RNP_ETH_OVERHEAD \
(RTE_ETHER_HDR_LEN + RTE_VLAN_HLEN * 2)
 #define RNP_MAC_MAXFRM_SIZE(9590)
-
+#define RNP_MAX_TSO_PKT(16 * 1024)
 #define RNP_RX_MAX_MTU_SEG (64)
 #define RNP_TX_MAX_MTU_SEG (32)
 #define RNP_RX_MAX_SEG (150)
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 5886894..47d4771 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -650,6 +650,17 @@ static int rnp_dev_infos_get(struct rte_eth_dev *eth_dev,
dev_info->speed_capa = rnp_get_speed_caps(eth_dev);
/* rx support offload cap */
dev_info->rx_offload_capa = RNP_RX_CHECKSUM_SUPPORT;
+   /* tx support offload cap */
+   dev_info->tx_offload_capa = 0 |
+RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
+RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
+RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
+RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
+RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+RTE_ETH_TX_OFFLOAD_TCP_TSO |
+RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
+RTE_ETH_TX_OFFLOAD_MULTI_SEGS;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_drop_en = 0,
.rx_thresh = {
@@ -1083,13 +1094,18 @@ static void rnp_get_hw_stats(struct rte_eth_dev *dev)
(data->tx_queues))[i]->stats.opackets;
stats->q_obytes[i] = ((struct rnp_tx_queue **)
(data->tx_queues))[i]->stats.obytes;
+   stats->oerrors += ((struct rnp_tx_queue **)
+   (data->tx_queues))[i]->stats.errors;
stats->opackets += stats->q_opackets[i];
stats->obytes += stats->q_obytes[i];
+
} else {
stats->opackets += ((struct rnp_tx_queue **)
(data->tx_queues))[i]->stats.opackets;
stats->obytes += ((struct rnp_tx_queue **)
(data->tx_queues))[i]->stats.obytes;
+   stats->oerrors += ((struct rnp_tx_queue **)
+   (data->tx_queues))[i]->stats.errors;
}
}
stats->imissed = eth_stats->rx_trans_drop + eth_stats->rx_trunc_drop;
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index 5493da4..bacbfca 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -1130,6 +1130,198 @@ struct rnp_rx_cksum_parse {
 
return txq->nb_tx_free;
 }
+static inline uint32_t
+rnp_cal_tso_seg(struct rte_mbuf *mbuf)
+{
+   uint32_t hdr_len;
+
+   hdr_len = mbuf->l2_len + mbuf->l3_len + mbuf->l4_len;
+
+   hdr_len += (mbuf->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) ?
+   mbuf->outer_l2_len + mbuf->outer_l3_len : 0;
+
+   return (mbuf->tso_segsz) ? mbuf->tso_segsz : hdr_len;
+}
+
+static inline bool
+rnp_need_ctrl_desc(uint64_t flags)
+{
+   static uint64_t mask = RTE_MBUF_F_TX_OUTER_IP_CKSUM |
+  RTE_MBUF_F_TX_TCP_SEG |
+  RTE_MBUF_F_TX_TUNNEL_VXLAN |
+  RTE_MBUF_F_TX_TUNNEL_GRE;
+   return (flags & mask) ? 1 : 0;
+}
+
+static void
+rnp_build_tx_control_desc(struct rnp_tx_queue *txq,
+ volatile struct rnp_tx_desc *txbd,
+ struct rte_mbuf *mbuf)
+{
+   struct rte_gre_hdr *gre_hdr;
+   uint16_t tunnel_len = 0;
+   uint64_t flags;
+
+   *txbd = txq->zero_desc

[PATCH v7 08/28] net/rnp: add queue setup and release operations

[Wenbo Cao]

support tx/rx queue setup and release add hw bd
queue reset,sw queue reset.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst |   1 +
 drivers/net/rnp/base/meson.build|   1 +
 drivers/net/rnp/base/rnp_bdq_if.c   | 397 ++
 drivers/net/rnp/base/rnp_bdq_if.h   | 149 +++
 drivers/net/rnp/base/rnp_common.h   |   4 +
 drivers/net/rnp/base/rnp_dma_regs.h |  45 
 drivers/net/rnp/base/rnp_eth_regs.h |   4 +
 drivers/net/rnp/base/rnp_hw.h   |   3 +
 drivers/net/rnp/base/rnp_osdep.h|  13 +
 drivers/net/rnp/meson.build |   1 +
 drivers/net/rnp/rnp.h   |   2 +
 drivers/net/rnp/rnp_ethdev.c|  29 +++
 drivers/net/rnp/rnp_rxtx.c  | 476 
 drivers/net/rnp/rnp_rxtx.h  | 123 ++
 14 files changed, 1248 insertions(+)
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.c
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.h
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 62585ac..5417593 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -10,6 +10,7 @@ driver support for the inbuilt network device found in the 
**Mucse RNP**
 Features
 
 
+- Multiple queues for TX and RX
 - Promiscuous mode
 
 Prerequisites
diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index b9db033..c2ef0d0 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -7,6 +7,7 @@ sources = [
 'rnp_mbx_fw.c',
 'rnp_common.c',
 'rnp_mac.c',
+   'rnp_bdq_if.c',
 ]
 
 error_cflags = ['-Wno-unused-value',
diff --git a/drivers/net/rnp/base/rnp_bdq_if.c 
b/drivers/net/rnp/base/rnp_bdq_if.c
new file mode 100644
index 000..cc3fe51
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_bdq_if.c
@@ -0,0 +1,397 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include "rnp_osdep.h"
+
+#include "../rnp.h"
+#include "rnp_dma_regs.h"
+#include "rnp_eth_regs.h"
+#include "rnp_bdq_if.h"
+#include "rnp_common.h"
+#include "../rnp_rxtx.h"
+
+static void
+rnp_read_mac_veb(struct rnp_hw *hw,
+ u16 nr_lane,
+ u16 vf_id,
+ struct rnp_veb_cfg *cfg)
+{
+   cfg->mac_lo = RNP_E_REG_RD(hw, RNP_VEB_MAC_LO(nr_lane, vf_id));
+   cfg->mac_hi = RNP_E_REG_RD(hw, RNP_VEB_MAC_HI(nr_lane, vf_id));
+   cfg->ring = RNP_E_REG_RD(hw, RNP_VEB_VF_RING(nr_lane, vf_id));
+}
+
+static void
+rnp_update_mac_veb(struct rnp_hw *hw,
+  u16 nr_lane,
+  u16 vf_id,
+  struct rnp_veb_cfg *cfg)
+{
+   u32 reg = cfg->ring;
+   u16 idx = 0;
+
+   idx = nr_lane;
+   wmb();
+   RNP_E_REG_WR(hw, RNP_VEB_MAC_LO(idx, vf_id), cfg->mac_lo);
+   RNP_E_REG_WR(hw, RNP_VEB_MAC_HI(idx, vf_id), cfg->mac_hi);
+   reg |= ((RNP_VEB_SWITCH_VF_EN | vf_id) << 8);
+   RNP_E_REG_WR(hw, RNP_VEB_VF_RING(idx, vf_id), reg);
+}
+
+void
+rnp_rxq_flow_disable(struct rnp_hw *hw,
+u16 hw_idx)
+{
+   u32 fc_ctrl;
+
+   spin_lock(&hw->rxq_reset_lock);
+   fc_ctrl = RNP_E_REG_RD(hw, RNP_RING_FC_EN(hw_idx));
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_THRESH(hw_idx), 0);
+   fc_ctrl |= 1 << (hw_idx % 32);
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_EN(hw_idx), fc_ctrl);
+}
+
+void
+rnp_rxq_flow_enable(struct rnp_hw *hw,
+   u16 hw_idx)
+{
+   u32 fc_ctrl;
+
+
+   fc_ctrl = RNP_E_REG_RD(hw, RNP_RING_FC_EN(hw_idx));
+   fc_ctrl &= ~(1 << (hw_idx % 32));
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_EN(hw_idx), fc_ctrl);
+
+   spin_unlock(&hw->rxq_reset_lock);
+}
+
+#define RNP_RXQ_RESET_PKT_LEN  (64)
+
+static void
+rnp_reset_xmit(struct rnp_tx_queue *txq, u64 pkt_addr)
+{
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *tx_entry;
+   u16 timeout = 0;
+   u16 tx_id;
+
+   tx_id = txq->tx_tail;
+   txbd = &txq->tx_bdr[tx_id];
+   tx_entry = &txq->sw_ring[tx_id];
+   memset(tx_entry, 0, sizeof(*tx_entry));
+
+   txbd->d.addr = pkt_addr;
+   txbd->d.blen = RNP_RXQ_RESET_PKT_LEN;
+   wmb();
+   txbd->d.cmd = cpu_to_le16(RNP_CMD_EOP | RNP_CMD_RS);
+   tx_id = (tx_id + 1) & txq->attr.nb_desc_mask;
+   wmb();
+   RNP_REG_WR(txq->tx_tailreg, 0, tx_id);
+   do {
+   if (txbd->d.cmd & RNP_CMD_DD)
+   break;
+   if (timeout == 1000)
+   RNP_PMD_ERR("rx queue %u reset send pkt is hang\n",
+   txq->attr.index);
+   timeout++;
+   udelay(10);
+   } while (1);
+}
+
+void
+rnp_reset_hw_rxq_op(struct rnp_hw *hw,
+   struct rnp_rx_queue *rxq,
+   struct rnp_tx_queue *txq,
+

Re: [PATCH v4] test: improve resiliency of malloc autotest

[fengchengwen]

Acked-by: Chengwen Feng 

On 2025/2/7 22:32, Bruce Richardson wrote:
> The test case "test_multi_alloc_statistics" was brittle in that it did
> some allocations and frees and then checked statistics without
> considering the initial state of the malloc heaps. This meant that,
> depending on what allocations/frees were done beforehand, the test can
> sometimes fail.
> 
> We can improve resiliency by running the test using a new malloc heap,
> which means it is unaffected by any previous allocations.
> 
> Bugzilla ID: 1579
> Fixes: a40a1f8231b4 ("app: various tests update")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bruce Richardson 

Re: [PATCH] net/mana: use mana_local_data for tracking usage data for primary process

[Stephen Hemminger]

On Fri,  7 Feb 2025 15:21:45 -0800
lon...@linuxonhyperv.com wrote:

> + /* At least one eth_dev is probed, init shared data */
> + if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> + rte_spinlock_lock(&mana_shared_data_lock);
> + mana_local_data.primary_cnt++;
> + rte_spinlock_unlock(&mana_shared_data_lock);
> + } else {
> + rte_spinlock_lock(&mana_shared_data_lock);
> + mana_local_data.secondary_cnt++;
> + rte_spinlock_unlock(&mana_shared_data_lock);
> +
> + rte_spinlock_lock(&mana_shared_data->lock);
> + mana_shared_data->secondary_cnt++;
> + rte_spinlock_unlock(&mana_shared_data->lock);

If all you are doing is wanting a MP safe counter, use atomic operations
instead of the overhead of a spin lock.

[PATCH v26 11/13] compress/zsda: add zsda compressdev enqueue datapath

[Hanxiao Li]

Add zsda compressdev enqueue datapath.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/meson.build   |   2 +-
 drivers/common/zsda/zsda_qp.c | 115 +
 drivers/common/zsda/zsda_qp.h |   9 +-
 drivers/common/zsda/zsda_qp_common.c  |  72 
 drivers/common/zsda/zsda_qp_common.h  |  30 
 drivers/compress/zsda/zsda_comp.c | 233 ++
 drivers/compress/zsda/zsda_comp.h |  36 
 drivers/compress/zsda/zsda_comp_pmd.c |  15 +-
 8 files changed, 509 insertions(+), 3 deletions(-)
 create mode 100644 drivers/compress/zsda/zsda_comp.c
 create mode 100644 drivers/compress/zsda/zsda_comp.h

diff --git a/drivers/common/zsda/meson.build b/drivers/common/zsda/meson.build
index 6e6d5ab006..152150e5ef 100644
--- a/drivers/common/zsda/meson.build
+++ b/drivers/common/zsda/meson.build
@@ -20,7 +20,7 @@ zsda_compress_path = 'compress/zsda'
 zsda_compress_relpath = '../../' + zsda_compress_path
 includes += include_directories(zsda_compress_relpath)
 if zsda_compress
-   foreach f: ['zsda_comp_pmd.c']
+   foreach f: ['zsda_comp_pmd.c', 'zsda_comp.c']
sources += files(join_paths(zsda_compress_relpath, f))
endforeach
 endif
diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
index 3c3226ec45..c85b9ddb75 100644
--- a/drivers/common/zsda/zsda_qp.c
+++ b/drivers/common/zsda/zsda_qp.c
@@ -237,6 +237,16 @@ zsda_modulo_32(uint32_t data, uint32_t modulo_mask)
 {
return (data) & (modulo_mask);
 }
+static inline uint16_t
+zsda_modulo_16(uint16_t data, uint16_t modulo_mask)
+{
+   return (data) & (modulo_mask);
+}
+static inline uint8_t
+zsda_modulo_8(uint8_t data, uint8_t modulo_mask)
+{
+   return (data) & (modulo_mask);
+}
 
 static int
 zsda_admin_msg_send(const struct rte_pci_device *pci_dev, void *req,
@@ -773,3 +783,108 @@ zsda_task_queue_setup(struct zsda_pci_device 
*zsda_pci_dev,
 
return ret;
 }
+
+static int
+zsda_free_cookie_find(const struct zsda_queue *queue, void **op_cookie,
+ uint16_t *idx)
+{
+   uint16_t old_tail = queue->tail;
+   uint16_t tail = queue->tail;
+   struct zsda_op_cookie *cookie;
+
+   do {
+   cookie = op_cookie[tail];
+   if (!cookie->used) {
+   *idx = tail & (queue->queue_size - 1);
+   return ZSDA_SUCCESS;
+   }
+   tail = zsda_modulo_16(tail++, queue->modulo_mask);
+   } while (old_tail != tail);
+
+   return -EINVAL;
+}
+
+static int
+zsda_enqueue(void *op, struct zsda_qp *qp)
+{
+   uint16_t new_tail;
+   enum zsda_service_type type;
+   void **op_cookie;
+   int ret = ZSDA_SUCCESS;
+   struct zsda_queue *queue;
+
+   for (type = 0; type < ZSDA_SERVICE_INVALID; type++) {
+   if (qp->srv[type].used) {
+   if (!qp->srv[type].match(op))
+   continue;
+   queue = &qp->srv[type].tx_q;
+   op_cookie = qp->srv[type].op_cookies;
+
+   if (zsda_free_cookie_find(queue, op_cookie,
+ &new_tail)) {
+   ret = -EBUSY;
+   break;
+   }
+   ret = qp->srv[type].tx_cb(op, queue, op_cookie,
+ new_tail);
+   if (ret) {
+   qp->srv[type].stats.enqueue_err_count++;
+   ZSDA_LOG(ERR, "Failed! config wqe");
+   break;
+   }
+   qp->srv[type].stats.enqueued_count++;
+
+   queue->tail = zsda_modulo_16(new_tail + 1,
+queue->queue_size - 1);
+
+   if (new_tail > queue->tail)
+   queue->valid =
+   zsda_modulo_8(queue->valid + 1,
+   (uint8_t)(queue->cycle_size - 1));
+
+   queue->pushed_wqe++;
+   break;
+   }
+   }
+
+   return ret;
+}
+
+static void
+zsda_tx_tail_write(struct zsda_queue *queue)
+{
+   if (queue->pushed_wqe)
+   WRITE_CSR_WQ_TAIL(queue->io_addr, queue->hw_queue_number,
+ queue->tail);
+
+   queue->pushed_wqe = 0;
+}
+
+uint16_t
+zsda_enqueue_burst(struct zsda_qp *qp, void **ops, const uint16_t nb_ops)
+{
+   int ret = ZSDA_SUCCESS;
+   enum zsda_service_type type;
+   uint16_t i;
+   uint16_t nb_send = 0;
+   void *op;
+
+   if (nb_ops > ZSDA_MAX_DESC) {
+   ZSDA_LOG(ERR, "Enqueue number bigger than %d", ZSDA_MAX_DESC);
+   return 0;
+   }
+
+   for (i = 0; i < nb_ops; i++) {
+   op = ops[i]

[PATCH v26 06/13] compress/zsda: add zsda compressdev driver skeleton

[Hanxiao Li]

Add zsda compressdev driver interface skeleton

Signed-off-by: Hanxiao Li 
---
 MAINTAINERS   |   3 +
 doc/guides/compressdevs/features/zsda.ini |   6 +
 doc/guides/compressdevs/index.rst |   1 +
 doc/guides/compressdevs/zsda.rst  | 171 ++
 drivers/common/zsda/meson.build   |  12 +-
 drivers/common/zsda/zsda_device.c |   9 +-
 drivers/common/zsda/zsda_device.h |   5 +
 drivers/common/zsda/zsda_qp.c |  24 +++
 drivers/common/zsda/zsda_qp.h |  10 ++
 drivers/common/zsda/zsda_qp_common.h  |   4 +-
 drivers/compress/zsda/zsda_comp_pmd.c | 104 +
 drivers/compress/zsda/zsda_comp_pmd.h |  36 +
 12 files changed, 382 insertions(+), 3 deletions(-)
 create mode 100644 doc/guides/compressdevs/features/zsda.ini
 create mode 100644 doc/guides/compressdevs/zsda.rst
 create mode 100644 drivers/compress/zsda/zsda_comp_pmd.c
 create mode 100644 drivers/compress/zsda/zsda_comp_pmd.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 86864bc5f1..ff90c916a5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1315,6 +1315,9 @@ F: doc/guides/compressdevs/features/zlib.ini
 ZTE Storage Data Accelerator(ZSDA)
 M: Hanxiao Li 
 F: drivers/common/zsda/
+F: drivers/compress/zsda/
+F: doc/guides/compressdevs/zsda.rst
+F: doc/guides/compressdevs/features/zsda.ini
 
 DMAdev Drivers
 --
diff --git a/doc/guides/compressdevs/features/zsda.ini 
b/doc/guides/compressdevs/features/zsda.ini
new file mode 100644
index 00..5cc9a3b1a6
--- /dev/null
+++ b/doc/guides/compressdevs/features/zsda.ini
@@ -0,0 +1,6 @@
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+; Supported features of 'ZSDA' compression driver.
+;
+[Features]
diff --git a/doc/guides/compressdevs/index.rst 
b/doc/guides/compressdevs/index.rst
index 87ed4f72a4..bab226ffbc 100644
--- a/doc/guides/compressdevs/index.rst
+++ b/doc/guides/compressdevs/index.rst
@@ -17,3 +17,4 @@ Compression Device Drivers
 qat_comp
 uadk
 zlib
+zsda
diff --git a/doc/guides/compressdevs/zsda.rst b/doc/guides/compressdevs/zsda.rst
new file mode 100644
index 00..da7117b45e
--- /dev/null
+++ b/doc/guides/compressdevs/zsda.rst
@@ -0,0 +1,171 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2024 ZTE Corporation.
+
+ZTE Storage Data Accelerator (ZSDA) Poll Mode Driver
+===
+
+The ZSDA compression PMD provides poll mode compression & decompression driver
+support for the following hardware accelerator devices:
+
+* ``ZTE Processing accelerators 1cf2``
+
+
+Features
+
+
+
+Installation
+
+
+The ZSDA compression PMD is built by default with a standard DPDK build.
+
+
+
+Building PMDs on ZSDA
+-
+
+A ZSDA device can host multiple acceleration services:
+
+* data compression
+
+These services are provided to DPDK applications via PMDs which register to
+implement the compressdev APIs. The PMDs use common ZSDA driver code
+which manages the ZSDA PCI device.
+
+
+Configuring and Building the DPDK ZSDA PMDs
+~~~
+
+Further information on configuring, building and installing DPDK is described
+:doc:`here <../linux_gsg/build_dpdk>`.
+
+
+Build Configuration
+~~~
+These is the build configuration options affecting ZSDA, and its default 
values:
+
+.. code-block:: console
+
+   RTE_PMD_ZSDA_MAX_PCI_DEVICES=256
+
+
+Device and driver naming
+
+
+* The zsda compressdev driver name is "compress_zsda".
+  The rte_compressdev_devices_get() returns the devices exposed by this driver.
+
+* Each zsda compression device has a unique name, in format
+  , e.g. ":cc:00.3_zsda".
+  This name can be passed to rte_compressdev_get_dev_id() to get the device_id.
+
+
+Enable VFs
+---
+
+Instructions for installation are below, but first an explanation of the
+relationships between the PF/VF devices and the PMDs visible to
+DPDK applications.
+
+Each ZSDA PF device exposes a number of VF devices. Each VF device can
+enable one compressdev PMD.
+
+These ZSDA PMDs share the same underlying device and pci-mgmt code, but are
+enumerated independently on their respective APIs and appear as independent
+devices to applications.
+
+.. Note::
+
+   Each VF can only be used by one DPDK process. It is not possible to share
+   the same VF across multiple processes, even if these processes are using
+   different acceleration services.
+   Conversely one DPDK process can use one or more ZSDA VFs and can expose
+   compressdev instances on each of those VFs.
+
+
+The examples below are based on the 1cf2 device, if you have a different device
+use the corresponding values in the above table.
+
+In BIOS ensure that SRIOV is enabled and either:
+
+* Disable VT-d or
+* Enable VT-d and set ``"intel_iommu=on iommu=pt"`` in the grub file.
+
+you need to ex

[PATCH v26 10/13] compress/zsda: add zsda compressdev qp ops

[Hanxiao Li]

Add zsda compressdev qp interface implementation.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/zsda_qp.c | 267 ++
 drivers/common/zsda/zsda_qp.h |  80 
 drivers/common/zsda/zsda_qp_common.c  |  52 +
 drivers/common/zsda/zsda_qp_common.h  |  42 
 drivers/compress/zsda/zsda_comp_pmd.c |  66 ++-
 5 files changed, 505 insertions(+), 2 deletions(-)

diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
index 1ad609675d..3c3226ec45 100644
--- a/drivers/common/zsda/zsda_qp.c
+++ b/drivers/common/zsda/zsda_qp.c
@@ -7,6 +7,8 @@
 #define MAGIC_SEND 0xab
 #define MAGIC_RECV 0xcd
 #define ADMIN_VER 1
+#define RING_DIR_TX 0
+#define RING_DIR_RX 1
 
 static uint8_t zsda_num_used_qps;
 
@@ -506,3 +508,268 @@ zsda_queue_init(struct zsda_pci_device *zsda_pci_dev)
 
return ret;
 }
+
+struct zsda_qp_hw *
+zsda_qps_hw_per_service(struct zsda_pci_device *zsda_pci_dev,
+   enum zsda_service_type type)
+{
+   struct zsda_qp_hw *qp_hw = NULL;
+
+   if (type < ZSDA_SERVICE_INVALID)
+   qp_hw = &(zsda_pci_dev->zsda_hw_qps[type]);
+
+   return qp_hw;
+}
+
+static const struct rte_memzone *
+zsda_queue_dma_zone_reserve(const char *queue_name,
+   const unsigned int queue_size,
+   const unsigned int socket_id)
+{
+   const struct rte_memzone *mz;
+
+   mz = rte_memzone_lookup(queue_name);
+   if (mz != 0) {
+   if (((size_t)queue_size <= mz->len) &&
+   ((socket_id == (SOCKET_ID_ANY & 0x)) ||
+(socket_id == (mz->socket_id & 0x {
+   ZSDA_LOG(DEBUG,
+"re-use memzone already allocated for %s",
+queue_name);
+   return mz;
+   }
+   ZSDA_LOG(ERR, "Failed! queue_name exist");
+   return NULL;
+   }
+
+   mz = rte_memzone_reserve_aligned(queue_name, queue_size,
+  (int)(socket_id & 0xfff),
+  RTE_MEMZONE_IOVA_CONTIG, queue_size);
+
+   return mz;
+}
+
+static int
+zsda_queue_create(const uint8_t dev_id, struct zsda_queue *queue,
+ const struct zsda_qp_config *qp_conf, const uint8_t dir)
+{
+   void *io_addr;
+   const struct rte_memzone *qp_mz;
+   struct qinfo qcfg = {0};
+
+   uint16_t desc_size = ((dir == RING_DIR_TX) ? qp_conf->hw->tx_msg_size
+  : qp_conf->hw->rx_msg_size);
+   unsigned int queue_size_bytes = qp_conf->nb_descriptors * desc_size;
+
+   queue->hw_queue_number =
+   ((dir == RING_DIR_TX) ? qp_conf->hw->tx_ring_num
+ : qp_conf->hw->rx_ring_num);
+
+   struct rte_pci_device *pci_dev = zsda_devs[dev_id].pci_dev;
+   struct zsda_pci_device *zsda_dev =
+   (struct zsda_pci_device *)zsda_devs[dev_id].mz->addr;
+
+   zsda_queue_cfg_by_id_get(zsda_dev, queue->hw_queue_number, &qcfg);
+
+   if (dir == RING_DIR_TX)
+   snprintf(queue->memz_name, sizeof(queue->memz_name),
+"%s_%d_%s_%s_%d", pci_dev->driver->driver.name, dev_id,
+qp_conf->service_str, "qptxmem",
+queue->hw_queue_number);
+   else
+   snprintf(queue->memz_name, sizeof(queue->memz_name),
+"%s_%d_%s_%s_%d", pci_dev->driver->driver.name, dev_id,
+qp_conf->service_str, "qprxmem",
+queue->hw_queue_number);
+
+   qp_mz = zsda_queue_dma_zone_reserve(queue->memz_name, queue_size_bytes,
+  rte_socket_id());
+   if (qp_mz == NULL) {
+   ZSDA_LOG(ERR, "Failed! qp_mz is NULL");
+   return -ENOMEM;
+   }
+
+   queue->base_addr = qp_mz->addr;
+   queue->base_phys_addr = qp_mz->iova;
+   queue->modulo_mask = MAX_NUM_OPS;
+   queue->msg_size = desc_size;
+
+   queue->head = (dir == RING_DIR_TX) ? qcfg.wq_head : qcfg.cq_head;
+   queue->tail = (dir == RING_DIR_TX) ? qcfg.wq_tail : qcfg.cq_tail;
+
+   if ((queue->head == 0) && (queue->tail == 0))
+   qcfg.cycle += 1;
+
+   queue->valid = qcfg.cycle & (ZSDA_MAX_CYCLE - 1);
+   queue->queue_size = ZSDA_MAX_DESC;
+   queue->cycle_size = ZSDA_MAX_CYCLE;
+   queue->io_addr = pci_dev->mem_resource[0].addr;
+
+   memset(queue->base_addr, 0x0, queue_size_bytes);
+   io_addr = pci_dev->mem_resource[0].addr;
+
+   if (dir == RING_DIR_TX)
+   ZSDA_CSR_WQ_RING_BASE(io_addr, queue->hw_queue_number,
+ queue->base_phys_addr);
+   else
+   ZSDA_CSR_CQ_RING_BASE(io_addr, queue->hw_queue_number,
+  

[PATCH v26 01/13] config: add zsda device number

[Hanxiao Li]

Add the number of zsda devices.

Signed-off-by: Hanxiao Li 
---
 config/rte_config.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/config/rte_config.h b/config/rte_config.h
index 3734db6bdc..86897de75e 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -119,6 +119,10 @@
 #define RTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS 16
 #define RTE_PMD_QAT_COMP_IM_BUFFER_SIZE 65536
 
+/* ZSDA device */
+/* Max. number of ZSDA devices which can be attached */
+#define RTE_PMD_ZSDA_MAX_PCI_DEVICES 256
+
 /* virtio crypto defines */
 #define RTE_MAX_VIRTIO_CRYPTO 32
 
-- 
2.27.0

[PATCH v26 02/13] common/zsda: add zsdadev driver

[Hanxiao Li]

Add basic zsdadev init and register PCI probe functions

Signed-off-by: Hanxiao Li 
---
 MAINTAINERS  |   3 +
 drivers/common/zsda/meson.build  |  13 ++
 drivers/common/zsda/zsda_device.c| 187 +++
 drivers/common/zsda/zsda_device.h|  54 
 drivers/common/zsda/zsda_qp_common.h |  28 
 drivers/meson.build  |   1 +
 6 files changed, 286 insertions(+)
 create mode 100644 drivers/common/zsda/meson.build
 create mode 100644 drivers/common/zsda/zsda_device.c
 create mode 100644 drivers/common/zsda/zsda_device.h
 create mode 100644 drivers/common/zsda/zsda_qp_common.h

diff --git a/MAINTAINERS b/MAINTAINERS
index b86cdd266b..86864bc5f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1312,6 +1312,9 @@ F: drivers/compress/zlib/
 F: doc/guides/compressdevs/zlib.rst
 F: doc/guides/compressdevs/features/zlib.ini
 
+ZTE Storage Data Accelerator(ZSDA)
+M: Hanxiao Li 
+F: drivers/common/zsda/
 
 DMAdev Drivers
 --
diff --git a/drivers/common/zsda/meson.build b/drivers/common/zsda/meson.build
new file mode 100644
index 00..68bc549c27
--- /dev/null
+++ b/drivers/common/zsda/meson.build
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 ZTE Corporation
+
+if is_windows
+build = false
+reason = 'not supported on Windows'
+subdir_done()
+endif
+
+deps += ['bus_pci', 'mbuf']
+sources += files(
+   'zsda_device.c',
+   )
diff --git a/drivers/common/zsda/zsda_device.c 
b/drivers/common/zsda/zsda_device.c
new file mode 100644
index 00..a7a3ff5440
--- /dev/null
+++ b/drivers/common/zsda/zsda_device.c
@@ -0,0 +1,187 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include "zsda_device.h"
+
+/* per-process array of device data */
+struct zsda_device_info zsda_devs[RTE_PMD_ZSDA_MAX_PCI_DEVICES];
+static int zsda_nb_pci_devices;
+
+/*
+ * The set of PCI devices this driver supports
+ */
+static const struct rte_pci_id pci_id_zsda_map[] = {
+   {
+   RTE_PCI_DEVICE(0x1cf2, 0x8050),
+   },
+   {
+   RTE_PCI_DEVICE(0x1cf2, 0x8051),
+   },
+   {.device_id = 0},
+};
+
+static struct zsda_pci_device *
+zsda_pci_dev_by_name_get(const char *name)
+{
+   unsigned int i;
+
+   if (name == NULL)
+   return NULL;
+
+   for (i = 0; i < RTE_PMD_ZSDA_MAX_PCI_DEVICES; i++) {
+   if (zsda_devs[i].mz &&
+   (strcmp(((struct zsda_pci_device *)zsda_devs[i].mz->addr)
+   ->name,
+   name) == 0))
+   return (struct zsda_pci_device *)zsda_devs[i].mz->addr;
+   }
+
+   return NULL;
+}
+
+static uint8_t
+zsda_pci_dev_free_id_get(void)
+{
+   uint32_t dev_id;
+
+   for (dev_id = 0; dev_id < RTE_PMD_ZSDA_MAX_PCI_DEVICES; dev_id++)
+   if (zsda_devs[dev_id].mz == NULL)
+   break;
+
+   return dev_id & (ZSDA_MAX_DEV - 1);
+}
+
+static struct zsda_pci_device *
+zsda_pci_dev_get(const struct rte_pci_device *pci_dev)
+{
+   char name[ZSDA_DEV_NAME_MAX_LEN];
+
+   rte_pci_device_name(&pci_dev->addr, name, sizeof(name));
+
+   return zsda_pci_dev_by_name_get(name);
+}
+
+static struct zsda_pci_device *
+zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
+{
+   struct zsda_pci_device *zsda_pci_dev;
+   uint8_t zsda_dev_id;
+   char name[ZSDA_DEV_NAME_MAX_LEN];
+   unsigned int socket_id = rte_socket_id();
+
+   rte_pci_device_name(&pci_dev->addr, name, sizeof(name));
+   snprintf(name + strlen(name), (ZSDA_DEV_NAME_MAX_LEN - strlen(name)),
+"_zsda");
+   if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+   const struct rte_memzone *mz = rte_memzone_lookup(name);
+
+   if (mz == NULL)
+   return NULL;
+   zsda_pci_dev = mz->addr;
+   zsda_devs[zsda_pci_dev->zsda_dev_id].mz = mz;
+   zsda_devs[zsda_pci_dev->zsda_dev_id].pci_dev = pci_dev;
+   zsda_nb_pci_devices++;
+   return zsda_pci_dev;
+   }
+
+   if (zsda_pci_dev_by_name_get(name) != NULL)
+   return NULL;
+
+   zsda_dev_id = zsda_pci_dev_free_id_get();
+
+   if (zsda_dev_id == (RTE_PMD_ZSDA_MAX_PCI_DEVICES - 1))
+   return NULL;
+
+   zsda_devs[zsda_dev_id].mz =
+   rte_memzone_reserve(name, sizeof(struct zsda_pci_device),
+   (int)(socket_id & 0xfff), 0);
+
+   if (zsda_devs[zsda_dev_id].mz == NULL)
+   return NULL;
+
+   zsda_pci_dev = zsda_devs[zsda_dev_id].mz->addr;
+   memset(zsda_pci_dev, 0, sizeof(*zsda_pci_dev));
+   memcpy(zsda_pci_dev->name, name, ZSDA_DEV_NAME_MAX_LEN);
+   zsda_pci_dev->zsda_dev_id = zsda_dev_id;
+   zsda_pci_dev->pci_dev = pci_dev;
+   zsda_devs[zsda_dev_id].

[PATCH v26 13/13] compress/zsda: add zsda compressdev capabilities

[Hanxiao Li]

Add zsda compressdev capabilities

Signed-off-by: Hanxiao Li 
---
 doc/guides/compressdevs/features/zsda.ini |  9 ++
 doc/guides/compressdevs/zsda.rst  | 23 ++
 doc/guides/rel_notes/release_25_03.rst|  7 +
 drivers/compress/zsda/zsda_comp_pmd.c | 37 +++
 4 files changed, 76 insertions(+)

diff --git a/doc/guides/compressdevs/features/zsda.ini 
b/doc/guides/compressdevs/features/zsda.ini
index 5cc9a3b1a6..3b087ea7f9 100644
--- a/doc/guides/compressdevs/features/zsda.ini
+++ b/doc/guides/compressdevs/features/zsda.ini
@@ -4,3 +4,12 @@
 ; Supported features of 'ZSDA' compression driver.
 ;
 [Features]
+HW Accelerated = Y
+OOP SGL In SGL Out = Y
+OOP SGL In LB  Out = Y
+OOP LB  In SGL Out = Y
+Deflate= Y
+Adler32= Y
+Crc32  = Y
+Fixed  = Y
+Dynamic= Y
diff --git a/doc/guides/compressdevs/zsda.rst b/doc/guides/compressdevs/zsda.rst
index da7117b45e..77de026a16 100644
--- a/doc/guides/compressdevs/zsda.rst
+++ b/doc/guides/compressdevs/zsda.rst
@@ -13,6 +13,29 @@ support for the following hardware accelerator devices:
 Features
 
 
+ZSDA compression PMD has support for:
+
+Compression/Decompression algorithm:
+
+* DEFLATE - using Fixed and Dynamic Huffman encoding
+
+Checksum generation:
+
+* CRC32, Adler32
+
+Huffman code type:
+
+* FIXED
+* DYNAMIC
+
+
+Limitations
+---
+
+* Compressdev level 0, no compression, is not supported.
+* No BSD support as BSD ZSDA kernel driver not available.
+* Stateful is not supported.
+
 
 Installation
 
diff --git a/doc/guides/rel_notes/release_25_03.rst 
b/doc/guides/rel_notes/release_25_03.rst
index 85986ffa61..59d9ea19d9 100644
--- a/doc/guides/rel_notes/release_25_03.rst
+++ b/doc/guides/rel_notes/release_25_03.rst
@@ -24,6 +24,13 @@ DPDK Release 25.03
 New Features
 
 
+* **Added ZTE Storage Data Accelerator(ZSDA) device driver.**
+
+  Added a new compress driver for ZSDA devices to support
+  the deflate compression and decompression algorithm.
+
+  See the :doc:`../compressdevs/zsda` guide for more details on the new driver.
+
 .. This section should contain new features added in this release.
Sample format:
 
diff --git a/drivers/compress/zsda/zsda_comp_pmd.c 
b/drivers/compress/zsda/zsda_comp_pmd.c
index 13dda1d515..e4d0600c0b 100644
--- a/drivers/compress/zsda/zsda_comp_pmd.c
+++ b/drivers/compress/zsda/zsda_comp_pmd.c
@@ -10,6 +10,20 @@
 #include "zsda_comp_pmd.h"
 #include "zsda_comp.h"
 
+static const struct rte_compressdev_capabilities zsda_comp_capabilities[] = {
+   {
+   .algo = RTE_COMP_ALGO_DEFLATE,
+   .comp_feature_flags = RTE_COMP_FF_HUFFMAN_DYNAMIC |
+   
RTE_COMP_FF_OOP_SGL_IN_SGL_OUT |
+   
RTE_COMP_FF_OOP_SGL_IN_LB_OUT |
+   
RTE_COMP_FF_OOP_LB_IN_SGL_OUT |
+   
RTE_COMP_FF_CRC32_CHECKSUM |
+   
RTE_COMP_FF_ADLER32_CHECKSUM |
+   
RTE_COMP_FF_SHAREABLE_PRIV_XFORM,
+   .window_size = {.min = 15, .max = 15, .increment = 0},
+   },
+};
+
 static int
 zsda_comp_xform_size(void)
 {
@@ -321,8 +335,11 @@ zsda_comp_dev_create(struct zsda_pci_device *zsda_pci_dev)
};
 
char name[RTE_COMPRESSDEV_NAME_MAX_LEN];
+   char capa_memz_name[RTE_COMPRESSDEV_NAME_MAX_LEN];
struct rte_compressdev *compressdev;
struct zsda_comp_dev_private *comp_dev;
+   const struct rte_compressdev_capabilities *capabilities;
+   uint16_t capa_size = sizeof(struct rte_compressdev_capabilities);
 
snprintf(name, RTE_COMPRESSDEV_NAME_MAX_LEN, "%s_%s",
 zsda_pci_dev->name, "comp");
@@ -352,6 +369,26 @@ zsda_comp_dev_create(struct zsda_pci_device *zsda_pci_dev)
comp_dev->zsda_pci_dev = zsda_pci_dev;
comp_dev->compressdev = compressdev;
 
+   capabilities = zsda_comp_capabilities;
+
+   snprintf(capa_memz_name, RTE_COMPRESSDEV_NAME_MAX_LEN,
+"ZSDA_COMP_CAPA");
+   comp_dev->capa_mz = rte_memzone_lookup(capa_memz_name);
+   if (comp_dev->capa_mz == NULL)
+   comp_dev->capa_mz = rte_memzone_reserve(
+   capa_memz_name, capa_size, rte_socket_id(), 0);
+
+   if (comp_dev->capa_mz == NULL) {
+   ZSDA_LOG(DEBUG, "Failed! comp_dev->capa_mz is NULL");
+   memset(&dev_info->comp_rte_dev, 0,
+  sizeof(dev_info->comp_rte_dev));
+   rte_compressdev_pmd_destroy(compressdev);
+   return -EFAULT;
+   }
+
+   memcpy(comp_dev->capa_mz->addr, capabilities, capa_size);
+   comp_dev->zsda_dev_capabilities = comp_dev->capa_mz

[PATCH v26 03/13] common/zsda: add logging macros

[Hanxiao Li]

Add zxdh logging implementation.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/meson.build  |  1 +
 drivers/common/zsda/zsda_device.c| 22 +++---
 drivers/common/zsda/zsda_logs.c  | 19 +++
 drivers/common/zsda/zsda_logs.h  | 27 +++
 drivers/common/zsda/zsda_qp_common.h |  1 +
 5 files changed, 63 insertions(+), 7 deletions(-)
 create mode 100644 drivers/common/zsda/zsda_logs.c
 create mode 100644 drivers/common/zsda/zsda_logs.h

diff --git a/drivers/common/zsda/meson.build b/drivers/common/zsda/meson.build
index 68bc549c27..342d000c6d 100644
--- a/drivers/common/zsda/meson.build
+++ b/drivers/common/zsda/meson.build
@@ -10,4 +10,5 @@ endif
 deps += ['bus_pci', 'mbuf']
 sources += files(
'zsda_device.c',
+   'zsda_logs.c',
)
diff --git a/drivers/common/zsda/zsda_device.c 
b/drivers/common/zsda/zsda_device.c
index a7a3ff5440..18ca372f60 100644
--- a/drivers/common/zsda/zsda_device.c
+++ b/drivers/common/zsda/zsda_device.c
@@ -26,9 +26,10 @@ zsda_pci_dev_by_name_get(const char *name)
 {
unsigned int i;
 
-   if (name == NULL)
+   if (name == NULL) {
+   ZSDA_LOG(ERR, "Failed! name is NULL.");
return NULL;
-
+   }
for (i = 0; i < RTE_PMD_ZSDA_MAX_PCI_DEVICES; i++) {
if (zsda_devs[i].mz &&
(strcmp(((struct zsda_pci_device *)zsda_devs[i].mz->addr)
@@ -76,8 +77,10 @@ zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
const struct rte_memzone *mz = rte_memzone_lookup(name);
 
-   if (mz == NULL)
+   if (mz == NULL) {
+   ZSDA_LOG(ERR, "Secondary can't find %s mz", name);
return NULL;
+   }
zsda_pci_dev = mz->addr;
zsda_devs[zsda_pci_dev->zsda_dev_id].mz = mz;
zsda_devs[zsda_pci_dev->zsda_dev_id].pci_dev = pci_dev;
@@ -85,8 +88,10 @@ zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
return zsda_pci_dev;
}
 
-   if (zsda_pci_dev_by_name_get(name) != NULL)
+   if (zsda_pci_dev_by_name_get(name) != NULL) {
+   ZSDA_LOG(ERR, "Failed! config");
return NULL;
+   }
 
zsda_dev_id = zsda_pci_dev_free_id_get();
 
@@ -97,9 +102,10 @@ zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
rte_memzone_reserve(name, sizeof(struct zsda_pci_device),
(int)(socket_id & 0xfff), 0);
 
-   if (zsda_devs[zsda_dev_id].mz == NULL)
+   if (zsda_devs[zsda_dev_id].mz == NULL) {
+   ZSDA_LOG(ERR, "Failed! malloc");
return NULL;
-
+   }
zsda_pci_dev = zsda_devs[zsda_dev_id].mz->addr;
memset(zsda_pci_dev, 0, sizeof(*zsda_pci_dev));
memcpy(zsda_pci_dev->name, name, ZSDA_DEV_NAME_MAX_LEN);
@@ -154,8 +160,10 @@ zsda_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct zsda_pci_device *zsda_pci_dev;
 
zsda_pci_dev = zsda_pci_device_allocate(pci_dev);
-   if (zsda_pci_dev == NULL)
+   if (zsda_pci_dev == NULL) {
+   ZSDA_LOG(ERR, "Failed! zsda_pci_dev is NULL");
return -ENODEV;
+   }
 
return ret;
 }
diff --git a/drivers/common/zsda/zsda_logs.c b/drivers/common/zsda/zsda_logs.c
new file mode 100644
index 00..f76d9d9d0d
--- /dev/null
+++ b/drivers/common/zsda/zsda_logs.c
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include 
+
+#include "zsda_logs.h"
+
+int
+zsda_hexdump_log(uint32_t level, uint32_t logtype, const char *title,
+   const void *buf, unsigned int len)
+{
+   if (rte_log_can_log(logtype, level))
+   rte_hexdump(rte_log_get_stream(), title, buf, len);
+
+   return 0;
+}
+
+RTE_LOG_REGISTER_SUFFIX(zsda_logtype_gen, gen, NOTICE);
diff --git a/drivers/common/zsda/zsda_logs.h b/drivers/common/zsda/zsda_logs.h
new file mode 100644
index 00..9d77254773
--- /dev/null
+++ b/drivers/common/zsda/zsda_logs.h
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#ifndef _ZSDA_LOGS_H_
+#define _ZSDA_LOGS_H_
+
+#include 
+
+extern int zsda_logtype_gen;
+#define RTE_LOGTYPE_ZSDA_GEN zsda_logtype_gen
+
+#define ZSDA_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZSDA_GEN, "%s(): ", \
+   __func__, __VA_ARGS__)
+
+/**
+ * zsda_hexdump_log - Dump out memory in a special hex dump format.
+ *
+ * Dump out the message buffer in a special hex dump output format with
+ * characters printed for each line of 16 hex values. The message will be sent
+ * to the stream used by the rte_log infrastructure.
+ */
+int zsda_hexdump_log(uint32_t level, uint32_t logtype, const char *title,
+ 

[PATCH v26 08/13] compress/zsda: add zsda compressdev stats ops

[Hanxiao Li]

Add zsda compressdev stats interface implementation.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/meson.build   |  1 +
 drivers/common/zsda/zsda_qp_common.c  | 68 +++
 drivers/common/zsda/zsda_qp_common.h  | 17 +++
 drivers/compress/zsda/zsda_comp_pmd.c | 24 +-
 4 files changed, 108 insertions(+), 2 deletions(-)
 create mode 100644 drivers/common/zsda/zsda_qp_common.c

diff --git a/drivers/common/zsda/meson.build b/drivers/common/zsda/meson.build
index 6ee2a68f4b..6e6d5ab006 100644
--- a/drivers/common/zsda/meson.build
+++ b/drivers/common/zsda/meson.build
@@ -12,6 +12,7 @@ sources += files(
'zsda_device.c',
'zsda_logs.c',
'zsda_qp.c',
+   'zsda_qp_common.c',
)
 
 zsda_compress = true
diff --git a/drivers/common/zsda/zsda_qp_common.c 
b/drivers/common/zsda/zsda_qp_common.c
new file mode 100644
index 00..9e61f96132
--- /dev/null
+++ b/drivers/common/zsda/zsda_qp_common.c
@@ -0,0 +1,68 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include "zsda_qp_common.h"
+
+void
+zsda_stats_get(void **queue_pairs, const uint32_t nb_queue_pairs,
+ struct zsda_qp_stat *stats)
+{
+   enum zsda_service_type type;
+   uint32_t i;
+   struct zsda_qp *qp;
+
+   if ((stats == NULL) || (queue_pairs == NULL)) {
+   ZSDA_LOG(ERR, "Failed! stats or queue_pairs is NULL");
+   return;
+   }
+
+   for (i = 0; i < nb_queue_pairs; i++) {
+   qp = queue_pairs[i];
+
+   if (qp == NULL) {
+   ZSDA_LOG(ERR, "Failed! queue_pairs[i] is NULL");
+   break;
+   }
+
+   for (type = 0; type < ZSDA_SERVICE_INVALID; type++) {
+   if (qp->srv[type].used) {
+   stats->enqueued_count +=
+   qp->srv[type].stats.enqueued_count;
+   stats->dequeued_count +=
+   qp->srv[type].stats.dequeued_count;
+   stats->enqueue_err_count +=
+   qp->srv[type].stats.enqueue_err_count;
+   stats->dequeue_err_count +=
+   qp->srv[type].stats.dequeue_err_count;
+   }
+   }
+   }
+}
+
+void
+zsda_stats_reset(void **queue_pairs, const uint32_t nb_queue_pairs)
+{
+   enum zsda_service_type type;
+   uint32_t i;
+   struct zsda_qp *qp;
+
+   if (queue_pairs == NULL) {
+   ZSDA_LOG(ERR, "Failed! queue_pairs is NULL");
+   return;
+   }
+
+   for (i = 0; i < nb_queue_pairs; i++) {
+   qp = queue_pairs[i];
+
+   if (qp == NULL) {
+   ZSDA_LOG(ERR, "Failed! queue_pairs[i] is NULL");
+   break;
+   }
+   for (type = 0; type < ZSDA_MAX_SERVICES; type++) {
+   if (qp->srv[type].used)
+   memset(&(qp->srv[type].stats), 0,
+  sizeof(struct zsda_qp_stat));
+   }
+   }
+}
diff --git a/drivers/common/zsda/zsda_qp_common.h 
b/drivers/common/zsda/zsda_qp_common.h
index 550411dbc4..3108827764 100644
--- a/drivers/common/zsda/zsda_qp_common.h
+++ b/drivers/common/zsda/zsda_qp_common.h
@@ -80,10 +80,23 @@ struct zsda_queue {
uint16_t sid;
 };
 
+struct zsda_qp_stat {
+   /**< Count of all operations enqueued */
+   uint64_t enqueued_count;
+   /**< Count of all operations dequeued */
+   uint64_t dequeued_count;
+
+   /**< Total error count on operations enqueued */
+   uint64_t enqueue_err_count;
+   /**< Total error count on operations dequeued */
+   uint64_t dequeue_err_count;
+};
+
 struct qp_srv {
bool used;
struct zsda_queue tx_q;
struct zsda_queue rx_q;
+   struct zsda_qp_stat stats;
struct rte_mempool *op_cookie_pool;
void **op_cookies;
uint16_t nb_descriptors;
@@ -93,4 +106,8 @@ struct zsda_qp {
struct qp_srv srv[ZSDA_MAX_SERVICES];
 };
 
+void zsda_stats_get(void **queue_pairs, const uint32_t nb_queue_pairs,
+   struct zsda_qp_stat *stats);
+void zsda_stats_reset(void **queue_pairs, const uint32_t nb_queue_pairs);
+
 #endif /* _ZSDA_QP_COMMON_H_ */
diff --git a/drivers/compress/zsda/zsda_comp_pmd.c 
b/drivers/compress/zsda/zsda_comp_pmd.c
index 07c03a8d13..f1d20e245e 100644
--- a/drivers/compress/zsda/zsda_comp_pmd.c
+++ b/drivers/compress/zsda/zsda_comp_pmd.c
@@ -129,6 +129,26 @@ zsda_comp_dev_info_get(struct rte_compressdev *dev,
}
 }
 
+static void
+zsda_comp_stats_get(struct rte_compressdev *dev,
+   struct rte_compressdev_stats *stats)
+{
+   struct zsda_qp_stat stats_info = {0

[PATCH v26 05/13] common/zsda: add definition and use of msg chan.

[Hanxiao Li]

Add msg chan functions and the use to get
hardware information or operate hardware.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/zsda_qp.c| 297 +++
 drivers/common/zsda/zsda_qp.h|  48 +
 drivers/common/zsda/zsda_qp_common.h |  26 +++
 3 files changed, 371 insertions(+)

diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
index 7feafe4023..c2a5667a77 100644
--- a/drivers/common/zsda/zsda_qp.c
+++ b/drivers/common/zsda/zsda_qp.c
@@ -4,8 +4,50 @@
 
 #include "zsda_qp.h"
 
+#define MAGIC_SEND 0xab
+#define MAGIC_RECV 0xcd
+#define ADMIN_VER 1
+
 static uint8_t zsda_num_used_qps;
 
+static struct ring_size zsda_qp_hw_ring_size[ZSDA_MAX_SERVICES] = {
+};
+
+static const uint8_t crc8_table[256] = {
+   0x00, 0x41, 0x13, 0x52, 0x26, 0x67, 0x35, 0x74, 0x4c, 0x0d, 0x5f, 0x1e,
+   0x6a, 0x2b, 0x79, 0x38, 0x09, 0x48, 0x1a, 0x5b, 0x2f, 0x6e, 0x3c, 0x7d,
+   0x45, 0x04, 0x56, 0x17, 0x63, 0x22, 0x70, 0x31, 0x12, 0x53, 0x01, 0x40,
+   0x34, 0x75, 0x27, 0x66, 0x5e, 0x1f, 0x4d, 0x0c, 0x78, 0x39, 0x6b, 0x2a,
+   0x1b, 0x5a, 0x08, 0x49, 0x3d, 0x7c, 0x2e, 0x6f, 0x57, 0x16, 0x44, 0x05,
+   0x71, 0x30, 0x62, 0x23, 0x24, 0x65, 0x37, 0x76, 0x02, 0x43, 0x11, 0x50,
+   0x68, 0x29, 0x7b, 0x3a, 0x4e, 0x0f, 0x5d, 0x1c, 0x2d, 0x6c, 0x3e, 0x7f,
+   0x0b, 0x4a, 0x18, 0x59, 0x61, 0x20, 0x72, 0x33, 0x47, 0x06, 0x54, 0x15,
+   0x36, 0x77, 0x25, 0x64, 0x10, 0x51, 0x03, 0x42, 0x7a, 0x3b, 0x69, 0x28,
+   0x5c, 0x1d, 0x4f, 0x0e, 0x3f, 0x7e, 0x2c, 0x6d, 0x19, 0x58, 0x0a, 0x4b,
+   0x73, 0x32, 0x60, 0x21, 0x55, 0x14, 0x46, 0x07, 0x48, 0x09, 0x5b, 0x1a,
+   0x6e, 0x2f, 0x7d, 0x3c, 0x04, 0x45, 0x17, 0x56, 0x22, 0x63, 0x31, 0x70,
+   0x41, 0x00, 0x52, 0x13, 0x67, 0x26, 0x74, 0x35, 0x0d, 0x4c, 0x1e, 0x5f,
+   0x2b, 0x6a, 0x38, 0x79, 0x5a, 0x1b, 0x49, 0x08, 0x7c, 0x3d, 0x6f, 0x2e,
+   0x16, 0x57, 0x05, 0x44, 0x30, 0x71, 0x23, 0x62, 0x53, 0x12, 0x40, 0x01,
+   0x75, 0x34, 0x66, 0x27, 0x1f, 0x5e, 0x0c, 0x4d, 0x39, 0x78, 0x2a, 0x6b,
+   0x6c, 0x2d, 0x7f, 0x3e, 0x4a, 0x0b, 0x59, 0x18, 0x20, 0x61, 0x33, 0x72,
+   0x06, 0x47, 0x15, 0x54, 0x65, 0x24, 0x76, 0x37, 0x43, 0x02, 0x50, 0x11,
+   0x29, 0x68, 0x3a, 0x7b, 0x0f, 0x4e, 0x1c, 0x5d, 0x7e, 0x3f, 0x6d, 0x2c,
+   0x58, 0x19, 0x4b, 0x0a, 0x32, 0x73, 0x21, 0x60, 0x14, 0x55, 0x07, 0x46,
+   0x77, 0x36, 0x64, 0x25, 0x51, 0x10, 0x42, 0x03, 0x3b, 0x7a, 0x28, 0x69,
+   0x1d, 0x5c, 0x0e, 0x4f};
+
+static uint8_t
+zsda_crc8(const uint8_t *message, const int length)
+{
+   uint8_t crc = 0;
+   int i;
+
+   for (i = 0; i < length; i++)
+   crc = crc8_table[crc ^ message[i]];
+   return crc;
+}
+
 static uint8_t
 zsda_used_qps_num_get(const struct rte_pci_device *pci_dev)
 {
@@ -113,6 +155,248 @@ zsda_queue_clear(const struct rte_pci_device *pci_dev)
return ret;
 }
 
+static uint32_t
+zsda_reg_8_set(void *addr, const uint8_t val0, const uint8_t val1,
+ const uint8_t val2, const uint8_t val3)
+{
+   uint8_t val[4];
+
+   val[0] = val0;
+   val[1] = val1;
+   val[2] = val2;
+   val[3] = val3;
+   ZSDA_CSR_WRITE32(addr, *(uint32_t *)val);
+   return *(uint32_t *)val;
+}
+
+static uint8_t
+zsda_reg_8_get(void *addr, const int offset)
+{
+   uint32_t val = ZSDA_CSR_READ32(addr);
+
+   return *(((uint8_t *)&val) + offset);
+}
+
+static inline uint32_t
+zsda_modulo_32(uint32_t data, uint32_t modulo_mask)
+{
+   return (data) & (modulo_mask);
+}
+
+static int
+zsda_admin_msg_send(const struct rte_pci_device *pci_dev, void *req,
+   const uint32_t len)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   uint8_t wq_flag;
+   uint8_t crc;
+   uint16_t admin_db;
+   uint32_t retry = ZSDA_TIME_NUM;
+   int i;
+   uint16_t db;
+   int repeat = sizeof(struct zsda_admin_req) / sizeof(uint32_t);
+
+   if (len > ADMIN_BUF_DATA_LEN)
+   return -EINVAL;
+
+   for (i = 0; i < repeat; i++) {
+   ZSDA_CSR_WRITE32(((uint32_t *)(mmio_base + ZSDA_ADMIN_WQ) + i),
+*((uint32_t *)req + i));
+   }
+
+   crc = zsda_crc8((uint8_t *)req, ADMIN_BUF_DATA_LEN);
+   zsda_reg_8_set(mmio_base + ZSDA_ADMIN_WQ_BASE7, crc, ADMIN_VER, 
MAGIC_SEND, 0);
+   rte_delay_us_sleep(ZSDA_TIME_SLEEP_US);
+   rte_wmb();
+
+   admin_db = ZSDA_CSR_READ32(mmio_base + ZSDA_ADMIN_WQ_TAIL);
+   db = zsda_modulo_32(admin_db, 0x1ff);
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_WQ_TAIL, db);
+
+   do {
+   rte_delay_us_sleep(ZSDA_TIME_SLEEP_US);
+   wq_flag = zsda_reg_8_get(mmio_base + ZSDA_ADMIN_WQ_BASE7, 2);
+   if (wq_flag == MAGIC_RECV)
+   break;
+
+   retry--;
+   if (!retry) {
+   ZSDA_LOG(ERR, "wq_flag 0x%X", wq_flag);
+   zsda_reg_8_set(mmio_base + ZSDA_ADM

[PATCH v26 00/13] drivers/zsda: introduce zsda drivers

[Hanxiao Li]

v26:
- try to ensure all patches gets compiled incrementally.

v25:
- replace the ``__rte_packed`` macro.
- fix an extra line at end of file in patch 11.

v24:
- Try to resolve the issue in v23 by sending all patches at once

v23:
- modify funcitons name to move the verb to the end
- move the qp_setup and qp_release calls in same patch
- make the queue setup APIs common with one function.
- Fix some code in original patch.

v22:
- modify misspelled errors.

v21:
- modify some errors.

v20
- add release note which was forgot in last version

v19:
- delete cryptodev drivers and prepare to submit it next time.
- only submit compressdev driver this time.
- resplit the patches.

v18:
- add code in drivers/meson.build to compile zsda drivers.
- make every patch compile without any warnings or errors.

v17:
- fix some spelling errors

v16:
- resplit patches.
- complete documentation which is yet there in that patch.
- every patch should compile without any warnings or errors.
- delete unused comments.

v15:
- split to more patches.

v14:
- Uniform Byte Alignment.

v13:
- resolve some comiler warnings that are being suppressed.

v12:
- use RTE_LOG_LINE_PREFIX in logging macro.
- delete the check for null with rte_mempool_free.
- delete some unused initial values.

v11:
- use RTE_LOG_LINE in logging macro.
- fix some known bugs.

v10:
- delete new blank line at EOF
- Cleaning up some code in zsda_log.h

v9:
- add a new feature  in default.ini.
- Re-split the patch according to the new PMD guidelines
https://patches.dpdk.org/project/dpdk/patch/20241006184
254.53499-1-nandinipersad...@gmail.com/
- Split SM4-XTS tests into a new series to releases.
- Separate out datapath(enqueue/dequeue) as a separate patch.

v8:
- fix some errors in cryptodevs/features/zsda.ini.

v7: 
- add release notes and some documentations.
- add MAINTAINERS context in the patch where the file/folder is added.
- add files in meason.build which are included in the patch only.
- add a check for unsupported on Windows.
- notice the implicit cast in C.
- add cover letter.
- compile each of the patches individually.


Hanxiao Li (13):
  config: add zsda device number
  common/zsda: add zsdadev driver
  common/zsda: add logging macros
  common/zsda: add functions to operate hardware queue
  common/zsda: add definition and use of msg chan.
  compress/zsda: add zsda compressdev driver skeleton
  compress/zsda: add zsda compressdev dev ops
  compress/zsda: add zsda compressdev stats ops
  compress/zsda: add zsda compressdev xform ops
  compress/zsda: add zsda compressdev qp ops
  compress/zsda: add zsda compressdev enqueue datapath
  compress/zsda: add zsda compressdev dequeue datapath
  compress/zsda: add zsda compressdev capabilities

 MAINTAINERS   |   6 +
 config/rte_config.h   |   4 +
 doc/guides/compressdevs/features/zsda.ini |  15 +
 doc/guides/compressdevs/index.rst |   1 +
 doc/guides/compressdevs/zsda.rst  | 194 +
 doc/guides/rel_notes/release_25_03.rst|   7 +
 drivers/common/zsda/meson.build   |  26 +
 drivers/common/zsda/zsda_device.c | 209 +
 drivers/common/zsda/zsda_device.h |  59 ++
 drivers/common/zsda/zsda_logs.c   |  19 +
 drivers/common/zsda/zsda_logs.h   |  27 +
 drivers/common/zsda/zsda_qp.c | 946 ++
 drivers/common/zsda/zsda_qp.h | 186 +
 drivers/common/zsda/zsda_qp_common.c  | 192 +
 drivers/common/zsda/zsda_qp_common.h  | 189 +
 drivers/compress/zsda/zsda_comp.c | 388 +
 drivers/compress/zsda/zsda_comp.h |  45 +
 drivers/compress/zsda/zsda_comp_pmd.c | 418 ++
 drivers/compress/zsda/zsda_comp_pmd.h |  41 +
 drivers/meson.build   |   1 +
 20 files changed, 2973 insertions(+)
 create mode 100644 doc/guides/compressdevs/features/zsda.ini
 create mode 100644 doc/guides/compressdevs/zsda.rst
 create mode 100644 drivers/common/zsda/meson.build
 create mode 100644 drivers/common/zsda/zsda_device.c
 create mode 100644 drivers/common/zsda/zsda_device.h
 create mode 100644 drivers/common/zsda/zsda_logs.c
 create mode 100644 drivers/common/zsda/zsda_logs.h
 create mode 100644 drivers/common/zsda/zsda_qp.c
 create mode 100644 drivers/common/zsda/zsda_qp.h
 create mode 100644 drivers/common/zsda/zsda_qp_common.c
 create mode 100644 drivers/common/zsda/zsda_qp_common.h
 create mode 100644 drivers/compress/zsda/zsda_comp.c
 create mode 100644 drivers/compress/zsda/zsda_comp.h
 create mode 100644 drivers/compress/zsda/zsda_comp_pmd.c
 create mode 100644 drivers/compress/zsda/zsda_comp_pmd.h

-- 
2.27.0

[PATCH v26 12/13] compress/zsda: add zsda compressdev dequeue datapath

[Hanxiao Li]

Add zsda compressdev dequeue datapath.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/zsda_qp.c |  56 ++
 drivers/common/zsda/zsda_qp.h |   1 +
 drivers/common/zsda/zsda_qp_common.h  |   4 +
 drivers/compress/zsda/zsda_comp.c | 155 ++
 drivers/compress/zsda/zsda_comp.h |   9 ++
 drivers/compress/zsda/zsda_comp_pmd.c |  11 +-
 6 files changed, 235 insertions(+), 1 deletion(-)

diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
index c85b9ddb75..0ef7cac585 100644
--- a/drivers/common/zsda/zsda_qp.c
+++ b/drivers/common/zsda/zsda_qp.c
@@ -888,3 +888,59 @@ zsda_enqueue_burst(struct zsda_qp *qp, void **ops, const 
uint16_t nb_ops)
 
return nb_send;
 }
+
+static void
+zsda_dequeue(struct qp_srv *srv, void **ops, const uint16_t nb_ops, uint16_t 
*nb)
+{
+   uint16_t head;
+   struct zsda_cqe *cqe;
+   struct zsda_queue *queue = &srv->rx_q;
+   struct zsda_op_cookie *cookie;
+   head = queue->head;
+
+   while (*nb < nb_ops) {
+   cqe = (struct zsda_cqe *)(
+   (uint8_t *)queue->base_addr + head * queue->msg_size);
+
+   if (!CQE_VALID(cqe->err1))
+   break;
+   cookie = srv->op_cookies[cqe->sid];
+
+   ops[*nb] = cookie->op;
+   if (srv->rx_cb(cookie, cqe) == ZSDA_SUCCESS)
+   srv->stats.dequeued_count++;
+   else {
+   ZSDA_LOG(ERR,
+"ERR! Cqe, opcode 0x%x, sid 0x%x, "
+"tx_real_length 0x%x, err0 0x%x, err1 0x%x",
+cqe->op_code, cqe->sid, cqe->tx_real_length,
+cqe->err0, cqe->err1);
+   srv->stats.dequeue_err_count++;
+   }
+   (*nb)++;
+   cookie->used = false;
+
+   head = zsda_modulo_16(head + 1, queue->modulo_mask);
+   queue->head = head;
+   WRITE_CSR_CQ_HEAD(queue->io_addr, queue->hw_queue_number, head);
+   memset(cqe, 0x0, sizeof(struct zsda_cqe));
+   }
+}
+
+uint16_t
+zsda_dequeue_burst(struct zsda_qp *qp, void **ops, const uint16_t nb_ops)
+{
+   uint16_t nb = 0;
+   uint32_t type = 0;
+   struct qp_srv *srv;
+
+   for (type = 0; type < ZSDA_SERVICE_INVALID; type++) {
+   if (!qp->srv[type].used)
+   continue;
+   srv = &qp->srv[type];
+   zsda_dequeue(srv, ops, nb_ops, &nb);
+   if (nb >= nb_ops)
+   return nb_ops;
+   }
+   return nb;
+}
diff --git a/drivers/common/zsda/zsda_qp.h b/drivers/common/zsda/zsda_qp.h
index 209526fa98..486474ee70 100644
--- a/drivers/common/zsda/zsda_qp.h
+++ b/drivers/common/zsda/zsda_qp.h
@@ -181,5 +181,6 @@ int zsda_task_queue_setup(struct zsda_pci_device 
*zsda_pci_dev,
struct zsda_qp *qp, struct task_queue_info 
*task_q_info);
 
 uint16_t zsda_enqueue_burst(struct zsda_qp *qp, void **ops, const uint16_t 
nb_ops);
+uint16_t zsda_dequeue_burst(struct zsda_qp *qp, void **ops, const uint16_t 
nb_ops);
 
 #endif /* _ZSDA_QP_H_ */
diff --git a/drivers/common/zsda/zsda_qp_common.h 
b/drivers/common/zsda/zsda_qp_common.h
index 0acd2685e3..941278c6d2 100644
--- a/drivers/common/zsda/zsda_qp_common.h
+++ b/drivers/common/zsda/zsda_qp_common.h
@@ -49,6 +49,10 @@ enum zsda_service_type {
 #define ZSDA_OPC_DECOMP_ZLIB   0x19 /* Decomp inflate-Zlib */
 #define ZSDA_OPC_INVALID   0xff
 
+#define CQE_VALID(value) (value & 0x8000)
+#define CQE_ERR0(value) (value & 0x)
+#define CQE_ERR1(value) (value & 0x7FFF)
+
 enum wqe_element_type {
WQE_ELM_TYPE_PHYS_ADDR = 1,
WQE_ELM_TYPE_LIST,
diff --git a/drivers/compress/zsda/zsda_comp.c 
b/drivers/compress/zsda/zsda_comp.c
index 608c50c49a..af57c237b2 100644
--- a/drivers/compress/zsda/zsda_comp.c
+++ b/drivers/compress/zsda/zsda_comp.c
@@ -10,6 +10,83 @@
 #define GZIP_TRAILER_SIZE 8
 #define CHECKSUM_SIZE 4
 
+#define POLYNOMIAL 0xEDB88320
+static uint32_t crc32_table[8][256];
+static int table_config;
+
+static void
+crc32_table_build(void)
+{
+   for (uint32_t i = 0; i < 256; i++) {
+   uint32_t crc = i;
+   for (uint32_t j = 0; j < 8; j++)
+   crc = (crc >> 1) ^ ((crc & 1) ? POLYNOMIAL : 0);
+   crc32_table[0][i] = crc;
+   }
+
+   for (int i = 1; i < 8; i++) {
+   for (uint32_t j = 0; j < 256; j++)
+   crc32_table[i][j] = (crc32_table[i-1][j] >> 8) ^
+   crc32_table[0][crc32_table[i-1][j] & 
0xFF];
+   }
+   table_config = 1;
+}
+
+static uint32_t
+zsda_crc32(const uint8_t *data, size_t length)
+{
+   uint32_t crc = 0x;
+
+   if (!table_config)
+   crc32_table_build();
+
+   while (length >= 8) {
+  

[PATCH v26 04/13] common/zsda: add functions to operate hardware queue

[Hanxiao Li]

Add functions to operate hardware queue,
such as queue start,stop and clear.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/meson.build  |   1 +
 drivers/common/zsda/zsda_device.c|   7 ++
 drivers/common/zsda/zsda_qp.c| 136 +++
 drivers/common/zsda/zsda_qp.h|  37 
 drivers/common/zsda/zsda_qp_common.h |   5 +
 5 files changed, 186 insertions(+)
 create mode 100644 drivers/common/zsda/zsda_qp.c
 create mode 100644 drivers/common/zsda/zsda_qp.h

diff --git a/drivers/common/zsda/meson.build b/drivers/common/zsda/meson.build
index 342d000c6d..4c910d7e7d 100644
--- a/drivers/common/zsda/meson.build
+++ b/drivers/common/zsda/meson.build
@@ -11,4 +11,5 @@ deps += ['bus_pci', 'mbuf']
 sources += files(
'zsda_device.c',
'zsda_logs.c',
+   'zsda_qp.c',
)
diff --git a/drivers/common/zsda/zsda_device.c 
b/drivers/common/zsda/zsda_device.c
index 18ca372f60..189614f881 100644
--- a/drivers/common/zsda/zsda_device.c
+++ b/drivers/common/zsda/zsda_device.c
@@ -2,6 +2,7 @@
  * Copyright(c) 2024 ZTE Corporation
  */
 
+#include "zsda_qp.h"
 #include "zsda_device.h"
 
 /* per-process array of device data */
@@ -165,6 +166,12 @@ zsda_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
return -ENODEV;
}
 
+   ret = zsda_queue_init(zsda_pci_dev);
+   if (ret) {
+   ZSDA_LOG(ERR, "Failed! queue init.");
+   return ret;
+   }
+
return ret;
 }
 
diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
new file mode 100644
index 00..7feafe4023
--- /dev/null
+++ b/drivers/common/zsda/zsda_qp.c
@@ -0,0 +1,136 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include "zsda_qp.h"
+
+static uint8_t zsda_num_used_qps;
+
+static uint8_t
+zsda_used_qps_num_get(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   uint8_t num_used_qps;
+
+   num_used_qps = ZSDA_CSR_READ8(mmio_base + 0);
+
+   return num_used_qps;
+}
+
+static int
+zsda_check_write(uint8_t *addr, const uint32_t dst_value)
+{
+   int times = ZSDA_TIME_NUM;
+   uint32_t val;
+
+   val = ZSDA_CSR_READ32(addr);
+
+   while ((val != dst_value) && times--) {
+   val = ZSDA_CSR_READ32(addr);
+   rte_delay_us_sleep(ZSDA_TIME_SLEEP_US);
+   }
+   if (val == dst_value)
+   return ZSDA_SUCCESS;
+   else
+   return ZSDA_FAILED;
+}
+
+static int
+zsda_admin_q_start(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   int ret;
+
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_START, 0);
+
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_START, ZSDA_Q_START);
+   ret = zsda_check_write(mmio_base + ZSDA_ADMIN_Q_START, ZSDA_Q_START);
+
+   return ret;
+}
+
+static int __rte_unused
+zsda_admin_q_stop(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   int ret;
+
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_STOP_RESP, ZSDA_RESP_INVALID);
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_STOP, ZSDA_Q_STOP);
+
+   ret = zsda_check_write(mmio_base + ZSDA_ADMIN_Q_STOP_RESP,
+  ZSDA_RESP_VALID);
+
+   if (ret)
+   ZSDA_LOG(INFO, "Failed! zsda_admin q stop");
+
+   return ret;
+}
+
+static int __rte_unused
+zsda_admin_q_clear(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   int ret;
+
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_CLR_RESP, ZSDA_RESP_INVALID);
+   ZSDA_CSR_WRITE32(mmio_base + ZSDA_ADMIN_Q_CLR, ZSDA_RESP_VALID);
+
+   ret = zsda_check_write(mmio_base + ZSDA_ADMIN_Q_CLR_RESP,
+  ZSDA_RESP_VALID);
+
+   if (ret)
+   ZSDA_LOG(INFO, "Failed! zsda_admin q clear");
+
+   return ret;
+}
+
+static int
+zsda_single_queue_clear(uint8_t *mmio_base, const uint8_t id)
+{
+   int ret;
+   uint8_t *addr_clear = mmio_base + ZSDA_IO_Q_CLR + (4 * id);
+   uint8_t *addr_resp = mmio_base + ZSDA_IO_Q_CLR_RESP + (4 * id);
+
+   ZSDA_CSR_WRITE32(addr_resp, ZSDA_RESP_INVALID);
+   ZSDA_CSR_WRITE32(addr_clear, ZSDA_CLEAR_VALID);
+   ret = zsda_check_write(addr_resp, ZSDA_RESP_VALID);
+   ZSDA_CSR_WRITE32(addr_clear, ZSDA_CLEAR_INVALID);
+
+   return ret;
+}
+
+static int
+zsda_queue_clear(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   uint8_t id;
+   int ret = ZSDA_SUCCESS;
+
+   for (id = 0; id < zsda_num_used_qps; id++)
+   ret |= zsda_single_queue_clear(mmio_base, id);
+
+   return ret;
+}
+
+int
+zsda_queue_init(struct zsda_pci_device *zsda_pci_dev)
+{
+   int ret;
+
+   zsda_num_used_qps = zsd

[PATCH v26 07/13] compress/zsda: add zsda compressdev dev ops

[Hanxiao Li]

add zsda compressdev dev interface implementation.

Signed-off-by: Hanxiao Li 
---
 drivers/common/zsda/zsda_qp.c |  51 ++
 drivers/common/zsda/zsda_qp.h |   3 +
 drivers/common/zsda/zsda_qp_common.h  |  34 +++
 drivers/compress/zsda/zsda_comp_pmd.c | 133 +-
 drivers/compress/zsda/zsda_comp_pmd.h |   5 +
 5 files changed, 221 insertions(+), 5 deletions(-)

diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c
index a87ec0f93a..1ad609675d 100644
--- a/drivers/common/zsda/zsda_qp.c
+++ b/drivers/common/zsda/zsda_qp.c
@@ -129,6 +129,31 @@ zsda_admin_q_clear(const struct rte_pci_device *pci_dev)
return ret;
 }
 
+static int
+zsda_single_queue_start(uint8_t *mmio_base, const uint8_t id)
+{
+   uint8_t *addr_start = mmio_base + ZSDA_IO_Q_START + (4 * id);
+
+   ZSDA_CSR_WRITE32(addr_start, ZSDA_Q_START);
+   return zsda_check_write(addr_start, ZSDA_Q_START);
+}
+
+static int
+zsda_single_queue_stop(uint8_t *mmio_base, const uint8_t id)
+{
+   int ret;
+   uint8_t *addr_stop = mmio_base + ZSDA_IO_Q_STOP + (4 * id);
+   uint8_t *addr_resp = mmio_base + ZSDA_IO_Q_STOP_RESP + (4 * id);
+
+   ZSDA_CSR_WRITE32(addr_resp, ZSDA_RESP_INVALID);
+   ZSDA_CSR_WRITE32(addr_stop, ZSDA_Q_STOP);
+
+   ret = zsda_check_write(addr_resp, ZSDA_RESP_VALID);
+   ZSDA_CSR_WRITE32(addr_resp, ZSDA_RESP_INVALID);
+
+   return ret;
+}
+
 static int
 zsda_single_queue_clear(uint8_t *mmio_base, const uint8_t id)
 {
@@ -144,6 +169,32 @@ zsda_single_queue_clear(uint8_t *mmio_base, const uint8_t 
id)
return ret;
 }
 
+int
+zsda_queue_start(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   uint8_t id;
+   int ret = ZSDA_SUCCESS;
+
+   for (id = 0; id < zsda_num_used_qps; id++)
+   ret |= zsda_single_queue_start(mmio_base, id);
+
+   return ret;
+}
+
+int
+zsda_queue_stop(const struct rte_pci_device *pci_dev)
+{
+   uint8_t *mmio_base = pci_dev->mem_resource[0].addr;
+   uint8_t id;
+   int ret = ZSDA_SUCCESS;
+
+   for (id = 0; id < zsda_num_used_qps; id++)
+   ret |= zsda_single_queue_stop(mmio_base, id);
+
+   return ret;
+}
+
 static int
 zsda_queue_clear(const struct rte_pci_device *pci_dev)
 {
diff --git a/drivers/common/zsda/zsda_qp.h b/drivers/common/zsda/zsda_qp.h
index 0347b0f6cd..c07b8cc653 100644
--- a/drivers/common/zsda/zsda_qp.h
+++ b/drivers/common/zsda/zsda_qp.h
@@ -90,6 +90,9 @@ struct zsda_num_qps {
 
 extern struct zsda_num_qps zsda_nb_qps;
 
+int zsda_queue_start(const struct rte_pci_device *pci_dev);
+int zsda_queue_stop(const struct rte_pci_device *pci_dev);
+
 int zsda_queue_init(struct zsda_pci_device *zsda_pci_dev);
 
 #endif /* _ZSDA_QP_H_ */
diff --git a/drivers/common/zsda/zsda_qp_common.h 
b/drivers/common/zsda/zsda_qp_common.h
index e69dd03bc9..550411dbc4 100644
--- a/drivers/common/zsda/zsda_qp_common.h
+++ b/drivers/common/zsda/zsda_qp_common.h
@@ -59,4 +59,38 @@ struct __rte_packed_begin zsda_admin_resp_qcfg {
uint8_t data[14];
 } __rte_packed_end;
 
+struct zsda_queue {
+   char memz_name[RTE_MEMZONE_NAMESIZE];
+   uint8_t *io_addr;
+   uint8_t *base_addr;/* Base address */
+   rte_iova_t base_phys_addr; /* Queue physical address */
+   uint16_t head; /* Shadow copy of the head */
+   uint16_t tail; /* Shadow copy of the tail */
+   uint16_t modulo_mask;
+   uint16_t msg_size;
+   uint16_t queue_size;
+   uint16_t cycle_size;
+   uint16_t pushed_wqe;
+
+   uint8_t hw_queue_number;
+   uint32_t csr_head; /* last written head value */
+   uint32_t csr_tail; /* last written tail value */
+
+   uint8_t valid;
+   uint16_t sid;
+};
+
+struct qp_srv {
+   bool used;
+   struct zsda_queue tx_q;
+   struct zsda_queue rx_q;
+   struct rte_mempool *op_cookie_pool;
+   void **op_cookies;
+   uint16_t nb_descriptors;
+};
+
+struct zsda_qp {
+   struct qp_srv srv[ZSDA_MAX_SERVICES];
+};
+
 #endif /* _ZSDA_QP_COMMON_H_ */
diff --git a/drivers/compress/zsda/zsda_comp_pmd.c 
b/drivers/compress/zsda/zsda_comp_pmd.c
index a9cb1f2996..07c03a8d13 100644
--- a/drivers/compress/zsda/zsda_comp_pmd.c
+++ b/drivers/compress/zsda/zsda_comp_pmd.c
@@ -8,13 +8,134 @@
 #include "zsda_qp_common.h"
 #include "zsda_comp_pmd.h"
 
+static int
+zsda_comp_xform_size(void)
+{
+   return RTE_ALIGN_CEIL(sizeof(struct zsda_comp_xform), 8);
+}
+
+static struct rte_mempool *
+zsda_comp_xform_pool_create(struct zsda_comp_dev_private *comp_dev,
+   struct rte_compressdev_config *config,
+   uint32_t num_elements)
+{
+   char xform_pool_name[RTE_MEMPOOL_NAMESIZE];
+   struct rte_mempool *mp;
+
+   snprintf(xform_pool_name, RTE_MEMPOOL_NAMESIZE, "%s_xforms",
+comp_dev->zsda_pci_dev->name);
+
+   ZSDA_L

[PATCH v26 09/13] compress/zsda: add zsda compressdev xform ops

[Hanxiao Li]

Add zsda compressdev xform interface implementation.

Signed-off-by: Hanxiao Li 
---
 drivers/compress/zsda/zsda_comp_pmd.c | 54 ++-
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/drivers/compress/zsda/zsda_comp_pmd.c 
b/drivers/compress/zsda/zsda_comp_pmd.c
index f1d20e245e..ec7918a32e 100644
--- a/drivers/compress/zsda/zsda_comp_pmd.c
+++ b/drivers/compress/zsda/zsda_comp_pmd.c
@@ -149,6 +149,56 @@ zsda_comp_stats_reset(struct rte_compressdev *dev)
zsda_stats_reset(dev->data->queue_pairs, dev->data->nb_queue_pairs);
 }
 
+static int
+zsda_comp_private_xform_create(struct rte_compressdev *dev,
+  const struct rte_comp_xform *xform,
+  void **private_xform)
+{
+   struct zsda_comp_dev_private *zsda = dev->data->dev_private;
+
+   if (unlikely(private_xform == NULL)) {
+   ZSDA_LOG(ERR, "Failed! private_xform is NULL");
+   return -EINVAL;
+   }
+   if (unlikely(zsda->xformpool == NULL)) {
+   ZSDA_LOG(ERR, "Failed! zsda->xformpool is NULL");
+   return -ENOMEM;
+   }
+   if (rte_mempool_get(zsda->xformpool, private_xform)) {
+   ZSDA_LOG(ERR, "Failed! zsda->xformpool is NULL");
+   return -ENOMEM;
+   }
+
+   struct zsda_comp_xform *zsda_xform = *private_xform;
+   zsda_xform->type = xform->type;
+
+   if (zsda_xform->type == RTE_COMP_COMPRESS)
+   zsda_xform->checksum_type = xform->compress.chksum;
+   else
+   zsda_xform->checksum_type = xform->decompress.chksum;
+
+   if (zsda_xform->checksum_type == RTE_COMP_CHECKSUM_CRC32_ADLER32)
+   return -EINVAL;
+
+   return ZSDA_SUCCESS;
+}
+
+static int
+zsda_comp_private_xform_free(struct rte_compressdev *dev __rte_unused,
+void *private_xform)
+{
+   struct zsda_comp_xform *zsda_xform = private_xform;
+
+   if (zsda_xform) {
+   memset(zsda_xform, 0, zsda_comp_xform_size());
+   struct rte_mempool *mp = rte_mempool_from_obj(zsda_xform);
+
+   rte_mempool_put(mp, zsda_xform);
+   return ZSDA_SUCCESS;
+   }
+   return -EINVAL;
+}
+
 static struct rte_compressdev_ops compress_zsda_ops = {
 
.dev_configure = zsda_comp_dev_config,
@@ -162,8 +212,8 @@ static struct rte_compressdev_ops compress_zsda_ops = {
.queue_pair_setup = NULL,
.queue_pair_release = NULL,
 
-   .private_xform_create = NULL,
-   .private_xform_free = NULL
+   .private_xform_create = zsda_comp_private_xform_create,
+   .private_xform_free = zsda_comp_private_xform_free,
 };
 
 /* An rte_driver is needed in the registration of the device with compressdev.
-- 
2.27.0

[RFC 02/10] common/qat: remove weak symbols

[David Marchand]

Remove dead code, those symbols are never used as the "strong" symbols
are always linked in.

Signed-off-by: David Marchand 
---
 drivers/common/qat/qat_qp.c | 8 
 drivers/common/qat/qat_qp.h | 5 -
 2 files changed, 13 deletions(-)

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 4bf9bac23e..0d2bbdb8a5 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -944,11 +944,3 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp)
return ret;
 }
 #endif
-
-__rte_weak int
-qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused,
- void *op_cookie __rte_unused,
- uint64_t *dequeue_err_count __rte_unused)
-{
-   return  0;
-}
diff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h
index f0ea907503..5ccaedefa7 100644
--- a/drivers/common/qat/qat_qp.h
+++ b/drivers/common/qat/qat_qp.h
@@ -156,11 +156,6 @@ int
 qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp);
 #endif
 
-/* Needed for weak function*/
-int
-qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused,
- void *op_cookie __rte_unused,
- uint64_t *dequeue_err_count __rte_unused);
 int
 qat_read_qp_config(struct qat_pci_device *qat_dev);
 
-- 
2.48.1

[RFC 03/10] drivers: remove weak symbols in Nitrox drivers

[David Marchand]

Make compress and crypto drivers register to the common driver.
Remove (unneeded) include_directories().

Signed-off-by: David Marchand 
---
 drivers/common/nitrox/meson.build |  3 --
 drivers/common/nitrox/nitrox_device.c | 75 ++-
 drivers/common/nitrox/nitrox_device.h | 16 ++
 drivers/common/nitrox/version.map |  1 +
 drivers/compress/nitrox/meson.build   |  2 -
 drivers/compress/nitrox/nitrox_comp.c |  6 +++
 drivers/crypto/nitrox/meson.build |  2 -
 drivers/crypto/nitrox/nitrox_sym.c|  6 +++
 8 files changed, 57 insertions(+), 54 deletions(-)

diff --git a/drivers/common/nitrox/meson.build 
b/drivers/common/nitrox/meson.build
index f3cb42f006..115dd8de4d 100644
--- a/drivers/common/nitrox/meson.build
+++ b/drivers/common/nitrox/meson.build
@@ -14,6 +14,3 @@ sources += files(
 'nitrox_logs.c',
 'nitrox_qp.c',
 )
-
-includes += include_directories('../../crypto/nitrox')
-includes += include_directories('../../compress/nitrox')
diff --git a/drivers/common/nitrox/nitrox_device.c 
b/drivers/common/nitrox/nitrox_device.c
index 39edc440a7..6cd57faaa4 100644
--- a/drivers/common/nitrox/nitrox_device.c
+++ b/drivers/common/nitrox/nitrox_device.c
@@ -6,8 +6,6 @@
 
 #include "nitrox_device.h"
 #include "nitrox_hal.h"
-#include "nitrox_sym.h"
-#include "nitrox_comp.h"
 
 #define PCI_VENDOR_ID_CAVIUM   0x177d
 #define NITROX_V_PCI_VF_DEV_ID 0x13
@@ -63,11 +61,21 @@ ndev_release(struct nitrox_device *ndev)
rte_free(ndev);
 }
 
+TAILQ_HEAD(ndrv_list, nitrox_driver);
+static struct ndrv_list ndrv_list = TAILQ_HEAD_INITIALIZER(ndrv_list);
+
+void
+nitrox_register_driver(struct nitrox_driver *ndrv)
+{
+   TAILQ_INSERT_TAIL(&ndrv_list, ndrv, next);
+}
+
 static int
 nitrox_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *pdev)
 {
struct nitrox_device *ndev;
+   struct nitrox_driver *ndrv;
int err = -1;
 
/* Nitrox CSR space */
@@ -79,19 +87,21 @@ nitrox_pci_probe(struct rte_pci_driver *pci_drv 
__rte_unused,
return -ENOMEM;
 
ndev_init(ndev, pdev);
-   err = nitrox_sym_pmd_create(ndev);
-   if (err)
-   goto sym_pmd_err;
-
-   err = nitrox_comp_pmd_create(ndev);
-   if (err)
-   goto comp_pmd_err;
+   TAILQ_FOREACH(ndrv, &ndrv_list, next) {
+   err = ndrv->create(ndev);
+   if (err)
+   goto drv_err;
+   }
 
return 0;
 
-comp_pmd_err:
-   nitrox_sym_pmd_destroy(ndev);
-sym_pmd_err:
+drv_err:
+   ndrv = TAILQ_PREV(ndrv, ndrv_list, next);
+   while (ndrv != NULL) {
+   ndrv->destroy(ndev);
+   ndrv = TAILQ_PREV(ndrv, ndrv_list, next);
+   }
+
ndev_release(ndev);
return err;
 }
@@ -100,19 +110,18 @@ static int
 nitrox_pci_remove(struct rte_pci_device *pdev)
 {
struct nitrox_device *ndev;
+   struct nitrox_driver *ndrv;
int err;
 
ndev = find_ndev(pdev);
if (!ndev)
return -ENODEV;
 
-   err = nitrox_sym_pmd_destroy(ndev);
-   if (err)
-   return err;
-
-   err = nitrox_comp_pmd_destroy(ndev);
-   if (err)
-   return err;
+   TAILQ_FOREACH(ndrv, &ndrv_list, next) {
+   err = ndrv->destroy(ndev);
+   if (err)
+   return err;
+   }
 
ndev_release(ndev);
return 0;
@@ -133,33 +142,5 @@ static struct rte_pci_driver nitrox_pmd = {
.remove = nitrox_pci_remove,
 };
 
-__rte_weak int
-nitrox_sym_pmd_create(struct nitrox_device *ndev)
-{
-   RTE_SET_USED(ndev);
-   return 0;
-}
-
-__rte_weak int
-nitrox_sym_pmd_destroy(struct nitrox_device *ndev)
-{
-   RTE_SET_USED(ndev);
-   return 0;
-}
-
-__rte_weak int
-nitrox_comp_pmd_create(struct nitrox_device *ndev)
-{
-   RTE_SET_USED(ndev);
-   return 0;
-}
-
-__rte_weak int
-nitrox_comp_pmd_destroy(struct nitrox_device *ndev)
-{
-   RTE_SET_USED(ndev);
-   return 0;
-}
-
 RTE_PMD_REGISTER_PCI(nitrox, nitrox_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(nitrox, pci_id_nitrox_map);
diff --git a/drivers/common/nitrox/nitrox_device.h 
b/drivers/common/nitrox/nitrox_device.h
index 877bccb321..b74b71808e 100644
--- a/drivers/common/nitrox/nitrox_device.h
+++ b/drivers/common/nitrox/nitrox_device.h
@@ -6,6 +6,7 @@
 #define _NITROX_DEVICE_H_
 
 #include 
+#include 
 
 struct nitrox_sym_device;
 struct nitrox_comp_device;
@@ -21,4 +22,19 @@ struct nitrox_device {
uint16_t nr_queues;
 };
 
+struct nitrox_driver {
+   TAILQ_ENTRY(nitrox_driver) next;
+   int (*create)(struct nitrox_device *ndev);
+   int (*destroy)(struct nitrox_device *ndev);
+};
+
+__rte_internal
+void nitrox_register_driver(struct nitrox_driver *ndrv);
+
+#define NITROX_REGISTER_DRIVER(ndrv) \
+RTE_INIT(ndrv ## _register) \
+{ \
+   nitrox_register_driver(&ndrv); \
+}
+
 #endif /* _NITROX_DEVICE_H

[RFC 00/10] Remove weak symbols

[David Marchand]

This is an alternative to André series:
https://inbox.dpdk.org/dev/1735009552-31906-1-git-send-email-andre...@linux.microsoft.com/

Weak symbols can be easily replaced with some linking updates, and make
it clearer which symbols are actually ending up in the final binary.


-- 
David Marchand

David Marchand (10):
  bus/auxiliary: remove weak symbols
  common/qat: remove weak symbols
  drivers: remove weak symbols in Nitrox drivers
  net/enic: remove weak symbols
  net/hns3: remove weak symbols
  net/fm10k: remove weak symbols
  net/nfp: remove weak symbols
  net/virtio: remove weak symbols
  app/compress-perf: remove weak symbols
  eal: deprecate weak symbols

 app/test-compress-perf/main.c| 62 
 doc/guides/rel_notes/release_25_03.rst   |  2 +
 drivers/bus/auxiliary/auxiliary_common.c |  6 +-
 drivers/bus/auxiliary/meson.build|  1 +
 drivers/common/nitrox/meson.build|  3 -
 drivers/common/nitrox/nitrox_device.c| 75 +---
 drivers/common/nitrox/nitrox_device.h| 16 +
 drivers/common/nitrox/version.map|  1 +
 drivers/common/qat/qat_qp.c  |  8 ---
 drivers/common/qat/qat_qp.h  |  5 --
 drivers/compress/nitrox/meson.build  |  2 -
 drivers/compress/nitrox/nitrox_comp.c|  6 ++
 drivers/crypto/nitrox/meson.build|  2 -
 drivers/crypto/nitrox/nitrox_sym.c   |  6 ++
 drivers/net/enic/enic_main.c |  8 +--
 drivers/net/enic/meson.build |  1 +
 drivers/net/hns3/hns3_rxtx.c | 22 ---
 drivers/net/intel/fm10k/fm10k_ethdev.c   | 20 ---
 drivers/net/nfp/meson.build  |  7 ++-
 drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c |  2 +-
 drivers/net/nfp/nfp_rxtx_vec_stub.c  |  4 +-
 drivers/net/virtio/meson.build   |  5 ++
 drivers/net/virtio/virtio_rxtx.c |  6 +-
 drivers/net/virtio/virtio_rxtx_simple.c  |  4 +-
 lib/eal/include/rte_common.h |  6 +-
 25 files changed, 119 insertions(+), 161 deletions(-)

-- 
2.48.1

[RFC 10/10] eal: deprecate weak symbols

[David Marchand]

Mark __rte_weak as deprecated.
It will avoid having to support such feature with other linkers,
plus this was never really needed.

Signed-off-by: David Marchand 
---
 doc/guides/rel_notes/release_25_03.rst | 2 ++
 lib/eal/include/rte_common.h   | 6 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_25_03.rst 
b/doc/guides/rel_notes/release_25_03.rst
index 269ab6f68a..e9a9abbb13 100644
--- a/doc/guides/rel_notes/release_25_03.rst
+++ b/doc/guides/rel_notes/release_25_03.rst
@@ -125,6 +125,8 @@ API Changes
 * eal: The ``__rte_packed`` macro for packing data is replaced with
   ``__rte_packed_begin`` / ``__rte_packed_end``.
 
+* eal: The ``__rte_weak`` macro is deprecated and will be removed in a future 
release.
+
 * build: The Intel networking drivers:
   cpfl, e1000, fm10k, i40e, iavf, ice, idpf, igc, ipn3ke and ixgbe,
   have been moved from ``drivers/net`` to a new ``drivers/net/intel`` 
directory.
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 7a252c1997..2e0ee9dc7e 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -181,7 +181,11 @@ typedef uint16_t unaligned_uint16_t;
 /**
  * Mark a function or variable to a weak reference.
  */
-#define __rte_weak __attribute__((__weak__))
+#ifdef RTE_TOOLCHAIN_MSVC
+#define __rte_weak RTE_DEPRECATED(__rte_weak)
+#else
+#define __rte_weak RTE_DEPRECATED(__rte_weak) __attribute__((__weak__))
+#endif
 
 /**
  * Mark a function to be pure.
-- 
2.48.1

[RFC 09/10] app/compress-perf: remove weak symbols

[David Marchand]

Remove dead code, those symbols are never used as the "strong" symbols
are always linked in.

Signed-off-by: David Marchand 
---
 app/test-compress-perf/main.c | 62 ---
 1 file changed, 62 deletions(-)

diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index fa366123ed..70ce4316cc 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -521,65 +521,3 @@ main(int argc, char **argv)
}
return ret;
 }
-
-__rte_weak void *
-cperf_cyclecount_test_constructor(uint8_t dev_id __rte_unused,
-uint16_t qp_id __rte_unused,
-struct comp_test_data *options __rte_unused)
-{
-   RTE_LOG(INFO, USER1, "Cycle count test is not supported yet\n");
-   return NULL;
-}
-
-__rte_weak void
-cperf_cyclecount_test_destructor(void *arg __rte_unused)
-{
-   RTE_LOG(INFO, USER1, "Something wrong happened!!!\n");
-}
-
-__rte_weak int
-cperf_cyclecount_test_runner(void *test_ctx __rte_unused)
-{
-   return 0;
-}
-
-__rte_weak void *
-cperf_throughput_test_constructor(uint8_t dev_id __rte_unused,
-uint16_t qp_id __rte_unused,
-struct comp_test_data *options __rte_unused)
-{
-   RTE_LOG(INFO, USER1, "Benchmark test is not supported yet\n");
-   return NULL;
-}
-
-__rte_weak void
-cperf_throughput_test_destructor(void *arg __rte_unused)
-{
-
-}
-
-__rte_weak int
-cperf_throughput_test_runner(void *test_ctx __rte_unused)
-{
-   return 0;
-}
-__rte_weak void *
-cperf_verify_test_constructor(uint8_t dev_id __rte_unused,
-uint16_t qp_id __rte_unused,
-struct comp_test_data *options __rte_unused)
-{
-   RTE_LOG(INFO, USER1, "Verify test is not supported yet\n");
-   return NULL;
-}
-
-__rte_weak void
-cperf_verify_test_destructor(void *arg __rte_unused)
-{
-
-}
-
-__rte_weak int
-cperf_verify_test_runner(void *test_ctx __rte_unused)
-{
-   return 0;
-}
-- 
2.48.1

[RFC 08/10] net/virtio: remove weak symbols

[David Marchand]

Rather than use weak symbols, expose stubs symbols when needed.

Signed-off-by: David Marchand 
---
 drivers/net/virtio/meson.build  | 5 +
 drivers/net/virtio/virtio_rxtx.c| 6 --
 drivers/net/virtio/virtio_rxtx_simple.c | 4 +++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
index c708ea5258..56c763e96f 100644
--- a/drivers/net/virtio/meson.build
+++ b/drivers/net/virtio/meson.build
@@ -28,6 +28,7 @@ cflags += no_wvla_cflag
 if arch_subdir == 'x86'
 if cc_has_avx512
 cflags += ['-DCC_AVX512_SUPPORT']
+cflags += ['-DVIRTIO_RXTX_PACKED_VEC']
 virtio_avx512_lib = static_library('virtio_avx512_lib',
 'virtio_rxtx_packed.c',
 dependencies: [static_rte_ethdev,
@@ -43,11 +44,15 @@ if arch_subdir == 'x86'
 cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
 endif
 endif
+cflags += ['-DVIRTIO_RXTX_VEC']
 sources += files('virtio_rxtx_simple_sse.c')
 elif arch_subdir == 'ppc'
+cflags += ['-DVIRTIO_RXTX_VEC']
 sources += files('virtio_rxtx_simple_altivec.c')
 elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
+cflags += ['-DVIRTIO_RXTX_PACKED_VEC']
 sources += files('virtio_rxtx_packed.c')
+cflags += ['-DVIRTIO_RXTX_VEC']
 sources += files('virtio_rxtx_simple_neon.c')
 endif
 
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index b67f063b31..2a0d1b6101 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -2045,7 +2045,8 @@ virtio_xmit_pkts_inorder(void *tx_queue,
return nb_tx;
 }
 
-__rte_weak uint16_t
+#ifndef VIRTIO_RXTX_PACKED_VEC
+uint16_t
 virtio_recv_pkts_packed_vec(void *rx_queue __rte_unused,
struct rte_mbuf **rx_pkts __rte_unused,
uint16_t nb_pkts __rte_unused)
@@ -2053,10 +2054,11 @@ virtio_recv_pkts_packed_vec(void *rx_queue __rte_unused,
return 0;
 }
 
-__rte_weak uint16_t
+uint16_t
 virtio_xmit_pkts_packed_vec(void *tx_queue __rte_unused,
struct rte_mbuf **tx_pkts __rte_unused,
uint16_t nb_pkts __rte_unused)
 {
return 0;
 }
+#endif /* DVIRTIO_RXTX_PACKED_VEC */
diff --git a/drivers/net/virtio/virtio_rxtx_simple.c 
b/drivers/net/virtio/virtio_rxtx_simple.c
index 439e00a7e1..aa96c9c488 100644
--- a/drivers/net/virtio/virtio_rxtx_simple.c
+++ b/drivers/net/virtio/virtio_rxtx_simple.c
@@ -43,8 +43,9 @@ virtio_rxq_vec_setup(struct virtnet_rx *rxq)
return 0;
 }
 
+#ifndef VIRTIO_RXTX_VEC
 /* Stub for linkage when arch specific implementation is not available */
-__rte_weak uint16_t
+uint16_t
 virtio_recv_pkts_vec(void *rx_queue __rte_unused,
 struct rte_mbuf **rx_pkts __rte_unused,
 uint16_t nb_pkts __rte_unused)
@@ -52,3 +53,4 @@ virtio_recv_pkts_vec(void *rx_queue __rte_unused,
rte_panic("Wrong weak function linked by linker\n");
return 0;
 }
+#endif /* VIRTIO_RXTX_VEC */
-- 
2.48.1

[RFC 05/10] net/hns3: remove weak symbols

[David Marchand]

Rather than use weak symbols, expose stubs symbols when needed.

Signed-off-by: David Marchand 
---
 drivers/net/hns3/hns3_rxtx.c | 22 +++---
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index 09e39cb673..0b42b9826e 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -2787,18 +2787,19 @@ hns3_recv_scattered_pkts(void *rx_queue,
return nb_rx;
 }
 
-void __rte_weak
+#ifndef RTE_ARCH_ARM64
+void
 hns3_rxq_vec_setup(__rte_unused struct hns3_rx_queue *rxq)
 {
 }
 
-int __rte_weak
+int
 hns3_rx_check_vec_support(__rte_unused struct rte_eth_dev *dev)
 {
return -ENOTSUP;
 }
 
-uint16_t __rte_weak
+uint16_t
 hns3_recv_pkts_vec(__rte_unused void *rx_queue,
   __rte_unused struct rte_mbuf **rx_pkts,
   __rte_unused uint16_t nb_pkts)
@@ -2806,13 +2807,16 @@ hns3_recv_pkts_vec(__rte_unused void *rx_queue,
return 0;
 }
 
-uint16_t __rte_weak
+#ifndef RTE_HAS_SVE_ACLE
+uint16_t
 hns3_recv_pkts_vec_sve(__rte_unused void *rx_queue,
   __rte_unused struct rte_mbuf **rx_pkts,
   __rte_unused uint16_t nb_pkts)
 {
return 0;
 }
+#endif /* RTE_HAS_SVE_ACLE */
+#endif /* RTE_ARCH_ARM64 */
 
 int
 hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,
@@ -4256,13 +4260,14 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts, uint16_t nb_pkts)
return nb_tx;
 }
 
-int __rte_weak
+#ifndef RTE_ARCH_ARM64
+int
 hns3_tx_check_vec_support(__rte_unused struct rte_eth_dev *dev)
 {
return -ENOTSUP;
 }
 
-uint16_t __rte_weak
+uint16_t
 hns3_xmit_pkts_vec(__rte_unused void *tx_queue,
   __rte_unused struct rte_mbuf **tx_pkts,
   __rte_unused uint16_t nb_pkts)
@@ -4270,13 +4275,16 @@ hns3_xmit_pkts_vec(__rte_unused void *tx_queue,
return 0;
 }
 
-uint16_t __rte_weak
+#ifndef RTE_HAS_SVE_ACLE
+uint16_t
 hns3_xmit_pkts_vec_sve(void __rte_unused * tx_queue,
   struct rte_mbuf __rte_unused **tx_pkts,
   uint16_t __rte_unused nb_pkts)
 {
return 0;
 }
+#endif /* RTE_HAS_SVE_ACLE */
+#endif /* RTE_ARCH_ARM64 */
 
 int
 hns3_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,
-- 
2.48.1

[RFC 04/10] net/enic: remove weak symbols

[David Marchand]

Rather than use weak symbols, expose stubs symbols when needed.

Signed-off-by: David Marchand 
---
 drivers/net/enic/enic_main.c | 8 +++-
 drivers/net/enic/meson.build | 1 +
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index b755b15d92..5ee2ae555d 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -509,15 +509,13 @@ static void enic_prep_wq_for_simple_tx(struct enic *enic, 
uint16_t queue_idx)
}
 }
 
-/*
- * The 'strong' version is in enic_rxtx_vec_avx2.c. This weak version is used
- * used when that file is not compiled.
- */
-__rte_weak bool
+#ifndef ENIC_RXTX_VEC
+bool
 enic_use_vector_rx_handler(__rte_unused struct rte_eth_dev *eth_dev)
 {
return false;
 }
+#endif /* ENIC_RXTX_VEC */
 
 void enic_pick_rx_handler(struct rte_eth_dev *eth_dev)
 {
diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build
index 00f8348348..1e26338350 100644
--- a/drivers/net/enic/meson.build
+++ b/drivers/net/enic/meson.build
@@ -33,6 +33,7 @@ includes += include_directories('base')
 # may not. This is to support users who build for the min supported machine
 # and need to run the binary on newer CPUs too.
 if dpdk_conf.has('RTE_ARCH_X86_64')
+cflags += '-DENIC_RXTX_VEC'
 enic_avx2_lib = static_library('enic_avx2_lib',
 'enic_rxtx_vec_avx2.c',
 dependencies: [static_rte_ethdev, static_rte_bus_pci],
-- 
2.48.1

[RFC 06/10] net/fm10k: remove weak symbols

[David Marchand]

Rather than use weak symbols, expose stubs symbols when needed.

Signed-off-by: David Marchand 
---
 drivers/net/intel/fm10k/fm10k_ethdev.c | 20 +++-
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/net/intel/fm10k/fm10k_ethdev.c 
b/drivers/net/intel/fm10k/fm10k_ethdev.c
index 7b490bea17..633c501ce8 100644
--- a/drivers/net/intel/fm10k/fm10k_ethdev.c
+++ b/drivers/net/intel/fm10k/fm10k_ethdev.c
@@ -129,14 +129,15 @@ fm10k_mbx_unlock(struct fm10k_hw *hw)
rte_spinlock_unlock(FM10K_DEV_PRIVATE_TO_MBXLOCK(hw->back));
 }
 
-/* Stubs needed for linkage when vPMD is disabled */
-__rte_weak int
+#ifndef RTE_ARCH_X86
+/* Stubs for non x86 architectures. */
+int
 fm10k_rx_vec_condition_check(__rte_unused struct rte_eth_dev *dev)
 {
return -1;
 }
 
-__rte_weak uint16_t
+uint16_t
 fm10k_recv_pkts_vec(
__rte_unused void *rx_queue,
__rte_unused struct rte_mbuf **rx_pkts,
@@ -145,7 +146,7 @@ fm10k_recv_pkts_vec(
return 0;
 }
 
-__rte_weak uint16_t
+uint16_t
 fm10k_recv_scattered_pkts_vec(
__rte_unused void *rx_queue,
__rte_unused struct rte_mbuf **rx_pkts,
@@ -154,39 +155,40 @@ fm10k_recv_scattered_pkts_vec(
return 0;
 }
 
-__rte_weak int
+int
 fm10k_rxq_vec_setup(__rte_unused struct fm10k_rx_queue *rxq)
 
 {
return -1;
 }
 
-__rte_weak void
+void
 fm10k_rx_queue_release_mbufs_vec(
__rte_unused struct fm10k_rx_queue *rxq)
 {
return;
 }
 
-__rte_weak void
+void
 fm10k_txq_vec_setup(__rte_unused struct fm10k_tx_queue *txq)
 {
return;
 }
 
-__rte_weak int
+int
 fm10k_tx_vec_condition_check(__rte_unused struct fm10k_tx_queue *txq)
 {
return -1;
 }
 
-__rte_weak uint16_t
+uint16_t
 fm10k_xmit_fixed_burst_vec(__rte_unused void *tx_queue,
   __rte_unused struct rte_mbuf **tx_pkts,
   __rte_unused uint16_t nb_pkts)
 {
return 0;
 }
+#endif /* RTE_ARCH_X86 */
 
 /*
  * reset queue to initial state, allocate software buffers used when starting
-- 
2.48.1

[RFC 07/10] net/nfp: remove weak symbols

[David Marchand]

Rather than use weak symbols, link stubs code when needed.

Signed-off-by: David Marchand 
---
 drivers/net/nfp/meson.build  | 7 +--
 drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c | 2 +-
 drivers/net/nfp/nfp_rxtx_vec_stub.c  | 4 ++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build
index 4052846dc2..39762bd45a 100644
--- a/drivers/net/nfp/meson.build
+++ b/drivers/net/nfp/meson.build
@@ -17,7 +17,6 @@ sources = files(
 'flower/nfp_flower_service.c',
 'nfd3/nfp_nfd3_dp.c',
 'nfdk/nfp_nfdk_dp.c',
-'nfdk/nfp_nfdk_vec_stub.c',
 'nfpcore/nfp_cppcore.c',
 'nfpcore/nfp_crc.c',
 'nfpcore/nfp_elf.c',
@@ -45,7 +44,6 @@ sources = files(
 'nfp_net_flow.c',
 'nfp_net_meta.c',
 'nfp_rxtx.c',
-'nfp_rxtx_vec_stub.c',
 'nfp_service.c',
 )
 
@@ -67,6 +65,11 @@ if arch_subdir == 'x86'
 )
 
 objs += nfp_avx2_lib.extract_all_objects(recursive: true)
+else
+sources += files(
+'nfp_rxtx_vec_stub.c',
+'nfdk/nfp_nfdk_vec_stub.c',
+)
 endif
 
 deps += ['hash', 'security', 'common_nfp']
diff --git a/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c 
b/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
index 146ec21d51..4f905bce6b 100644
--- a/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
+++ b/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
@@ -5,7 +5,7 @@
 
 #include "nfp_nfdk_vec.h"
 
-uint16_t __rte_weak
+uint16_t
 nfp_net_nfdk_vec_avx2_xmit_pkts(__rte_unused void *tx_queue,
__rte_unused struct rte_mbuf **tx_pkts,
__rte_unused uint16_t nb_pkts)
diff --git a/drivers/net/nfp/nfp_rxtx_vec_stub.c 
b/drivers/net/nfp/nfp_rxtx_vec_stub.c
index c480f61ef0..201965afbe 100644
--- a/drivers/net/nfp/nfp_rxtx_vec_stub.c
+++ b/drivers/net/nfp/nfp_rxtx_vec_stub.c
@@ -10,13 +10,13 @@
 
 #include "nfp_rxtx_vec.h"
 
-bool __rte_weak
+bool
 nfp_net_get_avx2_supported(void)
 {
return false;
 }
 
-uint16_t __rte_weak
+uint16_t
 nfp_net_vec_avx2_recv_pkts(__rte_unused void *rx_queue,
__rte_unused struct rte_mbuf **rx_pkts,
__rte_unused uint16_t nb_pkts)
-- 
2.48.1

[RFC 01/10] bus/auxiliary: remove weak symbols

[David Marchand]

Rather than use weak symbols, expose stubs symbols when needed.

Signed-off-by: David Marchand 
---
 drivers/bus/auxiliary/auxiliary_common.c | 6 --
 drivers/bus/auxiliary/meson.build| 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/auxiliary/auxiliary_common.c 
b/drivers/bus/auxiliary/auxiliary_common.c
index e6cbc4d356..b444eb43ef 100644
--- a/drivers/bus/auxiliary/auxiliary_common.c
+++ b/drivers/bus/auxiliary/auxiliary_common.c
@@ -36,12 +36,13 @@ auxiliary_devargs_lookup(const char *name)
return NULL;
 }
 
+#ifndef AUXILIARY_OS_SUPPORTED
 /*
  * Test whether the auxiliary device exist.
  *
  * Stub for OS not supporting auxiliary bus.
  */
-__rte_weak bool
+bool
 auxiliary_dev_exists(const char *name)
 {
RTE_SET_USED(name);
@@ -53,11 +54,12 @@ auxiliary_dev_exists(const char *name)
  *
  * Stub for OS not supporting auxiliary bus.
  */
-__rte_weak int
+int
 auxiliary_scan(void)
 {
return 0;
 }
+#endif /* AUXILIARY_OS_SUPPORTED */
 
 /*
  * Update a device's devargs being scanned.
diff --git a/drivers/bus/auxiliary/meson.build 
b/drivers/bus/auxiliary/meson.build
index 10468fd130..38d2f05d4b 100644
--- a/drivers/bus/auxiliary/meson.build
+++ b/drivers/bus/auxiliary/meson.build
@@ -7,6 +7,7 @@ sources = files(
 'auxiliary_params.c',
 )
 if is_linux
+cflags += '-DAUXILIARY_OS_SUPPORTED'
 sources += files(
 'linux/auxiliary.c',
 )
-- 
2.48.1

Re: [PATCH v8 2/2] net/af_xdp: Refactor af_xdp_tx_zc

[Maryam Tahhan]

>
> 
>

@@ -559,51 +587,30 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
> mbuf = bufs[i];
>
> if (mbuf->pool == umem->mb_pool) {
> -   if (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx))
> {
> + if (!(desc = reserve_and_fill(txq, mbuf, umem, NULL))) {
> kick_tx(txq, cq);
> -   if (!xsk_ring_prod__reserve(&txq->tx, 1,
> -   &idx_tx))
> +   desc = reserve_and_fill(txq, mbuf, umem,
> NULL);
> +   if (!desc)
> goto out;
> }
> -   desc = xsk_ring_prod__tx_desc(&txq->tx, idx_tx);
> -   desc->len = mbuf->pkt_len;
> -   addr = (uint64_t)mbuf - (uint64_t)umem->buffer -
> -   umem->mb_pool->header_size;
> -   offset = rte_pktmbuf_mtod(mbuf, uint64_t) -
> -   (uint64_t)mbuf +
> -   umem->mb_pool->header_size;
> -   offset = offset << XSK_UNALIGNED_BUF_OFFSET_SHIFT;
> -   desc->addr = addr | offset;
> +
> tx_bytes += desc->len;
> count++;
> } else {
> -   struct rte_mbuf *local_mbuf =
> -   rte_pktmbuf_alloc(umem->mb_pool);
> -   void *pkt;
> -
> -   if (local_mbuf == NULL)
> +   if (!(local_mbuf =
> rte_pktmbuf_alloc(umem->mb_pool)))
> goto out;
>
> -   if (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx))
> {
> +   desc = reserve_and_fill(txq, local_mbuf, umem,
> &pkt);
> +   if (!desc) {
> rte_pktmbuf_free(local_mbuf);
> goto out;
> }
>
> -   desc = xsk_ring_prod__tx_desc(&txq->tx, idx_tx);
> -   desc->len = mbuf->pkt_len;
> -
> -   addr = (uint64_t)local_mbuf -
> (uint64_t)umem->buffer -
> -   umem->mb_pool->header_size;
> -   offset = rte_pktmbuf_mtod(local_mbuf, uint64_t) -
> -   (uint64_t)local_mbuf +
> -   umem->mb_pool->header_size;
> -   pkt = xsk_umem__get_data(umem->buffer, addr +
> offset);
> -   offset = offset << XSK_UNALIGNED_BUF_OFFSET_SHIFT;
> -   desc->addr = addr | offset;
> +   desc->len = local_mbuf->pkt_len;
>

Sorry if my remarks were confusing, it was just missing from the previous
patch and it needs to be:
desc->len = mbuf->pkt_len;

We need to keep this the same as the original code. This is a scenario
where we need to copy the data from an mbuf that isn't in from the pool of
buffers allocated for the umem. So the desc->len needs to be set to that of
the (non umem) mbuf.

The other changes look good. Nearly there,

Thanks again

Re: [PATCH v8 2/2] net/af_xdp: Refactor af_xdp_tx_zc

[Maryam Tahhan]

On 06/02/2025 21:42, Stephen Hemminger wrote:

On Thu,  6 Feb 2025 21:46:45 +0100
Ariel Otilibili wrote:

  
+static inline struct xdp_desc *

+reserve_and_fill(struct pkt_tx_queue *txq, struct rte_mbuf *mbuf,
+struct xsk_umem_info *umem, void **pkt_ptr)
+{
+   struct xdp_desc *desc = NULL;
+   uint64_t addr, offset;
+   uint32_t idx_tx;
+
+   if (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx))
+   goto out;
+
+   desc = xsk_ring_prod__tx_desc(&txq->tx, idx_tx);
+   desc->len = mbuf->pkt_len;
+
+   addr = (uint64_t)mbuf - (uint64_t)umem->buffer
+   - umem->mb_pool->header_size;

addr (and the cast of mbuf) should probably be uintptr_t since the
intent is to do calculations with pointers.


I think it's ok as we would end up casting it anyway for the `struct xdp_desc`

/* Rx/Tx descriptor */
struct xdp_desc {
    __u64 addr;
    __u32 len;
    __u32 options;
};

Re: [PATCH v2 1/3] bbdev: add trace point

[Maxime Coquelin]

On 1/23/25 11:55 PM, Nicolas Chautru wrote:

Adds trace points for rte_bbdev.

Signed-off-by: Nicolas Chautru 
---
  lib/bbdev/bbdev_trace.h| 69 ++
  lib/bbdev/bbdev_trace_points.c | 27 +
  lib/bbdev/meson.build  |  6 ++-
  lib/bbdev/rte_bbdev.c  | 17 +
  lib/bbdev/rte_bbdev.h  | 50 +---
  lib/bbdev/rte_bbdev_trace_fp.h | 41 
  lib/bbdev/version.map  |  4 ++
  7 files changed, 206 insertions(+), 8 deletions(-)
  create mode 100644 lib/bbdev/bbdev_trace.h
  create mode 100644 lib/bbdev/bbdev_trace_points.c
  create mode 100644 lib/bbdev/rte_bbdev_trace_fp.h

diff --git a/lib/bbdev/bbdev_trace.h b/lib/bbdev/bbdev_trace.h
new file mode 100644
index 00..7256d6b703
--- /dev/null
+++ b/lib/bbdev/bbdev_trace.h
@@ -0,0 +1,69 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2025 Intel Corporation
+ */
+
+#ifndef BBDEV_TRACE_H
+#define BBDEV_TRACE_H
+
+/**
+ * @file
+ *
+ * API for bbdev trace support
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include 
+
+#include "rte_bbdev.h"
+
+RTE_TRACE_POINT(
+   rte_bbdev_trace_setup_queues,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint16_t num_queues, int 
socket_id),
+   rte_trace_point_emit_u8(dev_id);
+   rte_trace_point_emit_u16(num_queues);
+   rte_trace_point_emit_int(socket_id);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_queue_configure,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint16_t queue_id, const char 
*op_str, uint8_t pri),
+   rte_trace_point_emit_u8(dev_id);
+   rte_trace_point_emit_u16(queue_id);
+   rte_trace_point_emit_string(op_str);
+   rte_trace_point_emit_u8(pri);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_start,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id),
+   rte_trace_point_emit_u8(dev_id);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_stop,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id),
+   rte_trace_point_emit_u8(dev_id);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_close,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id),
+   rte_trace_point_emit_u8(dev_id);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_queue_start,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint16_t queue_id),
+   rte_trace_point_emit_u8(dev_id);
+   rte_trace_point_emit_u16(queue_id);
+)
+RTE_TRACE_POINT(
+   rte_bbdev_trace_queue_stop,
+   RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint16_t queue_id),
+   rte_trace_point_emit_u8(dev_id);
+   rte_trace_point_emit_u16(queue_id);
+)
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* BBDEV_TRACE_H */
diff --git a/lib/bbdev/bbdev_trace_points.c b/lib/bbdev/bbdev_trace_points.c
new file mode 100644
index 00..6f90e2aa65
--- /dev/null
+++ b/lib/bbdev/bbdev_trace_points.c
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2025 Intel Corporation
+ */
+
+#include 
+
+#include "bbdev_trace.h"
+
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_setup_queues,
+   lib.bbdev.queue.setup)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_queue_configure,
+   lib.bbdev.queue.configure)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_start,
+   lib.bbdev.start)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_stop,
+   lib.bbdev.stop)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_close,
+   lib.bbdev.close)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_queue_start,
+   lib.bbdev.queue.start)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_queue_stop,
+   lib.bbdev.queue.stop)
+
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_enqueue,
+   lib.bbdev.enq)
+RTE_TRACE_POINT_REGISTER(rte_bbdev_trace_dequeue,
+   lib.bbdev.deq)
diff --git a/lib/bbdev/meson.build b/lib/bbdev/meson.build
index 07685e7578..d8b95a400e 100644
--- a/lib/bbdev/meson.build
+++ b/lib/bbdev/meson.build
@@ -7,8 +7,10 @@ if is_windows
  subdir_done()
  endif
  
-sources = files('rte_bbdev.c')

+sources = files('rte_bbdev.c',
+'bbdev_trace_points.c')
  headers = files('rte_bbdev.h',
  'rte_bbdev_pmd.h',
-'rte_bbdev_op.h')
+'rte_bbdev_op.h',
+'rte_bbdev_trace_fp.h')
  deps += ['mbuf']
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index bd32da79b0..d7901cd29d 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -20,6 +20,7 @@
  #include "rte_bbdev_op.h"
  #include "rte_bbdev.h"
  #include "rte_bbdev_pmd.h"
+#include "bbdev_trace.h"
  
  #define DEV_NAME "BBDEV"
  
@@ -321,6 +322,8 @@ rte_bbdev_setup_queues(uint16_t dev_id, uint16_t num_queues, int socket_id)
  
  	VALID_DEV_OPS_OR_RET_ERR(dev, dev_id);
  
+	rte_bbdev_trace_setup_queues(dev_id, num_queues, socket_id);

+
if (dev->data->started) {
rte_bbdev_log(ERR,
"Device %u cannot be configured when started",
@@ -436,6 +439,10 @@ int
  rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,
const struct rte_bbdev_queue_conf *conf)
  {
+
+

Re: [PATCH 0/5] use portable macro for weak linking

[David Marchand]

On Tue, Dec 24, 2024 at 4:06 AM Andre Muezerie
 wrote:
>
> MSVC uses pragmas to indicate weak linking, so the old __rte_weak
> attribute needs to made into a macro so that the same syntax can
> be used for MSVC and other compilers like gcc.
>
> Andre Muezerie (5):
>   lib/eal: add portable macro for weak linking
>   app/test-compress-perf: use portable macro for weak linking
>   drivers/bus: use portable macro for weak linking
>   drivers/common: use portable macro for weak linking
>   drivers/net: use portable macro for weak linking

I am not a fan of the weak linking stuff in the first place.
Reading the code with __rte_weak, I always wonder which symbol is used when...
I prefer explicit linking and no duplicate symbols end up in the binaries.

I posted a RFC, can you have a look?
https://inbox.dpdk.org/dev/20250207083252.3131588-1-david.march...@redhat.com/


-- 
David Marchand

RE: [RFC 07/10] net/nfp: remove weak symbols

[Chaoyong He]

Seems ok for me.

Acked-by: Chaoyong He 

> -Original Message-
> From: David Marchand 
> Sent: Friday, February 7, 2025 4:33 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; bruce.richard...@intel.com;
> andre...@linux.microsoft.com; Chaoyong He 
> Subject: [RFC 07/10] net/nfp: remove weak symbols
> 
> Rather than use weak symbols, link stubs code when needed.
> 
> Signed-off-by: David Marchand 
> ---
>  drivers/net/nfp/meson.build  | 7 +--
>  drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c | 2 +-
>  drivers/net/nfp/nfp_rxtx_vec_stub.c  | 4 ++--
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build index
> 4052846dc2..39762bd45a 100644
> --- a/drivers/net/nfp/meson.build
> +++ b/drivers/net/nfp/meson.build
> @@ -17,7 +17,6 @@ sources = files(
>  'flower/nfp_flower_service.c',
>  'nfd3/nfp_nfd3_dp.c',
>  'nfdk/nfp_nfdk_dp.c',
> -'nfdk/nfp_nfdk_vec_stub.c',
>  'nfpcore/nfp_cppcore.c',
>  'nfpcore/nfp_crc.c',
>  'nfpcore/nfp_elf.c',
> @@ -45,7 +44,6 @@ sources = files(
>  'nfp_net_flow.c',
>  'nfp_net_meta.c',
>  'nfp_rxtx.c',
> -'nfp_rxtx_vec_stub.c',
>  'nfp_service.c',
>  )
> 
> @@ -67,6 +65,11 @@ if arch_subdir == 'x86'
>  )
> 
>  objs += nfp_avx2_lib.extract_all_objects(recursive: true)
> +else
> +sources += files(
> +'nfp_rxtx_vec_stub.c',
> +'nfdk/nfp_nfdk_vec_stub.c',
> +)
>  endif
> 
>  deps += ['hash', 'security', 'common_nfp'] diff --git
> a/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
> b/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
> index 146ec21d51..4f905bce6b 100644
> --- a/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
> +++ b/drivers/net/nfp/nfdk/nfp_nfdk_vec_stub.c
> @@ -5,7 +5,7 @@
> 
>  #include "nfp_nfdk_vec.h"
> 
> -uint16_t __rte_weak
> +uint16_t
>  nfp_net_nfdk_vec_avx2_xmit_pkts(__rte_unused void *tx_queue,
>   __rte_unused struct rte_mbuf **tx_pkts,
>   __rte_unused uint16_t nb_pkts)
> diff --git a/drivers/net/nfp/nfp_rxtx_vec_stub.c
> b/drivers/net/nfp/nfp_rxtx_vec_stub.c
> index c480f61ef0..201965afbe 100644
> --- a/drivers/net/nfp/nfp_rxtx_vec_stub.c
> +++ b/drivers/net/nfp/nfp_rxtx_vec_stub.c
> @@ -10,13 +10,13 @@
> 
>  #include "nfp_rxtx_vec.h"
> 
> -bool __rte_weak
> +bool
>  nfp_net_get_avx2_supported(void)
>  {
>   return false;
>  }
> 
> -uint16_t __rte_weak
> +uint16_t
>  nfp_net_vec_avx2_recv_pkts(__rte_unused void *rx_queue,
>   __rte_unused struct rte_mbuf **rx_pkts,
>   __rte_unused uint16_t nb_pkts)
> --
> 2.48.1

Re: [PATCH v2 3/3] trace: fix undefined behavior in register

[David Marchand]

Hello Jerin, Sunil,

On Thu, Jan 30, 2025 at 3:59 PM David Marchand
 wrote:
>
> Registering a tracepoint handler was resulting so far in undefined
> behavior at runtime.
>
> The RTE_TRACE_POINT_REGISTER() macro was casting the tracepoint handler
> (which expects arguments) to a void (*)(void).
> At runtime, calling this handler while registering resulted in
> reading the current stack with no relation to this function prototype.
>
> Instead, declare an additional inline _register() handler for each
> tracepoint and make sure that the emitting macros in
> rte_trace_point_register.h only work on arguments name and type.
>
> The original tracepoint handler prototype is adjusted by adding a
> __rte_unused for each argument (since emitting macros do nothing
> with them).
> This last part introduces an implementation limit of 15 arguments.
>
> With this change in place, the workaround in dmadev tracepoints can be
> removed.
>
> Signed-off-by: David Marchand 

Can I have your opinion and review on this patch?

Thanks.


-- 
David Marchand

Re: [PATCH v3] test: improve resiliency of malloc autotest

[Bruce Richardson]

On Fri, Feb 07, 2025 at 03:44:56PM +0800, fengchengwen wrote:
> On 2025/2/6 19:40, Bruce Richardson wrote:
> > On Fri, Jan 24, 2025 at 03:18:11PM +0800, fengchengwen wrote:
> >> The new impl don't support re-test, how about add a wrap:
> >> 1. rename test_multi_alloc_statistics with do_test_multi_alloc_statistics, 
> >> and make it take socket as parameter
> >> 2. create a new function test_multi_alloc_statistics {
> >> // prepare a new malloc heap
> >> ret = do_test_multi_alloc_statistics(socket);
> >> // free the heap
> >> return ret;
> >> }
> >>
> > 
> > Can you clarify the issues being seen on re-test? I have just run
> > malloc_autotest multiple times within the same dpdk-test instance and not
> > seen any issues.
> 
> If the middle logic fail, for example:
> 
>   if ((post_stats.heap_totalsz_bytes != pre_stats.heap_totalsz_bytes) ||
>   (post_stats.heap_freesz_bytes != 
> pre_stats.heap_freesz_bytes) ||
>   (post_stats.heap_allocsz_bytes != 
> pre_stats.heap_allocsz_bytes) ||
>   (post_stats.alloc_count != pre_stats.alloc_count) ||
>   (post_stats.free_count != pre_stats.free_count)) {
>   printf("Malloc statistics are incorrect - freed alloc\n");
>   return -1;
>   }
> 
> If the above if branch taken, then retest, the 
> rte_malloc_heap_create(__func__) will
> failed because already exist the heap.
> 
Ok, retest on failure is broken. Got it. Will rework.

Re: [RFC 06/10] net/fm10k: remove weak symbols

[Bruce Richardson]

On Fri, Feb 07, 2025 at 09:32:46AM +0100, David Marchand wrote:
> Rather than use weak symbols, expose stubs symbols when needed.
> 
> Signed-off-by: David Marchand 
> ---
>  drivers/net/intel/fm10k/fm10k_ethdev.c | 20 +++-
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
Acked-by: Bruce Richardson 

Re: [PATCH v2 3/3] baseband/acc: add internal logging

[Maxime Coquelin]

Hi Nicolas,

On 1/24/25 7:00 PM, Stephen Hemminger wrote:

On Fri, 24 Jan 2025 17:52:43 +
"Chautru, Nicolas"  wrote:


Hi Stephen,

The commit message may be misleading, the logging interface doesn't change 
here. Note also that I reuse existing trace point framework for some of the 
error logging when relevant (see previous commit).
Here the scope for that buffer is more limited, not a new logging method really 
(the commit message is misleading).
The queue_ops_dump() already provides api to dump device specific information 
related to queue into file (logging in real time is not an option) based on 
information already in PMD memory.
This new buffer is purely there to add storage for the string out of 
rte_bbdev_ops_param_string() for failed operation on that queue, so that extend 
that capture as this info is not stored by PMD.
The name of the buffer could be renamed probably, or I could store copy of the 
actual operation instead of the string in case that makes a difference for you.

I guess it would possible to move this to trace point but I thought it would be 
quite convoluted. That information would fits nicely in the queue dump capture, 
and this would require adding trace point for each operation type (I don't 
believe it can manage arbitrary string) and would be a bit of an unconventional 
use of trace point.

Any thought?


I think the introduction of trace points in patch 2 is a good addition,
and could be extended further to not just emit a simple string but also
the necessary values to enable debugging (basically what you write in
the buffers).

It would have the advantage of having the different traces to be
synchronized (bbdev and acc ones), and also would have less performance
impact.


Thanks
Nic



-Original Message-
From: Stephen Hemminger 
Sent: Thursday, January 23, 2025 3:24 PM
To: Chautru, Nicolas 
Cc: dev@dpdk.org; maxime.coque...@redhat.com;
hemant.agra...@nxp.com; Vargas, Hernan 
Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging

On Thu, 23 Jan 2025 14:55:19 -0800
Nicolas Chautru  wrote:
   

Adds internal buffer for more flexible logging.

Signed-off-by: Nicolas Chautru 


Inventing another device specific error log seems like a short sighted
concept.
Why doesn't existing DPDK logging work well enough?




My feedback is that why can't you just use DEBUG logging for this.


Or indeed could use the existing logging mechanism.





Thanks,
Maxime

Re: [PATCH v2 00/34] net/ntnic: bugfixes and refactoring

[Serhii Iliushyk]

On Wed,  5 Feb 2025 11:45:09 +0100
Serhii Iliushyk  wrote:

> This patch set addresses fixing issues in the ntnic PMD driver.
>
> Changes in this patch:
>
> The issues detected by the Coverity Scan tool.
> The problems that were detected by the internal tests.
> Fix for Bug 1622: ntnic: using signals and threads:
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fbugs.dpdk.org%2fshow_bug.cgi%3fid%3d1622&c=E,1,6udE5Jl1KN1y6YarjUq8xAU2C_RnMxvCsO4FC_7QGgRwCOMRCfX-0jEcl4wPapW-A2poKdj_W5XNKd_SMg4ohWp5E3FgSkpTr8VsSWWoOlne_dqw77o,&typo=1.
>   The handling of signals within the PMD driver was removed.
>   For manipulation with all threads dedicated EAL API
> (rte_thread_create_internal_control) is used.
>   Product by design requires usage of threads inside PMD driver.

Do any of these patches need to be backported to stable versions of DPDK?

Hi Stephen,

We do not need to backport these patches to the stable version.
Please keep them only for the latest DPDK.

Thanks,
Serhii

[DPDK/vhost/virtio Bug 1658] Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1658

Kevin Traynor (ktray...@redhat.com) changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||ktray...@redhat.com

--- Comment #1 from Kevin Traynor (ktray...@redhat.com) ---
Just to note looking at Qemu code and when bug and fix were committed, this
affects only Qemu versions between v4.2.0 and v5.1.0.

Closing as this is a Qemu bug and there is no action required for DPDK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [PATCH v5 1/2] common/idpf: enable AVX2 for single queue Rx

[Bruce Richardson]

On Mon, Feb 03, 2025 at 01:25:07PM +0530, Shaiq Wani wrote:
> In case some CPUs don't support AVX512. Enable AVX2 for them to
> get better per-core performance.
> 
> The single queue model processes all packets in order while
> the split queue model separates packet data and metadata into
> different queues for parallel processing and improved performance.
> 
> Signed-off-by: Shaiq Wani 
> ---
>  drivers/common/idpf/idpf_common_device.h|   1 +
>  drivers/common/idpf/idpf_common_rxtx.h  |   4 +
>  drivers/common/idpf/idpf_common_rxtx_avx2.c | 480 
>  drivers/common/idpf/meson.build |   7 +
>  drivers/common/idpf/version.map |   1 +
>  drivers/net/intel/idpf/idpf_rxtx.c  |  11 +
>  6 files changed, 504 insertions(+)
>  create mode 100644 drivers/common/idpf/idpf_common_rxtx_avx2.c
> 
Acked-by: Bruce Richardson 

Re: [PATCH v5 2/2] common/idpf: enable AVX2 for single queue Tx

[Bruce Richardson]

On Mon, Feb 03, 2025 at 01:25:08PM +0530, Shaiq Wani wrote:
> In case some CPUs don't support AVX512. Enable AVX2 for them to
> get better per-core performance.
> 
> The single queue model processes all packets in order while
> the split queue model separates packet data and metadata into
> different queues for parallel processing and improved performance.
> 
> Signed-off-by: Shaiq Wani 

Acked-by: Bruce Richardson 

See feedback inline below. Would it be possible for this release to rework
the driver to use the common functions from drivers/net/intel/common? If
not, can that be looked at for the next release?

/Bruce

> ---
>  doc/guides/nics/idpf.rst|   8 +-
>  doc/guides/rel_notes/release_25_03.rst  |   7 +
>  drivers/common/idpf/idpf_common_device.h|   1 +
>  drivers/common/idpf/idpf_common_rxtx.h  |   4 +
>  drivers/common/idpf/idpf_common_rxtx_avx2.c | 224 
>  drivers/common/idpf/version.map |   1 +
>  drivers/net/intel/idpf/idpf_rxtx.c  |  13 ++
>  7 files changed, 255 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/idpf.rst b/doc/guides/nics/idpf.rst
> index 0370989a07..90b651d193 100644
> --- a/doc/guides/nics/idpf.rst
> +++ b/doc/guides/nics/idpf.rst
> @@ -93,9 +93,11 @@ The paths are chosen based on 2 conditions:
>  
>  - ``CPU``
>  
> -  On the x86 platform, the driver checks if the CPU supports AVX512.
> -  If the CPU supports AVX512 and EAL argument ``--force-max-simd-bitwidth``
> -  is set to 512, AVX512 paths will be chosen.
> +  On the x86 platform, the driver checks if the CPU supports AVX instruction 
> set.
> +  If the CPU supports AVX512 and EAL argument --force-max-simd-bitwidth is 
> set to 512, AVX512 paths will be chosen
> +  else if --force-max-simd-bitwidth is set to 256, AVX2 paths will be chosen.
> +  Note that 256 is the default bitwidth if no specific value is provided.
> +
>  
>  - ``Offload features``
>  
> diff --git a/doc/guides/rel_notes/release_25_03.rst 
> b/doc/guides/rel_notes/release_25_03.rst
> index a88b04d958..905e8f363c 100644
> --- a/doc/guides/rel_notes/release_25_03.rst
> +++ b/doc/guides/rel_notes/release_25_03.rst
> @@ -76,6 +76,13 @@ New Features
>  
>* Added support for virtual function (VF).
>  
> +* **Added support of AVX2 instructions on IDPF.**
> +
> +   Support for AVX2 instructions in IDPF single queue RX and TX path
> +   added.The single queue model processes all packets in order within
> +   one RX queue, while the split queue model separates packet data and
> +   metadata into different queues for parallel processing and improved 
> performance.
> +
>  
>  Removed Items
>  -
> diff --git a/drivers/common/idpf/idpf_common_device.h 
> b/drivers/common/idpf/idpf_common_device.h
> index 734be1c88a..5f3e4a4fcf 100644
> --- a/drivers/common/idpf/idpf_common_device.h
> +++ b/drivers/common/idpf/idpf_common_device.h
> @@ -124,6 +124,7 @@ struct idpf_vport {
>   bool rx_vec_allowed;
>   bool tx_vec_allowed;
>   bool rx_use_avx2;
> + bool tx_use_avx2;
>   bool rx_use_avx512;
>   bool tx_use_avx512;
>  
> diff --git a/drivers/common/idpf/idpf_common_rxtx.h 
> b/drivers/common/idpf/idpf_common_rxtx.h
> index f50cf5ef46..e19e1878f3 100644
> --- a/drivers/common/idpf/idpf_common_rxtx.h
> +++ b/drivers/common/idpf/idpf_common_rxtx.h
> @@ -306,5 +306,9 @@ __rte_internal
>  uint16_t idpf_dp_singleq_recv_pkts_avx2(void *rx_queue,
>   struct rte_mbuf **rx_pkts,
>   uint16_t nb_pkts);
> +__rte_internal
> +uint16_t idpf_dp_singleq_xmit_pkts_avx2(void *tx_queue,
> + struct rte_mbuf **tx_pkts,
> + uint16_t nb_pkts);
>  
>  #endif /* _IDPF_COMMON_RXTX_H_ */
> diff --git a/drivers/common/idpf/idpf_common_rxtx_avx2.c 
> b/drivers/common/idpf/idpf_common_rxtx_avx2.c
> index 277b2a9469..7d292ff19e 100644
> --- a/drivers/common/idpf/idpf_common_rxtx_avx2.c
> +++ b/drivers/common/idpf/idpf_common_rxtx_avx2.c
> @@ -478,3 +478,227 @@ idpf_dp_singleq_recv_pkts_avx2(void *rx_queue, struct 
> rte_mbuf **rx_pkts, uint16
>  {
>   return _idpf_singleq_recv_raw_pkts_vec_avx2(rx_queue, rx_pkts, nb_pkts);
>  }
> +static __rte_always_inline void
> +idpf_tx_backlog_entry(struct idpf_tx_entry *txep,
> +  struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
> +{
> + int i;
> +
> + for (i = 0; i < (int)nb_pkts; ++i)
> + txep[i].mbuf = tx_pkts[i];
> +}

Can idpf driver switch to using ci_tx_entry (and ci_tx_entry_vec) from the
intel/common/tx.h header? Then we can drop this code and just use
ct_tx_backlog_entry and similar functions.

> +
> +static __rte_always_inline int
> +idpf_singleq_tx_free_bufs_vec(struct idpf_tx_queue *txq)
> +{
> + struct idpf_tx_entry *txep;
> + uint32_t n;
> + uint32_t i;
> + int nb_free = 0;
> + struct rte_mbuf *m, *free[txq->rs_thresh];
> +
> + 

[DPDK/other Bug 1656] AVX-512 support disabled

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1656

Kevin Traynor (ktray...@redhat.com) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ktray...@redhat.com
 Resolution|--- |WONTFIX

--- Comment #1 from Kevin Traynor (ktray...@redhat.com) ---
Thanks for logging this issue, it is good to have a record of it. 18.11 is no
longer supported [1], so any issues on it will not be fixed.

[1] http://core.dpdk.org/roadmap/#stable

-- 
You are receiving this mail because:
You are the assignee for the bug.

RE: [EXTERNAL] Re: [PATCH v2 3/3] trace: fix undefined behavior in register

[Sunil Kumar Kori]

Hi David,

I will look into this at earliest and provide feedback.

Thanks

From: David Marchand 
Sent: Friday, February 7, 2025 2:20 PM
To: Jerin Jacob ; Sunil Kumar Kori 
Cc: dev@dpdk.org; Chengwen Feng ; Kevin Laatz 
; Bruce Richardson ; Tyler 
Retzlaff ; Andre Muezerie 
; Thomas Monjalon ; Stephen 
Hemminger 
Subject: [EXTERNAL] Re: [PATCH v2 3/3] trace: fix undefined behavior in register

Hello Jerin, Sunil, On Thu, Jan 30, 2025 at 3: 59 PM David Marchand  wrote: > > Registering a tracepoint handler was 
resulting so far in undefined > behavior at runtime. > > The 
RTE_TRACE_POINT_REGISTER()


Hello Jerin, Sunil,



On Thu, Jan 30, 2025 at 3:59 PM David Marchand

mailto:david.march...@redhat.com>> wrote:

>

> Registering a tracepoint handler was resulting so far in undefined

> behavior at runtime.

>

> The RTE_TRACE_POINT_REGISTER() macro was casting the tracepoint handler

> (which expects arguments) to a void (*)(void).

> At runtime, calling this handler while registering resulted in

> reading the current stack with no relation to this function prototype.

>

> Instead, declare an additional inline _register() handler for each

> tracepoint and make sure that the emitting macros in

> rte_trace_point_register.h only work on arguments name and type.

>

> The original tracepoint handler prototype is adjusted by adding a

> __rte_unused for each argument (since emitting macros do nothing

> with them).

> This last part introduces an implementation limit of 15 arguments.

>

> With this change in place, the workaround in dmadev tracepoints can be

> removed.

>

> Signed-off-by: David Marchand 
> mailto:david.march...@redhat.com>>



Can I have your opinion and review on this patch?



Thanks.





--

David Marchand

[PATCH] common/qat: fix incorrect size in the parser

[Arkadiusz Kusztal]

The function `strlen` returns the size of the string without a terminating
null-character, therefore a request to allocate memory space for a parsed
argument is too small by 1.

Fixes: 99ab2806687b ("common/qat: isolate parser arguments configuration")
Cc: sta...@dpdk.org

Signed-off-by: Arkadiusz Kusztal 
---
 drivers/common/qat/qat_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index bca88fd9bd..746d8a28bb 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -226,7 +226,7 @@ qat_dev_parse_command_line(struct qat_pci_device *qat_dev,
if (!devargs)
return 0;
 
-   len = strlen(devargs->drv_str);
+   len = strlen(devargs->drv_str) + 1;
if (len == 0)
return 0;
/* Allocate per-device command line */
-- 
2.34.1

Re: [PATCH v9 2/2] net/af_xdp: Refactor af_xdp_tx_zc

[Maryam Tahhan]

On 07/02/2025 10:45, Ariel Otilibili wrote:

Both legs of the loop share the same logic: the common parts are about
reserving and filling both address and length into the description.

This is moved into reserve_and_fill().

Bugzilla ID: 1440
Suggested-by: Maryam Tahhan
Signed-off-by: Ariel Otilibili


Acked-by: Maryam Tahhan

Re: [PATCH v1 00/24] Fixes for igc and e1000

[Bruce Richardson]

On Thu, Feb 06, 2025 at 04:08:23PM +, Anatoly Burakov wrote:
> This patchset is taken out of recent e1000/igc driver update [1].
> 
> [1] https://inbox.dpdk.org/dev/cover.1738681725.git.anatoly.bura...@intel.com/
> 
> Aleksandr Loktionov (2):
>   net/igc/base: fix MAC addr hash bit shift
>   net/e1000/base: fix MAC addr hash bit shift
> 
> Amir Avivi (2):
>   net/igc/base: fix iterator type
>   net/e1000/base: fix iterator type
> 
> Anatoly Burakov (1):
>   net/e1000/base: correct mPHY access logic
> 
> Barbara Skobiej (3):
>   net/igc/base: fix data type in MAC hash
>   net/e1000/base: fix data type in MAC hash
>   net/e1000/base: fix reset for 82580
> 
> Carolyn Wyborny (1):
>   net/e1000/base: skip MANC check for 82575
> 
> Dima Ruinskiy (5):
>   net/igc/base: fix deadlock in i225
>   net/igc/base: fix infinite loop
>   net/igc/base: fix typo in LTR calculation
>   net/igc/base: fix unused value
>   net/e1000/base: fix unchecked return
> 
> Jakub Buchocki (1):
>   net/e1000/base: fix uninitialized variable usage
> 
> Pawel Malinowski (2):
>   net/igc/base: fix semaphore timeout value
>   net/e1000/base: fix semaphore timeout value
> 
> Przemyslaw Ciesielski (4):
>   net/igc/base: fix bitwise op type mismatch
>   net/igc/base: fix static analysis warning
>   net/e1000/base: fix static analysis warning
>   net/e1000/base: fix static analysis warning
> 
> Sasha Neftin (3):
>   net/igc/base: increase PHY power up delay
>   net/igc/base: reset loop variable
>   net/igc/base: fix LTR for i225
> 
>  .mailmap  |  3 +++
>  .../net/intel/e1000/base/e1000_80003es2lan.c  |  2 +-
>  drivers/net/intel/e1000/base/e1000_82575.c|  5 ++--
>  drivers/net/intel/e1000/base/e1000_base.c |  3 ++-
>  drivers/net/intel/e1000/base/e1000_defines.h  |  1 +
>  drivers/net/intel/e1000/base/e1000_ich8lan.c  |  2 ++
>  drivers/net/intel/e1000/base/e1000_mac.c  | 12 +
>  drivers/net/intel/e1000/base/e1000_nvm.c  |  4 +--
>  drivers/net/intel/e1000/base/e1000_phy.c  | 25 +--
>  drivers/net/intel/e1000/base/e1000_vf.c   | 12 +
>  drivers/net/intel/igc/base/igc_defines.h  |  1 +
>  drivers/net/intel/igc/base/igc_i225.c | 24 --
>  drivers/net/intel/igc/base/igc_mac.c  | 10 +---
>  drivers/net/intel/igc/base/igc_nvm.c  |  4 +--
>  drivers/net/intel/igc/base/igc_phy.c  |  8 +++---
>  15 files changed, 68 insertions(+), 48 deletions(-)
> 

Patches all LGTM. I see a couple of fixes have to be applied to both e1000
and igc - which is another reason why we are deduplicating and merging
those drivers - but agree with the decision to keep the fixes in separate
patches here for easier reviewing/backporting/cherry-picking.

Series-acked-by: Bruce Richardson 

Series applied to dpdk-next-net-intel

Thanks,
/Bruce

Re: [PATCH v2 0/3] Improve lock annotations

[David Marchand]

On Thu, Dec 12, 2024 at 5:02 PM David Marchand
 wrote:
>
> A recent bug (see 22aa9a9c7099 ("vhost: fix deadlock in Rx async path"))
> made more visible a gap in the clang thread safety annotations that
> DPDK uses: no distinction is made between releasing a read lock and
> releasing a write lock.
>
> Clang 3.6 and later offers improved thread safety checks.
>
> Marking objects as "lockable" has evolved into flagging some named
> "capability". clang reports the capability name when an error is
> reported (making this report a bit easier to understand).
>
> For example, a spinlock is now flagged as:
> typedef struct __rte_capability("spinlock") {
>   volatile RTE_ATOMIC(int) locked;
> } rte_spinlock_t;
>
>
> For "exclusive" locking (spinlocks / write locks), the conversion is:
> - exclusive_lock_function -> acquire_capability
> - exclusive_trylock_function -> try_acquire_capability
> - unlock_function -> release_capability
> ...
>
> For "shared" locking (read locks):
> - shared_lock_function -> acquire_shared_capability
> - shared_trylock_function -> try_acquire_shared_capability
> - unlock_function -> release_shared_capability
> ...
>
>
> This series proposes to use those annotations (sticking to the
> convention of simply prefixing the compiler attributes with __rte_).
> The existing "old" annotations macros are left in place in case users
> started to rely on them.
>
> Note: DPDK requirements state that clang version must be >= 3.6
> (following use of C11 standard).

Series applied, thanks.


-- 
David Marchand

[DPDK/testpmd Bug 1651] Linux kernel 4.10.0 iommu attribute read error

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1651

Kevin Traynor (ktray...@redhat.com) changed:

   What|Removed |Added

 CC||ktray...@redhat.com
 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Kevin Traynor (ktray...@redhat.com) ---
This issue originates to DPDK v18.05 and Linux Kernel 4.10. Neither of these
are still maintained so will close. Thank you for logging the issue.

http://core.dpdk.org/roadmap/#stable
https://www.kernel.org/releases.html

-- 
You are receiving this mail because:
You are the assignee for the bug.