On Tue, Dec 24, 2024 at 4:06 AM Andre Muezerie <andre...@linux.microsoft.com> wrote: > > MSVC uses pragmas to indicate weak linking, so the old __rte_weak > attribute needs to made into a macro so that the same syntax can > be used for MSVC and other compilers like gcc. > > Andre Muezerie (5): > lib/eal: add portable macro for weak linking > app/test-compress-perf: use portable macro for weak linking > drivers/bus: use portable macro for weak linking > drivers/common: use portable macro for weak linking > drivers/net: use portable macro for weak linking
I am not a fan of the weak linking stuff in the first place. Reading the code with __rte_weak, I always wonder which symbol is used when... I prefer explicit linking and no duplicate symbols end up in the binaries. I posted a RFC, can you have a look? https://inbox.dpdk.org/dev/20250207083252.3131588-1-david.march...@redhat.com/ -- David Marchand
