Re: [PATCH] net/ice: fix tso tunnel setting to not take effect

[David Marchand]

On Fri, Nov 24, 2023 at 8:27 AM Kaiwen Deng  wrote:
>
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")

This Fixes: tag is wrong.

> Cc: sta...@dpdk.org
>
> Signed-off-by: Kaiwen Deng 
> ---
>  drivers/net/ice/ice_ethdev.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct 
> rte_eth_dev_info *dev_info)
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> -   RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> +   RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> +   RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> +   RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> +   RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> +   RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
> dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
> }

Is this tunnel + tso feature supported with vector drivers?

Is there some documentation to update to reflect this addition?


-- 
David Marchand

Re: [PATCH 3/5] doc: fix some ordered lists

[David Marchand]

On Thu, Nov 23, 2023 at 6:22 PM Dariusz Sosnowski  wrote:
>
> Hi,
>
> > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> > 45379960f0..39a8c5d7b4 100644
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > @@ -2326,19 +2326,18 @@ This command performs:
> >
> >  #. Call the regular ``port attach`` function with updated identifier.
> >
> > -For example, to attach a port whose PCI address is ``:0a:00.0`` -and 
> > its
> > socket path is ``/var/run/import_ipc_socket``:
> > +   For example, to attach a port whose PCI address is ``:0a:00.0``
> > +   and its socket path is ``/var/run/import_ipc_socket``:
> >
> > -.. code-block:: console
> > -
> > -   testpmd> mlx5 port attach :0a:00.0
> > socket=/var/run/import_ipc_socket
> > -   testpmd: MLX5 socket path is /var/run/import_ipc_socket
> > -   testpmd: Attach port with extra devargs
> > :0a:00.0,cmd_fd=40,pd_handle=1
> > -   Attaching a new port...
> > -   EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: :0a:00.0 (socket
> > 0)
> > -   Port 0 is attached. Now total ports is 1
> > -   Done
> > +   .. code-block:: console
> >
> > +  testpmd> mlx5 port attach :0a:00.0
> > socket=/var/run/import_ipc_socket
> > +  testpmd: MLX5 socket path is /var/run/import_ipc_socket
> > +  testpmd: Attach port with extra devargs
> > :0a:00.0,cmd_fd=40,pd_handle=1
> > +  Attaching a new port...
> > +  EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: :0a:00.0 
> > (socket
> > 0)
> > +  Port 0 is attached. Now total ports is 1
> > +  Done
> >
> >  port map external Rx queue
> >  ~~
> The preceding list explains what "mlx5 port attach" command does and the 
> following section provides an example of usage.
> I don't think this section should be a part of that list.

Re-reading this section, I agree.
I will drop this hunk.

Thanks Dariusz.


-- 
David Marchand

RE: [PATCH 2/2] app/graph: implement L2FWD usecase

[Sunil Kumar Kori]

> -Original Message-
> From: Rakesh Kudurumalla 
> Sent: Thursday, November 23, 2023 11:46 AM
> To: Sunil Kumar Kori ; Rakesh Kudurumalla
> 
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin
> Kumar Dabilpuram 
> Subject: [PATCH 2/2] app/graph: implement L2FWD usecase
> 
> Added l2fwd usecase for graph
> 
Need details about patch. Please refer commit to add l3fwd usecase.

> Signed-off-by: Rakesh Kudurumalla 
> ---
>  app/graph/cli.c  |   1 +
>  app/graph/examples/l2fwd.cli |  41 ++
>  app/graph/graph.c|   8 +-
>  app/graph/l2fwd.c| 148 +++
>  app/graph/l2fwd.h|  11 +++
>  app/graph/meson.build|   2 +
>  app/graph/module_api.h   |   2 +
>  app/graph/portfwd.c  | 110 ++
>  app/graph/portfwd.h  |  21 +
>  app/graph/portfwd_priv.h |  14 
>  10 files changed, 357 insertions(+), 1 deletion(-)  create mode 100644
> app/graph/examples/l2fwd.cli  create mode 100644 app/graph/l2fwd.c
> create mode 100644 app/graph/l2fwd.h  create mode 100644
> app/graph/portfwd.c  create mode 100644 app/graph/portfwd.h  create
> mode 100644 app/graph/portfwd_priv.h
> 
1. Split patch into 2 separate patches. One to add new ethdev command and 
second to add l2fwd usecase.
2. Code related to ethdev command can be moved to ethdev.c, ethdev.h and 
ethdev_priv.h. No need to add new files.
3. Update " doc/guides/tools/graph.rst " to support l2fwd usecase.

> diff --git a/app/graph/cli.c b/app/graph/cli.c index
> 30b12312d6..76f5b8e670 100644
> --- a/app/graph/cli.c
> +++ b/app/graph/cli.c
> @@ -32,6 +32,7 @@ cmdline_parse_ctx_t modules_ctx[] = {
>   (cmdline_parse_inst_t *)ðdev_prom_mode_cmd_ctx,
>   (cmdline_parse_inst_t *)ðdev_ip4_cmd_ctx,
>   (cmdline_parse_inst_t *)ðdev_ip6_cmd_ctx,
> + (cmdline_parse_inst_t *)ðdev_forward_cmd_ctx,
>   (cmdline_parse_inst_t *)ðdev_cmd_ctx,
>   (cmdline_parse_inst_t *)ðdev_help_cmd_ctx,
>   (cmdline_parse_inst_t *)ðdev_rx_cmd_ctx, diff --git
> a/app/graph/examples/l2fwd.cli b/app/graph/examples/l2fwd.cli new file
> mode 100644 index 00..af24a5836a
> --- /dev/null
> +++ b/app/graph/examples/l2fwd.cli
> @@ -0,0 +1,41 @@
> +; SPDX-License-Identifier: BSD-3-Clause ; Copyright(c) 2023 Marvell.
> +
> +;
> +; Graph configuration for given usecase ; graph l2fwd coremask 0xff bsz
> +32 tmo 10 model default pcap_enable 1 num_pcap_pkts 10 pcap_file
> +/tmp/output.pcap
> +
> +;
> +; Mempools to be attached with ethdev
> +;
> +mempool mempool0 size 8192 buffers 4000 cache 256 numa 0
> +
> +;
> +; DPDK devices and configuration.
> +;
> +; Note: Customize the parameters below to match your setup.
> +;
> +ethdev 0002:01:00.1 rxq 1 txq 8 mempool0 ethdev 0002:01:00.4 rxq 1 txq
> +8 mempool0 ethdev 0002:01:00.6 rxq 1 txq 8 mempool0 ethdev
> 0002:02:00.0
> +rxq 1 txq 8 mempool0
> +
> +;
> +; L2 mac forwarding rules
> +;
> +ethdev forward 0002:01:00.4 0002:02:00.0 ethdev forward 0002:01:00.1
> +0002:01:00.6
> +
> +;
> +; Port-Queue-Core mapping for ethdev_rx node ; ethdev_rx map port
> +0002:02:00.0 queue 0 core 1 ethdev_rx map port 0002:01:00.6 queue 0
> +core 2
> +
> +;
> +; Graph start command to create graph.
> +;
> +; Note: No more command should come after this.
> +;
> +graph start
> diff --git a/app/graph/graph.c b/app/graph/graph.c index
> a65723a196..4e0441f1a7 100644
> --- a/app/graph/graph.c
> +++ b/app/graph/graph.c
> @@ -24,7 +24,7 @@ cmd_graph_help[] = "graph  bsz 
> tmo  coremask  "
>  "model  pcap_enable <0 | 1>
> num_pcap_pkts "
>  "pcap_file ";
> 
> -static const char * const supported_usecases[] = {"l3fwd"};
> +static const char * const supported_usecases[] = {"l3fwd", "l2fwd"};
>  struct graph_config graph_config;
>  bool graph_started;
> 
> @@ -273,6 +273,12 @@ cli_graph_start(__rte_unused void *parsed_result,
> __rte_unused struct cmdline *c
>   break;
>   }
>   }
> + if (!strcmp(graph_config.usecases[i].name, "l2fwd")) {
> + if (graph_config.usecases[i].enabled) {
> + rc  = usecase_l2fwd_configure(conf,
> nb_conf, nb_graphs);
> + break;
> + }
> + }
>   }
> 
>   if (!rc)
> diff --git a/app/graph/l2fwd.c b/app/graph/l2fwd.c new file mode 100644
> index 00..1f18d69ea8
> --- /dev/null
> +++ b/app/graph/l2fwd.c
> @@ -0,0 +1,148 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2023 Marvell.
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include "module_api.h"
> +
> +static int
> +l2fwd_pattern_configure(void)
> +{
> + struct rte_graph_param graph_conf;
> + const char **node_patterns;
> + uint64_t pcap_pkts_count;
> + st

DPDK Release Status Meeting 2023-11-23

[Mcnamara, John]

Release status meeting minutes 2023-11-23
=

Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens

Participants:
* AMD
* ARM
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat

Release Dates
-

The following are the current working dates for 23.11:

* V1:  12 August   2023
* RC1: 11 October  2023
* RC2:  6 November 2023
* RC3: 13 November 2023
* RC4: 23 November 2023
* Release: 24 November 2023


The following are the current working dates for 24.03:

- Proposal deadline (RFC/v1 patches): 22 December 2023
- API freeze (-rc1): 5 February 2024
- PMD features freeze (-rc2): 23 February 2024
- Builtin applications features freeze (-rc3): 4 March 2024
- Release: 14 March 2024



Subtrees


* next-net
  * No direct changes past RC4

* next-net-intel
  * No direct changes past RC4

* next-net-mlx
  * No direct changes past RC4

* next-net-mvl
  * No direct changes past RC4

* next-eventdev
  * No direct changes past RC4

* next-baseband
  * No direct changes past RC4

* next-virtio
  * No direct changes past RC4

* next-crypto
  * No direct changes past RC4

* main
  * RC4 released
  * Release targeted for 24 November 2023, depending on some build/CI issues:
* Build/link issue on Debian
  https://salsa.debian.org/debian/dpdk/-/jobs/4949787
* cpfl compilation issue
  
https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_Next/i586
* LCOREs autotest timing out on ARM:
  
https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_12/aarch64


Proposed Schedule for 2023
--

See http://core.dpdk.org/roadmap/#dates


LTS
---

* 22.11.3 - In progress
* 21.11.6 - In progress
* 20.11.10 - In progress
* 19.11.15 - Will only be updated with CVE and critical fixes.


* Distros
  * Debian 12 contains DPDK v22.11
  * Ubuntu 22.04-LTS contains DPDK v21.11
  * Ubuntu 23.04 contains DPDK v22.11

Defects
---

* Bugzilla links, 'Bugs',  added for hosted projects
  * https://www.dpdk.org/hosted-projects/



DPDK Release Status Meetings


The DPDK Release Status Meeting is intended for DPDK Committers to discuss the
status of the master tree and sub-trees, and for project managers to track
progress or milestone dates.

The meeting occurs on every Thursday at 9:30 UTC over Jitsi on 
https://meet.jit.si/DPDK

You don't need an invite to join the meeting but if you want a calendar 
reminder just
send an email to "John McNamara john.mcnam...@intel.com" for the invite.

net/virtio: duplicated xstats

[Edwin Brossette]

Hello,

I noticed a small inconsistency in the virtio pmd's xstats.
The stat "rx_q0_errors" appears twice.
I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and
"tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes",
"tx_q0_good_packets" and "tx_q0_good_bytes"

I believe this issue probably appeared after this commit:

f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats
http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2

>From what I understand, the rxq0_error stat was originally reported by the
librte. However, changes were made so it is reported by the pmd instead.
The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep the
old behaviour so that every pmd could have time to adapt the change.
But it seems the flag was forgotten in the virtio pmd and as a result, some
stats are fetched at two different times when displaying xstats.

First in lib_rte_ethdev:
https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266
(you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag before
the snprintf on eth_dev_rxq_stats_strings[] )

And a second time in the virtio pmd:
https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705 pmd
(see the snprintf on rte_virtio_rxq_stat_strings[] )

This problem can be reproduced on testpmd simply by displaying the xstats
on a port with the net_virtio driver:

Reproduction:
===

1) start dpdk-testpmd:

modprobe -a uio_pci_generic
dpdk-devbind -b uio_pci_generic 03:00.0
dpdk-devbind -b uio_pci_generic 04:00.0

dpdk-devbind -s

Network devices using DPDK-compatible driver

:03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
unused=vfio-pci
:04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
unused=vfio-pci
[...]

dpdk-testpmd -a :03:00.0 -a :04:00.0 -- -i --rxq=1 --txq=1
--coremask=0x4 --total-num-mbufs=25
EAL: Detected CPU lcores: 3
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: VFIO support initialized
EAL: Probe PCI driver: net_virtio (1af4:1041) device: :03:00.0 (socket
-1)
EAL: Probe PCI driver: net_virtio (1af4:1041) device: :04:00.0 (socket
-1)
Interactive-mode selected
Warning: NUMA should be configured manually by using --port-numa-config and
--ring-numa-config parameters along with --numa.
testpmd: create a new mbuf pool : n=25, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Configuring Port 0 (socket 0)
Port 0: 52:54:00:B0:8F:88
Configuring Port 1 (socket 0)
Port 1: 52:54:00:EF:09:1F
Checking link statuses...
Done

2) port info:

show port info 0

* Infos for port 0  *
MAC address: 52:54:00:B0:8F:88
Device name: :03:00.0
Driver name: net_virtio
Firmware-version: not available
Devargs:
Connect to socket: 0
memory allocation on the socket: 0
Link status: up
Link speed: Unknown
Link duplex: full-duplex
Autoneg status: On
MTU: 1500
Promiscuous mode: enabled
Allmulticast mode: disabled
Maximum number of MAC addresses: 64
Maximum number of MAC addresses of hash filtering: 0
VLAN offload:
  strip off, filter off, extend off, qinq strip off
No RSS offload flow type is supported.
Minimum size of RX buffer: 64
Maximum configurable length of RX packet: 9728
Maximum configurable size of LRO aggregated packet: 0
Current number of RX queues: 1
Max possible RX queues: 1
Max possible number of RXDs per queue: 32768
Min possible number of RXDs per queue: 32
RXDs number alignment: 1
Current number of TX queues: 1
Max possible TX queues: 1
Max possible number of TXDs per queue: 32768
Min possible number of TXDs per queue: 32
TXDs number alignment: 1
Max segment number per packet: 65535
Max segment number per MTU/TSO: 65535
Device capabilities: 0x0( )
Device error handling mode: none
Device private info:
guest_features: 0x110af8020
vtnet_hdr_size: 12
use_vec: rx-0 tx-0
use_inorder: rx-0 tx-0
intr_lsc: 1
max_mtu: 9698
max_rx_pkt_len: 1530
max_queue_pairs: 1
req_guest_features: 0x805f10ef8028

3) show port xstats:

show port xstats 0
## NIC extended statistics for port 0
rx_good_packets: 0
tx_good_packets: 0
rx_good_bytes: 0
tx_good_bytes: 0
rx_missed_errors: 0
rx_errors: 0
tx_errors: 0
rx_mbuf_allocation_errors: 0
rx_q0_packets: 0
rx_q0_bytes: 0
rx_q0_errors: 0  <==
tx_q0_packets: 0
tx_q0_bytes: 0
rx_q0_good_packets: 0
rx_q0_good_bytes: 0
rx_q0_errors: 0  <==
rx_q0_multicast_packets: 0
rx_q0_broadcast_packets: 0
rx_q0_undersize_packets: 0
rx_q0_size_64_packets: 0
rx_q0_size_65_127_packets: 0
rx_q0_size_128_255_packets: 0
rx_q0_size_256_511_packets: 0
rx_q0_size_512_1023_packets: 0
rx_q0_size_1024_1518_packets: 0
rx_q0_size_1519_max_packets: 0
tx_q0_good_packets: 0
tx_q0_good_bytes: 0
tx_q0_multicast_packets: 0
tx_q0_br

Re: net/virtio: duplicated xstats

[Olivier Matz]

Fix Maxime's mail.

On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote:
> Hello,
> 
> I noticed a small inconsistency in the virtio pmd's xstats.
> The stat "rx_q0_errors" appears twice.
> I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and
> "tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes",
> "tx_q0_good_packets" and "tx_q0_good_bytes"
> 
> I believe this issue probably appeared after this commit:
> 
> f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats
> http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2
> 
> From what I understand, the rxq0_error stat was originally reported by the
> librte. However, changes were made so it is reported by the pmd instead.
> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep the
> old behaviour so that every pmd could have time to adapt the change.
> But it seems the flag was forgotten in the virtio pmd and as a result, some
> stats are fetched at two different times when displaying xstats.
> 
> First in lib_rte_ethdev:
> https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266
> (you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag before
> the snprintf on eth_dev_rxq_stats_strings[] )
> 
> And a second time in the virtio pmd:
> https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705 pmd
> (see the snprintf on rte_virtio_rxq_stat_strings[] )
> 
> This problem can be reproduced on testpmd simply by displaying the xstats
> on a port with the net_virtio driver:
> 
> Reproduction:
> ===
> 
> 1) start dpdk-testpmd:
> 
> modprobe -a uio_pci_generic
> dpdk-devbind -b uio_pci_generic 03:00.0
> dpdk-devbind -b uio_pci_generic 04:00.0
> 
> dpdk-devbind -s
> 
> Network devices using DPDK-compatible driver
> 
> :03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
> unused=vfio-pci
> :04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
> unused=vfio-pci
> [...]
> 
> dpdk-testpmd -a :03:00.0 -a :04:00.0 -- -i --rxq=1 --txq=1
> --coremask=0x4 --total-num-mbufs=25
> EAL: Detected CPU lcores: 3
> EAL: Detected NUMA nodes: 1
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'PA'
> EAL: VFIO support initialized
> EAL: Probe PCI driver: net_virtio (1af4:1041) device: :03:00.0 (socket
> -1)
> EAL: Probe PCI driver: net_virtio (1af4:1041) device: :04:00.0 (socket
> -1)
> Interactive-mode selected
> Warning: NUMA should be configured manually by using --port-numa-config and
> --ring-numa-config parameters along with --numa.
> testpmd: create a new mbuf pool : n=25, size=2176, socket=0
> testpmd: preferred mempool ops selected: ring_mp_mc
> Configuring Port 0 (socket 0)
> Port 0: 52:54:00:B0:8F:88
> Configuring Port 1 (socket 0)
> Port 1: 52:54:00:EF:09:1F
> Checking link statuses...
> Done
> 
> 2) port info:
> 
> show port info 0
> 
> * Infos for port 0  *
> MAC address: 52:54:00:B0:8F:88
> Device name: :03:00.0
> Driver name: net_virtio
> Firmware-version: not available
> Devargs:
> Connect to socket: 0
> memory allocation on the socket: 0
> Link status: up
> Link speed: Unknown
> Link duplex: full-duplex
> Autoneg status: On
> MTU: 1500
> Promiscuous mode: enabled
> Allmulticast mode: disabled
> Maximum number of MAC addresses: 64
> Maximum number of MAC addresses of hash filtering: 0
> VLAN offload:
>   strip off, filter off, extend off, qinq strip off
> No RSS offload flow type is supported.
> Minimum size of RX buffer: 64
> Maximum configurable length of RX packet: 9728
> Maximum configurable size of LRO aggregated packet: 0
> Current number of RX queues: 1
> Max possible RX queues: 1
> Max possible number of RXDs per queue: 32768
> Min possible number of RXDs per queue: 32
> RXDs number alignment: 1
> Current number of TX queues: 1
> Max possible TX queues: 1
> Max possible number of TXDs per queue: 32768
> Min possible number of TXDs per queue: 32
> TXDs number alignment: 1
> Max segment number per packet: 65535
> Max segment number per MTU/TSO: 65535
> Device capabilities: 0x0( )
> Device error handling mode: none
> Device private info:
> guest_features: 0x110af8020
> vtnet_hdr_size: 12
> use_vec: rx-0 tx-0
> use_inorder: rx-0 tx-0
> intr_lsc: 1
> max_mtu: 9698
> max_rx_pkt_len: 1530
> max_queue_pairs: 1
> req_guest_features: 0x805f10ef8028
> 
> 3) show port xstats:
> 
> show port xstats 0
> ## NIC extended statistics for port 0
> rx_good_packets: 0
> tx_good_packets: 0
> rx_good_bytes: 0
> tx_good_bytes: 0
> rx_missed_errors: 0
> rx_errors: 0
> tx_errors: 0
> rx_mbuf_allocation_errors: 0
> rx_q0_packets: 0
> rx_q0_bytes: 0
> rx_q0_errors: 0  <==
> tx_q0_packets: 0
> tx_q0_bytes: 0
> rx_q0_good_packets: 0
> rx_q0_good_bytes: 0
> rx_q0_errors: 0  <===

RE: [PATCH] maintainers: add mlx5 driver platform guides

[Dariusz Sosnowski]

> As drivers/common/mlx5/ is listed before drivers/net/mlx5/ we should list
> doc/guides/platform/mlx5.rst before doc/guides/nics/mlx5.rst Probably that
> bluefield.rst should be in the middle between common and NIC docs.
I agree, this ordering will be more logical.

I'll send v2. Thank you.

[PATCH v2] maintainers: add mlx5 driver platform guides

[Dariusz Sosnowski]

Add NVIDIA's platform specific guides to files maintained by networking
mlx5 driver maintainers.

Signed-off-by: Dariusz Sosnowski 
---
Changes since v1:
- Placed common docs before NIC docs.

 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b07dfbcd39..0d1c8126e3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -875,6 +875,8 @@ T: git://dpdk.org/next/dpdk-next-net-mlx
 F: drivers/common/mlx5/
 F: drivers/net/mlx5/
 F: buildtools/options-ibverbs-static.sh
+F: doc/guides/platform/mlx5.rst
+F: doc/guides/platform/bluefield.rst
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-- 
2.25.1

Re: [PATCH v2] crypto/ipsec_mb: fix getting process ID per job

[Thomas Monjalon]

> > Currently, when using IPsec-mb 1.4+, the process ID is obtained for each 
> > job in
> > a burst with a call to getpid().
> > This system call uses too many CPU cycles, and is unnecessary per job.
> > 
> > Instead, set the process ID value per lcore.
> > This is read when processing the burst, instead of per job.
> > 
> > Fixes: 9593d83e5d88 ("crypto/ipsec_mb: fix aesni_mb multi-process session
> > ID")
> > Cc: sta...@dpdk.org
> > 
> > Signed-off-by: Ciara Power 
> 
> Acked-by: Pablo de Lara 

Applied, thanks.

[PATCH v2] eal/linux: force iova-mode va without pa available

[christian . ehrhardt]

From: David Wilder 

When using --no-huge option physical address are not guaranteed
to be persistent.

This change effectively makes "--no-huge" the same as
"--no-huge --iova-mode=va".

When --no-huge is used (or any other condition making physical
addresses unavailable) setting --iova-mode=pa will have no effect.

Signed-off-by: Christian Ehrhardt 
---
 doc/guides/prog_guide/env_abstraction_layer.rst |  9 ++---
 lib/eal/linux/eal.c | 16 ++--
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst 
b/doc/guides/prog_guide/env_abstraction_layer.rst
index 6debf54efb..20c7355e0f 100644
--- a/doc/guides/prog_guide/env_abstraction_layer.rst
+++ b/doc/guides/prog_guide/env_abstraction_layer.rst
@@ -559,9 +559,12 @@ IOVA Mode is selected by considering what the current 
usable Devices on the
 system require and/or support.
 
 On FreeBSD, RTE_IOVA_PA is always the default. On Linux, the IOVA mode is
-detected based on a 2-step heuristic detailed below.
+detected based on a heuristic detailed below.
 
-For the first step, EAL asks each bus its requirement in terms of IOVA mode
+For the first step, if no Physical Addresses are available RTE_IOVA_VA is
+selected.
+
+Then EAL asks each bus its requirement in terms of IOVA mode
 and decides on a preferred IOVA mode.
 
 - if all buses report RTE_IOVA_PA, then the preferred IOVA mode is RTE_IOVA_PA,
@@ -575,7 +578,7 @@ and decides on a preferred IOVA mode.
 If the buses have expressed no preference on which IOVA mode to pick, then a
 default is selected using the following logic:
 
-- if physical addresses are not available, RTE_IOVA_VA mode is used
+- if enable_iova_as_pa was not set at build RTE_IOVA_VA mode is used
 - if /sys/kernel/iommu_groups is not empty, RTE_IOVA_VA mode is used
 - otherwise, RTE_IOVA_PA mode is used
 
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 57da058cec..2f1fce3c54 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1067,6 +1067,16 @@ rte_eal_init(int argc, char **argv)
 
phys_addrs = rte_eal_using_phys_addrs() != 0;
 
+   if (!phys_addrs) {
+   /* if we have no access to physical addresses, pick IOVA as VA 
mode. */
+   if (internal_conf->iova_mode == RTE_IOVA_PA)
+   RTE_LOG(WARNING, EAL, "WARNING: --iova-mode=pa, but 
Physical addresses are unavailable, selecting IOVA as VA mode.\n");
+   else
+   RTE_LOG(DEBUG, EAL, "Physical addresses are 
unavailable, selecting IOVA as VA mode.\n");
+   internal_conf->iova_mode = RTE_IOVA_VA;
+   rte_eal_get_configuration()->iova_mode = 
internal_conf->iova_mode;
+   }
+
/* if no EAL option "--iova-mode=", use bus IOVA scheme */
if (internal_conf->iova_mode == RTE_IOVA_DC) {
/* autodetect the IOVA mapping mode */
@@ -1078,12 +1088,6 @@ rte_eal_init(int argc, char **argv)
if (!RTE_IOVA_IN_MBUF) {
iova_mode = RTE_IOVA_VA;
RTE_LOG(DEBUG, EAL, "IOVA as VA mode is forced 
by build option.\n");
-   } else if (!phys_addrs) {
-   /* if we have no access to physical addresses,
-* pick IOVA as VA mode.
-*/
-   iova_mode = RTE_IOVA_VA;
-   RTE_LOG(DEBUG, EAL, "Physical addresses are 
unavailable, selecting IOVA as VA mode.\n");
} else if (is_iommu_enabled()) {
/* we have an IOMMU, pick IOVA as VA mode */
iova_mode = RTE_IOVA_VA;
-- 
2.34.1

RE: [PATCH v7] app/test: secondary process passes allow parameters

[Ye, MingjinX]

Hi, 

Thanks for the ack. would like to change the state of the patch, which will be 
merged into the dpdk.

Change: The "--allow" parameter is added when the number of allow is greater 
than zero.

Thanks,
Mingjin

> -Original Message-
> From: Richardson, Bruce 
> Sent: Friday, November 17, 2023 7:17 PM
> To: Ye, MingjinX 
> Cc: dev@dpdk.org; Yang, Qiming ;
> sta...@dpdk.org; Xu, HailinX 
> Subject: Re: [PATCH v7] app/test: secondary process passes allow
> parameters
> 
> On Fri, Nov 17, 2023 at 10:24:41AM +, Ye, MingjinX wrote:
> > Hi Richardson,
> >
> > can you please take a look at this patch.
> >
> > Thanks,
> > Mingjin
> >
> 
> Hi,
> 
> I acked v6. If nothing major has changed in the patch, then the ack can be
> kept for v7. If there is something that has changed that you think I should
> look at, please include it in the change-log, so I can check it out.
> 
> For now, assuming no major changes:
> 
> Acked-by: Bruce Richardson 
> 
> /Bruce
> 
> >
> > > -Original Message-
> > > From: Ye, MingjinX 
> > > Sent: Tuesday, November 14, 2023 6:28 PM
> > > To: dev@dpdk.org
> > > Cc: Yang, Qiming ; Ye, MingjinX
> > > ; sta...@dpdk.org
> > > Subject: [PATCH v7] app/test: secondary process passes allow
> > > parameters
> > >
> > > In EAL related test cases, the allow parameters are not passed to
> > > the secondary process, resulting in unexpected NICs being loaded.
> > >
> > > This patch fixes this issue by appending the allow parameters to the
> > > secondary process.
> > >
> > > Fixes: af75078fece3 ("first public release")
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Mingjin Ye 
> > > ---
> > > v5: Optimized.
> > > ---
> > > v6: Optimized.
> > > ---
> > > v7: Fix CI errors.
> > > ---
> > >  app/test/process.h | 46
> > > ++
> > >  1 file changed, 42 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/app/test/process.h b/app/test/process.h index
> > > af7bc3e0de..06b2f8b192 100644
> > > --- a/app/test/process.h
> > > +++ b/app/test/process.h
> > > @@ -17,6 +17,7 @@
> > >  #include 
> > >
> > >  #include  /* strlcpy */
> > > +#include 
> > >
> > >  #ifdef RTE_EXEC_ENV_FREEBSD
> > >  #define self "curproc"
> > > @@ -34,6 +35,34 @@ extern uint16_t flag_for_send_pkts;  #endif
> > > #endif
> > >
> > > +#define PREFIX_ALLOW "--allow="
> > > +
> > > +static int
> > > +add_parameter_allow(char **argv, int max_capacity) {
> > > + struct rte_devargs *devargs;
> > > + int count = 0;
> > > +
> > > + RTE_EAL_DEVARGS_FOREACH(NULL, devargs) {
> > > + if (strlen(devargs->name) == 0)
> > > + continue;
> > > +
> > > + if (devargs->data == NULL || strlen(devargs->data) == 0) {
> > > + if (asprintf(&argv[count], PREFIX_ALLOW"%s",
> > > devargs->name) < 0)
> > > + break;
> > > + } else {
> > > + if (asprintf(&argv[count], PREFIX_ALLOW"%s,%s",
> > > +  devargs->name, devargs->data) < 0)
> > > + break;
> > > + }
> > > +
> > > + if (++count == max_capacity)
> > > + break;
> > > + }
> > > +
> > > + return count;
> > > +}
> > > +
> > >  /*
> > >   * launches a second copy of the test process using the given argv
> > > parameters,
> > >   * which should include argv[0] as the process name. To identify in
> > > the @@ -
> > > 43,8 +72,10 @@ extern uint16_t flag_for_send_pkts;  static inline
> > > int process_dup(const char *const argv[], int numargs, const char
> *env_value)  {
> > > - int num;
> > > - char *argv_cpy[numargs + 1];
> > > + int num = 0;
> > > + char **argv_cpy;
> > > + int allow_num;
> > > + int argv_num;
> > >   int i, status;
> > >   char path[32];
> > >  #ifdef RTE_LIB_PDUMP
> > > @@ -58,11 +89,18 @@ process_dup(const char *const argv[], int
> > > numargs, const char *env_value)
> > >   if (pid < 0)
> > >   return -1;
> > >   else if (pid == 0) {
> > > + allow_num =
> > > rte_devargs_type_count(RTE_DEVTYPE_ALLOWED);
> > > + argv_num = numargs + allow_num + 1;
> > > + argv_cpy = calloc(argv_num, sizeof(char *));
> > > + if (!argv_cpy)
> > > + rte_panic("Memory allocation failed\n");
> > > +
> > >   /* make a copy of the arguments to be passed to exec */
> > >   for (i = 0; i < numargs; i++)
> > >   argv_cpy[i] = strdup(argv[i]);
> > > - argv_cpy[i] = NULL;
> > > - num = numargs;
> > > + if (allow_num > 0)
> > > + num = add_parameter_allow(&argv_cpy[i],
> > > allow_num);
> > > + num += numargs;
> > >
> > >  #ifdef RTE_EXEC_ENV_LINUX
> > >   {
> > > --
> > > 2.25.1
> >

Re: [PATCH v2] eal/linux: force iova-mode va without pa available

[Dmitry Kozlyuk]

2023-11-24 11:09 (UTC+0100), christian.ehrha...@canonical.com:
[...]
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 57da058cec..2f1fce3c54 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -1067,6 +1067,16 @@ rte_eal_init(int argc, char **argv)
>  
>   phys_addrs = rte_eal_using_phys_addrs() != 0;
>  
> + if (!phys_addrs) {
> + /* if we have no access to physical addresses, pick IOVA as VA 
> mode. */
> + if (internal_conf->iova_mode == RTE_IOVA_PA)
> + RTE_LOG(WARNING, EAL, "WARNING: --iova-mode=pa, but 
> Physical addresses are unavailable, selecting IOVA as VA mode.\n");

If an impossible combination of options is requested,
initialization should fail instead.

> + else
> + RTE_LOG(DEBUG, EAL, "Physical addresses are 
> unavailable, selecting IOVA as VA mode.\n");
> + internal_conf->iova_mode = RTE_IOVA_VA;
> + rte_eal_get_configuration()->iova_mode = 
> internal_conf->iova_mode;
> + }
> +
>   /* if no EAL option "--iova-mode=", use bus IOVA scheme */
>   if (internal_conf->iova_mode == RTE_IOVA_DC) {
>   /* autodetect the IOVA mapping mode */

What do you think about keeping the existing code structure:

if (--iova-mode not specified) {
iova_mode = VA if !phys_addrs or !RTE_IOVA_IN_MBUF (with logs)
if (iova_mode == DC) {
// autodetect from bus requirements and IOMMU (with logs)
}
rte_eal_get_configuration()->iova_mode = iova_mode;
} else {
rte_eal_get_configuration()->iova_mode =
internal_conf->iova_mode;
}
// verify rte_eal_get_configuration()->iova_mode

Note: the logic should be consistent across OS when possible.

RE: [PATCH v7 0/2] fix legacy device missing region info

[Ye, MingjinX]

Hi,

can you please take a look at this patch.

Thanks,
Mingjin

> -Original Message-
> From: Ye, MingjinX 
> Sent: Wednesday, November 22, 2023 6:23 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Ye, MingjinX
> 
> Subject: [PATCH v7 0/2] fix legacy device missing region info
> 
> Fill in missing region information for legacy devices in secondary processes.
> And added rte_vfio_get_device_info API for EAL, which makes it easier and
> more generic to get device information through vfio driver.
> 
> Mingjin Ye (2):
>   vfio: add get device info API
>   bus/pci: fix legacy device missing region info
> 
>  drivers/bus/pci/linux/pci_vfio.c | 26 ++
>  lib/eal/include/rte_vfio.h   | 29 +
>  lib/eal/linux/eal_vfio.c | 27 +++
>  lib/eal/version.map  |  3 +++
>  4 files changed, 85 insertions(+)
> 
> --
> 2.25.1

Re: net/virtio: duplicated xstats

[Maxime Coquelin]

Hi Edwin,

Thanks for reporting the issue.

On 11/24/23 10:26, Olivier Matz wrote:

Fix Maxime's mail.


Thanks Olivier.


On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote:

Hello,

I noticed a small inconsistency in the virtio pmd's xstats.
The stat "rx_q0_errors" appears twice.
I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and
"tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes",
"tx_q0_good_packets" and "tx_q0_good_bytes"

I believe this issue probably appeared after this commit:

f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats
http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2


Adding Ferruh as he is the author of this commit.


 From what I understand, the rxq0_error stat was originally reported by the
librte. However, changes were made so it is reported by the pmd instead.
The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep the
old behaviour so that every pmd could have time to adapt the change.
But it seems the flag was forgotten in the virtio pmd and as a result, some
stats are fetched at two different times when displaying xstats.


Have you tried adding this flag to Virtio PMD? Does it fixes the issue?


First in lib_rte_ethdev:
https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266
(you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag before
the snprintf on eth_dev_rxq_stats_strings[] )

And a second time in the virtio pmd:
https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705 pmd
(see the snprintf on rte_virtio_rxq_stat_strings[] )

This problem can be reproduced on testpmd simply by displaying the xstats
on a port with the net_virtio driver:

Reproduction:
===

 1) start dpdk-testpmd:

modprobe -a uio_pci_generic
dpdk-devbind -b uio_pci_generic 03:00.0
dpdk-devbind -b uio_pci_generic 04:00.0

dpdk-devbind -s

Network devices using DPDK-compatible driver

:03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
unused=vfio-pci
:04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
unused=vfio-pci
[...]

dpdk-testpmd -a :03:00.0 -a :04:00.0 -- -i --rxq=1 --txq=1
--coremask=0x4 --total-num-mbufs=25
EAL: Detected CPU lcores: 3
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: VFIO support initialized
EAL: Probe PCI driver: net_virtio (1af4:1041) device: :03:00.0 (socket
-1)
EAL: Probe PCI driver: net_virtio (1af4:1041) device: :04:00.0 (socket
-1)
Interactive-mode selected
Warning: NUMA should be configured manually by using --port-numa-config and
--ring-numa-config parameters along with --numa.
testpmd: create a new mbuf pool : n=25, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Configuring Port 0 (socket 0)
Port 0: 52:54:00:B0:8F:88
Configuring Port 1 (socket 0)
Port 1: 52:54:00:EF:09:1F
Checking link statuses...
Done

 2) port info:

show port info 0

* Infos for port 0  *
MAC address: 52:54:00:B0:8F:88
Device name: :03:00.0
Driver name: net_virtio
Firmware-version: not available
Devargs:
Connect to socket: 0
memory allocation on the socket: 0
Link status: up
Link speed: Unknown
Link duplex: full-duplex
Autoneg status: On
MTU: 1500
Promiscuous mode: enabled
Allmulticast mode: disabled
Maximum number of MAC addresses: 64
Maximum number of MAC addresses of hash filtering: 0
VLAN offload:
   strip off, filter off, extend off, qinq strip off
No RSS offload flow type is supported.
Minimum size of RX buffer: 64
Maximum configurable length of RX packet: 9728
Maximum configurable size of LRO aggregated packet: 0
Current number of RX queues: 1
Max possible RX queues: 1
Max possible number of RXDs per queue: 32768
Min possible number of RXDs per queue: 32
RXDs number alignment: 1
Current number of TX queues: 1
Max possible TX queues: 1
Max possible number of TXDs per queue: 32768
Min possible number of TXDs per queue: 32
TXDs number alignment: 1
Max segment number per packet: 65535
Max segment number per MTU/TSO: 65535
Device capabilities: 0x0( )
Device error handling mode: none
Device private info:
guest_features: 0x110af8020
vtnet_hdr_size: 12
use_vec: rx-0 tx-0
use_inorder: rx-0 tx-0
intr_lsc: 1
max_mtu: 9698
max_rx_pkt_len: 1530
max_queue_pairs: 1
req_guest_features: 0x805f10ef8028

 3) show port xstats:

show port xstats 0
## NIC extended statistics for port 0
rx_good_packets: 0
tx_good_packets: 0
rx_good_bytes: 0
tx_good_bytes: 0
rx_missed_errors: 0
rx_errors: 0
tx_errors: 0
rx_mbuf_allocation_errors: 0
rx_q0_packets: 0
rx_q0_bytes: 0
rx_q0_errors: 0  <==
tx_q0_packets: 0
tx_q0_bytes: 0
rx_q0_good_packets: 0
rx_q0_good_bytes: 0
rx_q0_errors: 0  <==
rx_q0_multicast_packets: 0
rx_q0_broadcast_p

Re: [PATCH v7 2/2] bus/pci: fix legacy device missing region info

[Gupta, Nipun]

On 11/22/2023 3:52 PM, Mingjin Ye wrote:

If the legacy device in the primary process does not support mapping the
io port bar, the secondary process needs to proactively get the device
information and fil the region information.

Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value")

Signed-off-by: Mingjin Ye 


I have already sent my Acked-by on v6. Once you receive an Ack, you need 
to add it in the subsequent versions.


For this one I am again doing for the committer.

Acked-by: Nipun Gupta 

[PATCH v1] doc: update release notes for 23.11

[John McNamara]

Fix grammar, spelling and formatting of DPDK 23.11 release notes.

Signed-off-by: John McNamara 
---
 doc/guides/rel_notes/release_23_11.rst | 30 ++
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index e16bc20466..f979c8f21a 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -63,8 +63,8 @@ New Features
 
   More specifically, the requirements will be:
 
-  * Support for flag "-std=c11" (or similar)
-  * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag
+  * Support for flag ``-std=c11`` (or similar)
+  * ``__STDC_NO_ATOMICS__`` is *not defined* when using c11 flag
 
   Please note:
 
@@ -92,9 +92,11 @@ New Features
 
 * **Added support for power intrinsics with AMD processors.**
 
-* **Added support for allow/block list in vmbus bus driver.***
+  Added support for power intrinsics with AMD processors.
 
-  The ``vmbus`` bus driver now supports -a and -b EAL options for selecting
+* **Added support for allow/block list in vmbus bus driver.**
+
+  The ``vmbus`` bus driver now supports ``-a`` and ``-b`` EAL options for 
selecting
   devices.
 
 * **Added mbuf recycling support.**
@@ -133,7 +135,7 @@ New Features
 
   For P4-programmable devices, hardware pipeline can be configured through
   a new "PROG" action type and its associated custom arguments.
-  Such P4 pipeline, not using the standard blocks of the flow API,
+  Such P4 pipelines, not using the standard blocks of the flow API,
   can be managed with ``RTE_FLOW_ITEM_TYPE_FLEX`` and 
``RTE_FLOW_ACTION_TYPE_PROG``.
 
 * **Added flow group set miss actions.**
@@ -145,7 +147,7 @@ New Features
 * **Updated Amazon ena (Elastic Network Adapter) net driver.**
 
   * Upgraded ENA HAL to latest version.
-  * Added support for connection tracking allowance utilization metric.
+  * Added support for connection tracking allowance utilization metrics.
   * Added support for reporting Rx overrun errors in xstats.
   * Added support for ENA-express metrics.
 
@@ -212,12 +214,12 @@ New Features
   Added Rx inject API to allow applications to submit packets
   for protocol offload and have them injected back to ethdev Rx
   so that further ethdev Rx actions (IP reassembly, packet parsing and flow 
lookups)
-  can happen based on inner packet.
+  can happen based on the inner packet.
 
-  The API when implemented by an ethdev, application would be able to process
+  When using the API when implemented by an ethdev the application would be 
able to process
   packets that are received without/failed inline offload processing
   (such as fragmented ESP packets with inline IPsec offload).
-  The API when implemented by a cryptodev, can be used for injecting packets
+  When using the AP when implemented by a cryptodev it can be used for 
injecting packets
   to ethdev Rx after IPsec processing and take advantage of ethdev Rx actions
   for the inner packet which cannot be accelerated in inline protocol offload 
mode.
 
@@ -229,7 +231,7 @@ New Features
 * **Updated ipsec_mb crypto driver.**
 
   * Added Intel IPsec MB v1.5 library support for x86 platform.
-  * Added support for digest encrypted to AESNI_MB asynchronous crypto driver.
+  * Added support for digest encrypted to the AESNI_MB asynchronous crypto 
driver.
 
 * **Updated Intel QuickAssist Technology driver.**
 
@@ -272,8 +274,8 @@ New Features
 
 * **Added eventdev support to link queues to port with link profile.**
 
-  Introduced event link profiles that can be used to associated links between
-  event queues and an event port with a unique identifier termed as link 
profile.
+  Introduced event link profiles that can be used to associate links between
+  event queues and an event port with a unique identifier termed the "link 
profile".
   The profile can be used to switch between the associated links in fast-path
   without the additional overhead of linking/unlinking and waiting for 
unlinking.
 
@@ -298,8 +300,8 @@ New Features
 
 * **Added CLI based graph application.**
 
-  Added CLI based graph application which exercises on different use cases.
-  Application provides a framework so that each use case can be added via a 
file.
+  Added CLI based graph application which exercises different use cases.
+  The application provides a framework so that each use case can be added via 
a file.
   Each CLI will further be translated into a graph representing the use case.
 
 * **Added layer 2 MACsec forwarding example application.**
-- 
2.34.1

RE: [EXT] [PATCH v1] doc: update release notes for 23.11

[Anoob Joseph]

Hi John,

Please see inline.

Thanks,
Anoob

> -Original Message-
> From: John McNamara 
> Sent: Friday, November 24, 2023 5:35 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; John McNamara 
> Subject: [EXT] [PATCH v1] doc: update release notes for 23.11
> 
> External Email
> 
> --
> Fix grammar, spelling and formatting of DPDK 23.11 release notes.
> 
> Signed-off-by: John McNamara 
> ---
>  doc/guides/rel_notes/release_23_11.rst | 30 ++
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_23_11.rst
> b/doc/guides/rel_notes/release_23_11.rst
> index e16bc20466..f979c8f21a 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst



> @@ -212,12 +214,12 @@ New Features
>Added Rx inject API to allow applications to submit packets
>for protocol offload and have them injected back to ethdev Rx
>so that further ethdev Rx actions (IP reassembly, packet parsing and flow
> lookups)
> -  can happen based on inner packet.
> +  can happen based on the inner packet.
> 
> -  The API when implemented by an ethdev, application would be able to process
> +  When using the API when implemented by an ethdev the application
> + would be able to process
>packets that are received without/failed inline offload processing
>(such as fragmented ESP packets with inline IPsec offload).
> -  The API when implemented by a cryptodev, can be used for injecting packets
> +  When using the AP when implemented by a cryptodev it can be used for

[Anoob] The above should be API instead of AP. Can you correct the same?

Re: [PATCH v1] doc: update release notes for 23.11

[David Marchand]

Hello John,

On Fri, Nov 24, 2023 at 1:05 PM John McNamara  wrote:
> @@ -92,9 +92,11 @@ New Features
>
>  * **Added support for power intrinsics with AMD processors.**

You forgot to remove this line above, before adding the rewording below.

>
> -* **Added support for allow/block list in vmbus bus driver.***
> +  Added support for power intrinsics with AMD processors.
>
> -  The ``vmbus`` bus driver now supports -a and -b EAL options for selecting
> +* **Added support for allow/block list in vmbus bus driver.**
> +
> +  The ``vmbus`` bus driver now supports ``-a`` and ``-b`` EAL options for 
> selecting
>devices.
>
>  * **Added mbuf recycling support.**


-- 
David Marchand

Re: [PATCH 0/5] Some documentation fixes

[David Marchand]

On Thu, Nov 23, 2023 at 12:44 PM David Marchand
 wrote:
>
> Not urgent for the release (especially the last patch which is scary by
> its size) but here are some cleanups in the documentation.
>
>
> --
> David Marchand
>
> David Marchand (5):
>   doc: remove restriction on ixgbe vector support
>   doc: enhance readability in memif example commands
>   doc: fix some ordered lists
>   doc: remove number of commands in vDPA guide
>   doc: use ordered list

Series applied with minor changes following comments.
Thanks.


-- 
David Marchand

Re: [PATCH] doc/guides: refer to generic binding devices section

[David Marchand]

On Wed, Nov 15, 2023 at 11:10 AM Maxime Coquelin
 wrote:
> On 10/6/23 14:55, David Marchand wrote:
> > Rather than copy/paste everywhere how to bind a device and create VF
> > devices, refer to the Linux GSG section about it.
> >
> > Signed-off-by: David Marchand 
> Reviewed-by: Maxime Coquelin 

Applied, thanks.


-- 
David Marchand

Re: net/virtio: duplicated xstats

[Edwin Brossette]

Hello again,

The flag is already set during the device init, so it should be removed,
not added.
I can confirm removing it fixed my issue.

I will submit a patch for this bug.

Regards,
Edwin Brossette.

On Fri, Nov 24, 2023 at 11:39 AM Maxime Coquelin 
wrote:

> Hi Edwin,
>
> Thanks for reporting the issue.
>
> On 11/24/23 10:26, Olivier Matz wrote:
> > Fix Maxime's mail.
>
> Thanks Olivier.
>
> > On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote:
> >> Hello,
> >>
> >> I noticed a small inconsistency in the virtio pmd's xstats.
> >> The stat "rx_q0_errors" appears twice.
> >> I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets"
> and
> >> "tx_q0_bytes" are duplicates of "rx_q0_good_packets",
> "rx_q0_good_bytes",
> >> "tx_q0_good_packets" and "tx_q0_good_bytes"
> >>
> >> I believe this issue probably appeared after this commit:
> >>
> >> f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats
> >>
> http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2
>
> Adding Ferruh as he is the author of this commit.
>
> >>  From what I understand, the rxq0_error stat was originally reported by
> the
> >> librte. However, changes were made so it is reported by the pmd instead.
> >> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep
> the
> >> old behaviour so that every pmd could have time to adapt the change.
> >> But it seems the flag was forgotten in the virtio pmd and as a result,
> some
> >> stats are fetched at two different times when displaying xstats.
>
> Have you tried adding this flag to Virtio PMD? Does it fixes the issue?
>
> >> First in lib_rte_ethdev:
> >> https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266
> >> (you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag
> before
> >> the snprintf on eth_dev_rxq_stats_strings[] )
> >>
> >> And a second time in the virtio pmd:
> >> https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705
> pmd
> >> (see the snprintf on rte_virtio_rxq_stat_strings[] )
> >>
> >> This problem can be reproduced on testpmd simply by displaying the
> xstats
> >> on a port with the net_virtio driver:
> >>
> >> Reproduction:
> >> ===
> >>
> >>  1) start dpdk-testpmd:
> >>
> >> modprobe -a uio_pci_generic
> >> dpdk-devbind -b uio_pci_generic 03:00.0
> >> dpdk-devbind -b uio_pci_generic 04:00.0
> >>
> >> dpdk-devbind -s
> >>
> >> Network devices using DPDK-compatible driver
> >> 
> >> :03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
> >> unused=vfio-pci
> >> :04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
> >> unused=vfio-pci
> >> [...]
> >>
> >> dpdk-testpmd -a :03:00.0 -a :04:00.0 -- -i --rxq=1 --txq=1
> >> --coremask=0x4 --total-num-mbufs=25
> >> EAL: Detected CPU lcores: 3
> >> EAL: Detected NUMA nodes: 1
> >> EAL: Detected static linkage of DPDK
> >> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> >> EAL: Selected IOVA mode 'PA'
> >> EAL: VFIO support initialized
> >> EAL: Probe PCI driver: net_virtio (1af4:1041) device: :03:00.0
> (socket
> >> -1)
> >> EAL: Probe PCI driver: net_virtio (1af4:1041) device: :04:00.0
> (socket
> >> -1)
> >> Interactive-mode selected
> >> Warning: NUMA should be configured manually by using --port-numa-config
> and
> >> --ring-numa-config parameters along with --numa.
> >> testpmd: create a new mbuf pool : n=25, size=2176,
> socket=0
> >> testpmd: preferred mempool ops selected: ring_mp_mc
> >> Configuring Port 0 (socket 0)
> >> Port 0: 52:54:00:B0:8F:88
> >> Configuring Port 1 (socket 0)
> >> Port 1: 52:54:00:EF:09:1F
> >> Checking link statuses...
> >> Done
> >>
> >>  2) port info:
> >>
> >> show port info 0
> >>
> >> * Infos for port 0  *
> >> MAC address: 52:54:00:B0:8F:88
> >> Device name: :03:00.0
> >> Driver name: net_virtio
> >> Firmware-version: not available
> >> Devargs:
> >> Connect to socket: 0
> >> memory allocation on the socket: 0
> >> Link status: up
> >> Link speed: Unknown
> >> Link duplex: full-duplex
> >> Autoneg status: On
> >> MTU: 1500
> >> Promiscuous mode: enabled
> >> Allmulticast mode: disabled
> >> Maximum number of MAC addresses: 64
> >> Maximum number of MAC addresses of hash filtering: 0
> >> VLAN offload:
> >>strip off, filter off, extend off, qinq strip off
> >> No RSS offload flow type is supported.
> >> Minimum size of RX buffer: 64
> >> Maximum configurable length of RX packet: 9728
> >> Maximum configurable size of LRO aggregated packet: 0
> >> Current number of RX queues: 1
> >> Max possible RX queues: 1
> >> Max possible number of RXDs per queue: 32768
> >> Min possible number of RXDs per queue: 32
> >> RXDs number alignment: 1
> >> Current number of TX queues: 1
> >> Max possible TX queues: 1
> >> Max possible number of TXDs per queue: 32768
> >> Min possible number of TXDs per queue: 32
> >> 

Re: net/virtio: duplicated xstats

[Maxime Coquelin]

On 11/24/23 14:13, Edwin Brossette wrote:

Hello again,

The flag is already set during the device init, so it should be removed, 
not added.

I can confirm removing it fixed my issue.

I will submit a patch for this bug.

g

Great, thanks Edwin!

Don't forget to add the Fixes: tag and cc sta...@dpdk.org.

Maxime


Regards,
Edwin Brossette.

On Fri, Nov 24, 2023 at 11:39 AM Maxime Coquelin 
mailto:maxime.coque...@redhat.com>> wrote:


Hi Edwin,

Thanks for reporting the issue.

On 11/24/23 10:26, Olivier Matz wrote:
 > Fix Maxime's mail.

Thanks Olivier.

 > On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote:
 >> Hello,
 >>
 >> I noticed a small inconsistency in the virtio pmd's xstats.
 >> The stat "rx_q0_errors" appears twice.
 >> I also think the stats "rx_q0_packets", "rx_q0_bytes",
"tx_q0_packets" and
 >> "tx_q0_bytes" are duplicates of "rx_q0_good_packets",
"rx_q0_good_bytes",
 >> "tx_q0_good_packets" and "tx_q0_good_bytes"
 >>
 >> I believe this issue probably appeared after this commit:
 >>
 >> f30e69b41f94: ethdev: add device flag to bypass auto-filled
queue xstats
 >>

http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2
 


Adding Ferruh as he is the author of this commit.

 >>  From what I understand, the rxq0_error stat was originally
reported by the
 >> librte. However, changes were made so it is reported by the pmd
instead.
 >> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set
to keep the
 >> old behaviour so that every pmd could have time to adapt the change.
 >> But it seems the flag was forgotten in the virtio pmd and as a
result, some
 >> stats are fetched at two different times when displaying xstats.

Have you tried adding this flag to Virtio PMD? Does it fixes the issue?

 >> First in lib_rte_ethdev:
 >> https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266

 >> (you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS
flag before
 >> the snprintf on eth_dev_rxq_stats_strings[] )
 >>
 >> And a second time in the virtio pmd:
 >>
https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705 
 pmd
 >> (see the snprintf on rte_virtio_rxq_stat_strings[] )
 >>
 >> This problem can be reproduced on testpmd simply by displaying
the xstats
 >> on a port with the net_virtio driver:
 >>
 >> Reproduction:
 >> ===
 >>
 >>      1) start dpdk-testpmd:
 >>
 >> modprobe -a uio_pci_generic
 >> dpdk-devbind -b uio_pci_generic 03:00.0
 >> dpdk-devbind -b uio_pci_generic 04:00.0
 >>
 >> dpdk-devbind -s
 >>
 >> Network devices using DPDK-compatible driver
 >> 
 >> :03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
 >> unused=vfio-pci
 >> :04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic
 >> unused=vfio-pci
 >> [...]
 >>
 >> dpdk-testpmd -a :03:00.0 -a :04:00.0 -- -i --rxq=1 --txq=1
 >> --coremask=0x4 --total-num-mbufs=25
 >> EAL: Detected CPU lcores: 3
 >> EAL: Detected NUMA nodes: 1
 >> EAL: Detected static linkage of DPDK
 >> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
 >> EAL: Selected IOVA mode 'PA'
 >> EAL: VFIO support initialized
 >> EAL: Probe PCI driver: net_virtio (1af4:1041) device:
:03:00.0 (socket
 >> -1)
 >> EAL: Probe PCI driver: net_virtio (1af4:1041) device:
:04:00.0 (socket
 >> -1)
 >> Interactive-mode selected
 >> Warning: NUMA should be configured manually by using
--port-numa-config and
 >> --ring-numa-config parameters along with --numa.
 >> testpmd: create a new mbuf pool : n=25,
size=2176, socket=0
 >> testpmd: preferred mempool ops selected: ring_mp_mc
 >> Configuring Port 0 (socket 0)
 >> Port 0: 52:54:00:B0:8F:88
 >> Configuring Port 1 (socket 0)
 >> Port 1: 52:54:00:EF:09:1F
 >> Checking link statuses...
 >> Done
 >>
 >>      2) port info:
 >>
 >> show port info 0
 >>
 >> * Infos for port 0  *
 >> MAC address: 52:54:00:B0:8F:88
 >> Device name: :03:00.0
 >> Driver name: net_virtio
 >> Firmware-version: not available
 >> Devargs:
 >> Connect to socket: 0
 >> memory allocation on the socket: 0
 >> Link status: up
 >> Link speed: Unknown
 >> Link duplex: full-duplex
 >> Autoneg status: On
 >> MTU: 1500
 >> Promiscuous mode: enabled
 >> Allmulticast mode

Re: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'

[David Marchand]

On Fri, Nov 24, 2023 at 4:31 AM Sunyang Wu  wrote:
>
> Fix the issue of incorrect definition of 'NVGRE_ENCAP', and
> modified the error comments of 'rte_flow_action_nvgre_encap'.
>
> Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter")
> Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions")

Please use the format for Fixes tag described in the contributing guide.

Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object
converter")
Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions")

> Cc: sta...@dpdk.org

Copying more maintainers.
Apart from readability, I think this patch does not fix any real bug, does it?

>
> Signed-off-by: Joey Xing 
> Signed-off-by: Sunyang Wu 


-- 
David Marchand

Re: [PATCH] doc/rel_notes: add note on libarchive dependencies

[David Marchand]

On Thu, Nov 9, 2023 at 11:52 AM Bruce Richardson
 wrote:
>
> Since DPDK now registers an explicit dependency on libarchive, rather
> than just putting -larchive in link args, we need to add a documentation
> note about potential missing dependencies when static linking.
>
> Signed-off-by: Bruce Richardson 

Reviewed-by: David Marchand 

Applied, thanks.

-- 
David Marchand

Re: [PATCH] doc/contributing: update RST text-wrapping guidelines

[David Marchand]

On Fri, Nov 3, 2023 at 2:29 PM Bruce Richardson
 wrote:
>
> Update and clarify the guidelines on how to wrap lines in our RST docs.
> We no longer limit lines to just 80 characters, and what is more
> important that line length is the wrapping of sentences, starting a new
> sentence on a new line, and wrapping at punctuation.
>
> Signed-off-by: Bruce Richardson 

Acked-by: Ferruh Yigit 
Acked-by: Thomas Monjalon 

Applied, thanks.

-- 
David Marchand

Re: [PATCH] docs: add note about experimental API in LTS

[David Marchand]

On Fri, Oct 20, 2023 at 4:19 PM Kevin Traynor  wrote:
>
> The justification and impact for changing experimental API on LTS
> branches is different from the main branch. So the policy that is
> being used for allowing experimental APIs to change is stricter on
> the LTS branches.
>
> This was not documented anywhere, so add some documentation.
>
> Suggested-by: David Marchand 
> Signed-off-by: Kevin Traynor 

Thanks Kevin, applied.


-- 
David Marchand

[PATCH] net/virtio: fix duplicated rxq xstats

[edwin . brossette]

From: Edwin Brossette 

The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while
moving queue stats from 'struct rte_eth_stats' to the individual pmds,
as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass
auto-filled queue xstats").

This flag was added so every pmd would keep its original behavior until
the change was implemented. However, this flag was not removed
afterwards in the virtio pmd and as a result, some queue stats are
displayed twice when trying to get them: once in lib_rte_ethdev, and a
second time in the virtio pmd.

Remove this flag so stats are printed only once.

Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue 
xstats")
Cc: sta...@dpdk.org

Signed-off-by: Edwin Brossette 
---
 drivers/net/virtio/virtio_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c 
b/drivers/net/virtio/virtio_ethdev.c
index c2c0a1a11137..517585740eeb 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1793,8 +1793,6 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t 
req_features)
else
eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;
 
-   eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
-
/* Setting up rx_header size for the device */
if (virtio_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF) ||
virtio_with_feature(hw, VIRTIO_F_VERSION_1) ||
-- 
2.35.0.4.g44a5d4affccf

Re: [PATCH] doc: relax requirement on commit messages of security fixes

[David Marchand]

On Thu, Mar 10, 2022 at 7:00 PM  wrote:
>
> From: Luca Boccassi 
>
> Allow more flexibility with embargo lifting by not requiring
> mentions of CVEs in commit messages if the lift date allows
> it.
>
> Signed-off-by: Luca Boccassi 

Applied, thanks Luca.


-- 
David Marchand

Re: [PATCH] vfio: add get device info API

[Burakov, Anatoly]

On 11/14/2023 11:48 AM, Mingjin Ye wrote:

This patch adds an API to support getting device information.

The driver can use the "rte_vfio_get_device_info" helper to get
device information from EAL.

Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
  lib/eal/include/rte_vfio.h | 26 ++
  lib/eal/linux/eal_vfio.c   | 19 +++
  lib/eal/version.map|  1 +
  3 files changed, 46 insertions(+)

diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
index 3487c4f2a2..b3f55963e3 100644
--- a/lib/eal/include/rte_vfio.h
+++ b/lib/eal/include/rte_vfio.h
@@ -212,6 +212,32 @@ int
  rte_vfio_get_group_num(const char *sysfs_base,
  const char *dev_addr, int *iommu_group_num);
  
+/**

+ * Get device information
+ *
+ * This function is only relevant to linux and will return
+ * an error on BSD.
+ *
+ * @param sysfs_base
+ *   sysfs path prefix.
+ *
+ * @param dev_addr
+ *   device location.
+ *
+ * @param vfio_dev_fd
+ *   VFIO fd.
+ *
+ * @param device_info
+ *   Device information.
+ *
+ * @return
+ *   0 on success.
+ *   <0 on failure.
+ */
+int
+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info);
+
  /**
   * Open a new VFIO container fd
   *
diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
index ad3c1654b2..5810d9fcd7 100644
--- a/lib/eal/linux/eal_vfio.c
+++ b/lib/eal/linux/eal_vfio.c
@@ -1222,6 +1222,25 @@ vfio_set_iommu_type(int vfio_container_fd)
return NULL;
  }
  
+int

+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info)
+{
+   if (!device_info || *vfio_dev_fd < 0)
+   return -1;


Do we not need to check other parameters? E.g. sysfs_base, dev_addr, 
vfio_dev_fd itself (could be NULL dereference).



+
+   if (*vfio_dev_fd == 0) {
+   if (rte_vfio_setup_device(sysfs_base, dev_addr,
+   vfio_dev_fd, device_info))
+   return -1;
+   } else {
+   if (ioctl(*vfio_dev_fd, VFIO_DEVICE_GET_INFO, &device_info))
+   return -1;
+   }


Couldn't this just be an `else if`?

Would also be nice to have some DEBUG output here.

With all of the above addressed,

Acked-by: Anatoly Burakov 


+
+   return 0;
+}
+
  int
  vfio_has_supported_extensions(int vfio_container_fd)
  {
diff --git a/lib/eal/version.map b/lib/eal/version.map
index e00a844805..8b4a9c237e 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -300,6 +300,7 @@ DPDK_24 {
rte_vfio_noiommu_is_enabled; # WINDOWS_NO_EXPORT
rte_vfio_release_device; # WINDOWS_NO_EXPORT
rte_vfio_setup_device; # WINDOWS_NO_EXPORT
+   rte_vfio_get_device_info; # WINDOWS_NO_EXPORT
rte_zmalloc;
rte_zmalloc_socket;
  


--
Thanks,
Anatoly

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

[David Marchand]

On Thu, Nov 23, 2023 at 7:34 AM Lingli Chen  wrote:
>
> Add tested Intel platforms with Intel NICs to v23.11 release note.
>
> Signed-off-by: Lingli Chen 

Applied, thanks.


-- 
David Marchand

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

[David Marchand]

On Thu, Nov 23, 2023 at 11:19 AM Raslan Darawsheh  wrote:
>
> Add tested platforms with NVIDIA NICs to the 23.11 release notes.
>
> Signed-off-by: Raslan Darawsheh 

Removed spurious : in the middle of the patch.
Applied, thanks.


-- 
David Marchand

RE: [PATCH v1] doc: update release notes for 23.11

[Mcnamara, John]

> -Original Message-
> From: David Marchand 
> Sent: Friday, November 24, 2023 12:40 PM
> To: Mcnamara, John 
> Cc: dev@dpdk.org; tho...@monjalon.net
> Subject: Re: [PATCH v1] doc: update release notes for 23.11
> 
> Hello John,
> 
> On Fri, Nov 24, 2023 at 1:05 PM John McNamara 
> wrote:
> > @@ -92,9 +92,11 @@ New Features
> >
> >  * **Added support for power intrinsics with AMD processors.**
> 
> You forgot to remove this line above, before adding the rewording below.

Good catch.

I was trying to add a body line to the "power intrinsics with AMD processors" 
heading
Because the bare heading looked odd in the rendered docs but I must have 
deleted the
next heading by mistake.

I'll send a v2.

[PATCH v2] doc: update release notes for 23.11

[John McNamara]

Fix grammar, spelling and formatting of DPDK 23.11 release notes.

Signed-off-by: John McNamara 
---
v2: fix accidental deletion and typo


 doc/guides/rel_notes/release_23_11.rst | 28 ++
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index a2d8d74059..9584514be3 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -63,8 +63,8 @@ New Features
 
   More specifically, the requirements will be:
 
-  * Support for flag "-std=c11" (or similar)
-  * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag
+  * Support for flag ``-std=c11`` (or similar)
+  * ``__STDC_NO_ATOMICS__`` is *not defined* when using c11 flag
 
   Please note:
 
@@ -102,9 +102,11 @@ New Features
 
 * **Added support for power intrinsics with AMD processors.**
 
+  Added power intrinsics support for AMD processors.
+
 * **Added support for allow/block list in vmbus bus driver.***
 
-  The ``vmbus`` bus driver now supports -a and -b EAL options for selecting
+  The ``vmbus`` bus driver now supports ``-a`` and ``-b`` EAL options for 
selecting
   devices.
 
 * **Added mbuf recycling support.**
@@ -143,7 +145,7 @@ New Features
 
   For P4-programmable devices, hardware pipeline can be configured through
   a new "PROG" action type and its associated custom arguments.
-  Such P4 pipeline, not using the standard blocks of the flow API,
+  Such P4 pipelines, not using the standard blocks of the flow API,
   can be managed with ``RTE_FLOW_ITEM_TYPE_FLEX`` and 
``RTE_FLOW_ACTION_TYPE_PROG``.
 
 * **Added flow group set miss actions.**
@@ -155,7 +157,7 @@ New Features
 * **Updated Amazon ena (Elastic Network Adapter) net driver.**
 
   * Upgraded ENA HAL to latest version.
-  * Added support for connection tracking allowance utilization metric.
+  * Added support for connection tracking allowance utilization metrics.
   * Added support for reporting Rx overrun errors in xstats.
   * Added support for ENA-express metrics.
 
@@ -222,12 +224,12 @@ New Features
   Added Rx inject API to allow applications to submit packets
   for protocol offload and have them injected back to ethdev Rx
   so that further ethdev Rx actions (IP reassembly, packet parsing and flow 
lookups)
-  can happen based on inner packet.
+  can happen based on the inner packet.
 
-  The API when implemented by an ethdev, application would be able to process
+  When using the API implemented by an ethdev the application would be able to 
process
   packets that are received without/failed inline offload processing
   (such as fragmented ESP packets with inline IPsec offload).
-  The API when implemented by a cryptodev, can be used for injecting packets
+  When using the API implemented by a cryptodev it can be used for injecting 
packets
   to ethdev Rx after IPsec processing and take advantage of ethdev Rx actions
   for the inner packet which cannot be accelerated in inline protocol offload 
mode.
 
@@ -239,7 +241,7 @@ New Features
 * **Updated ipsec_mb crypto driver.**
 
   * Added Intel IPsec MB v1.5 library support for x86 platform.
-  * Added support for digest encrypted to AESNI_MB asynchronous crypto driver.
+  * Added support for digest encrypted to the AESNI_MB asynchronous crypto 
driver.
 
 * **Updated Intel QuickAssist Technology driver.**
 
@@ -282,8 +284,8 @@ New Features
 
 * **Added eventdev support to link queues to port with link profile.**
 
-  Introduced event link profiles that can be used to associated links between
-  event queues and an event port with a unique identifier termed as link 
profile.
+  Introduced event link profiles that can be used to associate links between
+  event queues and an event port with a unique identifier termed the "link 
profile".
   The profile can be used to switch between the associated links in fast-path
   without the additional overhead of linking/unlinking and waiting for 
unlinking.
 
@@ -308,8 +310,8 @@ New Features
 
 * **Added CLI based graph application.**
 
-  Added CLI based graph application which exercises on different use cases.
-  Application provides a framework so that each use case can be added via a 
file.
+  Added CLI based graph application which exercises different use cases.
+  The application provides a framework so that each use case can be added via 
a file.
   Each CLI will further be translated into a graph representing the use case.
 
 * **Added layer 2 MACsec forwarding example application.**
-- 
2.34.1

Re: [PATCH v2] maintainers: add mlx5 driver platform guides

[Thomas Monjalon]

24/11/2023 10:35, Dariusz Sosnowski:
> Add NVIDIA's platform specific guides to files maintained by networking
> mlx5 driver maintainers.
> 
> Signed-off-by: Dariusz Sosnowski 

Applied, thanks.

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

[Stephen Hemminger]

This is a better alternative.

From 52c805b9526dbef62377276c4499c997fbc96268 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger 
Date: Thu, 23 Nov 2023 11:12:02 -0800
Subject: [PATCH] common/dpaxx: replace zero length array

The zero length ip_header is used as an overlay to the
encap IP header. Since the code is already assuming the layout
of the structure, replace the array with direct access.

Signed-off-by: Stephen Hemminger 
---
 drivers/common/dpaax/caamflib/desc/ipsec.h | 20 ++--
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/common/dpaax/caamflib/desc/ipsec.h 
b/drivers/common/dpaax/caamflib/desc/ipsec.h
index 95fc3ea5ba3b..d1411cc6aab4 100644
--- a/drivers/common/dpaax/caamflib/desc/ipsec.h
+++ b/drivers/common/dpaax/caamflib/desc/ipsec.h
@@ -334,9 +334,7 @@ struct ipsec_encap_gcm {
  * @seq_num: IPsec sequence number
  * @spi: IPsec SPI (Security Parameters Index)
  * @ip_hdr_len: optional IP Header length (in bytes)
- *  reserved - 16b
- *  Opt. IP Hdr Len - 16b
- * @ip_hdr: optional IP Header content (only for IPsec legacy mode)
+ *  Ip header must follow directly after ipsec_encap_pdb
  */
 struct ipsec_encap_pdb {
uint32_t options;
@@ -350,7 +348,6 @@ struct ipsec_encap_pdb {
};
uint32_t spi;
uint32_t ip_hdr_len;
-   uint8_t ip_hdr[0];
 };
 
 static inline unsigned int
@@ -776,7 +773,12 @@ cnstr_shdsc_ipsec_encap(uint32_t *descbuf, bool ps, bool 
swap,
PROGRAM_SET_36BIT_ADDR(p);
phdr = SHR_HDR(p, share, hdr, 0);
__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);
-   COPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);
+
+   /* ip header if any follows the encap_pdb */
+   if (pdb->ip_hdr_len > 0) {
+   void *ip_hdr = pdb + 1;
+   COPY_DATA(p, ip_hdr, pdb->ip_hdr_len);
+   }
SET_LABEL(p, hdr);
pkeyjmp = JUMP(p, keyjmp, LOCAL_JUMP, ALL_TRUE, BOTH|SHRD);
if (authdata->keylen)
@@ -913,7 +915,13 @@ cnstr_shdsc_ipsec_encap_des_aes_xcbc(uint32_t *descbuf,
PROGRAM_CNTXT_INIT(p, descbuf, 0);
phdr = SHR_HDR(p, share, hdr, 0);
__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);
-   COPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);
+
+   /* ip header if any follows the encap_pdb */
+   if (pdb->ip_hdr_len > 0) {
+   void *ip_hdr = pdb + 1;
+   COPY_DATA(p, ip_hdr, pdb->ip_hdr_len);
+   }
+
SET_LABEL(p, hdr);
pkeyjump = JUMP(p, keyjump, LOCAL_JUMP, ALL_TRUE, SHRD | SELF);
/*
-- 
2.42.0

RE: [EXT] [PATCH 2/2] devtools: remove ABI exception for crypto asym operations

[Akhil Goyal]

> Those API are now stable.
> 
> Fixes: 79a4c2cda131 ("cryptodev: promote some functions as stable")
> 
> Signed-off-by: David Marchand 
> ---
Acked-by: Akhil Goyal 

[PATCH v3 0/6] doc/features: fix some features and add new features

[Huisong Li]

The support for setting RSS hash algorithm has been introduced to 23.11,
but doesn't add feature for it. So this series add this feature and perfect
RSS other features by the way.

In addition, serval features, like "set link up/down", "TM", "dump device
private information" and "loopback mode", had beed supported, but they are
absent from the freatures list.

---
 -v3:
   - fix description of the patchset cover
   - remove '/features' in 'doc/features' tag for every patch.
   - add Acked-by: Chengwen Feng 
   - retrigger CI build because of wrong CI warning

 -v2:
   - add loopback mode feature.

Huisong Li (6):
  doc: add RSS hash algorithm feature
  doc: add link up/down feature
  doc: add features for link speeds
  doc: add Traffic Manager feature
  doc: add dump device private information feature
  doc: add feature for loopback mode

 doc/guides/nics/features.rst | 78 ++--
 1 file changed, 74 insertions(+), 4 deletions(-)

-- 
2.33.0

[PATCH v3 3/6] doc: add features for link speeds

[Huisong Li]

Add features for link speeds.

Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index f14962a6c3..d13e43ae81 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -34,6 +34,17 @@ Supports getting the speed capabilities that the current 
device is capable of.
 * **[related]  API**: ``rte_eth_dev_info_get()``.
 
 
+.. _nic_features_link_speeds_config:
+
+Link speed configuration
+
+
+Supports configurating fixed speed and link autonegotiation.
+
+* **[uses] user config**: ``dev_conf.link_speeds:RTE_ETH_LINK_SPEED_*``.
+* **[related]  API**: ``rte_eth_dev_configure()``.
+
+
 .. _nic_features_link_status:
 
 Link status
-- 
2.33.0

[PATCH v3 2/6] doc: add link up/down feature

[Huisong Li]

Add link up/down feature for features.rst.

Fixes: 915e67837586 ("ethdev: API for link up and down")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 4 
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 0d38c5c525..f14962a6c3 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -45,6 +45,10 @@ Supports getting the link speed, duplex mode and link state 
(up/down).
 * **[implements] rte_eth_dev_data**: ``dev_link``.
 * **[related]API**: ``rte_eth_link_get()``, ``rte_eth_link_get_nowait()``.
 
+Set link up/down an Ethernet device.
+
+* **[implements] eth_dev_ops**: ``dev_set_link_up``, ``dev_set_link_down``.
+* **[related]API**: ``rte_eth_dev_set_link_up()``, 
``rte_eth_dev_set_link_down()``.
 
 .. _nic_features_link_status_event:
 
-- 
2.33.0

[PATCH v3 4/6] doc: add Traffic Manager feature

[Huisong Li]

Add Traffic Manager feature.

Fixes: 5d109deffa87 ("ethdev: add traffic management API")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 13 +
 1 file changed, 13 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index d13e43ae81..ef061759c7 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -773,6 +773,19 @@ Supports congestion management.
   ``rte_eth_cman_config_set()``, ``rte_eth_cman_config_get()``.
 
 
+.. _nic_features_traffic_manager:
+
+Traffic manager
+---
+
+Supports Traffic manager.
+
+* **[implements] rte_tm_ops**: ``capabilities_get``, ``shaper_profile_add``,
+  ``hierarchy_commit`` and so on.
+* **[related]API**: ``rte_tm_capabilities_get()``, 
``rte_tm_shaper_profile_add()``,
+  ``rte_tm_hierarchy_commit()`` and so on.
+
+
 .. _nic_features_fw_version:
 
 FW version
-- 
2.33.0

[PATCH v3 1/6] doc: add RSS hash algorithm feature

[Huisong Li]

Add hash algorithm feature introduced by 23.11 and fix some RSS features
description.

Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 26 ++
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 1a1dc16c1e..0d38c5c525 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -277,10 +277,12 @@ RSS hash
 Supports RSS hashing on RX.
 
 * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` = 
``RTE_ETH_MQ_RX_RSS_FLAG``.
-* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
+* **[uses] user config**: ``rss_conf.rss_hf``.
 * **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
 * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
 * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, ``mbuf.rss``.
+* **[related]  API**: ``rte_eth_dev_configure``, 
``rte_eth_dev_rss_hash_update``
+  ``rte_eth_dev_rss_hash_conf_get()``.
 
 
 .. _nic_features_inner_rss:
@@ -288,7 +290,7 @@ Supports RSS hashing on RX.
 Inner RSS
 -
 
-Supports RX RSS hashing on Inner headers.
+Supports RX RSS hashing on Inner headers by rte_flow API.
 
 * **[uses]rte_flow_action_rss**: ``level``.
 * **[uses]rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
@@ -303,9 +305,25 @@ RSS key update
 Supports configuration of Receive Side Scaling (RSS) hash computation. Updating
 Receive Side Scaling (RSS) hash key.
 
-* **[implements] eth_dev_ops**: ``rss_hash_update``, ``rss_hash_conf_get``.
+* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, 
``rss_hash_conf_get``.
+* **[uses] user config**: ``rss_conf.rss_key``, ``rss_conf.rss_key_len``
 * **[provides]   rte_eth_dev_info**: ``hash_key_size``.
-* **[related]API**: ``rte_eth_dev_rss_hash_update()``,
+* **[related]API**: ``rte_eth_dev_configure``, 
``rte_eth_dev_rss_hash_update()``,
+  ``rte_eth_dev_rss_hash_conf_get()``.
+
+
+.. _nic_features_rss_hash_algo_update:
+
+RSS hash algorithm update
+-
+
+Supports configuration of Receive Side Scaling (RSS) hash algorithm. Updating
+RSS hash algorithm.
+
+* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, 
``rss_hash_conf_get``.
+* **[uses] user config**: ``rss_conf.algorithm``
+* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``.
+* **[related]API**: ``rte_eth_dev_configure``, 
``rte_eth_dev_rss_hash_update()``,
   ``rte_eth_dev_rss_hash_conf_get()``.
 
 
-- 
2.33.0

[PATCH v3 5/6] doc: add dump device private information feature

[Huisong Li]

Add dump device private information feature.

Fixes: edcf22c6d389 ("ethdev: introduce dump API")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 12 
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index ef061759c7..c5c4dbf745 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -832,6 +832,18 @@ registers and register size).
 * **[related]API**: ``rte_eth_dev_get_reg_info()``.
 
 
+.. _nic_features_device_private_info_dump:
+
+Device private information dump
+---
+
+Supports retrieving device private information to a file. Provided data and
+the order depends on PMD.
+
+* **[implements] eth_dev_ops**: ``eth_dev_priv_dump``.
+* **[related]API**: ``rte_eth_dev_priv_dump()``.
+
+
 .. _nic_features_led:
 
 LED
-- 
2.33.0

[PATCH v3 6/6] doc: add feature for loopback mode

[Huisong Li]

Add feature for loopback mode.

Fixes: db0359256170 ("ixgbe: add Tx->Rx loopback mode for 82599")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 12 
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index c5c4dbf745..caf1258554 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -45,6 +45,18 @@ Supports configurating fixed speed and link autonegotiation.
 * **[related]  API**: ``rte_eth_dev_configure()``.
 
 
+.. _nic_features_loopback:
+
+Loopback configuration
+--
+
+Supports configurating loopback mode. The default value 0 is to disable
+loopback mode and other value is defined by given Ethernet controller.
+
+* **[uses] user config**: ``dev_conf.lpbk_mode``.
+* **[related]  API**: ``rte_eth_dev_configure()``.
+
+
 .. _nic_features_link_status:
 
 Link status
-- 
2.33.0