date:20230721

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

2023-07-21 Thread Sunil Kumar Kori

> -Original Message-
> From: Jerin Jacob 
> Sent: Friday, July 21, 2023 12:18 PM
> To: Rakesh Kudurumalla 
> Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; Yan,
> Zhirun ; tho...@monjalon.net; Jerin Jacob
> Kollanukkaran ; Nithin Kumar Dabilpuram
> ; Liang, Cunming ;
> Wang, Haiyue ; Sunil Kumar Kori
> 
> Subject: Re: [EXT] Re: [PATCH v2 4/4] app: add testgraph application
> 
> On Thu, Jul 20, 2023 at 9:22 PM Rakesh Kudurumalla
>  wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Vamsi Krishna Attunuru 
> > > Sent: Thursday, June 1, 2023 8:14 AM
> > > To: Jerin Jacob 
> > > Cc: Yan, Zhirun ; dev@dpdk.org;
> > > tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> > > Nithin Kumar Dabilpuram ; Liang, Cunming
> > > ; Wang, Haiyue ;
> > > Sunil Kumar Kori 
> > > Subject: RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application
> > >
> 
> >
> >
> > Example use case: l3fwd
> > 
> > ;Configure usecase
> > graph l3fwd default 0xff
> >
> > ;global specific configuration
> > mempool mempool0 size 2046 buffers 32000 cache 256 cpu 0 ethdev
> > 0002:02:00.0 rxq 1 txq 1 mempool0 promiscuous off ethdev 0002:03:00.0
> > rxq 1 txq 1 mempool0 promiscuous off
> > ip4 addr add 10.0.2.1/24 0002:02:00.0
> > ip4 addr add 10.0.3.1/24 0002:03:00.0
> > neigh add ipv4 10.0.2.2 52:20:DA:4F:68:70 neigh add ipv4 10.0.2.5
> > 62:20:DA:4F:68:70 neigh add ipv4 10.0.3.2 72:20:DA:4F:68:70 neigh add
> > ipv4 10.0.3.5 82:20:DA:4F:68:70
> >
> > ;node specific configuration
> > route add ipv4 ipv4_lookup 10.0.2.0 netmask 255.255.255.0 via 10.0.2.1
> > route add ipv4 ipv4_lookup  10.0.3.0 netmask 255.255.255.0 via
> > 10.0.3.1
> 
> I prefer to use node name first.
> 
Ack.

> >
> >
> > map ethdev_rx  port 0002:02:00.0 queue 0 core 6 map ethdev_rx  port
> > 0002:03:00.0 queue 1 core 5
> 
> I prefer to use node name first.
> 
Ack.

> Rest looks good to me.
> 
> >
> > ;Run usecase
> > graph start

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

2023-07-21 Thread Rakesh Kudurumalla

> -Original Message-
> From: Sunil Kumar Kori 
> Sent: Friday, July 21, 2023 12:31 PM
> To: Jerin Jacob ; Rakesh Kudurumalla
> 
> Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; Yan,
> Zhirun ; tho...@monjalon.net; Jerin Jacob
> Kollanukkaran ; Nithin Kumar Dabilpuram
> ; Liang, Cunming ;
> Wang, Haiyue 
> Subject: RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application
> 
> > -Original Message-
> > From: Jerin Jacob 
> > Sent: Friday, July 21, 2023 12:18 PM
> > To: Rakesh Kudurumalla 
> > Cc: Vamsi Krishna Attunuru ; dev@dpdk.org;
> Yan,
> > Zhirun ; tho...@monjalon.net; Jerin Jacob
> > Kollanukkaran ; Nithin Kumar Dabilpuram
> > ; Liang, Cunming ;
> > Wang, Haiyue ; Sunil Kumar Kori
> > 
> > Subject: Re: [EXT] Re: [PATCH v2 4/4] app: add testgraph application
> >
> > On Thu, Jul 20, 2023 at 9:22 PM Rakesh Kudurumalla
> >  wrote:
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Vamsi Krishna Attunuru 
> > > > Sent: Thursday, June 1, 2023 8:14 AM
> > > > To: Jerin Jacob 
> > > > Cc: Yan, Zhirun ; dev@dpdk.org;
> > > > tho...@monjalon.net; Jerin Jacob Kollanukkaran
> > > > ; Nithin Kumar Dabilpuram
> > > > ; Liang, Cunming
> > > > ; Wang, Haiyue ;
> > > > Sunil Kumar Kori 
> > > > Subject: RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph
> > > > application
> > > >
> >
> > >
> > >
> > > Example use case: l3fwd
> > > 
> > > ;Configure usecase
> > > graph l3fwd default 0xff
> > >
> > > ;global specific configuration
> > > mempool mempool0 size 2046 buffers 32000 cache 256 cpu 0 ethdev
> > > 0002:02:00.0 rxq 1 txq 1 mempool0 promiscuous off ethdev
> > > 0002:03:00.0 rxq 1 txq 1 mempool0 promiscuous off
> > > ip4 addr add 10.0.2.1/24 0002:02:00.0
> > > ip4 addr add 10.0.3.1/24 0002:03:00.0 neigh add ipv4 10.0.2.2
> > > 52:20:DA:4F:68:70 neigh add ipv4 10.0.2.5
> > > 62:20:DA:4F:68:70 neigh add ipv4 10.0.3.2 72:20:DA:4F:68:70 neigh
> > > add
> > > ipv4 10.0.3.5 82:20:DA:4F:68:70
> > >
> > > ;node specific configuration
> > > route add ipv4 ipv4_lookup 10.0.2.0 netmask 255.255.255.0 via
> > > 10.0.2.1 route add ipv4 ipv4_lookup  10.0.3.0 netmask 255.255.255.0
> > > via
> > > 10.0.3.1
> >
> > I prefer to use node name first.
> >
> Ack.
> 
> > >
> > >
> > > map ethdev_rx  port 0002:02:00.0 queue 0 core 6 map ethdev_rx  port
> > > 0002:03:00.0 queue 1 core 5
> >
> > I prefer to use node name first.
> >
> Ack.
> 
> > Rest looks good to me.
> >
> > >
> > > ;Run usecase
> > > graph start

Addressed comments and updated specification

Graph application Interface file
Configure Use cases
=
This section consists of which use cases are needed to be configured and model 
to be used along with number of coremask 
to run graph on that. Following is the exposed syntax to configure given use 
case.

Syntax:

graph  [usecase specific configuration]  [model specific 
configuration]

Where:

usecases: It is comma separated list defining the requested use cases. Example 
values are -
l3fwd
ipsec
usecase specific configuration: It defines following usecase specific 
configuration -
burst size (bsz)
timeout (tmo)
coremask
model: It defines the model for dequeuing packets.  Example models are -
run to completion (rtc)
multi core dispatch (mcd)
Global specific configuration
==
This section consists of device specific configuration which are needed to make 
a DPDK port usable such as number

of Rx/TX queues, MTU, mempool etc. Along with it consists global network table 
configuration required for each use case

such as configure IP address to device, arp entries for given IP etc. Supported 
hardware offloads to be used by 
this use case is also added under this configuration. Graph is created for this 
use case at the end of this configuration.

Syntax:

mempool  size  buffers  cache  

Where:

mempool_name  : Name of the mempool used for further pool operations.
size  : Size of each element in mempool
buffers: Number of elements in mempool
cache : Size of the per-core object cache
  : Socket id

Syntax:

ethdev  rxq  txq   promiscuous 
ethdev  tx_offload 
ethdev  rx_offload 
ethdev  promiscuous 
ethdev  mtu 

Where:

dbdf: PCI id of device in DBDF format or vdev name for 
non-pci devices.
rxq  : Number of Rx queues on device
txq  : Number of Tx queues on device
mempool_name : Mempool to be attached on RQ.
rx_offload   : Supported offloads on ingress. It is bitmask of required 
offloads. Valid offloads are combination of RTE_ETH_RX_OFFLOAD_*
tx_offload   : Supported offloads on egress. It is bitmask of required 
offloads. valid offloads are combination of RTE_ETH_TX_OFFLOAD_*
promiscuous   : Toggle promiscuous mode
mtu  : MTU size

Syntax:

neigh add ipv4  

Where:

ip: IPv4/IPv6 address for which MAC address is to be added.
mac: MAC  address which is to be configured corresponding to given IP. 

Syntax:

ip4 addr add

Re: [PATCH] net/mana: fix stats for txq bytes sent

2023-07-21 Thread Ferruh Yigit

On 7/20/2023 11:42 PM, lon...@linuxonhyperv.com wrote:
> From: Long Li 
> 
> Bytes should be calculated using the packet length, not the mbuf segment
> data length.
> 
> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Long Li 
>

Applied to dpdk-next-net/main, thanks.

RE: release candidate 23.07-rc4

2023-07-21 Thread Xu, HailinX

> -Original Message-
> From: Thomas Monjalon 
> Sent: Thursday, July 20, 2023 1:16 PM
> To: annou...@dpdk.org
> Subject: release candidate 23.07-rc4
> 
> A new DPDK release candidate is ready for testing:
>   https://git.dpdk.org/dpdk/tag/?id=v23.07-rc4
> 
> There are 37 new patches in this snapshot.
> 
> Release notes:
>   https://doc.dpdk.org/guides/rel_notes/release_23_07.html
> 
> Except few policy updates and last minute release notes, everything ready and
> not risky should be there in DPDK 23.07-rc4.
> Do not forget to review the deprecation notices.
> 
> You may share some release validation results by replying to this message at
> dev@dpdk.org and by adding tested hardware in the release notes.
> 
> Please think about sharing your roadmap now for DPDK 23.11.
> 
> Thank you everyone
> 
Update the test status for Intel part. Till now dpdk23.07-rc4 test execution 
rate is 70%. no critical issue found.
# Basic Intel(R) NIC testing
* Build or compile:  
 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.2, Fedora38, 
RHEL8.7/9.2, Centos7.9, OpenAnolis8.8, CBL-Mariner2.0 etc.
  - All test passed.
 *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.2 
and RHEL9.0.
  - All test passed with latest dpdk.
* Meson test & Asan test: 
known issue:
- [dpdk23.07][asan] multiprocess_iavf/multiprocess_simple_mpbasicoperation: 
AddressSanitizer: heap-use-after-free -> Intel dev is under investigating
- https://bugs.dpdk.org/show_bug.cgi?id=1107 [22.11-rc1][meson test] 
seqlock_autotest test failed
- https://bugs.dpdk.org/show_bug.cgi?id=1123 [dpdk-22.11][asan] the 
stack-buffer-overflow was found when quit testpmd in Redhat9
- https://bugs.dpdk.org/show_bug.cgi?id=1250 [dpdk-23.07][meson test] 
driver-tests/cryptodev_openssl_asym_autotest blocked in RHEL9.0 -> has fix patch
* PF/VF(i40e, ixgbe): test scenarios including 
PF/VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
  - All test done. No new issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow 
Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
  - execution rate is 80%. No new issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single 
core performance test, RFC2544 Zero packet loss performance test, etc.
  - execution rate is 50%. No new issue is found.
* Power and IPsec: 
 * Power: test scenarios including bi-direction/Telemetry/Empty Poll 
Lib/Priority Base Frequency, etc. 
  - execution rate is 50%. No new issue is found. 
 * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - 
QAT&SW/FIB library, etc.
  - on going. No new issue is found. 
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 8.0, etc.
  - execution rate is 40%. No new issue is found.
* Cryptodev: 
 *Function test: test scenarios including Cryptodev API testing/CompressDev 
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
  - on going. No new issue is found.
 *Performance test: test scenarios including Throughput Performance /Cryptodev 
Latency, etc.
  - on going. No new issue is found.

Regards,
Xu, Hailin

[POC v3] net/iavf: support no data path polling mode

2023-07-21 Thread Mingjin Ye

Currently, during a PF to VF reset due to an action such as changing
trust settings on a VF, the DPDK application running with iavf PMD
loses connectivity, and the only solution is to reset the DPDK
application.

Instead of forcing a reset of the DPDK application to restore
connectivity, the iavf PMD driver handles the PF to VF reset event
normally by performing all necessary steps to bring the VF back
online.

To minimize downtime, a devargs "no-poll-on-link-down" is introduced
in iavf PMD. When this flag is set, the PMD switches to no-poll mode
when the link state is down (rx/tx bursts return to 0 immediately).
When the link state returns to normal, the PMD switches to normal
rx/tx burst state.

NOTE: The DPDK application needs to handle the
RTE_ETH_EVENT_INTR_RESET event posted by the iavf PMD and reset
the vf upon receipt of this event.

Signed-off-by: Mingjin Ye 
---
V2: Add IAVF_NO_POLL_ON_LINK_DOWN_ARG macro to iavf_valid_args.
---
V3: Improve commit log.
---
 drivers/net/iavf/iavf.h |  2 ++
 drivers/net/iavf/iavf_ethdev.c  | 11 +++
 drivers/net/iavf/iavf_rxtx.c| 29 +++--
 drivers/net/iavf/iavf_rxtx.h|  1 +
 drivers/net/iavf/iavf_rxtx_vec_avx2.c   | 29 ++---
 drivers/net/iavf/iavf_rxtx_vec_avx512.c | 42 ++---
 drivers/net/iavf/iavf_rxtx_vec_sse.c| 21 -
 drivers/net/iavf/iavf_vchnl.c   | 17 ++
 8 files changed, 140 insertions(+), 12 deletions(-)

diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index 98861e4242..30b05d25b6 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -305,6 +305,7 @@ struct iavf_devargs {
uint8_t proto_xtr[IAVF_MAX_QUEUE_NUM];
uint16_t quanta_size;
uint32_t watchdog_period;
+   uint16_t no_poll_on_link_down;
 };
 
 struct iavf_security_ctx;
@@ -323,6 +324,7 @@ struct iavf_adapter {
uint32_t ptype_tbl[IAVF_MAX_PKT_TYPE] __rte_cache_min_aligned;
bool stopped;
bool closed;
+   bool no_poll;
uint16_t fdir_ref_cnt;
struct iavf_devargs devargs;
 };
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index ac7154d720..c922c64838 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -37,6 +37,7 @@
 #define IAVF_PROTO_XTR_ARG "proto_xtr"
 #define IAVF_QUANTA_SIZE_ARG   "quanta_size"
 #define IAVF_RESET_WATCHDOG_ARG"watchdog_period"
+#define IAVF_NO_POLL_ON_LINK_DOWN_ARG   "no-poll-on-link-down"
 
 uint64_t iavf_timestamp_dynflag;
 int iavf_timestamp_dynfield_offset = -1;
@@ -45,6 +46,7 @@ static const char * const iavf_valid_args[] = {
IAVF_PROTO_XTR_ARG,
IAVF_QUANTA_SIZE_ARG,
IAVF_RESET_WATCHDOG_ARG,
+   IAVF_NO_POLL_ON_LINK_DOWN_ARG,
NULL
 };
 
@@ -2237,6 +2239,7 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
struct rte_kvargs *kvlist;
int ret;
int watchdog_period = -1;
+   uint16_t no_poll_on_link_down;
 
if (!devargs)
return 0;
@@ -2270,6 +2273,14 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
else
ad->devargs.watchdog_period = watchdog_period;
 
+   no_poll_on_link_down = rte_kvargs_count(kvlist,
+   IAVF_NO_POLL_ON_LINK_DOWN_ARG);
+
+   if (no_poll_on_link_down == 0)
+   ad->devargs.no_poll_on_link_down = 0;
+   else
+   ad->devargs.no_poll_on_link_down = 1;
+
if (ad->devargs.quanta_size != 0 &&
(ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||
 ad->devargs.quanta_size & 0x40)) {
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index f7df4665d1..447e306fee 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -770,6 +770,7 @@ iavf_dev_tx_queue_setup(struct rte_eth_dev *dev,
IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct iavf_info *vf =
IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+   struct iavf_vsi *vsi = &vf->vsi;
struct iavf_tx_queue *txq;
const struct rte_memzone *mz;
uint32_t ring_size;
@@ -843,6 +844,7 @@ iavf_dev_tx_queue_setup(struct rte_eth_dev *dev,
txq->port_id = dev->data->port_id;
txq->offloads = offloads;
txq->tx_deferred_start = tx_conf->tx_deferred_start;
+   txq->vsi = vsi;
 
if (iavf_ipsec_crypto_supported(adapter))
txq->ipsec_crypto_pkt_md_offset =
@@ -1406,9 +1408,12 @@ iavf_recv_pkts(void *rx_queue, struct rte_mbuf 
**rx_pkts, uint16_t nb_pkts)
uint64_t pkt_flags;
const uint32_t *ptype_tbl;
 
+   rxq = rx_queue;
+   if (!rxq->vsi || rxq->vsi->adapter->no_poll)
+   return 0;
+
nb_rx = 0;
nb_hold = 0;
-   rxq = rx_queue;
rx_id = rxq->rx_tail;
rx_ring = rxq->rx_ring;
ptype

crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou

Hi Guys,

Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf 
application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is 
called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count 
test does not expect to support decryption. Or is it a bug?

I have no idea with the application design background, is it expected?

Thanks,
Suanming Mou

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

2023-07-21 Thread Hemant Agrawal


Acked-by: Hemant Agrawal 

On 21-Jul-23 10:58 AM, Gagandeep Singh wrote:

Caution: This is an external email. Please take care when clicking links or 
opening attachments. When in doubt, report the message using the 'Report this 
email' button


when RTE_ENABLE_ASSERT is enable, DPAA driver is doing
wrong NULL check on frame queue which allows the code
to have access to NULL address.
GCC v13 is giving array bounds error if code is
accessing any memory region less than 4KB.
This patch fixes this issue by adding proper NULL checks
on frame queue.

Please refer: https://bugs.dpdk.org/show_bug.cgi?id=1233

Bugzilla ID: 1233
Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
Cc: sta...@dpdk.org

Signed-off-by: Gagandeep Singh 
---
  drivers/bus/dpaa/base/qbman/qman.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
b/drivers/bus/dpaa/base/qbman/qman.c
index 3949bf8712..83db0a534e 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -1,7 +1,7 @@
  /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
   *
   * Copyright 2008-2016 Freescale Semiconductor Inc.
- * Copyright 2017,2019 NXP
+ * Copyright 2017,2019-2023 NXP
   *
   */

@@ -897,7 +897,7 @@ static u32 __poll_portal_slow(struct qman_portal *p, u32 is)
 /* Lookup in the retirement table */
 fq = table_find_fq(p,
be32_to_cpu(msg->fq.fqid));
-   DPAA_BUG_ON(!fq);
+   DPAA_BUG_ON(fq != NULL);
 fq_state_change(p, fq, &swapped_msg, verb);
 if (fq->cb.fqs)
 fq->cb.fqs(p, fq, &swapped_msg);
@@ -909,6 +909,7 @@ static u32 __poll_portal_slow(struct qman_portal *p, u32 is)
  #else
 fq = (void *)(uintptr_t)msg->fq.contextB;
  #endif
+   DPAA_BUG_ON(fq != NULL);
 fq_state_change(p, fq, msg, verb);
 if (fq->cb.fqs)
 fq->cb.fqs(p, fq, &swapped_msg);
--
2.25.1

[PATCH] app/test: fix include of standard header

2023-07-21 Thread Bruce Richardson

Standard headers, or headers not in the current directory generally,
should be wrapped in "<>" rather than in regular quotes "". Fix one
instance of unistd.h being included using quotes

Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 app/test/test_link_bonding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 5c496352c2..2f46e4c6ee 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -2,7 +2,7 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include "unistd.h"
+#include 
 #include 
 #include 
 #include 
-- 
2.39.2

RE: [PATCH] app/test: fix include of standard header

2023-07-21 Thread Morten Brørup

> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 21 July 2023 12.57
> 
> Standard headers, or headers not in the current directory generally,
> should be wrapped in "<>" rather than in regular quotes "". Fix one
> instance of unistd.h being included using quotes
> 
> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bruce Richardson 
> ---

Acked-by: Morten Brørup

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Akhil Goyal

Hi Suanming,

The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue.
It does not matter what is the content of the packet, as we are not validating 
the content
after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload 
and
will process it as per the session attached.
Hence, doing memcpy to mbuf is not required.

Regards,
Akhil

From: Suanming Mou 
Sent: Friday, July 21, 2023 4:06 PM
To: ciara.po...@intel.com; Akhil Goyal 
Cc: dev@dpdk.org
Subject: [EXT] crypto decryption support in test-crypto-perf pmd-cycle-count 
test

External Email

Hi Guys,

Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf 
application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is 
called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count 
test does not expect to support decryption. Or is it a bug?

I have no idea with the application design background, is it expected?

Thanks,
Suanming Mou

[RFC PATCH 0/5] replace build code for unit tests

2023-07-21 Thread Bruce Richardson

While working on series such as [1] to make DPDK builds more
configurable, the majority of the complexity involved centered on the
unit tests, and ensuring that the individual files were added/removed
from the build as the components were enabled/disabled.

This complexity was exacerbated by:
* C files having multiple dependencies, specifically,
* Some libraries having one set of independent tests, while other
  library tests requiring additional components
* Having to maintain lists of tests in various suites which also needed
  to be updated, depending on component availability.
* Everything having to be checked via if-else clauses, since this was
  not data-driven

This RFC attempts to address these issues by doing the following:
* Creating a per-file dependency list for the autotests, allowing easy
  checks of when a file could be built
* Tagging the various fast-tests/perf-tests/drivers-tests suites via
  macros in the C code. Then scan the C-files we are building to
  construct the test suites based on what is available


This RFC is just an early prototype, and probably needs cleanup and
validation of the dependency lists. Windows support is probably also
broken, given the fact that our current build file maintains custom
lists there. However, I would hope it should not be too big a job to
enable the unit tests for the windows components that are already
available. (Tests for any components not being build on windows are
already removed via the dependency lists).

Another (hopefully less-impactful) side-effect of this change is that
the "test" binary has moved in the build folder. It is now put
along-side the other binaries in "build/app" rather than being in the
subdirectory "build/app/test".

Future work could also be done to scan the C files that are not being
build for tests. Those tests could then be stubbed out in an
auto-genereated file to always return "SKIPPED", meaning that all test
commands are always valid, irrespective of what components are present
or not.

[1] http://patches.dpdk.org/project/dpdk/list/?series=28628&state=10

Bruce Richardson (5):
  app/test: add new macros for various test types
  app/test: tag tests with the test type
  app/test: build using per-file dependency matrix
  app/test: define unit tests suites based on test macros
  app/test: add fast test suite to new build infrastructure

 app/meson.build   |  15 +-
 app/test/meson.build  | 796 +-
 app/test/suites/meson.build   |  75 ++
 app/test/test.h   |   9 +-
 app/test/test_acl.c   |   2 +-
 app/test/test_atomic.c|   2 +-
 app/test/test_barrier.c   |   2 +-
 app/test/test_bitmap.c|   2 +-
 app/test/test_bitops.c|   2 +-
 app/test/test_bpf.c   |   4 +-
 app/test/test_byteorder.c |   2 +-
 app/test/test_cksum.c |   2 +-
 app/test/test_cmdline.c   |   2 +-
 app/test/test_common.c|   2 +-
 app/test/test_cpuflags.c  |   2 +-
 app/test/test_crc.c   |   2 +-
 app/test/test_cryptodev.c |  38 +-
 app/test/test_cryptodev_asym.c|   2 +-
 app/test/test_cycles.c|   2 +-
 app/test/test_debug.c |   2 +-
 app/test/test_devargs.c   |   2 +-
 app/test/test_distributor.c   |   2 +-
 app/test/test_distributor_perf.c  |   2 +-
 app/test/test_dmadev.c|   2 +-
 app/test/test_eal_flags.c |  24 +-
 app/test/test_eal_fs.c|   2 +-
 app/test/test_efd.c   |   2 +-
 app/test/test_efd_perf.c  |   2 +-
 app/test/test_errno.c |   2 +-
 app/test/test_ethdev_link.c   |   2 +-
 app/test/test_event_ring.c|   2 +-
 app/test/test_eventdev.c  |   2 +-
 app/test/test_fbarray.c   |   2 +-
 app/test/test_fib.c   |   4 +-
 app/test/test_fib6.c  |   4 +-
 app/test/test_fib6_perf.c |   2 +-
 app/test/test_fib_perf.c  |   2 +-
 app/test/test_func_reentrancy.c   |   2 +-
 app/test/test_hash.c  |   2 +-
 app/test/test_hash_functions.c|   2 +-
 app/test/test_hash_multiwriter.c  |   2 +-
 app/test/test_hash_perf.c |   2 +-
 app/test/test_hash_readwrite.c|   4 +-
 app/test/test_hash_readwrite_lf_perf.c|   2 +-
 app/test/test_interrupts.c|   2 +-
 app/test/test_ipfrag.c|   2 +-
 app/test/test_ipsec.c

[RFC PATCH 1/5] app/test: add new macros for various test types

2023-07-21 Thread Bruce Richardson

Rather than just registering all tests using a single generic macro,
add macros which identify the test as being of a particular type.

Signed-off-by: Bruce Richardson 
---
 app/test/test.h | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/app/test/test.h b/app/test/test.h
index 85f57efbc6..a91ded76af 100644
--- a/app/test/test.h
+++ b/app/test/test.h
@@ -190,7 +190,7 @@ struct test_command {
 
 void add_test_command(struct test_command *t);
 
-/* Register a test function with its command string */
+/* Register a test function with its command string. Should not be used 
directly */
 #define REGISTER_TEST_COMMAND(cmd, func) \
static struct test_command test_struct_##cmd = { \
.command = RTE_STR(cmd), \
@@ -201,4 +201,11 @@ void add_test_command(struct test_command *t);
add_test_command(&test_struct_##cmd); \
}
 
+/* Register a test function as a particular type.
+ * These can be used to build up test suites automatically
+ */
+#define REGISTER_FAST_TEST(cmd, no_huge, ASan, func)  
REGISTER_TEST_COMMAND(cmd, func)
+#define REGISTER_PERF_TEST REGISTER_TEST_COMMAND
+#define REGISTER_DRIVER_TEST REGISTER_TEST_COMMAND
+
 #endif
-- 
2.39.2

[RFC PATCH 2/5] app/test: tag tests with the test type

2023-07-21 Thread Bruce Richardson

Rather than having the test types called out in the meson.build file, we
can use macros to identify the test type in the C file itself and then
dynamically build up the tests lists at config time.

Signed-off-by: Bruce Richardson 
---
NOTE:
This replacement was automatically done using the list of tests given
in the meson.build file. As can be seen by checking the repo after this,
there were a number of tests not called out in any test suite. The
addition of these tests to suites is a separate issue not covered by
this patchset
---
 app/test/test_acl.c  |  2 +-
 app/test/test_atomic.c   |  2 +-
 app/test/test_barrier.c  |  2 +-
 app/test/test_bitmap.c   |  2 +-
 app/test/test_bitops.c   |  2 +-
 app/test/test_bpf.c  |  4 +--
 app/test/test_byteorder.c|  2 +-
 app/test/test_cksum.c|  2 +-
 app/test/test_cmdline.c  |  2 +-
 app/test/test_common.c   |  2 +-
 app/test/test_cpuflags.c |  2 +-
 app/test/test_crc.c  |  2 +-
 app/test/test_cryptodev.c| 38 
 app/test/test_cryptodev_asym.c   |  2 +-
 app/test/test_cycles.c   |  2 +-
 app/test/test_debug.c|  2 +-
 app/test/test_devargs.c  |  2 +-
 app/test/test_distributor.c  |  2 +-
 app/test/test_distributor_perf.c |  2 +-
 app/test/test_dmadev.c   |  2 +-
 app/test/test_eal_flags.c| 24 +++
 app/test/test_eal_fs.c   |  2 +-
 app/test/test_efd.c  |  2 +-
 app/test/test_efd_perf.c |  2 +-
 app/test/test_errno.c|  2 +-
 app/test/test_ethdev_link.c  |  2 +-
 app/test/test_event_ring.c   |  2 +-
 app/test/test_eventdev.c |  2 +-
 app/test/test_fbarray.c  |  2 +-
 app/test/test_fib.c  |  4 +--
 app/test/test_fib6.c |  4 +--
 app/test/test_fib6_perf.c|  2 +-
 app/test/test_fib_perf.c |  2 +-
 app/test/test_func_reentrancy.c  |  2 +-
 app/test/test_hash.c |  2 +-
 app/test/test_hash_functions.c   |  2 +-
 app/test/test_hash_multiwriter.c |  2 +-
 app/test/test_hash_perf.c|  2 +-
 app/test/test_hash_readwrite.c   |  4 +--
 app/test/test_hash_readwrite_lf_perf.c   |  2 +-
 app/test/test_interrupts.c   |  2 +-
 app/test/test_ipfrag.c   |  2 +-
 app/test/test_ipsec.c|  2 +-
 app/test/test_ipsec_perf.c   |  2 +-
 app/test/test_kni.c  |  2 +-
 app/test/test_kvargs.c   |  2 +-
 app/test/test_lcores.c   |  2 +-
 app/test/test_logs.c |  2 +-
 app/test/test_lpm.c  |  2 +-
 app/test/test_lpm6.c |  2 +-
 app/test/test_lpm6_perf.c|  2 +-
 app/test/test_lpm_perf.c |  2 +-
 app/test/test_malloc.c   |  2 +-
 app/test/test_malloc_perf.c  |  2 +-
 app/test/test_mbuf.c |  2 +-
 app/test/test_mcslock.c  |  2 +-
 app/test/test_member.c   |  2 +-
 app/test/test_member_perf.c  |  2 +-
 app/test/test_memcpy.c   |  2 +-
 app/test/test_memcpy_perf.c  |  2 +-
 app/test/test_memory.c   |  2 +-
 app/test/test_mempool.c  |  2 +-
 app/test/test_mempool_perf.c |  2 +-
 app/test/test_memzone.c  |  2 +-
 app/test/test_meter.c|  2 +-
 app/test/test_mp_secondary.c |  2 +-
 app/test/test_per_lcore.c|  2 +-
 app/test/test_pflock.c   |  2 +-
 app/test/test_pie.c  |  6 ++--
 app/test/test_pmd_perf.c |  2 +-
 app/test/test_power.c|  2 +-
 app/test/test_power_cpufreq.c|  2 +-
 app/test/test_power_intel_uncore.c   |  2 +-
 app/test/test_power_kvm_vm.c |  2 +-
 app/test/test_prefetch.c |  2 +-
 app/test/test_rand_perf.c|  2 +-
 app/test/test_rcu_qsbr.c |  2 +-
 app/test/test_rcu_qsbr_perf.c|  2 +-
 app/test/test_reassembly_perf.c  |  2 +-
 app/test/test_reciprocal_division.c  |  2 +-
 app/test/test_reciprocal_division_perf.c |  2 +-
 app/test/test_red.c  |  4 +--
 app/test/test_reorder.c  |  2 +-
 app/test/test_rib.c  |  4 +--
 app/test/test_rib6.c |  4 +--
 app/test/test_ring.c |  2 +-
 app/test/test_ring_perf.c|  2 +-
 app/test/test_rwlock.c   |  8 ++---
 app/test/test

[RFC PATCH 3/5] app/test: build using per-file dependency matrix

2023-07-21 Thread Bruce Richardson

Rather than using if-else constructs to selectively add or remove files
from the UT build, switch to a table-based approach where each file
lists out what libs or drivers it depends upon.

Initial version of this table was generated via analysis of the header
files included in each C file.

Signed-off-by: Bruce Richardson 
---
 app/meson.build  |   8 +-
 app/test/meson.build | 796 +++
 2 files changed, 203 insertions(+), 601 deletions(-)

diff --git a/app/meson.build b/app/meson.build
index 4fc1a83eba..0d8b618e7f 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -32,6 +32,11 @@ apps = [
 'test-security-perf',
 ]
 
+if get_option('tests')
+# build the auto test app if enabled.
+apps += 'test'
+endif
+
 default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']
 default_ldflags = []
 if get_option('default_library') == 'static' and not is_windows
@@ -106,6 +111,3 @@ foreach app:apps
 install_rpath: join_paths(get_option('prefix'), 
driver_install_path),
 install: true)
 endforeach
-
-# special case the autotests
-subdir('test')
diff --git a/app/test/meson.build b/app/test/meson.build
index b89cf0368f..475d87860e 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -1,452 +1,202 @@
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2017 Intel Corporation
-
-if not get_option('tests')
-subdir_done()
-endif
-
-test_sources = files(
-'commands.c',
-'packet_burst_generator.c',
-'test.c',
-'test_acl.c',
-'test_alarm.c',
-'test_atomic.c',
-'test_barrier.c',
-'test_bitops.c',
-'test_bitmap.c',
-'test_bpf.c',
-'test_byteorder.c',
-'test_cksum.c',
-'test_cksum_perf.c',
-'test_cmdline.c',
-'test_cmdline_cirbuf.c',
-'test_cmdline_etheraddr.c',
-'test_cmdline_ipaddr.c',
-'test_cmdline_lib.c',
-'test_cmdline_num.c',
-'test_cmdline_portlist.c',
-'test_cmdline_string.c',
-'test_common.c',
-'test_cpuflags.c',
-'test_crc.c',
-'test_cryptodev.c',
-'test_cryptodev_asym.c',
-'test_cryptodev_blockcipher.c',
-'test_cryptodev_crosscheck.c',
-'test_cryptodev_security_ipsec.c',
-'test_cryptodev_security_pdcp.c',
-'test_cycles.c',
-'test_debug.c',
-'test_devargs.c',
-'test_distributor.c',
-'test_distributor_perf.c',
-'test_dmadev.c',
-'test_dmadev_api.c',
-'test_eal_flags.c',
-'test_eal_fs.c',
-'test_efd.c',
-'test_efd_perf.c',
-'test_errno.c',
-'test_ethdev_link.c',
-'test_event_crypto_adapter.c',
-'test_event_eth_rx_adapter.c',
-'test_event_ring.c',
-'test_event_timer_adapter.c',
-'test_eventdev.c',
-'test_external_mem.c',
-'test_fbarray.c',
-'test_fib.c',
-'test_fib_perf.c',
-'test_fib6.c',
-'test_fib6_perf.c',
-'test_func_reentrancy.c',
-'test_hash.c',
-'test_hash_functions.c',
-'test_hash_multiwriter.c',
-'test_hash_readwrite.c',
-'test_hash_perf.c',
-'test_hash_readwrite_lf_perf.c',
-'test_interrupts.c',
-'test_ipfrag.c',
-'test_ipsec.c',
-'test_ipsec_sad.c',
-'test_ipsec_perf.c',
-'test_kni.c',
-'test_kvargs.c',
-'test_lcores.c',
-'test_logs.c',
-'test_lpm.c',
-'test_lpm6.c',
-'test_lpm6_perf.c',
-'test_lpm_perf.c',
-'test_malloc.c',
-'test_malloc_perf.c',
-'test_mbuf.c',
-'test_member.c',
-'test_member_perf.c',
-'test_memcpy.c',
-'test_memcpy_perf.c',
-'test_memory.c',
-'test_mempool.c',
-'test_mempool_perf.c',
-'test_memzone.c',
-'test_meter.c',
-'test_mcslock.c',
-'test_mp_secondary.c',
-'test_per_lcore.c',
-'test_pflock.c',
-'test_pmd_perf.c',
-'test_power.c',
-'test_power_cpufreq.c',
-'test_power_kvm_vm.c',
-'test_power_intel_uncore.c',
-'test_prefetch.c',
-'test_rand_perf.c',
-'test_rawdev.c',
-'test_rcu_qsbr.c',
-'test_rcu_qsbr_perf.c',
-'test_reassembly_perf.c',
-'test_reciprocal_division.c',
-'test_reciprocal_division_perf.c',
-'test_red.c',
-'test_pie.c',
-'test_reorder.c',
-'test_rib.c',
-'test_rib6.c',
-'test_ring.c',
-'test_ring_mpmc_stress.c',
-'test_ring_hts_stress.c',
-'test_ring_mt_peek_stress.c',
-'test_ring_mt_peek_stress_zc.c',
-'test_ring_perf.c',
-'test_ring_rts_stress.c',
-'test_ring_st_peek_stress.c',
-'test_ring_st_peek_stress_zc.c',
-'test_ring_stress.c',
-'test_r

[RFC PATCH 4/5] app/test: define unit tests suites based on test macros

2023-07-21 Thread Bruce Richardson

Rather than having the test suites listed out in the meson.build files
and having to have them enabled/disabled selectively based on what libs
are being built, pull the tests to run from the source files which were
added to the build.

Signed-off-by: Bruce Richardson 
---
 app/meson.build   |  7 ++-
 app/test/suites/meson.build   | 29 +
 buildtools/get-test-suites.py | 24 
 buildtools/meson.build|  1 +
 4 files changed, 60 insertions(+), 1 deletion(-)
 create mode 100644 app/test/suites/meson.build
 create mode 100644 buildtools/get-test-suites.py

diff --git a/app/meson.build b/app/meson.build
index 0d8b618e7f..c14dc80892 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -101,7 +101,7 @@ foreach app:apps
 link_libs = dpdk_static_libraries + dpdk_drivers
 endif
 
-executable('dpdk-' + name,
+exec = executable('dpdk-' + name,
 sources,
 c_args: cflags,
 link_args: ldflags,
@@ -110,4 +110,9 @@ foreach app:apps
 include_directories: includes,
 install_rpath: join_paths(get_option('prefix'), 
driver_install_path),
 install: true)
+if name == 'test'
+dpdk_test = exec
+autotest_sources = sources
+subdir('test/suites')  # define the pre-canned test suites
+endif
 endforeach
diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build
new file mode 100644
index 00..135620578c
--- /dev/null
+++ b/app/test/suites/meson.build
@@ -0,0 +1,29 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2023 Intel Corporation
+
+# some perf tests (eg: memcpy perf autotest)take very long
+# to complete, so timeout to 10 minutes
+timeout_seconds = 600
+
+# process source files to determine the different unit test suites
+# - fast_tests
+# - perf_tests
+# - driver_tests
+test_suites = run_command(get_test_suites_cmd, 
autotest_sources).stdout().strip().split()
+foreach suite:test_suites
+suite = suite.split('=')
+suite_name = suite[0]
+suite_tests = suite[1].split(',')
+if suite_name == 'fast-tests'
+# special fast-test handling here
+
+else
+foreach t: suite_tests
+test(t, dpdk_test,
+args: ['--', t],
+timeout: timeout_seconds,
+is_parallel: false,
+suite: suite_name)
+endforeach
+endif
+endforeach
diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
new file mode 100644
index 00..43cde80970
--- /dev/null
+++ b/buildtools/get-test-suites.py
@@ -0,0 +1,24 @@
+#! /usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2023 Intel Corporation
+
+import sys
+import re
+
+input_list = sys.argv[1:]
+test_def_regex = re.compile("REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
+test_suites = {}
+
+for fname in input_list:
+with open(fname) as f:
+contents = [ln for ln in f.readlines() if 
test_def_regex.match(ln.strip())]
+for ln in contents:
+(test_suite, test_name) = test_def_regex.match(ln).group(1, 2)
+suite_name = f"{test_suite.lower()}-tests"
+if suite_name in test_suites:
+test_suites[suite_name].append(test_name)
+else:
+test_suites[suite_name] = [test_name]
+
+for suite in test_suites.keys():
+print(f"{suite}={','.join(test_suites[suite])}")
diff --git a/buildtools/meson.build b/buildtools/meson.build
index e1c600e40f..12e4b36165 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -18,6 +18,7 @@ map_to_win_cmd = py3 + files('map_to_win.py')
 sphinx_wrapper = py3 + files('call-sphinx-build.py')
 get_cpu_count_cmd = py3 + files('get-cpu-count.py')
 get_numa_count_cmd = py3 + files('get-numa-count.py')
+get_test_suites_cmd = py3 + files('get-test-suites.py')
 binutils_avx512_check = (py3 + files('binutils-avx512-check.py') +
 [objdump] + cc.cmd_array())
 
-- 
2.39.2

[RFC PATCH 5/5] app/test: add fast test suite to new build infrastructure

2023-07-21 Thread Bruce Richardson

The fast-tests are special in that they have additional parameters
associated with them. This requires script changes and meson.build
changes to take account of these parameters.

Signed-off-by: Bruce Richardson 
---
 app/test/suites/meson.build   | 56 +--
 buildtools/get-test-suites.py |  9 +++
 .../has-hugepages.py  |  0
 buildtools/meson.build|  1 +
 4 files changed, 61 insertions(+), 5 deletions(-)
 rename app/test/has_hugepage.py => buildtools/has-hugepages.py (100%)

diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build
index 135620578c..720b43eb62 100644
--- a/app/test/suites/meson.build
+++ b/app/test/suites/meson.build
@@ -4,20 +4,24 @@
 # some perf tests (eg: memcpy perf autotest)take very long
 # to complete, so timeout to 10 minutes
 timeout_seconds = 600
+timeout_seconds_fast = 10
+
+test_no_huge_args = ['--no-huge', '-m', '2048']
+has_hugepage = run_command(has_hugepages_cmd, check: true).stdout().strip() != 
'0'
+message('hugepage availability: @0@'.format(has_hugepage))
 
 # process source files to determine the different unit test suites
 # - fast_tests
 # - perf_tests
 # - driver_tests
-test_suites = run_command(get_test_suites_cmd, 
autotest_sources).stdout().strip().split()
+test_suites = run_command(get_test_suites_cmd, autotest_sources,
+ check: true).stdout().strip().split()
 foreach suite:test_suites
 suite = suite.split('=')
 suite_name = suite[0]
 suite_tests = suite[1].split(',')
-if suite_name == 'fast-tests'
-# special fast-test handling here
-
-else
+if suite_name != 'fast-tests'
+# simple cases - tests without parameters or special handling
 foreach t: suite_tests
 test(t, dpdk_test,
 args: ['--', t],
@@ -25,5 +29,47 @@ foreach suite:test_suites
 is_parallel: false,
 suite: suite_name)
 endforeach
+else
+# special fast-test handling here
+foreach t: suite_tests
+params = t.split(':')
+test_name = params[0]
+nohuge = params[1] == 'true'
+asan = params[2] == 'true'
+
+test_args = []
+if nohuge
+test_args += test_no_huge_args
+elif not has_hugepage
+continue  #skip this tests
+endif
+if not asan and (get_option('b_sanitize') == 'address'
+or get_option('b_sanitize') == 'address,undefined')
+continue  # skip this test
+endif
+
+if (get_option('default_library') == 'shared' 
+and test_name == 'event_eth_tx_adapter_autotest')
+test_args += ['-d', dpdk_drivers_build_dir]
+endif
+if is_linux
+test_args += ['--file-prefix=@0@'.format(arg[0])]
+endif
+
+test(test_name, dpdk_test,
+args : test_args + ['--', test_name],
+timeout : timeout_seconds_fast,
+is_parallel : false,
+suite : 'fast-tests')
+if not is_windows and test_name == 'trace_autotest'
+test_args += ['--trace=.*']
+test_args += 
['--trace-dir=@0@'.format(meson.current_build_dir())]
+test(test_name + '_with_traces', dpdk_test,
+args : test_args + ['--', test_name],
+timeout : timeout_seconds_fast,
+is_parallel : false,
+suite : 'fast-tests')
+endif
+endforeach
 endif
 endforeach
diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
index 43cde80970..95a9cad4c8 100644
--- a/buildtools/get-test-suites.py
+++ b/buildtools/get-test-suites.py
@@ -9,6 +9,13 @@
 test_def_regex = re.compile("REGISTER_([A-Z]+)_TEST\s*\(\s*([a-z0-9_]+)")
 test_suites = {}
 
+def get_fast_test_params(test_name, ln):
+"Extract the extra fast-test parameters from the line"
+#print(f"ln: {ln.rstrip()}, test_name: {test_name}, split: 
{ln.split(test_name, 1)}")
+(_, rest_of_line) = ln.split(test_name, 1)
+(_, nohuge, asan, _func) = rest_of_line.split(',', 3)
+return f":{nohuge.strip().lower()}:{asan.strip().lower()}"
+
 for fname in input_list:
 with open(fname) as f:
 contents = [ln for ln in f.readlines() if 
test_def_regex.match(ln.strip())]
@@ -19,6 +26,8 @@
 test_suites[suite_name].append(test_name)
 else:
 test_suites[suite_name] = [test_name]
+if suite_name == "fast-tests":
+test_suites["fast-tests"][-1] += get_fast_test_params(test_name, 
ln)
 
 for suite in test_suites.keys():
 print(f"{suite}={','.join(test_suites[suite])}")
diff --git a/app/test/has_hugepage.py b/buildtools/has-hugepages.py
similarity index 100%
rename from app/test/has_hugepage.py
rename to buildto

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou

Thanks Akhil.
Yes, I see.
But for decryption, we should prepare the correct cipher data, right? Or that 
test does not make any sense.
I assume decryption with incorrect data will cause PMD reject work properly.

From: Akhil Goyal 
Sent: Friday, July 21, 2023 7:49 PM
To: Suanming Mou ; ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

Hi Suanming,

The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue.
It does not matter what is the content of the packet, as we are not validating 
the content
after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload 
and
will process it as per the session attached.
Hence, doing memcpy to mbuf is not required.

Regards,
Akhil

From: Suanming Mou mailto:suanmi...@nvidia.com>>
Sent: Friday, July 21, 2023 4:06 PM
To: ciara.po...@intel.com; Akhil Goyal 
mailto:gak...@marvell.com>>
Cc: dev@dpdk.org
Subject: [EXT] crypto decryption support in test-crypto-perf pmd-cycle-count 
test

External Email

Hi Guys,

Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf 
application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is 
called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count 
test does not expect to support decryption. Or is it a bug?

I have no idea with the application design background, is it expected?

Thanks,
Suanming Mou

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Akhil Goyal

Yes, for auth cases, the PMD may give errors. However, cipher only cases would 
work without issues.
You can send a patch to fix this. But make sure not to add that inside the time 
keeping loop.

From: Suanming Mou 
Sent: Friday, July 21, 2023 5:23 PM
To: Akhil Goyal ; ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: [EXT] RE: crypto decryption support in test-crypto-perf 
pmd-cycle-count test

External Email

Thanks Akhil.
Yes, I see.
But for decryption, we should prepare the correct cipher data, right? Or that 
test does not make any sense.
I assume decryption with incorrect data will cause PMD reject work properly.

From: Akhil Goyal mailto:gak...@marvell.com>>
Sent: Friday, July 21, 2023 7:49 PM
To: Suanming Mou mailto:suanmi...@nvidia.com>>; 
ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

Hi Suanming,

The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue.
It does not matter what is the content of the packet, as we are not validating 
the content
after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload 
and
will process it as per the session attached.
Hence, doing memcpy to mbuf is not required.

Regards,
Akhil

From: Suanming Mou mailto:suanmi...@nvidia.com>>
Sent: Friday, July 21, 2023 4:06 PM
To: ciara.po...@intel.com; Akhil Goyal 
mailto:gak...@marvell.com>>
Cc: dev@dpdk.org
Subject: [EXT] crypto decryption support in test-crypto-perf pmd-cycle-count 
test

External Email

Hi Guys,

Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf 
application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is 
called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count 
test does not expect to support decryption. Or is it a bug?

I have no idea with the application design background, is it expected?

Thanks,
Suanming Mou

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou

Sure, in fact I also find throughput testing with decryption and in-place-mode 
will override the cipher data in the single mbuf as well. So I assume 
out-of-place mode is valid in that case.
I will try to deliver some patches when have effort.  Thank you!

From: Akhil Goyal 
Sent: Friday, July 21, 2023 8:04 PM
To: Suanming Mou ; ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

Yes, for auth cases, the PMD may give errors. However, cipher only cases would 
work without issues.
You can send a patch to fix this. But make sure not to add that inside the time 
keeping loop.

From: Suanming Mou mailto:suanmi...@nvidia.com>>
Sent: Friday, July 21, 2023 5:23 PM
To: Akhil Goyal mailto:gak...@marvell.com>>; 
ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: [EXT] RE: crypto decryption support in test-crypto-perf 
pmd-cycle-count test

External Email

Thanks Akhil.
Yes, I see.
But for decryption, we should prepare the correct cipher data, right? Or that 
test does not make any sense.
I assume decryption with incorrect data will cause PMD reject work properly.

From: Akhil Goyal mailto:gak...@marvell.com>>
Sent: Friday, July 21, 2023 7:49 PM
To: Suanming Mou mailto:suanmi...@nvidia.com>>; 
ciara.po...@intel.com
Cc: dev@dpdk.org
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

Hi Suanming,

The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue.
It does not matter what is the content of the packet, as we are not validating 
the content
after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload 
and
will process it as per the session attached.
Hence, doing memcpy to mbuf is not required.

Regards,
Akhil

From: Suanming Mou mailto:suanmi...@nvidia.com>>
Sent: Friday, July 21, 2023 4:06 PM
To: ciara.po...@intel.com; Akhil Goyal 
mailto:gak...@marvell.com>>
Cc: dev@dpdk.org
Subject: [EXT] crypto decryption support in test-crypto-perf pmd-cycle-count 
test

External Email

Hi Guys,

Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf 
application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is 
called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count 
test does not expect to support decryption. Or is it a bug?

I have no idea with the application design background, is it expected?

Thanks,
Suanming Mou

Re: [PATCH] net/ngbe: fix RSS offload capability

2023-07-21 Thread Ferruh Yigit

On 7/20/2023 10:01 AM, Jiawen Wu wrote:
> Fix missed RTE_ETH_RX_OFFLOAD_RSS_HASH flag in ngbe_get_rx_port_offloads().
> 
> Fixes: 0779d7f61991 ("net/ngbe: support RSS hash")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Jiawen Wu 
>

Applied to dpdk-next-net/main, thanks.

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

2023-07-21 Thread Jerin Jacob

On Fri, Jul 21, 2023 at 4:18 PM Hemant Agrawal
 wrote:
>
> Acked-by: Hemant Agrawal 


Acked-by: Jerin Jacob 


>
> On 21-Jul-23 10:58 AM, Gagandeep Singh wrote:
> > Caution: This is an external email. Please take care when clicking links or 
> > opening attachments. When in doubt, report the message using the 'Report 
> > this email' button
> >
> >
> > when RTE_ENABLE_ASSERT is enable, DPAA driver is doing
> > wrong NULL check on frame queue which allows the code
> > to have access to NULL address.
> > GCC v13 is giving array bounds error if code is
> > accessing any memory region less than 4KB.
> > This patch fixes this issue by adding proper NULL checks
> > on frame queue.
> >
> > Please refer: https://bugs.dpdk.org/show_bug.cgi?id=1233
> >
> > Bugzilla ID: 1233
> > Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Gagandeep Singh 
> > ---
> >   drivers/bus/dpaa/base/qbman/qman.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
> > b/drivers/bus/dpaa/base/qbman/qman.c
> > index 3949bf8712..83db0a534e 100644
> > --- a/drivers/bus/dpaa/base/qbman/qman.c
> > +++ b/drivers/bus/dpaa/base/qbman/qman.c
> > @@ -1,7 +1,7 @@
> >   /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
> >*
> >* Copyright 2008-2016 Freescale Semiconductor Inc.
> > - * Copyright 2017,2019 NXP
> > + * Copyright 2017,2019-2023 NXP
> >*
> >*/
> >
> > @@ -897,7 +897,7 @@ static u32 __poll_portal_slow(struct qman_portal *p, 
> > u32 is)
> >  /* Lookup in the retirement table */
> >  fq = table_find_fq(p,
> > 
> > be32_to_cpu(msg->fq.fqid));
> > -   DPAA_BUG_ON(!fq);
> > +   DPAA_BUG_ON(fq != NULL);
> >  fq_state_change(p, fq, &swapped_msg, verb);
> >  if (fq->cb.fqs)
> >  fq->cb.fqs(p, fq, &swapped_msg);
> > @@ -909,6 +909,7 @@ static u32 __poll_portal_slow(struct qman_portal *p, 
> > u32 is)
> >   #else
> >  fq = (void *)(uintptr_t)msg->fq.contextB;
> >   #endif
> > +   DPAA_BUG_ON(fq != NULL);
> >  fq_state_change(p, fq, msg, verb);
> >  if (fq->cb.fqs)
> >  fq->cb.fqs(p, fq, &swapped_msg);
> > --
> > 2.25.1
> >

Re: [PATCH v1] test/graph: fix unused return value

2023-07-21 Thread Jerin Jacob

On Fri, Jul 21, 2023 at 8:12 AM Zhirun Yan  wrote:
>
> Return value stored in "ret" but it may be overwritten before use.
> Add goto to return when meet an error. Issue reported by coverity scan.
>
> Coverity issue: 395532
> Fixes: 15f483feec65 ("graph: fix model check in core binding")
>
> Signed-off-by: Zhirun Yan 

Acked-by: Jerin Jacob 


> ---
>  app/test/test_graph.c | 11 +++
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_graph.c b/app/test/test_graph.c
> index af90ac07ec..7995f67757 100644
> --- a/app/test/test_graph.c
> +++ b/app/test/test_graph.c
> @@ -740,13 +740,13 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)
> ret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);
> if (ret != 0) {
> printf("Set graph mcore dispatch model failed\n");
> -   ret = -1;
> +   goto fail;
> }
>
> ret = rte_graph_model_mcore_dispatch_core_bind(cloned_graph_id, 
> worker_lcore);
> if (ret != 0) {
> printf("bind graph %d to lcore %u failed\n", graph_id, 
> worker_lcore);
> -   ret = -1;
> +   goto fail;
> }
>
> graph = rte_graph_lookup("worker0-cloned-test2");
> @@ -755,6 +755,7 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)
> printf("bind graph %s(id:%d) with lcore %u failed\n",
>graph->name, graph->id, worker_lcore);
> ret = -1;
> +   goto fail;
> }
>
> rte_graph_model_mcore_dispatch_core_unbind(cloned_graph_id);
> @@ -764,6 +765,7 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)
> ret = -1;
> }
>
> +fail:
> rte_graph_destroy(cloned_graph_id);
>
> return ret;
> @@ -781,7 +783,7 @@ test_graph_worker_model_set_get(void)
> ret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);
> if (ret != 0) {
> printf("Set graph mcore dispatch model failed\n");
> -   ret = -1;
> +   goto fail;
> }
>
> graph = rte_graph_lookup("worker0-cloned-test3");
> @@ -790,9 +792,10 @@ test_graph_worker_model_set_get(void)
> ret = -1;
> }
>
> +fail:
> rte_graph_destroy(cloned_graph_id);
>
> -   return 0;
> +   return ret;
>  }
>
>  static int
> --
> 2.37.2
>

Re: [PATCH v3] tap: fix build of TAP BPF program

2023-07-21 Thread Ferruh Yigit

On 7/21/2023 12:25 AM, Stephen Hemminger wrote:
> Move the BPF program related code into a subdirectory.
> And add a Makefile for building it.
> 
> The code was depending on old versions of headers from iproute2.
> Include those headers here so that build works.
> 

Thanks Stephen, build works now.
But I am not sure about importing dependent headers to DPDK, could build
work with latest external headers if application updated accordingly?

> The standalone build was also broken because by
> commit ef5baf3486e0 ("replace packed attributes")
> which introduced __rte_packed into this code.
> 
> Add a python program to extract the resulting BPF into
> a format that can be consumed by the TAP driver.
> 
> Update the documentation.
> 
> Signed-off-by: Stephen Hemminger 

<...>

> --- /dev/null
> +++ b/drivers/net/tap/bpf/bpf_api.h
> @@ -0,0 +1,261 @@
> +#ifndef __BPF_API__
> +#define __BPF_API__
> +

What should be License and Copyright of these files?
Same for all imported headers.

DPDK Release Status Meeting 2023-07-20

2023-07-21 Thread Mcnamara, John

Release status meeting minutes 2023-07-20
=

Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens

Participants:
* AMD
* ARM
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
* Canonical

Release Dates
-

The following are the proposed working dates for 23.07:

* V1:  22 April 2023
* RC1: 13  June 2023
* RC2: 27  June 2023
* RC3: 12  July 2023
* RC4: 18  July 2023
* Release: 21  July 2023


Subtrees


* next-net
  * Fix patches merged for RC4.

* next-net-intel
  * Fixes merged.

* next-net-mlx
  * Merged to RC4.

* next-net-mvl
  * Merged to RC4.

* next-eventdev
  * Merged to RC4.

* next-baseband
  * Merged to RC4.

* next-virtio
  * Merged to RC4.

* next-crypto
  * Merged to RC4.

* main
  * RC4 is out.
  * Deprecation notices to be closed.

  * NOTE: deprecation notices should be sent soon so we can get sufficient Acks.
https://patchwork.dpdk.org/bundle/dmarchand/deprecation_notices/?state=*

  * Updated RC/Release dates:
Final release July 21

 * NOTE: no community call until August 10.



Proposed Schedule for 2023
--

See also http://core.dpdk.org/roadmap/#dates

23.11
  * Proposal deadline (RFC/v1 patches): 12 August 2023
  * API freeze (-rc1): 29 September 2023
  * PMD features freeze (-rc2): 20 October 2023
  * Builtin applications features freeze (-rc3): 27 October 2023
  * Release: 15 November 2023


LTS
---

Backporting in progress.

Next LTS releases:

* 22.11.2
* 21.11.5
  - Backports done to RC3
* 20.11.9
  - Backports done to RC3
* 19.11.15
  * Will be updated with CVE and critical fixes only.


* Distros
  * v22.11 in Debian 12
  * Ubuntu 22.04-LTS contains 21.11
  * Ubuntu 23.04 contains 22.11

Defects
---

* Bugzilla links, 'Bugs',  added for hosted projects
  * https://www.dpdk.org/hosted-projects/




DPDK Release Status Meetings


The DPDK Release Status Meeting is intended for DPDK Committers to discuss the
status of the master tree and sub-trees, and for project managers to track
progress or milestone dates.

The meeting occurs on every Thursday at 9:30 UTC over Jitsi on 
https://meet.jit.si/DPDK

You don't need an invite to join the meeting but if you want a calendar 
reminder just
send an email to "John McNamara john.mcnam...@intel.com" for the invite.


* NOTE: no community call until August 10.

[PATCH v1] doc: update release notes for 23.07

2023-07-21 Thread John McNamara

Fix grammar, spelling and formatting of DPDK 23.07 release notes.

Signed-off-by: John McNamara 
---
 doc/guides/rel_notes/release_23_07.rst | 49 +-
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/doc/guides/rel_notes/release_23_07.rst 
b/doc/guides/rel_notes/release_23_07.rst
index 6a1c45162b..74cddedb09 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -57,20 +57,20 @@ New Features
 
 * **Added AMD CDX bus support.**
 
-  CDX bus driver has been added to support AMD CDX bus,
+  CDX bus driver has been added to support the AMD CDX bus
   which operates on FPGA based CDX devices.
-  The CDX devices are memory mapped on system bus for embedded CPUs.
+  The CDX devices are memory mapped on system buses for embedded CPUs.
 
 * **Added MMIO read and write API to PCI bus.**
 
-  Introduced ``rte_pci_mmio_read()`` and ``rte_pci_mmio_write()`` API
+  Introduced ``rte_pci_mmio_read()`` and ``rte_pci_mmio_write()`` APIs
   to PCI bus so that PCI drivers can access PCI memory resources
-  when they are not mapped to process address space.
+  when they are not mapped to process address spaces.
 
 * **Added ethdev Rx/Tx queue ID check API.**
 
   Added ethdev Rx/Tx queue ID check API.
-  If the queue has been setup, it is considered valid.
+  If the queue has been set up it is considered valid.
 
 * **Added LLRS FEC mode in ethdev.**
 
@@ -89,7 +89,7 @@ New Features
 
   Added ``RTE_FLOW_ACTION_TYPE_IPV6_EXT_PUSH`` and 
``RTE_FLOW_ACTION_TYPE_IPV6_EXT_PUSH``
   to push or remove the specific IPv6 extension into or from the packets.
-  Push always put the new extension as the last one due to the next header 
awareness.
+  Push always puts the new extension as the last one due to the next header 
awareness.
 
 * **Added indirect list flow action.**
 
@@ -97,34 +97,35 @@ New Features
 
 * **Added flow rule update.**
 
-  * Added API for updating the action list in the already existing rule.
+  * Added API for updating the action list in an already existing rule.
 Introduced both ``rte_flow_actions_update()`` and
 ``rte_flow_async_actions_update()`` functions.
 
 * **Added vhost callback API for interrupt handling.**
 
-  A new callback, ``guest_notify``, is introduced that can be used to handle
+  Introduced a new callback, ``guest_notify`` that can be used to handle
   the interrupt kick outside of the datapath fast path.
   In addition, a new API, ``rte_vhost_notify_guest()``,
-  is added to raise the interrupt outside of the fast path.
-
-* **Added vhost API to set maximum queue pairs supported.**
-
-  Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit
-  the maximum number of supported queue pairs, required for VDUSE support.
+  was added to raise the interrupt outside of the fast path.
 
 * **Added VDUSE support into vhost library.**
 
   VDUSE aims at implementing vDPA devices in userspace.
   It can be used as an alternative to Vhost-user when using Vhost-vDPA,
-  but also enable providing a virtio-net netdev to the host
+  but it also enables providing a virtio-net netdev to the host
   when using Virtio-vDPA driver.
+
   A limitation in this release is the lack of reconnection support.
-  While VDUSE support is already available in upstream kernel,
-  a couple of patches are required to support network device type,
+  While VDUSE support is already available in the upstream kernel,
+  a couple of patches are required to support network device types,
   which are being upstreamed:
   
https://lore.kernel.org/all/20230419134329.346825-1-maxime.coque...@redhat.com/
 
+* **Added vhost API to set maximum queue pairs supported.**
+
+  Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit
+  the maximum number of supported queue pairs, required for VDUSE support.
+
 * **Updated Google GVE net driver.**
 
   * Added DQO queue descriptor format support.
@@ -149,9 +150,9 @@ New Features
 
   * Added support for configuring FEC mode, querying FEC capabilities and
 current FEC mode from a device.
-  * Added partial support for transfer flow actions SET_IPV4_DST, SET_TP_DST,
-SET_IPV4_SRC and SET_TP_SRC on SN1000 SmartNICs.
-  * Added support for transfer flow action INDIRECT with subtype COUNT,
+  * Added partial support for transfer flow actions ``SET_IPV4_DST``, 
``SET_TP_DST``,
+``SET_IPV4_SRC`` and ``SET_TP_SRC`` on SN1000 SmartNICs.
+  * Added support for transfer flow action ``INDIRECT`` with subtype ``COUNT``,
 for aggregated statistics.
   * Added support for keeping CRC.
   * Added VLAN stripping support on SN1000 SmartNICs.
@@ -159,7 +160,7 @@ New Features
 * **Added vmxnet3 version 7 support.**
 
   Added support for vmxnet3 version 7 which includes support
-  for uniform passthrough(UPT). The patches also add support
+  for uniform passthrough (UPT). The patches also add support
   for new capability registers, large passthrough BAR and some
   performance enha

Re: [PATCH v3] tap: fix build of TAP BPF program

2023-07-21 Thread Stephen Hemminger

On Fri, 21 Jul 2023 14:05:52 +0100
Ferruh Yigit  wrote:

> On 7/21/2023 12:25 AM, Stephen Hemminger wrote:
> > Move the BPF program related code into a subdirectory.
> > And add a Makefile for building it.
> > 
> > The code was depending on old versions of headers from iproute2.
> > Include those headers here so that build works.
> >   
> 
> Thanks Stephen, build works now.
> But I am not sure about importing dependent headers to DPDK, could build
> work with latest external headers if application updated accordingly?

These are not exported headers, it looks like Ophir was extracting them
from iproute2. The headers are GPL-2.0 licensed; though just asked Daniel
to allow BSD-3-clause version.

Not much is being used so we could just open code the parts that are
used.

[RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit

Drivers start/stop device queues on port start/stop, but not all drivers
update queue state accordingly.

This becomes more visible if a specific queue stopped explicitly and
port stopped/started later, in this case although all queues are
started, the state of that specific queue is stopped and it is
misleading.

Misrepresentation of queue state became a defect with commit [1] that
does forwarding decision based on queue state and commit [2] that gets
up to date queue state from ethdev/device before forwarding.

This patch documents that status of all queues of a device should be
`RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should
be`RTE_ETH_QUEUE_STATE_STARTED` after port start.

Also an unit test added to verify drivers.

Signed-off-by: Ferruh Yigit 
---
Cc: Jie Hai 
Cc: Song Jiale 
Cc: Yuan Peng 
Cc: Raslan Darawsheh 
Cc: Qiming Yang 
---
 app/test/meson.build   |   2 +
 app/test/test_ethdev_api.c | 169 +
 lib/ethdev/rte_ethdev.h|   5 ++
 3 files changed, 176 insertions(+)
 create mode 100644 app/test/test_ethdev_api.c

diff --git a/app/test/meson.build b/app/test/meson.build
index b89cf0368fb5..8e409cf59c35 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -49,6 +49,7 @@ test_sources = files(
 'test_efd_perf.c',
 'test_errno.c',
 'test_ethdev_link.c',
+'test_ethdev_api.c',
 'test_event_crypto_adapter.c',
 'test_event_eth_rx_adapter.c',
 'test_event_ring.c',
@@ -187,6 +188,7 @@ fast_tests = [
 ['eal_fs_autotest', true, true],
 ['errno_autotest', true, true],
 ['ethdev_link_status', true, true],
+['ethdev_api', true, true],
 ['event_ring_autotest', true, true],
 ['fib_autotest', true, true],
 ['fib6_autotest', true, true],
diff --git a/app/test/test_ethdev_api.c b/app/test/test_ethdev_api.c
new file mode 100644
index ..1b4569396dda
--- /dev/null
+++ b/app/test/test_ethdev_api.c
@@ -0,0 +1,169 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C) 2023, Advanced Micro Devices, Inc.
+ */
+
+#include 
+#include 
+
+#include 
+#include "test.h"
+
+#define NUM_RXQ2
+#define NUM_TXQ2
+#define NUM_RXD 512
+#define NUM_TXD 512
+#define NUM_MBUF 1024
+#define MBUF_CACHE_SIZE 256
+
+static int32_t
+ethdev_api_queue_status(void)
+{
+   struct rte_eth_dev_info dev_info;
+   struct rte_eth_rxq_info rx_qinfo;
+   struct rte_eth_txq_info tx_qinfo;
+   struct rte_mempool *mbuf_pool;
+   /*struct rte_eth_rxconf rx_conf;*/
+   /*struct rte_eth_txconf tx_conf;*/
+   struct rte_eth_conf eth_conf;
+   uint16_t port_id;
+   int ret;
+
+   mbuf_pool = rte_pktmbuf_pool_create("MBUF_POOL", NUM_MBUF, 
MBUF_CACHE_SIZE, 0,
+   RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
+
+   RTE_ETH_FOREACH_DEV(port_id) {
+   memset(ð_conf, 0, sizeof(dev_info));
+   ret = rte_eth_dev_configure(port_id, NUM_RXQ, NUM_TXQ, 
ð_conf);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to configure.\n", port_id);
+
+   /* RxQ setup */
+   /*memset(&rx_conf, 0, sizeof(rx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_RXQ; queue_id++) {
+   ret = rte_eth_rx_queue_setup(port_id, queue_id, NUM_RXD,
+   rte_socket_id(), NULL,  mbuf_pool);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup RxQ.\n",
+   port_id, queue_id);
+   }
+
+   /* TxQ setup */
+   /*memset(&tx_conf, 0, sizeof(tx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_TXQ; queue_id++) {
+   ret = rte_eth_tx_queue_setup(port_id, queue_id, NUM_TXD,
+   rte_socket_id(), NULL);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup TxQ.\n",
+   port_id, queue_id);
+   }
+
+   ret = rte_eth_dev_info_get(port_id, &dev_info);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to get dev info.\n", port_id);
+
+   /* Initial RxQ */
+   for (uint16_t queue_id = 0; queue_id < dev_info.nb_rx_queues; 
queue_id++) {
+   ret = rte_eth_rx_queue_info_get(port_id, queue_id, 
&rx_qinfo);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to get RxQ info.\n",
+   port_id, queue_id);
+
+   TEST_ASSERT(rx_qinfo.queue_state == 
RTE_ETH_QUEUE_STATE_STOPPED,
+   "Wrong initial Rx queue(%u) state(%d)\n",
+   queue_id, rx_qinfo.queue_state);
+   }
+
+

[PATCH v12 1/2] mempool cache: add zero-copy get and put functions

2023-07-21 Thread Dharmik Thakkar

From: Morten Brørup 

Zero-copy access to mempool caches is beneficial for PMD performance.
Furthermore, having a zero-copy mempool API is considered a precondition
for fixing a certain category of bugs, present in some PMDs: For
performance reasons, some PMDs had bypassed the mempool API in order to
achieve zero-copy access to the mempool cache. This can only be fixed
in those PMDs without a performance regression if the mempool library
offers zero-copy access APIs, so the PMDs can use the proper mempool
API instead of copy-pasting code from the mempool library.
Furthermore, the copy-pasted code in those PMDs has not been kept up to
date with the improvements of the mempool library, so when they bypass
the mempool API, mempool trace is missing and mempool statistics is not
updated.

Bugzilla ID: 1052

Signed-off-by: Morten Brørup 
Signed-off-by: Kamalakshitha Aligeri 
Signed-off-by: Dharmik Thakkar 
Reviewed-by: Ruifeng Wang 
Acked-by: Konstantin Ananyev 
Acked-by: Chengwen Feng 

---
v12:
* Fix CI compilation issues on [patch 2/2] in the series
v11:
* Changed patch description and version to 23.07
v10:
* Added mempool test cases with zero-copy API's
v9:
* Also set rte_errno in zero-copy put function, if returning NULL.
  (Honnappa)
* Revert v3 comparison to prevent overflow if n is really huge and len is
  non-zero. (Olivier)
v8:
* Actually include the rte_errno header file.
  Note to self: The changes only take effect on the disk after the file in
  the text editor has been saved.
v7:
* Fix typo in function description. (checkpatch)
* Zero-copy functions may set rte_errno; include rte_errno header file.
  (ci/loongarch-compilation)
v6:
* Improve description of the 'n' parameter to the zero-copy get function.
  (Konstantin, Bruce)
* The caches used for zero-copy may not be user-owned, so remove this word
  from the function descriptions. (Kamalakshitha)
v5:
* Bugfix: Compare zero-copy get request to the cache size instead of the
  flush threshold; otherwise refill could overflow the memory allocated
  for the cache. (Andrew)
* Split the zero-copy put function into an internal function doing the
  work, and a public function with trace.
* Avoid code duplication by rewriting rte_mempool_do_generic_put() to use
  the internal zero-copy put function. (Andrew)
* Corrected the return type of rte_mempool_cache_zc_put_bulk() from void *
  to void **; it returns a pointer to an array of objects.
* Fix coding style: Add missing curly brackets. (Andrew)
v4:
* Fix checkpatch warnings.
v3:
* Bugfix: Respect the cache size; compare to the flush threshold instead
  of RTE_MEMPOOL_CACHE_MAX_SIZE.
* Added 'rewind' function for incomplete 'put' operations. (Konstantin)
* Replace RTE_ASSERTs with runtime checks of the request size.
  Instead of failing, return NULL if the request is too big. (Konstantin)
* Modified comparison to prevent overflow if n is really huge and len is
  non-zero. (Andrew)
* Updated the comments in the code.
v2:
* Fix checkpatch warnings.
* Fix missing registration of trace points.
* The functions are inline, so they don't go into the map file.
v1 changes from the RFC:
* Removed run-time parameter checks. (Honnappa)
  This is a hot fast path function; requiring correct application
  behaviour, i.e. function parameters must be valid.
* Added RTE_ASSERT for parameters instead.
  Code for this is only generated if built with RTE_ENABLE_ASSERT.
* Removed fallback when 'cache' parameter is not set. (Honnappa)
* Chose the simple get function; i.e. do not move the existing objects in
  the cache to the top of the new stack, just leave them at the bottom.
* Renamed the functions. Other suggestions are welcome, of course. ;-)
* Updated the function descriptions.
* Added the functions to trace_fp and version.map.

---
 app/test/test_mempool.c|  81 +++---
 lib/mempool/mempool_trace_points.c |   9 ++
 lib/mempool/rte_mempool.h  | 239 +
 lib/mempool/rte_mempool_trace_fp.h |  23 +++
 lib/mempool/version.map|   9 ++
 5 files changed, 311 insertions(+), 50 deletions(-)

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 8e493eda47f4..6d29f5bc7b07 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -74,7 +74,7 @@ my_obj_init(struct rte_mempool *mp, __rte_unused void *arg,
 
 /* basic tests (done on one core) */
 static int
-test_mempool_basic(struct rte_mempool *mp, int use_external_cache)
+test_mempool_basic(struct rte_mempool *mp, int use_external_cache, int 
use_zc_api)
 {
uint32_t *objnum;
void **objtable;
@@ -84,6 +84,7 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
unsigned i, j;
int offset;
struct rte_mempool_cache *cache;
+   void **cache_objs;
 
if (use_external_cache) {
/* Create a user-owned mempool cache. */
@@ -100,8 +101,13 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
rte_mempool_

[PATCH v12 2/2] net/i40e: replace put function

2023-07-21 Thread Dharmik Thakkar

From: Kamalakshitha Aligeri 

Integrated zero-copy put API in mempool cache in i40e PMD.
On Ampere Altra server, l3fwd single core's performance improves by 5%
with the new API

Signed-off-by: Kamalakshitha Aligeri 
Signed-off-by: Dharmik Thakkar 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Feifei Wang 
Acked-by: Morten Brørup 
Acked-by: Konstantin Ananyev 
---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 29 -
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
b/drivers/net/i40e/i40e_rxtx_vec_common.h
index fe1a6ec75ef5..bb746fc36823 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -85,7 +85,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
uint32_t n;
uint32_t i;
int nb_free = 0;
-   struct rte_mbuf *m, *free[RTE_I40E_TX_MAX_FREE_BUF_SZ];
+   struct rte_mbuf *m, *free[RTE_I40E_TX_MAX_FREE_BUF_SZ] = {0};
 
/* check DD bits on threshold descriptor */
if ((txq->tx_ring[txq->tx_next_dd].cmd_type_offset_bsz &
@@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
 
n = txq->tx_rs_thresh;
 
-/* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
+   /* first buffer to free from S/W ring is at index
+* tx_next_dd - (tx_rs_thresh-1)
+*/
txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];
 
if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
+   struct rte_mempool *mp = txep[0].mbuf->pool;
+   struct rte_mempool_cache *cache = rte_mempool_default_cache(mp, 
rte_lcore_id());
+   void **cache_objs;
+
+   if (unlikely(!cache))
+   goto fallback;
+
+   cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);
+   if (unlikely(!cache_objs))
+   goto fallback;
+
for (i = 0; i < n; i++) {
-   free[i] = txep[i].mbuf;
+   cache_objs[i] = txep[i].mbuf;
/* no need to reset txep[i].mbuf in vector path */
}
-   rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
goto done;
+
+fallback:
+   for (i = 0; i < n; i++)
+   free[i] = txep[i].mbuf;
+   rte_mempool_generic_put(mp, (void **)free, n, cache);
+   goto done;
+
}
 
m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
-- 
2.25.1

Re: [PATCH] app/test: fix include of standard header

2023-07-21 Thread Ferruh Yigit

On 7/21/2023 12:24 PM, Morten Brørup wrote:
>> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
>> Sent: Friday, 21 July 2023 12.57
>>
>> Standard headers, or headers not in the current directory generally,
>> should be wrapped in "<>" rather than in regular quotes "". Fix one
>> instance of unistd.h being included using quotes
>>
>> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Bruce Richardson 
>> ---
> 
> Acked-by: Morten Brørup 
> 

Acked-by: Ferruh Yigit 

Applied to dpdk-next-net/main, thanks.

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ivan Malov


Hi Ferruh,

The commit log says "commit [1]" and "commit [2]" but
does not seem to provide the URLs for the [1] and [2].
What are these resources? I'd like to know.

Thank you.

On Fri, 21 Jul 2023, Ferruh Yigit wrote:


Drivers start/stop device queues on port start/stop, but not all drivers
update queue state accordingly.

This becomes more visible if a specific queue stopped explicitly and
port stopped/started later, in this case although all queues are
started, the state of that specific queue is stopped and it is
misleading.

Misrepresentation of queue state became a defect with commit [1] that
does forwarding decision based on queue state and commit [2] that gets
up to date queue state from ethdev/device before forwarding.

This patch documents that status of all queues of a device should be
`RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should
be`RTE_ETH_QUEUE_STATE_STARTED` after port start.

Also an unit test added to verify drivers.

Signed-off-by: Ferruh Yigit 
---
Cc: Jie Hai 
Cc: Song Jiale 
Cc: Yuan Peng 
Cc: Raslan Darawsheh 
Cc: Qiming Yang 
---
app/test/meson.build   |   2 +
app/test/test_ethdev_api.c | 169 +
lib/ethdev/rte_ethdev.h|   5 ++
3 files changed, 176 insertions(+)
create mode 100644 app/test/test_ethdev_api.c

diff --git a/app/test/meson.build b/app/test/meson.build
index b89cf0368fb5..8e409cf59c35 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -49,6 +49,7 @@ test_sources = files(
'test_efd_perf.c',
'test_errno.c',
'test_ethdev_link.c',
+'test_ethdev_api.c',
'test_event_crypto_adapter.c',
'test_event_eth_rx_adapter.c',
'test_event_ring.c',
@@ -187,6 +188,7 @@ fast_tests = [
['eal_fs_autotest', true, true],
['errno_autotest', true, true],
['ethdev_link_status', true, true],
+['ethdev_api', true, true],
['event_ring_autotest', true, true],
['fib_autotest', true, true],
['fib6_autotest', true, true],
diff --git a/app/test/test_ethdev_api.c b/app/test/test_ethdev_api.c
new file mode 100644
index ..1b4569396dda
--- /dev/null
+++ b/app/test/test_ethdev_api.c
@@ -0,0 +1,169 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C) 2023, Advanced Micro Devices, Inc.
+ */
+
+#include 
+#include 
+
+#include 
+#include "test.h"
+
+#define NUM_RXQ2
+#define NUM_TXQ2
+#define NUM_RXD 512
+#define NUM_TXD 512
+#define NUM_MBUF 1024
+#define MBUF_CACHE_SIZE 256
+
+static int32_t
+ethdev_api_queue_status(void)
+{
+   struct rte_eth_dev_info dev_info;
+   struct rte_eth_rxq_info rx_qinfo;
+   struct rte_eth_txq_info tx_qinfo;
+   struct rte_mempool *mbuf_pool;
+   /*struct rte_eth_rxconf rx_conf;*/
+   /*struct rte_eth_txconf tx_conf;*/
+   struct rte_eth_conf eth_conf;
+   uint16_t port_id;
+   int ret;
+
+   mbuf_pool = rte_pktmbuf_pool_create("MBUF_POOL", NUM_MBUF, 
MBUF_CACHE_SIZE, 0,
+   RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
+
+   RTE_ETH_FOREACH_DEV(port_id) {
+   memset(ð_conf, 0, sizeof(dev_info));
+   ret = rte_eth_dev_configure(port_id, NUM_RXQ, NUM_TXQ, 
ð_conf);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to configure.\n", port_id);
+
+   /* RxQ setup */
+   /*memset(&rx_conf, 0, sizeof(rx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_RXQ; queue_id++) {
+   ret = rte_eth_rx_queue_setup(port_id, queue_id, NUM_RXD,
+   rte_socket_id(), NULL,  mbuf_pool);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup RxQ.\n",
+   port_id, queue_id);
+   }
+
+   /* TxQ setup */
+   /*memset(&tx_conf, 0, sizeof(tx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_TXQ; queue_id++) {
+   ret = rte_eth_tx_queue_setup(port_id, queue_id, NUM_TXD,
+   rte_socket_id(), NULL);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup TxQ.\n",
+   port_id, queue_id);
+   }
+
+   ret = rte_eth_dev_info_get(port_id, &dev_info);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to get dev info.\n", port_id);
+
+   /* Initial RxQ */
+   for (uint16_t queue_id = 0; queue_id < dev_info.nb_rx_queues; 
queue_id++) {
+   ret = rte_eth_rx_queue_info_get(port_id, queue_id, 
&rx_qinfo);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to get RxQ info.\n",
+   port_id, queue_id);
+
+   TEST_ASSERT(rx_qinfo.qu

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ivan Malov


Hi Ferruh,

PSB

Thank you.

On Fri, 21 Jul 2023, Ferruh Yigit wrote:


Drivers start/stop device queues on port start/stop, but not all drivers
update queue state accordingly.

This becomes more visible if a specific queue stopped explicitly and
port stopped/started later, in this case although all queues are
started, the state of that specific queue is stopped and it is
misleading.

Misrepresentation of queue state became a defect with commit [1] that
does forwarding decision based on queue state and commit [2] that gets
up to date queue state from ethdev/device before forwarding.

This patch documents that status of all queues of a device should be
`RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should
be`RTE_ETH_QUEUE_STATE_STARTED` after port start.

Also an unit test added to verify drivers.

Signed-off-by: Ferruh Yigit 
---
Cc: Jie Hai 
Cc: Song Jiale 
Cc: Yuan Peng 
Cc: Raslan Darawsheh 
Cc: Qiming Yang 
---
app/test/meson.build   |   2 +
app/test/test_ethdev_api.c | 169 +
lib/ethdev/rte_ethdev.h|   5 ++
3 files changed, 176 insertions(+)
create mode 100644 app/test/test_ethdev_api.c

diff --git a/app/test/meson.build b/app/test/meson.build
index b89cf0368fb5..8e409cf59c35 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -49,6 +49,7 @@ test_sources = files(
'test_efd_perf.c',
'test_errno.c',
'test_ethdev_link.c',
+'test_ethdev_api.c',
'test_event_crypto_adapter.c',
'test_event_eth_rx_adapter.c',
'test_event_ring.c',
@@ -187,6 +188,7 @@ fast_tests = [
['eal_fs_autotest', true, true],
['errno_autotest', true, true],
['ethdev_link_status', true, true],
+['ethdev_api', true, true],
['event_ring_autotest', true, true],
['fib_autotest', true, true],
['fib6_autotest', true, true],
diff --git a/app/test/test_ethdev_api.c b/app/test/test_ethdev_api.c
new file mode 100644
index ..1b4569396dda
--- /dev/null
+++ b/app/test/test_ethdev_api.c
@@ -0,0 +1,169 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (C) 2023, Advanced Micro Devices, Inc.
+ */
+
+#include 
+#include 
+
+#include 
+#include "test.h"
+
+#define NUM_RXQ2
+#define NUM_TXQ2
+#define NUM_RXD 512
+#define NUM_TXD 512
+#define NUM_MBUF 1024
+#define MBUF_CACHE_SIZE 256
+
+static int32_t
+ethdev_api_queue_status(void)
+{
+   struct rte_eth_dev_info dev_info;
+   struct rte_eth_rxq_info rx_qinfo;
+   struct rte_eth_txq_info tx_qinfo;
+   struct rte_mempool *mbuf_pool;
+   /*struct rte_eth_rxconf rx_conf;*/
+   /*struct rte_eth_txconf tx_conf;*/
+   struct rte_eth_conf eth_conf;
+   uint16_t port_id;
+   int ret;
+
+   mbuf_pool = rte_pktmbuf_pool_create("MBUF_POOL", NUM_MBUF, 
MBUF_CACHE_SIZE, 0,
+   RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
+
+   RTE_ETH_FOREACH_DEV(port_id) {
+   memset(ð_conf, 0, sizeof(dev_info));

This clears "eth_conf", but the sizeof is "dev_info". Why?


+   ret = rte_eth_dev_configure(port_id, NUM_RXQ, NUM_TXQ, 
ð_conf);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to configure.\n", port_id);
+
+   /* RxQ setup */
+   /*memset(&rx_conf, 0, sizeof(rx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_RXQ; queue_id++) {
+   ret = rte_eth_rx_queue_setup(port_id, queue_id, NUM_RXD,
+   rte_socket_id(), NULL,  mbuf_pool);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup RxQ.\n",
+   port_id, queue_id);
+   }
+
+   /* TxQ setup */
+   /*memset(&tx_conf, 0, sizeof(tx_conf));*/
+   for (uint16_t queue_id = 0; queue_id < NUM_TXQ; queue_id++) {
+   ret = rte_eth_tx_queue_setup(port_id, queue_id, NUM_TXD,
+   rte_socket_id(), NULL);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to setup TxQ.\n",
+   port_id, queue_id);
+   }
+
+   ret = rte_eth_dev_info_get(port_id, &dev_info);
+   TEST_ASSERT(ret == 0,
+   "Port(%u) failed to get dev info.\n", port_id);
+
+   /* Initial RxQ */
+   for (uint16_t queue_id = 0; queue_id < dev_info.nb_rx_queues; 
queue_id++) {
+   ret = rte_eth_rx_queue_info_get(port_id, queue_id, 
&rx_qinfo);
+   TEST_ASSERT(ret == 0,
+   "Port(%u), queue(%u) failed to get RxQ info.\n",
+   port_id, queue_id);
+
+   TEST_ASSERT(rx_qinfo.queue_state == 
RTE_ETH_QUEUE_STATE_STOPPED,
+   "Wrong initi

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit

On 7/21/2023 6:33 PM, Ivan Malov wrote:
> Hi Ferruh,
> 
> The commit log says "commit [1]" and "commit [2]" but
> does not seem to provide the URLs for the [1] and [2].
> What are these resources? I'd like to know.
> 

Ahh, I missed to add them to commit log, will add to next version:

[1]
3c4426db54fc ("app/testpmd: do not poll stopped queues")

[2]
5028f207a4fa ("app/testpmd: fix secondary process packet forwarding")


> Thank you.
> 
> On Fri, 21 Jul 2023, Ferruh Yigit wrote:
> 
>> Drivers start/stop device queues on port start/stop, but not all drivers
>> update queue state accordingly.
>>
>> This becomes more visible if a specific queue stopped explicitly and
>> port stopped/started later, in this case although all queues are
>> started, the state of that specific queue is stopped and it is
>> misleading.
>>
>> Misrepresentation of queue state became a defect with commit [1] that
>> does forwarding decision based on queue state and commit [2] that gets
>> up to date queue state from ethdev/device before forwarding.
>>
>> This patch documents that status of all queues of a device should be
>> `RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should
>> be`RTE_ETH_QUEUE_STATE_STARTED` after port start.
>>
>> Also an unit test added to verify drivers.
>>
>> Signed-off-by: Ferruh Yigit 
>> ---
>> Cc: Jie Hai 
>> Cc: Song Jiale 
>> Cc: Yuan Peng 
>> Cc: Raslan Darawsheh 
>> Cc: Qiming Yang 
>> ---
>> app/test/meson.build   |   2 +
>> app/test/test_ethdev_api.c | 169 +
>> lib/ethdev/rte_ethdev.h    |   5 ++
>> 3 files changed, 176 insertions(+)
>> create mode 100644 app/test/test_ethdev_api.c
>>
>> diff --git a/app/test/meson.build b/app/test/meson.build
>> index b89cf0368fb5..8e409cf59c35 100644
>> --- a/app/test/meson.build
>> +++ b/app/test/meson.build
>> @@ -49,6 +49,7 @@ test_sources = files(
>>     'test_efd_perf.c',
>>     'test_errno.c',
>>     'test_ethdev_link.c',
>> +    'test_ethdev_api.c',
>>     'test_event_crypto_adapter.c',
>>     'test_event_eth_rx_adapter.c',
>>     'test_event_ring.c',
>> @@ -187,6 +188,7 @@ fast_tests = [
>>     ['eal_fs_autotest', true, true],
>>     ['errno_autotest', true, true],
>>     ['ethdev_link_status', true, true],
>> +    ['ethdev_api', true, true],
>>     ['event_ring_autotest', true, true],
>>     ['fib_autotest', true, true],
>>     ['fib6_autotest', true, true],
>> diff --git a/app/test/test_ethdev_api.c b/app/test/test_ethdev_api.c
>> new file mode 100644
>> index ..1b4569396dda
>> --- /dev/null
>> +++ b/app/test/test_ethdev_api.c
>> @@ -0,0 +1,169 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright (C) 2023, Advanced Micro Devices, Inc.
>> + */
>> +
>> +#include 
>> +#include 
>> +
>> +#include 
>> +#include "test.h"
>> +
>> +#define NUM_RXQ    2
>> +#define NUM_TXQ    2
>> +#define NUM_RXD 512
>> +#define NUM_TXD 512
>> +#define NUM_MBUF 1024
>> +#define MBUF_CACHE_SIZE 256
>> +
>> +static int32_t
>> +ethdev_api_queue_status(void)
>> +{
>> +    struct rte_eth_dev_info dev_info;
>> +    struct rte_eth_rxq_info rx_qinfo;
>> +    struct rte_eth_txq_info tx_qinfo;
>> +    struct rte_mempool *mbuf_pool;
>> +    /*struct rte_eth_rxconf rx_conf;*/
>> +    /*struct rte_eth_txconf tx_conf;*/
>> +    struct rte_eth_conf eth_conf;
>> +    uint16_t port_id;
>> +    int ret;
>> +
>> +    mbuf_pool = rte_pktmbuf_pool_create("MBUF_POOL", NUM_MBUF,
>> MBUF_CACHE_SIZE, 0,
>> +    RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
>> +
>> +    RTE_ETH_FOREACH_DEV(port_id) {
>> +    memset(ð_conf, 0, sizeof(dev_info));
>> +    ret = rte_eth_dev_configure(port_id, NUM_RXQ, NUM_TXQ,
>> ð_conf);
>> +    TEST_ASSERT(ret == 0,
>> +    "Port(%u) failed to configure.\n", port_id);
>> +
>> +    /* RxQ setup */
>> +    /*memset(&rx_conf, 0, sizeof(rx_conf));*/
>> +    for (uint16_t queue_id = 0; queue_id < NUM_RXQ; queue_id++) {
>> +    ret = rte_eth_rx_queue_setup(port_id, queue_id, NUM_RXD,
>> +    rte_socket_id(), NULL,  mbuf_pool);
>> +    TEST_ASSERT(ret == 0,
>> +    "Port(%u), queue(%u) failed to setup RxQ.\n",
>> +    port_id, queue_id);
>> +    }
>> +
>> +    /* TxQ setup */
>> +    /*memset(&tx_conf, 0, sizeof(tx_conf));*/
>> +    for (uint16_t queue_id = 0; queue_id < NUM_TXQ; queue_id++) {
>> +    ret = rte_eth_tx_queue_setup(port_id, queue_id, NUM_TXD,
>> +    rte_socket_id(), NULL);
>> +    TEST_ASSERT(ret == 0,
>> +    "Port(%u), queue(%u) failed to setup TxQ.\n",
>> +    port_id, queue_id);
>> +    }
>> +
>> +    ret = rte_eth_dev_info_get(port_id, &dev_info);
>> +    TEST_ASSERT(ret == 0,
>> +    "Port(%u) failed to get dev info.\n", port_id);
>> +
>> +    /* Initial RxQ */
>> +    for (uint16_t queue_id = 0; queue_id < dev_info.nb_rx_queues;
>> queue_id+

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit

On 7/21/2023 6:42 PM, Ivan Malov wrote:
> Hi Ferruh,
> 
> PSB
> 
> Thank you.
> 
> On Fri, 21 Jul 2023, Ferruh Yigit wrote:
> 
>> Drivers start/stop device queues on port start/stop, but not all drivers
>> update queue state accordingly.
>>
>> This becomes more visible if a specific queue stopped explicitly and
>> port stopped/started later, in this case although all queues are
>> started, the state of that specific queue is stopped and it is
>> misleading.
>>
>> Misrepresentation of queue state became a defect with commit [1] that
>> does forwarding decision based on queue state and commit [2] that gets
>> up to date queue state from ethdev/device before forwarding.
>>
>> This patch documents that status of all queues of a device should be
>> `RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should
>> be`RTE_ETH_QUEUE_STATE_STARTED` after port start.
>>
>> Also an unit test added to verify drivers.
>>
>> Signed-off-by: Ferruh Yigit 
>> ---
>> Cc: Jie Hai 
>> Cc: Song Jiale 
>> Cc: Yuan Peng 
>> Cc: Raslan Darawsheh 
>> Cc: Qiming Yang 
>> ---
>> app/test/meson.build   |   2 +
>> app/test/test_ethdev_api.c | 169 +
>> lib/ethdev/rte_ethdev.h    |   5 ++
>> 3 files changed, 176 insertions(+)
>> create mode 100644 app/test/test_ethdev_api.c
>>
>> diff --git a/app/test/meson.build b/app/test/meson.build
>> index b89cf0368fb5..8e409cf59c35 100644
>> --- a/app/test/meson.build
>> +++ b/app/test/meson.build
>> @@ -49,6 +49,7 @@ test_sources = files(
>>     'test_efd_perf.c',
>>     'test_errno.c',
>>     'test_ethdev_link.c',
>> +    'test_ethdev_api.c',
>>     'test_event_crypto_adapter.c',
>>     'test_event_eth_rx_adapter.c',
>>     'test_event_ring.c',
>> @@ -187,6 +188,7 @@ fast_tests = [
>>     ['eal_fs_autotest', true, true],
>>     ['errno_autotest', true, true],
>>     ['ethdev_link_status', true, true],
>> +    ['ethdev_api', true, true],
>>     ['event_ring_autotest', true, true],
>>     ['fib_autotest', true, true],
>>     ['fib6_autotest', true, true],
>> diff --git a/app/test/test_ethdev_api.c b/app/test/test_ethdev_api.c
>> new file mode 100644
>> index ..1b4569396dda
>> --- /dev/null
>> +++ b/app/test/test_ethdev_api.c
>> @@ -0,0 +1,169 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright (C) 2023, Advanced Micro Devices, Inc.
>> + */
>> +
>> +#include 
>> +#include 
>> +
>> +#include 
>> +#include "test.h"
>> +
>> +#define NUM_RXQ    2
>> +#define NUM_TXQ    2
>> +#define NUM_RXD 512
>> +#define NUM_TXD 512
>> +#define NUM_MBUF 1024
>> +#define MBUF_CACHE_SIZE 256
>> +
>> +static int32_t
>> +ethdev_api_queue_status(void)
>> +{
>> +    struct rte_eth_dev_info dev_info;
>> +    struct rte_eth_rxq_info rx_qinfo;
>> +    struct rte_eth_txq_info tx_qinfo;
>> +    struct rte_mempool *mbuf_pool;
>> +    /*struct rte_eth_rxconf rx_conf;*/
>> +    /*struct rte_eth_txconf tx_conf;*/
>> +    struct rte_eth_conf eth_conf;
>> +    uint16_t port_id;
>> +    int ret;
>> +
>> +    mbuf_pool = rte_pktmbuf_pool_create("MBUF_POOL", NUM_MBUF,
>> MBUF_CACHE_SIZE, 0,
>> +    RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
>> +
>> +    RTE_ETH_FOREACH_DEV(port_id) {
>> +    memset(ð_conf, 0, sizeof(dev_info));
> This clears "eth_conf", but the sizeof is "dev_info". Why?
> 

Will fix in next version, thx.

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

Re: [PATCH] net/mana: fix stats for txq bytes sent

RE: release candidate 23.07-rc4

[POC v3] net/iavf: support no data path polling mode

crypto decryption support in test-crypto-perf pmd-cycle-count test

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

[PATCH] app/test: fix include of standard header

RE: [PATCH] app/test: fix include of standard header

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

[RFC PATCH 0/5] replace build code for unit tests

[RFC PATCH 1/5] app/test: add new macros for various test types

[RFC PATCH 2/5] app/test: tag tests with the test type

[RFC PATCH 3/5] app/test: build using per-file dependency matrix

[RFC PATCH 4/5] app/test: define unit tests suites based on test macros

[RFC PATCH 5/5] app/test: add fast test suite to new build infrastructure

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

Re: [PATCH] net/ngbe: fix RSS offload capability

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

Re: [PATCH v1] test/graph: fix unused return value

Re: [PATCH v3] tap: fix build of TAP BPF program

DPDK Release Status Meeting 2023-07-20

[PATCH v1] doc: update release notes for 23.07

Re: [PATCH v3] tap: fix build of TAP BPF program

[RFC] ethdev: clarify device queue state after start and stop

[PATCH v12 1/2] mempool cache: add zero-copy get and put functions

[PATCH v12 2/2] net/i40e: replace put function

Re: [PATCH] app/test: fix include of standard header

Re: [RFC] ethdev: clarify device queue state after start and stop

Re: [RFC] ethdev: clarify device queue state after start and stop

Re: [RFC] ethdev: clarify device queue state after start and stop

Re: [RFC] ethdev: clarify device queue state after start and stop

34 matches

Site Navigation

Mail list logo

Footer information