[PATCH] ice: fix build error on 32bit configure

[Yiding Zhou]

Replace 'rte_memcpy' with 'memcpy' like other PMD code to avoid errors when
compiling with GCC-12 on 32-bit configure.

Compiler reports the follow error:

error: array subscript 8 is outside array bounds of "struct rte_mbuf *[32]"
[-Werror=array-bounds]

Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
Cc: sta...@dpdk.org

Signed-off-by: Yiding Zhou 
---
 drivers/net/ice/ice_rxtx_vec_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_rxtx_vec_common.h 
b/drivers/net/ice/ice_rxtx_vec_common.h
index eec6ea2134..55840cf170 100644
--- a/drivers/net/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/ice/ice_rxtx_vec_common.h
@@ -72,7 +72,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct 
rte_mbuf **rx_bufs,
/* save the partial packet for next time */
rxq->pkt_first_seg = start;
rxq->pkt_last_seg = end;
-   rte_memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
+   memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
return pkt_idx;
 }
 
-- 
2.34.1

RE: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID

[De Lara Guarch, Pablo]

> -Original Message-
> From: Power, Ciara 
> Sent: Friday, June 30, 2023 9:35 AM
> To: dev@dpdk.org
> Cc: Ji, Kai ; Power, Ciara ; De Lara
> Guarch, Pablo 
> Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID
> 
> In the case of multiprocess, when the same session is being used for both
> primary and secondary processes, the session ID will be the same.
> However the pointers are not available to the secondary process, so in this
> case when the session was created by a different process ID, then copy the
> template session to the job again.
> 
> Fixes: 0fb4834e00af ("crypto/ipsec_mb: set and use session ID")
> Cc: pablo.de.lara.gua...@intel.com
> 
> Signed-off-by: Ciara Power 

Acked-by: Pablo de Lara 

[PATCH] child process synchronization NIC startup parameters

[Kaisen You]

In meson_test, because the child process does not synchronize
the NIC startup parameters of the parent process at startup,
it uses all NICs bound by vfio as startup parameters by default,
and an exception occurs in the subsequent hugefile check,
causing the test to fail. Synchronize the NIC startup parameters
of the parent process to the child process to solve this problem.

Fixes: 786b29255c49 ("test: fix file prefix discovery")
Cc: sta...@dpdk.org

Signed-off-by: Kaisen You 
---
 app/test/process.h | 81 --
 1 file changed, 78 insertions(+), 3 deletions(-)

diff --git a/app/test/process.h b/app/test/process.h
index 1f073b9c5c..95dffab69c 100644
--- a/app/test/process.h
+++ b/app/test/process.h
@@ -15,6 +15,8 @@
 #include  /* strerror */
 #include  /* readlink */
 #include 
+#include 
+#include 
 
 #include  /* strlcpy */
 
@@ -24,6 +26,7 @@
 #else
 #define self "self"
 #define exe "exe"
+#define MAX_EXTRA_ARGS 32
 #endif
 
 #ifdef RTE_LIB_PDUMP
@@ -34,6 +37,50 @@ extern uint16_t flag_for_send_pkts;
 #endif
 #endif
 
+/* get cmdline form PID. Read process info form /proc/$PID. */
+static char *get_cmdline_from_pid(pid_t pid, char *buf, int len)
+{
+   char filename[PATH_MAX];
+   char *name = NULL;
+   int fd;
+   int ret;
+
+   if (pid < 1 || buf == NULL || len < 0) {
+   printf("%s: illegal param\n", __func__);
+   return NULL;
+   }
+
+   snprintf(filename, PATH_MAX, "/proc/%d/cmdline", pid);
+   memset(buf, 0, len);
+   fd = open(filename, O_RDONLY);
+   if (fd < 0) {
+   perror("open:");
+   return NULL;
+   }
+   ret = read(fd, buf, len);
+   close(fd);
+
+   if (ret < 0)
+   return NULL;
+
+   if (buf[ret-1] == '\n')
+   buf[--ret] = 0;
+
+   name = buf;
+   while (ret) {
+   if (((unsigned char)*name) < ' ')
+   *name = ' ';
+   name++;
+   ret--;
+   }
+   *name = 0;
+
+   if (buf[0])
+   return buf;
+
+   return NULL;
+}
+
 /*
  * launches a second copy of the test process using the given argv parameters,
  * which should include argv[0] as the process name. To identify in the
@@ -44,9 +91,15 @@ static inline int
 process_dup(const char *const argv[], int numargs, const char *env_value)
 {
int num;
-   char *argv_cpy[numargs + 1];
-   int i, status;
+   char *argv_cpy[MAX_EXTRA_ARGS];
+   int i, status, n, s, j;
char path[32];
+   char buf[1024];
+   char *token;
+   char str_1[] = "-a";
+   char str_2[] = " ";
+   char *argv_str[MAX_EXTRA_ARGS];
+   char *argv_copy[MAX_EXTRA_ARGS];
 #ifdef RTE_LIB_PDUMP
 #ifdef RTE_NET_RING
pthread_t thread;
@@ -113,10 +166,32 @@ process_dup(const char *const argv[], int numargs, const 
char *env_value)
closedir(dir);
}
 #endif
+   /* Add the -a parameter to the child process start parameter */
+   get_cmdline_from_pid(getppid(), buf, 1024);
+   token = strtok(buf, str_2);
+   argv_str[0] = strdup(token);
+   n = 0;
+   j = 0;
+   while (token != NULL) {
+   n = n + 1;
+   argv_str[n] = strdup(token);
+   token = strtok(NULL, str_2);
+   }
+   for (s = 0; s < n; s++) {
+   if (strcmp(argv_str[s], str_1) == 0 ||
+   strcmp(argv_str[s + 1], str_1) == 0) {
+   argv_copy[j] = strdup(argv_str[s + 1]);
+   j++;
+   }
+   }
+   for (s = 0; s < j; s++)
+   argv_cpy[numargs + s] = strdup(argv_copy[s]);
+
printf("Running binary with argv[]:");
-   for (i = 0; i < num; i++)
+   for (i = 0; i < num + j; i++)
printf("'%s' ", argv_cpy[i]);
printf("\n");
+   argv_cpy[numargs + j] = NULL;
fflush(stdout);
 
/* set the environment variable */
-- 
2.25.1

Re: [PATCH] eventdev: remove single-event enqueue operation

[Jerin Jacob]

On Tue, Jul 4, 2023 at 5:29 PM Mattias Rönnblom
 wrote:
>
> Eliminate non-burst enqueue operation from Eventdev.
>
> The effect of this change is to reduce Eventdev code complexity
> somewhat and slightly improve performance.
>
> The single-event enqueue shortcut provided a very minor performance
> advantage in some situations (e.g., with a compile time-constant burst
> size of '1'), but would in other situations cause a noticeable
> performance penalty (e.g., rte_event_enqueue_forward_burst() with run
> time-variable burst sizes varying between '1' and larger burst sizes).
>
> Signed-off-by: Mattias Rönnblom 
>
> --
>
> PATCH: Add ABI deprecation notice.


Need to split this patch as depreciation notice only will be merged to
this release.
Example: 
https://patches.dpdk.org/project/dpdk/patch/20230704194445.3332847-1-gak...@marvell.com/

I think, we need to remove the single dequeue as well. So I think, we
can write a generic deprecation notice
which says size of struct rte_event_fp_ops will be changed by removing
single enqueue, dequeue and.
Reservation fields size . Later we can analysis the performance impact
when the implementation patch is ready.
For now, let make deprecation notice for this release.

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

[Ferruh Yigit]

On 7/5/2023 4:16 AM, lihuisong (C) wrote:
> 
> 在 2023/7/4 18:59, Ferruh Yigit 写道:
>> On 7/4/2023 9:45 AM, Jie Hai wrote:
>>> Function update_queue_state updates queue state of all queues
>>> of all ports, using the queue num nb_rxq|nb_txq stored locally
>>> by testpmd. An error on the invalid queue ID occurs if we run
>>> testpmd with two ports and detach-attach one of them and start
>>> the other port first. This is because the attached port has not
>>> been configured and has no queues, which differs from nb_rxq|nb_txq.
>>> The similar error happens in multi-process senoris if secondary
>>> process attaches a port and starts it.
>>>
>>> This patch updates queue state of the specified port, which has
>>> been configured by primary process. As the secondary process
>>> cannot configure the ports, make sure that the secondary process
>>> starts the port only after the primary process has done so.
> Now look good to me.
> Acked-by: Huisong Li 
>>>
>>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling
>>> all queues")
>>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
>>> forwarding")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Jie Hai 
>>>
>> The problem description and solution looks reasonable to me, but Intel
>> testing still reporting the issue.
>>
>> There is a chance that the issue Intel side observing is different,
>> waiting for more information from Intel test team.
>>
>> .

Hi Song,

As far as I understand this patch works with an update from ixgbevf
driver, can you please confirm?
And can we have the ixgbevf fix soon, to not block the -rc3?

Thanks,
ferruh

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

[Ferruh Yigit]

On 7/5/2023 9:02 AM, Ferruh Yigit wrote:
> On 7/5/2023 4:16 AM, lihuisong (C) wrote:
>>
>> 在 2023/7/4 18:59, Ferruh Yigit 写道:
>>> On 7/4/2023 9:45 AM, Jie Hai wrote:
 Function update_queue_state updates queue state of all queues
 of all ports, using the queue num nb_rxq|nb_txq stored locally
 by testpmd. An error on the invalid queue ID occurs if we run
 testpmd with two ports and detach-attach one of them and start
 the other port first. This is because the attached port has not
 been configured and has no queues, which differs from nb_rxq|nb_txq.
 The similar error happens in multi-process senoris if secondary
 process attaches a port and starts it.

 This patch updates queue state of the specified port, which has
 been configured by primary process. As the secondary process
 cannot configure the ports, make sure that the secondary process
 starts the port only after the primary process has done so.
>> Now look good to me.
>> Acked-by: Huisong Li 

 Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling
 all queues")
 Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
 forwarding")
 Cc: sta...@dpdk.org

 Signed-off-by: Jie Hai 

>>> The problem description and solution looks reasonable to me, but Intel
>>> testing still reporting the issue.
>>>
>>> There is a chance that the issue Intel side observing is different,
>>> waiting for more information from Intel test team.
>>>
>>> .
> 
> Hi Song,
> 
> As far as I understand this patch works with an update from ixgbevf
> driver, can you please confirm?
> And can we have the ixgbevf fix soon, to not block the -rc3?
> 
> 

To record, the problem is testpmd change was to get queue status from
ethdev but ixgbe is not setting queue status correctly.

Re: [PATCH] eventdev: remove single-event enqueue operation

[Mattias Rönnblom]

On 2023-07-05 09:47, Jerin Jacob wrote:

On Tue, Jul 4, 2023 at 5:29 PM Mattias Rönnblom
 wrote:


Eliminate non-burst enqueue operation from Eventdev.

The effect of this change is to reduce Eventdev code complexity
somewhat and slightly improve performance.

The single-event enqueue shortcut provided a very minor performance
advantage in some situations (e.g., with a compile time-constant burst
size of '1'), but would in other situations cause a noticeable
performance penalty (e.g., rte_event_enqueue_forward_burst() with run
time-variable burst sizes varying between '1' and larger burst sizes).

Signed-off-by: Mattias Rönnblom 

--

PATCH: Add ABI deprecation notice.



Need to split this patch as depreciation notice only will be merged to
this release.
Example: 
https://patches.dpdk.org/project/dpdk/patch/20230704194445.3332847-1-gak...@marvell.com/

I think, we need to remove the single dequeue as well. So I think, we
can write a generic deprecation notice
which says size of struct rte_event_fp_ops will be changed by removing
single enqueue, dequeue and.
Reservation fields size . Later we can analysis the performance impact
when the implementation patch is ready.
For now, let make deprecation notice for this release.


OK, sounds good.

The size may be the same, but layout will be different.

[PATCH] eventdev: announce single-event enqueue/dequeue ABI change

[Mattias Rönnblom]

Announce the removal of the single-event enqueue and dequeue
operations from the eventdev ABI.

Signed-off-by: Mattias Rönnblom 
---
 doc/guides/rel_notes/deprecation.rst | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 66431789b0..ca192d838d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -153,3 +153,11 @@ Deprecation Notices
   The new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status
   starting with DPDK 23.07 release.
+
+* eventdev: The single-event (non-burst) enqueue and dequeue
+  operations, used by static inline burst enqueue and dequeue
+  functions in , will be removed in DPDK 23.11. This
+  simplification includes changing the layout and potentially also the
+  size of the public rte_event_fp_ops struct, breaking the ABI. Since
+  these functions are not called directly by the application, the API
+  remains unaffected.
-- 
2.34.1

[PATCH v1 0/2] fix memory leak

[Wenjun Wu]

This patch set fix memory leak in vdev and example hotplug_mp.

Wenjun Wu (2):
  bus/vdev: fix memory leak
  examples/multi_process: fix memory leak

 drivers/bus/vdev/vdev.c  |  5 +
 examples/multi_process/hotplug_mp/commands.c | 22 
 2 files changed, 27 insertions(+)

-- 
2.34.1

[PATCH v1 1/2] bus/vdev: fix memory leak

[Wenjun Wu]

In hotplug usecase, devargs will be allocated in secondary process
in the function alloc_devargs. Since it will not be insert into the
devarg_list, it will have no chance to be freed.

This patch adds additional memory free for device structure member devargs
in the secondary process in rte_vdev_uninit.

Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
Cc: sta...@dpdk.org

Signed-off-by: Wenjun Wu 
---
 drivers/bus/vdev/vdev.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 7974b27295..3f4e6a1b55 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -373,6 +373,11 @@ rte_vdev_uninit(const char *name)
 
TAILQ_REMOVE(&vdev_device_list, dev, next);
rte_devargs_remove(dev->device.devargs);
+   if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
+   dev->device.devargs != NULL) {
+   rte_devargs_reset(dev->device.devargs);
+   free(dev->device.devargs);
+   }
free(dev);
 
 unlock:
-- 
2.34.1

[PATCH v1 2/2] examples/multi_process: fix memory leak

[Wenjun Wu]

The device should be detached before quit, otherwise it will
cause memory leak.

Fixes: 05f1d6842fc3 ("examples/multi_process: add hotplug sample")
Cc: sta...@dpdk.org

Signed-off-by: Wenjun Wu 
---
 examples/multi_process/hotplug_mp/commands.c | 22 
 1 file changed, 22 insertions(+)

diff --git a/examples/multi_process/hotplug_mp/commands.c 
b/examples/multi_process/hotplug_mp/commands.c
index 88f44e00a0..143d57eeb6 100644
--- a/examples/multi_process/hotplug_mp/commands.c
+++ b/examples/multi_process/hotplug_mp/commands.c
@@ -52,6 +52,28 @@ static void cmd_quit_parsed(__rte_unused void *parsed_result,
struct cmdline *cl,
__rte_unused void *data)
 {
+   uint16_t port_id;
+   char dev_name[RTE_DEV_NAME_MAX_LEN];
+   struct rte_devargs da;
+
+   RTE_ETH_FOREACH_DEV(port_id) {
+   rte_eth_dev_get_name_by_port(port_id, dev_name);
+   memset(&da, 0, sizeof(da));
+
+   if (rte_devargs_parsef(&da, "%s", dev_name)) {
+   cmdline_printf(cl,
+  "cannot parse devargs for device %s\n",
+  dev_name);
+   }
+   printf("detaching before quit...\n");
+   if (!rte_eal_hotplug_remove(rte_bus_name(da.bus), da.name))
+   cmdline_printf(cl, "detached device %s\n",
+   da.name);
+   else
+   cmdline_printf(cl, "failed to detach device %s\n",
+   da.name);
+
+   }
cmdline_quit(cl);
 }
 
-- 
2.34.1

[PATCH] child process synchronization NIC startup parameters

[Kaisen You]

In meson_test, because the child process does not synchronize
the NIC startup parameters of the parent process at startup,
it uses all NICs bound by vfio as startup parameters by default,
and an exception occurs in the subsequent hugefile check,
causing the test to fail. Synchronize the NIC startup parameters
of the parent process to the child process to solve this problem.

Fixes: 786b29255c49 ("test: fix file prefix discovery")
Cc: sta...@dpdk.org

Signed-off-by: Kaisen You 
---
 app/test/process.h | 80 --
 1 file changed, 77 insertions(+), 3 deletions(-)

diff --git a/app/test/process.h b/app/test/process.h
index 1f073b9c5c..c8a15e8989 100644
--- a/app/test/process.h
+++ b/app/test/process.h
@@ -15,9 +15,11 @@
 #include  /* strerror */
 #include  /* readlink */
 #include 
+#include 
 
 #include  /* strlcpy */
 
+#define MAX_EXTRA_ARGS 32
 #ifdef RTE_EXEC_ENV_FREEBSD
 #define self "curproc"
 #define exe "file"
@@ -34,6 +36,50 @@ extern uint16_t flag_for_send_pkts;
 #endif
 #endif
 
+/* get cmdline form PID. Read process info form /proc/$PID. */
+static char *get_cmdline_from_pid(pid_t pid, char *buf, int len)
+{
+   char filename[PATH_MAX];
+   char *name = NULL;
+   int fd;
+   int ret;
+
+   if (pid < 1 || buf == NULL || len < 0) {
+   printf("%s: illegal param\n", __func__);
+   return NULL;
+   }
+
+   snprintf(filename, PATH_MAX, "/proc/%d/cmdline", pid);
+   memset(buf, 0, len);
+   fd = open(filename, O_RDONLY);
+   if (fd < 0) {
+   perror("open:");
+   return NULL;
+   }
+   ret = read(fd, buf, len);
+   close(fd);
+
+   if (ret < 0)
+   return NULL;
+
+   if (buf[ret-1] == '\n')
+   buf[--ret] = 0;
+
+   name = buf;
+   while (ret) {
+   if (((unsigned char)*name) < ' ')
+   *name = ' ';
+   name++;
+   ret--;
+   }
+   *name = 0;
+
+   if (buf[0])
+   return buf;
+
+   return NULL;
+}
+
 /*
  * launches a second copy of the test process using the given argv parameters,
  * which should include argv[0] as the process name. To identify in the
@@ -44,9 +90,15 @@ static inline int
 process_dup(const char *const argv[], int numargs, const char *env_value)
 {
int num;
-   char *argv_cpy[numargs + 1];
-   int i, status;
+   char *argv_cpy[MAX_EXTRA_ARGS];
+   int i, status, n, s, j;
char path[32];
+   char buf[1024];
+   char *token;
+   char str_1[] = "-a";
+   char str_2[] = " ";
+   char *argv_str[MAX_EXTRA_ARGS];
+   char *argv_copy[MAX_EXTRA_ARGS];
 #ifdef RTE_LIB_PDUMP
 #ifdef RTE_NET_RING
pthread_t thread;
@@ -113,10 +165,32 @@ process_dup(const char *const argv[], int numargs, const 
char *env_value)
closedir(dir);
}
 #endif
+   /* Add the -a parameter to the child process start parameter */
+   get_cmdline_from_pid(getppid(), buf, 1024);
+   token = strtok(buf, str_2);
+   argv_str[0] = strdup(token);
+   n = 0;
+   j = 0;
+   while (token != NULL) {
+   n = n + 1;
+   argv_str[n] = strdup(token);
+   token = strtok(NULL, str_2);
+   }
+   for (s = 0; s < n; s++) {
+   if (strcmp(argv_str[s], str_1) == 0 ||
+   strcmp(argv_str[s + 1], str_1) == 0) {
+   argv_copy[j] = strdup(argv_str[s + 1]);
+   j++;
+   }
+   }
+   for (s = 0; s < j; s++)
+   argv_cpy[numargs + s] = strdup(argv_copy[s]);
+
printf("Running binary with argv[]:");
-   for (i = 0; i < num; i++)
+   for (i = 0; i < num + j; i++)
printf("'%s' ", argv_cpy[i]);
printf("\n");
+   argv_cpy[numargs + j] = NULL;
fflush(stdout);
 
/* set the environment variable */
-- 
2.25.1

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

[lihuisong (C)]

在 2023/7/5 16:02, Ferruh Yigit 写道:

On 7/5/2023 4:16 AM, lihuisong (C) wrote:

在 2023/7/4 18:59, Ferruh Yigit 写道:

On 7/4/2023 9:45 AM, Jie Hai wrote:

Function update_queue_state updates queue state of all queues
of all ports, using the queue num nb_rxq|nb_txq stored locally
by testpmd. An error on the invalid queue ID occurs if we run
testpmd with two ports and detach-attach one of them and start
the other port first. This is because the attached port has not
been configured and has no queues, which differs from nb_rxq|nb_txq.
The similar error happens in multi-process senoris if secondary
process attaches a port and starts it.

This patch updates queue state of the specified port, which has
been configured by primary process. As the secondary process
cannot configure the ports, make sure that the secondary process
starts the port only after the primary process has done so.

Now look good to me.
Acked-by: Huisong Li 

Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling
all queues")
Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
forwarding")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 


The problem description and solution looks reasonable to me, but Intel
testing still reporting the issue.

There is a chance that the issue Intel side observing is different,
waiting for more information from Intel test team.

.

Hi Song,

As far as I understand this patch works with an update from ixgbevf
driver, can you please confirm?
And can we have the ixgbevf fix soon, to not block the -rc3?


Hi Ferruh,

Yes, ixgbe is not setting queue status correctly.
Whether tesptmd polls the queue depends on the queue status 
(dev->data->rx_queue_state[queue_id]).

But some drivers (not just ixgbe) do not set the status correctly.
Jie is doing this. will be sent ASAP.

/Huisong

.

[PATCH] net/mlx5: fix non-ip packets are not delivered when RSS hash type ESP is used.

[Maayan Kashani]

Non-ip packets such as ARP or LACP are not delivered if you use RTE flow rule 
with empty pattern and rss action with specific combination of RSS hash types: 
"ipv4-tcp ipv4-udp ipv4-other ipv6-tcp ipv6-udp ipv6-other esp".

The stack which used for RSS expansion was overflowed and trashed rss 
expanstion data(buf->entry[MLX5_RSS_EXP_ELT_N]). Use bigger stack size instead. 
And add relevant ASSERT for the future.

Signed-off-by: Maayan Kashani
Acked-by: Ori Kam
---
 drivers/net/mlx5/mlx5_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index cf83db7b60..41e298855b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -374,7 +374,7 @@ mlx5_flow_expand_rss_skip_explicit(const struct 
mlx5_flow_expand_node graph[],
return next;
 }
 
-#define MLX5_RSS_EXP_ELT_N 16
+#define MLX5_RSS_EXP_ELT_N 32
 
 /**
  * Expand RSS flows into several possible flows according to the RSS hash
@@ -539,6 +539,7 @@ mlx5_flow_expand_rss(struct mlx5_flow_expand_rss *buf, 
size_t size,
if (lsize > size)
return -EINVAL;
n = elt * sizeof(*item);
+   MLX5_ASSERT((buf->entries) < MLX5_RSS_EXP_ELT_N);
buf->entry[buf->entries].priority =
stack_pos + 1 + missed;
buf->entry[buf->entries].pattern = addr;
-- 
2.25.1

RE: [PATCH] cryptodev: fix device socket ID type

[Morten Brørup]

In my opinion, changing the type to the conventional type used for socket_id 
seems like a much better solution than just changing the signedness, as 
proposed in  another RFC [1]. (If we used more specialized types, like 
socket_id_t, we wouldn't even have this discussion. It is the DPDK convention 
to avoid specialized types, and I'm not against this convention; I'm only 
mentioning it to support changing the type here to int.)

 

And SOCKET_ID_ANY (-1) being used for multiple purposes, as discussed in the 
RFC, is another issue, to be discussed separately.

 

[1]: 
https://patches.dpdk.org/project/dpdk/patch/20230117101646.2521875-1-didier.pall...@6wind.com/
 

 

 

Acked-by: Morten Brørup 

 

Acked-by: Kai Ji 



From: Power, Ciara 
Sent: 29 June 2023 14:21
To: dev@dpdk.org 
Cc: Ji, Kai ; Power, Ciara ; Matz, 
Olivier ; Akhil Goyal ; Fan Zhang 

Subject: [PATCH] cryptodev: fix device socket ID type 

 

The socket ID field for a cryptodev device data was unsigned int.
Due to recent changes to the default device socket ID,
this caused an issue when the socket ID was unknown and set to -1.
The device socket ID wrapped around to 255,
and caused errors when allocating memory.

Changing this field type to int fixes the issue, as it now takes the
correct -1 value.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com

Signed-off-by: Ciara Power 
---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 8710ed7558..4c98cedca6 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -65,7 +65,7 @@ struct rte_cryptodev_data {
 /** Device ID for this instance */
 uint8_t dev_id;
 /** Socket ID where memory is allocated */
-   uint8_t socket_id;
+   int socket_id;
 /** Unique identifier name */
 char name[RTE_CRYPTODEV_NAME_MAX_LEN];
 
-- 
2.25.1

[v2 1/2] doc: add policy for adding vendor PMD specific examples

[Hemant Agrawal]

This patch update the dpdk sample app policy to support
vendor PMD specific test examples in the respective drivers
sub-directory in examples.

Signed-off-by: Hemant Agrawal 
Acked-by: Jerin Jacob 
---
 doc/guides/sample_app_ug/intro.rst | 12 
 1 file changed, 12 insertions(+)

diff --git a/doc/guides/sample_app_ug/intro.rst 
b/doc/guides/sample_app_ug/intro.rst
index e765f1fd6b..279aecdfda 100644
--- a/doc/guides/sample_app_ug/intro.rst
+++ b/doc/guides/sample_app_ug/intro.rst
@@ -94,3 +94,15 @@ examples are highlighted below.
 There are many more examples shown in the following chapters. Each of the
 documented sample applications show how to compile, configure and run the
 application as well as explaining the main functionality of the code.
+
+Driver specific Sample Application
+--
+
+There are cases where existing sample applications may not be suitable to test
+a new driver contribution. In such cases a new driver specific sample 
application
+can be added to specific drivers sub-directory in the examples folder with 
prior
+approval from DPDK technical board. e.g.
+
+* :doc:`NTB Sample Application`: The NTB Sample Application,
+  or ``ntb`` application demonstrates how to use NTB rawdev driver for
+  packet based processing between two systems..
-- 
2.17.1

[v2 2/2] examples: move vendor specific apps to drivers sub directory

[Hemant Agrawal]

As approved by DPDK technical board on 2021-03-24 NTB
raw driver example application will be moved to
example/rawdev/ to avoid PMD specific example application
to show up in examples directory.

Signed-off-by: Hemant Agrawal 
---
 doc/guides/sample_app_ug/ntb.rst  |  2 +-
 examples/meson.build  |  2 +-
 examples/rawdev/Makefile  | 10 ++
 examples/{ => rawdev}/ntb/Makefile|  0
 examples/{ => rawdev}/ntb/meson.build |  0
 examples/{ => rawdev}/ntb/ntb_fwd.c   |  0
 6 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 examples/rawdev/Makefile
 rename examples/{ => rawdev}/ntb/Makefile (100%)
 rename examples/{ => rawdev}/ntb/meson.build (100%)
 rename examples/{ => rawdev}/ntb/ntb_fwd.c (100%)

diff --git a/doc/guides/sample_app_ug/ntb.rst b/doc/guides/sample_app_ug/ntb.rst
index f80b221db7..10f7395aff 100644
--- a/doc/guides/sample_app_ug/ntb.rst
+++ b/doc/guides/sample_app_ug/ntb.rst
@@ -22,7 +22,7 @@ Compiling the Application
 
 To compile the sample application see :doc:`compiling`.
 
-The application is located in the ``ntb`` sub-directory.
+The ``ntb`` application code is located in the ``rawdev/ntb`` sub-directory.
 
 Running the Application
 ---
diff --git a/examples/meson.build b/examples/meson.build
index 55ba8847a0..f4a1ea3f70 100644
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -39,12 +39,12 @@ all_examples = [
 'multi_process/hotplug_mp',
 'multi_process/simple_mp',
 'multi_process/symmetric_mp',
-'ntb',
 'packet_ordering',
 'pipeline',
 'ptpclient',
 'qos_meter',
 'qos_sched',
+'rawdev/ntb',
 'rxtx_callbacks',
 'server_node_efd/efd_node',
 'server_node_efd/efd_server',
diff --git a/examples/rawdev/Makefile b/examples/rawdev/Makefile
new file mode 100644
index 00..0c26937a13
--- /dev/null
+++ b/examples/rawdev/Makefile
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2023 NXP
+
+subdirs := ntb
+
+.PHONY: all static shared clean $(subdirs)
+all static shared clean: $(subdirs)
+
+$(subdirs):
+   $(MAKE) -C $@ $(MAKECMDGOALS)
diff --git a/examples/ntb/Makefile b/examples/rawdev/ntb/Makefile
similarity index 100%
rename from examples/ntb/Makefile
rename to examples/rawdev/ntb/Makefile
diff --git a/examples/ntb/meson.build b/examples/rawdev/ntb/meson.build
similarity index 100%
rename from examples/ntb/meson.build
rename to examples/rawdev/ntb/meson.build
diff --git a/examples/ntb/ntb_fwd.c b/examples/rawdev/ntb/ntb_fwd.c
similarity index 100%
rename from examples/ntb/ntb_fwd.c
rename to examples/rawdev/ntb/ntb_fwd.c
-- 
2.17.1

[PATCH] crypto/ipsec_mb: fix jobs array used for burst

[Ciara Power]

The jobs variable was global, which meant it was not thread safe.
This casued a segmentation fault when running the crypto performance
app, using more than one lcore for crypto processing.

Moving this to the dequeue function where it is used fixes the issue.

Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
Cc: marcel.d.co...@intel.com

Signed-off-by: Ciara Power 
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c 
b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index f4322d9af4..f702127f7f 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data {
uint32_t offset;
 };
 
-#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM
-static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};
-#endif
-
 /**
  * Calculate the authentication pre-computes
  *
@@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct 
rte_crypto_op **ops,
IMB_JOB *job;
int retval, processed_jobs = 0;
uint16_t i, nb_jobs;
+   IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};
 
if (unlikely(nb_ops == 0 || mb_mgr == NULL))
return 0;
-- 
2.25.1

Re: [PATCH] crypto/ipsec_mb: fix jobs array used for burst

[Ji, Kai]

Acked-by: Kai Ji mailto:kai...@intel.com>>

From: Power, Ciara 
Sent: 05 July 2023 11:15
To: dev@dpdk.org 
Cc: gak...@marvell.com ; De Lara Guarch, Pablo 
; Power, Ciara ; Cornu, 
Marcel D ; Ji, Kai 
Subject: [PATCH] crypto/ipsec_mb: fix jobs array used for burst

The jobs variable was global, which meant it was not thread safe.
This casued a segmentation fault when running the crypto performance
app, using more than one lcore for crypto processing.

Moving this to the dequeue function where it is used fixes the issue.

Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
Cc: marcel.d.co...@intel.com

Signed-off-by: Ciara Power 
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c 
b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index f4322d9af4..f702127f7f 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data {
 uint32_t offset;
 };

-#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM
-static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};
-#endif
-
 /**
  * Calculate the authentication pre-computes
  *
@@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct 
rte_crypto_op **ops,
 IMB_JOB *job;
 int retval, processed_jobs = 0;
 uint16_t i, nb_jobs;
+   IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};

 if (unlikely(nb_ops == 0 || mb_mgr == NULL))
 return 0;
--
2.25.1

[PATCH v2] crypto/ipsec_mb: fix jobs array used for burst

[Ciara Power]

The jobs variable was global, which meant it was not thread safe.
This caused a segmentation fault when running the crypto performance
app, using more than one lcore for crypto processing.

Moving this to the dequeue function where it is used fixes the issue.

Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
Cc: marcel.d.co...@intel.com

Signed-off-by: Ciara Power 
Acked-by: Kai Ji 

---
v2: fixed typo in commit
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c 
b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index f4322d9af4..f702127f7f 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data {
uint32_t offset;
 };
 
-#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM
-static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};
-#endif
-
 /**
  * Calculate the authentication pre-computes
  *
@@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct 
rte_crypto_op **ops,
IMB_JOB *job;
int retval, processed_jobs = 0;
uint16_t i, nb_jobs;
+   IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL};
 
if (unlikely(nb_ops == 0 || mb_mgr == NULL))
return 0;
-- 
2.25.1

[PATCH] app/crypto-perf: fix socket ID default value

[Ciara Power]

Due to recent changes to the default device socket ID,
before being used as an index for session mempool list,
the socket ID should be set to 0 if unknown (-1).

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org

Signed-off-by: Ciara Power 
---
 app/test-crypto-perf/main.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index af5bd0d23b..b74e7ba118 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -651,6 +651,11 @@ main(int argc, char **argv)
cdev_id = enabled_cdevs[cdev_index];
 
uint8_t socket_id = rte_cryptodev_socket_id(cdev_id);
+   /* range check the socket_id, negative values become big
+* positive ones due to use of unsigned value
+*/
+   if (socket_id >= RTE_MAX_NUMA_NODES)
+   socket_id = 0;
 
ctx[i] = cperf_testmap[opts.test].constructor(
session_pool_socket[socket_id].sess_mp,
-- 
2.25.1

[PATCH] net/iavf: fix Tunnel TSO path selecting.

[Ke Xu]

IAVF curerently supports TSO and Tunnel TSO. Both these two features
 are implemented in scalar path. As there are missed flags for Tunnel
 TSO, it selects vector paths wrongly when only Tunnel TSO is enabled.

This patch added the missed flags to fix the Tunnel TSO path selecting.

Signed-off-by: Ke Xu 
---
 drivers/net/iavf/iavf_rxtx.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 8d4a77271a..605ea3f824 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -31,6 +31,10 @@
RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
RTE_ETH_TX_OFFLOAD_MULTI_SEGS |  \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+   RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |   \
+   RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+   RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |\
+   RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |  \
RTE_ETH_TX_OFFLOAD_SECURITY)
 
 #define IAVF_TX_VECTOR_OFFLOAD (\
-- 
2.34.1

[PATCH v2] cryptodev: fix device socket ID type

[Ciara Power]

The socket ID field for a cryptodev device data was unsigned int.
Due to recent changes to the default device socket ID,
this caused an issue when the socket ID was unknown and set to -1.
The device socket ID wrapped around to 255,
and caused errors when allocating memory.

Changing this field type to int fixes the issue, as it now takes the
correct -1 value.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org

Signed-off-by: Ciara Power 
Acked-by: Morten Brørup 
Acked-by: Kai Ji 

---
v2: Added cc for stable mailing list
---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 8710ed7558..4c98cedca6 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -65,7 +65,7 @@ struct rte_cryptodev_data {
/** Device ID for this instance */
uint8_t dev_id;
/** Socket ID where memory is allocated */
-   uint8_t socket_id;
+   int socket_id;
/** Unique identifier name */
char name[RTE_CRYPTODEV_NAME_MAX_LEN];
 
-- 
2.25.1

[PATCH] doc: add information to update dma entry limit

[Nipun Gupta]

VFIO module provides configurable dma_entry_limit
parameter to store the DMA entries. By default this
is 64K and if we are using --no-huge, we shall need
to increase the value of dma_entry_limit. Add
commands in linux_gsg document to change the
dma_entry_limit.

Signed-off-by: Nipun Gupta 
---
 doc/guides/linux_gsg/linux_drivers.rst | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/doc/guides/linux_gsg/linux_drivers.rst 
b/doc/guides/linux_gsg/linux_drivers.rst
index 2cec1ebede..b729bb38a8 100644
--- a/doc/guides/linux_gsg/linux_drivers.rst
+++ b/doc/guides/linux_gsg/linux_drivers.rst
@@ -180,6 +180,21 @@ VFIO module parameter ``dma_entry_limit`` with a default 
value of 64K.
 When application is out of DMA entries, these limits need to be adjusted to
 increase the allowed limit.
 
+When ``no-huge`` parameter is used, the page size used is of smaller size of
+``4K`` or ``64K`` and we shall need to increase ``dma_entry_limit``.
+To update the ``dma_entry_limit``, ``vfio_iommu_type1`` has to be loaded with
+additional module parameter:
+
+.. code-block:: console
+
+   modprobe vfio_iommu_type1 dma_entry_limit=512000
+
+Alternatively, one can also change this value in an already loaded kernel 
module:
+
+.. code-block:: console
+
+   echo 512000 > /sys/module/vfio_iommu_type1/parameters/dma_entry_limit
+
 Creating Virtual Functions using vfio-pci
 ~~
 
-- 
2.17.1

Re: [PATCH] doc: announce deprecation for security ops

[Hemant Agrawal]

Acked-by: Hemant Agrawal 

On 05-Jul-23 1:14 AM, Akhil Goyal wrote:

Caution: This is an external email. Please take care when clicking links or 
opening attachments. When in doubt, report the message using the 'Report this 
email' button


Structure rte_security_ops and rte_security_ctx are meant to
be used by rte_security library and the PMDs associated.
These will be moved to an internal header in DPDK 23.11 release.

Signed-off-by: Akhil Goyal 
---
  doc/guides/rel_notes/deprecation.rst | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 8e1cdd677a..74bdb4f577 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -133,6 +133,9 @@ Deprecation Notices
``rte_cryptodev_get_auth_algo_string``, 
``rte_cryptodev_get_aead_algo_string`` and
``rte_cryptodev_asym_get_xform_string`` respectively.

+* security: Hide structures ``rte_security_ops`` and ``rte_security_ctx`` as 
these
+  are internal to DPDK library and PMDs.
+
  * flow_classify: The flow_classify library and example have no maintainer.
The library is experimental and, as such, it could be removed from DPDK.
Its removal has been postponed to let potential users report interest
--
2.25.1

[PATCH v4 0/4] net/mlx5: introduce Tx datapath tracing

[Viacheslav Ovsiienko]

The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track the internal delay issues).

Because the DPDK tx datapath API does not suppose getting any feedback
from the driver and the feature looks like to be mlx5 specific, it seems
to be reasonable to engage exisiting DPDK datapath tracing capability.

The work cycle is supposed to be:
  - compile appplication with enabled tracing
  - run application with EAL parameters configuring the tracing in mlx5
Tx datapath
  - store the dump file with gathered tracing information
  - run analyzing scrypt (in Python) to combine related events (packet
firing and completion) and see the data in human-readable view

Below is the detailed instruction "how to" with mlx5 NIC to gather
all the debug data including the full timings information.


1. Build DPDK application with enabled datapath tracing

The meson option should be specified:
   --enable_trace_fp=true

The c_args shoudl be specified:
   -DALLOW_EXPERIMENTAL_API

The DPDK configuration examples:

  meson configure --buildtype=debug -Denable_trace_fp=true
-Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT 
-DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=debug -Denable_trace_fp=true
-Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=release -Denable_trace_fp=true
-Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=release -Denable_trace_fp=true
-Dc_args='-DALLOW_EXPERIMENTAL_API' build


2. Configuring the NIC

If the sending completion timings are important the NIC should be configured
to provide realtime timestamps, the REAL_TIME_CLOCK_ENABLE NV settings parameter
should be configured to TRUE, for example with command (and with following
FW/driver reset):

  sudo mlxconfig -d /dev/mst/mt4125_pciconf0 s REAL_TIME_CLOCK_ENABLE=1


3. Run DPDK application to gather the traces

EAL parameters controlling trace capability in runtime

  --trace=pmd.net.mlx5.tx - the regular expression enabling the tracepoints
with matching names at least "pmd.net.mlx5.tx"
must be enabled to gather all events needed
to analyze mlx5 Tx datapath and its timings.
By default all tracepoints are disabled.

  --trace-dir=/var/log - trace storing directory

  --trace-bufsz=B|K|M - optional, trace data buffer size
   per thread. The default is 1MB.

  --trace-mode=overwrite|discard  - optional, selects trace data buffer mode.


4. Installing or Building Babeltrace2 Package

The gathered trace data can be analyzed with a developed Python script.
To parse the trace, the data script uses the Babeltrace2 library.
The package should be either installed or built from source code as
shown below:

  git clone https://github.com/efficios/babeltrace.git
  cd babeltrace
  ./bootstrap
  ./configure -help
  ./configure --disable-api-doc --disable-man-pages
  --disable-python-bindings-doc --enbale-python-plugins
  --enable-python-binding

5. Running the Analyzing Script

The analyzing script is located in the folder: ./drivers/net/mlx5/tools
It requires Python3.6, Babeltrace2 packages and it takes the only parameter
of trace data file. For example:

   ./mlx5_trace.py /var/log/rte-2023-01-23-AM-11-52-39


6. Interpreting the Script Output Data

All the timings are given in nanoseconds.
The list of Tx (and coming Rx) bursts per port/queue is presented in the output.
Each list element contains the list of built WQEs with specific opcodes, and
each WQE contains the list of the encompassed packets to send.

Signed-off-by: Viacheslav Ovsiienko 

--
v2: - comment addressed: "dump_trace" command is replaced with "save_trace"
- Windows build failure addressed, Windows does not support tracing

v3: - tracepoint routines are moved to the net folder, no need to export
- documentation added
- testpmd patches moved out from series to the dedicated patches

v4: - Python comments addressed
- codestyle issues fixed

Viacheslav Ovsiienko (4):
  net/mlx5: introduce tracepoints for mlx5 drivers
  net/mlx5: add comprehensive send completion trace
  net/mlx5: add Tx datapath trace analyzing script
  doc: add mlx5 datapath tracing feature description

 doc/guides/nics/mlx5.rst |  78 +++
 drivers/net/mlx5/linux/mlx5_verbs.c  |   8 +-
 drivers/net/mlx5/mlx5_devx.c |   8 +-
 drivers/net/mlx5/mlx5_rx.h   |  19 --
 drivers/net/mlx5/mlx5_rxtx.h |  19 ++
 drivers/net/mlx5/mlx5_tx.c   |  29 +++
 drivers/net/mlx5/mlx5_tx.h   | 135 +++-
 drivers/net/mlx5/tools/mlx5_tr

[PATCH v4 2/4] net/mlx5: add comprehensive send completion trace

[Viacheslav Ovsiienko]

There is the demand to trace the send completions of
every WQE if time scheduling is enabled.

The patch extends the size of completion queue and
requests completion on every issued WQE in the
send queue. As the result hardware provides CQE on
each completed WQE and driver is able to fetch
completion timestamp for dedicated operation.

The add code is under conditional compilation
RTE_ENABLE_TRACE_FP flag and does not impact the
release code.

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/linux/mlx5_verbs.c |  8 +++-
 drivers/net/mlx5/mlx5_devx.c|  8 +++-
 drivers/net/mlx5/mlx5_tx.h  | 63 +++--
 3 files changed, 71 insertions(+), 8 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c 
b/drivers/net/mlx5/linux/mlx5_verbs.c
index 7233c2c7fa..b54f3ccd9a 100644
--- a/drivers/net/mlx5/linux/mlx5_verbs.c
+++ b/drivers/net/mlx5/linux/mlx5_verbs.c
@@ -968,8 +968,12 @@ mlx5_txq_ibv_obj_new(struct rte_eth_dev *dev, uint16_t idx)
rte_errno = EINVAL;
return -rte_errno;
}
-   cqe_n = desc / MLX5_TX_COMP_THRESH +
-   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
+   if (__rte_trace_point_fp_is_enabled() &&
+   txq_data->offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP)
+   cqe_n = UINT16_MAX / 2 - 1;
+   else
+   cqe_n = desc / MLX5_TX_COMP_THRESH +
+   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
txq_obj->cq = mlx5_glue->create_cq(priv->sh->cdev->ctx, cqe_n,
   NULL, NULL, 0);
if (txq_obj->cq == NULL) {
diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index 4369d2557e..5082a7e178 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -1465,8 +1465,12 @@ mlx5_txq_devx_obj_new(struct rte_eth_dev *dev, uint16_t 
idx)
MLX5_ASSERT(ppriv);
txq_obj->txq_ctrl = txq_ctrl;
txq_obj->dev = dev;
-   cqe_n = (1UL << txq_data->elts_n) / MLX5_TX_COMP_THRESH +
-   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
+   if (__rte_trace_point_fp_is_enabled() &&
+   txq_data->offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP)
+   cqe_n = UINT16_MAX / 2 - 1;
+   else
+   cqe_n = (1UL << txq_data->elts_n) / MLX5_TX_COMP_THRESH +
+   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
log_desc_n = log2above(cqe_n);
cqe_n = 1UL << log_desc_n;
if (cqe_n > UINT16_MAX) {
diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h
index b90cdf1fcc..47ee8bca4f 100644
--- a/drivers/net/mlx5/mlx5_tx.h
+++ b/drivers/net/mlx5/mlx5_tx.h
@@ -775,6 +775,54 @@ mlx5_tx_request_completion(struct mlx5_txq_data 
*__rte_restrict txq,
}
 }
 
+/**
+ * Set completion request flag for all issued WQEs.
+ * This routine is intended to be used with enabled fast path tracing
+ * and send scheduling on time to provide the detailed report in trace
+ * for send completions on every WQE.
+ *
+ * @param txq
+ *   Pointer to TX queue structure.
+ * @param loc
+ *   Pointer to burst routine local context.
+ * @param olx
+ *   Configured Tx offloads mask. It is fully defined at
+ *   compile time and may be used for optimization.
+ */
+static __rte_always_inline void
+mlx5_tx_request_completion_trace(struct mlx5_txq_data *__rte_restrict txq,
+struct mlx5_txq_local *__rte_restrict loc,
+unsigned int olx)
+{
+   uint16_t head = txq->elts_comp;
+
+   while (txq->wqe_comp != txq->wqe_ci) {
+   volatile struct mlx5_wqe *wqe;
+   uint32_t wqe_n;
+
+   MLX5_ASSERT(loc->wqe_last);
+   wqe = txq->wqes + (txq->wqe_comp & txq->wqe_m);
+   if (wqe == loc->wqe_last) {
+   head = txq->elts_head;
+   head += MLX5_TXOFF_CONFIG(INLINE) ?
+   0 : loc->pkts_sent - loc->pkts_copy;
+   txq->elts_comp = head;
+   }
+   /* Completion request flag was set on cseg constructing. */
+#ifdef RTE_LIBRTE_MLX5_DEBUG
+   txq->fcqs[txq->cq_pi++ & txq->cqe_m] = head |
+ (wqe->cseg.opcode >> 8) << 16;
+#else
+   txq->fcqs[txq->cq_pi++ & txq->cqe_m] = head;
+#endif
+   /* A CQE slot must always be available. */
+   MLX5_ASSERT((txq->cq_pi - txq->cq_ci) <= txq->cqe_s);
+   /* Advance to the next WQE in the queue. */
+   wqe_n = rte_be_to_cpu_32(wqe->cseg.sq_ds) & 0x3F;
+   txq->wqe_comp += RTE_ALIGN(wqe_n, 4) / 4;
+   }
+}
+
 /**
  * Build the Control Segment with specified opcode:
  * - MLX5_OPCODE_SEND
@@ -801,7 +849,7 @@ mlx5_tx_cseg_init(struct mlx5_txq_data *__rte_restrict txq,
  struct mlx5_wqe *__rte_restrict wqe,
  unsigned int ds,
  unsigned i

[PATCH v4 1/4] net/mlx5: introduce tracepoints for mlx5 drivers

[Viacheslav Ovsiienko]

There is an intention to engage DPDK tracing capabilities
for mlx5 PMDs monitoring and profiling in various modes.
The patch introduces tracepoints for the Tx datapath in
the ethernet device driver.

To engage this tracing capability the following steps
should be taken:

- meson option -Denable_trace_fp=true
- meson option -Dc_args='-DALLOW_EXPERIMENTAL_API'
- EAL command line parameter --trace=pmd.net.mlx5.tx.*

The Tx datapath tracing allows to get information how packets
are pushed into hardware descriptors, time stamping for
scheduled wait and send completions, etc.

To provide the human readable form of trace results the
dedicated post-processing script is presumed.

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/mlx5_rx.h   | 19 --
 drivers/net/mlx5/mlx5_rxtx.h | 19 ++
 drivers/net/mlx5/mlx5_tx.c   | 29 +++
 drivers/net/mlx5/mlx5_tx.h   | 72 +++-
 4 files changed, 118 insertions(+), 21 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rx.h b/drivers/net/mlx5/mlx5_rx.h
index 3514edd84e..f42607dce4 100644
--- a/drivers/net/mlx5/mlx5_rx.h
+++ b/drivers/net/mlx5/mlx5_rx.h
@@ -377,25 +377,6 @@ mlx5_rx_mb2mr(struct mlx5_rxq_data *rxq, struct rte_mbuf 
*mb)
return mlx5_mr_mempool2mr_bh(mr_ctrl, mb->pool, addr);
 }
 
-/**
- * Convert timestamp from HW format to linear counter
- * from Packet Pacing Clock Queue CQE timestamp format.
- *
- * @param sh
- *   Pointer to the device shared context. Might be needed
- *   to convert according current device configuration.
- * @param ts
- *   Timestamp from CQE to convert.
- * @return
- *   UTC in nanoseconds
- */
-static __rte_always_inline uint64_t
-mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)
-{
-   RTE_SET_USED(sh);
-   return (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;
-}
-
 /**
  * Set timestamp in mbuf dynamic field.
  *
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index 876aa14ae6..b109d50758 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -43,4 +43,23 @@ int mlx5_queue_state_modify_primary(struct rte_eth_dev *dev,
 int mlx5_queue_state_modify(struct rte_eth_dev *dev,
struct mlx5_mp_arg_queue_state_modify *sm);
 
+/**
+ * Convert timestamp from HW format to linear counter
+ * from Packet Pacing Clock Queue CQE timestamp format.
+ *
+ * @param sh
+ *   Pointer to the device shared context. Might be needed
+ *   to convert according current device configuration.
+ * @param ts
+ *   Timestamp from CQE to convert.
+ * @return
+ *   UTC in nanoseconds
+ */
+static __rte_always_inline uint64_t
+mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)
+{
+   RTE_SET_USED(sh);
+   return (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;
+}
+
 #endif /* RTE_PMD_MLX5_RXTX_H_ */
diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index 14e1487e59..13e2d90e03 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -232,6 +233,15 @@ mlx5_tx_handle_completion(struct mlx5_txq_data 
*__rte_restrict txq,
MLX5_ASSERT((txq->fcqs[txq->cq_ci & txq->cqe_m] >> 16) ==
cqe->wqe_counter);
 #endif
+   if (__rte_trace_point_fp_is_enabled()) {
+   uint64_t ts = rte_be_to_cpu_64(cqe->timestamp);
+   uint16_t wqe_id = rte_be_to_cpu_16(cqe->wqe_counter);
+
+   if (txq->rt_timestamp)
+   ts = mlx5_txpp_convert_rx_ts(NULL, ts);
+   rte_pmd_mlx5_trace_tx_complete(txq->port_id, txq->idx,
+  wqe_id, ts);
+   }
ring_doorbell = true;
++txq->cq_ci;
last_cqe = cqe;
@@ -752,3 +762,22 @@ mlx5_tx_burst_mode_get(struct rte_eth_dev *dev,
}
return -EINVAL;
 }
+
+/* TX burst subroutines trace points. */
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_entry,
+   pmd.net.mlx5.tx.entry)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_exit,
+   pmd.net.mlx5.tx.exit)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_wqe,
+   pmd.net.mlx5.tx.wqe)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_wait,
+   pmd.net.mlx5.tx.wait)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_push,
+   pmd.net.mlx5.tx.push)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_complete,
+   pmd.net.mlx5.tx.complete)
diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h
index cc8f7e98aa..b90cdf1fcc 100644
--- a/drivers/net/mlx5/mlx5_tx.h
+++ b/drivers/net/mlx5/mlx5_tx.h
@@ -13,12 +13,61 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 
 #include "mlx5.h"
 #include "mlx5_autoconf.h"
+#include "mlx5_rxtx.h"
+
+/* TX burst subroutines trace points. */
+RTE_TRACE

[PATCH v4 3/4] net/mlx5: add Tx datapath trace analyzing script

[Viacheslav Ovsiienko]

The Python script is intended to analyze mlx5 PMD
datapath traces and report:
  - tx_burst routine timings
  - how packets are pushed to WQEs
  - how packet sending is completed with timings

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/tools/mlx5_trace.py | 307 +++
 1 file changed, 307 insertions(+)
 create mode 100755 drivers/net/mlx5/tools/mlx5_trace.py

diff --git a/drivers/net/mlx5/tools/mlx5_trace.py 
b/drivers/net/mlx5/tools/mlx5_trace.py
new file mode 100755
index 00..8c1fd0a350
--- /dev/null
+++ b/drivers/net/mlx5/tools/mlx5_trace.py
@@ -0,0 +1,307 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2023 NVIDIA Corporation & Affiliates
+
+"""
+Analyzing the mlx5 PMD datapath tracings
+"""
+import sys
+import argparse
+import bt2
+
+PFX_TX = "pmd.net.mlx5.tx."
+PFX_TX_LEN = len(PFX_TX)
+
+
+class MlxQueue:
+"""Queue container object"""
+
+def __init__(self):
+self.done_burst = []  # completed bursts
+self.wait_burst = []  # waiting for completion
+self.pq_id = 0
+
+def log(self):
+"""Log all queue bursts"""
+for txb in self.done_burst:
+txb.log()
+
+
+class MlxMbuf:
+"""Packet mbufs container object"""
+
+def __init__(self):
+self.wqe = 0 # wqe id
+self.ptr = None  # first packet mbuf pointer
+self.len = 0 # packet data length
+self.nseg = 0# number of segments
+
+def log(self):
+"""Log mbuf"""
+out_txt = "%X: %u" % (self.ptr, self.len)
+if self.nseg != 1:
+out_txt += " (%d segs)" % self.nseg
+print(out_txt)
+
+
+class MlxWqe:
+"""WQE container object"""
+
+def __init__(self):
+self.mbuf = []# list of mbufs in WQE
+self.wait_ts = 0  # preceding wait/push timestamp
+self.comp_ts = 0  # send/recv completion timestamp
+self.opcode = 0
+
+def log(self):
+"""Log WQE"""
+wqe_id = (self.opcode >> 8) & 0x
+wqe_op = self.opcode & 0xFF
+out_txt = "  %04X: " % wqe_id
+if wqe_op == 0xF:
+out_txt += "WAIT"
+elif wqe_op == 0x29:
+out_txt += "EMPW"
+elif wqe_op == 0xE:
+out_txt += "TSO "
+elif wqe_op == 0xA:
+out_txt += "SEND"
+else:
+out_txt += "0x%02X" % wqe_op
+if self.comp_ts != 0:
+out_txt += " (%d, %d)" % (self.wait_ts, self.comp_ts - 
self.wait_ts)
+else:
+out_txt += " (%d)" % self.wait_ts
+print(out_txt)
+for mbuf in self.mbuf:
+mbuf.log()
+
+def comp(self, wqe_id, wqe_ts):
+"""Return 0 if WQE in not completedLog WQE"""
+if self.comp_ts != 0:
+return 1
+cur_id = (self.opcode >> 8) & 0x
+if cur_id > wqe_id:
+cur_id -= wqe_id
+if cur_id <= 0x8000:
+return 0
+else:
+cur_id = wqe_id - cur_id
+if cur_id >= 0x8000:
+return 0
+self.comp_ts = wqe_ts
+return 1
+
+
+class MlxBurst:
+"""Packet burst container object"""
+
+def __init__(self):
+self.wqes = []# issued burst WQEs
+self.done = 0 # number of sent/recv packets
+self.req = 0  # requested number of packets
+self.call_ts = 0  # burst routine invocation
+self.done_ts = 0  # burst routine done
+self.queue = None
+
+def log(self):
+"""Log burst"""
+port = self.queue.pq_id >> 16
+queue = self.queue.pq_id & 0x
+if self.req == 0:
+print(
+"%u: tx(p=%u, q=%u, %u/%u pkts (incomplete)"
+% (self.call_ts, port, queue, self.done, self.req)
+)
+else:
+print(
+"%u: tx(p=%u, q=%u, %u/%u pkts in %u"
+% (
+self.call_ts,
+port,
+queue,
+self.done,
+self.req,
+self.done_ts - self.call_ts,
+)
+)
+for wqe in self.wqes:
+wqe.log()
+
+def comp(self, wqe_id, wqe_ts):
+"""Return 0 if not all of WQEs in burst completed"""
+wlen = len(self.wqes)
+if wlen == 0:
+return 0
+for wqe in self.wqes:
+if wqe.comp(wqe_id, wqe_ts) == 0:
+return 0
+return 1
+
+
+class MlxTrace:
+"""Trace representing object"""
+
+def __init__(self):
+self.tx_blst = {}  # current Tx bursts per CPU
+self.tx_qlst = {}  # active Tx queues per port/queue
+self.tx_wlst = {}  # wait timestamp list per CPU
+
+def run(self, msg_it):
+"""Run over gathered tracing data and build database"""
+for msg in msg_it:
+if not isinstance(msg, bt2._EventMessageConst):
+

[PATCH v4 4/4] doc: add mlx5 datapath tracing feature description

[Viacheslav Ovsiienko]

The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track the internal delay issues).

The patch adds the documentation for feature usage.

Signed-off-by: Viacheslav Ovsiienko 
---
 doc/guides/nics/mlx5.rst | 78 
 1 file changed, 78 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index b9843edbd9..1c8fc6f6d4 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -2077,3 +2077,81 @@ where:
 * ``sw_queue_id``: queue index in range [64536, 65535].
   This range is the highest 1000 numbers.
 * ``hw_queue_id``: queue index given by HW in queue creation.
+
+
+Tx datapath tracing
+^^^
+
+The mlx5 provides the Tx datapath tracing capability with extra debug
+information - when and how packets were scheduled and when the actual
+sending was completed by the NIC hardware. The feature engages the
+existing DPDK datapath tracing capability.
+
+Usage of the mlx5 Tx datapath tracing:
+
+#. Build DPDK application with enabled datapath tracking
+
+   * The meson option should be specified: ``--enable_trace_fp=true``
+   * The c_args should be specified:  ``-DALLOW_EXPERIMENTAL_API``
+
+   .. code-block:: console
+
+  meson configure --buildtype=debug -Denable_trace_fp=true
+ -Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT 
-DALLOW_EXPERIMENTAL_API' build
+
+  meson configure --buildtype=release -Denable_trace_fp=true
+ -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build
+
+#. Configure the NIC
+
+   If the sending completion timings are important the NIC should be configured
+   to provide realtime timestamps, the ``REAL_TIME_CLOCK_ENABLE`` NV settings
+   parameter should be configured as TRUE.
+
+   .. code-block:: console
+
+  mlxconfig -d /dev/mst/mt4125_pciconf0 s REAL_TIME_CLOCK_ENABLE=1
+
+#. Run application with EAL parameters configuring the tracing in mlx5 Tx 
datapath
+
+* ``--trace=pmd.net.mlx5.tx`` - the regular expression enabling the 
tracepoints
+  with matching names at least "pmd.net.mlx5.tx" must be enabled to gather 
all
+  events needed to analyze mlx5 Tx datapath and its timings. By default all
+  tracepoints are disabled.
+
+#. Store the file with gathered tracing information
+
+#. Install or build the ``babeltrace2`` package
+
+   The gathered trace data can be analyzed with a developed Python script.
+   To parse the trace, the data script uses the ``babeltrace2`` library.
+   The package should be either installed or built from source code as
+   shown below.
+
+   .. code-block:: console
+
+  git clone https://github.com/efficios/babeltrace.git
+  cd babeltrace
+  ./bootstrap
+  ./configure -help
+  ./configure --disable-api-doc --disable-man-pages
+  --disable-python-bindings-doc --enable-python-plugins
+  --enable-python-binding
+
+#. Run analyzing scrypt (in Python) to combine related events (packet firing 
and
+   completion) and see the output in human-readable view
+
+   The analyzing script is located in the folder: ``./drivers/net/mlx5/tools``
+   It requires Python3.6, ``babeltrace2`` packages and it takes the only 
parameter
+   of trace data file.
+
+   .. code-block:: console
+
+  ./mlx5_trace.py /var/log/rte-2023-01-23-AM-11-52-39
+
+#. Interpreting the Script Output Data
+
+   All the timings are given in nanoseconds.
+   The list of Tx bursts per port/queue is presented in the output.
+   Each list element contains the list of built WQEs with specific opcodes, and
+   each WQE contains the list of the encompassed packets to send.
-- 
2.18.1

RE: [PATCH] doc: update iavf feature list

[Zhang, Qi Z]

> -Original Message-
> From: Zeng, ZhichaoX 
> Sent: Wednesday, July 5, 2023 2:03 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Zeng, ZhichaoX
> ; Wu, Jingjing ; Xing, Beilei
> 
> Subject: [PATCH] doc: update iavf feature list
> 
> The iavf supports timestamp offload on vector path.
> 
> Signed-off-by: Zhichao Zeng 
> ---
>  doc/guides/nics/features/iavf.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/features/iavf.ini 
> b/doc/guides/nics/features/iavf.ini
> index 55a02165a0..b72cd98484 100644
> --- a/doc/guides/nics/features/iavf.ini
> +++ b/doc/guides/nics/features/iavf.ini
> @@ -27,7 +27,7 @@ CRC offload  = Y
>  VLAN offload = P
>  L3 checksum offload  = Y
>  L4 checksum offload  = Y
> -Timestamp offload= P
> +Timestamp offload= Y
>  Inner L3 checksum= Y
>  Inner L4 checksum= Y
>  Packet type parsing  = Y
> --
> 2.34.1

Acked-by: Qi Zhang 

Applied to dpdk-next-net-intel.

Thanks
Qi

[PATCH v2] doc: announce single-event enqueue/dequeue ABI change

[Mattias Rönnblom]

Announce the removal of the single-event enqueue and dequeue
operations from the eventdev ABI.

Signed-off-by: Mattias Rönnblom 

---
PATCH v2: Fix commit subject prefix.
---
 doc/guides/rel_notes/deprecation.rst | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 66431789b0..ca192d838d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -153,3 +153,11 @@ Deprecation Notices
   The new port library API (functions rte_swx_port_*)
   will gradually transition from experimental to stable status
   starting with DPDK 23.07 release.
+
+* eventdev: The single-event (non-burst) enqueue and dequeue
+  operations, used by static inline burst enqueue and dequeue
+  functions in , will be removed in DPDK 23.11. This
+  simplification includes changing the layout and potentially also the
+  size of the public rte_event_fp_ops struct, breaking the ABI. Since
+  these functions are not called directly by the application, the API
+  remains unaffected.
-- 
2.34.1

Re: [PATCH v2] cryptodev: fix device socket ID type

[Konstantin Ananyev]

05/07/2023 11:36, Ciara Power пишет:

The socket ID field for a cryptodev device data was unsigned int.
Due to recent changes to the default device socket ID,
this caused an issue when the socket ID was unknown and set to -1.
The device socket ID wrapped around to 255,
and caused errors when allocating memory.

Changing this field type to int fixes the issue, as it now takes the
correct -1 value.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org

Signed-off-by: Ciara Power 
Acked-by: Morten Brørup 
Acked-by: Kai Ji 

---
v2: Added cc for stable mailing list
---
  lib/cryptodev/cryptodev_pmd.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 8710ed7558..4c98cedca6 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -65,7 +65,7 @@ struct rte_cryptodev_data {
/** Device ID for this instance */
uint8_t dev_id;
/** Socket ID where memory is allocated */
-   uint8_t socket_id;
+   int socket_id;
/** Unique identifier name */
char name[RTE_CRYPTODEV_NAME_MAX_LEN];
  


Acked-by: Konstantin Ananyev 

Re: [PATCH] doc: announce deprecation for security ops

[Konstantin Ananyev]

04/07/2023 20:44, Akhil Goyal пишет:

Structure rte_security_ops and rte_security_ctx are meant to
be used by rte_security library and the PMDs associated.
These will be moved to an internal header in DPDK 23.11 release.

Signed-off-by: Akhil Goyal 
---
  doc/guides/rel_notes/deprecation.rst | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 8e1cdd677a..74bdb4f577 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -133,6 +133,9 @@ Deprecation Notices
``rte_cryptodev_get_auth_algo_string``, 
``rte_cryptodev_get_aead_algo_string`` and
``rte_cryptodev_asym_get_xform_string`` respectively.
  
+* security: Hide structures ``rte_security_ops`` and ``rte_security_ctx`` as these

+  are internal to DPDK library and PMDs.
+
  * flow_classify: The flow_classify library and example have no maintainer.
The library is experimental and, as such, it could be removed from DPDK.
Its removal has been postponed to let potential users report interest


Acked-by: Konstantin Ananyev 

Re: [PATCH v4 1/4] doc: announce new cpu flag added to rte_cpu_flag_t

[Konstantin Ananyev]

18/04/2023 09:25, Sivaprasad Tummala пишет:

A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in
DPDK 23.07 release to support monitorx instruction on EPYC processors.
This results in ABI breakage for legacy apps.

Signed-off-by: Sivaprasad Tummala 
---
  doc/guides/rel_notes/deprecation.rst | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index dcc1ca1696..831713983f 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -163,3 +163,6 @@ Deprecation Notices
The new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status
starting with DPDK 23.07 release.
+
+* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag
+  ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors.


Acked-by: Konstantin Ananyev 

Re: [PATCH] doc: announce ethdev operation struct changes

[Konstantin Ananyev]

04/07/2023 09:10, Feifei Wang пишет:

To support mbufs recycle mode, announce the coming ABI changes
from DPDK 23.11.

Signed-off-by: Feifei Wang 
Reviewed-by: Ruifeng Wang 
---
  doc/guides/rel_notes/deprecation.rst | 4 
  1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 66431789b0..c7e1ffafb2 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -118,6 +118,10 @@ Deprecation Notices
The legacy actions should be removed
once ``MODIFY_FIELD`` alternative is implemented in drivers.
  
+* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` and

+  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be updated
+  with new fields to support mbufs recycle mode from DPDK 23.11.
+
  * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
to have another parameter ``qp_id`` to return the queue pair ID
which got error interrupt to the application,


Acked-by: Konstantin Ananyev 

Re: [PATCH v2] pcap: support MTU set

[Ferruh Yigit]

On 7/4/2023 10:02 PM, Stephen Hemminger wrote:
> Support rte_eth_dev_set_mtu for pcap driver when the
> pcap device is convigured to point to a network interface.
> 
> This is rebased an consolidated from earlier version.
> Added support for FreeBSD.
> 

As far as I understand motivation is to make pcap PMD behave close the
physical NIC and able to test the application MTU feature.
If so, Ido's v4 was simpler, which doesn't distinguish if pcap backed by
physical interface or .pcap file.
What was wrong with that approach?

> Signed-off-by: Ido Goshen 
> Signed-off-by: Stephen Hemminger 
> ---
> v2 - fix FreeBSD part
> 
>  drivers/net/pcap/pcap_ethdev.c| 49 ++-
>  drivers/net/pcap/pcap_osdep.h |  1 +
>  drivers/net/pcap/pcap_osdep_freebsd.c | 23 +
>  drivers/net/pcap/pcap_osdep_linux.c   | 21 
>  drivers/net/pcap/pcap_osdep_windows.c |  7 
>  5 files changed, 100 insertions(+), 1 deletion(-)
> 

Better to update driver documentation and release notes too.

> diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
> index bfec0850456f..672f42d30d8e 100644
> --- a/drivers/net/pcap/pcap_ethdev.c
> +++ b/drivers/net/pcap/pcap_ethdev.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #include 
> +#include 
>  #include 
>  
>  #include 
> @@ -495,8 +496,13 @@ eth_pcap_tx(void *queue, struct rte_mbuf **bufs, 
> uint16_t nb_pkts)
>*/
>   ret = pcap_sendpacket(pcap,
>   rte_pktmbuf_read(mbuf, 0, len, temp_data), len);
> - if (unlikely(ret != 0))
> + if (unlikely(ret != 0)) {
> + /* Oversize packet dropped due to MTU */
> + if (errno == EMSGSIZE)
> + continue;

This will leak mbuf, since loop continues application will assume driver
sent the packet and freed mbuf. Ido's version does it right.

>   break;
> + }
> +
>   num_tx++;
>   tx_bytes += len;
>   rte_pktmbuf_free(mbuf);
> @@ -808,6 +814,46 @@ eth_stats_reset(struct rte_eth_dev *dev)
>   return 0;
>  }
>  
> +static int
> +eth_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> + struct pmd_internals *internals = dev->data->dev_private;
> + unsigned int i;
> + bool is_supported = false;
> + int ret;
> +
> + for (i = 0; i < dev->data->nb_rx_queues; i++) {
> + struct pcap_rx_queue *queue = &internals->rx_queue[i];
> +
> + if ((strcmp(queue->type, ETH_PCAP_IFACE_ARG) == 0) ||
> + (strcmp(queue->type, ETH_PCAP_RX_IFACE_ARG) == 0) ||
> + (strcmp(queue->type, ETH_PCAP_RX_IFACE_IN_ARG) == 0)) {
> + ret = osdep_iface_mtu_set(queue->name, mtu);
> + if (ret < 0)
> + return ret;
> + is_supported = true;
> + }

If there are multiple devices (each pcap queue represents a device), and
one in the middle one fails to set MTU, there will be mixed MTU values
in devices.

> + }
> +
> + for (i = 0; i < dev->data->nb_tx_queues; i++) {
> + struct pcap_tx_queue *queue = &internals->tx_queue[i];
> +
> + if ((strcmp(queue->type, ETH_PCAP_IFACE_ARG) == 0) ||

Rx devices and Tx devices can be same device, causing duplicated MTU set
for same device, but it is hard to detect if they are same devices.
At least it is easier to detect when queue type is 'ETH_PCAP_IFACE_ARG',
what about set MTU once for this queue type?

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

[Ferruh Yigit]

On 7/5/2023 10:40 AM, lihuisong (C) wrote:
> 
> 在 2023/7/5 16:02, Ferruh Yigit 写道:
>> On 7/5/2023 4:16 AM, lihuisong (C) wrote:
>>> 在 2023/7/4 18:59, Ferruh Yigit 写道:
 On 7/4/2023 9:45 AM, Jie Hai wrote:
> Function update_queue_state updates queue state of all queues
> of all ports, using the queue num nb_rxq|nb_txq stored locally
> by testpmd. An error on the invalid queue ID occurs if we run
> testpmd with two ports and detach-attach one of them and start
> the other port first. This is because the attached port has not
> been configured and has no queues, which differs from nb_rxq|nb_txq.
> The similar error happens in multi-process senoris if secondary
> process attaches a port and starts it.
>
> This patch updates queue state of the specified port, which has
> been configured by primary process. As the secondary process
> cannot configure the ports, make sure that the secondary process
> starts the port only after the primary process has done so.
>>> Now look good to me.
>>> Acked-by: Huisong Li 
> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling
> all queues")
> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
> forwarding")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Hai 
>
 The problem description and solution looks reasonable to me, but Intel
 testing still reporting the issue.

 There is a chance that the issue Intel side observing is different,
 waiting for more information from Intel test team.

 .
>> Hi Song,
>>
>> As far as I understand this patch works with an update from ixgbevf
>> driver, can you please confirm?
>> And can we have the ixgbevf fix soon, to not block the -rc3?
>>
> Hi Ferruh,
> 
> Yes, ixgbe is not setting queue status correctly.
> Whether tesptmd polls the queue depends on the queue status
> (dev->data->rx_queue_state[queue_id]).
> But some drivers (not just ixgbe) do not set the status correctly.
> Jie is doing this. will be sent ASAP.
> 

Hi Huisong, Jie

As you said some drivers don't do it right, and my concern is:
a) if we have a side effect from last minute changes from drivers,
b) if there are more drivers impacted but not recognized yet

That is why my proposal is to revert Jie's fix for this release, record
known issue, and merge it back early next release to give more time to
drivers adjust. What do you think?

RE: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst

[De Lara Guarch, Pablo]

> -Original Message-
> From: Power, Ciara 
> Sent: Wednesday, July 5, 2023 11:26 AM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; De Lara Guarch, Pablo
> ; Power, Ciara ;
> Cornu, Marcel D ; Ji, Kai 
> Subject: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst
> 
> The jobs variable was global, which meant it was not thread safe.
> This caused a segmentation fault when running the crypto performance app,
> using more than one lcore for crypto processing.
> 
> Moving this to the dequeue function where it is used fixes the issue.
> 
> Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
> Cc: marcel.d.co...@intel.com
> 
> Signed-off-by: Ciara Power 
> Acked-by: Kai Ji 

Acked-by: Pablo de Lara 

Re: [PATCH] doc: add information to update dma entry limit

[Thomas Monjalon]

05/07/2023 12:53, Nipun Gupta:
> VFIO module provides configurable dma_entry_limit
> parameter to store the DMA entries. By default this
> is 64K and if we are using --no-huge, we shall need
> to increase the value of dma_entry_limit. Add
> commands in linux_gsg document to change the
> dma_entry_limit.
> 
> Signed-off-by: Nipun Gupta 
> ---
>  doc/guides/linux_gsg/linux_drivers.rst | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/linux_gsg/linux_drivers.rst 
> b/doc/guides/linux_gsg/linux_drivers.rst
> index 2cec1ebede..b729bb38a8 100644
> --- a/doc/guides/linux_gsg/linux_drivers.rst
> +++ b/doc/guides/linux_gsg/linux_drivers.rst
> @@ -180,6 +180,21 @@ VFIO module parameter ``dma_entry_limit`` with a default 
> value of 64K.
>  When application is out of DMA entries, these limits need to be adjusted to
>  increase the allowed limit.
>  
> +When ``no-huge`` parameter is used, the page size used is of smaller size of

I would add "--" to have the full option "--no-huge".
By the way, this is an "option" in the shell language :-)

> +``4K`` or ``64K`` and we shall need to increase ``dma_entry_limit``.
> +To update the ``dma_entry_limit``, ``vfio_iommu_type1`` has to be loaded with
> +additional module parameter:
> +
> +.. code-block:: console
> +
> +   modprobe vfio_iommu_type1 dma_entry_limit=512000
> +
> +Alternatively, one can also change this value in an already loaded kernel 
> module:
> +
> +.. code-block:: console
> +
> +   echo 512000 > /sys/module/vfio_iommu_type1/parameters/dma_entry_limit

That looks good, thank you.

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

[Jerin Jacob]

On Wed, Jul 5, 2023 at 4:48 PM Mattias Rönnblom
 wrote:
>
> Announce the removal of the single-event enqueue and dequeue
> operations from the eventdev ABI.
>
> Signed-off-by: Mattias Rönnblom 

Acked-by: Jerin Jacob 


>
> ---
> PATCH v2: Fix commit subject prefix.
> ---
>  doc/guides/rel_notes/deprecation.rst | 8 
>  1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 66431789b0..ca192d838d 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -153,3 +153,11 @@ Deprecation Notices
>The new port library API (functions rte_swx_port_*)
>will gradually transition from experimental to stable status
>starting with DPDK 23.07 release.
> +
> +* eventdev: The single-event (non-burst) enqueue and dequeue
> +  operations, used by static inline burst enqueue and dequeue
> +  functions in , will be removed in DPDK 23.11. This
> +  simplification includes changing the layout and potentially also the
> +  size of the public rte_event_fp_ops struct, breaking the ABI. Since
> +  these functions are not called directly by the application, the API
> +  remains unaffected.
> --
> 2.34.1
>

RE: [EXT] Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

[Pavan Nikhilesh Bhagavatula]

> On Wed, Jul 5, 2023 at 4:48 PM Mattias Rönnblom
>  wrote:
> >
> > Announce the removal of the single-event enqueue and dequeue
> > operations from the eventdev ABI.
> >
> > Signed-off-by: Mattias Rönnblom 
> 
> Acked-by: Jerin Jacob 

Acked-by: Pavan Nikhilesh 
> 
> 
> >
> > ---
> > PATCH v2: Fix commit subject prefix.
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 8 
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > index 66431789b0..ca192d838d 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -153,3 +153,11 @@ Deprecation Notices
> >The new port library API (functions rte_swx_port_*)
> >will gradually transition from experimental to stable status
> >starting with DPDK 23.07 release.
> > +
> > +* eventdev: The single-event (non-burst) enqueue and dequeue
> > +  operations, used by static inline burst enqueue and dequeue
> > +  functions in , will be removed in DPDK 23.11. This
> > +  simplification includes changing the layout and potentially also the
> > +  size of the public rte_event_fp_ops struct, breaking the ABI. Since
> > +  these functions are not called directly by the application, the API
> > +  remains unaffected.
> > --
> > 2.34.1
> >

Re: [PATCH] app/crypto-perf: fix socket ID default value

[Ji, Kai]

Acked-by: Kai Ji mailto:kai...@intel.com>>

From: Ciara Power 
Sent: 05 July 2023 11:30
To: dev@dpdk.org 
Cc: gak...@marvell.com ; Power, Ciara 
; Matz, Olivier ; 
sta...@dpdk.org 
Subject: [PATCH] app/crypto-perf: fix socket ID default value

Due to recent changes to the default device socket ID,
before being used as an index for session mempool list,
the socket ID should be set to 0 if unknown (-1).

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org

Signed-off-by: Ciara Power 
---
 app/test-crypto-perf/main.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index af5bd0d23b..b74e7ba118 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -651,6 +651,11 @@ main(int argc, char **argv)
 cdev_id = enabled_cdevs[cdev_index];

 uint8_t socket_id = rte_cryptodev_socket_id(cdev_id);
+   /* range check the socket_id, negative values become big
+* positive ones due to use of unsigned value
+*/
+   if (socket_id >= RTE_MAX_NUMA_NODES)
+   socket_id = 0;

 ctx[i] = cperf_testmap[opts.test].constructor(
 session_pool_socket[socket_id].sess_mp,
--
2.25.1

[PATCH 0/2] VDUSE fixes for v23.07

[Maxime Coquelin]

This small series brings a couple of VDUSE fixes
for v23.07, discovered during testing with OVS-DPDK.

Maxime Coquelin (2):
  vhost: fix vduse features negotiation
  vduse: fix missing event index features

 lib/vhost/socket.c | 19 +--
 lib/vhost/vduse.c  | 28 +++-
 lib/vhost/vduse.h  | 21 +
 3 files changed, 41 insertions(+), 27 deletions(-)

-- 
2.41.0

[PATCH 1/2] vhost: fix vduse features negotiation

[Maxime Coquelin]

The series introducing VDUSE support missed the
application capability to disable supported features.

This results in TSO being negotiated while not supported by
the application.

Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction")

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/socket.c | 19 +--
 lib/vhost/vduse.c  | 28 +++-
 lib/vhost/vduse.h  | 20 
 3 files changed, 40 insertions(+), 27 deletions(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index 19a7469e45..a65d301406 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -921,6 +921,10 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
VHOST_LOG_CONFIG(path, ERR, "failed to init connection 
mutex\n");
goto out_free;
}
+
+   if (!strncmp("/dev/vduse/", path, strlen("/dev/vduse/")))
+   vsocket->is_vduse = true;
+
vsocket->vdpa_dev = NULL;
vsocket->max_queue_pairs = VHOST_MAX_QUEUE_PAIRS;
vsocket->extbuf = flags & RTE_VHOST_USER_EXTBUF_SUPPORT;
@@ -950,9 +954,14 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 * two values.
 */
vsocket->use_builtin_virtio_net = true;
-   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
-   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
-   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
+   if (vsocket->is_vduse) {
+   vsocket->supported_features = VDUSE_NET_SUPPORTED_FEATURES;
+   vsocket->features   = VDUSE_NET_SUPPORTED_FEATURES;
+   } else {
+   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
+   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
+   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
+   }
 
if (vsocket->async_copy) {
vsocket->supported_features &= ~(1ULL << VHOST_F_LOG_ALL);
@@ -993,9 +1002,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 #endif
}
 
-   if (!strncmp("/dev/vduse/", path, strlen("/dev/vduse/"))) {
-   vsocket->is_vduse = true;
-   } else {
+   if (!vsocket->is_vduse) {
if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
vsocket->reconnect = !(flags & 
RTE_VHOST_USER_NO_RECONNECT);
if (vsocket->reconnect && reconn_tid == 0) {
diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
index a509daf80c..1478562be1 100644
--- a/lib/vhost/vduse.c
+++ b/lib/vhost/vduse.c
@@ -26,26 +26,6 @@
 #define VHOST_VDUSE_API_VERSION 0
 #define VDUSE_CTRL_PATH "/dev/vduse/control"
 
-#define VDUSE_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
-   (1ULL << VIRTIO_F_ANY_LAYOUT) | \
-   (1ULL << VIRTIO_F_VERSION_1)   | \
-   (1ULL << VIRTIO_NET_F_GSO) | \
-   (1ULL << VIRTIO_NET_F_HOST_TSO4) | \
-   (1ULL << VIRTIO_NET_F_HOST_TSO6) | \
-   (1ULL << VIRTIO_NET_F_HOST_UFO) | \
-   (1ULL << VIRTIO_NET_F_HOST_ECN) | \
-   (1ULL << VIRTIO_NET_F_CSUM)| \
-   (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \
-   (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \
-   (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \
-   (1ULL << VIRTIO_NET_F_GUEST_UFO) | \
-   (1ULL << VIRTIO_NET_F_GUEST_ECN) | \
-   (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
-   (1ULL << VIRTIO_F_IN_ORDER) | \
-   (1ULL << VIRTIO_F_IOMMU_PLATFORM) | \
-   (1ULL << VIRTIO_NET_F_CTRL_VQ) | \
-   (1ULL << VIRTIO_NET_F_MQ))
-
 struct vduse {
struct fdset fdset;
 };
@@ -440,7 +420,7 @@ vduse_device_create(const char *path)
struct virtio_net *dev;
struct virtio_net_config vnet_config = { 0 };
uint64_t ver = VHOST_VDUSE_API_VERSION;
-   uint64_t features = VDUSE_NET_SUPPORTED_FEATURES;
+   uint64_t features;
struct vduse_dev_config *dev_config = NULL;
const char *name = path + strlen("/dev/vduse/");
 
@@ -488,6 +468,12 @@ vduse_device_create(const char *path)
goto out_ctrl_close;
}
 
+   ret = rte_vhost_driver_get_features(path, &features);
+   if (ret < 0) {
+   VHOST_LOG_CONFIG(name, ERR, "Failed to get backend features\n");
+   goto out_free;
+   }
+
ret = rte_vhost_driver_get_queue_num(path, &max_queue_pairs);
if (ret < 0) {
VHOST_LOG_CONFIG(name, ERR, "Failed to get max queue pairs\n");
diff --git a/lib/vhost/vduse.h b/lib

[PATCH 2/2] vduse: fix missing event index features

[Maxime Coquelin]

This features was mistakenly removed, add it back.

Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction")

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vduse.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vhost/vduse.h b/lib/vhost/vduse.h
index cd55bfd858..46753fec73 100644
--- a/lib/vhost/vduse.h
+++ b/lib/vhost/vduse.h
@@ -22,6 +22,7 @@
(1ULL << VIRTIO_NET_F_GUEST_UFO) | \
(1ULL << VIRTIO_NET_F_GUEST_ECN) | \
(1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
+   (1ULL << VIRTIO_RING_F_EVENT_IDX) | \
(1ULL << VIRTIO_F_IN_ORDER) | \
(1ULL << VIRTIO_F_IOMMU_PLATFORM) | \
(1ULL << VIRTIO_NET_F_CTRL_VQ) | \
-- 
2.41.0

[PATCH] crypto/qat: fix legacy sm4 ecb capability

[Ciara Power]

Following the deprecation of insecure algorithms in QAT,
SM4-ECB should be included as legacy, to be disabled by default.

Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")

Signed-off-by: Ciara Power 
---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c 
b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
index bc71665a50..d25e1b2f3a 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
@@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities 
qat_sym_crypto_legacy_caps_gen3[] = {
QAT_SYM_PLAIN_AUTH_CAP(SHA3_224,
CAP_SET(block_size, 144),
CAP_RNG(digest_size, 28, 28, 0)),
+   QAT_SYM_CIPHER_CAP(SM4_ECB,
+   CAP_SET(block_size, 16),
+   CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))
 };
 
 static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
@@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities 
qat_sym_crypto_caps_gen3[] = {
CAP_RNG(key_size, 32, 32, 0),
CAP_RNG(digest_size, 16, 16, 0),
CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)),
-   QAT_SYM_CIPHER_CAP(SM4_ECB,
-   CAP_SET(block_size, 16),
-   CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),
QAT_SYM_CIPHER_CAP(SM4_CBC,
CAP_SET(block_size, 16),
CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),
-- 
2.25.1

RE: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID

[Akhil Goyal]

> > Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID
> >
> > In the case of multiprocess, when the same session is being used for both
> > primary and secondary processes, the session ID will be the same.
> > However the pointers are not available to the secondary process, so in this
> > case when the session was created by a different process ID, then copy the
> > template session to the job again.
> >
> > Fixes: 0fb4834e00af ("crypto/ipsec_mb: set and use session ID")
> > Cc: pablo.de.lara.gua...@intel.com
> >
> > Signed-off-by: Ciara Power 
> 
> Acked-by: Pablo de Lara 

Applied to dpdk-next-crypto
Thanks.

Re: [PATCH 1/2] vhost: fix vduse features negotiation

[David Marchand]

On Wed, Jul 5, 2023 at 3:22 PM Maxime Coquelin
 wrote:
> @@ -950,9 +954,14 @@ rte_vhost_driver_register(const char *path, uint64_t 
> flags)
>  * two values.
>  */
> vsocket->use_builtin_virtio_net = true;
> -   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
> -   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
> -   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
> +   if (vsocket->is_vduse) {
> +   vsocket->supported_features = VDUSE_NET_SUPPORTED_FEATURES;
> +   vsocket->features   = VDUSE_NET_SUPPORTED_FEATURES;
> +   } else {
> +   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
> +   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
> +   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
> +   }
>

Would it make sense to split those features in a set of features
shared by vhost-user and vduse, and one dedicated set for each of
them?
For example, the VIRTIO_NET_F_GUEST/HOST_* features are not bound to
vhost-user / vduse, are they?


-- 
David Marchand

[PATCH v2] doc: add information to update dma entry limit

[Nipun Gupta]

VFIO module provides configurable dma_entry_limit
parameter to store the DMA entries. By default this
is 64K and if we are using --no-huge, we shall need
to increase the value of dma_entry_limit. Add
commands in linux_gsg document to change the
dma_entry_limit.

Signed-off-by: Nipun Gupta 
---

Changes v1->v2:
- updated param 'no-huge' to '--no-huge' in documentation

 doc/guides/linux_gsg/linux_drivers.rst | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/doc/guides/linux_gsg/linux_drivers.rst 
b/doc/guides/linux_gsg/linux_drivers.rst
index 2cec1ebede..b729bb38a8 100644
--- a/doc/guides/linux_gsg/linux_drivers.rst
+++ b/doc/guides/linux_gsg/linux_drivers.rst
@@ -180,6 +180,21 @@ VFIO module parameter ``dma_entry_limit`` with a default 
value of 64K.
 When application is out of DMA entries, these limits need to be adjusted to
 increase the allowed limit.
 
+When ``--no-huge`` parameter is used, the page size used is of smaller size of
+``4K`` or ``64K`` and we shall need to increase ``dma_entry_limit``.
+To update the ``dma_entry_limit``, ``vfio_iommu_type1`` has to be loaded with
+additional module parameter:
+
+.. code-block:: console
+
+   modprobe vfio_iommu_type1 dma_entry_limit=512000
+
+Alternatively, one can also change this value in an already loaded kernel 
module:
+
+.. code-block:: console
+
+   echo 512000 > /sys/module/vfio_iommu_type1/parameters/dma_entry_limit
+
 Creating Virtual Functions using vfio-pci
 ~~
 
-- 
2.17.1

RE: [EXT] [PATCH] ipsec: fix NAT-T length calculation

[Akhil Goyal]

Hi Konstantin,
Can you review this patch?

> UDP header length is included in sa->hdr_len. Take care of that in
> L3 header and pakcet length calculation.
> 
> Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
> 
> Signed-off-by: Xiao Liang 
> ---
>  lib/ipsec/esp_outb.c | 2 +-
>  lib/ipsec/sa.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ipsec/esp_outb.c b/lib/ipsec/esp_outb.c
> index 9cbd9202f6..ec87b1dce2 100644
> --- a/lib/ipsec/esp_outb.c
> +++ b/lib/ipsec/esp_outb.c
> @@ -198,7 +198,7 @@ outb_tun_pkt_prepare(struct rte_ipsec_sa *sa,
> rte_be64_t sqc,
>   struct rte_udp_hdr *udph = (struct rte_udp_hdr *)
>   (ph + sa->hdr_len - sizeof(struct rte_udp_hdr));
>   udph->dgram_len = rte_cpu_to_be_16(mb->pkt_len - sqh_len -
> - sa->hdr_l3_off - sa->hdr_len);
> + sa->hdr_len + sizeof(struct rte_udp_hdr));
>   }
> 
>   /* update original and new ip header fields */
> diff --git a/lib/ipsec/sa.c b/lib/ipsec/sa.c
> index 59a547637d..2297bd6d72 100644
> --- a/lib/ipsec/sa.c
> +++ b/lib/ipsec/sa.c
> @@ -371,7 +371,7 @@ esp_outb_tun_init(struct rte_ipsec_sa *sa, const struct
> rte_ipsec_sa_prm *prm)
> 
>   /* update l2_len and l3_len fields for outbound mbuf */
>   sa->tx_offload.val = rte_mbuf_tx_offload(sa->hdr_l3_off,
> - sa->hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);
> + prm->tun.hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);
> 
>   esp_outb_init(sa, sa->hdr_len, prm->ipsec_xform.esn.value);
>  }
> --
> 2.40.0

RE: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst

[Akhil Goyal]

> > Subject: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst
> >
> > The jobs variable was global, which meant it was not thread safe.
> > This caused a segmentation fault when running the crypto performance app,
> > using more than one lcore for crypto processing.
> >
> > Moving this to the dequeue function where it is used fixes the issue.
> >
> > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI")
> > Cc: marcel.d.co...@intel.com
> >
> > Signed-off-by: Ciara Power 
> > Acked-by: Kai Ji 
> 
> Acked-by: Pablo de Lara 
Applied to dpdk-next-crypto

Thanks.

Re: [PATCH] crypto/qat: fix legacy sm4 ecb capability

[Ji, Kai]

Acked-by: Kai Ji mailto:kai...@intel.com>>

From: Power, Ciara 
Sent: 05 July 2023 14:23
To: dev@dpdk.org 
Cc: Ji, Kai ; O'Donovan, Saoirse 
; Power, Ciara 
Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability

Following the deprecation of insecure algorithms in QAT,
SM4-ECB should be included as legacy, to be disabled by default.

Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")

Signed-off-by: Ciara Power 
---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c 
b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
index bc71665a50..d25e1b2f3a 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
@@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities 
qat_sym_crypto_legacy_caps_gen3[] = {
 QAT_SYM_PLAIN_AUTH_CAP(SHA3_224,
 CAP_SET(block_size, 144),
 CAP_RNG(digest_size, 28, 28, 0)),
+   QAT_SYM_CIPHER_CAP(SM4_ECB,
+   CAP_SET(block_size, 16),
+   CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))
 };

 static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
@@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities 
qat_sym_crypto_caps_gen3[] = {
 CAP_RNG(key_size, 32, 32, 0),
 CAP_RNG(digest_size, 16, 16, 0),
 CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)),
-   QAT_SYM_CIPHER_CAP(SM4_ECB,
-   CAP_SET(block_size, 16),
-   CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),
 QAT_SYM_CIPHER_CAP(SM4_CBC,
 CAP_SET(block_size, 16),
 CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),
--
2.25.1

Re: [PATCH] doc: announce deprecation for security ops

[Jerin Jacob]

On Wed, Jul 5, 2023 at 5:01 PM Konstantin Ananyev
 wrote:
>
> 04/07/2023 20:44, Akhil Goyal пишет:
> > Structure rte_security_ops and rte_security_ctx are meant to
> > be used by rte_security library and the PMDs associated.
> > These will be moved to an internal header in DPDK 23.11 release.
> >
> > Signed-off-by: Akhil Goyal 
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst 
> > b/doc/guides/rel_notes/deprecation.rst
> > index 8e1cdd677a..74bdb4f577 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -133,6 +133,9 @@ Deprecation Notices
> > ``rte_cryptodev_get_auth_algo_string``, 
> > ``rte_cryptodev_get_aead_algo_string`` and
> > ``rte_cryptodev_asym_get_xform_string`` respectively.
> >
> > +* security: Hide structures ``rte_security_ops`` and ``rte_security_ctx`` 
> > as these
> > +  are internal to DPDK library and PMDs.
> > +
> >   * flow_classify: The flow_classify library and example have no maintainer.
> > The library is experimental and, as such, it could be removed from DPDK.
> > Its removal has been postponed to let potential users report interest
>
> Acked-by: Konstantin Ananyev 

Acked-by: Jerin Jacob 

Re: [PATCH v2] doc: announce addition of new security IPsec SA option

[Jerin Jacob]

On Tue, Jul 4, 2023 at 10:45 AM Nithin Dabilpuram
 wrote:
>
> Announce addition of new security IPsec SA option to enable
> out of place processing in Ingress Inline inbound SA's.
>
> Signed-off-by: Nithin Dabilpuram 
> Acked-by: Akhil Goyal 

Acked-by: Jerin Jacob 

> ---
>
> v2:
> - Modified deprication notice to include reserved opts removal.
>
>  doc/guides/rel_notes/deprecation.rst | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 8e1cdd677a..c46cc49812 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -156,3 +156,8 @@ Deprecation Notices
>The new port library API (functions rte_swx_port_*)
>will gradually transition from experimental to stable status
>starting with DPDK 23.07 release.
> +
> +* security: New sa option ``ingress_oop`` would be added in structure
> +  ``rte_security_ipsec_sa_options`` to support out of place processing
> +  for inline inbound SA's from DPDK 23.11. ``reserved_opts`` field in the
> +  same struct would be removed as discussed in techboard meeting.
> --
> 2.25.1
>

[PATCH] app/testpmd: revert primary process polling all queues fix

[Ferruh Yigit]

For some drivers [1], testpmd forwarding is broken with commit [2].

This is because with [2] testpmd gets queue state from ethdev and
forwarding is done only on queues in started state, but some drivers
don't update queue status properly, and this breaks forwarding for those
drivers.

Drivers should be fixed but more time is required to verify drivers
again, instead reverting [2] for now to not break drivers.
Target is to merge [2] back at the beginning of next release cycle and
fix drivers accordingly.

[1]
Bugzilla ID: 1259

[2]
Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all queues")
Cc: sta...@dpdk.org

Signed-off-by: Ferruh Yigit 
---
Cc: haij...@huawei.com
Cc: songx.ji...@intel.com
Cc: qiming.y...@intel.com
---
 app/test-pmd/testpmd.c | 20 
 doc/guides/rel_notes/release_23_07.rst |  9 +
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1fc70650e0a4..c6ad9b18bf03 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2424,13 +2424,6 @@ update_rx_queue_state(uint16_t port_id, uint16_t 
queue_id)
ports[port_id].rxq[queue_id].state =
rx_qinfo.queue_state;
} else if (rc == -ENOTSUP) {
-   /*
-* Do not change the rxq state for primary process
-* to ensure that the PMDs do not implement
-* rte_eth_rx_queue_info_get can forward as before.
-*/
-   if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-   return;
/*
 * Set the rxq state to RTE_ETH_QUEUE_STATE_STARTED
 * to ensure that the PMDs do not implement
@@ -2456,13 +2449,6 @@ update_tx_queue_state(uint16_t port_id, uint16_t 
queue_id)
ports[port_id].txq[queue_id].state =
tx_qinfo.queue_state;
} else if (rc == -ENOTSUP) {
-   /*
-* Do not change the txq state for primary process
-* to ensure that the PMDs do not implement
-* rte_eth_tx_queue_info_get can forward as before.
-*/
-   if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-   return;
/*
 * Set the txq state to RTE_ETH_QUEUE_STATE_STARTED
 * to ensure that the PMDs do not implement
@@ -2530,7 +2516,8 @@ start_packet_forwarding(int with_tx_first)
return;
 
if (stream_init != NULL) {
-   update_queue_state();
+   if (rte_eal_process_type() == RTE_PROC_SECONDARY)
+   update_queue_state();
for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++)
stream_init(fwd_streams[i]);
}
@@ -3293,7 +3280,8 @@ start_port(portid_t pid)
pl[cfg_pi++] = pi;
}
 
-   update_queue_state();
+   if (rte_eal_process_type() == RTE_PROC_SECONDARY)
+   update_queue_state();
 
if (at_least_one_port_successfully_started && !no_link_check)
check_all_ports_link_status(RTE_PORT_ALL);
diff --git a/doc/guides/rel_notes/release_23_07.rst 
b/doc/guides/rel_notes/release_23_07.rst
index 7b1c31469fa5..46b3d915c6e4 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -280,6 +280,15 @@ Known Issues
Also, make sure to start the actual text at the margin.
===
 
+* **Testpmd is not forwarding on queues individually stopped.**
+
+  Testpmd forwards packets on started queues.
+  If a queue explicitly stopped, and later port stopped and started again,
+  the status of the previously stopped queue is not updated, so forwarding
+  is not working on those queues.
+
+  As a workaround start queues back explicitly, instead of port stop/start.
+
 
 Tested Platforms
 
-- 
2.34.1

[PATCH] doc: support IPsec Multi-buffer lib v1.4

[Ciara Power]

Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G
and CHACHA20_POLY1305 PMD documentation guides
with information about the latest Intel IPsec Multi-buffer
library supported.

Signed-off-by: Ciara Power 
---
 doc/guides/cryptodevs/aesni_gcm.rst | 6 +++---
 doc/guides/cryptodevs/aesni_mb.rst  | 6 +++---
 doc/guides/cryptodevs/chacha20_poly1305.rst | 6 +++---
 doc/guides/cryptodevs/kasumi.rst| 6 +++---
 doc/guides/cryptodevs/snow3g.rst| 6 +++---
 doc/guides/cryptodevs/zuc.rst   | 6 +++---
 doc/guides/rel_notes/release_23_07.rst  | 4 
 7 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/doc/guides/cryptodevs/aesni_gcm.rst 
b/doc/guides/cryptodevs/aesni_gcm.rst
index 5192287ed8..e0d9188a5d 100644
--- a/doc/guides/cryptodevs/aesni_gcm.rst
+++ b/doc/guides/cryptodevs/aesni_gcm.rst
@@ -40,8 +40,8 @@ Installation
 To build DPDK with the AESNI_GCM_PMD the user is required to download the 
multi-buffer
 library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.3, which
-can be downloaded in 
``_.
+The latest version of the library supported by this PMD is v1.4, which
+can be downloaded in 
``_.
 
 .. code-block:: console
 
@@ -85,7 +85,7 @@ and the external crypto libraries supported by them:
18.05 - 19.02  Multi-buffer library 0.49 - 0.52
19.05 - 20.08  Multi-buffer library 0.52 - 0.55
20.11 - 21.08  Multi-buffer library 0.53 - 1.3*
-   21.11+ Multi-buffer library 1.0  - 1.3*
+   21.11+ Multi-buffer library 1.0  - 1.4*
=  
 
 \* Multi-buffer library 1.0 or newer only works for Meson but not Make build 
system.
diff --git a/doc/guides/cryptodevs/aesni_mb.rst 
b/doc/guides/cryptodevs/aesni_mb.rst
index eaa853e6b2..879eb42d44 100644
--- a/doc/guides/cryptodevs/aesni_mb.rst
+++ b/doc/guides/cryptodevs/aesni_mb.rst
@@ -99,8 +99,8 @@ Installation
 To build DPDK with the AESNI_MB_PMD the user is required to download the 
multi-buffer
 library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.3, which
-can be downloaded from 
``_.
+The latest version of the library supported by this PMD is v1.4, which
+can be downloaded from 
``_.
 
 .. code-block:: console
 
@@ -146,7 +146,7 @@ and the Multi-Buffer library version supported by them:
19.05 - 19.08   0.52
19.11 - 20.08   0.52 - 0.55
20.11 - 21.08   0.53 - 1.3*
-   21.11+  1.0  - 1.3*
+   21.11+  1.0  - 1.4*
==  
 
 \* Multi-buffer library 1.0 or newer only works for Meson but not Make build 
system.
diff --git a/doc/guides/cryptodevs/chacha20_poly1305.rst 
b/doc/guides/cryptodevs/chacha20_poly1305.rst
index 883d924e31..ee7b6e54e5 100644
--- a/doc/guides/cryptodevs/chacha20_poly1305.rst
+++ b/doc/guides/cryptodevs/chacha20_poly1305.rst
@@ -31,8 +31,8 @@ Installation
 To build DPDK with the Chacha20-poly1305 PMD the user is required to download
 the multi-buffer library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.3, which
-can be downloaded from 
``_.
+The latest version of the library supported by this PMD is v1.4, which
+can be downloaded from 
``_.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
@@ -72,7 +72,7 @@ and the external crypto libraries supported by them:
=  
DPDK version   Crypto library version
=  
-   21.11+ Multi-buffer library 1.0-1.3*
+   21.11+ Multi-buffer library 1.0-1.4*
=  
 
 \* Multi-buffer library 1.0 or newer only works for Meson but not Make build 
system.
diff --git a/doc/guides/cryptodevs/kasumi.rst b/doc/guides/cryptodevs/kasumi.rst
index 90f5379130..b9c512703a 100644
--- a/doc/guides/cryptodevs/kasumi.rst
+++ b/doc/guides/cryptodevs/kasumi.rst
@@ -44,8 +44,8 @@ Installation
 To build DPDK with the KASUMI_PMD the user is required to download the 
multi-buffer
 library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.3, which
-can be downloaded from 
`

Re: [PATCH v2] pcap: support MTU set

[Stephen Hemminger]

On Wed, 5 Jul 2023 12:37:41 +0100
Ferruh Yigit  wrote:

> On 7/4/2023 10:02 PM, Stephen Hemminger wrote:
> > Support rte_eth_dev_set_mtu for pcap driver when the
> > pcap device is convigured to point to a network interface.
> > 
> > This is rebased an consolidated from earlier version.
> > Added support for FreeBSD.
> >   
> 
> As far as I understand motivation is to make pcap PMD behave close the
> physical NIC and able to test the application MTU feature.
> If so, Ido's v4 was simpler, which doesn't distinguish if pcap backed by
> physical interface or .pcap file.
> What was wrong with that approach?

I started with Ido's patch, then:
  - combined the two patches into one.
  - fixed the error handling (propogate errno correctly)
  - add missing freebsd support

Normally would just give feedback but patch was so old not sure if it was
stuck and unlikely to get merged.

RE: [PATCH] doc: support IPsec Multi-buffer lib v1.4

[Dooley, Brian]

Hey Ciara,

> -Original Message-
> From: Ciara Power 
> Sent: Wednesday, July 5, 2023 3:34 PM
> To: dev@dpdk.org
> Cc: Ji, Kai ; De Lara Guarch, Pablo
> ; Power, Ciara 
> Subject: [PATCH] doc: support IPsec Multi-buffer lib v1.4
> 
> Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and
> CHACHA20_POLY1305 PMD documentation guides with information about
> the latest Intel IPsec Multi-buffer library supported.
> 
> Signed-off-by: Ciara Power 
> ---
>  doc/guides/cryptodevs/aesni_gcm.rst | 6 +++---
>  doc/guides/cryptodevs/aesni_mb.rst  | 6 +++---
>  doc/guides/cryptodevs/chacha20_poly1305.rst | 6 +++---
>  doc/guides/cryptodevs/kasumi.rst| 6 +++---
>  doc/guides/cryptodevs/snow3g.rst| 6 +++---
>  doc/guides/cryptodevs/zuc.rst   | 6 +++---
>  doc/guides/rel_notes/release_23_07.rst  | 4 
>  7 files changed, 22 insertions(+), 18 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/aesni_gcm.rst
> b/doc/guides/cryptodevs/aesni_gcm.rst
> index 5192287ed8..e0d9188a5d 100644
> --- a/doc/guides/cryptodevs/aesni_gcm.rst
> +++ b/doc/guides/cryptodevs/aesni_gcm.rst
> @@ -40,8 +40,8 @@ Installation
>  To build DPDK with the AESNI_GCM_PMD the user is required to download
> the multi-buffer  library from `here  mb>`_
>  and compile it on their user system before building DPDK.
> -The latest version of the library supported by this PMD is v1.3, which -can 
> be
> downloaded in ` mb/archive/v1.3.zip>`_.
> +The latest version of the library supported by this PMD is v1.4, which
> +can be downloaded in ` mb/archive/v1.4.zip>`_.
> 
>  .. code-block:: console
> 
> @@ -85,7 +85,7 @@ and the external crypto libraries supported by them:
> 18.05 - 19.02  Multi-buffer library 0.49 - 0.52
> 19.05 - 20.08  Multi-buffer library 0.52 - 0.55
> 20.11 - 21.08  Multi-buffer library 0.53 - 1.3*
> -   21.11+ Multi-buffer library 1.0  - 1.3*
> +   21.11+ Multi-buffer library 1.0  - 1.4*
> =  
> 
>  \* Multi-buffer library 1.0 or newer only works for Meson but not Make build
> system.
> diff --git a/doc/guides/cryptodevs/aesni_mb.rst
> b/doc/guides/cryptodevs/aesni_mb.rst
> index eaa853e6b2..879eb42d44 100644
> --- a/doc/guides/cryptodevs/aesni_mb.rst
> +++ b/doc/guides/cryptodevs/aesni_mb.rst
> @@ -99,8 +99,8 @@ Installation
>  To build DPDK with the AESNI_MB_PMD the user is required to download the
> multi-buffer  library from `here `_
>  and compile it on their user system before building DPDK.
> -The latest version of the library supported by this PMD is v1.3, which -can 
> be
> downloaded from ` mb/archive/v1.3.zip>`_.
> +The latest version of the library supported by this PMD is v1.4, which
> +can be downloaded from ` mb/archive/v1.4.zip>`_.
> 
>  .. code-block:: console
> 
> @@ -146,7 +146,7 @@ and the Multi-Buffer library version supported by
> them:
> 19.05 - 19.08   0.52
> 19.11 - 20.08   0.52 - 0.55
> 20.11 - 21.08   0.53 - 1.3*
> -   21.11+  1.0  - 1.3*
> +   21.11+  1.0  - 1.4*
> ==  
> 
>  \* Multi-buffer library 1.0 or newer only works for Meson but not Make build
> system.
> diff --git a/doc/guides/cryptodevs/chacha20_poly1305.rst
> b/doc/guides/cryptodevs/chacha20_poly1305.rst
> index 883d924e31..ee7b6e54e5 100644
> --- a/doc/guides/cryptodevs/chacha20_poly1305.rst
> +++ b/doc/guides/cryptodevs/chacha20_poly1305.rst
> @@ -31,8 +31,8 @@ Installation
>  To build DPDK with the Chacha20-poly1305 PMD the user is required to
> download  the multi-buffer library from `here
> `_
>  and compile it on their user system before building DPDK.
> -The latest version of the library supported by this PMD is v1.3, which -can 
> be
> downloaded from ` mb/archive/v1.3.zip>`_.
> +The latest version of the library supported by this PMD is v1.4, which
> +can be downloaded from ` mb/archive/v1.4.zip>`_.
> 
>  After downloading the library, the user needs to unpack and compile it  on
> their system before building DPDK:
> @@ -72,7 +72,7 @@ and the external crypto libraries supported by them:
> =  
> DPDK version   Crypto library version
> =  
> -   21.11+ Multi-buffer library 1.0-1.3*
> +   21.11+ Multi-buffer library 1.0-1.4*
> =  
> 
>  \* Multi-buffer library 1.0 or newer only works for Meson but not Make build
> system.
> diff --git a/doc/guides/cryptodevs/kasumi.rst
> b/doc/guides/cryptodevs/kasumi.rst
> index 90f537

[PATCH v5 1/4] net/mlx5: introduce tracepoints for mlx5 drivers

[Viacheslav Ovsiienko]

There is an intention to engage DPDK tracing capabilities
for mlx5 PMDs monitoring and profiling in various modes.
The patch introduces tracepoints for the Tx datapath in
the ethernet device driver.

To engage this tracing capability the following steps
should be taken:

- meson option -Denable_trace_fp=true
- meson option -Dc_args='-DALLOW_EXPERIMENTAL_API'
- EAL command line parameter --trace=pmd.net.mlx5.tx.*

The Tx datapath tracing allows to get information how packets
are pushed into hardware descriptors, time stamping for
scheduled wait and send completions, etc.

To provide the human readable form of trace results the
dedicated post-processing script is presumed.

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/meson.build  |  1 +
 drivers/net/mlx5/mlx5_rx.h| 19 -
 drivers/net/mlx5/mlx5_rxtx.h  | 19 +
 drivers/net/mlx5/mlx5_trace.c | 25 
 drivers/net/mlx5/mlx5_trace.h | 73 +++
 drivers/net/mlx5/mlx5_tx.c|  9 +
 drivers/net/mlx5/mlx5_tx.h| 26 -
 7 files changed, 151 insertions(+), 21 deletions(-)
 create mode 100644 drivers/net/mlx5/mlx5_trace.c
 create mode 100644 drivers/net/mlx5/mlx5_trace.h

diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index bcb9c8542f..69771c63ab 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -31,6 +31,7 @@ sources = files(
 'mlx5_rxtx.c',
 'mlx5_stats.c',
 'mlx5_trigger.c',
+'mlx5_trace.c',
 'mlx5_tx.c',
 'mlx5_tx_empw.c',
 'mlx5_tx_mpw.c',
diff --git a/drivers/net/mlx5/mlx5_rx.h b/drivers/net/mlx5/mlx5_rx.h
index 3514edd84e..f42607dce4 100644
--- a/drivers/net/mlx5/mlx5_rx.h
+++ b/drivers/net/mlx5/mlx5_rx.h
@@ -377,25 +377,6 @@ mlx5_rx_mb2mr(struct mlx5_rxq_data *rxq, struct rte_mbuf 
*mb)
return mlx5_mr_mempool2mr_bh(mr_ctrl, mb->pool, addr);
 }
 
-/**
- * Convert timestamp from HW format to linear counter
- * from Packet Pacing Clock Queue CQE timestamp format.
- *
- * @param sh
- *   Pointer to the device shared context. Might be needed
- *   to convert according current device configuration.
- * @param ts
- *   Timestamp from CQE to convert.
- * @return
- *   UTC in nanoseconds
- */
-static __rte_always_inline uint64_t
-mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)
-{
-   RTE_SET_USED(sh);
-   return (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;
-}
-
 /**
  * Set timestamp in mbuf dynamic field.
  *
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index 876aa14ae6..b109d50758 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -43,4 +43,23 @@ int mlx5_queue_state_modify_primary(struct rte_eth_dev *dev,
 int mlx5_queue_state_modify(struct rte_eth_dev *dev,
struct mlx5_mp_arg_queue_state_modify *sm);
 
+/**
+ * Convert timestamp from HW format to linear counter
+ * from Packet Pacing Clock Queue CQE timestamp format.
+ *
+ * @param sh
+ *   Pointer to the device shared context. Might be needed
+ *   to convert according current device configuration.
+ * @param ts
+ *   Timestamp from CQE to convert.
+ * @return
+ *   UTC in nanoseconds
+ */
+static __rte_always_inline uint64_t
+mlx5_txpp_convert_rx_ts(struct mlx5_dev_ctx_shared *sh, uint64_t ts)
+{
+   RTE_SET_USED(sh);
+   return (ts & UINT32_MAX) + (ts >> 32) * NS_PER_S;
+}
+
 #endif /* RTE_PMD_MLX5_RXTX_H_ */
diff --git a/drivers/net/mlx5/mlx5_trace.c b/drivers/net/mlx5/mlx5_trace.c
new file mode 100644
index 00..bbbfd9178c
--- /dev/null
+++ b/drivers/net/mlx5/mlx5_trace.c
@@ -0,0 +1,25 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 NVIDIA Corporation & Affiliates
+ */
+
+#include 
+#include 
+
+/* TX burst subroutines trace points. */
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_entry,
+   pmd.net.mlx5.tx.entry)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_exit,
+   pmd.net.mlx5.tx.exit)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_wqe,
+   pmd.net.mlx5.tx.wqe)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_wait,
+   pmd.net.mlx5.tx.wait)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_push,
+   pmd.net.mlx5.tx.push)
+
+RTE_TRACE_POINT_REGISTER(rte_pmd_mlx5_trace_tx_complete,
+   pmd.net.mlx5.tx.complete)
diff --git a/drivers/net/mlx5/mlx5_trace.h b/drivers/net/mlx5/mlx5_trace.h
new file mode 100644
index 00..888d96f60b
--- /dev/null
+++ b/drivers/net/mlx5/mlx5_trace.h
@@ -0,0 +1,73 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 NVIDIA Corporation & Affiliates
+ */
+
+#ifndef RTE_PMD_MLX5_TRACE_H_
+#define RTE_PMD_MLX5_TRACE_H_
+
+/**
+ * @file
+ *
+ * API for mlx5 PMD trace support
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include 
+#include 
+#include 
+
+/* TX burst subroutines trace points. */
+RTE_TRACE_POINT_FP(
+   rte_pmd_mlx5_trace_tx_entry,
+   RTE_TRACE_POINT

[PATCH v5 2/4] net/mlx5: add comprehensive send completion trace

[Viacheslav Ovsiienko]

There is the demand to trace the send completions of
every WQE if time scheduling is enabled.

The patch extends the size of completion queue and
requests completion on every issued WQE in the
send queue. As the result hardware provides CQE on
each completed WQE and driver is able to fetch
completion timestamp for dedicated operation.

The add code is under conditional compilation
RTE_ENABLE_TRACE_FP flag and does not impact the
release code.

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/linux/mlx5_verbs.c |  8 +++-
 drivers/net/mlx5/mlx5_devx.c|  8 +++-
 drivers/net/mlx5/mlx5_tx.h  | 63 +++--
 3 files changed, 71 insertions(+), 8 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c 
b/drivers/net/mlx5/linux/mlx5_verbs.c
index 7233c2c7fa..b54f3ccd9a 100644
--- a/drivers/net/mlx5/linux/mlx5_verbs.c
+++ b/drivers/net/mlx5/linux/mlx5_verbs.c
@@ -968,8 +968,12 @@ mlx5_txq_ibv_obj_new(struct rte_eth_dev *dev, uint16_t idx)
rte_errno = EINVAL;
return -rte_errno;
}
-   cqe_n = desc / MLX5_TX_COMP_THRESH +
-   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
+   if (__rte_trace_point_fp_is_enabled() &&
+   txq_data->offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP)
+   cqe_n = UINT16_MAX / 2 - 1;
+   else
+   cqe_n = desc / MLX5_TX_COMP_THRESH +
+   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
txq_obj->cq = mlx5_glue->create_cq(priv->sh->cdev->ctx, cqe_n,
   NULL, NULL, 0);
if (txq_obj->cq == NULL) {
diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index 4369d2557e..5082a7e178 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -1465,8 +1465,12 @@ mlx5_txq_devx_obj_new(struct rte_eth_dev *dev, uint16_t 
idx)
MLX5_ASSERT(ppriv);
txq_obj->txq_ctrl = txq_ctrl;
txq_obj->dev = dev;
-   cqe_n = (1UL << txq_data->elts_n) / MLX5_TX_COMP_THRESH +
-   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
+   if (__rte_trace_point_fp_is_enabled() &&
+   txq_data->offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP)
+   cqe_n = UINT16_MAX / 2 - 1;
+   else
+   cqe_n = (1UL << txq_data->elts_n) / MLX5_TX_COMP_THRESH +
+   1 + MLX5_TX_COMP_THRESH_INLINE_DIV;
log_desc_n = log2above(cqe_n);
cqe_n = 1UL << log_desc_n;
if (cqe_n > UINT16_MAX) {
diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h
index 5df0c4a794..264cc192dc 100644
--- a/drivers/net/mlx5/mlx5_tx.h
+++ b/drivers/net/mlx5/mlx5_tx.h
@@ -729,6 +729,54 @@ mlx5_tx_request_completion(struct mlx5_txq_data 
*__rte_restrict txq,
}
 }
 
+/**
+ * Set completion request flag for all issued WQEs.
+ * This routine is intended to be used with enabled fast path tracing
+ * and send scheduling on time to provide the detailed report in trace
+ * for send completions on every WQE.
+ *
+ * @param txq
+ *   Pointer to TX queue structure.
+ * @param loc
+ *   Pointer to burst routine local context.
+ * @param olx
+ *   Configured Tx offloads mask. It is fully defined at
+ *   compile time and may be used for optimization.
+ */
+static __rte_always_inline void
+mlx5_tx_request_completion_trace(struct mlx5_txq_data *__rte_restrict txq,
+struct mlx5_txq_local *__rte_restrict loc,
+unsigned int olx)
+{
+   uint16_t head = txq->elts_comp;
+
+   while (txq->wqe_comp != txq->wqe_ci) {
+   volatile struct mlx5_wqe *wqe;
+   uint32_t wqe_n;
+
+   MLX5_ASSERT(loc->wqe_last);
+   wqe = txq->wqes + (txq->wqe_comp & txq->wqe_m);
+   if (wqe == loc->wqe_last) {
+   head = txq->elts_head;
+   head += MLX5_TXOFF_CONFIG(INLINE) ?
+   0 : loc->pkts_sent - loc->pkts_copy;
+   txq->elts_comp = head;
+   }
+   /* Completion request flag was set on cseg constructing. */
+#ifdef RTE_LIBRTE_MLX5_DEBUG
+   txq->fcqs[txq->cq_pi++ & txq->cqe_m] = head |
+ (wqe->cseg.opcode >> 8) << 16;
+#else
+   txq->fcqs[txq->cq_pi++ & txq->cqe_m] = head;
+#endif
+   /* A CQE slot must always be available. */
+   MLX5_ASSERT((txq->cq_pi - txq->cq_ci) <= txq->cqe_s);
+   /* Advance to the next WQE in the queue. */
+   wqe_n = rte_be_to_cpu_32(wqe->cseg.sq_ds) & 0x3F;
+   txq->wqe_comp += RTE_ALIGN(wqe_n, 4) / 4;
+   }
+}
+
 /**
  * Build the Control Segment with specified opcode:
  * - MLX5_OPCODE_SEND
@@ -755,7 +803,7 @@ mlx5_tx_cseg_init(struct mlx5_txq_data *__rte_restrict txq,
  struct mlx5_wqe *__rte_restrict wqe,
  unsigned int ds,
  unsigned i

[PATCH v5 0/4] net/mlx5: introduce Tx datapath tracing

[Viacheslav Ovsiienko]

The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track the internal delay issues).

Because the DPDK tx datapath API does not suppose getting any feedback
from the driver and the feature looks like to be mlx5 specific, it seems
to be reasonable to engage exisiting DPDK datapath tracing capability.

The work cycle is supposed to be:
  - compile appplication with enabled tracing
  - run application with EAL parameters configuring the tracing in mlx5
Tx datapath
  - store the dump file with gathered tracing information
  - run analyzing scrypt (in Python) to combine related events (packet
firing and completion) and see the data in human-readable view

Below is the detailed instruction "how to" with mlx5 NIC to gather
all the debug data including the full timings information.


1. Build DPDK application with enabled datapath tracing

The meson option should be specified:
   --enable_trace_fp=true

The c_args shoudl be specified:
   -DALLOW_EXPERIMENTAL_API

The DPDK configuration examples:

  meson configure --buildtype=debug -Denable_trace_fp=true
-Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT 
-DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=debug -Denable_trace_fp=true
-Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=release -Denable_trace_fp=true
-Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build

  meson configure --buildtype=release -Denable_trace_fp=true
-Dc_args='-DALLOW_EXPERIMENTAL_API' build


2. Configuring the NIC

If the sending completion timings are important the NIC should be configured
to provide realtime timestamps, the REAL_TIME_CLOCK_ENABLE NV settings parameter
should be configured to TRUE, for example with command (and with following
FW/driver reset):

  sudo mlxconfig -d /dev/mst/mt4125_pciconf0 s REAL_TIME_CLOCK_ENABLE=1


3. Run DPDK application to gather the traces

EAL parameters controlling trace capability in runtime

  --trace=pmd.net.mlx5.tx - the regular expression enabling the tracepoints
with matching names at least "pmd.net.mlx5.tx"
must be enabled to gather all events needed
to analyze mlx5 Tx datapath and its timings.
By default all tracepoints are disabled.

  --trace-dir=/var/log - trace storing directory

  --trace-bufsz=B|K|M - optional, trace data buffer size
   per thread. The default is 1MB.

  --trace-mode=overwrite|discard  - optional, selects trace data buffer mode.


4. Installing or Building Babeltrace2 Package

The gathered trace data can be analyzed with a developed Python script.
To parse the trace, the data script uses the Babeltrace2 library.
The package should be either installed or built from source code as
shown below:

  git clone https://github.com/efficios/babeltrace.git
  cd babeltrace
  ./bootstrap
  ./configure -help
  ./configure --disable-api-doc --disable-man-pages
  --disable-python-bindings-doc --enbale-python-plugins
  --enable-python-binding

5. Running the Analyzing Script

The analyzing script is located in the folder: ./drivers/net/mlx5/tools
It requires Python3.6, Babeltrace2 packages and it takes the only parameter
of trace data file. For example:

   ./mlx5_trace.py /var/log/rte-2023-01-23-AM-11-52-39


6. Interpreting the Script Output Data

All the timings are given in nanoseconds.
The list of Tx (and coming Rx) bursts per port/queue is presented in the output.
Each list element contains the list of built WQEs with specific opcodes, and
each WQE contains the list of the encompassed packets to send.

Signed-off-by: Viacheslav Ovsiienko 

--
v2: - comment addressed: "dump_trace" command is replaced with "save_trace"
- Windows build failure addressed, Windows does not support tracing

v3: - tracepoint routines are moved to the net folder, no need to export
- documentation added
- testpmd patches moved out from series to the dedicated patches

v4: - Python comments addressed
- codestyle issues fixed

v5: - traces are moved to the dedicated files, otherwise registration
  header caused wrong code generation for 3rd party files/objects
  and resulted in performance drop

Viacheslav Ovsiienko (4):
  net/mlx5: introduce tracepoints for mlx5 drivers
  net/mlx5: add comprehensive send completion trace
  net/mlx5: add Tx datapath trace analyzing script
  doc: add mlx5 datapath tracing feature description

 doc/guides/nics/mlx5.rst |  78 +++
 drivers/net/mlx5/linux/mlx5_verbs.c  |   8 +-
 drivers/net/mlx5/meson.build |   1 +
 drivers/net/mlx5/mlx5_devx.c |   8 +-
 dri

[PATCH v5 3/4] net/mlx5: add Tx datapath trace analyzing script

[Viacheslav Ovsiienko]

The Python script is intended to analyze mlx5 PMD
datapath traces and report:
  - tx_burst routine timings
  - how packets are pushed to WQEs
  - how packet sending is completed with timings

Signed-off-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/tools/mlx5_trace.py | 307 +++
 1 file changed, 307 insertions(+)
 create mode 100755 drivers/net/mlx5/tools/mlx5_trace.py

diff --git a/drivers/net/mlx5/tools/mlx5_trace.py 
b/drivers/net/mlx5/tools/mlx5_trace.py
new file mode 100755
index 00..8c1fd0a350
--- /dev/null
+++ b/drivers/net/mlx5/tools/mlx5_trace.py
@@ -0,0 +1,307 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2023 NVIDIA Corporation & Affiliates
+
+"""
+Analyzing the mlx5 PMD datapath tracings
+"""
+import sys
+import argparse
+import bt2
+
+PFX_TX = "pmd.net.mlx5.tx."
+PFX_TX_LEN = len(PFX_TX)
+
+
+class MlxQueue:
+"""Queue container object"""
+
+def __init__(self):
+self.done_burst = []  # completed bursts
+self.wait_burst = []  # waiting for completion
+self.pq_id = 0
+
+def log(self):
+"""Log all queue bursts"""
+for txb in self.done_burst:
+txb.log()
+
+
+class MlxMbuf:
+"""Packet mbufs container object"""
+
+def __init__(self):
+self.wqe = 0 # wqe id
+self.ptr = None  # first packet mbuf pointer
+self.len = 0 # packet data length
+self.nseg = 0# number of segments
+
+def log(self):
+"""Log mbuf"""
+out_txt = "%X: %u" % (self.ptr, self.len)
+if self.nseg != 1:
+out_txt += " (%d segs)" % self.nseg
+print(out_txt)
+
+
+class MlxWqe:
+"""WQE container object"""
+
+def __init__(self):
+self.mbuf = []# list of mbufs in WQE
+self.wait_ts = 0  # preceding wait/push timestamp
+self.comp_ts = 0  # send/recv completion timestamp
+self.opcode = 0
+
+def log(self):
+"""Log WQE"""
+wqe_id = (self.opcode >> 8) & 0x
+wqe_op = self.opcode & 0xFF
+out_txt = "  %04X: " % wqe_id
+if wqe_op == 0xF:
+out_txt += "WAIT"
+elif wqe_op == 0x29:
+out_txt += "EMPW"
+elif wqe_op == 0xE:
+out_txt += "TSO "
+elif wqe_op == 0xA:
+out_txt += "SEND"
+else:
+out_txt += "0x%02X" % wqe_op
+if self.comp_ts != 0:
+out_txt += " (%d, %d)" % (self.wait_ts, self.comp_ts - 
self.wait_ts)
+else:
+out_txt += " (%d)" % self.wait_ts
+print(out_txt)
+for mbuf in self.mbuf:
+mbuf.log()
+
+def comp(self, wqe_id, wqe_ts):
+"""Return 0 if WQE in not completedLog WQE"""
+if self.comp_ts != 0:
+return 1
+cur_id = (self.opcode >> 8) & 0x
+if cur_id > wqe_id:
+cur_id -= wqe_id
+if cur_id <= 0x8000:
+return 0
+else:
+cur_id = wqe_id - cur_id
+if cur_id >= 0x8000:
+return 0
+self.comp_ts = wqe_ts
+return 1
+
+
+class MlxBurst:
+"""Packet burst container object"""
+
+def __init__(self):
+self.wqes = []# issued burst WQEs
+self.done = 0 # number of sent/recv packets
+self.req = 0  # requested number of packets
+self.call_ts = 0  # burst routine invocation
+self.done_ts = 0  # burst routine done
+self.queue = None
+
+def log(self):
+"""Log burst"""
+port = self.queue.pq_id >> 16
+queue = self.queue.pq_id & 0x
+if self.req == 0:
+print(
+"%u: tx(p=%u, q=%u, %u/%u pkts (incomplete)"
+% (self.call_ts, port, queue, self.done, self.req)
+)
+else:
+print(
+"%u: tx(p=%u, q=%u, %u/%u pkts in %u"
+% (
+self.call_ts,
+port,
+queue,
+self.done,
+self.req,
+self.done_ts - self.call_ts,
+)
+)
+for wqe in self.wqes:
+wqe.log()
+
+def comp(self, wqe_id, wqe_ts):
+"""Return 0 if not all of WQEs in burst completed"""
+wlen = len(self.wqes)
+if wlen == 0:
+return 0
+for wqe in self.wqes:
+if wqe.comp(wqe_id, wqe_ts) == 0:
+return 0
+return 1
+
+
+class MlxTrace:
+"""Trace representing object"""
+
+def __init__(self):
+self.tx_blst = {}  # current Tx bursts per CPU
+self.tx_qlst = {}  # active Tx queues per port/queue
+self.tx_wlst = {}  # wait timestamp list per CPU
+
+def run(self, msg_it):
+"""Run over gathered tracing data and build database"""
+for msg in msg_it:
+if not isinstance(msg, bt2._EventMessageConst):
+

[PATCH v5 4/4] doc: add mlx5 datapath tracing feature description

[Viacheslav Ovsiienko]

The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track the internal delay issues).

The patch adds the documentation for feature usage.

Signed-off-by: Viacheslav Ovsiienko 
---
 doc/guides/nics/mlx5.rst | 78 
 1 file changed, 78 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index b9843edbd9..1c8fc6f6d4 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -2077,3 +2077,81 @@ where:
 * ``sw_queue_id``: queue index in range [64536, 65535].
   This range is the highest 1000 numbers.
 * ``hw_queue_id``: queue index given by HW in queue creation.
+
+
+Tx datapath tracing
+^^^
+
+The mlx5 provides the Tx datapath tracing capability with extra debug
+information - when and how packets were scheduled and when the actual
+sending was completed by the NIC hardware. The feature engages the
+existing DPDK datapath tracing capability.
+
+Usage of the mlx5 Tx datapath tracing:
+
+#. Build DPDK application with enabled datapath tracking
+
+   * The meson option should be specified: ``--enable_trace_fp=true``
+   * The c_args should be specified:  ``-DALLOW_EXPERIMENTAL_API``
+
+   .. code-block:: console
+
+  meson configure --buildtype=debug -Denable_trace_fp=true
+ -Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT 
-DALLOW_EXPERIMENTAL_API' build
+
+  meson configure --buildtype=release -Denable_trace_fp=true
+ -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' build
+
+#. Configure the NIC
+
+   If the sending completion timings are important the NIC should be configured
+   to provide realtime timestamps, the ``REAL_TIME_CLOCK_ENABLE`` NV settings
+   parameter should be configured as TRUE.
+
+   .. code-block:: console
+
+  mlxconfig -d /dev/mst/mt4125_pciconf0 s REAL_TIME_CLOCK_ENABLE=1
+
+#. Run application with EAL parameters configuring the tracing in mlx5 Tx 
datapath
+
+* ``--trace=pmd.net.mlx5.tx`` - the regular expression enabling the 
tracepoints
+  with matching names at least "pmd.net.mlx5.tx" must be enabled to gather 
all
+  events needed to analyze mlx5 Tx datapath and its timings. By default all
+  tracepoints are disabled.
+
+#. Store the file with gathered tracing information
+
+#. Install or build the ``babeltrace2`` package
+
+   The gathered trace data can be analyzed with a developed Python script.
+   To parse the trace, the data script uses the ``babeltrace2`` library.
+   The package should be either installed or built from source code as
+   shown below.
+
+   .. code-block:: console
+
+  git clone https://github.com/efficios/babeltrace.git
+  cd babeltrace
+  ./bootstrap
+  ./configure -help
+  ./configure --disable-api-doc --disable-man-pages
+  --disable-python-bindings-doc --enable-python-plugins
+  --enable-python-binding
+
+#. Run analyzing scrypt (in Python) to combine related events (packet firing 
and
+   completion) and see the output in human-readable view
+
+   The analyzing script is located in the folder: ``./drivers/net/mlx5/tools``
+   It requires Python3.6, ``babeltrace2`` packages and it takes the only 
parameter
+   of trace data file.
+
+   .. code-block:: console
+
+  ./mlx5_trace.py /var/log/rte-2023-01-23-AM-11-52-39
+
+#. Interpreting the Script Output Data
+
+   All the timings are given in nanoseconds.
+   The list of Tx bursts per port/queue is presented in the output.
+   Each list element contains the list of built WQEs with specific opcodes, and
+   each WQE contains the list of the encompassed packets to send.
-- 
2.18.1

RE: [PATCH] crypto/qat: fix legacy sm4 ecb capability

[O'Donovan, Saoirse]

Hi Ciara,

> -Original Message-
> From: Power, Ciara 
> Sent: Wednesday 5 July 2023 14:23
> To: dev@dpdk.org
> Cc: Ji, Kai ; O'Donovan, Saoirse
> ; Power, Ciara 
> Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
> 
> Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> included as legacy, to be disabled by default.
> 
> Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> 
> Signed-off-by: Ciara Power 
> ---
>  drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Tested-by: Saoirse O'Donovan 

Re: [PATCH 1/1] app/test: resolve mbuf_test application failure

[Olivier Matz]

Hi Rakesh,

On Tue, May 23, 2023 at 03:39:53PM +, Rakesh Kudurumalla wrote:
> Ping
> 
> Regards,
> Rakesh
> 
> > -Original Message-
> > From: Rakesh Kudurumalla 
> > Sent: Wednesday, April 26, 2023 2:58 PM
> > To: Olivier Matz 
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin
> > Kumar Dabilpuram ; Rakesh Kudurumalla
> > 
> > Subject: [PATCH 1/1] app/test: resolve mbuf_test application failure
> > 
> > when RTE_ENABLE_ASSERT is defined test_mbuf application is failing
> > because we are trying to attach extbuf to a cloned buffer to which external
> > mbuf is already attached.This patch fixes the same.
> > 
> > Signed-off-by: Rakesh Kudurumalla 
> > ---
> > v2: removed gerrit id
> > 
> >  app/test/test_mbuf.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index
> > 8d8d3b9386..e2b81db308 100644
> > --- a/app/test/test_mbuf.c
> > +++ b/app/test/test_mbuf.c
> > @@ -2375,6 +2375,7 @@ test_pktmbuf_ext_shinfo_init_helper(struct
> > rte_mempool *pktmbuf_pool)
> > GOTO_FAIL("%s: Bad packet length\n", __func__);
> > 
> > /* attach the same external buffer to the cloned mbuf */
> > +   clone->ol_flags = 0;
> > rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
> > ret_shinfo);

I think we can simply remove the call to rte_pktmbuf_attach_extbuf() because
after the call to rte_pktmbuf_clone(), the mbuf is already attached.

I mean something like this:

  --- a/app/test/test_mbuf.c
  +++ b/app/test/test_mbuf.c
  @@ -2345,16 +2345,12 @@ test_pktmbuf_ext_shinfo_init_helper(struct 
rte_mempool *pktmbuf_pool)
  GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
  __func__);
   
  -   /* allocate one more mbuf */
  +   /* allocate one more mbuf, it is attached to the same external buffer 
*/
  clone = rte_pktmbuf_clone(m, pktmbuf_pool);
  if (clone == NULL)
  GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__);
  if (rte_pktmbuf_pkt_len(clone) != 0)
  GOTO_FAIL("%s: Bad packet length\n", __func__);
  -
  -   /* attach the same external buffer to the cloned mbuf */
  -   rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len,
  -   ret_shinfo);
  if (clone->ol_flags != RTE_MBUF_F_EXTERNAL)
  GOTO_FAIL("%s: External buffer is not attached to mbuf\n",
  __func__);


Regards,
Olivier

Re: [PATCH] app/testpmd: revert primary process polling all queues fix

[Ferruh Yigit]

On 7/5/2023 3:32 PM, Ferruh Yigit wrote:
> For some drivers [1], testpmd forwarding is broken with commit [2].
> 
> This is because with [2] testpmd gets queue state from ethdev and
> forwarding is done only on queues in started state, but some drivers
> don't update queue status properly, and this breaks forwarding for those
> drivers.
> 
> Drivers should be fixed but more time is required to verify drivers
> again, instead reverting [2] for now to not break drivers.
> Target is to merge [2] back at the beginning of next release cycle and
> fix drivers accordingly.
> 
> [1]
> Bugzilla ID: 1259
> 
> [2]
> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all 
> queues")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Ferruh Yigit 
> ---
> Cc: haij...@huawei.com
> Cc: songx.ji...@intel.com
> Cc: qiming.y...@intel.com

+Ali & Raslan

Re: [dpdk-dev] [PATCH v5 1/4] eal: explain argv behaviour during init

[Stephen Hemminger]

On Mon,  5 Apr 2021 21:39:51 +0200
Thomas Monjalon  wrote:

> After argument parsing done by rte_eal_init(),
> the remaining arguments are to be parsed by the application
> by progressing in the argv array.
> In this context, the first string represented by argv[0] is still
> the same program name as the original argv[0],
> while the next strings are the application arguments.
> This is because rte_eal_init() manipulates the argv array
> after EAL parsing, before returning to the application.
> 
> This note was missing in the doxygen comment of the API.
> 
> Signed-off-by: Thomas Monjalon 
> Acked-by: Bruce Richardson 
> Acked-by: Andrew Rybchenko 

This old patch is still worth applying

Acked-by: Stephen Hemminger 

Re: [PATCH 1/2] vhost: fix vduse features negotiation

[Maxime Coquelin]

Hi David,

On 7/5/23 15:36, David Marchand wrote:

On Wed, Jul 5, 2023 at 3:22 PM Maxime Coquelin
 wrote:

@@ -950,9 +954,14 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
  * two values.
  */
 vsocket->use_builtin_virtio_net = true;
-   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
-   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
-   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
+   if (vsocket->is_vduse) {
+   vsocket->supported_features = VDUSE_NET_SUPPORTED_FEATURES;
+   vsocket->features   = VDUSE_NET_SUPPORTED_FEATURES;
+   } else {
+   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
+   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
+   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
+   }



Would it make sense to split those features in a set of features
shared by vhost-user and vduse, and one dedicated set for each of
them?
For example, the VIRTIO_NET_F_GUEST/HOST_* features are not bound to
vhost-user / vduse, are they?


Most of the features are the same, but there are a few differences:
- VIRTIO_F_RING_PACKED: this is not really Vhost or VDUSE specific. The
issue is we just lack packed ring support in the control queue
implementation, only used by VDUSE for now. I expect to add it in
v23.11.

- VHOST_USER_F_PROTOCOL_FEATURES: This feature is Vhost-user specific

- VHOST_F_LOG_ALL: This is for live-migration, maybe it will be
advertised by VDUSE in the future, but we miss live-migration support in
Kernel VDUSE at the moment.

- VIRTIO_NET_F_CTRL_RX: This is advertised by Vhost-user, but it does
not do anything specific. While if we do it in VDUSE, we need to
implement its support in CVQ.

To summarize, we have some features specific to Vhost-user, but for the 
other differences, this is just some features are not yet

implemented/tested with VDUSE.

Maybe we could have something like this, which has the advantage to
highlight the gaps we have in VDUSE (not compiled/tested):


diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index a65d301406..f55fb299fd 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -958,8 +958,8 @@ rte_vhost_driver_register(const char *path, uint64_t 
flags)

vsocket->supported_features = VDUSE_NET_SUPPORTED_FEATURES;
vsocket->features   = VDUSE_NET_SUPPORTED_FEATURES;
} else {
-   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
-   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
+   vsocket->supported_features = 
VHOST_USER_NET_SUPPORTED_FEATURES;
+   vsocket->features   = 
VHOST_USER_NET_SUPPORTED_FEATURES;

vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
}

diff --git a/lib/vhost/vduse.h b/lib/vhost/vduse.h
index 46753fec73..5a8b37ec67 100644
--- a/lib/vhost/vduse.h
+++ b/lib/vhost/vduse.h
@@ -7,28 +7,7 @@

 #include "vhost.h"

-#define VDUSE_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
-   (1ULL << VIRTIO_F_ANY_LAYOUT) | \
-   (1ULL << VIRTIO_F_VERSION_1)   | \
-   (1ULL << VIRTIO_NET_F_GSO) | \
-   (1ULL << VIRTIO_NET_F_HOST_TSO4) | \
-   (1ULL << VIRTIO_NET_F_HOST_TSO6) | \
-   (1ULL << VIRTIO_NET_F_HOST_UFO) | \
-   (1ULL << VIRTIO_NET_F_HOST_ECN) | \
-   (1ULL << VIRTIO_NET_F_CSUM)| \
-   (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \
-   (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \
-   (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \
-   (1ULL << VIRTIO_NET_F_GUEST_UFO) | \
-   (1ULL << VIRTIO_NET_F_GUEST_ECN) | \
-   (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
-   (1ULL << VIRTIO_RING_F_EVENT_IDX) | \
-   (1ULL << VIRTIO_F_IN_ORDER) | \
-   (1ULL << VIRTIO_F_IOMMU_PLATFORM) | \
-   (1ULL << VIRTIO_NET_F_CTRL_VQ) | \
-   (1ULL << VIRTIO_NET_F_MQ))
-
-#ifdef VHOST_HAS_VDUSE
+#define VDUSE_NET_SUPPORTED_FEATURES VIRTIO_NET_SUPPORTED_FEATURES

 int vduse_device_create(const char *path);
 int vduse_device_destroy(const char *path);
diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 9ecede0f30..f49ce943b0 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -438,12 +438,8 @@ struct vring_packed_desc_event {
 #define VIRTIO_NET_SUPPORTED_FEATURES ((1ULL << 
VIRTIO_NET_F_MRG_RXBUF) | \

  

Re: [PATCH 1/2] vhost: fix vduse features negotiation

[David Marchand]

On Wed, Jul 5, 2023 at 7:02 PM Maxime Coquelin
 wrote:
>
> On 7/5/23 15:36, David Marchand wrote:
> > On Wed, Jul 5, 2023 at 3:22 PM Maxime Coquelin
> >  wrote:
> >> @@ -950,9 +954,14 @@ rte_vhost_driver_register(const char *path, uint64_t 
> >> flags)
> >>   * two values.
> >>   */
> >>  vsocket->use_builtin_virtio_net = true;
> >> -   vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
> >> -   vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
> >> -   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
> >> +   if (vsocket->is_vduse) {
> >> +   vsocket->supported_features = VDUSE_NET_SUPPORTED_FEATURES;
> >> +   vsocket->features   = VDUSE_NET_SUPPORTED_FEATURES;
> >> +   } else {
> >> +   vsocket->supported_features = 
> >> VIRTIO_NET_SUPPORTED_FEATURES;
> >> +   vsocket->features   = 
> >> VIRTIO_NET_SUPPORTED_FEATURES;
> >> +   vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
> >> +   }
> >>
> >
> > Would it make sense to split those features in a set of features
> > shared by vhost-user and vduse, and one dedicated set for each of
> > them?
> > For example, the VIRTIO_NET_F_GUEST/HOST_* features are not bound to
> > vhost-user / vduse, are they?
>
> Most of the features are the same, but there are a few differences:
> - VIRTIO_F_RING_PACKED: this is not really Vhost or VDUSE specific. The
> issue is we just lack packed ring support in the control queue
> implementation, only used by VDUSE for now. I expect to add it in
> v23.11.
>
> - VHOST_USER_F_PROTOCOL_FEATURES: This feature is Vhost-user specific
>
> - VHOST_F_LOG_ALL: This is for live-migration, maybe it will be
> advertised by VDUSE in the future, but we miss live-migration support in
> Kernel VDUSE at the moment.
>
> - VIRTIO_NET_F_CTRL_RX: This is advertised by Vhost-user, but it does
> not do anything specific. While if we do it in VDUSE, we need to
> implement its support in CVQ.
>
> To summarize, we have some features specific to Vhost-user, but for the
> other differences, this is just some features are not yet
> implemented/tested with VDUSE.
>
> Maybe we could have something like this, which has the advantage to
> highlight the gaps we have in VDUSE (not compiled/tested):

LGTM on the principle.
Thanks Maxime.


-- 
David Marchand

[PATCH v11 1/2] mempool cache: add zero-copy get and put functions

[Kamalakshitha Aligeri]

From: Morten Brørup 

Zero-copy access to mempool caches is beneficial for PMD performance.
Furthermore, having a zero-copy mempool API is considered a precondition
for fixing a certain category of bugs, present in some PMDs: For
performance reasons, some PMDs had bypassed the mempool API in order to
achieve zero-copy access to the mempool cache. This can only be fixed
in those PMDs without a performance regression if the mempool library
offers zero-copy access APIs, so the PMDs can use the proper mempool
API instead of copy-pasting code from the mempool library.
Furthermore, the copy-pasted code in those PMDs has not been kept up to
date with the improvements of the mempool library, so when they bypass
the mempool API, mempool trace is missing and mempool statistics is not
updated.

Bugzilla ID: 1052

Signed-off-by: Morten Brørup 
Signed-off-by: Kamalakshitha Aligeri 

v11:
* Changed patch description and version to 23.07
v10:
* Added mempool test cases with zero-copy API's
v9:
* Also set rte_errno in zero-copy put function, if returning NULL.
  (Honnappa)
* Revert v3 comparison to prevent overflow if n is really huge and len is
  non-zero. (Olivier)
v8:
* Actually include the rte_errno header file.
  Note to self: The changes only take effect on the disk after the file in
  the text editor has been saved.
v7:
* Fix typo in function description. (checkpatch)
* Zero-copy functions may set rte_errno; include rte_errno header file.
  (ci/loongarch-compilation)
v6:
* Improve description of the 'n' parameter to the zero-copy get function.
  (Konstantin, Bruce)
* The caches used for zero-copy may not be user-owned, so remove this word
  from the function descriptions. (Kamalakshitha)
v5:
* Bugfix: Compare zero-copy get request to the cache size instead of the
  flush threshold; otherwise refill could overflow the memory allocated
  for the cache. (Andrew)
* Split the zero-copy put function into an internal function doing the
  work, and a public function with trace.
* Avoid code duplication by rewriting rte_mempool_do_generic_put() to use
  the internal zero-copy put function. (Andrew)
* Corrected the return type of rte_mempool_cache_zc_put_bulk() from void *
  to void **; it returns a pointer to an array of objects.
* Fix coding style: Add missing curly brackets. (Andrew)
v4:
* Fix checkpatch warnings.
v3:
* Bugfix: Respect the cache size; compare to the flush threshold instead
  of RTE_MEMPOOL_CACHE_MAX_SIZE.
* Added 'rewind' function for incomplete 'put' operations. (Konstantin)
* Replace RTE_ASSERTs with runtime checks of the request size.
  Instead of failing, return NULL if the request is too big. (Konstantin)
* Modified comparison to prevent overflow if n is really huge and len is
  non-zero. (Andrew)
* Updated the comments in the code.
v2:
* Fix checkpatch warnings.
* Fix missing registration of trace points.
* The functions are inline, so they don't go into the map file.
v1 changes from the RFC:
* Removed run-time parameter checks. (Honnappa)
  This is a hot fast path function; requiring correct application
  behaviour, i.e. function parameters must be valid.
* Added RTE_ASSERT for parameters instead.
  Code for this is only generated if built with RTE_ENABLE_ASSERT.
* Removed fallback when 'cache' parameter is not set. (Honnappa)
* Chose the simple get function; i.e. do not move the existing objects in
  the cache to the top of the new stack, just leave them at the bottom.
* Renamed the functions. Other suggestions are welcome, of course. ;-)
* Updated the function descriptions.
* Added the functions to trace_fp and version.map.

---
 app/test/test_mempool.c|  81 +++---
 lib/mempool/mempool_trace_points.c |   9 ++
 lib/mempool/rte_mempool.h  | 239 +
 lib/mempool/rte_mempool_trace_fp.h |  23 +++
 lib/mempool/version.map|   9 ++
 5 files changed, 311 insertions(+), 50 deletions(-)

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 8e493eda47..6d29f5bc7b 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -74,7 +74,7 @@ my_obj_init(struct rte_mempool *mp, __rte_unused void *arg,

 /* basic tests (done on one core) */
 static int
-test_mempool_basic(struct rte_mempool *mp, int use_external_cache)
+test_mempool_basic(struct rte_mempool *mp, int use_external_cache, int 
use_zc_api)
 {
uint32_t *objnum;
void **objtable;
@@ -84,6 +84,7 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
unsigned i, j;
int offset;
struct rte_mempool_cache *cache;
+   void **cache_objs;

if (use_external_cache) {
/* Create a user-owned mempool cache. */
@@ -100,8 +101,13 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
rte_mempool_dump(stdout, mp);

printf("get an object\n");
-   if (rte_mempool_generic_get(mp, &obj, 1, cache) < 0)
-   GOTO_ERR(ret, out);
+   if (use_zc_api) {
+

[PATCH v11 2/2] net/i40e: replace put function

[Kamalakshitha Aligeri]

Integrated zero-copy put API in mempool cache in i40e PMD.
On Ampere Altra server, l3fwd single core's performance improves by 5%
with the new API

Signed-off-by: Kamalakshitha Aligeri 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Feifei Wang 
---
 .mailmap|  1 +
 drivers/net/i40e/i40e_rxtx_vec_common.h | 27 -
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/.mailmap b/.mailmap
index a9f4f28fba..2581d0efe7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -677,6 +677,7 @@ Kai Ji 
 Kaiwen Deng 
 Kalesh AP 
 Kamalakannan R 
+Kamalakshitha Aligeri 
 Kamil Bednarczyk 
 Kamil Chalupnik 
 Kamil Rytarowski 
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
b/drivers/net/i40e/i40e_rxtx_vec_common.h
index fe1a6ec75e..35cdb31b2e 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)

n = txq->tx_rs_thresh;

-/* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
+   /* first buffer to free from S/W ring is at index
+* tx_next_dd - (tx_rs_thresh-1)
+*/
txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];

if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
+   struct rte_mempool *mp = txep[0].mbuf->pool;
+   struct rte_mempool_cache *cache = rte_mempool_default_cache(mp, 
rte_lcore_id());
+   void **cache_objs;
+
+   if (unlikely(!cache))
+   goto fallback;
+
+   cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);
+   if (unlikely(!cache_objs))
+   goto fallback;
+
for (i = 0; i < n; i++) {
-   free[i] = txep[i].mbuf;
+   cache_objs[i] = txep[i].mbuf;
/* no need to reset txep[i].mbuf in vector path */
}
-   rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
goto done;
+
+fallback:
+   for (i = 0; i < n; i++)
+   free[i] = txep[i].mbuf;
+   rte_mempool_generic_put(mp, (void **)free, n, cache);
+   goto done;
+
}

m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
--
2.25.1

[dpdk-dev v1] examples/ipsec-secgw: fix of socket id default value

[Kai Ji]

Due to recent changes to the default device socket ID, before
being used as an index for session mempool list,
set socket ID to 0 if unknown (-1).

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org

Signed-off-by: Kai Ji 
---
 examples/ipsec-secgw/ipsec-secgw.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/examples/ipsec-secgw/ipsec-secgw.c 
b/examples/ipsec-secgw/ipsec-secgw.c
index 029749e522..e678625ece 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1699,6 +1699,11 @@ cryptodevs_init(enum eh_pkt_transfer_mode mode)
 
total_nb_qps += qp;
dev_conf.socket_id = rte_cryptodev_socket_id(cdev_id);
+   /* range check the socket_id - negative values become big
+* positive ones due to use of unsigned value
+*/
+   if (dev_conf.socket_id >= RTE_MAX_NUMA_NODES)
+   dev_conf.socket_id = 0;
dev_conf.nb_queue_pairs = qp;
dev_conf.ff_disable = RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO;
 
-- 
2.34.1

[PATCH v11 1/2] mempool cache: add zero-copy get and put functions

[Kamalakshitha Aligeri]

From: Morten Brørup 

Zero-copy access to mempool caches is beneficial for PMD performance.
Furthermore, having a zero-copy mempool API is considered a precondition
for fixing a certain category of bugs, present in some PMDs: For
performance reasons, some PMDs had bypassed the mempool API in order to
achieve zero-copy access to the mempool cache. This can only be fixed
in those PMDs without a performance regression if the mempool library
offers zero-copy access APIs, so the PMDs can use the proper mempool
API instead of copy-pasting code from the mempool library.
Furthermore, the copy-pasted code in those PMDs has not been kept up to
date with the improvements of the mempool library, so when they bypass
the mempool API, mempool trace is missing and mempool statistics is not
updated.

Bugzilla ID: 1052

Signed-off-by: Morten Brørup 
Signed-off-by: Kamalakshitha Aligeri 

v11:
* Changed patch description and version to 23.07
v10:
* Added mempool test cases with zero-copy API's
v9:
* Also set rte_errno in zero-copy put function, if returning NULL.
  (Honnappa)
* Revert v3 comparison to prevent overflow if n is really huge and len is
  non-zero. (Olivier)
v8:
* Actually include the rte_errno header file.
  Note to self: The changes only take effect on the disk after the file in
  the text editor has been saved.
v7:
* Fix typo in function description. (checkpatch)
* Zero-copy functions may set rte_errno; include rte_errno header file.
  (ci/loongarch-compilation)
v6:
* Improve description of the 'n' parameter to the zero-copy get function.
  (Konstantin, Bruce)
* The caches used for zero-copy may not be user-owned, so remove this word
  from the function descriptions. (Kamalakshitha)
v5:
* Bugfix: Compare zero-copy get request to the cache size instead of the
  flush threshold; otherwise refill could overflow the memory allocated
  for the cache. (Andrew)
* Split the zero-copy put function into an internal function doing the
  work, and a public function with trace.
* Avoid code duplication by rewriting rte_mempool_do_generic_put() to use
  the internal zero-copy put function. (Andrew)
* Corrected the return type of rte_mempool_cache_zc_put_bulk() from void *
  to void **; it returns a pointer to an array of objects.
* Fix coding style: Add missing curly brackets. (Andrew)
v4:
* Fix checkpatch warnings.
v3:
* Bugfix: Respect the cache size; compare to the flush threshold instead
  of RTE_MEMPOOL_CACHE_MAX_SIZE.
* Added 'rewind' function for incomplete 'put' operations. (Konstantin)
* Replace RTE_ASSERTs with runtime checks of the request size.
  Instead of failing, return NULL if the request is too big. (Konstantin)
* Modified comparison to prevent overflow if n is really huge and len is
  non-zero. (Andrew)
* Updated the comments in the code.
v2:
* Fix checkpatch warnings.
* Fix missing registration of trace points.
* The functions are inline, so they don't go into the map file.
v1 changes from the RFC:
* Removed run-time parameter checks. (Honnappa)
  This is a hot fast path function; requiring correct application
  behaviour, i.e. function parameters must be valid.
* Added RTE_ASSERT for parameters instead.
  Code for this is only generated if built with RTE_ENABLE_ASSERT.
* Removed fallback when 'cache' parameter is not set. (Honnappa)
* Chose the simple get function; i.e. do not move the existing objects in
  the cache to the top of the new stack, just leave them at the bottom.
* Renamed the functions. Other suggestions are welcome, of course. ;-)
* Updated the function descriptions.
* Added the functions to trace_fp and version.map.

---
 app/test/test_mempool.c|  81 +++---
 lib/mempool/mempool_trace_points.c |   9 ++
 lib/mempool/rte_mempool.h  | 239 +
 lib/mempool/rte_mempool_trace_fp.h |  23 +++
 lib/mempool/version.map|   9 ++
 5 files changed, 311 insertions(+), 50 deletions(-)

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 8e493eda47..6d29f5bc7b 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -74,7 +74,7 @@ my_obj_init(struct rte_mempool *mp, __rte_unused void *arg,

 /* basic tests (done on one core) */
 static int
-test_mempool_basic(struct rte_mempool *mp, int use_external_cache)
+test_mempool_basic(struct rte_mempool *mp, int use_external_cache, int 
use_zc_api)
 {
uint32_t *objnum;
void **objtable;
@@ -84,6 +84,7 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
unsigned i, j;
int offset;
struct rte_mempool_cache *cache;
+   void **cache_objs;

if (use_external_cache) {
/* Create a user-owned mempool cache. */
@@ -100,8 +101,13 @@ test_mempool_basic(struct rte_mempool *mp, int 
use_external_cache)
rte_mempool_dump(stdout, mp);

printf("get an object\n");
-   if (rte_mempool_generic_get(mp, &obj, 1, cache) < 0)
-   GOTO_ERR(ret, out);
+   if (use_zc_api) {
+

[PATCH v11 2/2] net/i40e: replace put function

[Kamalakshitha Aligeri]

Integrated zero-copy put API in mempool cache in i40e PMD.
On Ampere Altra server, l3fwd single core's performance improves by 5%
with the new API

Signed-off-by: Kamalakshitha Aligeri 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Feifei Wang 
---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 27 -
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
b/drivers/net/i40e/i40e_rxtx_vec_common.h
index fe1a6ec75e..35cdb31b2e 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)

n = txq->tx_rs_thresh;

-/* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
+   /* first buffer to free from S/W ring is at index
+* tx_next_dd - (tx_rs_thresh-1)
+*/
txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];

if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
+   struct rte_mempool *mp = txep[0].mbuf->pool;
+   struct rte_mempool_cache *cache = rte_mempool_default_cache(mp, 
rte_lcore_id());
+   void **cache_objs;
+
+   if (unlikely(!cache))
+   goto fallback;
+
+   cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);
+   if (unlikely(!cache_objs))
+   goto fallback;
+
for (i = 0; i < n; i++) {
-   free[i] = txep[i].mbuf;
+   cache_objs[i] = txep[i].mbuf;
/* no need to reset txep[i].mbuf in vector path */
}
-   rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
goto done;
+
+fallback:
+   for (i = 0; i < n; i++)
+   free[i] = txep[i].mbuf;
+   rte_mempool_generic_put(mp, (void **)free, n, cache);
+   goto done;
+
}

m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
--
2.25.1

RE: [EXT] [PATCH] app/crypto-perf: fix socket ID default value

[Akhil Goyal]

> Due to recent changes to the default device socket ID,
> before being used as an index for session mempool list,
> the socket ID should be set to 0 if unknown (-1).
> 
> Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by
> default")
> Cc: olivier.m...@6wind.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Ciara Power 
> ---
>  app/test-crypto-perf/main.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
> index af5bd0d23b..b74e7ba118 100644
> --- a/app/test-crypto-perf/main.c
> +++ b/app/test-crypto-perf/main.c
> @@ -651,6 +651,11 @@ main(int argc, char **argv)
>   cdev_id = enabled_cdevs[cdev_index];
> 
>   uint8_t socket_id = rte_cryptodev_socket_id(cdev_id);
> + /* range check the socket_id, negative values become big
> +  * positive ones due to use of unsigned value
> +  */
> + if (socket_id >= RTE_MAX_NUMA_NODES)
> + socket_id = 0;

Shouldn't we make this as
int socket_id = rte_cryptodev_socket_id(cdev_id);
if (socket_id == SOCKET_ID_ANY)
socket_id = 0;  /* Use the first socket if SOCKET_ID_ANY is returned. */

Since rte_cryptodev_socket_id returns signed value,
the application should not typecast it to unsigned value and then check for max 
value.
Same comment for the ipsec-secgw patch.

RE: [PATCH] crypto/qat: fix legacy sm4 ecb capability

[Akhil Goyal]

> > Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
> >
> > Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> > included as legacy, to be disabled by default.
> >
> > Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> >
> > Signed-off-by: Ciara Power 
> > ---
> >  drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Tested-by: Saoirse O'Donovan 

Applied to dpdk-next-crypto

Thanks.

RE: [EXT] Re: [PATCH v2] cryptodev: fix device socket ID type

[Akhil Goyal]

> 05/07/2023 11:36, Ciara Power пишет:
> > The socket ID field for a cryptodev device data was unsigned int.
> > Due to recent changes to the default device socket ID,
> > this caused an issue when the socket ID was unknown and set to -1.
> > The device socket ID wrapped around to 255,
> > and caused errors when allocating memory.
> >
> > Changing this field type to int fixes the issue, as it now takes the
> > correct -1 value.
> >
> > Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by
> default")
> > Cc: olivier.m...@6wind.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ciara Power 
> > Acked-by: Morten Brørup 
> > Acked-by: Kai Ji 
> >
> Acked-by: Konstantin Ananyev 
Acked-by: Akhil Goyal 
Applied to dpdk-next-crypto
Thanks.

RE: [PATCH] doc: support IPsec Multi-buffer lib v1.4

[Akhil Goyal]

> > Subject: [PATCH] doc: support IPsec Multi-buffer lib v1.4
> >
> > Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and
> > CHACHA20_POLY1305 PMD documentation guides with information about
> > the latest Intel IPsec Multi-buffer library supported.
> >
> > Signed-off-by: Ciara Power 
> Acked-by: Brian Dooley 
Applied to dpdk-next-crypto
Thanks.

Re: [PATCH] ice: fix build error on 32bit configure

[Luca Boccassi]

On Wed, 5 Jul 2023 at 08:21, Yiding Zhou  wrote:
>
> Replace 'rte_memcpy' with 'memcpy' like other PMD code to avoid errors when
> compiling with GCC-12 on 32-bit configure.
>
> Compiler reports the follow error:
>
> error: array subscript 8 is outside array bounds of "struct rte_mbuf *[32]"
> [-Werror=array-bounds]
>
> Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yiding Zhou 
> ---
>  drivers/net/ice/ice_rxtx_vec_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_rxtx_vec_common.h 
> b/drivers/net/ice/ice_rxtx_vec_common.h
> index eec6ea2134..55840cf170 100644
> --- a/drivers/net/ice/ice_rxtx_vec_common.h
> +++ b/drivers/net/ice/ice_rxtx_vec_common.h
> @@ -72,7 +72,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct 
> rte_mbuf **rx_bufs,
> /* save the partial packet for next time */
> rxq->pkt_first_seg = start;
> rxq->pkt_last_seg = end;
> -   rte_memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
> +   memcpy(rx_bufs, pkts, pkt_idx * (sizeof(*pkts)));
> return pkt_idx;
>  }

Tested-by: Luca Boccassi 

Re: [PATCH v3] dts: replace pexpect with fabric

[Jeremy Spewock]

Tested-by: Jeremy Spewock 

On Wed, Jun 21, 2023 at 2:33 PM Jeremy Spewock  wrote:

> Acked-by: Jeremy Spewock 
>
> On Fri, Jun 9, 2023 at 5:46 AM Juraj Linkeš 
> wrote:
>
>> Pexpect is not a dedicated SSH connection library while Fabric is. With
>> Fabric, all SSH-related logic is provided and we can just focus on
>> what's DTS specific.
>>
>> Signed-off-by: Juraj Linkeš 
>> ---
>>
>> Notes:
>> v3: updated passwordless sudo setup on Linux
>>
>>  doc/guides/tools/dts.rst  |  29 +-
>>  dts/conf.yaml |   2 +-
>>  dts/framework/exception.py|  10 +-
>>  dts/framework/remote_session/linux_session.py |  31 +-
>>  dts/framework/remote_session/os_session.py|  51 +++-
>>  dts/framework/remote_session/posix_session.py |  48 +--
>>  .../remote_session/remote/remote_session.py   |  35 ++-
>>  .../remote_session/remote/ssh_session.py  | 287 ++
>>  dts/framework/testbed_model/sut_node.py   |  12 +-
>>  dts/framework/utils.py|   9 -
>>  dts/poetry.lock   | 161 --
>>  dts/pyproject.toml|   2 +-
>>  12 files changed, 376 insertions(+), 301 deletions(-)
>>
>> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
>> index ebd6dceb6a..c7b31623e4 100644
>> --- a/doc/guides/tools/dts.rst
>> +++ b/doc/guides/tools/dts.rst
>> @@ -95,9 +95,14 @@ Setting up DTS environment
>>
>>  #. **SSH Connection**
>>
>> -   DTS uses Python pexpect for SSH connections between DTS environment
>> and the other hosts.
>> -   The pexpect implementation is a wrapper around the ssh command in the
>> DTS environment.
>> -   This means it'll use the SSH agent providing the ssh command and its
>> keys.
>> +   DTS uses the Fabric Python library for SSH connections between DTS
>> environment
>> +   and the other hosts.
>> +   The authentication method used is pubkey authentication.
>> +   Fabric tries to use a passed key/certificate,
>> +   then any key it can with through an SSH agent,
>> +   then any "id_rsa", "id_dsa" or "id_ecdsa" key discoverable in
>> ``~/.ssh/``
>> +   (with any matching OpenSSH-style certificates).
>> +   DTS doesn't pass any keys, so Fabric tries to use the other two
>> methods.
>>
>>
>>  Setting up System Under Test
>> @@ -132,6 +137,21 @@ There are two areas that need to be set up on a
>> System Under Test:
>>   It's possible to use the hugepage configuration already present on
>> the SUT.
>>   If you wish to do so, don't specify the hugepage configuration in
>> the DTS config file.
>>
>> +#. **User with administrator privileges**
>> +
>> +.. _sut_admin_user:
>> +
>> +   DTS needs administrator privileges to run DPDK applications (such as
>> testpmd) on the SUT.
>> +   The SUT user must be able run commands in privileged mode without
>> asking for password.
>> +   On most Linux distributions, it's a matter of setting up passwordless
>> sudo:
>> +
>> +   #. Run ``sudo visudo`` and check that it contains ``%sudo
>>  ALL=(ALL:ALL) NOPASSWD:ALL``.
>> +
>> +   #. Add the SUT user to the sudo group with:
>> +
>> +   .. code-block:: console
>> +
>> +  sudo usermod -aG sudo 
>>
>>  Running DTS
>>  ---
>> @@ -151,7 +171,8 @@ which is a template that illustrates what can be
>> configured in DTS:
>>   :start-at: executions:
>>
>>
>> -The user must be root or any other user with prompt starting with ``#``.
>> +The user must have :ref:`administrator privileges `
>> +which don't require password authentication.
>>  The other fields are mostly self-explanatory
>>  and documented in more detail in
>> ``dts/framework/config/conf_yaml_schema.json``.
>>
>> diff --git a/dts/conf.yaml b/dts/conf.yaml
>> index a9bd8a3ecf..129801d87c 100644
>> --- a/dts/conf.yaml
>> +++ b/dts/conf.yaml
>> @@ -16,7 +16,7 @@ executions:
>>  nodes:
>>- name: "SUT 1"
>>  hostname: sut1.change.me.localhost
>> -user: root
>> +user: dtsuser
>>  arch: x86_64
>>  os: linux
>>  lcores: ""
>> diff --git a/dts/framework/exception.py b/dts/framework/exception.py
>> index ca353d98fc..44ff4e979a 100644
>> --- a/dts/framework/exception.py
>> +++ b/dts/framework/exception.py
>> @@ -62,13 +62,19 @@ class SSHConnectionError(DTSError):
>>  """
>>
>>  host: str
>> +errors: list[str]
>>  severity: ClassVar[ErrorSeverity] = ErrorSeverity.SSH_ERR
>>
>> -def __init__(self, host: str):
>> +def __init__(self, host: str, errors: list[str] | None = None):
>>  self.host = host
>> +self.errors = [] if errors is None else errors
>>
>>  def __str__(self) -> str:
>> -return f"Error trying to connect with {self.host}"
>> +message = f"Error trying to connect with {self.host}."
>> +if self.errors:
>> +message += f" Errors encountered while retrying: {',
>> '.join(self.errors)}"
>> +
>> +return message
>>
>>
>>  class SSHSessionDeadError(DTSError):
>> diff --git a/dts/

[PATCH v7 0/5] Logging timetamp and related patches

[Stephen Hemminger]

Patchset that includes:
  - unified code for more of log argument handling
  - fix for duplicate option errors
  - timestamp option for logging

v7
  - consolidate patches
  - fix windows to have same getopt args as Linux and FreeBSD

Stephen Hemminger (5):
  windows: make getopt functions have const properties
  eal: fix help message for syslog option
  eal: unify logging code
  eal: allow user to set default log stream before init
  eal: add option to put timestamp on console output

 app/dumpcap/main.c|   3 +
 app/pdump/main.c  |   3 +
 app/proc-info/main.c  |   3 +
 app/test/test_eal_flags.c |   9 ++
 .../freebsd_gsg/freebsd_eal_parameters.rst|  32 +
 doc/guides/linux_gsg/linux_eal_parameters.rst |   5 +
 lib/eal/common/eal_common_log.c   |  55 +
 lib/eal/common/eal_common_options.c   |   8 +-
 lib/eal/common/eal_internal_cfg.h |   3 +
 lib/eal/common/eal_log.h  |   6 +
 lib/eal/common/eal_options.h  |   2 +
 lib/eal/freebsd/eal.c |  55 ++---
 lib/eal/linux/eal.c   |  46 +---
 lib/eal/linux/eal_log.c   |  61 --
 lib/eal/linux/meson.build |   1 -
 lib/eal/unix/eal_log.c| 111 ++
 lib/eal/unix/meson.build  |   1 +
 lib/eal/windows/eal.c |  36 +-
 lib/eal/windows/getopt.c  |  23 ++--
 lib/eal/windows/include/getopt.h  |   8 +-
 20 files changed, 275 insertions(+), 196 deletions(-)
 delete mode 100644 lib/eal/linux/eal_log.c
 create mode 100644 lib/eal/unix/eal_log.c

-- 
2.39.2

[PATCH v7 1/5] windows: make getopt functions have const properties

[Stephen Hemminger]

This aligns getopt, getopt_long, etc to have the same const
attributes as Linux and FreeBSD. The changes are derived from
the FreeBSD version of getopt_long.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/windows/getopt.c | 23 ---
 lib/eal/windows/include/getopt.h |  8 
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/lib/eal/windows/getopt.c b/lib/eal/windows/getopt.c
index a1f51c6c2318..50ff71b9300d 100644
--- a/lib/eal/windows/getopt.c
+++ b/lib/eal/windows/getopt.c
@@ -20,7 +20,7 @@
 #include 
 #include 
 
-const char*optarg; /* argument associated with option */
+char*optarg;   /* argument associated with option */
 intopterr = 1; /* if error message should be printed */
 intoptind = 1; /* index into parent argv vector */
 intoptopt = '?';   /* character checked for validity */
@@ -39,9 +39,9 @@ static void pass(const char *a) {(void) a; }
 #defineBADARG  ((*options == ':') ? (int)':' : (int)'?')
 #defineINORDER 1
 
-#defineEMSG""
+static char EMSG[] = "";
 
-static const char *place = EMSG; /* option letter processing */
+static char *place = EMSG; /* option letter processing */
 
 /* XXX: set optreset to 1 rather than these two */
 static int nonopt_start = -1; /* first non option argument (for permute) */
@@ -80,7 +80,7 @@ gcd(int a, int b)
  */
 static void
 permute_args(int panonopt_start, int panonopt_end, int opt_end,
-   char **nargv)
+   char * const *nargv)
 {
int cstart, cyclelen, i, j, ncycle, nnonopts, nopts, pos;
char *swap;
@@ -101,11 +101,12 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
pos -= nnonopts;
else
pos += nopts;
+
swap = nargv[pos];
/* LINTED const cast */
-   ((char **) nargv)[pos] = nargv[cstart];
+   ((char **)(uintptr_t)nargv)[pos] = nargv[cstart];
/* LINTED const cast */
-   ((char **)nargv)[cstart] = swap;
+   ((char **)(uintptr_t)nargv)[cstart] = swap;
}
}
 }
@@ -116,7 +117,7 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
  * Returns -1 if short_too is set and the option does not match long_options.
  */
 static int
-parse_long_options(char **nargv, const char *options,
+parse_long_options(char * const *nargv, const char *options,
const struct option *long_options, int *idx, int short_too)
 {
const char *current_argv;
@@ -236,7 +237,7 @@ parse_long_options(char **nargv, const char *options,
  * Parse argc/argv argument vector.  Called by user level routines.
  */
 static int
-getopt_internal(int nargc, char **nargv, const char *options,
+getopt_internal(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx, int flags)
 {
char *oli;  /* option letter list index */
@@ -434,7 +435,7 @@ getopt_internal(int nargc, char **nargv, const char 
*options,
  * Parse argc/argv argument vector.
  */
 int
-getopt(int nargc, char *nargv[], const char *options)
+getopt(int nargc, char *const nargv[], const char *options)
 {
return getopt_internal(nargc, nargv, options, NULL, NULL,
   FLAG_PERMUTE);
@@ -445,7 +446,7 @@ getopt(int nargc, char *nargv[], const char *options)
  * Parse argc/argv argument vector.
  */
 int
-getopt_long(int nargc, char *nargv[], const char *options,
+getopt_long(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
@@ -458,7 +459,7 @@ getopt_long(int nargc, char *nargv[], const char *options,
  * Parse argc/argv argument vector.
  */
 int
-getopt_long_only(int nargc, char *nargv[], const char *options,
+getopt_long_only(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
diff --git a/lib/eal/windows/include/getopt.h b/lib/eal/windows/include/getopt.h
index 6f57af454b17..e4cf6873cb0c 100644
--- a/lib/eal/windows/include/getopt.h
+++ b/lib/eal/windows/include/getopt.h
@@ -44,7 +44,7 @@
 
 
 /** argument to current option, or NULL if it has none */
-extern const char *optarg;
+extern char *optarg;
 /** Current position in arg string.  Starts from 1.
  * Setting to 0 resets state.
  */
@@ -80,14 +80,14 @@ struct option {
 };
 
 /** Compat: getopt */
-int getopt(int argc, char *argv[], const char *options);
+int getopt(int argc, char *const argv[], const char *options);
 
 /** Compat: getopt_long */
-int getopt_long(int argc, char *argv[], const char *options,
+int getopt_long(int argc, char *const argv[], const char *options,
const struct option *longopts, int *longindex);
 
 /** Co

[PATCH v7 2/5] eal: fix help message for syslog option

[Stephen Hemminger]

The --syslog flag takes facility argument.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 03059336987d..005da4d12001 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -2193,7 +2193,7 @@ eal_common_usage(void)
   "  --"OPT_VMWARE_TSC_MAP"Use VMware TSC map instead of 
native RDTSC\n"
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
 #ifndef RTE_EXEC_ENV_WINDOWS
-  "  --"OPT_SYSLOG"Set syslog facility\n"
+  "  --"OPT_SYSLOG"= Set syslog facility\n"
 #endif
   "  --"OPT_LOG_LEVEL"= Set global log level\n"
   "  --"OPT_LOG_LEVEL"=:\n"
-- 
2.39.2

[PATCH v7 3/5] eal: unify logging code

[Stephen Hemminger]

FreeBSD logging code was not using syslog and did not have
the same options as Linux. Use a common set of functions for that.

Pre-parsing for log level is common to all OS's.

Now the pre-scan can return an error.
A bad argument give to --log-level option was given the
code would keep going.

Use opterr to fix duplicate error message on bad option.

Signed-off-by: Stephen Hemminger 
---
 .../freebsd_gsg/freebsd_eal_parameters.rst| 27 +
 lib/eal/common/eal_common_log.c   | 49 +
 lib/eal/common/eal_log.h  |  5 ++
 lib/eal/freebsd/eal.c | 55 ---
 lib/eal/linux/eal.c   | 46 ++--
 lib/eal/linux/meson.build |  1 -
 lib/eal/{linux => unix}/eal_log.c | 11 
 lib/eal/unix/meson.build  |  1 +
 lib/eal/windows/eal.c | 36 +---
 9 files changed, 112 insertions(+), 119 deletions(-)
 rename lib/eal/{linux => unix}/eal_log.c (76%)

diff --git a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst 
b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
index fba467a2ce92..9270d9fa3bfc 100644
--- a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
+++ b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
@@ -18,3 +18,30 @@ FreeBSD-specific EAL parameters
 ---
 
 There are currently no FreeBSD-specific EAL command-line parameters available.
+
+Other options
+~
+
+*   ``--syslog ``
+
+Set syslog facility. Valid syslog facilities are::
+
+auth
+cron
+daemon
+ftp
+kern
+lpr
+mail
+news
+syslog
+user
+uucp
+local0
+local1
+local2
+local3
+local4
+local5
+local6
+local7
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index bd7b188ceb4a..1b2080e8ef04 100644
--- a/lib/eal/common/eal_common_log.c
+++ b/lib/eal/common/eal_common_log.c
@@ -2,6 +2,7 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
+#include 
 #include 
 #include 
 #include 
@@ -16,6 +17,8 @@
 #include 
 
 #include "eal_log.h"
+#include "eal_internal_cfg.h"
+#include "eal_options.h"
 #include "eal_private.h"
 
 struct rte_log_dynamic_type {
@@ -223,6 +226,52 @@ log_save_level(uint32_t priority, const char *regex, const 
char *pattern)
return -1;
 }
 
+
+/* Parse the all arguments looking for --log-level */
+int
+eal_log_level_parse(int argc, char * const argv[])
+{
+   struct internal_config *internal_conf = 
eal_get_internal_configuration();
+   int option_index, opt;
+   const int old_optind = optind;
+   const int old_optopt = optopt;
+   const int old_opterr = opterr;
+   char *old_optarg = optarg;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   const int old_optreset = optreset;
+   optreset = 1;
+#endif
+
+   optind = 1;
+   opterr = 0;
+
+   while ((opt = getopt_long(argc, argv, eal_short_options,
+ eal_long_options, &option_index)) != EOF) {
+
+   switch (opt) {
+   case OPT_LOG_LEVEL_NUM:
+   if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
+   return -1;
+   break;
+   case '?':
+   /* getopt is not happy, stop right now */
+   goto out;
+   default:
+   continue;
+   }
+   }
+out:
+   /* restore getopt lib */
+   optind = old_optind;
+   optopt = old_optopt;
+   optarg = old_optarg;
+   opterr = old_opterr;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   optreset = old_optreset;
+#endif
+   return 0;
+}
+
 int
 eal_log_save_regexp(const char *regex, uint32_t level)
 {
diff --git a/lib/eal/common/eal_log.h b/lib/eal/common/eal_log.h
index c784fa604389..31dc489350f6 100644
--- a/lib/eal/common/eal_log.h
+++ b/lib/eal/common/eal_log.h
@@ -13,6 +13,11 @@
  */
 int eal_log_init(const char *id, int facility);
 
+/*
+ * Scan command line args for log settings.
+ */
+int eal_log_level_parse(int argc, char * const argv[]);
+
 /*
  * Determine where log data is written when no call to rte_openlog_stream.
  */
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 7008303e112a..bb9a2b1653d9 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -52,6 +52,7 @@
 #include "eal_hugepages.h"
 #include "eal_options.h"
 #include "eal_memcfg.h"
+#include "eal_log.h"
 #include "eal_trace.h"
 
 #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
@@ -363,48 +364,6 @@ eal_get_hugepage_mem_size(void)
return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
 }
 
-/* Parse the arguments for --log-level only */
-static void
-eal_log_level_parse(int argc, char **argv)
-{
-   int opt;
-   char **argvopt;
-   int option_i

[PATCH v7 4/5] eal: allow user to set default log stream before init

[Stephen Hemminger]

It is useful for application to be able to set the default log
stream before call rte_eal_init(). This makes all messages go
to the new default.

For example, to skip using syslog; just doing
rte_openlog_stream(stderr);

There is no reason for helper command line applications to clutter
syslog with messages.

Signed-off-by: Stephen Hemminger 
---
 app/dumpcap/main.c  | 3 +++
 app/pdump/main.c| 3 +++
 app/proc-info/main.c| 3 +++
 lib/eal/common/eal_common_log.c | 6 ++
 lib/eal/common/eal_log.h| 1 +
 lib/eal/unix/eal_log.c  | 4 
 6 files changed, 20 insertions(+)

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 64294bbfb3e6..bf31eef13cf4 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -639,6 +639,9 @@ static void dpdk_init(void)
eal_argv[i++] = strdup(file_prefix);
}
 
+   /* keep any logging away from syslog. */
+   rte_openlog_stream(stderr);
+
if (rte_eal_init(eal_argc, eal_argv) < 0)
rte_exit(EXIT_FAILURE, "EAL init failed: is primary process 
running?\n");
 }
diff --git a/app/pdump/main.c b/app/pdump/main.c
index c94606275b28..82c67350e4ab 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -989,6 +989,9 @@ main(int argc, char **argv)
 
argc += 2;
 
+   /* keep any logging away from syslog. */
+   rte_openlog_stream(stderr);
+
diag = rte_eal_init(argc, argp);
if (diag < 0)
rte_panic("Cannot init EAL\n");
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 53e852a07c14..371b1f382d66 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1774,6 +1774,9 @@ main(int argc, char **argv)
 
argc += 4;
 
+   /* keep any logging away from syslog. */
+   rte_openlog_stream(stderr);
+
ret = rte_eal_init(argc, argp);
if (ret < 0)
rte_panic("Cannot init EAL\n");
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index 1b2080e8ef04..1533ee871f47 100644
--- a/lib/eal/common/eal_common_log.c
+++ b/lib/eal/common/eal_common_log.c
@@ -584,6 +584,12 @@ eal_log_set_default(FILE *default_log)
 #endif
 }
 
+FILE *
+eal_log_get_default(void)
+{
+   return default_log_stream;
+}
+
 /*
  * Called by eal_cleanup
  */
diff --git a/lib/eal/common/eal_log.h b/lib/eal/common/eal_log.h
index 31dc489350f6..268c2a264382 100644
--- a/lib/eal/common/eal_log.h
+++ b/lib/eal/common/eal_log.h
@@ -22,6 +22,7 @@ int eal_log_level_parse(int argc, char * const argv[]);
  * Determine where log data is written when no call to rte_openlog_stream.
  */
 void eal_log_set_default(FILE *default_log);
+FILE *eal_log_get_default(void);
 
 /*
  * Save a log option for later.
diff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c
index 85d817c2d31e..e66bcc68d07f 100644
--- a/lib/eal/unix/eal_log.c
+++ b/lib/eal/unix/eal_log.c
@@ -60,6 +60,10 @@ eal_log_init(const char *id, int facility)
 {
FILE *log_stream;
 
+   /* has user has already setup a log stream */
+   if (eal_log_get_default())
+   return 0;
+
log_stream = fopencookie(NULL, "w+", console_log_func);
if (log_stream == NULL)
return -1;
-- 
2.39.2

[PATCH v7 5/5] eal: add option to put timestamp on console output

[Stephen Hemminger]

When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing. The timestamp format is chosen to look
like the default Linux dmesg timestamp.

The first few lines are not timestamped because the flag is stored
in internal configuration which is stored in shared memory
which is not setup up until a little later in startup process.

This logging skips the unnecessary step of going through stdio,
which makes it more robust against being called in interrupt
handlers etc.

Example:
$ dpdk-testpmd --log-timestamp -- -i
EAL: Detected CPU lcores: 16
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
[   0.112264] testpmd: No probed ethernet devices
Interactive-mode selected
[   0.184573] testpmd: create a new mbuf pool : n=163456, 
size=2176, socket=0
[   0.184612] testpmd: preferred mempool ops selected: ring_mp_mc

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c |  9 
 .../freebsd_gsg/freebsd_eal_parameters.rst|  5 +++
 doc/guides/linux_gsg/linux_eal_parameters.rst |  5 +++
 lib/eal/common/eal_common_options.c   |  6 +++
 lib/eal/common/eal_internal_cfg.h |  3 ++
 lib/eal/common/eal_options.h  |  2 +
 lib/eal/unix/eal_log.c| 45 ---
 7 files changed, 70 insertions(+), 5 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d2b91e20750e..57637728d811 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1055,6 +1055,10 @@ test_misc_flags(void)
const char * const argv22[] = {prgname, prefix, mp_flag,
   "--huge-worker-stack=512"};
 
+   /* Try running with --log-timestamp */
+   const char * const argv23[] = {prgname, prefix, mp_flag,
+  "--log-timestamp" };
+
/* run all tests also applicable to FreeBSD first */
 
if (launch_proc(argv0) == 0) {
@@ -1162,6 +1166,11 @@ test_misc_flags(void)
printf("Error - process did not run ok with 
--huge-worker-stack=size parameter\n");
goto fail;
}
+   if (launch_proc(argv23) != 0) {
+   printf("Error - process did not run ok with --log-timestamp 
parameter\n");
+   goto fail;
+   }
+
 
rmdir(hugepath_dir3);
rmdir(hugepath_dir2);
diff --git a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst 
b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
index 9270d9fa3bfc..99cff10e963c 100644
--- a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
+++ b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst
@@ -45,3 +45,8 @@ Other options
 local5
 local6
 local7
+
+*   ``--log-timestamp``
+
+Add a timestamp of seconds and microseconds to each log message
+written to standard output.
diff --git a/doc/guides/linux_gsg/linux_eal_parameters.rst 
b/doc/guides/linux_gsg/linux_eal_parameters.rst
index ea8f38139119..719ca6851625 100644
--- a/doc/guides/linux_gsg/linux_eal_parameters.rst
+++ b/doc/guides/linux_gsg/linux_eal_parameters.rst
@@ -135,3 +135,8 @@ Other options
 local5
 local6
 local7
+
+*   ``--log-timestamp``
+
+Add a timestamp of seconds and microseconds to each log message
+written to standard output.
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 005da4d12001..67fe6efb4526 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -76,6 +76,7 @@ eal_long_options[] = {
{OPT_IOVA_MODE, 1, NULL, OPT_IOVA_MODE_NUM},
{OPT_LCORES,1, NULL, OPT_LCORES_NUM   },
{OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM},
+   {OPT_LOG_TIMESTAMP, 0, NULL, OPT_LOG_TIMESTAMP_NUM},
{OPT_TRACE, 1, NULL, OPT_TRACE_NUM},
{OPT_TRACE_DIR, 1, NULL, OPT_TRACE_DIR_NUM},
{OPT_TRACE_BUF_SIZE,1, NULL, OPT_TRACE_BUF_SIZE_NUM   },
@@ -1835,6 +1836,10 @@ eal_parse_common_option(int opt, const char *optarg,
}
 
 #ifndef RTE_EXEC_ENV_WINDOWS
+   case OPT_LOG_TIMESTAMP_NUM:
+   conf->log_timestamp = 1;
+   break;
+
case OPT_TRACE_NUM: {
if (eal_trace_args_save(optarg) < 0) {
RTE_LOG(ERR, EAL, "invalid parameters for --"
@@ -2194,6 +2199,7 @@ eal_common_usage(void)
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
 #ifndef RTE_EXEC_ENV_WINDOWS
   "  --"OPT_SYSLOG"= Set syslog facility\n"
+  "  --"OPT_LOG_TIMESTAMP" Timestamp log output\n"
 #endif
   "  --"OPT_LOG_LEVEL"= Se

[PATCH] MAINTAINERS: remove one maintainer from procinfo

[Stephen Hemminger]

Mail to marayam.tah...@intel.com is bouncing.
Presume no longer at Intel.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b5adba69d82d..d688b047b402 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1797,7 +1797,6 @@ F: doc/guides/tools/img/eventdev_*
 F: app/test/test_event_ring.c
 
 Procinfo tool
-M: Maryam Tahhan 
 M: Reshma Pattan 
 F: app/proc-info/
 F: doc/guides/tools/proc_info.rst
-- 
2.39.2

Re: [PATCH] doc: relax requirement on commit messages of security fixes

[Stephen Hemminger]

On Fri, 31 Mar 2023 12:37:40 +0200
Maxime Coquelin  wrote:

> Indeed!
> 
> On 3/31/23 12:34, Thomas Monjalon wrote:
> > We missed this patch, there was no comment.
> > Please review.
> > 
> > 10/03/2022 18:59, luca.bocca...@gmail.com:  
> >> From: Luca Boccassi 
> >>
> >> Allow more flexibility with embargo lifting by not requiring
> >> mentions of CVEs in commit messages if the lift date allows
> >> it.
> >>
> >> Signed-off-by: Luca Boccassi 
> >> ---
> >> -The CVE id and the bug id must be referenced in the patch.
> >> +The CVE id and the bug id must be referenced in the patch if there is no
> >> +embargo, or if there is an embargo, but it will be lifted when the release
> >> +including the patch is published. If the embargo is going to be lifted 
> >> after the
> >> +release, then the CVE and bug ids must be omitted from the commit 
> >> message.  
> > 
> >   
> 
> Reviewed-by: Maxime Coquelin 

Acked-by: Stephen Hemminger 

Re: [PATCH v2] eal/linux: enable the hugepage mem dump

[Stephen Hemminger]

On Wed, 6 Apr 2022 02:14:46 +0300
Dmitry Kozlyuk  wrote:

> > 
> > Don't merge this patch as is please; it would cause a lot of pain
> > in a cloud environment.
> > 
> > In our environment core dumps are collected (via systemd) and uploaded
> > to a central server. With this kind of change the processing would get
> > overloaded with multi-gigabyte core dump size. Probably couldn't even
> > save a core dump on these kind of smart nics.
> > 
> > 
> > This needs to be optional (from command line) and default to the current
> > behavior (not dumping huge pages).  
> 
> Maybe expose eal_mem_set_dump() as rte_mem_set_dump()?
> This would allow to implement the feature easily using memory callbacks.
> Better, one can enable hugepages to dump selectively:
> for example, dump some interesting hash tables but skip rings and mempools.

As was mentioned in thread core_dump_filter will also control these.
So it won't impact users who do not enable it.
Since the granularity is a the page level, it doesn't make sense
to try and be selective for hash tables, rings, mempools etc.

Looks good as is, though it might need a rebase.

Acked-by: Stephen Hemminger 

Registration Reminder & CFP Call - DPDK Dublin Summit, Sep. 2023

[Nathan Southern]

Good evening DPDK Community,

September 12-13, 2023 we will have the DPDK Summit at the Gibson Hotel in
Point Square in Dublin. Registration and attendance for this event are
*free!*

Our Call for Speakers is just wrapping up - the deadline is this Friday,
Jul. 7th at 11:59 PDT. If y
Please put your submissions here if you wish to be considered for a talk:

https://linuxfoundation.smapply.io/prog/dpdk_summit_2023_/

In addition to this, if you have not already registered for the event,
please do so now. *You may do so here:*

https://events.linuxfoundation.org/dpdk-userspace-summit/

I will point out that due to a legal technicality the Gibson Hotel isn't
yet referenced on the above link, but it has been confirmed and the event
will be held there.

Any questions let us know.

Thanks,

Nathan

Nathan C. Southern, Project Coordinator

Data Plane Development Kit

The Linux Foundation

248.835.4812 (mobile)

nsouth...@linuxfoundation.org

Re: [dpdk-dev] [PATCH v4 2/5] examples/multi_process: cleanup bus objects while terminating app

[Stephen Hemminger]

On Thu,  8 Oct 2020 21:00:44 +0530
rohit@nxp.com wrote:

> +static void
> +signal_handler(int signal)
> +{
> + if (signal == SIGINT)
> + rte_eal_cleanup();

NAK
Call rte_eal_cleanup in signal handler is not safe.

Need to set a flag and handle it in main code.

Re: [dpdk-dev] [PATCH v2 1/3] eal: add API for bus close

[Stephen Hemminger]

On Mon, 24 Aug 2020 13:54:12 +0530
rohit@nxp.com wrote:

> From: Rohit Raj 
> 
> As per the current code we have API for bus probe, but the
> bus close API is missing. This breaks the multi process
> scenarios as objects are not cleaned while terminating the
> secondary processes.
> 
> This patch adds a new API rte_bus_close() for cleanup of
> bus objects which were acquired during probe.
> 
> Signed-off-by: Rohit Raj 

This patchset got some good feedback but stalled at version 5.
Marking it as "Changes requested".
Please rebase and resubmit

[PATCH] mailmap: fix sorting

[Stephen Hemminger]

The mailmap file is supposed to be in sorted order,
but several entries are in the wrong place.

Signed-off-by: Stephen Hemminger 
---
 .mailmap | 334 +++
 1 file changed, 167 insertions(+), 167 deletions(-)

diff --git a/.mailmap b/.mailmap
index d200f363394d..1ec63cdbec86 100644
--- a/.mailmap
+++ b/.mailmap
@@ -2,8 +2,8 @@ Aakash Sasidharan 
 Aaro Koskinen 
 Aaron Campbell 
 Aaron Conole 
-Abdullah Ömer Yamaç 
 Abdullah Sevincer 
+Abdullah Ömer Yamaç 
 Abed Kamaluddin 
 Abhijit Gangurde 
 Abhijit Sinha 
@@ -40,6 +40,14 @@ Aleksandr Loktionov 
 Aleksandr Miloshenko 
 Aleksey Baulin 
 Aleksey Katargin 
+Alex Kiselev  
+Alex Marginean 
+Alex Markuze 
+Alex Porosanu 
+Alex Rosenbaum  
+Alex Vesker 
+Alex Wang 
+Alex Zelezniak 
 Alexander Bechikov 
 Alexander Belyakov 
 Alexander Chernavin 
@@ -50,19 +58,11 @@ Alexander Solganik 
 Alexander V Gutkin 
 Alexandre Ferrieux 
 Alexey Kardashevskiy 
-Alex Kiselev  
-Alex Marginean 
-Alex Markuze 
-Alex Porosanu 
-Alex Rosenbaum  
-Alex Vesker 
-Alex Wang 
-Alex Zelezniak 
 Alfredo Cardigliano 
 Ali Alnubani  
+Ali Volkan Atli 
 Alice Michael 
 Alin Rauta 
-Ali Volkan Atli 
 Allain Legacy 
 Allen Hubbe 
 Alok Makhariya 
@@ -71,26 +71,26 @@ Alvaro Karsz 
 Alvin Zhang 
 Aman Singh 
 Amaranath Somalapuram 
-Amine Kherbouche 
-Amin Tootoonchian 
 Ami Sabo 
+Amin Tootoonchian 
+Amine Kherbouche 
 Amit Bernstein 
 Amit Gupta 
 Amit Prakash Shukla 
 Amr Mokhtar 
 Amruta Zende 
 Amrutha Sampath 
-Ananda Sathyanarayana 
 Anand B Jyoti 
 Anand Rawat 
 Anand Sunkad 
+Ananda Sathyanarayana 
 Anatolii Gerasymenko 
 Anatoly Burakov 
 Anbarasan Murugesan 
 Anders Roxell 
+Andre Richter 
 Andrea Arcangeli 
 Andrea Grandi 
-Andre Richter 
 Andrew Boyer  
 Andrew Harvey 
 Andrew Jackson 
@@ -125,8 +125,8 @@ Arkadiusz Kusztal 
 Arnaud Fiorini 
 Arnon Warshavsky 
 Arshdeep Kaur 
-Artemii Morozov 
 Artem V. Andreev 
+Artemii Morozov 
 Artur Rojek 
 Artur Trybula 
 Artur Tyminski 
@@ -140,8 +140,8 @@ Ashish Sadanandan 
 Ashish Shah 
 Ashwin Sekhar T K  
 Asim Jamshed 
-Aviad Yehezkel 
 Avi Kivity 
+Aviad Yehezkel 
 Aws Ismail 
 Ayuj Verma  
 Balakrishna Bhamidipati 
@@ -153,16 +153,16 @@ Barak Enat 
 Barry Cao 
 Baruch Siach 
 Bassam Zaid AlKilani 
-Beilei Xing 
 Bei Sun 
-Benjamin Le Berre 
-Benjamin Mikailenko 
+Beilei Xing 
 Ben Magistro 
-Benoît Canet 
-Benoît Ganne 
 Ben Pfaff 
 Ben Shelton 
 Ben Walker 
+Benjamin Le Berre 
+Benjamin Mikailenko 
+Benoît Canet 
+Benoît Ganne 
 Bernard Iremonger 
 Bert van Leeuwen 
 Bhagyada Modali 
@@ -170,9 +170,9 @@ Bharat Mota 
 Bill Hong 
 Billy McFall 
 Billy O'Mahony 
-Bing Zhao   
 Bin Huang  
 Bin Zheng 
+Bing Zhao   
 Björn Töpel 
 Bo Chen 
 Boleslav Stankevich 
@@ -202,20 +202,20 @@ Chandubabu Namburu 
 Changchun Ouyang 
 Changpeng Liu 
 Changqing Wu 
-Chaoyong He 
 Chao Zhu  
+Chaoyong He 
 Charles Brett 
 Charles Myers 
 Charles Stoll 
 Chas Williams <3ch...@gmail.com>  
 Chenbo Xia 
+Cheng Jiang 
+Cheng Liu 
+Cheng Peng 
 Chengchang Tang  
 Chengfeng Ye 
 Chenghu Yao 
-Cheng Jiang 
 Chenglian Sun 
-Cheng Liu 
-Cheng Peng 
 Chengwen Feng 
 Chenmin Sun 
 Chenxu Di 
@@ -225,15 +225,15 @@ Chinh T Cao 
 Chintu Hetam 
 Choonho Son 
 Chris Metcalf 
+Chris Wright 
 Christian Ehrhardt 
 Christian Maciocco 
+Christoph Gysin 
 Christophe Fontaine 
 Christophe Grosse 
 Christopher Pau 
 Christopher Reder 
-Christoph Gysin 
 Christos Ricudis 
-Chris Wright 
 Chuanshe Zhang 
 Chuhong Yao 
 Chunsong Feng 
@@ -259,19 +259,19 @@ Damien Millescamps 
 Damjan Marion 
 Damodharam Ammepalli 
 Dan Aloni 
-Dana Vardi 
 Dan Gora 
-Daniele Di Proietto 
+Dan Nowlin 
+Dan Wei 
+Dana Vardi 
 Daniel Kaminsky 
 Daniel Kan 
 Daniel Martin Buckley 
 Daniel Mrzyglod 
 Daniel Shelepov 
 Daniel Verkamp 
-Dan Nowlin 
+Daniele Di Proietto 
 Danny Patel 
 Danny Zhou 
-Dan Wei 
 Dapeng Yu 
 Darek Stojaczyk 
 Daria Kolistratova 
@@ -286,7 +286,6 @@ David Binderman 
 David Bouyeure 
 David Christensen  
 David Coyle 
-Davide Caratti 
 David George 
 David Harton 
 David Hunt 
@@ -298,6 +297,7 @@ David Su 
 David Verbeiren 
 David Wilder 
 David Zeng 
+Davide Caratti 
 Dawid Gorecki 
 Dawid Jurczak 
 Dawid Lukwinski 
@@ -331,15 +331,15 @@ Dmitry Eremin-Solenikov 

 Dmitry Kozlyuk  
 Dmitry Vyukov 
 Dodji Seketeli 
+Don Provan 
+Don Wallwork 
 Donald Lee 
+Dong Wang 
+Dong Zhou  
 Dongdong Liu 
 Dongsheng Rong 
 Dongsu Han 
-Dong Wang 
 Dongyang Pan <197020...@qq.com>
-Dong Zhou  
-Don Provan 
-Don Wallwork 
 Doug Dziggel 
 Douglas Flint 
 Dr. David Alan Gilbert 
@@ -381,13 +381,13 @@ Evgeny Schemeilin 
 Fabio Pricoco 
 Fady Bader 
 Faicker Mo 
-Fangfang Wei 
-Fang TongHao 
 Fan Zhang  
+Fang TongHao 
+Fangfang Wei 
 Farah Smith 
 Fei Chen 
-Feifei Wang  
 Fei Qin 
+Feifei Wang  
 Fengnan Chang 
 Fengtian Guo 
 Ferdinand Thiessen 
@@ -401,9 +401,9 @@ Francesco Mancino 
 Francesco Santoro 
 Francis Kelly  
 Franck Lenormand 
-François-Frédéric Ozog 
 Frank Du 
 Frank Zhao 
+François-Frédéric Ozog 
 Frederico Cadete 
 Fredrik A Li

Re: [PATCH v1 1/2] bus/vdev: fix memory leak

[fengchengwen]

On 2023/7/5 17:25, Wenjun Wu wrote:
> In hotplug usecase, devargs will be allocated in secondary process
> in the function alloc_devargs. Since it will not be insert into the
> devarg_list, it will have no chance to be freed.
> 
> This patch adds additional memory free for device structure member devargs
> in the secondary process in rte_vdev_uninit.
> 
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Wenjun Wu 
> ---
>  drivers/bus/vdev/vdev.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 7974b27295..3f4e6a1b55 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -373,6 +373,11 @@ rte_vdev_uninit(const char *name)
>  
>   TAILQ_REMOVE(&vdev_device_list, dev, next);
>   rte_devargs_remove(dev->device.devargs);
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
> + dev->device.devargs != NULL) {

The prerequisite is that rte_vdev_init is invoked only in main process.

Suggest more general impl:
ret = rte_devargs_remove(dev->device.devargs);
if (ret != 0) {
rte_devargs_reset(dev->device.devargs);
free(dev->device.devargs);
}

> + rte_devargs_reset(dev->device.devargs);
> + free(dev->device.devargs);
> + }
>   free(dev);
>  
>  unlock:
> 

Re: [PATCH] mailmap: fix sorting

[Ferruh Yigit]

On 7/6/2023 12:45 AM, Stephen Hemminger wrote:
> The mailmap file is supposed to be in sorted order,
> but several entries are in the wrong place.
> 
> Signed-off-by: Stephen Hemminger 
>

Hi Stephen,

What are you using for sorting?

When I use 'sort' binary [1] I get only a few lines of diff,
but if I use vim ":sort" command I get a diff similar to this patch with
lots of change.

It looks like these two variant of 'sort' works differently.

At least vim ":sort l" gives same output with 'sort' binary, and vim
language config I have is "en_US.UTF-8", I assume 'sort' binary output
is based on this language setting.

Will it work to stick with 'sort' binary and fix a few lines of diff in
current file?


[1]
sort (GNU coreutils) 8.32

Re: [PATCH v1 2/2] examples/multi_process: fix memory leak

[fengchengwen]

On 2023/7/5 17:25, Wenjun Wu wrote:
> The device should be detached before quit, otherwise it will
> cause memory leak.

Which memory will leak?

For mp, if secondary process quit, it only needs to properly handle the memory 
shared with other process.

> 
> Fixes: 05f1d6842fc3 ("examples/multi_process: add hotplug sample")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Wenjun Wu 
> ---
>  examples/multi_process/hotplug_mp/commands.c | 22 
>  1 file changed, 22 insertions(+)
> 
> diff --git a/examples/multi_process/hotplug_mp/commands.c 
> b/examples/multi_process/hotplug_mp/commands.c
> index 88f44e00a0..143d57eeb6 100644
> --- a/examples/multi_process/hotplug_mp/commands.c
> +++ b/examples/multi_process/hotplug_mp/commands.c
> @@ -52,6 +52,28 @@ static void cmd_quit_parsed(__rte_unused void 
> *parsed_result,
>   struct cmdline *cl,
>   __rte_unused void *data)
>  {
> + uint16_t port_id;
> + char dev_name[RTE_DEV_NAME_MAX_LEN];
> + struct rte_devargs da;
> +
> + RTE_ETH_FOREACH_DEV(port_id) {
> + rte_eth_dev_get_name_by_port(port_id, dev_name);
> + memset(&da, 0, sizeof(da));
> +
> + if (rte_devargs_parsef(&da, "%s", dev_name)) {
> + cmdline_printf(cl,
> +"cannot parse devargs for device %s\n",
> +dev_name);
> + }
> + printf("detaching before quit...\n");
> + if (!rte_eal_hotplug_remove(rte_bus_name(da.bus), da.name))
> + cmdline_printf(cl, "detached device %s\n",
> + da.name);
> + else
> + cmdline_printf(cl, "failed to detach device %s\n",
> + da.name);
> +
> + }
>   cmdline_quit(cl);
>  }
>  
> 

RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue

[Lu, Wenzhuo]

Hi Qi,

> -Original Message-
> From: Zhang, Qi Z 
> Sent: Thursday, June 29, 2023 4:58 PM
> To: Jiale, SongX ; Lu, Wenzhuo
> ; dev@dpdk.org
> Cc: Lu, Wenzhuo 
> Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> 
> 
> 
> > -Original Message-
> > From: Jiale, SongX 
> > Sent: Wednesday, June 28, 2023 3:33 PM
> > To: Lu, Wenzhuo ; dev@dpdk.org
> > Cc: Lu, Wenzhuo 
> > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> >
> > > -Original Message-
> > > From: Wenzhuo Lu 
> > > Sent: Wednesday, June 21, 2023 9:15 AM
> > > To: dev@dpdk.org
> > > Cc: Lu, Wenzhuo 
> > > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> > >
> > > The SCTP tunnel packets cannot be forwarded in AVX2 mode.
> > >
> > > As 2 features are developed in parallel, 5712bf9d6e14
> > > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact
> > > of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on
> AVX512").
> > > So, the wrong TX path is selected.
> > >
> > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> > >
> > > Signed-off-by: Wenzhuo Lu 
> > > ---
> > Tested-by: Song Jiale 
> 
> Applied to dpdk-next-net-intel.
> 
> Thanks
> Qi
Sorry, this fix is not good because of some misunderstanding. Would you like 
helping to revert it? We'll send a new one to fix the issue. Thanks.

RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue

[Zhang, Qi Z]

> -Original Message-
> From: Lu, Wenzhuo 
> Sent: Thursday, July 6, 2023 9:27 AM
> To: Zhang, Qi Z ; Jiale, SongX ;
> dev@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> 
> Hi Qi,
> 
> > -Original Message-
> > From: Zhang, Qi Z 
> > Sent: Thursday, June 29, 2023 4:58 PM
> > To: Jiale, SongX ; Lu, Wenzhuo
> > ; dev@dpdk.org
> > Cc: Lu, Wenzhuo 
> > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> >
> >
> >
> > > -Original Message-
> > > From: Jiale, SongX 
> > > Sent: Wednesday, June 28, 2023 3:33 PM
> > > To: Lu, Wenzhuo ; dev@dpdk.org
> > > Cc: Lu, Wenzhuo 
> > > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding
> > > issue
> > >
> > > > -Original Message-
> > > > From: Wenzhuo Lu 
> > > > Sent: Wednesday, June 21, 2023 9:15 AM
> > > > To: dev@dpdk.org
> > > > Cc: Lu, Wenzhuo 
> > > > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue
> > > >
> > > > The SCTP tunnel packets cannot be forwarded in AVX2 mode.
> > > >
> > > > As 2 features are developed in parallel, 5712bf9d6e14
> > > > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact
> > > > of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on
> > AVX512").
> > > > So, the wrong TX path is selected.
> > > >
> > > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> > > >
> > > > Signed-off-by: Wenzhuo Lu 
> > > > ---
> > > Tested-by: Song Jiale 
> >
> > Applied to dpdk-next-net-intel.
> >
> > Thanks
> > Qi
> Sorry, this fix is not good because of some misunderstanding. Would you like
> helping to revert it? We'll send a new one to fix the issue. Thanks.

OK, has the patch has not been merged in main branch, I have reverted in 
dpdk-next-net-intel.

Re: [PATCH] mailmap: fix sorting

[Stephen Hemminger]

On Thu, 6 Jul 2023 01:58:03 +0100
Ferruh Yigit  wrote:

> On 7/6/2023 12:45 AM, Stephen Hemminger wrote:
> > The mailmap file is supposed to be in sorted order,
> > but several entries are in the wrong place.
> > 
> > Signed-off-by: Stephen Hemminger 
> >  
> 
> Hi Stephen,
> 
> What are you using for sorting?

Emacs has a sort-lines function.

> When I use 'sort' binary [1] I get only a few lines of diff,
> but if I use vim ":sort" command I get a diff similar to this patch with
> lots of change.
> 
> It looks like these two variant of 'sort' works differently.
> 
> At least vim ":sort l" gives same output with 'sort' binary, and vim
> language config I have is "en_US.UTF-8", I assume 'sort' binary output
> is based on this language setting.
> 
> Will it work to stick with 'sort' binary and fix a few lines of diff in
> current file?

Sure, lets just use sort with utf-8