On Wed, 6 Apr 2022 02:14:46 +0300 Dmitry Kozlyuk <dmitry.kozl...@gmail.com> wrote:
> > > > Don't merge this patch as is please; it would cause a lot of pain > > in a cloud environment. > > > > In our environment core dumps are collected (via systemd) and uploaded > > to a central server. With this kind of change the processing would get > > overloaded with multi-gigabyte core dump size. Probably couldn't even > > save a core dump on these kind of smart nics. > > > > > > This needs to be optional (from command line) and default to the current > > behavior (not dumping huge pages). > > Maybe expose eal_mem_set_dump() as rte_mem_set_dump()? > This would allow to implement the feature easily using memory callbacks. > Better, one can enable hugepages to dump selectively: > for example, dump some interesting hash tables but skip rings and mempools. As was mentioned in thread core_dump_filter will also control these. So it won't impact users who do not enable it. Since the granularity is a the page level, it doesn't make sense to try and be selective for hash tables, rings, mempools etc. Looks good as is, though it might need a rebase. Acked-by: Stephen Hemminger <step...@networkplumber.org>
