[PATCH v2 0/2] net/hns3: add FDIR VLAN match mode runtime config
This patchset contains two patches: The first one is to delete duplicate macro definition for hns3. The second one is to add FDIR VLAN match mode runtime config for hns3 v1->v2: - Fix the hns3.rst doc build warining. Huisong Li (2): net/hns3: delete duplicate macro definition net/hns3: add FDIR VLAN match mode runtime config doc/guides/nics/hns3.rst | 26 + drivers/net/hns3/hns3_common.c | 35 ++ drivers/net/hns3/hns3_common.h | 2 ++ drivers/net/hns3/hns3_ethdev.h | 7 --- drivers/net/hns3/hns3_fdir.c | 10 +++--- drivers/net/hns3/hns3_fdir.h | 8 6 files changed, 78 insertions(+), 10 deletions(-) -- 2.22.0
[PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config
From: Huisong Li
The VLAN number in FDIR meta data is used to enable that hardware
bases on VLAN number to strictly match the input flow. And it is
enabled by default.
For the following two rules:
rule0:
pattern: eth type is 0x0806
actions: queue index 3
rule1:
pattern: eth type is 0x0806 / vlan vid is 20
actions: queue index 4
If enable VLAN number, only the ARP packets with VLAN 20 are directed
to queue 4, and the ARP packets with other VLAN ID cannot be directed
to the specified queue. If app want to all ARP (VLAN or no VLAN)
packets to be directed to the specified queue, app has to set many
rules for VLAN packet. In this case, if driver doesn't enable VLAN
number, app just need to set one rule (rule0).
So this patch adds a "fdir_vlan_match_mode" runtime config which only
can be 'strict' or 'nostrict'. And driver still uses 'strict' mode as
the default mode. Please select 'nostrict' mode if you request all same
ethertype packets with and without VLAN to a specified queue.
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
doc/guides/nics/hns3.rst | 26 +
drivers/net/hns3/hns3_common.c | 35 ++
drivers/net/hns3/hns3_common.h | 2 ++
drivers/net/hns3/hns3_fdir.c | 10 +++---
drivers/net/hns3/hns3_fdir.h | 8
5 files changed, 78 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 5373ec5a8f..0d546f0a05 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -140,6 +140,32 @@ Runtime Configuration
For example::
-a :7d:00.0,mbx_time_limit_ms=600
+- ``fdir_vlan_match_mode`` (default `strict`)
+
+ Used to select VLAN match mode. This runtime config can be `strict`
+ or `nostrict` and is only valid for PF drives.
+ If driver works on `strict` mode (default mode), hardware does strictly
+ match the input flow base on VLAN number.
+
+ For the following scenarios with two rules:
+
+ .. code-block:: console
+
+rule0:
+ pattern: eth type is 0x0806
+ actions: queue index 3
+rule1:
+ pattern: eth type is 0x0806 / vlan vid is 20
+ actions: queue index 4
+
+ If application select `strict` mode, only the ARP packets with VLAN
+ 20 are directed to queue 4, and the ARP packets with other VLAN ID
+ cannot be directed to the specified queue. If application want to all
+ ARP packets with or without VLAN to be directed to the specified queue,
+ application can select `nostrict` mode and just need to set rule0.
+
+ For example::
+ -a :7d:00.0,fdir_vlan_match_mode=nostrict
Driver compilation and testing
--
diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index f077ef5057..a11ea686fd 100644
--- a/drivers/net/hns3/hns3_common.c
+++ b/drivers/net/hns3/hns3_common.c
@@ -238,6 +238,34 @@ hns3_parse_mbx_time_limit(const char *key, const char
*value, void *extra_args)
return 0;
}
+static int
+hns3_parse_vlan_match_mode(const char *key, const char *value, void *args)
+{
+ uint8_t mode;
+
+ RTE_SET_USED(key);
+
+ if (value == NULL) {
+ PMD_INIT_LOG(WARNING, "no value for key:\"%s\"", key);
+ return -1;
+ }
+
+ if (strcmp(value, "strict") == 0) {
+ mode = HNS3_FDIR_VLAN_STRICT_MATCH;
+ } else if (strcmp(value, "nostrict") == 0) {
+ mode = HNS3_FDIR_VLAN_NOSTRICT_MATCH;
+ } else {
+ PMD_INIT_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", "
+ "value must be 'strict' or 'nostrict'",
+ value, key);
+ return -1;
+ }
+
+ *(uint8_t *)args = mode;
+
+ return 0;
+}
+
void
hns3_parse_devargs(struct rte_eth_dev *dev)
{
@@ -254,6 +282,8 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
hns->tx_func_hint = HNS3_IO_FUNC_HINT_NONE;
hns->dev_caps_mask = 0;
hns->mbx_time_limit_ms = HNS3_MBX_DEF_TIME_LIMIT_MS;
+ if (!hns->is_vf)
+ hns->pf.fdir.vlan_match_mode = HNS3_FDIR_VLAN_STRICT_MATCH;
if (dev->device->devargs == NULL)
return;
@@ -270,6 +300,11 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
&hns3_parse_dev_caps_mask, &dev_caps_mask);
(void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX_TIME_LIMIT_MS,
&hns3_parse_mbx_time_limit, &mbx_time_limit_ms);
+ if (!hns->is_vf)
+ (void)rte_kvargs_process(kvlist,
+HNS3_DEVARG_FDIR_VALN_MATCH_MODE,
+&hns3_parse_vlan_match_mode,
+&hns->pf.fdir.vlan_match_mode);
rte_kvargs_free(kvlist);
diff --git a/drivers/net/hns3/hns3_common.h b/drivers/net/hns3/hns3_common.h
index 8eaeda26e7..cf9593bd0c 100644
--- a/drivers/net/hns3/hns3_common.h
+++ b/dri
[PATCH v2 1/2] net/hns3: delete duplicate macro definition
From: Huisong Li
This patch delete some duplicate macro definitions.
Fixes: a4c7152d0581 ("net/hns3: extract common code to its own file")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_ethdev.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index c58094d87b..c85a6912ad 100644
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -873,13 +873,6 @@ struct hns3_adapter {
struct hns3_ptype_table ptype_tbl __rte_cache_aligned;
};
-#define HNS3_DEVARG_RX_FUNC_HINT "rx_func_hint"
-#define HNS3_DEVARG_TX_FUNC_HINT "tx_func_hint"
-
-#define HNS3_DEVARG_DEV_CAPS_MASK "dev_caps_mask"
-
-#define HNS3_DEVARG_MBX_TIME_LIMIT_MS "mbx_time_limit_ms"
-
enum hns3_dev_cap {
HNS3_DEV_SUPPORT_DCB_B,
HNS3_DEV_SUPPORT_COPPER_B,
--
2.22.0
RE: [PATCH v4 0/5] Logging related patchs
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 26 June 2023 20.42 > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [PATCH v4 0/5] Logging related patchs > > This patch set rebases and extends some earlier work on logging. > > Stephen Hemminger (5): > eal: unify logging code for FreeBsd and Linux > eal: turn off getopt_long error message during eal_log_level > eal: skip stdio on console logging > eal: move logging initialization earlier > eal: add option to put timestamp on console output Series-acked-by: Morten Brørup
[PATCH 0/2] net/mlx5: fix counter object leaks
This patch series fixes the issue where after a long cycle of inserting/deleting flow rules using COUNT actions, mlx5_hws_cnt_pool_get() started returning either -EAGAIN or -ENOENT. Root cause of the issue was the fact that some counter objects were not properly returned to the shared counter pool. Dariusz Sosnowski (2): net/mlx5: fix queue used to deallocate counter net/mlx5: fix counter allocation from shared pool drivers/net/mlx5/mlx5_flow_hw.c | 14 +- drivers/net/mlx5/mlx5_hws_cnt.h | 17 + 2 files changed, 26 insertions(+), 5 deletions(-) -- 2.25.1
[PATCH 1/2] net/mlx5: fix queue used to deallocate counter
When ports are configured to share flow engine resources
(configured through rte_flow_configure()),
counter objects used during flow rule creation are pulled
directly from the shared counter pool.
This is done by calling mlx5_hws_cnt_pool_get() with NULL pointer
passed as queue pointer.
When a flow rule was destroyed on the host port,
counter object was not returned to the pool, because
mlx5_hws_cnt_pool_put() was always called with a pointer
to the currently used queue.
This forced placing the counter in the local queue cache.
As a result, during the application runtime, some counter objects
became inaccessible, since this queue is never fully flushed.
This patch fixes that behavior, by changing the flow rule destroying
logic. If port is configured to use shared resources,
mlx5_hws_cnt_pool_put() is called with NULL pointer
passed as queue pointer.
Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")
Cc: viachesl...@nvidia.com
Signed-off-by: Dariusz Sosnowski
Acked-by: Ori Kam
---
drivers/net/mlx5/mlx5_flow_hw.c | 14 +-
drivers/net/mlx5/mlx5_hws_cnt.h | 16
2 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index b5137a822a..a0c7956626 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -2273,6 +2273,7 @@ flow_hw_actions_construct(struct rte_eth_dev *dev,
struct mlx5_hrxq *hrxq;
uint32_t ct_idx;
cnt_id_t cnt_id;
+ uint32_t *cnt_queue;
uint32_t mtr_id;
action = &actions[act_data->action_src];
@@ -2429,10 +2430,9 @@ flow_hw_actions_construct(struct rte_eth_dev *dev,
break;
/* Fall-through. */
case RTE_FLOW_ACTION_TYPE_COUNT:
- ret = mlx5_hws_cnt_pool_get(priv->hws_cpool,
- (priv->shared_refcnt ||
-priv->hws_cpool->cfg.host_cpool) ?
- NULL : &queue, &cnt_id, age_idx);
+ /* If the port is engaged in resource sharing, do not
use queue cache. */
+ cnt_queue = mlx5_hws_cnt_is_pool_shared(priv) ? NULL :
&queue;
+ ret = mlx5_hws_cnt_pool_get(priv->hws_cpool, cnt_queue,
&cnt_id, age_idx);
if (ret != 0)
return ret;
ret = mlx5_hws_cnt_pool_get_action_offset
@@ -3014,6 +3014,8 @@ flow_hw_age_count_release(struct mlx5_priv *priv,
uint32_t queue,
struct rte_flow_hw *flow,
struct rte_flow_error *error)
{
+ uint32_t *cnt_queue;
+
if (mlx5_hws_cnt_is_shared(priv->hws_cpool, flow->cnt_id)) {
if (flow->age_idx && !mlx5_hws_age_is_indirect(flow->age_idx)) {
/* Remove this AGE parameter from indirect counter. */
@@ -3024,8 +3026,10 @@ flow_hw_age_count_release(struct mlx5_priv *priv,
uint32_t queue,
}
return;
}
+ /* If the port is engaged in resource sharing, do not use queue cache.
*/
+ cnt_queue = mlx5_hws_cnt_is_pool_shared(priv) ? NULL : &queue;
/* Put the counter first to reduce the race risk in BG thread. */
- mlx5_hws_cnt_pool_put(priv->hws_cpool, &queue, &flow->cnt_id);
+ mlx5_hws_cnt_pool_put(priv->hws_cpool, cnt_queue, &flow->cnt_id);
flow->cnt_id = 0;
if (flow->age_idx) {
if (mlx5_hws_age_is_indirect(flow->age_idx)) {
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h
index b4f3db0533..f37a7d6151 100644
--- a/drivers/net/mlx5/mlx5_hws_cnt.h
+++ b/drivers/net/mlx5/mlx5_hws_cnt.h
@@ -553,6 +553,22 @@ mlx5_hws_cnt_pool_get(struct mlx5_hws_cnt_pool *cpool,
uint32_t *queue,
return 0;
}
+/**
+ * Check if counter pool allocated for HWS is shared between ports.
+ *
+ * @param[in] priv
+ * Pointer to the port private data structure.
+ *
+ * @return
+ * True if counter pools is shared between ports. False otherwise.
+ */
+static __rte_always_inline bool
+mlx5_hws_cnt_is_pool_shared(struct mlx5_priv *priv)
+{
+ return priv && priv->hws_cpool &&
+ (priv->shared_refcnt || priv->hws_cpool->cfg.host_cpool != NULL);
+}
+
static __rte_always_inline unsigned int
mlx5_hws_cnt_pool_get_size(struct mlx5_hws_cnt_pool *cpool)
{
--
2.25.1
[PATCH 2/2] net/mlx5: fix counter allocation from shared pool
mlx5_hws_cnt struct represents counter objects which are used
in flow rules. This struct contains a union which stores
the following information:
- If counter object is used:
- `share` is set to 1 if and only if counter object is used
in an indirect action.
- `age_idx` is set to the relevant AGE object index.
- Both of these fields are set at the time of allocatin
a counter object from the pool.
- If counter object is unused:
- `query_gen_when_free` is set to the current reset cycle
of the counter service at the time of freeing the counter object.
When ports were configured to share the flow engine resources,
counter object allocation logic in mlx5_hws_cnt_pool_get()
did not reset the `share` field.
This caused issues when previously released counter object
had the least significant bit of `query_gen_when_free` set to 1.
That counter object was treated as shared counter (indirect action),
even if it was allocated by using COUNT action directly in the flow
rule.
This patch fixes this issue by adding the explicit reset of `share`
field.
Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode")
Cc: viachesl...@nvidia.com
Signed-off-by: Dariusz Sosnowski
Acked-by: Ori Kam
---
drivers/net/mlx5/mlx5_hws_cnt.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h
index f37a7d6151..f462665eac 100644
--- a/drivers/net/mlx5/mlx5_hws_cnt.h
+++ b/drivers/net/mlx5/mlx5_hws_cnt.h
@@ -506,6 +506,7 @@ mlx5_hws_cnt_pool_get(struct mlx5_hws_cnt_pool *cpool,
uint32_t *queue,
__hws_cnt_query_raw(cpool, *cnt_id,
&cpool->pool[iidx].reset.hits,
&cpool->pool[iidx].reset.bytes);
+ cpool->pool[iidx].share = 0;
MLX5_ASSERT(!cpool->pool[iidx].in_used);
cpool->pool[iidx].in_used = true;
cpool->pool[iidx].age_idx = age_idx;
--
2.25.1
Re: [PATCH v5 1/2] ip_frag: optimize key compare and hash generation
From: Pavan Nikhilesh
Use optimized rte_hash_k32_cmp_eq routine for key comparison for
x86 and ARM64.
Use CRC instructions for hash generation on ARM64.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Ruifeng Wang
---
On Neoverse-N2, performance improved by 10% when measured with
examples/ip_reassembly.
v5 Changes:
- Fix spellcheck.
v4 Changes:
- Fix compilation failures (sys/queue)
- Update test case to use proper macros.
v3 Changes:
- Drop NEON patch.
v2 Changes:
- Fix compilation failure with non ARM64/x86 targets
lib/hash/rte_cmp_arm64.h | 16
lib/hash/rte_cmp_x86.h | 16
lib/ip_frag/ip_frag_common.h | 14 ++
lib/ip_frag/ip_frag_internal.c | 4 ++--
4 files changed, 32 insertions(+), 18 deletions(-)
diff --git a/lib/hash/rte_cmp_arm64.h b/lib/hash/rte_cmp_arm64.h
index e9e26f9abd..a3e85635eb 100644
--- a/lib/hash/rte_cmp_arm64.h
+++ b/lib/hash/rte_cmp_arm64.h
@@ -3,7 +3,7 @@
*/
/* Functions to compare multiple of 16 byte keys (up to 128 bytes) */
-static int
+static inline int
rte_hash_k16_cmp_eq(const void *key1, const void *key2,
size_t key_len __rte_unused)
{
@@ -24,7 +24,7 @@ rte_hash_k16_cmp_eq(const void *key1, const void *key2,
return !(x0 == 0 && x1 == 0);
}
-static int
+static inline int
rte_hash_k32_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k16_cmp_eq(key1, key2, key_len) ||
@@ -32,7 +32,7 @@ rte_hash_k32_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 16, key_len);
}
-static int
+static inline int
rte_hash_k48_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k16_cmp_eq(key1, key2, key_len) ||
@@ -42,7 +42,7 @@ rte_hash_k48_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 32, key_len);
}
-static int
+static inline int
rte_hash_k64_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k32_cmp_eq(key1, key2, key_len) ||
@@ -50,7 +50,7 @@ rte_hash_k64_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 32, key_len);
}
-static int
+static inline int
rte_hash_k80_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k64_cmp_eq(key1, key2, key_len) ||
@@ -58,7 +58,7 @@ rte_hash_k80_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 64, key_len);
}
-static int
+static inline int
rte_hash_k96_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k64_cmp_eq(key1, key2, key_len) ||
@@ -66,7 +66,7 @@ rte_hash_k96_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 64, key_len);
}
-static int
+static inline int
rte_hash_k112_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k64_cmp_eq(key1, key2, key_len) ||
@@ -76,7 +76,7 @@ rte_hash_k112_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 96, key_len);
}
-static int
+static inline int
rte_hash_k128_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k64_cmp_eq(key1, key2, key_len) ||
diff --git a/lib/hash/rte_cmp_x86.h b/lib/hash/rte_cmp_x86.h
index 13a5836351..ddfbef462f 100644
--- a/lib/hash/rte_cmp_x86.h
+++ b/lib/hash/rte_cmp_x86.h
@@ -5,7 +5,7 @@
#include
/* Functions to compare multiple of 16 byte keys (up to 128 bytes) */
-static int
+static inline int
rte_hash_k16_cmp_eq(const void *key1, const void *key2, size_t key_len
__rte_unused)
{
const __m128i k1 = _mm_loadu_si128((const __m128i *) key1);
@@ -15,7 +15,7 @@ rte_hash_k16_cmp_eq(const void *key1, const void *key2,
size_t key_len __rte_unu
return !_mm_test_all_zeros(x, x);
}
-static int
+static inline int
rte_hash_k32_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k16_cmp_eq(key1, key2, key_len) ||
@@ -23,7 +23,7 @@ rte_hash_k32_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 16, key_len);
}
-static int
+static inline int
rte_hash_k48_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k16_cmp_eq(key1, key2, key_len) ||
@@ -33,7 +33,7 @@ rte_hash_k48_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *) key2 + 32, key_len);
}
-static int
+static inline int
rte_hash_k64_cmp_eq(const void *key1, const void *key2, size_t key_len)
{
return rte_hash_k32_cmp_eq(key1, key2, key_len) ||
@@ -41,7 +41,7 @@ rte_hash_k64_cmp_eq(const void *key1, const void *key2,
size_t key_len)
(const char *)
Re: [PATCH v4 5/9] build: make bpf library optional
23/06/2023 16:07, Bruce Richardson пишет:
This library is not essential for most DPDK uses, so mark it as optional
in the build config.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
---
app/test/meson.build | 10 +++---
lib/meson.build | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/app/test/meson.build b/app/test/meson.build
index 0f9992c0b2..0ef0bf690f 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -15,7 +15,6 @@ test_sources = files(
'test_barrier.c',
'test_bitops.c',
'test_bitmap.c',
-'test_bpf.c',
'test_byteorder.c',
'test_cksum.c',
'test_cksum_perf.c',
@@ -150,8 +149,6 @@ fast_tests = [
['acl_autotest', true, true],
['atomic_autotest', false, true],
['bitmap_autotest', true, true],
-['bpf_autotest', true, true],
-['bpf_convert_autotest', true, true],
['bitops_autotest', true, true],
['byteorder_autotest', true, true],
['cksum_autotest', true, true],
@@ -341,6 +338,13 @@ if dpdk_conf.has('RTE_EVENT_SKELETON')
test_deps += 'event_skeleton'
endif
+if dpdk_conf.has('RTE_LIB_BPF')
+test_sources += 'test_bpf.c'
+fast_tests += [
+['bpf_autotest', true, true],
+['bpf_convert_autotest', true, true],
+]
+endif
if dpdk_conf.has('RTE_LIB_DMADEV')
test_sources += ['test_dmadev.c', 'test_dmadev_api.c']
driver_test_names += 'dmadev_autotest'
diff --git a/lib/meson.build b/lib/meson.build
index de7069a078..47c18ca3b0 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -70,6 +70,7 @@ libraries = [
optional_libs = [
'bbdev',
'bitratestats',
+'bpf',
'cfgfile',
'compressdev',
'dmadev',
Acked-by: Konstantin Ananyev
Re: [PATCH v4 8/9] build: make fragmentation library optional
23/06/2023 16:07, Bruce Richardson пишет:
This library is not essential for most DPDK uses, so mark it as optional
in the build config.
Signed-off-by: Bruce Richardson
Acked-by: Morten Brørup
---
app/test/meson.build | 6 --
lib/meson.build | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/app/test/meson.build b/app/test/meson.build
index 0a971997a5..2e447e3402 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -56,7 +56,6 @@ test_sources = files(
'test_hash_perf.c',
'test_hash_readwrite_lf_perf.c',
'test_interrupts.c',
-'test_ipfrag.c',
'test_ipsec.c',
'test_ipsec_sad.c',
'test_ipsec_perf.c',
@@ -173,7 +172,6 @@ fast_tests = [
['func_reentrancy_autotest', false, true],
['hash_autotest', true, true],
['interrupt_autotest', true, true],
-['ipfrag_autotest', false, true],
['lcores_autotest', true, true],
['logs_autotest', true, true],
['lpm_autotest', true, true],
@@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH')
test_sources += 'test_graph_perf.c'
perf_test_names += 'graph_perf_autotest'
endif
+if dpdk_conf.has('RTE_LIB_IP_FRAG')
+test_sources += 'test_ipfrag.c'
+fast_tests += [['ipfrag_autotest', false, true]]
AFAIK, there is a new patch in flight to add new ip_frag perf autotest:
http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavat...@marvell.com/
Probably need to be synced with these changes too..
+endif
if dpdk_conf.has('RTE_LIB_METRICS')
test_sources += ['test_metrics.c']
fast_tests += [['metrics_autotest', true, true]]
diff --git a/lib/meson.build b/lib/meson.build
index 757c1a63e9..ea351b236a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -83,6 +83,7 @@ optional_libs = [
'gro',
'gso',
'kni',
+'ip_frag',
'jobstats',
'latencystats',
'member',
Acked-by: Konstantin Ananyev
Ring algorithm with fewer cache misses
Hi Honnappa, Konstantin, Bruce and Gavin, You might find this ring algorithm optimization article interesting: https://rigtorp.se/ringbuffer/ It adds the following optimization: The single-producer put() operation keeps a cache of the consumer's index. If the cached consumer index indicates that there was still sufficient room in the ring after the previous put() operation, it doesn't need to fetch the actual consumer index, and thus avoids a potential L1 cache miss (because the actual consumer index is written by the consumer threads). If the cached index doesn't indicate that there is sufficient room in the ring, the operation behaves like without the optimization, i.e. it proceeds to fetch the actual consumer index (and writes it to its cache) and determines if there is sufficient room in the ring. Similarly, the single-consumer get() operation caches the producer's index to determine if there were still sufficient objects present in the ring after the previous get() operation. Med venlig hilsen / Kind regards, -Morten Brørup
Re: [PATCH v5 2/2] test: add reassembly perf test
rom: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly. Each test is performed with variable number of fragments per flow, either ordered or unordered fragments and interleaved flows. Signed-off-by: Pavan Nikhilesh Reviewed-by: Amit Prakash Shukla Tested-by: Amit Prakash Shukla --- app/test/meson.build|2 + app/test/test_reassembly_perf.c | 1002 +++ 2 files changed, 1004 insertions(+) create mode 100644 app/test/test_reassembly_perf.c -- Acked-by: Konstantin Ananyev 2.25.1
RE: Ring algorithm with fewer cache misses
Hi Morten, > Hi Honnappa, Konstantin, Bruce and Gavin, > > You might find this ring algorithm optimization article interesting: > https://rigtorp.se/ringbuffer/ > > > It adds the following optimization: > > The single-producer put() operation keeps a cache of the consumer's index. If > the cached consumer index indicates that there was still > sufficient room in the ring after the previous put() operation, it doesn't > need to fetch the actual consumer index, and thus avoids a > potential L1 cache miss (because the actual consumer index is written by the > consumer threads). > > If the cached index doesn't indicate that there is sufficient room in the > ring, the operation behaves like without the optimization, i.e. it > proceeds to fetch the actual consumer index (and writes it to its cache) and > determines if there is sufficient room in the ring. > > > Similarly, the single-consumer get() operation caches the producer's index to > determine if there were still sufficient objects present in > the ring after the previous get() operation. > Indeed, that sounds like an interesting idea and worth to explore. Thinking a bit more - it probably could be extended to classic MP/MC case too - If we can update cons/prod head and this cached value atomically (CAS64?). Thanks Konstantin
Re: [PATCH v4] app/testpmd: fix primary process not polling all queues
On 6/26/2023 10:30 AM, Jie Hai wrote:
> On 2023/6/23 0:40, Ali Alnubani wrote:
>>> -Original Message-
>>> From: Jie Hai
>>> Sent: Friday, June 9, 2023 12:04 PM
>>> To: Aman Singh ; Yuying Zhang
>>> ; Anatoly Burakov ;
>>> Matan Azrad ; Dmitry Kozlyuk
>>>
>>> Cc: dev@dpdk.org; liudongdo...@huawei.com; shiyangx...@intel.com;
>>> ferruh.yi...@amd.com
>>> Subject: [PATCH v4] app/testpmd: fix primary process not polling all
>>> queues
>>>
>>> Here's how the problem arises.
>>> step1: Start the app.
>>> dpdk-testpmd -a :35:00.0 -l 0-3 -- -i --rxq=10 --txq=10
>>>
>>> step2: Perform the following steps and send traffic. As expected,
>>> queue 7 does not send or receive packets, and other queues do.
>>> port 0 rxq 7 stop
>>> port 0 txq 7 stop
>>> set fwd mac
>>> start
>>>
>>> step3: Perform the following steps and send traffic. All queues
>>> are expected to send and receive packets normally, but that's not
>>> the case for queue 7.
>>> stop
>>> port stop all
>>> port start all
>>> start
>>> show port xstats all
>>>
>>> In fact, only the value of rx_q7_packets for queue 7 is not zero,
>>> which means queue 7 is enabled for the driver but is not involved
>>> in packet receiving and forwarding by software. If we check queue
>>> state by command 'show rxq info 0 7' and 'show txq info 0 7',
>>> we see queue 7 is started as other queues are.
>>> Rx queue state: started
>>> Tx queue state: started
>>> The queue 7 is started but cannot forward. That's the problem.
>>>
>>> We know that each stream has a read-only "disabled" field that
>>> control if this stream should be used to forward. This field
>>> depends on testpmd local queue state, please see
>>> commit 3c4426db54fc ("app/testpmd: do not poll stopped queues").
>>> DPDK framework maintains ethdev queue state that drivers reported,
>>> which indicates the real state of queues.
>>>
>>> There are commands that update these two kind queue state such as
>>> 'port X rxq|txq start|stop'. But these operations take effect only
>>> in one stop-start round. In the following stop-start round, the
>>> preceding operations do not take effect anymore. However, only
>>> the ethdev queue state is updated, causing the testpmd and ethdev
>>> state information to diverge and causing unexpected side effects
>>> as above problem.
>>>
>>> There was a similar problem for the secondary process, please see
>>> commit 5028f207a4fa ("app/testpmd: fix secondary process packet
>>> forwarding").
>>>
>>> This patch applies its workaround with some difference to the
>>> primary process. Not all PMDs implement rte_eth_rx_queue_info_get and
>>> rte_eth_tx_queue_info_get, however they may support deferred_start
>>> with primary process. To not break their behavior, retain the original
>>> testpmd local queue state for those PMDs.
>>>
>>> Fixes: 3c4426db54fc ("app/testpmd: do not poll stopped queues")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Jie Hai
>>> ---
>>
>> Hi Jie,
>>
>> I see the error below when starting a representor port after
>> reattaching it with this patch, is it expected?
>>
>> $ sudo ./build /app/dpdk-testpmd -n 4 -a
>> :08:00.0,dv_esw_en=1,representor=vf0-1 -a auxiliary: -a 00:00.0
>> --iova-mode="va" -- -i
>> [..]
>> testpmd> port stop all
>> testpmd> port close 0
>> testpmd> device detach :08:00.0
>> testpmd> port attach :08:00.0,dv_esw_en=1,representor=0-1
>> testpmd> port start 1
>> Configuring Port 1 (socket 0)
>> Port 1: FA:9E:D8:5F:D7:D8
>> Invalid Rx queue_id=0
>> testpmd: Failed to get rx queue info
>> Invalid Tx queue_id=0
>> testpmd: Failed to get tx queue info
>>
>> Regards,
>> Ali
> Hi Ali,
> Thanks for your feedback.
>
> When update_queue_state is called, the status of all queues on all ports
> are updated.
> The number of queues is nb_rxq|nb_txq which is stored locally by testpmd
> process.
> All ports on the same process shares the same nb_rxq|nb_txq.
>
> After detached and attached, the number of queues of port 0 is 0.
> And it changes only when the port is reconfigured by testpmd,
> which is when port 0 is started.
>
> If we start port 1 first, update_queue_state will update nb_rxq|nb_txq
> queues state of port 0, and that's invalid because there's zero queues.
>
> If this patch is not applied, the same problem occurs when the secondary
> process detaches and attaches the port, and then starts the port in the
> multi-process scenario.
>
> I will submit a patch to fix this problem. When port starts, update
> queue state based on the number of queues reported by the driver.
>
Hi Ali,
How big a blocker is this issue, should the fix be part of -rc2?
RE: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 3:46 AM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; > rja...@redhat.com; jer...@marvell.com > Subject: Re: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > 20/06/2023 14:00, Raslan Darawsheh: > > Hi, > > > > > -Original Message- > > > From: Viacheslav Ovsiienko > > > Sent: Tuesday, June 13, 2023 7:59 PM > > > To: dev@dpdk.org > > > Subject: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > > > > > The mlx5 provides the send scheduling on specific moment of time, > > > and for the related kind of applications it would be extremely > > > useful to have extra debug information - when and how packets were > > > scheduled and when the actual sending was completed by the NIC > > > hardware (it helps application to track the internal delay issues). > > > > > > Because the DPDK tx datapath API does not suppose getting any > > > feedback from the driver and the feature looks like to be mlx5 > > > specific, it seems to be reasonable to engage exisiting DPDK datapath > tracing capability. > > > > > > The work cycle is supposed to be: > > > - compile appplication with enabled tracing > > > - run application with EAL parameters configuring the tracing in mlx5 > > > Tx datapath > > > - store the dump file with gathered tracing information > > > - run analyzing scrypt (in Python) to combine related events (packet > > > firing and completion) and see the data in human-readable view > > > > > > Below is the detailed instruction "how to" with mlx5 NIC to gather > > > all the debug data including the full timings information. > > > > > > > > > 1. Build DPDK application with enabled datapath tracing > > > > > > The meson option should be specified: > > >--enable_trace_fp=true > > > > > > The c_args shoudl be specified: > > >-DALLOW_EXPERIMENTAL_API > > > > > > The DPDK configuration examples: > > > > > > meson configure --buildtype=debug -Denable_trace_fp=true > > > -Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT - > > > DALLOW_EXPERIMENTAL_API' build > > > > > > meson configure --buildtype=debug -Denable_trace_fp=true > > > -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' > > > build > > > > > > meson configure --buildtype=release -Denable_trace_fp=true > > > -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' > > > build > > > > > > meson configure --buildtype=release -Denable_trace_fp=true > > > -Dc_args='-DALLOW_EXPERIMENTAL_API' build > > > > > > > > > 2. Configuring the NIC > > > > > > If the sending completion timings are important the NIC should be > > > configured to provide realtime timestamps, the > > > REAL_TIME_CLOCK_ENABLE NV settings parameter should be configured > to > > > TRUE, for example with command (and with following FW/driver reset): > > > > > > sudo mlxconfig -d /dev/mst/mt4125_pciconf0 s > > > REAL_TIME_CLOCK_ENABLE=1 > > > > > > > > > 3. Run DPDK application to gather the traces > > > > > > EAL parameters controlling trace capability in runtime > > > > > > --trace=pmd.net.mlx5.tx - the regular expression enabling the > > > tracepoints > > > with matching names at least "pmd.net.mlx5.tx" > > > must be enabled to gather all events needed > > > to analyze mlx5 Tx datapath and its timings. > > > By default all tracepoints are disabled. > > > > > > --trace-dir=/var/log - trace storing directory > > > > > > --trace-bufsz=B|K|M - optional, trace data buffer size > > >per thread. The default is 1MB. > > > > > > --trace-mode=overwrite|discard - optional, selects trace data buffer > mode. > > > > > > > > > 4. Installing or Building Babeltrace2 Package > > > > > > The gathered trace data can be analyzed with a developed Python script. > > > To parse the trace, the data script uses the Babeltrace2 library. > > > The package should be either installed or built from source code as > > > shown below: > > > > > > git clone https://github.com/efficios/babeltrace.git > > > cd babeltrace > > > ./bootstrap > > > ./configure -help > > > ./configure --disable-api-doc --disable-man-pages > > > --disable-python-bindings-doc --enbale-python-plugins > > > --enable-python-binding > > > > > > 5. Running the Analyzing Script > > > > > > The analyzing script is located in the folder: > > > ./drivers/net/mlx5/tools It requires Python3.6, Babeltrace2 packages > > > and it takes the only parameter of trace data file. For example: > > > > > >./mlx5_trace.py /var/log/rte-2023-01-23-AM-11-52-39 > > > > > > > > > 6. Interpreting the Script Output Data > > > > > > All the timings are given in nanoseconds. > > > The list of Tx (and coming Rx) bursts per port/queue is presented in > > > the output. > > > Each list element co
Re: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing
27/06/2023 13:24, Slava Ovsiienko: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, June 27, 2023 3:46 AM > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > rja...@redhat.com; jer...@marvell.com > > Subject: Re: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > > > 20/06/2023 14:00, Raslan Darawsheh: > > > Hi, > > > > > > > -Original Message- > > > > From: Viacheslav Ovsiienko > > > > Sent: Tuesday, June 13, 2023 7:59 PM > > > > To: dev@dpdk.org > > > > Subject: [PATCH v2 0/5] net/mlx5: introduce Tx datapath tracing > > > > > > > > The mlx5 provides the send scheduling on specific moment of time, > > > > and for the related kind of applications it would be extremely > > > > useful to have extra debug information - when and how packets were > > > > scheduled and when the actual sending was completed by the NIC > > > > hardware (it helps application to track the internal delay issues). > > > > > > > > Because the DPDK tx datapath API does not suppose getting any > > > > feedback from the driver and the feature looks like to be mlx5 > > > > specific, it seems to be reasonable to engage exisiting DPDK datapath > > tracing capability. > > > > > > > > The work cycle is supposed to be: > > > > - compile appplication with enabled tracing > > > > - run application with EAL parameters configuring the tracing in mlx5 > > > > Tx datapath > > > > - store the dump file with gathered tracing information > > > > - run analyzing scrypt (in Python) to combine related events (packet > > > > firing and completion) and see the data in human-readable view > > > > > > > > Below is the detailed instruction "how to" with mlx5 NIC to gather > > > > all the debug data including the full timings information. > > > > > > > > > > > > 1. Build DPDK application with enabled datapath tracing > > > > > > > > The meson option should be specified: > > > >--enable_trace_fp=true > > > > > > > > The c_args shoudl be specified: > > > >-DALLOW_EXPERIMENTAL_API > > > > > > > > The DPDK configuration examples: > > > > > > > > meson configure --buildtype=debug -Denable_trace_fp=true > > > > -Dc_args='-DRTE_LIBRTE_MLX5_DEBUG -DRTE_ENABLE_ASSERT - > > > > DALLOW_EXPERIMENTAL_API' build > > > > > > > > meson configure --buildtype=debug -Denable_trace_fp=true > > > > -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' > > > > build > > > > > > > > meson configure --buildtype=release -Denable_trace_fp=true > > > > -Dc_args='-DRTE_ENABLE_ASSERT -DALLOW_EXPERIMENTAL_API' > > > > build > > > > > > > > meson configure --buildtype=release -Denable_trace_fp=true > > > > -Dc_args='-DALLOW_EXPERIMENTAL_API' build > > > > > > > > > > > > 2. Configuring the NIC > > > > > > > > If the sending completion timings are important the NIC should be > > > > configured to provide realtime timestamps, the > > > > REAL_TIME_CLOCK_ENABLE NV settings parameter should be configured > > to > > > > TRUE, for example with command (and with following FW/driver reset): > > > > > > > > sudo mlxconfig -d /dev/mst/mt4125_pciconf0 s > > > > REAL_TIME_CLOCK_ENABLE=1 > > > > > > > > > > > > 3. Run DPDK application to gather the traces > > > > > > > > EAL parameters controlling trace capability in runtime > > > > > > > > --trace=pmd.net.mlx5.tx - the regular expression enabling the > > > > tracepoints > > > > with matching names at least > > > > "pmd.net.mlx5.tx" > > > > must be enabled to gather all events needed > > > > to analyze mlx5 Tx datapath and its timings. > > > > By default all tracepoints are disabled. > > > > > > > > --trace-dir=/var/log - trace storing directory > > > > > > > > --trace-bufsz=B|K|M - optional, trace data buffer size > > > >per thread. The default is 1MB. > > > > > > > > --trace-mode=overwrite|discard - optional, selects trace data buffer > > mode. > > > > > > > > > > > > 4. Installing or Building Babeltrace2 Package > > > > > > > > The gathered trace data can be analyzed with a developed Python script. > > > > To parse the trace, the data script uses the Babeltrace2 library. > > > > The package should be either installed or built from source code as > > > > shown below: > > > > > > > > git clone https://github.com/efficios/babeltrace.git > > > > cd babeltrace > > > > ./bootstrap > > > > ./configure -help > > > > ./configure --disable-api-doc --disable-man-pages > > > > --disable-python-bindings-doc --enbale-python-plugins > > > > --enable-python-binding > > > > > > > > 5. Running the Analyzing Script > > > > > > > > The analyzing script is located in the folder: > > > > ./drivers/net/mlx5/tools It requires Python3.6, Babeltrace2 packages > > > > and it takes the only parameter of trace data file. For example: > > > > > > > >
Re: [PATCH v4] app/testpmd: add trace dump command
On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > The tracing data are saved according to the EAL configuration > (explicit --trace-dir EAL command line parameter alters > the target folder to save). The result dump folder gets the name > like rte--MM-DD-xx-HH-MM-SS format. > > This command is useful to get the trace date without exiting > testpmd application and to get the multiple dumps to observe > the situation in dynamics. > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ferruh Yigit > -- > > v1: https://inbox.dpdk.org/dev/20230609152847.32496-2-viachesl...@nvidia.com > v2: https://inbox.dpdk.org/dev/20230613165845.19109-2-viachesl...@nvidia.com > - changed to save_trace command > - Windows compilation check added > > v3: https://inbox.dpdk.org/dev/20230626110734.14126-1-viachesl...@nvidia.com > - reverted to "dump_trace" command > > v4: - added missed header file include > - missed #ifdef added for Windows compilation (no trace support > for Windows) > --- > app/test-pmd/cmdline.c | 8 > 1 file changed, 8 insertions(+) > Can you please update 'doc/guides/testpmd_app_ug/testpmd_funcs.rst' for new command? It looks like dump_* commands missed in the help output, 'cmd_help_long_parsed()', can you please append this new one end of "display" section, we can complete the missing ones later? <...> > @@ -8371,10 +8372,17 @@ static void cmd_dump_parsed(void *parsed_result, > rte_lcore_dump(stdout); > else if (!strcmp(res->dump, "dump_log_types")) > rte_log_dump(stdout); > +#ifndef RTE_EXEC_ENV_WINDOWS > + else if (!strcmp(res->dump, "dump_trace")) > + rte_trace_save(); > +#endif > } > > static cmdline_parse_token_string_t cmd_dump_dump = > TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > +#ifndef RTE_EXEC_ENV_WINDOWS > + "dump_trace#" > +#endif > Why not add "dump_trace#" as last item, to keep same order with 'cmd_dump_parsed()'?
RE: [PATCH v4] app/testpmd: add trace dump command
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 27, 2023 2:35 PM > To: Slava Ovsiienko ; dev@dpdk.org > Cc: jer...@marvell.com > Subject: Re: [PATCH v4] app/testpmd: add trace dump command > > On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: > > The "dump_trace" CLI command is added to trigger saving the trace > > dumps to the trace directory. > > > > The tracing data are saved according to the EAL configuration > > (explicit --trace-dir EAL command line parameter alters the target > > folder to save). The result dump folder gets the name like > > rte--MM-DD-xx-HH-MM-SS format. > > > > This command is useful to get the trace date without exiting testpmd > > application and to get the multiple dumps to observe the situation in > > dynamics. > > > > Signed-off-by: Viacheslav Ovsiienko > > > > Acked-by: Ferruh Yigit > > > -- > > > > v1: > > https://inbox.dpdk.org/dev/20230609152847.32496-2-viacheslavo@nvidia.c > > om > > v2: https://inbox.dpdk.org/dev/20230613165845.19109-2- > viachesl...@nvidia.com > > - changed to save_trace command > > - Windows compilation check added > > > > v3: https://inbox.dpdk.org/dev/20230626110734.14126-1- > viachesl...@nvidia.com > > - reverted to "dump_trace" command > > > > v4: - added missed header file include > > - missed #ifdef added for Windows compilation (no trace support > > for Windows) > > --- > > app/test-pmd/cmdline.c | 8 > > 1 file changed, 8 insertions(+) > > > > Can you please update 'doc/guides/testpmd_app_ug/testpmd_funcs.rst' for > new command? Sure. > > It looks like dump_* commands missed in the help output, > 'cmd_help_long_parsed()', can you please append this new one end of > "display" section, we can complete the missing ones later? > > <...> > > > @@ -8371,10 +8372,17 @@ static void cmd_dump_parsed(void > *parsed_result, > > rte_lcore_dump(stdout); > > else if (!strcmp(res->dump, "dump_log_types")) > > rte_log_dump(stdout); > > +#ifndef RTE_EXEC_ENV_WINDOWS > > + else if (!strcmp(res->dump, "dump_trace")) > > + rte_trace_save(); > > +#endif > > } > > > > static cmdline_parse_token_string_t cmd_dump_dump = > > TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > > +#ifndef RTE_EXEC_ENV_WINDOWS > > + "dump_trace#" > > +#endif > > > > Why not add "dump_trace#" as last item, to keep same order with > 'cmd_dump_parsed()'? This would require modify the preceding command undef #ifndef and #else: #ifndef RTE_EXEC_ENV_WINDOWS "dump_log_types# "dump_trace"); #else "dump_log_types"); #endif If you think order is more important - please, let me know, I'll update With best regards, Slava
Re: [PATCH v4] app/testpmd: add trace dump command
On 6/27/2023 12:39 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, June 27, 2023 2:35 PM >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: jer...@marvell.com >> Subject: Re: [PATCH v4] app/testpmd: add trace dump command >> >> On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: >>> The "dump_trace" CLI command is added to trigger saving the trace >>> dumps to the trace directory. >>> >>> The tracing data are saved according to the EAL configuration >>> (explicit --trace-dir EAL command line parameter alters the target >>> folder to save). The result dump folder gets the name like >>> rte--MM-DD-xx-HH-MM-SS format. >>> >>> This command is useful to get the trace date without exiting testpmd >>> application and to get the multiple dumps to observe the situation in >>> dynamics. >>> >>> Signed-off-by: Viacheslav Ovsiienko >>> >> >> Acked-by: Ferruh Yigit >> >>> -- >>> >>> v1: >>> https://inbox.dpdk.org/dev/20230609152847.32496-2-viacheslavo@nvidia.c >>> om >>> v2: https://inbox.dpdk.org/dev/20230613165845.19109-2- >> viachesl...@nvidia.com >>> - changed to save_trace command >>> - Windows compilation check added >>> >>> v3: https://inbox.dpdk.org/dev/20230626110734.14126-1- >> viachesl...@nvidia.com >>> - reverted to "dump_trace" command >>> >>> v4: - added missed header file include >>> - missed #ifdef added for Windows compilation (no trace support >>> for Windows) >>> --- >>> app/test-pmd/cmdline.c | 8 >>> 1 file changed, 8 insertions(+) >>> >> >> Can you please update 'doc/guides/testpmd_app_ug/testpmd_funcs.rst' for >> new command? > Sure. > >> >> It looks like dump_* commands missed in the help output, >> 'cmd_help_long_parsed()', can you please append this new one end of >> "display" section, we can complete the missing ones later? >> >> <...> >> >>> @@ -8371,10 +8372,17 @@ static void cmd_dump_parsed(void >> *parsed_result, >>> rte_lcore_dump(stdout); >>> else if (!strcmp(res->dump, "dump_log_types")) >>> rte_log_dump(stdout); >>> +#ifndef RTE_EXEC_ENV_WINDOWS >>> + else if (!strcmp(res->dump, "dump_trace")) >>> + rte_trace_save(); >>> +#endif >>> } >>> >>> static cmdline_parse_token_string_t cmd_dump_dump = >>> TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, >>> +#ifndef RTE_EXEC_ENV_WINDOWS >>> + "dump_trace#" >>> +#endif >>> >> >> Why not add "dump_trace#" as last item, to keep same order with >> 'cmd_dump_parsed()'? > > This would require modify the preceding command undef #ifndef and #else: > #ifndef RTE_EXEC_ENV_WINDOWS > "dump_log_types# > "dump_trace"); > #else > "dump_log_types"); > #endif > > If you think order is more important - please, let me know, I'll update > Lets move it just before 'dump_log_types', in both instance :)
Re: [PATCH v2 0/2] net/hns3: add FDIR VLAN match mode runtime config
On 6/27/2023 8:11 AM, Dongdong Liu wrote: > This patchset contains two patches: > The first one is to delete duplicate macro definition for hns3. > The second one is to add FDIR VLAN match mode runtime config for hns3 > > v1->v2: > - Fix the hns3.rst doc build warining. > > Huisong Li (2): > net/hns3: delete duplicate macro definition > net/hns3: add FDIR VLAN match mode runtime config > Series applied to dpdk-next-net/main, thanks.
Re: [PATCH] buildtools: remove assumption about current work dir
15/06/2023 22:24, Tyler Retzlaff: > On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote: > > According to meson documentation, we should not make any assumptions as > > to what directory a script is called from[1]. The use of "relpath" when > > processing the output of directory globbing is therefore unsafe, as it > > was stripping off paths relative to the current directory - which just > > happened to be the same as the root directory we were processing. > > > > To improve safety, and support meson clones (like muon) which > > don't always run things from the currently processed path, we need to > > explicitly specify that the start parameter for relpath() should be > > "root" value. > > > > [1] https://mesonbuild.com/Reference-manual_functions.html#run_command > > > > Signed-off-by: Bruce Richardson > > --- > Reviewed-by: Tyler Retzlaff Applied, thanks.
[PATCH v5] app/testpmd: add trace dump command
The "dump_trace" CLI command is added to trigger
saving the trace dumps to the trace directory.
The tracing data are saved according to the EAL configuration
(explicit --trace-dir EAL command line parameter alters
the target folder to save). The result dump folder gets the name
like rte--MM-DD-xx-HH-MM-SS format.
This command is useful to get the trace date without exiting
testpmd application and to get the multiple dumps to observe
the situation in dynamics.
Signed-off-by: Viacheslav Ovsiienko
--
v1: https://inbox.dpdk.org/dev/20230609152847.32496-2-viachesl...@nvidia.com
v2: https://inbox.dpdk.org/dev/20230613165845.19109-2-viachesl...@nvidia.com
- changed to save_trace command
- Windows compilation check added
v3: https://inbox.dpdk.org/dev/20230626110734.14126-1-viachesl...@nvidia.com
- reverted to "dump_trace" command
v4:
http://patches.dpdk.org/project/dpdk/patch/20230626115749.8961-1-viachesl...@nvidia.com/
- added missed header file include
- missed #ifdef added for Windows compilation (no trace support
for Windows)
v5: - dump_trace command documented
- dump commands order neating
- checkpatch issue (white space) fixed
---
app/test-pmd/cmdline.c | 8
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++
2 files changed, 15 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5da38b0bb4..18e6e19497 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -39,6 +39,7 @@
#include
#endif
#include
+#include
#include
#include
@@ -8369,6 +8370,10 @@ static void cmd_dump_parsed(void *parsed_result,
rte_devargs_dump(stdout);
else if (!strcmp(res->dump, "dump_lcores"))
rte_lcore_dump(stdout);
+#ifndef RTE_EXEC_ENV_WINDOWS
+ else if (!strcmp(res->dump, "dump_trace"))
+ rte_trace_save();
+#endif
else if (!strcmp(res->dump, "dump_log_types"))
rte_log_dump(stdout);
}
@@ -8383,6 +8388,9 @@ static cmdline_parse_token_string_t cmd_dump_dump =
"dump_mempool#"
"dump_devargs#"
"dump_lcores#"
+#ifndef RTE_EXEC_ENV_WINDOWS
+ "dump_trace#"
+#endif
"dump_log_types");
static cmdline_parse_inst_t cmd_dump = {
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index b755c38c98..8660883ae3 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -598,6 +598,13 @@ Dumps the logical cores list::
testpmd> dump_lcores
+dump trace
+~~
+
+Dumps the tracing data to the folder according to the current EAL settings::
+
+ testpmd> dump_trace
+
dump log types
~~
--
2.18.1
[PATCH v1] event/dlb2: revise QE Weight Feature
Revise QE weight feature to enable from command line just passing a flag. If QE weight feature is enabled simply port cq weight will be same as dequeue depth. Also, update DLB documentation for revised QE weight feature and usage of eventdev application with DLB hardware. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 107 -- drivers/event/dlb2/dlb2.c | 132 +++-- drivers/event/dlb2/dlb2_priv.h | 4 +- 3 files changed, 131 insertions(+), 112 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index f5bf5757c6..c84d153a56 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -17,8 +17,8 @@ Configuration - The DLB PF PMD is a user-space PMD that uses VFIO to gain direct -device access. To use this operation mode, the PCIe PF device must be bound -to a DPDK-compatible VFIO driver, such as vfio-pci. +device access. To use this operation mode, the PCIe PF device must +be bound to a DPDK-compatible VFIO driver, such as vfio-pci. Eventdev API Notes -- @@ -395,26 +395,6 @@ The depth must be between 32 and 1024, and must be a power of 2. --allow ea:00.0,max_enqueue_depth= -QE Weight -~ - -DLB supports advanced scheduling mechanisms, such as CQ weight. -Each load balanced CQ has a configurable work capacity (max 256) -which corresponds to the total QE weight DLB will allow to be enqueued -to that consumer. Every load balanced event/QE carries a weight of 0, 2, 4, -or 8 and DLB will increment a (per CQ) load indicator when it schedules a -QE to that CQ. The weight is also stored in the history list. When a -completion arrives, the weight is popped from the history list and used to -decrement the load indicator. This creates a new scheduling condition - a CQ -whose load is equal to or in excess of capacity is not available for traffic. -Note that the weight may not exceed the maximum CQ depth. - -.. code-block:: console - - --allow ea:00.0,cq_weight=all: - --allow ea:00.0,cq_weight=qidA-qidB: - --allow ea:00.0,cq_weight=qid: - Producer Coremask ~ @@ -450,3 +430,86 @@ won't be used. .. code-block:: console --allow ea:00.0,default_port_allocation= + +QE Weight +~ + +DLB supports advanced scheduling mechanisms, such as CQ weight. +Each load balanced CQ has a configurable work capacity (max 256) +which corresponds to the total QE weight DLB will allow to be enqueued +to that consumer. Every load balanced event/QE carries a weight of 0, 2, 4, +or 8 and DLB will increment a (per CQ) load indicator when it schedules a +QE to that CQ. The weight is also stored in the history list. When a +completion arrives, the weight is popped from the history list and used to +decrement the load indicator. This creates a new scheduling condition - a CQ +whose load is equal to or in excess of capacity is not available for traffic. +Note that the weight may not exceed the maximum CQ depth. + +Example command to enable QE Weight feature: + +.. code-block:: console + + --allow ea:00.0,enable_cq_weight= + +Running Eventdev Applications with DLB Device +- +This section explains how to run eventdev applications +with DLB hardware as well as difference in command line parameter +to switch between a DLB hardware and a virtual eventdev device such as SW0, hence +users can run applications with or without DLB device to compare performance of +a DLB device. + +In order to run eventdev applications, DLB device must be bound +to a DPDK-compatible VFIO driver, such as vfio-pci. + +Example command to bind DLB device to vfio-pci driver: + +.. code-block:: console + + ../usertools/dpdk-devbind.py -b vfio-pci ea:00.0 + +Eventdev applications can be run with or without a DLB device. +Below examples give details of running eventdev application without DLB device +and with DLB device. Notice that the primary difference between two examples are +passing the parameter ``--vdev ``. The first example run uses a virtual +eventdev device SW0 while second example run directly and picks DLB device from +VFIO driver. + +Example command to run eventdev application without a DLB device: + + .. code-block:: console + + sudo /app/dpdk-test-eventdev --vdev=event_sw0 -- \ + --test=order_queue --plcores 1 --wlcores 2,3 + +After binding DLB device to a supported pci driver such as vfio-pci, +eventdev applications can be run on the DLB device. + +Example command to run eventdev application with a DLB device: + + .. code-block:: console + + sudo build/app/dpdk-test-eventdev -- --test=order_queue\ + --plcores=1 --wlcores=2-7 --stlist=o --worker_deq_depth=128\ + --prod_enq_burst_sz=64 --nb_flows=64 --nb_pkts=100 + +A particula
Re: [PATCH v5] build: prevent accidentally building without NUMA support
15/06/2023 16:38, Bruce Richardson: > When libnuma development package is missing on a system, DPDK can still > be built but will be missing much-needed support for NUMA memory > management. This may later cause issues at runtime if the resulting > binary is run on a NUMA system. > > We can reduce the incidence of such runtime errors by ensuring that, for > native builds*, libnuma is present - unless the user actually specifies > via "max_numa_nodes" that they don't require NUMA support. Having this > as an error condition is also in keeping with what is documented in the > Linux GSG doc, where libnuma is listed as a requirement for building > DPDK [1]. > > * NOTE: cross-compilation builds have a different logic set, with a > separate "numa" value indicating if numa support is necessary. > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > Signed-off-by: Bruce Richardson > Signed-off-by: David Marchand > > --- > V5: Rebase on main, since dependencies merged > > V4: Add Depends-on tag so CI picks up dependency > > V3: > - install 32-bit libnuma packages on CI systems [thanks to David > for the changes] > - split the patch out of the previous patchset, so it can be tracked > separately from the more minor fixup changes. > > V2: Limit check to linux only Is the test ci/Intel-compilation fixed? Could you send a new version for testing the CI?
Re: [PATCH] lib: fix coverity for unused variable
16/06/2023 13:06, Amit Prakash Shukla:
> Removed variable "rc" that stored a return value from a function
> rte_lpm6_lookup_bulk_func.
You are not really removing the variable, right?
It looks you just stop storing the return of this function.
Whouldn't it better to check the return code?
> Coverity issue: 385595
> Fixes: 20365d793e45 ("node: add IPv6 lookup node")
>
> Signed-off-by: Amit Prakash Shukla
> ---
> lib/node/ip6_lookup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
> index e4bbc7ed67..2b20194295 100644
> --- a/lib/node/ip6_lookup.c
> +++ b/lib/node/ip6_lookup.c
> @@ -135,7 +135,7 @@ ip6_lookup_node_process_scalar(struct rte_graph *graph,
> struct rte_node *node,
> node_mbuf_priv1(mbuf3, dyn)->ttl = ipv6_hdr->hop_limits;
> rte_memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16);
>
> - rc = rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop, 4);
> + rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop, 4);
>
> next_hop[0] = (next_hop[0] < 0) ? (int32_t)drop_nh :
> next_hop[0];
> node_mbuf_priv1(mbuf0, dyn)->nh = (uint16_t)next_hop[0];
>
Re: [PATCH 0/2] support IPv4 fragment matching in transfer rules
On 6/23/2023 5:58 PM, Artemii Morozov wrote: > This patch seria adds support for matching fragment offsets for IPv4 packets, > but with some limitations. Exact matching is supported only for zero offset, > ranges are allowed for non-zero offsets. > > Artemii Morozov (2): > common/sfc_efx/base: add MAE IP fragmentation match bits > net/sfc: support IPv4 fragment matching in transfer rules > Hi Artemii, There is a build error, can you please fix it: ../drivers/net/sfc/sfc_mae.c: In function ‘sfc_mae_rule_parse_item_ipv4’: ../drivers/net/sfc/sfc_mae.c:2335:22: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 2335 | last = item->last; | ^ cc1: all warnings being treated as errors
[PATCH] app/testpmd: add dump command help message
There was missing "dump_x" commands help message.
Patch adds support for "help dump" command to see one.
Signed-off-by: Viacheslav Ovsiienko
---
app/test-pmd/cmdline.c | 43 --
1 file changed, 41 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 18e6e19497..9edbb7d04f 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -92,6 +92,7 @@ static void cmd_help_brief_parsed(__rte_unused void
*parsed_result,
"help ports : Configuring ports.\n"
"help filters: Filters configuration
help.\n"
"help traffic_management : Traffic Management
commands.\n"
+ "help dump : Dumps related
commands.\n"
"help devices: Device related
commands.\n"
"help drivers: Driver specific
commands.\n"
"help all: All of the above
sections.\n\n"
@@ -982,6 +983,44 @@ static void cmd_help_long_parsed(void *parsed_result,
);
}
+ if (show_all || !strcmp(res->section, "dump")) {
+ cmdline_printf(
+ cl,
+ "\n"
+ "Dump Commands:\n"
+ "--\n"
+ "dump_physmem\n"
+ "Dumps all physical memory segment layouts\n\n"
+
+ "dump_socket_mem\n"
+ "Dumps the memory usage of all sockets\n\n"
+
+ "dump_memzone\n"
+ "Dumps the layout of all memory zones\n\n"
+
+ "dump_struct_sizes\n"
+ "Dumps the size of all memory structures\n\n"
+
+ "dump_ring\n"
+ "Dumps the status of all or specific element in
DPDK rings\n\n"
+
+ "dump_mempool\n"
+ "Dumps the statistics of all or specific memory
pool\n\n"
+
+ "dump_devargs\n"
+ "Dumps the user device list\n\n"
+
+ "dump_lcores\n"
+ "Dumps the logical cores list\n\n"
+
+ "dump_trace\n"
+ "Dumps the tracing data to the folder according to
the current EAL settings\n\n"
+
+ "dump_log_types\n"
+ "Dumps the log level for all the dpdk modules\n\n"
+ );
+ }
+
if (show_all || !strcmp(res->section, "devices")) {
cmdline_printf(
cl,
@@ -1016,13 +1055,13 @@ static cmdline_parse_token_string_t cmd_help_long_help =
static cmdline_parse_token_string_t cmd_help_long_section =
TOKEN_STRING_INITIALIZER(struct cmd_help_long_result, section,
"all#control#display#config#ports#"
- "filters#traffic_management#devices#drivers");
+ "filters#traffic_management#dump#devices#drivers");
static cmdline_parse_inst_t cmd_help_long = {
.f = cmd_help_long_parsed,
.data = NULL,
.help_str = "help all|control|display|config|ports|"
- "filters|traffic_management|devices|drivers: "
+ "filters|traffic_management|dump|devices|drivers: "
"Show help",
.tokens = {
(void *)&cmd_help_long_help,
--
2.18.1
Re: [PATCH v4 0/5] Logging related patchs
On Tue, 27 Jun 2023 09:40:01 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and extends some earlier work on logging. > > > > Stephen Hemminger (5): > > eal: unify logging code for FreeBsd and Linux > > eal: turn off getopt_long error message during eal_log_level > > eal: skip stdio on console logging > > eal: move logging initialization earlier > > eal: add option to put timestamp on console output > > Series-acked-by: Morten Brørup > There are a few bugs, still working them out. In initial review feedback there was desire for timestamp feature to be global. I.e secondary process would show time since start of primary. But this would hard to implement due to chicken/egg issues during argument parsing during startup; so made a decision that it wasn't worth doing.
Re: [PATCH 0/5] cleanup in library header files
14/06/2023 16:46, Bruce Richardson: > On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > > the three first patches are fixing a lot of comments. > > As it is not critical, they are not marked for backport. > > > > While looking the header files, I've fixed some misuses of "extern". > > > > > > Thomas Monjalon (5): > > lib: remove blank line ending comment blocks > > lib: remove extra asterisks ending comment blocks > > lib: align comment blocks > > lib: restrict use of keyword extern > > cryptodev: fix comments of modular operation parameters > > > > Some really good cleanup here, thanks. > > Not sure we need to fix the use of extern for functions, but removing the > extern is harmless so ok for it. > > Series-acked-by: Bruce Richardson Applied
Re: [PATCH v4 0/5] Logging related patchs
On Tue, Jun 27, 2023 at 09:40:01AM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 26 June 2023 20.42 > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [PATCH v4 0/5] Logging related patchs > > > > This patch set rebases and extends some earlier work on logging. > > > > Stephen Hemminger (5): > > eal: unify logging code for FreeBsd and Linux > > eal: turn off getopt_long error message during eal_log_level > > eal: skip stdio on console logging > > eal: move logging initialization earlier > > eal: add option to put timestamp on console output > > Series-acked-by: Morten Brørup > Gave it a quick sanity-test run on FreeBSD and all looks ok to me. Tested-by: Bruce Richardson
RE: [PATCH v4 0/5] Logging related patchs
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 27 June 2023 16.49 > > On Tue, 27 Jun 2023 09:40:01 +0200 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday, 26 June 2023 20.42 > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [PATCH v4 0/5] Logging related patchs > > > > > > This patch set rebases and extends some earlier work on logging. > > > > > > Stephen Hemminger (5): > > > eal: unify logging code for FreeBsd and Linux > > > eal: turn off getopt_long error message during eal_log_level > > > eal: skip stdio on console logging > > > eal: move logging initialization earlier > > > eal: add option to put timestamp on console output > > > > Series-acked-by: Morten Brørup > > > > There are a few bugs, still working them out. > In initial review feedback there was desire for timestamp feature > to be global. I.e secondary process would show time since start > of primary. But this would hard to implement due to chicken/egg > issues during argument parsing during startup; so made a decision > that it wasn't worth doing. I suppose it could be implemented with a piece of shared memory set by the primary process and read by secondary processes, holding the start time offset from a system global timer (e.g. CLOCK_MONOTONIC) and a tristate variable telling if timestamps are configured - which, if true or false, overrides any timestamp parameter given to the secondary process. Anyway, secondary process support is far from perfect, so I wouldn't worry too much about getting timestamp parameters from the primary process to the secondary process either. In short: I agree with your decision.
Re: [PATCH v5] app/testpmd: add trace dump command
On 6/27/2023 2:09 PM, Viacheslav Ovsiienko wrote: > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > The tracing data are saved according to the EAL configuration > (explicit --trace-dir EAL command line parameter alters > the target folder to save). The result dump folder gets the name > like rte--MM-DD-xx-HH-MM-SS format. > > This command is useful to get the trace date without exiting > testpmd application and to get the multiple dumps to observe > the situation in dynamics. > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ferruh Yigit Help message for dump_trace command are still missing, but all can be added with a single commit, so OK to continue with this. Applied to dpdk-next-net/main, thanks.
Re: [PATCH v11 2/2] gro : add support for IPv6 GRO
21/06/2023 10:38, Kumara Parameshwaran: > Add support for IPv6 GRO for TCP packets > > Signed-off-by: Kumara Parameshwaran Did minor fixes in documentation, added review tag from Jiayu (please keep it in your patch when received) and applied, thanks.
RE: [EXT] Re: [PATCH] lib: fix coverity for unused variable
Hi Thomas,
Please find my reply inline.
Thanks,
Amit Shukla
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, June 27, 2023 7:15 PM
> To: Amit Prakash Shukla
> Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh
> Bhagavatula ; dev@dpdk.org; Jerin Jacob
> Kollanukkaran
> Subject: [EXT] Re: [PATCH] lib: fix coverity for unused variable
>
> External Email
>
> --
> 16/06/2023 13:06, Amit Prakash Shukla:
> > Removed variable "rc" that stored a return value from a function
> > rte_lpm6_lookup_bulk_func.
>
> You are not really removing the variable, right?
> It looks you just stop storing the return of this function.
> Whouldn't it better to check the return code?
Yes, I am just not storing the return value. The reason to not
store return code is to avoid return code check in datapath.
rte_lpm6_lookup_bulk_func will return error only if
lpm6, ip_batch, next_hop are NULL. In function ip6_lookup_node_process_scalar
these variables will never be NULL.
>
>
> > Coverity issue: 385595
> > Fixes: 20365d793e45 ("node: add IPv6 lookup node")
> >
> > Signed-off-by: Amit Prakash Shukla
> > ---
> > lib/node/ip6_lookup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c index
> > e4bbc7ed67..2b20194295 100644
> > --- a/lib/node/ip6_lookup.c
> > +++ b/lib/node/ip6_lookup.c
> > @@ -135,7 +135,7 @@ ip6_lookup_node_process_scalar(struct rte_graph
> *graph, struct rte_node *node,
> > node_mbuf_priv1(mbuf3, dyn)->ttl = ipv6_hdr->hop_limits;
> > rte_memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16);
> >
> > - rc = rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop,
> 4);
> > + rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop, 4);
> >
> > next_hop[0] = (next_hop[0] < 0) ? (int32_t)drop_nh :
> next_hop[0];
> > node_mbuf_priv1(mbuf0, dyn)->nh =
> (uint16_t)next_hop[0];
> >
>
>
>
>
Re: [PATCH] app/testpmd: add dump command help message
On 6/27/2023 3:44 PM, Viacheslav Ovsiienko wrote: > There was missing "dump_x" commands help message. > Patch adds support for "help dump" command to see one. > Hi Slava, Thanks for the patch, this seems missed for a while. > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/cmdline.c | 43 -- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 18e6e19497..9edbb7d04f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -92,6 +92,7 @@ static void cmd_help_brief_parsed(__rte_unused void > *parsed_result, > "help ports : Configuring ports.\n" > "help filters: Filters configuration > help.\n" > "help traffic_management : Traffic Management > commands.\n" > + "help dump : Dumps related > commands.\n" I am not sure 'dump_*' commands are unique group to make a new help section, even description is vague "dump related ..", or if they are important enough for a new section, what would you think to append them to 'display' section?
[PATCH] config/ppc: fix gcc "internal compiler error" message for p10
Building DPDK with gcc 11.3.x for the power10 instruction set may
generate the following error:
../drivers/mempool/cnxk/cnxk_mempool_ops.c
during RTL pass: final
../drivers/mempool/cnxk/cnxk_mempool_ops.c:
In function ‘cnxk_mempool_alloc’:
../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1:
internal compiler error: output_operand: invalid expression as operand
124 | }
| ^
Please submit a full bug report,
with preprocessed source if appropriate.
...
ninja: build stopped: subcommand failed.
The same issue is not encoutered when building with gcc 11.4 or
later, where the compiler automatically adds the option
"-mno-block-ops-vector-pair" when building for power10 which
is intended as a code optimization and also effectively avoids
the compiler bug displayed.
Modify the meson.build file for ppc and manually set the flag when
building for power10 with gcc less than 11.4.
Bugzilla ID: 1251
Signed-off-by: David Christensen
Tested-by: Thinh Tran
---
config/ppc/meson.build | 8
1 file changed, 8 insertions(+)
diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index 1cba44011f..160b203cb1 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -105,6 +105,14 @@ else
endif
endif
machine_args = ['-mcpu=' + cpu_instruction_set, '-mtune=' +
cpu_instruction_set]
+
+# gcc versions < 11.4 may fail to build for power10, see
https://bugs.dpdk.org/show_bug.cgi?id=1251.
+# Explicitly specify a default used in gcc 11.4 and later to workaround the
issue
+if (cpu_instruction_set == 'power10' and cc.get_id() == 'gcc' and
+cc.version().version_compare('<=11.4'))
+machine_args += '-mno-block-ops-vector-pair'
+endif
+
dpdk_conf.set('RTE_MACHINE', cpu_instruction_set)
--
2.31.1
[PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10
Building DPDK with gcc 11.3.x for the power10 instruction set may
generate the following error:
../drivers/mempool/cnxk/cnxk_mempool_ops.c
during RTL pass: final
../drivers/mempool/cnxk/cnxk_mempool_ops.c:
In function ‘cnxk_mempool_alloc’:
../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1:
internal compiler error: output_operand: invalid expression as operand
124 | }
| ^
Please submit a full bug report,
with preprocessed source if appropriate.
...
ninja: build stopped: subcommand failed.
The same issue is not encountered when building with gcc 11.4 or
later, where the compiler automatically adds the option
"-mno-block-ops-vector-pair" when building for power10 which
is intended as a code optimization and also effectively avoids
the compiler bug displayed.
Modify the meson.build file for ppc and manually set the flag when
building for power10 with gcc less than 11.4.
Bugzilla ID: 1251
Signed-off-by: David Christensen
Tested-by: Thinh Tran
---
v2:
- Fixed spelling error in commit message
---
config/ppc/meson.build | 8
1 file changed, 8 insertions(+)
diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index 1cba44011f..160b203cb1 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -105,6 +105,14 @@ else
endif
endif
machine_args = ['-mcpu=' + cpu_instruction_set, '-mtune=' +
cpu_instruction_set]
+
+# gcc versions < 11.4 may fail to build for power10, see
https://bugs.dpdk.org/show_bug.cgi?id=1251.
+# Explicitly specify a default used in gcc 11.4 and later to workaround the
issue
+if (cpu_instruction_set == 'power10' and cc.get_id() == 'gcc' and
+cc.version().version_compare('<=11.4'))
+machine_args += '-mno-block-ops-vector-pair'
+endif
+
dpdk_conf.set('RTE_MACHINE', cpu_instruction_set)
--
2.31.1
Re: [PATCH v2 0/3] bus/cdx: fix coverity issue
19/06/2023 05:58, Nipun Gupta: > > Please use in-reply-to while sending subsequent version of patches. > > On 6/16/2023 6:09 PM, Abhijit Gangurde wrote: > > This series fixes coverity issues 385379, 385381, 385377 > > > > v2: > > - Merged coverity fix patches into series > > - Updated commit message > > Series Acked-by: Nipun Gupta Applied, thanks.
Re: [PATCH] config/arm: add AMD CDX
16/06/2023 10:36, Ruifeng Wang: > > -Original Message- > > From: Nipun Gupta > > Sent: Friday, June 16, 2023 12:19 AM > > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > > Cc: ferruh.yi...@amd.com; nikhil.agar...@amd.com; Ruifeng Wang > > ; > > Honnappa Nagarahalli ; Nipun Gupta > > > > Subject: [PATCH] config/arm: add AMD CDX > > > > Add meson build configuration for AMD CDX platform. > > > > Signed-off-by: Nipun Gupta > > Acked-by: Ruifeng Wang Applied, thanks.
Re: [PATCH] config/arm: add HiSilicon hip10
27/06/2023 05:13, Ruifeng Wang: > > -Original Message- > > From: Dongdong Liu > > Sent: Monday, June 26, 2023 8:43 PM > > To: dev@dpdk.org; ferruh.yi...@amd.com; tho...@monjalon.net; Ruifeng Wang > > > > Subject: [PATCH] config/arm: add HiSilicon hip10 > > > > Adding support for HiSilicon hip10 platform. > > > > Signed-off-by: Dongdong Liu > > --- > > config/arm/arm64_hip10_linux_gcc | 16 > > config/arm/meson.build | 19 +++ > > 2 files changed, 35 insertions(+) > > create mode 100644 config/arm/arm64_hip10_linux_gcc > > > Acked-by: Ruifeng Wang Applied, thanks.
Re: [EXT] Re: [PATCH] lib: fix coverity for unused variable
27/06/2023 18:05, Amit Prakash Shukla: > Hi Thomas, > > Please find my reply inline. > > Thanks, > Amit Shukla > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, June 27, 2023 7:15 PM > > To: Amit Prakash Shukla > > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > > Bhagavatula ; dev@dpdk.org; Jerin Jacob > > Kollanukkaran > > Subject: [EXT] Re: [PATCH] lib: fix coverity for unused variable > > > > External Email > > > > -- > > 16/06/2023 13:06, Amit Prakash Shukla: > > > Removed variable "rc" that stored a return value from a function > > > rte_lpm6_lookup_bulk_func. > > > > You are not really removing the variable, right? > > It looks you just stop storing the return of this function. > > Whouldn't it better to check the return code? > > Yes, I am just not storing the return value. The reason to not > store return code is to avoid return code check in datapath. > rte_lpm6_lookup_bulk_func will return error only if > lpm6, ip_batch, next_hop are NULL. In function ip6_lookup_node_process_scalar > these variables will never be NULL. I will update the commit message accordingly.
Re: [PATCH v2] config/arm: add Ampere Altra/AltraMax/AmpereOne platform
16/06/2023 05:17, Ruifeng Wang: > > -Original Message- > > From: Yutang Jiang > > Sent: Thursday, June 15, 2023 7:24 PM > > To: dev@dpdk.org > > Cc: patc...@amperecomputing.com; yutang.ji...@amperecomputing.com; > > jiangyut...@os.amperecomputing.com; Ruifeng Wang ; nd > > ; > > juraj.lin...@pantheon.tech > > Subject: [PATCH v2] config/arm: add Ampere Altra/AltraMax/AmpereOne platform > > > > This patch add Ampere series platform support for DPDK: > > 1. Merging the eMAG and AmpereOne to the one struct implementer_ampere. > > 2. The microarchitecture of Altra/AltraMax is N1, which > > implementer/part_number > >is defined in arm, so the definition of RTE_MAX_LCORE/RTE_MAX_NUMA_NODES > >refers to the quadrant sub-numa definition in AltraMax 2P system. > > 3. Added basic definition of AmpereOne. > > > > Signed-off-by: Yutang Jiang > > Acked-by: Ruifeng Wang Sorted alphabetically and applied, thanks.
Re: [EXT] Re: [PATCH] lib: fix coverity for unused variable
27/06/2023 23:52, Thomas Monjalon: > 27/06/2023 18:05, Amit Prakash Shukla: > > From: Thomas Monjalon > > > 16/06/2023 13:06, Amit Prakash Shukla: > > > > Removed variable "rc" that stored a return value from a function > > > > rte_lpm6_lookup_bulk_func. > > > > > > You are not really removing the variable, right? > > > It looks you just stop storing the return of this function. > > > Whouldn't it better to check the return code? > > > > Yes, I am just not storing the return value. The reason to not > > store return code is to avoid return code check in datapath. > > rte_lpm6_lookup_bulk_func will return error only if > > lpm6, ip_batch, next_hop are NULL. In function > > ip6_lookup_node_process_scalar > > these variables will never be NULL. > > I will update the commit message accordingly. Applied with updated explanation: node: remove useless return code assignment No need to store the return code of rte_lpm6_lookup_bulk_func() as it returns error only if parameters are NULL. In the function ip6_lookup_node_process_scalar(), these variables will never be NULL. Not checking the return code will avoid check in datapath. Storing of the return code is useless and removed.
Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config
27/06/2023 09:11, Dongdong Liu: > +- ``fdir_vlan_match_mode`` (default `strict`) > + > + Used to select VLAN match mode. This runtime config can be `strict` > + or `nostrict` and is only valid for PF drives. drives? Do you mean devices? > + If driver works on `strict` mode (default mode), hardware does strictly > + match the input flow base on VLAN number. > + > + For the following scenarios with two rules: > + > + .. code-block:: console > + > +rule0: > + pattern: eth type is 0x0806 > + actions: queue index 3 > +rule1: > + pattern: eth type is 0x0806 / vlan vid is 20 > + actions: queue index 4 > + > + If application select `strict` mode, only the ARP packets with VLAN > + 20 are directed to queue 4, and the ARP packets with other VLAN ID > + cannot be directed to the specified queue. If application want to all > + ARP packets with or without VLAN to be directed to the specified queue, > + application can select `nostrict` mode and just need to set rule0. As it is done in the rest of the document, you should use double backquotes for values of the devargs.
Re: [PATCH] maintainers: update for OCTEON EP and CNXK DMA
> > Marvell OCTEON TX EP - endpoint > > -M: Radha Mohan Chintakuntla > > -M: Veerasenareddy Burru > > -M: Sathesh Edara > > +M: Vamsi Attunuru > > T: git://dpdk.org/next/dpdk-next-net-mrvl > > F: drivers/net/octeon_ep/ > > F: doc/guides/nics/features/octeon_ep.ini > > @@ -1250,8 +1248,7 @@ F: drivers/dma/hisilicon/ > > F: doc/guides/dmadevs/hisilicon.rst > > > > Marvell CNXK DPI DMA > > -M: Radha Mohan Chintakuntla > > -M: Veerasenareddy Burru > > +M: Vamsi Attunuru > > F: drivers/dma/cnxk/ > > F: doc/guides/dmadevs/cnxk.rst > > > > Acked-by: Radha Mohan Chintakuntla > Acked-by: Sathesh B Edara Applied
Re: [PATCH v1 1/1] maintainers: update maintainership of power lib
15/06/2023 11:16, Anatoly Burakov: > Add co-maintainer for power library. > > Signed-off-by: Anatoly Burakov [...] > Power management > +M: Anatoly Burakov > M: David Hunt > F: lib/power/ > F: doc/guides/prog_guide/power_man.rst I have to ask for a word from David Hunt.
Re: [PATCH] maintainers: update for PCI bus driver and library
13/06/2023 08:57, Chenbo Xia: > Add myself as maintainer of PCI bus driver and co-maintainer of PCI > library. > > Signed-off-by: Chenbo Xia Applied, thanks Chenbo.
Re: [PATCH v1] maintainers: update maintainer for DLB Driver
26/06/2023 10:04, Abdullah Sevincer: > Abdullah Sevincer is now maintainer for DLB Driver. > > Signed-off-by: Abdullah Sevincer > --- > Intel DLB2 > -M: Timothy McDaniel > +M: Abdullah Sevincer Would you be able to get an ack from Timothy?
Re: [PATCH v3] net/bnx2x: offer maintainership for bnx2x
We are waiting for an ack here. 02/06/2023 09:52, Julien Aube: > This is an offer to maintain the code for bnx2x-based > cards. It may not be possible on the long run due to > the old design of this chipset. > > Note that I'm not affiliated with LSI nor Broadcom and > do not have access to documentation or other NDA-based > code. > > Signed-off-by: Julien Aube > --- > .mailmap | 1 + > MAINTAINERS | 3 +-- > doc/guides/rel_notes/deprecation.rst | 3 --- > 3 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/.mailmap b/.mailmap > index db85cc66c6..cb689ef751 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -666,6 +666,7 @@ JP Lee > Juan Antonio Montesinos > Juhamatti Kuusisaari > Juho Snellman > +Julien Aube > Julien Castets > Julien Courtat > Julien Cretin > diff --git a/MAINTAINERS b/MAINTAINERS > index a5219926ab..563f8c56eb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -940,8 +940,7 @@ F: drivers/net/pfe/ > F: doc/guides/nics/features/pfe.ini > > Marvell QLogic bnx2x > -M: Rasesh Mody > -M: Shahed Shaikh > +M: Julien Aube > T: git://dpdk.org/next/dpdk-next-net-mrvl > F: drivers/net/bnx2x/ > F: doc/guides/nics/bnx2x.rst > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index dcc1ca1696..6b7c644ef8 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -118,9 +118,6 @@ Deprecation Notices >The legacy actions should be removed >once ``MODIFY_FIELD`` alternative is implemented in drivers. > > -* net/bnx2x: Starting from DPDK 23.07, the Marvell QLogic bnx2x driver will > be removed. > - This decision has been made to alleviate the burden of maintaining a > discontinued product. > - > * net/liquidio: Remove LiquidIO ethdev driver. >The LiquidIO product line has been substituted >with CN9K/CN10K OCTEON product line smart NICs located in > ``drivers/net/octeon_ep/``. >
Re: [PATCH] maintainers: update for PCI bus driver
22/06/2023 10:55, Ferruh Yigit: > On 6/15/2023 5:14 PM, Nipun Gupta wrote: > > Add myself as co-maintainer of PCI bus driver > > > > Signed-off-by: Nipun Gupta > > --- > > This patch is based on top of: > > http://patches.dpdk.org/project/dpdk/patch/20230613065738.42370-1-chenbo@intel.com/ > > > > PCI bus driver > > M: Chenbo Xia > > +M: Nipun Gupta > > F: drivers/bus/pci/ > > Acked-by: Ferruh Yigit Applied, thanks Nipun.
Re: [PATCH v2] config/ppc: fix gcc "internal compiler error" message for p10
27/06/2023 23:03, David Christensen: > Building DPDK with gcc 11.3.x for the power10 instruction set may > generate the following error: > > ../drivers/mempool/cnxk/cnxk_mempool_ops.c > during RTL pass: final > ../drivers/mempool/cnxk/cnxk_mempool_ops.c: > In function ‘cnxk_mempool_alloc’: > ../drivers/mempool/cnxk/cnxk_mempool_ops.c:124:1: > internal compiler error: output_operand: invalid expression as operand > 124 | } > | ^ > Please submit a full bug report, > with preprocessed source if appropriate. > ... > ninja: build stopped: subcommand failed. > > The same issue is not encountered when building with gcc 11.4 or > later, where the compiler automatically adds the option > "-mno-block-ops-vector-pair" when building for power10 which > is intended as a code optimization and also effectively avoids > the compiler bug displayed. > > Modify the meson.build file for ppc and manually set the flag when > building for power10 with gcc less than 11.4. > > Bugzilla ID: 1251 > > Signed-off-by: David Christensen > Tested-by: Thinh Tran Applied, thanks. Note: IBM POWER support is still marked as alpha. Would you like to work on its status?
Re: [PATCH v4] doc: prefer installing using meson rather than ninja
23/06/2023 13:43, Bruce Richardson: > After doing a build, to install DPDK system-wide our documentation > recommended using the "ninja install" command. However, for anyone > building as a non-root user and only installing as root, the "meson > install" command is a better alternative, as it provides for > automatically dropping or elevating privileges as necessary in more > recent meson releases [1]. > > [1] https://mesonbuild.com/Installing.html#installing-as-the-superuser > > Signed-off-by: Bruce Richardson Applied, thanks.
Re: [PATCH] examples/ntb: remove redundant logic for dev close
14/06/2023 07:14, Junfeng Guo: > During EAL cleanup stage, all bus devices are cleaned up properly. > Based on this, there is no need to do extra device close process, > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > If this dev ops for ntb was called twice, the interrupt handle for > EAL will be disabled twice and will lead to error for the seconde > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" You should fix ntb to not disable interrupt twice.
Re: [dpdk-dev] [PATCH v1] doc: fix ip6 node API doxygen generation
> > Add ip6 node public API to doxygen list.
> >
> > Fixes: 20365d793e45 ("node: add IPv6 lookup node")
> > Cc: Sunil Kumar Kori
> > Cc: Amit Prakash Shukla
> > Cc: Nithin Dabilpuram
> >
> > Signed-off-by: Jerin Jacob
> > ---
> > doc/api/doxy-api-index.md | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Acked-by: Sunil Kumar Kori
Applied, thanks.
Re: [PATCH] app: do not call printf in signal handlers
15/06/2023 22:14, Tyler Retzlaff:
> On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote:
> > Using printf is not async-signal safe and worst case may lead to deadlock.
> > Remove printf from signal handlers present in several applications.
> >
> > Testpmd was already fixed by
> > commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
> >
> > Signed-off-by: Prateek Agarwal
> > Signed-off-by: Stephen Hemminger
> > ---
>
> Acked-by: Tyler Retzlaff
Applied, thanks for reviving this old patch.
release candidate 23.07-rc2
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.07-rc2 There are 237 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_07.html There were a lot of updates in drivers. The driver features should be frozen now. Please test and report issues on bugs.dpdk.org. Do not forget to review examples, tests and documentation updates. Breaking changes for 23.11 must be announced in 23.07. DPDK 23.07-rc3 is expected in approximately one week. Thank you everyone
Re: [PATCH v14 5/6] memarea: support dump API
Hi Anatoly,
Thanks for your review, a lot of valuable advice.
PS: This library stays for a long time, want to hear TB's opinion: whether to
continue or stop.
If continue I will push a new version.
Thanks.
On 2023/6/22 23:55, Burakov, Anatoly wrote:
> On 2/9/2023 6:36 AM, Chengwen Feng wrote:
>> This patch supports rte_memarea_dump() API which could be used for
>> debug.
>>
>> Signed-off-by: Chengwen Feng
>> Reviewed-by: Dongdong Liu
>> Acked-by: Morten Brørup
>> ---
>
> Provisionally,
>
> Acked-by: Anatoly Burakov
>
> As long as below is addressed.
>
>> +static void
>> +memarea_dump_objects_detail(struct rte_memarea *ma, FILE *f)
>> +{
>> + struct memarea_objhdr *hdr;
>> + size_t offset;
>> + void *ptr;
>> +
>> + fprintf(f, " objects:\n");
>> + TAILQ_FOREACH(hdr, &ma->obj_list, obj_next) {
>> + if (hdr == ma->guard_hdr)
>> + break;
>> + memarea_check_cookie(ma, hdr, 2);
>> + ptr = RTE_PTR_ADD(hdr, sizeof(struct memarea_objhdr));
>> + offset = RTE_PTR_DIFF(ptr, ma->area_base);
>> +#ifdef RTE_LIBRTE_MEMAREA_DEBUG
>> + fprintf(f, " %p off: 0x%zx size: 0x%zx %s\n",
>> + ptr, offset, MEMAREA_OBJECT_GET_SIZE(hdr),
>> + MEMAREA_OBJECT_IS_ALLOCATED(hdr) ? "allocated" : "");
>> +#else
>> + fprintf(f, " off: 0x%zx size: 0x%zx %s\n",
>> + offset, MEMAREA_OBJECT_GET_SIZE(hdr),
>> + MEMAREA_OBJECT_IS_ALLOCATED(hdr) ? "allocated" : "");
>> +#endif
>> + }.
>> +}
>> +
>> +int
>> +rte_memarea_dump(struct rte_memarea *ma, FILE *f, bool dump_all)
>> +{
>> + if (ma == NULL || f == NULL)
>> + return -EINVAL;
>
> I feel like the API is inconsistent in this way. I would suggest picking a
> method of error reporting, and sticking with it. I would suggest returning
> 0/-1 or ptr/NULL with rte_errno set to indicate error, as that is how most
> libraries in DPDK behave.
>
Re: [PATCH v14 5/6] memarea: support dump API
28/06/2023 03:25, fengchengwen: > Hi Anatoly, > > Thanks for your review, a lot of valuable advice. > > PS: This library stays for a long time, want to hear TB's opinion: whether > to continue or stop. > If continue I will push a new version. Would you be able to attend the techboard meeting today (3pm UTC)? https://core.dpdk.org/techboard/minutes/ We could discuss the value of this library. Anatoly, would you be able to prepare some arguments as well?
Re: [PATCH v14 5/6] memarea: support dump API
On 2023/6/28 9:39, Thomas Monjalon wrote: > 28/06/2023 03:25, fengchengwen: >> Hi Anatoly, >> >> Thanks for your review, a lot of valuable advice. >> >> PS: This library stays for a long time, want to hear TB's opinion: whether >> to continue or stop. >> If continue I will push a new version. > > Would you be able to attend the techboard meeting today (3pm UTC)? Great, I will attend, Thanks. > https://core.dpdk.org/techboard/minutes/ > We could discuss the value of this library. > Anatoly, would you be able to prepare some arguments as well? > > > . >
[PATCH v10] app/dma-perf: introduce dma-perf application
There are many high-performance DMA devices supported in DPDK now, and
these DMA devices can also be integrated into other modules of DPDK as
accelerators, such as Vhost. Before integrating DMA into applications,
developers need to know the performance of these DMA devices in various
scenarios and the performance of CPUs in the same scenario, such as
different buffer lengths. Only in this way can we know the target
performance of the application accelerated by using them. This patch
introduces a high-performance testing tool, which supports comparing the
performance of CPU and DMA in different scenarios automatically with a
pre-set config file. Memory Copy performance test are supported for now.
Signed-off-by: Cheng Jiang
Signed-off-by: Jiayu Hu
Signed-off-by: Yuan Wang
Acked-by: Morten Brørup
Acked-by: Chenbo Xia
---
v10:
rebased code from 23.07-rc2;
v9:
improved error handling;
improved lcore_params structure;
improved mbuf api calling;
improved exit process;
fixed some typos;
added scenario summary data display;
removed unnecessary include;
v8:
fixed string copy issue in parse_lcore();
improved some data display format;
added doc in doc/guides/tools;
updated release notes;
v7:
fixed some strcpy issues;
removed cache setup in calling rte_pktmbuf_pool_create();
fixed some typos;
added some memory free and null set operations;
improved result calculation;
v6:
improved code based on Anoob's comments;
fixed some code structure issues;
v5:
fixed some LONG_LINE warnings;
v4:
fixed inaccuracy of the memory footprint display;
v3:
fixed some typos;
v2:
added lcore/dmadev designation;
added error case process;
removed worker_threads parameter from config.ini;
improved the logs;
improved config file;
app/meson.build| 1 +
app/test-dma-perf/benchmark.c | 508
app/test-dma-perf/config.ini | 61 +++
app/test-dma-perf/main.c | 616 +
app/test-dma-perf/main.h | 64 +++
app/test-dma-perf/meson.build | 17 +
doc/guides/rel_notes/release_23_07.rst | 6 +
doc/guides/tools/dmaperf.rst | 103 +
doc/guides/tools/index.rst | 1 +
9 files changed, 1377 insertions(+)
create mode 100644 app/test-dma-perf/benchmark.c
create mode 100644 app/test-dma-perf/config.ini
create mode 100644 app/test-dma-perf/main.c
create mode 100644 app/test-dma-perf/main.h
create mode 100644 app/test-dma-perf/meson.build
create mode 100644 doc/guides/tools/dmaperf.rst
diff --git a/app/meson.build b/app/meson.build
index 74d2420f67..4fc1a83eba 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -19,6 +19,7 @@ apps = [
'test-cmdline',
'test-compress-perf',
'test-crypto-perf',
+'test-dma-perf',
'test-eventdev',
'test-fib',
'test-flow-perf',
diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
new file mode 100644
index 00..0601e0d171
--- /dev/null
+++ b/app/test-dma-perf/benchmark.c
@@ -0,0 +1,508 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include "main.h"
+
+#define MAX_DMA_CPL_NB 255
+
+#define TEST_WAIT_U_SECOND 1
+#define POLL_MAX 1000
+
+#define CSV_LINE_DMA_FMT "Scenario %u,%u,%s,%u,%u,%u,%u,%.2lf,%" PRIu64
",%.3lf,%.3lf\n"
+#define CSV_LINE_CPU_FMT "Scenario %u,%u,NA,NA,NA,%u,%u,%.2lf,%" PRIu64
",%.3lf,%.3lf\n"
+
+#define CSV_TOTAL_LINE_FMT "Scenario %u Summary, , , , ,
,%u,%.2lf,%u,%.3lf,%.3lf\n"
+
+struct worker_info {
+ bool ready_flag;
+ bool start_flag;
+ bool stop_flag;
+ uint32_t total_cpl;
+ uint32_t test_cpl;
+};
+
+struct lcore_params {
+ uint8_t scenario_id;
+ unsigned int lcore_id;
+ char *dma_name;
+ uint16_t worker_id;
+ uint16_t dev_id;
+ uint32_t nr_buf;
+ uint16_t kick_batch;
+ uint32_t buf_size;
+ uint16_t test_secs;
+ struct rte_mbuf **srcs;
+ struct rte_mbuf **dsts;
+ volatile struct worker_info worker_info;
+};
+
+static struct rte_mempool *src_pool;
+static struct rte_mempool *dst_pool;
+
+static struct lcore_params *lcores[MAX_WORKER_NB];
+
+#define PRINT_ERR(...) print_err(__func__, __LINE__, __VA_ARGS__)
+
+static inline int
+__rte_format_printf(3, 4)
+print_err(const char *func, int lineno, const char *format, ...)
+{
+ va_list ap;
+ int ret;
+
+ ret = fprintf(stderr, "In %s:%d - ", func, lineno);
+ va_start(ap, format);
+ ret += vfprintf(stderr, format, ap);
+ va_end(ap);
+
+ return ret;
+}
+
+static inline void
+calc_result(uint32_t buf_size, uint32_t nr_buf, uint16_t nb_workers, uint16_t
test_secs,
+ uint32_t total_cnt, float *memory, uint32_t
*ave_cycle,
+
DPDK Tech Board call tomorrow morning 8am Pacific/11am Eastern/1500h UTC
Good evening DPDK Community, Tomorrow the tech board meets at 8am Pacific/11am Eastern/1500h UTC. Here is a read-only copy of our agenda: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db And as always the link to join is: https://meet.jit.si/dpdk See you there. Thanks, Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux Foundation 248.835.4812 (mobile) nsouth...@linuxfoundation.org
RE: [PATCH] examples/ntb: remove redundant logic for dev close
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 28, 2023 08:12 > To: Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang > ; Laatz, Kevin ; > Richardson, Bruce > Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev close > > 14/06/2023 07:14, Junfeng Guo: > > During EAL cleanup stage, all bus devices are cleaned up properly. > > Based on this, there is no need to do extra device close process, > > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > > > If this dev ops for ntb was called twice, the interrupt handle for > > EAL will be disabled twice and will lead to error for the seconde > > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" > > You should fix ntb to not disable interrupt twice. Thanks for the comment! Yes, it is exactly what this patch did. The interrupt disabling process is part of 'dev_close' ops, and will be called twice (one in EAL cleanup, another in ntb example cleanup). Now that fixed & covered by the EAL cleanup, there is no need to run dev_close at ntb example. Just remove that redundant logic. Regards, Junfeng >
RE: [PATCH] examples/ntb: remove redundant logic for dev close
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, June 28, 2023 10:19 > To: Thomas Monjalon ; Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang > ; Laatz, Kevin ; > Richardson, Bruce > Subject: RE: [PATCH] examples/ntb: remove redundant logic for dev close > > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, June 28, 2023 08:12 > > To: Wu, Jingjing ; Guo, Junfeng > > > > Cc: dev@dpdk.org; sta...@dpdk.org; He, Xingguang > > ; Laatz, Kevin ; > > Richardson, Bruce > > Subject: Re: [PATCH] examples/ntb: remove redundant logic for dev > close > > > > 14/06/2023 07:14, Junfeng Guo: > > > During EAL cleanup stage, all bus devices are cleaned up properly. > > > Based on this, there is no need to do extra device close process, > > > which may call the dev ops '*dev->dev_ops->dev_close' twice. > > > > > > If this dev ops for ntb was called twice, the interrupt handle for > > > EAL will be disabled twice and will lead to error for the seconde > > > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" > > > > You should fix ntb to not disable interrupt twice. > > Thanks for the comment! > > Yes, it is exactly what this patch did. Another solution is to add extra logic in dev_close, i.e., to do the interrupt disabling process only when the interrupt handler is valid. That is, to disable interrupt only when 'intr_handle->max_intr' or 'intr_handle->nb_efd' is non-zero. But I'm not sure if this method is a better solution. Please help give some advice, thanks! > > The interrupt disabling process is part of 'dev_close' ops, and will be > called twice (one in EAL cleanup, another in ntb example cleanup). > > Now that fixed & covered by the EAL cleanup, there is no need to > run dev_close at ntb example. Just remove that redundant logic. > > Regards, > Junfeng > > >
[PATCH] doc: add release note for new Intel devices
This patch add release note for new Intel devices in this release. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_23_07.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst index 4459144140..355640f7ab 100644 --- a/doc/guides/rel_notes/release_23_07.rst +++ b/doc/guides/rel_notes/release_23_07.rst @@ -200,6 +200,17 @@ New Features Enhanced the GRO library to support TCP packets over IPv6 network. +* **Updated Intel e1000 driver.** + + * Added support for new I219 devices. + +* **Updated Intel igc driver.** + + * Added suuport for I225-LMVP. + +* **Updated Intel ice driver.** + + * Added suuport for new E823 devices. Removed Items - -- 2.25.1
Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config
Hi Thomas Many thanks for your review. On 2023/6/28 7:12, Thomas Monjalon wrote: 27/06/2023 09:11, Dongdong Liu: +- ``fdir_vlan_match_mode`` (default `strict`) + + Used to select VLAN match mode. This runtime config can be `strict` + or `nostrict` and is only valid for PF drives. drives? Do you mean devices? for PF devices, will fix. + If driver works on `strict` mode (default mode), hardware does strictly + match the input flow base on VLAN number. + + For the following scenarios with two rules: + + .. code-block:: console + +rule0: + pattern: eth type is 0x0806 + actions: queue index 3 +rule1: + pattern: eth type is 0x0806 / vlan vid is 20 + actions: queue index 4 + + If application select `strict` mode, only the ARP packets with VLAN + 20 are directed to queue 4, and the ARP packets with other VLAN ID + cannot be directed to the specified queue. If application want to all + ARP packets with or without VLAN to be directed to the specified queue, + application can select `nostrict` mode and just need to set rule0. As it is done in the rest of the document, you should use double backquotes for values of the devargs. Good point, will fix. Thanks, Dongdong. .
RE: [PATCH v5] build: prevent accidentally building without NUMA support
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 9:27 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; David Marchand > Subject: Re: [PATCH v5] build: prevent accidentally building without NUMA > support > > 15/06/2023 16:38, Bruce Richardson: > > When libnuma development package is missing on a system, DPDK can > > still be built but will be missing much-needed support for NUMA memory > > management. This may later cause issues at runtime if the resulting > > binary is run on a NUMA system. > > > > We can reduce the incidence of such runtime errors by ensuring that, > > for native builds*, libnuma is present - unless the user actually > > specifies via "max_numa_nodes" that they don't require NUMA support. > > Having this as an error condition is also in keeping with what is > > documented in the Linux GSG doc, where libnuma is listed as a > > requirement for building DPDK [1]. > > > > * NOTE: cross-compilation builds have a different logic set, with a > > separate "numa" value indicating if numa support is necessary. > > > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: David Marchand > > > > --- > > V5: Rebase on main, since dependencies merged > > > > V4: Add Depends-on tag so CI picks up dependency > > > > V3: > > - install 32-bit libnuma packages on CI systems [thanks to David > > for the changes] > > - split the patch out of the previous patchset, so it can be tracked > > separately from the more minor fixup changes. > > > > V2: Limit check to linux only > > Is the test ci/Intel-compilation fixed? > Could you send a new version for testing the CI? > Sorry, this is caused by intel testbeds lack of dep libnuma, Installed it and re-run the CI, result is PASSED.
[PATCH v2] doc: fix missing release note for I219 support
Add missing release note for I219 support
Fixes: a33e1a5bcd3f ("net/e1000: support more I219 devices")
Signed-off-by: Qiming Yang
---
v2 changes: add fix line
---
doc/guides/rel_notes/release_23_07.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..2d5d22d63e 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -200,6 +200,9 @@ New Features
Enhanced the GRO library to support TCP packets over IPv6 network.
+* **Updated Intel e1000 driver.**
+
+ * Added support for new I219 devices.
Removed Items
-
--
2.25.1
[PATCH] doc: fix missing release note for I225 support
Add missing release note for I225-LMVP support.
Fixes: 431d5e6dc3de ("net/igc: support I225-LMVP device")
Signed-off-by: Qiming Yang
---
doc/guides/rel_notes/release_23_07.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..c4a6043780 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -200,6 +200,9 @@ New Features
Enhanced the GRO library to support TCP packets over IPv6 network.
+* **Updated Intel igc driver.**
+
+ * Added support for I225-LMVP.
Removed Items
-
--
2.25.1
RE: [EXT] [PATCH v10] app/dma-perf: introduce dma-perf application
> There are many high-performance DMA devices supported in DPDK now, > and these DMA devices can also be integrated into other modules of DPDK as > accelerators, such as Vhost. Before integrating DMA into applications, > developers need to know the performance of these DMA devices in various > scenarios and the performance of CPUs in the same scenario, such as > different buffer lengths. Only in this way can we know the target > performance of the application accelerated by using them. This patch > introduces a high-performance testing tool, which supports comparing the > performance of CPU and DMA in different scenarios automatically with a pre- > set config file. Memory Copy performance test are supported for now. > > Signed-off-by: Cheng Jiang > Signed-off-by: Jiayu Hu > Signed-off-by: Yuan Wang > Acked-by: Morten Brørup > Acked-by: Chenbo Xia > --- > v10: > rebased code from 23.07-rc2; > v9: > improved error handling; > improved lcore_params structure; > improved mbuf api calling; > improved exit process; > fixed some typos; > added scenario summary data display; > removed unnecessary include; > v8: > fixed string copy issue in parse_lcore(); > improved some data display format; > added doc in doc/guides/tools; > updated release notes; > v7: > fixed some strcpy issues; > removed cache setup in calling rte_pktmbuf_pool_create(); > fixed some typos; > added some memory free and null set operations; > improved result calculation; > v6: > improved code based on Anoob's comments; > fixed some code structure issues; > v5: > fixed some LONG_LINE warnings; > v4: > fixed inaccuracy of the memory footprint display; > v3: > fixed some typos; > v2: > added lcore/dmadev designation; > added error case process; > removed worker_threads parameter from config.ini; > improved the logs; > improved config file; > > app/meson.build| 1 + > app/test-dma-perf/benchmark.c | 508 > app/test-dma-perf/config.ini | 61 +++ > app/test-dma-perf/main.c | 616 + > app/test-dma-perf/main.h | 64 +++ > app/test-dma-perf/meson.build | 17 + > doc/guides/rel_notes/release_23_07.rst | 6 + > doc/guides/tools/dmaperf.rst | 103 + > doc/guides/tools/index.rst | 1 + > 9 files changed, 1377 insertions(+) > create mode 100644 app/test-dma-perf/benchmark.c create mode 100644 > app/test-dma-perf/config.ini create mode 100644 app/test-dma- > perf/main.c create mode 100644 app/test-dma-perf/main.h create mode > 100644 app/test-dma-perf/meson.build create mode 100644 > doc/guides/tools/dmaperf.rst > Thanks Cheng for addressing all the comments. Acked-by: Anoob Joseph Tested-by: Anoob Joseph
[PATCH] doc: fix missing release note for timestamp offload on iavf
Add missing release note for Rx timestamp offload on vector path.
Fixes: 61b6874b9224 ("net/iavf: support Rx timestamp offload on AVX512")
Signed-off-by: Zhichao Zeng
---
doc/guides/rel_notes/release_23_07.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..cd33607af8 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -125,6 +125,10 @@ New Features
which are being upstreamed:
https://lore.kernel.org/all/20230419134329.346825-1-maxime.coque...@redhat.com/
+* **Updated Intel iavf driver.**
+
+ * Added support for Rx timestamp offload on vector path.
+
* **Updated Marvell cnxk ethdev driver.**
* Added support for reassembly of multi-segment packets.
--
2.34.1
[PATCH] doc: fix missing release note for UFO on iavf and ice
Add missing release note for UDP fragmentation offload on iavf and ice.
Fixes: 0f24dc14654e ("net/iavf: enable UDP fragmentation offload")
Fixes: 623ca7a15db4 ("net/ice: enable UDP fragmentation offload")
Signed-off-by: Zhichao Zeng
---
doc/guides/rel_notes/release_23_07.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..b32276818a 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -125,6 +125,14 @@ New Features
which are being upstreamed:
https://lore.kernel.org/all/20230419134329.346825-1-maxime.coque...@redhat.com/
+* **Updated Intel iavf driver.**
+
+ * Added support for UDP fragmentation offload.
+
+* **Updated Intel ice driver.**
+
+ * Added support for UDP fragmentation offload.
+
* **Updated Marvell cnxk ethdev driver.**
* Added support for reassembly of multi-segment packets.
--
2.34.1
[PATCH] doc: fix missing release note for double vlan on ice
Add missing release note for double vlan on ice driver.
Fixes: de5da9d16430 ("net/ice: support double VLAN")
Signed-off-by: Mingjin Ye
---
doc/guides/rel_notes/release_23_07.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index dc0d250e16..ba4efa69f2 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -156,6 +156,11 @@ New Features
* Added support for combined Cipher-CRC offload for DOCSIS for QAT GENs 2,3
and 4.
+* **Updated Intel ice driver.**
+
+ * Added support for double vlan, include outer vlan stripping,
+port-based outer vlan insertion and outer vlan tag type setting.
+
* **Updated Marvell cnxk crypto driver.**
* Added support for PDCP chain in cn10k crypto driver.
--
2.25.1
[PATCH] doc: fix missing release note for link support
fix missing release note for link speed change support.
Fixes: 36afbc269081 ("net/ice: support link speed change")
Signed-off-by: kevin-intel
---
doc/guides/rel_notes/release_23_07.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..d3fa6a89f1 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -141,6 +141,10 @@ New Features
* Added support for quota flow action and item.
* Added support for flow rule update.
+* **Updated Intel ice driver.**
+
+ * Added support for link speed change.
+
* **Updated Solarflare network PMD.**
* Added support for configuring FEC mode, querying FEC capabilities and
--
2.34.1
RE: [PATCH v10] app/dma-perf: introduce dma-perf application
> -Original Message- > From: Jiang, Cheng1 > Sent: Wednesday, June 28, 2023 9:21 AM > To: tho...@monjalon.net; Richardson, Bruce > ; m...@smartsharesystems.com; Xia, Chenbo > ; amitpraka...@marvell.com; ano...@marvell.com; > huangdeng...@huawei.com; Laatz, Kevin ; > fengcheng...@huawei.com; jer...@marvell.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, > YuanX ; He, Xingguang ; > Ling, WeiX ; Jiang, Cheng1 > Subject: [PATCH v10] app/dma-perf: introduce dma-perf application > > There are many high-performance DMA devices supported in DPDK now, > and these DMA devices can also be integrated into other modules of DPDK as > accelerators, such as Vhost. Before integrating DMA into applications, > developers need to know the performance of these DMA devices in various > scenarios and the performance of CPUs in the same scenario, such as > different buffer lengths. Only in this way can we know the target > performance of the application accelerated by using them. This patch > introduces a high-performance testing tool, which supports comparing the > performance of CPU and DMA in different scenarios automatically with a pre- > set config file. Memory Copy performance test are supported for now. > > Signed-off-by: Cheng Jiang > Signed-off-by: Jiayu Hu > Signed-off-by: Yuan Wang > Acked-by: Morten Brørup > Acked-by: Chenbo Xia > --- > v10: > rebased code from 23.07-rc2; > v9: > improved error handling; > improved lcore_params structure; > improved mbuf api calling; > improved exit process; > fixed some typos; > added scenario summary data display; > removed unnecessary include; > v8: > fixed string copy issue in parse_lcore(); > improved some data display format; > added doc in doc/guides/tools; > updated release notes; > v7: > fixed some strcpy issues; > removed cache setup in calling rte_pktmbuf_pool_create(); > fixed some typos; > added some memory free and null set operations; > improved result calculation; > v6: > improved code based on Anoob's comments; > fixed some code structure issues; > v5: > fixed some LONG_LINE warnings; > v4: > fixed inaccuracy of the memory footprint display; > v3: > fixed some typos; > v2: > added lcore/dmadev designation; > added error case process; > removed worker_threads parameter from config.ini; > improved the logs; > improved config file; > > app/meson.build| 1 + > app/test-dma-perf/benchmark.c | 508 > app/test-dma-perf/config.ini | 61 +++ > app/test-dma-perf/main.c | 616 + > app/test-dma-perf/main.h | 64 +++ > app/test-dma-perf/meson.build | 17 + > doc/guides/rel_notes/release_23_07.rst | 6 + > doc/guides/tools/dmaperf.rst | 103 + > doc/guides/tools/index.rst | 1 + > 9 files changed, 1377 insertions(+) > create mode 100644 app/test-dma-perf/benchmark.c create mode 100644 > app/test-dma-perf/config.ini create mode 100644 app/test-dma- > perf/main.c create mode 100644 app/test-dma-perf/main.h create mode > 100644 app/test-dma-perf/meson.build create mode 100644 > doc/guides/tools/dmaperf.rst > Tested-by: Wei Ling
[PATCH] doc: fix missing release note for double vlan on ice
Add missing release note for double vlan on ice driver.
Fixes: de5da9d16430 ("net/ice: support double VLAN")
Signed-off-by: Mingjin Ye
---
doc/guides/rel_notes/release_23_07.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..fbbf349c63 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -141,6 +141,11 @@ New Features
* Added support for quota flow action and item.
* Added support for flow rule update.
+* **Updated Intel ice driver.**
+
+ * Added support for double vlan, include outer vlan stripping,
+port-based outer vlan insertion and outer vlan tag type setting.
+
* **Updated Solarflare network PMD.**
* Added support for configuring FEC mode, querying FEC capabilities and
--
2.25.1
[PATCH] doc: fix missing release note for link support
fix missing release note for link speed change support.
Fixes: 36afbc269081 ("net/ice: support link speed change")
Signed-off-by: Kaiwen Deng
---
doc/guides/rel_notes/release_23_07.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_07.rst
b/doc/guides/rel_notes/release_23_07.rst
index 4459144140..d3fa6a89f1 100644
--- a/doc/guides/rel_notes/release_23_07.rst
+++ b/doc/guides/rel_notes/release_23_07.rst
@@ -141,6 +141,10 @@ New Features
* Added support for quota flow action and item.
* Added support for flow rule update.
+* **Updated Intel ice driver.**
+
+ * Added support for link speed change.
+
* **Updated Solarflare network PMD.**
* Added support for configuring FEC mode, querying FEC capabilities and
--
2.34.1
[PATCH 1/2] net/virtio: fix legacy device IO port map in secondary process
When doing IO port map for legacy device in sencondary process,
vfio_cfg setup for leagacy device like vfio_group_fd and vfio_dev_fd
is missing. So, in sencondary process, rte_pci_map_device is added
for legacy device to setup vfio_cfg and fill region info like in
primary process.
Fixes: 512e27eeb743 ("net/virtio: move PCI specific dev init to PCI ethdev
init")
Cc: sta...@dpdk.org
Signed-off-by: Miao Li
---
drivers/net/virtio/virtio_pci_ethdev.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/virtio/virtio_pci_ethdev.c
b/drivers/net/virtio/virtio_pci_ethdev.c
index 9b4b846f8a..dc11a6e82f 100644
--- a/drivers/net/virtio/virtio_pci_ethdev.c
+++ b/drivers/net/virtio/virtio_pci_ethdev.c
@@ -44,23 +44,23 @@ virtio_remap_pci(struct rte_pci_device *pci_dev, struct
virtio_pci_dev *dev)
{
struct virtio_hw *hw = &dev->hw;
- if (dev->modern) {
- /*
-* We don't have to re-parse the PCI config space, since
-* rte_pci_map_device() makes sure the mapped address
-* in secondary process would equal to the one mapped in
-* the primary process: error will be returned if that
-* requirement is not met.
-*
-* That said, we could simply reuse all cap pointers
-* (such as dev_cfg, common_cfg, etc.) parsed from the
-* primary process, which is stored in shared memory.
-*/
- if (rte_pci_map_device(pci_dev)) {
- PMD_INIT_LOG(DEBUG, "failed to map pci device!");
- return -1;
- }
- } else {
+ /*
+* We don't have to re-parse the PCI config space, since
+* rte_pci_map_device() makes sure the mapped address
+* in secondary process would equal to the one mapped in
+* the primary process: error will be returned if that
+* requirement is not met.
+*
+* That said, we could simply reuse all cap pointers
+* (such as dev_cfg, common_cfg, etc.) parsed from the
+* primary process, which is stored in shared memory.
+*/
+ if (rte_pci_map_device(pci_dev)) {
+ PMD_INIT_LOG(DEBUG, "failed to map pci device!");
+ return -1;
+ }
+
+ if (!dev->modern) {
if (vtpci_legacy_ioport_map(hw) < 0)
return -1;
}
--
2.25.1
[PATCH 2/2] bus/pci: add IO port region check before region map
This patch adds IO port region check to skip region map
when doing IO port map for legacy device in sencondary process.
Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping")
Cc: sta...@dpdk.org
Signed-off-by: Miao Li
---
drivers/bus/pci/linux/pci_vfio.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index e634de8322..dd4ca46120 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -1099,6 +1099,15 @@ pci_vfio_map_resource_secondary(struct rte_pci_device
*dev)
maps = vfio_res->maps;
for (i = 0; i < vfio_res->nb_maps; i++) {
+ /* chk for io port region */
+ ret = pci_vfio_is_ioport_bar(dev, vfio_dev_fd, i);
+ if (ret < 0) {
+ goto err_vfio_dev_fd;
+ } else if (ret) {
+ RTE_LOG(INFO, EAL, "Ignore mapping IO port bar(%d)\n",
i);
+ continue;
+ }
+
if (maps[i].nr_areas > 0) {
ret = pci_vfio_sparse_mmap_bar(vfio_dev_fd, vfio_res,
i, MAP_FIXED);
if (ret < 0) {
--
2.25.1
RE: [PATCH] net/ice: fix VLAN mode parser
> -Original Message-
> From: Yang, Qiming
> Sent: Sunday, June 25, 2023 4:23 PM
> To: Zhang, Qi Z ; dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org
> Subject: [PATCH] net/ice: fix VLAN mode parser
>
> Parser will not be ctreated if raw packet filter is not support.
> This patch add NULL pointer check for parser structure when VLAN mode
> configure.
>
> Fixes: 6e753d777ffc ("net/ice: initialize parser for double VLAN")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qiming Yang
Acked-by: Qi Zhang
Applied to dpdk-next-net-intel.
Thanks
Qi
> ---
> drivers/net/ice/ice_generic_flow.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ice/ice_generic_flow.c
> b/drivers/net/ice/ice_generic_flow.c
> index ed3075d555..91bf1d6fcb 100644
> --- a/drivers/net/ice/ice_generic_flow.c
> +++ b/drivers/net/ice/ice_generic_flow.c
> @@ -1836,10 +1836,12 @@ ice_flow_init(struct ice_adapter *ad)
> if (ice_parser_create(&ad->hw, &ad->psr) != ICE_SUCCESS)
> PMD_INIT_LOG(WARNING, "Failed to initialize DDP parser, raw
> packet filter will not be supported");
>
> - if (ice_is_dvm_ena(&ad->hw))
> - ice_parser_dvm_set(ad->psr, true);
> - else
> - ice_parser_dvm_set(ad->psr, false);
> + if (ad->psr) {
> + if (ice_is_dvm_ena(&ad->hw))
> + ice_parser_dvm_set(ad->psr, true);
> + else
> + ice_parser_dvm_set(ad->psr, false);
> + }
>
> RTE_TAILQ_FOREACH_SAFE(engine, &engine_list, node, temp) {
> if (engine->init == NULL) {
> --
> 2.25.1
RE: [PATCH] net/iavf: fix VLAN insertion in vector path
> -Original Message-
> From: Wenzhuo Lu
> Sent: Wednesday, June 21, 2023 9:19 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; sta...@dpdk.org
> Subject: [PATCH] net/iavf: fix VLAN insertion in vector path
>
> As the VLAN insertion is partially supported in vector path, the behavior is
> different in scalar and vector path.
> For a VLAN packet, if using scalar path, the new VLAN tag will be inserted
> after
> the original VLAN tag. If using vector path, the new VLAN tag is inserted
> before
> the original VLAN tag.
> To avoid any misleading, disable VLAN insertion in vector path.
>
> Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Wenzhuo Lu
> ---
> drivers/net/iavf/iavf_rxtx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index
> 547b68f..2459c15 100644
> --- a/drivers/net/iavf/iavf_rxtx.h
> +++ b/drivers/net/iavf/iavf_rxtx.h
> @@ -27,13 +27,13 @@
> #define IAVF_VPMD_TX_MAX_FREE_BUF 64
>
> #define IAVF_TX_NO_VECTOR_FLAGS ( \
> + RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \
> + RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
> RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
> RTE_ETH_TX_OFFLOAD_TCP_TSO | \
> RTE_ETH_TX_OFFLOAD_SECURITY)
>
> #define IAVF_TX_VECTOR_OFFLOAD ( \
> - RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \
> - RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
> RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \
> RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \
> --
> 1.8.3.1
We may need to update the iavf.ini to claim VLAN offload is partially supported
to align with this implementation.
VLAN offload = P
