Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable
On Wed, Sep 1, 2021 at 1:17 PM Kinsella, Ray wrote: > On 01/09/2021 08:29, Mattias Rönnblom wrote: > > Remove experimental tag from rte_rand_max(). > > > > Signed-off-by: Mattias Rönnblom > > Acked-by: Ray Kinsella Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH] eal: promote register type and pick level API as stable
On Tue, Aug 31, 2021 at 8:31 PM Kinsella, Ray wrote: > On 31/08/2021 19:14, Ivan Malov wrote: > > This one might be quite mature to be attested as stable. > > > > Signed-off-by: Ivan Malov > > Reviewed-by: Andrew Rybchenko > > --- > > Acked-by: Ray Kinsella > Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions
Hello,
On Thu, Sep 30, 2021 at 7:42 PM Sean Morrissey wrote:
>
> These methods were introduced in 20.05.
> There has been no changes in their public API since then.
> They seem mature enough to remove the experimental tag.
I am a bit skeptical at the patch.
Can you double check?
/** prod/cons sync types */
enum rte_ring_sync_type {
RTE_RING_SYNC_MT, /**< multi-thread safe (default mode) */
RTE_RING_SYNC_ST, /**< single thread only */
#ifdef ALLOW_EXPERIMENTAL_API
RTE_RING_SYNC_MT_RTS, /**< multi-thread relaxed tail sync */
RTE_RING_SYNC_MT_HTS, /**< multi-thread head/tail sync */
#endif
};
There is also in rte_ring_elem.h:
#ifdef ALLOW_EXPERIMENTAL_API
#include
#include
#endif
And later
static __rte_always_inline unsigned int
rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table,
unsigned int esize, unsigned int n, unsigned int *free_space)
{
...
#ifdef ALLOW_EXPERIMENTAL_API
case RTE_RING_SYNC_MT_RTS:
return rte_ring_mp_rts_enqueue_bulk_elem(r, obj_table, esize, n,
free_space);
I don't think those HTS and RTS modes work if the code is compiled
without the experimental flag.
--
David Marchand
Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
On Thu, Sep 16, 2021 at 1:38 PM Olivier Matz wrote: > > On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote: > > rte_net_make_rarp_packet was introduced in version v18.02, there was no > > change in this public API since then, and it's still being used by vhost > > lib and virtio driver, so promote it as stable ABI. > > > > Signed-off-by: Xiao Wang > Acked-by: Stephen Hemminger Acked-by: Chenbo Xia Acked-by: Olivier Matz Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH 1/2] rib: announce experimental tag removal of the rib API
On Thu, Aug 5, 2021 at 1:26 PM Vladimir Medvedkin wrote: > > This patch announces the experimental tag removal of all rib APIs, > which have been experimental for 2 years. > API will be promoted to stable in DPDK 21.11 > > Signed-off-by: Vladimir Medvedkin Either this series was missed or judged unneeded during 21.08. In any case, the API promotion to stable will be merged in 21.11. Marked series as not applicable. -- David Marchand
Re: [dpdk-dev] [PATCH] rib: promote experimental API's to stable
On Wed, Sep 1, 2021 at 9:16 PM Medvedkin, Vladimir wrote: > On 31/08/2021 23:49, Stephen Hemminger wrote: > > The rib and rib6 API's have been in since 19.11 and > > should be marked as stable. > > > > Signed-off-by: Stephen Hemminger > Acked-by: Vladimir Medvedkin Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH] fib: promote experimental API's to stable
On Wed, Sep 8, 2021 at 7:04 PM Conor Walsh wrote: > > The fib and fib6 API's have been in since 19.11 and > > should be marked as stable. > > > > Signed-off-by: Vladimir Medvedkin > Acked-by: Conor Walsh Updated MAINTAINERS accordingly. Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable
On Tue, Aug 31, 2021 at 9:35 PM Stephen Hemminger
wrote:
>
> This function should be made stable now.
>
> Also, fix the docbook comment format.
>
> Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value")
> Cc: konstantin.anan...@intel.com
> Signed-off-by: Stephen Hemminger
> ---
> lib/mbuf/rte_mbuf.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 7722b36ee44b..627790fe26e7 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf
> *head, struct rte_mbuf *tail
> return 0;
> }
>
> -/*
> +/**
> * @warning
> * @b EXPERIMENTAL: This API may change without prior notice.
> *
> @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf
> *head, struct rte_mbuf *tail
> * @return
> * raw tx_offload value.
> */
> +__rte_experimental
>From title and description, I would expect we remove
__rte_experimental tag, not add one.
Can you clarify the intention?
> static __rte_always_inline uint64_t
> rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso,
> uint64_t ol3, uint64_t ol2, uint64_t unused)
> --
> 2.30.2
>
--
David Marchand
Re: [dpdk-dev] [PATCH] net: make rte_ether_unformat_addr stable
On Thu, Sep 16, 2021 at 1:36 PM Olivier Matz wrote: > > On Wed, Sep 01, 2021 at 09:49:09AM +0100, Ferruh Yigit wrote: > > On 9/1/2021 8:11 AM, Andrew Rybchenko wrote: > > > On 8/31/21 11:07 PM, Stephen Hemminger wrote: > > >> This function has been in since 19.11. > > >> > > >> Signed-off-by: Stephen Hemminger > > > Acked-by: Andrew Rybchenko > > Acked-by: Ferruh Yigit > Acked-by: Olivier Matz Applied, thanks. -- David Marchand
Re: [dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable
On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz wrote:
>
> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
> header extensions skip function") (2018), and is used by vmxnet3 driver.
> Promote it as stable.
>
> Signed-off-by: Olivier Matz
Acked-by: David Marchand
--
David Marchand
Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions
Hi David,
> Hello,
>
> On Thu, Sep 30, 2021 at 7:42 PM Sean Morrissey
> wrote:
> >
> > These methods were introduced in 20.05.
> > There has been no changes in their public API since then.
> > They seem mature enough to remove the experimental tag.
>
> I am a bit skeptical at the patch.
> Can you double check?
>
>
> /** prod/cons sync types */
> enum rte_ring_sync_type {
> RTE_RING_SYNC_MT, /**< multi-thread safe (default mode) */
> RTE_RING_SYNC_ST, /**< single thread only */
> #ifdef ALLOW_EXPERIMENTAL_API
> RTE_RING_SYNC_MT_RTS, /**< multi-thread relaxed tail sync */
> RTE_RING_SYNC_MT_HTS, /**< multi-thread head/tail sync */
> #endif
> };
>
> There is also in rte_ring_elem.h:
>
> #ifdef ALLOW_EXPERIMENTAL_API
> #include
> #include
> #endif
>
> And later
>
> static __rte_always_inline unsigned int
> rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table,
> unsigned int esize, unsigned int n, unsigned int *free_space)
> {
> ...
> #ifdef ALLOW_EXPERIMENTAL_API
> case RTE_RING_SYNC_MT_RTS:
> return rte_ring_mp_rts_enqueue_bulk_elem(r, obj_table, esize,
> n,
> free_space);
>
>
> I don't think those HTS and RTS modes work if the code is compiled
> without the experimental flag.
>
You are right, sorry I forgot about these things ☹
Will change in v2.
Re: [dpdk-dev] [PATCH v3 00/28] net/cnxk: support for inline ipsec
On Fri, Oct 1, 2021 at 7:10 PM Nithin Dabilpuram wrote: > > Support for inline ipsec in CN9K event mode and in Cn10K event mode and > poll mode. > > Kommula Shiva Shankar (1): > common/cnxk: add CQ enable support in NIX Tx path > > Nithin Dabilpuram (18): > common/cnxk: support CPT parse header dump > common/cnxk: allow reuse of SSO API for inline dev > common/cnxk: change NIX debug API and queue API interface > common/cnxk: support NIX inline device IRQ > common/cnxk: support NIX inline device init and fini > common/cnxk: support NIX inline inbound and outbound setup > common/cnxk: disable CQ drop when inline inbound is enabled > common/cnxk: dump CPT LF registers on error intr > common/cnxk: align CPT LF enable/disable sequence > common/cnxk: restore NIX sqb pool limit before destroy > common/cnxk: setup aura BP conf based on nix > net/cnxk: support inline security setup for cn9k > net/cnxk: support inline security setup for cn10k > net/cnxk: support Rx security offload on cn9k > net/cnxk: support Tx security offload on cn9k > net/cnxk: support Rx security offload on cn10k > net/cnxk: support Tx security offload on cn10k > net/cnxk: reflect globally enabled offloads in queue conf > > Satheesh Paul (2): > common/cnxk: support inline IPsec rte flow action > net/cnxk: support configuring channel mask via devargs > > Srujana Challa (7): > common/cnxk: support cn9k fast path security session > common/cnxk: support anti-replay check in SW for cn9k > net/cnxk: support IPsec anti replay in cn9k > net/cnxk: support IPsec transport mode in cn10k > net/cnxk: update ethertype for mixed IPsec tunnel versions > net/cnxk: allow zero udp6 checksum for non inline device > net/cnxk: add crypto capabilities for AES CBC and HMAC SHA1 > > v3: > - Rebased and fixed conflicts > > v2: > - Included bug fixes for second pass packets > - Updated .ini files. > - Reworded commit messages with additional description > and abbreviation fixes Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net. Thanks. > > doc/guides/nics/cnxk.rst | 122 +++ > doc/guides/nics/features/cnxk.ini|1 + > doc/guides/nics/features/cnxk_vec.ini|1 + > doc/guides/nics/features/cnxk_vf.ini |1 + > doc/guides/rel_notes/release_21_11.rst |2 + > drivers/common/cnxk/cnxk_security.c | 212 + > drivers/common/cnxk/cnxk_security.h | 12 + > drivers/common/cnxk/cnxk_security_ar.h | 184 > drivers/common/cnxk/hw/cpt.h | 19 + > drivers/common/cnxk/meson.build |3 + > drivers/common/cnxk/roc_api.h| 49 +- > drivers/common/cnxk/roc_constants.h | 58 ++ > drivers/common/cnxk/roc_cpt.c| 54 +- > drivers/common/cnxk/roc_cpt.h| 10 + > drivers/common/cnxk/roc_cpt_debug.c | 63 +- > drivers/common/cnxk/roc_cpt_priv.h |1 + > drivers/common/cnxk/roc_idev.c |2 + > drivers/common/cnxk/roc_idev_priv.h |3 + > drivers/common/cnxk/roc_io.h |9 + > drivers/common/cnxk/roc_io_generic.h |3 +- > drivers/common/cnxk/roc_irq.c|7 +- > drivers/common/cnxk/roc_nix.c|2 +- > drivers/common/cnxk/roc_nix.h|7 + > drivers/common/cnxk/roc_nix_debug.c | 168 +++- > drivers/common/cnxk/roc_nix_fc.c | 23 +- > drivers/common/cnxk/roc_nix_inl.c| 778 + > drivers/common/cnxk/roc_nix_inl.h| 170 > drivers/common/cnxk/roc_nix_inl_dev.c| 639 ++ > drivers/common/cnxk/roc_nix_inl_dev_irq.c| 359 > drivers/common/cnxk/roc_nix_inl_priv.h | 68 ++ > drivers/common/cnxk/roc_nix_priv.h | 31 + > drivers/common/cnxk/roc_nix_queue.c | 137 +-- > drivers/common/cnxk/roc_npc.c| 27 +- > drivers/common/cnxk/roc_npc_mcam.c | 28 +- > drivers/common/cnxk/roc_platform.h | 11 +- > drivers/common/cnxk/roc_priv.h |3 + > drivers/common/cnxk/roc_sso.c| 52 +- > drivers/common/cnxk/roc_sso_priv.h |9 + > drivers/common/cnxk/version.map | 34 + > drivers/event/cnxk/cn10k_eventdev.c | 93 +- > drivers/event/cnxk/cn10k_worker.h| 147 +++- > drivers/event/cnxk/cn10k_worker_deq.c|2 +- > drivers/event/cnxk/cn10k_worker_deq_burst.c |2 +- > drivers/event/cnxk/cn10k_worker_deq_ca.c |2 +- > drivers/event/cnxk/cn10k_worker_deq_tmo.c|2 +- > drivers/event/cnxk/cn10k_worker_tx_enq.c |2 +- > drivers/event/c
Re: [dpdk-dev] [PATCH v3 01/27] common/cnxk: update policer MBOX APIs and HW definitions
On Thu, Sep 30, 2021 at 3:31 PM Kinsella, Ray wrote: > > > > On 30/09/2021 10:08, sk...@marvell.com wrote: > > From: Sunil Kumar Kori > > > > To support ingress policer on CN10K, MBOX interfaces and HW > > definitions are synced. > > > > Signed-off-by: Sunil Kumar Kori # Please add cover letter # Please update the release notes for this feature # Please rebase to next-net-mrvl and fix following issues [for-next-net]dell[dpdk-next-net-mrvl] $ git pw series apply 19286 && rm -rf /tmp/k/* && git format-patch HEAD~27 -o /tmp/k/ && git reset --hard HEAD~27 Applying: common/cnxk: update policer MBOX APIs and HW definitions Applying: common/cnxk: support RoC API to get level to index Using index info to reconstruct a base tree... M drivers/common/cnxk/meson.build M drivers/common/cnxk/roc_nix.h M drivers/common/cnxk/roc_nix_priv.h M drivers/common/cnxk/roc_utils.c M drivers/common/cnxk/version.map Falling back to patching base and 3-way merge... Auto-merging drivers/common/cnxk/version.map Auto-merging drivers/common/cnxk/roc_utils.c Auto-merging drivers/common/cnxk/roc_nix_priv.h Auto-merging drivers/common/cnxk/roc_nix.h CONFLICT (content): Merge conflict in drivers/common/cnxk/roc_nix.h Auto-merging drivers/common/cnxk/meson.build error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0002 common/cnxk: support RoC API to get level to index When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". > > --- > > v3: > > - Rebase support on latest DPDK > > - Handled multilevel chaining for tree hierarchy > > - Fix naming convention > > v2: > > - Rebase support on latest DPDK > > - Handled multilevel chaining for linear hierarchy > > - Review comments incorporated > > > > drivers/common/cnxk/hw/nix.h | 13 ++--- > > drivers/common/cnxk/roc_mbox.h | 34 +- > > 2 files changed, 43 insertions(+), 4 deletions(-) > > > Acked-by: Ray Kinsella > (for the series).
[dpdk-dev] [PATCH] mbuf: promote some helpers to stable
Those accessors have been introduced more than two years ago
(rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.02).
Time to mark them stable.
rte_mbuf_to_baddr() could be removed, but since we lack a deprecation
notice, keep it as a simple wrapper.
Signed-off-by: David Marchand
---
lib/mbuf/rte_mbuf.h | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index a555f216ae..756a0462a2 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -191,11 +191,6 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi)
* mbuf is already known because it doesn't need to access mbuf contents in
* order to get the mempool pointer.
*
- * @warning
- * @b EXPERIMENTAL: This API may change without prior notice.
- * This will be used by rte_mbuf_to_baddr() which has redundant code once
- * experimental tag is removed.
- *
* @param mb
* The pointer to the mbuf.
* @param mp
@@ -203,7 +198,6 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi)
* @return
* The pointer of the mbuf buffer.
*/
-__rte_experimental
static inline char *
rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool *mp)
{
@@ -213,26 +207,15 @@ rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool
*mp)
/**
* Return the default address of the beginning of the mbuf data.
*
- * @warning
- * @b EXPERIMENTAL: This API may change without prior notice.
- *
* @param mb
* The pointer to the mbuf.
* @return
* The pointer of the beginning of the mbuf data.
*/
-__rte_experimental
static inline char *
-rte_mbuf_data_addr_default(__rte_unused struct rte_mbuf *mb)
+rte_mbuf_data_addr_default(struct rte_mbuf *mb)
{
- /* gcc complains about calling this experimental function even
-* when not using it. Hide it with ALLOW_EXPERIMENTAL_API.
-*/
-#ifdef ALLOW_EXPERIMENTAL_API
return rte_mbuf_buf_addr(mb, mb->pool) + RTE_PKTMBUF_HEADROOM;
-#else
- return NULL;
-#endif
}
/**
@@ -251,13 +234,7 @@ rte_mbuf_data_addr_default(__rte_unused struct rte_mbuf
*mb)
static inline char *
rte_mbuf_to_baddr(struct rte_mbuf *md)
{
-#ifdef ALLOW_EXPERIMENTAL_API
return rte_mbuf_buf_addr(md, md->pool);
-#else
- char *buffer_addr;
- buffer_addr = (char *)md + sizeof(*md) +
rte_pktmbuf_priv_size(md->pool);
- return buffer_addr;
-#endif
}
/**
@@ -272,7 +249,6 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
* @return
* The starting address of the private data area of the given mbuf.
*/
-__rte_experimental
static inline void *
rte_mbuf_to_priv(struct rte_mbuf *m)
{
--
2.23.0
Re: [dpdk-dev] [PATCH] app/test: fix memory autotests on FreeBSD
On Fri, Sep 17, 2021 at 5:09 PM Bruce Richardson
wrote:
>
> The memory autotests were failing on FreeBSD, due to an incorrect errno
> variable being checked for ENOTSUP. The test checked "errno" while the
> DPDK API sets "rte_errno". Changing to check the right variable makes
> the test behave properly.
>
> Fixes: c3e35a0966b8 ("test/mem: check segment fd API")
>
> Reported-by: Brandon Lo
> Signed-off-by: Bruce Richardson
Reviewed-by: David Marchand
Applied, thanks.
--
David Marchand
Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts
On Mon, Sep 13, 2021 at 3:15 PM Burakov, Anatoly
wrote:
> On 13-Sep-21 12:06 PM, Bruce Richardson wrote:
> > Only a single DPDK process on the system can be using the /dev/contigmem
> > mappings at a time, but this was never explicitly enforced, e.g. when
> > using --in-memory flag on two processes. To prevent possible conflict
> > issues, we lock the dev node when it's in use, preventing other DPDK
> > processes from starting up and causing problems for us.
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Bruce Richardson
> Reviewed-by: Anatoly Burakov
Applied, thanks.
--
David Marchand
Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts
On Mon, Sep 13, 2021 at 4:40 PM Burakov, Anatoly wrote: > >> I'm a bit uneasy with --in-memory mode pretending to work on > >> FreeBSD and Windows, but that's a separate problem :) > > > > Yes, it is, though one that does belong is the same area as this one. The > > "fix" is probably to just print a warning when --in-memory is used, > > informing the user that the flag is ignored and then continue. > > Alternatively we can error out, but I think the warn+continue is better, > > myself. > > I think erroring out is better. The feature is intended to work a > certain way, so if we can't guarantee that it does, we can't pretend it > is "supported" or "is working". But again, irrelevant to this patch :) > Please, can you review https://patchwork.dpdk.org/project/dpdk/patch/20210913140848.184928-1-bruce.richard...@intel.com/ ? Thanks. -- David Marchand
Re: [dpdk-dev] [PATCH] test/hash: use compiler atomics for sync
Hello guys, On Wed, Sep 22, 2021 at 11:52 PM Dharmik Thakkar wrote: > > Convert rte_atomic usages to compiler atomic built-ins > for stats sync > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Joyce Kong > Reviewed-by: Ruifeng Wang Review please. -- David Marchand
[dpdk-dev] [Bug 752] Leak in ice init if ice_flow_init or ice_reset_fxp_resource fails
https://bugs.dpdk.org/show_bug.cgi?id=752 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #2 from David Marchand (david.march...@redhat.com) --- Fixed with: https://git.dpdk.org/dpdk/commit/?id=96b25c496aad -- You are receiving this mail because: You are the assignee for the bug.
[dpdk-dev] [Bug 818] [asan] hash: buffer overflow in hash_autotest
https://bugs.dpdk.org/show_bug.cgi?id=818 Bug ID: 818 Summary: [asan] hash: buffer overflow in hash_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: david.march...@redhat.com CC: bruce.richard...@intel.com, vladimir.medved...@intel.com, yipeng1.w...@intel.com Target Milestone: --- This issue was caught by ASAN. To reproduce, please look at the last patch of series 18997: https://github.com/ovsrobot/dpdk/commit/series_18997 30/94 DPDK:fast-tests / hash_autotest FAIL 0.97 s (exit status 1) --- command --- DPDK_TEST='hash_autotest' /home/runner/work/dpdk/dpdk/build/app/test/dpdk-test -l 0-1 --file-prefix=hash_autotest --- stdout --- RTE>>hash_autotest --- stderr --- EAL: Detected 2 lcore(s) EAL: Detected 1 NUMA nodes EAL: Detected shared linkage of DPDK EAL: WARNING! Base virtual address hint (0x15000 != 0x7f890e95a000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: Multi-process socket /var/run/dpdk/hash_autotest/mp_socket EAL: Selected IOVA mode 'PA' EAL: No available 1048576 kB hugepages reported EAL: VFIO support initialized EAL: WARNING! Base virtual address hint (0x1b000 != 0x7f88fd558000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100011000 != 0x7f88fd39f000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100a12000 != 0x7f84fb80) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100c17000 != 0x7f88fd33e000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x101618000 != 0x7f80fb60) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x10181d000 != 0x7f88fd19f000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x10221e000 != 0x7f7cfb40) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x102423000 != 0x7f88fd13e000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x102e24000 != 0x7f78fb20) not respected! EAL:This may cause issues with mapping memory into secondary processes APP: HPET is not enabled, using TSC as default timer = ==25013==ERROR: AddressSanitizer: global-buffer-overflow on address 0x037220f0 at pc 0x014a8de4 bp 0x7ffe74374b30 sp 0x7ffe74374b28 READ of size 4 at 0x037220f0 thread T0 #0 0x14a8de3 in __rte_jhash_2hashes /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:104:9 #1 0x14abb53 in rte_jhash_32b_2hashes /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:259:2 #2 0x14aba71 in rte_jhash_32b /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:307:2 #3 0x7f890a546627 in rte_hash_hash /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_cuckoo_hash.c:538:9 #4 0x7f890a555672 in rte_hash_add_key /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_cuckoo_hash.c:1212:46 #5 0x1497373 in test_hash_add_delete_2_jhash2 /home/runner/work/dpdk/dpdk/build/../app/test/test_hash.c:1666:9 #6 0x14968e0 in test_hash /home/runner/work/dpdk/dpdk/build/../app/test/test_hash.c:2187:6 #7 0x4d6166 in cmd_autotest_parsed /home/runner/work/dpdk/dpdk/build/../app/test/commands.c:71:10 #8 0x7f890b0b46c5 in cmdline_parse /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline_parse.c:290:3 #9 0x7f890b0ad8d5 in cmdline_valid_buffer /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline.c:26:8 #10 0x7f890b0bef07 in rdline_char_in /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline_rdline.c:421:5 #11 0x7f890b0ae03f in cmdline_in /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline.c:149:9 #12 0x5ac68e in main /home/runner/work/dpdk/dpdk/build/../app/test/test.c:214:8 #13 0x7f890370bbf6 in __libc_start_main /build/glibc-S9d2JN/glibc-2.27/csu/../csu/libc-start.c:310 #14 0x42ea19 in _start (/home/runner/work/dpdk/dpdk/build/app/test/dpdk-test+0x42ea19) 0x037220f0 is located 48 bytes to the left of global variable 'hashtest_funcs' defined in '../app/test/test_hash.c:36:26' (0x3722120) of size 16 0x037220f0 is located 0 bytes to the right of global variable 'key' defined in '../app/test/test_hash.c:1596:16' (0x37220e0) o
[dpdk-dev] [Bug 819] [asan] lpm: buffer overflow in lpm6_autotest
https://bugs.dpdk.org/show_bug.cgi?id=819 Bug ID: 819 Summary: [asan] lpm: buffer overflow in lpm6_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: david.march...@redhat.com Target Milestone: --- This issue was caught by ASAN. To reproduce, please look at the last patch of series 18997: https://github.com/ovsrobot/dpdk/commit/series_18997 36/94 DPDK:fast-tests / lpm6_autotest FAIL 6.54 s (exit status 1) --- command --- DPDK_TEST='lpm6_autotest' /home/runner/work/dpdk/dpdk/build/app/test/dpdk-test -l 0-1 --file-prefix=lpm6_autotest --- stdout --- RTE>>lpm6_autotest --- stderr --- EAL: Detected 2 lcore(s) EAL: Detected 1 NUMA nodes EAL: Detected shared linkage of DPDK EAL: WARNING! Base virtual address hint (0x15000 != 0x7f26bdb3b000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: Multi-process socket /var/run/dpdk/lpm6_autotest/mp_socket EAL: Selected IOVA mode 'PA' EAL: No available 1048576 kB hugepages reported EAL: VFIO support initialized EAL: WARNING! Base virtual address hint (0x1b000 != 0x7f26ac739000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100011000 != 0x7f26ac59f000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100a12000 != 0x7f22aaa0) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100c17000 != 0x7f26ac53e000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x101618000 != 0x7f1eaa80) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x10181d000 != 0x7f26ac39f000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x10221e000 != 0x7f1aaa60) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x102423000 != 0x7f26ac33e000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x102e24000 != 0x7f16aa40) not respected! EAL:This may cause issues with mapping memory into secondary processes APP: HPET is not enabled, using TSC as default timer RING: Cannot reserve memory HASH: memory allocation failed LPM: LPM rules hash table allocation failed: File exists (17)= ==25187==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffdded97cf0 at pc 0x7f26b76a2206 bp 0x7ffdded972b0 sp 0x7ffdded972a8 READ of size 4 at 0x7ffdded97cf0 thread T0 #0 0x7f26b76a2205 in __rte_jhash_2hashes /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:129:9 #1 0x7f26b76a1690 in rte_jhash_2hashes /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:238:2 #2 0x7f26b76a15be in rte_jhash /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_jhash.h:284:2 #3 0x7f26b767d042 in rule_hash /home/runner/work/dpdk/dpdk/build/../lib/lpm/rte_lpm6.c:160:9 #4 0x7f26b9727627 in rte_hash_hash /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_cuckoo_hash.c:538:9 #5 0x7f26b9736926 in rte_hash_lookup_data /home/runner/work/dpdk/dpdk/build/../lib/hash/rte_cuckoo_hash.c:1449:45 #6 0x7f26b76a6982 in rule_find_with_key /home/runner/work/dpdk/dpdk/build/../lib/lpm/rte_lpm6.c:454:8 #7 0x7f26b769b4dd in rule_add /home/runner/work/dpdk/dpdk/build/../lib/lpm/rte_lpm6.c:497:15 #8 0x7f26b767da05 in rte_lpm6_add /home/runner/work/dpdk/dpdk/build/../lib/lpm/rte_lpm6.c:882:20 #9 0x16d1ef9 in test9 /home/runner/work/dpdk/dpdk/build/../app/test/test_lpm6.c:456:11 #10 0x16de5cc in test_lpm6 /home/runner/work/dpdk/dpdk/build/../app/test/test_lpm6.c:1784:12 #11 0x4d6166 in cmd_autotest_parsed /home/runner/work/dpdk/dpdk/build/../app/test/commands.c:71:10 #12 0x7f26ba2956c5 in cmdline_parse /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline_parse.c:290:3 #13 0x7f26ba28e8d5 in cmdline_valid_buffer /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline.c:26:8 #14 0x7f26ba29ff07 in rdline_char_in /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline_rdline.c:421:5 #15 0x7f26ba28f03f in cmdline_in /home/runner/work/dpdk/dpdk/build/../lib/cmdline/cmdline.c:149:9 #16 0x5ac68e in main /home/runner/work/dpdk/dpdk/build/../app/test/test.c:214:8 #17 0x7f26b28ecbf6 in __libc_start_main /build/glibc-S9d2JN/glibc-2.27/csu/../cs
[dpdk-dev] [Bug 820] [asan] table: buffer overflow in table_autotest
https://bugs.dpdk.org/show_bug.cgi?id=820 Bug ID: 820 Summary: [asan] table: buffer overflow in table_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: david.march...@redhat.com CC: cristian.dumitre...@intel.com Target Milestone: --- This issue was caught by ASAN. To reproduce, please look at the last patch of series 18997: https://github.com/ovsrobot/dpdk/commit/series_18997 64/94 DPDK:fast-tests / table_autotestFAIL 1.02 s (exit status 1) --- command --- DPDK_TEST='table_autotest' /home/runner/work/dpdk/dpdk/build/app/test/dpdk-test -l 0-1 --file-prefix=table_autotest --- stdout --- RTE>>table_autotest Getting/Creating the mempool ... Pipeline tests Added default entry to table id 0 with action 0 Added default entry to table id 1 with action 0 Pipeline Consistency OK! Got no objects from ring 0 - error code 0 Got no objects from ring 1 - error code 0 Added default entry to table id 0 with action 1 Added default entry to table id 1 with action 1 Pipeline Consistency OK! Got 2 object(s) from ring 0! Object: at [0x7f55b8c85a00], len=0 Object: at [0x7f55b8c86340], len=0 Got 2 object(s) from ring 1! Object: at [0x7f55b8c84780], len=0 Object: at [0x7f55b8c850c0], len=0 Added default entry to table id 0 with action 1 Added default entry to table id 1 with action 1 Pipeline Consistency OK! STUB Table Action Miss - setting mask to 0x1 STUB Table Action Miss - setting mask to 0x1 Got 1 object(s) from ring 0! Object: at [0x7f55b8c86340], len=0 Got 1 object(s) from ring 1! Object: at [0x7f55b8c850c0], len=0 Added default entry to table id 0 with action 1 Added default entry to table id 1 with action 1 Pipeline Consistency OK! STUB Table Action Miss - setting mask to 0x2 STUB Table Action Miss - setting mask to 0x2 Got 1 object(s) from ring 0! Object: at [0x7f55b8c84780], len=0 Got 1 object(s) from ring 1! Object: at [0x7f55b8c86340], len=0 Added default entry to table id 0 with action 1 Added default entry to table id 1 with action 1 Pipeline Consistency OK! STUB Table Action Miss - setting mask to 0x3 STUB Table Action Miss - setting mask to 0x3 Got 2 object(s) from ring 0! Object: at [0x7f55b8c85a00], len=0 Object: at [0x7f55b8c850c0], len=0 Got 2 object(s) from ring 1! Object: at [0x7f55b8c86340], len=0 Object: at [0x7f55b8c84780], len=0 Setting first table to output to next table Added default entry to table id 0 with action 3 Setting secont table to output to port Added default entry to table id 0 with action 1 Setting first table to output to next table Added default entry to table id 2 with action 3 Setting secont table to output to port Added default entry to table id 2 with action 1 Pipeline Consistency OK! Got 2 object(s) from ring 0! Object: at [0x7f55b8c850c0], len=0 Object: at [0x7f55b8c85a00], len=0 Got 2 object(s) from ring 1! Object: at [0x7f55b8c84780], len=0 Object: at [0x7f55b8c86340], len=0 TEST - two tables, hitmask override to 0x01 Setting first table to output to next table Added default entry to table id 0 with action 3 Setting secont table to output to port Added default entry to table id 0 with action 1 Setting first table to output to next table Added default entry to table id 2 with action 3 Setting secont table to output to port Added default entry to table id 2 with action 1 Pipeline Consistency OK! STUB Table Action Miss - setting mask to 0x1 STUB Table Action Miss - setting mask to 0x1 STUB Table Action Miss - setting mask to 0x1 STUB Table Action Miss - setting mask to 0x1 Got 1 object(s) from ring 0! Object: at [0x7f55b8c85a00], len=0 Got 1 object(s) from ring 1! Object: at [0x7f55b8c86340], len=0 --- stderr --- EAL: Detected 2 lcore(s) EAL: Detected 1 NUMA nodes EAL: Detected shared linkage of DPDK EAL: WARNING! Base virtual address hint (0x15000 != 0x7f59cb695000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: Multi-process socket /var/run/dpdk/table_autotest/mp_socket EAL: Selected IOVA mode 'PA' EAL: No available 1048576 kB hugepages reported EAL: VFIO support initialized EAL: WARNING! Base virtual address hint (0x1b000 != 0x7f59ba293000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100011000 != 0x7f59ba232000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100a12000 != 0x7f55b840) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100c17000 != 0x7f59ba09f000) not respected! EAL:This may cause issues with mapping memory into secondary processes EAL: WARNI
[dpdk-dev] [kmods PATCH 0/4] windows: independent fixes
Fixes for building with Windows Development Kit 22000.1 and some build configuration cleanup. Dmitry Kozlyuk (4): windows: specify signature hash algorithm windows/virt2phys: support only x86 configurations windows/virt2phys: change setup class GUID to custom windows/virt2phys: add PnpLockdown directive windows/netuio/netuio.vcxproj | 6 ++ windows/virt2phys/virt2phys.inf | 3 +- windows/virt2phys/virt2phys.vcxproj | 146 ++-- 3 files changed, 15 insertions(+), 140 deletions(-) -- 2.29.3
[dpdk-dev] [kmods PATCH 1/4] windows: specify signature hash algorithm
Windows Driver Kit version 22000.1 requires the signature hash algorithm to be specified, otherwise an error occurs: SIGNTASK : SignTool error : No file digest algorithm specified. Specify "certHash" to match the algorithm of any certificate used. Signed-off-by: Dmitry Kozlyuk --- windows/netuio/netuio.vcxproj | 6 ++ windows/virt2phys/virt2phys.vcxproj | 6 ++ 2 files changed, 12 insertions(+) diff --git a/windows/netuio/netuio.vcxproj b/windows/netuio/netuio.vcxproj index 87c8b94..2ab761e 100644 --- a/windows/netuio/netuio.vcxproj +++ b/windows/netuio/netuio.vcxproj @@ -70,6 +70,9 @@ 0.6.1 + + certHash + %(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib @@ -85,6 +88,9 @@ 0.6.1 + + certHash + %(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib diff --git a/windows/virt2phys/virt2phys.vcxproj b/windows/virt2phys/virt2phys.vcxproj index c86cc9b..66462bc 100644 --- a/windows/virt2phys/virt2phys.vcxproj +++ b/windows/virt2phys/virt2phys.vcxproj @@ -178,6 +178,9 @@ 0.1 + + certHash + @@ -186,6 +189,9 @@ trace.h true + + certHash + -- 2.29.3
[dpdk-dev] [kmods PATCH 2/4] windows/virt2phys: support only x86 configurations
While non inherently limited to one platform, virt2phys is only developed on x86 and tested for it. Arm configurations were created by the driver template project and were never maintained. Remove them to reduce the burden of keeping all configurations in sync. The template also enabled tracing for x86 Release configuration, but the file needed for it is missing. Disable it to fix the build. Fixes: e15f53c36512 (windows/virt2phys: virtual to physical address translator) Signed-off-by: Dmitry Kozlyuk --- windows/virt2phys/virt2phys.vcxproj | 140 +--- 1 file changed, 1 insertion(+), 139 deletions(-) diff --git a/windows/virt2phys/virt2phys.vcxproj b/windows/virt2phys/virt2phys.vcxproj index 66462bc..6794452 100644 --- a/windows/virt2phys/virt2phys.vcxproj +++ b/windows/virt2phys/virt2phys.vcxproj @@ -1,14 +1,6 @@ http://schemas.microsoft.com/developer/msbuild/2003";> - - Debug - Win32 - - - Release - Win32 - Debug x64 @@ -17,22 +9,6 @@ Release x64 - - Debug - ARM - - - Release - ARM - - - Debug - ARM64 - - - Release - ARM64 - @@ -53,22 +29,6 @@ virt2phys - -Windows10 -true -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - - -Windows10 -false -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - Windows10 true @@ -85,38 +45,6 @@ KMDF Universal - -Windows10 -true -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - - -Windows10 -false -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - - -Windows10 -true -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - - -Windows10 -false -WindowsKernelModeDriver10.0 -Driver -KMDF -Universal - @@ -125,46 +53,12 @@ - -DbgengKernelDebugger - - -DbgengKernelDebugger - DbgengKernelDebugger DbgengKernelDebugger - -DbgengKernelDebugger - - -DbgengKernelDebugger - - -DbgengKernelDebugger - - -DbgengKernelDebugger - - - - true - true - trace.h - true - - - - - true - true - trace.h - true - - false @@ -184,7 +78,7 @@ - true + false true trace.h true @@ -193,38 +87,6 @@ certHash - - - true - true - trace.h - true - - - - - true - true - trace.h - true - - - - - true - true - trace.h - true - - - - - true - true - trace.h - true - - -- 2.29.3
[dpdk-dev] [kmods PATCH 3/4] windows/virt2phys: change setup class GUID to custom
virt2phys was using the setup class GUID of sample drivers with class
name "kernel bypass". Windows Driver Kit version 22000.1 recognizes this
GUID and emits an error:
error 1280: Class name and ClassGuid mismatch, expecting Class
"Sample" for ClassGuid "{78A1C341-4539-11d3-B88D-00C04FAD5171}".
Generate and use a new GUID for "Kernel bypass" device class.
Signed-off-by: Dmitry Kozlyuk
---
windows/virt2phys/virt2phys.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/windows/virt2phys/virt2phys.inf b/windows/virt2phys/virt2phys.inf
index e35765e..c1ea8d9 100644
--- a/windows/virt2phys/virt2phys.inf
+++ b/windows/virt2phys/virt2phys.inf
@@ -4,7 +4,7 @@
[Version]
Signature = "$WINDOWS NT$"
Class = %ClassName%
-ClassGuid = {78A1C341-4539-11d3-B88D-00C04FAD5171}
+ClassGuid = {6d53d3f7-734b-44ec-a6a9-4e369dc121a4}
Provider = %ManufacturerName%
CatalogFile = virt2phys.cat
DriverVer =
--
2.29.3
[dpdk-dev] [kmods PATCH 4/4] windows/virt2phys: add PnpLockdown directive
WDK for Windows 10, version 2004 emits a warning suggesting to add
PnpLockdown directive to INI [1]. Add it since virt2phys has no
potential use-cases that require modifications to driver files.
[1]:
https://docs.microsoft.com/en-us/windows-hardware/drivers/install/inf-version-section
Signed-off-by: Dmitry Kozlyuk
---
windows/virt2phys/virt2phys.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/windows/virt2phys/virt2phys.inf b/windows/virt2phys/virt2phys.inf
index c1ea8d9..5af77d2 100644
--- a/windows/virt2phys/virt2phys.inf
+++ b/windows/virt2phys/virt2phys.inf
@@ -8,6 +8,7 @@ ClassGuid = {6d53d3f7-734b-44ec-a6a9-4e369dc121a4}
Provider = %ManufacturerName%
CatalogFile = virt2phys.cat
DriverVer =
+PnpLockdown = 1
[DestinationDirs]
DefaultDestDir = 12
--
2.29.3
[dpdk-dev] [PATCH v2 0/3] Experiment ASAN in GHA
Following fixes for ASAN, I added ASAN in GHA to see where we stand. Here are two fixes that can be merged. The last patch enables ASAN, but as we can see, there are still some unit tests who fails because of ASAN: - multiprocess is broken, we could flag the ut requiring/testing mp, - hash tests have a lot of issues, I suspect bugs in the hash library, bugs have been opened, -- David Marchand David Marchand (3): bus/vmbus: fix leak on device scan test/latencystats: fix incorrect loop boundary ci: run unit tests with ASAN .ci/linux-build.sh | 9 - app/test/test_latencystats.c| 2 +- drivers/bus/vmbus/linux/vmbus_bus.c | 6 +- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.23.0
[dpdk-dev] [PATCH v2 2/3] test/latencystats: fix incorrect loop boundary
Caught running ASAN.
lat_stats_strings[] is an array containing NUM_STATS strings.
Fixes: 1e3676a06e4c ("test/latency: add unit tests for latencystats library")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Reshma Pattan
---
app/test/test_latencystats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c
index 427339904d..724acbc315 100644
--- a/app/test/test_latencystats.c
+++ b/app/test/test_latencystats.c
@@ -80,7 +80,7 @@ static int test_latencystats_get_names(void)
/* Success Test: Valid names and size */
size = NUM_STATS;
ret = rte_latencystats_get_names(names, size);
- for (i = 0; i <= NUM_STATS; i++) {
+ for (i = 0; i < NUM_STATS; i++) {
if (strcmp(lat_stats_strings[i].name, names[i].name) == 0)
printf(" %s\n", names[i].name);
else
--
2.23.0
[dpdk-dev] [PATCH v2 3/3] ci: run unit tests with ASAN
Enable ASAN for clang jobs.
This can greatly help identify leaks and buffer overflows.
This patch is more a fyi, as some unit tests stil have issues.
Signed-off-by: David Marchand
---
.ci/linux-build.sh | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 91e43a975b..a961d9b92d 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -79,7 +79,14 @@ fi
OPTS="$OPTS -Dmachine=default"
OPTS="$OPTS --default-library=$DEF_LIB"
-OPTS="$OPTS --buildtype=debugoptimized"
+
+if [ "$CC" != "${CC%%clang}" ] && [ "$RUN_TESTS" = 'true' ]; then
+# Let's run tests with ASAN
+OPTS="$OPTS -Db_sanitize=address -Db_lundef=false --buildtype=debug"
+else
+OPTS="$OPTS --buildtype=debugoptimized"
+fi
+
OPTS="$OPTS -Dcheck_includes=true"
meson build --werror $OPTS
ninja -C build
--
2.23.0
[dpdk-dev] [PATCH v2 1/3] bus/vmbus: fix leak on device scan
Caught running ASAN.
The device name was leaked on scan.
rte_device name field being a const, use a local pointer and release
in error path.
Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
Changes since v1:
- left rte_vmbus_device untouched,
---
drivers/bus/vmbus/linux/vmbus_bus.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c
b/drivers/bus/vmbus/linux/vmbus_bus.c
index 3c924eee14..68f6cc5742 100644
--- a/drivers/bus/vmbus/linux/vmbus_bus.c
+++ b/drivers/bus/vmbus/linux/vmbus_bus.c
@@ -236,13 +236,14 @@ vmbus_scan_one(const char *name)
char filename[PATH_MAX];
char dirname[PATH_MAX];
unsigned long tmp;
+ char *dev_name;
dev = calloc(1, sizeof(*dev));
if (dev == NULL)
return -1;
dev->device.bus = &rte_vmbus_bus.bus;
- dev->device.name = strdup(name);
+ dev->device.name = dev_name = strdup(name);
if (!dev->device.name)
goto error;
@@ -261,6 +262,7 @@ vmbus_scan_one(const char *name)
/* skip non-network devices */
if (rte_uuid_compare(dev->class_id, vmbus_nic_uuid) != 0) {
+ free(dev_name);
free(dev);
return 0;
}
@@ -312,6 +314,7 @@ vmbus_scan_one(const char *name)
} else { /* already registered */
VMBUS_LOG(NOTICE,
"%s already registered", name);
+ free(dev_name);
free(dev);
}
return 0;
@@ -322,6 +325,7 @@ vmbus_scan_one(const char *name)
error:
VMBUS_LOG(DEBUG, "failed");
+ free(dev_name);
free(dev);
return -1;
}
--
2.23.0
Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache
> > > Current mempool per core cache implementation is based on pointer For
> > > most architectures, each pointer consumes 64b Replace it with
> > > index-based implementation, where in each buffer is addressed by (pool
> > > address + index)
> >
> > I don't think it is going to work:
> > On 64-bit systems difference between pool address and it's elem address
> > could be bigger than 4GB.
> Are you talking about a case where the memory pool size is more than 4GB?
That is one possible scenario.
Another possibility - user populates mempool himself with some external
memory by calling rte_mempool_populate_iova() directly.
I suppose such situation can even occur even with normal rte_mempool_create(),
though it should be a really rare one.
>
> >
> > > It will reduce memory requirements
> > >
> > > L3Fwd performance testing reveals minor improvements in the cache
> > > performance and no change in throughput
> > >
> > > Micro-benchmarking the patch using mempool_perf_test shows significant
> > > improvement with majority of the test cases
> > >
> > > Future plan involves replacing global pool's pointer-based
> > > implementation with index-based implementation
> > >
> > > Signed-off-by: Dharmik Thakkar
> > > ---
> > > drivers/mempool/ring/rte_mempool_ring.c | 2 +-
> > > lib/mempool/rte_mempool.c | 8 +++
> > > lib/mempool/rte_mempool.h | 74 ++---
> > > 3 files changed, 74 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/drivers/mempool/ring/rte_mempool_ring.c
> > > b/drivers/mempool/ring/rte_mempool_ring.c
> > > index b1f09ff28f4d..e55913e47f21 100644
> > > --- a/drivers/mempool/ring/rte_mempool_ring.c
> > > +++ b/drivers/mempool/ring/rte_mempool_ring.c
> > > @@ -101,7 +101,7 @@ ring_alloc(struct rte_mempool *mp, uint32_t
> > rg_flags)
> > > return -rte_errno;
> > >
> > > mp->pool_data = r;
> > > -
> > > + mp->local_cache_base_addr = &r[1];
> > > return 0;
> > > }
> > >
> > > diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
> > > index 59a588425bd6..424bdb19c323 100644
> > > --- a/lib/mempool/rte_mempool.c
> > > +++ b/lib/mempool/rte_mempool.c
> > > @@ -480,6 +480,7 @@ rte_mempool_populate_default(struct
> > rte_mempool *mp)
> > > int ret;
> > > bool need_iova_contig_obj;
> > > size_t max_alloc_size = SIZE_MAX;
> > > + unsigned lcore_id;
> > >
> > > ret = mempool_ops_alloc_once(mp);
> > > if (ret != 0)
> > > @@ -600,6 +601,13 @@ rte_mempool_populate_default(struct
> > rte_mempool *mp)
> > > }
> > > }
> > >
> > > + /* Init all default caches. */
> > > + if (mp->cache_size != 0) {
> > > + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++)
> > > + mp->local_cache[lcore_id].local_cache_base_value =
> > > + *(void **)mp->local_cache_base_addr;
> > > + }
> > > +
> > > rte_mempool_trace_populate_default(mp);
> > > return mp->size;
> > >
> > > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
> > > index 4235d6f0bf2b..545405c0d3ce 100644
> > > --- a/lib/mempool/rte_mempool.h
> > > +++ b/lib/mempool/rte_mempool.h
> > > @@ -51,6 +51,8 @@
> > > #include
> > > #include
> > >
> > > +#include
> > > +
> > > #include "rte_mempool_trace_fp.h"
> > >
> > > #ifdef __cplusplus
> > > @@ -91,11 +93,12 @@ struct rte_mempool_cache {
> > > uint32_t size;/**< Size of the cache */
> > > uint32_t flushthresh; /**< Threshold before we flush excess elements
> > */
> > > uint32_t len; /**< Current cache count */
> > > + void *local_cache_base_value; /**< Base value to calculate indices
> > > +*/
> > > /*
> > >* Cache is allocated to this size to allow it to overflow in certain
> > >* cases to avoid needless emptying of cache.
> > >*/
> > > - void *objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 3]; /**< Cache
> > objects */
> > > + uint32_t objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 3]; /**< Cache
> > objects */
> > > } __rte_cache_aligned;
> > >
> > > /**
> > > @@ -172,7 +175,6 @@ struct rte_mempool_objtlr {
> > > * A list of memory where objects are stored
> > > */
> > > STAILQ_HEAD(rte_mempool_memhdr_list, rte_mempool_memhdr);
> > > -
> > > /**
> > > * Callback used to free a memory chunk
> > > */
> > > @@ -244,6 +246,7 @@ struct rte_mempool {
> > > int32_t ops_index;
> > >
> > > struct rte_mempool_cache *local_cache; /**< Per-lcore local cache */
> > > + void *local_cache_base_addr; /**< Reference to the base value */
> > >
> > > uint32_t populated_size; /**< Number of populated objects. */
> > > struct rte_mempool_objhdr_list elt_list; /**< List of objects in
> > > pool */ @@ -1269,7 +1272,15 @@ rte_mempool_cache_flush(struct
> > rte_mempool_cache *cache,
> > > if (cache == NULL || cache->len == 0)
> > > return;
> > > rte_mempool_trace_cache_flush(cache, mp);
> > > - rte_mempool_ops_enqueue_bulk(mp, cache->objs, cache->len);
> > > +
> > > + unsigned int i;
> > > + unsigned int cache
Re: [dpdk-dev] [EXT] Re: [RFC 06/15] eventdev: use new API for inline functions
>Hello Pavan, > >On Mon, Aug 23, 2021 at 9:41 PM wrote: >> >> From: Pavan Nikhilesh >> >> Use new driver interface for the fastpath enqueue/dequeue inline >> functions. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> lib/eventdev/rte_event_crypto_adapter.h | 13 +- >> lib/eventdev/rte_event_eth_tx_adapter.h | 22 ++--- >> lib/eventdev/rte_eventdev.h | 61 +++-- >> 3 files changed, 22 insertions(+), 74 deletions(-) > >I sent this series in a branch of mine, and ran it per commit in GHA. >It caught a UT failure on this patch: >https://urldefense.proofpoint.com/v2/url?u=https- >3A__github.com_david-2Dmarchand_dpdk_runs_3408921022-3Fcheck- >5Fsuite-5Ffocus- >3Dtrue&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVs >B-fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=tO66InX69hLTAjHqOU- >zyUJUFA4AbnwTf4hFh1Wx2-c&s=awIyoR8T6crX- >sB4E1_NfLyzBt5zGfhSmfX6CIyw1x0&e= > > >--- stdout --- >RTE>>event_eth_tx_adapter_autotest > + --- + > + Test Suite : tx event eth adapter test suite >Port 0 MAC: 00 00 00 00 00 00 >Port 1 MAC: 00 00 00 00 00 00 >Failed to find a valid event device, testing with event_sw0 device > + --- + > + TestCase [ 0] : tx_adapter_create_free succeeded > + TestCase [ 1] : tx_adapter_queue_add_del succeeded > + TestCase [ 2] : tx_adapter_start_stop succeeded > + TestCase [ 3] : tx_adapter_service failed > + TestCase [ 4] : tx_adapter_dynamic_device failed > + --- + > + Test Suite Summary : tx event eth adapter test suite > + --- + > + Tests Total :5 > + Tests Skipped : 0 > + Tests Executed : 5 > + Tests Unsupported: 0 > + Tests Passed : 3 > + Tests Failed : 2 > + --- + >Test Failed > I just check with v2 (in progress) of my series and test passes, hopefully it fixes something overlooked in v1 EAL: Detected CPU lcores: 24 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: No available 16777216 kB hugepages reported EAL: No available 2048 kB hugepages reported EAL: VFIO support initialized TELEMETRY: No legacy callbacks, legacy socket not created APP: HPET is not enabled, using TSC as default timer RTE>>event_eth_tx_adapter_autotest + --- + + Test Suite : tx event eth adapter test suite Port 0 MAC: 00 00 00 00 00 00 Port 1 MAC: 00 00 00 00 00 00 Failed to find a valid event device, testing with event_sw0 device + --- + + TestCase [ 0] : tx_adapter_create_free succeeded Invalid port_id=2 EVENTDEV: txa_service_adapter_free() line 743: 1 Tx queues not deleted + TestCase [ 1] : tx_adapter_queue_add_del succeeded + TestCase [ 2] : tx_adapter_start_stop succeeded + TestCase [ 3] : tx_adapter_service succeeded + TestCase [ 4] : tx_adapter_dynamic_device succeeded + --- + + Test Suite Summary : tx event eth adapter test suite + --- + + Tests Total :5 + Tests Skipped : 0 + Tests Executed : 5 + Tests Unsupported: 0 + Tests Passed : 5 + Tests Failed : 0 + --- + Test OK RTE>> > >Can you double check? >Thanks. > >-- >David Marchand
[dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality
Hi Everyone, I sent this last week and haven’t heard back – apologize if I missed the response but if not here it is again… We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may release qpair memory that was allocated when we called rte_cryptodev_queue_pair_setup(). We’d do so by calling the function pointer queue_pair_release() which I believe is the prescribed way to do this. The DPDK change in question is here: https://github.com/DPDK/dpdk/commit/af668035f7f492424b2e199f155690815944a8ca Question: Is there another way for us to release this memory? I’ve looked through the public API and nothing stands out. Thanks Paul
[dpdk-dev] [PATCH] common/cnxk: add REE support
From: Liron Himi
Adding REE definitions and related ROC code
Signed-off-by: Liron Himi
---
drivers/common/cnxk/hw/ree.h| 165 +++
drivers/common/cnxk/hw/rvu.h| 5 +
drivers/common/cnxk/meson.build | 1 +
drivers/common/cnxk/roc_api.h | 4 +
drivers/common/cnxk/roc_constants.h | 2 +
drivers/common/cnxk/roc_mbox.h | 100 +
drivers/common/cnxk/roc_platform.c | 1 +
drivers/common/cnxk/roc_platform.h | 2 +
drivers/common/cnxk/roc_priv.h | 3 +
drivers/common/cnxk/roc_ree.c | 647
drivers/common/cnxk/roc_ree.h | 137 ++
drivers/common/cnxk/roc_ree_priv.h | 18 +
drivers/common/cnxk/version.map | 18 +-
13 files changed, 1102 insertions(+), 1 deletion(-)
create mode 100644 drivers/common/cnxk/hw/ree.h
create mode 100644 drivers/common/cnxk/roc_ree.c
create mode 100644 drivers/common/cnxk/roc_ree.h
create mode 100644 drivers/common/cnxk/roc_ree_priv.h
diff --git a/drivers/common/cnxk/hw/ree.h b/drivers/common/cnxk/hw/ree.h
new file mode 100644
index 00..0766d35e52
--- /dev/null
+++ b/drivers/common/cnxk/hw/ree.h
@@ -0,0 +1,165 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#ifndef __REE_HW_H__
+#define __REE_HW_H__
+
+/* REE instruction queue length */
+#define REE_IQ_LEN (1 << 13)
+
+#define REE_DEFAULT_CMD_QLEN REE_IQ_LEN
+
+/* Status register bits */
+#define REE_STATUS_PMI_EOJ_BIT(1 << 14)
+#define REE_STATUS_PMI_SOJ_BIT(1 << 13)
+#define REE_STATUS_MP_CNT_DET_BIT (1 << 7)
+#define REE_STATUS_MM_CNT_DET_BIT (1 << 6)
+#define REE_STATUS_ML_CNT_DET_BIT (1 << 5)
+#define REE_STATUS_MST_CNT_DET_BIT (1 << 4)
+#define REE_STATUS_MPT_CNT_DET_BIT (1 << 3)
+
+/* Register offsets */
+/* REE LF registers */
+#define REE_LF_DONE_INT0x120ull
+#define REE_LF_DONE_INT_W1S0x130ull
+#define REE_LF_DONE_INT_ENA_W1S 0x138ull
+#define REE_LF_DONE_INT_ENA_W1C 0x140ull
+#define REE_LF_MISC_INT0x300ull
+#define REE_LF_MISC_INT_W1S0x310ull
+#define REE_LF_MISC_INT_ENA_W1S 0x320ull
+#define REE_LF_MISC_INT_ENA_W1C 0x330ull
+#define REE_LF_ENA 0x10ull
+#define REE_LF_SBUF_ADDR 0x20ull
+#define REE_LF_DONE0x100ull
+#define REE_LF_DONE_ACK0x110ull
+#define REE_LF_DONE_WAIT 0x148ull
+#define REE_LF_DOORBELL0x400ull
+#define REE_LF_OUTSTAND_JOB0x410ull
+
+/* BAR 0 */
+#define REE_AF_REEXM_MAX_MATCH (0x80c8ull)
+#define REE_AF_QUE_SBUF_CTL(a) (0x1200ull | (uint64_t)(a) << 3)
+#define REE_PRIV_LF_CFG(a) (0x41000ull | (uint64_t)(a) << 3)
+
+#define REE_AF_QUEX_GMCTL(a) (0x800 | (a) << 3)
+
+#define REE_AF_INT_VEC_RAS (0x0ull)
+#define REE_AF_INT_VEC_RVU (0x1ull)
+#define REE_AF_INT_VEC_QUE_DONE (0x2ull)
+#define REE_AF_INT_VEC_AQ (0x3ull)
+
+/* ENUMS */
+
+#define REE_LF_INT_VEC_QUE_DONE (0x0ull)
+#define REE_LF_INT_VEC_MISC(0x1ull)
+
+#define REE_LF_BAR2(vf, q_id)
\
+ ((vf)->dev->bar2 + (((vf)->block_address << 20) | ((q_id) << 12)))
+
+#define REE_QUEUE_HI_PRIO 0x1
+
+enum ree_desc_type_e {
+ REE_TYPE_JOB_DESC = 0x0,
+ REE_TYPE_RESULT_DESC = 0x1,
+ REE_TYPE_ENUM_LAST = 0x2
+};
+
+union ree_priv_lf_cfg {
+ uint64_t u;
+ struct {
+ uint64_t slot : 8;
+ uint64_t pf_func : 16;
+ uint64_t reserved_24_62 : 39;
+ uint64_t ena : 1;
+ } s;
+};
+
+union ree_lf_sbuf_addr {
+ uint64_t u;
+ struct {
+ uint64_t off : 7;
+ uint64_t ptr : 46;
+ uint64_t reserved_53_63 : 11;
+ } s;
+};
+
+union ree_lf_ena {
+ uint64_t u;
+ struct {
+ uint64_t ena : 1;
+ uint64_t reserved_1_63 : 63;
+ } s;
+};
+
+union ree_af_reexm_max_match {
+ uint64_t u;
+ struct {
+ uint64_t max : 8;
+ uint64_t reserved_8_63 : 56;
+ } s;
+};
+
+union ree_lf_done {
+ uint64_t u;
+ struct {
+ uint64_t done : 20;
+ uint64_t reserved_20_63 : 44;
+ } s;
+};
+
+union ree_res_status {
+ uint64_t u;
+ struct {
+ uint64_t job_type : 3;
+ uint64_t mpt_cnt_det : 1;
+ uint64_t mst_cnt_det : 1;
+ uint64_t ml_cnt_det : 1;
+ uint64_t mm_cnt_det : 1;
+ uint64_t mp_cnt_det : 1;
+ uint64_t mode : 2;
+ uint64_t reserved_10_11 : 2;
+ uint64_t reserved_12_12 : 1;
+ uint64_t pmi_soj : 1;
+ uint64_t pmi_eoj : 1;
+ uint64_t reserved_15_15 : 1;
+ uint64_t reserved_16_63 : 48;
+ } s;
+};
+
+union ree_res {
+ uint64_t u[8];
+ struct ree_res_s_98 {
+ uint64_t done : 1;
+ uint64_t hwjid : 7;
+ uint64_t ree_res_job_id :
