Re: [dpdk-dev] [PATCH v2 1/3] ethdev: support metadata as flow rule criteria

[Xueming(Steven) Li]

> -Original Message-
> From: dev  On Behalf Of Dekel Peled
> Sent: Sunday, September 16, 2018 10:38 PM
> To: wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; 
> dev@dpdk.org;
> olivier.m...@6wind.com; Adrien Mazarguil ; Thomas 
> Monjalon
> ; ferruh.yi...@intel.com; arybche...@solarflare.com
> Cc: Shahaf Shuler ; Ori Kam 
> Subject: [dpdk-dev] [PATCH v2 1/3] ethdev: support metadata as flow rule 
> criteria
> 
> As described in [1], a new rte_flow item is added to support metadata to use 
> as flow rule match
> pattern.
> The metadata is an opaque item, fully controlled by the application.
> 
> The use of metadata is relevant for egress rules only.
> It can be set in the flow rule using the RTE_FLOW_ITEM_META.
> 
> In order to avoid change in mbuf API, exisitng field buf.hash.fdir.hi is used 
> to carry the metadata
> item. This field is used only in ingress packets, so using it for egress 
> metadata will not cause
> conflicts.
> 
> Application should set the packet metadata in the mbuf dedicated field, and 
> set the PKT_TX_METADATA
> flag in the mbuf->ol_flags.
> The NIC will use the packet metadata as match criteria for relevant flow 
> rules.
> 
> This patch introduces metadata item type for rte_flow RTE_FLOW_ITEM_META, 
> along with corresponding
> struct rte_flow_item_meta and ol_flag PKT_TX_METADATA.
> 
> [1] "[RFC,v2] ethdev: support metadata as flow rule criteria"
> 
> Signed-off-by: Dekel Peled 
> ---
> V2:
> * Fix some checkpatch coding style issues (wrongly sent).
> ---
> 
>  doc/guides/prog_guide/rte_flow.rst | 21 +
>  lib/librte_ethdev/rte_ethdev.c |  1 +
>  lib/librte_ethdev/rte_ethdev.h |  5 +
>  lib/librte_ethdev/rte_flow.c   |  1 +
>  lib/librte_ethdev/rte_flow.h   | 24 
>  lib/librte_mbuf/rte_mbuf.c |  2 ++
>  lib/librte_mbuf/rte_mbuf.h | 16 ++--
>  7 files changed, 68 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/rte_flow.rst 
> b/doc/guides/prog_guide/rte_flow.rst
> index b305a72..560e45a 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -1191,6 +1191,27 @@ Normally preceded by any of:
>  - `Item: ICMP6_ND_NS`_
>  - `Item: ICMP6_ND_OPT`_
> 
> +Item: ``META``
> +^^
> +
> +Matches an application specific 32 bit metadata item.
> +
> +- Default ``mask`` matches any 32 bit value.
> +
> +.. _table_rte_flow_item_meta:
> +
> +.. table:: META
> +
> +   +--+--+---+
> +   | Field| Subfield | Value |
> +   +==+==+===+
> +   | ``spec`` | ``data`` | 32 bit metadata value |
> +   +--+--+
> +   | ``last`` | ``data`` | upper range value |
> +   +--+--+---+
> +   | ``mask`` | ``data`` | zeroed to match any value |
> +   +--+--+---+
> +
>  Actions
>  ~~~
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c 
> index f790d42..1ae7694
> 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -158,6 +158,7 @@ struct rte_eth_xstats_name_off {
>   RTE_TX_OFFLOAD_BIT2STR(SECURITY),
>   RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
>   RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
> + RTE_TX_OFFLOAD_BIT2STR(MATCH_METADATA),
>  };
> 
>  #undef RTE_TX_OFFLOAD_BIT2STR
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h 
> index 7070e9a..a0da16c
> 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -953,6 +953,11 @@ struct rte_eth_conf {
>   * for tunnel TSO.
>   */
>  #define DEV_TX_OFFLOAD_IP_TNL_TSO   0x0008
> +/**
> + * Device supports match on metadata Tx offload..
> + * Application must set PKT_TX_METADATA and mbuf metadata field.
> + */
> +#define DEV_TX_OFFLOAD_MATCH_METADATA   0x0010
> 
>  #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x0001  /**< Device 
> supports Rx queue setup
> after device started*/ diff --git a/lib/librte_ethdev/rte_flow.c 
> b/lib/librte_ethdev/rte_flow.c
> index cff4b52..54e5ef8 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -66,6 +66,7 @@ struct rte_flow_desc_data {
>sizeof(struct rte_flow_item_icmp6_nd_opt_sla_eth)),
>   MK_FLOW_ITEM(ICMP6_ND_OPT_TLA_ETH,
>sizeof(struct rte_flow_item_icmp6_nd_opt_tla_eth)),
> + MK_FLOW_ITEM(META, sizeof(struct rte_flow_item_meta)),
>  };
> 
>  /** Generate flow_action[] entry. */
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h 
> index f8ba71c..4cc5954
> 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -413,6 +413,14 @@ enum rte_flow_item_type {
>* See struct rte_flow_item_mark.
>*/
>   RTE_

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

[Xiaoyu Min]

>  
>  static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index f8ba71cdb..48c3c606e 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1505,6 +1505,34 @@ enum rte_flow_action_type {
>* error.
>*/
>   RTE_FLOW_ACTION_TYPE_NVGRE_DECAP,
> +
> + /**
> +  * Modify IPv4 source address
> +  *
> +  * See struct rte_flow_action_set_ipv4.
> +  */
> + RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC,
> +
> + /**
> +  * Modify IPv4 destination address
> +  *
> +  * See struct rte_flow_action_set_ipv4.
> +  */
> + RTE_FLOW_ACTION_TYPE_SET_IPV4_DST,
> +
> + /**
> +  * Modify IPv6 source address
> +  *
> +  * See struct rte_flow_action_set_ipv6.
> +  */
> + RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC,
> +
> + /**
> +  * Modify IPv6 destination address
> +  *
> +  * See struct rte_flow_action_set_ipv6.
> +  */
> + RTE_FLOW_ACTION_TYPE_SET_IPV6_DST,
>  };
Hey Rahul,

Sorry for the late response. Just a small comment:

We would need the corresponding RTE_FLOW_ITEM_TYPE_* specified in pattern.
i.e RTE_FLOW_ITEM_TYPE_IPV6 must be in pattern for action 
RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
otherwise RTE_FLOW_ERROR_TYPE_ACTION return.
Would be better to document this in comments and __rte_flow.rst__

What do you think?

-Jack

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support metadata as flow rule criteria

[Xueming(Steven) Li]

> -Original Message-
> From: dev  On Behalf Of Dekel Peled
> Sent: Sunday, September 16, 2018 10:38 PM
> To: wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; 
> dev@dpdk.org;
> olivier.m...@6wind.com; Adrien Mazarguil ; Thomas 
> Monjalon
> ; ferruh.yi...@intel.com; arybche...@solarflare.com
> Cc: Shahaf Shuler ; Ori Kam 
> Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support metadata as flow rule 
> criteria
> 
> As described in [1], this series adds option to set metadata value as match 
> pattern when creating a
> new flow rule.
> 
> This patch introduces additional options in testpmd commands.
> New item type "meta" "data", new offload flag "match_metadata".
> 
> [1] "ethdev: support metadata as flow rule criteria"
> 
> Signed-off-by: Dekel Peled 
> ---
> V2:
> * Fix some checkpatch coding style issues (wrongly sent).
> ---
> 
>  app/test-pmd/cmdline.c  | 14 --
>  app/test-pmd/cmdline_flow.c | 25 +
>  app/test-pmd/config.c   |  1 +
>  app/test-pmd/testpmd.c  |  4 
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  5 ++---
>  5 files changed, 40 insertions(+), 9 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 
> 589121d..4559d59 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -17403,7 +17403,8 @@ struct cmd_config_per_port_tx_offload_result {
> "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
> "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
> "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
> -   "mt_lockfree#multi_segs#mbuf_fast_free#security");
> +   "mt_lockfree#multi_segs#mbuf_fast_free#security#"
> +   "match_metadata");
>  cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off =
>   TOKEN_STRING_INITIALIZER
>   (struct cmd_config_per_port_tx_offload_result,
> @@ -17484,8 +17485,8 @@ struct cmd_config_per_port_tx_offload_result {
>   "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
>   "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
>   "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
> - "mt_lockfree|multi_segs|mbuf_fast_free|security "
> - "on|off",
> + "mt_lockfree|multi_segs|mbuf_fast_free|security|"
> + "match_metadata on|off",
>   .tokens = {
>   (void *)&cmd_config_per_port_tx_offload_result_port,
>   (void *)&cmd_config_per_port_tx_offload_result_config,
> @@ -17535,7 +17536,8 @@ struct cmd_config_per_queue_tx_offload_result {
> "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
> "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
> "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
> -   "mt_lockfree#multi_segs#mbuf_fast_free#security");
> +   "mt_lockfree#multi_segs#mbuf_fast_free#security#"
> +   "match_metadata");
>  cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off =
>   TOKEN_STRING_INITIALIZER
>   (struct cmd_config_per_queue_tx_offload_result,
> @@ -17588,8 +17590,8 @@ struct cmd_config_per_queue_tx_offload_result {
>   "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
>   "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
>   "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
> - "mt_lockfree|multi_segs|mbuf_fast_free|security "
> - "on|off",
> + "mt_lockfree|multi_segs|mbuf_fast_free|security|"
> + "match_metadata on|off",
>   .tokens = {
>   (void *)&cmd_config_per_queue_tx_offload_result_port,
>   (void *)&cmd_config_per_queue_tx_offload_result_port_id,
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 
> f926060..f6ca6b4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -178,6 +178,8 @@ enum index {
>   ITEM_ICMP6_ND_OPT_SLA_ETH_SLA,
>   ITEM_ICMP6_ND_OPT_TLA_ETH,
>   ITEM_ICMP6_ND_OPT_TLA_ETH_TLA,
> + ITEM_META,
> + ITEM_META_DATA,
> 
>   /* Validate/create actions. */
>   ACTIONS,
> @@ -564,6 +566,7 @@ struct parse_action_priv {
>   ITEM_ICMP6_ND_OPT,
>   ITEM_ICMP6_ND_OPT_SLA_ETH,
>   ITEM_ICMP6_ND_OPT_TLA_ETH,
> + ITEM_META,
>   ZERO,
>  };
> 
> @@ -784,6 +787,12 @@ struct parse_action_priv {
>   ZERO,
>  };
> 
> +static const enum index item_meta[] = {
> + ITEM_META_DATA,
> + ITEM_NEXT,
> + ZERO,
> +};
> +
>  static const enum index next_action[] = {
>   ACTION_END,
>   ACTION_VOID,
> @@ -1985,6 +1994,22 @@ static int comp_vc_action_rss_queue(struct context *, 
> const struct token *

[dpdk-dev] [PATCH v1] e1000: support dev reset

[Gaetan Rivet]

Add support for passive device reset on IGB ports.

Signed-off-by: Gaetan Rivet 
---
 drivers/net/e1000/igb_ethdev.c | 29 +
 1 file changed, 29 insertions(+)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 64dfe6836..4dbf46b28 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -74,6 +74,7 @@ static void eth_igb_stop(struct rte_eth_dev *dev);
 static int  eth_igb_dev_set_link_up(struct rte_eth_dev *dev);
 static int  eth_igb_dev_set_link_down(struct rte_eth_dev *dev);
 static void eth_igb_close(struct rte_eth_dev *dev);
+static int eth_igb_reset(struct rte_eth_dev *dev);
 static void eth_igb_promiscuous_enable(struct rte_eth_dev *dev);
 static void eth_igb_promiscuous_disable(struct rte_eth_dev *dev);
 static void eth_igb_allmulticast_enable(struct rte_eth_dev *dev);
@@ -351,6 +352,7 @@ static const struct eth_dev_ops eth_igb_ops = {
.dev_set_link_up  = eth_igb_dev_set_link_up,
.dev_set_link_down= eth_igb_dev_set_link_down,
.dev_close= eth_igb_close,
+   .dev_reset= eth_igb_reset,
.promiscuous_enable   = eth_igb_promiscuous_enable,
.promiscuous_disable  = eth_igb_promiscuous_disable,
.allmulticast_enable  = eth_igb_allmulticast_enable,
@@ -1593,6 +1595,33 @@ eth_igb_close(struct rte_eth_dev *dev)
rte_eth_linkstatus_set(dev, &link);
 }
 
+/*
+ * Reset PF device.
+ */
+static int
+eth_igb_reset(struct rte_eth_dev *dev)
+{
+   int ret;
+
+   /* When a DPDK PMD PF begin to reset PF port, it should notify all
+* its VF to make them align with it. The detailed notification
+* mechanism is PMD specific and is currently not implemented.
+* To avoid unexpected behavior in VF, currently reset of PF with
+* SR-IOV activation is not supported. It might be supported later.
+*/
+   if (dev->data->sriov.active)
+   return -ENOTSUP;
+
+   ret = eth_igb_dev_uninit(dev);
+   if (ret)
+   return ret;
+
+   ret = eth_igb_dev_init(dev);
+
+   return ret;
+}
+
+
 static int
 igb_get_rx_buffer_size(struct e1000_hw *hw)
 {
-- 
2.18.0

[dpdk-dev] [PATCH v1] testpmd: eeprom display

[Gaetan Rivet]

The interactive command

  show port eeprom 

will dump the content of the EEPROM for the selected port.
Dumping eeprom of all ports at once is not supported.

Signed-off-by: Gaetan Rivet 
---
 app/test-pmd/cmdline.c |  9 +++--
 app/test-pmd/config.c  | 32 
 app/test-pmd/testpmd.h |  1 +
 3 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index a7c0e622a..0801e7e74 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -170,6 +170,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"show port 
(info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"
"Display information for port_id, or all.\n\n"
 
+   "show port eeprom (port_id)\n"
+   "Display port EEPROM for port_id.\n\n"
+
"show port X rss reta (size) (mask0,mask1,...)\n"
"Display the rss redirection table entry indicated"
" by masks on port X. size is used to indicate the"
@@ -7202,6 +7205,8 @@ static void cmd_showport_parsed(void *parsed_result,
port_dcb_info_display(res->portnum);
else if (!strcmp(res->what, "cap"))
port_offload_cap_display(res->portnum);
+   else if (!strcmp(res->what, "eeprom"))
+   port_eeprom_display(res->portnum);
 }
 
 cmdline_parse_token_string_t cmd_showport_show =
@@ -7211,7 +7216,7 @@ cmdline_parse_token_string_t cmd_showport_port =
TOKEN_STRING_INITIALIZER(struct cmd_showport_result, port, "port");
 cmdline_parse_token_string_t cmd_showport_what =
TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
-"info#stats#xstats#fdir#stat_qmap#dcb_tc#cap");
+
"info#stats#xstats#fdir#stat_qmap#dcb_tc#cap#eeprom");
 cmdline_parse_token_num_t cmd_showport_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT16);
 
@@ -7219,7 +7224,7 @@ cmdline_parse_inst_t cmd_showport = {
.f = cmd_showport_parsed,
.data = NULL,
.help_str = "show|clear port "
-   "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap "
+   "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap|eeprom "
"",
.tokens = {
(void *)&cmd_showport_show,
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 14ccd6864..af1a7d37a 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -49,6 +49,7 @@
 #include 
 #endif
 #include 
+#include 
 #include 
 
 #include "testpmd.h"
@@ -739,6 +740,37 @@ port_offload_cap_display(portid_t port_id)
}
 }
 
+void
+port_eeprom_display(portid_t port_id)
+{
+   struct rte_eth_dev_module_info minfo;
+   struct rte_dev_eeprom_info einfo;
+   char buf[1024];
+   int ret;
+
+   if (port_id == (portid_t)RTE_PORT_ALL)
+   return;
+
+   ret = rte_eth_dev_get_module_info(port_id, &minfo);
+   if (ret) {
+   printf("Unable to get module info: %d\n", ret);
+   return;
+   }
+
+   einfo.offset = 0;
+   einfo.length = minfo.eeprom_len;
+   einfo.data = buf;
+
+   ret = rte_eth_dev_get_module_eeprom(port_id, &einfo);
+   if (ret) {
+   printf("Unable to get module EEPROM: %d\n", ret);
+   return;
+   }
+
+   printf("Port %hhu EEPROM:\n", port_id);
+   rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);
+}
+
 int
 port_id_is_invalid(portid_t port_id, enum print_warning warning)
 {
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index a1f661472..bf817bdcf 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -595,6 +595,7 @@ void nic_xstats_clear(portid_t port_id);
 void nic_stats_mapping_display(portid_t port_id);
 void port_infos_display(portid_t port_id);
 void port_offload_cap_display(portid_t port_id);
+void port_eeprom_display(portid_t port_id);
 void rx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
 void tx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
 void fwd_lcores_config_display(void);
-- 
2.18.0

[dpdk-dev] DEV_RX_OFFLOAD_SCATTER not available in i40e an cxgbe

[Martin Weiser]

Hi,

is there a specific reason that the rx offload capability
DEV_RX_OFFLOAD_SCATTER is not available in the i40e and cxgbe drivers in
DPDK 18.08?
We previously used this feature with DPDK 17.11 to handle jumbo frames
while using 2k mbufs and it worked without a problem.
It also seems that simply adding the flag to dev_info->rx_offload_capa
makes it work again.

Best regards,
Martin

Re: [dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

[Xiaoyu Min]

> 
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 638331c17..f60be0862 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3713,6 +3713,14 @@ This section lists supported actions and their
> attributes, if any.
> 
>- ``ipv6_addr``: New IPv6 destination address.
> 
> +- ``of_set_tp_src``: Set a new TCP/UDP source port number.
should be set_tp_src :-)
> +
> +  - ``port``: New TCP/UDP source port number.
> +
> +- ``of_set_tp_dst``: Set a new TCP/UDP destination port number.
set_tp_dst
> +  - ``port``: New TCP/UDP destination port number.
> +
>  Destroying flow rules
>  ~
> 


>  static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 48c3c606e..c80771b25 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1533,6 +1533,20 @@ enum rte_flow_action_type {
>  * See struct rte_flow_action_set_ipv6.
>  */
> RTE_FLOW_ACTION_TYPE_SET_IPV6_DST,
> +
> +   /**
> +* Modify source port in TCP/UDP packets.
> +*
> +* See struct rte_flow_action_set_tp.
> +*/
> +   RTE_FLOW_ACTION_TYPE_SET_TP_SRC,
> +
> +   /**
> +* Modify destination port in TCP/UDP packets.
> +*
> +* See struct rte_flow_action_set_tp.
> +*/
> +   RTE_FLOW_ACTION_TYPE_SET_TP_DST,
>  };
> 
We need to state the corresponding RTE_FLOW_ITEM_TYPE_(UDP|TCP) should be in 
pattern

-Jack   

[dpdk-dev] [PATCH v6] app/testpmd: add forwarding mode to simulate a noisy neighbour

[Jens Freimann]

This adds a new forwarding mode to testpmd to simulate
more realistic behavior of a guest machine engaged in receiving
and sending packets performing Virtual Network Function (VNF).

The goal is to enable a simple way of measuring performance impact on
cache and memory footprint utilization from various VNF co-located on
the same host machine. For this it does:

* Buffer packets in a FIFO:

Create a fifo to buffer received packets. Once it flows over put
those packets into the actual tx queue. The fifo is created per tx
queue and its size can be set with the --noisy-tx-sw-buffer-flushtime
commandline parameter.

A second commandline parameter is used to set a timeout in
milliseconds after which the fifo is flushed.

--noisy-tx-sw-buffer-size [packet numbers]
Keep the mbuf in a FIFO and forward the over flooding packets from the
FIFO. This queue is per TX-queue (after all other packet processing).

--noisy-tx-sw-buffer-flushtime [delay]
Flush the packet queue if no packets have been seen during
[delay]. As long as packets are seen, the timer is reset.

Add several options to simulate route lookups (memory reads) in tables
that can be quite large, as well as route hit statistics update.
These options simulates the while stack traversal and
will trash the cache. Memory access is random.

* simulate route lookups:

Allocate a buffer and perform reads and writes on it as specified by
commandline options:

--noisy-lkup-memory [size]
Size of the VNF internal memory (MB), in which the random
read/write will be done, allocated by rte_malloc (hugepages).

--noisy-lkup-num-writes [num]
Number of random writes in memory per packet should be
performed, simulating hit-flags update. 64 bits per write,
all write in different cache lines.

--noisy-lkup-num-reads [num]
Number of random reads in memory per packet should be
performed, simulating FIB/table lookups. 64 bits per read,
all write in different cache lines.

--noisy-lkup-num-reads-writes [num]
Number of random reads and writes in memory per packet should
be performed, simulating stats update. 64 bits per read-write, all
reads and writes in different cache lines.

Signed-off-by: Jens Freimann 
---
v5->v6:
 * fix patch description
 * fix comment for pkt_burst_noisy_vnf
 * check if flush needed when no packets were received
 * free dropped packets  
 * remove redundant else-if
 * do memory access simulation in all cases
 * change order of free'd data structures in noisy_fwd_end
 * only allocate one noisy_config struct per port 
 * check for return of rte_ring_create()
 * change checking of input parameters in noisy_fwd_begin(). Decided to
   allow to set paramters to 0 (which is the default)
 * did not change use of "=N" in documentation as suggested by Kevin
   because it is how it's done for most other parameters
 * make error message match code in checking of flush time parameter
 * don't add whitespace in testpmd.h 

v4->v5:
 * try to minimize impact in common code. Instead implement fwd_begin and 
fwd_end
 * simplify actual fwd function
 * remove unnecessary casts (Kevin)
 * use more meaningful names for parameters and global variables (Kevin)
 * free ring and vnf_mem as well (Kevin)
 * squash documentation and code into single patch (Bernard)
 * fix patch subject to "app/testpmd" (Bernard)

 app/test-pmd/Makefile   |   1 +
 app/test-pmd/meson.build|   1 +
 app/test-pmd/noisy_vnf.c| 279 
 app/test-pmd/parameters.c   |  60 +
 app/test-pmd/testpmd.c  |  35 +++
 app/test-pmd/testpmd.h  |   8 +
 doc/guides/testpmd_app_ug/run_app.rst   |  33 +++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 +-
 8 files changed, 422 insertions(+), 2 deletions(-)
 create mode 100644 app/test-pmd/noisy_vnf.c

diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index 2b4d604b8..e2581ca66 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -33,6 +33,7 @@ SRCS-y += rxonly.c
 SRCS-y += txonly.c
 SRCS-y += csumonly.c
 SRCS-y += icmpecho.c
+SRCS-y += noisy_vnf.c
 SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c
 SRCS-$(CONFIG_RTE_LIBRTE_BPF) += bpf_cmd.c
 
diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index a0b3be07f..9ef6ed957 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -17,6 +17,7 @@ sources = files('cmdline.c',
'iofwd.c',
'macfwd.c',
'macswap.c',
+   'noisy_vnf.c',
'parameters.c',
'rxonly.c',
'testpmd.c',
diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c
new file mode 100644
index 0..de9022074
--- /dev/null
+++ b/app/test-pmd/noisy_vnf.c
@@ -0,0 +1,279 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Red Hat Corp.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#includ

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

[Thomas Monjalon]

25/07/2018 20:20, Stephen Hemminger:
> No need for profanity in comments.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  drivers/net/bnx2x/elink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> index 34a29373af3b..08fe817720a1 100644
> --- a/drivers/net/bnx2x/elink.c
> +++ b/drivers/net/bnx2x/elink.c
> @@ -3993,11 +3993,11 @@ static elink_status_t 
> elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
>  PORT_HW_CFG_E3_MOD_ABS_MASK) >>
>   PORT_HW_CFG_E3_MOD_ABS_SHIFT;
>  
> - /* Should not happen. This function called upon interrupt
> + /*
> +  * Should not happen. This function called upon interrupt
>* triggered by GPIO ( since EPIO can only generate interrupts
>* to MCP).
>* So if this function was called and none of the GPIOs was set,
> -  * it means the shit hit the fan.
>*/

It makes the comment ends with a comma, like the end is missing.

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

[Thomas Monjalon]

26/07/2018 11:41, Burakov, Anatoly:
> On 25-Jul-18 7:20 PM, Stephen Hemminger wrote:
> > There is no need to call rte_exit and crash the application here;
> > better to let the application handle the error itself.
> > 
> > Remove the gratuitous profanity which would be visible if
> > the rte_exit was still there.
> > 
> > Signed-off-by: Stephen Hemminger 
> > ---
> > --- a/lib/librte_eal/common/eal_common_proc.c
> > +++ b/lib/librte_eal/common/eal_common_proc.c
> > @@ -841,14 +841,12 @@ mp_request_async(const char *dst, struct rte_mp_msg 
> > *req,
> >   
> > param->user_reply.nb_sent++;
> >   
> > -   if (rte_eal_alarm_set(ts->tv_sec * 100 + ts->tv_nsec / 1000,
> > - async_reply_handle, pending_req) < 0) {
> > +   ret = rte_eal_alarm_set(ts->tv_sec * 100 + ts->tv_nsec / 1000,
> > +   async_reply_handle, pending_req);
> > +   if (ret < 0)
> > RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n",
> > dst, req->name);
> > -   rte_panic("Fix the above shit to properly free all memory\n");
> 
> Profanity aside, i think the message was trying to tell me something - 
> namely, that if alarm_set fails, we're risking to leak this memory if 
> reply from the peer never comes, and we're risking leaving the 
> application hanging because the timeout never triggers. I'm not sure if 
> leaving this "to the user" is the right choice, because there is no way 
> for the user to free IPC-internal memory if it leaks.
> 
> So i think the proper way to handle this would've been to set the alarm 
> first, then, if it fails, don't sent the message in the first place.

What should be done here? OK to remove rte_panic for now?

Re: [dpdk-dev] [dpdk-stable] [PATCH] pdump: remove dependency on libpthread

[Thomas Monjalon]

07/08/2018 16:41, Reshma Pattan:
> pdump library now uses generic multi process channel
> and it is no more dependent on the pthreads, so remove
> the dependency from the Makefile.
> 

Fixes: 660098d61f57 ("pdump: use generic multi-process channel")
> CC: sta...@dpdk.org
> 
> Signed-off-by: Reshma Pattan 

Applied (with added Fixes), thanks

Re: [dpdk-dev] [PATCH 11/11] telemetry: add collectd plugin patch

[Thomas Monjalon]

23/08/2018 14:08, Ciara Power:
> This patch adds the patch for the collectd plugin developed for use
> with the DPDK Telemetry library. The patch is included here to allow
> users to apply the patch to collectd when using DPDK Telemetry.
> Further details on applying the collectd patch can be found in the
> collectd patch commit message.
> 
> The collectd plugin will be upstreamed to collectd at a later stage.

Yes it must be upstreamed to collectd.
So no need to add it in DPDK. OK to remove it in v2?

Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

[Bruce Richardson]

On Mon, Sep 17, 2018 at 09:58:59PM +0200, Thomas Monjalon wrote:
> 17/09/2018 21:34, Bruce Richardson:
> > On Mon, Sep 17, 2018 at 06:44:52PM +0200, Thomas Monjalon wrote:
> > > 17/09/2018 17:17, Bruce Richardson:
> > > > On Mon, Sep 17, 2018 at 03:38:58PM +0200, Thomas Monjalon wrote:
> > > > > 17/09/2018 14:54, Bruce Richardson:
> > > > > > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote:
> > > > > > > 29/08/2018 18:02, Bruce Richardson:
> > > > > > > > Add in a cross-file to enable 32-bit compile tests as part
> > > > > > > > of the test-meson-builds script.
> > > > > > > > 
> > > > > > > > Signed-off-by: Bruce Richardson 
> > > > > > > > ---
> > > > > > > > NOTE: For ease of use, it's recommended that meson 0.47 be used 
> > > > > > > > for
> > > > > > > > this testing. With earlier versions, it may be necessary to 
> > > > > > > > ensure that
> > > > > > > > the same development packages are installed for both 64-bit and 
> > > > > > > > 32-bit.
> > > > > > > > ---
> > > > > > > >  config/x86/i686_sse4_linuxapp_gcc | 18 ++
> > > > > > > >  devtools/test-meson-builds.sh |  4 
> > > > > > > >  2 files changed, 22 insertions(+)
> > > > > > > 
> > > > > > > I'm not sure about adding this test as mandatory, because 32-bit 
> > > > > > > version
> > > > > > > of libraries can be hard to get, especially libbsd and libnuma.
> > > > > > > I hope this test will be run by all developers, so we should not 
> > > > > > > discourage
> > > > > > > them by adding too many requirements.
> > > > > > > Opinion? Idea?
> > > > > > 
> > > > > > Libbsd is not required, but yes, libnuma is, so you do need a 32-bit
> > > > > > libnuma (devel) installed to run this test. I would expect that to 
> > > > > > be
> > > > > > available on most distros though. I'm open to suggestions as to how 
> > > > > > to make
> > > > > > this optional, but I do think that sanity checking 32-bit is good 
> > > > > > practice
> > > > > > to avoid errors, e.g. those wonderful printf format strings for 
> > > > > > uint64_t.*
> > > > > 
> > > > > I agree and I am testing i686 with the "make build system".
> > > > > I define DPDK_DEP_NUMA=n which disables any NUMA option.
> > > > > Can we have this kind of tweak with meson?
> > > > > 
> > > > > Or perhaps we can just have an option in the script to disable this 
> > > > > test?
> > > > > 
> > > > Actually, do you see build failures with 32-bit without the numa or BSD
> > > > libraries? I removed 32-bit versions of both dev packages and everything
> > > > still compiles? The setting of the appropriate defines is based on 
> > > > detected
> > > > libraries.
> > > 
> > > This is what I see:
> > > 
> > > ninja -C build-i686
> > > ninja: Entering directory `build-i686'
> > > [6/1237] Linking target lib/librte_kvargs.so.1.1.
> > > FAILED: lib/librte_kvargs.so.1.1 
> > > gcc  -o lib/librte_kvargs.so.1.1 
> > > 'lib/lib@@rte_kvargs@sta/librte_kvargs_rte_kvargs.c.o' -Wl,--no-undefined 
> > > -Wl,--as-needed -Wl,-O1 -shared -fPIC -Wl,--start-group 
> > > -Wl,-soname,librte_kvargs.so.1 -pthread -lm -ldl -lnuma -lbsd 
> > > -Wl,--end-group 
> > > -Wl,--version-script=lib/librte_kvargs/rte_kvargs_version.map -m32 
> > > /usr/bin/ld: skipping incompatible 
> > > /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libnuma.so when searching 
> > > for -lnuma
> > > /usr/bin/ld: skipping incompatible /usr/lib/libnuma.so when searching for 
> > > -lnuma
> > > /usr/bin/ld: cannot find -lnuma
> > > /usr/bin/ld: skipping incompatible 
> > > /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libbsd.so when searching 
> > > for -lbsd
> > > /usr/bin/ld: skipping incompatible /usr/lib/libbsd.so when searching for 
> > > -lbsd
> > > /usr/bin/ld: cannot find -lbsd
> > > collect2: error: ld returned 1 exit status
> > > [11/1237] Compiling C object 
> > > 'lib/lib@@rte_eal@sta/librte_eal_common_eal_common_fbarray.c.o'.
> > > ninja: build stopped: subcommand failed.
> > > 
> > What version of meson are you using? As the comment in the file suggests,
> > 0.47 is really needed for sane behaviour, as before then meson could
> > sometimes pick up 64-bit static libs and use them for 32-bit compilation.
> > [Being static libs makes them rather hard to test if they are usable since
> > the .a file itself doesn't provide that info, unlike for a .so]. So for
> > 0.46 or earlier, you can still build, but you probably need 32-bit versions
> > of your 64-bit dev packages installed.
> 
> I am using meson 0.47.2
> Is there a bug somewhere?
> 
Possibly.
Let's leave out the patch for now and I'll try and investigate further.
What OS distro are you using, so I can try and reproduce the issue?

/Bruce

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

[Burakov, Anatoly]

On 18-Sep-18 10:43 AM, Thomas Monjalon wrote:

26/07/2018 11:41, Burakov, Anatoly:

On 25-Jul-18 7:20 PM, Stephen Hemminger wrote:

There is no need to call rte_exit and crash the application here;
better to let the application handle the error itself.

Remove the gratuitous profanity which would be visible if
the rte_exit was still there.

Signed-off-by: Stephen Hemminger 
---
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -841,14 +841,12 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,
   
   	param->user_reply.nb_sent++;
   
-	if (rte_eal_alarm_set(ts->tv_sec * 100 + ts->tv_nsec / 1000,

- async_reply_handle, pending_req) < 0) {
+   ret = rte_eal_alarm_set(ts->tv_sec * 100 + ts->tv_nsec / 1000,
+   async_reply_handle, pending_req);
+   if (ret < 0)
RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n",
dst, req->name);
-   rte_panic("Fix the above shit to properly free all memory\n");


Profanity aside, i think the message was trying to tell me something -
namely, that if alarm_set fails, we're risking to leak this memory if
reply from the peer never comes, and we're risking leaving the
application hanging because the timeout never triggers. I'm not sure if
leaving this "to the user" is the right choice, because there is no way
for the user to free IPC-internal memory if it leaks.

So i think the proper way to handle this would've been to set the alarm
first, then, if it fails, don't sent the message in the first place.


What should be done here? OK to remove rte_panic for now?



As i said, the above fix is wrong because it leaks memory (however 
unlikely it may be).


The alarm set call should be moved to before we do send_msg() call (and 
goto fail; on failure). That way, even if alarm triggers too early (i.e. 
immediately), the requests tailq will still be locked until we complete 
our request sends - so we appropriately free memory on response, on 
timeout or in our failure handler if alarm set has failed.


--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

[Thomas Monjalon]

18/09/2018 12:15, Bruce Richardson:
> On Mon, Sep 17, 2018 at 09:58:59PM +0200, Thomas Monjalon wrote:
> > 17/09/2018 21:34, Bruce Richardson:
> > > On Mon, Sep 17, 2018 at 06:44:52PM +0200, Thomas Monjalon wrote:
> > > > 17/09/2018 17:17, Bruce Richardson:
> > > > > On Mon, Sep 17, 2018 at 03:38:58PM +0200, Thomas Monjalon wrote:
> > > > > > 17/09/2018 14:54, Bruce Richardson:
> > > > > > > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote:
> > > > > > > > 29/08/2018 18:02, Bruce Richardson:
> > > > > > > > > Add in a cross-file to enable 32-bit compile tests as part
> > > > > > > > > of the test-meson-builds script.
> > > > > > > > > 
> > > > > > > > > Signed-off-by: Bruce Richardson 
> > > > > > > > > ---
> > > > > > > > > NOTE: For ease of use, it's recommended that meson 0.47 be 
> > > > > > > > > used for
> > > > > > > > > this testing. With earlier versions, it may be necessary to 
> > > > > > > > > ensure that
> > > > > > > > > the same development packages are installed for both 64-bit 
> > > > > > > > > and 32-bit.
> > > > > > > > > ---
> > > > > > > > >  config/x86/i686_sse4_linuxapp_gcc | 18 ++
> > > > > > > > >  devtools/test-meson-builds.sh |  4 
> > > > > > > > >  2 files changed, 22 insertions(+)
> > > > > > > > 
> > > > > > > > I'm not sure about adding this test as mandatory, because 
> > > > > > > > 32-bit version
> > > > > > > > of libraries can be hard to get, especially libbsd and libnuma.
> > > > > > > > I hope this test will be run by all developers, so we should 
> > > > > > > > not discourage
> > > > > > > > them by adding too many requirements.
> > > > > > > > Opinion? Idea?
> > > > > > > 
> > > > > > > Libbsd is not required, but yes, libnuma is, so you do need a 
> > > > > > > 32-bit
> > > > > > > libnuma (devel) installed to run this test. I would expect that 
> > > > > > > to be
> > > > > > > available on most distros though. I'm open to suggestions as to 
> > > > > > > how to make
> > > > > > > this optional, but I do think that sanity checking 32-bit is good 
> > > > > > > practice
> > > > > > > to avoid errors, e.g. those wonderful printf format strings for 
> > > > > > > uint64_t.*
> > > > > > 
> > > > > > I agree and I am testing i686 with the "make build system".
> > > > > > I define DPDK_DEP_NUMA=n which disables any NUMA option.
> > > > > > Can we have this kind of tweak with meson?
> > > > > > 
> > > > > > Or perhaps we can just have an option in the script to disable this 
> > > > > > test?
> > > > > > 
> > > > > Actually, do you see build failures with 32-bit without the numa or 
> > > > > BSD
> > > > > libraries? I removed 32-bit versions of both dev packages and 
> > > > > everything
> > > > > still compiles? The setting of the appropriate defines is based on 
> > > > > detected
> > > > > libraries.
> > > > 
> > > > This is what I see:
> > > > 
> > > > ninja -C build-i686
> > > > ninja: Entering directory `build-i686'
> > > > [6/1237] Linking target lib/librte_kvargs.so.1.1.
> > > > FAILED: lib/librte_kvargs.so.1.1 
> > > > gcc  -o lib/librte_kvargs.so.1.1 
> > > > 'lib/lib@@rte_kvargs@sta/librte_kvargs_rte_kvargs.c.o' 
> > > > -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -shared -fPIC 
> > > > -Wl,--start-group -Wl,-soname,librte_kvargs.so.1 -pthread -lm -ldl 
> > > > -lnuma -lbsd -Wl,--end-group 
> > > > -Wl,--version-script=lib/librte_kvargs/rte_kvargs_version.map -m32 
> > > > /usr/bin/ld: skipping incompatible 
> > > > /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libnuma.so when 
> > > > searching for -lnuma
> > > > /usr/bin/ld: skipping incompatible /usr/lib/libnuma.so when searching 
> > > > for -lnuma
> > > > /usr/bin/ld: cannot find -lnuma
> > > > /usr/bin/ld: skipping incompatible 
> > > > /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libbsd.so when 
> > > > searching for -lbsd
> > > > /usr/bin/ld: skipping incompatible /usr/lib/libbsd.so when searching 
> > > > for -lbsd
> > > > /usr/bin/ld: cannot find -lbsd
> > > > collect2: error: ld returned 1 exit status
> > > > [11/1237] Compiling C object 
> > > > 'lib/lib@@rte_eal@sta/librte_eal_common_eal_common_fbarray.c.o'.
> > > > ninja: build stopped: subcommand failed.
> > > > 
> > > What version of meson are you using? As the comment in the file suggests,
> > > 0.47 is really needed for sane behaviour, as before then meson could
> > > sometimes pick up 64-bit static libs and use them for 32-bit compilation.
> > > [Being static libs makes them rather hard to test if they are usable since
> > > the .a file itself doesn't provide that info, unlike for a .so]. So for
> > > 0.46 or earlier, you can still build, but you probably need 32-bit 
> > > versions
> > > of your 64-bit dev packages installed.
> > 
> > I am using meson 0.47.2
> > Is there a bug somewhere?
> > 
> Possibly.
> Let's leave out the patch for now and I'll try and investigate further.
> What OS distro are you using, so I can try and reproduce the issue?

I am using archlinux.

Thanks for investigating.

[dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

[Bruce Richardson]

Versions of meson prior to 0.47 flattened the parameters to the
"set_variable" function, which meant that the function could not take
array variables as a parameter. Therefore, we need to disable driver
tracking for those older versions, in order to maintain compatibility
with the minimum supported 0.41 version, and also v0.45 shipped in
Ubuntu 18.04 release.

Fixes: 806c45dd483d ("build: add configuration summary at end of config")

Signed-off-by: Bruce Richardson 
---
 drivers/meson.build |  5 -
 meson.build | 33 +++--
 2 files changed, 23 insertions(+), 15 deletions(-)

diff --git a/drivers/meson.build b/drivers/meson.build
index b6ce974de..c5df313dd 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -145,5 +145,8 @@ foreach class:driver_classes
endif # build
endforeach
 
-   set_variable(class + '_drivers', class_drivers)
+   if meson.version().version_compare('>=0.47')
+   # prior to 0.47, set_variable can't take array params
+   set_variable(class + '_drivers', class_drivers)
+   endif
 endforeach
diff --git a/meson.build b/meson.build
index 7332e75b5..2ed1247a3 100644
--- a/meson.build
+++ b/meson.build
@@ -89,18 +89,23 @@ foreach lib:enabled_libs
 endforeach
 message(output_message + '\n')
 
-output_message = '\n===\nDrivers Enabled\n===\n'
-foreach class:driver_classes
-   class_drivers = get_variable(class + '_drivers')
-   output_message += '\n' + class + ':\n\t'
-   output_count = 0
-   foreach drv:class_drivers
-   output_message += drv + ', '
-   output_count += 1
-   if output_count == 8
-   output_message += '\n\t'
-   output_count = 0
-   endif
+
+# prior to 0.47 set_variable didn't work with arrays, so we can't
+# track driver lists easily
+if meson.version().version_compare('>=0.47')
+   output_message = '\n===\nDrivers Enabled\n===\n'
+   foreach class:driver_classes
+   class_drivers = get_variable(class + '_drivers')
+   output_message += '\n' + class + ':\n\t'
+   output_count = 0
+   foreach drv:class_drivers
+   output_message += drv + ', '
+   output_count += 1
+   if output_count == 8
+   output_message += '\n\t'
+   output_count = 0
+   endif
+   endforeach
endforeach
-endforeach
-message(output_message + '\n')
+   message(output_message + '\n')
+endif
-- 
2.17.1

[dpdk-dev] [PATCH v7 1/2] librte_lpm: Improve performance of the delete and add functions

[Alex Kiselev]

lpm6: store rules in hash table for lpm6

Rework the lpm6 rule subsystem and replace
current rules algorithm complexity O(n)
with hashtables which allow dealing with
large (50k) rule sets.

Signed-off-by: Alex Kiselev 
Acked-by: Bruce Richardson 
---
 lib/Makefile   |   2 +-
 lib/librte_lpm/Makefile|   2 +-
 lib/librte_lpm/meson.build |   1 +
 lib/librte_lpm/rte_lpm6.c  | 368 +
 4 files changed, 210 insertions(+), 163 deletions(-)

diff --git a/lib/Makefile b/lib/Makefile
index d82462ba2..070104657 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -47,7 +47,7 @@ DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
 DEPDIRS-librte_efd := librte_eal librte_ring librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm
-DEPDIRS-librte_lpm := librte_eal
+DEPDIRS-librte_lpm := librte_eal librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl
 DEPDIRS-librte_acl := librte_eal
 DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
diff --git a/lib/librte_lpm/Makefile b/lib/librte_lpm/Makefile
index 482bd72e9..a7946a1c5 100644
--- a/lib/librte_lpm/Makefile
+++ b/lib/librte_lpm/Makefile
@@ -8,7 +8,7 @@ LIB = librte_lpm.a
 
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
-LDLIBS += -lrte_eal
+LDLIBS += -lrte_eal -lrte_hash
 
 EXPORT_MAP := rte_lpm_version.map
 
diff --git a/lib/librte_lpm/meson.build b/lib/librte_lpm/meson.build
index 067849427..a5176d8ae 100644
--- a/lib/librte_lpm/meson.build
+++ b/lib/librte_lpm/meson.build
@@ -7,3 +7,4 @@ headers = files('rte_lpm.h', 'rte_lpm6.h')
 # since header files have different names, we can install all vector headers
 # without worrying about which architecture we actually need
 headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h')
+deps += ['hash']
diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index 149677eb1..d86e878bc 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -21,6 +21,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 #include "rte_lpm6.h"
 
@@ -37,6 +40,8 @@
 #define BYTE_SIZE 8
 #define BYTES2_SIZE  16
 
+#define RULE_HASH_TABLE_EXTRA_SPACE  64
+
 #define lpm6_tbl8_gindex next_hop
 
 /** Flags for setting an entry as valid/invalid. */
@@ -70,6 +75,12 @@ struct rte_lpm6_rule {
uint8_t depth; /**< Rule depth. */
 };
 
+/** Rules tbl entry key. */
+struct rte_lpm6_rule_key {
+   uint8_t ip[RTE_LPM6_IPV6_ADDR_SIZE]; /**< Rule IP address. */
+   uint8_t depth; /**< Rule depth. */
+};
+
 /** LPM6 structure. */
 struct rte_lpm6 {
/* LPM metadata. */
@@ -80,7 +91,7 @@ struct rte_lpm6 {
uint32_t next_tbl8;  /**< Next tbl8 to be used. */
 
/* LPM Tables. */
-   struct rte_lpm6_rule *rules_tbl; /**< LPM rules. */
+   struct rte_hash *rules_tbl; /**< LPM rules. */
struct rte_lpm6_tbl_entry tbl24[RTE_LPM6_TBL24_NUM_ENTRIES]
__rte_cache_aligned; /**< LPM tbl24 table. */
struct rte_lpm6_tbl_entry tbl8[0]
@@ -93,22 +104,69 @@ struct rte_lpm6 {
  * and set the rest to 0.
  */
 static inline void
-mask_ip(uint8_t *ip, uint8_t depth)
+ip6_mask_addr(uint8_t *ip, uint8_t depth)
 {
-int16_t part_depth, mask;
-int i;
+   int16_t part_depth, mask;
+   int i;
 
-   part_depth = depth;
+   part_depth = depth;
 
-   for (i = 0; i < RTE_LPM6_IPV6_ADDR_SIZE; i++) {
-   if (part_depth < BYTE_SIZE && part_depth >= 0) {
-   mask = (uint16_t)(~(UINT8_MAX >> part_depth));
-   ip[i] = (uint8_t)(ip[i] & mask);
-   } else if (part_depth < 0) {
-   ip[i] = 0;
-   }
-   part_depth -= BYTE_SIZE;
-   }
+   for (i = 0; i < RTE_LPM6_IPV6_ADDR_SIZE; i++) {
+   if (part_depth < BYTE_SIZE && part_depth >= 0) {
+   mask = (uint16_t)(~(UINT8_MAX >> part_depth));
+   ip[i] = (uint8_t)(ip[i] & mask);
+   } else if (part_depth < 0)
+   ip[i] = 0;
+
+   part_depth -= BYTE_SIZE;
+   }
+}
+
+/* copy ipv6 address */
+static inline void
+ip6_copy_addr(uint8_t *dst, const uint8_t *src)
+{
+   rte_memcpy(dst, src, RTE_LPM6_IPV6_ADDR_SIZE);
+}
+
+/*
+ * LPM6 rule hash function
+ *
+ * It's used as a hash function for the rte_hash
+ * containing rules
+ */
+static inline uint32_t
+rule_hash(const void *data, __rte_unused uint32_t data_len,
+ uint32_t init_val)
+{
+   return rte_jhash(data, sizeof(struct rte_lpm6_rule_key), init_val);
+}
+
+/*
+ * Init a rule key.
+ *   note that ip must be already masked
+ */
+static inline void
+rule_key_init(struct rte_lpm6_rule_key *key, uint8_t *ip, uint8_t depth)
+{
+   

[dpdk-dev] [PATCH v7 2/2] librte_lpm: Improve performance of the delete and add functions

[Alex Kiselev]

lpm6: add incremental update on delete

rework the delete function and add additional 
internal data structures to support incremental 
LPM tree update rather than full tree rebuild

Signed-off-by: Alex Kiselev 
Acked-by: Bruce Richardson 
---
 lib/librte_lpm/rte_lpm6.c | 712 ++
 1 file changed, 597 insertions(+), 115 deletions(-)

diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index d86e878bc..6f1f94e23 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -41,6 +41,7 @@
 #define BYTES2_SIZE  16
 
 #define RULE_HASH_TABLE_EXTRA_SPACE  64
+#define TBL24_INDUINT32_MAX
 
 #define lpm6_tbl8_gindex next_hop
 
@@ -81,6 +82,17 @@ struct rte_lpm6_rule_key {
uint8_t depth; /**< Rule depth. */
 };
 
+/* Header of tbl8 */
+struct rte_lpm_tbl8_hdr {
+   uint32_t owner_tbl_ind; /**< owner table: TBL24_IND if owner is tbl24,
+   * otherwise index of tbl8
+   */
+   uint32_t owner_entry_ind; /**< index of the owner table entry where
+   * pointer to the tbl8 is stored
+   */
+   uint32_t ref_cnt; /**< table reference counter */
+};
+
 /** LPM6 structure. */
 struct rte_lpm6 {
/* LPM metadata. */
@@ -88,12 +100,17 @@ struct rte_lpm6 {
uint32_t max_rules;  /**< Max number of rules. */
uint32_t used_rules; /**< Used rules so far. */
uint32_t number_tbl8s;   /**< Number of tbl8s to allocate. */
-   uint32_t next_tbl8;  /**< Next tbl8 to be used. */
 
/* LPM Tables. */
struct rte_hash *rules_tbl; /**< LPM rules. */
struct rte_lpm6_tbl_entry tbl24[RTE_LPM6_TBL24_NUM_ENTRIES]
__rte_cache_aligned; /**< LPM tbl24 table. */
+
+   uint32_t *tbl8_pool; /**< pool of indexes of free tbl8s */
+   uint32_t tbl8_pool_pos; /**< current position in the tbl8 pool */
+
+   struct rte_lpm_tbl8_hdr *tbl8_hdrs; /* array of tbl8 headers */
+
struct rte_lpm6_tbl_entry tbl8[0]
__rte_cache_aligned; /**< LPM tbl8 table. */
 };
@@ -142,6 +159,59 @@ rule_hash(const void *data, __rte_unused uint32_t data_len,
return rte_jhash(data, sizeof(struct rte_lpm6_rule_key), init_val);
 }
 
+/*
+ * Init pool of free tbl8 indexes
+ */
+static void
+tbl8_pool_init(struct rte_lpm6 *lpm)
+{
+   uint32_t i;
+
+   /* put entire range of indexes to the tbl8 pool */
+   for (i = 0; i < lpm->number_tbl8s; i++)
+   lpm->tbl8_pool[i] = i;
+
+   lpm->tbl8_pool_pos = 0;
+}
+
+/*
+ * Get an index of a free tbl8 from the pool
+ */
+static inline uint32_t
+tbl8_get(struct rte_lpm6 *lpm, uint32_t *tbl8_ind)
+{
+   if (lpm->tbl8_pool_pos == lpm->number_tbl8s)
+   /* no more free tbl8 */
+   return -ENOSPC;
+
+   /* next index */
+   *tbl8_ind = lpm->tbl8_pool[lpm->tbl8_pool_pos++];
+   return 0;
+}
+
+/*
+ * Put an index of a free tbl8 back to the pool
+ */
+static inline uint32_t
+tbl8_put(struct rte_lpm6 *lpm, uint32_t tbl8_ind)
+{
+   if (lpm->tbl8_pool_pos == 0)
+   /* pool is full */
+   return -ENOSPC;
+
+   lpm->tbl8_pool[--lpm->tbl8_pool_pos] = tbl8_ind;
+   return 0;
+}
+
+/*
+ * Returns number of tbl8s available in the pool
+ */
+static inline uint32_t
+tbl8_available(struct rte_lpm6 *lpm)
+{
+   return lpm->number_tbl8s - lpm->tbl8_pool_pos;
+}
+
 /*
  * Init a rule key.
  *   note that ip must be already masked
@@ -182,6 +252,8 @@ rte_lpm6_create(const char *name, int socket_id,
uint64_t mem_size;
struct rte_lpm6_list *lpm_list;
struct rte_hash *rules_tbl = NULL;
+   uint32_t *tbl8_pool = NULL;
+   struct rte_lpm_tbl8_hdr *tbl8_hdrs = NULL;
 
lpm_list = RTE_TAILQ_CAST(rte_lpm6_tailq.head, rte_lpm6_list);
 
@@ -216,6 +288,28 @@ rte_lpm6_create(const char *name, int socket_id,
goto fail_wo_unlock;
}
 
+   /* allocate tbl8 indexes pool */
+   tbl8_pool = rte_malloc(NULL,
+   sizeof(uint32_t) * config->number_tbl8s,
+   RTE_CACHE_LINE_SIZE);
+   if (tbl8_pool == NULL) {
+   RTE_LOG(ERR, LPM, "LPM tbl8 pool allocation failed: %s (%d)",
+ rte_strerror(rte_errno), rte_errno);
+   rte_errno = ENOMEM;
+   goto fail_wo_unlock;
+   }
+
+   /* allocate tbl8 headers */
+   tbl8_hdrs = rte_malloc(NULL,
+   sizeof(struct rte_lpm_tbl8_hdr) * config->number_tbl8s,
+   RTE_CACHE_LINE_SIZE);
+   if (tbl8_hdrs == NULL) {
+   RTE_LOG(ERR, LPM, "LPM tbl8 headers allocation failed: %s (%d)",
+ rte_strerror(rte_errno), 

Re: [dpdk-dev] [PATCH v5] doc: add cross compile part for sample applications

[Jerin Jacob]

-Original Message-
> Date: Mon, 17 Sep 2018 18:53:43 +0800
> From: Gavin Hu 
> To: dev@dpdk.org
> CC: gavin...@arm.com, honnappa.nagaraha...@arm.com,
>  jerin.ja...@caviumnetworks.com, sta...@dpdk.org
> Subject: [PATCH v5] doc: add cross compile part for sample applications
> X-Mailer: git-send-email 2.11.0
> 
> External Email
> 
> Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Gavin Hu 
> Reviewed-by: Honnappa Nagarahalli 
> ---
>  doc/guides/sample_app_ug/compiling.rst | 16 +++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/sample_app_ug/compiling.rst 
> b/doc/guides/sample_app_ug/compiling.rst
> index a2d75ed22..9ff531906 100644
> --- a/doc/guides/sample_app_ug/compiling.rst
> +++ b/doc/guides/sample_app_ug/compiling.rst
> @@ -9,7 +9,6 @@ This section explains how to compile the DPDK sample 
> applications.
>  To compile all the sample applications
>  --
> 
> -
>  Set the path to DPDK source code if its not set:
> 
>  .. code-block:: console
> @@ -93,3 +92,18 @@ Build the application:
> 
>  export RTE_TARGET=build
>  make
> +
> +To cross compile the sample application(s)
> +--
> +
> +For cross compiling the sample application(s), please append 
> 'CROSS=$(CROSS_COMPILER_PREFIX)' to the 'make' command.

IMO, You can remove "please"

> +In example of AARCH64 cross compiling:

I think, it is better to change to "AARCH64 cross compiling example:"

> +
> +.. code-block:: console
> +
> +export RTE_TARGET=build
> +export RTE_SDK=/path/to/rte_sdk
> +make -C examples CROSS=aarch64-linux-gnu-
> +   or
> +cd $(pwd)/examples/

Better to change to:
cd $(RTE_SDK)/examples/

> +make CROSS=aarch64-linux-gnu-
> --
> 2.11.0


With above changes you can add my Acked-by:
Acked-by: Jerin Jacob 

> 

Re: [dpdk-dev] [PATCH v1] testpmd: eeprom display

[Gaëtan Rivet]

Hi,

I am looking at support on e1000/IGB ports, and I have used this
command to verify support. It works for fiber but not for copper.

I can see in the get_module_info callback that copper SFPs are
not supported. Same thing as the kernel driver.

Is it possible to use MDIO for dumping the SFP EEPROM?
Alternatively, is I2C available in MGII mode with copper?

Thanks,

On Tue, Sep 18, 2018 at 10:59:46AM +0200, Gaetan Rivet wrote:
> The interactive command
> 
>   show port eeprom 
> 
> will dump the content of the EEPROM for the selected port.
> Dumping eeprom of all ports at once is not supported.
> 
> Signed-off-by: Gaetan Rivet 
> ---
>  app/test-pmd/cmdline.c |  9 +++--
>  app/test-pmd/config.c  | 32 
>  app/test-pmd/testpmd.h |  1 +
>  3 files changed, 40 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index a7c0e622a..0801e7e74 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -170,6 +170,9 @@ static void cmd_help_long_parsed(void *parsed_result,
>   "show port 
> (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"
>   "Display information for port_id, or all.\n\n"
>  
> + "show port eeprom (port_id)\n"
> + "Display port EEPROM for port_id.\n\n"
> +
>   "show port X rss reta (size) (mask0,mask1,...)\n"
>   "Display the rss redirection table entry indicated"
>   " by masks on port X. size is used to indicate the"
> @@ -7202,6 +7205,8 @@ static void cmd_showport_parsed(void *parsed_result,
>   port_dcb_info_display(res->portnum);
>   else if (!strcmp(res->what, "cap"))
>   port_offload_cap_display(res->portnum);
> + else if (!strcmp(res->what, "eeprom"))
> + port_eeprom_display(res->portnum);
>  }
>  
>  cmdline_parse_token_string_t cmd_showport_show =
> @@ -7211,7 +7216,7 @@ cmdline_parse_token_string_t cmd_showport_port =
>   TOKEN_STRING_INITIALIZER(struct cmd_showport_result, port, "port");
>  cmdline_parse_token_string_t cmd_showport_what =
>   TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
> -  "info#stats#xstats#fdir#stat_qmap#dcb_tc#cap");
> +  
> "info#stats#xstats#fdir#stat_qmap#dcb_tc#cap#eeprom");
>  cmdline_parse_token_num_t cmd_showport_portnum =
>   TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT16);
>  
> @@ -7219,7 +7224,7 @@ cmdline_parse_inst_t cmd_showport = {
>   .f = cmd_showport_parsed,
>   .data = NULL,
>   .help_str = "show|clear port "
> - "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap "
> + "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap|eeprom "
>   "",
>   .tokens = {
>   (void *)&cmd_showport_show,
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 14ccd6864..af1a7d37a 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -49,6 +49,7 @@
>  #include 
>  #endif
>  #include 
> +#include 
>  #include 
>  
>  #include "testpmd.h"
> @@ -739,6 +740,37 @@ port_offload_cap_display(portid_t port_id)
>   }
>  }
>  
> +void
> +port_eeprom_display(portid_t port_id)
> +{
> + struct rte_eth_dev_module_info minfo;
> + struct rte_dev_eeprom_info einfo;
> + char buf[1024];
> + int ret;
> +
> + if (port_id == (portid_t)RTE_PORT_ALL)
> + return;
> +
> + ret = rte_eth_dev_get_module_info(port_id, &minfo);
> + if (ret) {
> + printf("Unable to get module info: %d\n", ret);
> + return;
> + }
> +
> + einfo.offset = 0;
> + einfo.length = minfo.eeprom_len;
> + einfo.data = buf;
> +
> + ret = rte_eth_dev_get_module_eeprom(port_id, &einfo);
> + if (ret) {
> + printf("Unable to get module EEPROM: %d\n", ret);
> + return;
> + }
> +
> + printf("Port %hhu EEPROM:\n", port_id);
> + rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);
> +}
> +
>  int
>  port_id_is_invalid(portid_t port_id, enum print_warning warning)
>  {
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> index a1f661472..bf817bdcf 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -595,6 +595,7 @@ void nic_xstats_clear(portid_t port_id);
>  void nic_stats_mapping_display(portid_t port_id);
>  void port_infos_display(portid_t port_id);
>  void port_offload_cap_display(portid_t port_id);
> +void port_eeprom_display(portid_t port_id);
>  void rx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
>  void tx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
>  void fwd_lcores_config_display(void);
> -- 
> 2.18.0
> 

-- 
Gaëtan Rivet
6WIND

[dpdk-dev] [Bug 91] Unable to build on Ubuntu 18.04

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=91

Bug ID: 91
   Summary: Unable to build on Ubuntu 18.04
   Product: DPDK
   Version: unspecified
  Hardware: x86
OS: Linux
Status: CONFIRMED
  Severity: critical
  Priority: Normal
 Component: mk
  Assignee: dev@dpdk.org
  Reporter: and...@wavecon.ru
  Target Milestone: ---

Clean fresh install of Ubuntu 14.04.1 Desktop. Build essential installed.
Bug: unable to build DPDK if path contains tilde char "~".
Make commands finish immediately with success, but noting happens.

For example, if path:
/projects/dpdk
it's ok.

but if path contains "~" char:
/projects/~new/dpdk 
it's unable to build with no error.

Configuration: x86_64-native-linuxapp-gcc

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [PATCH 1/3] event: add function for reading unlink in progress

[Elo, Matias (Nokia - FI/Espoo)]

> 
> +/**
> + * Returns the number of unlinks in progress.
> + *
> + * This function provides the application with a method to detect when an
> + * unlink has been completed by the implementation. See 
> *rte_event_port_unlink*
> + * on how to issue unlink requests.
> + *
> + * @param dev_id
> + *   The indentifier of the device.
> + *
> + * @param port_id
> + *   Event port identifier to select port to check for unlinks in progress.
> + *
> + * @return
> + * The number of unlinks that are in progress. A return of zero indicates 
> that
> + * there are no outstanding unlink requests. A positive return value 
> indicates
> + * the number of unlinks that are in progress, but are not yet complete.
> + * A negative return value indicates an error, -EINVAL indicates an invalid
> + * parameter passed for *dev_id* or *port_id*.
> + */
> +int __rte_experimental
> +rte_event_port_unlinks_in_progress(uint8_t dev_id, uint8_t port_id);
> +

Sorry for slow response (been out of office for the past week). This looks good 
to me and should solve my original problem.

Re: [dpdk-dev] [PATCH 02/10] crypto/caam_jr: introduce basic driver

[Akhil Goyal]

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:


From: Hemant Agrawal 

This patch introduces basic support for caam_jr crypto driver.

Signed-off-by: Gagandeep Singh 
Signed-off-by: Hemant Agrawal 
---
  config/common_base|   8 +
  config/common_linuxapp|   1 +
  config/defconfig_arm64-dpaa-linuxapp-gcc  |   4 +
  drivers/crypto/Makefile   |   1 +
  drivers/crypto/caam_jr/Makefile   |  40 +
  drivers/crypto/caam_jr/caam_jr.c  | 157 ++
  drivers/crypto/caam_jr/caam_jr_log.h  |  42 +
  drivers/crypto/caam_jr/meson.build|  11 ++
  .../caam_jr/rte_pmd_caam_jr_version.map   |   4 +
  drivers/crypto/meson.build|   2 +-
  10 files changed, 269 insertions(+), 1 deletion(-)
  create mode 100644 drivers/crypto/caam_jr/Makefile
  create mode 100644 drivers/crypto/caam_jr/caam_jr.c
  create mode 100644 drivers/crypto/caam_jr/caam_jr_log.h
  create mode 100644 drivers/crypto/caam_jr/meson.build
  create mode 100644 drivers/crypto/caam_jr/rte_pmd_caam_jr_version.map

diff --git a/config/common_base b/config/common_base
index 4bcbaf923..a73f063d1 100644
--- a/config/common_base
+++ b/config/common_base
@@ -479,6 +479,14 @@ CONFIG_RTE_CRYPTO_MAX_DEVS=64
  CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO=n
  CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n
  
+#

+# Compile NXP CAAM JR crypto Driver
+#
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR_BE=n
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR_DEBUG=n


Do you really need DEBUG?


+CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS=2048


MAX_NB_SESSIONS is no more used in any of the drivers.

Do you have a limitation in your hardware?


+
  #
  # Compile NXP DPAA2 crypto sec driver for CAAM HW
  #
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 9c5ea9d89..c1c7c4287 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -35,6 +35,7 @@ CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
  CONFIG_RTE_LIBRTE_DPAA_PMD=y
  CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
  CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR=y
  
  # NXP FSLMC BUS and DPAA2 drivers

  CONFIG_RTE_LIBRTE_FSLMC_BUS=y
diff --git a/config/defconfig_arm64-dpaa-linuxapp-gcc 
b/config/defconfig_arm64-dpaa-linuxapp-gcc
index c47aec0a6..e5343f7a9 100644
--- a/config/defconfig_arm64-dpaa-linuxapp-gcc
+++ b/config/defconfig_arm64-dpaa-linuxapp-gcc
@@ -21,3 +21,7 @@ CONFIG_RTE_PKTMBUF_HEADROOM=128
  # NXP DPAA Bus
  CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=n
  CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
+
+# NXP CAAM_JR driver
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR=y
+CONFIG_RTE_LIBRTE_PMD_CAAM_JR_BE=y
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index c480cbd37..e3711d703 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -6,6 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += aesni_gcm
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += aesni_mb
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += armv8
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_CCP) += ccp
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_OPENSSL) += openssl
  DIRS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += scheduler
diff --git a/drivers/crypto/caam_jr/Makefile b/drivers/crypto/caam_jr/Makefile
new file mode 100644
index 0..46d752af7
--- /dev/null
+++ b/drivers/crypto/caam_jr/Makefile
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2017 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_caam_jr.a
+
+# build flags
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -D _GNU_SOURCE
+ifeq ($(CONFIG_RTE_LIBRTE_CAAM_JR_DEBUG),y)
+CFLAGS += -O0 -g
+CFLAGS += "-Wno-error"
+else
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+endif
+
+CFLAGS += -I$(RTE_SDK)/drivers/crypto/caam_jr
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
+
+# versioning export map
+EXPORT_MAP := rte_pmd_caam_jr_version.map
+
+# library version
+LIBABIVER := 1
+
+# library source files
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr.c
+# library dependencies
+
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_cryptodev
+LDLIBS += -lrte_bus_vdev
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
new file mode 100644
index 0..68779cba5
--- /dev/null
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -0,0 +1,157 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2017-2018 NXP
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define CRYPTODEV_NAME_CAAM_JR_PMD crypto_caam_jr
+static uint8_t cryptodev_driver_id;
+int caam_jr_logtype;
+
+
+/*
+ * @brief Release the resources used by the SEC user space driver.
+ *
+ * Reset and release

Re: [dpdk-dev] [PATCH 01/10] doc: add caam jr cryptodev details

[Akhil Goyal]

++John

Hi Gagan,

Please make this patch as last patch in your patchset for v2.

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:

From: Hemant Agrawal 

Signed-off-by: Hemant Agrawal 
---
  doc/guides/cryptodevs/caam_jr.rst | 159 ++
  doc/guides/cryptodevs/index.rst   |   1 +
  2 files changed, 160 insertions(+)
  create mode 100644 doc/guides/cryptodevs/caam_jr.rst

diff --git a/doc/guides/cryptodevs/caam_jr.rst 
b/doc/guides/cryptodevs/caam_jr.rst
new file mode 100644
index 0..0ee501506
--- /dev/null
+++ b/doc/guides/cryptodevs/caam_jr.rst
@@ -0,0 +1,159 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright 2017 NXP
+
+
+NXP CAAM JOB RING (caam_jr)
+===
+
+The caam_jr PMD provides poll mode crypto driver support for NXP SEC 4.x+ 
(CAAM)
+hardware accelerator. More information is available at:
+
+`NXP Cryptographic Acceleration Technology  
`_.
+
+Architecture
+
+
+SEC is the SOC's security engine, which serves as NXP's latest cryptographic
+acceleration and offloading hardware. It combines functions previously
+implemented in separate modules to create a modular and scalable acceleration
+and assurance engine. It also implements block encryption algorithms, stream
+cipher algorithms, hashing algorithms, public key algorithms, run-time
+integrity checking, and a hardware random number generator. SEC performs
+higher-level cryptographic operations than previous NXP cryptographic
+accelerators. This provides significant improvement to system level 
performance.
+
+SEC HW accelerator above 4.x+ version are also known as CAAM.
+
+caam_jr PMD is one of DPAA drivers which uses uio interface to interact with
+Linux kernel for configure and destroy the device instance (ring).
+
+
+Implementation
+--
+
+SEC provides platform assurance by working with SecMon, which is a companion
+logic block that tracks the security state of the SOC. SEC is programmed by
+means of descriptors (not to be confused with frame descriptors (FDs)) that
+indicate the operations to be performed and link to the message and
+associated data. SEC incorporates two DMA engines to fetch the descriptors,
+read the message data, and write the results of the operations. The DMA
+engine provides a scatter/gather capability so that SEC can read and write
+data scattered in memory. SEC may be configured by means of software for
+dynamic changes in byte ordering. The default configuration for this version
+of SEC is little-endian mode.
+
+Note that one physical Job Ring represent one caam_jr device.
+
+Features
+
+
+The CAAM_JR PMD has support for:
+
+Cipher algorithms:
+
+* ``RTE_CRYPTO_CIPHER_3DES_CBC``
+* ``RTE_CRYPTO_CIPHER_AES128_CBC``
+* ``RTE_CRYPTO_CIPHER_AES192_CBC``
+* ``RTE_CRYPTO_CIPHER_AES256_CBC``
+* ``RTE_CRYPTO_CIPHER_AES128_CTR``
+* ``RTE_CRYPTO_CIPHER_AES192_CTR``
+* ``RTE_CRYPTO_CIPHER_AES256_CTR``
+
+Hash algorithms:
+
+* ``RTE_CRYPTO_AUTH_SHA1_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA224_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA256_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA384_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA512_HMAC``
+* ``RTE_CRYPTO_AUTH_MD5_HMAC``
+
+AEAD algorithms:
+
+* ``RTE_CRYPTO_AEAD_AES_GCM``
+
I do not see the features/caam_jr.ini file in the patch set. Please add 
the supported features in that file as well.

+Supported DPAA SoCs
+
+
+* LS1046A/LS1026A
+* LS1043A/LS1023A
+* LS1028A
+* LS1012A
+
+Limitations
+---
+
+* Hash followed by Cipher mode is not supported
+* Only supports the session-oriented API implementation (session-less APIs are 
not supported).
+
+Prerequisites
+-
+
+caam_jr driver has following dependencies are not part of DPDK and must be 
installed separately:
+
+* **NXP Linux SDK**
+
+  NXP Linux software development kit (SDK) includes support for the family
+  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
+
+Currently supported by DPDK:
+
+* NXP SDK **18.09+**.
+* Supported architectures:  **arm64 LE**.
+
+* Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+
+Pre-Installation Configuration
+--
+
+Config File Options
+~~~
+
+The following options can be modified in the ``config`` file
+to enable caam_jr PMD.
+
+Please note that enabling debugging options may affect system performance.
+
+* ``CONFIG_RTE_LIBRTE_PMD_CAAM_JR`` (default ``n``)
+  By default it is only enabled

Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

[Shreyansh Jain]

On Monday 17 September 2018 06:30 PM, Burakov, Anatoly wrote:

On 17-Sep-18 1:16 PM, Shahaf Shuler wrote:

Monday, September 17, 2018 1:07 PM, Burakov, Anatoly:
Subject: Re: [dpdk-dev] [PATCH 00/16] Support externally allocated 
memory

in DPDK

On 13-Sep-18 8:44 AM, Shahaf Shuler wrote:


[...]


The responsibility to ensure memory is accessible before using it is
on the shoulders of the user - there is no checking done with regards
to validity of the memory (nor could there be...).


That makes sense. However who should be in-charge of mapping this

memory for dma access?
The user or internally be the PMD when encounter the first packet or 
while

traversing the existing mempools?



Hi Shahaf,

There are two ways this can be solved. The first way is to perform VFIO
mapping automatically on adding/attaching memory. The second is to force
user to do it manually. For now, the latter is chosen because user 
knows best

if they intend to do DMA on that memory, but i'm open to suggestions.


I agree with that approach, and will add not only if the mempool is 
for dma or not but also which ports will use this mempool (this can 
effect on the mapping).


That is perhaps too hardware-specific - this should probably be handled 
inside the driver callbacks.


However I don't think this is generic enough to use only VFIO. As you 
said, there are some devices not using VFIO for mapping rather some 
proprietary driver utility.

IMO DPDK should introduce generic and device agnostic APIs to the user.

My suggestion is instead of doing vfio_dma_map that or vfio_dma_unmap 
that have a generic dma_map(uint8_t port, address, len). Each driver 
will register with its own mapping callback (can be vfio_dma_map).
It can be outside of this series, just wondering the people opinion on 
such approach.


I don't disagree. I don't like bus/net/etc drivers doing their own thing 
with regards to mapping, and i would by far prefer generic way to set up 
DMA maps, to which VFIO will be a subscriber.






There is an issue with some devices and buses (i.e. bus/fslmc) 
bypassing EAL

VFIO infrastructure and performing their own VFIO/DMA mapping magic, but
solving that problem is outside the scope of this patchset. Those
devices/buses should fix themselves :)


DMA mapping is a very common principle and can be easily be a candidate 
for lets-make-generic-movement, but, being close to hardware (or 
hardware specific), it does require the driver to have some flexibility 
in terms of its eventual implementation.


I maintain one of those drivers (bus/fslmc) in DPDK which needs to have 
special VFIO layer - and from that experience, I can say that VFIO 
mapping does require some flexibility. SoC semantics are sometimes too 
complex to pin to general-universally-agreed-standard concept. (or, one 
can easily call it a 'bug', while it is a 'feature' for others :D)


In fact, NXP has another driver (bus/dpaa) which doesn't even work with 
VFIO - loves to work directly with Phys_addr. And, it is not at a lower 
priority than one with VFIO.


Thus, I really don't think a strongly controlled VFIO mapping should be 
EAL's responsibility. Failure because of lack of mapping is a driver's 
problem.




When not using VFIO, it's out of our hands anyway.


Why?
VFIO is not a must requirement for devices in DPDK.


When i say "out of our hands", what i mean to say is, currently as far 
as EAL API is concerned, there is no DMA mapping outside of VFIO.






--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

[Akhil Goyal]

Hi Anoob,

On 9/17/2018 7:43 PM, Joseph, Anoob wrote:

Hi Akhil,


On 17-09-2018 17:50, Akhil Goyal wrote:

External Email

On 9/17/2018 5:12 PM, Joseph, Anoob wrote:


Hi Akhil,
On 17-09-2018 16:07, Akhil Goyal wrote:

External Email

I think it would be better to squash the makefile related changes in
the 3/33 patch as the code
is actually added in that and here the code is not getting compiled
here.

So the changes in the following files has to be moved to patch 3/33?
   drivers/crypto/Makefile
   drivers/crypto/meson.build
   drivers/crypto/octeontx/Makefile
   drivers/crypto/octeontx/meson.build
   mk/rte.app.mk
I think this patch will just have MAINTAINER edit (even that might be
required to be moved to 3/33?) & changes to config/common_base, after
that. Is that fine?

In my opinion, you do not need this patch as separate one.
config/common_base can also be added in the 3/33.

In that case 02/33 patch would become the first patch right? The same
problem would be there too, I guess. The macros added in that patch 
gets

used only in 03/33 patch. Is that fine?


I think that would be fine. Better to have a 03/33 patch before 02/33 
if it doesn't have dependencies.
03/33 patch is dependent on 02/33 patch. Shall I proceed with merging 
01/33 to 03/33 and make 02/33 the first patch?



The first patch would be a shell patch for most PMD additions. That's
the reason we started this way. If you want it changed, will do so.
Please do let me know what will be the right approach.


For the makefiles, you would be compiling the empty files which does 
not have any code. That does not make any sense to me.
With 01/33 there won't be any files compiled. We are just adding the 
library (which would be empty)


Normally, when we submit a new PMD, we add the basic PMD probe/remove 
in the first patch and add it into build system. Maintainers is also 
updated for the new PMD.


Further ops are added later in the patchset.

Hardware specific header files/ functions are added before they are 
used in the driver in a single/multiple logical patches.


In the end, documentation is added along with release note and 
MAINTAINERS update for documentation files.
I shall proceed with merging 01/33 to 03/33, if you can confirm making 
02/33 the first patch is fine. Or please do let me know if you have 
any other suggestions.


I see that the 2/33 is adding the logging macros. I believe that can 
also be merged in the 03/33.
Also I missed one comment on the documentation patch.. Please add your 
pmd doc entry in index.rst as well.

Anoob

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

[Joseph]

Hi Akhil,

On 18-09-2018 18:01, Akhil Goyal wrote:
> External Email
>
> Hi Anoob,
>
> On 9/17/2018 7:43 PM, Joseph, Anoob wrote:
>> Hi Akhil,
>>
>>
>> On 17-09-2018 17:50, Akhil Goyal wrote:
>>> External Email
>>>
>>> On 9/17/2018 5:12 PM, Joseph, Anoob wrote:
>>>
 Hi Akhil,
 On 17-09-2018 16:07, Akhil Goyal wrote:
> External Email
>>> I think it would be better to squash the makefile related 
>>> changes in
>>> the 3/33 patch as the code
>>> is actually added in that and here the code is not getting compiled
>>> here.
>> So the changes in the following files has to be moved to patch 3/33?
>>    drivers/crypto/Makefile
>>    drivers/crypto/meson.build
>>    drivers/crypto/octeontx/Makefile
>>    drivers/crypto/octeontx/meson.build
>>    mk/rte.app.mk
>> I think this patch will just have MAINTAINER edit (even that 
>> might be
>> required to be moved to 3/33?) & changes to config/common_base, 
>> after
>> that. Is that fine?
> In my opinion, you do not need this patch as separate one.
> config/common_base can also be added in the 3/33.
 In that case 02/33 patch would become the first patch right? The same
 problem would be there too, I guess. The macros added in that patch
 gets
 used only in 03/33 patch. Is that fine?
>>>
>>> I think that would be fine. Better to have a 03/33 patch before 02/33
>>> if it doesn't have dependencies.
>> 03/33 patch is dependent on 02/33 patch. Shall I proceed with merging
>> 01/33 to 03/33 and make 02/33 the first patch?
>>>
 The first patch would be a shell patch for most PMD additions. That's
 the reason we started this way. If you want it changed, will do so.
 Please do let me know what will be the right approach.
>>>
>>> For the makefiles, you would be compiling the empty files which does
>>> not have any code. That does not make any sense to me.
>> With 01/33 there won't be any files compiled. We are just adding the
>> library (which would be empty)
>>>
>>> Normally, when we submit a new PMD, we add the basic PMD probe/remove
>>> in the first patch and add it into build system. Maintainers is also
>>> updated for the new PMD.
>>>
>>> Further ops are added later in the patchset.
>>>
>>> Hardware specific header files/ functions are added before they are
>>> used in the driver in a single/multiple logical patches.
>>>
>>> In the end, documentation is added along with release note and
>>> MAINTAINERS update for documentation files.
>> I shall proceed with merging 01/33 to 03/33, if you can confirm making
>> 02/33 the first patch is fine. Or please do let me know if you have
>> any other suggestions.
>>
> I see that the 2/33 is adding the logging macros. I believe that can
> also be merged in the 03/33.
./devtools/check-git-log.sh was giving me issues when one patch was 
having edits in both drivers/common/cpt & drivers/crypto/octeontx. 
That's the reason it was separated out. Many patches had to be divided 
because of this.
> Also I missed one comment on the documentation patch.. Please add your
> pmd doc entry in index.rst as well.
Will fix this in v3.

Thanks,
Anoob

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

[Ananyev, Konstantin]

> > I am not saying this should be the ONLY way to do as it does not work
> > very well with non NPU/FPGA class of SoC.
> >
> > So how about making the proposed IPSec library as plugin/driver to
> > rte_security.
> 
> As I mentioned above, I don't think that pushing whole IPSec data-path into 
> rte_security
> is the best possible approach.
> Though I probably understand your concern:
> In RFC code we always do whole prepare/process in SW (attach/remove ESP 
> headers/trailers, so paddings etc.),
> i.e. right now only device types: RTE_SECURITY_ACTION_TYPE_NONE and 
> RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO are covered.
> Though there are devices where most of prepare/process can be done in HW
> (RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL/RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL),
> plus in future could be devices where prepare/process would be split between 
> HW/SW in a custom way.
> Is that so?
> To address that issue I suppose we can do:
> 1. Add support for RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL and 
> RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL
> security devices into ipsec.
> We planned to do it anyway, just don't have it done yet.
> 2. For custom case - introduce RTE_SECURITY_ACTION_TYPE_INLINE_CUSTOM and 
> RTE_SECURITY_ACTION_TYPE_LOOKASIDE_CUSTOM
> and add into rte_security_ops   new functions:
> uint16_t lookaside_prepare(struct rte_security_session *sess, struct 
> rte_mbuf *mb[], struct struct rte_crypto_op *cop[], uint16_t num);
> uint16_t lookaside_process(struct rte_security_session *sess, struct 
> rte_mbuf *mb[], struct struct rte_crypto_op *cop[], uint16_t num);
> uint16_t inline_process(struct rte_security_session *sess, struct 
> rte_mbuf *mb[], struct struct rte_crypto_op *cop[], uint16_t num);
> So for custom HW, PMD can overwrite normal prepare/process behavior.
> 

Actually  after another thought: 
My previous assumption (probably wrong one) was that for both
RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL and 
RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL
devices can do whole data-path ipsec processing totally in HW - no need for any 
SW support (except init/config).
Now looking at dpaa and dpaa2 devices (the only ones that supports 
RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL right now)
I am not so sure about that - looks like some SW help might be needed for 
replay window updates, etc.  
Hemant, Shreyansh - can you guys confirm what is expected from 
RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL devices
(HW/SW roses/responsibilities)?
About RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL  - I didn't find any driver 
inside DPDK source tree that does support that capability.
So my question is there any devices/drivers that do support it?
If so, where could source code could be found, and what are HW/SW 
roles/responsibilities for that type of devices?
Konstantin

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

[Akhil Goyal]

On 9/18/2018 6:10 PM, jos...@dpdk.org wrote:

Hi Akhil,

On 18-09-2018 18:01, Akhil Goyal wrote:

External Email

Hi Anoob,

On 9/17/2018 7:43 PM, Joseph, Anoob wrote:

Hi Akhil,


On 17-09-2018 17:50, Akhil Goyal wrote:

External Email

On 9/17/2018 5:12 PM, Joseph, Anoob wrote:


Hi Akhil,
On 17-09-2018 16:07, Akhil Goyal wrote:

External Email

I think it would be better to squash the makefile related
changes in
the 3/33 patch as the code
is actually added in that and here the code is not getting compiled
here.

So the changes in the following files has to be moved to patch 3/33?
    drivers/crypto/Makefile
    drivers/crypto/meson.build
    drivers/crypto/octeontx/Makefile
    drivers/crypto/octeontx/meson.build
    mk/rte.app.mk
I think this patch will just have MAINTAINER edit (even that
might be
required to be moved to 3/33?) & changes to config/common_base,
after
that. Is that fine?

In my opinion, you do not need this patch as separate one.
config/common_base can also be added in the 3/33.

In that case 02/33 patch would become the first patch right? The same
problem would be there too, I guess. The macros added in that patch
gets
used only in 03/33 patch. Is that fine?

I think that would be fine. Better to have a 03/33 patch before 02/33
if it doesn't have dependencies.

03/33 patch is dependent on 02/33 patch. Shall I proceed with merging
01/33 to 03/33 and make 02/33 the first patch?

The first patch would be a shell patch for most PMD additions. That's
the reason we started this way. If you want it changed, will do so.
Please do let me know what will be the right approach.

For the makefiles, you would be compiling the empty files which does
not have any code. That does not make any sense to me.

With 01/33 there won't be any files compiled. We are just adding the
library (which would be empty)

Normally, when we submit a new PMD, we add the basic PMD probe/remove
in the first patch and add it into build system. Maintainers is also
updated for the new PMD.

Further ops are added later in the patchset.

Hardware specific header files/ functions are added before they are
used in the driver in a single/multiple logical patches.

In the end, documentation is added along with release note and
MAINTAINERS update for documentation files.

I shall proceed with merging 01/33 to 03/33, if you can confirm making
02/33 the first patch is fine. Or please do let me know if you have
any other suggestions.


I see that the 2/33 is adding the logging macros. I believe that can
also be merged in the 03/33.

./devtools/check-git-log.sh was giving me issues when one patch was
having edits in both drivers/common/cpt & drivers/crypto/octeontx.
That's the reason it was separated out. Many patches had to be divided
because of this.
Oh,  my bad... I missed that this is a separate driver. I thought it was 
for the same driver.

It would be fine to have 02/33 as your first patch as Thomas also suggested.

Also I missed one comment on the documentation patch.. Please add your
pmd doc entry in index.rst as well.

Will fix this in v3.

Thanks,
Anoob

Re: [dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

[Timothy Redaelli]

On Tue, 18 Sep 2018 11:55:52 +0100
Bruce Richardson  wrote:

> Versions of meson prior to 0.47 flattened the parameters to the
> "set_variable" function, which meant that the function could not take
> array variables as a parameter. Therefore, we need to disable driver
> tracking for those older versions, in order to maintain compatibility
> with the minimum supported 0.41 version, and also v0.45 shipped in
> Ubuntu 18.04 release.
> 
> Fixes: 806c45dd483d ("build: add configuration summary at end of
> config")
> 
> Signed-off-by: Bruce Richardson 

Tried to build using meson 0.42.1 and it builds correctly

Tested-by: Timothy Redaelli 

[dpdk-dev] [PATCH v4 00/10] A Distributed Software Event Device

[Mattias Rönnblom]

v4:
* Reworded DSW introduction in the documentation.
* Updated the MAINTAINERS file and the 18.11 release notes.

v3:
* Fixed incorrect headline prefixes.
* Removed dummy dsw_event_schedule() function.
* Removed redundant output buffer flush.

v2:
* Added support for Meson builds.
* Eventdev 'xstats' support is now mandatory.
* Added check in dsw_probe() to allow secondary processes.
* rte_event_dev_stop() now runs the flush callback.
* Added documentation.
* Fixed uninitialized-use warning in ‘dsw_port_consider_migration'.
* Removed some dead (#if 0) debugging code.
* Version .map file is bumped to 18.11.
* Header files sorted in alphabetic order, newline after declarations
  and various other coding style-related improvements.

This is the Distributed Software (DSW) event device, which distributes
the task of scheduling events among all the eventdev ports and their
lcore threads.

DSW is primarily designed for atomic-only queues, but also supports
single-link and parallel queues.

(DSW would be more accurately described as 'parallel', but since that
term is used to describe an eventdev queue type, it's referred to as
'distributed', to avoid suggesting it's somehow biased toward parallel
queues.)

Event Scheduling


Internally, DSW hashes an eventdev flow id to a 15-bit "flow
hash". For each eventdev queue, there's a table mapping a flow hash to
an eventdev port. That port is considered the owner of the
flow. Owners are randomly picked at initialization time, among the
ports serving (i.e. are linked to) that queue.

The scheduling of an event to a port is done (by the sender port) at
time of the enqueue operation, and in most cases simply consists of
hashing the flow id and performing a lookup in the destination queue's
table. Each port has an MP/SC event ring to which the events are
enqueued. This means events go directly port-to-port, typically
meaning core-to-core.

Port Load Measurement
=

DSW includes a concept of port load. The event device keeps track of
transitions between "idle" and "busy" (or vice versa) on a per-port
basis, compares this to the wall time passed, and computes to what
extent the port was busy (for a certain interval). A port transitions
to "busy" on a non-zero dequeue, and again back to "idle" at the point
it performs a dequeue operation returning zero events.

Flow Migration
==

Periodically, hidden to the API user and as a part of a normal
enqueue/dequeue operations, a port updates its load estimate, and in
case the load has reached a certain threshold, considers moving one of
its flow to a different, more lightly loaded, port. This process is
called migration.

Migration Strategy
~~

The DSW migration strategy is to move a small, but yet active flow. To
quickly find which are the active flows (w/o resorting to scanning
through the tables and/or keeping per-event counters), each port
maintains a list of the last 128 events it has dequeued. If there are
lightly-loaded enough target ports, it will attempt to migrate one of
those flows, starting with the smallest. The size is estimated by the
number of events seen on that flow, in that small sample of events.

A good migration strategy, based on reasonably good estimates of port
and current flow event rates, is key for proper load balancing in a
DSW-style event device.

Migration Process
~

If the prerequisites are met, and a migration target flow and port is
found, the owning (source) port will initiate the migration
process. For parallel queues it's a very straightforward operation -
simply a table update. For atomic queues, in order to maintain their
semantics, it's a fair bit more elaborate a procedure.

A high-level view the migration process is available[1] in the form a
sequence diagram.

Much simplified, it consist of the source port sending messages to all
ports configured, asking them to "pause" the to-be-migrated flow. Such
ports will flush their output buffers and provide a confirmation back
to the source port.

Each port holds a list of which flows are paused. Upon the enqueue of
an event belonging to a paused flow, it will be accepted into the
machinery, but kept in a paused-events buffer located on the sending
port.

After receiving confirmations from all ports, the source port will
make sure its application-level user has finished processing of all
events related to the migrating flow, update the relevant queue's
table, and forward all unprocessed events (in its input event ring) to
the new target port.

The source port will then send out a request to "unpause" the flow to
all ports. Upon receiving such a request, the port will flush any
buffered (paused) events related to the paused flow, and provide a
confirmation.

All the signaling are done on regular DPDK rings (separate from the
event-carrying rings), and are pulled as a part of normal
enqueue/dequeue operation.

The migrations can be made fairly rapidly (in the range of a couple

[dpdk-dev] [PATCH v4 02/10] event/dsw: add DSW device and queue configuration

[Mattias Rönnblom]

Allow queue- and device-level configuration for and retrieval of
contextual information from a DSW event device.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c | 87 +++
 drivers/event/dsw/dsw_evdev.h | 28 +++
 2 files changed, 115 insertions(+)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 6990bbc9e..1500d2426 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -9,6 +9,91 @@
 
 #define EVENTDEV_NAME_DSW_PMD event_dsw
 
+static int
+dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
+   const struct rte_event_queue_conf *conf)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   struct dsw_queue *queue = &dsw->queues[queue_id];
+
+   if (RTE_EVENT_QUEUE_CFG_ALL_TYPES & conf->event_queue_cfg)
+   return -ENOTSUP;
+
+   if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
+   return -ENOTSUP;
+
+   /* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it
+* avoid the "fake" TYPE_PARALLEL flow_id assignment. Since
+* the queue will only have a single serving port, no
+* migration will ever happen, so the extra TYPE_ATOMIC
+* migration overhead is avoided.
+*/
+   if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg)
+   queue->schedule_type = RTE_SCHED_TYPE_ATOMIC;
+   else /* atomic or parallel */
+   queue->schedule_type = conf->schedule_type;
+
+   queue->num_serving_ports = 0;
+
+   return 0;
+}
+
+static void
+dsw_queue_def_conf(struct rte_eventdev *dev __rte_unused,
+  uint8_t queue_id __rte_unused,
+  struct rte_event_queue_conf *queue_conf)
+{
+   *queue_conf = (struct rte_event_queue_conf) {
+   .nb_atomic_flows = 4096,
+   .schedule_type = RTE_SCHED_TYPE_ATOMIC,
+   .priority = RTE_EVENT_DEV_PRIORITY_NORMAL
+   };
+}
+
+static void
+dsw_queue_release(struct rte_eventdev *dev __rte_unused,
+ uint8_t queue_id __rte_unused)
+{
+}
+
+static void
+dsw_info_get(struct rte_eventdev *dev __rte_unused,
+struct rte_event_dev_info *info)
+{
+   *info = (struct rte_event_dev_info) {
+   .driver_name = DSW_PMD_NAME,
+   .max_event_queues = DSW_MAX_QUEUES,
+   .max_event_queue_flows = DSW_MAX_FLOWS,
+   .max_event_queue_priority_levels = 1,
+   .max_event_priority_levels = 1,
+   .max_event_ports = DSW_MAX_PORTS,
+   .max_event_port_dequeue_depth = DSW_MAX_PORT_DEQUEUE_DEPTH,
+   .max_event_port_enqueue_depth = DSW_MAX_PORT_ENQUEUE_DEPTH,
+   .max_num_events = DSW_MAX_EVENTS,
+   .event_dev_cap = RTE_EVENT_DEV_CAP_BURST_MODE|
+   RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED
+   };
+}
+
+static int
+dsw_configure(const struct rte_eventdev *dev)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   const struct rte_event_dev_config *conf = &dev->data->dev_conf;
+
+   dsw->num_queues = conf->nb_event_queues;
+
+   return 0;
+}
+
+static struct rte_eventdev_ops dsw_evdev_ops = {
+   .queue_setup = dsw_queue_setup,
+   .queue_def_conf = dsw_queue_def_conf,
+   .queue_release = dsw_queue_release,
+   .dev_infos_get = dsw_info_get,
+   .dev_configure = dsw_configure,
+};
+
 static int
 dsw_probe(struct rte_vdev_device *vdev)
 {
@@ -23,6 +108,8 @@ dsw_probe(struct rte_vdev_device *vdev)
if (dev == NULL)
return -EFAULT;
 
+   dev->dev_ops = &dsw_evdev_ops;
+
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
return 0;
 
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index 9a0f4c357..5eda8d114 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -9,8 +9,36 @@
 
 #define DSW_PMD_NAME RTE_STR(event_dsw)
 
+/* Code changes are required to allow more ports. */
+#define DSW_MAX_PORTS (64)
+#define DSW_MAX_PORT_DEQUEUE_DEPTH (128)
+#define DSW_MAX_PORT_ENQUEUE_DEPTH (128)
+
+#define DSW_MAX_QUEUES (16)
+
+#define DSW_MAX_EVENTS (16384)
+
+/* Code changes are required to allow more flows than 32k. */
+#define DSW_MAX_FLOWS_BITS (15)
+#define DSW_MAX_FLOWS (1<<(DSW_MAX_FLOWS_BITS))
+#define DSW_MAX_FLOWS_MASK (DSW_MAX_FLOWS-1)
+
+struct dsw_queue {
+   uint8_t schedule_type;
+   uint16_t num_serving_ports;
+};
+
 struct dsw_evdev {
struct rte_eventdev_data *data;
+
+   struct dsw_queue queues[DSW_MAX_QUEUES];
+   uint8_t num_queues;
 };
 
+static inline struct dsw_evdev *
+dsw_pmd_priv(const struct rte_eventdev *eventdev)
+{
+   return eventdev->data->dev_private;
+}
+
 #endif
-- 
2.17.1

[dpdk-dev] [PATCH v4 03/10] event/dsw: add DSW port configuration

[Mattias Rönnblom]

Allow port setup and release in the DSW event device.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c | 60 +++
 drivers/event/dsw/dsw_evdev.h | 28 
 2 files changed, 88 insertions(+)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 1500d2426..91b1a2449 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -9,6 +9,62 @@
 
 #define EVENTDEV_NAME_DSW_PMD event_dsw
 
+static int
+dsw_port_setup(struct rte_eventdev *dev, uint8_t port_id,
+  const struct rte_event_port_conf *conf)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   struct dsw_port *port;
+   struct rte_event_ring *in_ring;
+   char ring_name[RTE_RING_NAMESIZE];
+
+   port = &dsw->ports[port_id];
+
+   *port = (struct dsw_port) {
+   .id = port_id,
+   .dsw = dsw,
+   .dequeue_depth = conf->dequeue_depth,
+   .enqueue_depth = conf->enqueue_depth,
+   .new_event_threshold = conf->new_event_threshold
+   };
+
+   snprintf(ring_name, sizeof(ring_name), "dsw%d_p%u", dev->data->dev_id,
+port_id);
+
+   in_ring = rte_event_ring_create(ring_name, DSW_IN_RING_SIZE,
+   dev->data->socket_id,
+   RING_F_SC_DEQ|RING_F_EXACT_SZ);
+
+   if (in_ring == NULL)
+   return -ENOMEM;
+
+   port->in_ring = in_ring;
+
+   dev->data->ports[port_id] = port;
+
+   return 0;
+}
+
+static void
+dsw_port_def_conf(struct rte_eventdev *dev __rte_unused,
+ uint8_t port_id __rte_unused,
+ struct rte_event_port_conf *port_conf)
+{
+   *port_conf = (struct rte_event_port_conf) {
+   .new_event_threshold = 1024,
+   .dequeue_depth = DSW_MAX_PORT_DEQUEUE_DEPTH / 4,
+   .enqueue_depth = DSW_MAX_PORT_ENQUEUE_DEPTH / 4
+   };
+}
+
+static void
+dsw_port_release(void *p)
+{
+   struct dsw_port *port = p;
+
+   rte_event_ring_free(port->in_ring);
+}
+
 static int
 dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
const struct rte_event_queue_conf *conf)
@@ -81,12 +137,16 @@ dsw_configure(const struct rte_eventdev *dev)
struct dsw_evdev *dsw = dsw_pmd_priv(dev);
const struct rte_event_dev_config *conf = &dev->data->dev_conf;
 
+   dsw->num_ports = conf->nb_event_ports;
dsw->num_queues = conf->nb_event_queues;
 
return 0;
 }
 
 static struct rte_eventdev_ops dsw_evdev_ops = {
+   .port_setup = dsw_port_setup,
+   .port_def_conf = dsw_port_def_conf,
+   .port_release = dsw_port_release,
.queue_setup = dsw_queue_setup,
.queue_def_conf = dsw_queue_def_conf,
.queue_release = dsw_queue_release,
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index 5eda8d114..2a4f10421 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -5,6 +5,7 @@
 #ifndef _DSW_EVDEV_H_
 #define _DSW_EVDEV_H_
 
+#include 
 #include 
 
 #define DSW_PMD_NAME RTE_STR(event_dsw)
@@ -23,6 +24,31 @@
 #define DSW_MAX_FLOWS (1<<(DSW_MAX_FLOWS_BITS))
 #define DSW_MAX_FLOWS_MASK (DSW_MAX_FLOWS-1)
 
+/* The rings are dimensioned so that all in-flight events can reside
+ * on any one of the port rings, to avoid the trouble of having to
+ * care about the case where there's no room on the destination port's
+ * input ring.
+ */
+#define DSW_IN_RING_SIZE (DSW_MAX_EVENTS)
+
+struct dsw_port {
+   uint16_t id;
+
+   /* Keeping a pointer here to avoid container_of() calls, which
+* are expensive since they are very frequent and will result
+* in an integer multiplication (since the port id is an index
+* into the dsw_evdev port array).
+*/
+   struct dsw_evdev *dsw;
+
+   uint16_t dequeue_depth;
+   uint16_t enqueue_depth;
+
+   int32_t new_event_threshold;
+
+   struct rte_event_ring *in_ring __rte_cache_aligned;
+} __rte_cache_aligned;
+
 struct dsw_queue {
uint8_t schedule_type;
uint16_t num_serving_ports;
@@ -31,6 +57,8 @@ struct dsw_queue {
 struct dsw_evdev {
struct rte_eventdev_data *data;
 
+   struct dsw_port ports[DSW_MAX_PORTS];
+   uint16_t num_ports;
struct dsw_queue queues[DSW_MAX_QUEUES];
uint8_t num_queues;
 };
-- 
2.17.1

[dpdk-dev] [PATCH v4 05/10] event/dsw: add DSW event scheduling and device start/stop

[Mattias Rönnblom]

With this patch, the DSW event device can be started and stopped,
and also supports scheduling events between ports.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/Makefile|   2 +-
 drivers/event/dsw/dsw_evdev.c | 125 
 drivers/event/dsw/dsw_evdev.h |  56 ++
 drivers/event/dsw/dsw_event.c | 359 ++
 drivers/event/dsw/meson.build |   2 +-
 5 files changed, 542 insertions(+), 2 deletions(-)
 create mode 100644 drivers/event/dsw/dsw_event.c

diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
index 5cbf488ff..6374a454e 100644
--- a/drivers/event/dsw/Makefile
+++ b/drivers/event/dsw/Makefile
@@ -21,6 +21,6 @@ LIBABIVER := 1
 
 EXPORT_MAP := rte_pmd_dsw_event_version.map
 
-SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += dsw_evdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += dsw_evdev.c dsw_event.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 5dccc232a..40a7435be 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -6,6 +6,7 @@
 
 #include 
 #include 
+#include 
 
 #include "dsw_evdev.h"
 
@@ -201,10 +202,125 @@ dsw_configure(const struct rte_eventdev *dev)
 {
struct dsw_evdev *dsw = dsw_pmd_priv(dev);
const struct rte_event_dev_config *conf = &dev->data->dev_conf;
+   int32_t min_max_in_flight;
 
dsw->num_ports = conf->nb_event_ports;
dsw->num_queues = conf->nb_event_queues;
 
+   /* Avoid a situation where consumer ports are holding all the
+* credits, without making use of them.
+*/
+   min_max_in_flight = conf->nb_event_ports * DSW_PORT_MAX_CREDITS;
+
+   dsw->max_inflight = RTE_MAX(conf->nb_events_limit, min_max_in_flight);
+
+   return 0;
+}
+
+
+static void
+initial_flow_to_port_assignment(struct dsw_evdev *dsw)
+{
+   uint8_t queue_id;
+   for (queue_id = 0; queue_id < dsw->num_queues; queue_id++) {
+   struct dsw_queue *queue = &dsw->queues[queue_id];
+   uint16_t flow_hash;
+   for (flow_hash = 0; flow_hash < DSW_MAX_FLOWS; flow_hash++) {
+   uint8_t port_idx =
+   rte_rand() % queue->num_serving_ports;
+   uint8_t port_id =
+   queue->serving_ports[port_idx];
+   dsw->queues[queue_id].flow_to_port_map[flow_hash] =
+   port_id;
+   }
+   }
+}
+
+static int
+dsw_start(struct rte_eventdev *dev)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+
+   rte_atomic32_init(&dsw->credits_on_loan);
+
+   initial_flow_to_port_assignment(dsw);
+
+   return 0;
+}
+
+static void
+dsw_port_drain_buf(uint8_t dev_id, struct rte_event *buf, uint16_t buf_len,
+  eventdev_stop_flush_t flush, void *flush_arg)
+{
+   uint16_t i;
+
+   for (i = 0; i < buf_len; i++)
+   flush(dev_id, buf[i], flush_arg);
+}
+
+static void
+dsw_port_drain_out(uint8_t dev_id, struct dsw_evdev *dsw, struct dsw_port 
*port,
+  eventdev_stop_flush_t flush, void *flush_arg)
+{
+   uint16_t dport_id;
+
+   for (dport_id = 0; dport_id < dsw->num_ports; dport_id++)
+   if (dport_id != port->id)
+   dsw_port_drain_buf(dev_id, port->out_buffer[dport_id],
+  port->out_buffer_len[dport_id],
+  flush, flush_arg);
+}
+
+static void
+dsw_port_drain_in_ring(uint8_t dev_id, struct dsw_port *port,
+  eventdev_stop_flush_t flush, void *flush_arg)
+{
+   struct rte_event ev;
+
+   while (rte_event_ring_dequeue_burst(port->in_ring, &ev, 1, NULL))
+   flush(dev_id, ev, flush_arg);
+}
+
+static void
+dsw_drain(uint8_t dev_id, struct dsw_evdev *dsw,
+ eventdev_stop_flush_t flush, void *flush_arg)
+{
+   uint16_t port_id;
+
+   if (flush == NULL)
+   return;
+
+   for (port_id = 0; port_id < dsw->num_ports; port_id++) {
+   struct dsw_port *port = &dsw->ports[port_id];
+
+   dsw_port_drain_out(dev_id, dsw, port, flush, flush_arg);
+   dsw_port_drain_in_ring(dev_id, port, flush, flush_arg);
+   }
+}
+
+static void
+dsw_stop(struct rte_eventdev *dev)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   uint8_t dev_id;
+   eventdev_stop_flush_t flush;
+   void *flush_arg;
+
+   dev_id = dev->data->dev_id;
+   flush = dev->dev_ops->dev_stop_flush;
+   flush_arg = dev->data->dev_stop_flush_arg;
+
+   dsw_drain(dev_id, dsw, flush, flush_arg);
+}
+
+static int
+dsw_close(struct rte_eventdev *dev)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+
+   dsw->num_ports = 0;
+   dsw->num_queues = 0;
+
return 0;
 }
 
@@ -219,6 +335,9 @@ static struct rte_eventdev_ops dsw_evdev_ops = {

[dpdk-dev] [PATCH v4 04/10] event/dsw: add support in DSW for linking/unlinking ports

[Mattias Rönnblom]

Added support for linking and unlinking ports to queues in a DSW event
device.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c | 67 +++
 drivers/event/dsw/dsw_evdev.h |  1 +
 2 files changed, 68 insertions(+)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 91b1a2449..5dccc232a 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2018 Ericsson AB
  */
 
+#include 
+
 #include 
 #include 
 
@@ -112,6 +114,69 @@ dsw_queue_release(struct rte_eventdev *dev __rte_unused,
 {
 }
 
+static void
+queue_add_port(struct dsw_queue *queue, uint16_t port_id)
+{
+   queue->serving_ports[queue->num_serving_ports] = port_id;
+   queue->num_serving_ports++;
+}
+
+static bool
+queue_remove_port(struct dsw_queue *queue, uint16_t port_id)
+{
+   uint16_t i;
+
+   for (i = 0; i < queue->num_serving_ports; i++)
+   if (queue->serving_ports[i] == port_id) {
+   uint16_t last_idx = queue->num_serving_ports - 1;
+   if (i != last_idx)
+   queue->serving_ports[i] =
+   queue->serving_ports[last_idx];
+   queue->num_serving_ports--;
+   return true;
+   }
+   return false;
+}
+
+static int
+dsw_port_link_unlink(struct rte_eventdev *dev, void *port,
+const uint8_t queues[], uint16_t num, bool link)
+{
+   struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   struct dsw_port *p = port;
+   uint16_t i;
+   uint16_t count = 0;
+
+   for (i = 0; i < num; i++) {
+   uint8_t qid = queues[i];
+   struct dsw_queue *q = &dsw->queues[qid];
+   if (link) {
+   queue_add_port(q, p->id);
+   count++;
+   } else {
+   bool removed = queue_remove_port(q, p->id);
+   if (removed)
+   count++;
+   }
+   }
+
+   return count;
+}
+
+static int
+dsw_port_link(struct rte_eventdev *dev, void *port, const uint8_t queues[],
+ const uint8_t priorities[] __rte_unused, uint16_t num)
+{
+   return dsw_port_link_unlink(dev, port, queues, num, true);
+}
+
+static int
+dsw_port_unlink(struct rte_eventdev *dev, void *port, uint8_t queues[],
+   uint16_t num)
+{
+   return dsw_port_link_unlink(dev, port, queues, num, false);
+}
+
 static void
 dsw_info_get(struct rte_eventdev *dev __rte_unused,
 struct rte_event_dev_info *info)
@@ -150,6 +215,8 @@ static struct rte_eventdev_ops dsw_evdev_ops = {
.queue_setup = dsw_queue_setup,
.queue_def_conf = dsw_queue_def_conf,
.queue_release = dsw_queue_release,
+   .port_link = dsw_port_link,
+   .port_unlink = dsw_port_unlink,
.dev_infos_get = dsw_info_get,
.dev_configure = dsw_configure,
 };
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index 2a4f10421..ad0f857cc 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -51,6 +51,7 @@ struct dsw_port {
 
 struct dsw_queue {
uint8_t schedule_type;
+   uint8_t serving_ports[DSW_MAX_PORTS];
uint16_t num_serving_ports;
 };
 
-- 
2.17.1

[dpdk-dev] [PATCH v4 07/10] event/dsw: add load balancing to the DSW event device

[Mattias Rönnblom]

The DSW event device will now attempt to migrate (move) flows between
ports in order to balance the load.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c |  27 ++
 drivers/event/dsw/dsw_evdev.h |  80 
 drivers/event/dsw/dsw_event.c | 735 +-
 3 files changed, 838 insertions(+), 4 deletions(-)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index bcfa17bab..2ecb365ba 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -20,6 +20,7 @@ dsw_port_setup(struct rte_eventdev *dev, uint8_t port_id,
struct dsw_evdev *dsw = dsw_pmd_priv(dev);
struct dsw_port *port;
struct rte_event_ring *in_ring;
+   struct rte_ring *ctl_in_ring;
char ring_name[RTE_RING_NAMESIZE];
 
port = &dsw->ports[port_id];
@@ -42,13 +43,29 @@ dsw_port_setup(struct rte_eventdev *dev, uint8_t port_id,
if (in_ring == NULL)
return -ENOMEM;
 
+   snprintf(ring_name, sizeof(ring_name), "dswctl%d_p%u",
+dev->data->dev_id, port_id);
+
+   ctl_in_ring = rte_ring_create(ring_name, DSW_CTL_IN_RING_SIZE,
+ dev->data->socket_id,
+ RING_F_SC_DEQ|RING_F_EXACT_SZ);
+
+   if (ctl_in_ring == NULL) {
+   rte_event_ring_free(in_ring);
+   return -ENOMEM;
+   }
+
port->in_ring = in_ring;
+   port->ctl_in_ring = ctl_in_ring;
 
rte_atomic16_init(&port->load);
 
port->load_update_interval =
(DSW_LOAD_UPDATE_INTERVAL * rte_get_timer_hz()) / US_PER_S;
 
+   port->migration_interval =
+   (DSW_MIGRATION_INTERVAL * rte_get_timer_hz()) / US_PER_S;
+
dev->data->ports[port_id] = port;
 
return 0;
@@ -72,6 +89,7 @@ dsw_port_release(void *p)
struct dsw_port *port = p;
 
rte_event_ring_free(port->in_ring);
+   rte_ring_free(port->ctl_in_ring);
 }
 
 static int
@@ -272,6 +290,14 @@ dsw_port_drain_buf(uint8_t dev_id, struct rte_event *buf, 
uint16_t buf_len,
flush(dev_id, buf[i], flush_arg);
 }
 
+static void
+dsw_port_drain_paused(uint8_t dev_id, struct dsw_port *port,
+ eventdev_stop_flush_t flush, void *flush_arg)
+{
+   dsw_port_drain_buf(dev_id, port->paused_events, port->paused_events_len,
+  flush, flush_arg);
+}
+
 static void
 dsw_port_drain_out(uint8_t dev_id, struct dsw_evdev *dsw, struct dsw_port 
*port,
   eventdev_stop_flush_t flush, void *flush_arg)
@@ -308,6 +334,7 @@ dsw_drain(uint8_t dev_id, struct dsw_evdev *dsw,
struct dsw_port *port = &dsw->ports[port_id];
 
dsw_port_drain_out(dev_id, dsw, port, flush, flush_arg);
+   dsw_port_drain_paused(dev_id, port, flush, flush_arg);
dsw_port_drain_in_ring(dev_id, port, flush, flush_arg);
}
 }
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index a5399dda5..783c418bf 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -73,7 +73,37 @@
 #define DSW_LOAD_UPDATE_INTERVAL (DSW_MIGRATION_INTERVAL/4)
 #define DSW_OLD_LOAD_WEIGHT (1)
 
+/* The minimum time (in us) between two flow migrations. What puts an
+ * upper limit on the actual migration rate is primarily the pace in
+ * which the ports send and receive control messages, which in turn is
+ * largely a function of how much cycles are spent the processing of
+ * an event burst.
+ */
 #define DSW_MIGRATION_INTERVAL (1000)
+#define DSW_MIN_SOURCE_LOAD_FOR_MIGRATION (DSW_LOAD_FROM_PERCENT(70))
+#define DSW_MAX_TARGET_LOAD_FOR_MIGRATION (DSW_LOAD_FROM_PERCENT(95))
+
+#define DSW_MAX_EVENTS_RECORDED (128)
+
+/* Only one outstanding migration per port is allowed */
+#define DSW_MAX_PAUSED_FLOWS (DSW_MAX_PORTS)
+
+/* Enough room for paus request/confirm and unpaus request/confirm for
+ * all possible senders.
+ */
+#define DSW_CTL_IN_RING_SIZE ((DSW_MAX_PORTS-1)*4)
+
+struct dsw_queue_flow {
+   uint8_t queue_id;
+   uint16_t flow_hash;
+};
+
+enum dsw_migration_state {
+   DSW_MIGRATION_STATE_IDLE,
+   DSW_MIGRATION_STATE_PAUSING,
+   DSW_MIGRATION_STATE_FORWARDING,
+   DSW_MIGRATION_STATE_UNPAUSING
+};
 
 struct dsw_port {
uint16_t id;
@@ -98,6 +128,7 @@ struct dsw_port {
 
uint16_t ops_since_bg_task;
 
+   /* most recent 'background' processing */
uint64_t last_bg;
 
/* For port load measurement. */
@@ -108,11 +139,46 @@ struct dsw_port {
uint64_t busy_cycles;
uint64_t total_busy_cycles;
 
+   /* For the ctl interface and flow migration mechanism. */
+   uint64_t next_migration;
+   uint64_t migration_interval;
+   enum dsw_migration_state migration_state;
+
+   uint64_t migration_start;
+   uint64_t migrations;
+   uint64_t migration_latency;
+
+   uint8_t migration_target_

[dpdk-dev] [PATCH v4 01/10] event/dsw: add DSW device registration and build system

[Mattias Rönnblom]

This patch contains the Meson and GNU Make build system extensions
required for the Distributed Event Device, and also the initialization
code for the driver itself.

Signed-off-by: Mattias Rönnblom 
---
 config/common_base|  5 ++
 drivers/event/Makefile|  1 +
 drivers/event/dsw/Makefile| 26 ++
 drivers/event/dsw/dsw_evdev.c | 52 +++
 drivers/event/dsw/dsw_evdev.h | 16 ++
 drivers/event/dsw/meson.build |  6 +++
 .../event/dsw/rte_pmd_dsw_event_version.map   |  3 ++
 drivers/event/meson.build |  2 +-
 mk/rte.app.mk |  1 +
 9 files changed, 111 insertions(+), 1 deletion(-)
 create mode 100644 drivers/event/dsw/Makefile
 create mode 100644 drivers/event/dsw/dsw_evdev.c
 create mode 100644 drivers/event/dsw/dsw_evdev.h
 create mode 100644 drivers/event/dsw/meson.build
 create mode 100644 drivers/event/dsw/rte_pmd_dsw_event_version.map

diff --git a/config/common_base b/config/common_base
index 4bcbaf923..c43f5139d 100644
--- a/config/common_base
+++ b/config/common_base
@@ -614,6 +614,11 @@ CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG=n
 #
 CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV=y
 
+#
+# Compile PMD for distributed software event device
+#
+CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV=y
+
 #
 # Compile PMD for octeontx sso event device
 #
diff --git a/drivers/event/Makefile b/drivers/event/Makefile
index f301d8dc2..03ad1b6cb 100644
--- a/drivers/event/Makefile
+++ b/drivers/event/Makefile
@@ -6,6 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += skeleton
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += sw
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += dsw
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += octeontx
 ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y)
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV) += dpaa
diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
new file mode 100644
index 0..5cbf488ff
--- /dev/null
+++ b/drivers/event/dsw/Makefile
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Ericsson AB
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+LIB = librte_pmd_dsw_event.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -Wno-format-nonliteral
+
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_mbuf
+LDLIBS += -lrte_mempool
+LDLIBS += -lrte_ring
+LDLIBS += -lrte_eventdev
+LDLIBS += -lrte_bus_vdev
+
+LIBABIVER := 1
+
+EXPORT_MAP := rte_pmd_dsw_event_version.map
+
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += dsw_evdev.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
new file mode 100644
index 0..6990bbc9e
--- /dev/null
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -0,0 +1,52 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Ericsson AB
+ */
+
+#include 
+#include 
+
+#include "dsw_evdev.h"
+
+#define EVENTDEV_NAME_DSW_PMD event_dsw
+
+static int
+dsw_probe(struct rte_vdev_device *vdev)
+{
+   const char *name;
+   struct rte_eventdev *dev;
+   struct dsw_evdev *dsw;
+
+   name = rte_vdev_device_name(vdev);
+
+   dev = rte_event_pmd_vdev_init(name, sizeof(struct dsw_evdev),
+ rte_socket_id());
+   if (dev == NULL)
+   return -EFAULT;
+
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+   return 0;
+
+   dsw = dev->data->dev_private;
+   dsw->data = dev->data;
+
+   return 0;
+}
+
+static int
+dsw_remove(struct rte_vdev_device *vdev)
+{
+   const char *name;
+
+   name = rte_vdev_device_name(vdev);
+   if (name == NULL)
+   return -EINVAL;
+
+   return rte_event_pmd_vdev_uninit(name);
+}
+
+static struct rte_vdev_driver evdev_dsw_pmd_drv = {
+   .probe = dsw_probe,
+   .remove = dsw_remove
+};
+
+RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_DSW_PMD, evdev_dsw_pmd_drv);
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
new file mode 100644
index 0..9a0f4c357
--- /dev/null
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Ericsson AB
+ */
+
+#ifndef _DSW_EVDEV_H_
+#define _DSW_EVDEV_H_
+
+#include 
+
+#define DSW_PMD_NAME RTE_STR(event_dsw)
+
+struct dsw_evdev {
+   struct rte_eventdev_data *data;
+};
+
+#endif
diff --git a/drivers/event/dsw/meson.build b/drivers/event/dsw/meson.build
new file mode 100644
index 0..275d051c3
--- /dev/null
+++ b/drivers/event/dsw/meson.build
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Ericsson AB
+
+allow_experimental_apis = true
+deps += ['bus_vdev']
+sources = files('dsw_evdev.c')
diff --git a/drivers/event/dsw/rte_pmd_dsw_event_version.map 
b/drivers/event/dsw/rte_pmd_dsw_event_version.map
new file mode 100644
index 0

[dpdk-dev] [PATCH v4 08/10] event/dsw: let DSW event device sort events on dequeue

[Mattias Rönnblom]

With this patch, the DSW event device will (optionally) sort the event
burst before giving it to the application. The sorting will primarily
be on queue id, and secondary on flow id.

The sorting is an attempt to optimize data and instruction cache usage
for the application, at the cost of additional event device overhead.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.h | 11 
 drivers/event/dsw/dsw_event.c | 23 +
 drivers/event/dsw/dsw_sort.h  | 48 +++
 3 files changed, 82 insertions(+)
 create mode 100644 drivers/event/dsw/dsw_sort.h

diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index 783c418bf..f6f8f0454 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -93,6 +93,17 @@
  */
 #define DSW_CTL_IN_RING_SIZE ((DSW_MAX_PORTS-1)*4)
 
+/* With DSW_SORT_DEQUEUED enabled, the scheduler will, at the point of
+ * dequeue(), arrange events so that events with the same flow id on
+ * the same queue forms a back-to-back "burst", and also so that such
+ * bursts of different flow ids, but on the same queue, also come
+ * consecutively. All this in an attempt to improve data and
+ * instruction cache usage for the application, at the cost of a
+ * scheduler overhead increase.
+ */
+
+/* #define DSW_SORT_DEQUEUED */
+
 struct dsw_queue_flow {
uint8_t queue_id;
uint16_t flow_hash;
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index f0347592d..a84b19c33 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -4,6 +4,10 @@
 
 #include "dsw_evdev.h"
 
+#ifdef DSW_SORT_DEQUEUED
+#include "dsw_sort.h"
+#endif
+
 #include 
 #include 
 
@@ -1121,6 +1125,21 @@ dsw_port_record_seen_events(struct dsw_port *port, 
struct rte_event *events,
DSW_MAX_EVENTS_RECORDED);
 }
 
+#ifdef DSW_SORT_DEQUEUED
+
+#define DSW_EVENT_TO_INT(_event)   \
+   ((int)_event)->queue_id)<<16)|((_event)->flow_id)))
+
+static inline int
+dsw_cmp_event(const void *v_event_a, const void *v_event_b)
+{
+   const struct rte_event *event_a = v_event_a;
+   const struct rte_event *event_b = v_event_b;
+
+   return DSW_EVENT_TO_INT(event_a) - DSW_EVENT_TO_INT(event_b);
+}
+#endif
+
 static uint16_t
 dsw_port_dequeue_burst(struct dsw_port *port, struct rte_event *events,
   uint16_t num)
@@ -1191,5 +1210,9 @@ dsw_event_dequeue_burst(void *port, struct rte_event 
*events, uint16_t num,
 *  0.
 */
 
+#ifdef DSW_SORT_DEQUEUED
+   dsw_stable_sort(events, dequeued, sizeof(events[0]), dsw_cmp_event);
+#endif
+
return dequeued;
 }
diff --git a/drivers/event/dsw/dsw_sort.h b/drivers/event/dsw/dsw_sort.h
new file mode 100644
index 0..609767fdf
--- /dev/null
+++ b/drivers/event/dsw/dsw_sort.h
@@ -0,0 +1,48 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Ericsson AB
+ */
+
+#ifndef _DSW_SORT_
+#define _DSW_SORT_
+
+#include 
+
+#include 
+
+#define DSW_ARY_ELEM_PTR(_ary, _idx, _elem_size)   \
+   RTE_PTR_ADD(_ary, (_idx) * (_elem_size))
+
+#define DSW_ARY_ELEM_SWAP(_ary, _a_idx, _b_idx, _elem_size)\
+   do {\
+   char tmp[_elem_size];   \
+   void *_a_ptr = DSW_ARY_ELEM_PTR(_ary, _a_idx, _elem_size); \
+   void *_b_ptr = DSW_ARY_ELEM_PTR(_ary, _b_idx, _elem_size); \
+   memcpy(tmp, _a_ptr, _elem_size);\
+   memcpy(_a_ptr, _b_ptr, _elem_size); \
+   memcpy(_b_ptr, tmp, _elem_size);\
+   } while (0)
+
+static inline void
+dsw_insertion_sort(void *ary, uint16_t len, uint16_t elem_size,
+  int (*cmp_fn)(const void *, const void *))
+{
+   uint16_t i;
+
+   for (i = 1; i < len; i++) {
+   uint16_t j;
+   for (j = i; j > 0 &&
+cmp_fn(DSW_ARY_ELEM_PTR(ary, j-1, elem_size),
+   DSW_ARY_ELEM_PTR(ary, j, elem_size)) > 0;
+j--)
+   DSW_ARY_ELEM_SWAP(ary, j, j-1, elem_size);
+   }
+}
+
+static inline void
+dsw_stable_sort(void *ary, uint16_t len, uint16_t elem_size,
+   int (*cmp_fn)(const void *, const void *))
+{
+   dsw_insertion_sort(ary, len, elem_size, cmp_fn);
+}
+
+#endif
-- 
2.17.1

[dpdk-dev] [PATCH v4 06/10] event/dsw: add DSW port load measurements

[Mattias Rönnblom]

The DSW event device port now attempts to estimate its load (i.e. how
busy it is). This is required for load balancing to work (although
load balancing is not included in this patch), and may also be useful
for debugging purposes.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c |  14 +
 drivers/event/dsw/dsw_evdev.h |  40 +
 drivers/event/dsw/dsw_event.c | 109 ++
 3 files changed, 163 insertions(+)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 40a7435be..bcfa17bab 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -4,6 +4,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -43,6 +44,11 @@ dsw_port_setup(struct rte_eventdev *dev, uint8_t port_id,
 
port->in_ring = in_ring;
 
+   rte_atomic16_init(&port->load);
+
+   port->load_update_interval =
+   (DSW_LOAD_UPDATE_INTERVAL * rte_get_timer_hz()) / US_PER_S;
+
dev->data->ports[port_id] = port;
 
return 0;
@@ -240,11 +246,19 @@ static int
 dsw_start(struct rte_eventdev *dev)
 {
struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   uint16_t i;
+   uint64_t now;
 
rte_atomic32_init(&dsw->credits_on_loan);
 
initial_flow_to_port_assignment(dsw);
 
+   now = rte_get_timer_cycles();
+   for (i = 0; i < dsw->num_ports; i++) {
+   dsw->ports[i].measurement_start = now;
+   dsw->ports[i].busy_start = now;
+   }
+
return 0;
 }
 
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index f8e94e4a4..a5399dda5 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -36,6 +36,15 @@
  */
 #define DSW_PARALLEL_FLOWS (1024)
 
+/* 'Background tasks' are polling the control rings for *
+ *  migration-related messages, or flush the output buffer (so
+ *  buffered events doesn't linger too long). Shouldn't be too low,
+ *  since the system won't benefit from the 'batching' effects from
+ *  the output buffer, and shouldn't be too high, since it will make
+ *  buffered events linger too long in case the port goes idle.
+ */
+#define DSW_MAX_PORT_OPS_PER_BG_TASK (128)
+
 /* Avoid making small 'loans' from the central in-flight event credit
  * pool, to improve efficiency.
  */
@@ -50,6 +59,22 @@
  */
 #define DSW_IN_RING_SIZE (DSW_MAX_EVENTS)
 
+#define DSW_MAX_LOAD (INT16_MAX)
+#define DSW_LOAD_FROM_PERCENT(x) ((int16_t)(((x)*DSW_MAX_LOAD)/100))
+#define DSW_LOAD_TO_PERCENT(x) ((100*x)/DSW_MAX_LOAD)
+
+/* The thought behind keeping the load update interval shorter than
+ * the migration interval is that the load from newly migrated flows
+ * should 'show up' on the load measurement before new migrations are
+ * considered. This is to avoid having too many flows, from too many
+ * source ports, to be migrated too quickly to a lightly loaded port -
+ * in particular since this might cause the system to oscillate.
+ */
+#define DSW_LOAD_UPDATE_INTERVAL (DSW_MIGRATION_INTERVAL/4)
+#define DSW_OLD_LOAD_WEIGHT (1)
+
+#define DSW_MIGRATION_INTERVAL (1000)
+
 struct dsw_port {
uint16_t id;
 
@@ -71,10 +96,25 @@ struct dsw_port {
 
uint16_t next_parallel_flow_id;
 
+   uint16_t ops_since_bg_task;
+
+   uint64_t last_bg;
+
+   /* For port load measurement. */
+   uint64_t next_load_update;
+   uint64_t load_update_interval;
+   uint64_t measurement_start;
+   uint64_t busy_start;
+   uint64_t busy_cycles;
+   uint64_t total_busy_cycles;
+
uint16_t out_buffer_len[DSW_MAX_PORTS];
struct rte_event out_buffer[DSW_MAX_PORTS][DSW_MAX_PORT_OUT_BUFFER];
 
struct rte_event_ring *in_ring __rte_cache_aligned;
+
+   /* Estimate of current port load. */
+   rte_atomic16_t load __rte_cache_aligned;
 } __rte_cache_aligned;
 
 struct dsw_queue {
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index 4a3af8ecd..f326147c9 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -7,6 +7,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 static bool
@@ -75,6 +76,70 @@ dsw_port_return_credits(struct dsw_evdev *dsw, struct 
dsw_port *port,
}
 }
 
+static void
+dsw_port_load_record(struct dsw_port *port, unsigned int dequeued)
+{
+   if (dequeued > 0 && port->busy_start == 0)
+   /* work period begins */
+   port->busy_start = rte_get_timer_cycles();
+   else if (dequeued == 0 && port->busy_start > 0) {
+   /* work period ends */
+   uint64_t work_period =
+   rte_get_timer_cycles() - port->busy_start;
+   port->busy_cycles += work_period;
+   port->busy_start = 0;
+   }
+}
+
+static int16_t
+dsw_port_load_close_period(struct dsw_port *port, uint64_t now)
+{
+   uint64_t passed = now - port->measurement_start;
+   uint64_t busy_cycles = port->busy_cycle

[dpdk-dev] [PATCH v4 09/10] event/dsw: implement eventdev 'xstats' counters in DSW

[Mattias Rönnblom]

The DSW event device now implements the 'xstats' interface and a
number of port- and device-level counters.

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/Makefile |   3 +-
 drivers/event/dsw/dsw_evdev.c  |   5 +-
 drivers/event/dsw/dsw_evdev.h  |  19 +++
 drivers/event/dsw/dsw_event.c  |  35 
 drivers/event/dsw/dsw_xstats.c | 288 +
 drivers/event/dsw/meson.build  |   2 +-
 6 files changed, 349 insertions(+), 3 deletions(-)
 create mode 100644 drivers/event/dsw/dsw_xstats.c

diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
index 6374a454e..ea1e5259a 100644
--- a/drivers/event/dsw/Makefile
+++ b/drivers/event/dsw/Makefile
@@ -21,6 +21,7 @@ LIBABIVER := 1
 
 EXPORT_MAP := rte_pmd_dsw_event_version.map
 
-SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += dsw_evdev.c dsw_event.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DSW_EVENTDEV) += \
+   dsw_evdev.c dsw_event.c dsw_xstats.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 2ecb365ba..33ba13647 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -378,7 +378,10 @@ static struct rte_eventdev_ops dsw_evdev_ops = {
.dev_configure = dsw_configure,
.dev_start = dsw_start,
.dev_stop = dsw_stop,
-   .dev_close = dsw_close
+   .dev_close = dsw_close,
+   .xstats_get = dsw_xstats_get,
+   .xstats_get_names = dsw_xstats_get_names,
+   .xstats_get_by_name = dsw_xstats_get_by_name
 };
 
 static int
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index f6f8f0454..dc28ab125 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -176,6 +176,14 @@ struct dsw_port {
uint16_t seen_events_idx;
struct dsw_queue_flow seen_events[DSW_MAX_EVENTS_RECORDED];
 
+   uint64_t new_enqueued;
+   uint64_t forward_enqueued;
+   uint64_t release_enqueued;
+   uint64_t queue_enqueued[DSW_MAX_QUEUES];
+
+   uint64_t dequeued;
+   uint64_t queue_dequeued[DSW_MAX_QUEUES];
+
uint16_t out_buffer_len[DSW_MAX_PORTS];
struct rte_event out_buffer[DSW_MAX_PORTS][DSW_MAX_PORT_OUT_BUFFER];
 
@@ -243,6 +251,17 @@ uint16_t dsw_event_dequeue(void *port, struct rte_event 
*ev, uint64_t wait);
 uint16_t dsw_event_dequeue_burst(void *port, struct rte_event *events,
 uint16_t num, uint64_t wait);
 
+int dsw_xstats_get_names(const struct rte_eventdev *dev,
+enum rte_event_dev_xstats_mode mode,
+uint8_t queue_port_id,
+struct rte_event_dev_xstats_name *xstats_names,
+unsigned int *ids, unsigned int size);
+int dsw_xstats_get(const struct rte_eventdev *dev,
+  enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id,
+  const unsigned int ids[], uint64_t values[], unsigned int n);
+uint64_t dsw_xstats_get_by_name(const struct rte_eventdev *dev,
+   const char *name, unsigned int *id);
+
 static inline struct dsw_evdev *
 dsw_pmd_priv(const struct rte_eventdev *eventdev)
 {
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index a84b19c33..61a66fabf 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -82,6 +82,33 @@ dsw_port_return_credits(struct dsw_evdev *dsw, struct 
dsw_port *port,
}
 }
 
+static void
+dsw_port_enqueue_stats(struct dsw_port *port, uint16_t num_new,
+  uint16_t num_forward, uint16_t num_release)
+{
+   port->new_enqueued += num_new;
+   port->forward_enqueued += num_forward;
+   port->release_enqueued += num_release;
+}
+
+static void
+dsw_port_queue_enqueue_stats(struct dsw_port *source_port, uint8_t queue_id)
+{
+   source_port->queue_enqueued[queue_id]++;
+}
+
+static void
+dsw_port_dequeue_stats(struct dsw_port *port, uint16_t num)
+{
+   port->dequeued += num;
+}
+
+static void
+dsw_port_queue_dequeued_stats(struct dsw_port *source_port, uint8_t queue_id)
+{
+   source_port->queue_dequeued[queue_id]++;
+}
+
 static void
 dsw_port_load_record(struct dsw_port *port, unsigned int dequeued)
 {
@@ -1059,12 +1086,16 @@ dsw_event_enqueue_burst_generic(void *port, const 
struct rte_event events[],
 
source_port->pending_releases -= num_release;
 
+   dsw_port_enqueue_stats(source_port, num_new,
+  num_non_release-num_new, num_release);
+
for (i = 0; i < events_len; i++) {
const struct rte_event *event = &events[i];
 
if (likely(num_release == 0 ||
   event->op != RTE_EVENT_OP_RELEASE))
dsw_port_buffer_event(dsw, source_port, event);
+   dsw_port_queue_enqueue_stats(source_port, event->queue_id);
}
 
DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-re

[dpdk-dev] [PATCH v4 10/10] event/dsw: include DSW event device documentation

[Mattias Rönnblom]

The DSW event device is documented in DPDK Programmer's Guide.

The MAINTAINERS file and the 18.11 release notes are updated.

Signed-off-by: Mattias Rönnblom 
---
 MAINTAINERS|  5 ++
 doc/guides/eventdevs/dsw.rst   | 96 ++
 doc/guides/eventdevs/index.rst |  1 +
 doc/guides/rel_notes/release_18_11.rst |  8 +++
 4 files changed, 110 insertions(+)
 create mode 100644 doc/guides/eventdevs/dsw.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index 9fd258fad..cbfa7e106 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -919,6 +919,11 @@ F: doc/guides/eventdevs/sw.rst
 F: examples/eventdev_pipeline/
 F: doc/guides/sample_app_ug/eventdev_pipeline.rst
 
+Distributed Software Eventdev PMD
+M: Mattias Rönnblom 
+F: drivers/event/dsw/
+F: doc/guides/eventdevs/dsw.rst
+
 Software OPDL Eventdev PMD
 M: Liang Ma 
 M: Peter Mccarthy 
diff --git a/doc/guides/eventdevs/dsw.rst b/doc/guides/eventdevs/dsw.rst
new file mode 100644
index 0..6653f501c
--- /dev/null
+++ b/doc/guides/eventdevs/dsw.rst
@@ -0,0 +1,96 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Ericsson AB
+
+Distributed Software Eventdev Poll Mode Driver
+==
+
+The distributed software event device is an eventdev driver which
+distributes the task of scheduling events among all the eventdev ports
+and the lcore threads using them.
+
+Features
+
+
+Queues
+ * Atomic
+ * Parallel
+ * Single-Link
+
+Ports
+ * Load balanced (for Atomic, Ordered, Parallel queues)
+ * Single Link (for single-link queues)
+
+Configuration and Options
+-
+
+The distributed software eventdev is a vdev device, and as such can be
+created from the application code, or from the EAL command line:
+
+* Call ``rte_vdev_init("event_dsw0")`` from the application
+
+* Use ``--vdev="event_dsw0"`` in the EAL options, which will call
+  rte_vdev_init() internally
+
+Example:
+
+.. code-block:: console
+
+./your_eventdev_application --vdev="event_dsw0"
+
+Limitations
+---
+
+Unattended Ports
+
+
+The distributed software eventdev uses an internal signaling schema
+between the ports to achieve load balancing. In order for this to
+work, the application must perform enqueue and/or dequeue operations
+on all ports.
+
+Producer-only ports which currently have no events to enqueue should
+periodically call rte_event_enqueue_burst() with a zero-sized burst.
+
+Ports left unattended for longer periods of time will prevent load
+balancing, and also cause traffic interruptions on the flows which
+are in the process of being migrated.
+
+Output Buffering
+
+
+For efficiency reasons, the distributed software eventdev might not
+send enqueued events immediately to the destination port, but instead
+store them in an internal buffer in the source port.
+
+In case no more events are enqueued on a port with buffered events,
+these events will be sent after the application has performed a number
+of enqueue and/or dequeue operations.
+
+For explicit flushing, an application may call
+rte_event_enqueue_burst() with a zero-sized burst.
+
+
+Priorities
+~~
+
+The distributed software eventdev does not support event priorities.
+
+Ordered Queues
+~~
+
+The distributed software eventdev does not support the ordered queue type.
+
+
+"All Types" Queues
+~~
+
+The distributed software eventdev does not support queues of type
+RTE_EVENT_QUEUE_CFG_ALL_TYPES, which allow both atomic, ordered, and
+parallel events on the same queue.
+
+Dynamic Link/Unlink
+~~~
+
+The distributed software eventdev does not support calls to
+rte_event_port_link() or rte_event_port_unlink() after
+rte_event_dev_start() has been called.
diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.rst
index 18ec8e462..984eea5f4 100644
--- a/doc/guides/eventdevs/index.rst
+++ b/doc/guides/eventdevs/index.rst
@@ -14,5 +14,6 @@ application trough the eventdev API.
 dpaa
 dpaa2
 sw
+dsw
 octeontx
 opdl
diff --git a/doc/guides/rel_notes/release_18_11.rst 
b/doc/guides/rel_notes/release_18_11.rst
index 3ae6b3f58..9c6b1fd0b 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -54,6 +54,14 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
+* **Added Distributed Software Eventdev PMD.**
+
+  Added the new Distributed Software Event Device (DSW), which is a
+  pure-software eventdev driver distributing the work of scheduling
+  among all eventdev ports and the lcores using them. DSW, compared to
+  the SW eventdev PMD, sacrifices load balancing performance to
+  gain better event scheduling throughput and scalability.
+
 
 API Changes
 ---
-- 
2.17.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix non-matching parameters documentation

[Ferruh Yigit]

On 9/17/2018 10:07 PM, Yongseok Koh wrote:
> 
>> On Sep 17, 2018, at 9:03 AM, Asaf Penso  wrote:
>>
>> tso and vlan parameters were removed from the signature
>> of txq_mbuf_to_swp function.
>>
>> The documentation of the function was not updated accordingly.
>>
>> Remove the tso and vlan documentation to match the function signature.
>>
>> Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
>> Cc: ys...@mellanox.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Asaf Penso 
>> ---
> Acked-by: Yongseok Koh 
> 
> Thanks and welcome to the DPDK world!
> Yongseok

Hi Asaf, Yongseok,

Is this patch hit the mail list? I don't see it both in mail list and patchwork.
Perhaps Asaf needs to register to mail list?

btw, welcome Asaf :)

Re: [dpdk-dev] [PATCH v7] net/i40e: add interface to use latest vec path

[Ferruh Yigit]

On 9/18/2018 3:22 AM, Xiaoyun Li wrote:
> For IA, the AVX2 vector path is only recommended to be used on later
> platforms (identified by AVX512 support, like SKL etc.) This is because
> performance benchmark shows downgrade when running AVX2 vector path on
> early platform (BDW/HSW) in some cases. But we still observe perf gain
> with some real work loading.
> 
> So this patch introduced the new devarg use-latest-supported-vec to
> force the driver always selecting the latest supported vec path. Then
> apps are able to take AVX2 path on early platforms. And this logic can
> be re-used if we will have AVX512 vec path in future.
> 
> This patch only affects IA platforms. The selected vec path would be
> like the following:
>   Without devarg/devarg = 0:
>   Machine vPMD
>   AVX512F AVX2
>   AVX2SSE4.2
>   SSE4.2  SSE4.2
>
>   With devarg = 1
>   Machine vPMD
>   AVX512F AVX2
>   AVX2AVX2
>   SSE4.2  SSE4.2
>
> Other platforms can also apply the same logic if necessary in future.
> 
> Signed-off-by: Xiaoyun Li 
> ---
> v7:
>  * Use uint_8 instead of bool type for struct member.
> v6:
>  * Polish the doc and commit log.
>  * Use rte_kvargs_process instead of directly kvlist internals.
> v5:
>  * Simpify the rx set function.
> v4:
>  * Polish the codes.
> v3:
>  * Polish the doc and commit log.
> v2:
>  * Correct the calling of the wrong function last time.
>  * Fix seg fault bug.
> ---
>  doc/guides/nics/i40e.rst   |   8 ++

Doc is causing warning:
doc/guides/nics/i40e.rst:172: WARNING: Unexpected indentation.

Except from that,
Reviewed-by: Ferruh Yigit 

[dpdk-dev] [PATCH v3 1/2] doc: create a platorm specific page for NXP DPAA platform

[Hemant Agrawal]

Signed-off-by: Hemant Agrawal 
---
v3: merge the patches

 doc/guides/cryptodevs/dpaa_sec.rst |  25 +-
 doc/guides/eventdevs/dpaa.rst  |  48 ++
 doc/guides/nics/dpaa.rst   |  59 +-
 doc/guides/platform/dpaa.rst   | 100 +
 doc/guides/platform/index.rst  |   1 +
 5 files changed, 108 insertions(+), 125 deletions(-)
 create mode 100644 doc/guides/platform/dpaa.rst

diff --git a/doc/guides/cryptodevs/dpaa_sec.rst 
b/doc/guides/cryptodevs/dpaa_sec.rst
index dd68389..897a4fe 100644
--- a/doc/guides/cryptodevs/dpaa_sec.rst
+++ b/doc/guides/cryptodevs/dpaa_sec.rst
@@ -101,32 +101,11 @@ Prerequisites
 -
 
 DPAA_SEC driver has similar pre-requisites as described in 
:ref:`dpaa_overview`.
-The following dependencies are not part of DPDK and must be installed 
separately:
 
-* **NXP Linux SDK**
+See :doc:`../platform/dpaa` for setup information
 
-  NXP Linux software development kit (SDK) includes support for the family
-  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
-  and corresponding boards.
 
-  It includes the Linux board support packages (BSPs) for NXP SoCs,
-  a fully operational tool chain, kernel and board specific modules.
-
-  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
-
-* **DPDK Extras Scripts**
-
-  DPAA based resources can be configured easily with the help of ready scripts
-  as provided in the DPDK Extras repository.
-
-  `DPDK Extras Scripts `_.
-
-Currently supported by DPDK:
-
-* NXP SDK **2.0+**.
-* Supported architectures:  **arm64 LE**.
-
-* Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
 
 Pre-Installation Configuration
 --
diff --git a/doc/guides/eventdevs/dpaa.rst b/doc/guides/eventdevs/dpaa.rst
index 7383295..3af2343 100644
--- a/doc/guides/eventdevs/dpaa.rst
+++ b/doc/guides/eventdevs/dpaa.rst
@@ -25,57 +25,17 @@ The DPAA EVENTDEV implements many features in the eventdev 
API;
 Supported DPAA SoCs
 
 
-- LS1046A
-- LS1043A
+- LS1046A/LS1026A
+- LS1043A/LS1023A
 
 Prerequisites
 -
 
-There are following pre-requisites for executing EVENTDEV on a DPAA compatible
-platform:
-
-1. **ARM 64 Tool Chain**
-
-  For example, the `*aarch64* Linaro Toolchain 
`_.
-
-2. **Linux Kernel**
-
-   It can be obtained from `NXP's Github hosting 
`_.
-
-3. **Rootfile System**
-
-   Any *aarch64* supporting filesystem can be used. For example,
-   Ubuntu 15.10 (Wily) or 16.04 LTS (Xenial) userland which can be obtained
-   from `here 
`_.
-
-As an alternative method, DPAA EVENTDEV can also be executed using images 
provided
-as part of SDK from NXP. The SDK includes all the above prerequisites necessary
-to bring up a DPAA board.
-
-The following dependencies are not part of DPDK and must be installed
-separately:
-
-- **NXP Linux SDK**
-
-  NXP Linux software development kit (SDK) includes support for family
-  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
-  and corresponding boards.
-
-  It includes the Linux board support packages (BSPs) for NXP SoCs,
-  a fully operational tool chain, kernel and board specific modules.
-
-  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
-
-- **DPDK Extra Scripts**
-
-  DPAA based resources can be configured easily with the help of ready to use
-  xml files as provided in the DPDK Extra repository.
-
-  `DPDK Extras Scripts `_.
+See :doc:`../platform/dpaa` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **2.0+** or LSDK **17.09+**
+- NXP SDK **2.0+** or LSDK **18.09+**
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rst
index 620c045..2173673 100644
--- a/doc/guides/nics/dpaa.rst
+++ b/doc/guides/nics/dpaa.rst
@@ -181,65 +181,8 @@ Supported DPAA SoCs
 Prerequisites
 -
 
-There are three main pre-requisities for executing DPAA PMD on a DPAA
-compatible board:
+See :doc:`../platform/dpaa` for setup information
 
-1. **ARM 64 Tool Chain**
-
-   For example, the `*aarch64* Linaro Toolchain 

[dpdk-dev] [PATCH v3 2/2] doc: create a platorm specific page for NXP DPAA2 platform

[Hemant Agrawal]

Signed-off-by: Hemant Agrawal 
---
v3: merge the patches

 doc/guides/cryptodevs/dpaa2_sec.rst | 28 +++
 doc/guides/eventdevs/dpaa2.rst  | 50 ++-
 doc/guides/nics/dpaa2.rst   | 49 ++-
 doc/guides/platform/dpaa2.rst   | 98 +
 doc/guides/platform/index.rst   |  1 +
 5 files changed, 114 insertions(+), 112 deletions(-)
 create mode 100644 doc/guides/platform/dpaa2.rst

diff --git a/doc/guides/cryptodevs/dpaa2_sec.rst 
b/doc/guides/cryptodevs/dpaa2_sec.rst
index 9191704..aee79ab 100644
--- a/doc/guides/cryptodevs/dpaa2_sec.rst
+++ b/doc/guides/cryptodevs/dpaa2_sec.rst
@@ -129,7 +129,7 @@ AEAD algorithms:
 Supported DPAA2 SoCs
 
 
-* LS2080A/LS2040A
+* LS2160A
 * LS2084A/LS2044A
 * LS2088A/LS2048A
 * LS1088A/LS1048A
@@ -157,31 +157,15 @@ Prerequisites
 DPAA2_SEC driver has similar pre-requisites as described in 
:ref:`dpaa2_overview`.
 The following dependencies are not part of DPDK and must be installed 
separately:
 
-* **NXP Linux SDK**
-
-  NXP Linux software development kit (SDK) includes support for the family
-  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
-  and corresponding boards.
-
-  It includes the Linux board support packages (BSPs) for NXP SoCs,
-  a fully operational tool chain, kernel and board specific modules.
-
-  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
-
-* **DPDK Extra Scripts**
-
-  DPAA2 based resources can be configured easily with the help of ready scripts
-  as provided in the DPDK helper repository.
-
-  `DPDK Extra Scripts `_.
+See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-* NXP SDK **17.08+**.
-* MC Firmware version **10.3.1** and higher.
-* Supported architectures:  **arm64 LE**.
+- NXP SDK **18.09+**.
+- MC Firmware version **10.10.0** and higher.
+- Supported architectures:  **arm64 LE**.
 
-* Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
 
 Pre-Installation Configuration
 --
diff --git a/doc/guides/eventdevs/dpaa2.rst b/doc/guides/eventdevs/dpaa2.rst
index ad94f24..2b1700a 100644
--- a/doc/guides/eventdevs/dpaa2.rst
+++ b/doc/guides/eventdevs/dpaa2.rst
@@ -26,7 +26,7 @@ The DPAA2 EVENTDEV implements many features in the eventdev 
API;
 Supported DPAA2 SoCs
 
 
-- LS2080A/LS2040A
+- LX2160A
 - LS2084A/LS2044A
 - LS2088A/LS2048A
 - LS1088A/LS1048A
@@ -34,52 +34,12 @@ Supported DPAA2 SoCs
 Prerequisites
 -
 
-There are three main pre-requisities for executing DPAA2 EVENTDEV on a DPAA2
-compatible board:
-
-1. **ARM 64 Tool Chain**
-
-   For example, the `*aarch64* Linaro Toolchain 
`_.
-
-2. **Linux Kernel**
-
-   It can be obtained from `NXP's Github hosting 
`_.
-
-3. **Rootfile system**
-
-   Any *aarch64* supporting filesystem can be used. For example,
-   Ubuntu 15.10 (Wily) or 16.04 LTS (Xenial) userland which can be obtained
-   from `here 
`_.
-
-As an alternative method, DPAA2 EVENTDEV can also be executed using images 
provided
-as part of SDK from NXP. The SDK includes all the above prerequisites necessary
-to bring up a DPAA2 board.
-
-The following dependencies are not part of DPDK and must be installed
-separately:
-
-- **NXP Linux SDK**
-
-  NXP Linux software development kit (SDK) includes support for family
-  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
-  and corresponding boards.
-
-  It includes the Linux board support packages (BSPs) for NXP SoCs,
-  a fully operational tool chain, kernel and board specific modules.
-
-  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
-
-- **DPDK Extra Scripts**
-
-  DPAA2 based resources can be configured easily with the help of ready scripts
-  as provided in the DPDK Extra repository.
-
-  `DPDK Extras Scripts `_.
+See :doc:`../platform/dpaa2` for setup information
 
 Currently supported by DPDK:
 
-- NXP SDK **2.0+**.
-- MC Firmware version **10.0.0** and higher.
+- NXP SDK **18.09+**.
+- MC Firmware version **10.10.0** and higher.
 - Supported architectures:  **arm64 LE**.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
@@ -155,4 +115,4 @@ DPAA2 drivers for DPDK can o

Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log

[Ferruh Yigit]

On 9/18/2018 6:44 AM, Beilei Xing wrote:
> Remove driver log when no interrupt event indicated
> in alarm handler for both PF and VF, otherwise there
> will be lots of prints which makes console unusable.
> 
> Signed-off-by: Beilei Xing 

Reviewed-by: Ferruh Yigit 

Re: [dpdk-dev] [PATCH v2] devtools/test-meson-build: use shared libraries to save space

[Thomas Monjalon]

14/09/2018 18:21, Luca Boccassi:
> On Fri, 2018-09-14 at 17:17 +0100, Bruce Richardson wrote:
> > For usability, the default build type in meson is static, so that
> > binaries can be run from the build directory easily. However, static
> > builds take more space, so for build-testing purposes default to
> > using
> > shared builds where possible.
> > 
> > Signed-off-by: Bruce Richardson 
> > ---
> > With this patch applied on Debian 9 (Stretch) the space used by a
> > DPDK
> > checkout and test builds drops from ~2.5G to <1G. [Including space
> > used
> > by cross compiles]
> > 
> > V2: fix typo in commit message
> > ---
> >  devtools/test-meson-builds.sh | 9 +
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> Acked-by: Luca Boccassi 

Applied (without 32-bit part), thanks

Re: [dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

[Luca Boccassi]

Hi,

The application must already stop and close before detaching (which
will call uninit). Quoting from the documentation:

"*  Before detaching, they must be stopped and closed.

    DPDK applications must call "rte_eth_dev_stop()" and
    "rte_eth_dev_close()" APIs before detaching ports. These functions will
    start finalization sequence of the PMDs."

http://doc.dpdk.org/guides/prog_guide/port_hotplug_framework.html

On Mon, 2018-09-17 at 19:06 +, Louis Luo wrote:
> Hi Luca,
> 
> When eth_vmxnet3_dev_uninit() is called, is it guaranteed that
> vmxnet3_dev_close/ vmxnet3_dev_stop must have been called? I'm not
> familiar with the hot-plug procedure, so just wonder if there is any
> chance that eth_vmxnet3_dev_uninit() is called without calling
> vmxnet3_dev_close/ vmxnet3_dev_stop.
> 
> Thanks,
> Louis
> 
> On 8/16/18, 6:51 AM, "dev on behalf of Luca Boccassi"  pdk.org on behalf of bl...@debian.org> wrote:
> 
> The vmxnet3 driver can't call back into dev_close(), and possibly
> dev_stop(), in dev_uninit().  When dev_uninit() is called,
> anything
> that those routines would want to clean up has already been
> released.
> Further, for complete cleanup, it is necessary to release any of
> the
> queue resources during dev_close().
> This allows a vmxnet3 device to be hot-unplugged without leaking
> queues.
> 
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode
> driver implementation")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Brian Russell 
> Signed-off-by: Luca Boccassi 
> ---
>  drivers/net/vmxnet3/vmxnet3_ethdev.c | 36 
> 
>  1 file changed, 26 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 2613cd1358..b5d4be5e24 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -348,16 +348,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev
> *eth_dev)
>  static int
>  eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)
>  {
> - struct vmxnet3_hw *hw = eth_dev->data->dev_private;
> -
>   PMD_INIT_FUNC_TRACE();
>  
>   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>   return 0;
>  
> - if (hw->adapter_stopped == 0)
> - vmxnet3_dev_close(eth_dev);
> -
>   eth_dev->dev_ops = NULL;
>   eth_dev->rx_pkt_burst = NULL;
>   eth_dev->tx_pkt_burst = NULL;
> @@ -803,7 +798,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
>   PMD_INIT_FUNC_TRACE();
>  
>   if (hw->adapter_stopped == 1) {
> - PMD_INIT_LOG(DEBUG, "Device already closed.");
> + PMD_INIT_LOG(DEBUG, "Device already stopped.");
>   return;
>   }
>  
> @@ -827,7 +822,6 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
>   /* reset the device */
>   VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,
> VMXNET3_CMD_RESET_DEV);
>   PMD_INIT_LOG(DEBUG, "Device reset.");
> - hw->adapter_stopped = 0;
>  
>   vmxnet3_dev_clear_queues(dev);
>  
> @@ -837,6 +831,30 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
>   link.link_speed = ETH_SPEED_NUM_10G;
>   link.link_autoneg = ETH_LINK_FIXED;
>   rte_eth_linkstatus_set(dev, &link);
> +
> + hw->adapter_stopped = 1;
> +}
> +
> +static void
> +vmxnet3_free_queues(struct rte_eth_dev *dev)
> +{
> + int i;
> +
> + PMD_INIT_FUNC_TRACE();
> +
> + for (i = 0; i < dev->data->nb_rx_queues; i++) {
> + void *rxq = dev->data->rx_queues[i];
> +
> + vmxnet3_dev_rx_queue_release(rxq);
> + }
> + dev->data->nb_rx_queues = 0;
> +
> + for (i = 0; i < dev->data->nb_tx_queues; i++) {
> + void *txq = dev->data->tx_queues[i];
> +
> + vmxnet3_dev_tx_queue_release(txq);
> + }
> + dev->data->nb_tx_queues = 0;
>  }
>  
>  /*
> @@ -845,12 +863,10 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
>  static void
>  vmxnet3_dev_close(struct rte_eth_dev *dev)
>  {
> - struct vmxnet3_hw *hw = dev->data->dev_private;
> -
>   PMD_INIT_FUNC_TRACE();
>  
>   vmxnet3_dev_stop(dev);
> - hw->adapter_stopped = 1;
> + vmxnet3_free_queues(dev);
>  }
>  
>  static void
> -- 
> 2.18.0
> 
> 
> 

-- 
Kind regards,
Luca Boccassi

[dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

[Bruce Richardson]

Compiling with all warnings turned on causes errors about unused variables
and an unused label. Remove these to allow building without having to
disable those warnings.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting")
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")

CC: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
Acked-by: Luca Boccassi 
---
 drivers/net/avf/avf_ethdev.c | 15 +--
 drivers/net/avf/avf_rxtx.c   | 17 +
 drivers/net/avf/avf_vchnl.c  |  2 --
 3 files changed, 6 insertions(+), 28 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a7d69828c..6b6ff7d55 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -154,7 +154,6 @@ static int
 avf_init_rss(struct avf_adapter *adapter)
 {
struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(adapter);
-   struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);
struct rte_eth_rss_conf *rss_conf;
uint8_t i, j, nb_q;
int ret;
@@ -259,11 +258,8 @@ avf_init_rxq(struct rte_eth_dev *dev, struct avf_rx_queue 
*rxq)
 static int
 avf_init_queues(struct rte_eth_dev *dev)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_rx_queue **rxq =
(struct avf_rx_queue **)dev->data->rx_queues;
-   struct avf_tx_queue **txq =
-   (struct avf_tx_queue **)dev->data->tx_queues;
int i, ret = AVF_SUCCESS;
 
for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -415,7 +411,6 @@ avf_dev_start(struct rte_eth_dev *dev)
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
 
PMD_INIT_FUNC_TRACE();
@@ -476,9 +471,7 @@ avf_dev_stop(struct rte_eth_dev *dev)
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
-   int ret, i;
 
PMD_INIT_FUNC_TRACE();
 
@@ -503,8 +496,6 @@ avf_dev_stop(struct rte_eth_dev *dev)
 static void
 avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
memset(dev_info, 0, sizeof(*dev_info));
@@ -914,7 +905,6 @@ avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 static int
 avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
uint32_t frame_size = mtu + AVF_ETH_OVERHEAD;
int ret = 0;
 
@@ -1044,8 +1034,6 @@ avf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, 
uint16_t queue_id)
 static int
 avf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint16_t msix_intr;
@@ -1088,7 +1076,7 @@ avf_check_vf_reset_done(struct avf_hw *hw)
 static int
 avf_init_vf(struct rte_eth_dev *dev)
 {
-   int i, err, bufsz;
+   int err, bufsz;
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1197,7 +1185,6 @@ avf_dev_interrupt_handler(void *param)
 
avf_handle_virtchnl_msg(dev);
 
-done:
avf_enable_irq0(hw);
 }
 
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index e03a136fc..edff48d27 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -247,7 +247,6 @@ alloc_rxq_mbufs(struct avf_rx_queue *rxq)
 static inline void
 release_rxq_mbufs(struct avf_rx_queue *rxq)
 {
-   struct rte_mbuf *mbuf;
uint16_t i;
 
if (!rxq->sw_ring)
@@ -310,9 +309,8 @@ avf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
struct avf_rx_queue *rxq;
const struct rte_memzone *mz;
uint32_t ring_size;
-   uint16_t len, i;
+   uint16_t len;
uint16_t rx_free_thresh;
-   uint16_t base, bsf, tc_mapping;
 
PMD_INIT_FUNC_TRACE();
 
@@ -428,13 +426,10 @@ avf_dev_tx_

[dpdk-dev] [PATCH v2 2/2] net/avf: fix missing compiler error flags

[Bruce Richardson]

The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means
that a number of compilation errors were getting missed. This patch adds
in the flag and fixes most of the errors, just disabling the
strict-aliasing ones.

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")

CC: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/avf/Makefile   | 2 +-
 drivers/net/avf/avf_ethdev.c   | 2 +-
 drivers/net/avf/avf_rxtx.h | 2 +-
 drivers/net/avf/avf_rxtx_vec_sse.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
index 3f815bbc4..0a142c104 100644
--- a/drivers/net/avf/Makefile
+++ b/drivers/net/avf/Makefile
@@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 #
 LIB = librte_pmd_avf.a
 
-CFLAGS += -O3
+CFLAGS += -O3 $(WERROR_FLAGS) -Wno-strict-aliasing
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
 LDLIBS += -lrte_bus_pci
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 6b6ff7d55..549498477 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -559,7 +559,7 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
 }
 
 static const uint32_t *
-avf_dev_supported_ptypes_get(struct rte_eth_dev *dev)
+avf_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)
 {
static const uint32_t ptypes[] = {
RTE_PTYPE_L2_ETHER,
diff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h
index 297d0776d..c4120f8a4 100644
--- a/drivers/net/avf/avf_rxtx.h
+++ b/drivers/net/avf/avf_rxtx.h
@@ -227,7 +227,7 @@ static inline
 void avf_dump_tx_descriptor(const struct avf_tx_queue *txq,
const void *desc, uint16_t tx_id)
 {
-   char *name;
+   const char *name;
const struct avf_tx_desc *tx_desc = desc;
enum avf_tx_desc_dtype_value type;
 
diff --git a/drivers/net/avf/avf_rxtx_vec_sse.c 
b/drivers/net/avf/avf_rxtx_vec_sse.c
index 8275100f3..343a6aac3 100644
--- a/drivers/net/avf/avf_rxtx_vec_sse.c
+++ b/drivers/net/avf/avf_rxtx_vec_sse.c
@@ -621,7 +621,7 @@ avf_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf 
**tx_pkts,
return nb_pkts;
 }
 
-void __attribute__((cold))
+static void __attribute__((cold))
 avf_rx_queue_release_mbufs_sse(struct avf_rx_queue *rxq)
 {
_avf_rx_queue_release_mbufs_vec(rxq);
-- 
2.17.1

Re: [dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards

[Thomas Monjalon]

18/09/2018 14:44, Timothy Redaelli:
> On Tue, 18 Sep 2018 11:55:52 +0100
> Bruce Richardson  wrote:
> 
> > Versions of meson prior to 0.47 flattened the parameters to the
> > "set_variable" function, which meant that the function could not take
> > array variables as a parameter. Therefore, we need to disable driver
> > tracking for those older versions, in order to maintain compatibility
> > with the minimum supported 0.41 version, and also v0.45 shipped in
> > Ubuntu 18.04 release.
> > 
> > Fixes: 806c45dd483d ("build: add configuration summary at end of
> > config")
> > 
> > Signed-off-by: Bruce Richardson 
> 
> Tried to build using meson 0.42.1 and it builds correctly
> 
> Tested-by: Timothy Redaelli 

Applied, thanks

[dpdk-dev] [PATCH v2 01/13] net/dpaa: configure frame queue on MAC ID basis

[Hemant Agrawal]

The current code has the hardcoded seq for fq allocation.
It require multiple changes, when some of the interfaces
are assigned to kernel stack. Changing it on the mac
id basis provide the flexibility to assign any interface
to kernel.

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_ethdev.c | 25 ++---
 drivers/net/dpaa/dpaa_ethdev.h |  2 +-
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 30eff65..b9bd557 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -1011,7 +1011,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct 
qman_cgr *cgr_rx,
 {
struct qm_mcc_initfq opts = {0};
int ret;
-   u32 flags = 0;
+   u32 flags = QMAN_FQ_FLAG_NO_ENQUEUE;
struct qm_mcc_initcgr cgr_opts = {
.we_mask = QM_CGR_WE_CS_THRES |
QM_CGR_WE_CSTD_EN |
@@ -1024,15 +1024,18 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, 
struct qman_cgr *cgr_rx,
 
PMD_INIT_FUNC_TRACE();
 
-   ret = qman_reserve_fqid(fqid);
-   if (ret) {
-   DPAA_PMD_ERR("reserve rx fqid 0x%x failed with ret: %d",
-fqid, ret);
-   return -EINVAL;
+   if (fqid) {
+   ret = qman_reserve_fqid(fqid);
+   if (ret) {
+   DPAA_PMD_ERR("reserve rx fqid 0x%x failed with ret: %d",
+fqid, ret);
+   return -EINVAL;
+   }
+   } else {
+   flags |= QMAN_FQ_FLAG_DYNAMIC_FQID;
}
-
DPAA_PMD_DEBUG("creating rx fq %p, fqid 0x%x", fq, fqid);
-   ret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq);
+   ret = qman_create_fq(fqid, flags, fq);
if (ret) {
DPAA_PMD_ERR("create rx fqid 0x%x failed with ret: %d",
fqid, ret);
@@ -1051,7 +1054,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct 
qman_cgr *cgr_rx,
if (ret) {
DPAA_PMD_WARN(
"rx taildrop init fail on rx fqid 0x%x(ret=%d)",
-   fqid, ret);
+   fq->fqid, ret);
goto without_cgr;
}
opts.we_mask |= QM_INITFQ_WE_CGID;
@@ -1059,7 +1062,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct 
qman_cgr *cgr_rx,
opts.fqd.fq_ctrl |= QM_FQCTRL_CGE;
}
 without_cgr:
-   ret = qman_init_fq(fq, flags, &opts);
+   ret = qman_init_fq(fq, 0, &opts);
if (ret)
DPAA_PMD_ERR("init rx fqid 0x%x failed with ret:%d", fqid, ret);
return ret;
@@ -1212,7 +1215,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)
if (default_q)
fqid = cfg->rx_def;
else
-   fqid = DPAA_PCD_FQID_START + dpaa_intf->ifid *
+   fqid = DPAA_PCD_FQID_START + dpaa_intf->fif->mac_idx *
DPAA_PCD_FQID_MULTIPLIER + loop;
 
if (dpaa_intf->cgr_rx)
diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h
index c79b9f8..2c38c34 100644
--- a/drivers/net/dpaa/dpaa_ethdev.h
+++ b/drivers/net/dpaa/dpaa_ethdev.h
@@ -63,7 +63,7 @@
 #define DPAA_PCD_FQID_START0x400
 #define DPAA_PCD_FQID_MULTIPLIER   0x100
 #define DPAA_DEFAULT_NUM_PCD_QUEUES1
-#define DPAA_MAX_NUM_PCD_QUEUES32
+#define DPAA_MAX_NUM_PCD_QUEUES4
 
 #define DPAA_IF_TX_PRIORITY3
 #define DPAA_IF_RX_PRIORITY0
-- 
2.7.4

[dpdk-dev] [PATCH v2 00/13] NXP DPAA driver enhancements

[Hemant Agrawal]

Misc fixes for dpaa driver

V2: remove the unused function from map file
Add description/details in git commit logs.


Hemant Agrawal (9):
  net/dpaa: configure frame queue on MAC ID basis
  net/dpaa: fix jumbo buffer config
  net/dpaa: implement scatter offload support
  net/dpaa: minor debug log enhancements
  bus/dpaa: add interrupt based portal fd support
  net/dpaa: separate Rx function for LS1046
  net/dpaa: tune prefetch in Rx path
  bus/dpaa: add check for re-definition in compat
  mempool/dpaa: change the debug log level to DP

Nipun Gupta (2):
  bus/dpaa: avoid tag Set for eqcr in Tx path
  bus/dpaa: avoid using be conversions for contextb

Sachin Saxena (1):
  net/dpaa: fix link speed based on MAC type

Sunil Kumar Kori (1):
  net/dpaa: rearranging of atomic queue support code

 drivers/bus/dpaa/base/qbman/bman_driver.c |  17 ++--
 drivers/bus/dpaa/base/qbman/qman.c|  72 +
 drivers/bus/dpaa/base/qbman/qman_driver.c |   7 +-
 drivers/bus/dpaa/include/compat.h |  20 +++--
 drivers/bus/dpaa/include/fsl_qman.h   |  20 +
 drivers/bus/dpaa/include/fsl_usd.h|   6 ++
 drivers/bus/dpaa/rte_bus_dpaa_version.map |  16 +++-
 drivers/mempool/dpaa/dpaa_mempool.c   |   2 +-
 drivers/net/dpaa/dpaa_ethdev.c| 126 --
 drivers/net/dpaa/dpaa_ethdev.h|   5 +-
 drivers/net/dpaa/dpaa_rxtx.c  | 100 
 drivers/net/dpaa/dpaa_rxtx.h  |   5 +-
 12 files changed, 305 insertions(+), 91 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH v2 03/13] net/dpaa: implement scatter offload support

[Hemant Agrawal]

This patch implement the sg support, which can be
enabled/disabled w.r.t configuration.

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_ethdev.c | 62 +++---
 drivers/net/dpaa/dpaa_ethdev.h |  3 +-
 drivers/net/dpaa/dpaa_rxtx.c   |  8 +++---
 drivers/net/dpaa/dpaa_rxtx.h   |  2 --
 4 files changed, 64 insertions(+), 11 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index db166f5..9ea8510 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -47,15 +47,15 @@
 
 /* Supported Rx offloads */
 static uint64_t dev_rx_offloads_sup =
-   DEV_RX_OFFLOAD_JUMBO_FRAME;
+   DEV_RX_OFFLOAD_JUMBO_FRAME |
+   DEV_RX_OFFLOAD_SCATTER;
 
 /* Rx offloads which cannot be disabled */
 static uint64_t dev_rx_offloads_nodis =
DEV_RX_OFFLOAD_IPV4_CKSUM |
DEV_RX_OFFLOAD_UDP_CKSUM |
DEV_RX_OFFLOAD_TCP_CKSUM |
-   DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
-   DEV_RX_OFFLOAD_SCATTER;
+   DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
 
 /* Supported Tx offloads */
 static uint64_t dev_tx_offloads_sup;
@@ -147,11 +147,30 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
struct dpaa_if *dpaa_intf = dev->data->dev_private;
uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN
+ VLAN_TAG_SIZE;
+   uint32_t buffsz = dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;
 
PMD_INIT_FUNC_TRACE();
 
if (mtu < ETHER_MIN_MTU || frame_size > DPAA_MAX_RX_PKT_LEN)
return -EINVAL;
+   /*
+* Refuse mtu that requires the support of scattered packets
+* when this feature has not been enabled before.
+*/
+   if (dev->data->min_rx_buf_size &&
+   !dev->data->scattered_rx && frame_size > buffsz) {
+   DPAA_PMD_ERR("SG not enabled, will not fit in one buffer");
+   return -EINVAL;
+   }
+
+   /* check  *   >= max_frame */
+   if (dev->data->min_rx_buf_size && dev->data->scattered_rx &&
+   (frame_size > buffsz * DPAA_SGT_MAX_ENTRIES)) {
+   DPAA_PMD_ERR("Too big to fit for Max SG list %d",
+   buffsz * DPAA_SGT_MAX_ENTRIES);
+   return -EINVAL;
+   }
+
if (frame_size > ETHER_MAX_LEN)
dev->data->dev_conf.rxmode.offloads &=
DEV_RX_OFFLOAD_JUMBO_FRAME;
@@ -208,6 +227,13 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
DPAA_MAX_RX_PKT_LEN);
}
}
+
+   if (rx_offloads & DEV_RX_OFFLOAD_SCATTER) {
+   DPAA_PMD_DEBUG("enabling scatter mode");
+   fman_if_set_sg(dpaa_intf->fif, 1);
+   dev->data->scattered_rx = 1;
+   }
+
return 0;
 }
 
@@ -305,7 +331,6 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev,
 
dev_info->max_rx_queues = dpaa_intf->nb_rx_queues;
dev_info->max_tx_queues = dpaa_intf->nb_tx_queues;
-   dev_info->min_rx_bufsize = DPAA_MIN_RX_BUF_SIZE;
dev_info->max_rx_pktlen = DPAA_MAX_RX_PKT_LEN;
dev_info->max_mac_addrs = DPAA_MAX_MAC_FILTER;
dev_info->max_hash_mac_addrs = 0;
@@ -519,6 +544,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
struct qm_mcc_initfq opts = {0};
u32 flags = 0;
int ret;
+   u32 buffsz = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;
 
PMD_INIT_FUNC_TRACE();
 
@@ -532,6 +558,28 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
DPAA_PMD_INFO("Rx queue setup for queue index: %d fq_id (0x%x)",
queue_idx, rxq->fqid);
 
+   /* Max packet can fit in single buffer */
+   if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) {
+   ;
+   } else if (dev->data->dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_SCATTER) {
+   if (dev->data->dev_conf.rxmode.max_rx_pkt_len >
+   buffsz * DPAA_SGT_MAX_ENTRIES) {
+   DPAA_PMD_ERR("max RxPkt size %d too big to fit "
+   "MaxSGlist %d",
+   dev->data->dev_conf.rxmode.max_rx_pkt_len,
+   buffsz * DPAA_SGT_MAX_ENTRIES);
+   rte_errno = EOVERFLOW;
+   return -rte_errno;
+   }
+   } else {
+   DPAA_PMD_WARN("The requested maximum Rx packet size (%u) is"
+" larger than a single mbuf (%u) and scattered"
+" mode has not been requested",
+dev->data->dev_conf.rxmode.max_rx_pkt_len,
+buffsz - RTE_PKTMBUF_HEADROOM);
+   }
+
if (!dpaa_intf->bp_info || dpaa_intf->bp_info->mp !=

[dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

[Hemant Agrawal]

Avoid return after the jumbo buffer config in dev config API

Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU")
Cc: sta...@dpdk.org

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_ethdev.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index b9bd557..db166f5 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -195,11 +195,17 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
if (dev->data->dev_conf.rxmode.max_rx_pkt_len <=
DPAA_MAX_RX_PKT_LEN) {
+   DPAA_PMD_DEBUG("enabling jumbo");
fman_if_set_maxfrm(dpaa_intf->fif,
dev->data->dev_conf.rxmode.max_rx_pkt_len);
-   return 0;
+   dev->data->mtu =
+   dev->data->dev_conf.rxmode.max_rx_pkt_len -
+   ETHER_HDR_LEN - ETHER_CRC_LEN - VLAN_TAG_SIZE;
} else {
-   return -1;
+   DPAA_PMD_ERR("enabling jumbo err conf max len=%d "
+   "supported is %d",
+   dev->data->dev_conf.rxmode.max_rx_pkt_len,
+   DPAA_MAX_RX_PKT_LEN);
}
}
return 0;
-- 
2.7.4

[dpdk-dev] [PATCH v2 05/13] net/dpaa: minor debug log enhancements

[Hemant Agrawal]

Improving the debug message for event mode and
reducing the log level for less important log

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_ethdev.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index fa63afc..c2d6f44 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -613,9 +613,9 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
fman_if_set_bp(dpaa_intf->fif, mp->size,
   dpaa_intf->bp_info->bpid, bp_size);
dpaa_intf->valid = 1;
-   DPAA_PMD_INFO("if =%s - fd_offset = %d offset = %d",
-   dpaa_intf->name, fd_offset,
-   fman_if_get_fdoff(dpaa_intf->fif));
+   DPAA_PMD_DEBUG("if:%s fd_offset = %d offset = %d",
+   dpaa_intf->name, fd_offset,
+   fman_if_get_fdoff(dpaa_intf->fif));
}
DPAA_PMD_DEBUG("if:%s sg_on = %d, max_frm =%d", dpaa_intf->name,
fman_if_get_sg_enable(dpaa_intf->fif),
@@ -693,7 +693,8 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
struct qm_mcc_initfq opts = {0};
 
if (dpaa_push_mode_max_queue)
-   DPAA_PMD_WARN("PUSH mode already enabled for first %d queues.\n"
+   DPAA_PMD_WARN("PUSH mode q and EVENTDEV are not compatible\n"
+ "PUSH mode already enabled for first %d queues.\n"
  "To disable set DPAA_PUSH_QUEUES_NUMBER to 0\n",
  dpaa_push_mode_max_queue);
 
-- 
2.7.4

[dpdk-dev] [PATCH v2 06/13] bus/dpaa: add interrupt based portal fd support

[Hemant Agrawal]

This patch add supports in bus driver for qbman to support
and configure portal based FDs, which can be used for interrupt
based processing.

Signed-off-by: Hemant Agrawal 
---
 drivers/bus/dpaa/base/qbman/bman_driver.c | 17 ++
 drivers/bus/dpaa/base/qbman/qman.c| 52 +++
 drivers/bus/dpaa/base/qbman/qman_driver.c |  7 -
 drivers/bus/dpaa/include/fsl_qman.h   | 20 
 drivers/bus/dpaa/include/fsl_usd.h|  6 
 drivers/bus/dpaa/rte_bus_dpaa_version.map | 16 +-
 6 files changed, 110 insertions(+), 8 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/bman_driver.c 
b/drivers/bus/dpaa/base/qbman/bman_driver.c
index b14b590..750b756 100644
--- a/drivers/bus/dpaa/base/qbman/bman_driver.c
+++ b/drivers/bus/dpaa/base/qbman/bman_driver.c
@@ -23,7 +23,7 @@ static void *bman_ccsr_map;
 /* Portal driver */
 /*/
 
-static __thread int fd = -1;
+static __thread int bmfd = -1;
 static __thread struct bm_portal_config pcfg;
 static __thread struct dpaa_ioctl_portal_map map = {
.type = dpaa_portal_bman
@@ -70,14 +70,14 @@ static int fsl_bman_portal_init(uint32_t idx, int is_shared)
pcfg.index = map.index;
bman_depletion_fill(&pcfg.mask);
 
-   fd = open(BMAN_PORTAL_IRQ_PATH, O_RDONLY);
-   if (fd == -1) {
+   bmfd = open(BMAN_PORTAL_IRQ_PATH, O_RDONLY);
+   if (bmfd == -1) {
pr_err("BMan irq init failed");
process_portal_unmap(&map.addr);
return -EBUSY;
}
/* Use the IRQ FD as a unique IRQ number */
-   pcfg.irq = fd;
+   pcfg.irq = bmfd;
 
portal = bman_create_affine_portal(&pcfg);
if (!portal) {
@@ -90,7 +90,7 @@ static int fsl_bman_portal_init(uint32_t idx, int is_shared)
/* Set the IRQ number */
irq_map.type = dpaa_portal_bman;
irq_map.portal_cinh = map.addr.cinh;
-   process_portal_irq_map(fd, &irq_map);
+   process_portal_irq_map(bmfd, &irq_map);
return 0;
 }
 
@@ -99,7 +99,7 @@ static int fsl_bman_portal_finish(void)
__maybe_unused const struct bm_portal_config *cfg;
int ret;
 
-   process_portal_irq_unmap(fd);
+   process_portal_irq_unmap(bmfd);
 
cfg = bman_destroy_affine_portal();
DPAA_BUG_ON(cfg != &pcfg);
@@ -109,6 +109,11 @@ static int fsl_bman_portal_finish(void)
return ret;
 }
 
+int bman_thread_fd(void)
+{
+   return bmfd;
+}
+
 int bman_thread_init(void)
 {
/* Convert from contiguous/virtual cpu numbering to real cpu when
diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
b/drivers/bus/dpaa/base/qbman/qman.c
index 7c17027..8730550 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -1040,6 +1040,50 @@ static inline unsigned int __poll_portal_fast(struct 
qman_portal *p,
return limit;
 }
 
+int qman_irqsource_add(u32 bits)
+{
+   struct qman_portal *p = get_affine_portal();
+
+   bits = bits & QM_PIRQ_VISIBLE;
+
+   /* Clear any previously remaining interrupt conditions in
+* QCSP_ISR. This prevents raising a false interrupt when
+* interrupt conditions are enabled in QCSP_IER.
+*/
+   qm_isr_status_clear(&p->p, bits);
+   dpaa_set_bits(bits, &p->irq_sources);
+   qm_isr_enable_write(&p->p, p->irq_sources);
+
+
+   return 0;
+}
+
+int qman_irqsource_remove(u32 bits)
+{
+   struct qman_portal *p = get_affine_portal();
+   u32 ier;
+
+   /* Our interrupt handler only processes+clears status register bits that
+* are in p->irq_sources. As we're trimming that mask, if one of them
+* were to assert in the status register just before we remove it from
+* the enable register, there would be an interrupt-storm when we
+* release the IRQ lock. So we wait for the enable register update to
+* take effect in h/w (by reading it back) and then clear all other bits
+* in the status register. Ie. we clear them from ISR once it's certain
+* IER won't allow them to reassert.
+*/
+
+   bits &= QM_PIRQ_VISIBLE;
+   dpaa_clear_bits(bits, &p->irq_sources);
+   qm_isr_enable_write(&p->p, p->irq_sources);
+   ier = qm_isr_enable_read(&p->p);
+   /* Using "~ier" (rather than "bits" or "~p->irq_sources") creates a
+* data-dependency, ie. to protect against re-ordering.
+*/
+   qm_isr_status_clear(&p->p, ~ier);
+   return 0;
+}
+
 u16 qman_affine_channel(int cpu)
 {
if (cpu < 0) {
@@ -1114,6 +1158,14 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit,
return rx_number;
 }
 
+void qman_clear_irq(void)
+{
+   struct qman_portal *p = get_affine_portal();
+   u32 clear = QM_DQAVAIL_MASK | (p->irq_sources &
+   ~(QM_PIRQ_CSCI | QM_PIRQ_CCSCI));
+   qm_isr_status_clear(&p->p, clear);
+}
+
 u32 qman_portal_dequeue(struct rte_event ev[], unsigned int poll_limi

[dpdk-dev] [PATCH v2 04/13] net/dpaa: fix link speed based on MAC type

[Hemant Agrawal]

From: Sachin Saxena 

The link speed shall be on the basis of mac type.

Fixes: 799db4568c76 ("net/dpaa: support device info and speed capability")
Cc: shreyansh.j...@nxp.com
Cc: sta...@dpdk.org

Signed-off-by: Sachin Saxena 
---
 drivers/net/dpaa/dpaa_ethdev.c | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 9ea8510..fa63afc 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -337,8 +337,15 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev,
dev_info->max_vfs = 0;
dev_info->max_vmdq_pools = ETH_16_POOLS;
dev_info->flow_type_rss_offloads = DPAA_RSS_OFFLOAD_ALL;
-   dev_info->speed_capa = (ETH_LINK_SPEED_1G |
-   ETH_LINK_SPEED_10G);
+
+   if (dpaa_intf->fif->mac_type == fman_mac_1g)
+   dev_info->speed_capa = ETH_LINK_SPEED_1G;
+   else if (dpaa_intf->fif->mac_type == fman_mac_10g)
+   dev_info->speed_capa = (ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G);
+   else
+   DPAA_PMD_ERR("invalid link_speed: %s, %d",
+dpaa_intf->name, dpaa_intf->fif->mac_type);
+
dev_info->rx_offload_capa = dev_rx_offloads_sup |
dev_rx_offloads_nodis;
dev_info->tx_offload_capa = dev_tx_offloads_sup |
-- 
2.7.4

[dpdk-dev] [PATCH v2 08/13] bus/dpaa: avoid using be conversions for contextb

[Hemant Agrawal]

From: Nipun Gupta 

minor optimization in packet handling path

Signed-off-by: Nipun Gupta 
---
 drivers/bus/dpaa/base/qbman/qman.c | 15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
b/drivers/bus/dpaa/base/qbman/qman.c
index 71da275..dc64d08 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -852,11 +852,9 @@ static u32 __poll_portal_slow(struct qman_portal *p, u32 
is)
case QM_MR_VERB_FQPN:
/* Parked */
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
-   fq = get_fq_table_entry(
-   be32_to_cpu(msg->fq.contextB));
+   fq = get_fq_table_entry(msg->fq.contextB);
 #else
-   fq = (void *)(uintptr_t)
-   be32_to_cpu(msg->fq.contextB);
+   fq = (void *)(uintptr_t)msg->fq.contextB;
 #endif
fq_state_change(p, fq, msg, verb);
if (fq->cb.fqs)
@@ -967,7 +965,6 @@ static inline unsigned int __poll_portal_fast(struct 
qman_portal *p,
*shadow = *dq;
dq = shadow;
shadow->fqid = be32_to_cpu(shadow->fqid);
-   shadow->contextB = be32_to_cpu(shadow->contextB);
shadow->seqnum = be16_to_cpu(shadow->seqnum);
hw_fd_to_cpu(&shadow->fd);
 #endif
@@ -1136,9 +1133,9 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit,
 
/* SDQCR: context_b points to the FQ */
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
-   fq = qman_fq_lookup_table[be32_to_cpu(dq[rx_number]->contextB)];
+   fq = qman_fq_lookup_table[dq[rx_number]->contextB];
 #else
-   fq = (void *)be32_to_cpu(dq[rx_number]->contextB);
+   fq = (void *)dq[rx_number]->contextB;
 #endif
if (fq->cb.dqrr_prepare)
fq->cb.dqrr_prepare(shadow[rx_number],
@@ -1195,7 +1192,6 @@ u32 qman_portal_dequeue(struct rte_event ev[], unsigned 
int poll_limit,
*shadow = *dq;
dq = shadow;
shadow->fqid = be32_to_cpu(shadow->fqid);
-   shadow->contextB = be32_to_cpu(shadow->contextB);
shadow->seqnum = be16_to_cpu(shadow->seqnum);
hw_fd_to_cpu(&shadow->fd);
 #endif
@@ -1260,7 +1256,6 @@ struct qm_dqrr_entry *qman_dequeue(struct qman_fq *fq)
*shadow = *dq;
dq = shadow;
shadow->fqid = be32_to_cpu(shadow->fqid);
-   shadow->contextB = be32_to_cpu(shadow->contextB);
shadow->seqnum = be16_to_cpu(shadow->seqnum);
hw_fd_to_cpu(&shadow->fd);
 #endif
@@ -1556,7 +1551,7 @@ int qman_init_fq(struct qman_fq *fq, u32 flags, struct 
qm_mcc_initfq *opts)
 
mcc->initfq.we_mask |= QM_INITFQ_WE_CONTEXTB;
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
-   mcc->initfq.fqd.context_b = fq->key;
+   mcc->initfq.fqd.context_b = cpu_to_be32(fq->key);
 #else
mcc->initfq.fqd.context_b = (u32)(uintptr_t)fq;
 #endif
-- 
2.7.4

[dpdk-dev] [PATCH v2 07/13] bus/dpaa: avoid tag Set for eqcr in Tx path

[Hemant Agrawal]

From: Nipun Gupta 

Minor optimization for TX path.

Signed-off-by: Nipun Gupta 
---
 drivers/bus/dpaa/base/qbman/qman.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
b/drivers/bus/dpaa/base/qbman/qman.c
index 8730550..71da275 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -2238,11 +2238,6 @@ int qman_enqueue_multi(struct qman_fq *fq,
/* try to send as many frames as possible */
while (eqcr->available && frames_to_send--) {
eq->fqid = fq->fqid_le;
-#ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
-   eq->tag = cpu_to_be32(fq->key);
-#else
-   eq->tag = cpu_to_be32((u32)(uintptr_t)fq);
-#endif
eq->fd.opaque_addr = fd->opaque_addr;
eq->fd.addr = cpu_to_be40(fd->addr);
eq->fd.status = cpu_to_be32(fd->status);
-- 
2.7.4

[dpdk-dev] [PATCH v2 10/13] net/dpaa: separate Rx function for LS1046

[Hemant Agrawal]

This is to avoid the checks in datapath and help in performance.
LS1046 has different data stash settings.

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_ethdev.c |  9 +--
 drivers/net/dpaa/dpaa_rxtx.c   | 60 +-
 drivers/net/dpaa/dpaa_rxtx.h   |  3 +++
 3 files changed, 58 insertions(+), 14 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index c2d6f44..c430cac 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -657,8 +657,13 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
"ret:%d(%s)", rxq->fqid, ret, strerror(ret));
return ret;
}
-   rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb;
-   rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare;
+   if (dpaa_svr_family == SVR_LS1043A_FAMILY) {
+   rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb_no_prefetch;
+   } else {
+   rxq->cb.dqrr_dpdk_pull_cb = dpaa_rx_cb;
+   rxq->cb.dqrr_prepare = dpaa_rx_cb_prepare;
+   }
+
rxq->is_static = true;
}
dev->data->rx_queues[queue_idx] = rxq;
diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c
index 6698c97..2c57741 100644
--- a/drivers/net/dpaa/dpaa_rxtx.c
+++ b/drivers/net/dpaa/dpaa_rxtx.c
@@ -398,8 +398,9 @@ dpaa_eth_fd_to_mbuf(const struct qm_fd *fd, uint32_t ifid)
return mbuf;
 }
 
+/* Specific for LS1043 */
 void
-dpaa_rx_cb(struct qman_fq **fq, struct qm_dqrr_entry **dqrr,
+dpaa_rx_cb_no_prefetch(struct qman_fq **fq, struct qm_dqrr_entry **dqrr,
   void **bufs, int num_bufs)
 {
struct rte_mbuf *mbuf;
@@ -411,17 +412,13 @@ dpaa_rx_cb(struct qman_fq **fq, struct qm_dqrr_entry 
**dqrr,
uint32_t length;
uint8_t format;
 
-   if (dpaa_svr_family != SVR_LS1046A_FAMILY) {
-   bp_info = DPAA_BPID_TO_POOL_INFO(dqrr[0]->fd.bpid);
-   ptr = rte_dpaa_mem_ptov(qm_fd_addr(&dqrr[0]->fd));
-   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
-   bufs[0] = (struct rte_mbuf *)((char *)ptr -
-   bp_info->meta_data_size);
-   }
+   bp_info = DPAA_BPID_TO_POOL_INFO(dqrr[0]->fd.bpid);
+   ptr = rte_dpaa_mem_ptov(qm_fd_addr(&dqrr[0]->fd));
+   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
+   bufs[0] = (struct rte_mbuf *)((char *)ptr - bp_info->meta_data_size);
 
for (i = 0; i < num_bufs; i++) {
-   if (dpaa_svr_family != SVR_LS1046A_FAMILY &&
-   i < num_bufs - 1) {
+   if (i < num_bufs - 1) {
bp_info = DPAA_BPID_TO_POOL_INFO(dqrr[i + 1]->fd.bpid);
ptr = rte_dpaa_mem_ptov(qm_fd_addr(&dqrr[i + 1]->fd));
rte_prefetch0((void *)((uint8_t *)ptr +
@@ -458,6 +455,46 @@ dpaa_rx_cb(struct qman_fq **fq, struct qm_dqrr_entry 
**dqrr,
}
 }
 
+void
+dpaa_rx_cb(struct qman_fq **fq, struct qm_dqrr_entry **dqrr,
+  void **bufs, int num_bufs)
+{
+   struct rte_mbuf *mbuf;
+   const struct qm_fd *fd;
+   struct dpaa_if *dpaa_intf;
+   uint16_t offset, i;
+   uint32_t length;
+   uint8_t format;
+
+   for (i = 0; i < num_bufs; i++) {
+   fd = &dqrr[i]->fd;
+   dpaa_intf = fq[0]->dpaa_intf;
+
+   format = (fd->opaque & DPAA_FD_FORMAT_MASK) >>
+   DPAA_FD_FORMAT_SHIFT;
+   if (unlikely(format == qm_fd_sg)) {
+   bufs[i] = dpaa_eth_sg_to_mbuf(fd, dpaa_intf->ifid);
+   continue;
+   }
+
+   offset = (fd->opaque & DPAA_FD_OFFSET_MASK) >>
+   DPAA_FD_OFFSET_SHIFT;
+   length = fd->opaque & DPAA_FD_LENGTH_MASK;
+
+   mbuf = bufs[i];
+   mbuf->data_off = offset;
+   mbuf->data_len = length;
+   mbuf->pkt_len = length;
+   mbuf->port = dpaa_intf->ifid;
+
+   mbuf->nb_segs = 1;
+   mbuf->ol_flags = 0;
+   mbuf->next = NULL;
+   rte_mbuf_refcnt_set(mbuf, 1);
+   dpaa_eth_packet_info(mbuf, mbuf->buf_addr);
+   }
+}
+
 void dpaa_rx_cb_prepare(struct qm_dqrr_entry *dq, void **bufs)
 {
struct dpaa_bp_info *bp_info = DPAA_BPID_TO_POOL_INFO(dq->fd.bpid);
@@ -468,8 +505,7 @@ void dpaa_rx_cb_prepare(struct qm_dqrr_entry *dq, void 
**bufs)
 * So we prefetch the annoation beforehand, so that it is available
 * in cache when accessed.
 */
-   if (dpaa_svr_family == SVR_LS1046A_FAMILY)
-   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
+   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
 
*bufs = (struct rt

[dpdk-dev] [PATCH v2 09/13] net/dpaa: rearranging of atomic queue support code

[Hemant Agrawal]

From: Sunil Kumar Kori 

This is to align the code with dpaa2 to ease out maintaince
of both driver code bases.

Signed-off-by: Sunil Kumar Kori 
---
 drivers/net/dpaa/dpaa_rxtx.c | 25 +
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c
index 3a3a048..6698c97 100644
--- a/drivers/net/dpaa/dpaa_rxtx.c
+++ b/drivers/net/dpaa/dpaa_rxtx.c
@@ -870,6 +870,19 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, 
uint16_t nb_bufs)
DPAA_TX_BURST_SIZE : nb_bufs;
for (loop = 0; loop < frames_to_send; loop++) {
mbuf = *(bufs++);
+   seqn = mbuf->seqn;
+   if (seqn != DPAA_INVALID_MBUF_SEQN) {
+   index = seqn - 1;
+   if (DPAA_PER_LCORE_DQRR_HELD & (1 << index)) {
+   flags[loop] =
+  ((index & QM_EQCR_DCA_IDXMASK) << 8);
+   flags[loop] |= QMAN_ENQUEUE_FLAG_DCA;
+   DPAA_PER_LCORE_DQRR_SIZE--;
+   DPAA_PER_LCORE_DQRR_HELD &=
+   ~(1 << index);
+   }
+   }
+
if (likely(RTE_MBUF_DIRECT(mbuf))) {
mp = mbuf->pool;
bp_info = DPAA_MEMPOOL_TO_POOL_INFO(mp);
@@ -916,18 +929,6 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, 
uint16_t nb_bufs)
goto send_pkts;
}
}
-   seqn = mbuf->seqn;
-   if (seqn != DPAA_INVALID_MBUF_SEQN) {
-   index = seqn - 1;
-   if (DPAA_PER_LCORE_DQRR_HELD & (1 << index)) {
-   flags[loop] =
-  ((index & QM_EQCR_DCA_IDXMASK) << 8);
-   flags[loop] |= QMAN_ENQUEUE_FLAG_DCA;
-   DPAA_PER_LCORE_DQRR_SIZE--;
-   DPAA_PER_LCORE_DQRR_HELD &=
-   ~(1 << index);
-   }
-   }
}
 
 send_pkts:
-- 
2.7.4

[dpdk-dev] [PATCH v2 11/13] net/dpaa: tune prefetch in Rx path

[Hemant Agrawal]

As part of performance optimization excercise, tuning
the prefetch placement.

Signed-off-by: Hemant Agrawal 
---
 drivers/net/dpaa/dpaa_rxtx.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c
index 2c57741..c4471c2 100644
--- a/drivers/net/dpaa/dpaa_rxtx.c
+++ b/drivers/net/dpaa/dpaa_rxtx.c
@@ -370,10 +370,6 @@ dpaa_eth_fd_to_mbuf(const struct qm_fd *fd, uint32_t ifid)
if (unlikely(format == qm_fd_sg))
return dpaa_eth_sg_to_mbuf(fd, ifid);
 
-   ptr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd));
-
-   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
-
offset = (fd->opaque & DPAA_FD_OFFSET_MASK) >> DPAA_FD_OFFSET_SHIFT;
length = fd->opaque & DPAA_FD_LENGTH_MASK;
 
@@ -381,8 +377,11 @@ dpaa_eth_fd_to_mbuf(const struct qm_fd *fd, uint32_t ifid)
 
/* Ignoring case when format != qm_fd_contig */
dpaa_display_frame(fd);
+   ptr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd));
 
mbuf = (struct rte_mbuf *)((char *)ptr - bp_info->meta_data_size);
+   /* Prefetch the Parse results and packet data to L1 */
+   rte_prefetch0((void *)((uint8_t *)ptr + DEFAULT_RX_ICEOF));
 
mbuf->data_off = offset;
mbuf->data_len = length;
-- 
2.7.4

[dpdk-dev] [PATCH v2 12/13] bus/dpaa: add check for re-definition in compat

[Hemant Agrawal]

Few fields in compat are giving re-defination error
with new drivers such as caam_jr.
Checks have been added.

Signed-off-by: Hemant Agrawal 
---
 drivers/bus/dpaa/include/compat.h | 20 ++--
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/dpaa/include/compat.h 
b/drivers/bus/dpaa/include/compat.h
index 92241d2..4122657 100644
--- a/drivers/bus/dpaa/include/compat.h
+++ b/drivers/bus/dpaa/include/compat.h
@@ -57,8 +57,9 @@
 #ifndef __packed
 #define __packed   __rte_packed
 #endif
+#ifndef noinline
 #define noinline   __attribute__((noinline))
-
+#endif
 #define L1_CACHE_BYTES 64
 #define cacheline_aligned __attribute__((aligned(L1_CACHE_BYTES)))
 #define __stringify_1(x) #x
@@ -75,20 +76,25 @@
printf(fmt, ##args); \
fflush(stdout); \
} while (0)
-
+#ifndef pr_crit
 #define pr_crit(fmt, args...)   prflush("CRIT:" fmt, ##args)
+#endif
+#ifndef pr_err
 #define pr_err(fmt, args...)prflush("ERR:" fmt, ##args)
+#endif
+#ifndef pr_warn
 #define pr_warn(fmt, args...)   prflush("WARN:" fmt, ##args)
+#endif
+#ifndef pr_info
 #define pr_info(fmt, args...)   prflush(fmt, ##args)
-
-#ifdef RTE_LIBRTE_DPAA_DEBUG_BUS
-#ifdef pr_debug
-#undef pr_debug
 #endif
+#ifndef pr_debug
+#ifdef RTE_LIBRTE_DPAA_DEBUG_BUS
 #define pr_debug(fmt, args...) printf(fmt, ##args)
 #else
 #define pr_debug(fmt, args...) {}
 #endif
+#endif
 
 #define DPAA_BUG_ON(x) RTE_ASSERT(x)
 
@@ -256,7 +262,9 @@ __bswap_24(uint32_t x)
 #define be16_to_cpu(x) rte_be_to_cpu_16(x)
 
 #define cpu_to_be64(x) rte_cpu_to_be_64(x)
+#if !defined(cpu_to_be32)
 #define cpu_to_be32(x) rte_cpu_to_be_32(x)
+#endif
 #define cpu_to_be16(x) rte_cpu_to_be_16(x)
 
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
-- 
2.7.4

[dpdk-dev] [PATCH v2 13/13] mempool/dpaa: change the debug log level to DP

[Hemant Agrawal]

When the system goes out of buffers temporarily, the logs
further slow down the system. There is no need for this
continuos logs.

Signed-off-by: Hemant Agrawal 
---
 drivers/mempool/dpaa/dpaa_mempool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mempool/dpaa/dpaa_mempool.c 
b/drivers/mempool/dpaa/dpaa_mempool.c
index 10c536b..1c12122 100644
--- a/drivers/mempool/dpaa/dpaa_mempool.c
+++ b/drivers/mempool/dpaa/dpaa_mempool.c
@@ -122,7 +122,7 @@ dpaa_buf_free(struct dpaa_bp_info *bp_info, uint64_t addr)
struct bm_buffer buf;
int ret;
 
-   DPAA_MEMPOOL_DEBUG("Free 0x%" PRIx64 " to bpid: %d",
+   DPAA_MEMPOOL_DPDEBUG("Free 0x%" PRIx64 " to bpid: %d",
   addr, bp_info->bpid);
 
bm_buffer_set64(&buf, addr);
-- 
2.7.4

Re: [dpdk-dev] [PATCH 03/10] crypto/caam_jr: add HW config for job rings

[Akhil Goyal]

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:

From: Hemant Agrawal 

Signed-off-by: Gagandeep Singh 
Signed-off-by: Hemant Agrawal 
---
  drivers/crypto/caam_jr/Makefile  |   6 +
  drivers/crypto/caam_jr/caam_jr.c | 329 +++-
  drivers/crypto/caam_jr/caam_jr_config.h  | 207 
  drivers/crypto/caam_jr/caam_jr_hw.c  | 365 ++
  drivers/crypto/caam_jr/caam_jr_hw_specific.h | 503 +++
  drivers/crypto/caam_jr/caam_jr_pvt.h | 285 +++
  drivers/crypto/caam_jr/caam_jr_uio.c | 491 ++
  drivers/crypto/caam_jr/meson.build   |   5 +-
  8 files changed, 2188 insertions(+), 3 deletions(-)
  create mode 100644 drivers/crypto/caam_jr/caam_jr_config.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_hw.c
  create mode 100644 drivers/crypto/caam_jr/caam_jr_hw_specific.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_pvt.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_uio.c

diff --git a/drivers/crypto/caam_jr/Makefile b/drivers/crypto/caam_jr/Makefile
index 46d752af7..8b863b4af 100644
--- a/drivers/crypto/caam_jr/Makefile
+++ b/drivers/crypto/caam_jr/Makefile
@@ -19,7 +19,10 @@ CFLAGS += -O3
  CFLAGS += $(WERROR_FLAGS)
  endif
  
+CFLAGS += -I$(RTE_SDK)/drivers/bus/dpaa/include

  CFLAGS += -I$(RTE_SDK)/drivers/crypto/caam_jr
+#sharing the hw flib headers from dpaa2_sec pmd
+CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
  
@@ -30,11 +33,14 @@ EXPORT_MAP := rte_pmd_caam_jr_version.map

  LIBABIVER := 1
  
  # library source files

+SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr_hw.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr_uio.c
  SRCS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += caam_jr.c
  # library dependencies
  
  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring

  LDLIBS += -lrte_cryptodev
+LDLIBS += -lrte_bus_dpaa
  LDLIBS += -lrte_bus_vdev
  
  include $(RTE_SDK)/mk/rte.lib.mk

diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 68779cba5..9d5f5b79b 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -16,13 +16,146 @@
  #include 
  #include 
  #include 
+#include 
Please give one line break between the rte_ includes and driver specific 
includes
  
+/* RTA header files */

+#include 
+#include 
+#include 
+#include 
  #include 
  
  #define CRYPTODEV_NAME_CAAM_JR_PMD	crypto_caam_jr

  static uint8_t cryptodev_driver_id;
  int caam_jr_logtype;
  
+enum rta_sec_era rta_sec_era;

+
+/* Lists the states possible for the SEC user space driver. */
+enum sec_driver_state_e {
+   SEC_DRIVER_STATE_IDLE,  /* Driver not initialized */
+   SEC_DRIVER_STATE_STARTED,   /* Driver initialized and can be used*/
+   SEC_DRIVER_STATE_RELEASE,   /* Driver release is in progress */
+};
+
+/* Job rings used for communication with SEC HW */
+static struct sec_job_ring_t g_job_rings[MAX_SEC_JOB_RINGS];
+
+/* The current state of SEC user space driver */
+static enum sec_driver_state_e g_driver_state = SEC_DRIVER_STATE_IDLE;
+
+/* The number of job rings used by SEC user space driver */
+static int g_job_rings_no;
+static int g_job_rings_max;
+
+/* @brief Poll the HW for already processed jobs in the JR
+ * and silently discard the available jobs or notify them to UA
+ * with indicated error code.
+ *
+ * @param [in,out]  job_ringThe job ring to poll.
+ * @param [in]  do_notify   Can be #TRUE or #FALSE. Indicates if
+ * descriptors are to be discarded
+ *  or notified to UA with given error_code.
+ * @param [out] notified_descsNumber of notified descriptors. Can be NULL
+ * if do_notify is #FALSE
+ */
+static void hw_flush_job_ring(struct sec_job_ring_t *job_ring,
+ uint32_t do_notify,
+ uint32_t *notified_descs)
static void should be in a separate line.. Please check in rest of the 
code as well.

+{
+   int32_t jobs_no_to_discard = 0;
+   int32_t discarded_descs_no = 0;
+
+   CAAM_JR_DEBUG("Jr[%p] pi[%d] ci[%d].Flushing jr notify desc=[%d]",
+   job_ring, job_ring->pidx, job_ring->cidx, do_notify);
+
+   jobs_no_to_discard = hw_get_no_finished_jobs(job_ring);
+
+   /* Discard all jobs */
+   CAAM_JR_DEBUG("Jr[%p] pi[%d] ci[%d].Discarding %d descs",
+ job_ring, job_ring->pidx, job_ring->cidx,
+ jobs_no_to_discard);
+
+   while (jobs_no_to_discard > discarded_descs_no) {
+   /* Get completed descriptor */
+#if 0
+   /*TODO if we want to do something with desc*/
+   /* Since the memory is contigous, then P2V translation is a
+* mere addition to the base descriptor physical address
+  

Re: [dpdk-dev] [PATCH v5 4/4] build: generate API documentation with Meson

[Thomas Monjalon]

11/09/2018 22:42, Luca Boccassi:
> Signed-off-by: Luca Boccassi 
> Acked-by: Bruce Richardson 

Series applied, thanks

Re: [dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

[Ferruh Yigit]

On 9/18/2018 2:17 PM, Bruce Richardson wrote:
> Compiling with all warnings turned on causes errors about unused variables
> and an unused label. Remove these to allow building without having to
> disable those warnings.
> 
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting")
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")>
> CC: sta...@dpdk.org
> 
> Signed-off-by: Bruce Richardson 
> Acked-by: Luca Boccassi 

<...>

> @@ -1268,7 +1266,6 @@ static inline uint16_t
>  rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
>  {
>   struct avf_rx_queue *rxq = (struct avf_rx_queue *)rx_queue;
> - struct rte_eth_dev *dev;

Fixes: 1060591eada5 ("net/avf: enable bulk allocate Rx")

>   uint16_t nb_rx = 0;
>  
>   if (!nb_pkts)
> @@ -1584,10 +1581,6 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf 
> **tx_pkts, uint16_t nb_pkts)
>  
>   if (nb_ctx) {
>   /* Setup TX context descriptor if required */
> - volatile struct avf_tx_context_desc *ctx_txd =
> - (volatile struct avf_tx_context_desc *)
> - &txr[tx_id];

ctx_txd seems used in below macro controlled by DEBUG_DUMP_DESC define
AVF_DUMP_TX_DESC(txq, ctx_txd, tx_id);

Re: [dpdk-dev] [PATCH v7] net/i40e: add interface to use latest vec path

[Zhang, Qi Z]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, September 18, 2018 9:01 PM
> To: Li, Xiaoyun ; Xing, Beilei ;
> Zhang, Qi Z 
> Cc: dev@dpdk.org; Yang, Zhiyong ;
> tho...@monjalon.net; Richardson, Bruce 
> Subject: Re: [PATCH v7] net/i40e: add interface to use latest vec path
> 
> On 9/18/2018 3:22 AM, Xiaoyun Li wrote:
> > For IA, the AVX2 vector path is only recommended to be used on later
> > platforms (identified by AVX512 support, like SKL etc.) This is
> > because performance benchmark shows downgrade when running AVX2
> vector
> > path on early platform (BDW/HSW) in some cases. But we still observe
> > perf gain with some real work loading.
> >
> > So this patch introduced the new devarg use-latest-supported-vec to
> > force the driver always selecting the latest supported vec path. Then
> > apps are able to take AVX2 path on early platforms. And this logic can
> > be re-used if we will have AVX512 vec path in future.
> >
> > This patch only affects IA platforms. The selected vec path would be
> > like the following:
> >   Without devarg/devarg = 0:
> >   Machine   vPMD
> >   AVX512F   AVX2
> >   AVX2  SSE4.2
> >   SSE4.2SSE4.2
> >>
> >   With devarg = 1
> >   Machine   vPMD
> >   AVX512F   AVX2
> >   AVX2  AVX2
> >   SSE4.2SSE4.2
> >>
> > Other platforms can also apply the same logic if necessary in future.
> >
> > Signed-off-by: Xiaoyun Li 
> > ---
> > v7:
> >  * Use uint_8 instead of bool type for struct member.
> > v6:
> >  * Polish the doc and commit log.
> >  * Use rte_kvargs_process instead of directly kvlist internals.
> > v5:
> >  * Simpify the rx set function.
> > v4:
> >  * Polish the codes.
> > v3:
> >  * Polish the doc and commit log.
> > v2:
> >  * Correct the calling of the wrong function last time.
> >  * Fix seg fault bug.
> > ---
> >  doc/guides/nics/i40e.rst   |   8 ++
> 
> Doc is causing warning:
> doc/guides/nics/i40e.rst:172: WARNING: Unexpected indentation.
> 
> Except from that,
> Reviewed-by: Ferruh Yigit 

Applied to dpdk-next-net-intel.

Thanks
Qi

Re: [dpdk-dev] [PATCH v2 2/2] net/avf: fix missing compiler error flags

[Ferruh Yigit]

On 9/18/2018 2:17 PM, Bruce Richardson wrote:
> The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means
> that a number of compilation errors were getting missed. This patch adds
> in the flag and fixes most of the errors, just disabling the
> strict-aliasing ones.
> 
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
> Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> 
> CC: sta...@dpdk.org
> 
> Signed-off-by: Bruce Richardson 

Reviewed-by: Ferruh Yigit 

Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log

[Zhang, Qi Z]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, September 18, 2018 9:04 PM
> To: Xing, Beilei ; Zhang, Qi Z 
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove driver log
> 
> On 9/18/2018 6:44 AM, Beilei Xing wrote:
> > Remove driver log when no interrupt event indicated in alarm handler
> > for both PF and VF, otherwise there will be lots of prints which makes
> > console unusable.
> >
> > Signed-off-by: Beilei Xing 
> 
> Reviewed-by: Ferruh Yigit 

Applied to dpdk-next-net-intel

Thanks
Qi

Re: [dpdk-dev] [PATCH 04/10] crypto/caam_jr: add device configuration routines

[Akhil Goyal]

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:

From: Hemant Agrawal 

Signed-off-by: Gagandeep Singh 
Signed-off-by: Hemant Agrawal 
---
  drivers/crypto/caam_jr/caam_jr.c | 100 +++-
  drivers/crypto/caam_jr/caam_jr.h | 257 +++
  2 files changed, 356 insertions(+), 1 deletion(-)
  create mode 100644 drivers/crypto/caam_jr/caam_jr.h

diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 9d5f5b79b..43fe5233b 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -22,6 +22,7 @@
  #include 
  #include 
  #include 
+#include 
  #include 
  #include 
  
@@ -104,6 +105,90 @@ static void hw_flush_job_ring(struct sec_job_ring_t *job_ring,

  }
  
  
+static int

+caam_jr_dev_configure(struct rte_cryptodev *dev,
+  struct rte_cryptodev_config *config __rte_unused)
+{
+   char str[20];
+   struct sec_job_ring_t *internals;
+
+   PMD_INIT_FUNC_TRACE();
+
+   internals = dev->data->dev_private;
+   sprintf(str, "ctx_pool_%d", dev->data->dev_id);
+   if (!internals->ctx_pool) {
+   internals->ctx_pool = rte_mempool_create((const char *)str,
+   CTX_POOL_NUM_BUFS,
+   sizeof(struct caam_jr_op_ctx),
+   CTX_POOL_CACHE_SIZE, 0,
+   NULL, NULL, NULL, NULL,
+   SOCKET_ID_ANY, 0);
+   if (!internals->ctx_pool) {
+   CAAM_JR_ERR("%s create failed\n", str);
+   return -ENOMEM;
+   }
+   } else
+   CAAM_JR_INFO("mempool already created for dev_id : %d",
+   dev->data->dev_id);
+
+   return 0;
+}
+
+static int
+caam_jr_dev_start(struct rte_cryptodev *dev __rte_unused)
+{
+   PMD_INIT_FUNC_TRACE();
+   return 0;
+}
+
+static void
+caam_jr_dev_stop(struct rte_cryptodev *dev __rte_unused)
+{
+   PMD_INIT_FUNC_TRACE();
+}
+
+static int
+caam_jr_dev_close(struct rte_cryptodev *dev)
+{
+   struct sec_job_ring_t *internals;
+
+   PMD_INIT_FUNC_TRACE();
+
+   if (dev == NULL)
+   return -ENOMEM;
+
+   internals = dev->data->dev_private;
+   rte_mempool_free(internals->ctx_pool);
+   internals->ctx_pool = NULL;
+
+   return 0;
+}
+
+static void
+caam_jr_dev_infos_get(struct rte_cryptodev *dev,
+  struct rte_cryptodev_info *info)
+{
+   struct sec_job_ring_t *internals = dev->data->dev_private;
+
+   PMD_INIT_FUNC_TRACE();
+   if (info != NULL) {
+   info->max_nb_queue_pairs = internals->max_nb_queue_pairs;
+   info->feature_flags = dev->feature_flags;
+   info->capabilities = caam_jr_capabilities;
+   info->sym.max_nb_sessions = internals->max_nb_sessions;
+   info->driver_id = cryptodev_driver_id;
+   }
+}
+
+static struct rte_cryptodev_ops caam_jr_ops = {
+   .dev_configure= caam_jr_dev_configure,
+   .dev_start= caam_jr_dev_start,
+   .dev_stop = caam_jr_dev_stop,
+   .dev_close= caam_jr_dev_close,
+   .dev_infos_get= caam_jr_dev_infos_get,
+};
+
+
  /* @brief Flush job rings of any processed descs.
   * The processed descs are silently dropped,
   * WITHOUT being notified to UA.
@@ -366,7 +451,20 @@ caam_jr_dev_init(const char *name,
}
  
  	dev->driver_id = cryptodev_driver_id;

-   dev->dev_ops = NULL;
+   dev->dev_ops = &caam_jr_ops;
+
+   /* register rx/tx burst functions for data path */
+   dev->dequeue_burst = NULL;
+   dev->enqueue_burst = NULL;
+   dev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |
+   RTE_CRYPTODEV_FF_HW_ACCELERATED |
+   RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
+   RTE_CRYPTODEV_FF_SECURITY |
+   RTE_CRYPTODEV_FF_IN_PLACE_SGL |
+   RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
+   RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
+   RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |
+   RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
  
  	/* For secondary processes, we don't initialise any further as primary

 * has already done this work. Only check we don't need a different
diff --git a/drivers/crypto/caam_jr/caam_jr.h b/drivers/crypto/caam_jr/caam_jr.h
new file mode 100644
index 0..d7c36ca9d
--- /dev/null
+++ b/drivers/crypto/caam_jr/caam_jr.h
@@ -0,0 +1,257 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2017-2018 NXP
+ */
+
+#ifndef CAAM_JR_H
+#define CAAM_JR_H
+
+static const struct rte_cryptodev_capabilities caam_jr_capabilities[] = {
+   {   /* MD5 HMAC */
+   .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,

Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

[Thomas Monjalon]

18/09/2018 15:31, Hemant Agrawal:
> Avoid return after the jumbo buffer config in dev config API
> 
> Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Hemant Agrawal 

Thanks for adding some comments in this series.

About this fix, would it be easier to understand if explaining
what is the bug first?

Re: [dpdk-dev] [PATCH 05/10] crypto/caam_jr: add queue config functions

[Akhil Goyal]

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:

From: Hemant Agrawal 

Signed-off-by: Gagandeep Singh 
Signed-off-by: Hemant Agrawal 
---
  drivers/crypto/caam_jr/caam_jr.c | 64 
  1 file changed, 64 insertions(+)

diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 43fe5233b..f05e966b0 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -104,6 +104,67 @@ static void hw_flush_job_ring(struct sec_job_ring_t 
*job_ring,
}
  }
  
+/* Release queue pair */

+static int
+caam_jr_queue_pair_release(struct rte_cryptodev *dev,
+   uint16_t qp_id)
+{
+   struct sec_job_ring_t *internals;
+   struct caam_jr_qp *qp = NULL;
+
+   PMD_INIT_FUNC_TRACE();
+
+   CAAM_JR_DEBUG("dev =%p, queue =%d", dev, qp_id);
+
+   internals = dev->data->dev_private;
+   if (qp_id >= internals->max_nb_queue_pairs) {
+   CAAM_JR_ERR("Max supported qpid %d",
+internals->max_nb_queue_pairs);
+   return -EINVAL;
+   }
+
+   qp = &internals->qps[qp_id];
+   qp->ring = NULL;
+   dev->data->queue_pairs[qp_id] = NULL;
+
+   return 0;
+}
+
+/* Setup a queue pair */
+static int
+caam_jr_queue_pair_setup(
+   struct rte_cryptodev *dev, uint16_t qp_id,
+   __rte_unused const struct rte_cryptodev_qp_conf *qp_conf,
+   __rte_unused int socket_id,
+   __rte_unused struct rte_mempool *session_pool)
+{
+   struct sec_job_ring_t *internals;
+   struct caam_jr_qp *qp = NULL;
+


PMD_INIT_FUNC_TRACE(); missing here and please check other ops as well


+   CAAM_JR_DEBUG("dev =%p, queue =%d, conf =%p", dev, qp_id, qp_conf);
+
+   internals = dev->data->dev_private;
+   if (qp_id >= internals->max_nb_queue_pairs) {
+   CAAM_JR_ERR("Max supported qpid %d",
+internals->max_nb_queue_pairs);
+   return -EINVAL;
+   }
+
+   qp = &internals->qps[qp_id];
+   qp->ring = internals;
+   dev->data->queue_pairs[qp_id] = qp;
+
+   return 0;
+}
+
+/* Return the number of allocated queue pairs */
+static uint32_t
+caam_jr_queue_pair_count(struct rte_cryptodev *dev)
+{
+   PMD_INIT_FUNC_TRACE();
+
+   return dev->data->nb_queue_pairs;
+}
  
  static int

  caam_jr_dev_configure(struct rte_cryptodev *dev,
@@ -186,6 +247,9 @@ static struct rte_cryptodev_ops caam_jr_ops = {
.dev_stop = caam_jr_dev_stop,
.dev_close= caam_jr_dev_close,
.dev_infos_get= caam_jr_dev_infos_get,
+   .queue_pair_setup = caam_jr_queue_pair_setup,
+   .queue_pair_release   = caam_jr_queue_pair_release,
+   .queue_pair_count = caam_jr_queue_pair_count,
  };
  
  

Re: [dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label

[Bruce Richardson]

On Tue, Sep 18, 2018 at 02:51:27PM +0100, Ferruh Yigit wrote:
> On 9/18/2018 2:17 PM, Bruce Richardson wrote:
> > Compiling with all warnings turned on causes errors about unused variables
> > and an unused label. Remove these to allow building without having to
> > disable those warnings.
> > 
> > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> > Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting")
> > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> > Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")>
> > CC: sta...@dpdk.org
> > 
> > Signed-off-by: Bruce Richardson 
> > Acked-by: Luca Boccassi 
> 
> <...>
> 
> > @@ -1268,7 +1266,6 @@ static inline uint16_t
> >  rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> >  {
> > struct avf_rx_queue *rxq = (struct avf_rx_queue *)rx_queue;
> > -   struct rte_eth_dev *dev;
> 
> Fixes: 1060591eada5 ("net/avf: enable bulk allocate Rx")
> 
There's always one more! :-(

> > uint16_t nb_rx = 0;
> >  
> > if (!nb_pkts)
> > @@ -1584,10 +1581,6 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf 
> > **tx_pkts, uint16_t nb_pkts)
> >  
> > if (nb_ctx) {
> > /* Setup TX context descriptor if required */
> > -   volatile struct avf_tx_context_desc *ctx_txd =
> > -   (volatile struct avf_tx_context_desc *)
> > -   &txr[tx_id];
> 
> ctx_txd seems used in below macro controlled by DEBUG_DUMP_DESC define
> AVF_DUMP_TX_DESC(txq, ctx_txd, tx_id);

Yes, looking now it is. The function that is called from that macro takes a
void *, so I don't think the temporary variable is needed at all. I'll do a
V3, changing ctx_txd to &txr[tx_id] in that instance.

However, compiling with the DUMP_DESC flag turned on raises a whole set of
other compiler warnings in the code - even with 18.08 release. Therefore
that option should either be fixed and made a proper debug option in the
build config, or else dropped.

/Bruce

Re: [dpdk-dev] [PATCH 00/10] Introducing the NXP CAAM job ring driver

[Akhil Goyal]

Hi Gagan,

On 9/13/2018 11:38 AM, Gagandeep Singh wrote:

The caam_jr PMD provides poll mode crypto driver
support for NXP SEC 4.x+ (CAAM) hardware accelerator.

This patch has dependancy on below patches:
http://patchwork.dpdk.org/patch/43986/
http://patchwork.dpdk.org/patch/43964/

Hemant Agrawal (10):
   doc: add caam jr cryptodev details
   crypto/caam_jr: introduce basic driver
   crypto/caam_jr: add HW config for job rings
   crypto/caam_jr: add device configuration routines
   crypto/caam_jr: add queue config functions
   crypto/caam_jr: add basic session config routines
   crypto/caam_jr: add enqueue and dequeue routines
   crypto/caam_jr: add auth cipher and aead session support
   crypto/caam_jr: add stats support
   crypto/caam_jr: add security offload support

  config/common_base|8 +
  config/common_linuxapp|1 +
  config/defconfig_arm64-dpaa-linuxapp-gcc  |4 +
  doc/guides/cryptodevs/caam_jr.rst |  159 ++
  doc/guides/cryptodevs/index.rst   |1 +
  drivers/crypto/Makefile   |1 +
  drivers/crypto/caam_jr/Makefile   |   46 +
  drivers/crypto/caam_jr/caam_jr.c  | 2485 +
  drivers/crypto/caam_jr/caam_jr.h  |  257 ++
  drivers/crypto/caam_jr/caam_jr_config.h   |  207 ++
  drivers/crypto/caam_jr/caam_jr_desc.h |  289 ++
  drivers/crypto/caam_jr/caam_jr_hw.c   |  365 +++
  drivers/crypto/caam_jr/caam_jr_hw_specific.h  |  503 
  drivers/crypto/caam_jr/caam_jr_log.h  |   42 +
  drivers/crypto/caam_jr/caam_jr_pvt.h  |  288 ++
  drivers/crypto/caam_jr/caam_jr_uio.c  |  491 
  drivers/crypto/caam_jr/meson.build|   14 +
  .../caam_jr/rte_pmd_caam_jr_version.map   |4 +
  drivers/crypto/meson.build|2 +-
  19 files changed, 5166 insertions(+), 1 deletion(-)
  create mode 100644 doc/guides/cryptodevs/caam_jr.rst
  create mode 100644 drivers/crypto/caam_jr/Makefile
  create mode 100644 drivers/crypto/caam_jr/caam_jr.c
  create mode 100644 drivers/crypto/caam_jr/caam_jr.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_config.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_desc.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_hw.c
  create mode 100644 drivers/crypto/caam_jr/caam_jr_hw_specific.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_log.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_pvt.h
  create mode 100644 drivers/crypto/caam_jr/caam_jr_uio.c
  create mode 100644 drivers/crypto/caam_jr/meson.build
  create mode 100644 drivers/crypto/caam_jr/rte_pmd_caam_jr_version.map



I have some generic comments on your patchset:
1. Please add description to the patches. None of them have it.
2. Split of the patches could be better. You can have Hardware specific 
code in one patch and then you can use that in the next patch.

3. SG related stuff can be a separate patch.
4. there are checkpatch issues which can be resolved.
5. I could see extra spaces at many places. Please check.
6. Function definitions are not as per DPDK coding style.

Thanks,
Akhil

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

[Zhang, Qi Z]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong
> Sent: Friday, September 14, 2018 4:42 PM
> To: Wang, Xiao W 
> Cc: Bie, Tiwei ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
> 
> Looks good to me.
> 
> Reviewed-by: Ye Xiaolong 
> 
> Thanks,
> Xiaolong
> 
> On 09/14, Xiao Wang wrote:
> >If the device is not clearly reset by the previous driver and holds
> >some invalid ring addr, and the relay thread kicks it before HW is
> >properly re-configured, a bad DMA request may happen.
> >
> >Besides, the notify_addr which is used by the relay thread is set in
> >the vdpa_ifcvf_start function, if a kick relay happens before
> >vdpa_ifcvf_start finishes, a null addr is accessed.
> >
> >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> >
> >Signed-off-by: Xiao Wang 

Applied to dpdk-next-net-intel.

Thanks
Qi

[dpdk-dev] [PATCH v3 1/2] net/avf: fix unused variables and label

[Bruce Richardson]

Compiling with all warnings turned on causes errors about unused variables
and an unused label. Remove these to allow building without having to
disable those warnings.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting")
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Fixes: 1060591eada5 ("net/avf: enable bulk allocate Rx")

CC: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/avf/avf_ethdev.c | 15 +--
 drivers/net/avf/avf_rxtx.c   | 19 ++-
 drivers/net/avf/avf_vchnl.c  |  2 --
 3 files changed, 7 insertions(+), 29 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a7d69828c..6b6ff7d55 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -154,7 +154,6 @@ static int
 avf_init_rss(struct avf_adapter *adapter)
 {
struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(adapter);
-   struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);
struct rte_eth_rss_conf *rss_conf;
uint8_t i, j, nb_q;
int ret;
@@ -259,11 +258,8 @@ avf_init_rxq(struct rte_eth_dev *dev, struct avf_rx_queue 
*rxq)
 static int
 avf_init_queues(struct rte_eth_dev *dev)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_rx_queue **rxq =
(struct avf_rx_queue **)dev->data->rx_queues;
-   struct avf_tx_queue **txq =
-   (struct avf_tx_queue **)dev->data->tx_queues;
int i, ret = AVF_SUCCESS;
 
for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -415,7 +411,6 @@ avf_dev_start(struct rte_eth_dev *dev)
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
 
PMD_INIT_FUNC_TRACE();
@@ -476,9 +471,7 @@ avf_dev_stop(struct rte_eth_dev *dev)
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
-   int ret, i;
 
PMD_INIT_FUNC_TRACE();
 
@@ -503,8 +496,6 @@ avf_dev_stop(struct rte_eth_dev *dev)
 static void
 avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
memset(dev_info, 0, sizeof(*dev_info));
@@ -914,7 +905,6 @@ avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 static int
 avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
uint32_t frame_size = mtu + AVF_ETH_OVERHEAD;
int ret = 0;
 
@@ -1044,8 +1034,6 @@ avf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, 
uint16_t queue_id)
 static int
 avf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint16_t msix_intr;
@@ -1088,7 +1076,7 @@ avf_check_vf_reset_done(struct avf_hw *hw)
 static int
 avf_init_vf(struct rte_eth_dev *dev)
 {
-   int i, err, bufsz;
+   int err, bufsz;
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1197,7 +1185,6 @@ avf_dev_interrupt_handler(void *param)
 
avf_handle_virtchnl_msg(dev);
 
-done:
avf_enable_irq0(hw);
 }
 
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index e03a136fc..6b3b0191c 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -247,7 +247,6 @@ alloc_rxq_mbufs(struct avf_rx_queue *rxq)
 static inline void
 release_rxq_mbufs(struct avf_rx_queue *rxq)
 {
-   struct rte_mbuf *mbuf;
uint16_t i;
 
if (!rxq->sw_ring)
@@ -310,9 +309,8 @@ avf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
struct avf_rx_queue *rxq;
const struct rte_memzone *mz;
uint32_t ring_size;
-   uint16_t len, i;
+   uint16_t len;
uint16_t rx_free_thresh;
-   uint16_t base, bsf, tc_mapping;
 
PMD_INIT_FUNC_TRACE();
 

[dpdk-dev] [PATCH v3 2/2] net/avf: fix missing compiler error flags

[Bruce Richardson]

The AVF driver was missing $(WERROR_FLAGS) in it's cflags, which means
that a number of compilation errors were getting missed. This patch adds
in the flag and fixes most of the errors, just disabling the
strict-aliasing ones.

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")

CC: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/avf/Makefile   | 2 +-
 drivers/net/avf/avf_ethdev.c   | 2 +-
 drivers/net/avf/avf_rxtx.h | 2 +-
 drivers/net/avf/avf_rxtx_vec_sse.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
index 3f815bbc4..0a142c104 100644
--- a/drivers/net/avf/Makefile
+++ b/drivers/net/avf/Makefile
@@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 #
 LIB = librte_pmd_avf.a
 
-CFLAGS += -O3
+CFLAGS += -O3 $(WERROR_FLAGS) -Wno-strict-aliasing
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
 LDLIBS += -lrte_bus_pci
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 6b6ff7d55..549498477 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -559,7 +559,7 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
 }
 
 static const uint32_t *
-avf_dev_supported_ptypes_get(struct rte_eth_dev *dev)
+avf_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)
 {
static const uint32_t ptypes[] = {
RTE_PTYPE_L2_ETHER,
diff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h
index 297d0776d..c4120f8a4 100644
--- a/drivers/net/avf/avf_rxtx.h
+++ b/drivers/net/avf/avf_rxtx.h
@@ -227,7 +227,7 @@ static inline
 void avf_dump_tx_descriptor(const struct avf_tx_queue *txq,
const void *desc, uint16_t tx_id)
 {
-   char *name;
+   const char *name;
const struct avf_tx_desc *tx_desc = desc;
enum avf_tx_desc_dtype_value type;
 
diff --git a/drivers/net/avf/avf_rxtx_vec_sse.c 
b/drivers/net/avf/avf_rxtx_vec_sse.c
index 8275100f3..343a6aac3 100644
--- a/drivers/net/avf/avf_rxtx_vec_sse.c
+++ b/drivers/net/avf/avf_rxtx_vec_sse.c
@@ -621,7 +621,7 @@ avf_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf 
**tx_pkts,
return nb_pkts;
 }
 
-void __attribute__((cold))
+static void __attribute__((cold))
 avf_rx_queue_release_mbufs_sse(struct avf_rx_queue *rxq)
 {
_avf_rx_queue_release_mbufs_vec(rxq);
-- 
2.17.1

[dpdk-dev] [PATCH v5 1/9] build: add Meson file for TAP PMD

[Luca Boccassi]

Use same autoconf generation mechanism as the MLX4/5 PMDs

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/tap/meson.build | 41 +
 2 files changed, 42 insertions(+)
 create mode 100644 drivers/net/tap/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index c7a2d0e7db..b7b4870eb8 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -27,6 +27,7 @@ drivers = ['af_packet',
'sfc',
'softnic',
'szedata2',
+   'tap',
'thunderx',
'vhost',
'virtio']
diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
new file mode 100644
index 00..37f65b75c2
--- /dev/null
+++ b/drivers/net/tap/meson.build
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 Luca Boccassi 
+
+sources = files(
+   'rte_eth_tap.c',
+   'tap_bpf_api.c',
+   'tap_flow.c',
+   'tap_intr.c',
+   'tap_netlink.c',
+   'tap_tcmsgs.c',
+)
+
+deps = ['bus_vdev', 'gso', 'hash']
+
+cflags += '-DTAP_MAX_QUEUES=16'
+
+# To maintain the compatibility with the make build system
+# tap_autoconf.h file is still generated.
+# input array for meson symbol search:
+# [ "MACRO to define if found", "header for the search",
+#   "enum/define", "symbol to search" ]
+#
+args = [
+   [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_UNSPEC' ],
+   [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_KEY_VLAN_PRIO' ],
+   [ 'HAVE_TC_BPF', 'linux/pkt_cls.h',
+ 'TCA_BPF_UNSPEC' ],
+   [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h',
+ 'TCA_BPF_FD' ],
+   [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_UNSPEC' ],
+   [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_FD' ],
+]
+config = configuration_data()
+foreach arg:args
+   config.set(arg[0], cc.has_header_symbol(arg[1], arg[2]))
+endforeach
+configure_file(output : 'tap_autoconf.h', configuration : config)
-- 
2.18.0

[dpdk-dev] [PATCH v5 3/9] build: add Meson file for crypto scheduler PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/crypto/meson.build   |  2 +-
 drivers/crypto/scheduler/meson.build | 19 +++
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/scheduler/meson.build

diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index d64ca418bc..6ed853b7ab 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
-   'null', 'openssl', 'qat', 'virtio']
+   'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/crypto/scheduler/meson.build 
b/drivers/crypto/scheduler/meson.build
new file mode 100644
index 00..c5ba2d6804
--- /dev/null
+++ b/drivers/crypto/scheduler/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bus_vdev', 'reorder']
+name = 'crypto_scheduler'
+sources = files(
+   'rte_cryptodev_scheduler.c',
+   'scheduler_failover.c',
+   'scheduler_multicore.c',
+   'scheduler_pkt_size_distr.c',
+   'scheduler_pmd.c',
+   'scheduler_pmd_ops.c',
+   'scheduler_roundrobin.c',
+)
+
+headers = files(
+   'rte_cryptodev_scheduler.h',
+   'rte_cryptodev_scheduler_operations.h',
+)
-- 
2.18.0

[dpdk-dev] [PATCH v5 4/9] build: add Meson files for avf PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/avf/base/meson.build | 20 
 drivers/net/avf/meson.build  | 19 +++
 drivers/net/meson.build  |  1 +
 3 files changed, 40 insertions(+)
 create mode 100644 drivers/net/avf/base/meson.build
 create mode 100644 drivers/net/avf/meson.build

diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build
new file mode 100644
index 00..90fd6b445f
--- /dev/null
+++ b/drivers/net/avf/base/meson.build
@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'avf_adminq.c',
+   'avf_common.c',
+]
+
+error_cflags = ['-Wno-pointer-to-int-cast']
+c_args = cflags
+foreach flag: error_cflags
+   if cc.has_argument(flag)
+   c_args += flag
+   endif
+endforeach
+
+base_lib = static_library('avf_base', sources,
+   dependencies: static_rte_eal,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
new file mode 100644
index 00..b5ad9cc673
--- /dev/null
+++ b/drivers/net/avf/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+cflags += ['-Wno-strict-aliasing']
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'avf_ethdev.c',
+   'avf_rxtx.c',
+   'avf_rxtx_vec_sse.c',
+   'avf_vchnl.c',
+)
+
+if arch_subdir == 'x86'
+   dpdk_conf.set('RTE_LIBRTE_AVF_INC_VECTOR', 1)
+   sources += files('avf_rxtx_vec_sse.c')
+endif
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 68ac42d67c..28efeda0b6 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -3,6 +3,7 @@
 
 drivers = ['af_packet',
'ark',
+   'avf',
'avp',
'axgbe', 'bonding',
'bnx2x',
-- 
2.18.0

[dpdk-dev] [PATCH v5 2/9] build: add Meson file for vdev_netvsc PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/vdev_netvsc/meson.build | 19 +++
 2 files changed, 20 insertions(+)
 create mode 100644 drivers/net/vdev_netvsc/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index b7b4870eb8..68ac42d67c 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -29,6 +29,7 @@ drivers = ['af_packet',
'szedata2',
'tap',
'thunderx',
+   'vdev_netvsc',
'vhost',
'virtio']
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
diff --git a/drivers/net/vdev_netvsc/meson.build 
b/drivers/net/vdev_netvsc/meson.build
new file mode 100644
index 00..cc956e7b27
--- /dev/null
+++ b/drivers/net/vdev_netvsc/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files('vdev_netvsc.c')
+
+allow_experimental_apis = true
+
+cflags_options = [
+'-Wall',
+'-Wextra',
+'-D_BSD_SOURCE',
+'-D_DEFAULT_SOURCE',
+'-D_XOPEN_SOURCE=600'
+]
+foreach option:cflags_options
+if cc.has_argument(option)
+cflags += option
+endif
+endforeach
-- 
2.18.0

[dpdk-dev] [PATCH v5 5/9] build: add Meson files for qede PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
Acked-by: Shahed Shaikh 
---
 config/rte_config.h   |  3 ++
 drivers/net/meson.build   |  2 +-
 drivers/net/qede/base/meson.build | 57 +++
 drivers/net/qede/meson.build  | 12 +++
 4 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/qede/base/meson.build
 create mode 100644 drivers/net/qede/meson.build

diff --git a/config/rte_config.h b/config/rte_config.h
index 46775a8419..ee84f04977 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -116,4 +116,7 @@
 #define RTE_PMD_RING_MAX_RX_RINGS 16
 #define RTE_PMD_RING_MAX_TX_RINGS 16
 
+/* QEDE PMD defines */
+#define RTE_LIBRTE_QEDE_FW ""
+
 #endif /* _RTE_CONFIG_H_ */
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 28efeda0b6..74f4109161 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -24,7 +24,7 @@ drivers = ['af_packet',
'mvpp2',
'netvsc',
'nfp',
-   'null', 'octeontx', 'pcap', 'ring',
+   'null', 'octeontx', 'pcap', 'qede', 'ring',
'sfc',
'softnic',
'szedata2',
diff --git a/drivers/net/qede/base/meson.build 
b/drivers/net/qede/base/meson.build
new file mode 100644
index 00..59b41c895d
--- /dev/null
+++ b/drivers/net/qede/base/meson.build
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'bcm_osal.c',
+   'ecore_cxt.c',
+   'ecore_dcbx.c',
+   'ecore_dev.c',
+   'ecore_hw.c',
+   'ecore_init_fw_funcs.c',
+   'ecore_init_ops.c',
+   'ecore_int.c',
+   'ecore_l2.c',
+   'ecore_mcp.c',
+   'ecore_sp_commands.c',
+   'ecore_spq.c',
+   'ecore_sriov.c',
+   'ecore_vf.c',
+]
+
+
+error_cflags = [
+   '-Wno-unused-parameter',
+   '-Wno-sign-compare',
+   '-Wno-missing-prototypes',
+   '-Wno-cast-qual',
+   '-Wno-unused-function',
+   '-Wno-unused-variable',
+   '-Wno-strict-aliasing',
+   '-Wno-missing-prototypes',
+   '-Wno-unused-value',
+   '-Wno-format-nonliteral',
+   '-Wno-shift-negative-value',
+   '-Wno-unused-but-set-variable',
+   '-Wno-missing-declarations',
+   '-Wno-maybe-uninitialized',
+   '-Wno-strict-prototypes',
+   '-Wno-shift-negative-value',
+   '-Wno-implicit-fallthrough',
+   '-Wno-format-extra-args',
+   '-Wno-visibility',
+   '-Wno-empty-body',
+   '-Wno-invalid-source-encoding',
+   '-Wno-sometimes-uninitialized',
+   '-Wno-pointer-bool-conversion',
+]
+c_args = cflags
+foreach flag: error_cflags
+if cc.has_argument(flag)
+c_args += flag
+endif
+endforeach
+
+base_lib = static_library('qede_base', sources,
+   dependencies: static_rte_net,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build
new file mode 100644
index 00..6280073a56
--- /dev/null
+++ b/drivers/net/qede/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'qede_ethdev.c',
+   'qede_fdir.c',
+   'qede_main.c',
+   'qede_rxtx.c',
+)
-- 
2.18.0

[dpdk-dev] [PATCH v5 6/9] build: add Meson file for bbdev_null PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/baseband/meson.build  | 7 +++
 drivers/baseband/null/meson.build | 7 +++
 drivers/meson.build   | 1 +
 3 files changed, 15 insertions(+)
 create mode 100644 drivers/baseband/meson.build
 create mode 100644 drivers/baseband/null/meson.build

diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
new file mode 100644
index 00..52489df354
--- /dev/null
+++ b/drivers/baseband/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+drivers = ['null']
+
+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
+driver_name_fmt = 'rte_pmd_@0@'
diff --git a/drivers/baseband/null/meson.build 
b/drivers/baseband/null/meson.build
new file mode 100644
index 00..64c29d8600
--- /dev/null
+++ b/drivers/baseband/null/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bbdev', 'bus_vdev', 'ring']
+name = 'bbdev_null'
+allow_experimental_apis = true
+sources = files('bbdev_null.c')
diff --git a/drivers/meson.build b/drivers/meson.build
index c5df313dd2..47b4215a30 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -9,6 +9,7 @@ driver_classes = ['common',
   'crypto',  # depends on common, bus and mempool (net in future).
   'compress', # depends on common, bus, mempool.
   'event',   # depends on common, bus, mempool and net.
+  'baseband', # depends on common and bus.
   'raw'] # depends on common, bus, mempool, net and event.
 
 default_cflags = machine_args
-- 
2.18.0

[dpdk-dev] [PATCH v5 8/9] build: add Meson file for opdl_event PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/event/meson.build  |  2 +-
 drivers/event/opdl/meson.build | 11 +++
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 drivers/event/opdl/meson.build

diff --git a/drivers/event/meson.build b/drivers/event/meson.build
index e951199358..ed56d20062 100644
--- a/drivers/event/meson.build
+++ b/drivers/event/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['dpaa', 'dpaa2', 'octeontx', 'skeleton', 'sw']
+drivers = ['dpaa', 'dpaa2', 'octeontx', 'opdl', 'skeleton', 'sw']
 std_deps = ['eventdev', 'kvargs']
 config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
 driver_name_fmt = 'rte_pmd_@0@_event'
diff --git a/drivers/event/opdl/meson.build b/drivers/event/opdl/meson.build
new file mode 100644
index 00..cc6029c6f0
--- /dev/null
+++ b/drivers/event/opdl/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files(
+   'opdl_evdev.c',
+   'opdl_evdev_init.c',
+   'opdl_evdev_xstats.c',
+   'opdl_ring.c',
+   'opdl_test.c',
+)
+deps += ['bus_vdev']
-- 
2.18.0

[dpdk-dev] [PATCH v5 7/9] event/opdl: rename map file to match library name

[Luca Boccassi]

So that it can be used from Meson as well

Signed-off-by: Luca Boccassi 
---
 drivers/event/opdl/Makefile | 2 +-
 ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/event/opdl/{rte_pmd_evdev_opdl_version.map => 
rte_pmd_opdl_event_version.map} (100%)

diff --git a/drivers/event/opdl/Makefile b/drivers/event/opdl/Makefile
index cea8118d36..bf50a60a0b 100644
--- a/drivers/event/opdl/Makefile
+++ b/drivers/event/opdl/Makefile
@@ -24,7 +24,7 @@ LDLIBS += -lrte_bus_vdev -lrte_mbuf -lrte_mempool
 LIBABIVER := 1
 
 # versioning export map
-EXPORT_MAP := rte_pmd_evdev_opdl_version.map
+EXPORT_MAP := rte_pmd_opdl_event_version.map
 
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += opdl_ring.c
diff --git a/drivers/event/opdl/rte_pmd_evdev_opdl_version.map 
b/drivers/event/opdl/rte_pmd_opdl_event_version.map
similarity index 100%
rename from drivers/event/opdl/rte_pmd_evdev_opdl_version.map
rename to drivers/event/opdl/rte_pmd_opdl_event_version.map
-- 
2.18.0

[dpdk-dev] [PATCH v5 9/9] build: add Meson file for vmxnet3_uio PMD

[Luca Boccassi]

Note that the library built by meson will not have the _uio suffix:
librte_pmd_vmxnet3.so - as it follows the directory name, while the
legacy makefile rename it to librte_pmd_vmxnet3_uio.so.

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  4 +++-
 drivers/net/vmxnet3/meson.build | 18 ++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/vmxnet3/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 74f4109161..5906283c2f 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -32,7 +32,9 @@ drivers = ['af_packet',
'thunderx',
'vdev_netvsc',
'vhost',
-   'virtio']
+   'virtio',
+   'vmxnet3',
+]
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std
 std_deps += ['bus_vdev']# same with vdev bus
diff --git a/drivers/net/vmxnet3/meson.build b/drivers/net/vmxnet3/meson.build
new file mode 100644
index 00..a92bd28680
--- /dev/null
+++ b/drivers/net/vmxnet3/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+allow_experimental_apis = true
+sources += files(
+   'vmxnet3_ethdev.c',
+   'vmxnet3_rxtx.c',
+)
+
+error_cflags = [
+   '-Wno-unused-parameter', '-Wno-unused-value',
+'-Wno-strict-aliasing', '-Wno-format-extra-args',
+]
+foreach flag: error_cflags
+if cc.has_argument(flag)
+cflags += flag
+endif
+endforeach
-- 
2.18.0

Re: [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

[Luca Boccassi]

On Thu, 2018-09-13 at 17:16 +0100, Luca Boccassi wrote:
> Signed-off-by: Luca Boccassi 
> ---
>  drivers/net/meson.build |  4 +++-
>  drivers/net/vmxnet3/meson.build | 18 ++
>  2 files changed, 21 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/vmxnet3/meson.build
> 
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> index 74f4109161..5906283c2f 100644

On request I've sent a v5 adding a note in the commit message that the
filename of the library will be different from the one generated by the
makefiles, as it doesn't have the _uio suffix, following the suggestion
to avoid renames.

The following PMDs already have meson files which build a library file
with a different name from the makefiles:

net/liquidio
net/thurnderx
net/sfc
event/octeontx
compress/octeontx

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

[Stephen Hemminger]

On Tue, 18 Sep 2018 11:40:28 +0200
Thomas Monjalon  wrote:

> 25/07/2018 20:20, Stephen Hemminger:
> > No need for profanity in comments.
> > 
> > Signed-off-by: Stephen Hemminger 
> > ---
> >  drivers/net/bnx2x/elink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> > index 34a29373af3b..08fe817720a1 100644
> > --- a/drivers/net/bnx2x/elink.c
> > +++ b/drivers/net/bnx2x/elink.c
> > @@ -3993,11 +3993,11 @@ static elink_status_t 
> > elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
> >PORT_HW_CFG_E3_MOD_ABS_MASK) >>
> > PORT_HW_CFG_E3_MOD_ABS_SHIFT;
> >  
> > -   /* Should not happen. This function called upon interrupt
> > +   /*
> > +* Should not happen. This function called upon interrupt
> >  * triggered by GPIO ( since EPIO can only generate interrupts
> >  * to MCP).
> >  * So if this function was called and none of the GPIOs was set,
> > -* it means the shit hit the fan.
> >  */  
> 
> It makes the comment ends with a comma, like the end is missing.
> 
> 
> 

Yes, better language would be.
/* This should not happen since this function is called
 * from interrupt triggered by GPI ..

Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

[Burakov, Anatoly]

On 18-Sep-18 1:29 PM, Shreyansh Jain wrote:

On Monday 17 September 2018 06:30 PM, Burakov, Anatoly wrote:

On 17-Sep-18 1:16 PM, Shahaf Shuler wrote:

Monday, September 17, 2018 1:07 PM, Burakov, Anatoly:
Subject: Re: [dpdk-dev] [PATCH 00/16] Support externally allocated 
memory

in DPDK

On 13-Sep-18 8:44 AM, Shahaf Shuler wrote:


[...]


The responsibility to ensure memory is accessible before using it is
on the shoulders of the user - there is no checking done with regards
to validity of the memory (nor could there be...).


That makes sense. However who should be in-charge of mapping this

memory for dma access?
The user or internally be the PMD when encounter the first packet 
or while

traversing the existing mempools?



Hi Shahaf,

There are two ways this can be solved. The first way is to perform VFIO
mapping automatically on adding/attaching memory. The second is to 
force
user to do it manually. For now, the latter is chosen because user 
knows best

if they intend to do DMA on that memory, but i'm open to suggestions.


I agree with that approach, and will add not only if the mempool is 
for dma or not but also which ports will use this mempool (this can 
effect on the mapping).


That is perhaps too hardware-specific - this should probably be 
handled inside the driver callbacks.


However I don't think this is generic enough to use only VFIO. As you 
said, there are some devices not using VFIO for mapping rather some 
proprietary driver utility.

IMO DPDK should introduce generic and device agnostic APIs to the user.

My suggestion is instead of doing vfio_dma_map that or vfio_dma_unmap 
that have a generic dma_map(uint8_t port, address, len). Each driver 
will register with its own mapping callback (can be vfio_dma_map).
It can be outside of this series, just wondering the people opinion 
on such approach.


I don't disagree. I don't like bus/net/etc drivers doing their own 
thing with regards to mapping, and i would by far prefer generic way 
to set up DMA maps, to which VFIO will be a subscriber.






There is an issue with some devices and buses (i.e. bus/fslmc) 
bypassing EAL
VFIO infrastructure and performing their own VFIO/DMA mapping magic, 
but

solving that problem is outside the scope of this patchset. Those
devices/buses should fix themselves :)


DMA mapping is a very common principle and can be easily be a candidate 
for lets-make-generic-movement, but, being close to hardware (or 
hardware specific), it does require the driver to have some flexibility 
in terms of its eventual implementation.


Perhaps i didn't word my response clearly enough. I didn't mean to say 
(or imply) that EAL must handle all DMA mappings itself. Rather, EAL 
should provide a generic infrastructure of maintaining current mappings 
etc., and provide a subscription mechanism for other users (e.g. 
drivers) so that the details of implementation of exactly how to map 
things for DMA is up to the drivers.


In other words, we agree :)



I maintain one of those drivers (bus/fslmc) in DPDK which needs to have 
special VFIO layer - and from that experience, I can say that VFIO 
mapping does require some flexibility. SoC semantics are sometimes too 
complex to pin to general-universally-agreed-standard concept. (or, one 
can easily call it a 'bug', while it is a 'feature' for others :D)


In fact, NXP has another driver (bus/dpaa) which doesn't even work with 
VFIO - loves to work directly with Phys_addr. And, it is not at a lower 
priority than one with VFIO.


Thus, I really don't think a strongly controlled VFIO mapping should be 
EAL's responsibility. Failure because of lack of mapping is a driver's 
problem.




While EAL doesn't necessarily need to be involved with mapping things 
for VFIO, i believe it does need to be the authority on what gets 
mapped. The user needs a way to make arbitrary memory available for DMA 
- this is where EAL comes in. VFIO itself can be factored out into a 
separate subsystem (DMA drivers, anyone? :D ), but given that memory 
cometh and goeth (external memory included), and given that some things 
tend to be a bit complicated [*], EAL needs to know when something is 
supposed to be mapped or unmapped, and when to notify subscribers that 
they may have to refresh their DMA maps.


[*] for example, VFIO can only do mappings whenever there are devices 
actually attached to a VFIO container, so we have to maintain all maps 
between hotplug events to ensure that memory set up for DMA doesn't 
silently get unmapped on device detach and subsequent attach.


--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

[Bruce Richardson]

On Tue, Sep 18, 2018 at 04:00:12PM +0100, Luca Boccassi wrote:
> On Thu, 2018-09-13 at 17:16 +0100, Luca Boccassi wrote:
> > Signed-off-by: Luca Boccassi 
> > ---
> >  drivers/net/meson.build |  4 +++-
> >  drivers/net/vmxnet3/meson.build | 18 ++
> >  2 files changed, 21 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/net/vmxnet3/meson.build
> > 
> > diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> > index 74f4109161..5906283c2f 100644
> 
> On request I've sent a v5 adding a note in the commit message that the
> filename of the library will be different from the one generated by the
> makefiles, as it doesn't have the _uio suffix, following the suggestion
> to avoid renames.
> 
> The following PMDs already have meson files which build a library file
> with a different name from the makefiles:
> 
> net/liquidio
> net/thurnderx
> net/sfc
> event/octeontx
> compress/octeontx
> 
We should really start pointing people to use the pkg-config files to pull
in libraries, and with a properly installed DPDK using "ninja install", all
.so drivers should be automatically found on the PMD_PATH. Therefore, the
number of cases where built-in DPDK drivers are being explicitly loaded
individually using "-d " should be very, very few.

Regards,
/Bruce

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

[Ferruh Yigit]

On 9/14/2018 3:45 AM, Jerin Jacob wrote:
> -Original Message-
>> Date: Thu, 13 Sep 2018 23:45:31 +
>> From: Honnappa Nagarahalli 
>> To: Jerin Jacob 
>> CC: Ola Liljedahl , "Kokkilagadda, Kiran"
>>  , "Gavin Hu (Arm Technology China)"
>>  , Ferruh Yigit , "Jacob,  Jerin"
>>  , "dev@dpdk.org" , nd
>>  , Steve Capper , "Phil Yang (Arm
>>  Technology China)" 
>> Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer
>>  synchronization
>>
>> External Email
>>
>> -Original Message-
>>> Date: Thu, 13 Sep 2018 17:40:53 +
>>> From: Honnappa Nagarahalli 
>>> To: Jerin Jacob , Ola Liljedahl
>>> 
>>> CC: "Kokkilagadda, Kiran" , "Gavin Hu
>>> (Arm  Technology China)" , Ferruh Yigit
>>> , "Jacob,  Jerin"
>>>  , "dev@dpdk.org" ,
>>> nd  , Steve Capper , "Phil Yang (Arm
>>> Technology China)" 
>>> Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer
>>> synchronization
>>>
>>>
>>> Hi Jerin,
>>> Is there any reason for having 'RTE_RING_USE_C11_MEM_MODEL', which 
>>> is specific to rte_ring? I do not see a need for choosing only some 
>>> algorithms to work with C11 model. I suggest that we change this to 
>>> 'RTE_USE_C11_MEM_MODEL' so that it can apply to all libraries/algorithms.
>>
>>
>> Yes. Makes sense to me to keep only single config option.
>>
>> rte_ring has 2 sets of algorithms for Arm architecture, one with C11 memory 
>> model and the other with barriers. Going forward (for ex: for KNI), I think 
>> we should support C11 memory model only and skip the barriers.
> 
> IMO, Both should be supported and set N as in the config/common_base.
> Based on architecture or micro architecture the performance can vary.
> So keeping both options and allowing to override to arch/micro arch
> specific config file makes sense to me.(like existing model, as smp_*
> ops are compiler NOP for x86)

Hi Jerin, Honnappa,  Kiran,

Will there be a new version for this release?

I can see two options:
1- Add read/write barriers for both library and kernel parts.
2- Use c11 atomics
  2a- change existing RTE_RING_USE_C11_MEM_MODEL to RTE_USE_C11_MEM_MODEL
  2b- Use RTE_USE_C11_MEM_MODEL to implement c11 atomic for arm and ppc

2) seems agreed on, but is it clear who will work on it?

And 1) looks easier to implement, if 2) won't make time for release can we
fallback to this one?

Thanks,
ferruh

>  
>> Also, do you see any issues in making C11 memory model default for Arm 
>> architecture?
> 
> It is already set default Y to arm64. see config/common_armv8a_linuxapp.
> 
> And it is possible for micro architecture to override, see
> config/defconfig_arm64-thunderx-linuxapp-gcc
> 
> 
>>
>>>
>>> Thank you,
>>> Honnappa
>>>
>>> -Original Message-
>>> From: Jerin Jacob 
>>> Sent: Wednesday, August 29, 2018 3:58 AM
>>> To: Ola Liljedahl 
>>> Cc: Kokkilagadda, Kiran ; Honnappa
>>> Nagarahalli ; Gavin Hu
>>> ; Ferruh Yigit ; Jacob,
>>> Jerin ; dev@dpdk.org; nd
>>> ; Steve Capper 
>>> Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer
>>> synchronization
>>>
>>> -Original Message-
 Date: Wed, 29 Aug 2018 08:47:56 +
 From: Ola Liljedahl 
 To: Jerin Jacob 
 CC: "Kokkilagadda, Kiran" , Honnappa
 Nagarahalli , Gavin Hu
 ,  Ferruh Yigit , "Jacob,  Jerin"
  , "dev@dpdk.org"
 , nd  , Steve Capper
 
 Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer
 synchronization
 user-agent: Microsoft-MacOutlook/10.10.0.180812


 There was a mention of rte_ring which is a different data structure. But 
 perhaps I misunderstood why this was mentioned and the idea was only to 
 use the C11 memory model as is also used in rte_ring nowadays.

 But why would we have different code for x86 and for other architectures 
 (ARM, Power)? If we use the C11 memory model (and e.g. GCC __atomic 
 builtins), the code generated for x86 will be the same. 
 __atomic_load(__ATOMIC_ACQUIRE) and __atomic_store(__ATOMIC_RELEASE) 
 should translate to plain loads and stores on x86?
>>>
>>> # One reason was __atomic builtins  primitives were implemented in gcc 4.7 
>>> and x86 would like to support < gcc 4.7 and ICC compiler.
>>> # The theme was no change in the existing code for x86.I am not sure about 
>>> the code generation for x86 with __atomic builtins, I let x86 maintainers 
>>> to comments on this.
>>>
>>>

 -- Ola

 On 29/08/2018, 10:28, "Jerin Jacob"  
 wrote:

 -Original Message-
 > Date: Wed, 29 Aug 2018 07:34:34 +
 > From: Ola Liljedahl 
 > To: "Kokkilagadda, Kiran" , Honnappa
 >  Nagarahalli , Gavin Hu 
 ,
 >  Ferruh Yigit , "Jacob,  Jerin"
 >  
 > CC: "dev@dpdk.org" , nd , Steve Capper
 >  
 > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer
 >  synchronization
 > user-agent: Microsoft-MacOutlook/10.10.0.180812
 >
 > Is th

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

[Ferruh Yigit]

On 9/12/2018 12:29 AM, Dan Gora wrote:
> Set the carrier state to 'off' when the interface is instantiated
> or when it is marked 'up' or 'down'.  This is necessary to set the
> interface to a known operational state until the carrier state is
> changed with rte_kni_update_link().

Why setting to no-carrier mode by default? This will change the behavior of
interfaces and may effect others. And indeed I didn't get why this is required?

> 
> Signed-off-by: Dan Gora 
> ---
>  kernel/linux/kni/kni_misc.c | 2 ++
>  kernel/linux/kni/kni_net.c  | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
> index fa69f8e63..45649499d 100644
> --- a/kernel/linux/kni/kni_misc.c
> +++ b/kernel/linux/kni/kni_misc.c
> @@ -466,6 +466,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
>   return -ENODEV;
>   }
>  
> + netif_carrier_off(net_dev);
> +
>   ret = kni_run_thread(knet, kni, dev_info.force_bind);
>   if (ret != 0)
>   return ret;
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 7fcfa106c..1f8ba0700 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -133,6 +133,7 @@ kni_net_open(struct net_device *dev)
>   struct kni_dev *kni = netdev_priv(dev);
>  
>   netif_start_queue(dev);
> + netif_carrier_off(dev);
>  
>   memset(&req, 0, sizeof(req));
>   req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
> @@ -152,6 +153,7 @@ kni_net_release(struct net_device *dev)
>   struct kni_dev *kni = netdev_priv(dev);
>  
>   netif_stop_queue(dev); /* can't transmit any more */
> + netif_carrier_off(dev);
>  
>   memset(&req, 0, sizeof(req));
>   req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
> 

Re: [dpdk-dev] [PATCH] kni: return failure for all ioctls

[Ferruh Yigit]

On 9/13/2018 10:46 PM, Dan Gora wrote:
> Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead
> of 0.
> 
> This is necessary because the Wicked (and possibly other) network
> interface managers will perform the SIOCGIWNAME ioctl to check if
> the interface is a wireless interface.  If the KNI module returns
> success, Wicked will incorrectly interpret the interface as a wireless
> interface.
> 
> Signed-off-by: Dan Gora 

Acked-by: Ferruh Yigit 

Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

[Hemant]

On 9/18/2018 7:33 PM, Thomas Monjalon wrote:

18/09/2018 15:31, Hemant Agrawal:

Avoid return after the jumbo buffer config in dev config API

Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU")
Cc: sta...@dpdk.org

Signed-off-by: Hemant Agrawal 

Thanks for adding some comments in this series.

About this fix, would it be easier to understand if explaining
what is the bug first?



yes. I can be more specific here.
1. the dev->data->mtu was not getting updated earlier for the jumbo 
buffer config.
2. we don't expect to return error, if this config fails. A debug err 
log is ok.  DPAA1 - supports jumbo by default, enable/disable may give 
errors.

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

[Ferruh Yigit]

On 9/18/2018 5:15 PM, Ferruh Yigit wrote:
> On 9/12/2018 12:29 AM, Dan Gora wrote:
>> Set the carrier state to 'off' when the interface is instantiated
>> or when it is marked 'up' or 'down'.  This is necessary to set the
>> interface to a known operational state until the carrier state is
>> changed with rte_kni_update_link().
> 
> Why setting to no-carrier mode by default? This will change the behavior of
> interfaces and may effect others. And indeed I didn't get why this is 
> required?

I just read the other thread, including Igor's and your comment about starting
the interface down, overall I got your point but my concerns is if someone has a
solution based on assumption that interface will be up when created will be
affected.

> 
>>
>> Signed-off-by: Dan Gora 
>> ---
>>  kernel/linux/kni/kni_misc.c | 2 ++
>>  kernel/linux/kni/kni_net.c  | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
>> index fa69f8e63..45649499d 100644
>> --- a/kernel/linux/kni/kni_misc.c
>> +++ b/kernel/linux/kni/kni_misc.c
>> @@ -466,6 +466,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
>>  return -ENODEV;
>>  }
>>  
>> +netif_carrier_off(net_dev);
>> +
>>  ret = kni_run_thread(knet, kni, dev_info.force_bind);
>>  if (ret != 0)
>>  return ret;
>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
>> index 7fcfa106c..1f8ba0700 100644
>> --- a/kernel/linux/kni/kni_net.c
>> +++ b/kernel/linux/kni/kni_net.c
>> @@ -133,6 +133,7 @@ kni_net_open(struct net_device *dev)
>>  struct kni_dev *kni = netdev_priv(dev);
>>  
>>  netif_start_queue(dev);
>> +netif_carrier_off(dev);
>>  
>>  memset(&req, 0, sizeof(req));
>>  req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
>> @@ -152,6 +153,7 @@ kni_net_release(struct net_device *dev)
>>  struct kni_dev *kni = netdev_priv(dev);
>>  
>>  netif_stop_queue(dev); /* can't transmit any more */
>> +netif_carrier_off(dev);
>>  
>>  memset(&req, 0, sizeof(req));
>>  req.req_id = RTE_KNI_REQ_CFG_NETWORK_IF;
>>
> 

Re: [dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface

[Ferruh Yigit]

On 9/12/2018 12:29 AM, Dan Gora wrote:
> Add a new API function to KNI, rte_kni_update_link() to allow DPDK
> applications to update the link status for KNI network interfaces in
> the linux kernel.
> 
> Signed-off-by: Dan Gora 

+1 to sysfs implementation.

But right now this API is not used at all which makes it hard to test and catch
when API broken.
Can you please implement the API either on kni sample app or kni unit test?

Also you need to add new API to .map file for shared library build. (you would
catch this if API implemented somewhere...)

[dpdk-dev] [PATCH v4 00/10] net/softnic: implement metering and policing API

[Jasvinder Singh]

This series is prepared on top of following patchset;
https://mails.dpdk.org/archives/dev/2018-September/111379.html

v4 changes
- introduce the table meter profile check in softnic pipeline table meter
  profile add function (rte_eth_softnic_thread.c)
- change the table action check function to more generic form
  softnic_table_is_action_enabled() (rte_eth_softnic_flow.c)
  
v3 changes:
- update pipeline table with meter profiles
- update pipeline table with dscp table entry update

v2 changes:
- fix copyright year for rte_eth_softnic_meter.c
- Place all checks in a separate functions while creating meter object
- Use softnic_pipeline_table_mtr_profile_add() api to add meter profile
  instead of implementing new function
- Use stats type indicator to determine the stats_mask for meter stats read 
 
Jasvinder Singh (10):
  net/softnic: add metering and policing support
  net/softnic: add meter profile
  net/softnic: delete meter profile
  net/softnic: create meter object
  net/softnic: destroy meter object
  net/softnic: update meter profile
  net/softnic: update dscp table
  net/softnic: update policer actions
  net/softnic: meter stats read
  net/softnic: enable flow rule with meter action

 drivers/net/softnic/Makefile|   1 +
 drivers/net/softnic/meson.build |   1 +
 drivers/net/softnic/rte_eth_softnic.c   |  13 +
 drivers/net/softnic/rte_eth_softnic_flow.c  | 155 -
 drivers/net/softnic/rte_eth_softnic_internals.h |  66 +++
 drivers/net/softnic/rte_eth_softnic_meter.c | 728 
 drivers/net/softnic/rte_eth_softnic_pipeline.c  |  26 +
 drivers/net/softnic/rte_eth_softnic_thread.c|  48 +-
 8 files changed, 1032 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/softnic/rte_eth_softnic_meter.c

-- 
2.9.3

[dpdk-dev] [PATCH v4 02/10] net/softnic: add meter profile

[Jasvinder Singh]

Implement meter profile add function.

Signed-off-by: Jasvinder Singh 
---
 drivers/net/softnic/rte_eth_softnic.c   |   3 +
 drivers/net/softnic/rte_eth_softnic_internals.h |  31 ++
 drivers/net/softnic/rte_eth_softnic_meter.c | 122 +++-
 3 files changed, 155 insertions(+), 1 deletion(-)

diff --git a/drivers/net/softnic/rte_eth_softnic.c 
b/drivers/net/softnic/rte_eth_softnic.c
index 659a1b4..b7b2383 100644
--- a/drivers/net/softnic/rte_eth_softnic.c
+++ b/drivers/net/softnic/rte_eth_softnic.c
@@ -191,6 +191,7 @@ pmd_dev_stop(struct rte_eth_dev *dev)
softnic_mempool_free(p);
 
tm_hierarchy_free(p);
+   softnic_mtr_free(p);
 }
 
 static void
@@ -291,6 +292,7 @@ pmd_init(struct pmd_params *params)
 
/* Resources */
tm_hierarchy_init(p);
+   softnic_mtr_init(p);
 
softnic_mempool_init(p);
softnic_swq_init(p);
@@ -345,6 +347,7 @@ pmd_free(struct pmd_internals *p)
softnic_mempool_free(p);
 
tm_hierarchy_free(p);
+   softnic_mtr_free(p);
 
rte_free(p);
 }
diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h 
b/drivers/net/softnic/rte_eth_softnic_internals.h
index 92be4e8..1db9310 100644
--- a/drivers/net/softnic/rte_eth_softnic_internals.h
+++ b/drivers/net/softnic/rte_eth_softnic_internals.h
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rte_eth_softnic.h"
 #include "conn.h"
@@ -68,6 +69,24 @@ struct flow_internals {
 };
 
 /**
+ * Meter
+ */
+
+/* MTR meter profile */
+struct softnic_mtr_meter_profile {
+   TAILQ_ENTRY(softnic_mtr_meter_profile) node;
+   uint32_t meter_profile_id;
+   struct rte_mtr_meter_profile params;
+   uint32_t n_users;
+};
+
+TAILQ_HEAD(softnic_mtr_meter_profile_list, softnic_mtr_meter_profile);
+
+struct mtr_internals {
+   struct softnic_mtr_meter_profile_list meter_profiles;
+};
+
+/**
  * MEMPOOL
  */
 struct softnic_mempool_params {
@@ -525,6 +544,8 @@ struct pmd_internals {
} soft;
 
struct flow_internals flow;
+   struct mtr_internals mtr;
+
struct softnic_conn *conn;
struct softnic_mempool_list mempool_list;
struct softnic_swq_list swq_list;
@@ -574,6 +595,16 @@ extern const struct rte_flow_ops pmd_flow_ops;
 /**
  * Meter
  */
+int
+softnic_mtr_init(struct pmd_internals *p);
+
+void
+softnic_mtr_free(struct pmd_internals *p);
+
+struct softnic_mtr_meter_profile *
+softnic_mtr_meter_profile_find(struct pmd_internals *p,
+   uint32_t meter_profile_id);
+
 extern const struct rte_mtr_ops pmd_mtr_ops;
 
 /**
diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c 
b/drivers/net/softnic/rte_eth_softnic_meter.c
index 0a5409b..1222866 100644
--- a/drivers/net/softnic/rte_eth_softnic_meter.c
+++ b/drivers/net/softnic/rte_eth_softnic_meter.c
@@ -11,10 +11,130 @@
 
 #include "rte_eth_softnic_internals.h"
 
+int
+softnic_mtr_init(struct pmd_internals *p)
+{
+   /* Initialize meter profiles list */
+   TAILQ_INIT(&p->mtr.meter_profiles);
+
+   return 0;
+}
+
+void
+softnic_mtr_free(struct pmd_internals *p)
+{
+   /* Remove meter profiles */
+   for ( ; ; ) {
+   struct softnic_mtr_meter_profile *mp;
+
+   mp = TAILQ_FIRST(&p->mtr.meter_profiles);
+   if (mp == NULL)
+   break;
+
+   TAILQ_REMOVE(&p->mtr.meter_profiles, mp, node);
+   free(mp);
+   }
+}
+
+struct softnic_mtr_meter_profile *
+softnic_mtr_meter_profile_find(struct pmd_internals *p,
+   uint32_t meter_profile_id)
+{
+   struct softnic_mtr_meter_profile_list *mpl = &p->mtr.meter_profiles;
+   struct softnic_mtr_meter_profile *mp;
+
+   TAILQ_FOREACH(mp, mpl, node)
+   if (meter_profile_id == mp->meter_profile_id)
+   return mp;
+
+   return NULL;
+}
+
+static int
+meter_profile_check(struct rte_eth_dev *dev,
+   uint32_t meter_profile_id,
+   struct rte_mtr_meter_profile *profile,
+   struct rte_mtr_error *error)
+{
+   struct pmd_internals *p = dev->data->dev_private;
+   struct softnic_mtr_meter_profile *mp;
+
+   /* Meter profile ID must be valid. */
+   if (meter_profile_id == UINT32_MAX)
+   return -rte_mtr_error_set(error,
+   EINVAL,
+   RTE_MTR_ERROR_TYPE_METER_PROFILE_ID,
+   NULL,
+   "Meter profile id not valid");
+
+   /* Meter profile must not exist. */
+   mp = softnic_mtr_meter_profile_find(p, meter_profile_id);
+   if (mp)
+   return -rte_mtr_error_set(error,
+   EEXIST,
+   RTE_MTR_ERROR_TYPE_METER_PROFILE_ID,
+   NULL,
+   "Meter prfile already exists");
+
+   /* Profile must not be NULL. */
+   if (profile == NULL)
+   return -rte_mtr_error_set(error,
+   EINVAL,
+