Re: [dpdk-dev] [PATCH 18.05-RC2 1/4] eal: remove unused define

[David Marchand]

On Wed, Apr 25, 2018 at 2:24 PM, Anatoly Burakov
 wrote:
> The define was a leftover from IVSHMEM library.
>
> Fixes: c711ccb30987 ("ivshmem: remove library and its EAL integration")
> Cc: david.march...@6wind.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov 

Indeed.
Reviewed-by: David Marchand 

However, not sure this really needs to go to stable.

-- 
David Marchand

Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter

[Akhil Goyal]

Hi Abhinandan,
On 4/26/2018 11:37 AM, Gujjar, Abhinandan S wrote:

Hi Akhil,


-Original Message-
From: Akhil Goyal [mailto:akhil.go...@nxp.com]
Sent: Wednesday, April 25, 2018 6:12 PM
To: Gujjar, Abhinandan S ;
jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com;
akhil.go...@nxp.com; dev@dpdk.org
Cc: Vangati, Narender ; Rao, Nikhil
; Eads, Gage 
Subject: Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter

Hi Abhinandan,
On 4/24/2018 6:13 PM, Abhinandan Gujjar wrote:

Signed-off-by: Abhinandan Gujjar 
Signed-off-by: Nikhil Rao 
Signed-off-by: Gage Eads 
---
 lib/librte_eventdev/rte_event_crypto_adapter.h | 532
+
 1 file changed, 532 insertions(+)
 create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h

diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h
b/lib/librte_eventdev/rte_event_crypto_adapter.h
new file mode 100644
index 000..aa4f32c
--- /dev/null
+++ b/lib/librte_eventdev/rte_event_crypto_adapter.h
@@ -0,0 +1,532 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017-2018 Intel Corporation  */
+
+#ifndef _RTE_EVENT_CRYPTO_ADAPTER_
+#define _RTE_EVENT_CRYPTO_ADAPTER_
+
+/**
+ * @file
+ *
+ * RTE Event crypto adapter
+ *
+ * Eventdev library provides couple of adapters to bridge between
+various
+ * components for providing new event source. The event crypto
+adapter is
+ * one of those adapter which is intended to bridge between event
+devices
+ * and crypto devices.
+ *
+ * The crypto adapter adds support to enqueue/dequeue crypto
+operations to/
+ * from event device. The packet flow between crypto device and the
+event
+ * device can be accomplished using both SW and HW based transfer

mechanisms.

+ * The adapter uses an EAL service core function for SW based packet
+transfer
+ * and uses the eventdev PMD functions to configure HW based packet
+transfer
+ * between the crypto device and the event device.
+ *
+ * The application can choose to submit a crypto operation directly
+to
+ * crypto device or send it to the crypto adapter via eventdev, the
+crypto
+ * adapter then submits the crypto operation to the crypto device.
+ * The first mode is known as the dequeue only (DEQ_ONLY) mode and
+the
+ * second as the enqueue - dequeue (ENQ_DEQ) mode. The choice of mode
+can
+ * be specified while creating the adapter.
+ *
+ *
+ * Working model of DEQ_ONLY mode:
+ * ===
+ *
+ * +--+ +--+
+ * Events  |  | | Crypto stage |
+ * <-->| Event device |>| + enqueue to |
+ * |  | |   cryptodev  |
+ * +--+ +--+
+ * event  ^|
+ * enqueue||  crypto
+ *|v enqueue
+ * +--+ +--+
+ * |  | |  |
+ * |Crypto adapter|<|  Cryptodev   |
+ * |  | |  |
+ * +--+ +--+
+ *

The diagram looks a bit cryptic. Enqueue to cryptodev will be done from
application and not from event device. The arrow from event device to crypto
stage is not clear. And application dequeues events from event device. So that
should not be bidirectional arrow.


You are right, it is done from application. But the application will be in the 
crypto stage of
pipeline. Since crypto is an intermediate stage, events are first dequeued from 
eventdev to
find out it's a crypto stage. Then application, in the crypto stage, enqueue 
"rte_crypto_ops"
to cryptodev and finally adapter enqueue crypto completions as events to 
eventdev.
From this point, eventdev will pass events to the next stage (may be Tx).
That's the reason behind bidirectional arrow to event device.

You are talking about a particular application, but the comments should 
be generic. In DEQ ONLY mode, enqueue to cryptodev is responsibility of 
application and should not be from event dev. Actually the application 
will dequeue from event dev and decide that this event comes from NIC 
(say), and it needs to be processed by cryptodev next. So in this case 
the application decides what will happen to the packet and not the event 
dev, so it cannot be bi-directional arrow.





+ * In the DEQ_ONLY mode, application submits crypto operations
+ directly to
+ * crypto device. The adapter then dequeues crypto completions from
+ crypto
+ * device and enqueue events to the event device.
+ * In this mode, application needs to specify event information
+ (response
+ * information) which is needed to enqueue an event after the crypto
+ operation
+ * is completed.
+ *
+ *
+ * Working model of ENQ_DEQ mode:
+ * ==
+ *
+ * +--+ +--+
+ * Events  |  | |  |
+ * <-->| Event device |>| Cr

Re: [dpdk-dev] [PATCH] eal: shut up warning about master lcore

[Burakov, Anatoly]

On 26-Apr-18 1:48 AM, Stephen Hemminger wrote:

This message looks suspicious and seen on healthy testpmd.
  EAL: WARNING: Master core has no memory on local socket!

The message is wrong: the master lcore is 0 and its socket is 0
and there are multiple available memory segments on socket 0.

At that point in the startup process, the count value is zero,
meaning they are not used yet so the check_socket gets confused.

Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Signed-off-by: Stephen Hemminger 
---


Was aware of this and going to fix it myself, but higher priority items 
popped up. Thanks for fixing this!


Acked-by: Anatoly Burakov 

--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH] app/pdump: remove unused socket path options

[Pattan, Reshma]

> -Original Message-
> From: Tan, Jianfeng
> Sent: Thursday, April 26, 2018 1:33 AM
> To: Thomas Monjalon ; dev@dpdk.org
> Cc: Burakov, Anatoly ; Pattan, Reshma
> 
> Subject: RE: [PATCH] app/pdump: remove unused socket path options
> 
> 
> 
> > -Original Message-
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Wednesday, April 25, 2018 9:04 PM
> > To: dev@dpdk.org
> > Cc: Burakov, Anatoly; Pattan, Reshma; Tan, Jianfeng
> > Subject: [PATCH] app/pdump: remove unused socket path options
> >
> > The options --server-socket-path and --client-socket-path were said to
> > be deprecated and will be removed soon.
> > No need to wait for removing application options which have no effect,
> > and can confuse the user.
> >
> > Fixes: 660098d61f57 ("pdump: use generic multi-process channel")
> > Cc: jianfeng@intel.com
> >
> > Signed-off-by: Thomas Monjalon 
> 
> Reviewed-by: Jianfeng Tan 
Acked-by: Reshma Pattan 

Thanks,
Reshma

Re: [dpdk-dev] [PATCH v4] ethdev: check Rx/Tx offloads

[Zhang, Qi Z]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, April 26, 2018 1:05 AM
> To: Dai, Wei ; tho...@monjalon.net; Zhang, Qi Z
> 
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v4] ethdev: check Rx/Tx offloads
> 
> On 4/25/2018 12:50 PM, Wei Dai wrote:
> > This patch check if a requested offloading is supported in the device
> > capability.
> > Any offloading is disabled by default if it is not set in
> > rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
> > A per port offloading can only be enabled in rte_eth_dev_configure().
> > If a per port offloading is sent to rte_eth_[rt]x_queue_setup( ),
> > return error.
> > Only per queue offloading can be sent to rte_eth_[rt]x_queue_setup( ).
> > A per queue offloading is enabled only if it is enabled in
> > rte_eth_dev_configure( ) OR if it is enabled in
> > rte_eth_[rt]x_queue_setup( ).
> > If a per queue offloading is enabled in rte_eth_dev_configure(), it
> > can't be disabled in rte_eth_[rt]x_queue_setup( ).
> > If a per queue offloading is disabled in rte_eth_dev_configure( ), it
> > can be enabled or disabled( ) in rte_eth_[rt]x_queue_setup( ).
> >
> > This patch can make such checking in a common way in rte_ethdev layer
> > to avoid same checking in underlying PMD.
> 
> Hi Wei,
> 
> For clarification, there is existing API for rc1, and there is a suggested 
> update
> in API for rc2. I guess this patch is for suggested update in rc2?
> 
> > Signed-off-by: Wei Dai 
> >
> > ---
> > v4: fix a wrong description in git log message.
> >
> > v3: rework according to dicision of offloading API in community
> >
> > v2: add offloads checking in rte_eth_dev_configure( ).
> > check if a requested offloading is supported.
> > ---
> >  lib/librte_ether/rte_ethdev.c | 76
> > +++
> >  1 file changed, 76 insertions(+)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.c
> > b/lib/librte_ether/rte_ethdev.c index f0f53d4..70a7904 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -1196,6 +1196,28 @@ rte_eth_dev_configure(uint16_t port_id,
> uint16_t nb_rx_q, uint16_t nb_tx_q,
> > ETHER_MAX_LEN;
> > }
> >
> > +   /* Any requested offload must be within its device capability */
> > +   if ((local_conf.rxmode.offloads & dev_info.rx_offload_capa) !=
> > +local_conf.rxmode.offloads) {
> > +   RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Rx
> offloads "
> > +   "0x%" PRIx64 " doesn't match Rx offloads "
> > +   "capability 0x%" PRIx64 "\n",
> > +   port_id,
> > +   local_conf.rxmode.offloads,
> > +   dev_info.rx_offload_capa);
> > +   return -EINVAL;
> > +   }
> > +   if ((local_conf.txmode.offloads & dev_info.tx_offload_capa) !=
> > +local_conf.txmode.offloads) {
> > +   RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Tx
> offloads "
> > +   "0x%" PRIx64 " doesn't match Tx offloads "
> > +   "capability 0x%" PRIx64 "\n",
> > +   port_id,
> > +   local_conf.txmode.offloads,
> > +   dev_info.tx_offload_capa);
> > +   return -EINVAL;
> > +   }
> +1 having these checks here.
> 
> > +
> > /*
> >  * Setup new number of RX/TX queues and reconfigure device.
> >  */
> > @@ -1547,6 +1569,33 @@ rte_eth_rx_queue_setup(uint16_t port_id,
> uint16_t rx_queue_id,
> > &local_conf.offloads);
> > }
> >
> > +   /*
> > +* Only per-queue offload can be enabled from application.
> > +* If any pure per-port offload is sent to this function, return -EINVAL
> > +*/
> > +   if ((local_conf.offloads & dev_info.rx_queue_offload_capa) !=
> > +local_conf.offloads) {
> > +   RTE_PMD_DEBUG_TRACE("Ethdev port_id=%d rx_queue_id=%d "
> > +   "Requested offload 0x%" PRIx64 "doesn't "
> > +   "match per-queue capability 0x%" PRIx64
> > +   " in rte_eth_rx_queue_setup( )\n",
> > +   port_id,
> > +   rx_queue_id,
> > +   local_conf.offloads,
> > +   dev_info.rx_queue_offload_capa);
> > +   return -EINVAL;
> > +   }
> 
> There is a change here. If requested offload is already enabled in port level,
> instead of returning error, ignore it.
> So this removes the restriction for apps that "only an offload from queue
> capabilities can be send for queue_setup() functions". This is not
> requirement for application as it has been before, but this is allowed for app
> now.
> 
> If app tried to enable a port offload in queue level that is not already 

[dpdk-dev] [PATCH] mem: fix handling return value

[Jianfeng Tan]

resize_hugefile() returns either 0 (which indicates success) or -1
(which indicates failure). We failed to check the success as we
use --single-file-segments option.

Fixes: 2a04139f66b4 ("eal: add single file segments option")

Cc: Anatoly Burakov 

Signed-off-by: Jianfeng Tan 
---
 lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c 
b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
index 1f553dd..301c34e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
@@ -419,7 +419,7 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
if (internal_config.single_file_segments) {
map_offset = seg_idx * alloc_sz;
ret = resize_hugefile(fd, map_offset, alloc_sz, true);
-   if (ret < 1)
+   if (ret < 0)
goto resized;
} else {
map_offset = 0;
-- 
2.7.4

Re: [dpdk-dev] [PATCH] vhost: fix vDPA set features

[Maxime Coquelin]

On 04/25/2018 04:18 AM, Xiao Wang wrote:

We should call set_features callback after setting features in virtio_net
structure, otherwise vDPA driver cannot get the right features.

Fixes: 07718b4f87aa ("vhost: adapt library for selective datapath")

Signed-off-by: Xiao Wang
---
  lib/librte_vhost/vhost_user.c | 10 +-
  1 file changed, 5 insertions(+), 5 deletions(-)


Reiewed-by: Maxime Coquelin 

Thanks!
Maxime

[dpdk-dev] [PATCH v2 1/2] malloc: add biggest free IOVA-contiguous element to stats

[Anatoly Burakov]

User might be interested to find out what is the biggest chunk of
IOVA-contiguous free space that can be allocated from malloc. Add
relevant malloc-internal functions and expose this through malloc
stats calculation call.

Signed-off-by: Anatoly Burakov 
---

Notes:
v2:
- Add header to newly recalculated element start

 lib/librte_eal/common/include/rte_malloc.h |  1 +
 lib/librte_eal/common/malloc_elem.c| 59 ++
 lib/librte_eal/common/malloc_elem.h|  3 ++
 lib/librte_eal/common/malloc_heap.c|  8 
 lib/librte_eal/common/rte_malloc.c |  2 +
 5 files changed, 73 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_malloc.h 
b/lib/librte_eal/common/include/rte_malloc.h
index a9fb7e4..2553201 100644
--- a/lib/librte_eal/common/include/rte_malloc.h
+++ b/lib/librte_eal/common/include/rte_malloc.h
@@ -27,6 +27,7 @@ struct rte_malloc_socket_stats {
size_t heap_totalsz_bytes; /**< Total bytes on heap */
size_t heap_freesz_bytes;  /**< Total free bytes on heap */
size_t greatest_free_size; /**< Size in bytes of largest free block */
+   size_t greatest_free_iova_contig_size; /**< Size in bytes of largest 
IOVA-contiguous block */
unsigned free_count;   /**< Number of free elements on heap */
unsigned alloc_count;  /**< Number of allocated elements on heap */
size_t heap_allocsz_bytes; /**< Total allocated bytes on heap */
diff --git a/lib/librte_eal/common/malloc_elem.c 
b/lib/librte_eal/common/malloc_elem.c
index ee79dcd..d28ede6 100644
--- a/lib/librte_eal/common/malloc_elem.c
+++ b/lib/librte_eal/common/malloc_elem.c
@@ -18,12 +18,71 @@
 #include 
 #include 
 
+#include "eal_internal_cfg.h"
 #include "eal_memalloc.h"
 #include "malloc_elem.h"
 #include "malloc_heap.h"
 
 #define MIN_DATA_SIZE (RTE_CACHE_LINE_SIZE)
 
+size_t
+malloc_elem_find_max_iova_contig(struct malloc_elem *elem)
+{
+   void *cur_page, *contig_seg_start, *page_end, *elem_end, *cur_seg_end;
+   rte_iova_t expected_iova;
+   struct rte_memseg *ms;
+   size_t page_sz, cur, max;
+
+   /* if we're in IOVA as VA mode, or if we're in legacy mode with
+* hugepages, all elements are IOVA-contiguous.
+*/
+   if (rte_eal_iova_mode() == RTE_IOVA_VA ||
+   (internal_config.legacy_mem && rte_eal_has_hugepages()))
+   return elem->size;
+
+   page_sz = (size_t)elem->msl->page_sz;
+   elem_end = RTE_PTR_ADD(elem, elem->size);
+   cur_page = RTE_PTR_ALIGN_FLOOR(elem, page_sz);
+   ms = rte_mem_virt2memseg(cur_page, elem->msl);
+   contig_seg_start = elem;
+
+   /* do first iteration outside the loop */
+   page_end = RTE_PTR_ADD(cur_page, page_sz);
+   cur_seg_end = RTE_MIN(page_end, elem_end);
+   cur = RTE_PTR_DIFF(cur_seg_end, contig_seg_start);
+   max = cur;
+   expected_iova = ms->iova + page_sz;
+   /* memsegs are contiguous in memory */
+   ms++;
+
+   cur_page = RTE_PTR_ADD(cur_page, page_sz);
+
+   while (cur_page < elem_end) {
+   page_end = RTE_PTR_ADD(cur_page, page_sz);
+   cur_seg_end = RTE_MIN(page_end, elem_end);
+
+   /* reset start of contiguous segment if unexpected iova. this is
+* a contiguous segment, and elem->size includes header len, so
+* move element start point to where header would've started
+*/
+   if (ms->iova != expected_iova)
+   contig_seg_start = RTE_PTR_SUB(cur_page,
+   MALLOC_ELEM_HEADER_LEN);
+   cur = RTE_PTR_DIFF(cur_seg_end, contig_seg_start);
+   /* update max if cur value is bigger */
+   if (cur > max)
+   max = cur;
+
+   /* move to next page */
+   cur_page = page_end;
+   expected_iova = ms->iova + page_sz;
+   /* memsegs are contiguous in memory */
+   ms++;
+   }
+
+   return max;
+}
+
 /*
  * Initialize a general malloc_elem header structure
  */
diff --git a/lib/librte_eal/common/malloc_elem.h 
b/lib/librte_eal/common/malloc_elem.h
index 8f4aef8..19e8db5 100644
--- a/lib/librte_eal/common/malloc_elem.h
+++ b/lib/librte_eal/common/malloc_elem.h
@@ -177,4 +177,7 @@ malloc_elem_free_list_index(size_t size);
 void
 malloc_elem_free_list_insert(struct malloc_elem *elem);
 
+size_t
+malloc_elem_find_max_iova_contig(struct malloc_elem *elem);
+
 #endif /* MALLOC_ELEM_H_ */
diff --git a/lib/librte_eal/common/malloc_heap.c 
b/lib/librte_eal/common/malloc_heap.c
index 590e9e3..d8ad164 100644
--- a/lib/librte_eal/common/malloc_heap.c
+++ b/lib/librte_eal/common/malloc_heap.c
@@ -764,16 +764,24 @@ malloc_heap_get_stats(struct malloc_heap *heap,
socket_stats->free_count = 0;
socket_stats->heap_freesz_bytes = 0;
socket_stats->greatest_free_size = 0;
+   s

[dpdk-dev] [PATCH v2 2/2] memzone: allow IOVA-contiguous memzones with zero size

[Anatoly Burakov]

Previously, reserving IOVA-contiguous memzones with zero
size (which would reserve biggest available memzone) was
not allowed. Now that we can have biggest IOVA-contiguous
malloc element statistic exposed through a malloc stats
call, this now becomes possible.

Signed-off-by: Anatoly Burakov 
---

Notes:
v2:
- Fixed checkpatch warning for unsigned

 lib/librte_eal/common/eal_common_memzone.c | 19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_memzone.c 
b/lib/librte_eal/common/eal_common_memzone.c
index bce3321..9cc9961 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -57,7 +57,7 @@ memzone_lookup_thread_unsafe(const char *name)
  * specified. If no heap has been specified, it will return the heap and
  * length of the greatest free block available in all heaps */
 static size_t
-find_heap_max_free_elem(int *s, unsigned align)
+find_heap_max_free_elem(int *s, unsigned int align, bool contig)
 {
struct rte_mem_config *mcfg;
struct rte_malloc_socket_stats stats;
@@ -68,12 +68,16 @@ find_heap_max_free_elem(int *s, unsigned align)
mcfg = rte_eal_get_configuration()->mem_config;
 
for (i = 0; i < RTE_MAX_NUMA_NODES; i++) {
+   size_t found_len;
if ((socket != SOCKET_ID_ANY) && (socket != i))
continue;
 
malloc_heap_get_stats(&mcfg->malloc_heaps[i], &stats);
-   if (stats.greatest_free_size > len) {
-   len = stats.greatest_free_size;
+   found_len = contig ?
+   stats.greatest_free_iova_contig_size :
+   stats.greatest_free_size;
+   if (found_len > len) {
+   len = found_len;
*s = i;
}
}
@@ -166,16 +170,11 @@ memzone_reserve_aligned_thread_unsafe(const char *name, 
size_t len,
flags &= ~RTE_MEMZONE_IOVA_CONTIG;
 
if (len == 0) {
-   /* len == 0 is only allowed for non-contiguous zones */
-   if (contig) {
-   RTE_LOG(DEBUG, EAL, "Reserving zero-length contiguous 
memzones is not supported\n");
-   rte_errno = EINVAL;
-   return NULL;
-   }
if (bound != 0)
requested_len = bound;
else {
-   requested_len = find_heap_max_free_elem(&socket_id, 
align);
+   requested_len = find_heap_max_free_elem(&socket_id,
+   align, contig);
if (requested_len == 0) {
rte_errno = ENOMEM;
return NULL;
-- 
2.7.4

Re: [dpdk-dev] [PATCH] mem: fix handling return value

[Burakov, Anatoly]

On 26-Apr-18 9:06 AM, Jianfeng Tan wrote:

resize_hugefile() returns either 0 (which indicates success) or -1
(which indicates failure). We failed to check the success as we
use --single-file-segments option.

Fixes: 2a04139f66b4 ("eal: add single file segments option")

Cc: Anatoly Burakov 

Signed-off-by: Jianfeng Tan 
---


Acked-by: Anatoly Burakov 

--
Thanks,
Anatoly

[dpdk-dev] [PATCH] doc/vhost: update zero copy perfromance tip

[Junjie Chen]

In VM2NIC case zero copy may need some tuning to get best performance. This
patch describes the zero copy starved case and provides a tuning tip.

Signed-off-by: Junjie Chen 
---
 doc/guides/prog_guide/vhost_lib.rst | 20 
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/doc/guides/prog_guide/vhost_lib.rst 
b/doc/guides/prog_guide/vhost_lib.rst
index ef9a178..92dcdb5 100644
--- a/doc/guides/prog_guide/vhost_lib.rst
+++ b/doc/guides/prog_guide/vhost_lib.rst
@@ -65,14 +65,18 @@ The following is an overview of some key Vhost API 
functions:
 * zero copy is really good for VM2VM case. For iperf between two VMs, the
   boost could be above 70% (when TSO is enableld).
 
-* for VM2NIC case, the ``nb_tx_desc`` has to be small enough: <= 64 if 
virtio
-  indirect feature is not enabled and <= 128 if it is enabled.
-
-  This is because when dequeue zero copy is enabled, guest Tx used vring 
will
-  be updated only when corresponding mbuf is freed. Thus, the nb_tx_desc
-  has to be small enough so that the PMD driver will run out of available
-  Tx descriptors and free mbufs timely. Otherwise, guest Tx vring would be
-  starved.
+* For zero copy in VM2NIC case, guest Tx used vring may be starved if the
+  PMD driver consume the mbuf but not release them timely.
+
+  For example, i40e driver has an optimization to maximum NIC pipeline 
which
+  postpones returning transmitted mbuf until only tx_free_threshold free
+  descs left. The virtio TX used ring will be starved if the formula
+  (num_i40e_tx_desc - num_virtio_tx_desc > tx_free_threshold) is true, 
since
+  i40e will not return back mbuf.
+
+  A performance tip for tuning zero copy in VM2NIC case is to adjust the
+  frequency of mbuf free (i.e. adjust tx_free_threshold of i40e driver) to
+  balance consumer and producer.
 
 * Guest memory should be backended with huge pages to achieve better
   performance. Using 1G page size is the best.
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v4] ethdev: check Rx/Tx offloads

[Thomas Monjalon]

26/04/2018 09:59, Zhang, Qi Z:
> 
> > -Original Message-
> > From: Yigit, Ferruh
> > Sent: Thursday, April 26, 2018 1:05 AM
> > To: Dai, Wei ; tho...@monjalon.net; Zhang, Qi Z
> > 
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH v4] ethdev: check Rx/Tx offloads
> > 
> > On 4/25/2018 12:50 PM, Wei Dai wrote:
> > > This patch check if a requested offloading is supported in the device
> > > capability.
> > > Any offloading is disabled by default if it is not set in
> > > rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
> > > A per port offloading can only be enabled in rte_eth_dev_configure().
> > > If a per port offloading is sent to rte_eth_[rt]x_queue_setup( ),
> > > return error.
> > > Only per queue offloading can be sent to rte_eth_[rt]x_queue_setup( ).
> > > A per queue offloading is enabled only if it is enabled in
> > > rte_eth_dev_configure( ) OR if it is enabled in
> > > rte_eth_[rt]x_queue_setup( ).
> > > If a per queue offloading is enabled in rte_eth_dev_configure(), it
> > > can't be disabled in rte_eth_[rt]x_queue_setup( ).
> > > If a per queue offloading is disabled in rte_eth_dev_configure( ), it
> > > can be enabled or disabled( ) in rte_eth_[rt]x_queue_setup( ).
> > >
> > > This patch can make such checking in a common way in rte_ethdev layer
> > > to avoid same checking in underlying PMD.
> > 
> > Hi Wei,
> > 
> > For clarification, there is existing API for rc1, and there is a suggested 
> > update
> > in API for rc2. I guess this patch is for suggested update in rc2?
> > 
> > > Signed-off-by: Wei Dai 
> > >
> > > ---
> > > v4: fix a wrong description in git log message.
> > >
> > > v3: rework according to dicision of offloading API in community
> > >
> > > v2: add offloads checking in rte_eth_dev_configure( ).
> > > check if a requested offloading is supported.
> > > ---
> > >  lib/librte_ether/rte_ethdev.c | 76
> > > +++
> > >  1 file changed, 76 insertions(+)
> > >
> > > diff --git a/lib/librte_ether/rte_ethdev.c
> > > b/lib/librte_ether/rte_ethdev.c index f0f53d4..70a7904 100644
> > > --- a/lib/librte_ether/rte_ethdev.c
> > > +++ b/lib/librte_ether/rte_ethdev.c
> > > @@ -1196,6 +1196,28 @@ rte_eth_dev_configure(uint16_t port_id,
> > uint16_t nb_rx_q, uint16_t nb_tx_q,
> > >   ETHER_MAX_LEN;
> > >   }
> > >
> > > + /* Any requested offload must be within its device capability */
> > > + if ((local_conf.rxmode.offloads & dev_info.rx_offload_capa) !=
> > > +  local_conf.rxmode.offloads) {
> > > + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Rx
> > offloads "
> > > + "0x%" PRIx64 " doesn't match Rx offloads "
> > > + "capability 0x%" PRIx64 "\n",
> > > + port_id,
> > > + local_conf.rxmode.offloads,
> > > + dev_info.rx_offload_capa);
> > > + return -EINVAL;
> > > + }
> > > + if ((local_conf.txmode.offloads & dev_info.tx_offload_capa) !=
> > > +  local_conf.txmode.offloads) {
> > > + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Tx
> > offloads "
> > > + "0x%" PRIx64 " doesn't match Tx offloads "
> > > + "capability 0x%" PRIx64 "\n",
> > > + port_id,
> > > + local_conf.txmode.offloads,
> > > + dev_info.tx_offload_capa);
> > > + return -EINVAL;
> > > + }
> > +1 having these checks here.
> > 
> > > +
> > >   /*
> > >* Setup new number of RX/TX queues and reconfigure device.
> > >*/
> > > @@ -1547,6 +1569,33 @@ rte_eth_rx_queue_setup(uint16_t port_id,
> > uint16_t rx_queue_id,
> > >   &local_conf.offloads);
> > >   }
> > >
> > > + /*
> > > +  * Only per-queue offload can be enabled from application.
> > > +  * If any pure per-port offload is sent to this function, return -EINVAL
> > > +  */
> > > + if ((local_conf.offloads & dev_info.rx_queue_offload_capa) !=
> > > +  local_conf.offloads) {
> > > + RTE_PMD_DEBUG_TRACE("Ethdev port_id=%d rx_queue_id=%d "
> > > + "Requested offload 0x%" PRIx64 "doesn't "
> > > + "match per-queue capability 0x%" PRIx64
> > > + " in rte_eth_rx_queue_setup( )\n",
> > > + port_id,
> > > + rx_queue_id,
> > > + local_conf.offloads,
> > > + dev_info.rx_queue_offload_capa);
> > > + return -EINVAL;
> > > + }
> > 
> > There is a change here. If requested offload is already enabled in port 
> > level,
> > instead of returning error, ignore it.
> > So this removes the restriction for apps that "only an offload from queue
> > capabilities can be send for queue_setup() functions". This i

Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

[Olivier Matz]

Le 25 avril 2018 17:52:00 GMT+02:00, Pavan Nikhilesh 
 a écrit :
>On Mon, Apr 23, 2018 at 11:00:09AM +0200, Olivier Matz wrote:
>> On Fri, Apr 20, 2018 at 12:21:59AM +0530, Pavan Nikhilesh wrote:
>> > Signed-off-by: Pavan Nikhilesh 
>> > ---
>> >  drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 -
>> >  drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++--
>> >  drivers/bus/dpaa/base/qbman/qman.c| 2 +-
>> >  drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++--
>> >  drivers/bus/dpaa/base/qbman/qman_priv.h   | 1 -
>> >  drivers/bus/dpaa/dpaa_bus.c   | 2 +-
>> >  drivers/bus/fslmc/qbman/qbman_portal.c| 3 +--
>> >  drivers/bus/fslmc/qbman/qbman_portal.h| 1 -
>> >  drivers/net/i40e/i40e_flow.c  | 2 +-
>> >  drivers/net/qede/base/bcm_osal.c  | 2 +-
>> >  drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 2 +-
>> >  lib/librte_net/net_crc_neon.h | 4 ++--
>> >  12 files changed, 12 insertions(+), 20 deletions(-)
>>
>> [...]
>>
>> > diff --git a/lib/librte_net/net_crc_neon.h
>b/lib/librte_net/net_crc_neon.h
>> > index 63fa1d4a1..cb3da72ed 100644
>> > --- a/lib/librte_net/net_crc_neon.h
>> > +++ b/lib/librte_net/net_crc_neon.h
>> > @@ -21,8 +21,8 @@ struct crc_pmull_ctx {
>> >uint64x2_t rk7_rk8;
>> >  };
>> >
>> > -struct crc_pmull_ctx crc32_eth_pmull __rte_aligned(16);
>> > -struct crc_pmull_ctx crc16_ccitt_pmull __rte_aligned(16);
>> > +static struct crc_pmull_ctx crc32_eth_pmull __rte_aligned(16);
>> > +static struct crc_pmull_ctx crc16_ccitt_pmull __rte_aligned(16);
>> >
>> >  /**
>>
>> Not sure it will still work after that.
>>
>> From what I see, these global variables are initialized once in
>> rte_net_crc_neon_init, and used as a const parameter in
>> crc32_eth_calc_pmull().
>>
>> Changing them to static will create an instance of these variables
>for
>> each included file, which is not what we want.
>>
>> I think that the proper way to solve it would be to add the
>definition
>> in a new .c file, and only have a declaration in the .h.
>>
>>
>Hi Olivier,
>
>Thanks for the heads up, the second solution seems more viable and
>while
>implementing it I faced few Issues. GCC doesnt suport const vector
>instructions
>i.e. the following assignment throw as compiler error.
>
>   static const struct crc_pmull_ctx crc32_eth_pmull = {
>   .rk1_rk2 = vld1q_u64((uint64_t[2]){0xccaa009eLLU, 
> 0x1751997d0LLU}),
>   .rk5_rk6 = vld1q_u64((uint64_t[2]){0xccaa009eLLU, 
> 0x163cd6124LLU}),
>   .rk7_rk8 = vld1q_u64((uint64_t[2]){0x1f7011640LLU, 
> 0x1db710641LLU}),
>   } __rte_aligned(16);
>
>I have gotten path the error by modifying struct crc_pmull_ctx as
>follows:
>
>   struct crc_pmull_ctx {
>   union {
>   uint64_t rk12[2];
>   uint64x2_t rk1_rk2;
>   };
>   union {
>   uint64_t rk56[2];
>   uint64x2_t rk5_rk6;
>   };
>   union {
>   uint64_t rk78[2];
>   uint64x2_t rk7_rk8;
>   };
>   };
>
>   static const struct crc_pmull_ctx crc32_eth_pmull __rte_aligned(16) =
>{
>   .rk12 = {0xccaa009eLLU, 0x1751997d0LLU},
>   .rk56 = {0xccaa009eLLU, 0x163cd6124LLU},
>   .rk78 = {0x1f7011640LLU, 0x1db710641LLU},
>   };
>
>   static const struct crc_pmull_ctx crc16_ccitt_pmull __rte_aligned(16)
>= {
>   .rk12 = {0x189aeLLU, 0x8e10LLU},
>   .rk56 = {0x189aeLLU, 0x114aaLLU},
>   .rk78 = {0x11c581910LLU, 0x10811LLU},
>   };
>
>I have checked the hex dump of the assignment with the current code and
>the
>above piece of code and they are similar.
>
>Let me know if my solution seems viable I will send the v2.
>

Looks good, just wondering about possible endianness issues. Is arm 
architecture supported with both little and big endian in dpdk ?


>> An even better way would be to make variable const and initialize it
>> with its content. It could even enhance performance. Something like:
>>
>> net_crc_neon.h:
>>
>> static const struct crc_pmull_ctx crc32_eth_pmull = {
>>   
>> } __rte_aligned(16);
>>
>> static const struct crc_pmull_ctx crc16_ccitt_pmull = {
>>   
>> } __rte_aligned(16);
>>
>
>Thanks,
>Pavan.

Re: [dpdk-dev] [PATCH v4] ethdev: check Rx/Tx offloads

[Zhang, Qi Z]

> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, April 26, 2018 4:19 PM
> To: Zhang, Qi Z 
> Cc: Yigit, Ferruh ; Dai, Wei ;
> dev@dpdk.org
> Subject: Re: [PATCH v4] ethdev: check Rx/Tx offloads
> 
> 26/04/2018 09:59, Zhang, Qi Z:
> >
> > > -Original Message-
> > > From: Yigit, Ferruh
> > > Sent: Thursday, April 26, 2018 1:05 AM
> > > To: Dai, Wei ; tho...@monjalon.net; Zhang, Qi Z
> > > 
> > > Cc: dev@dpdk.org
> > > Subject: Re: [PATCH v4] ethdev: check Rx/Tx offloads
> > >
> > > On 4/25/2018 12:50 PM, Wei Dai wrote:
> > > > This patch check if a requested offloading is supported in the
> > > > device capability.
> > > > Any offloading is disabled by default if it is not set in
> > > > rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
> > > > A per port offloading can only be enabled in rte_eth_dev_configure().
> > > > If a per port offloading is sent to rte_eth_[rt]x_queue_setup( ),
> > > > return error.
> > > > Only per queue offloading can be sent to rte_eth_[rt]x_queue_setup( ).
> > > > A per queue offloading is enabled only if it is enabled in
> > > > rte_eth_dev_configure( ) OR if it is enabled in
> > > > rte_eth_[rt]x_queue_setup( ).
> > > > If a per queue offloading is enabled in rte_eth_dev_configure(),
> > > > it can't be disabled in rte_eth_[rt]x_queue_setup( ).
> > > > If a per queue offloading is disabled in rte_eth_dev_configure( ),
> > > > it can be enabled or disabled( ) in rte_eth_[rt]x_queue_setup( ).
> > > >
> > > > This patch can make such checking in a common way in rte_ethdev
> > > > layer to avoid same checking in underlying PMD.
> > >
> > > Hi Wei,
> > >
> > > For clarification, there is existing API for rc1, and there is a
> > > suggested update in API for rc2. I guess this patch is for suggested 
> > > update
> in rc2?
> > >
> > > > Signed-off-by: Wei Dai 
> > > >
> > > > ---
> > > > v4: fix a wrong description in git log message.
> > > >
> > > > v3: rework according to dicision of offloading API in community
> > > >
> > > > v2: add offloads checking in rte_eth_dev_configure( ).
> > > > check if a requested offloading is supported.
> > > > ---
> > > >  lib/librte_ether/rte_ethdev.c | 76
> > > > +++
> > > >  1 file changed, 76 insertions(+)
> > > >
> > > > diff --git a/lib/librte_ether/rte_ethdev.c
> > > > b/lib/librte_ether/rte_ethdev.c index f0f53d4..70a7904 100644
> > > > --- a/lib/librte_ether/rte_ethdev.c
> > > > +++ b/lib/librte_ether/rte_ethdev.c
> > > > @@ -1196,6 +1196,28 @@ rte_eth_dev_configure(uint16_t port_id,
> > > uint16_t nb_rx_q, uint16_t nb_tx_q,
> > > > ETHER_MAX_LEN;
> > > > }
> > > >
> > > > +   /* Any requested offload must be within its device capability */
> > > > +   if ((local_conf.rxmode.offloads & dev_info.rx_offload_capa) !=
> > > > +local_conf.rxmode.offloads) {
> > > > +   RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Rx
> > > offloads "
> > > > +   "0x%" PRIx64 " doesn't match Rx 
> > > > offloads "
> > > > +   "capability 0x%" PRIx64 "\n",
> > > > +   port_id,
> > > > +   local_conf.rxmode.offloads,
> > > > +   dev_info.rx_offload_capa);
> > > > +   return -EINVAL;
> > > > +   }
> > > > +   if ((local_conf.txmode.offloads & dev_info.tx_offload_capa) !=
> > > > +local_conf.txmode.offloads) {
> > > > +   RTE_PMD_DEBUG_TRACE("ethdev port_id=%d requested Tx
> > > offloads "
> > > > +   "0x%" PRIx64 " doesn't match Tx 
> > > > offloads "
> > > > +   "capability 0x%" PRIx64 "\n",
> > > > +   port_id,
> > > > +   local_conf.txmode.offloads,
> > > > +   dev_info.tx_offload_capa);
> > > > +   return -EINVAL;
> > > > +   }
> > > +1 having these checks here.
> > >
> > > > +
> > > > /*
> > > >  * Setup new number of RX/TX queues and reconfigure device.
> > > >  */
> > > > @@ -1547,6 +1569,33 @@ rte_eth_rx_queue_setup(uint16_t port_id,
> > > uint16_t rx_queue_id,
> > > > 
> > > > &local_conf.offloads);
> > > > }
> > > >
> > > > +   /*
> > > > +* Only per-queue offload can be enabled from application.
> > > > +* If any pure per-port offload is sent to this function, return
> -EINVAL
> > > > +*/
> > > > +   if ((local_conf.offloads & dev_info.rx_queue_offload_capa) !=
> > > > +local_conf.offloads) {
> > > > +   RTE_PMD_DEBUG_TRACE("Ethdev port_id=%d
> rx_queue_id=%d "
> > > > +   "Requested offload 0x%" PRIx64 
> >

[dpdk-dev] [PATCH] app/crypto-perf: fix pmd_cyclecount_bench_ops

[Tomasz Jozwiak]

this patch fixes segmentation fault in pmd_cyclecount_bench_ops
function in case when state->opts->nb_descriptors is not
natural multiple of burst size.
To reproduce run: dpdk-test-crypto-perf with params:
  --ptest pmd-cyclecount --pmd-cyclecount-delay-ms 5
  --devtype crypto_qat --optype cipher-then-auth
  --cipher-algo aes-cbc --cipher-op encrypt
  --cipher-key-sz 16 --cipher-iv-sz 16
  --auth-algo sha2-256-hmac
  --auth-op generate --auth-key-sz 64 --digest-sz 32
  --total-ops 1 --burst-sz 255 --buffer-sz 1024 --silent

Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode")
Cc: Anatoly Burakov 
Cc: sta...@dpdk.org

Signed-off-by: Tomasz Jozwiak 
---
 app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c 
b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
index 8f76160..c8d16db 100644
--- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
+++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
@@ -145,7 +145,7 @@ pmd_cyclecount_bench_ops(struct pmd_cyclecount_state 
*state, uint32_t cur_op,
 
for (cur_iter_op = 0; cur_iter_op < iter_ops_needed;
cur_iter_op += test_burst_size) {
-   uint32_t burst_size = RTE_MIN(state->opts->total_ops - cur_op,
+   uint32_t burst_size = RTE_MIN(iter_ops_needed - cur_iter_op,
test_burst_size);
struct rte_crypto_op **ops = &state->ctx->ops[cur_iter_op];
 
-- 
2.7.4

[dpdk-dev] [PATCH v6 0/5] Introduce Intel FPGA BUS

[Xu, Rosen]

From: "Xu, Rosen" 

Intel FPGA BUS in DPDK
-

This patch set introduces Intel FPGA BUS support in DPDK.

v6 updates:
===
 - Add documentation
 - Add meson build script
 - Split new patch for OPAE share code

v5 updates:
===
 - Fixed SHARED LIB Build issue
 - Changed command name to IFPGA Rawdev name,
   so remove pci library datastruct and function.
 - Fixed PATCH v2/v3/v4 comments
 
v4 updates:
===
 - Remove all modifications from eal
 - Create vdev to take IFPGA parameters configuration
 - AFU Device Driver bind to AFU Device by uuid
 - Take more test in scenario of Multi-FPGA System
 
v3 updates:
===
 - Remove all modifications of bus scan and probe
 - FPGA BUS Scan is trigged by hotplug of Rawdev
 - Took Modifications of comments
 - Move AFU Device to IFPGA
 - FPGA BUS Scan depend on its IFPGA Rawdev
 - Add Build Macros for FPGA BUS and IFPGA Rawdev

Questions
=
Why not PCI Bus?
All of the AFUs of one FPGA may share same PCI BDF.
Why not vdev Bus?
Because AFUs depend on Rawdev, and it's hardware specpic.

Motivation
==
FPGA is used more and more widely in Cloud and NFV, one primary reason is
that FPGA not only provide ASIC performance but also it's more flexible 
than ASIC. FPGA use Partial Reconfigure(PR) Parts of Bitstream to achieve 
its flexibility. Another reason is that one FPGA can be shared 
by different Users, and each User can use some of AFUs of One FPGA.

That means One FPGA Device Bitstream is divided into many Parts of 
Bitstream(each Part of Bitstream is defined as AFU-Accelerated 
Function Unit), and each AFU is a Hardware Acceleration Unit and 
it can dynamically Reload respectively.

Proposed Solution
=
 - Involve Rawdev to take FPGA Partial Configuration(Download/PR)
 - Defined FPGA-BUS for Acceleration Drivers of AFUs
   - FPGA PCI Scan(1st Scan) follows DPDK UIO/VFIO PCI Scan Process, 
 probe Intel FPGA Rawdev Driver. FPGA-BUS scan is called, but AFU
 depend on Rawdev, so this scan doesn't trig AFU device create.
   - AFU Scan(2nd Scan) bind DPDK Driver to FPGA Partial-Bitstream.
 This scan is trigged by hotplug of IFPGA Rawdev probe, in this
 scan the AFUs will be created and their dirves are also probed.

Scope
=
The Intel FPGA BUS implementation is target towards various FPGA Devices 
use PR to provide many Acceleration Function. Specific PMDs may also 
bind to its AFU. And Applications don't care they are using ASIC 
Acceleration or FPGA AFU Acceleration.


Status
=
With integrating Intel PSG FPGA Software Stack OPAE(Open Programmable 
Acceleration Engine) Share Code, Intel FPGA BUS runs well in 
Intel PSG FPGA Cards.

Figo Zhang (2):
  iFPGA: add meson build
  iFPGA: add document for iFPGA driver

Rosen Xu (3):
  iFPGA: Add Intel FPGA BUS Library
  iFPGA: Add Intel FPGA OPAE Share Code
  iFPGA: Add Intel FPGA BUS Rawdev Driver

 config/common_base |6 +
 doc/guides/index.rst   |1 +
 doc/guides/rawdevs/ifpga_rawdev.rst|  112 ++
 doc/guides/rawdevs/index.rst   |   11 +
 doc/guides/rel_notes/release_18_05.rst |   13 +
 drivers/bus/Makefile   |1 +
 drivers/bus/ifpga/Makefile |   32 +
 drivers/bus/ifpga/ifpga_bus.c  |  503 ++
 drivers/bus/ifpga/ifpga_common.c   |   88 ++
 drivers/bus/ifpga/ifpga_common.h   |   18 +
 drivers/bus/ifpga/ifpga_logs.h |   31 +
 drivers/bus/ifpga/meson.build  |6 +
 drivers/bus/ifpga/rte_bus_ifpga.h  |  168 ++
 drivers/bus/ifpga/rte_bus_ifpga_version.map|   10 +
 drivers/bus/meson.build|2 +-
 drivers/meson.build|3 +-
 drivers/raw/Makefile   |1 +
 drivers/raw/ifpga_rawdev/Makefile  |   36 +
 drivers/raw/ifpga_rawdev/base/Makefile |   26 +
 drivers/raw/ifpga_rawdev/base/README   |   31 +
 drivers/raw/ifpga_rawdev/base/ifpga_api.c  |  294 
 drivers/raw/ifpga_rawdev/base/ifpga_api.h  |   28 +
 drivers/raw/ifpga_rawdev/base/ifpga_compat.h   |   57 +
 drivers/raw/ifpga_rawdev/base/ifpga_defines.h  | 1661 
 drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c|  824 ++
 drivers/raw/ifpga_rawdev/base/ifpga_enumerate.h|   11 +
 drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c  |  314 
 drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h  |  164 ++
 drivers/raw/ifpga_rawdev/base/ifpga_fme.c  |  734 +
 drivers/raw/ifpga_rawdev/base/ifpga_fme_dperf.c|  301 
 drivers/raw/ifpga_rawdev/base/ifpga_fme_error.c|  403 +
 drivers/raw/ifpga_rawdev/base/ifpga_fme_iperf.c|  715 +
 drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c   |  

[dpdk-dev] [PATCH v6 1/5] iFPGA: Add Intel FPGA BUS Library

[Xu, Rosen]

From: Rosen Xu 

Defined FPGA-BUS for Acceleration Drivers of AFUs
1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process,
probe Intel FPGA Rawdev Driver.
2. AFU Scan(2nd Scan) bind DPDK driver to FPGA Partial-Bitstream.
This scan is trigged by hotplug of IFPGA Rawdev probe, in this scan
the AFUs will be created and their drivers are also probed.

Signed-off-by: Rosen Xu 
Signed-off-by: Figo zhang 
---
 config/common_base  |   5 +
 drivers/bus/Makefile|   1 +
 drivers/bus/ifpga/Makefile  |  32 ++
 drivers/bus/ifpga/ifpga_bus.c   | 503 
 drivers/bus/ifpga/ifpga_common.c|  88 +
 drivers/bus/ifpga/ifpga_common.h|  18 +
 drivers/bus/ifpga/ifpga_logs.h  |  31 ++
 drivers/bus/ifpga/meson.build   |   6 +
 drivers/bus/ifpga/rte_bus_ifpga.h   | 168 ++
 drivers/bus/ifpga/rte_bus_ifpga_version.map |  10 +
 drivers/bus/meson.build |   2 +-
 mk/rte.app.mk   |   2 +
 12 files changed, 865 insertions(+), 1 deletion(-)
 create mode 100644 drivers/bus/ifpga/Makefile
 create mode 100644 drivers/bus/ifpga/ifpga_bus.c
 create mode 100644 drivers/bus/ifpga/ifpga_common.c
 create mode 100644 drivers/bus/ifpga/ifpga_common.h
 create mode 100644 drivers/bus/ifpga/ifpga_logs.h
 create mode 100644 drivers/bus/ifpga/meson.build
 create mode 100644 drivers/bus/ifpga/rte_bus_ifpga.h
 create mode 100644 drivers/bus/ifpga/rte_bus_ifpga_version.map

diff --git a/config/common_base b/config/common_base
index 7e45412..b59f1de 100644
--- a/config/common_base
+++ b/config/common_base
@@ -148,6 +148,11 @@ CONFIG_RTE_LIBRTE_PCI_BUS=y
 CONFIG_RTE_LIBRTE_VDEV_BUS=y
 
 #
+# Compile the Intel FPGA bus
+#
+CONFIG_RTE_LIBRTE_IFPGA_BUS=y
+
+#
 # Compile ARK PMD
 #
 CONFIG_RTE_LIBRTE_ARK_PMD=y
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index c251b65..cff3567 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -9,5 +9,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
 endif
 DIRS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += pci
 DIRS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += vdev
+DIRS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) += ifpga
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/bus/ifpga/Makefile b/drivers/bus/ifpga/Makefile
new file mode 100644
index 000..3ff3bdb
--- /dev/null
+++ b/drivers/bus/ifpga/Makefile
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_bus_ifpga.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_rawdev
+LDLIBS += -lrte_kvargs
+
+# versioning export map
+EXPORT_MAP := rte_bus_ifpga_version.map
+
+# library version
+LIBABIVER := 1
+
+SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) += ifpga_bus.c
+SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) += ifpga_common.c
+
+#
+# Export include files
+#
+SYMLINK-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)-include += rte_bus_ifpga.h
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
new file mode 100644
index 000..67c24ae
--- /dev/null
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -0,0 +1,503 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include "rte_rawdev.h"
+#include "rte_rawdev_pmd.h"
+#include "rte_bus_ifpga.h"
+#include "ifpga_logs.h"
+#include "ifpga_common.h"
+
+int ifpga_bus_logtype;
+
+/* Forward declare to access Intel FPGA bus name */
+static struct rte_bus rte_ifpga_bus;
+
+/** Double linked list of IFPGA device. */
+TAILQ_HEAD(ifpga_device_list, rte_ifpga_device);
+
+static struct ifpga_device_list ifpga_device_list =
+   TAILQ_HEAD_INITIALIZER(ifpga_device_list);
+struct afu_driver_list afu_driver_list =
+   TAILQ_HEAD_INITIALIZER(afu_driver_list);
+
+
+/* register a ifpga bus based driver */
+void rte_ifpga_driver_register(struct rte_afu_driver *driver)
+{
+   RTE_VERIFY(driver);
+
+   TAILQ_INSERT_TAIL(&afu_driver_list, driver, next);
+}
+
+/* un-register a fpga bus based driver */
+void rte_ifpga_driver_unregister(struct rte_afu_driver *driver)
+{
+   TAILQ_REMOVE(&afu_driver_list, driver, next);
+}
+
+static struct rte_ifpga_device *
+ifpga_find_ifpga_dev(const struct rte_rawdev *rdev)
+{
+   struct rte_ifpga_device *ifpga_dev = NULL;
+
+   TAILQ_FOREACH(ifpga_dev, &ifpga_device_list, next) {
+   if (rdev &&
+   ifpga_dev->rdev &&
+   ifpga_dev->rdev == rdev)
+   return ifpga_dev;
+   }
+   return NULL;
+}
+
+static struct rte_afu_device *
+ifpga

[dpdk-dev] [PATCH v6 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver

[Xu, Rosen]

From: Rosen Xu 

Add Intel FPGA BUS Rawdev Driver which is based on
librte_rawdev library.

Signed-off-by: Rosen Xu 
Signed-off-by: Yanglong Wu 
Signed-off-by: Figo zhang 
---
 config/common_base |   1 +
 drivers/raw/Makefile   |   1 +
 drivers/raw/ifpga_rawdev/Makefile  |  36 ++
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 597 +
 drivers/raw/ifpga_rawdev/ifpga_rawdev.h|  37 ++
 .../raw/ifpga_rawdev/rte_ifpga_rawdev_version.map  |   4 +
 mk/rte.app.mk  |   1 +
 7 files changed, 677 insertions(+)
 create mode 100644 drivers/raw/ifpga_rawdev/Makefile
 create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.c
 create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.h
 create mode 100644 drivers/raw/ifpga_rawdev/rte_ifpga_rawdev_version.map

diff --git a/config/common_base b/config/common_base
index b59f1de..13fce00 100644
--- a/config/common_base
+++ b/config/common_base
@@ -151,6 +151,7 @@ CONFIG_RTE_LIBRTE_VDEV_BUS=y
 # Compile the Intel FPGA bus
 #
 CONFIG_RTE_LIBRTE_IFPGA_BUS=y
+CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
 
 #
 # Compile ARK PMD
diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
index da7c8b4..6fc8f2f 100644
--- a/drivers/raw/Makefile
+++ b/drivers/raw/Makefile
@@ -5,5 +5,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 
 # DIRS-$() += 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += skeleton_rawdev
+DIRS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/raw/ifpga_rawdev/Makefile 
b/drivers/raw/ifpga_rawdev/Makefile
new file mode 100644
index 000..66e2e34
--- /dev/null
+++ b/drivers/raw/ifpga_rawdev/Makefile
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_ifpga_rawdev.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga
+CFLAGS += -I$(RTE_SDK)/drivers/raw/ifpga_rawdev
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_rawdev
+LDLIBS += -lrte_bus_vdev
+LDLIBS += -lrte_kvargs
+LDLIBS += -lrte_bus_pci
+LDLIBS += -lrte_bus_ifpga
+
+EXPORT_MAP := rte_ifpga_rawdev_version.map
+
+LIBABIVER := 1
+
+VPATH += $(SRCDIR)/base
+
+include $(RTE_SDK)/drivers/raw/ifpga_rawdev/base/Makefile
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c 
b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
new file mode 100644
index 000..71a41b9
--- /dev/null
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -0,0 +1,597 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "base/opae_hw_api.h"
+#include "rte_rawdev.h"
+#include "rte_rawdev_pmd.h"
+#include "rte_bus_ifpga.h"
+#include "ifpga_common.h"
+#include "ifpga_logs.h"
+#include "ifpga_rawdev.h"
+
+int ifpga_rawdev_logtype;
+
+#define PCI_VENDOR_ID_INTEL  0x8086
+/* PCI Device ID */
+#define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
+#define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
+#define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
+/* VF Device */
+#define PCIE_DEVICE_ID_VF_INT_5_X0xBCBF
+#define PCIE_DEVICE_ID_VF_INT_6_X0xBCC1
+#define PCIE_DEVICE_ID_VF_DSC_1_X0x09C5
+#define RTE_MAX_RAW_DEVICE   10
+
+static const struct rte_pci_id pci_ifpga_map[] = {
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_INT_5_X) },
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_INT_5_X) },
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_INT_6_X) },
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_INT_6_X) },
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_DSC_1_X) },
+   { RTE_PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_DSC_1_X) },
+   { .vendor_id = 0, /* sentinel */ },
+};
+
+static int ifpga_fill_afu_dev(struct opae_accelerator *acc,
+   struct rte_afu_device *afu_dev)
+{
+   struct rte_mem_resource *res = afu_dev->mem_resource;
+   struct opae_acc_region_info region_info;
+   struct opae_acc_info info;
+   unsigned long i;
+   int ret;
+
+   ret = opae_acc_get_info(acc, &info);
+   if (ret)
+   return ret;
+
+   if (info.num_regions > PCI_MAX_RESOURCE)
+   return -EFAULT;
+
+   afu_dev->num_region = info.num_regions;
+
+   for (i = 0; i < info.num_regions; i++) {
+   region_info.index = i;
+   ret = opae_acc_get_region_info(acc, ®ion_info);
+   if (r

[dpdk-dev] [PATCH v6 5/5] iFPGA: add document for iFPGA driver

[Xu, Rosen]

From: Rosen Xu 

add some introduction, motivation and usage for iFPGA driver.

Signed-off-by: Rosen Xu 
Signed-off-by: Figo Zhang 
---
 doc/guides/index.rst   |   1 +
 doc/guides/rawdevs/ifpga_rawdev.rst| 112 +
 doc/guides/rawdevs/index.rst   |  11 
 doc/guides/rel_notes/release_18_05.rst |  13 
 4 files changed, 137 insertions(+)
 create mode 100644 doc/guides/rawdevs/ifpga_rawdev.rst
 create mode 100644 doc/guides/rawdevs/index.rst

diff --git a/doc/guides/index.rst b/doc/guides/index.rst
index d60529d..a93baac 100644
--- a/doc/guides/index.rst
+++ b/doc/guides/index.rst
@@ -20,6 +20,7 @@ DPDK documentation
eventdevs/index
mempool/index
platform/index
+   rawdevs/index
contributing/index
rel_notes/index
faq/index
diff --git a/doc/guides/rawdevs/ifpga_rawdev.rst 
b/doc/guides/rawdevs/ifpga_rawdev.rst
new file mode 100644
index 000..3311586
--- /dev/null
+++ b/doc/guides/rawdevs/ifpga_rawdev.rst
@@ -0,0 +1,112 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Intel Corporation.
+
+IFPGA Rawdev Driver
+==
+
+FPGA is used more and more widely in Cloud and NFV, one primary reason is
+that FPGA not only provides ASIC performance but also it's more flexible
+than ASIC.
+
+FPGA uses Partial Reconfigure(PR) Parts of Bit Stream to achieve its
+flexibility. That means one FPGA Device Bit Stream is divided into many Parts
+of Bit Stream(each Part of Bit Stream is defined as AFU-Accelerated Function
+Unit), and each AFU is a hardware acceleration unit which can be dynamically
+reloaded respectively.
+
+By PR(Partial Reconfiguration) AFUs, one FPGA resources can be time-shared by
+different users. FPGA hot upgraded and fault tolerance can be provided easily.
+
+The SW IFPGA Rawdev Driver (**ifpga_rawdev**) provides a Rawdev driver
+that utilizes Intel FPGA Software Stack OPAE(Open Programmable Acceleration
+Engine) for FPGA management.
+
+Implementation details
+--
+
+Each instance of IFPGA Rawdev Driver is probed by Intel FpgaDev. Cooperated
+with OPAE share code IFPGA Rawdev Driver provides common FPGA management ops
+for FPGA operation, OPAE provides all following operations:
+- FPGA PR(Partial Reconfiguration) management
+- FPGA AFUs Identifying
+- FPGA Thermal Management
+- FPGA Power Management
+- FPGA Performance reporting
+- FPGA Remote Debug
+
+All configuration parameters is taken by vdev_ifpga_cfg driver. Besides
+configuration, vdev_ifpga_cfg driver also hot plugin AFUs in IFPGA Bus.
+
+All of the AFUs of one FPGA may share same PCI BDF and AFUs scan depend on
+IFPGA Rawdev Driver so IFPGA Bus takes AFU device scan and AFU drivers probe.
+All AFU device driver bind to AFU device by its UUID(Universally Unique
+Identifier).
+
+To avoid unnecessary code duplication and ensure maximum performance,
+handling of AFU devices is left to different PMDs; all the design as
+summarized by the following block diagram::
+
+ +---+
+ |   Application(s)  |
+ +.--+
+  |
+  |
+ +'--+
+ |DPDK Framework (APIs)  |
+ +--||.-|+
+   /  \ |
+  /\|
+ +---'---+  +---'---+  +'+
+ |Eth PMD|  |   Crypto PMD  |  | |
+ +---.---+  +---.---+  | |
+ |  |  | |
+ |  |  | |
+ +---'---+  +---'---+  |  IFPGA  |
+ |  Eth AFU Dev  |  |Crypto AFU Dev |  |  Rawdev Driver  |
+ +---.---+  +---.---+  |(OPAE Share Code)|
+ |  |  | |
+ |  |  Rawdev  | |
+ +---'--'---+Ops   | |
+ |  IFPGA Bus   | >| |
+ +-.+  +.+
+   ||
+ Hot-plugin -->||
+   ||
+ +-'--++'+
+ |vdev_ifpga_cfg driver   ||  Intel FpgaDev  |
+ +++-+
+
+Build 

[dpdk-dev] [PATCH v6 4/5] iFPGA: add meson build

[Xu, Rosen]

From: Figo Zhang 

add meson build support for iFPGA driver.

Signed-off-by: Figo Zhang 
---
 drivers/meson.build   |  3 ++-
 drivers/raw/ifpga_rawdev/base/meson.build | 34 +++
 drivers/raw/ifpga_rawdev/meson.build  | 13 
 drivers/raw/meson.build   |  6 ++
 4 files changed, 55 insertions(+), 1 deletion(-)
 create mode 100644 drivers/raw/ifpga_rawdev/base/meson.build
 create mode 100644 drivers/raw/ifpga_rawdev/meson.build
 create mode 100644 drivers/raw/meson.build

diff --git a/drivers/meson.build b/drivers/meson.build
index b146f09..b7fc0d6 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -7,7 +7,8 @@ driver_classes = ['common',
   'mempool', # depends on common and bus.
   'net', # depends on common, bus and mempool.
   'crypto',  # depends on common, bus and mempool (net in future).
-  'event']   # depends on common, bus, mempool and net.
+  'event',   # depends on common, bus, mempool and net.
+   'raw']
 
 foreach class:driver_classes
drivers = []
diff --git a/drivers/raw/ifpga_rawdev/base/meson.build 
b/drivers/raw/ifpga_rawdev/base/meson.build
new file mode 100644
index 000..cb65535
--- /dev/null
+++ b/drivers/raw/ifpga_rawdev/base/meson.build
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+sources = [
+   'ifpga_api.c',
+   'ifpga_enumerate.c',
+   'ifpga_feature_dev.c',
+   'ifpga_fme.c',
+   'ifpga_fme_iperf.c',
+   'ifpga_fme_dperf.c',
+   'ifpga_fme_error.c',
+   'ifpga_port.c',
+   'ifpga_port_error.c',
+   'ifpga_fme_pr.c',
+   'opae_hw_api.c',
+   'opae_ifpga_hw_api.c',
+   'opae_debug.c'
+]
+
+error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
+   '-Wno-format', '-Wno-unused-but-set-variable',
+   '-Wno-strict-aliasing'
+]
+c_args = cflags
+foreach flag: error_cflags
+   if cc.has_argument(flag)
+   c_args += flag
+   endif
+endforeach
+
+base_lib = static_library('ifpga_rawdev_base', sources,
+   dependencies: static_rte_eal,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/raw/ifpga_rawdev/meson.build 
b/drivers/raw/ifpga_rawdev/meson.build
new file mode 100644
index 000..37896af
--- /dev/null
+++ b/drivers/raw/ifpga_rawdev/meson.build
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+version = 1
+
+subdir('base')
+objs = [base_objs]
+
+deps += ['rawdev', 'pci', 'bus_pci', 'kvargs',
+   'bus_vdev', 'bus_ifpga']
+sources = files('ifpga_rawdev.c')
+
+includes += include_directories('base')
diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build
new file mode 100644
index 000..410f908
--- /dev/null
+++ b/drivers/raw/meson.build
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Intel Corporation
+
+drivers = ['ifpga_rawdev']
+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
+driver_name_fmt = 'rte_@0@'
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose

[Ferruh Yigit]

On 4/26/2018 1:16 AM, Zhang, Qi Z wrote:
> 
> 
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Wednesday, April 25, 2018 10:15 PM
>> To: Lu, Wenzhuo ; Wu, Jingjing
>> 
>> Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z
>> 
>> Subject: [PATCH] app/testpmd: update start log to be less verbose
>>
>> A per port per queue log is too verbose with multiple port/queue log is
>> longer than full screen, make it less verbose:
>> - Reduced log to only first queue of the port, as a sample
>> - Merged a few lines
>> - Indent queue logs for readability
>>
>> The log becomes as following after update:
>>
>> testpmd> start tx_first
>> io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled,
>> MP over anonymous pages disabled Logical Core 1 (socket 0) forwards
>> packets on 8 streams:
>>   RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
>>   RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00
>>
>>   io packet forwarding packets/burst=32
>>   nb forwarding cores=1 - nb forwarding ports=2
>>   port 0: RX queue number: 4 Tx queue number: 4
>>   Rx offloads=0x1000 Tx offloads=0x0
>>   RX queue: 0
>> RX desc=0 - RX free threshold=32
>> RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>> RX Offloads=0x1000
>>   TX queue: 0
>> TX desc=0 - TX free threshold=32
>> TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>> TX RS bit threshold=32
>> TX offloads=0x0
>>   port 1: RX queue number: 4 Tx queue number: 4
>>   Rx offloads=0x1000 Tx offloads=0x0
>>   RX queue: 0
>> RX desc=0 - RX free threshold=32
>> RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>> RX Offloads=0x1000
>>   TX queue: 0
>> TX desc=0 - TX free threshold=32
>> TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>> TX RS bit threshold=32
>> TX offloads=0x0
>>
>> Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure")
>> Cc: qi.z.zh...@intel.com
>>
>> Signed-off-by: Ferruh Yigit 
>> ---
>>
>> Hi Qi,
>>
>> If you are agree with the patch I can squash into original patch.
> 
> OK

Thanks, I will squash this one.

> 
>>
>> btw, desc numbers are zero, "TX desc=0","RX desc=0", is this correct?
> 
> Yes, since the default value of nb_rxd and nb_txd is 0 which mean let device 
> take its default value.
> The patch keep rxtx_config_display just print the configure parameters but 
> not real device configure as before.
> But maybe "TX desc=default" is better for readable?

Instead of "default" what about to display actual value, I assume user will be
interested more with it actual value.

> 
> Regards
> Qi
> 

Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

Hi Kamil,

> -Original Message-
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 10:42 AM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: Mokhtar, Amr 
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo,
> 
> > -Original Message-
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, April 25, 2018 6:11 PM
> > To: Chalupnik, KamilX ; dev@dpdk.org
> > Cc: Mokhtar, Amr 
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> > Hi Kamil,
> >
> > > -Original Message-
> > > From: Chalupnik, KamilX
> > > Sent: Wednesday, April 25, 2018 9:43 AM
> > > To: De Lara Guarch, Pablo ;
> > > dev@dpdk.org
> > > Cc: Mokhtar, Amr 
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> > > > -Original Message-
> > > > From: De Lara Guarch, Pablo
> > > > Sent: Tuesday, April 24, 2018 4:18 PM
> > > > To: Chalupnik, KamilX ; dev@dpdk.org
> > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX
> > > > 
> > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > >
> > > > Hi Kamil,
> > > >
> > > > > -Original Message-
> > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX
> > > > > Chalupnik
> > > > > Sent: Wednesday, April 4, 2018 3:06 PM
> > > > > To: dev@dpdk.org
> > > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX
> > > > > 
> > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > > >
> > > > > From: "Chalupnik, KamilX" 
> > > > >
> > > > > Support for linking with dynamic library added in Baseband
> > > > > Device test application
> > > > >
> > > > > Signed-off-by: KamilX Chalupnik 
> > > > > ---
> > > > >  app/test-bbdev/Makefile| 4 
> > > > >  doc/guides/tools/testbbdev.rst | 7 +++
> > > > >  2 files changed, 11 insertions(+)
> > > > >
> > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile
> > > > > index 6da0c8e..26c9a4b 100644
> > > > > --- a/app/test-bbdev/Makefile
> > > > > +++ b/app/test-bbdev/Makefile
> > > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=
> > > > test_bbdev_vector.c
> > > > >
> > > > >  LDLIBS += -lm
> > > > >
> > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y)
> > > > > +LDLIBS += -lrte_pmd_bbdev_turbo_sw endif
> > > >
> > > > This is already done in mk/rte.app.mk, so it should not be needed.
> > > >
> > >
> > > We need this here when DPDK is built as dynamic library.
> > > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when
> > > CONFIG_RTE_BUILD_SHARED_LIB is not set.
> >
> > In that case, you need to use the EAL option "-d" with  the .so library.
> >
> > ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev="turbo_sw"
> 
> I thought it is fine as long as other test applications works in that way, 
> e.g. test-
> crypto-perf, test-pmd

I think some of them are including the PMDs like what you are doing because 
these have additional API.
In case of Turbo, it does not have it, and therefore, it is just another driver 
that can be plugged it in through
"-d" option (notice that most of the PMDs are not doing what you are trying to 
do, which means that it is not required).

Thanks!
Pablo

Re: [dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver

[Andrew Rybchenko]

On 04/26/2018 01:04 AM, Thomas Monjalon wrote:

25/04/2018 23:56, Thomas Monjalon:

Usually it is better to update the release notes in the main patch
implementing the feature (probably the first one in this case).
You can also update it step by step in several patches.


Yes, will do in v4.


25/04/2018 18:32, Andrew Rybchenko:

--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -147,7 +147,15 @@ New Features
compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver
to vhost lib, when virtio connected, with the help of the registered vDPA
driver the assigned VF gets configured to Rx/Tx directly to VM's virtio
-  vrings.

Removing this last word is probably a mistake.


My bad, very inaccurate rebase.


+
+* **Added bucket mempool driver.**
+
+  Added bucket mempool driver which provides a way to allocate contiguous
+  block of objects.
+  Number of objects in the block depends on how many objects fit in
+  RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
+  The number may be obtained using rte_mempool_ops_get_info() API.
+  Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API.

Please add this feature at the beginning of the list (as the first one).


Will do in v4


If possible, I would prefer you rebase on top of the mainline
(looks to be next-net here).


Yes, that's right. Will do in v4.


Thanks and sorry for nit-picking, I'm testing your stamina :)


You're welcome. Thanks for review notes.

Andrew.

Re: [dpdk-dev] [PATCH v6 08/11] net/mlx5: add hardware flow debug dump

[Ferruh Yigit]

On 4/23/2018 1:33 PM, Xueming Li wrote:
> Dump verb flow detail including flow spec type and size for debugging
> purpose.

This patch is causing build errors [1], please test build with debug enabled.

Also set is already in next-net-mlx, fixed version needs to be updated there.

Thanks,
ferruh

[1]
...dpdk/drivers/net/mlx5/mlx5_rxq.c:1460:29: error: format specifies type
'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
[-Werror,-Wformat]
  hash_fields, tunnel, rss_level,
   ^

...dpdk/drivers/net/mlx5/mlx5_rxq.c:1599:23: error: format specifies type
'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
[-Werror,-Wformat]
  hrxq->tunnel, hrxq->rss_level);
^~~

> 
> Signed-off-by: Xueming Li 
> ---
>  drivers/net/mlx5/mlx5_flow.c  | 68 
> ---
>  drivers/net/mlx5/mlx5_rxq.c   | 26 ++---
>  drivers/net/mlx5/mlx5_utils.h |  6 
>  3 files changed, 86 insertions(+), 14 deletions(-)

<...>

[dpdk-dev] [PATCH 0/7 v3] Introduce DPAA2 Command Interface raw driver

[Nipun Gupta]

This patch set introduces DPAA2 based Command Interface
device driver.

This driver is provides communication between the GPP and
AIOP Firmware.

This patchset is based on top of:
https://dpdk.org/dev/patchwork/patch/38798/

Patches 1-3:
  Makes necessary changes and fixes in the DPAA2 bus and
  mempool region
Patches 4-6:
  Add the DPAA2 CMDIF driver
Patches 7:
  Update the respective documentation

Changes in v2:
  - Move CMDIF compilation to common_linuxapp
  - Support physical addressing mode

Changes in v3:
  - Rebased over DPAA2 QDMA patches
  - Updated logging adding Data Path logs too
  - Fix up error handling in patch 3
  - Merged the two separate doc patches (patch 7)

Nipun Gupta (7):
  mempool/dpaa2: add functions exposed to DPDK applications
  bus/fslmc: expose API to free dpci device
  bus/fslmc: keep Tx queues information for DPCI devices too
  raw/dpaa2_cmdif: introduce DPAA2 command interface driver
  raw/dpaa2_cmdif: add attribute get functionality
  raw/dpaa2_cmdif: support enqueue dequeue operations
  doc: add DPAA2 CMDIF rawdev guide

 MAINTAINERS|   5 +
 config/common_base |   5 +
 config/common_linuxapp |   1 +
 doc/api/doxy-api-index.md  |   2 +
 doc/api/doxy-api.conf  |   2 +
 doc/guides/rawdevs/dpaa2_cmdif.rst | 132 +
 doc/guides/rawdevs/index.rst   |   1 +
 doc/guides/rel_notes/release_18_05.rst |  11 +
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c   |  86 --
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h|   3 +-
 drivers/bus/fslmc/rte_bus_fslmc_version.map|   1 +
 drivers/event/dpaa2/dpaa2_eventdev.c   |  10 +-
 drivers/mempool/dpaa2/Makefile |   2 +
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c   |  30 +++
 drivers/mempool/dpaa2/rte_dpaa2_mempool.h  |  53 
 .../mempool/dpaa2/rte_mempool_dpaa2_version.map|   8 +
 drivers/raw/Makefile   |   1 +
 drivers/raw/dpaa2_cmdif/Makefile   |  35 +++
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c  | 300 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h |  46 
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h  |  35 +++
 .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map|   4 +
 mk/rte.app.mk  |   1 +
 23 files changed, 745 insertions(+), 29 deletions(-)
 create mode 100644 doc/guides/rawdevs/dpaa2_cmdif.rst
 create mode 100644 drivers/mempool/dpaa2/rte_dpaa2_mempool.h
 create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map

-- 
1.9.1

[dpdk-dev] [PATCH 1/7 v3] mempool/dpaa2: add functions exposed to DPDK applications

[Nipun Gupta]

There are two API's which are required by NXP specific Command Interface
Application (AIOP CMDIF). This patch exposes these two API's.

Signed-off-by: Nipun Gupta 
---
 doc/api/doxy-api-index.md  |  1 +
 doc/api/doxy-api.conf  |  1 +
 drivers/mempool/dpaa2/Makefile |  2 +
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c   | 30 
 drivers/mempool/dpaa2/rte_dpaa2_mempool.h  | 53 ++
 .../mempool/dpaa2/rte_mempool_dpaa2_version.map|  8 
 6 files changed, 95 insertions(+)
 create mode 100644 drivers/mempool/dpaa2/rte_dpaa2_mempool.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 437d903..12d3e5c 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -38,6 +38,7 @@ The public API headers are grouped by topics:
   [i40e]   (@ref rte_pmd_i40e.h),
   [bnxt]   (@ref rte_pmd_bnxt.h),
   [dpaa]   (@ref rte_pmd_dpaa.h),
+  [dpaa2]  (@ref rte_dpaa2_mempool.h),
   [dpaa2_qdma] (@ref rte_pmd_dpaa2_qdma.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index 18a7ed4..0ab164f 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -31,6 +31,7 @@
 PROJECT_NAME= DPDK
 INPUT   = doc/api/doxy-api-index.md \
   drivers/crypto/scheduler \
+  drivers/mempool/dpaa2 \
   drivers/net/bnxt \
   drivers/net/bonding \
   drivers/net/dpaa \
diff --git a/drivers/mempool/dpaa2/Makefile b/drivers/mempool/dpaa2/Makefile
index 5125ad1..9e4c87d 100644
--- a/drivers/mempool/dpaa2/Makefile
+++ b/drivers/mempool/dpaa2/Makefile
@@ -31,4 +31,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += dpaa2_hw_mempool.c
 LDLIBS += -lrte_bus_fslmc
 LDLIBS += -lrte_eal -lrte_mempool -lrte_ring
 
+SYMLINK-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)-include := rte_dpaa2_mempool.h
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c 
b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index ce7a4c5..3c603f5 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include "rte_dpaa2_mempool.h"
 
 #include 
 #include 
@@ -237,6 +238,35 @@
}
 }
 
+uint16_t
+rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp)
+{
+   struct dpaa2_bp_info *bp_info;
+
+   bp_info = mempool_to_bpinfo(mp);
+   if (!(bp_info->bp_list)) {
+   RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n");
+   return -ENOMEM;
+   }
+
+   return bp_info->bpid;
+}
+
+struct rte_mbuf *
+rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr)
+{
+   struct dpaa2_bp_info *bp_info;
+
+   bp_info = mempool_to_bpinfo(mp);
+   if (!(bp_info->bp_list)) {
+   RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n");
+   return NULL;
+   }
+
+   return (struct rte_mbuf *)((uint8_t *)buf_addr -
+   bp_info->meta_data_size);
+}
+
 int
 rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
  void **obj_table, unsigned int count)
diff --git a/drivers/mempool/dpaa2/rte_dpaa2_mempool.h 
b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h
new file mode 100644
index 000..4a22b7c
--- /dev/null
+++ b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#ifndef __RTE_DPAA2_MEMPOOL_H__
+#define __RTE_DPAA2_MEMPOOL_H__
+
+/**
+ * @file
+ *
+ * NXP specific mempool related functions.
+ *
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include 
+
+/**
+ * Get BPID corresponding to the packet pool
+ *
+ * @param mp
+ *   memory pool
+ *
+ * @return
+ *   BPID of the buffer pool
+ */
+uint16_t
+rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp);
+
+/**
+ * Get MBUF from the corresponding 'buf_addr'
+ *
+ * @param mp
+ *   memory pool
+ * @param buf_addr
+ *   The 'buf_addr' of the mbuf. This is the start buffer address
+ *   of the packet buffer (mbuf).
+ *
+ * @return
+ *   - MBUF pointer for success
+ *   - NULL in case of error
+ */
+struct rte_mbuf *
+rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __RTE_DPAA2_MEMPOOL_H__ */
diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map 
b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
index a8aa685..b45e7a9 100644
--- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
+++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
@@ -6,3 +6,11 @@ DPDK_17.05 {
 
local: *;
 };
+
+DPDK_18.05 {
+   global:
+
+   rte_dpaa2_mbuf_from_buf_addr;
+   rte_dpaa2_mbuf_pool_bpid;
+
+} DPDK_17.05;
-- 
1.9.1

[dpdk-dev] [PATCH 2/7 v3] bus/fslmc: expose API to free dpci device

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map 
b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index 70fb719..d433714 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -114,5 +114,6 @@ DPDK_18.05 {
dpdmai_open;
dpdmai_set_rx_queue;
dpdmai_set_tx_queue;
+   rte_dpaa2_free_dpci_dev;
 
 } DPDK_18.02;
-- 
1.9.1

[dpdk-dev] [PATCH 4/7 v3] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 MAINTAINERS|   4 +
 config/common_base |   5 +
 config/common_linuxapp |   1 +
 drivers/raw/Makefile   |   1 +
 drivers/raw/dpaa2_cmdif/Makefile   |  33 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c  | 139 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h |  35 ++
 .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map|   4 +
 mk/rte.app.mk  |   1 +
 9 files changed, 223 insertions(+)
 create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index 6ad6d81..0871af9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -791,6 +791,10 @@ M: Nipun Gupta 
 F: drivers/raw/dpaa2_qdma/
 F: doc/guides/rawdevs/dpaa2_qdma.rst
 
+DPAA2 CMDIF
+M: Nipun Gupta 
+F: drivers/raw/dpaa2_cmdif/
+
 
 Eventdev Drivers
 
diff --git a/config/common_base b/config/common_base
index f69e867..8034403 100644
--- a/config/common_base
+++ b/config/common_base
@@ -617,6 +617,11 @@ CONFIG_RTE_RAWDEV_MAX_DEVS=10
 CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV=y
 
 #
+# Compile PMD for NXP DPAA2 CMDIF raw device
+#
+CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n
+
+#
 # Compile PMD for NXP DPAA2 QDMA raw device
 #
 CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n
diff --git a/config/common_linuxapp b/config/common_linuxapp
index f752a0f..0e83163 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -37,4 +37,5 @@ CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
 CONFIG_RTE_LIBRTE_DPAA2_PMD=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
+CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=y
diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
index 0f2b076..2eb2787 100644
--- a/drivers/raw/Makefile
+++ b/drivers/raw/Makefile
@@ -6,6 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # DIRS-$() += 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += skeleton_rawdev
 ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy)
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) += dpaa2_cmdif
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) += dpaa2_qdma
 endif
 
diff --git a/drivers/raw/dpaa2_cmdif/Makefile b/drivers/raw/dpaa2_cmdif/Makefile
new file mode 100644
index 000..66f9c0e
--- /dev/null
+++ b/drivers/raw/dpaa2_cmdif/Makefile
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_dpaa2_cmdif.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/qbman/include
+
+LDLIBS += -lrte_bus_fslmc
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_rawdev
+LDLIBS += -lrte_bus_vdev
+LDLIBS += -lrte_kvargs
+
+EXPORT_MAP := rte_pmd_dpaa2_cmdif_version.map
+
+LIBABIVER := 1
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) += dpaa2_cmdif.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
new file mode 100644
index 000..0d98d36
--- /dev/null
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -0,0 +1,139 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include "rte_pmd_dpaa2_cmdif.h"
+#include "dpaa2_cmdif_logs.h"
+
+/* Dynamic log type identifier */
+int dpaa2_cmdif_logtype;
+
+/* CMDIF driver name */
+#define DPAA2_CMDIF_PMD_NAME dpaa2_dpci
+
+/* CMDIF driver object */
+static struct rte_vdev_driver dpaa2_cmdif_drv;
+
+static const struct rte_rawdev_ops dpaa2_cmdif_ops = {
+};
+
+static int
+dpaa2_cmdif_create(const char *name,
+  struct rte_vdev_device *vdev,
+  int socket_id)
+{
+   struct rte_rawdev *rawdev;
+   struct dpaa2_dpci_dev *cidev;
+
+   /* Allocate device structure */
+   rawdev = rte_rawdev_pmd_allocate(name, sizeof(struct dpaa2_dpci_dev),
+socket_id);
+   if (!rawdev) {
+   DPAA2_CMDIF_ERR("Unable to allocate rawdevice");
+   return -EINVAL;
+   }
+
+   rawdev->dev_ops = &dpaa2_cmdif_ops;
+   rawdev->device = &vdev->device;
+   rawdev->driver_name = vdev->device.driver->name;
+
+   /* For secondary processes, the primary has done all the work */
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+   return 0;
+
+   cidev = rte_dpaa2_alloc_dpci_dev();
+   if (!cidev) {
+   

[dpdk-dev] [PATCH 6/7 v3] raw/dpaa2_cmdif: support enqueue dequeue operations

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 doc/api/doxy-api-index.md |   1 +
 doc/api/doxy-api.conf |   1 +
 drivers/raw/dpaa2_cmdif/Makefile  |   2 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 136 ++
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h|  23 +++--
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h |  35 +++
 6 files changed, 192 insertions(+), 6 deletions(-)
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 12d3e5c..a2f9fde 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -39,6 +39,7 @@ The public API headers are grouped by topics:
   [bnxt]   (@ref rte_pmd_bnxt.h),
   [dpaa]   (@ref rte_pmd_dpaa.h),
   [dpaa2]  (@ref rte_dpaa2_mempool.h),
+  [dpaa2_cmdif](@ref rte_pmd_dpaa2_cmdif.h),
   [dpaa2_qdma] (@ref rte_pmd_dpaa2_qdma.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index 0ab164f..f2f5237 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -38,6 +38,7 @@ INPUT   = doc/api/doxy-api-index.md \
   drivers/net/i40e \
   drivers/net/ixgbe \
   drivers/net/softnic \
+  drivers/raw/dpaa2_cmdif \
   drivers/raw/dpaa2_qdma \
   lib/librte_eal/common/include \
   lib/librte_eal/common/include/generic \
diff --git a/drivers/raw/dpaa2_cmdif/Makefile b/drivers/raw/dpaa2_cmdif/Makefile
index 66f9c0e..fdb0ec8 100644
--- a/drivers/raw/dpaa2_cmdif/Makefile
+++ b/drivers/raw/dpaa2_cmdif/Makefile
@@ -30,4 +30,6 @@ LIBABIVER := 1
 #
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) += dpaa2_cmdif.c
 
+SYMLINK-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV)-include += 
rte_pmd_dpaa2_cmdif.h
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 9044489..521883c 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -53,8 +53,144 @@
return 0;
 }
 
+static int
+dpaa2_cmdif_enqueue_bufs(struct rte_rawdev *dev,
+struct rte_rawdev_buf **buffers,
+unsigned int count,
+rte_rawdev_obj_t context)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+   struct rte_dpaa2_cmdif_context *cmdif_send_cnxt;
+   struct dpaa2_queue *txq;
+   struct qbman_fd fd;
+   struct qbman_eq_desc eqdesc;
+   struct qbman_swp *swp;
+   int ret;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(count);
+
+   if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+   ret = dpaa2_affine_qbman_swp();
+   if (ret) {
+   DPAA2_CMDIF_ERR("Failure in affining portal\n");
+   return 0;
+   }
+   }
+   swp = DPAA2_PER_LCORE_PORTAL;
+
+   cmdif_send_cnxt = (struct rte_dpaa2_cmdif_context *)(context);
+   txq = &(cidev->tx_queue[cmdif_send_cnxt->priority]);
+
+   /* Prepare enqueue descriptor */
+   qbman_eq_desc_clear(&eqdesc);
+   qbman_eq_desc_set_fq(&eqdesc, txq->fqid);
+   qbman_eq_desc_set_no_orp(&eqdesc, 0);
+   qbman_eq_desc_set_response(&eqdesc, 0, 0);
+
+   /* Set some of the FD parameters to i.
+* For performance reasons do not memset
+*/
+   fd.simple.bpid_offset = 0;
+   fd.simple.ctrl = 0;
+
+   DPAA2_SET_FD_ADDR(&fd, DPAA2_VADDR_TO_IOVA(buffers[0]->buf_addr));
+   DPAA2_SET_FD_LEN(&fd, cmdif_send_cnxt->size);
+   DPAA2_SET_FD_FRC(&fd, cmdif_send_cnxt->frc);
+   DPAA2_SET_FD_FLC(&fd, cmdif_send_cnxt->flc);
+
+   /* Enqueue a packet to the QBMAN */
+   do {
+   ret = qbman_swp_enqueue_multiple(swp, &eqdesc, &fd, NULL, 1);
+   if (ret < 0 && ret != -EBUSY)
+   DPAA2_CMDIF_ERR("Transmit failure with err: %d\n", ret);
+   } while (ret == -EBUSY);
+
+   DPAA2_CMDIF_DP_DEBUG("Successfully transmitted a packet\n");
+
+   return 0;
+}
+
+static int
+dpaa2_cmdif_dequeue_bufs(struct rte_rawdev *dev,
+struct rte_rawdev_buf **buffers,
+unsigned int count,
+rte_rawdev_obj_t context)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+   struct rte_dpaa2_cmdif_context *cmdif_rcv_cnxt;
+   struct dpaa2_queue *rxq;
+   struct qbman_swp *swp;
+   struct qbman_result *dq_storage;
+   const struct qbman_fd *fd;
+   struct qbman_pull_desc pulldesc;
+   uint8_t status;
+   int ret;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(count);
+
+   if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+   

[dpdk-dev] [PATCH 5/7 v3] raw/dpaa2_cmdif: add attribute get functionality

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 25 +
 1 file changed, 25 insertions(+)

diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 0d98d36..9044489 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -29,7 +29,32 @@
 /* CMDIF driver object */
 static struct rte_vdev_driver dpaa2_cmdif_drv;
 
+/*
+ * This API provides the DPCI device ID in 'attr_value'.
+ * The device ID shall be passed by GPP to the AIOP using CMDIF commands.
+ */
+static int
+dpaa2_cmdif_get_attr(struct rte_rawdev *dev,
+const char *attr_name,
+uint64_t *attr_value)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(attr_name);
+
+   if (!attr_value) {
+   DPAA2_CMDIF_ERR("Invalid arguments for getting attributes");
+   return -EINVAL;
+   }
+   *attr_value = cidev->dpci_id;
+
+   return 0;
+}
+
 static const struct rte_rawdev_ops dpaa2_cmdif_ops = {
+   .attr_get = dpaa2_cmdif_get_attr,
 };
 
 static int
-- 
1.9.1

[dpdk-dev] [PATCH 3/7 v3] bus/fslmc: keep Tx queues information for DPCI devices too

[Nipun Gupta]

The DPCI devices have oth Tx and Rx queues. Event devices use
DPCI Rx queues only, but CMDIF (AIOP) uses both Tx and Rx queues.
This patch enables Tx queues configuration too.

Signed-off-by: Nipun Gupta 
Acked-by: Shreyansh Jain 
---
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 86 +++-
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h  |  3 +-
 drivers/event/dpaa2/dpaa2_eventdev.c | 10 ++--
 3 files changed, 70 insertions(+), 29 deletions(-)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c 
b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
index aee870a..5ad0374 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
@@ -39,13 +39,14 @@
struct dpci_attr attr;
struct dpci_rx_queue_cfg rx_queue_cfg;
struct dpci_rx_queue_attr rx_attr;
+   struct dpci_tx_queue_attr tx_attr;
int ret, i;
 
/* Allocate DPAA2 dpci handle */
dpci_node = rte_malloc(NULL, sizeof(struct dpaa2_dpci_dev), 0);
if (!dpci_node) {
DPAA2_BUS_ERR("Memory allocation failed for DPCI Device");
-   return -1;
+   return -ENOMEM;
}
 
/* Open the dpci object */
@@ -54,8 +55,7 @@
CMD_PRI_LOW, dpci_id, &dpci_node->token);
if (ret) {
DPAA2_BUS_ERR("Resource alloc failure with err code: %d", ret);
-   rte_free(dpci_node);
-   return -1;
+   goto err;
}
 
/* Get the device attributes */
@@ -63,21 +63,40 @@
  CMD_PRI_LOW, dpci_node->token, &attr);
if (ret != 0) {
DPAA2_BUS_ERR("Reading device failed with err code: %d", ret);
-   rte_free(dpci_node);
-   return -1;
+   goto err;
}
 
-   /* Set up the Rx Queue */
-   memset(&rx_queue_cfg, 0, sizeof(struct dpci_rx_queue_cfg));
-   ret = dpci_set_rx_queue(&dpci_node->dpci,
-   CMD_PRI_LOW,
-   dpci_node->token,
-   0, &rx_queue_cfg);
-   if (ret) {
-   DPAA2_BUS_ERR("Setting Rx queue failed with err code: %d",
- ret);
-   rte_free(dpci_node);
-   return -1;
+   for (i = 0; i < DPAA2_DPCI_MAX_QUEUES; i++) {
+   struct dpaa2_queue *rxq;
+
+   memset(&rx_queue_cfg, 0, sizeof(struct dpci_rx_queue_cfg));
+   ret = dpci_set_rx_queue(&dpci_node->dpci,
+   CMD_PRI_LOW,
+   dpci_node->token,
+   i, &rx_queue_cfg);
+   if (ret) {
+   DPAA2_BUS_ERR("Setting Rx queue failed with err code: 
%d",
+ ret);
+   goto err;
+   }
+
+   /* Allocate DQ storage for the DPCI Rx queues */
+   rxq = &(dpci_node->rx_queue[i]);
+   rxq->q_storage = rte_malloc("dq_storage",
+   sizeof(struct queue_storage_info_t),
+   RTE_CACHE_LINE_SIZE);
+   if (!rxq->q_storage) {
+   DPAA2_BUS_ERR("q_storage allocation failed\n");
+   ret = -ENOMEM;
+   goto err;
+   }
+
+   memset(rxq->q_storage, 0, sizeof(struct queue_storage_info_t));
+   ret = dpaa2_alloc_dq_storage(rxq->q_storage);
+   if (ret) {
+   DPAA2_BUS_ERR("dpaa2_alloc_dq_storage failed\n");
+   goto err;
+   }
}
 
/* Enable the device */
@@ -85,8 +104,7 @@
  CMD_PRI_LOW, dpci_node->token);
if (ret != 0) {
DPAA2_BUS_ERR("Enabling device failed with err code: %d", ret);
-   rte_free(dpci_node);
-   return -1;
+   goto err;
}
 
for (i = 0; i < DPAA2_DPCI_MAX_QUEUES; i++) {
@@ -96,13 +114,22 @@
dpci_node->token, i,
&rx_attr);
if (ret != 0) {
-   DPAA2_BUS_ERR("Rx queue fetch failed with err code:"
- " %d", ret);
-   rte_free(dpci_node);
-   return -1;
+   DPAA2_BUS_ERR("Rx queue fetch failed with err code: %d",
+ ret);
+   goto err;
}
+   dpci_node->rx_queue[i].fqid = rx_attr.fqid;
 
-   dpci_node->queue[i].fqid = rx_attr.fqid;
+   ret = dpci_get_tx_queue(&dpci_node->dpci,
+   CMD_PRI_LOW,
+   dpci_node->token, i,
+   

[dpdk-dev] [PATCH 7/7 v3] doc: add DPAA2 CMDIF rawdev guide

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
Acked-by: Marko Kovacevic 
---
 MAINTAINERS|   1 +
 doc/guides/rawdevs/dpaa2_cmdif.rst | 132 +
 doc/guides/rawdevs/index.rst   |   1 +
 doc/guides/rel_notes/release_18_05.rst |  11 +++
 4 files changed, 145 insertions(+)
 create mode 100644 doc/guides/rawdevs/dpaa2_cmdif.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index 0871af9..2502940 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -794,6 +794,7 @@ F: doc/guides/rawdevs/dpaa2_qdma.rst
 DPAA2 CMDIF
 M: Nipun Gupta 
 F: drivers/raw/dpaa2_cmdif/
+F: doc/guides/rawdevs/dpaa2_cmdif.rst
 
 
 Eventdev Drivers
diff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst 
b/doc/guides/rawdevs/dpaa2_cmdif.rst
new file mode 100644
index 000..31a5dae
--- /dev/null
+++ b/doc/guides/rawdevs/dpaa2_cmdif.rst
@@ -0,0 +1,132 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright 2018 NXP
+
+NXP DPAA2 CMDIF Driver
+==
+
+The DPAA2 CMDIF is an implementation of the rawdev API, that provides
+communication between the GPP and AIOP (Firmware). This is achieved
+via using the DPCI devices exposed by MC for GPP <--> AIOP interaction.
+
+More information can be found at `NXP Official Website
+`_.
+
+Features
+
+
+The DPAA2 CMDIF implements following features in the rawdev API;
+
+- Getting the object ID of the device (DPCI) using attributes
+- I/O to and from the AIOP device using DPCI
+
+Supported DPAA2 SoCs
+
+
+- LS2084A/LS2044A
+- LS2088A/LS2048A
+- LS1088A/LS1048A
+
+Prerequisites
+-
+
+There are three main pre-requisities for executing DPAA2 CMDIF on a DPAA2
+compatible board:
+
+1. **ARM 64 Tool Chain**
+
+   For example, the `*aarch64* Linaro Toolchain 
`_.
+
+2. **Linux Kernel**
+
+   It can be obtained from `NXP's Github hosting 
`_.
+
+3. **Rootfile system**
+
+   Any *aarch64* supporting filesystem can be used. For example,
+   Ubuntu 15.10 (Wily) or 16.04 LTS (Xenial) userland which can be obtained
+   from `here 
`_.
+
+As an alternative method, DPAA2 CMDIF can also be executed using images 
provided
+as part of SDK from NXP. The SDK includes all the above prerequisites necessary
+to bring up a DPAA2 board.
+
+The following dependencies are not part of DPDK and must be installed
+separately:
+
+- **NXP Linux SDK**
+
+  NXP Linux software development kit (SDK) includes support for family
+  of QorIQ?? ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
+
+- **DPDK Extra Scripts**
+
+  DPAA2 based resources can be configured easily with the help of ready scripts
+  as provided in the DPDK Extra repository.
+
+  `DPDK Extras Scripts `_.
+
+Currently supported by DPDK:
+
+- NXP SDK **2.0+**.
+- MC Firmware version **10.0.0** and higher.
+- Supported architectures:  **arm64 LE**.
+
+- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+
+.. note::
+
+   Some part of fslmc bus code (mc flib - object library) routines are
+   dual licensed (BSD & GPLv2).
+
+Pre-Installation Configuration
+--
+
+Config File Options
+~~~
+
+The following options can be modified in the ``config`` file.
+
+- ``CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV`` (default ``y``)
+
+  Toggle compilation of the ``lrte_pmd_dpaa2_cmdif`` driver.
+
+Driver Compilation
+~~
+
+To compile the DPAA2 CMDIF PMD for Linux arm64 gcc target, run the
+following ``make`` command:
+
+.. code-block:: console
+
+   cd 
+   make config T=arm64-dpaa2-linuxapp-gcc install
+
+Initialization
+--
+
+The DPAA2 CMDIF is exposed as a vdev device which consists of dpci devices.
+On EAL initialization, dpci devices will be probed and then vdev device
+can be created from the application code by
+
+* Invoking ``rte_vdev_init("dpaa2_dpci")`` from the application
+
+* Using ``--vdev="dpaa2_dpci"`` in the EAL options, which will call
+  rte_vdev_init() internally
+
+Example:
+
+.. code-block:: console
+
+./your_cmdif_application --vdev="dpaa2_dpci"
+
+Platform Requirement
+
+
+DPAA2 drivers for DPDK can only work on NXP SoCs as listed in the
+``Supported DPAA2 SoCs``.
diff --git a/doc/guides/rawdevs/index.r

Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit

[Shweta Choudaha]

Hi Ferruh/ Helin,

  Anything else needed for this patch

http://dpdk.org/dev/patchwork/patch/37802/
Or can this be now acked  - Have addressed all comments so far.

Thanks,
Shweta

On Tue, Apr 10, 2018 at 4:58 PM, Shweta Choudaha 
wrote:

> Thanks for the review.
> I have sent an updated patch and will send patch to remove experimental
> from API for next release
>
> Thanks,
> Shweta
>
> On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson <
> bruce.richard...@intel.com> wrote:
>
>> On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote:
>> > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote:
>> > > Hi Shweta,
>> > >
>> > >
>> > >> -Original Message-
>> > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha
>> > >> Sent: Friday, February 23, 2018 7:59 PM
>> > >> To: dev@dpdk.org
>> > >> Cc: shweta.choud...@att.com
>> > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit
>> > >>
>> > >> From: Shweta Choudaha 
>> > >>
>> > >> Add ixgbe API to enable SBP bit in FCTRL register to allow receiving
>> packets
>> > >> that may otherwise be considered length errors by ixgbe and dropped
>> > >>
>> > >> Signed-off-by: Shweta Choudaha 
>> > >> Reviewed-by: Chas Williams 
>> > >> Reviewed-by: Luca Boccassi 
>> > >> ---
>> > >
>> > >
>> > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
>> > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
>> > >> @@ -52,3 +52,9 @@ DPDK_17.08 {
>> > >>rte_pmd_ixgbe_bypass_wd_timeout_show;
>> > >>rte_pmd_ixgbe_bypass_wd_timeout_store;
>> > >>  } DPDK_17.05;
>> > >> +
>> > >> +EXPERIMENTAL {
>> > >> +  global:
>> > >> +
>> > >> +  rte_pmd_ixgbe_upd_fctrl_sbp;
>> > >> +} DPDK_17.08;
>> > > The patch is fine except we should use 18.05 here.
>> >
>> > We have a rule to have an API as experimental for one release.
>> >
>> > Not sure about this rule covering the PMD specific APIs but by default
>> it is, we
>> > can discuss to have an exception for PMD APIs or not.
>> >
>> > After one release developer should send patch to remove experimental
>> from API
>> >
>> +1 for following the process.
>> I don't see why pmd-specific APIs should be a general exception. Any
>> exceptions should be on an individual case-by-case basis IMHO
>>
>
>

Re: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose

[Ferruh Yigit]

On 4/26/2018 10:45 AM, Ferruh Yigit wrote:
> On 4/26/2018 1:16 AM, Zhang, Qi Z wrote:
>>
>>
>>> -Original Message-
>>> From: Yigit, Ferruh
>>> Sent: Wednesday, April 25, 2018 10:15 PM
>>> To: Lu, Wenzhuo ; Wu, Jingjing
>>> 
>>> Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z
>>> 
>>> Subject: [PATCH] app/testpmd: update start log to be less verbose
>>>
>>> A per port per queue log is too verbose with multiple port/queue log is
>>> longer than full screen, make it less verbose:
>>> - Reduced log to only first queue of the port, as a sample
>>> - Merged a few lines
>>> - Indent queue logs for readability
>>>
>>> The log becomes as following after update:
>>>
>>> testpmd> start tx_first
>>> io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled,
>>> MP over anonymous pages disabled Logical Core 1 (socket 0) forwards
>>> packets on 8 streams:
>>>   RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
>>>   RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
>>>   RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
>>>   RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
>>>   RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>>>   RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
>>>   RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
>>>   RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00
>>>
>>>   io packet forwarding packets/burst=32
>>>   nb forwarding cores=1 - nb forwarding ports=2
>>>   port 0: RX queue number: 4 Tx queue number: 4
>>>   Rx offloads=0x1000 Tx offloads=0x0
>>>   RX queue: 0
>>> RX desc=0 - RX free threshold=32
>>> RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>>> RX Offloads=0x1000
>>>   TX queue: 0
>>> TX desc=0 - TX free threshold=32
>>> TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>>> TX RS bit threshold=32
>>> TX offloads=0x0
>>>   port 1: RX queue number: 4 Tx queue number: 4
>>>   Rx offloads=0x1000 Tx offloads=0x0
>>>   RX queue: 0
>>> RX desc=0 - RX free threshold=32
>>> RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>>> RX Offloads=0x1000
>>>   TX queue: 0
>>> TX desc=0 - TX free threshold=32
>>> TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>>> TX RS bit threshold=32
>>> TX offloads=0x0
>>>
>>> Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure")
>>> Cc: qi.z.zh...@intel.com
>>>
>>> Signed-off-by: Ferruh Yigit 
>>> ---
>>>
>>> Hi Qi,
>>>
>>> If you are agree with the patch I can squash into original patch.
>>
>> OK
> 
> Thanks, I will squash this one.


Squashed into relevant commit in next-net, thanks.

While applying one more indentation for port level added, also one more line for
Tx queue merged, the output become:

testpmd> start
io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled, MP
over anonymous pages disabled
Logical Core 1 (socket 0) forwards packets on 8 streams:
  RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
  RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00

  io packet forwarding packets/burst=32
  nb forwarding cores=1 - nb forwarding ports=2
  port 0: RX queue number: 4 Tx queue number: 4
Rx offloads=0x1000 Tx offloads=0x0
RX queue: 0
  RX desc=0 - RX free threshold=32
  RX threshold registers: pthresh=8 hthresh=8  wthresh=0
  RX Offloads=0x1000
TX queue: 0
  TX desc=0 - TX free threshold=32
  TX threshold registers: pthresh=32 hthresh=0  wthresh=0
  TX offloads=0x0 - TX RS bit threshold=32
  port 1: RX queue number: 4 Tx queue number: 4
Rx offloads=0x1000 Tx offloads=0x0
RX queue: 0
  RX desc=0 - RX free threshold=32
  RX threshold registers: pthresh=8 hthresh=8  wthresh=0
  RX Offloads=0x1000
TX queue: 0
  TX desc=0 - TX free threshold=32
  TX threshold registers: pthresh=32 hthresh=0  wthresh=0
  TX offloads=0x0 - TX RS bit threshold=32

Re: [dpdk-dev] [RFC] net/mvpp2: implement dynamic logging

[Tomasz Duszynski]

Hello Stephen,

A few nits on this inline.

On Wed, Apr 25, 2018 at 09:44:54AM -0700, Stephen Hemminger wrote:
> All DPDK drivers should use dynamic log types, not the default PMD
> value.
>
> This is an RFC not a patch since I don't have libraries are
> hardware to validate it.
>
> Signed-off-by: Stephen Hemminger 
> ---
>  drivers/net/mvpp2/mrvl_ethdev.c | 135 +---
>  drivers/net/mvpp2/mrvl_ethdev.h |   6 ++
>  drivers/net/mvpp2/mrvl_flow.c   |  24 +++---
>  drivers/net/mvpp2/mrvl_qos.c|  32 
>  4 files changed, 107 insertions(+), 90 deletions(-)
>
> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
> index 05998bf2dbc0..25969159baf9 100644
> --- a/drivers/net/mvpp2/mrvl_ethdev.c
> +++ b/drivers/net/mvpp2/mrvl_ethdev.c
> @@ -94,6 +94,8 @@ struct pp2_bpool 
> *mrvl_port_to_bpool_lookup[RTE_MAX_ETHPORTS];
>  int 
> mrvl_port_bpool_size[PP2_NUM_PKT_PROC][PP2_BPOOL_NUM_POOLS][RTE_MAX_LCORE];
>  uint64_t cookie_addr_high = MRVL_COOKIE_ADDR_INVALID;
>
> +int mvrl_logtype;

s/mvrl/mrvl

together with the others typos similar to this in other places.

> +
>  struct mrvl_ifnames {
>   const char *names[PP2_NUM_ETH_PPIO * PP2_NUM_PKT_PROC];
>   int idx;
> @@ -206,7 +208,7 @@ mrvl_init_hif(int core_id)
>
>   ret = mrvl_reserve_bit(&used_hifs, MRVL_MUSDK_HIFS_MAX);
>   if (ret < 0) {
> - RTE_LOG(ERR, PMD, "Failed to allocate hif %d\n", core_id);
> + MRVL_LOG(ERR, "Failed to allocate hif %d\n", core_id);
>   return ret;
>   }
>
> @@ -216,7 +218,7 @@ mrvl_init_hif(int core_id)
>   params.out_size = MRVL_PP2_AGGR_TXQD_MAX;
>   ret = pp2_hif_init(¶ms, &hifs[core_id]);
>   if (ret) {
> - RTE_LOG(ERR, PMD, "Failed to initialize hif %d\n", core_id);
> + MRVL_LOG(ERR, "Failed to initialize hif %d\n", core_id);
>   return ret;
>   }
>
> @@ -235,7 +237,7 @@ mrvl_get_hif(struct mrvl_priv *priv, int core_id)
>
>   ret = mrvl_init_hif(core_id);
>   if (ret < 0) {
> - RTE_LOG(ERR, PMD, "Failed to allocate hif %d\n", core_id);
> + MRVL_LOG(ERR, "Failed to allocate hif %d\n", core_id);
>   goto out;
>   }
>
> @@ -265,7 +267,7 @@ static int
>  mrvl_configure_rss(struct mrvl_priv *priv, struct rte_eth_rss_conf *rss_conf)
>  {
>   if (rss_conf->rss_key)
> - RTE_LOG(WARNING, PMD, "Changing hash key is not supported\n");
> + MRVL_LOG(WARNING, "Changing hash key is not supported\n");
>
>   if (rss_conf->rss_hf == 0) {
>   priv->ppio_params.inqs_params.hash_type = PP2_PPIO_HASH_T_NONE;
> @@ -307,34 +309,34 @@ mrvl_dev_configure(struct rte_eth_dev *dev)
>
>   if (dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_NONE &&
>   dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {
> - RTE_LOG(INFO, PMD, "Unsupported rx multi queue mode %d\n",
> + MRVL_LOG(INFO, "Unsupported rx multi queue mode %d\n",
>   dev->data->dev_conf.rxmode.mq_mode);
>   return -EINVAL;
>   }
>
>   if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_CRC_STRIP)) {
> - RTE_LOG(INFO, PMD,
> + MRVL_LOG(INFO,
>   "L2 CRC stripping is always enabled in hw\n");
>   dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_CRC_STRIP;
>   }
>
>   if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
> - RTE_LOG(INFO, PMD, "VLAN stripping not supported\n");
> + MRVL_LOG(INFO, "VLAN stripping not supported\n");
>   return -EINVAL;
>   }
>
>   if (dev->data->dev_conf.rxmode.split_hdr_size) {
> - RTE_LOG(INFO, PMD, "Split headers not supported\n");
> + MRVL_LOG(INFO, "Split headers not supported\n");
>   return -EINVAL;
>   }
>
>   if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_SCATTER) {
> - RTE_LOG(INFO, PMD, "RX Scatter/Gather not supported\n");
> + MRVL_LOG(INFO, "RX Scatter/Gather not supported\n");
>   return -EINVAL;
>   }
>
>   if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO) {
> - RTE_LOG(INFO, PMD, "LRO not supported\n");
> + MRVL_LOG(INFO, "LRO not supported\n");
>   return -EINVAL;
>   }
>
> @@ -358,7 +360,7 @@ mrvl_dev_configure(struct rte_eth_dev *dev)
>
>   if (dev->data->nb_rx_queues == 1 &&
>   dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
> - RTE_LOG(WARNING, PMD, "Disabling hash for 1 rx queue\n");
> + MRVL_LOG(WARNING, "Disabling hash for 1 rx queue\n");
>   priv->ppio_params.inqs_params.hash_type = PP2_PPIO_HASH_T_NONE;
>
>   return 0;
> @@ -482,7 +484,7 @@ mrvl_tx_queue_start(struct rte_eth_dev *dev, uint16_t 
> queue_id)
>   /* passing 1 enables given tx queue */
>   re

Re: [dpdk-dev] [PATCH v5 3/3] Add Intel FPGA OPAE Share Code

[Xu, Rosen]

Hi Hemant,

> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Wednesday, April 04, 2018 20:00
> To: Xu, Rosen ; dev@dpdk.org; Richardson, Bruce
> 
> Cc: Doherty, Declan ; shreyansh.j...@nxp.com;
> Yigit, Ferruh ; Ananyev, Konstantin
> ; Zhang, Tianfei ;
> Wu, Hao ; gaetan.ri...@6wind.com; Xu, Yilun
> 
> Subject: Re: [dpdk-dev] [PATCH v5 3/3] Add Intel FPGA OPAE Share Code
> 
> 
> Hi Rosen/Bruce,
> 
> On 4/4/2018 12:21 PM, Rosen Xu wrote:
> > +++ b/drivers/raw/ifpga_rawdev/base/Makefile
> > @@ -0,0 +1,54 @@
> > +#   BSD LICENSE
> > +#
> > +#   Copyright(c) 2017-2018 Intel Corporation. All rights reserved.
> > +#   All rights reserved.
> > +#
> > +#   Redistribution and use in source and binary forms, with or without
> > +#   modification, are permitted provided that the following conditions
> > +#   are met:
> > +#
> > +# * Redistributions of source code must retain the above copyright
> > +#   notice, this list of conditions and the following disclaimer.
> > +# * Redistributions in binary form must reproduce the above copyright
> > +#   notice, this list of conditions and the following disclaimer in
> > +#   the documentation and/or other materials provided with the
> > +#   distribution.
> > +# * Neither the name of Intel Corporation nor the names of its
> > +#   contributors may be used to endorse or promote products derived
> > +#   from this software without specific prior written permission.
> > +#
> > +#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS
> > +#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> NOT
> > +#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> FITNESS FOR
> > +#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> COPYRIGHT
> > +#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL,
> > +#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> BUT NOT
> > +#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> LOSS OF USE,
> > +#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> AND ON ANY
> > +#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> TORT
> > +#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> OF THE USE
> > +#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> 
> These files are adding the full license boiler plate.
> What is your plan to change it to SPDX?
> 
> 
> Bruce, may be your script can help Rosen to do it faster.
It's fixed in PATCH v6.
> Regards,
> Hemant

Re: [dpdk-dev] [PATCH v4 2/3] Add Intel FPGA BUS Rawdev Driver

[Xu, Rosen]

Hi Shreyansh,

> -Original Message-
> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com]
> Sent: Wednesday, April 04, 2018 19:31
> To: Xu, Rosen 
> Cc: dev@dpdk.org; Doherty, Declan ;
> Richardson, Bruce ; Yigit, Ferruh
> ; Ananyev, Konstantin
> ; Zhang, Tianfei ;
> Wu, Hao ; gaetan.ri...@6wind.com; Wu, Yanglong
> 
> Subject: RE: [dpdk-dev] [PATCH v4 2/3] Add Intel FPGA BUS Rawdev Driver
> 
> Hello Rosen,
> 
> > -Original Message-
> > From: Xu, Rosen [mailto:rosen...@intel.com]
> > Sent: Wednesday, April 4, 2018 7:20 AM
> > To: Shreyansh Jain 
> > Cc: dev@dpdk.org; Doherty, Declan ;
> > Richardson, Bruce ; Yigit, Ferruh
> > ; Ananyev, Konstantin
> > ; Zhang, Tianfei
> > ; Wu, Hao ;
> > gaetan.ri...@6wind.com; Wu, Yanglong 
> > Subject: RE: [dpdk-dev] [PATCH v4 2/3] Add Intel FPGA BUS Rawdev
> > Driver
> >
> >
> >
> > > -Original Message-
> > > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com]
> > > Sent: Tuesday, April 03, 2018 17:35
> > > To: Xu, Rosen 
> > > Cc: dev@dpdk.org; Doherty, Declan ;
> > > Richardson, Bruce ;
> > shreyansh.j...@nxp.com;
> > > Yigit, Ferruh ; Ananyev, Konstantin
> > > ; Zhang, Tianfei
> > ;
> > > Wu, Hao ; gaetan.ri...@6wind.com; Wu, Yanglong
> > > 
> > > Subject: Re: [dpdk-dev] [PATCH v4 2/3] Add Intel FPGA BUS Rawdev
> > Driver
> > >
> > > On Saturday 31 March 2018 09:33 PM, Rosen Xu wrote:
> > > > Signed-off-by: Rosen Xu 
> > > > Signed-off-by: Yanglong Wu  
> > > > ---
> > > >   config/common_base |   1 +
> > > >   drivers/raw/Makefile   |   1 +
> > > >   drivers/raw/ifpga_rawdev/Makefile  |  34 ++
> > > >   drivers/raw/ifpga_rawdev/ifpga_rawdev.c| 594
> > > +
> > > >   drivers/raw/ifpga_rawdev/ifpga_rawdev.h|  37 ++
> > > >   .../raw/ifpga_rawdev/rte_ifpga_rawdev_version.map  |   4 +
> > > >   mk/rte.app.mk  |   1 +
> > > >   7 files changed, 672 insertions(+)
> > > >   create mode 100644 drivers/raw/ifpga_rawdev/Makefile
> > > >   create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > > >   create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.h
> > > >   create mode 100644
> > > > drivers/raw/ifpga_rawdev/rte_ifpga_rawdev_version.map
> > > >
> > > > diff --git a/config/common_base b/config/common_base index
> > > > 49f6b09..08b7cce 100644
> > > > --- a/config/common_base
> > > > +++ b/config/common_base
> > > > @@ -137,6 +137,7 @@ CONFIG_RTE_LIBRTE_VDEV_BUS=y
> > > >   # Compile the Intel FPGA bus
> > > >   #
> > > >   CONFIG_RTE_LIBRTE_IFPGA_BUS=y
> > > > +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
> > > >
> > > >   #
> > > >   # Compile ARK PMD
> > > > diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile index
> > > > da7c8b4..6fc8f2f 100644
> > > > --- a/drivers/raw/Makefile
> > > > +++ b/drivers/raw/Makefile
> > > > @@ -5,5 +5,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
> > > >
> > > >   # DIRS-$() += 
> > > >   DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=
> > > skeleton_rawdev
> > > > +DIRS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev
> > > >
> > > >   include $(RTE_SDK)/mk/rte.subdir.mk diff --git
> > > > a/drivers/raw/ifpga_rawdev/Makefile
> > > > b/drivers/raw/ifpga_rawdev/Makefile
> > > > new file mode 100644
> > > > index 000..118c729
> > > > --- /dev/null
> > > > +++ b/drivers/raw/ifpga_rawdev/Makefile
> > > > @@ -0,0 +1,34 @@
> > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel
> > > > +Corporation
> > > > +
> > > > +include $(RTE_SDK)/mk/rte.vars.mk
> > > > +
> > > > +#
> > > > +# library name
> > > > +#
> > > > +LIB = librte_ifpga_rawdev.a
> > > > +
> > > > +CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS +=
> > > > +$(WERROR_FLAGS) CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga CFLAGS
> > > > ++= -I$(RTE_SDK)/drivers/raw/ifpga_rawdev
> > > > +LDLIBS += -lrte_eal
> > > > +LDLIBS += -lrte_rawdev
> > > > +LDLIBS += -lrte_bus_vdev
> > > > +LDLIBS += -lrte_kvargs
> > > > +
> > > > +EXPORT_MAP := rte_ifpga_rawdev_version.map
> > > > +
> > > > +LIBABIVER := 1
> > > > +
> > > > +VPATH += $(SRCDIR)/base
> > > > +
> > > > +include $(RTE_SDK)/drivers/raw/ifpga_rawdev/base/Makefile
> > > > +
> > > > +#
> > > > +# all source are stored in SRCS-y #
> > > > +SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev.c
> > > > +
> > > > +include $(RTE_SDK)/mk/rte.lib.mk
> > >
> > > [...]
> > > Your patch doesn't compile at this point: (Static build; Shared is
> > still stuck on
> > > patch [1/3]).
> > >
> > > --->8---
> > > == Build drivers/raw/ifpga_rawdev
> > >
> /home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/Makefil
> > > e:27:
> > >
> /home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/base/M
> > > akefile:
> > > No such file or directory
> > > make[6]: *** No rule to make target
> > >
> '/home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/base/M
> > > akefile'.
> > >   Stop.
> > > /home/shreyansh/build/DPDK/00_dpdk/mk/rte.sub

Re: [dpdk-dev] [PATCH v6 08/11] net/mlx5: add hardware flow debug dump

[Shahaf Shuler]

Thursday, April 26, 2018 1:10 PM, Ferruh Yigit:
> Subject: Re: [dpdk-dev] [PATCH v6 08/11] net/mlx5: add hardware flow
> debug dump
> 
> On 4/23/2018 1:33 PM, Xueming Li wrote:
> > Dump verb flow detail including flow spec type and size for debugging
> > purpose.
> 
> This patch is causing build errors [1], please test build with debug enabled.
> 
> Also set is already in next-net-mlx, fixed version needs to be updated there.
> 
> Thanks,
> ferruh
> 
> [1]
> ...dpdk/drivers/net/mlx5/mlx5_rxq.c:1460:29: error: format specifies type
> 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') [-
> Werror,-Wformat]
>   hash_fields, tunnel, rss_level,
>^
> 
> ...dpdk/drivers/net/mlx5/mlx5_rxq.c:1599:23: error: format specifies type
> 'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int') [-
> Werror,-Wformat]
>   hrxq->tunnel, hrxq->rss_level);
> ^~~

Fixed locally on next-net-mlx, no need to send patch. 

> 
> >
> > Signed-off-by: Xueming Li 
> > ---
> >  drivers/net/mlx5/mlx5_flow.c  | 68
> ---
> >  drivers/net/mlx5/mlx5_rxq.c   | 26 ++---
> >  drivers/net/mlx5/mlx5_utils.h |  6 
> >  3 files changed, 86 insertions(+), 14 deletions(-)
> 
> <...>

[dpdk-dev] [PATCH v8 2/9] ethdev: add switch identifier parameter to port

[Declan Doherty]

Introduces a new port attribute to ethdev port's which denotes the
switch domain a port belongs to. By default all port's switch
identifiers are set to RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID. Ports
which supported the concept of switch domains can be configured with
the same switch domain id.

Signed-off-by: Declan Doherty 
---
 app/test-pmd/config.c | 12 
 lib/librte_ether/rte_ethdev.h | 27 +++
 2 files changed, 39 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 216a7eb4e..26f416100 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -517,6 +517,18 @@ port_infos_display(portid_t port_id)
printf("Min possible number of TXDs per queue: %hu\n",
dev_info.tx_desc_lim.nb_min);
printf("TXDs number alignment: %hu\n", dev_info.tx_desc_lim.nb_align);
+
+   /* Show switch info only if valid switch domain and port id is set */
+   if (dev_info.switch_info.domain_id !=
+   RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID) {
+   if (dev_info.switch_info.name)
+   printf("Switch name: %s\n", dev_info.switch_info.name);
+
+   printf("Switch domain Id: %u\n",
+   dev_info.switch_info.domain_id);
+   printf("Switch Port Id: %u\n",
+   dev_info.switch_info.port_id);
+   }
 }
 
 void
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index efd84bb7b..06d9b288b 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1026,6 +1026,28 @@ struct rte_eth_dev_portconf {
uint16_t nb_queues; /**< Device-preferred number of queues */
 };
 
+/**
+ * Default values for switch domain id when ethdev does not support switch
+ * domain definitions.
+ */
+#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID   (0)
+
+/**
+ * Ethernet device associated switch information
+ */
+struct rte_eth_switch_info {
+   const char *name;   /**< switch name */
+   uint16_t domain_id; /**< switch domain id */
+   uint16_t port_id;
+   /**<
+* mapping to the devices physical switch port as enumerated from the
+* perspective of the embedded interconnect/switch. For SR-IOV enabled
+* device this may correspond to the VF_ID of each virtual function,
+* but each driver should explicitly define the mapping of switch
+* port identifier to that physical interconnect/switch
+*/
+};
+
 /**
  * Ethernet device information
  */
@@ -1073,6 +1095,11 @@ struct rte_eth_dev_info {
struct rte_eth_dev_portconf default_txportconf;
/** Generic device capabilities (RTE_ETH_DEV_CAPA_). */
uint64_t dev_capa;
+   /**
+* Switching information for ports on a device with a
+* embedded managed interconnect/switch.
+*/
+   struct rte_eth_switch_info switch_info;
 };
 
 /**
-- 
2.14.3

[dpdk-dev] [PATCH v8 1/9] doc: add switch representation documentation

[Declan Doherty]

Add document to describe the  model for representing switching capable
devices in DPDK, using a general ethdev port model and through port
representors. This document also details the port model and the
rte_flow semantics required for flow programming, as well as listing
some example use cases.

Signed-off-by: Adrien Mazarguil 
Signed-off-by: Declan Doherty 
Reviewed-by: Marko Kovacevic 
---
 doc/guides/prog_guide/index.rst |   1 +
 doc/guides/prog_guide/switch_representation.rst | 837 
 2 files changed, 838 insertions(+)
 create mode 100644 doc/guides/prog_guide/switch_representation.rst

diff --git a/doc/guides/prog_guide/index.rst b/doc/guides/prog_guide/index.rst
index 589c05d96..235ad0201 100644
--- a/doc/guides/prog_guide/index.rst
+++ b/doc/guides/prog_guide/index.rst
@@ -17,6 +17,7 @@ Programmer's Guide
 mbuf_lib
 poll_mode_drv
 rte_flow
+switch_representation
 traffic_metering_and_policing
 traffic_management
 bbdev
diff --git a/doc/guides/prog_guide/switch_representation.rst 
b/doc/guides/prog_guide/switch_representation.rst
new file mode 100644
index 0..f5ee516f6
--- /dev/null
+++ b/doc/guides/prog_guide/switch_representation.rst
@@ -0,0 +1,837 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 6WIND S.A.
+
+.. _switch_representation:
+
+Switch Representation within DPDK Applications
+==
+
+.. contents:: :local:
+
+Introduction
+
+
+Network adapters with multiple physical ports and/or SR-IOV capabilities
+usually support the offload of traffic steering rules between their virtual
+functions (VFs), physical functions (PFs) and ports.
+
+Like for standard Ethernet switches, this involves a combination of
+automatic MAC learning and manual configuration. For most purposes it is
+managed by the host system and fully transparent to users and applications.
+
+On the other hand, applications typically found on hypervisors that process
+layer 2 (L2) traffic (such as OVS) need to steer traffic themselves
+according on their own criteria.
+
+Without a standard software interface to manage traffic steering rules
+between VFs, PFs and the various physical ports of a given device,
+applications cannot take advantage of these offloads; software processing is
+mandatory even for traffic which ends up re-injected into the device it
+originates from.
+
+This document describes how such steering rules can be configured through
+the DPDK flow API (**rte_flow**), with emphasis on the SR-IOV use case
+(PF/VF steering) using a single physical port for clarity, however the same
+logic applies to any number of ports without necessarily involving SR-IOV.
+
+Port Representors
+-
+
+In many cases, traffic steering rules cannot be determined in advance;
+applications usually have to process a bit of traffic in software before
+thinking about offloading specific flows to hardware.
+
+Applications therefore need the ability to receive and inject traffic to
+various device endpoints (other VFs, PFs or physical ports) before
+connecting them together. Device drivers must provide means to hook the
+"other end" of these endpoints and to refer them when configuring flow
+rules.
+
+This role is left to so-called "port representors" (also known as "VF
+representors" in the specific context of VFs), which are to DPDK what the
+Ethernet switch device driver model (**switchdev**) [1]_ is to Linux, and
+which can be thought as a software "patch panel" front-end for applications.
+
+- DPDK port representors are implemented as additional virtual Ethernet
+  device (**ethdev**) instances, spawned on an as needed basis through
+  configuration parameters passed to the driver of the underlying
+  device using devargs.
+
+::
+
+   -w pci:dbdf,representor=0
+   -w pci:dbdf,representor=[0-3]
+   -w pci:dbdf,representor=[0,5-11]
+
+- As virtual devices, they may be more limited than their physical
+  counterparts, for instance by exposing only a subset of device
+  configuration callbacks and/or by not necessarily having Rx/Tx capability.
+
+- Among other things, they can be used to assign MAC addresses to the
+  resource they represent.
+
+- Applications can tell port representors apart from other physical of virtual
+  port by checking the dev_flags field within their device information
+  structure for the RTE_ETH_DEV_REPRESENTOR bit-field.
+
+.. code-block:: c
+
+  struct rte_eth_dev_info {
+  ...
+  uint32_t dev_flags; /**< Device flags */
+  ...
+  };
+
+- The device or group relationship of ports can be discovered using the
+  switch ``domain_id`` field within the devices switch information structure. 
By
+  default the switch ``domain_id`` of a port will be
+  ``RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID`` to indicate that the port doesn't
+  support the concept of a switch domain, but ports which do support the 
concept
+  will be allocated a unique switch ``domain_i

[dpdk-dev] [dpdk=-dev][PATCH v8 0/9] switching devices representation

[Declan Doherty]

This patchset follows on from the port rerpesentor patchsets and the
community discussion that resulted. It outlines the model for
representing and controlling switching capable devices in a new
programmer's guide entry based upon the excellent summary by
Adrien Mazarguil in
(http://dpdk.org/ml/archives/dev/2018-March/092513.html).

The next patches introduce changes to librte_ether to:
1, support the definition of a switch domain and make it public to
application through the rte_eth_dev_info structure.
2, Add generic ethdev create/destroy APIs to facilitate and generalise the
creation of ethdev's on different bus types.
3, Add ethdev attribute to dev_flags to specify that a port is a
representor port and make public through the rte_eth_dev_info
structure.
4, Add devargs parsing for generic eth_devargs to facilate parsing in
NET PMDs. This will be refactored to take account of the changes in
(http://dpdk.org/ml/archives/dev/2018-March/092513.html)
5, Add new API to allocate switch domain ids to devices which support
this feature.

This patchset also includes the enablement of vf port representor for ixgbe
and i40e PF devices.

V8:
- add detailed descriptions to switch information structures
- fix err condition checking ethdev create helper function
- fix devargs memory leak and error checking + add documentation on
  ethdev args.
- remove rte_eth_switch_domains structure from export items.

V7:

This patch address the following changes:
 - fixes in documentation patch
 - changes the default value of switch domain id to be INVALID to allow
   applications to easily identify devices which can/cannot support the
   concept. Updates the switch information available through the
   rte_eth_dev_info structure.
 - remove the rte_ethdev_representor.h header and leave representor
   specific initialisation to driver
 - add new APIs for allocating and freeing switch domain identifier to
   enable PMDs to have unique switch domaind ids without the ethdev
   infrastructure placing any restriction on how theses are managed by
   devices.
 - bug fix in ethdev args parsing code.

Declan Doherty (8):
  doc: add switch representation documentation
  ethdev: add switch identifier parameter to port
  ethdev: add generic create/destroy ethdev APIs
  ethdev: Add port representor device flag
  app/testpmd: add port name to device info
  ethdev: add switch domain allocator
  net/i40e: add support for representor ports
  net/ixgbe: add support for representor ports

Remy Horton (1):
  ethdev: add common devargs parser

 app/test-pmd/config.c   |  15 +
 doc/guides/nics/i40e.rst|  15 +
 doc/guides/nics/ixgbe.rst   |  14 +
 doc/guides/prog_guide/index.rst |   1 +
 doc/guides/prog_guide/poll_mode_drv.rst |  19 +
 doc/guides/prog_guide/switch_representation.rst | 837 
 drivers/net/i40e/Makefile   |   3 +
 drivers/net/i40e/i40e_ethdev.c  |  82 ++-
 drivers/net/i40e/i40e_ethdev.h  |  16 +
 drivers/net/i40e/i40e_vf_representor.c  | 405 
 drivers/net/i40e/meson.build|   4 +-
 drivers/net/i40e/rte_pmd_i40e.c |  43 ++
 drivers/net/i40e/rte_pmd_i40e.h |  18 +
 drivers/net/ixgbe/Makefile  |   1 +
 drivers/net/ixgbe/ixgbe_ethdev.c|  80 ++-
 drivers/net/ixgbe/ixgbe_ethdev.h|  14 +
 drivers/net/ixgbe/ixgbe_pf.c|   7 +
 drivers/net/ixgbe/ixgbe_vf_representor.c| 217 ++
 drivers/net/ixgbe/meson.build   |   1 +
 lib/Makefile|   1 +
 lib/librte_ether/rte_ethdev.c   | 331 ++
 lib/librte_ether/rte_ethdev.h   |  30 +
 lib/librte_ether/rte_ethdev_driver.h| 126 
 lib/librte_ether/rte_ethdev_pci.h   |  12 +
 lib/librte_ether/rte_ethdev_version.map |   5 +
 25 files changed, 2280 insertions(+), 17 deletions(-)
 create mode 100644 doc/guides/prog_guide/switch_representation.rst
 create mode 100644 drivers/net/i40e/i40e_vf_representor.c
 create mode 100644 drivers/net/ixgbe/ixgbe_vf_representor.c

-- 
2.14.3

[dpdk-dev] [PATCH v8 7/9] ethdev: add switch domain allocator

[Declan Doherty]

Add switch domain allocate and free API to enable NET devices to synchronise
switch domain allocation.

Signed-off-by: Declan Doherty 
---
 lib/librte_ether/rte_ethdev.c   | 54 +
 lib/librte_ether/rte_ethdev_driver.h| 39 
 lib/librte_ether/rte_ethdev_version.map |  2 ++
 3 files changed, 95 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index cb85d8bb7..a09c7e5b3 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -4102,6 +4102,60 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const 
char *pool)
return (*dev->dev_ops->pool_ops_supported)(dev, pool);
 }
 
+/**
+ * A set of values to describe the possible states of a switch domain.
+ */
+enum rte_eth_switch_domain_state {
+   RTE_ETH_SWITCH_DOMAIN_UNUSED = 0,
+   RTE_ETH_SWITCH_DOMAIN_ALLOCATED
+};
+
+/**
+ * Array of switch domains available for allocation. Array is sized to
+ * RTE_MAX_ETHPORTS elements as there cannot be more active switch domains than
+ * ethdev ports in a single process.
+ */
+struct rte_eth_dev_switch {
+   enum rte_eth_switch_domain_state state;
+} rte_eth_switch_domains[RTE_MAX_ETHPORTS];
+
+int __rte_experimental
+rte_eth_switch_domain_alloc(uint16_t *domain_id)
+{
+   unsigned int i;
+
+   *domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
+
+   for (i = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID + 1;
+   i < RTE_MAX_ETHPORTS; i++) {
+   if (rte_eth_switch_domains[i].state ==
+   RTE_ETH_SWITCH_DOMAIN_UNUSED) {
+   rte_eth_switch_domains[i].state =
+   RTE_ETH_SWITCH_DOMAIN_ALLOCATED;
+   *domain_id = i;
+   return 0;
+   }
+   }
+
+   return -ENOSPC;
+}
+
+int __rte_experimental
+rte_eth_switch_domain_free(uint16_t domain_id)
+{
+   if (domain_id == RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID ||
+   domain_id >= RTE_MAX_ETHPORTS)
+   return -EINVAL;
+
+   if (rte_eth_switch_domains[domain_id].state !=
+   RTE_ETH_SWITCH_DOMAIN_ALLOCATED)
+   return -EINVAL;
+
+   rte_eth_switch_domains[domain_id].state = RTE_ETH_SWITCH_DOMAIN_UNUSED;
+
+   return 0;
+}
+
 typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
 
 static int
diff --git a/lib/librte_ether/rte_ethdev_driver.h 
b/lib/librte_ether/rte_ethdev_driver.h
index 492da754a..f428afa72 100644
--- a/lib/librte_ether/rte_ethdev_driver.h
+++ b/lib/librte_ether/rte_ethdev_driver.h
@@ -188,6 +188,45 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev,
 #endif
 }
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Allocate an unique switch domain identifier.
+ *
+ * A pool of switch domain identifiers which can be allocated on request. This
+ * will enabled devices which support the concept of switch domains to request
+ * a switch domain id which is guaranteed to be unique from other devices
+ * running in the same process.
+ *
+ * @param domain_id
+ *  switch domain identifier parameter to pass back to application
+ *
+ * @return
+ *   Negative errno value on error, 0 on success.
+ */
+int __rte_experimental
+rte_eth_switch_domain_alloc(uint16_t *domain_id);
+
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Free switch domain.
+ *
+ * Return a switch domain identifier to the pool of free identifiers after it 
is
+ * no longer in use by device.
+ *
+ * @param domain_id
+ *  switch domain identifier to free
+ *
+ * @return
+ *   Negative errno value on error, 0 on success.
+ */
+int __rte_experimental
+rte_eth_switch_domain_free(uint16_t domain_id);
+
+
 
 /** Generic Ethernet device arguments  */
 struct rte_eth_devargs {
diff --git a/lib/librte_ether/rte_ethdev_version.map 
b/lib/librte_ether/rte_ethdev_version.map
index 41c3d2699..86f06769a 100644
--- a/lib/librte_ether/rte_ethdev_version.map
+++ b/lib/librte_ether/rte_ethdev_version.map
@@ -220,6 +220,8 @@ EXPERIMENTAL {
rte_eth_dev_rx_offload_name;
rte_eth_dev_tx_offload_name;
rte_eth_find_next_owned_by;
+   rte_eth_switch_domain_alloc;
+   rte_eth_switch_domain_free;
rte_mtr_capabilities_get;
rte_mtr_create;
rte_mtr_destroy;
-- 
2.14.3

[dpdk-dev] [PATCH v8 4/9] ethdev: Add port representor device flag

[Declan Doherty]

Add new device flag to specify that an ethdev port is a port representor.
Extend rte_eth_dev_info structure to expose device flags to the user which
enables applications to discover if a port is a representor port.

Signed-off-by: Declan Doherty 
---
 lib/librte_ether/rte_ethdev.c | 2 ++
 lib/librte_ether/rte_ethdev.h | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 6f7695ab3..621f8af7f 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2380,6 +2380,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct 
rte_eth_dev_info *dev_info)
dev_info->driver_name = dev->device->driver->name;
dev_info->nb_rx_queues = dev->data->nb_rx_queues;
dev_info->nb_tx_queues = dev->data->nb_tx_queues;
+
+   dev_info->dev_flags = &dev->data->dev_flags;
 }
 
 int
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 06d9b288b..0f28ee50d 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1056,6 +1056,7 @@ struct rte_eth_dev_info {
const char *driver_name; /**< Device Driver name. */
unsigned int if_index; /**< Index to bound host interface, or 0 if none.
Use if_indextoname() to translate into an interface name. */
+   const uint32_t *dev_flags; /**< Device flags */
uint32_t min_rx_bufsize; /**< Minimum size of RX buffer. */
uint32_t max_rx_pktlen; /**< Maximum configurable length of RX pkt. */
uint16_t max_rx_queues; /**< Maximum number of RX queues. */
@@ -1302,6 +1303,8 @@ struct rte_eth_dev_owner {
 #define RTE_ETH_DEV_BONDED_SLAVE 0x0004
 /** Device supports device removal interrupt */
 #define RTE_ETH_DEV_INTR_RMV 0x0008
+/** Device is port representor */
+#define RTE_ETH_DEV_REPRESENTOR  0x0010
 
 /**
  * @warning
-- 
2.14.3

[dpdk-dev] [PATCH v8 3/9] ethdev: add generic create/destroy ethdev APIs

[Declan Doherty]

Add new bus generic ethdev create/destroy APIs which are bus independent
and provide hooks for bus specific initialisation.

Signed-off-by: Declan Doherty 
---
 lib/librte_ether/rte_ethdev.c   | 93 +
 lib/librte_ether/rte_ethdev_driver.h| 57 
 lib/librte_ether/rte_ethdev_pci.h   | 12 +
 lib/librte_ether/rte_ethdev_version.map |  2 +
 4 files changed, 164 insertions(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 5f1a1bf2b..6f7695ab3 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -3391,6 +3391,99 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, 
const char *ring_name,
RTE_MEMZONE_IOVA_CONTIG, align);
 }
 
+int __rte_experimental
+rte_eth_dev_create(struct rte_device *device, const char *name,
+   size_t priv_data_size,
+   ethdev_bus_specific_init ethdev_bus_specific_init,
+   void *bus_init_params,
+   ethdev_init_t ethdev_init, void *init_params)
+{
+   struct rte_eth_dev *ethdev;
+   int retval;
+
+   RTE_FUNC_PTR_OR_ERR_RET(*ethdev_init, -EINVAL);
+
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+   ethdev = rte_eth_dev_allocate(name);
+   if (!ethdev) {
+   retval = -ENODEV;
+   goto probe_failed;
+   }
+
+   if (priv_data_size) {
+   ethdev->data->dev_private = rte_zmalloc_socket(
+   name, priv_data_size, RTE_CACHE_LINE_SIZE,
+   device->numa_node);
+
+   if (!ethdev->data->dev_private) {
+   RTE_LOG(ERR, EAL, "failed to allocate private 
data");
+   retval = -ENOMEM;
+   goto probe_failed;
+   }
+   }
+   } else {
+   ethdev = rte_eth_dev_attach_secondary(name);
+   if (!ethdev) {
+   RTE_LOG(ERR, EAL, "secondary process attach failed, "
+   "ethdev doesn't exist");
+   retval = -ENODEV;
+   goto probe_failed;
+   }
+   }
+
+   ethdev->device = device;
+
+   if (ethdev_bus_specific_init) {
+   retval = ethdev_bus_specific_init(ethdev, bus_init_params);
+   if (retval) {
+   RTE_LOG(ERR, EAL,
+   "ethdev bus specific initialisation failed");
+   goto probe_failed;
+   }
+   }
+
+   retval = ethdev_init(ethdev, init_params);
+   if (retval) {
+   RTE_LOG(ERR, EAL, "ethdev initialisation failed");
+   goto probe_failed;
+   }
+
+   return retval;
+probe_failed:
+   /* free ports private data if primary process */
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+   rte_free(ethdev->data->dev_private);
+
+   rte_eth_dev_release_port(ethdev);
+
+   return retval;
+}
+
+int  __rte_experimental
+rte_eth_dev_destroy(struct rte_eth_dev *ethdev,
+   ethdev_uninit_t ethdev_uninit)
+{
+   int ret;
+
+   ethdev = rte_eth_dev_allocated(ethdev->data->name);
+   if (!ethdev)
+   return -ENODEV;
+
+   RTE_FUNC_PTR_OR_ERR_RET(*ethdev_uninit, -EINVAL);
+   if (ethdev_uninit) {
+   ret = ethdev_uninit(ethdev);
+   if (ret)
+   return ret;
+   }
+
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+   rte_free(ethdev->data->dev_private);
+
+   ethdev->data->dev_private = NULL;
+
+   return rte_eth_dev_release_port(ethdev);
+}
+
 int
 rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
  int epfd, int op, void *data)
diff --git a/lib/librte_ether/rte_ethdev_driver.h 
b/lib/librte_ether/rte_ethdev_driver.h
index a406ef123..8c61ab2f4 100644
--- a/lib/librte_ether/rte_ethdev_driver.h
+++ b/lib/librte_ether/rte_ethdev_driver.h
@@ -188,6 +188,63 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev,
 #endif
 }
 
+
+typedef int (*ethdev_init_t)(struct rte_eth_dev *ethdev, void *init_params);
+typedef int (*ethdev_bus_specific_init)(struct rte_eth_dev *ethdev,
+   void *bus_specific_init_params);
+
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * PMD helper function for the creation of a new ethdev ports.
+ *
+ * @param device
+ *  rte_device handle.
+ * @param name
+ *  port name.
+ * @param priv_data_size
+ *  size of private data required for port.
+ * @param bus_specific_init
+ *  port bus specific initialisation callback function
+ * @param bus_init_params
+ *  port bus specific initialisation parameters
+ * @param ethdev_init
+ *  device specific port initialization callback function
+ * @param init_params
+ *  port

[dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Declan Doherty]

From: Remy Horton 

Introduces a new structure, rte_eth_devargs, to support generic
ethdev arguments common across NET PMDs, with a new API
rte_eth_devargs_parse API to support PMD parsing these arguments. The
patch add support for a representor argument  passed with passed with
the EAL -w option. The representor parameter allows the user to specify
which representor ports to initialise on a device.

The argument supports passing a single representor port, a list of
port values or a range of port values.

-w BDF,representor=1  # create representor port 1 on pci device BDF
-w BDF,representor=[1,2,5,6,10] # create representor ports in list
-w BDF,representor=[0-31] # create representor ports in range

Signed-off-by: Remy Horton 
Signed-off-by: Declan Doherty 
---
 doc/guides/prog_guide/poll_mode_drv.rst |  19 
 lib/Makefile|   1 +
 lib/librte_ether/rte_ethdev.c   | 182 
 lib/librte_ether/rte_ethdev_driver.h|  30 ++
 lib/librte_ether/rte_ethdev_version.map |   1 +
 5 files changed, 233 insertions(+)

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index e5d01874e..09a93baec 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -345,6 +345,25 @@ Ethernet Device API
 
 The Ethernet device API exported by the Ethernet PMDs is described in the 
*DPDK API Reference*.
 
+Ethernet Device Standard Device Arguments
+~
+
+Standard Ethernet device arguments allow for a set of commonly used arguments/
+parameters which are applicable to all Ethernet devices to be available to for
+specification of specific device and for passing common configuration
+parameters to those ports.
+
+* ``representor`` for a device which supports the creation of representor ports
+  this argument allows user to specify which switch ports to enable port
+  representors for.::
+
+   -w BDBF,representor=0
+   -w BDBF,representor=[0,4,6,9]
+   -w BDBF,representor=[0-31]
+
+Note: PMDs are not required to support the standard device arguments and users
+should consult the relevant PMD documentation to see support devargs.
+
 Extended Statistics API
 ~~~
 
diff --git a/lib/Makefile b/lib/Makefile
index 965be6c8d..536775e59 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal
 DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether
 DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring
 DEPDIRS-librte_ether += librte_mbuf
+DEPDIRS-librte_ether += librte_kvargs
 DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev
 DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf
 DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 621f8af7f..cb85d8bb7 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
++#include 
 
 #include "rte_ether.h"
 #include "rte_ethdev.h"
@@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const 
char *pool)
return (*dev->dev_ops->pool_ops_supported)(dev, pool);
 }
 
+typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
+
+static int
+rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)
+{
+   int state;
+   struct rte_kvargs_pair *pair;
+   char *letter;
+
+   arglist->str = strdup(str_in);
+   if (arglist->str == NULL)
+   return -ENOMEM;
+
+   letter = arglist->str;
+   state = 0;
+   arglist->count = 0;
+   pair = &arglist->pairs[0];
+   while (1) {
+   switch (state) {
+   case 0: /* Initial */
+   if (*letter == '=')
+   return -EINVAL;
+   else if (*letter == '\0')
+   return 0;
+
+   state = 1;
+   pair->key = letter;
+   /* fall-thru */
+
+   case 1: /* Parsing key */
+   if (*letter == '=') {
+   *letter = '\0';
+   pair->value = letter + 1;
+   state = 2;
+   } else if (*letter == ',' || *letter == '\0')
+   return -EINVAL;
+   break;
+
+
+   case 2: /* Parsing value */
+   if (*letter == '[')
+   state = 3;
+   else if (*letter == ',') {
+   *letter = '\0';
+   arglist->count++;
+   pair = &arglist->pairs[arglist->count];
+   state = 0;
+   } else if (*letter == '\0') {
+  

[dpdk-dev] [PATCH v8 5/9] app/testpmd: add port name to device info

[Declan Doherty]

Add the port name to information printed by show port info 

Signed-off-by: Declan Doherty 
---
 app/test-pmd/config.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 26f416100..57853e58f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -407,6 +407,7 @@ port_infos_display(portid_t port_id)
static const char *info_border = "*";
portid_t pid;
uint16_t mtu;
+   char name[RTE_ETH_NAME_MAX_LEN];
 
if (port_id_is_invalid(port_id, ENABLED_WARN)) {
printf("Valid port range is [0");
@@ -423,6 +424,8 @@ port_infos_display(portid_t port_id)
   info_border, port_id, info_border);
rte_eth_macaddr_get(port_id, &mac_addr);
print_ethaddr("MAC address: ", &mac_addr);
+   rte_eth_dev_get_name_by_port(port_id, name);
+   printf("\nDevice name: %s", name);
printf("\nDriver name: %s", dev_info.driver_name);
printf("\nConnect to socket: %u", port->socket_id);
 
-- 
2.14.3

[dpdk-dev] [PATCH v8 8/9] net/i40e: add support for representor ports

[Declan Doherty]

Add support for virtual function representor ports to the i40e PF driver.
When SR-IOV virtual functions devices are enabled a corresponding
representor port for each VF can be enabled, in the process in which the
i40e PMD is running, by specifying the representor devargs with
the list of VF ports that representors are to be created for.

An example of the devargs which would create VF representor for virtual
functions 0,2,4,5,6 and 7 is:

-w DBDF,representor=[0,2,4-7]

and to just specify a single representor on virtual function 3 (switch
port id):

-w DBDF,representor=3

Signed-off-by: Declan Doherty 
Signed-off-by: Mohammad Abdul Awal 
Signed-off-by: Remy Horton 
---
 doc/guides/nics/i40e.rst   |  15 ++
 drivers/net/i40e/Makefile  |   3 +
 drivers/net/i40e/i40e_ethdev.c |  82 ++-
 drivers/net/i40e/i40e_ethdev.h |  16 ++
 drivers/net/i40e/i40e_vf_representor.c | 405 +
 drivers/net/i40e/meson.build   |   4 +-
 drivers/net/i40e/rte_pmd_i40e.c|  43 
 drivers/net/i40e/rte_pmd_i40e.h|  18 ++
 lib/librte_ether/rte_ethdev.c  |   2 +-
 9 files changed, 579 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/i40e/i40e_vf_representor.c

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index e1b8083c1..212faf4b4 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -40,6 +40,7 @@ Features of the I40E PMD are:
 - VF Daemon (VFD) - EXPERIMENTAL
 - Dynamic Device Personalization (DDP)
 - Queue region configuration
+- Vitrual Function Port Representors
 
 Prerequisites
 -
@@ -121,6 +122,20 @@ Runtime Config Options
   will switch PF interrupt from IntN to Int0 to avoid interrupt conflict 
between
   DPDK and Linux Kernel.
 
+- ``Support VF Port Representor`` (default ``not enabled``)
+
+  The i40e PF PMD supports the creation of VF port representors for the control
+  and monitoring of i40e virtual function devices. Each port representor
+  corresponds to a single virtual function of that device. Using the 
``devargs``
+  option ``representor`` the user can specify which virtual functions to create
+  port representors for on initialization of the PF PMD by passing the VF IDs 
of
+  the VFs which are required.::
+
+  -w DBDF,representor=[0,1,4]
+
+  Currently hot-plugging of representor ports is not supported so all required
+  representors must be specified on the creation of the PF.
+
 Driver compilation and testing
 --
 
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 7e34b50a7..3f869a8d6 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -11,6 +11,8 @@ LIB = librte_pmd_i40e.a
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS) -DPF_DRIVER -DVF_DRIVER -DINTEGRATED_VF
 CFLAGS += -DX722_A0_SUPPORT
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
 LDLIBS += -lrte_bus_pci
@@ -85,6 +87,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_fdir.c
 SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_flow.c
 SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += rte_pmd_i40e.c
 SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_tm.c
+SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_vf_representor.c
 
 ifeq ($(findstring 
RTE_MACHINE_CPUFLAG_AVX2,$(CFLAGS)),RTE_MACHINE_CPUFLAG_AVX2)
CC_AVX2_SUPPORT=1
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 2fc98a7e7..0082ca693 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -213,7 +213,7 @@
 /* Bit mask of Extended Tag enable/disable */
 #define PCI_DEV_CTRL_EXT_TAG_MASK  (1 << PCI_DEV_CTRL_EXT_TAG_SHIFT)
 
-static int eth_i40e_dev_init(struct rte_eth_dev *eth_dev);
+static int eth_i40e_dev_init(struct rte_eth_dev *eth_dev, void *init_params);
 static int eth_i40e_dev_uninit(struct rte_eth_dev *eth_dev);
 static int i40e_dev_configure(struct rte_eth_dev *dev);
 static int i40e_dev_start(struct rte_eth_dev *dev);
@@ -607,16 +607,74 @@ static const struct rte_i40e_xstats_name_off 
rte_i40e_txq_prio_strings[] = {
 #define I40E_NB_TXQ_PRIO_XSTATS (sizeof(rte_i40e_txq_prio_strings) / \
sizeof(rte_i40e_txq_prio_strings[0]))
 
-static int eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
+
+static int
+eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *pci_dev)
 {
-   return rte_eth_dev_pci_generic_probe(pci_dev,
-   sizeof(struct i40e_adapter), eth_i40e_dev_init);
+   char name[RTE_ETH_NAME_MAX_LEN];
+   struct rte_eth_devargs eth_da = { .nb_representor_ports = 0 };
+   int i, retval;
+
+   retval = rte_eth_devargs_parse(pci_dev->device.devargs->args, ð_da);
+   if (retval)
+   return retval;
+
+   /* physical port net_bdf_port */
+   snprintf(name, sizeof(name), "net_%s", pci_dev->device.name);
+
+

[dpdk-dev] [PATCH v8 9/9] net/ixgbe: add support for representor ports

[Declan Doherty]

Add support for virtual function representor ports to the ixgbe PF driver.
When SR-IOV virtual functions devices are enabled a corresponding
representor port for each VF can be enabled in the process in which the
i40e PMD is running within, by specifying the representor devargs with
the list of VF ports that representors are to be created for.

An example of the devargs which would create VF representor for virtual
functions 0,2,4,5,6 and 7 is:

-w DBDF,representor=[0,2,4-7]

Signed-off-by: Declan Doherty 
Signed-off-by: Mohammad Abdul Awal 
Signed-off-by: Remy Horton 
---
 doc/guides/nics/ixgbe.rst|  14 ++
 drivers/net/ixgbe/Makefile   |   1 +
 drivers/net/ixgbe/ixgbe_ethdev.c |  80 ++--
 drivers/net/ixgbe/ixgbe_ethdev.h |  14 ++
 drivers/net/ixgbe/ixgbe_pf.c |   7 +
 drivers/net/ixgbe/ixgbe_vf_representor.c | 217 +++
 drivers/net/ixgbe/meson.build|   1 +
 7 files changed, 325 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/ixgbe/ixgbe_vf_representor.c

diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index 0c660f298..5512e0b08 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -228,6 +228,20 @@ For more details see the IPsec Security Gateway Sample 
Application and Security
 library documentation.
 
 
+Virtual Function Port Representors
+--
+The IXGBE PF PMD supports the creation of VF port representors for the control
+and monitoring of IXGBE virtual function devices. Each port representor
+corresponds to a single virtual function of that device. Using the ``devargs``
+option ``representor`` the user can specify which virtual functions to create
+port representors for on initialization of the PF PMD by passing the VF IDs of
+the VFs which are required.::
+
+  -w DBDF,representor=[0,1,4]
+
+Currently hot-plugging of representor ports is not supported so all required
+representors must be specified on the creation of the PF.
+
 Supported Chipsets and NICs
 ---
 
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index f8cad125b..7b6af3532 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -104,6 +104,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_ipsec.c
 endif
 SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += rte_pmd_ixgbe.c
 SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_tm.c
+SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_vf_representor.c
 
 # install this header file
 SYMLINK-$(CONFIG_RTE_LIBRTE_IXGBE_PMD)-include := rte_pmd_ixgbe.h
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 73a24b88a..ea2e58b16 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -132,7 +132,7 @@
 #define IXGBE_EXVET_VET_EXT_SHIFT  16
 #define IXGBE_DMATXCTL_VT_MASK 0x
 
-static int eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev);
+static int eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params);
 static int eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev);
 static int ixgbe_fdir_filter_init(struct rte_eth_dev *eth_dev);
 static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev);
@@ -1043,7 +1043,7 @@ ixgbe_swfw_lock_reset(struct ixgbe_hw *hw)
  * It returns 0 on success.
  */
 static int
-eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)
+eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
 {
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -1716,16 +1716,78 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)
return 0;
 }
 
-static int eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
-   struct rte_pci_device *pci_dev)
+static int
+eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
+   struct rte_pci_device *pci_dev)
 {
-   return rte_eth_dev_pci_generic_probe(pci_dev,
-   sizeof(struct ixgbe_adapter), eth_ixgbe_dev_init);
+   char name[RTE_ETH_NAME_MAX_LEN];
+
+   struct rte_eth_devargs eth_da;
+   int i, retval;
+
+   retval = rte_eth_devargs_parse(pci_dev->device.devargs->args, ð_da);
+   if (retval)
+   return retval;
+
+   /* physical port net_bdf_port */
+   snprintf(name, sizeof(name), "net_%s_%d", pci_dev->device.name, 0);
+
+   retval = rte_eth_dev_create(&pci_dev->device, name,
+   sizeof(struct ixgbe_adapter),
+   eth_dev_pci_specific_init, pci_dev,
+   eth_ixgbe_dev_init, NULL);
+
+   if (retval || eth_da.nb_representor_ports < 1)
+   return retval;
+
+   /* probe VF representor ports */
+   struct rte_eth_dev *pf_ethdev = rte_eth_dev_allocated(name);
+
+   for (i = 0; i < eth_da.nb_representor_ports; i++) {
+   struct ixgbe_vf_info *vfinf

Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit

[Ferruh Yigit]

On 4/26/2018 11:20 AM, Shweta Choudaha wrote:
> Hi Ferruh/ Helin,
> 
>   Anything else needed for this patch 
> 
> http://dpdk.org/dev/patchwork/patch/37802/ 
> Or can this be now acked  - Have addressed all comments so far.

Hi Helin, Qi, Wenzhuo,

Any more comment on patch?
Please let me know if you prefer me getting this directly to next-net?

> 
> Thanks,
> Shweta
> 
> On Tue, Apr 10, 2018 at 4:58 PM, Shweta Choudaha  > wrote:
> 
> Thanks for the review.
> I have sent an updated patch and will send patch to remove experimental 
> from
> API for next release
> 
> Thanks,
> Shweta
> 
> On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson
> mailto:bruce.richard...@intel.com>> wrote:
> 
> On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote:
> > On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote:
> > > Hi Shweta,
> > >
> > >
> > >> -Original Message-
> > >> From: dev [mailto:dev-boun...@dpdk.org
> ] On Behalf Of Shweta Choudaha
> > >> Sent: Friday, February 23, 2018 7:59 PM
> > >> To: dev@dpdk.org 
> > >> Cc: shweta.choud...@att.com 
> > >> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP 
> bit
> > >>
> > >> From: Shweta Choudaha  >
> > >>
> > >> Add ixgbe API to enable SBP bit in FCTRL register to allow
> receiving packets
> > >> that may otherwise be considered length errors by ixgbe and 
> dropped
> > >>
> > >> Signed-off-by: Shweta Choudaha  >
> > >> Reviewed-by: Chas Williams mailto:ch...@att.com>>
> > >> Reviewed-by: Luca Boccassi  >
> > >> ---
> > >
> > >
> > >> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
> > >> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
> > >> @@ -52,3 +52,9 @@ DPDK_17.08 {
> > >>    rte_pmd_ixgbe_bypass_wd_timeout_show;
> > >>    rte_pmd_ixgbe_bypass_wd_timeout_store;
> > >>  } DPDK_17.05;
> > >> +
> > >> +EXPERIMENTAL {
> > >> +  global:
> > >> +
> > >> +  rte_pmd_ixgbe_upd_fctrl_sbp;
> > >> +} DPDK_17.08;
> > > The patch is fine except we should use 18.05 here.
> >
> > We have a rule to have an API as experimental for one release.
> >
> > Not sure about this rule covering the PMD specific APIs but by 
> default
> it is, we
> > can discuss to have an exception for PMD APIs or not.
> >
> > After one release developer should send patch to remove experimental
> from API
> >
> +1 for following the process.
> I don't see why pmd-specific APIs should be a general exception. Any
> exceptions should be on an individual case-by-case basis IMHO
> 
> 
> 

[dpdk-dev] [PATCH v4 2/5] mempool: implement abstract mempool info API

[Andrew Rybchenko]

From: "Artem V. Andreev" 

Primarily, it is intended as a way for the mempool driver to provide
additional information on how it lays up objects inside the mempool.

Signed-off-by: Artem V. Andreev 
Signed-off-by: Andrew Rybchenko 
Acked-by: Olivier Matz 
---
 lib/librte_mempool/rte_mempool.h   | 50 ++
 lib/librte_mempool/rte_mempool_ops.c   | 15 +
 lib/librte_mempool/rte_mempool_version.map |  7 +
 3 files changed, 72 insertions(+)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 3e06ae051..853f2da4d 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -189,6 +189,23 @@ struct rte_mempool_memhdr {
void *opaque;/**< Argument passed to the free callback */
 };
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Additional information about the mempool
+ *
+ * The structure is cache-line aligned to avoid ABI breakages in
+ * a number of cases when something small is added.
+ */
+struct rte_mempool_info {
+   /*
+* Dummy structure member to make it non emtpy until the first
+* real member is added.
+*/
+   unsigned int dummy;
+} __rte_cache_aligned;
+
 /**
  * The RTE mempool structure.
  */
@@ -499,6 +516,16 @@ int rte_mempool_op_populate_default(struct rte_mempool *mp,
void *vaddr, rte_iova_t iova, size_t len,
rte_mempool_populate_obj_cb_t *obj_cb, void *obj_cb_arg);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Get some additional information about a mempool.
+ */
+typedef int (*rte_mempool_get_info_t)(const struct rte_mempool *mp,
+   struct rte_mempool_info *info);
+
+
 /** Structure defining mempool operations structure */
 struct rte_mempool_ops {
char name[RTE_MEMPOOL_OPS_NAMESIZE]; /**< Name of mempool ops struct. */
@@ -517,6 +544,10 @@ struct rte_mempool_ops {
 * provided memory chunk.
 */
rte_mempool_populate_t populate;
+   /**
+* Get mempool info
+*/
+   rte_mempool_get_info_t get_info;
 } __rte_cache_aligned;
 
 #define RTE_MEMPOOL_MAX_OPS_IDX 16  /**< Max registered ops structs */
@@ -679,6 +710,25 @@ int rte_mempool_ops_populate(struct rte_mempool *mp, 
unsigned int max_objs,
 rte_mempool_populate_obj_cb_t *obj_cb,
 void *obj_cb_arg);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Wrapper for mempool_ops get_info callback.
+ *
+ * @param[in] mp
+ *   Pointer to the memory pool.
+ * @param[out] info
+ *   Pointer to the rte_mempool_info structure
+ * @return
+ *   - 0: Success; The mempool driver supports retrieving supplementary
+ *mempool information
+ *   - -ENOTSUP - doesn't support get_info ops (valid case).
+ */
+__rte_experimental
+int rte_mempool_ops_get_info(const struct rte_mempool *mp,
+struct rte_mempool_info *info);
+
 /**
  * @internal wrapper for mempool_ops free callback.
  *
diff --git a/lib/librte_mempool/rte_mempool_ops.c 
b/lib/librte_mempool/rte_mempool_ops.c
index ea9be1eb2..efc1c084c 100644
--- a/lib/librte_mempool/rte_mempool_ops.c
+++ b/lib/librte_mempool/rte_mempool_ops.c
@@ -59,6 +59,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h)
ops->get_count = h->get_count;
ops->calc_mem_size = h->calc_mem_size;
ops->populate = h->populate;
+   ops->get_info = h->get_info;
 
rte_spinlock_unlock(&rte_mempool_ops_table.sl);
 
@@ -134,6 +135,20 @@ rte_mempool_ops_populate(struct rte_mempool *mp, unsigned 
int max_objs,
 obj_cb_arg);
 }
 
+/* wrapper to get additional mempool info */
+int
+rte_mempool_ops_get_info(const struct rte_mempool *mp,
+struct rte_mempool_info *info)
+{
+   struct rte_mempool_ops *ops;
+
+   ops = rte_mempool_get_ops(mp->ops_index);
+
+   RTE_FUNC_PTR_OR_ERR_RET(ops->get_info, -ENOTSUP);
+   return ops->get_info(mp, info);
+}
+
+
 /* sets mempool ops previously registered by rte_mempool_register_ops. */
 int
 rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name,
diff --git a/lib/librte_mempool/rte_mempool_version.map 
b/lib/librte_mempool/rte_mempool_version.map
index cf375dbe6..c9d16ecc4 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -57,3 +57,10 @@ DPDK_18.05 {
rte_mempool_op_populate_default;
 
 } DPDK_17.11;
+
+EXPERIMENTAL {
+   global:
+
+   rte_mempool_ops_get_info;
+
+} DPDK_18.05;
-- 
2.14.1

[dpdk-dev] [PATCH v4 0/5] mempool: add bucket driver

[Andrew Rybchenko]

The initial patch series [1] (RFCv1 is [2]) is split into two to simplify
processing.  It is the second part which relies on the first one [3]
which is already applied.

The patch series adds bucket mempool driver which allows to allocate
(both physically and virtually) contiguous blocks of objects and adds
mempool API to do it. It is still capable to provide separate objects,
but it is definitely more heavy-weight than ring/stack drivers.
The driver will be used by the future Solarflare driver enhancements
which allow to utilize physical contiguous blocks in the NIC firmware.

The target usecase is dequeue in blocks and enqueue separate objects
back (which are collected in buckets to be dequeued). So, the memory
pool with bucket driver is created by an application and provided to
networking PMD receive queue. The choice of bucket driver is done using
rte_eth_dev_pool_ops_supported(). A PMD that relies upon contiguous
block allocation should report the bucket driver as the only supported
and preferred one.

Introduction of the contiguous block dequeue operation is proven by
performance measurements using autotest with minor enhancements:
 - in the original test bulks are powers of two, which is unacceptable
   for us, so they are changed to multiple of contig_block_size;
 - the test code is duplicated to support plain dequeue and
   dequeue_contig_blocks;
 - all the extra test variations (with/without cache etc) are eliminated;
 - a fake read from the dequeued buffer is added (in both cases) to
   simulate mbufs access.

start performance test for bucket (without cache)
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Srate_persec=   111935488
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Srate_persec=   115290931
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Srate_persec=   353055539
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Srate_persec=   353330790
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Srate_persec=   224657407
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Srate_persec=   230411468
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Srate_persec=   706700902
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Srate_persec=   703673139
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Srate_persec=   425236887
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Srate_persec=   437295512
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Srate_persec=  1343409356
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Srate_persec=  1336567397
start performance test for bucket (without cache + contiguous dequeue)
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Crate_persec=   122945536
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Crate_persec=   126458265
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Crate_persec=   374262988
mempool_autotest cache=   0 cores= 1 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Crate_persec=   377316966
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Crate_persec=   244842496
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Crate_persec=   251618917
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Crate_persec=   751226060
mempool_autotest cache=   0 cores= 2 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Crate_persec=   756233010
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
30 Crate_persec=   462068120
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=   1 n_keep=  
60 Crate_persec=   476997221
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
30 Crate_persec=  1432171313
mempool_autotest cache=   0 cores= 4 n_get_bulk=  15 n_put_bulk=  15 n_keep=  
60 Crate_persec=  1438829771

The number of objects in the contiguous block is a function of bucket
memory size (.config option) and total element size. In the future
additional API with possibility to pass parameters on mempool allocation
may be added.

It breaks ABI since changes rte_mempool_ops. The ABI version is already
bumped in [4].

I've double-checked that mempool_autotest and mempool_perf_autotest
work fine if EAL argument --mbuf-pool-ops-name=bucket is used.

mempool_perf_autotest as is for bucket shows less rate than ring_mp_mc
since test dequeue bulk sizes are not aligned to contintiguous block size
and bucket driver is optimized for contiguous blocks allocation (or at
least allocation in bulks multiple by contiguous block size).

However, real 

[dpdk-dev] [PATCH v4 4/5] mempool/bucket: implement block dequeue operation

[Andrew Rybchenko]

From: "Artem V. Andreev" 

Signed-off-by: Artem V. Andreev 
Signed-off-by: Andrew Rybchenko 
---
 doc/guides/rel_notes/release_18_05.rst  |  2 ++
 drivers/mempool/bucket/rte_mempool_bucket.c | 52 +
 2 files changed, 54 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 3d56431cc..99f98c5ea 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -47,6 +47,8 @@ New Features
   block of objects.
   Number of objects in the block depends on how many objects fit in
   RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
+  The number may be obtained using rte_mempool_ops_get_info() API.
+  Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API.
 
 * **Added PMD-recommended Tx and Rx parameters**
 
diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c 
b/drivers/mempool/bucket/rte_mempool_bucket.c
index ef822eb2a..24be24e96 100644
--- a/drivers/mempool/bucket/rte_mempool_bucket.c
+++ b/drivers/mempool/bucket/rte_mempool_bucket.c
@@ -294,6 +294,46 @@ bucket_dequeue(struct rte_mempool *mp, void **obj_table, 
unsigned int n)
return rc;
 }
 
+static int
+bucket_dequeue_contig_blocks(struct rte_mempool *mp, void **first_obj_table,
+unsigned int n)
+{
+   struct bucket_data *bd = mp->pool_data;
+   const uint32_t header_size = bd->header_size;
+   struct bucket_stack *cur_stack = bd->buckets[rte_lcore_id()];
+   unsigned int n_buckets_from_stack = RTE_MIN(n, cur_stack->top);
+   struct bucket_header *hdr;
+   void **first_objp = first_obj_table;
+
+   bucket_adopt_orphans(bd);
+
+   n -= n_buckets_from_stack;
+   while (n_buckets_from_stack-- > 0) {
+   hdr = bucket_stack_pop_unsafe(cur_stack);
+   *first_objp++ = (uint8_t *)hdr + header_size;
+   }
+   if (n > 0) {
+   if (unlikely(rte_ring_dequeue_bulk(bd->shared_bucket_ring,
+  first_objp, n, NULL) != n)) {
+   /* Return the already dequeued buckets */
+   while (first_objp-- != first_obj_table) {
+   bucket_stack_push(cur_stack,
+ (uint8_t *)*first_objp -
+ header_size);
+   }
+   rte_errno = ENOBUFS;
+   return -rte_errno;
+   }
+   while (n-- > 0) {
+   hdr = (struct bucket_header *)*first_objp;
+   hdr->lcore_id = rte_lcore_id();
+   *first_objp++ = (uint8_t *)hdr + header_size;
+   }
+   }
+
+   return 0;
+}
+
 static void
 count_underfilled_buckets(struct rte_mempool *mp,
  void *opaque,
@@ -548,6 +588,16 @@ bucket_populate(struct rte_mempool *mp, unsigned int 
max_objs,
return n_objs;
 }
 
+static int
+bucket_get_info(const struct rte_mempool *mp, struct rte_mempool_info *info)
+{
+   struct bucket_data *bd = mp->pool_data;
+
+   info->contig_block_size = bd->obj_per_bucket;
+   return 0;
+}
+
+
 static const struct rte_mempool_ops ops_bucket = {
.name = "bucket",
.alloc = bucket_alloc,
@@ -557,6 +607,8 @@ static const struct rte_mempool_ops ops_bucket = {
.get_count = bucket_get_count,
.calc_mem_size = bucket_calc_mem_size,
.populate = bucket_populate,
+   .get_info = bucket_get_info,
+   .dequeue_contig_blocks = bucket_dequeue_contig_blocks,
 };
 
 
-- 
2.14.1

[dpdk-dev] [PATCH v4 3/5] mempool: support block dequeue operation

[Andrew Rybchenko]

From: "Artem V. Andreev" 

If mempool manager supports object blocks (physically and virtual
contiguous set of objects), it is sufficient to get the first
object only and the function allows to avoid filling in of
information about each block member.

Signed-off-by: Artem V. Andreev 
Signed-off-by: Andrew Rybchenko 
Acked-by: Olivier Matz 
---
 doc/guides/rel_notes/deprecation.rst   |   7 --
 lib/librte_mempool/Makefile|   1 +
 lib/librte_mempool/meson.build |   2 +
 lib/librte_mempool/rte_mempool.c   |  39 +
 lib/librte_mempool/rte_mempool.h   | 131 +++--
 lib/librte_mempool/rte_mempool_ops.c   |   1 +
 lib/librte_mempool/rte_mempool_version.map |   1 +
 7 files changed, 170 insertions(+), 12 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 72ab33cb7..da156c3cc 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -42,13 +42,6 @@ Deprecation Notices
 
   - ``rte_eal_mbuf_default_mempool_ops``
 
-* mempool: several API and ABI changes are planned in v18.05.
-
-  The following changes are planned:
-
-  - addition of new op to allocate contiguous
-block of objects if underlying driver supports it.
-
 * mbuf: The opaque ``mbuf->hash.sched`` field will be updated to support 
generic
   definition in line with the ethdev TM and MTR APIs. Currently, this field
   is defined in librte_sched in a non-generic way. The new generic format
diff --git a/lib/librte_mempool/Makefile b/lib/librte_mempool/Makefile
index 7f19f005a..e3c32b14f 100644
--- a/lib/librte_mempool/Makefile
+++ b/lib/librte_mempool/Makefile
@@ -10,6 +10,7 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
 # Allow deprecated symbol to use deprecated rte_mempool_populate_iova_tab()
 # from earlier deprecated rte_mempool_populate_phys_tab()
 CFLAGS += -Wno-deprecated-declarations
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 LDLIBS += -lrte_eal -lrte_ring
 
 EXPORT_MAP := rte_mempool_version.map
diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build
index baf2d24d5..d507e5511 100644
--- a/lib/librte_mempool/meson.build
+++ b/lib/librte_mempool/meson.build
@@ -1,6 +1,8 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
+allow_experimental_apis = true
+
 extra_flags = []
 
 # Allow deprecated symbol to use deprecated rte_mempool_populate_iova_tab()
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 84b3d640f..cf5d124ec 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -1255,6 +1255,36 @@ void rte_mempool_check_cookies(const struct rte_mempool 
*mp,
 #endif
 }
 
+void
+rte_mempool_contig_blocks_check_cookies(const struct rte_mempool *mp,
+   void * const *first_obj_table_const, unsigned int n, int free)
+{
+#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
+   struct rte_mempool_info info;
+   const size_t total_elt_sz =
+   mp->header_size + mp->elt_size + mp->trailer_size;
+   unsigned int i, j;
+
+   rte_mempool_ops_get_info(mp, &info);
+
+   for (i = 0; i < n; ++i) {
+   void *first_obj = first_obj_table_const[i];
+
+   for (j = 0; j < info.contig_block_size; ++j) {
+   void *obj;
+
+   obj = (void *)((uintptr_t)first_obj + j * total_elt_sz);
+   rte_mempool_check_cookies(mp, &obj, 1, free);
+   }
+   }
+#else
+   RTE_SET_USED(mp);
+   RTE_SET_USED(first_obj_table_const);
+   RTE_SET_USED(n);
+   RTE_SET_USED(free);
+#endif
+}
+
 #ifdef RTE_LIBRTE_MEMPOOL_DEBUG
 static void
 mempool_obj_audit(struct rte_mempool *mp, __rte_unused void *opaque,
@@ -1320,6 +1350,7 @@ void
 rte_mempool_dump(FILE *f, struct rte_mempool *mp)
 {
 #ifdef RTE_LIBRTE_MEMPOOL_DEBUG
+   struct rte_mempool_info info;
struct rte_mempool_debug_stats sum;
unsigned lcore_id;
 #endif
@@ -1361,6 +1392,7 @@ rte_mempool_dump(FILE *f, struct rte_mempool *mp)
 
/* sum and dump statistics */
 #ifdef RTE_LIBRTE_MEMPOOL_DEBUG
+   rte_mempool_ops_get_info(mp, &info);
memset(&sum, 0, sizeof(sum));
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
sum.put_bulk += mp->stats[lcore_id].put_bulk;
@@ -1369,6 +1401,8 @@ rte_mempool_dump(FILE *f, struct rte_mempool *mp)
sum.get_success_objs += mp->stats[lcore_id].get_success_objs;
sum.get_fail_bulk += mp->stats[lcore_id].get_fail_bulk;
sum.get_fail_objs += mp->stats[lcore_id].get_fail_objs;
+   sum.get_success_blks += mp->stats[lcore_id].get_success_blks;
+   sum.get_fail_blks += mp->stats[lcore_id].get_fail_blks;
}
fprintf(f, "  stats:\n");
fprintf(f, "put_bulk=%"PRIu64"\n", sum.put_bulk);
@@ -1377,6 +1411,11 @@ rte_mempool_dump(FILE *f, struct rte_m

[dpdk-dev] [PATCH v4 1/5] mempool/bucket: implement bucket mempool manager

[Andrew Rybchenko]

From: "Artem V. Andreev" 

The manager provides a way to allocate physically and virtually
contiguous set of objects.

Signed-off-by: Artem V. Andreev 
Signed-off-by: Andrew Rybchenko 
---
 MAINTAINERS|   9 +
 config/common_base |   2 +
 doc/guides/rel_notes/release_18_05.rst |   7 +
 drivers/mempool/Makefile   |   1 +
 drivers/mempool/bucket/Makefile|  27 +
 drivers/mempool/bucket/meson.build |   9 +
 drivers/mempool/bucket/rte_mempool_bucket.c| 563 +
 .../mempool/bucket/rte_mempool_bucket_version.map  |   4 +
 mk/rte.app.mk  |   1 +
 9 files changed, 623 insertions(+)
 create mode 100644 drivers/mempool/bucket/Makefile
 create mode 100644 drivers/mempool/bucket/meson.build
 create mode 100644 drivers/mempool/bucket/rte_mempool_bucket.c
 create mode 100644 drivers/mempool/bucket/rte_mempool_bucket_version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index 6f0235159..c0f5014c3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -364,6 +364,15 @@ F: test/test/test_rawdev.c
 F: doc/guides/prog_guide/rawdev.rst
 
 
+Memory Pool Drivers
+---
+
+Bucket memory pool
+M: Artem V. Andreev 
+M: Andrew Rybchenko 
+F: drivers/mempool/bucket/
+
+
 Bus Drivers
 ---
 
diff --git a/config/common_base b/config/common_base
index 7e4541244..f24417cb0 100644
--- a/config/common_base
+++ b/config/common_base
@@ -632,6 +632,8 @@ CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=n
 #
 # Compile Mempool drivers
 #
+CONFIG_RTE_DRIVER_MEMPOOL_BUCKET=y
+CONFIG_RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB=64
 CONFIG_RTE_DRIVER_MEMPOOL_RING=y
 CONFIG_RTE_DRIVER_MEMPOOL_STACK=y
 
diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 7c135a161..3d56431cc 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -41,6 +41,13 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
+* **Added bucket mempool driver.**
+
+  Added bucket mempool driver which provides a way to allocate contiguous
+  block of objects.
+  Number of objects in the block depends on how many objects fit in
+  RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
+
 * **Added PMD-recommended Tx and Rx parameters**
 
   Applications can now query drivers for device-tuned values of
diff --git a/drivers/mempool/Makefile b/drivers/mempool/Makefile
index fc8b73b38..28c2e8360 100644
--- a/drivers/mempool/Makefile
+++ b/drivers/mempool/Makefile
@@ -3,6 +3,7 @@
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
+DIRS-$(CONFIG_RTE_DRIVER_MEMPOOL_BUCKET) += bucket
 ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y)
 DIRS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += dpaa
 endif
diff --git a/drivers/mempool/bucket/Makefile b/drivers/mempool/bucket/Makefile
new file mode 100644
index 0..7364916bc
--- /dev/null
+++ b/drivers/mempool/bucket/Makefile
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: BSD-3-Clause
+#
+# Copyright (c) 2017-2018 Solarflare Communications Inc.
+# All rights reserved.
+#
+# This software was jointly developed between OKTET Labs (under contract
+# for Solarflare) and Solarflare Communications, Inc.
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_mempool_bucket.a
+
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+
+LDLIBS += -lrte_eal -lrte_mempool -lrte_ring
+
+EXPORT_MAP := rte_mempool_bucket_version.map
+
+LIBABIVER := 1
+
+SRCS-$(CONFIG_RTE_DRIVER_MEMPOOL_BUCKET) += rte_mempool_bucket.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/mempool/bucket/meson.build 
b/drivers/mempool/bucket/meson.build
new file mode 100644
index 0..618d79128
--- /dev/null
+++ b/drivers/mempool/bucket/meson.build
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: BSD-3-Clause
+#
+# Copyright (c) 2017-2018 Solarflare Communications Inc.
+# All rights reserved.
+#
+# This software was jointly developed between OKTET Labs (under contract
+# for Solarflare) and Solarflare Communications, Inc.
+
+sources = files('rte_mempool_bucket.c')
diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c 
b/drivers/mempool/bucket/rte_mempool_bucket.c
new file mode 100644
index 0..ef822eb2a
--- /dev/null
+++ b/drivers/mempool/bucket/rte_mempool_bucket.c
@@ -0,0 +1,563 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ *
+ * Copyright (c) 2017-2018 Solarflare Communications Inc.
+ * All rights reserved.
+ *
+ * This software was jointly developed between OKTET Labs (under contract
+ * for Solarflare) and Solarflare Communications, Inc.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+/*
+ * The general idea of the bucket mempool driver is as follows.
+ * We keep track of physically contiguous groups (buckets) of objects
+ * of a certain size. Every such a group ha

[dpdk-dev] [PATCH v4 5/5] mempool/bucket: do not allow one lcore to grab all buckets

[Andrew Rybchenko]

From: "Artem V. Andreev" 

Signed-off-by: Artem V. Andreev 
Signed-off-by: Andrew Rybchenko 
---
 drivers/mempool/bucket/rte_mempool_bucket.c | 13 +
 1 file changed, 13 insertions(+)

diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c 
b/drivers/mempool/bucket/rte_mempool_bucket.c
index 24be24e96..78d2b9d04 100644
--- a/drivers/mempool/bucket/rte_mempool_bucket.c
+++ b/drivers/mempool/bucket/rte_mempool_bucket.c
@@ -42,6 +42,7 @@ struct bucket_data {
unsigned int header_size;
unsigned int total_elt_size;
unsigned int obj_per_bucket;
+   unsigned int bucket_stack_thresh;
uintptr_t bucket_page_mask;
struct rte_ring *shared_bucket_ring;
struct bucket_stack *buckets[RTE_MAX_LCORE];
@@ -139,6 +140,7 @@ bucket_enqueue(struct rte_mempool *mp, void * const 
*obj_table,
   unsigned int n)
 {
struct bucket_data *bd = mp->pool_data;
+   struct bucket_stack *local_stack = bd->buckets[rte_lcore_id()];
unsigned int i;
int rc = 0;
 
@@ -146,6 +148,15 @@ bucket_enqueue(struct rte_mempool *mp, void * const 
*obj_table,
rc = bucket_enqueue_single(bd, obj_table[i]);
RTE_ASSERT(rc == 0);
}
+   if (local_stack->top > bd->bucket_stack_thresh) {
+   rte_ring_enqueue_bulk(bd->shared_bucket_ring,
+ &local_stack->objects
+ [bd->bucket_stack_thresh],
+ local_stack->top -
+ bd->bucket_stack_thresh,
+ NULL);
+   local_stack->top = bd->bucket_stack_thresh;
+   }
return rc;
 }
 
@@ -409,6 +420,8 @@ bucket_alloc(struct rte_mempool *mp)
bd->obj_per_bucket = (bd->bucket_mem_size - bucket_header_size) /
bd->total_elt_size;
bd->bucket_page_mask = ~(rte_align64pow2(bd->bucket_mem_size) - 1);
+   /* eventually this should be a tunable parameter */
+   bd->bucket_stack_thresh = (mp->size / bd->obj_per_bucket) * 4 / 3;
 
if (mp->flags & MEMPOOL_F_SP_PUT)
rg_flags |= RING_F_SP_ENQ;
-- 
2.14.1

Re: [dpdk-dev] [PATCH v6 11/11] doc: update mlx5 guide on tunnel offloading

[Ferruh Yigit]

On 4/23/2018 1:33 PM, Xueming Li wrote:
> Remove tunnel limitations, add new hardware tunnel offload features.
> 
> Signed-off-by: Xueming Li 
> ---
>  doc/guides/nics/features/default.ini | 1 +
>  doc/guides/nics/features/mlx5.ini| 3 +++
>  doc/guides/nics/mlx5.rst | 4 ++--
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/features/default.ini 
> b/doc/guides/nics/features/default.ini
> index dae2ad776..49be81450 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -29,6 +29,7 @@ Multicast MAC filter =
>  RSS hash =
>  RSS key update   =
>  RSS reta update  =
> +Inner RSS=
>  VMDq =
>  SR-IOV   =
>  DCB  =

When a new feature added, it need to be documented, in 
doc/guides/nics/features.rst.

To not block this set, can you please send an incremental patch for this?

Re: [dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities

[Ophir Munk]

Hi Ferruh,
Thanks for your review.
v2 was sent to mailing list that updates the log message and the commit message 
(based on Thomas comment that all queues capabilities must be reported as port 
capabilities)

> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, April 25, 2018 7:32 PM
> To: Ophir Munk ; dev@dpdk.org; Pascal Mazon
> 
> Cc: Thomas Monjalon ; Olga Shern
> ; sta...@dpdk.org
> Subject: Re: [PATCH v1] net/tap: return empty port offload capabilities
> 
> On 4/25/2018 5:15 PM, Ophir Munk wrote:
> > Fix report on port offload capabilities to be 0 (no capabilities).
> > Before this commit port capabilities were a clone of queue
> > capabilities, however the current TAP offload capabilities (e.g.
> > checksum calculation) are per queue and are not specific per port.
> 
> Overall looks good to me, thanks.
> 
> Is error log in tap_tx_queue_setup() still valid:
>   RTE_LOG(ERR, PMD,
>   "%p: Tx queue offloads 0x%" PRIx64
>   " don't match port offloads 0x%" PRIx64
>   " or supported offloads 0x%" PRIx64,
>   (void *)dev, tx_conf->offloads,
>   dev->data->dev_conf.txmode.offloads,
>   tap_tx_offload_get_port_capa());
> 
> There is no match expected, this path can be hit when requested offload out
> of reported capabilities, but either log or printed values give much
> information about real error cause.
> 
> Similar in tap_rx_queue_setup(), at least it does:
>  (tap_rx_offload_get_port_capa() | tap_rx_offload_get_queue_capa())
> 
> 
> 
> >
> > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
> > Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ophir Munk 
> > ---
> >  drivers/net/tap/rte_eth_tap.c | 21 ++---
> >  1 file changed, 6 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/net/tap/rte_eth_tap.c
> > b/drivers/net/tap/rte_eth_tap.c index fe62ab3..aea73b1 100644
> > --- a/drivers/net/tap/rte_eth_tap.c
> > +++ b/drivers/net/tap/rte_eth_tap.c
> > @@ -269,14 +269,9 @@ static uint64_t
> >  tap_rx_offload_get_port_capa(void)
> >  {
> > /*
> > -* In order to support legacy apps,
> > -* report capabilities also as port capabilities.
> > +* No specific port Rx offload capabilities.
> >  */
> > -   return DEV_RX_OFFLOAD_SCATTER |
> > -  DEV_RX_OFFLOAD_IPV4_CKSUM |
> > -  DEV_RX_OFFLOAD_UDP_CKSUM |
> > -  DEV_RX_OFFLOAD_TCP_CKSUM |
> > -  DEV_RX_OFFLOAD_CRC_STRIP;
> > +   return 0;
> >  }
> >
> >  static uint64_t
> > @@ -403,14 +398,9 @@ static uint64_t
> >  tap_tx_offload_get_port_capa(void)
> >  {
> > /*
> > -* In order to support legacy apps,
> > -* report capabilities also as port capabilities.
> > +* No specific port Tx offload capabilities.
> >  */
> > -   return DEV_TX_OFFLOAD_MULTI_SEGS |
> > -  DEV_TX_OFFLOAD_IPV4_CKSUM |
> > -  DEV_TX_OFFLOAD_UDP_CKSUM |
> > -  DEV_TX_OFFLOAD_TCP_CKSUM |
> > -  DEV_TX_OFFLOAD_TCP_TSO;
> > +   return 0;
> >  }
> >
> >  static uint64_t
> > @@ -787,7 +777,8 @@ tap_dev_stop(struct rte_eth_dev *dev)  static int
> > tap_dev_configure(struct rte_eth_dev *dev)  {
> > -   uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa();
> > +   uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa() |
> > +   tap_tx_offload_get_queue_capa();
> > uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;
> >
> > if ((tx_offloads & supp_tx_offloads) != tx_offloads) {
> >

[dpdk-dev] [PATCH v2] net/tap: return empty port offload capabilities

[Ophir Munk]

Fix internal report on port specific offload capabilities to be 0 (no
capabilities). Before this commit port capabilities were a clone of queue
capabilities, however the current TAP offload capabilities (e.g.
checksum calculation) are per queue and are not specific per port.
This commit fixes an internal validation check for new configured
queue offloads.
The port capability API keeps reporting all queue capabilities as port
capabilities.

Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
Cc: sta...@dpdk.org

Signed-off-by: Ophir Munk 
---
v1: initial release
v2: Fix log error message and update commit message

 drivers/net/tap/rte_eth_tap.c | 24 
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index fe62ab3..b4420ce 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -269,14 +269,9 @@ static uint64_t
 tap_rx_offload_get_port_capa(void)
 {
/*
-* In order to support legacy apps,
-* report capabilities also as port capabilities.
+* No specific port Rx offload capabilities.
 */
-   return DEV_RX_OFFLOAD_SCATTER |
-  DEV_RX_OFFLOAD_IPV4_CKSUM |
-  DEV_RX_OFFLOAD_UDP_CKSUM |
-  DEV_RX_OFFLOAD_TCP_CKSUM |
-  DEV_RX_OFFLOAD_CRC_STRIP;
+   return 0;
 }
 
 static uint64_t
@@ -403,14 +398,9 @@ static uint64_t
 tap_tx_offload_get_port_capa(void)
 {
/*
-* In order to support legacy apps,
-* report capabilities also as port capabilities.
+* No specific port Tx offload capabilities.
 */
-   return DEV_TX_OFFLOAD_MULTI_SEGS |
-  DEV_TX_OFFLOAD_IPV4_CKSUM |
-  DEV_TX_OFFLOAD_UDP_CKSUM |
-  DEV_TX_OFFLOAD_TCP_CKSUM |
-  DEV_TX_OFFLOAD_TCP_TSO;
+   return 0;
 }
 
 static uint64_t
@@ -787,7 +777,8 @@ tap_dev_stop(struct rte_eth_dev *dev)
 static int
 tap_dev_configure(struct rte_eth_dev *dev)
 {
-   uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa();
+   uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa() |
+   tap_tx_offload_get_queue_capa();
uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;
 
if ((tx_offloads & supp_tx_offloads) != tx_offloads) {
@@ -1351,7 +1342,8 @@ tap_tx_queue_setup(struct rte_eth_dev *dev,
" or supported offloads 0x%" PRIx64,
(void *)dev, tx_conf->offloads,
dev->data->dev_conf.txmode.offloads,
-   tap_tx_offload_get_port_capa());
+   (tap_tx_offload_get_port_capa() |
+   tap_tx_offload_get_queue_capa()));
return -rte_errno;
}
}
-- 
2.7.4

Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

> -Original Message-
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 10:42 AM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: Mokhtar, Amr 
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo,
> 
> > -Original Message-
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, April 25, 2018 6:11 PM
> > To: Chalupnik, KamilX ; dev@dpdk.org
> > Cc: Mokhtar, Amr 
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> > Hi Kamil,
> >
> > > -Original Message-
> > > From: Chalupnik, KamilX
> > > Sent: Wednesday, April 25, 2018 9:43 AM
> > > To: De Lara Guarch, Pablo ;
> > > dev@dpdk.org
> > > Cc: Mokhtar, Amr 
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> > > > -Original Message-
> > > > From: De Lara Guarch, Pablo
> > > > Sent: Tuesday, April 24, 2018 4:18 PM
> > > > To: Chalupnik, KamilX ; dev@dpdk.org
> > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX
> > > > 
> > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > >
> > > > Hi Kamil,
> > > >
> > > > > -Original Message-
> > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX
> > > > > Chalupnik
> > > > > Sent: Wednesday, April 4, 2018 3:06 PM
> > > > > To: dev@dpdk.org
> > > > > Cc: Mokhtar, Amr ; Chalupnik, KamilX
> > > > > 
> > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > > > >
> > > > > From: "Chalupnik, KamilX" 
> > > > >
> > > > > Support for linking with dynamic library added in Baseband
> > > > > Device test application
> > > > >
> > > > > Signed-off-by: KamilX Chalupnik 
> > > > > ---
> > > > >  app/test-bbdev/Makefile| 4 
> > > > >  doc/guides/tools/testbbdev.rst | 7 +++
> > > > >  2 files changed, 11 insertions(+)
> > > > >
> > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile
> > > > > index 6da0c8e..26c9a4b 100644
> > > > > --- a/app/test-bbdev/Makefile
> > > > > +++ b/app/test-bbdev/Makefile
> > > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=
> > > > test_bbdev_vector.c
> > > > >
> > > > >  LDLIBS += -lm
> > > > >
> > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y)
> > > > > +LDLIBS += -lrte_pmd_bbdev_turbo_sw endif
> > > >
> > > > This is already done in mk/rte.app.mk, so it should not be needed.
> > > >
> > >
> > > We need this here when DPDK is built as dynamic library.
> > > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when
> > > CONFIG_RTE_BUILD_SHARED_LIB is not set.
> >
> > In that case, you need to use the EAL option "-d" with  the .so library.
> >
> > ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev="turbo_sw"
> 
> I thought it is fine as long as other test applications works in that way, 
> e.g. test-
> crypto-perf, test-pmd
> 
> > Btw, now that I have seen the name of the vdev, I think you should
> > rename to "baseband_turbo_sw".
> > Also, NULL PMD should be renamed to "baseband_null".
> 
> Ok, we will deliver such changes in patches for next release. Are you ok with
> that?

I think this change should not take a long time. The sooner we do it, the 
better,
as there might be more people using this in the future.
I can send the patch for you, so you can focus on other changes, and then you 
can see if it is fine for you.

Thanks,
Pablo

> 
> 
> Best regards,
> Kamil

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

[Ananyev, Konstantin]

> -Original Message-
> From: Yongseok Koh [mailto:ys...@mellanox.com]
> Sent: Thursday, April 26, 2018 2:10 AM
> To: Lu, Wenzhuo ; Wu, Jingjing ; 
> olivier.m...@6wind.com
> Cc: dev@dpdk.org; Ananyev, Konstantin ; 
> arybche...@solarflare.com; step...@networkplumber.org;
> tho...@monjalon.net; adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com; 
> Yongseok Koh 
> Subject: [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf
> 
> This patch introduces a new way of attaching an external buffer to a mbuf.
> 
> Attaching an external buffer is quite similar to mbuf indirection in
> replacing buffer addresses and length of a mbuf, but a few differences:
>   - When an indirect mbuf is attached, refcnt of the direct mbuf would be
> 2 as long as the direct mbuf itself isn't freed after the attachment.
> In such cases, the buffer area of a direct mbuf must be read-only. But
> external buffer has its own refcnt and it starts from 1. Unless
> multiple mbufs are attached to a mbuf having an external buffer, the
> external buffer is writable.
>   - There's no need to allocate buffer from a mempool. Any buffer can be
> attached with appropriate free callback.
>   - Smaller metadata is required to maintain shared data such as refcnt.
> 
> Signed-off-by: Yongseok Koh 
> ---

Acked-by: Konstantin Ananyev 


> 
> ** This patch can pass the mbuf_autotest. **
> 
> Submitting only non-mlx5 patches to meet deadline for RC1. mlx5 patches
> will be submitted separately rebased on a differnet patchset which
> accommodates new memory hotplug design to mlx PMDs.
> 
> v6:
> * rte_pktmbuf_attach_extbuf() doesn't take NULL shinfo. Instead,
>   rte_pktmbuf_ext_shinfo_init_helper() is added.
> * bug fix in rte_pktmbuf_attach() - shinfo wasn't saved to mi.
> * minor changes from review.
> 
> v5:
> * rte_pktmbuf_attach_extbuf() sets headroom to 0.
> * if shinfo is provided when attaching, user should initialize it.
> * minor changes from review.
> 
> v4:
> * rte_pktmbuf_attach_extbuf() takes new arguments - buf_iova and shinfo.
>   user can pass memory for shared data via shinfo argument.
> * minor changes from review.
> 
> v3:
> * implement external buffer attachment instead of introducing buf_off for
>   mbuf indirection.
> 
>  lib/librte_mbuf/rte_mbuf.h | 335 
> +
>  1 file changed, 306 insertions(+), 29 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 43aaa9c5f..0a6885281 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -344,7 +344,10 @@ extern "C" {
>   PKT_TX_MACSEC |  \
>   PKT_TX_SEC_OFFLOAD)
> 
> -#define __RESERVED   (1ULL << 61) /**< reserved for future mbuf use 
> */
> +/**
> + * Mbuf having an external buffer attached. shinfo in mbuf must be filled.
> + */
> +#define EXT_ATTACHED_MBUF(1ULL << 61)
> 
>  #define IND_ATTACHED_MBUF(1ULL << 62) /**< Indirect attached mbuf */
> 
> @@ -584,8 +587,27 @@ struct rte_mbuf {
>   /** Sequence number. See also rte_reorder_insert(). */
>   uint32_t seqn;
> 
> + /** Shared data for external buffer attached to mbuf. See
> +  * rte_pktmbuf_attach_extbuf().
> +  */
> + struct rte_mbuf_ext_shared_info *shinfo;
> +
>  } __rte_cache_aligned;
> 
> +/**
> + * Function typedef of callback to free externally attached buffer.
> + */
> +typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque);
> +
> +/**
> + * Shared data at the end of an external buffer.
> + */
> +struct rte_mbuf_ext_shared_info {
> + rte_mbuf_extbuf_free_callback_t free_cb; /**< Free callback function */
> + void *fcb_opaque;/**< Free callback argument */
> + rte_atomic16_t refcnt_atomic;/**< Atomically accessed refcnt */
> +};
> +
>  /**< Maximum number of nb_segs allowed. */
>  #define RTE_MBUF_MAX_NB_SEGS UINT16_MAX
> 
> @@ -706,14 +728,34 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
>  }
> 
>  /**
> + * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE
> + * otherwise.
> + *
> + * If a mbuf has its data in another mbuf and references it by mbuf
> + * indirection, this mbuf can be defined as a cloned mbuf.
> + */
> +#define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF)
> +
> +/**
>   * Returns TRUE if given mbuf is indirect, or FALSE otherwise.
>   */
> -#define RTE_MBUF_INDIRECT(mb)   ((mb)->ol_flags & IND_ATTACHED_MBUF)
> +#define RTE_MBUF_INDIRECT(mb)   RTE_MBUF_CLONED(mb)
> +
> +/**
> + * Returns TRUE if given mbuf has an external buffer, or FALSE otherwise.
> + *
> + * External buffer is a user-provided anonymous buffer.
> + */
> +#define RTE_MBUF_HAS_EXTBUF(mb) ((mb)->ol_flags & EXT_ATTACHED_MBUF)
> 
>  /**
>   * Returns TRUE if given mbuf is direct, or FALSE otherwise.
> + *
> + * If a mbuf embeds its own data after the rte_mbuf structure, this mbuf
> + * can be defined as a direct mbuf.
>   */
> -#d

Re: [dpdk-dev] [PATCH v8 2/9] ethdev: add switch identifier parameter to port

[Thomas Monjalon]

26/04/2018 12:40, Declan Doherty:
> Introduces a new port attribute to ethdev port's which denotes the
> switch domain a port belongs to. By default all port's switch
> identifiers are set to RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID. Ports
> which supported the concept of switch domains can be configured with
> the same switch domain id.
> 
> Signed-off-by: Declan Doherty 

It's very well detailed now :)

Acked-by: Thomas Monjalon 

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Ananyev, Konstantin]

> -Original Message-
> From: Doherty, Declan
> Sent: Thursday, April 26, 2018 11:41 AM
> To: dev@dpdk.org
> Cc: Adrien Mazarguil ; Yigit, Ferruh 
> ; Thomas Monjalon ;
> Shahaf Shuler ; Ananyev, Konstantin 
> ; Horton, Remy ;
> Doherty, Declan 
> Subject: [dpdk-dev][PATCH v8 6/9] ethdev: add common devargs parser
> 
> From: Remy Horton 
> 
> Introduces a new structure, rte_eth_devargs, to support generic
> ethdev arguments common across NET PMDs, with a new API
> rte_eth_devargs_parse API to support PMD parsing these arguments. The
> patch add support for a representor argument  passed with passed with
> the EAL -w option. The representor parameter allows the user to specify
> which representor ports to initialise on a device.
> 
> The argument supports passing a single representor port, a list of
> port values or a range of port values.
> 
> -w BDF,representor=1  # create representor port 1 on pci device BDF
> -w BDF,representor=[1,2,5,6,10] # create representor ports in list
> -w BDF,representor=[0-31] # create representor ports in range
> 
> Signed-off-by: Remy Horton 
> Signed-off-by: Declan Doherty 
> ---
>  doc/guides/prog_guide/poll_mode_drv.rst |  19 
>  lib/Makefile|   1 +
>  lib/librte_ether/rte_ethdev.c   | 182 
> 
>  lib/librte_ether/rte_ethdev_driver.h|  30 ++
>  lib/librte_ether/rte_ethdev_version.map |   1 +
>  5 files changed, 233 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
> b/doc/guides/prog_guide/poll_mode_drv.rst
> index e5d01874e..09a93baec 100644
> --- a/doc/guides/prog_guide/poll_mode_drv.rst
> +++ b/doc/guides/prog_guide/poll_mode_drv.rst
> @@ -345,6 +345,25 @@ Ethernet Device API
> 
>  The Ethernet device API exported by the Ethernet PMDs is described in the 
> *DPDK API Reference*.
> 
> +Ethernet Device Standard Device Arguments
> +~
> +
> +Standard Ethernet device arguments allow for a set of commonly used 
> arguments/
> +parameters which are applicable to all Ethernet devices to be available to 
> for
> +specification of specific device and for passing common configuration
> +parameters to those ports.
> +
> +* ``representor`` for a device which supports the creation of representor 
> ports
> +  this argument allows user to specify which switch ports to enable port
> +  representors for.::
> +
> +   -w BDBF,representor=0
> +   -w BDBF,representor=[0,4,6,9]
> +   -w BDBF,representor=[0-31]
> +
> +Note: PMDs are not required to support the standard device arguments and 
> users
> +should consult the relevant PMD documentation to see support devargs.
> +
>  Extended Statistics API
>  ~~~
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 965be6c8d..536775e59 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal
>  DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether
>  DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring
>  DEPDIRS-librte_ether += librte_mbuf
> +DEPDIRS-librte_ether += librte_kvargs
>  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev
>  DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 621f8af7f..cb85d8bb7 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -34,6 +34,7 @@
>  #include 
>  #include 
>  #include 
> ++#include 
> 
>  #include "rte_ether.h"
>  #include "rte_ethdev.h"
> @@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, 
> const char *pool)
>   return (*dev->dev_ops->pool_ops_supported)(dev, pool);
>  }
> 
> +typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
> +
> +static int
> +rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)
> +{

I still think that if you'd like to extend rte_kvarrgs to be able to parse 
something like: "key=[val1,val2,...,valn]",
you have to make it generic kvargs ability and put it into librte_kvargs, not 
try to introduce your own new parser here.
Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string 
would contain some extra (let say device specific)
parameters.
What would happen, when PMD will try to use rte_kvargs_parse() on such string?
My understanding - it would fail, correct?

As an alternative - as I remember rte_kvargs allows you to have multiple 
identical key, i.e: "key=val1,key=val2,...,key=valn".
Why not to use that way, if you don't want to introduce extra code in 
rte_kvargs?

> + int state;
> + struct rte_kvargs_pair *pair;
> + char *letter;
> +
> + arglist->str = strdup(str_in);
> + if (arglist->str == NULL)
> + return -ENOMEM;
> +
> + letter = arglist->str;
> + state = 0;
> + arglist->count = 0;
> + pair = &arglist->pairs[0];
> + while (1) {
> +

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Ferruh Yigit]

On 4/26/2018 11:41 AM, Declan Doherty wrote:
> From: Remy Horton 
> 
> Introduces a new structure, rte_eth_devargs, to support generic
> ethdev arguments common across NET PMDs, with a new API
> rte_eth_devargs_parse API to support PMD parsing these arguments. The
> patch add support for a representor argument  passed with passed with
> the EAL -w option. The representor parameter allows the user to specify
> which representor ports to initialise on a device.
> 
> The argument supports passing a single representor port, a list of
> port values or a range of port values.
> 
> -w BDF,representor=1  # create representor port 1 on pci device BDF
> -w BDF,representor=[1,2,5,6,10] # create representor ports in list
> -w BDF,representor=[0-31] # create representor ports in range
> 
> Signed-off-by: Remy Horton 
> Signed-off-by: Declan Doherty 

<...>

> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * PMD helper function to parse ethdev arguments
> + *
> + * @param devargs
> + *  device arguments
> + * @param eth_devargs
> + *  parsed ethdev specific arguments.
> + *
> + * @return
> + *   Negative errno value on error, 0 on success.
> + */
> +int __rte_experimental
> +rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs 
> *eth_devargs);

API doc build giving warning because of doxygen comments, devargs vs dargs, I
will fix while applying as "devargs"

[dpdk-dev] [PATCH v6 0/4] additions to support tunnel encap/decap

[Declan Doherty]

his patchset contains the revised proposal to manage 
tunnel endpoints hardware accleration based on community
feedback on RFC
(http://dpdk.org/ml/archives/dev/2017-December/084676.html). This
proposal is purely enabled through rte_flow APIs with the
additions of some new features which were previously implemented
by the proposed rte_tep APIs which were proposed in the original
RFC. This patchset ultimately aims to enable the configuration
of inline data path encapsulation and decapsulation of tunnel
endpoint network overlays on accelerated IO devices.

V2:
- Split new functions into separate patches, and add additional
  documentaiton.

V3:

- Extended the description of group counter in documentation.
- Renamed VTEP to TUNNEL.
- Fixed C99 syntax.

V4:

- Modify encap/decap actions to be protocol specific
- rename group action type to jump
- add mark flow item type in place of metadata flow/action types
- add count action data structure
- modify query API to accept rte_flow_action structure in place of
  rte_flow_actio_type enumeration to support specification and
  querying of multiple actions of the same type

V5:
- Documentation and comment updates
- Mark new API structures as experimental
- squash new function testpmd enablement into relevant patches.

V6:
- rebased to head of next-net
- fixed whitespace issues add in previous revision

The summary of the additions to the rte_flow are as follows:

- Add new flow actions RTE_RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP and
RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP to rte_flow to support
specfication of encapsulation and decapsulation of VXLAN and NVGRE
tunnels in hardware.
- Introduces support for the use of pipeline metadata in
the flow pattern definition and the population of metadata fields
from flow actions using the MARK flow and action items.
- Add shared flag to counters to enable statistics to be kept on
groups offlows such as all ingress/egress flows of a tunnel
- Adds jump_action to allow a flows to be redirected to a group
within the device.

A high level summary of the proposed usage model is as follows:

1. Decapsulation

1.1. Decapsulation of tunnel outer headers and forward all traffic
 to the same queue/s or port, would have the follow flows
 paramteters, sudo code used here.

struct rte_flow_attr attr = { .ingress = 1 };

struct rte_flow_item pattern[] = {
{ .type = RTE_FLOW_ITEM_TYPE_ETH,  .spec = ð_item },
{ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item },
{ .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &udp_item },
{ .type = RTE_FLOW_ITEM_TYPE_VxLAN, .spec = &vxlan_item },
{ .type = RTE_FLOW_ITEM_TYPE_END }
};



struct rte_flow_action actions[] = {
{ .type = RTE_FLOW_ACTION_TYPE_VXLAN_DECAP },
{ .type = RTE_FLOW_ACTION_TYPE_VF, .conf = &vf_action  },
{ .type = RTE_FLOW_ACTION_TYPE_END }
}

1.2.

Decapsulation of tunnel outer headers and matching on inner
headers, and forwarding to the same queue/s or port.

1.2.1.

The same scenario as above but either the application
or hardware requires configuration as 2 logically independent
operations (viewing it as 2 logical tables). The first stage
being the flow rule to define the pattern to match the tunnel
and the action to decapsulate the packet, and the second stage
stage table matches the inner header and defines the actions,
forward to port etc.

flow rule for outer header on table 0

struct rte_flow_attr attr = { .ingress = 1, .table = 0 };

struct rte_flow_item pattern[] = {
{ .type = RTE_FLOW_ITEM_TYPE_ETH,  .spec = ð_item },
{ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item },
{ .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &udp_item },
{ .type = RTE_FLOW_ITEM_TYPE_VxLAN, .spec = &vxlan_item },
{ .type = RTE_FLOW_ITEM_TYPE_END }
};

struct rte_flow_item_count shared_couter = {
.shared = 1,
.id = {counter_id}
}

struct rte_flow_action actions[] = {
{ .type = RTE_FLOW_ACTION_TYPE_COUNT, .conf = &shared_counter },
{ .type = RTE_FLOW_ACTION_TYPE_MARK, .conf = &mark_action },
{ .type = RTE_FLOW_ACTION_TYPE_VXLAN_DECAP },
{
  .type = RTE_FLOW_ACTION_TYPE_JUMP,
  .conf = { .group = 1 }
},
{ .type = RTE_FLOW_ACTION_TYPE_END }
}

flow rule for inner header on table 1

struct rte_flow_attr attr = { .ingress = 1, .group = 1 };

struct rte_flow_item_mark mark_item = { id = {mark_id} };

struct rte_flow_item pattern[] = {
{ .type = RTE_FLOW_ITEM_TYPE_MARK,  .spec = &mark_item },
{ .type = RTE_FLOW_ITEM_TYPE_ETH,  .spec = ð_item },
{ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item },
{ .type = RTE_FLOW_ITEM_TYPE_TCP, .spec = &tcp_item },
{ .type = RTE_FLOW_ITEM_TYPE_END }
};

struct rte_flow_action actions[] = {
{
  .type = RTE_FLOW_ACTION_TYPE_PORT_ID,
  .conf = &port_id_action = { port_id }
},
{ .type = RTE_FLOW_ACTION_TYPE_END 

[dpdk-dev] [PATCH v6 1/4] ethdev: Add tunnel encap/decap actions

[Declan Doherty]

Add new flow action types and associated action data structures to
support the encapsulation and decapsulation of VXLAN and NVGRE tunnel
endpoints.

The RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP action will cause the
matching flow to be encapsulated in the tunnel endpoint overlay
defined in the [vxlan/nvgre]_encap action data.

The RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP action will cause all
headers associated with the outer most tunnel endpoint of the specified
type for the matching flows.

Signed-off-by: Declan Doherty 
---
 doc/guides/prog_guide/rte_flow.rst | 107 +
 lib/librte_ether/rte_flow.h| 103 +++
 2 files changed, 210 insertions(+)

diff --git a/doc/guides/prog_guide/rte_flow.rst 
b/doc/guides/prog_guide/rte_flow.rst
index 629cc90a9..a7197cb7e 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -1909,6 +1909,113 @@ Implements ``OFPAT_PUSH_MPLS`` ("push a new MPLS tag") 
as defined by the
| ``ethertype`` | EtherType |
+---+---+
 
+Action: ``VXLAN_ENCAP``
+^^^
+
+Performs a VXLAN encapsulation action by encapsulating the matched flow in the
+VXLAN tunnel as defined in the``rte_flow_action_vxlan_encap`` flow items
+definition.
+
+This action modifies the payload of matched flows. The flow definition 
specified
+in the ``rte_flow_action_tunnel_encap`` action structure must define a valid
+VLXAN network overlay which conforms with RFC 7348 (Virtual eXtensible Local
+Area Network (VXLAN): A Framework for Overlaying Virtualized Layer 2 Networks
+over Layer 3 Networks). The pattern must be terminated with the
+RTE_FLOW_ITEM_TYPE_END item type.
+
+.. _table_rte_flow_action_vxlan_encap:
+
+.. table:: VXLAN_ENCAP
+
+   ++-+
+   | Field  | Value   |
+   ++=+
+   | ``definition`` | Tunnel end-point overlay definition |
+   ++-+
+
+.. _table_rte_flow_action_vxlan_encap_example:
+
+.. table:: IPv4 VxLAN flow pattern example.
+
+   +---+--+
+   | Index | Item |
+   +===+==+
+   | 0 | Ethernet |
+   +---+--+
+   | 1 | IPv4 |
+   +---+--+
+   | 2 | UDP  |
+   +---+--+
+   | 3 | VXLAN|
+   +---+--+
+   | 4 | END  |
+   +---+--+
+
+Action: ``VXLAN_DECAP``
+^^^
+
+Performs a decapsulation action by stripping all headers of the VXLAN tunnel
+network overlay from the matched flow.
+
+The flow items pattern defined for the flow rule with which a ``VXLAN_DECAP``
+action is specified, must define a valid VXLAN tunnel as per RFC7348. If the
+flow pattern does not specify a valid VXLAN tunnel then a
+RTE_FLOW_ERROR_TYPE_ACTION error should be returned.
+
+This action modifies the payload of matched flows.
+
+Action: ``NVGRE_ENCAP``
+^^^
+
+Performs a NVGRE encapsulation action by encapsulating the matched flow in the
+NVGRE tunnel as defined in the``rte_flow_action_tunnel_encap`` flow item
+definition.
+
+This action modifies the payload of matched flows. The flow definition 
specified
+in the ``rte_flow_action_tunnel_encap`` action structure must defined a valid
+NVGRE network overlay which conforms with RFC 7637 (NVGRE: Network
+Virtualization Using Generic Routing Encapsulation). The pattern must be
+terminated with the RTE_FLOW_ITEM_TYPE_END item type.
+
+.. _table_rte_flow_action_nvgre_encap:
+
+.. table:: NVGRE_ENCAP
+
+   ++-+
+   | Field  | Value   |
+   ++=+
+   | ``definition`` | NVGRE end-point overlay definition |
+   ++-+
+
+.. _table_rte_flow_action_nvgre_encap_example:
+
+.. table:: IPv4 NVGRE flow pattern example.
+
+   +---+--+
+   | Index | Item |
+   +===+==+
+   | 0 | Ethernet |
+   +---+--+
+   | 1 | IPv4 |
+   +---+--+
+   | 2 | NVGRE|
+   +---+--+
+   | 3 | END  |
+   +---+--+
+
+Action: ``NVGRE_DECAP``
+^^^
+
+Performs a decapsulation action by stripping all headers of the NVGRE tunnel
+network overlay from the matched flow.
+
+The flow items pattern defined for the flow rule with which a ``NVGRE_DECAP``
+action is specified, must define a valid NVGRE tunnel as per RFC7637. If the
+flow pattern does not specify a valid NVGRE tunnel then a
+RTE_FLOW_ERROR_TYPE_ACTION error should be returned.
+
+This action modifies the payload of matched flows.
+
 Negative types
 ~~
 
diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
index f70056fbd..657cb9a99 100

Re: [dpdk-dev] [PATCH v8 3/9] ethdev: add generic create/destroy ethdev APIs

[Ferruh Yigit]

On 4/26/2018 11:40 AM, Declan Doherty wrote:
> Add new bus generic ethdev create/destroy APIs which are bus independent
> and provide hooks for bus specific initialisation.
> 
> Signed-off-by: Declan Doherty 

<...>

> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * PMD helper function for cleaing up the resources of a ethdev port on it's
> + * destruction.
> + *
> + * @param ethdev
> + *   ethdev handle of port.
> + * @param ethdev
> + *   device specific port un-initialise callback function
> + *
> + * @return
> + *   Negative errno value on error, 0 on success.
> + */
> +int __rte_experimental
> +rte_eth_dev_destroy(struct rte_eth_dev *ethdev,
> + ethdev_uninit_t ethdev_uninit);

Will fix doxygen warning while applying, ethdev vs ethdev_uninit

[dpdk-dev] [PATCH v6 2/4] ethdev: Add group JUMP action

[Declan Doherty]

Add jump action type which defines an action which allows a matched
flow to be redirect to the specified group. This allows physical and
logical flow table/group hierarchies to be defined through rte_flow.

This breaks ABI compatibility for the following public functions (as it
modifes the ordering of the rte_flow_action_type enumeration):

- rte_flow_copy()
- rte_flow_create()
- rte_flow_query()
- rte_flow_validate()

Add support for specification of new JUMP action to testpmd's flow
cli, and update the testpmd documentation to describe this new
action.

Signed-off-by: Declan Doherty 
---
 app/test-pmd/cmdline_flow.c | 23 +++
 doc/guides/prog_guide/rte_flow.rst  | 61 -
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  4 ++
 lib/librte_ether/rte_flow.h | 41 +++
 4 files changed, 112 insertions(+), 17 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 4239602b6..6e9fa5d7c 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -183,6 +183,8 @@ enum index {
ACTION_END,
ACTION_VOID,
ACTION_PASSTHRU,
+   ACTION_JUMP,
+   ACTION_JUMP_GROUP,
ACTION_MARK,
ACTION_MARK_ID,
ACTION_FLAG,
@@ -738,6 +740,7 @@ static const enum index next_action[] = {
ACTION_END,
ACTION_VOID,
ACTION_PASSTHRU,
+   ACTION_JUMP,
ACTION_MARK,
ACTION_FLAG,
ACTION_QUEUE,
@@ -856,6 +859,12 @@ static const enum index action_of_push_mpls[] = {
ZERO,
 };
 
+static const enum index action_jump[] = {
+   ACTION_JUMP_GROUP,
+   ACTION_NEXT,
+   ZERO,
+};
+
 static int parse_init(struct context *, const struct token *,
  const char *, unsigned int,
  void *, unsigned int);
@@ -1931,6 +1940,20 @@ static const struct token token_list[] = {
.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
.call = parse_vc,
},
+   [ACTION_JUMP] = {
+   .name = "jump",
+   .help = "redirect traffic to a given group",
+   .priv = PRIV_ACTION(JUMP, sizeof(struct rte_flow_action_jump)),
+   .next = NEXT(action_jump),
+   .call = parse_vc,
+   },
+   [ACTION_JUMP_GROUP] = {
+   .name = "group",
+   .help = "group to redirect traffic to",
+   .next = NEXT(action_jump, NEXT_ENTRY(UNSIGNED)),
+   .args = ARGS(ARGS_ENTRY(struct rte_flow_action_jump, group)),
+   .call = parse_vc_conf,
+   },
[ACTION_MARK] = {
.name = "mark",
.help = "attach 32 bit value to packets",
diff --git a/doc/guides/prog_guide/rte_flow.rst 
b/doc/guides/prog_guide/rte_flow.rst
index a7197cb7e..1102fae09 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -90,8 +90,12 @@ Thus predictable results for a given priority level can only 
be achieved
 with non-overlapping rules, using perfect matching on all protocol layers.
 
 Flow rules can also be grouped, the flow rule priority is specific to the
-group they belong to. All flow rules in a given group are thus processed
-either before or after another group.
+group they belong to. All flow rules in a given group are thus processed within
+the context of that group. Groups are not linked by default, so the logical
+hierarchy of groups must be explicitly defined by flow rules themselves in each
+group using the JUMP action to define the next group to redirect too. Only flow
+rules defined in the default group 0 are guarantee to be matched against, this
+makes group 0 the origin of any group hierarchy defined by an application.
 
 Support for multiple actions per rule may be implemented internally on top
 of non-default hardware priorities, as a result both features may not be
@@ -138,29 +142,34 @@ Attributes
 Attribute: Group
 
 
-Flow rules can be grouped by assigning them a common group number. Lower
-values have higher priority. Group 0 has the highest priority.
+Flow rules can be grouped by assigning them a common group number. Groups
+allow a logical hierarchy of flow rule groups (tables) to be defined. These
+groups can be supported virtually in the PMD or in the physical device.
+Group 0 is the default group and this is the only group which flows are
+guarantee to matched against, all subsequent groups can only be reached by
+way of the JUMP action from a matched flow rule.
 
 Although optional, applications are encouraged to group similar rules as
 much as possible to fully take advantage of hardware capabilities
 (e.g. optimized matching) and work around limitations (e.g. a single pattern
-type possibly allowed in a given group).
+type possibly allowed in a given group), while being aware that the groups
+hierarchies must be programmed explicitly.
 
 Note that support for more than a

[dpdk-dev] [PATCH v6 3/4] ethdev: add mark flow item to rte_flow_item_types

[Declan Doherty]

Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables
flow patterns to specify arbitrary integer values to match aginst
set by the RTE_FLOW_ACTION_TYPE_MARK action in previously matched
flows.

Add support for specification of new MARK flow item in testpmd's cli.
Update testpmd documentation to describe new MARK flow item support.

Signed-off-by: Declan Doherty 
---
 app/test-pmd/cmdline_flow.c | 22 +
 doc/guides/prog_guide/rte_flow.rst  | 30 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  4 
 lib/librte_ether/rte_flow.h | 29 
 4 files changed, 85 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6e9fa5d7c..1ac04a0ab 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -91,6 +91,8 @@ enum index {
ITEM_PHY_PORT_INDEX,
ITEM_PORT_ID,
ITEM_PORT_ID_ID,
+   ITEM_MARK,
+   ITEM_MARK_ID,
ITEM_RAW,
ITEM_RAW_RELATIVE,
ITEM_RAW_SEARCH,
@@ -494,6 +496,7 @@ static const enum index next_item[] = {
ITEM_VF,
ITEM_PHY_PORT,
ITEM_PORT_ID,
+   ITEM_MARK,
ITEM_RAW,
ITEM_ETH,
ITEM_VLAN,
@@ -555,6 +558,12 @@ static const enum index item_port_id[] = {
ZERO,
 };
 
+static const enum index item_mark[] = {
+   ITEM_MARK_ID,
+   ITEM_NEXT,
+   ZERO,
+};
+
 static const enum index item_raw[] = {
ITEM_RAW_RELATIVE,
ITEM_RAW_SEARCH,
@@ -1289,6 +1298,19 @@ static const struct token token_list[] = {
.next = NEXT(item_port_id, NEXT_ENTRY(UNSIGNED), item_param),
.args = ARGS(ARGS_ENTRY(struct rte_flow_item_port_id, id)),
},
+   [ITEM_MARK] = {
+   .name = "mark",
+   .help = "match traffic against value set in previously matched 
rule",
+   .priv = PRIV_ITEM(MARK, sizeof(struct rte_flow_item_mark)),
+   .next = NEXT(item_mark),
+   .call = parse_vc,
+   },
+   [ITEM_MARK_ID] = {
+   .name = "id",
+   .help = "Integer value to match against",
+   .next = NEXT(item_mark, NEXT_ENTRY(UNSIGNED), item_param),
+   .args = ARGS(ARGS_ENTRY(struct rte_flow_item_mark, id)),
+   },
[ITEM_RAW] = {
.name = "raw",
.help = "match an arbitrary byte string",
diff --git a/doc/guides/prog_guide/rte_flow.rst 
b/doc/guides/prog_guide/rte_flow.rst
index 1102fae09..301f8762e 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -656,6 +656,36 @@ representor" depending on the kind of underlying device).
| ``mask`` | ``id``   | zeroed to match any port ID |
+--+--+-+
 
+Item: ``MARK``
+^^
+
+Matches an arbitrary integer value which was set using the ``MARK`` action in
+a previously matched rule.
+
+This item can only specified once as a match criteria as the ``MARK`` action 
can
+only be specified once in a flow action.
+
+Note the value of MARK field is arbitrary and application defined.
+
+Depending on the underlying implementation the MARK item may be supported on
+the physical device, with virtual groups in the PMD or not at all.
+
+- Default ``mask`` matches any integer value.
+
+.. _table_rte_flow_item_mark:
+
+.. table:: MARK
+
+   +--+--+---+
+   | Field| Subfield | Value |
+   +==+==+===+
+   | ``spec`` | ``id``   | integer value |
+   +--+--+
+   | ``last`` | ``id``   | upper range value |
+   +--+--+---+
+   | ``mask`` | ``id``   | zeroed to match any value |
+   +--+--- --+---+
+
 Data matching item types
 
 
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst 
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 260d044d5..013a40549 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3240,6 +3240,10 @@ This section lists supported pattern items and their 
attributes, if any.
 
   - ``id {unsigned}``: DPDK port ID.
 
+- ``mark``: match value set in previously matched flow rule using the mark 
action.
+
+  - ``id {unsigned}``: arbitrary integer value.
+
 - ``raw``: match an arbitrary byte string.
 
   - ``relative {boolean}``: look for pattern after the previous item.
diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
index 17c1c4a89..d390bbf5a 100644
--- a/lib/librte_ether/rte_flow.h
+++ b/lib/librte_ether/rte_flow.h
@@ -406,6 +406,13 @@ enum rte_flow_item_type {
 * See struct rte_flow_item_icmp6_nd_opt_tla_eth.
 */
RTE_FLOW_ITEM_TYPE_ICMP6_ND_OP

[dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to rte_flow

[Declan Doherty]

Add rte_flow_action_count action data structure to enable shared
counters across multiple flows on a single port or across multiple
flows on multiple ports within the same switch domain. Also this enables
multiple count actions to be specified in a single flow action.

This patch also modifies the existing rte_flow_query API to take the
rte_flow_action structure as an input parameter instead of the
rte_flow_action_type enumeration to allow querying a specific action
from a flow rule when multiple actions of the same type are specified.

This patch also contains updates for the bonding and failsafe PMDs and
testpmd application which are affected by this API change.

Signed-off-by: Declan Doherty 
---
 app/test-pmd/cmdline_flow.c |  6 ++--
 app/test-pmd/config.c   | 15 +
 app/test-pmd/testpmd.h  |  2 +-
 doc/guides/prog_guide/rte_flow.rst  | 59 +
 drivers/net/bonding/rte_eth_bond_flow.c |  9 ++---
 drivers/net/failsafe/failsafe_flow.c|  4 +--
 lib/librte_ether/rte_flow.c |  2 +-
 lib/librte_ether/rte_flow.h | 38 +++--
 lib/librte_ether/rte_flow_driver.h  |  2 +-
 9 files changed, 93 insertions(+), 44 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1ac04a0ab..5754e7858 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -420,7 +420,7 @@ struct buffer {
} destroy; /**< Destroy arguments. */
struct {
uint32_t rule;
-   enum rte_flow_action_type action;
+   struct rte_flow_action action;
} query; /**< Query arguments. */
struct {
uint32_t *group;
@@ -1101,7 +1101,7 @@ static const struct token token_list[] = {
.next = NEXT(NEXT_ENTRY(QUERY_ACTION),
 NEXT_ENTRY(RULE_ID),
 NEXT_ENTRY(PORT_ID)),
-   .args = ARGS(ARGS_ENTRY(struct buffer, args.query.action),
+   .args = ARGS(ARGS_ENTRY(struct buffer, args.query.action.type),
 ARGS_ENTRY(struct buffer, args.query.rule),
 ARGS_ENTRY(struct buffer, port)),
.call = parse_query,
@@ -3842,7 +3842,7 @@ cmd_flow_parsed(const struct buffer *in)
break;
case QUERY:
port_flow_query(in->port, in->args.query.rule,
-   in->args.query.action);
+   &in->args.query.action);
break;
case LIST:
port_flow_list(in->port, in->args.list.group_n,
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 0f2425229..cd6102dfc 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1452,7 +1452,7 @@ port_flow_flush(portid_t port_id)
 /** Query a flow rule. */
 int
 port_flow_query(portid_t port_id, uint32_t rule,
-   enum rte_flow_action_type action)
+   const struct rte_flow_action *action)
 {
struct rte_flow_error error;
struct rte_port *port;
@@ -1474,15 +1474,16 @@ port_flow_query(portid_t port_id, uint32_t rule,
return -ENOENT;
}
if ((unsigned int)action >= RTE_DIM(flow_action) ||
-   !flow_action[action].name)
+   !flow_action[action->type].name)
name = "unknown";
else
-   name = flow_action[action].name;
-   switch (action) {
+   name = flow_action[action->type].name;
+   switch (action->type) {
case RTE_FLOW_ACTION_TYPE_COUNT:
break;
default:
-   printf("Cannot query action type %d (%s)\n", action, name);
+   printf("Cannot query action type %d (%s)\n",
+   action->type, name);
return -ENOTSUP;
}
/* Poisoning to make sure PMDs update it in case of error. */
@@ -1490,7 +1491,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
memset(&query, 0, sizeof(query));
if (rte_flow_query(port_id, pf->flow, action, &query, &error))
return port_flow_complain(&error);
-   switch (action) {
+   switch (action->type) {
case RTE_FLOW_ACTION_TYPE_COUNT:
printf("%s:\n"
   " hits_set: %u\n"
@@ -1505,7 +1506,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
break;
default:
printf("Cannot display result for action type %d (%s)\n",
-  action, name);
+  action->type, name);
break;
}
return 0;
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index a33b525e2..1af87b8f4 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -620,7 +620,7 @@ int port_flow_create(portid_t port_id

Re: [dpdk-dev] [PATCH v8 7/9] ethdev: add switch domain allocator

[Ananyev, Konstantin]

> -Original Message-
> From: Doherty, Declan
> Sent: Thursday, April 26, 2018 11:41 AM
> To: dev@dpdk.org
> Cc: Adrien Mazarguil ; Yigit, Ferruh 
> ; Thomas Monjalon ;
> Shahaf Shuler ; Ananyev, Konstantin 
> ; Doherty, Declan
> 
> Subject: [dpdk-dev][PATCH v8 7/9] ethdev: add switch domain allocator
> 
> Add switch domain allocate and free API to enable NET devices to synchronise
> switch domain allocation.
> 
> Signed-off-by: Declan Doherty 
> ---
>  lib/librte_ether/rte_ethdev.c   | 54 
> +
>  lib/librte_ether/rte_ethdev_driver.h| 39 
>  lib/librte_ether/rte_ethdev_version.map |  2 ++
>  3 files changed, 95 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index cb85d8bb7..a09c7e5b3 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -4102,6 +4102,60 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const 
> char *pool)
>   return (*dev->dev_ops->pool_ops_supported)(dev, pool);
>  }
> 
> +/**
> + * A set of values to describe the possible states of a switch domain.
> + */
> +enum rte_eth_switch_domain_state {
> + RTE_ETH_SWITCH_DOMAIN_UNUSED = 0,
> + RTE_ETH_SWITCH_DOMAIN_ALLOCATED
> +};
> +
> +/**
> + * Array of switch domains available for allocation. Array is sized to
> + * RTE_MAX_ETHPORTS elements as there cannot be more active switch domains 
> than
> + * ethdev ports in a single process.
> + */

Question from previous version review:
Probably already discussed before, but  if we can't have more than one 
switch_id per port,
while we can't use port_id as switch_id?
Or switch_id can represent some other entity (not rte_ethdev)?
Konstantin

> +struct rte_eth_dev_switch {
> + enum rte_eth_switch_domain_state state;
> +} rte_eth_switch_domains[RTE_MAX_ETHPORTS];
> +
> +int __rte_experimental
> +rte_eth_switch_domain_alloc(uint16_t *domain_id)
> +{
> + unsigned int i;
> +
> + *domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
> +
> + for (i = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID + 1;
> + i < RTE_MAX_ETHPORTS; i++) {
> + if (rte_eth_switch_domains[i].state ==
> + RTE_ETH_SWITCH_DOMAIN_UNUSED) {
> + rte_eth_switch_domains[i].state =
> + RTE_ETH_SWITCH_DOMAIN_ALLOCATED;
> + *domain_id = i;
> + return 0;
> + }
> + }
> +
> + return -ENOSPC;
> +}
> +
> +int __rte_experimental
> +rte_eth_switch_domain_free(uint16_t domain_id)
> +{
> + if (domain_id == RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID ||
> + domain_id >= RTE_MAX_ETHPORTS)
> + return -EINVAL;
> +
> + if (rte_eth_switch_domains[domain_id].state !=
> + RTE_ETH_SWITCH_DOMAIN_ALLOCATED)
> + return -EINVAL;
> +
> + rte_eth_switch_domains[domain_id].state = RTE_ETH_SWITCH_DOMAIN_UNUSED;
> +
> + return 0;
> +}
> +
>  typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
> 
>  static int
> diff --git a/lib/librte_ether/rte_ethdev_driver.h 
> b/lib/librte_ether/rte_ethdev_driver.h
> index 492da754a..f428afa72 100644
> --- a/lib/librte_ether/rte_ethdev_driver.h
> +++ b/lib/librte_ether/rte_ethdev_driver.h
> @@ -188,6 +188,45 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev,
>  #endif
>  }
> 
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Allocate an unique switch domain identifier.
> + *
> + * A pool of switch domain identifiers which can be allocated on request. 
> This
> + * will enabled devices which support the concept of switch domains to 
> request
> + * a switch domain id which is guaranteed to be unique from other devices
> + * running in the same process.
> + *
> + * @param domain_id
> + *  switch domain identifier parameter to pass back to application
> + *
> + * @return
> + *   Negative errno value on error, 0 on success.
> + */
> +int __rte_experimental
> +rte_eth_switch_domain_alloc(uint16_t *domain_id);
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Free switch domain.
> + *
> + * Return a switch domain identifier to the pool of free identifiers after 
> it is
> + * no longer in use by device.
> + *
> + * @param domain_id
> + *  switch domain identifier to free
> + *
> + * @return
> + *   Negative errno value on error, 0 on success.
> + */
> +int __rte_experimental
> +rte_eth_switch_domain_free(uint16_t domain_id);
> +
> +
> 
>  /** Generic Ethernet device arguments  */
>  struct rte_eth_devargs {
> diff --git a/lib/librte_ether/rte_ethdev_version.map 
> b/lib/librte_ether/rte_ethdev_version.map
> index 41c3d2699..86f06769a 100644
> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -220,6 +220,8 @@ EXPERIMENTAL {
>   rte_eth_dev_rx_offload_name;
>   rte_eth_dev_tx_offload_na

[dpdk-dev] [PATCH v1] doc: add Inner RSS feature

[Xueming Li]

Signed-off-by: Xueming Li 
---
 doc/guides/nics/features.rst | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 57cdd1d59..b9f42d81b 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -278,6 +278,17 @@ Supports RSS hashing on RX.
 * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``.
 
 
+.. _nic_features_inner_rss:
+
+Inner RSS
+
+
+Supports RX RSS hashing on Inner headers.
+
+* **[users]rte_flow_action_rss**: ``level``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``.
+
+
 .. _nic_features_rss_key_update:
 
 RSS key update
-- 
2.13.3

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

[Alejandro Lucero]

Hi Stephen,

Thanks for this patch set.

I'm happy with it although I have some concerns regarding how the dynamic
logs work, or maybe I have a wrong understanding about it. I have tried to
read some doc about how it works, and I found the original patch from
Olivier the best source, so maybe things have changed a bit and my concerns
are unfounded.

I think it is OK to specifically add something like

--log-level='pmd\.i40e.*,8'

if you want to debug a PMD, but if you are an user and you just want to
know why the app is not finding any port, finding out the right string is
not trivial. For example, with an PF, the NFP PMD goes through a process
where the NFP device (no the NIC) is accessed first through a complex
interface, then firmware is uploaded, DPDK ports created (for multiport
devices), etc. I think any error in that process should be output if the
right loglevel is there and not just if the right log type was specifically
enabled. Is this what would happen with your patchset?

I have suffered silent configuration problems, like the NFP card being in
the wrong NUMA socket, and although I can solve that quickly because I have
the knowledge, other people using NFP with DPDK require someone to help
because they do not know what is going on. And this is usually bad because
they have another NIC card in the same host (in the right NUMA socket) and
the app just works smoothly then, leaving our NIC with a bad press. So I
think, some errors should always appear with the right loglevel configured.




On Wed, Apr 25, 2018 at 4:45 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:

> These are several small changes to make the Netronome driver
> use logging macros in the same way as other drivers.
>
> Compile tested only. I don't have Netronome hardware.
>
> Stephen Hemminger (5):
>   net/nfp: use correct logtype for init messages
>   net/nfp: add implied new line to PMD_DRV_LOG
>   net/nfp: fix double space in init log
>   net/nfl: add newline in PMD_RX/TX_LOG macros
>   net/nfp: use dynamic logging everywhere
>
>  drivers/net/nfp/nfp_net.c  | 186 -
>  drivers/net/nfp/nfp_net_logs.h |   9 +-
>  2 files changed, 98 insertions(+), 97 deletions(-)
>
> --
> 2.17.0
>
>

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

[Zhang, Qi Z]

Hi Tonghao:
Would you submit v4 with Ferruh' s fix and also do a rebase on next-net?
Thanks
Qi

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, April 19, 2018 12:10 AM
> To: Tonghao Zhang 
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Xing, Beilei ; Dai,
> Wei ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt
> interval for EITR.
> 
> On 4/18/2018 2:01 AM, Tonghao Zhang wrote:
> > On Tue, Apr 17, 2018 at 7:00 PM, Ferruh Yigit 
> wrote:
> >> On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote:
> >>> From: Tonghao Zhang 
> >>>
> >>> Set EITR interval as default. This patch can improve the performance
> >>> when we enable the rx-intrrupt to process the packets because we
> >>> hope rx-intrrupt reduce CPU. For example, the 200us value of EITR
> >>> makes the performance better with the low CPU.
> >>>
> >>> Users can configure the value of ITR via DPDK configuration.
> >>>
> >>> The default value of ITR is 500us, compatible with RSC of ixgbe PF,
> >>> and next patch will use the default value.
> >>>
> >>> Signed-off-by: Tonghao Zhang 
> >>> ---
> >>> v1 --> v2:
> >>> use the configure file, for different user.
> >>> suggested by Beilei Xing, http://dpdk.org/dev/patchwork/patch/32989
> >>> ---
> >>>  config/common_base   |  2 ++
> >>>  drivers/net/ixgbe/ixgbe_ethdev.c |  7 +++
> >>> drivers/net/ixgbe/ixgbe_ethdev.h | 12 
> >>>  3 files changed, 21 insertions(+)
> >>>
> >>> diff --git a/config/common_base b/config/common_base index
> >>> e74febe..2e9fded 100644
> >>> --- a/config/common_base
> >>> +++ b/config/common_base
> >>> @@ -196,6 +196,8 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n
> >>>  CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
> >>>  CONFIG_RTE_IXGBE_INC_VECTOR=y
> >>>  CONFIG_RTE_LIBRTE_IXGBE_BYPASS=n
> >>> +# interval up to 1024 us
> >>> +CONFIG_RTE_LIBRTE_IXGBE_ITR_INTERVAL=-1
> >>
> >> I can understand this is to let user to ability to fine tune this
> >> value, the down side is when number of these kind of tune parameters
> >> increased, it become confusing and config options because less useful or
> perhaps useless.
> >>
> >> And overall we are trying to reduce config options we have.
> >>
> >> I can see there is already some default values in the header file,
> >> what do you think removing the config option and go with default values
> defined in header?
> > v2 used the default value in header, but for configuring it like as
> > i40e option (CONFIG_RTE_LIBRTE_IXGBE_ITR_INTERVAL).
> > so v3 makes some changes. These patches may have been applied. For
> > reducing config option, should we do it in individual patches to fix
> > the ixgbe/i40e option ?
> 
> Patches are still in Helin's tree, so this up to him how manage.
> Since patches are not in main repo yet I would suggest making new version if
> fits to Helin.
> 
> >
> >>>
> >>>  #
> >>>  # Compile burst-oriented I40E PMD driver diff --git
> >>> a/drivers/net/ixgbe/ixgbe_ethdev.c
> >>> b/drivers/net/ixgbe/ixgbe_ethdev.c
> >>> index e67389f..495e72c 100644
> >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> >>> @@ -5780,6 +5780,13 @@ static void ixgbevf_set_vfta_all(struct
> rte_eth_dev *dev, bool on)
> >>>   if (vector_idx < base + intr_handle->nb_efd - 1)
> >>>   vector_idx++;
> >>>   }
> >>> +
> >>> + /* As RX queue setting above show, all queues use the vector 0.
> >>> +  * Set only the ITR value of IXGBE_MISC_VEC_ID.
> >>> +  */
> >>> + IXGBE_WRITE_REG(hw, IXGBE_VTEITR(IXGBE_MISC_VEC_ID),
> >>> +
> ixgbe_calc_itr_interval(RTE_LIBRTE_IXGBE_ITR_INTERVAL)
> >>> + | IXGBE_EITR_CNT_WDIS);
> >>>  }
> >>>
> >>>  /**
> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> >>> b/drivers/net/ixgbe/ixgbe_ethdev.h
> >>> index 1db29bd..c779001 100644
> >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> >>> @@ -58,6 +58,18 @@
> >>>   IXGBE_EITR_ITR_INT_MASK)
> >>>
> >>>
> >>> +#define IXGBE_QUEUE_ITR_INTERVAL_MAX 1024 /* 1024us */
> >>> +#define IXGBE_QUEUE_ITR_INTERVAL_DEFAULT 500 /* 500us */
> >>> +
> >>> +static inline uint16_t
> >>> +ixgbe_calc_itr_interval(int16_t interval) {
> >>> + if (interval < 0 || interval > IXGBE_QUEUE_ITR_INTERVAL_MAX)
> >>> + interval = IXGBE_QUEUE_ITR_INTERVAL_DEFAULT;
> >>> +
> >>> + return IXGBE_EITR_INTERVAL_US(interval); }
> >>> +
> >>>  /* Loopback operation modes */
> >>>  /* 82599 specific loopback operation types */
> >>>  #define IXGBE_LPBK_82599_NONE   0x0 /* Default value. Loopback
> is disabled. */
> >>>
> >>

Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

> -Original Message-
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 1:48 PM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: Mokhtar, Amr 
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo
> 

...

> > > Ok, we will deliver such changes in patches for next release. Are
> > > you ok with that?
> >
> > I think this change should not take a long time. The sooner we do it,
> > the better, as there might be more people using this in the future.
> > I can send the patch for you, so you can focus on other changes, and
> > then you can see if it is fine for you.
> >
> > Thanks,
> > Pablo
> 
> Ok. I will add this change to our patchset as well.

In order to make sure that users can still use the previous name, to avoid 
breaking
Backwards compatibility, you modify DRIVER_NAME with the new name and then use
RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, turbo_sw);
This way, both names can be used, but you should update the docs to use the new 
name.

Thanks,
Pablo

[dpdk-dev] [PATCH 01/13] baseband/turbo_sw: update DPDK to work with FlexRAN 1.4.0

[Kamil Chalupnik]

From: KamilX Chalupnik 

Adjusting BaseBand drivers code to changes in FlexRAN 1.4.0:
- update usage of crc functions after API changes

Update the documentation describing Wireless Baseband Device:
- FlexRAN releases mapping table added
- download and build instructions for BBDEV turbo_sw driver in
  compliance with FlexRAN 1.4.0 release added

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 doc/guides/bbdevs/turbo_sw.rst   | 50 
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 21 +-
 2 files changed, 35 insertions(+), 36 deletions(-)

diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst
index b3fed16..996b2a2 100644
--- a/doc/guides/bbdevs/turbo_sw.rst
+++ b/doc/guides/bbdevs/turbo_sw.rst
@@ -40,24 +40,37 @@ FlexRAN SDK Download
 
 
 To build DPDK with the *turbo_sw* PMD the user is required to download
-the export controlled ``FlexRAN SDK`` Libraries. An account at Intel Resource
-Design Center needs to be registered from
-``_.
+the export controlled ``FlexRAN SDK`` Libraries. An account at `Intel Resource
+Design Center 
`_
+needs to be registered.
 
 Once registered, the user needs to log in, and look for
-*Intel SWA_SW_FlexRAN_Release_Package R1_3_0* and click for download. Or use
-this direct download link ``_.
+*Intel FlexRAN Software Release Package 1_4_0* to download or directly through
+this `link `_.
 
 After download is complete, the user needs to unpack and compile on their
 system before building DPDK.
 
+The following table maps DPDK versions with past FlexRAN SDK releases:
+
+.. _table_flexran_releases:
+
+.. table:: DPDK and FlexRAN SDK releases compliance
+
+   =  
+   DPDK version   FlexRAN SDK release
+   =  
+   18.02  1.3.0
+   18.05  1.4.0
+   =  
+
 FlexRAN SDK Installation
 
 
 The following are pre-requisites for building FlexRAN SDK Libraries:
  (a) An AVX2 supporting machine
  (b) Windriver TS 2 or CentOS 7 operating systems
- (c) Intel ICC compiler installed
+ (c) Intel ICC 17.0.3 compiler installed
 
 The following instructions should be followed in this exact order:
 
@@ -68,30 +81,19 @@ The following instructions should be followed in this exact 
order:
 source /linux/bin/compilervars.sh 
intel64 -platform linux
 
 
-#. Extract the ``FlexRAN-1.3.0.tar.gz.zip`` package, then run the SDK extractor
-   script and accept the license:
+#. Extract the 
``576288-576288-intel-swa-sw-flexran-release-package-r1-4-0.zip``
+   package, then run the SDK extractor script and accept the license:
 
 .. code-block:: console
 
-cd /FlexRAN-1.3.0/
-./SDK-R1.3.0.sh
-
-#. To allow ``FlexRAN SDK R1.3.0`` to work with bbdev properly, the following
-   hotfix is required. Change the return of function 
``rate_matching_turbo_lte_avx2()``
-   located in file
-   
``/FlexRAN-1.3.0/SDK-R1.3.0/sdk/source/phy/lib_rate_matching/phy_rate_match_avx2.cpp``
-   to return 0 instead of 1.
-
-.. code-block:: c
-
--  return 1;
-+  return 0;
+cd /FlexRAN-1.4.0/
+./SDK-R1.4.0.sh
 
 #. Generate makefiles based on system configuration:
 
 .. code-block:: console
 
-cd /FlexRAN-1.3.0/SDK-R1.3.0/sdk/
+cd /FlexRAN-1.4.0/SDK-R1.4.0/sdk/
 ./create-makefiles-linux.sh
 
 #. A build folder is generated in this form ``build--``, enter that
@@ -118,8 +120,8 @@ Example:
 
 .. code-block:: console
 
-export 
FLEXRAN_SDK=/FlexRAN-1.3.0/SDK-R1.3.0/sdk/build-avx2-icc/install
-export DIR_WIRELESS_SDK=/FlexRAN-1.3.0/SDK-R1.3.0/sdk/
+export 
FLEXRAN_SDK=/FlexRAN-1.4.0/SDK-R1.4.0/sdk/build-avx2-icc/install
+export DIR_WIRELESS_SDK=/FlexRAN-1.4.0/SDK-R1.4.0/sdk/
 
 
 * Set ``CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=y`` in DPDK common configuration
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index 302abf5..26b8560 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -462,6 +462,7 @@ process_enc_cb(struct turbo_sw_queue *q, struct 
rte_bbdev_enc_op *op,
uint8_t *in, *out0, *out1, *out2, *tmp_out, *rm_out;
struct rte_bbdev_op_turbo_enc *enc = &op->turbo_enc;
struct bblib_crc_request crc_req;
+   struct bblib_crc_response crc_resp;
struct bblib_turbo_encoder_request turbo_req;
struct bblib_turbo_encoder_response turbo_resp;
struct bblib_rate_match_dl_request rm_req;
@@ -482,13 +483,11 @@ process_en

[dpdk-dev] [PATCH 03/13] doc/bbdev: dynamic lib support

[Kamil Chalupnik]

From: KamilX Chalupnik 

Added a note to enable building as a shared lib

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 doc/guides/bbdevs/turbo_sw.rst | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst
index 996b2a2..ffe6e36 100644
--- a/doc/guides/bbdevs/turbo_sw.rst
+++ b/doc/guides/bbdevs/turbo_sw.rst
@@ -96,6 +96,14 @@ The following instructions should be followed in this exact 
order:
 cd /FlexRAN-1.4.0/SDK-R1.4.0/sdk/
 ./create-makefiles-linux.sh
 
+#. If build as a shared library is required, then add ``"-fPIC"`` option to 
file
+   
``/FlexRAN-1.4.0/SDK-R1.4.0/sdk/cmake/intel-compile-options.cmake``
+   as follows:
+
+.. code-block:: console
+
+add_compile_options("-fPIC")
+
 #. A build folder is generated in this form ``build--``, enter that
folder and install:
 
-- 
2.5.5

[dpdk-dev] [PATCH 04/13] baseband/turbo_sw: memcpy changed or removed from driver

[Kamil Chalupnik]

From: KamilX Chalupnik 

Optimization of Turbo Software driver:
- usage of memcpy changed or removed
- minor changes in defines definitions

Signed-off-by: Kamil Chalupnik 
---
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 143 +--
 lib/librte_bbdev/rte_bbdev_op.h  |  18 ++-
 2 files changed, 100 insertions(+), 61 deletions(-)

diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index 26b8560..2728b30 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -32,12 +32,6 @@ static int bbdev_turbo_sw_logtype;
rte_bbdev_log(DEBUG, RTE_STR(__LINE__) ":%s() " fmt, __func__, \
##__VA_ARGS__)
 
-/* Number of columns in sub-block interleaver (36.212, section 5.1.4.1.1) */
-#define C_SUBBLOCK (32)
-#define MAX_TB_SIZE (391656)
-#define MAX_CB_SIZE (6144)
-#define MAX_KW (18528)
-
 /* private data structure */
 struct bbdev_private {
unsigned int max_nb_queues;  /**< Max number of queues */
@@ -90,7 +84,7 @@ compute_idx(uint16_t k)
 {
int32_t result = 0;
 
-   if (k < 40 || k > MAX_CB_SIZE)
+   if (k < RTE_BBDEV_MIN_CB_SIZE || k > RTE_BBDEV_MAX_CB_SIZE)
return -1;
 
if (k > 2048) {
@@ -234,7 +228,8 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->enc_out = rte_zmalloc_socket(name,
-   ((MAX_TB_SIZE >> 3) + 3) * sizeof(*q->enc_out) * 3,
+   ((RTE_BBDEV_MAX_TB_SIZE >> 3) + 3) *
+   sizeof(*q->enc_out) * 3,
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->enc_out == NULL) {
rte_bbdev_log(ERR,
@@ -253,7 +248,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->enc_in = rte_zmalloc_socket(name,
-   (MAX_CB_SIZE >> 3) * sizeof(*q->enc_in),
+   (RTE_BBDEV_MAX_CB_SIZE >> 3) * sizeof(*q->enc_in),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->enc_in == NULL) {
rte_bbdev_log(ERR,
@@ -271,7 +266,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->ag = rte_zmalloc_socket(name,
-   MAX_CB_SIZE * 10 * sizeof(*q->ag),
+   RTE_BBDEV_MAX_CB_SIZE * 10 * sizeof(*q->ag),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->ag == NULL) {
rte_bbdev_log(ERR,
@@ -308,7 +303,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->deint_input = rte_zmalloc_socket(name,
-   MAX_KW * sizeof(*q->deint_input),
+   RTE_BBDEV_MAX_KW * sizeof(*q->deint_input),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->deint_input == NULL) {
rte_bbdev_log(ERR,
@@ -327,7 +322,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->deint_output = rte_zmalloc_socket(NULL,
-   MAX_KW * sizeof(*q->deint_output),
+   RTE_BBDEV_MAX_KW * sizeof(*q->deint_output),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->deint_output == NULL) {
rte_bbdev_log(ERR,
@@ -346,7 +341,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->adapter_output = rte_zmalloc_socket(NULL,
-   MAX_CB_SIZE * 6 * sizeof(*q->adapter_output),
+   RTE_BBDEV_MAX_CB_SIZE * 6 * sizeof(*q->adapter_output),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->adapter_output == NULL) {
rte_bbdev_log(ERR,
@@ -414,9 +409,9 @@ is_enc_input_valid(const uint16_t k, const int32_t k_idx,
return -1;
}
 
-   if (k > MAX_CB_SIZE) {
+   if (k > RTE_BBDEV_MAX_CB_SIZE) {
rte_bbdev_log(ERR, "CB size (%u) is too big, max: %d",
-   k, MAX_CB_SIZE);
+   k, RTE_BBDEV_MAX_CB_SIZE);
return -1;
}
 
@@ -441,9 +436,9 @@ is_dec_input_valid(int32_t k_idx, int16_t kw, int16_t 
in_length)
return -1;
}
 
-   if (kw > MAX_KW) {
+   if (kw > RTE_BBDEV_MAX_KW) {
rte_bbdev_log(ERR, "Input length (%u) is too big, max: %d",
-   kw, MAX_KW);
+   kw, RTE_BBDEV_MAX_KW);
return -1;
}
 
@@ -452,7 +447,7 @@ is_dec_input_valid(int32_t k_idx, int16_t kw, int16_t 
in_length)
 
 static inline void
 process_enc_cb(struct turbo_sw_queue *q, struct rte_bbdev_enc_op *op,
-   uint8_t cb_idx, ui

[dpdk-dev] [PATCH 02/13] doc/turbo_sw: update Wireless Baseband Device documentation

[Kamil Chalupnik]

From: KamilX Chalupnik 

Update the documentation describing Wireless Baseband Device:
- device capabilities updated
- input/output data buffers description added
- details about implementation of turbo encode/decode
  operation added

Signed-off-by: Kamil Chalupnik 
---
 doc/guides/prog_guide/bbdev.rst | 237 +++-
 1 file changed, 212 insertions(+), 25 deletions(-)

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index d40c7f4..4616594 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -6,12 +6,12 @@ Wireless Baseband Device Library
 
 The Wireless Baseband library provides a common programming framework that
 abstracts HW accelerators based on FPGA and/or Fixed Function Accelerators that
-assist with 3gpp Physical Layer processing. Furthermore, it decouples the
+assist with 3GPP Physical Layer processing. Furthermore, it decouples the
 application from the compute-intensive wireless functions by abstracting their
 optimized libraries to appear as virtual bbdev devices.
 
 The functional scope of the BBDEV library are those functions in relation to
-the 3gpp Layer 1 signal processing (channel coding, modulation, ...).
+the 3GPP Layer 1 signal processing (channel coding, modulation, ...).
 
 The framework currently only supports Turbo Code FEC function.
 
@@ -167,7 +167,7 @@ Logical Cores, Memory and Queues Relationships
 ~~
 
 The bbdev device Library as the Poll Mode Driver library support NUMA for when
-a processor’s logical cores and interfaces utilize its local memory. Therefore
+a processor's logical cores and interfaces utilize its local memory. Therefore
 baseband operations, the mbuf being operated on should be allocated from memory
 pools created in the local memory. The buffers should, if possible, remain on
 the local processor to obtain the best performance results and buffer
@@ -202,7 +202,7 @@ structure in the *DPDK API Reference*.
 
 A device reports its capabilities when registering itself in the bbdev 
framework.
 With the aid of this capabilities mechanism, an application can query devices 
to
-discover which operations within the 3gpp physical layer they are capable of
+discover which operations within the 3GPP physical layer they are capable of
 performing. Below is an example of the capabilities for a PMD it supports in
 relation to Turbo Encoding and Decoding operations.
 
@@ -216,7 +216,10 @@ relation to Turbo Encoding and Decoding operations.
 RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE |
 RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN |
 RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN |
-RTE_BBDEV_TURBO_CRC_TYPE_24B,
+RTE_BBDEV_TURBO_CRC_TYPE_24B |
+RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP |
+RTE_BBDEV_TURBO_EARLY_TERMINATION,
+.max_llr_modulus = 16,
 .num_buffers_src = RTE_BBDEV_MAX_CODE_BLOCKS,
 .num_buffers_hard_out =
 RTE_BBDEV_MAX_CODE_BLOCKS,
@@ -228,6 +231,7 @@ relation to Turbo Encoding and Decoding operations.
 .cap.turbo_enc = {
 .capability_flags =
 RTE_BBDEV_TURBO_CRC_24B_ATTACH |
+RTE_BBDEV_TURBO_CRC_24A_ATTACH |
 RTE_BBDEV_TURBO_RATE_MATCH |
 RTE_BBDEV_TURBO_RV_INDEX_BYPASS,
 .num_buffers_src = RTE_BBDEV_MAX_CODE_BLOCKS,
@@ -391,27 +395,101 @@ operation to its allocating pool.
 void rte_bbdev_enc_op_free_bulk(struct rte_bbdev_enc_op **ops,
 unsigned int num_ops)
 
-BBDEV Operations
-
+BBDEV Inbound/Outbound Memory
+~
 
 The bbdev operation structure contains all the mutable data relating to
-performing Turbo code processing on a referenced mbuf data buffer. It is used
-for either encode or decode operations.
+performing Turbo coding on a referenced mbuf data buffer. It is used for either
+encode or decode operations.
 
 Turbo Encode operation accepts one input and one output.
-
 Turbo Decode operation accepts one input and two outputs, called 
*hard-decision*
 and *soft-decision* outputs. *Soft-decision* output is optional.
 
-It is expected that the application provides input and output ``mbuf`` pointers
+It is expected that the application provides input and output mbuf pointers
 allocated and ready to use. The baseband framework supports turbo coding on
 Code Blocks (CB) and Transport Blocks (TB).
 
-For the output buffer(s), the application needs only to provide an allocated 
and
-free mbuf (containing only one mbuf segment), so that bbdev can write the
-operation outcome.
+For the output buffer(s), the application is required to provide an allocated
+and free mbuf, so that bbdev write back the resulting output.
+
+The support of split "scattered" buffers 

[dpdk-dev] [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-16 16]

[Kamil Chalupnik]

From: KamilX Chalupnik 

Update Turbo Software driver for Wireless Baseband Device:
- function scaling input LLR values to specific range [-16, 16] added
- new test vectors to check device capabilities added

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 app/test-bbdev/Makefile|  2 +
 app/test-bbdev/test_bbdev_perf.c   | 44 +-
 .../test_vectors/turbo_enc_c1_k40_r0_e1190_rm.data | 36 ++
 .../test_vectors/turbo_enc_c1_k40_r0_e1194_rm.data | 36 ++
 .../test_vectors/turbo_enc_c1_k40_r0_e1196_rm.data | 36 ++
 .../test_vectors/turbo_enc_c1_k40_r0_e272_rm.data  | 33 
 doc/guides/tools/testbbdev.rst |  7 
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   | 32 
 lib/librte_bbdev/rte_bbdev_op.h|  4 ++
 9 files changed, 220 insertions(+), 10 deletions(-)
 create mode 100644 
app/test-bbdev/test_vectors/turbo_enc_c1_k40_r0_e1190_rm.data
 create mode 100644 
app/test-bbdev/test_vectors/turbo_enc_c1_k40_r0_e1194_rm.data
 create mode 100644 
app/test-bbdev/test_vectors/turbo_enc_c1_k40_r0_e1196_rm.data
 create mode 100644 app/test-bbdev/test_vectors/turbo_enc_c1_k40_r0_e272_rm.data

diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile
index 9aedd77..6da0c8e 100644
--- a/app/test-bbdev/Makefile
+++ b/app/test-bbdev/Makefile
@@ -20,4 +20,6 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) += test_bbdev.c
 SRCS-$(CONFIG_RTE_TEST_BBDEV) += test_bbdev_perf.c
 SRCS-$(CONFIG_RTE_TEST_BBDEV) += test_bbdev_vector.c
 
+LDLIBS += -lm
+
 include $(RTE_SDK)/mk/rte.app.mk
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 00f3b08..0a2fdd3 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -4,6 +4,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -609,10 +610,32 @@ allocate_buffers_on_socket(struct rte_bbdev_op_data 
**buffers, const int len,
return (*buffers == NULL) ? TEST_FAILED : TEST_SUCCESS;
 }
 
+static void
+limit_input_llr_val_range(struct rte_bbdev_op_data *input_ops,
+   const uint16_t n, const int8_t max_llr_modulus)
+{
+   uint16_t i, byte_idx;
+
+   for (i = 0; i < n; ++i) {
+   struct rte_mbuf *m = input_ops[i].data;
+   while (m != NULL) {
+   int8_t *llr = rte_pktmbuf_mtod_offset(m, int8_t *,
+   input_ops[i].offset);
+   for (byte_idx = 0; byte_idx < input_ops[i].length;
+   ++byte_idx)
+   llr[byte_idx] = round((double)max_llr_modulus *
+   llr[byte_idx] / INT8_MAX);
+
+   m = m->next;
+   }
+   }
+}
+
 static int
 fill_queue_buffers(struct test_op_params *op_params,
struct rte_mempool *in_mp, struct rte_mempool *hard_out_mp,
struct rte_mempool *soft_out_mp, uint16_t queue_id,
+   const struct rte_bbdev_op_cap *capabilities,
uint16_t min_alignment, const int socket_id)
 {
int ret;
@@ -649,6 +672,10 @@ fill_queue_buffers(struct test_op_params *op_params,
"Couldn't init rte_bbdev_op_data structs");
}
 
+   if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC)
+   limit_input_llr_val_range(*queue_ops[DATA_INPUT], n,
+   capabilities->cap.turbo_dec.max_llr_modulus);
+
return 0;
 }
 
@@ -995,6 +1022,7 @@ run_test_case_on_device(test_case_function 
*test_case_func, uint8_t dev_id,
struct active_device *ad;
unsigned int burst_sz = get_burst_sz();
enum rte_bbdev_op_type op_type = test_vector.op_type;
+   const struct rte_bbdev_op_cap *capabilities = NULL;
 
ad = &active_devs[dev_id];
 
@@ -1027,9 +1055,20 @@ run_test_case_on_device(test_case_function 
*test_case_func, uint8_t dev_id,
goto fail;
}
 
-   if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC)
+   if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC) {
+   /* Find Decoder capabilities */
+   const struct rte_bbdev_op_cap *cap = info.drv.capabilities;
+   while (cap->type != RTE_BBDEV_OP_NONE) {
+   if (cap->type == RTE_BBDEV_OP_TURBO_DEC) {
+   capabilities = cap;
+   break;
+   }
+   }
+   TEST_ASSERT_NOT_NULL(capabilities,
+   "Couldn't find Decoder capabilities");
+
create_reference_dec_op(op_params->ref_dec_op);
-   else if (test_vector.op_type == RTE_BBDEV_OP_TURBO_ENC)
+   } else if (test_vector.op_type == RTE_BBDEV_OP_TURBO_ENC)
create_reference_enc_op(op_params->ref_enc_op);
 
   

[dpdk-dev] [PATCH 07/13] baseband/turbo_sw: support for optional CRC overlap

[Kamil Chalupnik]

From: KamilX Chalupnik 

Support for optional CRC overlap in decode processing implemented
in Turbo Software driver

Signed-off-by: Kamil Chalupnik 
---
 app/test-bbdev/test_bbdev_vector.c   |  2 ++
 doc/guides/bbdevs/turbo_sw.rst   |  2 ++
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 21 ++---
 lib/librte_bbdev/rte_bbdev_op.h  |  6 +-
 4 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_vector.c 
b/app/test-bbdev/test_bbdev_vector.c
index addef05..a37e35f 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -144,6 +144,8 @@ op_decoder_flag_strtoul(char *token, uint32_t 
*op_flag_value)
*op_flag_value = RTE_BBDEV_TURBO_MAP_DEC;
else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_SCATTER_GATHER"))
*op_flag_value = RTE_BBDEV_TURBO_DEC_SCATTER_GATHER;
+   else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP"))
+   *op_flag_value = RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP;
else {
printf("The given value is not a turbo decoder flag\n");
return -1;
diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst
index ffe6e36..914b972 100644
--- a/doc/guides/bbdevs/turbo_sw.rst
+++ b/doc/guides/bbdevs/turbo_sw.rst
@@ -26,6 +26,8 @@ For the decode operation:
 * ``RTE_BBDEV_TURBO_CRC_TYPE_24B``
 * ``RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN``
 * ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN``
+* ``RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP``
+* ``RTE_BBDEV_TURBO_EARLY_TERMINATION``
 
 
 Limitations
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index 7ee5405..1664fca 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -138,6 +138,7 @@ info_get(struct rte_bbdev *dev, struct 
rte_bbdev_driver_info *dev_info)
RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN |
RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN |
RTE_BBDEV_TURBO_CRC_TYPE_24B |
+   RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP |
RTE_BBDEV_TURBO_EARLY_TERMINATION,
.max_llr_modulus = 16,
.num_buffers_src = RTE_BBDEV_MAX_CODE_BLOCKS,
@@ -862,7 +863,7 @@ static inline void
 process_dec_cb(struct turbo_sw_queue *q, struct rte_bbdev_dec_op *op,
uint8_t c, uint16_t k, uint16_t kw, struct rte_mbuf *m_in,
struct rte_mbuf *m_out, uint16_t in_offset, uint16_t out_offset,
-   bool check_crc_24b, uint16_t total_left)
+   bool check_crc_24b, uint16_t crc24_overlap, uint16_t total_left)
 {
int ret;
int32_t k_idx;
@@ -920,7 +921,7 @@ process_dec_cb(struct turbo_sw_queue *q, struct 
rte_bbdev_dec_op *op,
adapter_resp.pharqout = q->adapter_output;
bblib_turbo_adapter_ul(&adapter_req, &adapter_resp);
 
-   out = (uint8_t *)rte_pktmbuf_append(m_out, (k >> 3));
+   out = (uint8_t *)rte_pktmbuf_append(m_out, ((k - crc24_overlap) >> 3));
if (out == NULL) {
op->status |= 1 << RTE_BBDEV_DATA_ERROR;
rte_bbdev_log(ERR, "Too little space in output mbuf");
@@ -960,6 +961,7 @@ enqueue_dec_one_op(struct turbo_sw_queue *q, struct 
rte_bbdev_dec_op *op)
 {
uint8_t c, r = 0;
uint16_t kw, k = 0;
+   uint16_t crc24_overlap = 0;
struct rte_bbdev_op_turbo_dec *dec = &op->turbo_dec;
struct rte_mbuf *m_in = dec->input.data;
struct rte_mbuf *m_out = dec->hard_output.data;
@@ -983,6 +985,10 @@ enqueue_dec_one_op(struct turbo_sw_queue *q, struct 
rte_bbdev_dec_op *op)
c = 1;
}
 
+   if ((c > 1) && !check_bit(dec->op_flags,
+   RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP))
+   crc24_overlap = 24;
+
while (total_left > 0) {
if (dec->code_block_mode == 0)
k = (r < dec->tb_params.c_neg) ?
@@ -1002,17 +1008,18 @@ enqueue_dec_one_op(struct turbo_sw_queue *q, struct 
rte_bbdev_dec_op *op)
 
process_dec_cb(q, op, c, k, kw, m_in, m_out, in_offset,
out_offset, check_bit(dec->op_flags,
-   RTE_BBDEV_TURBO_CRC_TYPE_24B), total_left);
-   /* As a result of decoding we get Code Block with included
-* decoded CRC24 at the end of Code Block. Type of CRC24 is
-* specified by flag.
+   RTE_BBDEV_TURBO_CRC_TYPE_24B), crc24_overlap,
+   total_left);
+   /* To keep CRC24 attached to end of Code block, use
+* RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP flag as it
+* removed by d

[dpdk-dev] [PATCH 06/13] baseband/turbo_sw: increase internal buffers

[Kamil Chalupnik]

From: KamilX Chalupnik 

Sizes of the internal buffers used by decoding were increased due to
problem with memory for large vectors

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 drivers/baseband/turbo_sw/bbdev_turbo_software.c | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index 14a4e0e..7ee5405 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -32,6 +32,10 @@ static int bbdev_turbo_sw_logtype;
rte_bbdev_log(DEBUG, RTE_STR(__LINE__) ":%s() " fmt, __func__, \
##__VA_ARGS__)
 
+#define DEINT_INPUT_BUF_SIZE (((RTE_BBDEV_MAX_CB_SIZE >> 3) + 1) * 48)
+#define DEINT_OUTPUT_BUF_SIZE (DEINT_INPUT_BUF_SIZE * 6)
+#define ADAPTER_OUTPUT_BUF_SIZE ((RTE_BBDEV_MAX_CB_SIZE + 4) * 48)
+
 /* private data structure */
 struct bbdev_private {
unsigned int max_nb_queues;  /**< Max number of queues */
@@ -285,7 +289,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->code_block = rte_zmalloc_socket(name,
-   (6144 >> 3) * sizeof(*q->code_block),
+   RTE_BBDEV_MAX_CB_SIZE * sizeof(*q->code_block),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->code_block == NULL) {
rte_bbdev_log(ERR,
@@ -304,7 +308,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->deint_input = rte_zmalloc_socket(name,
-   RTE_BBDEV_MAX_KW * sizeof(*q->deint_input),
+   DEINT_INPUT_BUF_SIZE * sizeof(*q->deint_input),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->deint_input == NULL) {
rte_bbdev_log(ERR,
@@ -323,7 +327,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->deint_output = rte_zmalloc_socket(NULL,
-   RTE_BBDEV_MAX_KW * sizeof(*q->deint_output),
+   DEINT_OUTPUT_BUF_SIZE * sizeof(*q->deint_output),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->deint_output == NULL) {
rte_bbdev_log(ERR,
@@ -342,7 +346,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,
return -ENAMETOOLONG;
}
q->adapter_output = rte_zmalloc_socket(NULL,
-   RTE_BBDEV_MAX_CB_SIZE * 6 * sizeof(*q->adapter_output),
+   ADAPTER_OUTPUT_BUF_SIZE * sizeof(*q->adapter_output),
RTE_CACHE_LINE_SIZE, queue_conf->socket);
if (q->adapter_output == NULL) {
rte_bbdev_log(ERR,
-- 
2.5.5

[dpdk-dev] [PATCH 09/13] bbdev: measure offload cost

[Kamil Chalupnik]

From: KamilX Chalupnik 

New test created to measure offload cost.
Changes were introduced in API, turbo software driver
and test application

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 app/test-bbdev/test_bbdev_perf.c | 333 ++-
 drivers/baseband/turbo_sw/bbdev_turbo_software.c |  55 +++-
 lib/librte_bbdev/rte_bbdev.h |   4 +
 3 files changed, 313 insertions(+), 79 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 0a2fdd3..d9b34e2 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -84,6 +84,28 @@ struct thread_params {
struct test_op_params *op_params;
 };
 
+/* Stores time statistics */
+struct test_time_stats {
+   /* Stores software enqueue total working time */
+   uint64_t enq_sw_tot_time;
+   /* Stores minimum value of software enqueue working time */
+   uint64_t enq_sw_min_time;
+   /* Stores maximum value of software enqueue working time */
+   uint64_t enq_sw_max_time;
+   /* Stores turbo enqueue total working time */
+   uint64_t enq_tur_tot_time;
+   /* Stores minimum value of turbo enqueue working time */
+   uint64_t enq_tur_min_time;
+   /* Stores maximum value of turbo enqueue working time */
+   uint64_t enq_tur_max_time;
+   /* Stores dequeue total working time */
+   uint64_t deq_tot_time;
+   /* Stores minimum value of dequeue working time */
+   uint64_t deq_min_time;
+   /* Stores maximum value of dequeue working time */
+   uint64_t deq_max_time;
+};
+
 typedef int (test_case_function)(struct active_device *ad,
struct test_op_params *op_params);
 
@@ -1144,7 +1166,6 @@ dequeue_event_callback(uint16_t dev_id,
double in_len;
 
struct thread_params *tp = cb_arg;
-
RTE_SET_USED(ret_param);
queue_id = tp->queue_id;
 
@@ -1689,20 +1710,21 @@ throughput_test(struct active_device *ad,
 }
 
 static int
-operation_latency_test_dec(struct rte_mempool *mempool,
+latency_test_dec(struct rte_mempool *mempool,
struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op,
int vector_mask, uint16_t dev_id, uint16_t queue_id,
const uint16_t num_to_process, uint16_t burst_sz,
-   uint64_t *total_time)
+   uint64_t *total_time, uint64_t *min_time, uint64_t *max_time)
 {
int ret = TEST_SUCCESS;
uint16_t i, j, dequeued;
struct rte_bbdev_dec_op *ops_enq[MAX_BURST], *ops_deq[MAX_BURST];
-   uint64_t start_time = 0;
+   uint64_t start_time = 0, last_time = 0;
 
for (i = 0, dequeued = 0; dequeued < num_to_process; ++i) {
uint16_t enq = 0, deq = 0;
bool first_time = true;
+   last_time = 0;
 
if (unlikely(num_to_process - dequeued < burst_sz))
burst_sz = num_to_process - dequeued;
@@ -1732,11 +1754,15 @@ operation_latency_test_dec(struct rte_mempool *mempool,
deq += rte_bbdev_dequeue_dec_ops(dev_id, queue_id,
&ops_deq[deq], burst_sz - deq);
if (likely(first_time && (deq > 0))) {
-   *total_time += rte_rdtsc_precise() - start_time;
+   last_time = rte_rdtsc_precise() - start_time;
first_time = false;
}
} while (unlikely(burst_sz != deq));
 
+   *max_time = RTE_MAX(*max_time, last_time);
+   *min_time = RTE_MIN(*min_time, last_time);
+   *total_time += last_time;
+
if (test_vector.op_type != RTE_BBDEV_OP_NONE) {
ret = validate_dec_op(ops_deq, burst_sz, ref_op,
vector_mask);
@@ -1751,20 +1777,21 @@ operation_latency_test_dec(struct rte_mempool *mempool,
 }
 
 static int
-operation_latency_test_enc(struct rte_mempool *mempool,
+latency_test_enc(struct rte_mempool *mempool,
struct test_buffers *bufs, struct rte_bbdev_enc_op *ref_op,
uint16_t dev_id, uint16_t queue_id,
const uint16_t num_to_process, uint16_t burst_sz,
-   uint64_t *total_time)
+   uint64_t *total_time, uint64_t *min_time, uint64_t *max_time)
 {
int ret = TEST_SUCCESS;
uint16_t i, j, dequeued;
struct rte_bbdev_enc_op *ops_enq[MAX_BURST], *ops_deq[MAX_BURST];
-   uint64_t start_time = 0;
+   uint64_t start_time = 0, last_time = 0;
 
for (i = 0, dequeued = 0; dequeued < num_to_process; ++i) {
uint16_t enq = 0, deq = 0;
bool first_time = true;
+   last_time = 0;
 
if (unlikely(num_to_process - dequeued < burst_sz))
burst_sz = num_to_process - dequeued;
@@ -1793,

[dpdk-dev] [PATCH 10/13] doc: update tests and usage of test app description

[Kamil Chalupnik]

From: KamilX Chalupnik 

Update the test app documentation:
- description of tests added
- usage of test app updated

Signed-off-by: Kamil Chalupnik 
Acked-by: Amr Mokhtar 
---
 doc/guides/tools/testbbdev.rst | 74 +++---
 1 file changed, 48 insertions(+), 26 deletions(-)

diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst
index c399286..40606b3 100644
--- a/doc/guides/tools/testbbdev.rst
+++ b/doc/guides/tools/testbbdev.rst
@@ -70,30 +70,6 @@ The following are the command-line options:
 ``-c TEST_CASE [TEST_CASE ...], --test_cases TEST_CASE [TEST_CASE ...]``
  Defines test cases to run. If not specified all available tests are run.
 
- The following tests can be run:
-
- * unittest
- Small unit tests witch check basic functionality of bbdev library.
- * latency
- Test calculates three latency metrics:
-
- * offload_latency_tc
- measures the cost of offloading enqueue and dequeue operations.
- * offload_latency_empty_q_tc
- measures the cost of offloading a dequeue operation from an empty 
queue.
- checks how long last dequeueing if there is no operations to dequeue
- * operation_latency_tc
- measures the time difference from the first attempt to enqueue till 
the
- first successful dequeue.
- * validation
- Test do enqueue on given vector and compare output after dequeueing.
- * throughput
- Test measures the achieved throughput on the available lcores.
- Results are printed in million operations per second and million bits per 
second.
- * interrupt
- The same test as 'throughput' but uses interrupts instead of PMD to 
perform
- the dequeue.
-
  **Example usage:**
 
  ``./test-bbdev.py -c validation``
@@ -130,8 +106,54 @@ The following are the command-line options:
  Specifies operations enqueue/dequeue burst size. If not specified burst_size 
is
  set to 32. Maximum is 512.
 
-
-Parameter globbing
+Test Cases
+~~
+
+There are 6 main test cases that can be executed using testbbdev tool:
+
+* Sanity checks [-c unittest]
+- Performs sanity checks on BBDEV interface, validating basic functionality
+
+* Validation tests [-c validation]
+- Performs full operation of enqueue and dequeue
+- Compares the dequeued data buffer with a expected values in the test
+  vector (TV) being used
+- Fails if any dequeued value does not match the data in the TV
+
+* Offload Cost measurement [-c offload]
+- Measures the CPU cycles consumed from the receipt of a user enqueue
+  until it is put on the device queue
+- The test measures 4 metrics
+(a) *SW Enq Offload Cost*: Software only enqueue offload cost, the 
cycle
+counts and time (us) from the point the enqueue API is called until
+the point the operation is put on the accelerator queue.
+(b) *Acc Enq Offload Cost*: The cycle count and time (us) from the
+point the operation is put on the accelerator queue until the 
return
+from enqueue.
+(c) *SW Deq Offload Cost*: Software dequeue cost, the cycle counts and
+time (us) consumed to dequeue one operation.
+(d) *Empty Queue Enq Offload Cost*: The cycle count and time (us)
+consumed to dequeue from an empty queue.
+
+* Latency measurement [-c latency]
+- Measures the time consumed from the first enqueue until the first
+  appearance of a dequeued result
+- This measurment represents the full latency of a bbdev operation
+  (encode or decode) to execute
+
+* Poll-mode Throughput measurement [-c throughput]
+- Performs full operation of enqueue and dequeue
+- Executes in poll mode
+- Measures the achieved throughput on a subset or all available CPU cores
+- Dequeued data is not validated against expected values stored in TV
+- Results are printed in million operations per second and million bits
+  per second
+
+* Interrupt-mode Throughput [-c interrupt]
+- Similar to Throughput test case, but using interrupts. No polling.
+
+
+Parameter Globbing
 ~~
 
 Thanks to the globbing functionality in python test-bbdev.py script allows to
-- 
2.5.5

[dpdk-dev] [PATCH 08/13] app/bbdev: update test vectors names

[Kamil Chalupnik]

From: KamilX Chalupnik 

Update test vectors directory for Wireless Baseband Device:
- update test vectors names
- python script used for tests execution updated

Update the test app documentation:
- vector test names updated

Signed-off-by: Kamil Chalupnik 
---
 app/test-bbdev/test-bbdev.py   |   2 +-
 app/test-bbdev/test_vectors/bbdev_null.data|   5 +
 app/test-bbdev/test_vectors/bbdev_vector_null.data |   5 -
 .../test_vectors/bbdev_vector_td_default.data  |  54 --
 .../test_vectors/bbdev_vector_te_default.data  |  33 --
 ...k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data | 643 +
 .../turbo_enc_c1_k6144_r0_e32256_crc24b_rm.data| 180 ++
 app/test-bbdev/turbo_dec_default.data  |   1 +
 app/test-bbdev/turbo_enc_default.data  |   1 +
 doc/guides/tools/testbbdev.rst |  52 +-
 10 files changed, 860 insertions(+), 116 deletions(-)
 create mode 100644 app/test-bbdev/test_vectors/bbdev_null.data
 delete mode 100644 app/test-bbdev/test_vectors/bbdev_vector_null.data
 delete mode 100644 app/test-bbdev/test_vectors/bbdev_vector_td_default.data
 delete mode 100644 app/test-bbdev/test_vectors/bbdev_vector_te_default.data
 create mode 100644 
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data
 create mode 100644 
app/test-bbdev/test_vectors/turbo_enc_c1_k6144_r0_e32256_crc24b_rm.data
 create mode 12 app/test-bbdev/turbo_dec_default.data
 create mode 12 app/test-bbdev/turbo_enc_default.data

diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
index ce78149..e3b1e6c 100755
--- a/app/test-bbdev/test-bbdev.py
+++ b/app/test-bbdev/test-bbdev.py
@@ -45,7 +45,7 @@ def kill(process):
 nargs="+",
 help="Specifies paths to the test vector files.",
 default=[dpdk_path +
-"/app/test-bbdev/test_vectors/bbdev_vector_null.data"])
+"/app/test-bbdev/test_vectors/bbdev_null.data"])
 parser.add_argument("-n", "--num-ops",
 type=int,
 help="Number of operations to process on device.",
diff --git a/app/test-bbdev/test_vectors/bbdev_null.data 
b/app/test-bbdev/test_vectors/bbdev_null.data
new file mode 100644
index 000..c9a9abe
--- /dev/null
+++ b/app/test-bbdev/test_vectors/bbdev_null.data
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Intel Corporation
+
+op_type =
+RTE_BBDEV_OP_NONE
\ No newline at end of file
diff --git a/app/test-bbdev/test_vectors/bbdev_vector_null.data 
b/app/test-bbdev/test_vectors/bbdev_vector_null.data
deleted file mode 100644
index c9a9abe..000
--- a/app/test-bbdev/test_vectors/bbdev_vector_null.data
+++ /dev/null
@@ -1,5 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2017 Intel Corporation
-
-op_type =
-RTE_BBDEV_OP_NONE
\ No newline at end of file
diff --git a/app/test-bbdev/test_vectors/bbdev_vector_td_default.data 
b/app/test-bbdev/test_vectors/bbdev_vector_td_default.data
deleted file mode 100644
index b5c3027..000
--- a/app/test-bbdev/test_vectors/bbdev_vector_td_default.data
+++ /dev/null
@@ -1,54 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2017 Intel Corporation
-
-op_type =
-RTE_BBDEV_OP_TURBO_DEC
-
-input0 =
-0x7f007f00, 0x7f817f00, 0x767f8100, 0x817f8100, 0x81008100, 0x7f818100, 
0x81817f00, 0x7f818100,
-0x86007f00, 0x7f818100, 0x887f8100, 0x81815200, 0x81008100, 0x817f7f00, 
0x7f7f8100, 0x9e817f00,
-0x7f7f, 0xb97f, 0xa781, 0x7f7f4a7f, 0x7f81, 0x7f7f7f7f, 
0x8172, 0x40658181,
-0x8481, 0x817f, 0x8181, 0x7f818181, 0x7f81, 0x81815a81, 
0x817f, 0x7a867f7b,
-0x817f, 0x6b7f, 0x7f81, 0x81818181, 0x817f, 0x7f7f817f, 
0x7f7f, 0xab7f4f7f,
-0x817f, 0x817f6c00, 0x8181, 0x817f8181, 0x7f81, 0x81816981, 
0x7f7f, 0x007f8181
-
-hard_output0 =
-0xa7d6732e, 0x61
-
-soft_output0 =
-0x7f7f7f7f, 0x81817f7f, 0x7f817f81, 0x817f7f81, 0x81817f81, 0x81817f81, 
0x8181817f, 0x7f81817f,
-0x7f81817f, 0x7f817f7f, 0x81817f7f, 0x817f8181, 0x81818181, 0x817f7f7f, 
0x7f818181, 0x817f817f,
-0x81818181, 0x81817f7f, 0x7f817f81, 0x7f81817f, 0x817f7f7f, 0x817f7f7f, 
0x7f81817f, 0x817f817f,
-0x81817f7f, 0x81817f7f, 0x81817f7f, 0x7f817f7f, 0x817f7f81, 0x7f7f8181, 
0x81817f81, 0x817f7f7f,
-0x7f7f8181
-
-e =
-17280
-
-k =
-40
-
-rv_index =
-1
-
-iter_max =
-8
-
-iter_min =
-4
-
-expected_iter_count =
-8
-
-ext_scale =
-15
-
-num_maps =
-0
-
-op_flags =
-RTE_BBDEV_TURBO_SOFT_OUTPUT, RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE, 
RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN,
-RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT
-
-expected_status =
-OK
diff --git a/app/test-bbdev/test_vectors/bbdev_vector_te_default.data 
b/app/test-bbdev/test_vectors/bbdev_vector_te_default.data
deleted file mode 100644
index 883a76c..000
--- a/app/test-bbdev/test_vectors/bbdev_vector_te_default.data
+++ /dev/null
@@ -1,33 +0,0

[dpdk-dev] [PATCH 13/13] app/bbdev: improve readability of test application

[Kamil Chalupnik]

From: KamilX Chalupnik 

Improve readability of test application by replacing
int values with rte_bbdev_event_type enum

Signed-off-by: Kamil Chalupnik 
---
 app/test-bbdev/test_bbdev.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index 5d325b6..a914817 100644
--- a/app/test-bbdev/test_bbdev.c
+++ b/app/test-bbdev/test_bbdev.c
@@ -895,12 +895,12 @@ test_bbdev_callback(void)
"Failed to callback rgstr for RTE_BBDEV_EVENT_UNKNOWN");
 
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_UNKNOWN, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process "
"for RTE_BBDEV_EVENT_UNKNOWN ");
 
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_ERROR, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process: "
"event RTE_BBDEV_EVENT_ERROR was not registered ");
 
@@ -919,12 +919,12 @@ test_bbdev_callback(void)
 
event_status = -1;
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_UNKNOWN, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process "
"for RTE_BBDEV_EVENT_UNKNOWN ");
 
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_ERROR, NULL);
-   TEST_ASSERT(event_status == 1,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_ERROR,
"Failed test for rte_bbdev_pmd_callback_process "
"for RTE_BBDEV_EVENT_ERROR ");
 
@@ -938,12 +938,12 @@ test_bbdev_callback(void)
 
event_status = -1;
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_UNKNOWN, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process "
"for RTE_BBDEV_EVENT_UNKNOWN ");
 
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_ERROR, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process: "
"event RTE_BBDEV_EVENT_ERROR was unregistered ");
 
@@ -992,7 +992,7 @@ test_bbdev_callback(void)
"for RTE_BBDEV_EVENT_ERROR ");
 
rte_bbdev_pmd_callback_process(dev2, RTE_BBDEV_EVENT_ERROR, NULL);
-   TEST_ASSERT(event_status == 1,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_ERROR,
"Failed test for rte_bbdev_pmd_callback_process in dev2 "
"for RTE_BBDEV_EVENT_ERROR ");
 
@@ -1006,7 +1006,7 @@ test_bbdev_callback(void)
"in dev 2 ");
 
rte_bbdev_pmd_callback_process(dev2, RTE_BBDEV_EVENT_UNKNOWN, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process in dev2"
" for RTE_BBDEV_EVENT_UNKNOWN ");
 
@@ -1026,7 +1026,7 @@ test_bbdev_callback(void)
" for RTE_BBDEV_EVENT_UNKNOWN ");
 
rte_bbdev_pmd_callback_process(dev1, RTE_BBDEV_EVENT_UNKNOWN, NULL);
-   TEST_ASSERT(event_status == 0,
+   TEST_ASSERT(event_status == (int) RTE_BBDEV_EVENT_UNKNOWN,
"Failed test for rte_bbdev_pmd_callback_process in dev2 
"
"for RTE_BBDEV_EVENT_UNKNOWN ");
 
-- 
2.5.5

[dpdk-dev] [PATCH 12/13] bbdev: split queue groups

[Kamil Chalupnik]

From: KamilX Chalupnik 

Splitting Queue Groups into UL/DL Groups in Turbo Software
Driver. They are independent for Decode/Encode.
Release note updated accordingly.

Signed-off-by: Kamil Chalupnik 
---
 app/test-bbdev/test_bbdev.c  | 11 ++-
 doc/guides/rel_notes/release_18_05.rst   |  5 +
 drivers/baseband/null/bbdev_null.c   |  3 ++-
 drivers/baseband/turbo_sw/bbdev_turbo_software.c |  3 ++-
 lib/librte_bbdev/rte_bbdev.c | 13 +++--
 lib/librte_bbdev/rte_bbdev.h |  6 --
 6 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index 10579ea..5d325b6 100644
--- a/app/test-bbdev/test_bbdev.c
+++ b/app/test-bbdev/test_bbdev.c
@@ -273,7 +273,7 @@ test_bbdev_configure_stop_queue(void)
 
/* Valid queue configuration */
ts_params->qconf.queue_size = info.drv.queue_size_lim;
-   ts_params->qconf.priority = info.drv.max_queue_priority;
+   ts_params->qconf.priority = info.drv.max_ul_queue_priority;
 
/* Device - started; queue - started */
rte_bbdev_start(dev_id);
@@ -413,14 +413,7 @@ test_bbdev_configure_invalid_queue_configure(void)
ts_params->qconf.queue_size);
 
ts_params->qconf.queue_size = info.drv.queue_size_lim;
-   ts_params->qconf.priority = info.drv.max_queue_priority + 1;
-   TEST_ASSERT_FAIL(rte_bbdev_queue_configure(dev_id, queue_id,
-   &ts_params->qconf),
-   "Failed test for rte_bbdev_queue_configure: "
-   "invalid value qconf.queue_size: %u",
-   ts_params->qconf.queue_size);
-
-   ts_params->qconf.priority = info.drv.max_queue_priority;
+   ts_params->qconf.priority = info.drv.max_ul_queue_priority;
queue_id = info.num_queues;
TEST_ASSERT_FAIL(rte_bbdev_queue_configure(dev_id, queue_id,
&ts_params->qconf),
diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 3923dc2..116c3d4 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -69,6 +69,11 @@ ABI Changes
Also, make sure to start the actual text at the margin.
=
 
+* **Queue Groups split into UL/DL Groups**
+
+  Queue Groups have been split into UL/DL Groups in Turbo Software Driver.
+  They are independent for Decode/Encode. ``rte_bbdev_driver_info`` reflects
+  introduced changes.
 
 Removed Items
 -
diff --git a/drivers/baseband/null/bbdev_null.c 
b/drivers/baseband/null/bbdev_null.c
index 6bc8491..e8e541f 100644
--- a/drivers/baseband/null/bbdev_null.c
+++ b/drivers/baseband/null/bbdev_null.c
@@ -71,7 +71,8 @@ info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info 
*dev_info)
dev_info->max_num_queues = internals->max_nb_queues;
dev_info->queue_size_lim = RTE_BBDEV_QUEUE_SIZE_LIMIT;
dev_info->hardware_accelerated = false;
-   dev_info->max_queue_priority = 0;
+   dev_info->max_dl_queue_priority = 0;
+   dev_info->max_ul_queue_priority = 0;
dev_info->default_queue_conf = default_queue_conf;
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = NULL;
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c 
b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index af484fc..39b597b 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -175,7 +175,8 @@ info_get(struct rte_bbdev *dev, struct 
rte_bbdev_driver_info *dev_info)
dev_info->max_num_queues = internals->max_nb_queues;
dev_info->queue_size_lim = RTE_BBDEV_QUEUE_SIZE_LIMIT;
dev_info->hardware_accelerated = false;
-   dev_info->max_queue_priority = 0;
+   dev_info->max_dl_queue_priority = 0;
+   dev_info->max_ul_queue_priority = 0;
dev_info->default_queue_conf = default_queue_conf;
dev_info->capabilities = bbdev_capabilities;
dev_info->cpu_flag_reqs = &cpu_flag;
diff --git a/lib/librte_bbdev/rte_bbdev.c b/lib/librte_bbdev/rte_bbdev.c
index 74ecc49..28434e0 100644
--- a/lib/librte_bbdev/rte_bbdev.c
+++ b/lib/librte_bbdev/rte_bbdev.c
@@ -495,11 +495,20 @@ rte_bbdev_queue_configure(uint16_t dev_id, uint16_t 
queue_id,
conf->queue_size, queue_id, dev_id);
return -EINVAL;
}
-   if (conf->priority > dev_info.max_queue_priority) {
+   if (conf->op_type == RTE_BBDEV_OP_TURBO_DEC &&
+   conf->priority > dev_info.max_ul_queue_priority) {
rte_bbdev_log(ERR,
"Priority (%u) of queue %u of bdev %u 
must be <= %u",
conf->priority, queue

[dpdk-dev] [PATCH 00/13] Documentation and Turbo Software Baseband Device Update

[Kamil Chalupnik]

From: KamilX Chalupnik 

Patchset adjusts BaseBand drivers code to changes in FlexRAN 1.4.0:
 - update usage of crc functions after API changes

Patchset includes following changes in Turbo Software drivers:
 - optimization of preparation data to encode processing (usage of memcpy
   changed or removed)
 - minor changes in defines definitions
 - function scaling input LLR values to specific range [-16, 16] added
 - sizes of the internal buffers used by decoding were increased due to
   problem with memory for large vectors
 - support for optional CRC overlap in decode processing implemented
 - support for measurement of offload cost added
 - splitting Queue Groups into UL/DL Groups. They are independent for
   Decode/Encode

Baseband Device documentation was updated:
 - FlexRAN releases mapping table added
 - download and build instructions for BBDEV turbo_sw driver in
   compliance with FlexRAN 1.4.0 release added
 - device capabilities updated
 - input/output data buffers description added
 - details about implementation of turbo encode/decode operation added
 - added a note to enable building as a shared lib
 - vector test names updated
 - description of test added
 - usage of test app updated

Test vectors, test script and test application were updated:
 - creation of new vectors to test and validate BBDevice capabilities.
 - python script used for tests execuption updated
 - Improve readability of test application by replacing
   int values with rte_bbdev_event_type enum

Release note updated according to introduced changes.

Kamil Chalupnik (13):
  baseband/turbo_sw: update DPDK to work with FlexRAN 1.4.0
  doc/turbo_sw: update Wireless Baseband Device documentation
  doc/bbdev: dynamic lib support
  baseband/turbo_sw: memcpy changed or removed from driver
  baseband/turbo_sw: scalling input LLR to range [-16 16]
  baseband/turbo_sw: increase internal buffers
  baseband/turbo_sw: support for optional CRC overlap
  app/bbdev: update test vectors names
  bbdev: measure offload cost
  doc: update tests and usage of test app description
  app/bbdev: added new test vectors
  bbdev: split queue groups
  app/bbdev: improve readability of test application

 app/test-bbdev/Makefile|2 +
 app/test-bbdev/test-bbdev.py   |2 +-
 app/test-bbdev/test_bbdev.c|   29 +-
 app/test-bbdev/test_bbdev_perf.c   |  377 --
 app/test-bbdev/test_bbdev_vector.c |2 +
 app/test-bbdev/test_vectors/bbdev_null.data|5 +
 app/test-bbdev/test_vectors/bbdev_vector_null.data |5 -
 .../test_vectors/bbdev_vector_td_default.data  |   54 -
 .../test_vectors/bbdev_vector_te_default.data  |   33 -
 .../turbo_dec_c1_k40_r0_e17280_sbd_negllr.data |   57 +
 ...k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data |  643 ++
 ..._k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data |  643 ++
 .../turbo_dec_c1_k6144_r0_e34560_negllr.data   |  645 +++
 .../turbo_dec_c1_k6144_r0_e34560_posllr.data   |  645 +++
 .../turbo_dec_c1_k6144_r0_e34560_sbd_negllr.data   | 1224 +++
 .../turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data   | 1225 
 .../turbo_dec_c2_k3136_r0_e4920_sbd_negllr.data|  676 +++
 ...bo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data |  677 +++
 .../test_vectors/turbo_enc_c1_k40_r0_e1190_rm.data |   36 +
 .../test_vectors/turbo_enc_c1_k40_r0_e1194_rm.data |   36 +
 .../test_vectors/turbo_enc_c1_k40_r0_e1196_rm.data |   36 +
 .../test_vectors/turbo_enc_c1_k40_r0_e272_rm.data  |   33 +
 .../turbo_enc_c1_k6144_r0_e120_rm_rvidx.data   |   63 +
 .../test_vectors/turbo_enc_c1_k6144_r0_e18444.data |  156 +++
 .../turbo_enc_c1_k6144_r0_e18448_crc24a.data   |  159 +++
 .../turbo_enc_c1_k6144_r0_e32256_crc24b_rm.data|  180 +++
 .../turbo_enc_c2_k5952_r0_e17868_crc24b.data   |  300 +
 .../turbo_enc_c3_k4800_r2_e14412_crc24b.data   |  153 +++
 .../turbo_enc_c4_k4800_r2_e14412_crc24b.data   |  252 
 app/test-bbdev/turbo_dec_default.data  |1 +
 app/test-bbdev/turbo_enc_default.data  |1 +
 doc/guides/bbdevs/turbo_sw.rst |   58 +-
 doc/guides/prog_guide/bbdev.rst|  237 +++-
 doc/guides/rel_notes/release_18_05.rst |5 +
 doc/guides/tools/testbbdev.rst |  173 ++-
 drivers/baseband/null/bbdev_null.c |3 +-
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  267 +++--
 lib/librte_bbdev/rte_bbdev.c   |   13 +-
 lib/librte_bbdev/rte_bbdev.h   |   10 +-
 lib/librte_bbdev/rte_bbdev_op.h|   28 +-
 40 files changed, 8767 insertions(+), 377 deletions(-)
 create mode 100644 app/test-bbdev/test_vectors/bbdev_null.data
 delete mode 100644 app/test-bbdev/test_vectors/bbdev_vector_null.data
 delete mode 100644 app/test-bbdev/test_vect

[dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

[Anatoly Burakov]

rte_lcore_has_role() returns 0 if role of lcore matches requested
role. The return value of the API is confusing, and this is a known
problem with a deprecation notice announcing the change to more
intuitive semantics:

Commit 064518f68d48 ("doc: announce EAL API change to lcore role function")
Cc: erik.g.carri...@intel.com

Implement changes announced in the deprecation notice, and remove it.
Also, fix usages of this API to reflect the change. Control thread patches
expected new behavior and were broken before, now they are fixed as well.

Fixes: d651ee4919cd ("eal: set affinity for control threads")
Cc: olivier.m...@6wind.com

Signed-off-by: Anatoly Burakov 
---
 doc/guides/rel_notes/deprecation.rst  | 5 -
 lib/librte_eal/common/eal_common_thread.c | 5 +
 lib/librte_timer/rte_timer.c  | 2 +-
 3 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 72ab33c..3353519 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -28,11 +28,6 @@ Deprecation Notices
   - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``
   - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``
 
-* eal: The semantics of the return value for the ``rte_lcore_has_role`` 
function
-  are planned to change in v18.05. The function currently returns 0 and <0 for
-  success and failure, respectively.  This will change to 1 and 0 for true and
-  false, respectively, to make use of the function more intuitive.
-
 * eal: a new set of mbuf mempool ops name APIs for user, platform and best
   mempool names have been defined in ``rte_mbuf`` in v18.02. The uses of
   ``rte_eal_mbuf_default_mempool_ops`` shall be replaced by
diff --git a/lib/librte_eal/common/eal_common_thread.c 
b/lib/librte_eal/common/eal_common_thread.c
index 4e75cb8..fcf00cd 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -34,10 +34,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum 
rte_lcore_role_t role)
if (lcore_id >= RTE_MAX_LCORE)
return -EINVAL;
 
-   if (cfg->lcore_role[lcore_id] == role)
-   return 0;
-
-   return -EINVAL;
+   return cfg->lcore_role[lcore_id] == role;
 }
 
 int eal_cpuset_socket_id(rte_cpuset_t *cpusetp)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 4bbcd06..590488c 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -403,7 +403,7 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
 
if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
!(rte_lcore_is_enabled(tim_lcore) ||
- rte_lcore_has_role(tim_lcore, ROLE_SERVICE) == 0)))
+ rte_lcore_has_role(tim_lcore, ROLE_SERVICE
return -1;
 
if (type == PERIODICAL)
-- 
2.7.4

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

[Tonghao Zhang]

On Thu, Apr 26, 2018 at 9:14 PM, Zhang, Qi Z  wrote:
> Hi Tonghao:
> Would you submit v4 with Ferruh' s fix and also do a rebase on 
> next-net?
Yes

> Thanks
> Qi
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Thursday, April 19, 2018 12:10 AM
>> To: Tonghao Zhang 
>> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
>> ; Xing, Beilei ; Dai,
>> Wei ; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt
>> interval for EITR.
>>
>> On 4/18/2018 2:01 AM, Tonghao Zhang wrote:
>> > On Tue, Apr 17, 2018 at 7:00 PM, Ferruh Yigit 
>> wrote:
>> >> On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote:
>> >>> From: Tonghao Zhang 
>> >>>
>> >>> Set EITR interval as default. This patch can improve the performance
>> >>> when we enable the rx-intrrupt to process the packets because we
>> >>> hope rx-intrrupt reduce CPU. For example, the 200us value of EITR
>> >>> makes the performance better with the low CPU.
>> >>>
>> >>> Users can configure the value of ITR via DPDK configuration.
>> >>>
>> >>> The default value of ITR is 500us, compatible with RSC of ixgbe PF,
>> >>> and next patch will use the default value.
>> >>>
>> >>> Signed-off-by: Tonghao Zhang 
>> >>> ---
>> >>> v1 --> v2:
>> >>> use the configure file, for different user.
>> >>> suggested by Beilei Xing, http://dpdk.org/dev/patchwork/patch/32989
>> >>> ---
>> >>>  config/common_base   |  2 ++
>> >>>  drivers/net/ixgbe/ixgbe_ethdev.c |  7 +++
>> >>> drivers/net/ixgbe/ixgbe_ethdev.h | 12 
>> >>>  3 files changed, 21 insertions(+)
>> >>>
>> >>> diff --git a/config/common_base b/config/common_base index
>> >>> e74febe..2e9fded 100644
>> >>> --- a/config/common_base
>> >>> +++ b/config/common_base
>> >>> @@ -196,6 +196,8 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n
>> >>>  CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
>> >>>  CONFIG_RTE_IXGBE_INC_VECTOR=y
>> >>>  CONFIG_RTE_LIBRTE_IXGBE_BYPASS=n
>> >>> +# interval up to 1024 us
>> >>> +CONFIG_RTE_LIBRTE_IXGBE_ITR_INTERVAL=-1
>> >>
>> >> I can understand this is to let user to ability to fine tune this
>> >> value, the down side is when number of these kind of tune parameters
>> >> increased, it become confusing and config options because less useful or
>> perhaps useless.
>> >>
>> >> And overall we are trying to reduce config options we have.
>> >>
>> >> I can see there is already some default values in the header file,
>> >> what do you think removing the config option and go with default values
>> defined in header?
>> > v2 used the default value in header, but for configuring it like as
>> > i40e option (CONFIG_RTE_LIBRTE_IXGBE_ITR_INTERVAL).
>> > so v3 makes some changes. These patches may have been applied. For
>> > reducing config option, should we do it in individual patches to fix
>> > the ixgbe/i40e option ?
>>
>> Patches are still in Helin's tree, so this up to him how manage.
>> Since patches are not in main repo yet I would suggest making new version if
>> fits to Helin.
>>
>> >
>> >>>
>> >>>  #
>> >>>  # Compile burst-oriented I40E PMD driver diff --git
>> >>> a/drivers/net/ixgbe/ixgbe_ethdev.c
>> >>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>> >>> index e67389f..495e72c 100644
>> >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> >>> @@ -5780,6 +5780,13 @@ static void ixgbevf_set_vfta_all(struct
>> rte_eth_dev *dev, bool on)
>> >>>   if (vector_idx < base + intr_handle->nb_efd - 1)
>> >>>   vector_idx++;
>> >>>   }
>> >>> +
>> >>> + /* As RX queue setting above show, all queues use the vector 0.
>> >>> +  * Set only the ITR value of IXGBE_MISC_VEC_ID.
>> >>> +  */
>> >>> + IXGBE_WRITE_REG(hw, IXGBE_VTEITR(IXGBE_MISC_VEC_ID),
>> >>> +
>> ixgbe_calc_itr_interval(RTE_LIBRTE_IXGBE_ITR_INTERVAL)
>> >>> + | IXGBE_EITR_CNT_WDIS);
>> >>>  }
>> >>>
>> >>>  /**
>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
>> >>> b/drivers/net/ixgbe/ixgbe_ethdev.h
>> >>> index 1db29bd..c779001 100644
>> >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.h
>> >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
>> >>> @@ -58,6 +58,18 @@
>> >>>   IXGBE_EITR_ITR_INT_MASK)
>> >>>
>> >>>
>> >>> +#define IXGBE_QUEUE_ITR_INTERVAL_MAX 1024 /* 1024us */
>> >>> +#define IXGBE_QUEUE_ITR_INTERVAL_DEFAULT 500 /* 500us */
>> >>> +
>> >>> +static inline uint16_t
>> >>> +ixgbe_calc_itr_interval(int16_t interval) {
>> >>> + if (interval < 0 || interval > IXGBE_QUEUE_ITR_INTERVAL_MAX)
>> >>> + interval = IXGBE_QUEUE_ITR_INTERVAL_DEFAULT;
>> >>> +
>> >>> + return IXGBE_EITR_INTERVAL_US(interval); }
>> >>> +
>> >>>  /* Loopback operation modes */
>> >>>  /* 82599 specific loopback operation types */
>> >>>  #define IXGBE_LPBK_82599_NONE   0x0 /* Default value. Loopback
>> is disabled. */
>> >>>
>> >>
>

Re: [dpdk-dev] [PATCH v6 11/11] doc: update mlx5 guide on tunnel offloading

[Xueming(Steven) Li]

Hi Ferruh,

Thanks for reminding, new patch sent:
http://www.dpdk.org/dev/patchwork/patch/39026/

Best Regards,
Xueming

> -Original Message-
> From: Ferruh Yigit 
> Sent: Thursday, April 26, 2018 7:00 PM
> To: Xueming(Steven) Li ; Nélio Laranjeiro 
> ; Shahaf
> Shuler 
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 11/11] doc: update mlx5 guide on tunnel 
> offloading
> 
> On 4/23/2018 1:33 PM, Xueming Li wrote:
> > Remove tunnel limitations, add new hardware tunnel offload features.
> >
> > Signed-off-by: Xueming Li 
> > ---
> >  doc/guides/nics/features/default.ini | 1 +
> >  doc/guides/nics/features/mlx5.ini| 3 +++
> >  doc/guides/nics/mlx5.rst | 4 ++--
> >  3 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/nics/features/default.ini 
> > b/doc/guides/nics/features/default.ini
> > index dae2ad776..49be81450 100644
> > --- a/doc/guides/nics/features/default.ini
> > +++ b/doc/guides/nics/features/default.ini
> > @@ -29,6 +29,7 @@ Multicast MAC filter =
> >  RSS hash =
> >  RSS key update   =
> >  RSS reta update  =
> > +Inner RSS=
> >  VMDq =
> >  SR-IOV   =
> >  DCB  =
> 
> When a new feature added, it need to be documented, in 
> doc/guides/nics/features.rst.
> 
> To not block this set, can you please send an incremental patch for this?

Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to rte_flow

[Ori Kam]

Hi Declan,

You are changing API (port_flow_query) which is in use in
both MLX5 and MLX4 this results in breaking the build.

Best,
Ori

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty
> Sent: Thursday, April 26, 2018 3:08 PM
> To: dev@dpdk.org
> Cc: Ferruh Yigit ; Declan Doherty
> 
> Subject: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to
> rte_flow
> 
> Add rte_flow_action_count action data structure to enable shared
> counters across multiple flows on a single port or across multiple
> flows on multiple ports within the same switch domain. Also this enables
> multiple count actions to be specified in a single flow action.
> 
> This patch also modifies the existing rte_flow_query API to take the
> rte_flow_action structure as an input parameter instead of the
> rte_flow_action_type enumeration to allow querying a specific action
> from a flow rule when multiple actions of the same type are specified.
> 
> This patch also contains updates for the bonding and failsafe PMDs and
> testpmd application which are affected by this API change.
> 
> Signed-off-by: Declan Doherty 
> ---
>  app/test-pmd/cmdline_flow.c |  6 ++--
>  app/test-pmd/config.c   | 15 +
>  app/test-pmd/testpmd.h  |  2 +-
>  doc/guides/prog_guide/rte_flow.rst  | 59 +--
> --
>  drivers/net/bonding/rte_eth_bond_flow.c |  9 ++---
>  drivers/net/failsafe/failsafe_flow.c|  4 +--
>  lib/librte_ether/rte_flow.c |  2 +-
>  lib/librte_ether/rte_flow.h | 38 +++--
>  lib/librte_ether/rte_flow_driver.h  |  2 +-
>  9 files changed, 93 insertions(+), 44 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 1ac04a0ab..5754e7858 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -420,7 +420,7 @@ struct buffer {
>   } destroy; /**< Destroy arguments. */
>   struct {
>   uint32_t rule;
> - enum rte_flow_action_type action;
> + struct rte_flow_action action;
>   } query; /**< Query arguments. */
>   struct {
>   uint32_t *group;
> @@ -1101,7 +1101,7 @@ static const struct token token_list[] = {
>   .next = NEXT(NEXT_ENTRY(QUERY_ACTION),
>NEXT_ENTRY(RULE_ID),
>NEXT_ENTRY(PORT_ID)),
> - .args = ARGS(ARGS_ENTRY(struct buffer, args.query.action),
> + .args = ARGS(ARGS_ENTRY(struct buffer,
> args.query.action.type),
>ARGS_ENTRY(struct buffer, args.query.rule),
>ARGS_ENTRY(struct buffer, port)),
>   .call = parse_query,
> @@ -3842,7 +3842,7 @@ cmd_flow_parsed(const struct buffer *in)
>   break;
>   case QUERY:
>   port_flow_query(in->port, in->args.query.rule,
> - in->args.query.action);
> + &in->args.query.action);
>   break;
>   case LIST:
>   port_flow_list(in->port, in->args.list.group_n,
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 0f2425229..cd6102dfc 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1452,7 +1452,7 @@ port_flow_flush(portid_t port_id)
>  /** Query a flow rule. */
>  int
>  port_flow_query(portid_t port_id, uint32_t rule,
> - enum rte_flow_action_type action)
> + const struct rte_flow_action *action)
>  {
>   struct rte_flow_error error;
>   struct rte_port *port;
> @@ -1474,15 +1474,16 @@ port_flow_query(portid_t port_id, uint32_t rule,
>   return -ENOENT;
>   }
>   if ((unsigned int)action >= RTE_DIM(flow_action) ||
> - !flow_action[action].name)
> + !flow_action[action->type].name)
>   name = "unknown";
>   else
> - name = flow_action[action].name;
> - switch (action) {
> + name = flow_action[action->type].name;
> + switch (action->type) {
>   case RTE_FLOW_ACTION_TYPE_COUNT:
>   break;
>   default:
> - printf("Cannot query action type %d (%s)\n", action, name);
> + printf("Cannot query action type %d (%s)\n",
> + action->type, name);
>   return -ENOTSUP;
>   }
>   /* Poisoning to make sure PMDs update it in case of error. */
> @@ -1490,7 +1491,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
>   memset(&query, 0, sizeof(query));
>   if (rte_flow_query(port_id, pf->flow, action, &query, &error))
>   return port_flow_complain(&error);
> - switch (action) {
> + switch (action->type) {
>   case RTE_FLOW_ACTION_TYPE_COUNT:
>   printf("%s:\n"
>  " hits_set: %u\n"
> @@ -1505,

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Ferruh Yigit]

On 4/26/2018 1:03 PM, Ananyev, Konstantin wrote:
> 
> 
>> -Original Message-
>> From: Doherty, Declan
>> Sent: Thursday, April 26, 2018 11:41 AM
>> To: dev@dpdk.org
>> Cc: Adrien Mazarguil ; Yigit, Ferruh 
>> ; Thomas Monjalon ;
>> Shahaf Shuler ; Ananyev, Konstantin 
>> ; Horton, Remy ;
>> Doherty, Declan 
>> Subject: [dpdk-dev][PATCH v8 6/9] ethdev: add common devargs parser
>>
>> From: Remy Horton 
>>
>> Introduces a new structure, rte_eth_devargs, to support generic
>> ethdev arguments common across NET PMDs, with a new API
>> rte_eth_devargs_parse API to support PMD parsing these arguments. The
>> patch add support for a representor argument  passed with passed with
>> the EAL -w option. The representor parameter allows the user to specify
>> which representor ports to initialise on a device.
>>
>> The argument supports passing a single representor port, a list of
>> port values or a range of port values.
>>
>> -w BDF,representor=1  # create representor port 1 on pci device BDF
>> -w BDF,representor=[1,2,5,6,10] # create representor ports in list
>> -w BDF,representor=[0-31] # create representor ports in range
>>
>> Signed-off-by: Remy Horton 
>> Signed-off-by: Declan Doherty 
>> ---
>>  doc/guides/prog_guide/poll_mode_drv.rst |  19 
>>  lib/Makefile|   1 +
>>  lib/librte_ether/rte_ethdev.c   | 182 
>> 
>>  lib/librte_ether/rte_ethdev_driver.h|  30 ++
>>  lib/librte_ether/rte_ethdev_version.map |   1 +
>>  5 files changed, 233 insertions(+)
>>
>> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
>> b/doc/guides/prog_guide/poll_mode_drv.rst
>> index e5d01874e..09a93baec 100644
>> --- a/doc/guides/prog_guide/poll_mode_drv.rst
>> +++ b/doc/guides/prog_guide/poll_mode_drv.rst
>> @@ -345,6 +345,25 @@ Ethernet Device API
>>
>>  The Ethernet device API exported by the Ethernet PMDs is described in the 
>> *DPDK API Reference*.
>>
>> +Ethernet Device Standard Device Arguments
>> +~
>> +
>> +Standard Ethernet device arguments allow for a set of commonly used 
>> arguments/
>> +parameters which are applicable to all Ethernet devices to be available to 
>> for
>> +specification of specific device and for passing common configuration
>> +parameters to those ports.
>> +
>> +* ``representor`` for a device which supports the creation of representor 
>> ports
>> +  this argument allows user to specify which switch ports to enable port
>> +  representors for.::
>> +
>> +   -w BDBF,representor=0
>> +   -w BDBF,representor=[0,4,6,9]
>> +   -w BDBF,representor=[0-31]
>> +
>> +Note: PMDs are not required to support the standard device arguments and 
>> users
>> +should consult the relevant PMD documentation to see support devargs.
>> +
>>  Extended Statistics API
>>  ~~~
>>
>> diff --git a/lib/Makefile b/lib/Makefile
>> index 965be6c8d..536775e59 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal
>>  DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether
>>  DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring
>>  DEPDIRS-librte_ether += librte_mbuf
>> +DEPDIRS-librte_ether += librte_kvargs
>>  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev
>>  DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf
>>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev
>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
>> index 621f8af7f..cb85d8bb7 100644
>> --- a/lib/librte_ether/rte_ethdev.c
>> +++ b/lib/librte_ether/rte_ethdev.c
>> @@ -34,6 +34,7 @@
>>  #include 
>>  #include 
>>  #include 
>> ++#include 
>>
>>  #include "rte_ether.h"
>>  #include "rte_ethdev.h"
>> @@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, 
>> const char *pool)
>>  return (*dev->dev_ops->pool_ops_supported)(dev, pool);
>>  }
>>
>> +typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
>> +
>> +static int
>> +rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)
>> +{
> 
> I still think that if you'd like to extend rte_kvarrgs to be able to parse 
> something like: "key=[val1,val2,...,valn]",
> you have to make it generic kvargs ability and put it into librte_kvargs, not 
> try to introduce your own new parser here.
> Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string 
> would contain some extra (let say device specific)
> parameters.
> What would happen, when PMD will try to use rte_kvargs_parse() on such string?
> My understanding - it would fail, correct?
> 
> As an alternative - as I remember rte_kvargs allows you to have multiple 
> identical key, i.e: "key=val1,key=val2,...,key=valn".
> Why not to use that way, if you don't want to introduce extra code in 
> rte_kvargs?

Hi Declan, Remy,

I will continue with existing patchset, for the sake of the rc1,
can you please address these comments as incremental updates to th

Re: [dpdk-dev] [PATCH v8 2/9] ethdev: add switch identifier parameter to port

[Thomas Monjalon]

26/04/2018 14:02, Thomas Monjalon:
> 26/04/2018 12:40, Declan Doherty:
> > Introduces a new port attribute to ethdev port's which denotes the
> > switch domain a port belongs to. By default all port's switch
> > identifiers are set to RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID. Ports
> > which supported the concept of switch domains can be configured with
> > the same switch domain id.
> > 
> > Signed-off-by: Declan Doherty 
> 
> It's very well detailed now :)
> 
> Acked-by: Thomas Monjalon 

One miss: you forgot to remove the deprecation notice in this patch.

Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to rte_flow

[Ferruh Yigit]

On 4/26/2018 3:06 PM, Ori Kam wrote:
> Hi Declan,
> 
> You are changing API (port_flow_query) which is in use in
> both MLX5 and MLX4 this results in breaking the build.

Hi Ori,

Do you mean "rte_flow_query"? port_flow_query() is a function in testpmd, how
mlx is using it?

> 
> Best,
> Ori
> 
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty
>> Sent: Thursday, April 26, 2018 3:08 PM
>> To: dev@dpdk.org
>> Cc: Ferruh Yigit ; Declan Doherty
>> 
>> Subject: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to
>> rte_flow
>>
>> Add rte_flow_action_count action data structure to enable shared
>> counters across multiple flows on a single port or across multiple
>> flows on multiple ports within the same switch domain. Also this enables
>> multiple count actions to be specified in a single flow action.
>>
>> This patch also modifies the existing rte_flow_query API to take the
>> rte_flow_action structure as an input parameter instead of the
>> rte_flow_action_type enumeration to allow querying a specific action
>> from a flow rule when multiple actions of the same type are specified.
>>
>> This patch also contains updates for the bonding and failsafe PMDs and
>> testpmd application which are affected by this API change.
>>
>> Signed-off-by: Declan Doherty 
>> ---
>>  app/test-pmd/cmdline_flow.c |  6 ++--
>>  app/test-pmd/config.c   | 15 +
>>  app/test-pmd/testpmd.h  |  2 +-
>>  doc/guides/prog_guide/rte_flow.rst  | 59 +--
>> --
>>  drivers/net/bonding/rte_eth_bond_flow.c |  9 ++---
>>  drivers/net/failsafe/failsafe_flow.c|  4 +--
>>  lib/librte_ether/rte_flow.c |  2 +-
>>  lib/librte_ether/rte_flow.h | 38 +++--
>>  lib/librte_ether/rte_flow_driver.h  |  2 +-
>>  9 files changed, 93 insertions(+), 44 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>> index 1ac04a0ab..5754e7858 100644
>> --- a/app/test-pmd/cmdline_flow.c
>> +++ b/app/test-pmd/cmdline_flow.c
>> @@ -420,7 +420,7 @@ struct buffer {
>>  } destroy; /**< Destroy arguments. */
>>  struct {
>>  uint32_t rule;
>> -enum rte_flow_action_type action;
>> +struct rte_flow_action action;
>>  } query; /**< Query arguments. */
>>  struct {
>>  uint32_t *group;
>> @@ -1101,7 +1101,7 @@ static const struct token token_list[] = {
>>  .next = NEXT(NEXT_ENTRY(QUERY_ACTION),
>>   NEXT_ENTRY(RULE_ID),
>>   NEXT_ENTRY(PORT_ID)),
>> -.args = ARGS(ARGS_ENTRY(struct buffer, args.query.action),
>> +.args = ARGS(ARGS_ENTRY(struct buffer,
>> args.query.action.type),
>>   ARGS_ENTRY(struct buffer, args.query.rule),
>>   ARGS_ENTRY(struct buffer, port)),
>>  .call = parse_query,
>> @@ -3842,7 +3842,7 @@ cmd_flow_parsed(const struct buffer *in)
>>  break;
>>  case QUERY:
>>  port_flow_query(in->port, in->args.query.rule,
>> -in->args.query.action);
>> +&in->args.query.action);
>>  break;
>>  case LIST:
>>  port_flow_list(in->port, in->args.list.group_n,
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 0f2425229..cd6102dfc 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1452,7 +1452,7 @@ port_flow_flush(portid_t port_id)
>>  /** Query a flow rule. */
>>  int
>>  port_flow_query(portid_t port_id, uint32_t rule,
>> -enum rte_flow_action_type action)
>> +const struct rte_flow_action *action)
>>  {
>>  struct rte_flow_error error;
>>  struct rte_port *port;
>> @@ -1474,15 +1474,16 @@ port_flow_query(portid_t port_id, uint32_t rule,
>>  return -ENOENT;
>>  }
>>  if ((unsigned int)action >= RTE_DIM(flow_action) ||
>> -!flow_action[action].name)
>> +!flow_action[action->type].name)
>>  name = "unknown";
>>  else
>> -name = flow_action[action].name;
>> -switch (action) {
>> +name = flow_action[action->type].name;
>> +switch (action->type) {
>>  case RTE_FLOW_ACTION_TYPE_COUNT:
>>  break;
>>  default:
>> -printf("Cannot query action type %d (%s)\n", action, name);
>> +printf("Cannot query action type %d (%s)\n",
>> +action->type, name);
>>  return -ENOTSUP;
>>  }
>>  /* Poisoning to make sure PMDs update it in case of error. */
>> @@ -1490,7 +1491,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
>>  memset(&query, 0, sizeof(query));
>>  if (rte_flow_query(port_id, pf->flow, action, &query, &error))
>>  return p

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Doherty, Declan]

On 26/04/2018 1:03 PM, Ananyev, Konstantin wrote:




-Original Message-
From: Doherty, Declan
Sent: Thursday, April 26, 2018 11:41 AM
To: dev@dpdk.org
Cc: Adrien Mazarguil ; Yigit, Ferruh 
; Thomas Monjalon ;
Shahaf Shuler ; Ananyev, Konstantin 
; Horton, Remy ;
Doherty, Declan 
Subject: [dpdk-dev][PATCH v8 6/9] ethdev: add common devargs parser

From: Remy Horton 

Introduces a new structure, rte_eth_devargs, to support generic
ethdev arguments common across NET PMDs, with a new API
rte_eth_devargs_parse API to support PMD parsing these arguments. The
patch add support for a representor argument  passed with passed with
the EAL -w option. The representor parameter allows the user to specify
which representor ports to initialise on a device.

The argument supports passing a single representor port, a list of
port values or a range of port values.

-w BDF,representor=1  # create representor port 1 on pci device BDF
-w BDF,representor=[1,2,5,6,10] # create representor ports in list
-w BDF,representor=[0-31] # create representor ports in range

Signed-off-by: Remy Horton 
Signed-off-by: Declan Doherty 
---
  doc/guides/prog_guide/poll_mode_drv.rst |  19 
  lib/Makefile|   1 +
  lib/librte_ether/rte_ethdev.c   | 182 
  lib/librte_ether/rte_ethdev_driver.h|  30 ++
  lib/librte_ether/rte_ethdev_version.map |   1 +
  5 files changed, 233 insertions(+)

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index e5d01874e..09a93baec 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -345,6 +345,25 @@ Ethernet Device API

  The Ethernet device API exported by the Ethernet PMDs is described in the 
*DPDK API Reference*.

+Ethernet Device Standard Device Arguments
+~
+
+Standard Ethernet device arguments allow for a set of commonly used arguments/
+parameters which are applicable to all Ethernet devices to be available to for
+specification of specific device and for passing common configuration
+parameters to those ports.
+
+* ``representor`` for a device which supports the creation of representor ports
+  this argument allows user to specify which switch ports to enable port
+  representors for.::
+
+   -w BDBF,representor=0
+   -w BDBF,representor=[0,4,6,9]
+   -w BDBF,representor=[0-31]
+
+Note: PMDs are not required to support the standard device arguments and users
+should consult the relevant PMD documentation to see support devargs.
+
  Extended Statistics API
  ~~~

diff --git a/lib/Makefile b/lib/Makefile
index 965be6c8d..536775e59 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal
  DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether
  DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring
  DEPDIRS-librte_ether += librte_mbuf
+DEPDIRS-librte_ether += librte_kvargs
  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev
  DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf
  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 621f8af7f..cb85d8bb7 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -34,6 +34,7 @@
  #include 
  #include 
  #include 
++#include 

  #include "rte_ether.h"
  #include "rte_ethdev.h"
@@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const 
char *pool)
return (*dev->dev_ops->pool_ops_supported)(dev, pool);
  }

+typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);
+
+static int
+rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)
+{


I still think that if you'd like to extend rte_kvarrgs to be able to parse something 
like: "key=[val1,val2,...,valn]",
you have to make it generic kvargs ability and put it into librte_kvargs, not 
try to introduce your own new parser here.
Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string 
would contain some extra (let say device specific)
parameters.
What would happen, when PMD will try to use rte_kvargs_parse() on such string?
My understanding - it would fail, correct?

As an alternative - as I remember rte_kvargs allows you to have multiple identical key, 
i.e: "key=val1,key=val2,...,key=valn".
Why not to use that way, if you don't want to introduce extra code in 
rte_kvargs?



Hey Konstantin, the rationale for keeping this independent from 
librte_kvargs was that it is likely that the implementation of parsing 
devarfs will change in the next release due the proposed rework on the 
whole devargs infrastructure. I hadn't considered the potential issue 
with rte_kvargs_parse() on string using the proposed syntax here. I'll 
send a patch for alignment with librte_kvargs for the next release 
candidate.



+   int state;
+   struct rt

Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support

[De Lara Guarch, Pablo]

> -Original Message-
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 3:24 PM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: Mokhtar, Amr 
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo
> 
> > -Original Message-
> > From: De Lara Guarch, Pablo
> > Sent: Thursday, April 26, 2018 3:22 PM
> > To: Chalupnik, KamilX ; dev@dpdk.org
> > Cc: Mokhtar, Amr 
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> >
> >
> > > -Original Message-
> > > From: Chalupnik, KamilX
> > > Sent: Thursday, April 26, 2018 1:48 PM
> > > To: De Lara Guarch, Pablo ;
> > > dev@dpdk.org
> > > Cc: Mokhtar, Amr 
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> >
> > ...
> >
> > > > > Ok, we will deliver such changes in patches for next release.
> > > > > Are you ok with that?
> > > >
> > > > I think this change should not take a long time. The sooner we do
> > > > it, the better, as there might be more people using this in the future.
> > > > I can send the patch for you, so you can focus on other changes,
> > > > and then you can see if it is fine for you.
> > > >
> > > > Thanks,
> > > > Pablo
> > >
> > > Ok. I will add this change to our patchset as well.
> >
> > In order to make sure that users can still use the previous name, to
> > avoid breaking Backwards compatibility, you modify DRIVER_NAME with
> > the new name and then use RTE_PMD_REGISTER_ALIAS(DRIVER_NAME,
> > turbo_sw); This way, both names can be used, but you should update the
> > docs to use the new name.
> >
> > Thanks,
> > Pablo
> 
> 
> Thanks for suggestions :)
> I've already prepared a changes. Just one question. Can I prepare separate 
> patch
> based on the 13 patchset? Is that ok? Such solution will be cleaner in my 
> opinion.
> 

Sure, this change should be independent from the other ones. You don't have to 
add all patches in the same patchset (when they are not logically related).

Thanks,
Pablo

> Best regards,
> Kamil
> 

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

[Remy Horton]

On 26/04/2018 13:03, Ananyev, Konstantin wrote:
[..]

I still think that if you'd like to extend rte_kvarrgs to be able to parse something 
like: "key=[val1,val2,...,valn]",
you have to make it generic kvargs ability and put it into librte_kvargs, not 
try to introduce your own new parser here.
Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string 
would contain some extra (let say device specific)
parameters.
What would happen, when PMD will try to use rte_kvargs_parse() on such string?
My understanding - it would fail, correct?


This is partly dependent on what will (and won't) devargs provide when 
it is finalised. It was insourced in order to unblock the rest of the 
patchset in the meantime.

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

[Thomas Monjalon]

26/04/2018 15:42, Anatoly Burakov:
> rte_lcore_has_role() returns 0 if role of lcore matches requested
> role. The return value of the API is confusing, and this is a known
> problem with a deprecation notice announcing the change to more
> intuitive semantics:
> 
> Commit 064518f68d48 ("doc: announce EAL API change to lcore role function")
> Cc: erik.g.carri...@intel.com
> 
> Implement changes announced in the deprecation notice, and remove it.
> Also, fix usages of this API to reflect the change. Control thread patches
> expected new behavior and were broken before, now they are fixed as well.
> 
> Fixes: d651ee4919cd ("eal: set affinity for control threads")
> Cc: olivier.m...@6wind.com
> 
> Signed-off-by: Anatoly Burakov 

Applied, thanks

[dpdk-dev] [PATCH] bbdev: change names of baseband devices

[Kamil Chalupnik]

Change baseband device name:
 - from turbo_sw to baseband_turbo_sw
 - from bbdev_null to baseband_null
To keep backwards compatibility the old names are still valid

Signed-off-by: Kamil Chalupnik 
---
 app/test-bbdev/test-bbdev.py |  2 +-
 doc/guides/bbdevs/null.rst   |  8 
 doc/guides/bbdevs/turbo_sw.rst   | 10 +-
 doc/guides/prog_guide/bbdev.rst  |  4 ++--
 doc/guides/sample_app_ug/bbdev_app.rst   | 11 ++-
 doc/guides/tools/testbbdev.rst   | 14 +++---
 drivers/baseband/null/bbdev_null.c   |  3 ++-
 drivers/baseband/turbo_sw/bbdev_turbo_software.c |  3 ++-
 8 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
index e3b1e6c..acab9eb 100755
--- a/app/test-bbdev/test-bbdev.py
+++ b/app/test-bbdev/test-bbdev.py
@@ -33,7 +33,7 @@ def kill(process):
 default=dpdk_path + "/" + dpdk_target + "/app/testbbdev")
 parser.add_argument("-e", "--eal-params",
 help="EAL arguments which are passed to the test app",
-default="--vdev=bbdev_null0")
+default="--vdev=baseband_null0")
 parser.add_argument("-t", "--timeout",
 type=int,
 help="Timeout in seconds",
diff --git a/doc/guides/bbdevs/null.rst b/doc/guides/bbdevs/null.rst
index 9baf2a9..0b885d1 100644
--- a/doc/guides/bbdevs/null.rst
+++ b/doc/guides/bbdevs/null.rst
@@ -4,7 +4,7 @@
 BBDEV null Poll Mode Driver
 
 
-The (**bbdev_null**) is a bbdev poll mode driver which provides a minimal
+The (**baseband_null**) is a bbdev poll mode driver which provides a minimal
 implementation of a software bbdev device. As a null device it does not modify
 the data in the mbuf on which the bbdev operation is to operate and it only
 works for operation type ``RTE_BBDEV_OP_NONE``.
@@ -30,9 +30,9 @@ Initialization
 
 To use the PMD in an application, user must:
 
-- Call ``rte_vdev_init("bbdev_null")`` within the application.
+- Call ``rte_vdev_init("baseband_null")`` within the application.
 
-- Use ``--vdev="bbdev_null"`` in the EAL options, which will call 
``rte_vdev_init()`` internally.
+- Use ``--vdev="baseband_null"`` in the EAL options, which will call 
``rte_vdev_init()`` internally.
 
 The following parameters (all optional) can be provided in the previous two 
calls:
 
@@ -46,4 +46,4 @@ Example:
 
 .. code-block:: console
 
-./test-bbdev.py -e="--vdev=bbdev_null,socket_id=0,max_nb_queues=8"
+./test-bbdev.py -e="--vdev=baseband_null,socket_id=0,max_nb_queues=8"
diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst
index 914b972..9661a30 100644
--- a/doc/guides/bbdevs/turbo_sw.rst
+++ b/doc/guides/bbdevs/turbo_sw.rst
@@ -4,7 +4,7 @@
 SW Turbo Poll Mode Driver
 =
 
-The SW Turbo PMD (**turbo_sw**) provides a poll mode bbdev driver that utilizes
+The SW Turbo PMD (**baseband_turbo_sw**) provides a poll mode bbdev driver 
that utilizes
 Intel optimized libraries for LTE Layer 1 workloads acceleration. This PMD
 supports the functions: Turbo FEC, Rate Matching and CRC functions.
 
@@ -41,7 +41,7 @@ Installation
 FlexRAN SDK Download
 
 
-To build DPDK with the *turbo_sw* PMD the user is required to download
+To build DPDK with the *baseband_turbo_sw* PMD the user is required to download
 the export controlled ``FlexRAN SDK`` Libraries. An account at `Intel Resource
 Design Center 
`_
 needs to be registered.
@@ -139,9 +139,9 @@ Example:
 
 To use the PMD in an application, user must:
 
-- Call ``rte_vdev_init("turbo_sw")`` within the application.
+- Call ``rte_vdev_init("baseband_turbo_sw")`` within the application.
 
-- Use ``--vdev="turbo_sw"`` in the EAL options, which will call 
``rte_vdev_init()`` internally.
+- Use ``--vdev="baseband_turbo_sw"`` in the EAL options, which will call 
``rte_vdev_init()`` internally.
 
 The following parameters (all optional) can be provided in the previous two 
calls:
 
@@ -155,5 +155,5 @@ Example:
 
 .. code-block:: console
 
-./test-bbdev.py -e="--vdev=turbo_sw,socket_id=0,max_nb_queues=8" \
+./test-bbdev.py -e="--vdev=baseband_turbo_sw,socket_id=0,max_nb_queues=8" \
 -c validation -v ./test_vectors/bbdev_vector_t?_default.data
diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 4616594..b0f44cc 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -42,13 +42,13 @@ From the command line using the --vdev EAL option
 
 .. code-block:: console
 
-   --vdev 'turbo_sw,max_nb_queues=8,socket_id=0'
+   --vdev 'baseband_turbo_sw,max_nb_queues=8,socket_id=0'
 
 Our using the rte_vdev_init API within the application code.
 
 .. code-block:: c
 
-rte_vdev_init("turbo_sw",

Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to rte_flow

[Ori Kam]

Hi,

PSB

Ori 
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, April 26, 2018 5:28 PM
> To: Ori Kam ; Declan Doherty
> ; dev@dpdk.org; Matan Azrad
> 
> Subject: Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support
> to rte_flow
> 
> On 4/26/2018 3:06 PM, Ori Kam wrote:
> > Hi Declan,
> >
> > You are changing API (port_flow_query) which is in use in both MLX5
> > and MLX4 this results in breaking the build.
> 
> Hi Ori,
> 
> Do you mean "rte_flow_query"? port_flow_query() is a function in testpmd,
> how mlx is using it?
>

My bad let me be clearer.
MLX5 and MLX4 are implementing the rte_flow_ops query function.
This patch changes the prototype for the query function which results in 
compilation error and should also result in some change in the MLX5 and MLX4 
implementation.
 
 
> >
> > Best,
> > Ori
> >
> >> -Original Message-
> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty
> >> Sent: Thursday, April 26, 2018 3:08 PM
> >> To: dev@dpdk.org
> >> Cc: Ferruh Yigit ; Declan Doherty
> >> 
> >> Subject: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support
> >> to rte_flow
> >>
> >> Add rte_flow_action_count action data structure to enable shared
> >> counters across multiple flows on a single port or across multiple
> >> flows on multiple ports within the same switch domain. Also this
> >> enables multiple count actions to be specified in a single flow action.
> >>
> >> This patch also modifies the existing rte_flow_query API to take the
> >> rte_flow_action structure as an input parameter instead of the
> >> rte_flow_action_type enumeration to allow querying a specific action
> >> from a flow rule when multiple actions of the same type are specified.
> >>
> >> This patch also contains updates for the bonding and failsafe PMDs
> >> and testpmd application which are affected by this API change.
> >>
> >> Signed-off-by: Declan Doherty 
> >> ---
> >>  app/test-pmd/cmdline_flow.c |  6 ++--
> >>  app/test-pmd/config.c   | 15 +
> >>  app/test-pmd/testpmd.h  |  2 +-
> >>  doc/guides/prog_guide/rte_flow.rst  | 59 +--
> 
> >> --
> >>  drivers/net/bonding/rte_eth_bond_flow.c |  9 ++---
> >>  drivers/net/failsafe/failsafe_flow.c|  4 +--
> >>  lib/librte_ether/rte_flow.c |  2 +-
> >>  lib/librte_ether/rte_flow.h | 38 +++--
> >>  lib/librte_ether/rte_flow_driver.h  |  2 +-
> >>  9 files changed, 93 insertions(+), 44 deletions(-)
> >>
> >> diff --git a/app/test-pmd/cmdline_flow.c
> >> b/app/test-pmd/cmdline_flow.c index 1ac04a0ab..5754e7858 100644
> >> --- a/app/test-pmd/cmdline_flow.c
> >> +++ b/app/test-pmd/cmdline_flow.c
> >> @@ -420,7 +420,7 @@ struct buffer {
> >>} destroy; /**< Destroy arguments. */
> >>struct {
> >>uint32_t rule;
> >> -  enum rte_flow_action_type action;
> >> +  struct rte_flow_action action;
> >>} query; /**< Query arguments. */
> >>struct {
> >>uint32_t *group;
> >> @@ -1101,7 +1101,7 @@ static const struct token token_list[] = {
> >>.next = NEXT(NEXT_ENTRY(QUERY_ACTION),
> >> NEXT_ENTRY(RULE_ID),
> >> NEXT_ENTRY(PORT_ID)),
> >> -  .args = ARGS(ARGS_ENTRY(struct buffer, args.query.action),
> >> +  .args = ARGS(ARGS_ENTRY(struct buffer,
> >> args.query.action.type),
> >> ARGS_ENTRY(struct buffer, args.query.rule),
> >> ARGS_ENTRY(struct buffer, port)),
> >>.call = parse_query,
> >> @@ -3842,7 +3842,7 @@ cmd_flow_parsed(const struct buffer *in)
> >>break;
> >>case QUERY:
> >>port_flow_query(in->port, in->args.query.rule,
> >> -  in->args.query.action);
> >> +  &in->args.query.action);
> >>break;
> >>case LIST:
> >>port_flow_list(in->port, in->args.list.group_n, diff --git
> >> a/app/test-pmd/config.c b/app/test-pmd/config.c index
> >> 0f2425229..cd6102dfc 100644
> >> --- a/app/test-pmd/config.c
> >> +++ b/app/test-pmd/config.c
> >> @@ -1452,7 +1452,7 @@ port_flow_flush(portid_t port_id)
> >>  /** Query a flow rule. */
> >>  int
> >>  port_flow_query(portid_t port_id, uint32_t rule,
> >> -  enum rte_flow_action_type action)
> >> +  const struct rte_flow_action *action)
> >>  {
> >>struct rte_flow_error error;
> >>struct rte_port *port;
> >> @@ -1474,15 +1474,16 @@ port_flow_query(portid_t port_id, uint32_t
> rule,
> >>return -ENOENT;
> >>}
> >>if ((unsigned int)action >= RTE_DIM(flow_action) ||
> >> -  !flow_action[action].name)
> >> +  !flow_action[action->type].name)
> >>name = "unknown";
> >>else
> >> -  name = flow_action[action].name;
> >