Hi Stephen, Thanks for this patch set.
I'm happy with it although I have some concerns regarding how the dynamic logs work, or maybe I have a wrong understanding about it. I have tried to read some doc about how it works, and I found the original patch from Olivier the best source, so maybe things have changed a bit and my concerns are unfounded. I think it is OK to specifically add something like --log-level='pmd\.i40e.*,8' if you want to debug a PMD, but if you are an user and you just want to know why the app is not finding any port, finding out the right string is not trivial. For example, with an PF, the NFP PMD goes through a process where the NFP device (no the NIC) is accessed first through a complex interface, then firmware is uploaded, DPDK ports created (for multiport devices), etc. I think any error in that process should be output if the right loglevel is there and not just if the right log type was specifically enabled. Is this what would happen with your patchset? I have suffered silent configuration problems, like the NFP card being in the wrong NUMA socket, and although I can solve that quickly because I have the knowledge, other people using NFP with DPDK require someone to help because they do not know what is going on. And this is usually bad because they have another NIC card in the same host (in the right NUMA socket) and the app just works smoothly then, leaving our NIC with a bad press. So I think, some errors should always appear with the right loglevel configured. On Wed, Apr 25, 2018 at 4:45 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > These are several small changes to make the Netronome driver > use logging macros in the same way as other drivers. > > Compile tested only. I don't have Netronome hardware. > > Stephen Hemminger (5): > net/nfp: use correct logtype for init messages > net/nfp: add implied new line to PMD_DRV_LOG > net/nfp: fix double space in init log > net/nfl: add newline in PMD_RX/TX_LOG macros > net/nfp: use dynamic logging everywhere > > drivers/net/nfp/nfp_net.c | 186 ++++++++++++++++----------------- > drivers/net/nfp/nfp_net_logs.h | 9 +- > 2 files changed, 98 insertions(+), 97 deletions(-) > > -- > 2.17.0 > >
