Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

[sebb]

On Sat, 7 Dec 2024 at 14:00, Mark Struberg  wrote:
>
> Hi Gilles!
>
> > Maybe something like `isNonIntrospectibleClass()`?
>
> Thanks, that's a really good name!
> I've changed it and pushed it to the PR.
>
>
> Btw, on a more general level.
> It seems that the discussions on the PRs are NOT mirrored on any ASF lists?

All GH messages should be reflected on mailing lists.
There are GH messages prefixed with PR on issues@commons and
notifications@commons.
If there are any that appear to be missing, please provide details so
Infra can be informed.

> Nor does the discussions on slack obviously.
Agreed.
> And as you all know: if it didn't happen on the list, it didn't happen.
>
> So I would really appreciate if the discussion gets moved over to here.

Probably a good idea anyway.

> For example I really cannot understand why we still keep adding --add-opens 
> for obviously broken stuff in the main branch instead of trying to discuss 
> solutions about how we approach fixing the modularity issues we have 
> *together*. My PR is really just a start, and I know that there is still a 
> lot to do. The question is more whether it is the right direction or not.
> But we should face it: right now commons-lang3 is not usable for the vast 
> majority of projects out there. In the last few months even the oldest 
> projects started moving away from Java8. And so should we imo. So please 
> folks, stop adding --add-opens all over the place.
>
> txs and LieGrue,
> strub
>
>
>
> > Am 06.12.2024 um 13:59 schrieb Gilles Sadowski :
> >
> > Hi.
> >
> > Le ven. 6 déc. 2024 à 13:41, struberg (via GitHub)  a 
> > écrit :
> >>
> >>
> >> struberg commented on PR #1328:
> >> URL: 
> >> https://github.com/apache/commons-lang/pull/1328#issuecomment-2523134541
> >>
> >>   Btw, I'm looking for another method name for `isJavaInternalClass()`. It 
> >> should rather express that the given clazz cannot be introspected via 
> >> reflection. Maybe something like `isNonIntrospectibleClass()`?
> >
> > How about "cannotDoReflection()"?
> >
> > Regards,
> > Gilles
> >
> >> [...]
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

[Mark Struberg]

Could you please also take a look? I peeked at commits@ and notifications@ and 
didn't see it. So maybe I overlooked them or they are not there.

txs and LieGrue,
strub

> Am 07.12.2024 um 17:05 schrieb sebb :
> 
> On Sat, 7 Dec 2024 at 14:00, Mark Struberg  > wrote:
>> 
>> Hi Gilles!
>> 
>>> Maybe something like `isNonIntrospectibleClass()`?
>> 
>> Thanks, that's a really good name!
>> I've changed it and pushed it to the PR.
>> 
>> 
>> Btw, on a more general level.
>> It seems that the discussions on the PRs are NOT mirrored on any ASF lists?
> 
> All GH messages should be reflected on mailing lists.
> There are GH messages prefixed with PR on issues@commons and
> notifications@commons.
> If there are any that appear to be missing, please provide details so
> Infra can be informed.
> 
>> Nor does the discussions on slack obviously.
> Agreed.
>> And as you all know: if it didn't happen on the list, it didn't happen.
>> 
>> So I would really appreciate if the discussion gets moved over to here.
> 
> Probably a good idea anyway.
> 
>> For example I really cannot understand why we still keep adding --add-opens 
>> for obviously broken stuff in the main branch instead of trying to discuss 
>> solutions about how we approach fixing the modularity issues we have 
>> *together*. My PR is really just a start, and I know that there is still a 
>> lot to do. The question is more whether it is the right direction or not.
>> But we should face it: right now commons-lang3 is not usable for the vast 
>> majority of projects out there. In the last few months even the oldest 
>> projects started moving away from Java8. And so should we imo. So please 
>> folks, stop adding --add-opens all over the place.
>> 
>> txs and LieGrue,
>> strub
>> 
>> 
>> 
>>> Am 06.12.2024 um 13:59 schrieb Gilles Sadowski :
>>> 
>>> Hi.
>>> 
>>> Le ven. 6 déc. 2024 à 13:41, struberg (via GitHub)  a 
>>> écrit :
 
 
 struberg commented on PR #1328:
 URL: 
 https://github.com/apache/commons-lang/pull/1328#issuecomment-2523134541
 
  Btw, I'm looking for another method name for `isJavaInternalClass()`. It 
 should rather express that the given clazz cannot be introspected via 
 reflection. Maybe something like `isNonIntrospectibleClass()`?
>>> 
>>> How about "cannotDoReflection()"?
>>> 
>>> Regards,
>>> Gilles
>>> 
 [...]
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
>> 
>> For additional commands, e-mail: dev-h...@commons.apache.org 
>> 
>> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> 
> For additional commands, e-mail: dev-h...@commons.apache.org 
> 

Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

[sebb]

On Sat, 7 Dec 2024 at 16:43, Mark Struberg  wrote:
>
> Could you please also take a look? I peeked at commits@ and notifications@ 
> and didn't see it. So maybe I overlooked them or they are not there.

Did you look at issues@?

What exactly is missing?

> txs and LieGrue,
> strub
>
> > Am 07.12.2024 um 17:05 schrieb sebb :
> >
> > On Sat, 7 Dec 2024 at 14:00, Mark Struberg  > > wrote:
> >>
> >> Hi Gilles!
> >>
> >>> Maybe something like `isNonIntrospectibleClass()`?
> >>
> >> Thanks, that's a really good name!
> >> I've changed it and pushed it to the PR.
> >>
> >>
> >> Btw, on a more general level.
> >> It seems that the discussions on the PRs are NOT mirrored on any ASF lists?
> >
> > All GH messages should be reflected on mailing lists.
> > There are GH messages prefixed with PR on issues@commons and
> > notifications@commons.
> > If there are any that appear to be missing, please provide details so
> > Infra can be informed.
> >
> >> Nor does the discussions on slack obviously.
> > Agreed.
> >> And as you all know: if it didn't happen on the list, it didn't happen.
> >>
> >> So I would really appreciate if the discussion gets moved over to here.
> >
> > Probably a good idea anyway.
> >
> >> For example I really cannot understand why we still keep adding 
> >> --add-opens for obviously broken stuff in the main branch instead of 
> >> trying to discuss solutions about how we approach fixing the modularity 
> >> issues we have *together*. My PR is really just a start, and I know that 
> >> there is still a lot to do. The question is more whether it is the right 
> >> direction or not.
> >> But we should face it: right now commons-lang3 is not usable for the vast 
> >> majority of projects out there. In the last few months even the oldest 
> >> projects started moving away from Java8. And so should we imo. So please 
> >> folks, stop adding --add-opens all over the place.
> >>
> >> txs and LieGrue,
> >> strub
> >>
> >>
> >>
> >>> Am 06.12.2024 um 13:59 schrieb Gilles Sadowski :
> >>>
> >>> Hi.
> >>>
> >>> Le ven. 6 déc. 2024 à 13:41, struberg (via GitHub)  a 
> >>> écrit :
> 
> 
>  struberg commented on PR #1328:
>  URL: 
>  https://github.com/apache/commons-lang/pull/1328#issuecomment-2523134541
> 
>   Btw, I'm looking for another method name for `isJavaInternalClass()`. 
>  It should rather express that the given clazz cannot be introspected via 
>  reflection. Maybe something like `isNonIntrospectibleClass()`?
> >>>
> >>> How about "cannotDoReflection()"?
> >>>
> >>> Regards,
> >>> Gilles
> >>>
>  [...]
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >>> For additional commands, e-mail: dev-h...@commons.apache.org
> >>>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> >> 
> >> For additional commands, e-mail: dev-h...@commons.apache.org 
> >> 
> >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org 
> > 
> > For additional commands, e-mail: dev-h...@commons.apache.org 
> > 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

[Mark Struberg]

Hi Gilles!

> Maybe something like `isNonIntrospectibleClass()`?

Thanks, that's a really good name!
I've changed it and pushed it to the PR.


Btw, on a more general level.
It seems that the discussions on the PRs are NOT mirrored on any ASF lists? Nor 
does the discussions on slack obviously.
And as you all know: if it didn't happen on the list, it didn't happen.

So I would really appreciate if the discussion gets moved over to here.

For example I really cannot understand why we still keep adding --add-opens for 
obviously broken stuff in the main branch instead of trying to discuss 
solutions about how we approach fixing the modularity issues we have 
*together*. My PR is really just a start, and I know that there is still a lot 
to do. The question is more whether it is the right direction or not.
But we should face it: right now commons-lang3 is not usable for the vast 
majority of projects out there. In the last few months even the oldest projects 
started moving away from Java8. And so should we imo. So please folks, stop 
adding --add-opens all over the place.

txs and LieGrue,
strub



> Am 06.12.2024 um 13:59 schrieb Gilles Sadowski :
> 
> Hi.
> 
> Le ven. 6 déc. 2024 à 13:41, struberg (via GitHub)  a écrit :
>> 
>> 
>> struberg commented on PR #1328:
>> URL: https://github.com/apache/commons-lang/pull/1328#issuecomment-2523134541
>> 
>>   Btw, I'm looking for another method name for `isJavaInternalClass()`. It 
>> should rather express that the given clazz cannot be introspected via 
>> reflection. Maybe something like `isNonIntrospectibleClass()`?
> 
> How about "cannotDoReflection()"?
> 
> Regards,
> Gilles
> 
>> [...]
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org