[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
Thanks for this PR @nathanejohnson, I will build it and run smoketests 
agains it. 
@blueorangutan package 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1957
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1960: CLOUDSTACK-9782: Host HA and KVM HA provider

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1960

CLOUDSTACK-9782: Host HA and KVM HA provider

Host-HA offers investigation, fencing and recovery mechanisms for host that 
for
any reason are malfunctioning. It uses Activity and Health checks to 
determine
current host state based on which it may degrade a host or try to recover 
it. On
failing to recover it, it may try to fence the host.

The core feature is implemented in a hypervisor agnostic way, with two 
separate
implementations of the driver/provider for Simulator and KVM hypervisors. 
The
framework also allows for implementation of other hypervisor specific 
provider
implementation in future.

The Host-HA provider implementation for KVM hypervisor uses the out-of-band
management sub-system to issue IPMI calls to reset (recover) or poweroff 
(fence)
a host.

The Host-HA provider implementation for Simulator provides a means of 
testing 
and validating the core framework implementation.

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Host+HA

Signed-off-by: Abhinandan Prateek 
Signed-off-by: Rohit Yadav 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack host-ha-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1960


commit 24ec0dd70a97be738e18cc66a6ec0401edd7f32f
Author: Rohit Yadav 
Date:   2017-02-15T12:06:18Z

CLOUDSTACK-9782: Host HA and KVM HA provider

Host-HA offers investigation, fencing and recovery mechanisms for host that 
for
any reason are malfunctioning. It uses Activity and Health checks to 
determine
current host state based on which it may degrade a host or try to recover 
it. On
failing to recover it, it may try to fence the host.

The core feature is implemented in a hypervisor agnostic way, with two 
separate
implementations of the driver/provider for Simulator and KVM hypervisors. 
The
framework also allows for implementation of other hypervisor specific 
provider
implementation in future.

The Host-HA provider implementation for KVM hypervisor uses the out-of-band
management sub-system to issue IPMI calls to reset (recover) or poweroff 
(fence)
a host.

The Host-HA provider implementation for Simulator provides a means of 
testing
and validating the core framework implementation.

Signed-off-by: Abhinandan Prateek 
Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][FS] Host HA for CloudStack

[Rohit Yadav]

Here are some advantages of the proposed feature that is implemented in two 
parts - a HA entity-agnostic framework and a HA provider implementation 
specific for a resource:

- Framework provides building blocks for health checks, degrading, recovery, 
fencing operations for a HA resource. This allows for several custom provider 
implementation possible for a resource type (host: hypervisor/storage etc), 
that are configurable/select-able for a host, with custom cluster/global 
settings to fine tune timeouts, rounds/limits and failure threshold ratios
- Separates policies from mechanism to provide health check investigation, 
fault detection (suspicions, activity checks) and degrade/recovery/fencing 
operation based on threshold/ratio of failure rounds. Over existing 
abstraction, the framework provides means to perform additional operations such 
as to perform liveness checks, recovery and degrading operations, and also 
perform all the operations (health checks, activity checks, 
degrade/recovery/fence operations) based on configurable rounds/thresholds of 
failure with all such tasks bound by a timeout for a partition (such as 
cluster, global etc).
- To reduce load on database and perform at scale (10k+ hosts), provides in 
memory task/queue management with configurable queue limits/sizes, operation 
thresholds and timeouts, operation counter management (for decision making) 
that are bound by a FSM.
- Also provides management of resource ownership across multiple management 
server
- Extends instrumentation to allow us to write deeper marvin tests to test 
internal state and state transitions using fault/state injecting APIs
- Host HA feature specifically provides means to recover and fence a host. With 
this feature, we've implemented a specific HA provider implementation for KVM 
that reliably uses out-of-band management subsystem (i.e uses ipmi) for 
recovery/fencing (reboot/poweroff), and uses a storage plugins approach to 
detect (disk) activities on NFS storage pools across a number of rounds and a 
failure threshold ratio for decision making.

I'll send the PR soon. Thanks.


Regards.


From: Koushik Das 
Sent: 21 February 2017 14:17:19
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS][FS] Host HA for CloudStack

See inline.

Thanks,
Koushik

On 21/02/17, 11:47 AM, "Rohit Yadav"  wrote:

Hi Koushik,


Thanks for sharing your comments and questions.


1. Yes, the FS is divided into two parts - a general HA framework which makes 
no assumption about the type of resource and HA provider implementation that 
works on a type of resource/hypervisor/storage etc.

[Koushik] Hmm the heading is misleading then. I would like to see the details 
of the generic HA framework that you are proposing for any resource type. What 
all resource types can/need to be HA’ed? Also I would like to see a clear 
definition of “storage HA”, ”network HA” or “any resource HA” etc. before going 
ahead with this generic framework. If this new framework ends up doing only 
doing Host/VM HA then there is no point doing all this.

Specifically, with this feature we want to solve the problem of HA-ing a host 
reliably and use out-of-band management subsystem (i.e. ipmi based 
status/reboot/power-off to investigate/recover/fence the host) in the HA 
provider implementation. Yes, a host HA should trigger VM HA, i.e. for the host 
being fenced move HA VMs to other hosts. This also reliably solves the issue of 
disk corruption when same HA VMs get started on multiple hosts.

[Koushik] If host HA implies doing HA on all VMs running in a host, I am not 
clear as to why host HA is needed separately when there is already VM HA 
available.

2. The old VM HA implementation makes a lot of assumptions about the type 
of resource (i.e. VM) it is HA-ing, it is tied to VM HA which is why HA for 
host could not be added in a straight forward way without regressions we could 
not test. With this new HA framework, it does not make any assumption around 
type of the resource and separates policy from mechanism, we also want to add 
deterministic tests (using marvin tests and a simulator based ha provider 
implementation) to demonstrate the generic HA functionality. In future with 
this framework, HA for various resources such as VM, storage, network can be 
added. As a first step we want to get the framework in, and support for Host as 
a resource type. We also want to reduce assumptions, or dependency as both VM 
HA and Host HA are related (sequence etc). The HAProvider interface would be 
something every hypervisor can implement.

[Koushik] Again please justify why host HA is needed when VM HA is already 
there? If the question is about ease of writing automated tests, I have already 
written simulator based tests for the existing VM HA. Please refer 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Writing+tests+leveraging+the+simulator+enhancements
 for the test details.

3. While an exi

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1942
  
LGTM on the code changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
LGTM but
I hope you appreciate the concerns @marcaurele , on the other hand let's 
fix what breaks and make sure the 4.9 to 4.10 works with this. We can always 
advice to upgrade to 4.9 before going up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It 
is not encoded in older upgrades. Unless we clean those upgrades up we will 
have some issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-523


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PRs for 4.10

[Rajani Karuturi]

6 days to go for the first RC.
Please get the required lgtms and tests ready for the PRs you like to see
in 4.10.
I will try to merge all the PRs that meet the criteria.

Thanks,
~Rajani

On 19 Feb 2017 3:11 p.m., "Rajani Karuturi"  wrote:

> noted.
>
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
>
> On February 17, 2017 at 6:03 PM, Frank Maximus (
> frank.maxi...@nuagenetworks.net) wrote:
>
> I have a couple of bugfixes on previous version outstanding,
> which I would like to have merged to 4.10,
> both still requiring review:
> on 4.8: PR#1912 : which
> fixes password service running on internal lb vms, making it impossible to
> do loadbalancing on port 8080
> on 4.9: PR#1925 : Minor
> plugin fix
>
> Kind Regards,
> Frank
>
> On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  wrote:
>
> I'd like to include https://github.com/apache/cloudstack/pull/1928 to 4.10
> as well. This is a simple fix that adds hypervisor capabilities for
> XenServer 7
>
> Thanks,
> -Syed
>
> On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 
> wrote:
>
> Not sure, I will see if I can find some time tomorrow to look at this.
> Thanks...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 
> wrote:
>
> Thanks Will. I will take a look at this today and merge.
>
> Is it possible to add a systemvmtemplate job on
> builds.apachecloudstack.net (https://builds.cloudstack.org/)
> similar to
> http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On February 13, 2017 at 10:46 PM, Will Stevens
> (wstev...@cloudops.com) wrote:
>
> At this point, I think 1741 is ready to merge. I think we need
> one more
> LGTM though...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
>  wrote:
>
> @Daan: In order for the tests to pass with 1741, the tests have
> to be run
> with the SystemVM from the PR being used.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland
> 
> wrote:
>
> About 1741, I started the packaging, Will but saw Boris making a
> remark about the system VMs. I'll look into that and start the
> tests.
>
> On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens
> 
> wrote:
>
> I would like to get 1741(strongswan) in, but I need to get
> Trillian to
>
> run
>
> against it with a system vm built from my pr. I have done a CI in
> bubble
> and it came back clean, but would like confirmation through
> Trillian as
> well.
>
> On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
>
> And this PR for 4.9 but need to be foward to 4.10 too.
>
> https://github.com/apache/cloudstack/pull/1929
>
> 2 LGTM
> CI green
>
> On 07/02/2017 13:07, Rajani Karuturi wrote:
>
> Hi all,
> If you know of any PRs which meet the below criteria, please
> mail
>
> them to
>
> me.
> 1. No open questions.
> 2. Has two LGTMs
> 3. Has CI test results.
>
> ~Rajani
> http://cloudplatform.accelerite.com
>
> --
> Daan
>
>

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-524


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-525


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
code LGTM

one small suggestion: 
Could you modify line 2253 (_vmIpFetchThreadExecutor.execute) to be 
executed only when hypervisor is XenServer(already supported) or Vmware 
(supported by this PR) ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Requesting for review - @abhinandanprateek @DaanHoogland @rashmidixit 
@karuturi @koushik-das 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
Requesting for review - @DaanHoogland @abhinandanprateek @karuturi 
@koushik-das @syed 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
@blueorangutan help


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
@rhtyd I understand these words: "help", "hello", "thanks", "package", 
"test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 
'vmware-51u1', 'vmware-50u1']
Additional tests: list of comma separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py, 
component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 
'abhinandanprateek', 'PaulAngus', 'borisstoyanov', 'DaanHoogland']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
@blueorangutan test centos7 xenserver-65sp1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@blueorangutan test centos7 xenserver-65sp1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1903
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1903
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/926
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/926
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PRs for 4.10

[Rohit Yadav]

Rajani and all,


Please consider following PRs for review and merge:


https://github.com/apache/cloudstack/pull/1829 (XenServer HVM VM attached disk 
limit bugfix, enough LGTMs and test results)

https://github.com/apache/cloudstack/pull/1941 (same as above with additional 
fixes, lacks review lgtms)
https://github.com/apache/cloudstack/pull/1896 (translation updates)

https://github.com/apache/cloudstack/pull/1770 (template size issue bugfix)

https://github.com/apache/cloudstack/pull/1950 (Ubuntu 16.04 packaging 
tomcat6/7 support)

https://github.com/apache/cloudstack/pull/1951 (xenserver7 capability fix and 
upgrade path from 4.9.2->4.9.3)

https://github.com/apache/cloudstack/pull/1944 (metrics view and infra tab/UI 
performance improvement)
https://github.com/apache/cloudstack/pull/1903 (cannot add users to vpc vpn)

https://github.com/apache/cloudstack/pull/1945

https://github.com/apache/cloudstack/pull/1946

https://github.com/apache/cloudstack/pull/1947
https://github.com/apache/cloudstack/pull/1856
https://github.com/apache/cloudstack/pull/1212



Regards.


From: Rajani Karuturi 
Sent: 22 February 2017 14:41:42
To: dev@cloudstack.apache.org
Subject: Re: PRs for 4.10

6 days to go for the first RC.
Please get the required lgtms and tests ready for the PRs you like to see
in 4.10.
I will try to merge all the PRs that meet the criteria.

Thanks,
~Rajani

On 19 Feb 2017 3:11 p.m., "Rajani Karuturi"  wrote:

> noted.
>
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
>
> On February 17, 2017 at 6:03 PM, Frank Maximus (
> frank.maxi...@nuagenetworks.net) wrote:
>
> I have a couple of bugfixes on previous version outstanding,
> which I would like to have merged to 4.10,
> both still requiring review:
> on 4.8: PR#1912 : which
> fixes password service running on internal lb vms, making it impossible to
> do loadbalancing on port 8080
> on 4.9: PR#1925 : Minor
> plugin fix
>
> Kind Regards,
> Frank
>
> On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  wrote:
>
> I'd like to include https://github.com/apache/cloudstack/pull/1928 to 4.10
> as well. This is a simple fix that adds hypervisor capabilities for
> XenServer 7
>
> Thanks,
> -Syed
>
> On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 
> wrote:
>
> Not sure, I will see if I can find some time tomorrow to look at this.
> Thanks...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 
> wrote:
>
> Thanks Will. I will take a look at this today and merge.
>
> Is it possible to add a systemvmtemplate job on
> builds.apachecloudstack.net (https://builds.cloudstack.org/)
> similar to
> http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
>
> Thanks,
>
> ~ Rajani
>
> http://cloudplatform.accelerite.com/
>
> On February 13, 2017 at 10:46 PM, Will Stevens
> (wstev...@cloudops.com) wrote:
>
> At this point, I think 1741 is ready to merge. I think we need
> one more
> LGTM though...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
>  wrote:
>
> @Daan: In order for the tests to pass with 1741, the tests have
> to be run
> with the SystemVM from the PR being used.
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland
> 
> wrote:
>
> About 1741, I started the packaging, Will but saw Boris making a
> remark about the system VMs. I'll look into that and start the
> tests.
>
> On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens
> 
> wrote:
>
> I would like to get 1741(strongswan) in, but I need to get
> Trillian to
>
> run
>
> against it with a system vm built from my pr. I have done a CI in
> bubble
> and it came back clean, but would like confirmation through
> Trillian as
> well.
>
> On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
>
> And this PR for 4.9 but need to be foward to 4.10 too.
>
> https://github.com/apache/cloudstack/pull/1929
>
> 2 LGTM
> CI green
>
> On 07/02/2017 13:07, Rajani Karuturi wrote:
>
> Hi all,
> If you know of any PRs which meet the below criteria, please
> mail
>
> them to
>
> me.
> 1. No open questions.
> 2. Has two LGTMs
> 3. Has CI test results.
>
> ~Rajani
> http://cloudplatform.accelerite.com
>
> --
> Daan
>
>

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
This is ready for merge @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1770: CLOUDSTACK-9628: Fix Template Size in Swift as Secon...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1770
  
@karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@karuturi pure translation changes, we need one more LGTM, otherwise this 
is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1946
  
LGTM.
@karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
LGTM, I'll test it manually as soon as I get some free time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
@karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1947
  
@karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
@karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
@karuturi this is ready for merge, using past review/test results. Though, 
I'll kick one more round of testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
Verified packages built alright with the change.
![screenshot from 2017-02-22 
16-09-11](https://cloud.githubusercontent.com/assets/95203/23207997/55394784-f919-11e6-9b50-a8c2897fd939.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r102430976
  
--- Diff: debian/control ---
@@ -16,6 +16,7 @@ Description: A common package which contains files which 
are shared by several C
 Package: cloudstack-management
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless | 
java8-runtime-headless | java8-runtime, cloudstack-common (= 
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector, 
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool, lsb-release
+Recommends: init-system-helpers
--- End diff --

@ustcweizhou is this necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r102431194
  
--- Diff: debian/control ---
@@ -16,6 +16,7 @@ Description: A common package which contains files which 
are shared by several C
 Package: cloudstack-management
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless | 
java8-runtime-headless | java8-runtime, cloudstack-common (= 
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector, 
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool, lsb-release
+Recommends: init-system-helpers
--- End diff --

Can we force it to a specific version, default it builds with 
init-system-helpers (>= 1.18~); if we can add >= 1.14 to support ubuntu 14.04?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@karuturi I think this should go in. Even being a bit of a risk, it will 
potentially reduce the support hours on upgrades.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1922#discussion_r102432766
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final 
VirtualRouter router, final
 sourceNatIpAdd = new Pair(ip, 
ipAddr.getNetworkId());
 addSourceNat = add;
 }
+
+if (!firstIP || add) {
+firstIP = false;
+}
--- End diff --

for additional public subnet on delete it is not sure which ip is set to 
first ip. So on delete we want to set sourcenat to true for all ips to delete 
source nat rules. 

@ramkatru 
I will add above comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

[stefaniabergljot]

Github user stefaniabergljot commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
@rafaelweingartner It's not, but you can treat IPNetwork like it's a 
standard list object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-526


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #672: Allow VM snapshots and volume snapshots to exi...

[anshul1886]

Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/672


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/926
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-527


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
I think changing the default API behaviour for fixing a bug should be ok as 
long as documented properly. Also in this case the deletion criteria is made 
more strict, so there is no unwanted data loss.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
I already see schema-4920to41000.sql and the corresponding cleanup file in 
master. So how will this fit in the overall scheme? Is there any plans for 
4.9.3?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r102445777
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@nitin-maharana @ustcweizhou The scope field in UI should be fine. But 
since there is a breaking change (accountName is made optional from required), 
there may be scenarios which will break. As long as it is documented should be 
ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

[dmabry]

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r102453548
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das : If we go with the scope field, we have to revert that change 
and have to make required depending on the scope we select. Like shown in the 
below snapshot.

https://cloud.githubusercontent.com/assets/12583725/23212092/1ba1cd22-f92b-11e6-83ba-72dab04dc497.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@koushik-das there is plan for 4.9.3, though the db schema change to 
insert/update the hypervisor capability need to go into 4.10.0 either with this 
PR carefully fwd-merged (which I can help with) or as a separate PR targeted 
only for 4.10. 4.9.x should not have unnecessary db changes, therefore 
4.9.2->4.9.3 is not expected of any other db changes, with this assumption and 
that 4.9.3 should be worked upon in next few months this would add an upgrade 
path from both 4.9.2/4.9.3 to 4.10.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: apidocs build failure

[Will Stevens]

The use case is to be able to display the API docs the same as we did in
the past with separation by default roles. It is still important to know
from the docs that a call like create private gateway can only be done by
an administrator (for example), which is longer possible from what I can
tell.

On Feb 22, 2017 2:29 AM, "Rohit Yadav"  wrote:

> Will, any specific use-case? For a live running cloudstack an apidocs
> plugin could also be written that displays apidocs for a role/user-account
> consuming from listApis.
>
>
> Regards.
>
> 
> From: williamstev...@gmail.com  on behalf of
> Will Stevens 
> Sent: 21 February 2017 20:31:14
> To: dev@cloudstack.apache.org
> Subject: Re: apidocs build failure
>
> Is there any chance we can fix the 'roles' issue with the API doc so we can
> get the docs split into the 'Admin', 'Domain Admin' and 'User' again?  The
> introduction of the dynamic roles broke the generation of the API docs with
> the different roles and I was not able to figure out how to fix it.  Any
> ideas for how to fix that?
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Tue, Feb 21, 2017 at 3:01 AM, Daan Hoogland <
> daan.hoogl...@shapeblue.com>
> wrote:
>
> > @Rajani @Rohit I missed this mail and fixed the apidoc on build.a.o
> > yesterday. I can disable it or throw it away might we so wish
> >
> > daan.hoogl...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands
> > @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> > Sent: 17 February 2017 10:27
> > To: dev@cloudstack.apache.org
> > Subject: Re: apidocs build failure
> >
> > Thanks Rajani, I've no objections.
> >
> >
> > Regards.
> >
> > 
> > From: Rajani Karuturi 
> > Sent: 17 February 2017 14:07:34
> > To: dev@cloudstack.apache.org
> > Subject: Re: apidocs build failure
> >
> > since travis is already verifying this, I asked infra to disable this
> job.
> >
> > Infra ticket https://issues.apache.org/jira/browse/INFRA-13527
> >
> > Please comment on the ticket if you think otherwise.
> >
> > Thanks,
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> > On February 13, 2017 at 12:29 PM, Rohit Yadav
> > (rohit.ya...@shapeblue.com) wrote:
> >
> > Jenkins need to have jdk8 available, someone need to setup jenv on it as
> > well.
> >
> > (The first job in Travis does apidocs/marvin/rat related checks to
> > validate changes and apidocs build).
> >
> > Regards.
> >
> > 
> > From: Rajani Karuturi 
> > Sent: 09 February 2017 12:21:40
> > To: dev@cloudstack.apache.org
> > Subject: apidocs build failure
> >
> > Hi all,
> >
> > All the apidocs builds[1] are failing after the recent java 8 change. Can
> > anyone having access fix it? Or should we talk to INFRA about it?
> >
> > Error message:
> >
> > [INFO]
> > -
> > [ERROR] COMPILATION ERROR : [INFO]
> > -
> > [ERROR] javac: invalid target release: 1.8 Usage: javac use -help for a
> > list of possible options
> >
> > [1] https://builds.apache.org/job/cloudstack-apidocs-master/
> >
> > Thanks
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com ( http://www.shapeblue.com )
> > 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> >
> >
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
Install log on Ubuntu 16.10:
root@antrix:/# apt-get install cloudstack-management -V
Reading package lists... Done
Building dependency tree   
Reading state information... Done
The following NEW packages will be installed:
   cloudstack-management (4.10.0.0-SNAPSHOT)
0 upgraded, 1 newly installed, 0 to remove and 36 not upgraded.
Need to get 0 B/345 MB of archives.
After this operation, 377 MB of additional disk space will be used.
Selecting previously unselected package cloudstack-management.
(Reading database ... 311454 files and directories currently installed.)
Preparing to unpack .../cloudstack-management_4.10.0.0-SNAPSHOT_all.deb ...
Unpacking cloudstack-management (4.10.0.0-SNAPSHOT) ...
Processing triggers for ureadahead (0.100.0-19) ...
Setting up cloudstack-management (4.10.0.0-SNAPSHOT) ...
usermod: no changes
Created symlink 
/etc/systemd/system/multi-user.target.wants/cloudstack-management.service → 
/lib/systemd/system/cloudstack-management.service.
Processing triggers for systemd (231-9ubuntu2) ...
Processing triggers for ureadahead (0.100.0-19) ...

Db setup:
root@antrix:/# cloudstack-setup-databases cloud:cloud --deploy-as=root:
Mysql user name:cloud   
[ OK ]
Mysql user password:**  
[ OK ]
Mysql server ip:localhost   
[ OK ]
Mysql server port:3306  
[ OK ]
Mysql root user name:root   
[ OK ]
Mysql root user password:** 
[ OK ]
Checking Cloud database files ...   
[ OK ]
Checking local machine hostname ... 
[ OK ]
Checking SELinux setup ...  
[ OK ]
Detected local IP address as 127.0.1.1, will use as cluster management 
server node IP[ OK ]
Preparing /etc/cloudstack/management/db.properties  
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-database.sql [ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema.sql   
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-database-premium.sql 
[ OK ]
Applying /usr/share/cloudstack-management/setup/create-schema-premium.sql   
[ OK ]
Applying /usr/share/cloudstack-management/setup/server-setup.sql
[ OK ]
Applying /usr/share/cloudstack-management/setup/templates.sql   
[ OK ]
Processing encryption ...   
[ OK ]
Finalizing setup ...
[ OK ]
CloudStack has successfully initialized database, you can check your 
database configuration in /etc/cloudstack/management/db.properties

Setup mgmt server:
 cloudstack-setup-management --tomcat7
Starting to configure CloudStack Management Server:
Configure Firewall ...[OK]
Configure CloudStack Management Server ...[Failed]
Failed to configure CloudStack Management Server, please see the 
/var/log/cloudstack/management/setupManagement.log for detail
Try to restore your system:
Restore Firewall ...  [OK]
Restore CloudStack Management Server ...[OK]

To fix this, I updated the JAVA_HOME in /etc/default/cloudstack-management
After this mgmt server successfully started:

root@antrix:/etc/cloudstack/management# cloudstack-setup-management 
--tomcat7
Starting to configure CloudStack Management Server:
Configure Firewall ...[OK]
Configure CloudStack Management Server ...[OK]
CloudStack Management Server setup is Done!

LGTM.

We might want to add in the install docs after the default JAVA_HOME. 
Alternatively, we can set the default for the 
/etc/default/cloudstack-management to: 
JAVA_HOME="/usr/lib/jvm/java-8-openjdk-amd64" @ustcweizhou ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
/cc @karuturi LGTM, manual tests confirm that mgmt server can be installed 
and setup on Ubuntu 16.04+.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
Additional notes, I still found issues with mgmt server not working 
afterwards likely due to permission/sudoers issue:

 017-02-22 18:37:25,076 INFO  [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) Trying to inject public and private keys 
into systemvm iso
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) Looking for scripts/vm/systemvm/injectkeys.sh in the classpath
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) System resource: 
file:/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) Absolute path =  
/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) Looking for vms/systemvm.iso in the classpath
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) System resource: file:/usr/share/cloudstack-common/vms/systemvm.iso
2017-02-22 18:37:25,076 DEBUG [c.c.u.s.Script] (localhost-startStop-1:null) 
(logid:) Absolute path =  /usr/share/cloudstack-common/vms/systemvm.iso
2017-02-22 18:37:25,076 DEBUG [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) Executing: /bin/bash 
/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh 
/var/lib/cloudstack/management/.ssh/id_rsa.pub 
/var/lib/cloudstack/management/.ssh/id_rsa 
/usr/share/cloudstack-common/vms/systemvm.iso 
2017-02-22 18:37:25,231 DEBUG [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) Exit value is 1
2017-02-22 18:37:25,232 DEBUG [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) mount: /dev/loop0 is write-protected, 
mounting read-onlymkdir: cannot create directory ‘/tmp/cloud/systemvm’: 
Permission denied
2017-02-22 18:37:25,232 INFO  [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) Injected public and private keys into 
systemvm iso with result : mount: /dev/loop0 is write-protected, mounting 
read-onlymkdir: cannot create directory ‘/tmp/cloud/systemvm’: Permission 
denied
2017-02-22 18:37:25,232 WARN  [c.c.s.ConfigurationServerImpl] 
(localhost-startStop-1:null) (logid:) Failed to inject generated public key 
into systemvm iso mount: /dev/loop0 is write-protected, mounting 
read-onlymkdir: cannot create directory ‘/tmp/cloud/systemvm’: Permission 
denied
2017-02-22 18:37:25,234 WARN  [o.a.c.s.m.c.ResourceApplicationContext] 
(localhost-startStop-1:null) (logid:) Exception encountered during context 
initialization - cancelling refresh attempt: 
org.springframework.context.ApplicationContextException: Failed to start bean 
'cloudStackLifeCycle'; nested exception is 
com.cloud.utils.exception.CloudRuntimeException: Failed to inject generated 
public key into systemvm iso mount: /dev/loop0 is write-protected, mounting 
read-onlymkdir: cannot create directory ‘/tmp/cloud/systemvm’: Permission 
denied




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@wido can you comment on this PR, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @serg38 @ustcweizhou @koushik-das @jburwell @borisstoyanov ,
Thanks for valuable insight. Code is modified according to your suggestion. 
:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
Great, nice work.
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1212
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
As a reminder for `-cleanup` SQL scripts:
> We rarely need cleanup scripts, only when some field/value is required 
during the data migration and has to be dropped later on.


https://cwiki.apache.org/confluence/display/CLOUDSTACK/DB+Upgrade+in+CloudStack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-528


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[dmabry]

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
LGTM.  tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar A part is still missing  that will use forced option in UI 
but give a user option to cancel deletion if active VMs exist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@serg38  
 
>A part is still missing that will use forced option in UI but give a user 
option to cancel deletion if active VMs exist.

I think it will be good to take all additional changes in separate PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #:

[borisstoyanov]

Github user borisstoyanov commented on the pull request:


https://github.com/apache/cloudstack/commit/3caedb9ef3556e2c59681f4ec52662f8d7797888#commitcomment-20995874
  
In test/integration/smoke/test_snapshots.py:
In test/integration/smoke/test_snapshots.py on line 281:
@nvazquez can you please see @serg38 comment:
```
We might need to tweak the test_data.py to add additional nfs mount e.g. 
nfs1 and use it in this test. E.g adding
"nfs1": {
"url": "nfs://nfs/export/automation/1/testprimary1",
"name": "Primary XEN1"
},
Blueorangutain environment will need to be adjusted as well. Otherwise the 
test fails with
CloudstackAPIException: Execute cmd: createstoragepool failed, due to: 
errorCode: 530, errorText:Failed to add data store: Storage pool 
NFS://10.2.0.16/acs/primary/pr1847-t854-kvm-centos7/marvin_pri1 already in use 
by another pod (id=1)\n']
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

[priyankparihar]

Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1774


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @borisstoyanov Please check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
Hi @borisstoyanov Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
Hi @borisstoyanov Please check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar Well. API use cases can be recoded but not UI. Presently we 
can delete templates in UI even with active VMs. With your changes there will 
be no recourse.  An easy option will be to   add a checkbox 'Forced' into 
Delete template confirmation dialog. I am -1 until UI supports deletion of 
templates with active VMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@blueorangutan package 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

[priyankparihar]

GitHub user priyankparihar reopened a pull request:

https://github.com/apache/cloudstack/pull/1774

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not …

Errored and Abandoned Templates should also be displayed on UI so that user 
has the accessibility to delete the template even before the clean up thread is 
run. Refer - 
[CLOUDSTACK-9608](https://issues.apache.org/jira/browse/CLOUDSTACK-9608)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9608

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1774


commit ca4088ded68a5b1e09960396683cf746cfe993ee
Author: Priyank Parihar 
Date:   2016-05-05T09:54:40Z

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not 
displayed on UI.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from
   self.services["nfs"],
to   self.services["nfs2"],

and re-merge this PR so it doesn't conflict with other tests using "nfs" 
test data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@borisroman and @serg38 Sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-529


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---