RE: KVM with OVS GRE has been supported on 4.3 release ?

2014-07-15 Thread lifuhui
Did u mean 4.4 will support it ?

> From: chiradeep.vit...@citrix.com
> To: dev@cloudstack.apache.org
> CC: murali.re...@citrix.com; ka...@uni-koeln.de
> Subject: Re: KVM with OVS GRE has been supported on 4.3 release ?
> Date: Mon, 14 Jul 2014 17:34:11 +
> 
> I believe there is a bug in 4.3 (but fixed in 4.4)
> 
> From: lifuhui mailto:gdblessu99...@hotmail.com>>
> Reply-To: "dev@cloudstack.apache.org" 
> mailto:dev@cloudstack.apache.org>>
> Date: Sunday, July 13, 2014 at 8:02 PM
> To: "dev@cloudstack.apache.org" 
> mailto:dev@cloudstack.apache.org>>
> Subject: KVM with OVS GRE has been supported on 4.3 release ?
> 
> Hello, everyone,
> Has anyone used OVS GRE with KVM on 4.3 release for isolation guest network ?
> Why there is no code support such as in
> 
> private String getGreEndpointIP(Host host, Network nw)
> ...
> switch (hvType) {
> case XenServer:
> String label = physNetTT.getXenNetworkLabel();
> if ((label != null) && (!label.equals(""))) {
> physNetLabel = label;
> }
> break;
> default:
> throw new CloudRuntimeException("Hypervisor " +
> hvType.toString() +
> " unsupported by OVS Tunnel Manager");
> ...
> 
> PS: Using 4.3 release code
> 
> If not support, why a release doc has mentioned as below:
> 
> 3.4 The OVS Plugin
> 3.4.1 Introduction to the OVS Plugin
> The OVS plugin is the native SDN implementations in CloudStack, using GRE 
> isolation method. The plugin can be
> used by CloudStack to implement isolated guest networks and to provide 
> additional services like NAT, port forwarding
> and load balancing.
> Features of the OVS Plugin
> The following table lists the CloudStack network services provided by the OVS 
> Plugin.
> Network Service
> Virtual Networking
> Static NAT
> Port Forwarding
> Load Balancing
> CloudStack version
> = 4.0
> = 4.3
> = 4.3
> = 4.3
> Table: Supported Services
> Note: The Virtual Networking service was originally called ‘Connectivity’ in 
> CloudStack 4.0
> The following hypervisors are supported by the OVS Plugin.
> Hypervisor
> XenServer
> KVM
> CloudStack version
> = 4.0
> = 4.3
> Table: Supported Hypervisors
> 
> Thanks
> 
> 
  

Re: [PROPOSAL] OAuth2 Single SignOn Integration

2014-07-15 Thread Sebastien Goasguen
Silvano,

Seems to me you are doing it for browser based dashboard access only ?

How about if I want to use the API straight up, how do you integrate an Oauth 
workflow there ?

On Jul 15, 2014, at 1:35 AM, Santhosh Edukulla  
wrote:

> Hi Silvano,
> 
> Few Notes:
> 
> 1. We had implementation details mentioned i believe, but we didn't mentioned 
> the design details and workflows. 
> 2. We didn't mentioned whether it is 2 legged flow or 3 legged flow.
> 3. Not clear with this statement, "Once user is authorized by oauth2 server, 
> javascript code reads parameters in url",
> 4. Whats the difference between "oauth2.credentials.url" and 
> "oauth2.baseurl", the later is redirect uri? If yes, Where will have redirect 
> uri hosted?
> 5. referring to the statement " When oauth2.baseurl, oauth2.client.id and 
> oauth2.client.secret are not set (default), oauthRequestUrl returns empty 
> response and OAuth2
> authentication is turned off.",  can we use a flag to denote whether to use 
> oauth flow or not? If set to false, dont use it otherwise continue with 
> default.
> 6. What about refresh token,i believe access token has limited life time? Any 
> call back mechanism to update with latest token if it gets expired?
> 7. Details like clientid,clientsecret needs to be encrypted when stored and 
> retrieved from global config?
> 8. How do we map the user logged in to roles and hierarchy inside CS? based 
> on email mapping?
> 9.  What is the significance of these two parameters  mentioned?
> oauth2.credentials.parameter.email (defaults to "email")
> * oauth2.domainid
> 10. clientid and clientsecret key are based upon per tenant basis, so what if 
> we want to oauth mechanism from multiple tenants at any stage? 
> 11. Default values for clientid and clientsecret are loaded at which stage? 
> during initial installation and for which tenant?
> 12. How do we verify the validity of clientid and clientsecret values? If 
> they are revoked? possibility of revoke is there? 
> 13. If we understand, it is only to authenticate a user through oauth flow, 
> we dont need authorization part inside of cs? I mean, what do we mean by 
> authorization from tenant once access key is granted?
> 14. If access key is not stored, how do we get refresh token?
> 15. What is the default sequence of authentication in case if oauth fails? 
> and order in which a given authentication mechanism will be chosen?
> 16. Can we also show a ui, where user can enable\disable oauth setting for a 
> given account? here, possibility of mismatch with emailid based upon current 
> implementation and oauth retrieved emailid post authentication is there? how 
> do we handle it?
> 17. Last, what is the significance of this feature, apart from authentication 
> support from third party clients? 
> 
> 
> Thanks!
> Santhosh
> 
> From: Silvano Nogueira Buback [silv...@corp.globo.com]
> Sent: Monday, July 14, 2014 4:59 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] OAuth2 Single SignOn Integration
> 
> Hi gyus,
> 
>I need to implement OAuth2 integration to provide single sign-on with
> others tools in my company. I can share this implementation with the
> community if you are interested. I suggest these changes in code:
> 
> 1. Create a new javascript called oauth2.js. This javascript is responsible
> for calling the new command called oauthRequestUrl that reads the global
> option "oauth2.baseurl" and returns this url plus "/authorize" with oauth2
> parameters. After receiving the answer, javascript redirects user to oauth2
> server.
> 2. Once user is authorized by oauth2 server, javascript code reads
> parameters in url and call oauthAuthorizeToken command. This command asks
> the oauth2 server by the access token, and if everything is ok, calls
> "oauth2.credentials.url" about user email and finds this user in the
> database, like ldap implementation does and returns authentication data.
> 3. Javascript fills g_loginResponse with answer from command and user is
> logged in.
> 
>   What do you think about this approach?
> 
> 
>  More details 
> 
> Alternative flows:
> 
> * When the url has parameter direct=true, the login dialog is shown.
> * When oauth2.baseurl, oauth2.client.id and oauth2.client.secret are not
> set (default), oauthRequestUrl returns empty response and OAuth2
> authentication is turned off.
> * If authorization token is invalid, user is redirected again to oauth2
> server.
> 
> 
> Commands:
> * oauthRequestUrl
> * oauthAuthorizeToken
> 
> 
> Global Options:
> * oauth2.baseurl
> * oauth2.client.id
> * oauth2.client.secret
> * oauth2.credentials.url: defaults to "/oauth2/v2/userinfo"
> * oauth2.credentials.parameter.email (defaults to "email")
> * oauth2.domainid
> 
> 
> Restrictions:
> * Domain Id will be a global option
> * Users are always redirected to oauth2 server. Access tokens are not
> stored.
> * Before using Cloudstack, the administrator must insert user in an account.

Nuage plugin in noredist or not

2014-07-15 Thread Hugo Trippaers
Heya,

While doing the review for the Nuage plugin (review 23282) i found that the 
plugin requires an distribution restricted library. Suresh (the developer) 
solved any runtime dependency problems by dynamically loading the library. My 
question is should we put the Nuage plugin in the noredist build because of 
this dependency anyway to clearly indicate that it is an optional component 
that needs distribution restricted libraries to work properly.

What do you think?

Cheers,

Hugo




Re: Nuage plugin in noredist or not

2014-07-15 Thread David Nalley
I think it should be in noredist, based on what I've seen.

--David

On Tue, Jul 15, 2014 at 3:40 AM, Hugo Trippaers  wrote:
> Heya,
>
> While doing the review for the Nuage plugin (review 23282) i found that the 
> plugin requires an distribution restricted library. Suresh (the developer) 
> solved any runtime dependency problems by dynamically loading the library. My 
> question is should we put the Nuage plugin in the noredist build because of 
> this dependency anyway to clearly indicate that it is an optional component 
> that needs distribution restricted libraries to work properly.
>
> What do you think?
>
> Cheers,
>
> Hugo
>
>


Re: [PROPOSAL] OAuth2 Single SignOn Integration

2014-07-15 Thread David Nalley
https://oltu.apache.org <-- maybe as a starting place.

On Tue, Jul 15, 2014 at 3:25 AM, Sebastien Goasguen  wrote:
> Silvano,
>
> Seems to me you are doing it for browser based dashboard access only ?
>
> How about if I want to use the API straight up, how do you integrate an Oauth 
> workflow there ?
>
> On Jul 15, 2014, at 1:35 AM, Santhosh Edukulla  
> wrote:
>
>> Hi Silvano,
>>
>> Few Notes:
>>
>> 1. We had implementation details mentioned i believe, but we didn't 
>> mentioned the design details and workflows.
>> 2. We didn't mentioned whether it is 2 legged flow or 3 legged flow.
>> 3. Not clear with this statement, "Once user is authorized by oauth2 server, 
>> javascript code reads parameters in url",
>> 4. Whats the difference between "oauth2.credentials.url" and 
>> "oauth2.baseurl", the later is redirect uri? If yes, Where will have 
>> redirect uri hosted?
>> 5. referring to the statement " When oauth2.baseurl, oauth2.client.id and 
>> oauth2.client.secret are not set (default), oauthRequestUrl returns empty 
>> response and OAuth2
>> authentication is turned off.",  can we use a flag to denote whether to use 
>> oauth flow or not? If set to false, dont use it otherwise continue with 
>> default.
>> 6. What about refresh token,i believe access token has limited life time? 
>> Any call back mechanism to update with latest token if it gets expired?
>> 7. Details like clientid,clientsecret needs to be encrypted when stored and 
>> retrieved from global config?
>> 8. How do we map the user logged in to roles and hierarchy inside CS? based 
>> on email mapping?
>> 9.  What is the significance of these two parameters  mentioned?
>> oauth2.credentials.parameter.email (defaults to "email")
>> * oauth2.domainid
>> 10. clientid and clientsecret key are based upon per tenant basis, so what 
>> if we want to oauth mechanism from multiple tenants at any stage?
>> 11. Default values for clientid and clientsecret are loaded at which stage? 
>> during initial installation and for which tenant?
>> 12. How do we verify the validity of clientid and clientsecret values? If 
>> they are revoked? possibility of revoke is there?
>> 13. If we understand, it is only to authenticate a user through oauth flow, 
>> we dont need authorization part inside of cs? I mean, what do we mean by 
>> authorization from tenant once access key is granted?
>> 14. If access key is not stored, how do we get refresh token?
>> 15. What is the default sequence of authentication in case if oauth fails? 
>> and order in which a given authentication mechanism will be chosen?
>> 16. Can we also show a ui, where user can enable\disable oauth setting for a 
>> given account? here, possibility of mismatch with emailid based upon current 
>> implementation and oauth retrieved emailid post authentication is there? how 
>> do we handle it?
>> 17. Last, what is the significance of this feature, apart from 
>> authentication support from third party clients?
>>
>>
>> Thanks!
>> Santhosh
>> 
>> From: Silvano Nogueira Buback [silv...@corp.globo.com]
>> Sent: Monday, July 14, 2014 4:59 PM
>> To: dev@cloudstack.apache.org
>> Subject: [PROPOSAL] OAuth2 Single SignOn Integration
>>
>> Hi gyus,
>>
>>I need to implement OAuth2 integration to provide single sign-on with
>> others tools in my company. I can share this implementation with the
>> community if you are interested. I suggest these changes in code:
>>
>> 1. Create a new javascript called oauth2.js. This javascript is responsible
>> for calling the new command called oauthRequestUrl that reads the global
>> option "oauth2.baseurl" and returns this url plus "/authorize" with oauth2
>> parameters. After receiving the answer, javascript redirects user to oauth2
>> server.
>> 2. Once user is authorized by oauth2 server, javascript code reads
>> parameters in url and call oauthAuthorizeToken command. This command asks
>> the oauth2 server by the access token, and if everything is ok, calls
>> "oauth2.credentials.url" about user email and finds this user in the
>> database, like ldap implementation does and returns authentication data.
>> 3. Javascript fills g_loginResponse with answer from command and user is
>> logged in.
>>
>>   What do you think about this approach?
>>
>>
>>  More details 
>>
>> Alternative flows:
>>
>> * When the url has parameter direct=true, the login dialog is shown.
>> * When oauth2.baseurl, oauth2.client.id and oauth2.client.secret are not
>> set (default), oauthRequestUrl returns empty response and OAuth2
>> authentication is turned off.
>> * If authorization token is invalid, user is redirected again to oauth2
>> server.
>>
>>
>> Commands:
>> * oauthRequestUrl
>> * oauthAuthorizeToken
>>
>>
>> Global Options:
>> * oauth2.baseurl
>> * oauth2.client.id
>> * oauth2.client.secret
>> * oauth2.credentials.url: defaults to "/oauth2/v2/userinfo"
>> * oauth2.credentials.parameter.email (defaults to "email")
>> * oauth2.domainid
>>
>>
>

Re: xapi jar as separate release

2014-07-15 Thread David Nalley
XAPI is not an apache project. I do not believe that we can sanely
make a separate release. Compared to bundling it with our release as
we We have essentially 'forked' XAPI from the upstream at Xen Project
and made our own changes. Those changes are in the latest version
AIUI, but not the version that we are currently using.

--David


On Mon, Jul 14, 2014 at 6:17 AM, Daan Hoogland  wrote:
> LS,
>
> One of the issues with the last RC was that the cloudstack xapi was
> not a released version (i.e. 6.2.0-1-SNAPSHOT). In the release build
> it was numbered as 6.2.0-1 but not referred by that release number but
> by the snapshot id. There are several solutions to this. The most
> correct would seem to be to release the xapi module separately and
> create a release for it. I know that there has been some shifting back
> and forth with this module and I would like to get consensus to create
> a separate module and release for it.
>
> So my question: How do I get a version into the maven repo?
>
> thanks,
> --
> Daan


Re: Nuage plugin in noredist or not

2014-07-15 Thread Daan Hoogland
I like the solution and wouldn't mind setting it as a policy for no
redist plugins. Still I think it should be in the noredist build to
prevent surprises for users at runtime.

On Tue, Jul 15, 2014 at 10:32 AM, David Nalley  wrote:
> I think it should be in noredist, based on what I've seen.
>
> --David
>
> On Tue, Jul 15, 2014 at 3:40 AM, Hugo Trippaers  wrote:
>> Heya,
>>
>> While doing the review for the Nuage plugin (review 23282) i found that the 
>> plugin requires an distribution restricted library. Suresh (the developer) 
>> solved any runtime dependency problems by dynamically loading the library. 
>> My question is should we put the Nuage plugin in the noredist build because 
>> of this dependency anyway to clearly indicate that it is an optional 
>> component that needs distribution restricted libraries to work properly.
>>
>> What do you think?
>>
>> Cheers,
>>
>> Hugo
>>
>>



-- 
Daan


Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47766
---


The patch applies cleanly on current master and i did some additional checking:

Findbugs report:
[INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @ 
cloud-plugin-network-vsp ---
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Found reliance on default encoding in 
com.cloud.network.manager.NuageVspManagerImpl.addNuageVspDevice(AddNuageVspDeviceCmd):
 String.getBytes() ["com.cloud.network.manager.NuageVspManagerImpl"] At 
NuageVspManagerImpl.java:[lines 90-420]

Can you have a look at this issue?

The coverage of the unit tests is at the moment 54 out of 1233 lines (4%) based 
on the cobertura coverage reports. We need either a significant unit test 
coverage or functional smoke tests so the community can validate that this 
plugin works when preparing for a release.




plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java


Are these your changes, they seem unrelated to the Nuage implementation?


- Hugo Trippaers


On July 15, 2014, 1:45 a.m., Suresh Ramamurthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
> 
> (Updated July 15, 2014, 1:45 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
> 
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/WEB-INF/classes/resources/messages.properties b192cb0 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 46933d9 
>   client/tomcatconf/commands.properties.in b9ac27b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  8e4c710 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  0922765 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  0f42df3 
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspA

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
---


Can you resubmit this patch without the reformatting of system.js? At the 
moment it shows 4233 changes to that file, which is impossible for me to 
review. I need to see only the changes you made for the brocade plugin. If you 
think a reformat is needed you can submit the reformat as a separate patch, but 
we would prefer to keep the existing format.



- Hugo Trippaers


On July 11, 2014, 10:10 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 11, 2014, 10:10 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>



Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47769
---


This is looking good, when you addresses the comment on the system.js file in 
the other review i'll apply both patches. If the patches apply clean i'll run 
findbugs and cobertura to check for any issues and unit test coverage. 

Hugo


plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd


Did you check with the rat plugin if the license is accepted like this?

I think the license is only properly detected with it is located in a 
comment like in the spring xml files.


- Hugo Trippaers


On July 11, 2014, 11:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 11, 2014, 11:44 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23314/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>



Re: Review Request 23448: Disable in-band management of OVS on cloud_link_local_network on XenServer

2014-07-15 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/#review47770
---

Ship it!


e8c32c7f5b21edda8cb67b2d477cf34e1faeb677

- daan Hoogland


On July 14, 2014, 9:11 a.m., Joris van Lieshout wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23448/
> ---
> 
> (Updated July 14, 2014, 9:11 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-7103
> https://issues.apache.org/jira/browse/CLOUDSTACK-7103
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> By default XenServer uses Openvswitch and has in-band management enabled on 
> any new network. This is not desirable for the cloud_link_local_network. This 
> can be disabled by setting the network's other config parameter 
> vswitch-disable-in-band to true.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  a9840bd 
> 
> Diff: https://reviews.apache.org/r/23448/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>



Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Suresh Ramamurthy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---

(Updated July 15, 2014, 11:38 a.m.)


Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
Yang.


Changes
---

Hi Hugo, Alena, Sheng

I have made following changes to the code and submitted for review:

a) Fixed find bug issue found by Hugo

b) Based on Alena's and Sheng's comment on VPC implementation, I removed 
NuageVspVpcElement file and NuageVspVpc provider. Now NuageVspElement handles
NetworkACL and VPCVirtualRouter is used for UserData service.

Thanks Alena and Sheng for pointing me about how to implement VPC

Thanks Hugo on taking care of reviewing our code chnages and sending out email 
regarding noredist...

Regards,
Suresh


Bugs: CLOUDSTACK-6845
https://issues.apache.org/jira/browse/CLOUDSTACK-6845


Repository: cloudstack-git


Description
---

This is first code drop for NuageVsp Network plugin support that will bring the 
Nuage VSP network virtualization technology to CloudStack.

We need a new branch to checkin the fixes once the review is done. Please 
create a new branch for NuageVsp plugin.


Diffs (updated)
-

  api/src/com/cloud/event/EventTypes.java 71bfdb6 
  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/WEB-INF/classes/resources/messages.properties b192cb0 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 46933d9 
  client/tomcatconf/commands.properties.in b9ac27b 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
8e4c710 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 0922765 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 0f42df3 
  plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AddNuageVspDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DeleteNuageVspDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/IssueNuageVspResourceRequestCmd.java
 PRE-CREATION 
  
plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListN

Re: [DISCUSS]CLOUDSTACK-6191

2014-07-15 Thread Daan Hoogland
Edison,

You reverted a600d8408ea86782318139c17cf346c8497943d0 in the end. The
code in there is solving a lot of resource problems. Did you pinpoint
the exact problem? I can not imagine that there is not a side effect
that Santhosh didn't know about and is undesirable that is really the
really the root case. We should find that and not just revert because
an existing bug was uncovered.


On Mon, Jul 14, 2014 at 11:18 PM, Edison Su  wrote:
> Yoshikazu fixed the issue related to qemu-img which introduced by his patch 
> in cloudstack-6191.
> But there is another issue introduced by commit: 
> a600d8408ea86782318139c17cf346c8497943d0, which causes starting vm failure.
> So I checked in a commit: e1095b0110f08fb0c7965f9cf293a6073bbce511, to fix 
> CLOUDSTACK-7051.
> So I think, both CLOUDSTACK-6191 and CLOUDSTACK-7051 should be fixed now, no 
> need to revert or change CLOUDSTACK-6191.
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Saturday, July 12, 2014 11:02 AM
>> To: dev
>> Subject: Re: [DISCUSS]CLOUDSTACK-6191
>>
>> -0 What does it fix and is the solution bonifide. We should fix the test 
>> suite if
>> it is. The test suite not working is not enough reason to revert a commit, it
>> should block the test-suite because the system is broken, not because of the
>> way the test suite works.
>>
>> Disclaimer: I do not know enough of KVM to make a judgement call. I just got
>> triggered by the motivation in the mail thread.
>>
>> On Sat, Jul 12, 2014 at 12:21 AM, Rayees Namathponnan
>>  wrote:
>> > +1 Revert now and enable after complete full test in KVM
>> >
>> > KVM automation blocked more than 7 days due to this defect
>> >
>> > https://issues.apache.org/jira/browse/CLOUDSTACK-7051
>> >
>> > Regards,
>> > Rayees
>> >
>> > -Original Message-
>> > From: Edison Su [mailto:edison...@citrix.com]
>> > Sent: Friday, July 11, 2014 2:49 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: [DISCUSS]CLOUDSTACK-6191
>> >
>> > Move the discussion to the list about CloudStack-6191:
>> > Automation test is blocked by this bug, we need to find a solution. My
>> suggestion is sort-of-revert-the-patch, but still give admin the opportunity 
>> to
>> specify the way to optimize KVM volume creation. The reasons:
>> >
>> > 1.   End user shouldn't care about how the volume is created, is it
>> sparse,flat/thin-provisoned or whatever technology used by hypervisor. So
>> we'd better not expose this option in disk offering.
>> >
>> > 2.It's true that admin does care about how the volume is created, 
>> > so
>> we can add a global configuration just for the kvm volume creation. For
>> vmware, the option is already there(vmware.create.full.clone to control
>> whether link clone or full clone is used to create volume). We can add an
>> option, something like kvm.qcow2.volume.create.options.
>> > Comments?
>>
>>
>>
>> --
>> Daan



-- 
Daan


Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Suresh Ramamurthy


> On July 15, 2014, 11:02 a.m., Hugo Trippaers wrote:
> > The patch applies cleanly on current master and i did some additional 
> > checking:
> > 
> > Findbugs report:
> > [INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @ 
> > cloud-plugin-network-vsp ---
> > [INFO] BugInstance size is 1
> > [INFO] Error size is 0
> > [INFO] Total bugs: 1
> > [INFO] Found reliance on default encoding in 
> > com.cloud.network.manager.NuageVspManagerImpl.addNuageVspDevice(AddNuageVspDeviceCmd):
> >  String.getBytes() ["com.cloud.network.manager.NuageVspManagerImpl"] At 
> > NuageVspManagerImpl.java:[lines 90-420]
> > 
> > Can you have a look at this issue?
> > 
> > The coverage of the unit tests is at the moment 54 out of 1233 lines (4%) 
> > based on the cobertura coverage reports. We need either a significant unit 
> > test coverage or functional smoke tests so the community can validate that 
> > this plugin works when preparing for a release.
> > 
> >

I have fixed the find bugs issue. I will work on functional test cases 
tomorrow. I will also send email to community as you suggested regarding FT for 
plugins.


> On July 15, 2014, 11:02 a.m., Hugo Trippaers wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java,
> >  line 1413
> > 
> >
> > Are these your changes, they seem unrelated to the Nuage implementation?

I do not see this diff in my latest file uploads. This is not our change.


- Suresh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47766
---


On July 15, 2014, 11:38 a.m., Suresh Ramamurthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
> 
> (Updated July 15, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
> 
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/WEB-INF/classes/resources/messages.properties b192cb0 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 46933d9 
>   client/tomcatconf/commands.properties.in b9ac27b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  8e4c710 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  0922765 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  0f42df3 
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nua

Guidelines on Functional Test for plugins

2014-07-15 Thread Suresh Ramamurthy
Hi All,

Can any one please point me to any document or example for sample FT for
plugins.
Testing plugin needs some setup tp be available.

Is there any way in ACS framework where we can bypass the setup and still
test the functionality?
In some cases where the client library can not be redistributed, how do we
test it?

Please let me know so that I can write some FT for plugin that we are
developing.

Thanks,
Suresh


[ACS44] non-blocking issue CLOUDSTACK-6036 CloudStack stops the machine for no reason

2014-07-15 Thread Daan Hoogland
Tomasz, Damodar,

The issue mentioned seems to be a timing issue. It must be a corner
case as only two users mention it and Ryan seems to have a work
around. I appriciate the nature of the issue being a bug but it seems
to be not a blocker for the release.

Can you concur?

-- 
Daan


[ACS44] kvm machines not starting blocker

2014-07-15 Thread Daan Hoogland
Gents,

is 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 to be pulled in 4.4? I
would like to be sure and spin another RC.

@Marcus: I am reading your mail as such that this is the only issue
remaining as blocker AFAYAC. correct?

-- 
Daan


Re: [VOTE] Apache Cloudstack 4.4.0

2014-07-15 Thread Daan Hoogland
Tomasz,

As I understand the issue this is what happens:

The user stops the vm from the UI
The MS sends the stop command to the machine
The machine stops and takes a long time for it
The MS reschedules the stop
Then machine stops
the user starts the machine
the MS get by stopping the machine

Did the user ever get a confirmation that the machine was stopped or
that stopping failed? If so, this is the bug, as it seems the MS works
as designed.

Don't get me wrong; I am trying to figure out a path to a solution for
you. I am not convinced there is a bug in the management server
though. That doesn't mean it can be in cloudstack over all. Either at
a design level or for instance in some inter-process communication.

kind regards,
Daan Hoogland


On Fri, Jul 11, 2014 at 2:45 PM, Tomasz Zięba  wrote:
> Hello,
>
> We are waiting for the patch with longingly.
>
> Error associated with self-closing of machines causes very serious
> complications, both from the technical (users need to wait for 10 minutes
> and check if the machine is not closed automatically) as well as the
> business side (this problem does not look very professional from the user
> side)
>
> Given that:
> - An error has been detected in February so 5 months ago,
> - in earlier versions  (3.0.2) error does not exists,
> - there is a procedure to reproduce this error,
>
> we would be very grateful if this issue will be resolved in ACS4.4.
>
>
> --
> Regards,
> Tomasz Zięba
> Twitter: @TZieba
> LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
>
> 2014-07-11 13:48 GMT+02:00 Daan Hoogland :
>
>> Our beloved VP pointed out that there has not come a vote conclusion yet:
>>
>> The 4.4.0 vote has resulted in a rejection of the present release
>> candidate due to -1 of Marcus and no active voting since.
>>
>> there are three issues pending from this vote thread:
>> - CLOUDSTACK-6036 (Tomasz)
>> - unable to add a KVM host (Marcus)
>> - top level pom.xml still contains a -SNAPSHOT suffix (Ove, question
>> outstanding to Tim)
>>
>> Can I have some reporting on the status of those issues by the
>> reporters, please?
>>
>> regards,
>> your friendly release manager
>>
>>
>> On Wed, Jul 2, 2014 at 10:18 PM, Daan Hoogland 
>> wrote:
>> > Hi All,
>> >
>> > I've created a 4.4.0 release, with the following artifacts up for a
>> > vote:
>> >
>> > Git Branch and Commit SH:
>> >
>> > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
>> > Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
>> >
>> > List of changes:
>> >
>> > http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
>> >
>> > Source release (checksums and signatures are available at the same
>> > location):
>> > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
>> >
>> > PGP release keys (signed using 4096R/AA4736F3):
>> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>> >
>> > Vote will be open for 72 hours.
>> >
>> > For sanity in tallying the vote, can PMC members please be sure to
>> > indicate "(binding)" with their vote?
>> >
>> > [ ] +1  approve
>> > [ ] +0  no opinion
>> > [ ] -1  disapprove (and reason why)
>> >
>> >
>> > I will ad my key to the mentioned KEYS file as soon as possible,
>> > --
>> > Daan
>>
>>
>>
>> --
>> Daan
>
>
>



-- 
Daan


Re: KVM with OVS GRE has been supported on 4.3 release ?

2014-07-15 Thread Murali Reddy
Yes. 4.4 has the support for KVM.

From: lifuhui mailto:gdblessu99...@hotmail.com>>
Date: Tuesday, 15 July 2014 12:34 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Murali Reddy mailto:murali.re...@citrix.com>>, 
Claus Kalle mailto:ka...@uni-koeln.de>>
Subject: RE: KVM with OVS GRE has been supported on 4.3 release ?

Did u mean 4.4 will support it ?

> From: chiradeep.vit...@citrix.com
> To: dev@cloudstack.apache.org
> CC: murali.re...@citrix.com; 
> ka...@uni-koeln.de
> Subject: Re: KVM with OVS GRE has been supported on 4.3 release ?
> Date: Mon, 14 Jul 2014 17:34:11 +
>
> I believe there is a bug in 4.3 (but fixed in 4.4)
>
> From: lifuhui 
> mailto:gdblessu99...@hotmail.com>>
> Reply-To: 
> "dev@cloudstack.apache.org"
>  
> mailto:dev@cloudstack.apache.org>>
> Date: Sunday, July 13, 2014 at 8:02 PM
> To: 
> "dev@cloudstack.apache.org"
>  
> mailto:dev@cloudstack.apache.org>>
> Subject: KVM with OVS GRE has been supported on 4.3 release ?
>
> Hello, everyone,
> Has anyone used OVS GRE with KVM on 4.3 release for isolation guest network ?
> Why there is no code support such as in
>
> private String getGreEndpointIP(Host host, Network nw)
> ...
> switch (hvType) {
> case XenServer:
> String label = physNetTT.getXenNetworkLabel();
> if ((label != null) && (!label.equals(""))) {
> physNetLabel = label;
> }
> break;
> default:
> throw new CloudRuntimeException("Hypervisor " +
> hvType.toString() +
> " unsupported by OVS Tunnel Manager");
> ...
>
> PS: Using 4.3 release code
>
> If not support, why a release doc has mentioned as below:
>
> 3.4 The OVS Plugin
> 3.4.1 Introduction to the OVS Plugin
> The OVS plugin is the native SDN implementations in CloudStack, using GRE 
> isolation method. The plugin can be
> used by CloudStack to implement isolated guest networks and to provide 
> additional services like NAT, port forwarding
> and load balancing.
> Features of the OVS Plugin
> The following table lists the CloudStack network services provided by the OVS 
> Plugin.
> Network Service
> Virtual Networking
> Static NAT
> Port Forwarding
> Load Balancing
> CloudStack version
> = 4.0
> = 4.3
> = 4.3
> = 4.3
> Table: Supported Services
> Note: The Virtual Networking service was originally called ‘Connectivity’ in 
> CloudStack 4.0
> The following hypervisors are supported by the OVS Plugin.
> Hypervisor
> XenServer
> KVM
> CloudStack version
> = 4.0
> = 4.3
> Table: Supported Hypervisors
>
> Thanks
>
>


Re: [VOTE] Apache Cloudstack 4.4.0

2014-07-15 Thread Tomasz Zięba
Hello,

The user does not receive confirmation of the operation.
>From the point of view of user input it looks like the machine itself
stopped.

As you can see in the logs, the ACS explicitly sends stop command, as if
they press the Stop button from the GUI, so it is aware of the action from
the perspective of the ACS / MS.

I can not point out which component may be responsible for it.
We have tried to analyze the code to understand what is happening,
but the part of the code related to HAWorker is not very clear.
Unfortunately we could not find online any assumptions on the level of
architecture / design of HAWorker.
Maybe method of small steps help find a solution.
First a small question: why HAWorker performs reschedule. What was the idea
for such action.




2014-07-15 14:26 GMT+02:00 Daan Hoogland :

> Tomasz,
>
> As I understand the issue this is what happens:
>
> The user stops the vm from the UI
> The MS sends the stop command to the machine
> The machine stops and takes a long time for it
> The MS reschedules the stop
> Then machine stops
> the user starts the machine
> the MS get by stopping the machine
>
> Did the user ever get a confirmation that the machine was stopped or
> that stopping failed? If so, this is the bug, as it seems the MS works
> as designed.
>
> Don't get me wrong; I am trying to figure out a path to a solution for
> you. I am not convinced there is a bug in the management server
> though. That doesn't mean it can be in cloudstack over all. Either at
> a design level or for instance in some inter-process communication.
>
> kind regards,
> Daan Hoogland
>
>
> On Fri, Jul 11, 2014 at 2:45 PM, Tomasz Zięba  wrote:
> > Hello,
> >
> > We are waiting for the patch with longingly.
> >
> > Error associated with self-closing of machines causes very serious
> > complications, both from the technical (users need to wait for 10 minutes
> > and check if the machine is not closed automatically) as well as the
> > business side (this problem does not look very professional from the user
> > side)
> >
> > Given that:
> > - An error has been detected in February so 5 months ago,
> > - in earlier versions  (3.0.2) error does not exists,
> > - there is a procedure to reproduce this error,
> >
> > we would be very grateful if this issue will be resolved in ACS4.4.
> >
> >
> > --
> > Regards,
> > Tomasz Zięba
> > Twitter: @TZieba
> > LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
> 
> >
> > 2014-07-11 13:48 GMT+02:00 Daan Hoogland :
> >
> >> Our beloved VP pointed out that there has not come a vote conclusion
> yet:
> >>
> >> The 4.4.0 vote has resulted in a rejection of the present release
> >> candidate due to -1 of Marcus and no active voting since.
> >>
> >> there are three issues pending from this vote thread:
> >> - CLOUDSTACK-6036 (Tomasz)
> >> - unable to add a KVM host (Marcus)
> >> - top level pom.xml still contains a -SNAPSHOT suffix (Ove, question
> >> outstanding to Tim)
> >>
> >> Can I have some reporting on the status of those issues by the
> >> reporters, please?
> >>
> >> regards,
> >> your friendly release manager
> >>
> >>
> >> On Wed, Jul 2, 2014 at 10:18 PM, Daan Hoogland  >
> >> wrote:
> >> > Hi All,
> >> >
> >> > I've created a 4.4.0 release, with the following artifacts up for a
> >> > vote:
> >> >
> >> > Git Branch and Commit SH:
> >> >
> >> >
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
> >> > Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
> >> >
> >> > List of changes:
> >> >
> >> >
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> >> >
> >> > Source release (checksums and signatures are available at the same
> >> > location):
> >> > https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
> >> >
> >> > PGP release keys (signed using 4096R/AA4736F3):
> >> > https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> >> >
> >> > Vote will be open for 72 hours.
> >> >
> >> > For sanity in tallying the vote, can PMC members please be sure to
> >> > indicate "(binding)" with their vote?
> >> >
> >> > [ ] +1  approve
> >> > [ ] +0  no opinion
> >> > [ ] -1  disapprove (and reason why)
> >> >
> >> >
> >> > I will ad my key to the mentioned KEYS file as soon as possible,
> >> > --
> >> > Daan
> >>
> >>
> >>
> >> --
> >> Daan
> >
> >
> >
>
>
>
> --
> Daan
>



-- 
Regards,
Tomasz Zięba
Twitter: @TZieba
LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/



vms stopped while restarted by user

2014-07-15 Thread Daan Hoogland
Tomasz,

I can only fantasize on the full rationale of the implementation of
the retry but in general it makes sense to me. A job has a time to try
and a times tried field. the worker manager has time to sleep and max
retries. As you can see below these are read from the configuration:

value = params.get("time.to.sleep");
_timeToSleep = NumbersUtil.parseInt(value, 60) * 1000;

value = params.get("max.retries");
_maxRetries = NumbersUtil.parseInt(value, 5);

there is also

value = params.get("stop.retry.interval");
_stopRetryInterval = NumbersUtil.parseInt(value, 10 * 60);


The time.to.sleep and stop.retry.interval seem to jointly explain the
ten minute scenario you described in the bug report. They don't do
completely as some of the handling of the values is based on
bitshifting and not on datetime calculus (using mixed factors of
1000,60,60,24 and 365.25)
You can try and play with those to tune your setting. In any case
looking at the vm to decide to restart the vm is not usefull as
Cloudstack will do some cleanup after stopping the instance. You
should really wait untill cloudstack reports on the job with either
succes or error.

On Tue, Jul 15, 2014 at 3:12 PM, Tomasz Zięba  wrote:
> Hello,
>
> The user does not receive confirmation of the operation.
> From the point of view of user input it looks like the machine itself
> stopped.
>
> As you can see in the logs, the ACS explicitly sends stop command, as if
> they press the Stop button from the GUI, so it is aware of the action from
> the perspective of the ACS / MS.
>
> I can not point out which component may be responsible for it.
> We have tried to analyze the code to understand what is happening,
> but the part of the code related to HAWorker is not very clear.
> Unfortunately we could not find online any assumptions on the level of
> architecture / design of HAWorker.
>
> Maybe method of small steps help find a solution.
> First a small question: why HAWorker performs reschedule. What was the idea
> for such action.
>
>
>
>
> 2014-07-15 14:26 GMT+02:00 Daan Hoogland :
>
>> Tomasz,
>>
>> As I understand the issue this is what happens:
>>
>> The user stops the vm from the UI
>> The MS sends the stop command to the machine
>> The machine stops and takes a long time for it
>> The MS reschedules the stop
>> Then machine stops
>> the user starts the machine
>> the MS get by stopping the machine
>>
>> Did the user ever get a confirmation that the machine was stopped or
>> that stopping failed? If so, this is the bug, as it seems the MS works
>> as designed.
>>
>> Don't get me wrong; I am trying to figure out a path to a solution for
>> you. I am not convinced there is a bug in the management server
>> though. That doesn't mean it can be in cloudstack over all. Either at
>> a design level or for instance in some inter-process communication.
>>
>> kind regards,
>> Daan Hoogland
>>
>>
>> On Fri, Jul 11, 2014 at 2:45 PM, Tomasz Zięba  wrote:
>> > Hello,
>> >
>> > We are waiting for the patch with longingly.
>> >
>> > Error associated with self-closing of machines causes very serious
>> > complications, both from the technical (users need to wait for 10
>> > minutes
>> > and check if the machine is not closed automatically) as well as the
>> > business side (this problem does not look very professional from the
>> > user
>> > side)
>> >
>> > Given that:
>> > - An error has been detected in February so 5 months ago,
>> > - in earlier versions  (3.0.2) error does not exists,
>> > - there is a procedure to reproduce this error,
>> >
>> > we would be very grateful if this issue will be resolved in ACS4.4.
>> >
>> >
>> > --
>> > Regards,
>> > Tomasz Zięba
>> > Twitter: @TZieba
>> > LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
>> >


-- 
Daan


Re: [ACS44] non-blocking issue CLOUDSTACK-6036 CloudStack stops the machine for no reason

2014-07-15 Thread Tomasz Zięba
Hello,

I can not assess time-consuming to solve this problem.

I'm afraid that with the growing popularity of the ACS product this problem
will escalate.
Users will be more persuasive to install large installation based on the
ACS.
The fact that the machine user closes after a few minutes does not mean
that there are problems with them. In our infrastructure, we have installed
a large ERP environment, DataMining, etc. hence we observe this issue so
fast.

Back to the main thread,

I can concur that we should shift this issue to the next version.

A few thoughts:
- Maybe we should introduce a flag indicating the potential complexity of
the solution error ? I am not a developer so I don't know if this proposal
is correct.
- Notice that with the emergence of the next versions, the list of "Known
Issues" is growing.
- It seems to me that the ACS is becoming a mature product so we should
ensure both the stability of the code, and new functionality - unless, that
idea may be new branches eg CloudSand.com


2014-07-15 14:11 GMT+02:00 Daan Hoogland :

> Tomasz, Damodar,
>
> The issue mentioned seems to be a timing issue. It must be a corner
> case as only two users mention it and Ryan seems to have a work
> around. I appriciate the nature of the issue being a bug but it seems
> to be not a blocker for the release.
>
> Can you concur?
>
> --
> Daan
>



-- 
Regards,
Tomasz Zięba
Twitter: @TZieba
LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/



Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

2014-07-15 Thread punith s


> On July 14, 2014, 11:16 p.m., Mike Tutkowski wrote:
> > From an e-mail I sent to dev@ about vendor-specific config values:
> > 
> > 
> > Alena Prokharchyk via cloudstack.apache.org 
> > 10:42 AM (1 hour ago)
> > 
> > to dev 
> > Mike, may be you already know this info, putting it here in case someone
> > is not aware of that. When global config variables are plugin specific,
> > they have to inserted by the manager from your plugin; they should never
> > be put to Config.java class.
> > 
> > To implement it, make your manager implement Configurable.java. Here is
> > the FS explaining it in more details:
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration

hi mike,

thanks for the update, considering that the plugin specific configurations to 
be inserted from the plugin manager, i'm now inserting the cloudbyte global 
config from the provider while the plugin is been configured or installed.

thanks.  


- punith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review47724
---


On July 11, 2014, 6:12 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 11, 2014, 6:12 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
>   server/src/com/cloud/configuration/Config.java fbcb1f4 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

2014-07-15 Thread punith s

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/
---

(Updated July 15, 2014, 7:48 p.m.)


Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.


Changes
---

inserting the cloudbyte global configurations from the plugin provider instead 
of config.java, also supporting the update api for storage pool.


Repository: cloudstack-git


Description
---

The new improvised cloudbyte plugin for cloudstack supports the following 
features

* support for managed storage, where each vm disk has the guaranteed QoS.

* supports resize of the volume.

* supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
KVM and vmware ESX with respect to managed storage.

* supports storage level snapshot capabilites as well as hypervisor level 
snapshot feature.

* also exposing the custom api's for better ui integration.

* support for unlimited storage nodes across the sites.

* account integration in cloudbyte with respect to domains in cloudstack.


Diffs (updated)
-

  
plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
 87c5f51 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
 99d1e2a 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
 33004e3 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
 de4711a 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
 e591082 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
 b75d12a 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
 PRE-CREATION 
  
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23410/diff/


Testing
---

system testing done.


Thanks,

punith s



unit tests not working from eclipse

2014-07-15 Thread Daan Hoogland
H,

a silly mistake probably: none of the unit tests I try to run from
eclipse work. they all report (test-) class not found. I have tried
several from server and utils so far. The target/test-classes is
configured in both projects. tests are passing beyond server on the
cli with mvn test.

Anyone that can show me the err of my ways?

thanks,
-- 
Daan


Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47774
---


Suresh,

While testing the new plugin i noticed that i get a popup telling me "Provider 
NuageVsp should be enabled in at least one physical network of the zone 
specified" even though i have not configured anything. I was just trying to 
create a VPC on a clean cloudstack installation (using VLAN isolation on the 
networks).

Can you have a look? The plugin should not impact anybody that is not using 
Nuage.



- Hugo Trippaers


On July 15, 2014, 11:38 a.m., Suresh Ramamurthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
> 
> (Updated July 15, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
> 
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/WEB-INF/classes/resources/messages.properties b192cb0 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 46933d9 
>   client/tomcatconf/commands.properties.in b9ac27b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  8e4c710 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  0922765 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  0f42df3 
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
>  PRE-CREATION 
> 

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Hugo Trippaers


> On July 15, 2014, 3:01 p.m., Hugo Trippaers wrote:
> > Suresh,
> > 
> > While testing the new plugin i noticed that i get a popup telling me 
> > "Provider NuageVsp should be enabled in at least one physical network of 
> > the zone specified" even though i have not configured anything. I was just 
> > trying to create a VPC on a clean cloudstack installation (using VLAN 
> > isolation on the networks).
> > 
> > Can you have a look? The plugin should not impact anybody that is not using 
> > Nuage.
> > 
> >

Hah, i think you just fixed my problem with diff 4, will retry.


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47774
---


On July 15, 2014, 11:38 a.m., Suresh Ramamurthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
> ---
> 
> (Updated July 15, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-6845
> https://issues.apache.org/jira/browse/CLOUDSTACK-6845
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
> 
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 71bfdb6 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/WEB-INF/classes/resources/messages.properties b192cb0 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 46933d9 
>   client/tomcatconf/commands.properties.in b9ac27b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  8e4c710 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  0922765 
>   
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>  0f42df3 
>   plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/nuage-vsp/src/com/cloud/agen

Re: KVM with OVS GRE has been supported on 4.3 release ?

2014-07-15 Thread Claus Kalle
Hi all,

I found out (also in mail exchange with Murali) that there is really no
support for management of the GRE tunnel itsself in 4.3.

If you setup the GRE tunnel(s) yourself statically (which I did) between
the KVM hosts, everything works out well for transporting the guest
traffic over the tunnel(s).
However still the only "network service" done by the ovs plugin is
"Virtual Networking", all the others being promissed in the doc do not
appear as choice in the respective dialog.

Murali mentioned a passible 4.3.1 pacth release fixing this and that...

Best regards, Claus

schrieb Chiradeep Vittal am 14.07.2014 19:34 Uhr:
> I believe there is a bug in 4.3 (but fixed in 4.4)
> 
> From: lifuhui mailto:gdblessu99...@hotmail.com>>
> Reply-To: "dev@cloudstack.apache.org "
> mailto:dev@cloudstack.apache.org>>
> Date: Sunday, July 13, 2014 at 8:02 PM
> To: "dev@cloudstack.apache.org "
> mailto:dev@cloudstack.apache.org>>
> Subject: KVM with OVS GRE has been supported on 4.3 release ?
> 
> Hello, everyone,
> Has anyone used OVS GRE with KVM on 4.3 release for isolation guest
> network ?
> Why there is no code support such as in
> 
> private String getGreEndpointIP(Host host, Network nw)
> ...
> switch (hvType) {
> case XenServer:
> String label = physNetTT.getXenNetworkLabel();
> if ((label != null) && (!label.equals(""))) {
> physNetLabel = label;
> }
> break;
> default:
> throw new CloudRuntimeException("Hypervisor " +
> hvType.toString() +
> " unsupported by OVS Tunnel Manager");
> ...
> 
> PS: Using 4.3 release code
> 
> If not support, why a release doc has mentioned as below:
> 
> 3.4 The OVS Plugin
> 3.4.1 Introduction to the OVS Plugin
> The OVS plugin is the native SDN implementations in CloudStack, using
> GRE isolation method. The plugin can be
> used by CloudStack to implement isolated guest networks and to provide
> additional services like NAT, port forwarding
> and load balancing.
> Features of the OVS Plugin
> The following table lists the CloudStack network services provided by
> the OVS Plugin.
> Network Service
> Virtual Networking
> Static NAT
> Port Forwarding
> Load Balancing
> CloudStack version
> 
> = 4.0
> = 4.3
> = 4.3
> = 4.3
> 
> Table: Supported Services
> Note: The Virtual Networking service was originally called
> ‘Connectivity’ in CloudStack 4.0
> The following hypervisors are supported by the OVS Plugin.
> Hypervisor
> XenServer
> KVM
> CloudStack version
> 
> = 4.0
> = 4.3
> 
> Table: Supported Hypervisors
> 
> Thanks
> 
>  

-- 
Claus Kalle, Universitaet zu Koeln, RRZK   i   i
 Leiter Abteilung Systeme  I   I
 E-Mail: ka...@uni-koeln.deM   M
 Fon: 0221 470 89581  /I\
 Fax: 0221 470 89625  MiMiMiM
 Snail-Mail: Weyertal 121, 50931 KoelnMIMiMiM


Re: KVM with OVS GRE has been supported on 4.3 release ?

2014-07-15 Thread Sebastien Goasguen
Let me wrap in Tuna in this discussion, since I believe he is the one who did 
the KVM support for the GRE controller.

On Jul 15, 2014, at 1:53 AM, Claus Kalle  wrote:

> Hi all,
> 
> I found out (also in mail exchange with Murali) that there is really no
> support for management of the GRE tunnel itsself in 4.3.
> 
> If you setup the GRE tunnel(s) yourself statically (which I did) between
> the KVM hosts, everything works out well for transporting the guest
> traffic over the tunnel(s).
> However still the only "network service" done by the ovs plugin is
> "Virtual Networking", all the others being promissed in the doc do not
> appear as choice in the respective dialog.
> 
> Murali mentioned a passible 4.3.1 pacth release fixing this and that...
> 
> Best regards, Claus
> 
> schrieb Chiradeep Vittal am 14.07.2014 19:34 Uhr:
>> I believe there is a bug in 4.3 (but fixed in 4.4)
>> 
>> From: lifuhui mailto:gdblessu99...@hotmail.com>>
>> Reply-To: "dev@cloudstack.apache.org "
>> mailto:dev@cloudstack.apache.org>>
>> Date: Sunday, July 13, 2014 at 8:02 PM
>> To: "dev@cloudstack.apache.org "
>> mailto:dev@cloudstack.apache.org>>
>> Subject: KVM with OVS GRE has been supported on 4.3 release ?
>> 
>> Hello, everyone,
>> Has anyone used OVS GRE with KVM on 4.3 release for isolation guest
>> network ?
>> Why there is no code support such as in
>> 
>> private String getGreEndpointIP(Host host, Network nw)
>> ...
>> switch (hvType) {
>>case XenServer:
>>String label = physNetTT.getXenNetworkLabel();
>>if ((label != null) && (!label.equals(""))) {
>>physNetLabel = label;
>>}
>>break;
>>default:
>>throw new CloudRuntimeException("Hypervisor " +
>>hvType.toString() +
>>" unsupported by OVS Tunnel Manager");
>> ...
>> 
>> PS: Using 4.3 release code
>> 
>> If not support, why a release doc has mentioned as below:
>> 
>> 3.4 The OVS Plugin
>> 3.4.1 Introduction to the OVS Plugin
>> The OVS plugin is the native SDN implementations in CloudStack, using
>> GRE isolation method. The plugin can be
>> used by CloudStack to implement isolated guest networks and to provide
>> additional services like NAT, port forwarding
>> and load balancing.
>> Features of the OVS Plugin
>> The following table lists the CloudStack network services provided by
>> the OVS Plugin.
>> Network Service
>> Virtual Networking
>> Static NAT
>> Port Forwarding
>> Load Balancing
>> CloudStack version
>> 
>>= 4.0
>>= 4.3
>>= 4.3
>>= 4.3
>> 
>> Table: Supported Services
>> Note: The Virtual Networking service was originally called
>> ‘Connectivity’ in CloudStack 4.0
>> The following hypervisors are supported by the OVS Plugin.
>> Hypervisor
>> XenServer
>> KVM
>> CloudStack version
>> 
>>= 4.0
>>= 4.3
>> 
>> Table: Supported Hypervisors
>> 
>> Thanks
>> 
>> 
> 
> -- 
> Claus Kalle, Universitaet zu Koeln, RRZK   i   i
> Leiter Abteilung Systeme  I   I
> E-Mail: ka...@uni-koeln.deM   M
> Fon: 0221 470 89581  /I\
> Fax: 0221 470 89625  MiMiMiM
> Snail-Mail: Weyertal 121, 50931 KoelnMIMiMiM



RE: Tomcat version issue while building cloudstack on RHEL7 RPMS

2014-07-15 Thread Rayees Namathponnan
Thanks Hugo, defect https://issues.apache.org/jira/browse/CLOUDSTACK-7106 
created to track this 

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Sunday, July 13, 2014 11:52 PM
To: dev@cloudstack.apache.org
Subject: Re: Tomcat version issue while building cloudstack on RHEL7 RPMS

Hey Rayees,

We should make a second set of scripts for the new redhat and cents releases. 
It's not only tomcat that has changes, for example we also need systemd scripts 
for cloudstack. I've been working on it, but it's not finished. 

Cheers.

Hugo


On 13 jul. 2014, at 19:19, Rayees Namathponnan  
wrote:

> Hi All,
> 
> I am trying to build  4.5/master RPM package in RHEL 7 box,  in cloud.spec 
> file there are dependency with tomcat6 which is not available in RHEL 7 repo.
> 
> RHEL 7 repo comes with tomcat7, and  I cannot create RPM package due tomcat6 
> missing package.
> 
> Any suggestion on this ? we should modify cloud.spec to remove hard 
> dependency on tomcat6 ?
> 
> Regards,
> Rayees
> 



Re: [PROPOSAL] OAuth2 Single SignOn Integration

2014-07-15 Thread Silvano Nogueira Buback
@Rohit Yadav
I know OAuth2 is tricky and the protocol was designed for authorization,
not authentication. But Globo.com, like many companies, use OAuth2 for
authentication. So, SAML is not a option to me. I need to integrate with
internal tools at Globo, and these tools work only with OAuth2.

@Sebastien
API are accessed by user, as today, using apikey and secretkey. OAuth is
only to UI.

@David,
Thank you. I will look this lib.

@Edukulla
I try to summarize your questions:

* In the code below, you can see all parameters needed to configure OAuth
authentication with Google, Github and Globo. My idea is that they are
global options (there are more global options than I sent before). Other
providers may not work, this list is for the first plugin release. People
can help integrating more providers.
* Pay attention with the way to get user email. This is really tricky,
because this is not part of specification. But if all providers answer json
and have a key named "email", the implementation will work. Google, Github
and Globo.co already do this.
* ClientId and secret may store encrypted in Global Options, like others
password.
* As the number of global options increase, I create an option called
"oauth2.enable", if you want to enable plugin. Of course,
if all parameters are not set, doesn't matter if plugin is enabled or not.
* The idea is not to authorize resources, is only to authenticate. So, I
don't need to store access key. When user accesses
UI, he is redirected to oauth2 server, and if authorization was granted
before, oauth2 server will redirect user to cloudstack without asking for
permission. This works with all 3 providers. I need only to have access to
email when the session starts, and then cloudstack keeps its own session.

The big problem is with domainid, that must be an global option. Other
problem happen with new accounts. May I create new user in an existed
account. The account name for new users are stored in global settings too.
At Globo.com we are discussing, but I guess if a user is not in cloudstack
they can't logged using oauth. Like happen in ldap.

Bellow I put some code to show that OAuth is not different between these 3
providers.

I will start the development of this feature next week. So, I will
appreciate all comments to help me to understand problems. After I start I
will create the design document.


-- BEGIN CODE ---
# before run: pip install requests_oauthlib
import sys
# Credentials you get from registering a new application
app = sys.argv[1]
print "For app %s" % repr(app)

redirect_uri = 'https://localhost:8000/'

if app == 'globo':
client_id = 'XXX'
client_secret = 'XXX'
authorization_base_url = "XXX"
token_url = "XXX"
user_url = 'XXX'
scope = []
elif app == 'github':
client_id = 'XXX'
client_secret = 'XXX'
authorization_base_url = "https://github.com/login/oauth/authorize";
token_url = "https://github.com/login/oauth/access_token";
user_url = 'https://api.github.com/user'
scope = ['user']
elif app == 'google':
client_id = 'XXX'
client_secret = 'XXX'
authorization_base_url = "https://accounts.google.com/o/oauth2/auth";
token_url = "https://accounts.google.com/o/oauth2/token";
scope = [
"https://www.googleapis.com/auth/userinfo.email";,
"https://www.googleapis.com/auth/userinfo.profile";
]
user_url = 'https://www.googleapis.com/oauth2/v1/userinfo'
else:
print "UNKNOW APP"
sys.exit(1)

from requests_oauthlib import OAuth2Session
oauth2_session = OAuth2Session(client_id, scope=scope,
redirect_uri=redirect_uri)

authorization_url, state =
oauth2_session.authorization_url(authorization_base_url)
print 'Please go here and authorize,', authorization_url

# Get the authorization verifier code from the callback url
redirect_response = raw_input('Paste the full redirect URL here:')

# Fetch the access token
oauth2_session.fetch_token(token_url, client_secret=client_secret,
authorization_response=redirect_response)

# Fetch a protected resource, i.e. user profile
r = oauth2_session.get(user_url)
print r.json()
print "email=", r.json()['email']
-- END CODE ---






On Tue, Jul 15, 2014 at 5:34 AM, David Nalley  wrote:

> https://oltu.apache.org <-- maybe as a starting place.
>
> On Tue, Jul 15, 2014 at 3:25 AM, Sebastien Goasguen 
> wrote:
> > Silvano,
> >
> > Seems to me you are doing it for browser based dashboard access only ?
> >
> > How about if I want to use the API straight up, how do you integrate an
> Oauth workflow there ?
> >
> > On Jul 15, 2014, at 1:35 AM, Santhosh Edukulla <
> santhosh.eduku...@citrix.com> wrote:
> >
> >> Hi Silvano,
> >>
> >> Few Notes:
> >>
> >> 1. We had implementation details mentioned i believe, but we didn't
> mentioned the design details and workflows.
> >> 2. We didn't mentioned whether it is 2 legged flow or 3 legged flow.
> >> 3. Not clear with this statement, "Once user is authorized by oauth2
> server, javascript co

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Suresh Ramamurthy
Hi Hugo,

Could you please test the latest diffs. I have removed default NuageVspVpc
offering. This could have caused the issue.
I will also test my changes locally.

Thanks,
Suresh


On Tue, Jul 15, 2014 at 8:02 AM, Hugo Trippaers <
htrippa...@schubergphilis.com> wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23282/
>
> On July 15th, 2014, 3:01 p.m. UTC, *Hugo Trippaers* wrote:
>
> Suresh,
>
> While testing the new plugin i noticed that i get a popup telling me 
> "Provider NuageVsp should be enabled in at least one physical network of the 
> zone specified" even though i have not configured anything. I was just trying 
> to create a VPC on a clean cloudstack installation (using VLAN isolation on 
> the networks).
>
> Can you have a look? The plugin should not impact anybody that is not using 
> Nuage.
>
>
>  Hah, i think you just fixed my problem with diff 4, will retry.
>
>
> - Hugo
>
> On July 15th, 2014, 11:38 a.m. UTC, Suresh Ramamurthy wrote:
>   Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and
> Sheng Yang.
> By Suresh Ramamurthy.
>
> *Updated July 15, 2014, 11:38 a.m.*
>  *Bugs: * CLOUDSTACK-6845
> 
>  *Repository: * cloudstack-git
> Description
>
> This is first code drop for NuageVsp Network plugin support that will bring 
> the Nuage VSP network virtualization technology to CloudStack.
>
> We need a new branch to checkin the fixes once the review is done. Please 
> create a new branch for NuageVsp plugin.
>
>
>   Testing
>
> Nuage VSP plugin depends on following components of Nuage SDN solution
> a) Nuage VSD
> b) Nuage VSC
> c) Nuage VRS, this needs installed on the Hypervisor
> All the above components needs to be provisioned for the plugin to function 
> properly. Also, Nuage VSP plugin directly talks with Nuage VSD using Rest 
> API. So, all the components needs to be running to test the plugin 
> functionality.
>
> The following tests are tested
>
> Isolated Network Test Cases
>
> a) Create a network offering with default egress deny rule and select 
> services supported by Nuage VSP plugin. Choose NuageVsp as the service 
> provider for DHCP, SourceNAT, StaticNAT, Firewall and Virtual Networking 
> services.
>Choose VirtualRouter as the service provider for UserData service.
> b) Create an isolated Network with network offering created above
> c) Spawn 2 VMs. Verify that VMs should each get an IP address. They should 
> ping each other. Verify that SSH to a box on the external network should fail
> b) Create a Static NAT and associate it one of the VM. Add an Egress rule for 
> the network with source CIDR as 0.0.0.0/0, protocol as TCP and ssh port number
> d) Verify that SSH to box that is in the external network should work
> e) Verify that Password reset for the VM should work
>
> VPC Test Cases
>
> a) Create a network offering for VPC with default deny all rule and select 
> services supported by Nuage VSP plugin for VPC. Choose NuageVsp as the 
> service provider for DHCP, SourceNAT, StaticNAT and Virtual Networking 
> services. Choose NuageVspVpc for NerworkACL service.
> b) Create an VPC and select "Default VPC offering with NuageVsp" as the VPC 
> offering
> c) Create a tier and select the network offering created above
> c) Spawn 2 VMs. Verify that VMs should each get an IP address. They should 
> ping each other. SSH to a box on the external network should fail
> d) Create a Static NAT and associate it one of the VM
> e) Add an Network ACL Egress rule for the network with source CIDR as 
> 0.0.0.0/0, protocol as TCP and ssh port number
> f) Verify that SSH to box that is in the external network should work
>
>   Diffs
>
>- api/src/com/cloud/event/EventTypes.java (71bfdb6)
>- api/src/com/cloud/network/Network.java (885bffe)
>- api/src/com/cloud/network/Networks.java (1e4d229)
>- api/src/com/cloud/network/PhysicalNetwork.java (8cc214e)
>- client/WEB-INF/classes/resources/messages.properties (b192cb0)
>- client/WEB-INF/classes/resources/messages_zh_CN.properties (1ec4e95)
>- client/pom.xml (46933d9)
>- client/tomcatconf/commands.properties.in (b9ac27b)
>- 
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>(8e4c710)
>- 
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>(0922765)
>- 
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
>(0f42df3)
>- plugins/network-elements/nuage-vsp/pom.xml (PRE-CREATION)
>- 
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties
>(PRE-CREATION)
>- 
> plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml
>(PRE-CREATION)
>- 
> plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
>(PRE-CREATION)
>- 
> plugins/net

Re: vms stopped while restarted by user

2014-07-15 Thread Chiradeep Vittal
Agree. Not sure why your system is so slow, but these parameters should help

From: Daan Hoogland mailto:daan.hoogl...@gmail.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Tuesday, July 15, 2014 at 6:29 AM
To: Tomasz Zięba mailto:t.a.zi...@gmail.com>>
Cc: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Marcus Sorensen 
mailto:shadow...@gmail.com>>, Damoder Reddy 
mailto:damoder.re...@citrix.com>>
Subject: vms stopped while restarted by user

Tomasz,

I can only fantasize on the full rationale of the implementation of
the retry but in general it makes sense to me. A job has a time to try
and a times tried field. the worker manager has time to sleep and max
retries. As you can see below these are read from the configuration:

value = params.get("time.to.sleep");
_timeToSleep = NumbersUtil.parseInt(value, 60) * 1000;

value = params.get("max.retries");
_maxRetries = NumbersUtil.parseInt(value, 5);

there is also

value = params.get("stop.retry.interval");
_stopRetryInterval = NumbersUtil.parseInt(value, 10 * 60);


The time.to.sleep and stop.retry.interval seem to jointly explain the
ten minute scenario you described in the bug report. They don't do
completely as some of the handling of the values is based on
bitshifting and not on datetime calculus (using mixed factors of
1000,60,60,24 and 365.25)
You can try and play with those to tune your setting. In any case
looking at the vm to decide to restart the vm is not usefull as
Cloudstack will do some cleanup after stopping the instance. You
should really wait untill cloudstack reports on the job with either
succes or error.

On Tue, Jul 15, 2014 at 3:12 PM, Tomasz Zięba 
mailto:t.a.zi...@gmail.com>> wrote:
Hello,

The user does not receive confirmation of the operation.
>From the point of view of user input it looks like the machine itself
stopped.

As you can see in the logs, the ACS explicitly sends stop command, as if
they press the Stop button from the GUI, so it is aware of the action from
the perspective of the ACS / MS.

I can not point out which component may be responsible for it.
We have tried to analyze the code to understand what is happening,
but the part of the code related to HAWorker is not very clear.
Unfortunately we could not find online any assumptions on the level of
architecture / design of HAWorker.

Maybe method of small steps help find a solution.
First a small question: why HAWorker performs reschedule. What was the idea
for such action.




2014-07-15 14:26 GMT+02:00 Daan Hoogland 
mailto:daan.hoogl...@gmail.com>>:

Tomasz,

As I understand the issue this is what happens:

The user stops the vm from the UI
The MS sends the stop command to the machine
The machine stops and takes a long time for it
The MS reschedules the stop
Then machine stops
the user starts the machine
the MS get by stopping the machine

Did the user ever get a confirmation that the machine was stopped or
that stopping failed? If so, this is the bug, as it seems the MS works
as designed.

Don't get me wrong; I am trying to figure out a path to a solution for
you. I am not convinced there is a bug in the management server
though. That doesn't mean it can be in cloudstack over all. Either at
a design level or for instance in some inter-process communication.

kind regards,
Daan Hoogland


On Fri, Jul 11, 2014 at 2:45 PM, Tomasz Zięba 
mailto:t.a.zi...@gmail.com>> wrote:
> Hello,
>
> We are waiting for the patch with longingly.
>
> Error associated with self-closing of machines causes very serious
> complications, both from the technical (users need to wait for 10
> minutes
> and check if the machine is not closed automatically) as well as the
> business side (this problem does not look very professional from the
> user
> side)
>
> Given that:
> - An error has been detected in February so 5 months ago,
> - in earlier versions  (3.0.2) error does not exists,
> - there is a procedure to reproduce this error,
>
> we would be very grateful if this issue will be resolved in ACS4.4.
>
>
> --
> Regards,
> Tomasz Zięba
> Twitter: @TZieba
> LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
>


--
Daan



Re: unit tests not working from eclipse

2014-07-15 Thread Laszlo Hornyak
Hi Daan,

It works for me on master, but it happens that eclipse messes up
things.Clean and rebuild? Possibly the project descriptors are not in sync
with maven pom files?


On Tue, Jul 15, 2014 at 4:18 PM, Daan Hoogland 
wrote:

> H,
>
> a silly mistake probably: none of the unit tests I try to run from
> eclipse work. they all report (test-) class not found. I have tried
> several from server and utils so far. The target/test-classes is
> configured in both projects. tests are passing beyond server on the
> cli with mvn test.
>
> Anyone that can show me the err of my ways?
>
> thanks,
> --
> Daan
>



-- 

EOF


Re: unit tests not working from eclipse

2014-07-15 Thread Daan Hoogland
I know it is not in the code. The same tests work in other source
trees/workspaces. I don't see the difference. very irritating.

On Tue, Jul 15, 2014 at 9:54 PM, Laszlo Hornyak
 wrote:
> Hi Daan,
>
> It works for me on master, but it happens that eclipse messes up
> things.Clean and rebuild? Possibly the project descriptors are not in sync
> with maven pom files?
>
>
> On Tue, Jul 15, 2014 at 4:18 PM, Daan Hoogland 
> wrote:
>
>> H,
>>
>> a silly mistake probably: none of the unit tests I try to run from
>> eclipse work. they all report (test-) class not found. I have tried
>> several from server and utils so far. The target/test-classes is
>> configured in both projects. tests are passing beyond server on the
>> cli with mvn test.
>>
>> Anyone that can show me the err of my ways?
>>
>> thanks,
>> --
>> Daan
>>
>
>
>
> --
>
> EOF



-- 
Daan


RE: xapi jar as separate release

2014-07-15 Thread Alex Huang
I checked into master the changes that remove our copy and just use the copy 
the XenServer team checked into maven.  Is there any reason we're talking about 
this?

--Alex

> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Tuesday, July 15, 2014 1:40 AM
> To: dev@cloudstack.apache.org
> Subject: Re: xapi jar as separate release
> 
> XAPI is not an apache project. I do not believe that we can sanely make a
> separate release. Compared to bundling it with our release as we We have
> essentially 'forked' XAPI from the upstream at Xen Project and made our
> own changes. Those changes are in the latest version AIUI, but not the
> version that we are currently using.
> 
> --David
> 
> 
> On Mon, Jul 14, 2014 at 6:17 AM, Daan Hoogland 
> wrote:
> > LS,
> >
> > One of the issues with the last RC was that the cloudstack xapi was
> > not a released version (i.e. 6.2.0-1-SNAPSHOT). In the release build
> > it was numbered as 6.2.0-1 but not referred by that release number but
> > by the snapshot id. There are several solutions to this. The most
> > correct would seem to be to release the xapi module separately and
> > create a release for it. I know that there has been some shifting back
> > and forth with this module and I would like to get consensus to create
> > a separate module and release for it.
> >
> > So my question: How do I get a version into the maven repo?
> >
> > thanks,
> > --
> > Daan


Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:16 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Updated diff after removing formatting of system.js. Also, removed the 
configuration reading from properties files. Now the plugin configurations are 
read as network service provider configurations from GUI or APIs.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal



Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal


> On July 15, 2014, 11:09 a.m., Hugo Trippaers wrote:
> > Can you resubmit this patch without the reformatting of system.js? At the 
> > moment it shows 4233 changes to that file, which is impossible for me to 
> > review. I need to see only the changes you made for the brocade plugin. If 
> > you think a reformat is needed you can submit the reformat as a separate 
> > patch, but we would prefer to keep the existing format.
> > 
> >

Hi Hugo,

I have resubmitted the patch. Updated diff after removing formatting of 
system.js. Also, removed the configuration reading from properties files. Now 
the plugin configurations are read as network service provider configurations 
from GUI or APIs.

Please review it.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
---


On July 15, 2014, 9:16 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>



Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Erik Weber

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---



api/src/com/cloud/network/PhysicalNetwork.java


Looks like you removed the 'N' in L3VPN


- Erik Weber


On July 15, 2014, 9:16 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>



Re: OpenVM.eu - repository of Cloudstack images and appliances

2014-07-15 Thread ilya musayev

Lucian,

Do you need help in making OVAs for vmware? vmdk.bz format is not 
something cloudstack can take advantage of @ the moment.


I assume you inject the cloud-init and proper virt tools for each 
image/hypervisor.


If not, please reconsider :)

Regards
ilya
On 6/26/14, 3:05 AM, Daan Hoogland wrote:

love it Lucian, How will the procedure for submissions look? (I'm
thinking a mail to you with a download link)

On Thu, Jun 26, 2014 at 1:18 AM, David Nalley  wrote:

This is awesome on Nux's part. I am thrilled to see this come to fruition.

This is not an official CloudStack deployment. There are a number of
reasons why this needs to be external (for instance, much of what he
has up for download is GPL-licensed; it's not our software, etc) In
addition, Infra does well to distribute the software we actually
produce, we'd politely decline the offer to provide a service like Nux
has stood up. :)

--David

On Wed, Jun 25, 2014 at 6:36 PM, Sally Khudairi
 wrote:

Cool --thanks, Lucian!

Just so I understand, this is a supporting repository and not an "official" 
CloudStack project resource, correct?

If so, totally fine: please do continue as intended. If not, I suspect this 
might need to reside somewhere in the cloudstack.apache.org/* home.

I'd love feedback from the community if you're planning to give folks a peek at 
tomorrow's meeting!

Cheers,
Sally




From: Nux! 
To: market...@cloudstack.apache.org
Cc: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Sent: Wednesday, 25 June 2014, 15:09
Subject: OpenVM.eu - repository of Cloudstack images and appliances


Hi,

I've been intending to do this for a while, but decided it has to happen this 
summer so here goes:

http://www.openvm.eu - A repository of Cloudstack images and appliances!

Do not be fooled by it's current façade, it will get better.
It only has one template for now, but I expect this number to increase 
significantly in the coming weeks.
It is just what I managed to do in a very short time at $work today and thought 
it might be worth a mention at tomorrow's European meeting in London.

I'll add a lot more templates, with a focus on CentOS and Cloudstack, of 
course, as this is where my interests lie at the moment.
In time I will add more OSes and platforms (Openstack and OpenNebula).

The templates are built on/for KVM, but should be able to boot on a variety of 
hypervisors (I think it will work on Xen/Xenserver, VMware, HyperV), although 
the file format is QCOW2.
I'll have to check my resources to see if I can afford the extra disk space and 
CPU time to offer VHD/RAW files as well.

All templates are 8 GB in size unless specified otherwise.

I'll keep the list updated.

Comments, questions, suggestions etc welcome!

Lucian



--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro










Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/
---

(Updated July 15, 2014, 9:52 p.m.)


Review request for cloudstack.


Changes
---

Removed the configuration reading from properties files. Now the plugin 
configurations are read as network service provider configurations from GUI or 
APIs.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Plugin specific code.


Diffs (updated)
-

  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23314/diff/


Testing
---


Thanks,

Ritu  Sabharwal



Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:57 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the PhysicalNetwork.java.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal



Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal


> On July 15, 2014, 9:30 p.m., Erik Weber wrote:
> > api/src/com/cloud/network/PhysicalNetwork.java, line 36
> > 
> >
> > Looks like you removed the 'N' in L3VPN

Fixed it.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---


On July 15, 2014, 9:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>



Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Ritu Sabharwal


> On July 15, 2014, 11:21 a.m., Hugo Trippaers wrote:
> > This is looking good, when you addresses the comment on the system.js file 
> > in the other review i'll apply both patches. If the patches apply clean 
> > i'll run findbugs and cobertura to check for any issues and unit test 
> > coverage. 
> > 
> > Hugo

Hi Hugo,

I have fixed the system.js file. Also, removed the configuration reading from 
properties files. Now the plugin configurations are read as network service 
provider configurations from GUI or APIs. The unit tests are also updated for 
the change.

Please review it and do the needful so that we can make it by July 19.

Thanks & Regards,
Ritu S.


> On July 15, 2014, 11:21 a.m., Hugo Trippaers wrote:
> > plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd, 
> > line 5
> > 
> >
> > Did you check with the rat plugin if the license is accepted like this?
> > 
> > I think the license is only properly detected with it is located in a 
> > comment like in the spring xml files.

The standard way to add comments to schema files is using annotation element. 
Reference: http://www.w3schools.com/schema/el_annotation.asp

The build throws parsing error if the comments are given like spring xml files. 
With annotation tag , the compilation goes fine and JAXB generation also works 
fine.

I did not find any xsd files in CloudStack codebase to get an example. What is 
the rat plugin?


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47769
---


On July 15, 2014, 9:52 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 15, 2014, 9:52 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>  PRE-CREATION 
> 

Re: [VOTE] Project Bylaw change - Adding Trademark Usage Approvals as an action

2014-07-15 Thread ilya musayev

+1 binding
On 7/14/14, 12:39 PM, Chip Childers wrote:

Since there don't appear to be any objections, I'm calling a vote for
the attached patch to our project bylaws.

Please vote:

[ ] +1 - accept the proposed patch to the project bylaws
[ ] +/-0 - no strong opinion
[ ] -1 - do not accept the proposed patch

This vote requires a lazy majority of active PMC members, at least 3 +1
(binding) and more +1 than -1.




Re: [VOTE] Project Bylaw change - Adding Trademark Usage Approvals as an action

2014-07-15 Thread David Nalley
+1 (binding)

On Mon, Jul 14, 2014 at 12:39 PM, Chip Childers  wrote:
> Since there don't appear to be any objections, I'm calling a vote for
> the attached patch to our project bylaws.
>
> Please vote:
>
> [ ] +1 - accept the proposed patch to the project bylaws
> [ ] +/-0 - no strong opinion
> [ ] -1 - do not accept the proposed patch
>
> This vote requires a lazy majority of active PMC members, at least 3 +1
> (binding) and more +1 than -1.


Re: [VOTE] Project Bylaw change - Adding Trademark Usage Approvals as an action

2014-07-15 Thread Chip Childers
That's defined in the bylaws as:

3.2.3. Lazy 2/3 Majority - Lazy 2/3 majority votes requires at least 3
binding votes and twice as many binding +1 votes as binding -1 votes.


On Monday, July 14, 2014, Daan Hoogland  wrote:

> +1 with a question. what does 'lazy' signify in 'lazy 2/3 majority of
> voting pmc members'? It would seem to me that it has no meaning when
> talking about a 2/3 majority of voting members. I guess I should have
> brought this up earlier, sorry.
>
> On Mon, Jul 14, 2014 at 6:39 PM, Chip Childers  > wrote:
> > Since there don't appear to be any objections, I'm calling a vote for
> > the attached patch to our project bylaws.
> >
> > Please vote:
> >
> > [ ] +1 - accept the proposed patch to the project bylaws
> > [ ] +/-0 - no strong opinion
> > [ ] -1 - do not accept the proposed patch
> >
> > This vote requires a lazy majority of active PMC members, at least 3 +1
> > (binding) and more +1 than -1.
>
>
>
> --
> Daan
>


Re: [VOTE] Project Bylaw change - Adding Trademark Usage Approvals as an action

2014-07-15 Thread Mike Tutkowski
+1 (binding)


On Tue, Jul 15, 2014 at 6:02 PM, Chip Childers 
wrote:

> That's defined in the bylaws as:
>
> 3.2.3. Lazy 2/3 Majority - Lazy 2/3 majority votes requires at least 3
> binding votes and twice as many binding +1 votes as binding -1 votes.
>
>
> On Monday, July 14, 2014, Daan Hoogland  wrote:
>
> > +1 with a question. what does 'lazy' signify in 'lazy 2/3 majority of
> > voting pmc members'? It would seem to me that it has no meaning when
> > talking about a 2/3 majority of voting members. I guess I should have
> > brought this up earlier, sorry.
> >
> > On Mon, Jul 14, 2014 at 6:39 PM, Chip Childers  > > wrote:
> > > Since there don't appear to be any objections, I'm calling a vote for
> > > the attached patch to our project bylaws.
> > >
> > > Please vote:
> > >
> > > [ ] +1 - accept the proposed patch to the project bylaws
> > > [ ] +/-0 - no strong opinion
> > > [ ] -1 - do not accept the proposed patch
> > >
> > > This vote requires a lazy majority of active PMC members, at least 3 +1
> > > (binding) and more +1 than -1.
> >
> >
> >
> > --
> > Daan
> >
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


[GitHub] cloudstack-docs pull request: Update concepts.rst

2014-07-15 Thread roryerickson
GitHub user roryerickson opened a pull request:

https://github.com/apache/cloudstack-docs/pull/5

Update concepts.rst

Fixed two minor typos.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/roryerickson/cloudstack-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 26a33318f6fe8e4f75690f585cc5b71f7fd09f54
Author: roryerickson 
Date:   2014-07-16T03:05:53Z

Update concepts.rst




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: How to change primary storage

2014-07-15 Thread Giri Prasad
Thanks for your comment. Will try it, and will inform the status.




 From: Sanjeev Neelarapu 
To: "us...@cloudstack.apache.org" ; Giri Prasad 
; "dev@cloudstack.apache.org"  
Sent: Tuesday, 15 July 2014 11:09 AM
Subject: RE: How to change primary storage
 

Configure your disk as NAS storage so that you can use it for both primary and 
secondary storages in CS.




-Original Message-
From: Giri Prasad [mailto:g_p...@yahoo.com.INVALID] 
Sent: Monday, July 14, 2014 12:44 PM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
Subject: Re: How to change primary storage

Thanks for the info.  So how does one configure , My Book Live disk to be used 
as primary/secondary storage in CS 4.1 or 4.2/3?





From: Sanjeev Neelarapu 
To: "dev@cloudstack.apache.org" ; Giri Prasad 

Cc: "us...@cloudstack.apache.org" 
Sent: Monday, 14 July 2014 10:51 AM
Subject: RE: How to change primary storage


Hi Giri,

CS 4.1 does not support smfs for primary storage. So you can't add your 
external disk in your setup.

-Sanjeev


-Original Message-
From: Giri Prasad [mailto:g_p...@yahoo.com.INVALID]
Sent: Thursday, July 10, 2014 2:32 PM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: How to change primary storage

I have a new install of CS 4.1 on Ubuntu 12.04 LTS.  I currently dont have any 
vm's or applications or volumes configured or running on the CS 4.1. Basically 
a freshly installed Ubuntu kernel and CS 4.1.


The storage setup on the Ubuntu host pc is

XXX.XXX.1.5:/export/primary on /mnt/primary1

XXX.XXX.1.5:/export/secondary on /mnt/secondary

The external disk (My Book Live disk) is configured as 

XXX.XXX.1.20:/nfs/Public/primary on /mnt/primary

    This external disk is configured in Linux host using : apt-get install 
smbfs. The external disk is mounting and is read/write-able in the Linux host.

Now, I want to add the external disk (XXX.XXX.1.20) as the primary storage and 
remove the (local hdd) primary storage XXX.XXX.1.5:/export/primary.

 So, if I just add the XXX.XXX.1.20  as the primary storage in CS, and remove 
1.5:/export/primary will do? Or some other procedure?


Please take note that I have used only smfs, for mounting.


Regards,




From: Prashant Kumar Mishra 
To: "dev@cloudstack.apache.org" ; Giri Prasad 

Cc: "us...@cloudstack.apache.org" 
Sent: Monday, 7 July 2014 10:56 AM
Subject: RE: How to change primary storage


Manually changing the db can help you but I prefer These steps ,  can be done  
without any downtime .

1-add http://XXX.XXX.1.20 with /export/dd
2- migrate volumes from http://XXX.XXX.1.5 to http://XXX.XXX.1.20 3-put 
http://XXX.XXX.1.5 to maintains mode
4- remove http://XXX.XXX.1.5.

thanks

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Monday, July 07, 2014 10:48 AM
To: dev@cloudstack.apache.org; Giri Prasad
Cc: us...@cloudstack.apache.org
Subject: Re: How to change primary storage

You can probably change the host_address field of the storage_pool table to 
change the IP address of your primary storage.

You will probably want to make sure you don't have any (non-deleted) volumes on 
the storage pool (primary storage) in question, though.

As you likely have seen, the volumes table is linked to the storage_pool table 
via the storage_pool.id and volumes.pool_id fields.

It might be easier for you to create new primary storage and migrate your 
volumes on the old primary storage to the new primary storage.


On Sun, Jul 6, 2014 at 11:07 PM, Giri Prasad 
wrote:

> Thanks.
>
> I want to change the primary storage IP address from
> http://XXX.XXX.1.5 to http://XXX.XXX.1.20. Also, I need to change the 
> primary storage directory, from /export/aa to /export/dd.  What is the 
> procedure?
>
>
>
> 
>  From: Prashant Kumar Mishra 
> To: Giri Prasad ; "dev@cloudstack.apache.org" < 
>dev@cloudstack.apache.org>; "us...@cloudstack.apache.org" < 
>us...@cloudstack.apache.org>
> Sent: Monday, 7 July 2014 10:30 AM
> Subject: RE: How to change primary storage
>
>
> For error like "The storage pool will not be used but cleanup is needed"
> you should check global settings "global.clenup.interaval " ,For quick 
> cleanup you can set it to 300ms and check  parameter related to 
> cleanup like storage.template.cleanup.enable  , storage cleanup 
> enabled etc. If global settings are properly tuned I don't think  any 
> database modifications required
>
> ->cloud.volume  stores volumes information , if you are not able to 
> ->delete
> storage because"volume still exist on the storage" change the volume 
> state and delete.
>
> -> storage_pool, storage_pool_view  for primary storage
>
> Thanks
> Prashant
>
>
> -Original Message-
> From: Giri Prasad [mailto:g_p...@yahoo.com]
> Sent: Monday, July 07, 2014 10:00 AM
> To: Prashant Kumar Mishra; dev@cloudstack.apache.org; 
> us

Re: xapi jar as separate release

2014-07-15 Thread Mike Tutkowski
That's exactly what I was wondering, Alex. :)


On Tue, Jul 15, 2014 at 3:13 PM, Alex Huang  wrote:

> I checked into master the changes that remove our copy and just use the
> copy the XenServer team checked into maven.  Is there any reason we're
> talking about this?
>
> --Alex
>
> > -Original Message-
> > From: David Nalley [mailto:da...@gnsa.us]
> > Sent: Tuesday, July 15, 2014 1:40 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: xapi jar as separate release
> >
> > XAPI is not an apache project. I do not believe that we can sanely make a
> > separate release. Compared to bundling it with our release as we We have
> > essentially 'forked' XAPI from the upstream at Xen Project and made our
> > own changes. Those changes are in the latest version AIUI, but not the
> > version that we are currently using.
> >
> > --David
> >
> >
> > On Mon, Jul 14, 2014 at 6:17 AM, Daan Hoogland 
> > wrote:
> > > LS,
> > >
> > > One of the issues with the last RC was that the cloudstack xapi was
> > > not a released version (i.e. 6.2.0-1-SNAPSHOT). In the release build
> > > it was numbered as 6.2.0-1 but not referred by that release number but
> > > by the snapshot id. There are several solutions to this. The most
> > > correct would seem to be to release the xapi module separately and
> > > create a release for it. I know that there has been some shifting back
> > > and forth with this module and I would like to get consensus to create
> > > a separate module and release for it.
> > >
> > > So my question: How do I get a version into the maven repo?
> > >
> > > thanks,
> > > --
> > > Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

2014-07-15 Thread Mike Tutkowski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review47858
---



server/src/com/cloud/configuration/Config.java


Perhaps I'm having trouble with Review Board, but it appears there are 
still CloudByte-specific values in 
server/src/com/cloud/configuration/Config.java.

I see that they get inserted from ElastistorPrimaryDataStoreProvider.java, 
as well.

Isn't ElastistorPrimaryDataStoreProvider.java the only place we want to 
insert them from?

Thanks for clarifying


- Mike Tutkowski


On July 15, 2014, 8:18 a.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 15, 2014, 8:18 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



[ACS4.5] When is feature freeze?

2014-07-15 Thread Mike Tutkowski
Hi,

Does anyone know when feature freeze is for 4.5?

I don't see 4.5 listed as a release in progress:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases+in+Progress

I thought feature freeze was supposed to be coming within a week or so.

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: [ACS4.5] When is feature freeze?

2014-07-15 Thread Erik Weber
16. juli 2014 07:00 skrev "Mike Tutkowski" 
følgende:
>
> Hi,
>
> Does anyone know when feature freeze is for 4.5?
>
> I don't see 4.5 listed as a release in progress:
>
>
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases+in+Progress
>
> I thought feature freeze was supposed to be coming within a week or so.
>

July 19th according to Hugo in this mail

http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3c69a41a0b-e75b-4d61-b8c9-06a9610a4...@apache.org%3E

Erik


Re: [ACS4.5] When is feature freeze?

2014-07-15 Thread Mike Tutkowski
Thanks!

I will assume then that we are sticking to July 19th.


On Tue, Jul 15, 2014 at 11:17 PM, Erik Weber  wrote:

> 16. juli 2014 07:00 skrev "Mike Tutkowski" 
> følgende:
> >
> > Hi,
> >
> > Does anyone know when feature freeze is for 4.5?
> >
> > I don't see 4.5 listed as a release in progress:
> >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases+in+Progress
> >
> > I thought feature freeze was supposed to be coming within a week or so.
> >
>
> July 19th according to Hugo in this mail
>
>
> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3c69a41a0b-e75b-4d61-b8c9-06a9610a4...@apache.org%3E
>
> Erik
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*


Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098

2014-07-15 Thread punith s


> On July 16, 2014, 10:25 a.m., Mike Tutkowski wrote:
> > server/src/com/cloud/configuration/Config.java, line 1942
> > 
> >
> > Perhaps I'm having trouble with Review Board, but it appears there are 
> > still CloudByte-specific values in 
> > server/src/com/cloud/configuration/Config.java.
> > 
> > I see that they get inserted from 
> > ElastistorPrimaryDataStoreProvider.java, as well.
> > 
> > Isn't ElastistorPrimaryDataStoreProvider.java the only place we want to 
> > insert them from?
> > 
> > Thanks for clarifying

hi mike,

i guess you might be referring to an older diff revision or some problem with 
the review board!
you can verify revision 3 in this link where i see config.java has been 
removed, https://reviews.apache.org/r/23410/diff/
also you can get the raw diff from https://reviews.apache.org/r/23410/diff/raw/

thanks
 


- punith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review47858
---


On July 15, 2014, 7:48 p.m., punith s wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> ---
> 
> (Updated July 15, 2014, 7:48 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The new improvised cloudbyte plugin for cloudstack supports the following 
> features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for 
> KVM and vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level 
> snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
>  87c5f51 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
>  99d1e2a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
>  33004e3 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
>  de4711a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
>  e591082 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
>  b75d12a 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
>  PRE-CREATION 
>   
> plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> ---
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>



Re: [ACS4.5] When is feature freeze?

2014-07-15 Thread Daan Hoogland
I hope so, but we don't have a release manager.

On Wed, Jul 16, 2014 at 7:20 AM, Mike Tutkowski
 wrote:
> Thanks!
>
> I will assume then that we are sticking to July 19th.
>
>
> On Tue, Jul 15, 2014 at 11:17 PM, Erik Weber  wrote:
>
>> 16. juli 2014 07:00 skrev "Mike Tutkowski" 
>> følgende:
>> >
>> > Hi,
>> >
>> > Does anyone know when feature freeze is for 4.5?
>> >
>> > I don't see 4.5 listed as a release in progress:
>> >
>> >
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases+in+Progress
>> >
>> > I thought feature freeze was supposed to be coming within a week or so.
>> >
>>
>> July 19th according to Hugo in this mail
>>
>>
>> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3c69a41a0b-e75b-4d61-b8c9-06a9610a4...@apache.org%3E
>>
>> Erik
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*



-- 
Daan


Re: [ACS4.5] When is feature freeze?

2014-07-15 Thread Sebastien Goasguen

On Jul 16, 2014, at 2:38 AM, Daan Hoogland  wrote:

> I hope so, but we don't have a release manager.
> 

What's the point of talking 4.5 when 4.4 is not out of the door …

Honestly, there is something very broken in the way we do things.



> On Wed, Jul 16, 2014 at 7:20 AM, Mike Tutkowski
>  wrote:
>> Thanks!
>> 
>> I will assume then that we are sticking to July 19th.
>> 
>> 
>> On Tue, Jul 15, 2014 at 11:17 PM, Erik Weber  wrote:
>> 
>>> 16. juli 2014 07:00 skrev "Mike Tutkowski" 
>>> følgende:
 
 Hi,
 
 Does anyone know when feature freeze is for 4.5?
 
 I don't see 4.5 listed as a release in progress:
 
 
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases+in+Progress
 
 I thought feature freeze was supposed to be coming within a week or so.
 
>>> 
>>> July 19th according to Hugo in this mail
>>> 
>>> 
>>> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3c69a41a0b-e75b-4d61-b8c9-06a9610a4...@apache.org%3E
>>> 
>>> Erik
>>> 
>> 
>> 
>> 
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> *™*
> 
> 
> 
> -- 
> Daan