----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/#review47768 -----------------------------------------------------------
Can you resubmit this patch without the reformatting of system.js? At the moment it shows 4233 changes to that file, which is impossible for me to review. I need to see only the changes you made for the brocade plugin. If you think a reformat is needed you can submit the reformat as a separate patch, but we would prefer to keep the existing format. - Hugo Trippaers On July 11, 2014, 10:10 p.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22863/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 10:10 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > First code drop for Brocade Network plugin to orchestrate Brocade VDX > switches for L2 connectivity. Please create a new branch for Brocade plugin. > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 885bffe > api/src/com/cloud/network/Networks.java 1e4d229 > api/src/com/cloud/network/PhysicalNetwork.java 8cc214e > client/pom.xml 29fef4f > plugins/pom.xml b5e6a61 > setup/db/db/schema-440to450.sql 77445a9 > ui/scripts/system.js 9a98a5c > ui/scripts/ui-custom/zoneWizard.js 4091c03 > > Diff: https://reviews.apache.org/r/22863/diff/ > > > Testing > ------- > > • Create an isolated network; verify that the port-profile is created on > the Brocade switch. > • Attach a VM to the network; verify that the VMs MAC address is > associated with the port profile of the network on the Brocade switch. > • Delete VMs for an isolated network; verify that the VMs MAC address is > disassociated with the port profile of the network on the Brocade switch. > • Delete the isolated network; verify that the port-profile is deleted > from the Brocade switch. > > > File Attachments > ---------------- > > Diff for the existing cloudstack code > > https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff > Patch file for Brocade functionality code > > https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch > > > Thanks, > > Ritu Sabharwal > >
