Re: Review Request 21070: Fixed few exception cases.

[Gaurav Aradhye]

Hi Santhosh,

I would like to mention one concern here.
If we are raising exception through "marvinRequest" function in
cloudstackConnection.py, instead of returning FAILED, then this will need
many test cases to be changed too, where we are explicitly asserting the
output of particular marvin command as FAILED or not as FAILED. Do you
think this can be avoided?

Many test cases failed last time we changed raising exception to returning
FAILED. And those fixes will stop working in this case.

May be we can solve the problem by extracting the exception message and
raising it as a string e.g raise Exception(string), and this will be logged
to the failure logs, and ultimately we return FAILED.


Regards,
Gaurav


On Mon, May 5, 2014 at 12:19 PM, Santhosh Edukulla <
santhosh.eduku...@citrix.com> wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
>
> Review request for cloudstack and sanjeev n.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed few exception cases. When some request fails, it throws up the
> stack, but the message str..does not contains a given attribute is little
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
>
>
> Diffs
> -
>
>   tools/marvin/marvin/cloudstackConnection.py caa8609
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94
>   tools/marvin/marvin/configGenerator.py 4f03fd0
>   tools/marvin/marvin/marvinInit.py de580ce
>   tools/marvin/marvin/marvinLog.py 65687aa
>   tools/marvin/marvin/marvinPlugin.py c817cd6
>
> Diff: https://reviews.apache.org/r/21070/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Santhosh Edukulla
>
>

Build failed in Jenkins: build-master #748

[jenkins]

See 

Changes:

[rajesh.battala] CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the 
guest network configured on the eth device

[rajesh.battala] CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty 
nic in VR/VpcVR to configure VPC entities

--
[...truncated 932 lines...]
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-security ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-security ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-security ---
[INFO] Compiling 7 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-security ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-security ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Core 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-core ---
[INFO] Deleting 
 (includes = 
[**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-core ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-core ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 26 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-core 
---
[INFO] Compiling 325 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-core ---
[INFO] Compiling 21 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-core ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.network.HAProxyConfiguratorTest
log4j:WARN No appenders could be found for logger 
(com.cloud.network.HAProxyConfigurator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec
Running com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec <<< 
FAILURE!
Running com.cloud.agent.transport.RequestTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.318 sec
Running org.apache.cloudstack.api.agent.test.BackupSnapshotAnswerTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec
Running org.apache.cloudstack.api.age

RE: Build failed in Jenkins: build-master #748

[Rajesh Battala]

Am working on fixing the unit test.

-Original Message-
From: jenk...@cloudstack.org [mailto:jenk...@cloudstack.org] 
Sent: Monday, May 5, 2014 12:56 PM
To: dev@cloudstack.apache.org; Rajesh Battala
Subject: Build failed in Jenkins: build-master #748

See 

Changes:

[rajesh.battala] CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the 
guest network configured on the eth device

[rajesh.battala] CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty 
nic in VR/VpcVR to configure VPC entities

--
[...truncated 932 lines...]
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-security --- [INFO] Starting audit...
Audit done.

[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-security --- [INFO] [INFO] --- 
maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-security --- [debug] execute contextualize [INFO] Using 'UTF-8' 
encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-security --- [INFO] Compiling 7 source files to 

[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-security --- [debug] execute contextualize [INFO] Using 'UTF-8' 
encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-security --- [INFO] No sources to compile [INFO] [INFO] --- 
maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-security --- 
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Core 4.5.0-SNAPSHOT [INFO] 

[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-core --- [INFO] 
Deleting  
(includes = [**/*], excludes = []) [INFO] Deleting 
 (includes = [target, 
dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check 
(cloudstack-checkstyle) @ cloud-core --- [INFO] Starting audit...
Audit done.

[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-core --- 
[INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-core --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to 
copy filtered resources.
[INFO] Copying 26 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-core 
--- [INFO] Compiling 325 source files to 

[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-core --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to 
copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-core --- [INFO] Compiling 21 source files to 

[INFO]
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-core --- 
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.network.HAProxyConfiguratorTest
log4j:WARN No appenders could be found for logger 
(com.cloud.network.HAProxyConfigurator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec 
Running com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec <<< 
FAILURE!
Running com.cloud.agent.transport.RequestTes

Build failed in Jenkins: cloudstack-4.4-forward-build #33

[jenkins]

See 

Changes:

[rajesh.battala] CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the 
guest network configured on the eth device

[rajesh.battala] CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty 
nic in VR/VpcVR to configure VPC entities

--
[...truncated 886 lines...]
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-security ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-security ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-security ---
[INFO] Compiling 7 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-security ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-security ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-security ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Core 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-core ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-core ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-core ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 26 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-core 
---
[INFO] Compiling 327 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-core ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-core ---
[INFO] Compiling 21 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-core ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.network.HAProxyConfiguratorTest
log4j:WARN No appenders could be found for logger 
(com.cloud.network.HAProxyConfigurator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec
Running com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.575 sec <<< 
FAILURE!
Running com.cloud.agent.transport.RequestTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.314 sec
Running org.a

Jenkins build is back to normal : cloudstack-4.4-forward-build #34

[jenkins]

See 

RE: Review Request 21070: Fixed few exception cases.

[Santhosh Edukulla]

Some places we are explicitly verifying for exception, EX: with assert for 
exception, with assert for not exception from CS, at some places we are 
verifying for return value say failed. If we return failed, then cases above 
are not clear. So, made it uniform for raising exception. Even earlier, the 
command raises the exception caught for command failure case. 

I believe all the test cases will still work.  Because of returning failed, 
base.py classes are directly calling on operation on the returned response, 
assuming response has received. So, the message dumped when failure happens is 
little misleading, it says string object has no attribute, but actual exception 
was some thing different.

During phase2 changes, we can make it more deterministic, by returning failure 
to test code, they can verify and assert, and we as well provide error 
information to them.  

Santhosh

From: Gaurav Aradhye [gaurav.arad...@clogeny.com]
Sent: Monday, May 05, 2014 3:04 AM
To: dev@cloudstack.apache.org; Santhosh Edukulla
Cc: Sanjeev Neelarapu
Subject: Re: Review Request 21070: Fixed few exception cases.

Hi Santhosh,

I would like to mention one concern here.
If we are raising exception through "marvinRequest" function in 
cloudstackConnection.py, instead of returning FAILED, then this will need many 
test cases to be changed too, where we are explicitly asserting the output of 
particular marvin command as FAILED or not as FAILED. Do you think this can be 
avoided?

Many test cases failed last time we changed raising exception to returning 
FAILED. And those fixes will stop working in this case.

May be we can solve the problem by extracting the exception message and raising 
it as a string e.g raise Exception(string), and this will be logged to the 
failure logs, and ultimately we return FAILED.


Regards,
Gaurav


On Mon, May 5, 2014 at 12:19 PM, Santhosh Edukulla 
mailto:santhosh.eduku...@citrix.com>> wrote:

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/
---

Review request for cloudstack and sanjeev n.


Repository: cloudstack-git


Description
---

Fixed few exception cases. When some request fails, it throws up the stack, but 
the message str..does not contains a given attribute is little misleading. So, 
raising exceptions for all cases.
Added testsuite name for userprovided\default log folder path
Fixed pep8 changes.


Diffs
-

  tools/marvin/marvin/cloudstackConnection.py caa8609
  tools/marvin/marvin/cloudstackTestClient.py d3a6b94
  tools/marvin/marvin/configGenerator.py 4f03fd0
  tools/marvin/marvin/marvinInit.py de580ce
  tools/marvin/marvin/marvinLog.py 65687aa
  tools/marvin/marvin/marvinPlugin.py c817cd6

Diff: https://reviews.apache.org/r/21070/diff/


Testing
---


Thanks,

Santhosh Edukulla

RE: Build failed in Jenkins: build-master #748

[Rajesh Battala]

Fixed the test cases 

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Monday, May 5, 2014 1:09 PM
To: dev@cloudstack.apache.org
Subject: RE: Build failed in Jenkins: build-master #748

Am working on fixing the unit test.

-Original Message-
From: jenk...@cloudstack.org [mailto:jenk...@cloudstack.org] 
Sent: Monday, May 5, 2014 12:56 PM
To: dev@cloudstack.apache.org; Rajesh Battala
Subject: Build failed in Jenkins: build-master #748

See 

Changes:

[rajesh.battala] CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the 
guest network configured on the eth device

[rajesh.battala] CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty 
nic in VR/VpcVR to configure VPC entities

--
[...truncated 932 lines...]
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-security --- [INFO] Starting audit...
Audit done.

[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-security --- [INFO] [INFO] --- 
maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-security --- [debug] execute contextualize [INFO] Using 'UTF-8' 
encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-security --- [INFO] Compiling 7 source files to 

[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-security --- [debug] execute contextualize [INFO] Using 'UTF-8' 
encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-security --- [INFO] No sources to compile [INFO] [INFO] --- 
maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-security --- 
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Core 4.5.0-SNAPSHOT [INFO] 

[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-core --- [INFO] 
Deleting  
(includes = [**/*], excludes = []) [INFO] Deleting 
 (includes = [target, 
dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check 
(cloudstack-checkstyle) @ cloud-core --- [INFO] Starting audit...
Audit done.

[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-core --- 
[INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-core --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to 
copy filtered resources.
[INFO] Copying 26 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-core 
--- [INFO] Compiling 325 source files to 

[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-core --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to 
copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-core --- [INFO] Compiling 21 source files to 

[INFO]
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-core --- 
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.network.HAProxyConfiguratorTest
log4j:WARN No appenders could be found for logger 
(com.cloud.network.HAProxyConfigurator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time 

Re: [QUESTION] Renaming files in Git

[Daan Hoogland]

use
$ git mv
and you should be allright. run git mv --help for options. One gotcha.
Any ref to the file you should do in the same commit but is not done
by this action.

On Mon, May 5, 2014 at 7:41 AM, Mike Tutkowski
 wrote:
> Hi,
>
> I was interested in renaming a couple files to improve the casing.
>
> I noticed, however, that someone changed Xenserver625StorageProcessor to
> XenServer625StorageProcessor and then reverted it back to
> Xenserver625StorageProcessor.
>
> This made me wonder if there is some issue related to renaming files in Git
> that I should be aware of.
>
> Any comments on this?
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*



-- 
Daan

Re: [ACS4.4] Cherry pick for CLOUDSTACK-6571

[Daan Hoogland]

On Mon, May 5, 2014 at 5:32 AM, Yoshikazu Nojima  wrote:
> 03156ecd6f52bfa0c73f1408ac4baca5332d1cad


done

-- 
Daan

Jenkins build is back to normal : build-master #749

[jenkins]

See 

cherry-pick requests

[Rajesh Battala]

Hi Daan,

Please cherry-pick these commits to 4.4 branch.

1 6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c
 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c
CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest network 
configured on the eth device


2. cf41ccaa5b6475dace0bddbe6681c98cc5149189
 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=cf41ccaa5b6475dace0bddbe6681c98cc5149189
CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR to 
configure VPC entities

3. 144990df11b2d7eb2ece50a043aea26b9eddfdda
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=144990df11b2d7eb2ece50a043aea26b9eddfdda
Fixed testSetupGuestNetwork unit test as the SetupGuestnetwork prepare command 
got changed


Thanks
Rajesh Battala

[Event]BigDataCloud Conference India 2014

[Radhika Puthiyetath]

Greetings !

Join us at the BigDataCloud 2014 Mini Conference at InMobi. Various top-level 
projects under Apache Software Foundation (ASF) are coming together for the 
first time to bring you the first edition of BigDataCloud Mini Conference in 
Bangalore. Jointly organized by Apache CloudStack, Apache Hadoop, and Apache 
Lucene/Solr communities in Bangalore, this premier event is to take place on 
May 6, 2013 at the beautiful campus of InMobi. Designed around the theme Cloud 
and Data Handling, this half-day Open Source gathering includes sessions by 
renowned members from the Apache community, as well as representatives from 
InMobi, CloudByte, Citrix and others.

The sessions starts at 2.30 PM.

This event is Open and Free for everyone! Anyone interested in Cloud or BigData 
is welcome !

You can book your spot at 
http://www.eventbrite.com/e/bigdatacloud-conference-india-2014-tickets-11314178011

For more information on agenda and location, visit http://bigdatacloudconf.org/

See you all tomorrow,

-Radhika

Can not find systemvmiso - CS42 with XenServer

[Pradeep Cloudstack]

I am running CS42 from my development environment. I am managing XenServer 6.2 
from my CS mgmt server.
When I try to create instances, I am getting this error:
**
RuntimeException due to com.cloud.utils.exception.CloudRuntimeException: can 
not find systemvmiso
com.cloud.utils.exception.CloudRuntimeException: can not find systemvmiso
    at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.createPatchVbd(CitrixResourceBase.java:1439)
    at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:1633)

**

I checked the following:
(1)I have systemvm.iso at the relative path to the patch file
(2)I have /usr/bin/vhd-util  (with executable permission)
(3)I have done cloud-install-sys-tmplt for hypervisor type - xenserver


Any help on debugging this further will be greatly appreciated

-Pradeep

Re: cherry-pick requests

[Daan Hoogland]

cf41ccaa5b6475dace0bddbe6681c98cc5149189 is introducing ^M line
endings. please make sure your env is clean. I hate to be nitpicking
but can you fix/prevent this?

I pushed the other two to wip-git.

On Mon, May 5, 2014 at 10:44 AM, Rajesh Battala
 wrote:
> Hi Daan,
>
> Please cherry-pick these commits to 4.4 branch.
>
> 1 6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c
>  
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c
> CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest network 
> configured on the eth device
>
>
> 2. cf41ccaa5b6475dace0bddbe6681c98cc5149189
>  
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=cf41ccaa5b6475dace0bddbe6681c98cc5149189
> CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR 
> to configure VPC entities
>
> 3. 144990df11b2d7eb2ece50a043aea26b9eddfdda
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=144990df11b2d7eb2ece50a043aea26b9eddfdda
> Fixed testSetupGuestNetwork unit test as the SetupGuestnetwork prepare 
> command got changed
>
>
> Thanks
> Rajesh Battala



-- 
Daan

Re: Cloudstack 4.3 instances can't access outside world

[Daan Hoogland]

Serg,

You marked the bug as to be solved in 4.3.1. There is no plan for a
4.3.1 and a 4.4.0 is planned for the coming weeks. I think some more
conversation on this list is needed for this issue. If you have a dev
env, please find the location of the bug and contact whoever has been
working on those modules to come to a solution with them.

kind regards,
Daan

On Sat, May 3, 2014 at 8:56 AM, Serg Senko  wrote:
> There is very urgent bug moved from users@
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-6464
>
>
> -- Forwarded message --
> From: Sebastien Goasguen 
> Date: Fri, May 2, 2014 at 12:48 PM
> Subject: Re: Cloudstack 4.3 instances can't access outside world
> To: us...@cloudstack.apache.org
>
>
>
> On Apr 30, 2014, at 4:14 PM, Evan McGee  wrote:
>
>> +1 on this — it’s a bit surprising that such a major regression made it
> into 4.3 final, as it appears any installation with traffic labeling will
> be affected.
>>
>> Should this conversation be moved to dev@cloudstack.apache.org?
>
> Yes please, can you send a note to dev@ with the issue.
>
> thanks
>
>>
>> On Apr 30, 2014, at 3:42 AM, Serg Senko  wrote:
>>
>>> Hi Seresh,
>>>
>>> This bug is still unassigned.
>>> It will be fixed?
>>>
>>> Currently is now way for upgrade to 4.3, 4.4..
>>>
>>>
>>>
>>>
>>> On Mon, Apr 21, 2014 at 11:46 AM, Suresh Sadhu >wrote:
>>>
 This need to be addressed and for tracking purpose I have raised this
> bug.
 kindly update your findings:

 https://issues.apache.org/jira/browse/CLOUDSTACK-6464

 regards
 sadhu


 -Original Message-
 From: Serg [mailto:kernc...@gmail.com]
 Sent: 21 April 2014 12:04
 To: us...@cloudstack.apache.org
 Cc: us...@cloudstack.apache.org
 Subject: Re: Cloudstack 4.3 instances can't access outside world

 Hi Suresh,

 Thanks for your update.
 There is already submitted bug ( bug id?)? it's will be fixed in 4.3.1
> or
 committed to 4.4?



 --
 Serg

> On 21 באפר 2014, at 08:50, Suresh Sadhu 
> wrote:
>
> Its temporary  and its regression bug caused due to other last min
 commit. due to this traffic labels are not considering.
>
> Regards
> Sadhu
>
>
>
> -Original Message-
> From: Serg Senko [mailto:kernc...@gmail.com]
> Sent: 21 April 2014 11:12
> To: us...@cloudstack.apache.org
> Subject: Re: Cloudstack 4.3 instances can't access outside world
>
> Hi,
>
> What does mean "In 4.3 traffic labels are not considering" ?
> It's temporary or " traffic labels " is deprecated now ?
>
>
> Does mean, anyone with KVM traffic labels environment can't upgrade to
 4.3.0?
>
>
>
>
>
> On Thu, Apr 10, 2014 at 5:05 PM, Suresh Sadhu  wrote:
>
>> Did you used traffic name labels?
>>
>> In 4.3 traffic labels are not considering ,by default its attaching
>> to default  traffic labels(eg:in KVM its cloudbr0 ...due to this
>> unable to access public network i.r before upgrade if ieth2 attached
>> cloudbr1 and after upgrade its attached to cloudbr0).maybe you are
 hitting this issue.
>>
>> Regards
>> sadhu
>>
>>
>> -Original Message-
>> From: motty cruz [mailto:motty.c...@gmail.com]
>> Sent: 10 April 2014 19:28
>> To: us...@cloudstack.apache.org
>> Subject: Re: Cloudstack 4.3 instances can't access outside world
>>
>> yes I can ping VR, also after the upgrade VR has four insterfaces,
>> eth0 subnet for Instances, eth1, eth2 for public IP and eth3 for
> public
 IP.
>>
>>
>>> On Wed, Apr 9, 2014 at 10:35 PM, Erik Weber 
 wrote:
>>>
>>> Can you ping the VR? Log on to the VR, and get the iptables rules.
>>> How do they look?
>>>
>>> Erik Weber
>>> 10. apr. 2014 00:21 skrev "motty cruz" 
 følgende:
>>>
 I did add egress rules, reboot network but no sucess, so I removed
 that rules and nothing.

 I am lost.


 On Wed, Apr 9, 2014 at 9:08 AM, Erik Weber 
>> wrote:

> Did you remove the egress rule again? If not, try that.
>
> Erik
> 9. apr. 2014 15:49 skrev "motty cruz" 
>> følgende:
>
>> yes I try adding the rule, restart network and router but no
>> success!
>>
>>
>> On Tue, Apr 8, 2014 at 11:16 PM, Erik Weber 
 wrote:
>>
>>> Try adding an egress rule, and removing it again.
>>>
>>> We experience the same, but has so far believed it was
>>> because we
> changed
>>> the default rule from deny to allow after accounts were made..
>>>
>>>
>>> On Tue, Apr 8, 2014 at 11:14 PM, motty cruz
>>> 
>> wrote:
>>>
 I have two isolated network both virtual routers can 

Re: Review Request 21009: Added Network API tests to test_escalation.py

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21009/#review42133
---

Ship it!


Ship It!

- Santhosh Edukulla


On May 2, 2014, 8:35 a.m., Anish Bindal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21009/
> ---
> 
> (Updated May 2, 2014, 8:35 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added Network API tests to test_escalation.py
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations.py e994579 
>   tools/marvin/marvin/config/test_data.py b862205 
> 
> Diff: https://reviews.apache.org/r/21009/diff/
> 
> 
> Testing
> ---
> 
> Executed all tests and attached are the result log files.
> 
> 
> File Attachments
> 
> 
> Result Log File
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt
> 
> 
> Thanks,
> 
> Anish Bindal
> 
>

Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures during start and stop the router incase of failures

[Rajani Karuturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
---

(Updated May 5, 2014, 9:47 a.m.)


Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
Reddy.


Bugs: CLOUDSTACK-6531
https://issues.apache.org/jira/browse/CLOUDSTACK-6531


Repository: cloudstack-git


Description
---

added a new configuration router.start.strict to optionally stop the router in 
case of command failures. Also added alerts for failures.


Diffs (updated)
-

  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
80ca1cf 

Diff: https://reviews.apache.org/r/20652/diff/


Testing
---

Manually tested.


Thanks,

Rajani Karuturi

[ACS 4.4] cherry-pick request for CLOUDSTACK-6463 and CLOUDSTACK-6466

[Harikrishna Patnala]

Hi Daan,

Could you cherry pick the following commits to 4.4 branch

1) Commit ce3074e9a23e71855798cb5decd01d7f9958f6c0 in cloudstack's branch 
refs/heads/4.4-forward
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ce3074e ]
CLOUDSTACK-6463: password is not set for VMs created from password enabled 
template

2) Commit 508e3e2c9b08850049a046bc5a22941e481fad5e in cloudstack's branch 
refs/heads/4.4-forward
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=508e3e2 ]
CLOUDSTACK-6466: cpu and ram is not getting updated correctly in 
usage_vm_instance table for usage type 2


Thank you,
Harikrishna

Re: Review Request 20652: CLOUDSTACK-6531: VR alerts for command failures during start and stop the router incase of failures

[Rajani Karuturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20652/
---

(Updated May 5, 2014, 10:02 a.m.)


Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali 
Reddy.


Bugs: CLOUDSTACK-6531
https://issues.apache.org/jira/browse/CLOUDSTACK-6531


Repository: cloudstack-git


Description
---

added a new configuration router.start.strict to optionally stop the router in 
case of command failures. Also added alerts for failures.


Diffs (updated)
-

  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
80ca1cf 

Diff: https://reviews.apache.org/r/20652/diff/


Testing
---

Manually tested.


Thanks,

Rajani Karuturi

[ACS 4.4] cherry-pick request for CLOUDSTACK-5077

[Bharat Kumar]

Hi Daan,

please cherry pick the following commit  to  4.4 branch.
commit 489bb0c7edf6ab011895d5f082328eb5fe48aac1 in cloudstack 4.4-forward 
branch.
link to diff  Cloudstack-5077: reserve cpu and memory only when 
vmware.reserve.cpu/mem are 
…

Thanks,
Bharat.

Re: Review Request 20891: CLOUDSTACK-6536: Code cleanup - removing unnecessary waits after VM stop operation

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20891/#review42134
---

Ship it!


Ship It!

- Santhosh Edukulla


On May 2, 2014, 2:23 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20891/
> ---
> 
> (Updated May 2, 2014, 2:23 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6536
> https://issues.apache.org/jira/browse/CLOUDSTACK-6536
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Also
> 1)Modified Imports
> 2)Removing white-spaces
> 3)Added try catch blocks wherever necessary
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 3e0e78b 
>   test/integration/component/test_blocker_bugs.py ba2602c 
>   test/integration/component/test_custom_hostname.py 7eeda49 
>   test/integration/component/test_dynamic_compute_offering.py da43fdf 
>   test/integration/component/test_egress_rules.py f0b98e4 
>   test/integration/component/test_escalations.py e994579 
>   test/integration/component/test_netscaler_configs.py 592b351 
>   test/integration/component/test_netscaler_lb.py 732f0f9 
>   test/integration/component/test_netscaler_nw_off.py d3f1f9e 
>   test/integration/component/test_network_offering.py b0b6906 
>   test/integration/component/test_persistent_networks.py deb0d6e 
>   test/integration/component/test_project_resources.py 8f81cf9 
>   test/integration/component/test_project_usage.py 16ca8c1 
>   test/integration/component/test_redundant_router_cleanups.py 2220d51 
>   test/integration/component/test_reset_ssh_keypair.py 307e8dc 
>   test/integration/component/test_resource_limits.py 09d9658 
>   test/integration/component/test_security_groups.py f5c4727 
>   test/integration/component/test_stopped_vm.py 6c77679 
>   test/integration/component/test_tags.py d6b43d9 
>   test/integration/component/test_templates.py 98b1cbc 
>   test/integration/component/test_usage.py eb92011 
>   test/integration/component/test_volumes.py a310472 
>   test/integration/component/test_vpc_network.py 2924b72 
>   test/integration/component/test_vpc_vm_life_cycle.py 95f46d0 
>   test/integration/smoke/test_service_offerings.py 3c91859 
>   test/integration/smoke/test_templates.py 4865ee3 
>   test/integration/smoke/test_vm_life_cycle.py f114ec9 
>   test/integration/smoke/test_volumes.py 7f5c4f3 
> 
> Diff: https://reviews.apache.org/r/20891/diff/
> 
> 
> Testing
> ---
> 
> Tested with python command. No changes in the actual executing code, only the 
> improvements and removing unnecessary code.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Fwd: Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2

[France]

Is upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2 officially supported / 
possible?



 Original Message 
Subject:Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2
Date:   Tue, 29 Apr 2014 10:31:56 +0200
From:   France 
Reply-To:   us...@cloudstack.apache.org
To: us...@cloudstack.apache.org



Tnx Samir for info, but you have had 6.1 while we have 6.0.2+Hotfixes.
We are still looking for official response.
Might have to escalate this to development mailing list (after
hollidays) :-)

On 29/4/14 10:09 AM, Amin Samir wrote:

It works for us on a lab environment,
Original environment is:
CentOs 6.5 (Management server)
Cloud Stack 4.2.1
Xen Server 6.1 latest patches

Target environment
CentOs 6.5 (Management Server)
Cloud Stack 4.3
Xen Server 6.2
Then upgraded to sp1
Then applied 1002, 1003, 1004 patches.

We will be upgrading our production environment within one month would keep you 
posted if that helps.

Kind Regards
Amin

-Original Message-
From: France [mailto:mailingli...@isg.si]
Sent: Tuesday, 29 April 2014 4:00 PM
To: us...@cloudstack.apache.org
Subject: Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2

+1 from me, exactly the same situation.

On 23/4/14 7:35 PM, Carlos Reategui wrote:

Hi All,

I would like to upgrade to Cloudstack 4.3 and also upgrade my
XenServers to 6.2.  I believe I've seen some comments about XS 6.2
only supported in a clean 4.3 install and not an upgrade.  I am not
able to find mention of this in the documentation.

Any suggestions for how to go about this?

thanks
Carlos

Re: [ACS 4.4] cherry-pick request for CLOUDSTACK-5077

[Bharat Kumar]

Hi Daan,

updating the link to diff.
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=99b4cf788eded0f6f155ff8cda51aeb2e505f764

Thanks
Bharat.
On 05-May-2014, at 3:36 pm, Bharat Kumar 
mailto:bharat.ku...@citrix.com>> wrote:

Hi Daan,

please cherry pick the following commit  to  4.4 branch.
commit 489bb0c7edf6ab011895d5f082328eb5fe48aac1 in cloudstack 4.4-forward 
branch.
link to diff  Cloudstack-5077: reserve cpu and memory only when 
vmware.reserve.cpu/mem are 
…

Thanks,
Bharat.

How is this working?

[Koushik Das]

I came across this code snippet in hostConnect() method in 
DefaultHostListener.java. Look at the line where the used bytes is set on the 
poolVO. This looks like a serious bug. Looking at the history this code has 
been there since a year. Has anyone encountered any issues with primary storage 
capacity?

ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
…..
StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
primaryStoreDao.update(pool.getId(), poolVO);


-Koushik

unit test failures in files unchanged for more then 3 months??

[Daan Hoogland]

Did anybody else see this?

Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
(main:) thread started
2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
(Thread-0:) before
2014-05-05 12:38:53,068 DEBUG [backoff.impl.ConstantTimeBackoffTest]
(main:) testing wakeup
Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.595
sec <<< FAILURE!

both the test and the test-subject have not changed recently. my env
hasn't changed much, but I suspect it must be in there. Running on
macosx 10.9. both in eclipse and on cmd line it fails with above
errors. both in master and in 4.4-forward

thanks for any pointer,
-- 
Daan

Re: Review Request 18677: CLOUDSTACK-3272

[Sonal Ojha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/
---

(Updated May 5, 2014, 10:56 a.m.)


Review request for cloudstack, Chiradeep Vittal and Murali Reddy.


Changes
---

Changes will work on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335.


Bugs: CLOUDSTACK-3272
https://issues.apache.org/jira/browse/CLOUDSTACK-3272


Repository: cloudstack-git


Description
---

At present, there are multiple event types that are generated by CS, action 
events,usage events, resource state change events and alerts. Current problem is
all the events gets published on the event bus when event bus is enabled. 
Intent is to introduce global setting config parameters to specify which 
category of events to be published or not be published on the event bus.


Diffs
-

  server/src/com/cloud/configuration/Config.java 2d55f46 
  server/src/com/cloud/event/ActionEventUtils.java 00122de 
  server/src/com/cloud/test/DatabaseConfig.java 9370218 

Diff: https://reviews.apache.org/r/18677/diff/


Testing
---

Successfully tested publishing / not publishing of various events based on the 
global parameter publish.*.events.


File Attachments (updated)


Working patch for master (latest git commit 55f53e13e)
  
https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
  
https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch


Thanks,

Sonal Ojha

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42136
---


Tried to apply it on master but it failed. Please rebase with master. Error 
messages are as follows:
[root@cent62-Sanjeev acs-repo]# git apply 
/root/0001-CLOUDSTACK-6257-Adding-function-to-check-state-of-VM.patch 
error: patch failed: tools/marvin/marvin/codes.py:31
error: tools/marvin/marvin/codes.py: patch does not apply
error: patch failed: tools/marvin/marvin/lib/base.py:22
error: tools/marvin/marvin/lib/base.py: patch does not apply


- sanjeev n


On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> ---
> 
> (Updated April 28, 2014, 10:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As suggested, added getState method for VirtualMachine class, and it is 
> called before template creation. If VM fails to go into desired state, it 
> returns failure.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py 28e907c 
>   tools/marvin/marvin/lib/base.py d753098 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: [REMINDER] [REVIEW] CLOUDSTACK-3272

[Sonal Ojha]

I have posted a new patch file in the review board, kindly review it.


On Mon, May 5, 2014 at 12:03 PM, Sonal Ojha wrote:

> I have updated the patch almost thrice but due to delay in reviewing the
> changes it doesnt work on the latest commit. I have mentioned the commit id
> against which the patch was created. Please make sure to review the patch
> with the commit mentioned with the patch file.
>
>
> On Fri, May 2, 2014 at 3:18 PM, Murali Reddy wrote:
>
>>  Sonal,
>>
>>  Can you please ensure your patch applies on latest master. Evert time I
>> attempted to push, patch does not apply. Please rebase your patch to latest
>> master and submit the patch.
>>
>>  Thanks,
>> Murali
>>
>>   From: Sonal Ojha 
>> Date: Friday, 2 May 2014 1:37 PM
>> To: "dev@cloudstack.apache.org" , Murali
>> Reddy , Daan Hoogland ,
>> Chiradeep Vittal 
>> Subject: [REMINDER] [REVIEW] CLOUDSTACK-3272
>>
>>   Hello,
>>
>>  Can anyone review the changes https://reviews.apache.org/r/18677/related to
>> https://issues.apache.org/jira/browse/CLOUDSTACK-3272.
>>
>>  Murali,
>> Can you please help me with a use case for which these changes would be
>> required / beneficial. It would be helpful to drive things further and
>> contribute better.
>>
>>  --
>>
>> *Thanks and Regards,*
>>
>> *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
>> Availability Services, India*
>>
>> 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
>> Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
>> ▪ www.sungardas. *in*
>>
>> *[image: Logo]* 
>> *[image: cid:image019.png@01CF48EC.6617C7F0]*
>>  *[image: 
>> cid:image020.png@01CF48EC.6617C7F0]*
>>  *[image: 
>> cid:image021.png@01CF48EC.6617C7F0]*
>>  *[image: 
>> cid:image022.png@01CF48EC.6617C7F0]*
>>  *[image: 
>> cid:image023.png@01CF48EC.6617C7F0]*
>>  *[image: cid:image024.png@01CF48EC.6617C7F0]*
>> *CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
>> confidential, proprietary and privileged information, and unauthorized
>> disclosure or use is prohibited.  If you received this e-mail in error,
>> please notify the sender and delete this e-mail from your system.
>>
>
>
>
> --
>
> *Thanks and Regards,*
>
> *Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard
> Availability Services, India*
>
> 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
> Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com
> ▪ www.sungardas. *in*
>
> *[image: Logo]* 
> *[image: cid:image019.png@01CF48EC.6617C7F0]* 
>  *[image: 
> cid:image020.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image021.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image022.png@01CF48EC.6617C7F0]*
>  *[image: 
> cid:image023.png@01CF48EC.6617C7F0]*
>  *[image: cid:image024.png@01CF48EC.6617C7F0]*
> *CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
> confidential, proprietary and privileged information, and unauthorized
> disclosure or use is prohibited.  If you received this e-mail in error,
> please notify the sender and delete this e-mail from your system.
>



-- 

*Thanks and Regards,*

*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*

2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.o...@sungardas.com ▪
www.sungardas. *in*

*[image: Logo]* 
*[image: cid:image019.png@01CF48EC.6617C7F0]*
 *[image:
cid:image020.png@01CF48EC.6617C7F0]* 
 *[image: 
cid:image021.png@01CF48EC.6617C7F0]*
 *[image: 
cid:image022.png@01CF48EC.6617C7F0]*
 *[image: 
cid:image023.png@01CF48EC.6617C7F0]*
 *[image: cid:image024.png@01CF48EC.6617C7F0]*
*CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.

Re: Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2

[Daan Hoogland]

It would seem that if you first upgrade cloudstack to 4.3 and then
upgrade your hosts this should be possible. You might want to remove
your hosts, upgrade and then add again, one by one, though. to be on
the save side.

On Mon, May 5, 2014 at 12:24 PM, France  wrote:
> Is upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2 officially supported /
> possible?
>
>
>
>  Original Message 
> Subject:Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2
> Date:   Tue, 29 Apr 2014 10:31:56 +0200
> From:   France 
> Reply-To:   us...@cloudstack.apache.org
> To: us...@cloudstack.apache.org
>
>
>
> Tnx Samir for info, but you have had 6.1 while we have 6.0.2+Hotfixes.
> We are still looking for official response.
> Might have to escalate this to development mailing list (after
> hollidays) :-)
>
> On 29/4/14 10:09 AM, Amin Samir wrote:
>>
>> It works for us on a lab environment,
>> Original environment is:
>> CentOs 6.5 (Management server)
>> Cloud Stack 4.2.1
>> Xen Server 6.1 latest patches
>>
>> Target environment
>> CentOs 6.5 (Management Server)
>> Cloud Stack 4.3
>> Xen Server 6.2
>> Then upgraded to sp1
>> Then applied 1002, 1003, 1004 patches.
>>
>> We will be upgrading our production environment within one month would
>> keep you posted if that helps.
>>
>> Kind Regards
>> Amin
>>
>> -Original Message-
>> From: France [mailto:mailingli...@isg.si]
>> Sent: Tuesday, 29 April 2014 4:00 PM
>> To: us...@cloudstack.apache.org
>> Subject: Re: Upgrade from 4.1.1 + XS 6.0.2 to 4.3 + XS 6.2
>>
>> +1 from me, exactly the same situation.
>>
>> On 23/4/14 7:35 PM, Carlos Reategui wrote:
>>>
>>> Hi All,
>>>
>>> I would like to upgrade to Cloudstack 4.3 and also upgrade my
>>> XenServers to 6.2.  I believe I've seen some comments about XS 6.2
>>> only supported in a clean 4.3 install and not an upgrade.  I am not
>>> able to find mention of this in the documentation.
>>>
>>> Any suggestions for how to go about this?
>>>
>>> thanks
>>> Carlos
>>>
>>
>
>
>



-- 
Daan

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

[sanjeev n]

> On May 5, 2014, 5:53 a.m., ASF Subversion and Git Services wrote:
> > Commit d81c5c44f112df8c0e4388e9d88300b24eefe3d0 in cloudstack's branch 
> > refs/heads/4.4-forward from Girish Shilamkar
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d81c5c4 ]
> > 
> > Revert "CLOUDSTACK-6257: Adding function to check state of VM"
> > 
> > This reverts commit 1be8b87fb7fb0203464ac4c66596008855ac5041.
> >

Hi Girish,

Why was this commit not reverted from master branch. If it was not reverted was 
there a fix for this patch in master?


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42119
---


On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> ---
> 
> (Updated April 28, 2014, 10:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> As suggested, added getState method for VirtualMachine class, and it is 
> called before template creation. If VM fails to go into desired state, it 
> returns failure.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py 28e907c 
>   tools/marvin/marvin/lib/base.py d753098 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: unit test failures in files unchanged for more then 3 months??

[Daan Hoogland]

my present 4.4 does not build either! :(

On Mon, May 5, 2014 at 12:49 PM, Daan Hoogland  wrote:
> Did anybody else see this?
>
> Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
> (main:) thread started
> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
> (Thread-0:) before
> 2014-05-05 12:38:53,068 DEBUG [backoff.impl.ConstantTimeBackoffTest]
> (main:) testing wakeup
> Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.595
> sec <<< FAILURE!
>
> both the test and the test-subject have not changed recently. my env
> hasn't changed much, but I suspect it must be in there. Running on
> macosx 10.9. both in eclipse and on cmd line it fails with above
> errors. both in master and in 4.4-forward
>
> thanks for any pointer,
> --
> Daan



-- 
Daan

[GitHub] cloudstack-docs-install pull request: doc for enabling CSP support...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/9

doc for enabling CSP support on xenserver 6.1

https://issues.apache.org/jira/browse/CLOUDSTACK-6574

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-install patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit caef894287994bb28bb34f2f556dc026536c61ae
Author: Rajani Karuturi 
Date:   2014-05-05T11:02:42Z

doc for enabling CSP support on xenserver 6.1

https://issues.apache.org/jira/browse/CLOUDSTACK-6574




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: unit test failures in files unchanged for more then 3 months??

[Daan Hoogland]

please note,

installing java 8 on your system causes these failures. Even if java 7
is still installed and used in your builds! Somehow a java 8 version
of java.util.concurrrent is used/called.

I am now re-installing java 7 to see if this solves the issue

On Mon, May 5, 2014 at 1:00 PM, Daan Hoogland  wrote:
> my present 4.4 does not build either! :(
>
> On Mon, May 5, 2014 at 12:49 PM, Daan Hoogland  
> wrote:
>> Did anybody else see this?
>>
>> Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
>> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>> (main:) thread started
>> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>> (Thread-0:) before
>> 2014-05-05 12:38:53,068 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>> (main:) testing wakeup
>> Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.595
>> sec <<< FAILURE!
>>
>> both the test and the test-subject have not changed recently. my env
>> hasn't changed much, but I suspect it must be in there. Running on
>> macosx 10.9. both in eclipse and on cmd line it fails with above
>> errors. both in master and in 4.4-forward
>>
>> thanks for any pointer,
>> --
>> Daan
>
>
>
> --
> Daan



-- 
Daan

RE: cherry-pick requests

[Rajesh Battala]

those are .cs files. As I was working with them on windows it could have got 
introduced.
I will correct them and request for a new cherry-pick.

Thanks
Rajesh Battala

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, May 5, 2014 2:52 PM
To: dev
Subject: Re: cherry-pick requests

cf41ccaa5b6475dace0bddbe6681c98cc5149189 is introducing ^M line endings. please 
make sure your env is clean. I hate to be nitpicking but can you fix/prevent 
this?

I pushed the other two to wip-git.

On Mon, May 5, 2014 at 10:44 AM, Rajesh Battala  
wrote:
> Hi Daan,
>
> Please cherry-pick these commits to 4.4 branch.
>
> 1 6cd1c7ab32a5e4ca3228b25aa6bd6158cb57963c
>  
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6c
> d1c7ab32a5e4ca3228b25aa6bd6158cb57963c
> CLOUDSTACK-6528 SetupGuestNetwork command is not deleting the guest 
> network configured on the eth device
>
>
> 2. cf41ccaa5b6475dace0bddbe6681c98cc5149189
>  
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=cf
> 41ccaa5b6475dace0bddbe6681c98cc5149189
> CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in 
> VR/VpcVR to configure VPC entities
>
> 3. 144990df11b2d7eb2ece50a043aea26b9eddfdda
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=14
> 4990df11b2d7eb2ece50a043aea26b9eddfdda
> Fixed testSetupGuestNetwork unit test as the SetupGuestnetwork prepare 
> command got changed
>
>
> Thanks
> Rajesh Battala



--
Daan

Re: unit test failures in files unchanged for more then 3 months??

[Daan Hoogland]

I recalled the ln command from long ago after installing 1.7
I did a
$ sudo ln -sf /Library/Java/JavaVirtualMachines/jdk1.7.0_55.jdk/Contents
CurrentJDK
(forgot the -n option but it works)

Somehow oracle overwrites the links when installing 8 but not when
installing 7 over it.

On Mon, May 5, 2014 at 1:23 PM, Daan Hoogland  wrote:
> please note,
>
> installing java 8 on your system causes these failures. Even if java 7
> is still installed and used in your builds! Somehow a java 8 version
> of java.util.concurrrent is used/called.
>
> I am now re-installing java 7 to see if this solves the issue
>
> On Mon, May 5, 2014 at 1:00 PM, Daan Hoogland  wrote:
>> my present 4.4 does not build either! :(
>>
>> On Mon, May 5, 2014 at 12:49 PM, Daan Hoogland  
>> wrote:
>>> Did anybody else see this?
>>>
>>> Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
>>> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>>> (main:) thread started
>>> 2014-05-05 12:38:52,966 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>>> (Thread-0:) before
>>> 2014-05-05 12:38:53,068 DEBUG [backoff.impl.ConstantTimeBackoffTest]
>>> (main:) testing wakeup
>>> Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.595
>>> sec <<< FAILURE!
>>>
>>> both the test and the test-subject have not changed recently. my env
>>> hasn't changed much, but I suspect it must be in there. Running on
>>> macosx 10.9. both in eclipse and on cmd line it fails with above
>>> errors. both in master and in 4.4-forward
>>>
>>> thanks for any pointer,
>>> --
>>> Daan
>>
>>
>>
>> --
>> Daan
>
>
>
> --
> Daan



-- 
Daan

Re: Review Request 20516: CLOUDSTACK-6463: password is not set for VMs created from password enabled template

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20516/#review42139
---


Commit df0564f14d35c02d5e745ffdea3b3e1e6d69698b in cloudstack's branch 
refs/heads/4.4 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=df0564f ]

CLOUDSTACK-6463: password is not set for VMs created from password enabled 
template


- ASF Subversion and Git Services


On April 21, 2014, 9:31 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20516/
> ---
> 
> (Updated April 21, 2014, 9:31 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6463
> https://issues.apache.org/jira/browse/CLOUDSTACK-6463
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6463: password is not set for VMs created from password enabled 
> template
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java c098e85 
> 
> Diff: https://reviews.apache.org/r/20516/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 20519: CLOUDSTACK-6466: cpu and ram is not getting updated correctly in usage_vm_instance table for usage type 2

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20519/#review42140
---


Commit 0c60ea2e01a80d5201b23415ebef818984db8730 in cloudstack's branch 
refs/heads/4.4 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c60ea2 ]

CLOUDSTACK-6466: cpu and ram is not getting updated correctly in 
usage_vm_instance table for usage type 2


- ASF Subversion and Git Services


On April 21, 2014, 9:55 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20519/
> ---
> 
> (Updated April 21, 2014, 9:55 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6466
> https://issues.apache.org/jira/browse/CLOUDSTACK-6466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6466: cpu and ram is not getting updated correctly in 
> usage_vm_instance table for usage type 2
> 
> 
> Diffs
> -
> 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 6ce6901 
> 
> Diff: https://reviews.apache.org/r/20519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: [ACS 4.4] cherry-pick request for CLOUDSTACK-6463 and CLOUDSTACK-6466

[Daan Hoogland]

both in

On Mon, May 5, 2014 at 11:56 AM, Harikrishna Patnala
 wrote:
> Hi Daan,
>
> Could you cherry pick the following commits to 4.4 branch
>
> 1) Commit ce3074e9a23e71855798cb5decd01d7f9958f6c0 in cloudstack's branch 
> refs/heads/4.4-forward
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ce3074e ]
> CLOUDSTACK-6463: password is not set for VMs created from password enabled 
> template
>
> 2) Commit 508e3e2c9b08850049a046bc5a22941e481fad5e in cloudstack's branch 
> refs/heads/4.4-forward
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=508e3e2 ]
> CLOUDSTACK-6466: cpu and ram is not getting updated correctly in 
> usage_vm_instance table for usage type 2
>
>
> Thank you,
> Harikrishna
>



-- 
Daan

Re: [ACS 4.4] cherry-pick request for CLOUDSTACK-5077

[Daan Hoogland]

thanks Bharat,

It is in.
I run git show on every commit that I then git cherry-pick so you
don't need to send me a link. the full id will do.

regards,
Daan

On Mon, May 5, 2014 at 12:27 PM, Bharat Kumar  wrote:
> Hi Daan,
>
> updating the link to diff.
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=99b4cf788eded0f6f155ff8cda51aeb2e505f764
>
> Thanks
> Bharat.
> On 05-May-2014, at 3:36 pm, Bharat Kumar 
> mailto:bharat.ku...@citrix.com>> wrote:
>
> Hi Daan,
>
> please cherry pick the following commit  to  4.4 branch.
> commit 489bb0c7edf6ab011895d5f082328eb5fe48aac1 in cloudstack 4.4-forward 
> branch.
> link to diff  Cloudstack-5077: reserve cpu and memory only when 
> vmware.reserve.cpu/mem are 
> …
>
> Thanks,
> Bharat.
>
>
>



-- 
Daan

Re: Review Request 20891: CLOUDSTACK-6536: Code cleanup - removing unnecessary waits after VM stop operation

[sanjeev n]

> On May 5, 2014, 10:20 a.m., Santhosh Edukulla wrote:
> > Ship It!

I tried to apply the patch on master, however it failed. Please rebase it with 
master.
Following are the erros:
[root@cent62-Sanjeev acs-repo]# git apply 
/root/0002-CLOUDSTACK-6536-Code-cleanup-removing-unnecessary-wa.patch 
error: patch failed: 
test/integration/component/test_dynamic_compute_offering.py:44
error: test/integration/component/test_dynamic_compute_offering.py: patch does 
not apply


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20891/#review42134
---


On May 2, 2014, 2:23 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20891/
> ---
> 
> (Updated May 2, 2014, 2:23 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6536
> https://issues.apache.org/jira/browse/CLOUDSTACK-6536
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Also
> 1)Modified Imports
> 2)Removing white-spaces
> 3)Added try catch blocks wherever necessary
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_add_remove_network.py 3e0e78b 
>   test/integration/component/test_blocker_bugs.py ba2602c 
>   test/integration/component/test_custom_hostname.py 7eeda49 
>   test/integration/component/test_dynamic_compute_offering.py da43fdf 
>   test/integration/component/test_egress_rules.py f0b98e4 
>   test/integration/component/test_escalations.py e994579 
>   test/integration/component/test_netscaler_configs.py 592b351 
>   test/integration/component/test_netscaler_lb.py 732f0f9 
>   test/integration/component/test_netscaler_nw_off.py d3f1f9e 
>   test/integration/component/test_network_offering.py b0b6906 
>   test/integration/component/test_persistent_networks.py deb0d6e 
>   test/integration/component/test_project_resources.py 8f81cf9 
>   test/integration/component/test_project_usage.py 16ca8c1 
>   test/integration/component/test_redundant_router_cleanups.py 2220d51 
>   test/integration/component/test_reset_ssh_keypair.py 307e8dc 
>   test/integration/component/test_resource_limits.py 09d9658 
>   test/integration/component/test_security_groups.py f5c4727 
>   test/integration/component/test_stopped_vm.py 6c77679 
>   test/integration/component/test_tags.py d6b43d9 
>   test/integration/component/test_templates.py 98b1cbc 
>   test/integration/component/test_usage.py eb92011 
>   test/integration/component/test_volumes.py a310472 
>   test/integration/component/test_vpc_network.py 2924b72 
>   test/integration/component/test_vpc_vm_life_cycle.py 95f46d0 
>   test/integration/smoke/test_service_offerings.py 3c91859 
>   test/integration/smoke/test_templates.py 4865ee3 
>   test/integration/smoke/test_vm_life_cycle.py f114ec9 
>   test/integration/smoke/test_volumes.py 7f5c4f3 
> 
> Diff: https://reviews.apache.org/r/20891/diff/
> 
> 
> Testing
> ---
> 
> Tested with python command. No changes in the actual executing code, only the 
> improvements and removing unnecessary code.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42142
---


Please rebase with master since patch apply failed on master branch.

- sanjeev n


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 20357: [CS-5907] [CS-6396] Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as OVM volumes (not able to snapshot)

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20357/#review42151
---


601827e6b34cb7debe67a8415a09440c389ba4a1 on master
2c4ae0883be04840a90b7238ad32aeaa38cc43ae on 4.4-forward
f8419b9303ea0c81310885acdc5498f6003ca4c6 on 4.4

- daan Hoogland


On April 16, 2014, 3:23 a.m., Tanner Danzey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20357/
> ---
> 
> (Updated April 16, 2014, 3:23 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5907 and CLOUDSTACK-6396
> https://issues.apache.org/jira/browse/CLOUDSTACK-5907
> https://issues.apache.org/jira/browse/CLOUDSTACK-6396
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix for RBD (and potentially CLVM) volumes w/ KVM incorrectly identified as 
> OVM volumes (not able to snapshot)
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/api/ApiDBUtils.java 67e47f7 
> 
> Diff: https://reviews.apache.org/r/20357/diff/
> 
> 
> Testing
> ---
> 
> Applied on otherwise clean 4.4 branch and tested in a live testing 
> environment with KVM hypervisors and RBD primary storage pool that would 
> otherwise identify as OVM. No errors and no weird behavior. Just the expected 
> result.
> 
> 
> Thanks,
> 
> Tanner Danzey
> 
>

Re: Review Request 16876: db sync fix : make sure that db sync task gets executed once: master branch fix

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16876/#review42152
---


Suresh, can I delete this request? It doesn't contain a diff.

- daan Hoogland


On Jan. 14, 2014, 11:43 p.m., Suresh Balineni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16876/
> ---
> 
> (Updated Jan. 14, 2014, 11:43 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Making sure that db sync task gets executed once, a master branch patch
> 
> 
> Diffs
> -
> 
> 
> Diff: https://reviews.apache.org/r/16876/diff/
> 
> 
> Testing
> ---
> 
> verified locally
> 
> 
> Thanks,
> 
> Suresh Balineni
> 
>

Re: Review Request 20557: CLOUDSTACK-6472 listUsageRecords generates NPEs for expunging instances

[Sam Schmit]

Sebastien,

I took a look at the 4.3 code, and I was mistaken - it will not commit
cleanly.  The EntityManager does not have the findIdIncludingRemoved
function added yet.  I'll have to spend more time looking into how to get
this into 4.3 cleanly.

Sam



On Fri, May 2, 2014 at 3:57 PM, Sebastien Goasguen  wrote:

>
> On May 2, 2014, at 2:17 PM, Sam Schmit  wrote:
>
> > All,
> >
> > I have submitted a bug fix patch for this issue:
> >
> > https://reviews.apache.org/r/21015/diff/
> >
> > If approved, this fix should also find its way into the 4.3 and 4.4
> builds.  It is fairly critical for getting usage data out of cloudstack.
> >
>
> Sam, thanks a lot for the patch. Since You and Pyr actually use this in
> prod, I will rely on your for testing :)
>
> I applied your patch to master and 4.4-forward.
>
> I need a clean patch for 4.3
>
> If you could check 4.4-forward and tell me if it's ok then I will request
> a cherry-pick shortly (to make the first RC).
>
>
> > Sam Schmit
> >
> >
> > On Thu, May 1, 2014 at 5:35 PM, Nate Gordon 
> wrote:
> > Sorry for being late to the discussion, I believe this patch doesn't
> fully
> > do what is actually expected. This patch does prevent the NPE, but
> doesn't
> > prevent the reason why the NPE was happening in the first place. It
> appears
> > that in commit f5e5b39, all the instances of
> > find{something}ByIdIncludingRemoved(id) where changed to
> > find{something}ById(id). This was 9 months ago, and since then it was
> > changed again to _entityMgr.findById({something}.class, id). So the
> reason
> > for the NPE is actually that we aren't querying for removed entries, but
> > those entries still exist, and used to be returned by the
> listUsageRecords
> > api. This patch mostly just prevents the UUID field from being populated
> in
> > those instances, which are relied upon by myself and surely others to
> > correlate records together.
> >
> > I'll try to get a new patch put together tonight that addresses that,
> > unless there is some other commentary as to why findByIdIncludingRemoved
> > was not included in the EntityManager interface, but is still present in
> > EntityManagerImpl.
> >
> > Having said that, I was just commenting to someone today that it would be
> > nice if there was some null checking done in this process and am glad
> that
> > it exists now. We have instances from time to time where something just
> > gets flat out removed from the db and that tends to break usage which
> > requires some unfortunate debugging effort.
> >
> > Thanks,
> >
> > -Nate
> >
> >
> > On Fri, Apr 25, 2014 at 4:01 PM, Sebastien Goasguen  >wrote:
> >
> > >
> > > ---
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/20557/#review41524
> > > ---
> > >
> > > Ship it!
> > >
> > >
> > > Applied to 4.3 with commit:
> > > 08997a9ba37d939dc6e546c632daf93b2b04e825
> > >
> > > I re-wrote the patch and committed to master as well with:
> > > 744e2a54e8b05d8136382664d8e5b9e3649fe88e
> > >
> > > Thanks for the patch, please make sure to tell us if there is more
> issue
> > > with this.
> > >
> > > You can mark the review as submitted.
> > >
> > >
> > > - Sebastien Goasguen
> > >
> > >
> > > On April 23, 2014, 12:47 p.m., Pierre-Yves Ritschard wrote:
> > > >
> > > > ---
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/20557/
> > > > ---
> > > >
> > > > (Updated April 23, 2014, 12:47 p.m.)
> > > >
> > > >
> > > > Review request for cloudstack.
> > > >
> > > >
> > > > Bugs: CLOUDSTACK-6472
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-6472
> > > >
> > > >
> > > > Repository: cloudstack-git
> > > >
> > > >
> > > > Description
> > > > ---
> > > >
> > > > This is a review request for CLOUDSTACK-6472 "listUsageRecords
> generates
> > > NPEs for expunging instances"
> > > >
> > > > The patch is against the 4.3 branch
> > > >
> > > >
> > > > Diffs
> > > > -
> > > >
> > > >   server/src/com/cloud/api/ApiResponseHelper.java e543d1c
> > > >
> > > > Diff: https://reviews.apache.org/r/20557/diff/
> > > >
> > > >
> > > > Testing
> > > > ---
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Pierre-Yves Ritschard
> > > >
> > > >
> > >
> > >
> >
> >
> > --
> >
> >
> > *Nate Gordon*Director of Technology | Appcore - the business of cloud
> > computing®
> >
> > Office +1.800.735.7104  |  Direct +1.515.612.7787
> > nate.gor...@appcore.com  |  www.appcore.com
> >
> > --
> >
> > The information in this message is intended for the named recipients
> only.
> > It may contain information that is privileged, confidential or otherwise
> > protected from disclosure. If you are not the intended re

Re: Review Request 18677: CLOUDSTACK-3272

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42154
---



File Attachment: Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 - 
0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch

can you use update diff instead of making attachements? This helps 
reviewing updates.

- daan Hoogland


On May 5, 2014, 10:56 a.m., Sonal Ojha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> ---
> 
> (Updated May 5, 2014, 10:56 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> At present, there are multiple event types that are generated by CS, action 
> events,usage events, resource state change events and alerts. Current problem 
> is
> all the events gets published on the event bus when event bus is enabled. 
> Intent is to introduce global setting config parameters to specify which 
> category of events to be published or not be published on the event bus.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/Config.java 2d55f46 
>   server/src/com/cloud/event/ActionEventUtils.java 00122de 
>   server/src/com/cloud/test/DatabaseConfig.java 9370218 
> 
> Diff: https://reviews.apache.org/r/18677/diff/
> 
> 
> Testing
> ---
> 
> Successfully tested publishing / not publishing of various events based on 
> the global parameter publish.*.events.
> 
> 
> File Attachments
> 
> 
> Working patch for master (latest git commit 55f53e13e)
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> 
> 
> Thanks,
> 
> Sonal Ojha
> 
>

Re: Cleanly remove management server

[Daan Hoogland]

H Michael,

Did you investigate this further? still planning to implement?


On Fri, Apr 18, 2014 at 3:33 PM, Michael Phillips
 wrote:
> Last week we talked about a GUI option to cleanly remove a management server. 
> I created a feature request for this as well. Hopefully this will get some 
> traction as well.
> https://issues.apache.org/jira/browse/CLOUDSTACK-6455
> I think I may dust up on my coding skills so I can contribute to the dev 
> cause.



-- 
Daan

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

[Daan Hoogland]

Alena,

I see nothing that keeps us from aplying this patch, do you?

regards,


On Wed, Apr 23, 2014 at 4:41 PM, upendra moturi
wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19902/
>
> On April 21st, 2014, 6:17 p.m. UTC, *daan Hoogland* wrote:
>
> did you verify that this works for your use case? Can you add unit tests and 
> test scenario?
>
>  Test Scenario :
> Add two vms with two nics each having different networks .Two networks to 
> each vm.
> One network of each vm have same network configurations (i.e 10.20.30.0/24).
> One nic of each vm have same ipaddress and one of the nic has portforward 
> rule and try deleting other vm nic throws error saying there is portforward 
> rule assigned.
>
> VM1 (nic1,nic2) -> network1,network2.
> VM2 (nic3,nic4) -> network3,network4.
>
> network2 - 10.20.30.0/24
> network4  - 10.20.30.0/24
>
> nic2(VM1) ipaddress - 10.20.30.5
> nic4(VM2) ipaddress - 10.20.30.5
>
> nic2 has portforward rule defined and trying to to delete nic4 throws message 
> saying there is portforward rule assigned.
>
>
>
>
>
> - upendra
>
> On April 2nd, 2014, 5:09 a.m. UTC, upendra moturi wrote:
>   Review request for cloudstack and Alena Prokharchyk.
> By upendra moturi.
>
> *Updated April 2, 2014, 5:09 a.m.*
>  *Repository: * cloudstack-git
> Description
>
> CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in 
> another domain has a nic with the same ip and a forwarding rule configured on 
> it
>
>   Diffs
>
>- engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java
>(4694cb9)
>- 
> engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java
>(45c0aeb)
>- server/src/com/cloud/network/rules/RulesManagerImpl.java (13f6306)
>
> View Diff 
>



-- 
Daan

Re: HyperV agent not able to connect with Jenkins and community builds blocked

[Daan Hoogland]

Rayees,

I consulted with Hugo, but we both do not know what jenkins slave this
is and where it should run. Did you find out more by now?

regards,
Daan

On Thu, Apr 24, 2014 at 3:41 PM, Rayees Namathponnan
 wrote:
> Hugo / Daan,
>
>
>
> Can you please help on this ? in case you have any idea ?
>
>
>
> Regards,
>
> Rayees
>
> From: Rayees Namathponnan
> Sent: Wednesday, April 23, 2014 11:14 PM
> To: dev@cloudstack.apache.org
> Subject: HyperV agent not able to connect with Jenkins and community builds
> blocked
>
>
>
> Hi All,
>
>
>
> I am facing issues with hyperV build job in Jenkins; but not sure, who is
> the administrator for jenkins http://jenkins.buildacloud.org
>
>
>
> There is job
> (http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-hyperv-agent )
> in Jenkins, it was configured to build hyperV agent;  it’s using hyperV
> build machine node (http://jenkins.buildacloud.org/computer/build-hyperv/ )
>
>
>
> Node “build-hyperv” was connected to jenkins through “launch Slave agents
> via Java Web start”, This node was up and we were able to create build from
> above till April 5.
>
>
>
> From April 5th node “build-hyperv” is offline, and I am unable to connect
> this back. Is there any upgrade happened on Jenkins during this time ?
>
>
>
> Any help highly appreciated.
>
>
>
>
>
> While searching I observed similar issues
>
> http://stackoverflow.com/questions/14277512/problems-launching-the-slave-agent-via-java-web-start-on-jenkins
>
> https://issues.jenkins-ci.org/browse/JENKINS-20204
>
>
>
>
>
> Regards,
>
> Rayees
>
>



-- 
Daan

Re: Review Request 20557: CLOUDSTACK-6472 listUsageRecords generates NPEs for expunging instances

[Olivier Lemasle]

Hi Sam,

I was going to suggest the same patch than you (with
findByIdIncludingRemoved), and I hit the same issue: no method
findByIdIncludingRemoved in com.cloud.utils.db.EntityManager.
But I see that the implementing class com.cloud.dao.EntityManagerImpl still
has findByIdIncludingRemoved(). Do you know why it was removed from the
interface in f5e5b39c9bc8d?

--
Olivier


On Mon, May 5, 2014 at 3:45 PM, Sam Schmit  wrote:

> Sebastien,
>
> I took a look at the 4.3 code, and I was mistaken - it will not commit
> cleanly.  The EntityManager does not have the findIdIncludingRemoved
> function added yet.  I'll have to spend more time looking into how to get
> this into 4.3 cleanly.
>
> Sam
>
>
>
> On Fri, May 2, 2014 at 3:57 PM, Sebastien Goasguen 
> wrote:
>
> >
> > On May 2, 2014, at 2:17 PM, Sam Schmit  wrote:
> >
> > > All,
> > >
> > > I have submitted a bug fix patch for this issue:
> > >
> > > https://reviews.apache.org/r/21015/diff/
> > >
> > > If approved, this fix should also find its way into the 4.3 and 4.4
> > builds.  It is fairly critical for getting usage data out of cloudstack.
> > >
> >
> > Sam, thanks a lot for the patch. Since You and Pyr actually use this in
> > prod, I will rely on your for testing :)
> >
> > I applied your patch to master and 4.4-forward.
> >
> > I need a clean patch for 4.3
> >
> > If you could check 4.4-forward and tell me if it's ok then I will request
> > a cherry-pick shortly (to make the first RC).
> >
> >
> > > Sam Schmit
> > >
> > >
> > > On Thu, May 1, 2014 at 5:35 PM, Nate Gordon 
> > wrote:
> > > Sorry for being late to the discussion, I believe this patch doesn't
> > fully
> > > do what is actually expected. This patch does prevent the NPE, but
> > doesn't
> > > prevent the reason why the NPE was happening in the first place. It
> > appears
> > > that in commit f5e5b39, all the instances of
> > > find{something}ByIdIncludingRemoved(id) where changed to
> > > find{something}ById(id). This was 9 months ago, and since then it was
> > > changed again to _entityMgr.findById({something}.class, id). So the
> > reason
> > > for the NPE is actually that we aren't querying for removed entries,
> but
> > > those entries still exist, and used to be returned by the
> > listUsageRecords
> > > api. This patch mostly just prevents the UUID field from being
> populated
> > in
> > > those instances, which are relied upon by myself and surely others to
> > > correlate records together.
> > >
> > > I'll try to get a new patch put together tonight that addresses that,
> > > unless there is some other commentary as to why
> findByIdIncludingRemoved
> > > was not included in the EntityManager interface, but is still present
> in
> > > EntityManagerImpl.
> > >
> > > Having said that, I was just commenting to someone today that it would
> be
> > > nice if there was some null checking done in this process and am glad
> > that
> > > it exists now. We have instances from time to time where something just
> > > gets flat out removed from the db and that tends to break usage which
> > > requires some unfortunate debugging effort.
> > >
> > > Thanks,
> > >
> > > -Nate
> > >
> > >
> > > On Fri, Apr 25, 2014 at 4:01 PM, Sebastien Goasguen  > >wrote:
> > >
> > > >
> > > > ---
> > > > This is an automatically generated e-mail. To reply, visit:
> > > > https://reviews.apache.org/r/20557/#review41524
> > > > ---
> > > >
> > > > Ship it!
> > > >
> > > >
> > > > Applied to 4.3 with commit:
> > > > 08997a9ba37d939dc6e546c632daf93b2b04e825
> > > >
> > > > I re-wrote the patch and committed to master as well with:
> > > > 744e2a54e8b05d8136382664d8e5b9e3649fe88e
> > > >
> > > > Thanks for the patch, please make sure to tell us if there is more
> > issue
> > > > with this.
> > > >
> > > > You can mark the review as submitted.
> > > >
> > > >
> > > > - Sebastien Goasguen
> > > >
> > > >
> > > > On April 23, 2014, 12:47 p.m., Pierre-Yves Ritschard wrote:
> > > > >
> > > > > ---
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > https://reviews.apache.org/r/20557/
> > > > > ---
> > > > >
> > > > > (Updated April 23, 2014, 12:47 p.m.)
> > > > >
> > > > >
> > > > > Review request for cloudstack.
> > > > >
> > > > >
> > > > > Bugs: CLOUDSTACK-6472
> > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-6472
> > > > >
> > > > >
> > > > > Repository: cloudstack-git
> > > > >
> > > > >
> > > > > Description
> > > > > ---
> > > > >
> > > > > This is a review request for CLOUDSTACK-6472 "listUsageRecords
> > generates
> > > > NPEs for expunging instances"
> > > > >
> > > > > The patch is against the 4.3 branch
> > > > >
> > > > >
> > > > > Diffs
> > > > > -
> > > > >
> > > > >   server/src/com/cloud/api/ApiResponseHelper.java e543d1c
> > > > >
> > 

Re: Review Request 20557: CLOUDSTACK-6472 listUsageRecords generates NPEs for expunging instances

[Sam Schmit]

Olivier,

I'm still checking into it, but it may work - as you said, it should be a
supported method.  I've already made the change on my dev machine, and I'm
getting set up with a development cloud to test it out.  I should know
later today if it will work for 4.3.

Sam


On Mon, May 5, 2014 at 10:04 AM, Olivier Lemasle  wrote:

> Hi Sam,
>
> I was going to suggest the same patch than you (with
> findByIdIncludingRemoved), and I hit the same issue: no method
> findByIdIncludingRemoved in com.cloud.utils.db.EntityManager.
> But I see that the implementing class com.cloud.dao.EntityManagerImpl still
> has findByIdIncludingRemoved(). Do you know why it was removed from the
> interface in f5e5b39c9bc8d?
>
> --
> Olivier
>
>
> On Mon, May 5, 2014 at 3:45 PM, Sam Schmit  wrote:
>
> > Sebastien,
> >
> > I took a look at the 4.3 code, and I was mistaken - it will not commit
> > cleanly.  The EntityManager does not have the findIdIncludingRemoved
> > function added yet.  I'll have to spend more time looking into how to get
> > this into 4.3 cleanly.
> >
> > Sam
> >
> >
> >
> > On Fri, May 2, 2014 at 3:57 PM, Sebastien Goasguen 
> > wrote:
> >
> > >
> > > On May 2, 2014, at 2:17 PM, Sam Schmit  wrote:
> > >
> > > > All,
> > > >
> > > > I have submitted a bug fix patch for this issue:
> > > >
> > > > https://reviews.apache.org/r/21015/diff/
> > > >
> > > > If approved, this fix should also find its way into the 4.3 and 4.4
> > > builds.  It is fairly critical for getting usage data out of
> cloudstack.
> > > >
> > >
> > > Sam, thanks a lot for the patch. Since You and Pyr actually use this in
> > > prod, I will rely on your for testing :)
> > >
> > > I applied your patch to master and 4.4-forward.
> > >
> > > I need a clean patch for 4.3
> > >
> > > If you could check 4.4-forward and tell me if it's ok then I will
> request
> > > a cherry-pick shortly (to make the first RC).
> > >
> > >
> > > > Sam Schmit
> > > >
> > > >
> > > > On Thu, May 1, 2014 at 5:35 PM, Nate Gordon  >
> > > wrote:
> > > > Sorry for being late to the discussion, I believe this patch doesn't
> > > fully
> > > > do what is actually expected. This patch does prevent the NPE, but
> > > doesn't
> > > > prevent the reason why the NPE was happening in the first place. It
> > > appears
> > > > that in commit f5e5b39, all the instances of
> > > > find{something}ByIdIncludingRemoved(id) where changed to
> > > > find{something}ById(id). This was 9 months ago, and since then it was
> > > > changed again to _entityMgr.findById({something}.class, id). So the
> > > reason
> > > > for the NPE is actually that we aren't querying for removed entries,
> > but
> > > > those entries still exist, and used to be returned by the
> > > listUsageRecords
> > > > api. This patch mostly just prevents the UUID field from being
> > populated
> > > in
> > > > those instances, which are relied upon by myself and surely others to
> > > > correlate records together.
> > > >
> > > > I'll try to get a new patch put together tonight that addresses that,
> > > > unless there is some other commentary as to why
> > findByIdIncludingRemoved
> > > > was not included in the EntityManager interface, but is still present
> > in
> > > > EntityManagerImpl.
> > > >
> > > > Having said that, I was just commenting to someone today that it
> would
> > be
> > > > nice if there was some null checking done in this process and am glad
> > > that
> > > > it exists now. We have instances from time to time where something
> just
> > > > gets flat out removed from the db and that tends to break usage which
> > > > requires some unfortunate debugging effort.
> > > >
> > > > Thanks,
> > > >
> > > > -Nate
> > > >
> > > >
> > > > On Fri, Apr 25, 2014 at 4:01 PM, Sebastien Goasguen <
> run...@gmail.com
> > > >wrote:
> > > >
> > > > >
> > > > > ---
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > https://reviews.apache.org/r/20557/#review41524
> > > > > ---
> > > > >
> > > > > Ship it!
> > > > >
> > > > >
> > > > > Applied to 4.3 with commit:
> > > > > 08997a9ba37d939dc6e546c632daf93b2b04e825
> > > > >
> > > > > I re-wrote the patch and committed to master as well with:
> > > > > 744e2a54e8b05d8136382664d8e5b9e3649fe88e
> > > > >
> > > > > Thanks for the patch, please make sure to tell us if there is more
> > > issue
> > > > > with this.
> > > > >
> > > > > You can mark the review as submitted.
> > > > >
> > > > >
> > > > > - Sebastien Goasguen
> > > > >
> > > > >
> > > > > On April 23, 2014, 12:47 p.m., Pierre-Yves Ritschard wrote:
> > > > > >
> > > > > > ---
> > > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > > https://reviews.apache.org/r/20557/
> > > > > > ---
> > > > > >
> > > > > > (Updated April 23, 2014, 12:47 p.m.)
> > 

Re: How is this working?

[Mike Tutkowski]

My storage plug-in actually uses a custom host listener, so I have not
encountered this issue.

I don't remember off hand if it was in 4.2 or 4.3, but at some point
someone changed the storage_pool table's available_bytes column to be
used_bytes.

It looks like this code you reference was missed.


On Mon, May 5, 2014 at 4:35 AM, Koushik Das  wrote:

> I came across this code snippet in hostConnect() method in
> DefaultHostListener.java. Look at the line where the used bytes is set on
> the poolVO. This looks like a serious bug. Looking at the history this code
> has been there since a year. Has anyone encountered any issues with primary
> storage capacity?
>
> ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> …..
> StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> primaryStoreDao.update(pool.getId(), poolVO);
>
>
> -Koushik
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: [QUESTION] Renaming files in Git

[Mike Tutkowski]

OK, thanks, Daan.

I can try it out in master at some point.


On Mon, May 5, 2014 at 2:26 AM, Daan Hoogland wrote:

> use
> $ git mv
> and you should be allright. run git mv --help for options. One gotcha.
> Any ref to the file you should do in the same commit but is not done
> by this action.
>
> On Mon, May 5, 2014 at 7:41 AM, Mike Tutkowski
>  wrote:
> > Hi,
> >
> > I was interested in renaming a couple files to improve the casing.
> >
> > I noticed, however, that someone changed Xenserver625StorageProcessor to
> > XenServer625StorageProcessor and then reverted it back to
> > Xenserver625StorageProcessor.
> >
> > This made me wonder if there is some issue related to renaming files in
> Git
> > that I should be aware of.
> >
> > Any comments on this?
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42157
---

Ship it!


Ship It!

- sanjeev n


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 21070: Fixed few exception cases.

[sanjeev n]

> On May 5, 2014, 4:06 p.m., sanjeev n wrote:
> > Ship It!

Applied patch to 4.4-automation branch
commit ef286da8ccc005fee58c4be5d508c5d7ddfc2a6c
Author: sanjeevneelarapu 
Date:   Tue May 6 02:57:08 2014 +0530

Fixed few exception cases


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21070/#review42157
---


On May 5, 2014, 6:49 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21070/
> ---
> 
> (Updated May 5, 2014, 6:49 a.m.)
> 
> 
> Review request for cloudstack and sanjeev n.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed few exception cases. When some request fails, it throws up the stack, 
> but the message str..does not contains a given attribute is little 
> misleading. So, raising exceptions for all cases.
> Added testsuite name for userprovided\default log folder path
> Fixed pep8 changes.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py caa8609 
>   tools/marvin/marvin/cloudstackTestClient.py d3a6b94 
>   tools/marvin/marvin/configGenerator.py 4f03fd0 
>   tools/marvin/marvin/marvinInit.py de580ce 
>   tools/marvin/marvin/marvinLog.py 65687aa 
>   tools/marvin/marvin/marvinPlugin.py c817cd6 
> 
> Diff: https://reviews.apache.org/r/21070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

RE: How is this working?

[Nitin Mehta]

This column is not used for calculating capacity for pool.
We have always used op host capacity table. Nevertheless please do file a bug

Thanks,
-Nitin

From: Mike Tutkowski [mike.tutkow...@solidfire.com]
Sent: Monday, May 05, 2014 9:12 PM
To: dev@cloudstack.apache.org
Subject: Re: How is this working?

My storage plug-in actually uses a custom host listener, so I have not
encountered this issue.

I don't remember off hand if it was in 4.2 or 4.3, but at some point
someone changed the storage_pool table's available_bytes column to be
used_bytes.

It looks like this code you reference was missed.


On Mon, May 5, 2014 at 4:35 AM, Koushik Das  wrote:

> I came across this code snippet in hostConnect() method in
> DefaultHostListener.java. Look at the line where the used bytes is set on
> the poolVO. This looks like a serious bug. Looking at the history this code
> has been there since a year. Has anyone encountered any issues with primary
> storage capacity?
>
> ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> …..
> StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> primaryStoreDao.update(pool.getId(), poolVO);
>
>
> -Koushik
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in Simulator results in incorrect size

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review42162
---



plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java


I would rather you get the size from the source. Can you have a look?


- daan Hoogland


On March 28, 2014, 7:10 a.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> ---
> 
> (Updated March 28, 2014, 7:10 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal 
> template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in 
> the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template 
> create mocking process, which ultimately setting up the size to 100 in the 
> tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
>  8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> ---
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting 
> populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>

Re: Review Request 20007: CLOUDSTACK-2697 - Populated the clusterId with actual value instead of Null in the alert message logs

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20007/#review42165
---


Commit 0babb92d62c08afc04aa0df1bbf053539a53c523 in cloudstack's branch 
refs/heads/master from Girish Chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0babb92 ]

CLOUDSTACK-2697 Removed the clusterId as null from the alert message logs

Signed-off-by: Daan Hoogland 


- ASF Subversion and Git Services


On April 3, 2014, 4:49 p.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20007/
> ---
> 
> (Updated April 3, 2014, 4:49 p.m.)
> 
> 
> Review request for cloudstack and prashant mishra.
> 
> 
> Bugs: CLOUDSTACK-2697
> https://issues.apache.org/jira/browse/CLOUDSTACK-2697
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2697 - cluster id in alert message is null {alertType:: 1 // 
> dataCenterId:: 1 // podId:: 1 // clusterId:: null }
> 
> The Cluster ID is getting populated as null in the logs for the alert 
> messages. In the code base the ClusterId has been hardcoded as null for the 
> log messages. I have modified to code to provide the actual cluster ID. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 2a343d5 
> 
> Diff: https://reviews.apache.org/r/20007/diff/
> 
> 
> Testing
> ---
> 
> Tested on the 4.3 platform. 
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>

Re: Review Request 20007: CLOUDSTACK-2697 - Populated the clusterId with actual value instead of Null in the alert message logs

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20007/#review42166
---

Ship it!


0babb92d62c08afc04aa0df1bbf053539a53c523

- daan Hoogland


On April 3, 2014, 4:49 p.m., Girish Chaudhari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20007/
> ---
> 
> (Updated April 3, 2014, 4:49 p.m.)
> 
> 
> Review request for cloudstack and prashant mishra.
> 
> 
> Bugs: CLOUDSTACK-2697
> https://issues.apache.org/jira/browse/CLOUDSTACK-2697
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2697 - cluster id in alert message is null {alertType:: 1 // 
> dataCenterId:: 1 // podId:: 1 // clusterId:: null }
> 
> The Cluster ID is getting populated as null in the logs for the alert 
> messages. In the code base the ClusterId has been hardcoded as null for the 
> log messages. I have modified to code to provide the actual cluster ID. 
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 2a343d5 
> 
> Diff: https://reviews.apache.org/r/20007/diff/
> 
> 
> Testing
> ---
> 
> Tested on the 4.3 platform. 
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>

Re: How is this working?

[Mike Tutkowski]

How's about I just check this code into master?

poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
mspAnswer.getPoolInfo().getAvailableBytes());

It is patterned off of the PrimaryDataStoreHelper.attachHost logic, which
looks like this:

pool.setUsedBytes(existingInfo.getCapacityBytes() -
existingInfo.getAvailableBytes());


On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta  wrote:

> This column is not used for calculating capacity for pool.
> We have always used op host capacity table. Nevertheless please do file a
> bug
>
> Thanks,
> -Nitin
> 
> From: Mike Tutkowski [mike.tutkow...@solidfire.com]
> Sent: Monday, May 05, 2014 9:12 PM
> To: dev@cloudstack.apache.org
> Subject: Re: How is this working?
>
> My storage plug-in actually uses a custom host listener, so I have not
> encountered this issue.
>
> I don't remember off hand if it was in 4.2 or 4.3, but at some point
> someone changed the storage_pool table's available_bytes column to be
> used_bytes.
>
> It looks like this code you reference was missed.
>
>
> On Mon, May 5, 2014 at 4:35 AM, Koushik Das 
> wrote:
>
> > I came across this code snippet in hostConnect() method in
> > DefaultHostListener.java. Look at the line where the used bytes is set on
> > the poolVO. This looks like a serious bug. Looking at the history this
> code
> > has been there since a year. Has anyone encountered any issues with
> primary
> > storage capacity?
> >
> > ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> > …..
> > StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> > poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> > poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> > primaryStoreDao.update(pool.getId(), poolVO);
> >
> >
> > -Koushik
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

console view not coming

[raja sekhar]

hii all,

After upgrading from cloudstack 4.2 to cloudstack 4.3,when i click on
console view it shows that google crome(The server refused the connection)
and firefox(can't establish a connection to the server).



regards,
rajasekhar

Heart Bleed - Apache Cloud Stack - open ssl

[Prakash Rao Banuka]

Hi:

It is learnt that openssl library is being called when console of system vms 
(secondarystorage , console proxy vm and router vm) is launched.

Is it mandatory to update openssl library in Apache Cloud Stack? If yes, is 
there any official document.

Thank you
Prakash

Re: How is this working?

[Nitin Mehta]

Ideally, we should deprecate the column since its not used and causes
confusion. 
Setting to this value wouldn't help because this column is never updated
regularly.

On 05/05/14 10:28 AM, "Mike Tutkowski" 
wrote:

>How's about I just check this code into master?
>
>poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
>mspAnswer.getPoolInfo().getAvailableBytes());
>
>It is patterned off of the PrimaryDataStoreHelper.attachHost logic, which
>looks like this:
>
>pool.setUsedBytes(existingInfo.getCapacityBytes() -
>existingInfo.getAvailableBytes());
>
>
>On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta 
>wrote:
>
>> This column is not used for calculating capacity for pool.
>> We have always used op host capacity table. Nevertheless please do file
>>a
>> bug
>>
>> Thanks,
>> -Nitin
>> 
>> From: Mike Tutkowski [mike.tutkow...@solidfire.com]
>> Sent: Monday, May 05, 2014 9:12 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: How is this working?
>>
>> My storage plug-in actually uses a custom host listener, so I have not
>> encountered this issue.
>>
>> I don't remember off hand if it was in 4.2 or 4.3, but at some point
>> someone changed the storage_pool table's available_bytes column to be
>> used_bytes.
>>
>> It looks like this code you reference was missed.
>>
>>
>> On Mon, May 5, 2014 at 4:35 AM, Koushik Das 
>> wrote:
>>
>> > I came across this code snippet in hostConnect() method in
>> > DefaultHostListener.java. Look at the line where the used bytes is
>>set on
>> > the poolVO. This looks like a serious bug. Looking at the history this
>> code
>> > has been there since a year. Has anyone encountered any issues with
>> primary
>> > storage capacity?
>> >
>> > ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
>> > Š..
>> > StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
>> > poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
>> > poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
>> > primaryStoreDao.update(pool.getId(), poolVO);
>> >
>> >
>> > -Koushik
>> >
>>
>>
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud
>> *�*
>>
>
>
>
>-- 
>*Mike Tutkowski*
>*Senior CloudStack Developer, SolidFire Inc.*
>e: mike.tutkow...@solidfire.com
>o: 303.746.7302
>Advancing the way the world uses the
>cloud
>*�*

Re: How is this working?

[Mike Tutkowski]

OK, I can log a JIRA ticket for this.

Thanks


On Mon, May 5, 2014 at 11:49 AM, Nitin Mehta  wrote:

> Ideally, we should deprecate the column since its not used and causes
> confusion.
> Setting to this value wouldn't help because this column is never updated
> regularly.
>
> On 05/05/14 10:28 AM, "Mike Tutkowski" 
> wrote:
>
> >How's about I just check this code into master?
> >
> >poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
> >mspAnswer.getPoolInfo().getAvailableBytes());
> >
> >It is patterned off of the PrimaryDataStoreHelper.attachHost logic, which
> >looks like this:
> >
> >pool.setUsedBytes(existingInfo.getCapacityBytes() -
> >existingInfo.getAvailableBytes());
> >
> >
> >On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta 
> >wrote:
> >
> >> This column is not used for calculating capacity for pool.
> >> We have always used op host capacity table. Nevertheless please do file
> >>a
> >> bug
> >>
> >> Thanks,
> >> -Nitin
> >> 
> >> From: Mike Tutkowski [mike.tutkow...@solidfire.com]
> >> Sent: Monday, May 05, 2014 9:12 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: How is this working?
> >>
> >> My storage plug-in actually uses a custom host listener, so I have not
> >> encountered this issue.
> >>
> >> I don't remember off hand if it was in 4.2 or 4.3, but at some point
> >> someone changed the storage_pool table's available_bytes column to be
> >> used_bytes.
> >>
> >> It looks like this code you reference was missed.
> >>
> >>
> >> On Mon, May 5, 2014 at 4:35 AM, Koushik Das 
> >> wrote:
> >>
> >> > I came across this code snippet in hostConnect() method in
> >> > DefaultHostListener.java. Look at the line where the used bytes is
> >>set on
> >> > the poolVO. This looks like a serious bug. Looking at the history this
> >> code
> >> > has been there since a year. Has anyone encountered any issues with
> >> primary
> >> > storage capacity?
> >> >
> >> > ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> >> > Š..
> >> > StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> >> > poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> >> > poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> >> > primaryStoreDao.update(pool.getId(), poolVO);
> >> >
> >> >
> >> > -Koushik
> >> >
> >>
> >>
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkow...@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the
> >> cloud
> >> * *
> >>
> >
> >
> >
> >--
> >*Mike Tutkowski*
> >*Senior CloudStack Developer, SolidFire Inc.*
> >e: mike.tutkow...@solidfire.com
> >o: 303.746.7302
> >Advancing the way the world uses the
> >cloud
> >* *
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: console view not coming

[Amogh Vasekar]

http://goo.gl/IsnRFw

Thanks,
Amogh



On 5/5/14 10:28 AM, "raja sekhar"  wrote:

>hii all,
>
>After upgrading from cloudstack 4.2 to cloudstack 4.3,when i click on
>console view it shows that google crome(The server refused the connection)
>and firefox(can't establish a connection to the server).
>
>
>
>regards,
>rajasekhar

Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management install package creates log directory that is never used

[Nux Ro]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42174
---

Ship it!


Ship It!

- Nux Ro


On April 30, 2014, 10:24 p.m., David Bierce wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> ---
> 
> (Updated April 30, 2014, 10:24 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The RPM build cloud.spec creates a directory that is never used by cloudstack 
> management and is just left as an empty directory name cloudstack-management 
> in /var/log.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 83c598b 
> 
> Diff: https://reviews.apache.org/r/20921/diff/
> 
> 
> Testing
> ---
> 
> Build RPMs on CentOS 6.4 and 6.5 using master
> 
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
> 
> Resulting packages installed on Centos 6.5 without the unused directory. 
> 
> 
> Thanks,
> 
> David Bierce
> 
>

old review https://reviews.apache.org/r/16002

[Daan Hoogland]

Brian, Jessica,

Can you please judge and apply or discard this review request? it is quite old.

-- 
Daan

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review42175
---


Alex, generic logic looks good to me. But still some things need to be fixed.

1) RegionVO

@Column(name = "active")
private boolean active;

Explicitly set it to be active by default. Just setting it in the DB might not 
be enough because DAO would always default boolean to false if not set in the 
constructor/intance variable declaration. It should look like:

@Column(name = "active")

private boolean active = true;

2) Please make the description for the new parameters in the addRegion API , 
more descriptive

@Parameter(name = ApiConstants.MODE, type = CommandType.STRING, required = 
true, description = "Region service active")
55  
private String mode;


3) AccountManager

* boolean updateUser(final Long id, String userName, String firstName, String 
lastName, String password, String email, String apiKey, String secretKey, 
String timeZone, Account.State state);

Why do we pass account state to the call? there should be only user info passed 
in. If the account needs to be updated, do it in the separate command; if you 
need to retrive the account state - get the account object from the user 
object. Please remove this parameter

* Why did you change the method signature for the

UserAccount disableUser(long userId) to disableUser(User user)? The only one 
info that you have to pass to the manager - is the userId. Please change it 
back.

The same for  boolean enableUser(User user), boolean lockAccount(Account 
account);

These changes don't seem to be critical or used for/by your plugin, so please 
change them back to the original way of doing things. Its not a good practice 
to change methods defined in the interfaces - AccountManager/AccountService - 
unless there is a real need for it.


* boolean updateAccount(AccountVO account, String newAccountName, String 
newNetworkDomain, final Map details, Account.State state);

As updateAccount doesn't allow account state update, please remove 
Account.State from the method signature


4) ApiResponseHelper.java

Why did you change createDomainResponse method? 

public DomainResponse createDomainResponse(Domain domain)?


To summarize it all, I would suggest to eliminate (revert) all the changes done 
to account/domain managers that your code doesn't actually need. It would make 
the changes list much shorter and easier for review.

- Alena Prokharchyk


On May 4, 2014, 9:12 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated May 4, 2014, 9:12 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 39ef710 
>   api/src/com/cloud/user/AccountService.java 7e37b38 
>   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
>   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
>   api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/query/QueryService.java 01af631 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml d8dbde7 
>   client/tomcatconf/commands.properties.in 45debe4 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  489b37d 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
>  957f708 
>   plugins/pom.xml 9b391b8 
>   
> server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
>  fc1c7e2 
>   server/src/com/cloud/api/ApiDBUtils.java 67e47f7 
>   server/src/com/cloud/api/ApiResponseHelper.java 38f2f0b 
>   server/src/com/cloud/api/dispatch/ParamProcessWorker.java e9bdd8b 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 3abb944 
>   server/src/com/cloud/api/query/ViewResponseHelper.java d06e1d1 
>   server/src/com/cloud/event/ActionEventUtils.java 28e5680 
>   server/src/com/cloud/server/ManagementServerImpl.java bce2930 
>   server/src/com/cloud/user/AccountMan

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17790/#review42177
---


Alex,

Move all new API commands/responses you've added 
(ListSyncAccountsCmdByAdmin.java, SyncAccountResponse.java), to your plugin's 
"multiregion" folder. Look how its done for other CS plugins - internallb for 
example

- Alena Prokharchyk


On May 4, 2014, 9:18 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17790/
> ---
> 
> (Updated May 4, 2014, 9:18 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Currently, under the environment of cloudstack with multiple regions, each 
> region has its own management server running with a separate database, which 
> will cause data discrepancies when users create/update/delete 
> domain/account/user data independently in each management server. So to 
> support multiple regions and provide one point of entry for each customer, 
> this implementation duplicates domain/account/user information of customers 
> in one region to all of the regions independently whenever there is any 
> change.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4992
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/ListSyncAccountsCmdByAdmin.java
>  PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/domain/ListSyncDomainChildrenCmd.java
>  PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/domain/ListSyncDomainsCmd.java
>  PRE-CREATION 
>   api/src/org/apache/cloudstack/api/command/admin/user/ListSyncUsersCmd.java 
> PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/user/account/ListSyncAccountsCmd.java
>  PRE-CREATION 
>   api/src/org/apache/cloudstack/api/response/SyncAccountResponse.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/api/response/SyncDomainResponse.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/api/response/SyncUserResponse.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/RmapVO.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/RsyncVO.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDao.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/dao/RmapDaoImpl.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDao.java 
> PRE-CREATION 
>   engine/schema/src/org/apache/cloudstack/multiregion/dao/RsyncDaoImpl.java 
> PRE-CREATION 
>   plugins/event-bus/multiregion/pom.xml PRE-CREATION 
>   
> plugins/event-bus/multiregion/resources/META-INF/cloudstack/spring-mom-multiregion-daos-context.xml
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/resources/META-INF/cloudstack/system/spring-plugin-multiregion-system-context.xml
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/FullSyncer.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/InjectedCollection.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/MultiRegionEventBus.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/StringManipulator.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/AccountCaller.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/BaseCaller.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/DomainCaller.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/api/UserCaller.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/exception/APIFailureException.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/AccountFullSyncProcessor.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/AccountService.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/BaseService.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/DomainFullSyncProcessor.java
>  PRE-CREATION 
>   
> plugins/event-bus/multiregion/src/org/apache/cloudstack/mom/multiregion/service/DomainService.java
>  PRE-CREATION 
>   
> plugins/event-b

Re: Review Request 17495: CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on the Upgraded Setup

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17495/#review42178
---


Commit db154a0d7937d1c01c561e510bac8c7ed74e7130 in cloudstack's branch 
refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=db154a0 ]

CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints
on the Upgraded Setup

- ASF Subversion and Git Services


On Jan. 29, 2014, 10:50 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17495/
> ---
> 
> (Updated Jan. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5976
> https://issues.apache.org/jira/browse/CLOUDSTACK-5976
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on 
> the Upgraded Setup
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade302to40.java 45f5f1b 
> 
> Diff: https://reviews.apache.org/r/17495/diff/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 17495: CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on the Upgraded Setup

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17495/#review42179
---


Commit a521c02c54dc670b48d9e5d81fb51e688f6f36a8 in cloudstack's branch 
refs/heads/4.4 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a521c02 ]

CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints
on the Upgraded Setup


- ASF Subversion and Git Services


On Jan. 29, 2014, 10:50 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17495/
> ---
> 
> (Updated Jan. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5976
> https://issues.apache.org/jira/browse/CLOUDSTACK-5976
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on 
> the Upgraded Setup
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade302to40.java 45f5f1b 
> 
> Diff: https://reviews.apache.org/r/17495/diff/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 17495: CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on the Upgraded Setup

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17495/#review42181
---


Commit 5ccde5de93db2a9b7768771912d2111cedbb1ed4 in cloudstack's branch 
refs/heads/4.3 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5ccde5d ]

CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints
on the Upgraded Setup
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade302to40.java


- ASF Subversion and Git Services


On Jan. 29, 2014, 10:50 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17495/
> ---
> 
> (Updated Jan. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5976
> https://issues.apache.org/jira/browse/CLOUDSTACK-5976
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on 
> the Upgraded Setup
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade302to40.java 45f5f1b 
> 
> Diff: https://reviews.apache.org/r/17495/diff/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 17495: CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on the Upgraded Setup

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17495/#review42183
---

Ship it!


db154a0d7937d1c01c561e510bac8c7ed74e7130 on master
a521c02c54dc670b48d9e5d81fb51e688f6f36a8 on 4.4
5ccde5de93db2a9b7768771912d2111cedbb1ed4 on 4.3

- daan Hoogland


On Jan. 29, 2014, 10:50 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17495/
> ---
> 
> (Updated Jan. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5976
> https://issues.apache.org/jira/browse/CLOUDSTACK-5976
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints on 
> the Upgraded Setup
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade302to40.java 45f5f1b 
> 
> Diff: https://reviews.apache.org/r/17495/diff/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: 4.4 release-notes

[Daan Hoogland]

Animesh,

Can you (give me rights to) add these filters to the release dashboard?

On Fri, May 2, 2014 at 4:43 AM, Pierre-Luc Dion  wrote:
> 4.4.0 Fixed Issues
> project = CLOUDSTACK AND type = Bug AND affectedVersion in (4.2.0, 4.2.1,
> 4.3.0) AND fixVersion = 4.4.0 AND resolution != "\"Unresolved\"" ORDER BY
> created DESC, priority DESC, key ASC
>
> 4.4.0 Known Issues
> project = CLOUDSTACK AND type = Bug AND (affectedVersion = 4.4.0 OR
> fixVersion = 4.4.0) AND resolution is EMPTY AND level = "Public" ORDER BY
> priority DESC, key ASC
>



-- 
Daan

Review Request 21087: Remove hard-coding for platform emulators in Xen Server

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/
---

Review request for cloudstack and Nitin Mehta.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358


Repository: cloudstack-git


Description
---

As a part of supporting dynamic guest OS defined by user, removing the 
hard-coded dependencies.
This patch is for XenServer


Diffs
-

  api/src/com/cloud/agent/api/to/VirtualMachineTO.java 
bbd83852abf840ab5d93f53ad0c71e61491b2dda 
  core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java 
d2abd54e0407ab597636d9c9d5a596e55f987108 
  
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
 e86bd23b0500f25268a603a7c41e8e00d18957d2 
  engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 
9eaa7e19c134caf0633bb9099c5f858075fddba7 
  
engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java
 b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 
89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 ad3797306c92d80d929a1e09b46b471231baa6c0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
 4a69d3aececd718cdb7257d3807225c429b73823 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java
 8cb7997305f1344429c5b256bea35878137bb5a3 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
 cc623bfab61f732a4310e3c6c93a51bc36a463b9 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
 3dc527e93d82733823f4e8fddb242d698c21629f 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java
 a78ed819bdeb4878850989915a7280b0639e3ab6 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java
 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java
 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java
 5c9bfbb5952008b332900cd7af21671f7dc465a5 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java
 c10dc1e90cbce2ff41cc62e2120f5e23931a4207 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java
 4f04961e35742d7e846cec47725551d67b704bfc 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java
 40143646f7744e05e2ca009d99d53973ceaf58ee 

Diff: https://reviews.apache.org/r/21087/diff/


Testing
---

1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct 
propagation of platform emulator.


Thanks,

Amogh Vasekar

Re: Review Request 21087: Remove hard-coding for platform emulators in Xen Server

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/
---

(Updated May 5, 2014, 7:02 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
---

Cleaning up some code


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358


Repository: cloudstack-git


Description
---

As a part of supporting dynamic guest OS defined by user, removing the 
hard-coded dependencies.
This patch is for XenServer


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/VirtualMachineTO.java 
bbd83852abf840ab5d93f53ad0c71e61491b2dda 
  core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java 
d2abd54e0407ab597636d9c9d5a596e55f987108 
  
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
 e86bd23b0500f25268a603a7c41e8e00d18957d2 
  engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 
9eaa7e19c134caf0633bb9099c5f858075fddba7 
  
engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java
 b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 
89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 ad3797306c92d80d929a1e09b46b471231baa6c0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
 4a69d3aececd718cdb7257d3807225c429b73823 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java
 8cb7997305f1344429c5b256bea35878137bb5a3 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
 cc623bfab61f732a4310e3c6c93a51bc36a463b9 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
 3dc527e93d82733823f4e8fddb242d698c21629f 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java
 a78ed819bdeb4878850989915a7280b0639e3ab6 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java
 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java
 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java
 5c9bfbb5952008b332900cd7af21671f7dc465a5 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java
 c10dc1e90cbce2ff41cc62e2120f5e23931a4207 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java
 4f04961e35742d7e846cec47725551d67b704bfc 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java
 40143646f7744e05e2ca009d99d53973ceaf58ee 

Diff: https://reviews.apache.org/r/21087/diff/


Testing
---

1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct 
propagation of platform emulator.


Thanks,

Amogh Vasekar

RE: old review https://reviews.apache.org/r/16002

[Brian Federle]

Yes, it looks like it indeed is still an issue in some cases. I'll take a look 
at it.

Thanks,
Brian

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, May 05, 2014 11:19 AM
To: Brian Federle; Jessica Wang
Cc: dev
Subject: old review https://reviews.apache.org/r/16002

Brian, Jessica,

Can you please judge and apply or discard this review request? it is quite old.

-- 
Daan

Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.

[Brian Federle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42188
---

Ship it!


Ship It!

- Brian Federle


On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> ---
> 
> (Updated Dec. 6, 2013, 5:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Wrong layout format in Secondary Storage QuickView: 
> https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
> 
> Problem with layout occurs when quick-view displays details field from json 
> data. In table body, row has the same class as the parent div.
> 
> 
> Diffs
> -
> 
>   ui/scripts/ui/widgets/detailView.js 
> b0ebaa9b27947f3720e2068471361004bce02f7a 
> 
> Diff: https://reviews.apache.org/r/16002/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
> 
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
> 
> 
> Thanks,
> 
> Dariusz Nejbauer
> 
>

Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42189
---


Commit 41684505d6626bc77d422017b5d7956a90a047e6 in cloudstack's branch 
refs/heads/master from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4168450 ]

CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL

Signed-off-by: Brian Federle 


- ASF Subversion and Git Services


On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> ---
> 
> (Updated Dec. 6, 2013, 5:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Wrong layout format in Secondary Storage QuickView: 
> https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
> 
> Problem with layout occurs when quick-view displays details field from json 
> data. In table body, row has the same class as the parent div.
> 
> 
> Diffs
> -
> 
>   ui/scripts/ui/widgets/detailView.js 
> b0ebaa9b27947f3720e2068471361004bce02f7a 
> 
> Diff: https://reviews.apache.org/r/16002/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
> 
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
> 
> 
> Thanks,
> 
> Dariusz Nejbauer
> 
>

Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42190
---


Commit 259ce3b59c6a8633fc77a7eac88fbefd915107e2 in cloudstack's branch 
refs/heads/4.4-forward from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=259ce3b ]

CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL

Signed-off-by: Brian Federle 


- ASF Subversion and Git Services


On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> ---
> 
> (Updated Dec. 6, 2013, 5:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Wrong layout format in Secondary Storage QuickView: 
> https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
> 
> Problem with layout occurs when quick-view displays details field from json 
> data. In table body, row has the same class as the parent div.
> 
> 
> Diffs
> -
> 
>   ui/scripts/ui/widgets/detailView.js 
> b0ebaa9b27947f3720e2068471361004bce02f7a 
> 
> Diff: https://reviews.apache.org/r/16002/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
> 
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
> 
> 
> Thanks,
> 
> Dariusz Nejbauer
> 
>

Re: 4.4 release-notes

[Daan Hoogland]

Pierre-Luc,

I made a copy of
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12323241
and added your filters. I don't know how to share them with you, yet.
Maybe I don't need to; it's at
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12323265
see if you can reach it. Let me know if it is as private as it claims
to be.

Daan

On Mon, May 5, 2014 at 8:52 PM, Daan Hoogland  wrote:
> Animesh,
>
> Can you (give me rights to) add these filters to the release dashboard?
>
> On Fri, May 2, 2014 at 4:43 AM, Pierre-Luc Dion  wrote:
>> 4.4.0 Fixed Issues
>> project = CLOUDSTACK AND type = Bug AND affectedVersion in (4.2.0, 4.2.1,
>> 4.3.0) AND fixVersion = 4.4.0 AND resolution != "\"Unresolved\"" ORDER BY
>> created DESC, priority DESC, key ASC
>>
>> 4.4.0 Known Issues
>> project = CLOUDSTACK AND type = Bug AND (affectedVersion = 4.4.0 OR
>> fixVersion = 4.4.0) AND resolution is EMPTY AND level = "Public" ORDER BY
>> priority DESC, key ASC
>>
>
>
>
> --
> Daan



-- 
Daan

Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42191
---


Commit e28948ccc3f16a6c9c956fc773a26fcfbd58014b in cloudstack's branch 
refs/heads/4.4 from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e28948c ]

CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL

Signed-off-by: Brian Federle 


- ASF Subversion and Git Services


On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> ---
> 
> (Updated Dec. 6, 2013, 5:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Wrong layout format in Secondary Storage QuickView: 
> https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
> 
> Problem with layout occurs when quick-view displays details field from json 
> data. In table body, row has the same class as the parent div.
> 
> 
> Diffs
> -
> 
>   ui/scripts/ui/widgets/detailView.js 
> b0ebaa9b27947f3720e2068471361004bce02f7a 
> 
> Diff: https://reviews.apache.org/r/16002/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
> 
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
> 
> 
> Thanks,
> 
> Dariusz Nejbauer
> 
>

Re: git commit: updated refs/heads/4.4-forward to 259ce3b

[Daan Hoogland]

On Mon, May 5, 2014 at 9:17 PM,   wrote:
> 259ce3b59c6a8633fc77a7eac88fbefd915107e2


so I guessed you'd want it cherry-picked ;)

-- 
Daan

Re: 4.4 release-notes

[Pierre-Luc Dion]

Thanks for you help Daan,

It would be best if filters could be publically accessible so the RN script
would work, if you can do this. I can't, from Jira doc I would not be allow
to do that but some person ca since 4.3 filters exists.


Pierre-Luc Dion
Architecte de Solution Cloud | Cloud Solutions Architect
855-OK-CLOUD (855-652-5683) x1101
- - -

*CloudOps*420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_


On Mon, May 5, 2014 at 3:19 PM, Daan Hoogland wrote:

> Pierre-Luc,
>
> I made a copy of
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12323241
> and added your filters. I don't know how to share them with you, yet.
> Maybe I don't need to; it's at
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12323265
> see if you can reach it. Let me know if it is as private as it claims
> to be.
>
> Daan
>
> On Mon, May 5, 2014 at 8:52 PM, Daan Hoogland 
> wrote:
> > Animesh,
> >
> > Can you (give me rights to) add these filters to the release dashboard?
> >
> > On Fri, May 2, 2014 at 4:43 AM, Pierre-Luc Dion 
> wrote:
> >> 4.4.0 Fixed Issues
> >> project = CLOUDSTACK AND type = Bug AND affectedVersion in (4.2.0,
> 4.2.1,
> >> 4.3.0) AND fixVersion = 4.4.0 AND resolution != "\"Unresolved\"" ORDER
> BY
> >> created DESC, priority DESC, key ASC
> >>
> >> 4.4.0 Known Issues
> >> project = CLOUDSTACK AND type = Bug AND (affectedVersion = 4.4.0 OR
> >> fixVersion = 4.4.0) AND resolution is EMPTY AND level = "Public" ORDER
> BY
> >> priority DESC, key ASC
> >>
> >
> >
> >
> > --
> > Daan
>
>
>
> --
> Daan
>

Build failed in Jenkins: cloudstack-4.4-maven-build #254

[jenkins]

See 

Changes:

[Daan Hoogland] CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage 
URL

--
[...truncated 1322 lines...]
main:
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 360 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 82 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.event.EventControlsUnitTest
log4j:WARN No appenders could be found for logger 
(com.cloud.event.EventControlsUnitTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.631 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","description":"Hello"}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.164 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 sec
Running com.cloud.capacity.CapacityManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.155 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.network.firewall.FirewallManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec
Running com.cloud.network.UpdatePhysicalNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.202 sec
Running com.cloud.network.CreatePrivateNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.123 sec
Running com.cloud.network.NetworkModelTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec
Running com.cloud.network.security.SecurityGroupManagerImplTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.469 sec
Running com.cloud.network.security.SecurityGroupQueueTest
Total jobs dequeued = 10, num queued=1010 queue current size=1000
Num Vms= 50 Queue size = 50
Num Vms= 2 Queue size = 2 time=284 ms
Num Vms= 5000 Queue size = 5000 time=2134 ms
Num Vms= 1 Queue size = 1 time=0 ms
Num Vms= 100 Queue size = 100 time=251 ms
Total jobs dequeued = 10, num queued=1009 queue current size=1000
Tests run: 4, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 3.2 sec <<< 
FAILURE!
Running com.cloud.network.vpc.VpcManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec
Running com.cloud.network.DedicateGuestVlanRangesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec
Running com.cloud.network.lb.AssignLoadBalancerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec
Running com.cloud.network.dao.NetworkDaoTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
Running com.cloud.vm.DeploymentPlanningManagerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.232 sec
Running com.cloud.vm.snapshot.VMSnapshotManagerTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.204 sec
Running com.cloud.vm.UserVmManagerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.2 sec
Running com.cloud.configuration.ValidateIpRangeTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 sec
Running com.cloud.configuration.ConfigurationManagerT

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

[Brian Federle]

It's a minor but easy fix, so it wouldn't hurt :)

Also, can you please cherry pick in 4d84970ddc91c2269807708e722942e9bc758185? 
This is a fix for a Firefox incompatibility for CLOUDSTACK-6342, where Firefox 
wasn't rendering the changes correctly (I was just going to make a separate 
request for that).

Thanks Daan.

-Brian

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, May 05, 2014 12:23 PM
To: dev; Brian Federle
Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b

On Mon, May 5, 2014 at 9:17 PM,   wrote:
> 259ce3b59c6a8633fc77a7eac88fbefd915107e2


so I guessed you'd want it cherry-picked ;)

-- 
Daan

Build failed in Jenkins: cloudstack-4.4-forward-build #38

[jenkins]

See 

Changes:

[brian.federle] CLOUDSTACK-6342: Fix LB table listing for Firefox

--
[...truncated 1323 lines...]
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 360 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 82 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.event.EventControlsUnitTest
log4j:WARN No appenders could be found for logger 
(com.cloud.event.EventControlsUnitTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.584 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","description":"Hello"}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.164 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 sec
Running com.cloud.capacity.CapacityManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.163 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.network.firewall.FirewallManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.001 sec
Running com.cloud.network.UpdatePhysicalNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.211 sec
Running com.cloud.network.CreatePrivateNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.142 sec
Running com.cloud.network.NetworkModelTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec
Running com.cloud.network.security.SecurityGroupManagerImplTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.667 sec
Running com.cloud.network.security.SecurityGroupQueueTest
Total jobs dequeued = 10, num queued=1009 queue current size=999
Num Vms= 50 Queue size = 50
Num Vms= 2 Queue size = 2 time=217 ms
Num Vms= 5000 Queue size = 5000 time=858 ms
Num Vms= 1 Queue size = 1 time=0 ms
Num Vms= 100 Queue size = 100 time=688 ms
Total jobs dequeued = 10, num queued=1010 queue current size=1000
Total jobs dequeued = 1, num queued=1001 queue current size=1000
Total jobs dequeued = 10, num queued=1000 queue current size=990
Total jobs dequeued = 10, num queued=10 queue current size=0
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.596 sec <<< 
FAILURE!
Running com.cloud.network.vpc.VpcManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec
Running com.cloud.network.DedicateGuestVlanRangesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 sec
Running com.cloud.network.lb.AssignLoadBalancerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec
Running com.cloud.network.dao.NetworkDaoTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.vm.DeploymentPlanningManagerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.215 sec
Running com.cloud.vm.snapshot.VMSnapshotManagerTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.153 sec
Running com.cloud.vm.UserVmManagerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.183

karma wanted

[Daan Hoogland]

I am looking to publicize filters and a dashboard. Can I or can I get
rights for that?

-- 
Daan

Re: 4.4 release-notes

[David Nalley]

You'll need to file a ticket with infra.

On Mon, May 5, 2014 at 2:52 PM, Daan Hoogland  wrote:
> Animesh,
>
> Can you (give me rights to) add these filters to the release dashboard?
>
> On Fri, May 2, 2014 at 4:43 AM, Pierre-Luc Dion  wrote:
>> 4.4.0 Fixed Issues
>> project = CLOUDSTACK AND type = Bug AND affectedVersion in (4.2.0, 4.2.1,
>> 4.3.0) AND fixVersion = 4.4.0 AND resolution != "\"Unresolved\"" ORDER BY
>> created DESC, priority DESC, key ASC
>>
>> 4.4.0 Known Issues
>> project = CLOUDSTACK AND type = Bug AND (affectedVersion = 4.4.0 OR
>> fixVersion = 4.4.0) AND resolution is EMPTY AND level = "Public" ORDER BY
>> priority DESC, key ASC
>>
>
>
>
> --
> Daan

Re: karma wanted

[David Nalley]

Ask for that level of karma in an infra ticket.

--David

On Mon, May 5, 2014 at 4:16 PM, Daan Hoogland  wrote:
> I am looking to publicize filters and a dashboard. Can I or can I get
> rights for that?
>
> --
> Daan

Re: git commit: updated refs/heads/4.4-forward to 259ce3b

[Daan Hoogland]

On Mon, May 5, 2014 at 9:36 PM, Brian Federle  wrote:
> 4d84970ddc91c2269807708e722942e9bc758185


doesn't apply/cherry-pick

-- 
Daan

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be 
> > fixed.
> > 
> > 1) RegionVO
> > 
> > @Column(name = "active")
> > private boolean active;
> > 
> > Explicitly set it to be active by default. Just setting it in the DB might 
> > not be enough because DAO would always default boolean to false if not set 
> > in the constructor/intance variable declaration. It should look like:
> > 
> > @Column(name = "active")
> > 
> > private boolean active = true;
> > 
> > 2) Please make the description for the new parameters in the addRegion API 
> > , more descriptive
> > 
> > @Parameter(name = ApiConstants.MODE, type = CommandType.STRING, required = 
> > true, description = "Region service active")
> > 55  
> > private String mode;
> > 
> > 
> > 3) AccountManager
> > 
> > * boolean updateUser(final Long id, String userName, String firstName, 
> > String lastName, String password, String email, String apiKey, String 
> > secretKey, String timeZone, Account.State state);
> > 
> > Why do we pass account state to the call? there should be only user info 
> > passed in. If the account needs to be updated, do it in the separate 
> > command; if you need to retrive the account state - get the account object 
> > from the user object. Please remove this parameter
> > 
> > * Why did you change the method signature for the
> > 
> > UserAccount disableUser(long userId) to disableUser(User user)? The only 
> > one info that you have to pass to the manager - is the userId. Please 
> > change it back.
> > 
> > The same for  boolean enableUser(User user), boolean lockAccount(Account 
> > account);
> > 
> > These changes don't seem to be critical or used for/by your plugin, so 
> > please change them back to the original way of doing things. Its not a good 
> > practice to change methods defined in the interfaces - 
> > AccountManager/AccountService - unless there is a real need for it.
> > 
> > 
> > * boolean updateAccount(AccountVO account, String newAccountName, String 
> > newNetworkDomain, final Map details, Account.State state);
> > 
> > As updateAccount doesn't allow account state update, please remove 
> > Account.State from the method signature
> > 
> > 
> > 4) ApiResponseHelper.java
> > 
> > Why did you change createDomainResponse method? 
> > 
> > public DomainResponse createDomainResponse(Domain domain)?
> > 
> > 
> > To summarize it all, I would suggest to eliminate (revert) all the changes 
> > done to account/domain managers that your code doesn't actually need. It 
> > would make the changes list much shorter and easier for review.

for 3) AccountManager

* updateUser in 'state' : it is necessary during the Full Sync when an object's 
information is not same with one in other regions.
* new signatures : they are necessary during the Full Sync not to generate 
events while changing them. They are just another methods to manage objects, so 
can you show me why they are not permitted?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review42175
---


On May 4, 2014, 9:12 p.m., Alex Ough wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20099/
> ---
> 
> (Updated May 4, 2014, 9:12 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the review request for the core changes related with #17790 that has 
> only the new plugin codes.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 39ef710 
>   api/src/com/cloud/user/AccountService.java 7e37b38 
>   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
>   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
>   api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
> f6743ba 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
> b08cbbb 
>   api/src/org/apache/cloudstack/api/response/RegionResponse.java 6c74fa6 
>   api/src/org/apache/cloudstack/query/QueryService.java 01af631 
>   api/src/org/apache/cloudstack/region/Region.java df64e44 
>   api/src/org/apache/cloudstack/region/RegionService.java afefcc7 
>   api/test/org/apache/cloudstack/api/command/test/RegionCmdTest.java 10c3d85 
>   client/pom.xml d8dbde7 
>   client/tomcatconf/commands.properties.in 45debe4 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  489b37d 
>   engine/schema/src/org/apache/cloudstack/region/RegionVO.java 608bd2b 
>   
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/co

Re: 4.4 release-notes

[Pierre-Luc Dion]

Request Created under ASF infrastructure team; INFRA project.

Thanks David,


Pierre-Luc Dion
Architecte de Solution Cloud | Cloud Solutions Architect
855-OK-CLOUD (855-652-5683) x1101
- - -

*CloudOps*420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_


On Mon, May 5, 2014 at 4:17 PM, David Nalley  wrote:

> You'll need to file a ticket with infra.
>
> On Mon, May 5, 2014 at 2:52 PM, Daan Hoogland 
> wrote:
> > Animesh,
> >
> > Can you (give me rights to) add these filters to the release dashboard?
> >
> > On Fri, May 2, 2014 at 4:43 AM, Pierre-Luc Dion 
> wrote:
> >> 4.4.0 Fixed Issues
> >> project = CLOUDSTACK AND type = Bug AND affectedVersion in (4.2.0,
> 4.2.1,
> >> 4.3.0) AND fixVersion = 4.4.0 AND resolution != "\"Unresolved\"" ORDER
> BY
> >> created DESC, priority DESC, key ASC
> >>
> >> 4.4.0 Known Issues
> >> project = CLOUDSTACK AND type = Bug AND (affectedVersion = 4.4.0 OR
> >> fixVersion = 4.4.0) AND resolution is EMPTY AND level = "Public" ORDER
> BY
> >> priority DESC, key ASC
> >>
> >
> >
> >
> > --
> > Daan
>

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

[Brian Federle]

Daan, oops, I think the problem is  I forgot to include a commit in the 
original cherry-pick request.

Please cp 38c99ffdab61ecbadf156f266ba4535958dcb67f first, then 
44a3f586d87fa7b4793cc753509024847270444f

Thanks,
Brian

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Monday, May 05, 2014 1:28 PM
To: Brian Federle
Cc: dev
Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b

On Mon, May 5, 2014 at 9:36 PM, Brian Federle  wrote:
> 4d84970ddc91c2269807708e722942e9bc758185


doesn't apply/cherry-pick

-- 
Daan

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alena Prokharchyk]

> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be 
> > fixed.
> > 
> > 1) RegionVO
> > 
> > @Column(name = "active")
> > private boolean active;
> > 
> > Explicitly set it to be active by default. Just setting it in the DB might 
> > not be enough because DAO would always default boolean to false if not set 
> > in the constructor/intance variable declaration. It should look like:
> > 
> > @Column(name = "active")
> > 
> > private boolean active = true;
> > 
> > 2) Please make the description for the new parameters in the addRegion API 
> > , more descriptive
> > 
> > @Parameter(name = ApiConstants.MODE, type = CommandType.STRING, required = 
> > true, description = "Region service active")
> > 55  
> > private String mode;
> > 
> > 
> > 3) AccountManager
> > 
> > * boolean updateUser(final Long id, String userName, String firstName, 
> > String lastName, String password, String email, String apiKey, String 
> > secretKey, String timeZone, Account.State state);
> > 
> > Why do we pass account state to the call? there should be only user info 
> > passed in. If the account needs to be updated, do it in the separate 
> > command; if you need to retrive the account state - get the account object 
> > from the user object. Please remove this parameter
> > 
> > * Why did you change the method signature for the
> > 
> > UserAccount disableUser(long userId) to disableUser(User user)? The only 
> > one info that you have to pass to the manager - is the userId. Please 
> > change it back.
> > 
> > The same for  boolean enableUser(User user), boolean lockAccount(Account 
> > account);
> > 
> > These changes don't seem to be critical or used for/by your plugin, so 
> > please change them back to the original way of doing things. Its not a good 
> > practice to change methods defined in the interfaces - 
> > AccountManager/AccountService - unless there is a real need for it.
> > 
> > 
> > * boolean updateAccount(AccountVO account, String newAccountName, String 
> > newNetworkDomain, final Map details, Account.State state);
> > 
> > As updateAccount doesn't allow account state update, please remove 
> > Account.State from the method signature
> > 
> > 
> > 4) ApiResponseHelper.java
> > 
> > Why did you change createDomainResponse method? 
> > 
> > public DomainResponse createDomainResponse(Domain domain)?
> > 
> > 
> > To summarize it all, I would suggest to eliminate (revert) all the changes 
> > done to account/domain managers that your code doesn't actually need. It 
> > would make the changes list much shorter and easier for review.
> 
> Alex Ough wrote:
> for 3) AccountManager
> 
> * updateUser in 'state' : it is necessary during the Full Sync when an 
> object's information is not same with one in other regions.
> * new signatures : they are necessary during the Full Sync not to 
> generate events while changing them. They are just another methods to manage 
> objects, so can you show me why they are not permitted?
>

Alex, correct me if I'm wrong. In most of your code you use CS APIs to 
retrieve/update/delete/disable(disable changes the state) the CS objects 
(user/domain/account - updateAccount/updateDomain/deleteAccount etc). And you 
do it in each reason, and that generates the events for all the regions when 
these APIs are processed. Like for example, I see these calls:

  public JSONObject updateAccount(String accountId, String currentName, String 
newName, String details, String domainId, String networkDomain) throws 
APIFailureException {
139 
140 
StringBuilder param = buildCmd("updateAccount");
141 
param.append(append(ApiConstants.ID, accountId));
142 
if (currentName != null) param.append(append(ApiConstants.ACCOUNT, 
currentName));
143 
if (newName != null) param.append(append(ApiConstants.NEW_NAME, 
newName));
144 
if (details != null) param.append(append(ApiConstants.ACCOUNT_DETAILS, 
details));
145 
if (domainId != null) param.append(append(ApiConstants.DOMAIN_ID, 
domainId));
146 
if (networkDomain != null) 
param.append(append(ApiConstants.NETWORK_DOMAIN, networkDomain));
147 
param.append(appendResType("json"));
148 
param.append(appendSessionKey(encodeSessionKey()));
149 
150 
return sendApacheGet(param.toString());
151 
}
152 
153 
public JSONObject disableAccount(String accountId) throws 
APIFailureException {
164 
165 
StringBuilder param = buildCmd("disableAccount");
166 
param.append(append(ApiConstants.ID, accountId));
167 
param.append(append(ApiConstants.LOCK, "false"));
168 
param.append(appendResType("json"));
169 
param.append(appendSessionKey(encodeSessionKey()));
170 
171 
return sendApacheGet(param.toString());
172 
}


But in some parts of yo

Re: git commit: updated refs/heads/4.4-forward to 259ce3b

[Daan Hoogland]

On Mon, May 5, 2014 at 10:44 PM, Brian Federle  wrote:
> Please cp 38c99ffdab61ecbadf156f266ba4535958dcb67f first, then 
> 44a3f586d87fa7b4793cc753509024847270444f


both in

-- 
Daan

[ACS4.4] Cherry pick for CLOUDSTACK-6483

[Jessica Wang]

Hugo/Daan,



Could you please cherry-pick the following commit from 4.4-forward to 4.4 
branch?



Please cherry-pick Brian's 3 commits in the email below, then cherry-pick mine:



Commit hash:d5079e9cfa54a004a91295b1b2f24d2308e3000b

CLOUDSTACK- 6483: [UI-Loading balancing]Multiple UI issues while assigning the 
VM to LB rule.


Thank you.



Jessica


From: Brian Federle
Sent: Friday, May 02, 2014 10:38 AM
To: dev@cloudstack.apache.org
Cc: Jessica Wang
Subject: [ACS4.4] Cherry pick for CLOUDSTACK-6483

Please cherry-pick 4.4-forward commits for CLOUDSTACK-6483 (in this order):

0b03609c45ecb5b4525e6a7b5216c70032d94a39
7daabf6515509dc276b968c6ca042cf964a328da
430d14b67608039159403036dae3dc7af1e590f5

Thank you,
Brian

RE: [ACS4.4] Cherry pick for CLOUDSTACK-6483

[Brian Federle]

Daan just cp'd all my UI fixes now, so yours is ready to go in.

-Brian

From: Jessica Wang
Sent: Monday, May 05, 2014 1:54 PM
To: dev@cloudstack.apache.org
Cc: Brian Federle
Subject: [ACS4.4] Cherry pick for CLOUDSTACK-6483


Hugo/Daan,



Could you please cherry-pick the following commit from 4.4-forward to 4.4 
branch?



Please cherry-pick Brian's 3 commits in the email below, then cherry-pick mine:



Commit hash:d5079e9cfa54a004a91295b1b2f24d2308e3000b

CLOUDSTACK- 6483: [UI-Loading balancing]Multiple UI issues while assigning the 
VM to LB rule.

Thank you.



Jessica


From: Brian Federle
Sent: Friday, May 02, 2014 10:38 AM
To: dev@cloudstack.apache.org
Cc: Jessica Wang
Subject: [ACS4.4] Cherry pick for CLOUDSTACK-6483

Please cherry-pick 4.4-forward commits for CLOUDSTACK-6483 (in this order):

0b03609c45ecb5b4525e6a7b5216c70032d94a39
7daabf6515509dc276b968c6ca042cf964a328da
430d14b67608039159403036dae3dc7af1e590f5

Thank you,
Brian

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[Alex Ough]

> On May 5, 2014, 6:27 p.m., Alena Prokharchyk wrote:
> > Alex, generic logic looks good to me. But still some things need to be 
> > fixed.
> > 
> > 1) RegionVO
> > 
> > @Column(name = "active")
> > private boolean active;
> > 
> > Explicitly set it to be active by default. Just setting it in the DB might 
> > not be enough because DAO would always default boolean to false if not set 
> > in the constructor/intance variable declaration. It should look like:
> > 
> > @Column(name = "active")
> > 
> > private boolean active = true;
> > 
> > 2) Please make the description for the new parameters in the addRegion API 
> > , more descriptive
> > 
> > @Parameter(name = ApiConstants.MODE, type = CommandType.STRING, required = 
> > true, description = "Region service active")
> > 55  
> > private String mode;
> > 
> > 
> > 3) AccountManager
> > 
> > * boolean updateUser(final Long id, String userName, String firstName, 
> > String lastName, String password, String email, String apiKey, String 
> > secretKey, String timeZone, Account.State state);
> > 
> > Why do we pass account state to the call? there should be only user info 
> > passed in. If the account needs to be updated, do it in the separate 
> > command; if you need to retrive the account state - get the account object 
> > from the user object. Please remove this parameter
> > 
> > * Why did you change the method signature for the
> > 
> > UserAccount disableUser(long userId) to disableUser(User user)? The only 
> > one info that you have to pass to the manager - is the userId. Please 
> > change it back.
> > 
> > The same for  boolean enableUser(User user), boolean lockAccount(Account 
> > account);
> > 
> > These changes don't seem to be critical or used for/by your plugin, so 
> > please change them back to the original way of doing things. Its not a good 
> > practice to change methods defined in the interfaces - 
> > AccountManager/AccountService - unless there is a real need for it.
> > 
> > 
> > * boolean updateAccount(AccountVO account, String newAccountName, String 
> > newNetworkDomain, final Map details, Account.State state);
> > 
> > As updateAccount doesn't allow account state update, please remove 
> > Account.State from the method signature
> > 
> > 
> > 4) ApiResponseHelper.java
> > 
> > Why did you change createDomainResponse method? 
> > 
> > public DomainResponse createDomainResponse(Domain domain)?
> > 
> > 
> > To summarize it all, I would suggest to eliminate (revert) all the changes 
> > done to account/domain managers that your code doesn't actually need. It 
> > would make the changes list much shorter and easier for review.
> 
> Alex Ough wrote:
> for 3) AccountManager
> 
> * updateUser in 'state' : it is necessary during the Full Sync when an 
> object's information is not same with one in other regions.
> * new signatures : they are necessary during the Full Sync not to 
> generate events while changing them. They are just another methods to manage 
> objects, so can you show me why they are not permitted?
>
> 
> Alena Prokharchyk wrote:
> Alex, correct me if I'm wrong. In most of your code you use CS APIs to 
> retrieve/update/delete/disable(disable changes the state) the CS objects 
> (user/domain/account - updateAccount/updateDomain/deleteAccount etc). And you 
> do it in each reason, and that generates the events for all the regions when 
> these APIs are processed. Like for example, I see these calls:
> 
>   public JSONObject updateAccount(String accountId, String currentName, 
> String newName, String details, String domainId, String networkDomain) throws 
> APIFailureException {
> 139   
> 140   
> StringBuilder param = buildCmd("updateAccount");
> 141   
> param.append(append(ApiConstants.ID, accountId));
> 142   
> if (currentName != null) 
> param.append(append(ApiConstants.ACCOUNT, currentName));
> 143   
> if (newName != null) param.append(append(ApiConstants.NEW_NAME, 
> newName));
> 144   
> if (details != null) 
> param.append(append(ApiConstants.ACCOUNT_DETAILS, details));
> 145   
> if (domainId != null) param.append(append(ApiConstants.DOMAIN_ID, 
> domainId));
> 146   
> if (networkDomain != null) 
> param.append(append(ApiConstants.NETWORK_DOMAIN, networkDomain));
> 147   
> param.append(appendResType("json"));
> 148   
> param.append(appendSessionKey(encodeSessionKey()));
> 149   
> 150   
> return sendApacheGet(param.toString());
> 151   
> }
> 152   
> 153   
> public JSONObject disableAccount(String accountId) throws 
> APIFailureException {
> 164   
> 165   
> StringBuilder param = buildCmd("disableAccount");
> 166   
> param.append(append(ApiConstants.ID, accountId)

Jenkins build is back to normal : cloudstack-4.4-maven-build #255

[jenkins]

See 

Jenkins build is back to normal : cloudstack-4.4-forward-build #39

[jenkins]

See