Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12992/
---

Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Bugs: CLOUDSTACK-3544


Repository: cloudstack-git


Description
---

CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

Added new guestOS in the schema-410to420 file supported by Xenserver 6.2


Diffs
-

  setup/db/db/schema-410to420.sql 8409c47 

Diff: https://reviews.apache.org/r/12992/diff/


Testing
---


Thanks,

Sanjay Tripathi

Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12993/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: 3874


Repository: cloudstack-git


Description
---

log4j policies in systemvms must be updated to avoid getting full disk space 
used. 
cloud-early-config must replace log4j.xml with updated policies.


Diffs
-

  patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 

Diff: https://reviews.apache.org/r/12993/diff/


Testing
---

Build is successful.
Patch applies cleanly.


Thanks,

Saksham Srivastava

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12993/#review24014
---


Review 12993 PASSED the build test
The url of build cloudstack-master-with-patch #58 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/58/

- Jenkins Cloudstack.org


On July 27, 2013, 8:55 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12993/
> ---
> 
> (Updated July 27, 2013, 8:55 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: 3874
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> log4j policies in systemvms must be updated to avoid getting full disk space 
> used. 
> cloud-early-config must replace log4j.xml with updated policies.
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 
> 
> Diff: https://reviews.apache.org/r/12993/diff/
> 
> 
> Testing
> ---
> 
> Build is successful.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12992/#review24015
---

Ship it!


Ship It!

- Abhinandan Prateek


On July 27, 2013, 8:48 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12992/
> ---
> 
> (Updated July 27, 2013, 8:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3544
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2
> 
> Added new guestOS in the schema-410to420 file supported by Xenserver 6.2
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 8409c47 
> 
> Diff: https://reviews.apache.org/r/12992/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12992/#review24016
---


Commit 65e12e1dadde0512ea1ebf51549bf6ab73c78818 in branch refs/heads/4.2 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=65e12e1 ]

CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On July 27, 2013, 8:48 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12992/
> ---
> 
> (Updated July 27, 2013, 8:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3544
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2
> 
> Added new guestOS in the schema-410to420 file supported by Xenserver 6.2
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 8409c47 
> 
> Diff: https://reviews.apache.org/r/12992/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12992/#review24017
---


Commit f33c887b0327f820429230654c040e45af2c651a in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33c887 ]

CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On July 27, 2013, 8:48 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12992/
> ---
> 
> (Updated July 27, 2013, 8:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3544
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2
> 
> Added new guestOS in the schema-410to420 file supported by Xenserver 6.2
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 8409c47 
> 
> Diff: https://reviews.apache.org/r/12992/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12993/#review24018
---

Ship it!


Ship It!

- Abhinandan Prateek


On July 27, 2013, 8:55 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12993/
> ---
> 
> (Updated July 27, 2013, 8:55 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: 3874
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> log4j policies in systemvms must be updated to avoid getting full disk space 
> used. 
> cloud-early-config must replace log4j.xml with updated policies.
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 
> 
> Diff: https://reviews.apache.org/r/12993/diff/
> 
> 
> Testing
> ---
> 
> Build is successful.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12993/#review24019
---


Commit a10861a57b1a0df11c80dbd04bd02cc2772de2f4 in branch refs/heads/master 
from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a10861a ]

CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of 
systemvms log rotation

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On July 27, 2013, 8:55 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12993/
> ---
> 
> (Updated July 27, 2013, 8:55 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: 3874
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> log4j policies in systemvms must be updated to avoid getting full disk space 
> used. 
> cloud-early-config must replace log4j.xml with updated policies.
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 
> 
> Diff: https://reviews.apache.org/r/12993/diff/
> 
> 
> Testing
> ---
> 
> Build is successful.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12993/#review24020
---


Commit 6403bb339d45b0a5fd0b2aa7aa59ec312c6ba2dd in branch refs/heads/4.2 from 
Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6403bb3 ]

CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of 
systemvms log rotation

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On July 27, 2013, 8:55 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12993/
> ---
> 
> (Updated July 27, 2013, 8:55 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: 3874
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> log4j policies in systemvms must be updated to avoid getting full disk space 
> used. 
> cloud-early-config must replace log4j.xml with updated policies.
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 
> 
> Diff: https://reviews.apache.org/r/12993/diff/
> 
> 
> Testing
> ---
> 
> Build is successful.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12992/#review24021
---


Review 12992 PASSED the build test
The url of build cloudstack-master-with-patch #59 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/59/

- Jenkins Cloudstack.org


On July 27, 2013, 8:48 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12992/
> ---
> 
> (Updated July 27, 2013, 8:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3544
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2
> 
> Added new guestOS in the schema-410to420 file supported by Xenserver 6.2
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 8409c47 
> 
> Diff: https://reviews.apache.org/r/12992/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: [DISCUSS] maven dependencies...

[Daan Hoogland]

ship it;)


On Sat, Jul 27, 2013 at 12:09 AM, Alex Huang  wrote:

> Everyone,
>
> After looking around in the maven documentation, I realized the way we are
> specifying dependencies is not quite right for a large project such as ours.
>
> Currently, almost every project declare their own dependencies and version
> number of the dependent jar.  For those of us who are conscious of the
> version number properties declared in the cloudstack pom file, we follow
> that example but in many places, the version numbers are actually hard
> coded, probably because the writer is not aware of this.
>
> Maven actually has a way to do this.  In the master pom file, we can
> declare in the  tags all of the third party
> dependencies we need and their version numbers.  And then each individual
> module can declare their dependency without version number, which defaults
> to the version declared by CloudStack's master pom.  If a version number is
> declared in the module's pom, it overrides the master's version number but
> there's a warning about this override.
>
> Sounds good?  If so I'll do a quick change to move it over.
>
> --Alex
>

RE: [DISCUSS] vlan uri format change

[Koushik Das]

I raised this in a separate thread. Daan created a new patch 
https://reviews.apache.org/r/12849/ to address backward compat.

> -Original Message-
> From: Prasanna Santhanam [mailto:t...@apache.org]
> Sent: Saturday, July 27, 2013 11:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] vlan uri format change
> 
> Daan,
> 
> This broke the KVM setups last week on master. I couldn't find your commit-
> id for this change scanning the git logs. Toshiaki-san was looking at
> CLOUDSTACK-3682 regarding this change [1] where he makes the scheme
> backwards compatible to work with KVM agents of the past.
> Could you please have a look at the changeset?
> 
> [1] https://reviews.apache.org/r/12985/
> 
> On Mon, Jul 01, 2013 at 10:28:57AM +0200, Daan Hoogland wrote:
> > The gain is that enums like BroadcastDomainType and IsolationType do
> > not have to check for different formats in the presented uri. It also
> > makes it more intiutive what the parts in the uri mean; vlan://
> > would inmply that id is a hostname instead of a scheme specific identifier.
> >
> > I think I am reducing complexity, not introducing any. The present use
> > of uri for vlans is abuse of the construct, i don't think my proposed
> > new use is.
> >
> >
> > On Mon, Jul 1, 2013 at 10:17 AM, Hiroaki KAWAI
> wrote:
> >
> > > Daan, I'm curious about what is the improvement of changing the vlan
> > > String format in URI?
> > >
> > > I'm -1 on pushing more complexity in URI, because that's abuse of
> > > URI class and sounds it's time to get rid of URI.
> > >
> > >
> > >
> > > (2013/07/01 16:47), Daan Hoogland wrote:
> > >
> > >> H,
> > >>
> > >> I've been trying to get a patch accepted and had some discussions
> > >> to do it in parts as well. I would like to refresh the first part:
> > >>
> > >> vlans are now referred as vlan://. I would like to change this
> > >> to vlan:. This will changee addressing the id as a scheme
> > >> specific part instead of as a host. As a result it will be easier
> > >> to fix the code to use Nicira NVP and other sdn networks whereever
> > >> vlans are used now. Doing this will result in a patch that is a
> > >> subset of my earlier patch. It touches a lot of core code and tests
> > >> but has been tested  thoroughly for VPC gateways with both vlans
> > >> and Nicira NVP.
> > >>
> > >> regards,
> > >> Daan
> > >>
> > >>
> > >
> 
> --
> Prasanna.,
> 
> 
> Powered by BigRock.com

Re: Review Request 12849: added backwards compatibility code to Networks enums

[daan Hoogland]

> On July 23, 2013, 12:30 p.m., Koushik Das wrote:
> > api/src/com/cloud/network/Networks.java, line 225
> > 
> >
> > Why only Vlan in case of IsolationType and Vlan, Storage and Mido in 
> > the case of BroadcastDomainType? Earlier both used similar logic.
> > 
> > If all system VMs (SSVM, CPVM and router VMs) are getting started after 
> > this then should be fine.
> > 
> > Also ensure that upgraded setups work fine as well.

tested by instantiating a zone. There are no upgrade (database) aspects to this 
as far as I can see.


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review23686
---


On July 23, 2013, 10:02 a.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12849/
> ---
> 
> (Updated July 23, 2013, 10:02 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Both BroadcastDomainType and IsolationType needed some extra code for 
> backwards compatibility
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
>  6fafa3e 
> 
> Diff: https://reviews.apache.org/r/12849/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

[Jayapal Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12809/#review24022
---


Patch failed to apply on 4.2.
Please update the patch

- Jayapal Reddy


On July 26, 2013, 10:05 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12809/
> ---
> 
> (Updated July 26, 2013, 10:05 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 
>   server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 
> 
> Diff: https://reviews.apache.org/r/12809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12928: update midterm review

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12928/
---

(Updated July 27, 2013, 10:57 a.m.)


Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.


Changes
---

Sorry about! Silly images. 


Repository: cloudstack-git


Description
---

Updates the midterm review I wrote. 
Normalizes screenshot sizes. fixes some phrasing.


Diffs (updated)
-

  docs/en-US/gsoc-midsummer-ian.xml c62cdc3 
  docs/en-US/images/add-ldap-configuration-failure.png 
4da295a8eb9b53024bb54d9300182ced908eb9db 
  docs/en-US/images/add-ldap-configuration.png 
e041eb2a0657cce50d896d06aafbb22c39b121d3 
  docs/en-US/images/delete-ldap-configuration-failure.png 
b5b50e0b7e563544ac044e0ad06019da984d9fd7 
  docs/en-US/images/delete-ldap-configuration.png PRE-CREATION 
  docs/en-US/images/delete-ldap.png c97bb4c47c3eeddf91ccee1517ce526284857908 
  docs/en-US/images/ldap-list-users.png 
aedcb0600b135879ca39c67f19824446c4aa8646 
  docs/en-US/images/list-ldap-configuration.png 
6d75674c58312e8465380047e5574c9c95b12fb3 

Diff: https://reviews.apache.org/r/12928/diff/


Testing
---

Build with publican. 


Thanks,

Ian Duffy

Re: [DISCUSS] Compatibility issue between network plugins and hypervisors

[Daan Hoogland]

H,

isn't it the responsibility of the administrator to setup the cloud in a
proper way? hypervisor and network implementations may enhance their
capabilities at minor upgrades so it will not be easy to keep checks on
this up to date in cloudstack. Am I missing the point here?

regards,
Daan


On Sat, Jul 27, 2013 at 1:10 AM, Toshiaki Hatano
wrote:

> I agree with Murali.
>
> I feel NetworkGuru should know their capability and should called when we
> add cluster.
> NetworkGurus already provide canHandle(NetworkOffering, NetworkType,
> PhysicalNetwork) method to check their capability.
> So, how about overloading this method to get HypervisorType in arguments?
>
> Thanks,
> --
> Toshiaki
>
> -Original Message-
> From: Murali Reddy [mailto:murali.re...@citrix.com]
> Sent: Thursday, July 25, 2013 22:33
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Compatibility issue between network plugins and
> hypervisors
>
> Also, should not we treat 'isolation' as Network Element capability rather
> than Hypervisor. Tunnelling capability could be a Hypervisor capability,
> but isolation (STT/GRE) is Network Element capability? So,zone isolation
> -> isolation provider -> supported hypervisors should be checked against
> add cluster IMO.
>
> On 26/07/13 9:24 AM, "Chiradeep Vittal" 
> wrote:
>
> >+1 (with a caveat), good idea since isolation method is supported on a
> >per-zone basis.
> >The caveat is that sometimes it makes sense to support multiple
> >isolation methods in a zone.
> >For example, VPC(advanced) + basic in the same zone.
> >Why would one do this? Simply because someone might start with one
> >isolation method (basic) and then offer advanced (using overlays like
> >VxLAN f.e). Since templates/snapshots/volumes tend to be zone-specific,
> >this makes the transition easier.
> >This is not unlike AWS "EC2-classic" and "VPC" in the same zone.
> >
> >
> >On 7/26/13 3:34 AM, "Alex Huang"  wrote:
> >
> >>+1
> >>
> >>I think we should take advantage of hypervisor capabilities to look
> >>for that compatibility.
> >>
> >>--Alex
> >>
> >>> -Original Message-
> >>> From: Toshiaki Hatano [mailto:toshiaki.hat...@verio.net]
> >>> Sent: Thursday, July 25, 2013 3:01 PM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: [DISCUSS] Compatibility issue between network plugins and
> >>> hypervisors
> >>>
> >>> Hi devs,
> >>>
> >>>
> >>>
> >>> CloudStack supports many hypervisors and many network isolation
> >>>methods.
> >>>
> >>> Some isolation method doesn't (or cannot) support some hypervisors,
> >>>
> >>> but it looks cloudstack doesn't check compatibility between network
> >>>isolation  and hypervisors.
> >>>
> >>>
> >>>
> >>> Why don't we check it during addCluster, first timing cloudstack-
> >>>management know isolation and hypervisor, and fail if it's
> >>>incompatible?
> >>>
> >>>
> >>>
> >>> Best Regards,
> >>>
> >>> --
> >>>
> >>> Toshiaki Hatano
> >>>
> >>> Verio, an NTT Communications company
> >>> E-mail:  toshiaki.hat...@verio.net
> >>> 
> >>>
> >>> AIM:  toshiaki.hat...@verio.net 
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> This email message is intended for the use of the person to whom it
> >>>has  been sent, and may contain information that is confidential or
> >>>legally  protected. If you are not the intended recipient or have
> >>>received this  message in error, you are not authorized to copy,
> >>>distribute, or otherwise  use this message or its attachments. Please
> >>>notify the sender immediately by  return e-mail and permanently
> >>>delete this message and any attachments.
> >>> Verio Inc. makes no warranty that this email is error or virus free.
> >>>Thank you.
> >
> >
>
>
>
>
> This email message is intended for the use of the person to whom it has
> been sent, and may contain information that is confidential or legally
> protected. If you are not the intended recipient or have received this
> message in error, you are not authorized to copy, distribute, or otherwise
> use this message or its attachments. Please notify the sender immediately
> by return e-mail and permanently delete this message and any attachments.
> Verio Inc. makes no warranty that this email is error or virus free.  Thank
> you.
>

Re: Review Request 12985: CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12985/#review24023
---


this is a duplicate of https://reviews.apache.org/r/12849/

please review that patch

this one does not take into account that some uri shouldn't have // after :

- daan Hoogland


On July 27, 2013, 12:25 a.m., Toshiaki Hatano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12985/
> ---
> 
> (Updated July 27, 2013, 12:25 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali 
> Reddy, Hugo Trippaers, and Sheng Yang.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3682
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CloudStack-management suddenly start generating broadcastUri in 'vlan:' 
> style instead of 'vlan://' style.
> That cause issue in KVM-agent VifDrivers (both Bridge and OVS), since they 
> cannot purse different style Uri.
> 
> For the compatibility to older version, CloudStack-management should generate 
> 'vlan://' style BroadcastUri.
> 
> Change the URI creation way in 2 method below to make sure they generate 
> 'scheme://host' style BroadcastUri.
> - com.cloud.network.Networks.IsolationType.toUri(T)
> - com.cloud.network.Networks.BroadcastDomainType.toUri(T)
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
>  195cf40 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
>  7038d7e 
>   server/src/com/cloud/network/guru/PublicNetworkGuru.java 8beb42e 
> 
> Diff: https://reviews.apache.org/r/12985/diff/
> 
> 
> Testing
> ---
> 
> Tested locally, advanced zone with a KVM hypervisor. 
> 
> 
> Thanks,
> 
> Toshiaki Hatano
> 
>

rejected mail by dev.apache.org

[Daan Hoogland]

Hello,

I replied to a message a minute ago and got 
Delivery to the following recipient failed permanently:

 dev@cloudstack.apache.org

Technical details of permanent failure:
Google tried to deliver your message, but it was rejected by the server for
the recipient domain cloudstack.apache.org by mx1.eu.apache.org.
[192.87.106.230].

The error that the other server returned was:
552 spam score (5.0) exceeded threshold (HTML_MESSAGE,RCVD_IN_DNSWL_
LOW,SPF_PASS,URIBL_BLACK


so this one is to test if it is me

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Saksham Srivastava]

> On July 26, 2013, 5:38 p.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230
> > 
> >
> > I don't understand why you need to do a bunch of search here. This 
> > method is invoked when a template is successfully downloaded to a secondary 
> > storage, why cannot you just do a simple UsageEventUtils.publishUsageEvents 
> > here just like _resourceLimitMgr.incrementResourceCount? template should 
> > have all the information you need to publish a usage event.

Min,
I had to add these checks because the method was getting called twice for a 
single event of register template, due to which there were duplicate entries 
for usage event.
Until the method is guaranteed to be called once, duplicate entries would be 
made for a single usage record and also incrementResourceCount was getting 
executed twice and thus resulted in a faulty resource count.
So for usage-event I am trying to search the usage records and if an entry for 
template creation for the same template exists, refrain from creating a usage 
entry again.
Once the root issue is fixed, the changes won't be needed but until then, they 
are required.


- Saksham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review23955
---


On July 26, 2013, 12:42 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 26, 2013, 12:42 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---+-+-+--+---+---+--+
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: rejected mail by dev.apache.org

[Ian Duffy]

Just check your not sending emails in HTML. They get rejected unless
they are plain text :-)

On 27 July 2013 12:21, Daan Hoogland  wrote:
> Hello,
>
> I replied to a message a minute ago and got 
> Delivery to the following recipient failed permanently:
>
>  dev@cloudstack.apache.org
>
> Technical details of permanent failure:
> Google tried to deliver your message, but it was rejected by the server for
> the recipient domain cloudstack.apache.org by mx1.eu.apache.org.
> [192.87.106.230].
>
> The error that the other server returned was:
> 552 spam score (5.0) exceeded threshold (HTML_MESSAGE,RCVD_IN_DNSWL_
> LOW,SPF_PASS,URIBL_BLACK
> 
>
> so this one is to test if it is me

Re: Unable to get the management server node id

[Ian Duffy]

Great thanks Alax.

Much neater than my work around of commenting out code.

On 27 July 2013 03:53, Alex Huang  wrote:
> Ian,
>
> Assuming you're on master, I just checked in a bunch of changes yesterday 
> that included this one item.  Every code now retrieves the management server 
> id from ManagementServerNode.java.  For your purposes, you can probably 
> default that code to recognize that there's no mac address and have it read 
> from an environment variable.
>
> --Alex
>
>> -Original Message-
>> From: Ian Duffy [mailto:i...@ianduffy.ie]
>> Sent: Friday, July 26, 2013 5:28 PM
>> To: CloudStack Dev
>> Subject: Unable to get the management server node id
>>
>> Hi,
>>
>> I'm unable to start jetty on a openvz based VPS where my nics have no mac
>> address.
>> Any work around for this?
>>
>> Code in question - https://gist.github.com/imduffy15/529f4f01ecb18d3aca21
>>
>> [duffy@neo cloudstack]$ ifconfig
>> loLink encap:Local Loopback
>>   inet addr:127.0.0.1  Mask:255.0.0.0
>>   inet6 addr: ::1/128 Scope:Host
>>   UP LOOPBACK RUNNING  MTU:16436  Metric:1
>>   RX packets:9359 errors:0 dropped:0 overruns:0 frame:0
>>   TX packets:9359 errors:0 dropped:0 overruns:0 carrier:0
>>   collisions:0 txqueuelen:0
>>   RX bytes:6111602 (5.8 MiB)  TX bytes:6111602 (5.8 MiB)
>>
>> venet0Link encap:UNSPEC  HWaddr
>> 00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00
>>   inet addr:127.0.0.1  P-t-P:127.0.0.1  Bcast:0.0.0.0
>> Mask:255.255.255.255
>>   inet6 addr: 2001:67c:12a0::63e1:7959/128 Scope:Global
>>   UP BROADCAST POINTOPOINT RUNNING NOARP  MTU:1500  Metric:1
>>   RX packets:359158 errors:0 dropped:0 overruns:0 frame:0
>>   TX packets:189532 errors:0 dropped:0 overruns:0 carrier:0
>>   collisions:0 txqueuelen:0
>>   RX bytes:511972416 (488.2 MiB)  TX bytes:16640302 (15.8 MiB)
>>
>> venet0:0  Link encap:UNSPEC  HWaddr
>> 00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00
>>   inet addr:91.228.53.85  P-t-P:91.228.53.85
>> Bcast:91.228.53.85  Mask:255.255.255.255
>>   UP BROADCAST POINTOPOINT RUNNING NOARP  MTU:1500  Metric:1

Re: rejected mail by dev.apache.org

[Daan Hoogland]

thanks, i c&p'd a link from another mail, big sin of course.


On Sat, Jul 27, 2013 at 1:23 PM, Ian Duffy  wrote:

> Just check your not sending emails in HTML. They get rejected unless
> they are plain text :-)
>
> On 27 July 2013 12:21, Daan Hoogland  wrote:
> > Hello,
> >
> > I replied to a message a minute ago and got 
> > Delivery to the following recipient failed permanently:
> >
> >  dev@cloudstack.apache.org
> >
> > Technical details of permanent failure:
> > Google tried to deliver your message, but it was rejected by the server
> for
> > the recipient domain cloudstack.apache.org by mx1.eu.apache.org.
> > [192.87.106.230].
> >
> > The error that the other server returned was:
> > 552 spam score (5.0) exceeded threshold (HTML_MESSAGE,RCVD_IN_DNSWL_
> > LOW,SPF_PASS,URIBL_BLACK
> > 
> >
> > so this one is to test if it is me
>

Re: [DISCUSS] vlan uri format change

[Daan Hoogland]

The original patch was committed under Alex' account. Work on the networks
enums is far from done with https://reviews.apache.org/r/12849/. I
commented on the one you are mentioning, Prasanna.

regards,
Daan

On Sat, Jul 27, 2013 at 12:41 PM, Koushik Das  wrote:
> I raised this in a separate thread. Daan created a new patch 
> https://reviews.apache.org/r/12849/ to address backward compat.
>
>> -Original Message-
>> From: Prasanna Santhanam [mailto:t...@apache.org]
>> Sent: Saturday, July 27, 2013 11:12 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] vlan uri format change
>>
>> Daan,
>>
>> This broke the KVM setups last week on master. I couldn't find your commit-
>> id for this change scanning the git logs. Toshiaki-san was looking at
>> CLOUDSTACK-3682 regarding this change [1] where he makes the scheme
>> backwards compatible to work with KVM agents of the past.
>> Could you please have a look at the changeset?
>>
>> [1] https://reviews.apache.org/r/12985/
>>
>> On Mon, Jul 01, 2013 at 10:28:57AM +0200, Daan Hoogland wrote:
>> > The gain is that enums like BroadcastDomainType and IsolationType do
>> > not have to check for different formats in the presented uri. It also
>> > makes it more intiutive what the parts in the uri mean; vlan://
>> > would inmply that id is a hostname instead of a scheme specific identifier.
>> >
>> > I think I am reducing complexity, not introducing any. The present use
>> > of uri for vlans is abuse of the construct, i don't think my proposed
>> > new use is.
>> >
>> >
>> > On Mon, Jul 1, 2013 at 10:17 AM, Hiroaki KAWAI
>> wrote:
>> >
>> > > Daan, I'm curious about what is the improvement of changing the vlan
>> > > String format in URI?
>> > >
>> > > I'm -1 on pushing more complexity in URI, because that's abuse of
>> > > URI class and sounds it's time to get rid of URI.
>> > >
>> > >
>> > >
>> > > (2013/07/01 16:47), Daan Hoogland wrote:
>> > >
>> > >> H,
>> > >>
>> > >> I've been trying to get a patch accepted and had some discussions
>> > >> to do it in parts as well. I would like to refresh the first part:
>> > >>
>> > >> vlans are now referred as vlan://. I would like to change this
>> > >> to vlan:. This will changee addressing the id as a scheme
>> > >> specific part instead of as a host. As a result it will be easier
>> > >> to fix the code to use Nicira NVP and other sdn networks whereever
>> > >> vlans are used now. Doing this will result in a patch that is a
>> > >> subset of my earlier patch. It touches a lot of core code and tests
>> > >> but has been tested  thoroughly for VPC gateways with both vlans
>> > >> and Nicira NVP.
>> > >>
>> > >> regards,
>> > >> Daan
>> > >>
>> > >>
>> > >
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>

Re: Review Request 12928: update midterm review

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12928/#review24025
---


Put the xml as patch. Mail me the images. I am still getting some issues with 
images, no use spending time on again creating the patch with images.

- Abhinandan Prateek


On July 27, 2013, 10:57 a.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12928/
> ---
> 
> (Updated July 27, 2013, 10:57 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Updates the midterm review I wrote. 
> Normalizes screenshot sizes. fixes some phrasing.
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-ian.xml c62cdc3 
>   docs/en-US/images/add-ldap-configuration-failure.png 
> 4da295a8eb9b53024bb54d9300182ced908eb9db 
>   docs/en-US/images/add-ldap-configuration.png 
> e041eb2a0657cce50d896d06aafbb22c39b121d3 
>   docs/en-US/images/delete-ldap-configuration-failure.png 
> b5b50e0b7e563544ac044e0ad06019da984d9fd7 
>   docs/en-US/images/delete-ldap-configuration.png PRE-CREATION 
>   docs/en-US/images/delete-ldap.png c97bb4c47c3eeddf91ccee1517ce526284857908 
>   docs/en-US/images/ldap-list-users.png 
> aedcb0600b135879ca39c67f19824446c4aa8646 
>   docs/en-US/images/list-ldap-configuration.png 
> 6d75674c58312e8465380047e5574c9c95b12fb3 
> 
> Diff: https://reviews.apache.org/r/12928/diff/
> 
> 
> Testing
> ---
> 
> Build with publican. 
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 12928: update midterm review

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12928/
---

(Updated July 27, 2013, 11:56 a.m.)


Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.


Changes
---

Upload images change patch to only modify the xml file.


Repository: cloudstack-git


Description
---

Updates the midterm review I wrote. 
Normalizes screenshot sizes. fixes some phrasing.


Diffs (updated)
-

  docs/en-US/gsoc-midsummer-ian.xml c62cdc3 

Diff: https://reviews.apache.org/r/12928/diff/


Testing
---

Build with publican. 


File Attachments (updated)



  
https://reviews.apache.org/media/uploaded/files/2013/07/27/add-ldap-configuration-failure.png

  
https://reviews.apache.org/media/uploaded/files/2013/07/27/add-ldap-configuration.png

  
https://reviews.apache.org/media/uploaded/files/2013/07/27/delete-ldap-configuration-failure.png

  
https://reviews.apache.org/media/uploaded/files/2013/07/27/delete-ldap-configuration.png

  https://reviews.apache.org/media/uploaded/files/2013/07/27/ldap-list-users.png

  
https://reviews.apache.org/media/uploaded/files/2013/07/27/list-ldap-configuration.png


Thanks,

Ian Duffy

Do we delete an account after all users are deleted?

[Sowmya Krishnan]

Do we perform any cleanup of an account if all users in that account are 
deleted? I don't find that is the current behavior. 
I was going through test_accounts.py and figured that's one of the tests. 
Here's the description of that test:

# Validate the following
# 1. Remove both the users from the account.
# 2. Verify account is removed
# 3. Verify all VMs associated with that account got removed

I don't think we remove an account or its resources automatically if all users 
are removed in that account... Wondering if this is a valid test at all.

Thanks,
Sowmya 

Review Request 12995: [GSoC] Add midterm report to docs

[Shiva Teja Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12995/
---

Review request for cloudstack and Sebastien Goasguen.


Repository: cloudstack-git


Description
---

GSoC - Add midterm review


Diffs
-

  docs/en-US/gsoc-midsummer-shiva.xml 67755c4 
  docs/en-US/images/add-account-screen.png PRE-CREATION 
  docs/en-US/images/async-calls.png PRE-CREATION 
  docs/en-US/images/configuration-edit-success.png PRE-CREATION 
  docs/en-US/images/configurations-screen.png PRE-CREATION 
  docs/en-US/images/create-account-post.png PRE-CREATION 
  docs/en-US/images/create-account-request.png PRE-CREATION 
  docs/en-US/images/edit-configuration.png PRE-CREATION 
  docs/en-US/images/instances-screen.png PRE-CREATION 
  docs/en-US/images/list-domain-vms.png PRE-CREATION 
  docs/en-US/images/list-specific-vm.png PRE-CREATION 
  docs/en-US/images/list-virtualmachines.png PRE-CREATION 
  docs/en-US/images/start-vm-screen.png PRE-CREATION 
  docs/en-US/images/vm-running.png PRE-CREATION 

Diff: https://reviews.apache.org/r/12995/diff/


Testing
---

Build was successful with publican


Thanks,

Shiva Teja Reddy

Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12994/
---

Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and Hugo 
Trippaers.


Bugs: 3216


Repository: cloudstack-git


Description
---

Issue:
==
logrotate.conf and logrotate config files in logrotate.d folder are having "x" 
permission. 
hence logrotate daemon not able to use this config 
logrotate reports the error as 
/etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf
reading config file /etc/logrotate.conf
including /etc/logrotate.d
Ignoring apache2 because of bad file mode.
reading config file apt
reading config file aptitude
reading config file conntrackd
Ignoring dnsmasq because of bad file mode.
reading config file dpkg
Ignoring haproxy because of bad file mode.
reading config file monit
Ignoring ppp because of bad file mode.
Ignoring rsyslog because of bad file mode.
==

Fix:
===
while generating the cloudscripts.tgz file, I had modified to include the 
logrotate.conf and logrotate config files under logrotate.d with 644 permission 
which will fix the issue. 
this is will fix the "bad file mode" error. 


Diffs
-

  patches/pom.xml 00eec02 

Diff: https://reviews.apache.org/r/12994/diff/


Testing
---

1. after generating new systemvm.iso tested the new router/ssvm/console proxy.

logrotate -d -v /etc/logrotate.conf
reading config file /etc/logrotate.conf
including /etc/logrotate.d
reading config file apache2
reading config file apt
reading config file aptitude
reading config file conntrackd
reading config file dnsmasq
reading config file dpkg
reading config file haproxy
reading config file monit
reading config file ppp
reading config file rsyslog


2. Verified after launching the VR, new instances are getting IP and hostname 
properly.


Thanks,

Rajesh Battala

Re: Review Request 12995: [GSoC] Add midterm report to docs

[Shiva Teja Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12995/
---

(Updated July 27, 2013, 1:11 p.m.)


Review request for cloudstack and Sebastien Goasguen.


Repository: cloudstack-git


Description
---

GSoC - Add midterm review


Diffs
-

  docs/en-US/gsoc-midsummer-shiva.xml 67755c4 
  docs/en-US/images/add-account-screen.png PRE-CREATION 
  docs/en-US/images/async-calls.png PRE-CREATION 
  docs/en-US/images/configuration-edit-success.png PRE-CREATION 
  docs/en-US/images/configurations-screen.png PRE-CREATION 
  docs/en-US/images/create-account-post.png PRE-CREATION 
  docs/en-US/images/create-account-request.png PRE-CREATION 
  docs/en-US/images/edit-configuration.png PRE-CREATION 
  docs/en-US/images/instances-screen.png PRE-CREATION 
  docs/en-US/images/list-domain-vms.png PRE-CREATION 
  docs/en-US/images/list-specific-vm.png PRE-CREATION 
  docs/en-US/images/list-virtualmachines.png PRE-CREATION 
  docs/en-US/images/start-vm-screen.png PRE-CREATION 
  docs/en-US/images/vm-running.png PRE-CREATION 

Diff: https://reviews.apache.org/r/12995/diff/


Testing
---

Build was successful with publican


Thanks,

Shiva Teja Reddy

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12972/#review24026
---

Ship it!


Here's how I tested this:

Reverted Sheng's revert which reincluded vm_data.sh 
(3b39fb04421424ebb1485c2a046708bb3661cd4c) and deployed devcloud2 which runs 
Xen underneath. Deployed server, started up systemVMs and ran the userdata 
tests:

$ nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_deploy_vm_with_userdata.py --load
Test userdata as GET, size > 2k ... ERROR
Test userdata as POST, size > 2k ... ERROR

They both failed to find the vm_data.sh script when applying userdata

/var/log/SMlog within devcloud2 shows the plugin failing to find the script

[8147] 2013-07-27 12:13:34.576201   vmdata failed with folder: metadata 
and file: cloud-identifier
[8147] 2013-07-27 12:13:34.576680   ['/bin/bash', 
'/usr/lib/xcp/bin/vm_data.sh', '-r', '169.254.2.157', '-v', '192.168.56.165', 
'-F', 'metadata', '-f', 'instance-id', '-d', '/tmp/tmpKDBarR']
[8147] 2013-07-27 12:13:34.584365   FAILED: (rc 127) stdout: '', stderr: 
'/bin/bash: /usr/lib/xcp/bin/vm_data.sh: No such file or directory


Then applied the patch here for CitrixResourceBase.java and redeployed 
devcloud2 and re-ran the userdata tests

This time they passed
$ nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_deploy_vm_with_userdata.py --load
Test userdata as GET, size > 2k ... ok
Test userdata as POST, size > 2k ... ok

--
Ran 2 tests in 96.547s

OK

Plugin was found and sent userdata via vmdata_kvm.py

[8958] 2013-07-27 12:55:25.961498    VMOPS enter  routerProxy 
[8958] 2013-07-27 12:55:25.962499   ['/bin/bash', 
'/usr/lib/xcp/bin/router_proxy.sh', 'vmdata_kvm.py', '169.254.2.238', '-d', 
'eyIxOTIuMTY4LjU2LjE0NiI6W1sidXNlcmRhdGEiLCJ1c2VyLWRhdGEiLCJNRm94TjFneFREZFhSVkpDVmpoSldGTkdXakExV0RORlFrMVhOelZOVUVjd01WbzJXRUpVVFRnNE56VlNUbEZNVWpoS04waERNVVUzT1U0MFJ6TllVVEpRUWtvd1N6QXhPRGxHVWxSWVREYzBRemRGU1VNMFdGRkpTa1ZMU2t0SVIxVTNXazVMVVZSTFEwNHpWRXRDTlRGWE9EQlVOa1ZDTWtKQldrb3lUekpGTTBsRlZrdEZTVXRMVXpSQ01raFdVemhZT1RCUU5sQk5RVFpHUTFOWk1rbzNWVUpaUWtVeU1USTVSMVpNVTAxUFNWQlhXamRPVms1R1UxbFpWekZVUjBKSFRVdEhUakZWU0RaRVNVUlhRa0ZGVUROT1NqaElVRGRaTWpKUVNUUTVSbFU1TVRCTVJqUklURmxIU3pSSVVEY3lORm8zV2xGQ1NUY3hWRFF4UVVwTVNFZENTMWxCTlZKVk1rWkdNRWhTUjBNMVNsbEZTVEphTmtrNFRqWllUMFpQVURkR1RrdEtVamszVEU0NFRrNDFWemRSV1VWVFVrczFPRVV3VWpJME5WTktUVXRXTjFwRU1FNDJWRmhFU0U5SFQweFpSVFJEVWtsVE0wOUVRbGxCTTFZNVV6SkROREpRVWpOT05VZE9WRE5NT1VsRVJVd3dWMEZNV0VzeFJ6bE1VRFpXVlRjMlRUaE5RMDlYVEZGR1V6TlBSMVJYUVRWWk5WWkRSRlZOUzBrelFWaFVWVmhITkVSUk9URXhTRWszU1RKRE1VWTJTRk5QUzBRelZETkxTMGRUU2toT1VGV
 
XdWVEV5U0VSQlNFVktVVXRQV2twV1FVNUtVbHBTUmxneVdEaENTRmxZVWs5T1MxWlRTVXRCVFU5WFJFZE5NMVE0UWpNMFYxUkRNRUpSVFUxSlRGaFpXVXc0TXpGWU0wdFBWa1JUVGtJd1JGbFlRVGRhVVVJNU9FdzNRMGhhVFZJeVdVaE1SVVk1VmpGQk4xZFBXRE5aUTBSR09VRkpObFJNVFZsUFVWTTJOMWhKUTFkSVRUTlFVRVpLUmpReU9ERXdOVVJDTlU1SFZrMHdTRWd5UkVKRVR6UlJSRk5QV2tsVVZFTkZTMWxaV1RCTFIwTlhWMU5FTWtGVFRESkRXbE14VjBGR1VqQlNWMEZEV1VkRVEwdzBSRTFaUWpkUFNVRkdWa1pLUXpOWVZWUXlNVnBDTUZCT1UwTkhNemxJTVZrMVUxRTBVRVZVV2tsUE9FdFdXa0ZVUTA0elJUUlBPRGhTVGtWSFdWRTNOMFJhUkZKSE1sUkRSVEJXTjFaS1F6WklXVlJSU0VRNFRWTXhWMUl5VmpFM1ZrWXlUamhhUmpCRlJFTkRSRlphVmtWWlVFTldURVZZU2pGQlQwNURNamM0VDFwVlRWb3lOMXBYVVZnNVJ6VlFTVTgwUkVOR1==']
[8958] 2013-07-27 12:55:26.155233   SUCCESS
[8958] 2013-07-27 12:55:26.155390    VMOPS exit  routerProxy 

Checked the userdata within the routervm and the decoded userdata is found:

root@r-5-VM:/var/www/html/userdata/192.168.56.150# pwd
/var/www/html/userdata/192.168.56.150

root@r-5-VM:/var/www/html/userdata/192.168.56.150# cat user-data 
0Z17X1L7WERBV8IXSFZ05X3EBMW75MPG01Z6XBTM8875RNQLR8J7HC1E79N4G3XQ2PBJ0K0189FRTXL74C7EIC4XQIJEKJKHGU7ZNKQTKCN3TKB51W80T6EB2BAZJ2O2E3IEVKEIKKS4B2HVS8X90P6PMA6FCSY2J7UBYBE2129GVLSMOIPWZ7NVNFSYYW1TGBGMKGN1UH6DIDWBAEP3NJ8HP7Y22PI49FU910LF4HLYGK4HP724Z7ZQBI71T41AJLHGBKYA5RU2FF0HRGC5JYEI2Z6I8N6XOFOP7FNKJR97LN8NN5W7QYESRK58E0R245SJMKV7ZD0N6TXDHOGOLYE4CRIS3ODBYA3V9S2C42PR3N5GNT3L9IDEL0WALXK1G9LP6VU76M8MCOWLQFS3OGTWA5Y5VCDUMKI3AXTUXG4DQ911HI7I2C1F6HSOKD3T3KKGSJHNPU0U12HDAHEJQKOZJVANJRZRFX2X8BHYXRONKVSIKAMOWDGM3T8B34WTC0BQMMILXYYL831X3KOVDSNB0DYXA7ZQB98L7CHZMR2YHLEF9V1A7WOX3YCDF9AI6TLMYOQS67XICWHM3PPFJF428105DB5NGVM0HH2DBDO4QDSOZITTCEKYYY0KGCWWSD2ASL2CZS1WAFR0RWACYGDCL4DMYB7OIAFVFJC3XUT21ZB0PNSCG39H1Y5SQ4PETZIO8KVZATCN3E4O88RNEGYQ77DZDRG2TCE0V7VJC6HYTQHD8MS1WR2V17VF2N8ZF0EDCCDVZVEYPCVLEXJ1AONC278OZUMZ27ZWQX9G5PIO4DCFCNSKBJV47SCWDDX3M3V8NO7D0WDS9IV17R0W37194N0AI7PQH4root@r-5-VM:/var/www/html/userdata/192.168.56.150#
 


When the account and the VMs were deleted the userdata for those VMs remained. 
So this probably is an existing bug not a result of the python plugin. The 
python script also looks fine save for the 

Re: Review Request 11626: Automation: Memory limits tests from Resource Limits Tests

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
---

(Updated July 27, 2013, 1:21 p.m.)


Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna 
Santhanam.


Changes
---

including dev and QA for review


Repository: cloudstack-git


Description
---

Adding resource limit tests related to Memory. Changes suggested in CPU 
resource limit tests which are applicable here are incorporated too.

Updated test plan is available here: 
https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000


Diffs
-

  test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION 
  test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION 
  test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION 
  test/integration/component/memory_limits/test_project_limits.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py 8d9a25d 
  tools/marvin/marvin/integration/lib/common.py 4f5acef 

Diff: https://reviews.apache.org/r/11626/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Do we delete an account after all users are deleted?

[Prasanna Santhanam]

On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> Do we perform any cleanup of an account if all users in that account
> are deleted? I don't find that is the current behavior. 
> I was going through test_accounts.py and figured that's one of the
> tests. Here's the description of that test:
> 
> # Validate the following
> # 1. Remove both the users from the account.
> # 2. Verify account is removed
> # 3. Verify all VMs associated with that account got removed
> 
> I don't think we remove an account or its resources automatically if
> all users are removed in that account... Wondering if this is a
> valid test at all.
> 

Yes the test is invalid. It had been skipped earlier with ("Open
Questions") in the reason. Probably something that was in a test plan
but didn't have clarity at the time it was written. I removed all
skips in the tests so we'll find those invalid ones now.

-- 
Prasanna.,


Powered by BigRock.com

RE: Do we delete an account after all users are deleted?

[Sowmya Krishnan]

> -Original Message-
> From: Prasanna Santhanam [mailto:t...@apache.org]
> Sent: Saturday, July 27, 2013 6:55 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Do we delete an account after all users are deleted?
> 
> On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> > Do we perform any cleanup of an account if all users in that account
> > are deleted? I don't find that is the current behavior.
> > I was going through test_accounts.py and figured that's one of the
> > tests. Here's the description of that test:
> >
> > # Validate the following
> > # 1. Remove both the users from the account.
> > # 2. Verify account is removed
> > # 3. Verify all VMs associated with that account got removed
> >
> > I don't think we remove an account or its resources automatically if
> > all users are removed in that account... Wondering if this is a valid
> > test at all.
> >
> 
> Yes the test is invalid. It had been skipped earlier with ("Open
> Questions") in the reason. Probably something that was in a test plan but 
> didn't
> have clarity at the time it was written. I removed all skips in the tests so 
> we'll
> find those invalid ones now.

Ok. This one evidently failed cleanup and surfaced here: 
https://issues.apache.org/jira/browse/CLOUDSTACK-3746 
We have a list of "to-be-skipped" tests? Just wondering how many more we have.

> 
> --
> Prasanna.,
> 
> 
> Powered by BigRock.com

RE: Do we delete an account after all users are deleted?

[Sowmya Krishnan]

> -Original Message-
> From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
> Sent: Saturday, July 27, 2013 7:05 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
> 
> 
> 
> > -Original Message-
> > From: Prasanna Santhanam [mailto:t...@apache.org]
> > Sent: Saturday, July 27, 2013 6:55 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Do we delete an account after all users are deleted?
> >
> > On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> > > Do we perform any cleanup of an account if all users in that account
> > > are deleted? I don't find that is the current behavior.
> > > I was going through test_accounts.py and figured that's one of the
> > > tests. Here's the description of that test:
> > >
> > > # Validate the following
> > > # 1. Remove both the users from the account.
> > > # 2. Verify account is removed
> > > # 3. Verify all VMs associated with that account got removed
> > >
> > > I don't think we remove an account or its resources automatically if
> > > all users are removed in that account... Wondering if this is a
> > > valid test at all.
> > >
> >
> > Yes the test is invalid. It had been skipped earlier with ("Open
> > Questions") in the reason. Probably something that was in a test plan
> > but didn't have clarity at the time it was written. I removed all
> > skips in the tests so we'll find those invalid ones now.
> 
> Ok. This one evidently failed cleanup and surfaced here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3746

It's this one in fact: https://issues.apache.org/jira/browse/CLOUDSTACK-3745

> We have a list of "to-be-skipped" tests? Just wondering how many more we
> have.
> 
> >
> > --
> > Prasanna.,
> >
> > 
> > Powered by BigRock.com

Re: Do we delete an account after all users are deleted?

[Prasanna Santhanam]

On Sat, Jul 27, 2013 at 01:34:25PM +, Sowmya Krishnan wrote:
> 
> 
> > -Original Message-
> > From: Prasanna Santhanam [mailto:t...@apache.org]
> > Sent: Saturday, July 27, 2013 6:55 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Do we delete an account after all users are deleted?
> > 
> > On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> > > Do we perform any cleanup of an account if all users in that account
> > > are deleted? I don't find that is the current behavior.
> > > I was going through test_accounts.py and figured that's one of the
> > > tests. Here's the description of that test:
> > >
> > > # Validate the following
> > > # 1. Remove both the users from the account.
> > > # 2. Verify account is removed
> > > # 3. Verify all VMs associated with that account got removed
> > >
> > > I don't think we remove an account or its resources automatically if
> > > all users are removed in that account... Wondering if this is a valid
> > > test at all.
> > >
> > 
> > Yes the test is invalid. It had been skipped earlier with ("Open
> > Questions") in the reason. Probably something that was in a test plan but 
> > didn't
> > have clarity at the time it was written. I removed all skips in the tests 
> > so we'll
> > find those invalid ones now.
> 
> Ok. This one evidently failed cleanup and surfaced here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3746 

Not much info in that bug report to tell why it failed. From what I
gather, we are probably missing a few account cleanups in some of the
suites and this one is one of them.

> We have a list of "to-be-skipped" tests? Just wondering how many
> more we have.

It's in the git logs but do you want to skip them now? I'd rather weed
out the invalid ones as they fail.

03e283c4b3ed0046a4b9dc1ad4ab948254af
8bc72ad55c76635939f463185291b0c283b57858
a4356b559cb1401c790e1aa62606c1f256e75229

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12809/#review24027
---


Commit a8ad908666b963bfd152b508fcec7259cf3a545f in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a8ad908 ]

CLOUDSTACK-3703: change service offering of stopped vm on

Conflicts:
server/test/com/cloud/vm/UserVmManagerTest.java


- ASF Subversion and Git Services


On July 26, 2013, 10:05 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12809/
> ---
> 
> (Updated July 26, 2013, 10:05 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 
>   server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 
> 
> Diff: https://reviews.apache.org/r/12809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12809/#review24029
---

Ship it!


commit b21de4006abd61512b027af2dd9e8b07df1dd06f

- Kishan Kavala


On July 26, 2013, 3:35 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12809/
> ---
> 
> (Updated July 26, 2013, 3:35 p.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 
>   server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 
> 
> Diff: https://reviews.apache.org/r/12809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12809/#review24028
---


Commit b21de4006abd61512b027af2dd9e8b07df1dd06f in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b21de40 ]

CLOUDSTACK-3703: change service offering of stopped vm on


- ASF Subversion and Git Services


On July 26, 2013, 10:05 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12809/
> ---
> 
> (Updated July 26, 2013, 10:05 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3703
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 
>   server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 
> 
> Diff: https://reviews.apache.org/r/12809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Review Request 12996: Unable to Resize Volume (kvm, vmware)

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/
---

Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram 
Ganesh.


Bugs: 3877


Repository: cloudstack-git


Description
---

Issue:
=
this issue is with the way we extract the hypevisor type from the sql 


mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, 
cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
++-+
| hypervisor | hypervisor_type |
++-+
| NULL | KVM |
++-+


first column value will be not null if the storage pool is Zone wide else it 
will be NULL. 
but in the code always first column is considering to figure out the hypervisor 
type which causing the hpervisor type to be NONE and hence failing to resize 
the volume


this issue is happening while determining the hypervisor type for a volume. 
for ZWPS, it will return the hypervisor because, in storage pool we store the 
hypervisor type if the pool is added of scoe ZONE. 
if the pool is of scope Cluster hypervisor type will be NULL

we support volume resize when the volume is present on ZONE scope and Cluster 
scope. 
they way of hypervisor type extraction from the sql query result should be 
change which will resolve this blocker.


Fix:
=

depending on the scope type of storage pool, the sql result is passed to 
determined the hypervisor type.


Diffs
-

  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 

Diff: https://reviews.apache.org/r/12996/diff/


Testing
---

1. Able to resize the volume successfully


Thanks,

Rajesh Battala

RE: Do we delete an account after all users are deleted?

[Alex Huang]

The bug is scarce on details.  

Assuming I understand what is asked correctly, this should not be done at all.  
A deletion of an account triggers an expunge of the all resources.  Suppose 
someone made a mistake and removed all users from an account and cs 
automatically deleted the account and automatically cleaned out the resources.  
Not a good idea.  Better to specifically delete the account.

--Alex

> -Original Message-
> From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
> Sent: Saturday, July 27, 2013 6:52 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
> 
> 
> 
> > -Original Message-
> > From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
> > Sent: Saturday, July 27, 2013 7:05 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Do we delete an account after all users are deleted?
> >
> >
> >
> > > -Original Message-
> > > From: Prasanna Santhanam [mailto:t...@apache.org]
> > > Sent: Saturday, July 27, 2013 6:55 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Do we delete an account after all users are deleted?
> > >
> > > On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> > > > Do we perform any cleanup of an account if all users in that
> > > > account are deleted? I don't find that is the current behavior.
> > > > I was going through test_accounts.py and figured that's one of the
> > > > tests. Here's the description of that test:
> > > >
> > > > # Validate the following
> > > > # 1. Remove both the users from the account.
> > > > # 2. Verify account is removed
> > > > # 3. Verify all VMs associated with that account got
> > > > removed
> > > >
> > > > I don't think we remove an account or its resources automatically
> > > > if all users are removed in that account... Wondering if this is a
> > > > valid test at all.
> > > >
> > >
> > > Yes the test is invalid. It had been skipped earlier with ("Open
> > > Questions") in the reason. Probably something that was in a test
> > > plan but didn't have clarity at the time it was written. I removed
> > > all skips in the tests so we'll find those invalid ones now.
> >
> > Ok. This one evidently failed cleanup and surfaced here:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-3746
> 
> It's this one in fact: https://issues.apache.org/jira/browse/CLOUDSTACK-
> 3745
> 
> > We have a list of "to-be-skipped" tests? Just wondering how many more
> > we have.
> >
> > >
> > > --
> > > Prasanna.,
> > >
> > > 
> > > Powered by BigRock.com

Review Request 12997: usage event is not generated for volume resize

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12997/
---

Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.


Repository: cloudstack-git


Description
---

issue:

when resize volume is requested and action is successfuly usage event is not 
recorded. Code is not present for recording the resize volume usage event.

fix:
Added the code to record the usage event when the resize volume is requested.


Diffs
-

  server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 

Diff: https://reviews.apache.org/r/12997/diff/


Testing
---

Environment:
kvm, with cluster scope storage pool.
default centos instance.

1. created a volume and tried to resize the volume.
volume resize is successful

usage event is registered in usage_event table now.

  | 0 | NULL |
| 27 | VOLUME.RESIZE   |  2 | 2013-07-27 14:54:51 |   1 |   
   21 | TestVol  |   6 |NULL |  
5368709120 | NULL   | 0 | NULL |
++-++-+-+-+--+-+-+-++---+--+


Thanks,

Rajesh Battala

RE: Do we delete an account after all users are deleted?

[Sowmya Krishnan]

That's the behavior right now - we don't delete the account if users are all 
deleted. 
So we just need the test script to be removed/altered which is testing the 
other way.

> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Saturday, July 27, 2013 8:38 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
> 
> The bug is scarce on details.
> 
> Assuming I understand what is asked correctly, this should not be done at 
> all.  A
> deletion of an account triggers an expunge of the all resources.  Suppose
> someone made a mistake and removed all users from an account and cs
> automatically deleted the account and automatically cleaned out the resources.
> Not a good idea.  Better to specifically delete the account.
> 
> --Alex
> 
> > -Original Message-
> > From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
> > Sent: Saturday, July 27, 2013 6:52 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Do we delete an account after all users are deleted?
> >
> >
> >
> > > -Original Message-
> > > From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com]
> > > Sent: Saturday, July 27, 2013 7:05 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: Do we delete an account after all users are deleted?
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Prasanna Santhanam [mailto:t...@apache.org]
> > > > Sent: Saturday, July 27, 2013 6:55 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: Do we delete an account after all users are deleted?
> > > >
> > > > On Sat, Jul 27, 2013 at 12:19:31PM +, Sowmya Krishnan wrote:
> > > > > Do we perform any cleanup of an account if all users in that
> > > > > account are deleted? I don't find that is the current behavior.
> > > > > I was going through test_accounts.py and figured that's one of
> > > > > the tests. Here's the description of that test:
> > > > >
> > > > > # Validate the following
> > > > > # 1. Remove both the users from the account.
> > > > > # 2. Verify account is removed
> > > > > # 3. Verify all VMs associated with that account got
> > > > > removed
> > > > >
> > > > > I don't think we remove an account or its resources
> > > > > automatically if all users are removed in that account...
> > > > > Wondering if this is a valid test at all.
> > > > >
> > > >
> > > > Yes the test is invalid. It had been skipped earlier with ("Open
> > > > Questions") in the reason. Probably something that was in a test
> > > > plan but didn't have clarity at the time it was written. I removed
> > > > all skips in the tests so we'll find those invalid ones now.
> > >
> > > Ok. This one evidently failed cleanup and surfaced here:
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-3746
> >
> > It's this one in fact:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-
> > 3745
> >
> > > We have a list of "to-be-skipped" tests? Just wondering how many
> > > more we have.
> > >
> > > >
> > > > --
> > > > Prasanna.,
> > > >
> > > > 
> > > > Powered by BigRock.com

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Min Chen]

> On July 26, 2013, 5:38 p.m., Min Chen wrote:
> > server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230
> > 
> >
> > I don't understand why you need to do a bunch of search here. This 
> > method is invoked when a template is successfully downloaded to a secondary 
> > storage, why cannot you just do a simple UsageEventUtils.publishUsageEvents 
> > here just like _resourceLimitMgr.incrementResourceCount? template should 
> > have all the information you need to publish a usage event.
> 
> Saksham Srivastava wrote:
> Min,
> I had to add these checks because the method was getting called twice for 
> a single event of register template, due to which there were duplicate 
> entries for usage event.
> Until the method is guaranteed to be called once, duplicate entries would 
> be made for a single usage record and also incrementResourceCount was getting 
> executed twice and thus resulted in a faulty resource count.
> So for usage-event I am trying to search the usage records and if an 
> entry for template creation for the same template exists, refrain from 
> creating a usage entry again.
> Once the root issue is fixed, the changes won't be needed but until then, 
> they are required.

Ok, I remember that problem, yes, for some reasons, this 
createTemplateAsyncCallBack is called twice at the end of template download, I 
haven't figured out the real reason yet. Thanks for clarification. But I still 
have a question here: from my own testing, when control is coming to this 
method, template is sure already downloaded (100%), why cannot you just do a 
simple duplicate usage record check to decide whether to publish usage event or 
not? I saw that in this code before checking usage record, you have done a 
bunch of check regarding cross zones and download percent, etc. Any catch here? 
Also, it is also better to put some comments here for the usage check 
workaround so that the other developer can understand.


- Min


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review23955
---


On July 26, 2013, 12:42 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 26, 2013, 12:42 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---+-+-+--+---+---+--+
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

RE: Dev Help: How to create scheduled tasks in ACS

[Alex Huang]

Hi Ian,

You might want to develop against vmsync branch for now, if you don't mind.  We 
intend to bring the job queue work there over to master.  I've been bringing 
vmsync over piece meal to master but haven't gotten to the job part yet.

In the vmsync branch, what you'll find is that we've isolated the asyncjob code 
into the framework-jobs project.  We also scrubbed the AsyncJobManager 
interface so that we removed all traces of api commands from it.  Now you 
basically create an asyncjobVO with a dispatcher and it gets scheduled.  When 
the job runs, the dispatcher gets notified of the job and the job content is 
sent to the dispatcher.  You can find two dispatchers already.  One is 
ApiAysncJobDispatcher and the other is the VmWorkJobDispatcher.  

Take a look.  Let me know if I can help you out with anything.

--Alex

> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Friday, July 26, 2013 2:48 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Dev Help: How to create scheduled tasks in ACS
> 
> > Are you looking for something in < 4.2?  Kelven did a great job abstracting
> out the entire job framework in vmsync, which he'll merge into > master
> soon.  I can give examples of both but it may be easier for Ian if it's in 
> master.
> 
> Hi Alex,
> 
> Its for master :-)
> 
> On 26 July 2013 22:34, Alex Huang  wrote:
> > Ilya,
> >
> > Are you looking for something in < 4.2?  Kelven did a great job abstracting
> out the entire job framework in vmsync, which he'll merge into master soon.
> I can give examples of both but it may be easier for Ian if it's in master.
> >
> > --Alex
> >
> >> -Original Message-
> >> From: Musayev, Ilya [mailto:imusa...@webmd.net]
> >> Sent: Friday, July 26, 2013 1:48 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: Dev Help: How to create scheduled tasks in ACS
> >>
> >> Donal,
> >>
> >> My apology as I was not clear, we need inner Java example currently
> >> used by ACS.
> >>
> >> External would be the very worst case, i would personally consider
> >> least desired.
> >>
> >> Thanks
> >> ilya
> >>
> >> > -Original Message-
> >> > From: Ian Duffy [mailto:i...@ianduffy.ie]
> >> > Sent: Friday, July 26, 2013 4:41 PM
> >> > To: dev@cloudstack.apache.org
> >> > Subject: Re: Dev Help: How to create scheduled tasks in ACS
> >> >
> >> > Hi Donal,
> >> >
> >> > Thats neat, not sure one would want to rely on a external task to
> >> > kick it off though.
> >> >
> >> > Something that is integrated within the Cloudstack lifecycle would
> >> > be preferred.
> >> >
> >> > Thanks.
> >

[GSOC][Urgent] Build docbook failed

[Nguyen Anh Tu]

Hi guys,

I build my GSoC mid-term review and get an error here:

Validation failed:
CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist content
does not follow the DTD, expecting (blockinfo? , (title , titleabbrev?)? ,
(caution | important | note | tip | warning | literallayout |
programlisting | programlistingco | screen | screenco | screenshot |
synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis |
constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara |
para | simpara | address | blockquote | graphic | graphicco | mediaobject |
mediaobjectco | informalequation | informalexample | informalfigure |
informaltable | anchor | bridgehead | remark | highlights | abstract |
authorblurb | epigraph | indexterm | beginpage)* , listitem+), got
(listitem mediaobject listitem mediaobject )

Sound like I use  in wrong way. But I don't know what exactly
causes the error.

Urgent. Anyone can help? Thank so much!

-- 

N.g.U.y.e.N.A.n.H.t.U

Re: [GSOC][Urgent] Build docbook failed

[Shiva Teja]

Hi,

Can you send the paste it somewhere and give a link? I can try.


On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu  wrote:

> Hi guys,
>
> I build my GSoC mid-term review and get an error here:
>
> Validation failed:
> CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist content
> does not follow the DTD, expecting (blockinfo? , (title , titleabbrev?)? ,
> (caution | important | note | tip | warning | literallayout |
> programlisting | programlistingco | screen | screenco | screenshot |
> synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis |
> constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara |
> para | simpara | address | blockquote | graphic | graphicco | mediaobject |
> mediaobjectco | informalequation | informalexample | informalfigure |
> informaltable | anchor | bridgehead | remark | highlights | abstract |
> authorblurb | epigraph | indexterm | beginpage)* , listitem+), got
> (listitem mediaobject listitem mediaobject )
>
> Sound like I use  in wrong way. But I don't know what exactly
> causes the error.
>
> Urgent. Anyone can help? Thank so much!
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>

Re: [GSOC][Urgent] Build docbook failed

[Shiva Teja]

Oops,

*paste it somewhere


On Sat, Jul 27, 2013 at 10:06 PM, Shiva Teja  wrote:

> Hi,
>
> Can you send the paste it somewhere and give a link? I can try.
>
>
> On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu  wrote:
>
>> Hi guys,
>>
>> I build my GSoC mid-term review and get an error here:
>>
>> Validation failed:
>> CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist
>> content
>> does not follow the DTD, expecting (blockinfo? , (title , titleabbrev?)? ,
>> (caution | important | note | tip | warning | literallayout |
>> programlisting | programlistingco | screen | screenco | screenshot |
>> synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis |
>> constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara |
>> para | simpara | address | blockquote | graphic | graphicco | mediaobject
>> |
>> mediaobjectco | informalequation | informalexample | informalfigure |
>> informaltable | anchor | bridgehead | remark | highlights | abstract |
>> authorblurb | epigraph | indexterm | beginpage)* , listitem+), got
>> (listitem mediaobject listitem mediaobject )
>>
>> Sound like I use  in wrong way. But I don't know what
>> exactly
>> causes the error.
>>
>> Urgent. Anyone can help? Thank so much!
>>
>> --
>>
>> N.g.U.y.e.N.A.n.H.t.U
>>
>
>

Re: [GSOC][Urgent] Build docbook failed

[Nguyen Anh Tu]

Hi Shiva, I send to you my report. Please try build it.

Thanks


2013/7/27 Shiva Teja 

> Oops,
>
> *paste it somewhere
>
>
> On Sat, Jul 27, 2013 at 10:06 PM, Shiva Teja  wrote:
>
> > Hi,
> >
> > Can you send the paste it somewhere and give a link? I can try.
> >
> >
> > On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu 
> wrote:
> >
> >> Hi guys,
> >>
> >> I build my GSoC mid-term review and get an error here:
> >>
> >> Validation failed:
> >> CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist
> >> content
> >> does not follow the DTD, expecting (blockinfo? , (title ,
> titleabbrev?)? ,
> >> (caution | important | note | tip | warning | literallayout |
> >> programlisting | programlistingco | screen | screenco | screenshot |
> >> synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis |
> >> constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara |
> >> para | simpara | address | blockquote | graphic | graphicco |
> mediaobject
> >> |
> >> mediaobjectco | informalequation | informalexample | informalfigure |
> >> informaltable | anchor | bridgehead | remark | highlights | abstract |
> >> authorblurb | epigraph | indexterm | beginpage)* , listitem+), got
> >> (listitem mediaobject listitem mediaobject )
> >>
> >> Sound like I use  in wrong way. But I don't know what
> >> exactly
> >> causes the error.
> >>
> >> Urgent. Anyone can help? Thank so much!
> >>
> >> --
> >>
> >> N.g.U.y.e.N.A.n.H.t.U
> >>
> >
> >
>



-- 

N.g.U.y.e.N.A.n.H.t.U

http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"; [

%BOOK_ENTITIES;
]>




Mid-Summer Progress Updates for Nguyen Anh Tu - "Add Xen/XCP support for GRE SDN controller"
This section describes my progress with the project titled "Add Xen/XCP support for GRE SDN controller"

	Introduction
	It has been a half way of GSoC2013 journey which I am getting more familiar with its activities. Personally, the previous one-and-a-half month has surprisingly passed by in a blink with lots of pressure. In this first time joining in GSoC2013, I have found it totally new and interesting in its working methods and challenges. Along with those stressful moments, I appreciated all wonderful experiences and knowledge that I have luckily gained from this commitment. It is time to review it all and present in time order.
	
	My project named “Add Xen/XCP support for GRE SDN controller”, the proposal can be found here: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/ngtuna/1";>Proposal
	
	Specifically, I need to improve the current GRE SDN controller to work with XCP, a free version of XenServer. Then, as things I talked with my two mentor Sebastien Goasguen and Hugo, I continuously work in next missions as below:
	
	
		re-factor GRE source code by following NiciraNVP plugin design.
		add GRE support for KVM hypervisor.
		develop a new ODL plugin using Opendaylight controller for controlling and managing network services via OpenFlow protocol.
	
	At the beginning, I started to explore frameworks and tools that CloudStack uses such as Spring framework, marven, git and Reviewboard. In my country developers are more familiar with svn than git, however these tools are also such easy to use so I don't write more about them. I want to note about using Spring in CloudStack and what happen in the Management Server startup process.
	


	Spring in CloudStack
	Spring provides a Container which contains pre-loaded components CloudStack use. At startup, these components are loaded to Container via two ways:
	
	
		components are declared as beans in componentcontext.xml and applicationcontext.xml
		
			
			
			
			bean.png: Bean declaration.
		
		components are marked with @Component annotation
		
		
		
	
	component.png: Component declaration.
			
	
	As I know recently @Component is not recommended.
	The fundamental functionality provided by the Spring Container is Dependency Injection (DI). To decouple Java components from other Java components the dependency to a certain other class should get injected into them rather that the class inself creates or finds this object. The general concept between dependency injection is called Inversion of Control. A class should not configure itself but should be configured from outside. A design based on independent classes / components increases the re-usability and possibility to test the software. Example of using DI in CloudStack is showed below:
	
	
	
	
	inject.png: Injection.
		


	Management Server Startup
	The MS startup process is defined in cloud-client-ui/WEB-INF/web.xml. The following items will be loaded sequentially:
	
		Log4jConfigListener.
		ContextLoaderListener.
		CloudStartupServlet.
		ConsoleServlet.
		ApiServlet.
	
	In which, CloudStartupServlet will call to ComponentContext to init all of defined components life cycle including configure() and start() phase. The components will be loaded sequentially corresponding to

Re: Review Request 12997: usage event is not generated for volume resize

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12997/#review24031
---


Review 12997 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #60 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/60/

- Jenkins Cloudstack.org


On July 27, 2013, 3:11 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12997/
> ---
> 
> (Updated July 27, 2013, 3:11 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> issue:
> 
> when resize volume is requested and action is successfuly usage event is not 
> recorded. Code is not present for recording the resize volume usage event.
> 
> fix:
> Added the code to record the usage event when the resize volume is requested.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 
> 
> Diff: https://reviews.apache.org/r/12997/diff/
> 
> 
> Testing
> ---
> 
> Environment:
> kvm, with cluster scope storage pool.
> default centos instance.
> 
> 1. created a volume and tried to resize the volume.
> volume resize is successful
> 
> usage event is registered in usage_event table now.
> 
>   | 0 | NULL |
> | 27 | VOLUME.RESIZE   |  2 | 2013-07-27 14:54:51 |   1 | 
>  21 | TestVol  |   6 |
> NULL |  5368709120 | NULL   | 0 | NULL |
> ++-++-+-+-+--+-+-+-++---+--+
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: [GSOC][Urgent] Build docbook failed

[Nguyen Anh Tu]

Yeah it worked. Thanks Shiva!


2013/7/28 Shiva Teja 

> Change the itemizedlist in the id="Spring" to this
>
> 
> 
> components are declared as beans in componentcontext.xml
> and applicationcontext.xml
> 
> 
> 
> 
> bean.png: Bean
> declaration.
> 
> 
> 
> components are marked with @Component annotation
> 
> 
> 
> 
> component.png: Component
> declaration.
> 
> 
> 
>
> It is working.
>
>
> On Sat, Jul 27, 2013 at 10:25 PM, Nguyen Anh Tu  wrote:
>
>> Hi Shiva, I send to you my report. Please try build it.
>>
>> Thanks
>>
>>
>> 2013/7/27 Shiva Teja 
>>
>>> Oops,
>>>
>>> *paste it somewhere
>>>
>>>
>>> On Sat, Jul 27, 2013 at 10:06 PM, Shiva Teja 
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > Can you send the paste it somewhere and give a link? I can try.
>>> >
>>> >
>>> > On Sat, Jul 27, 2013 at 9:46 PM, Nguyen Anh Tu 
>>> wrote:
>>> >
>>> >> Hi guys,
>>> >>
>>> >> I build my GSoC mid-term review and get an error here:
>>> >>
>>> >> Validation failed:
>>> >> CloudStack_GSoC_Guide.xml:67: validity error : Element itemizedlist
>>> >> content
>>> >> does not follow the DTD, expecting (blockinfo? , (title ,
>>> titleabbrev?)? ,
>>> >> (caution | important | note | tip | warning | literallayout |
>>> >> programlisting | programlistingco | screen | screenco | screenshot |
>>> >> synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis
>>> |
>>> >> constructorsynopsis | destructorsynopsis | methodsynopsis |
>>> formalpara |
>>> >> para | simpara | address | blockquote | graphic | graphicco |
>>> mediaobject
>>> >> |
>>> >> mediaobjectco | informalequation | informalexample | informalfigure |
>>> >> informaltable | anchor | bridgehead | remark | highlights | abstract |
>>> >> authorblurb | epigraph | indexterm | beginpage)* , listitem+), got
>>> >> (listitem mediaobject listitem mediaobject )
>>> >>
>>> >> Sound like I use  in wrong way. But I don't know what
>>> >> exactly
>>> >> causes the error.
>>> >>
>>> >> Urgent. Anyone can help? Thank so much!
>>> >>
>>> >> --
>>> >>
>>> >> N.g.U.y.e.N.A.n.H.t.U
>>> >>
>>> >
>>> >
>>>
>>
>>
>>
>> --
>>
>> N.g.U.y.e.N.A.n.H.t.U
>>
>
>


-- 

N.g.U.y.e.N.A.n.H.t.U

Re: Review Request 12996: Unable to Resize Volume (kvm, vmware)

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/#review24034
---


Review 12996 PASSED the build test
The url of build cloudstack-master-with-patch #61 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/61/

- Jenkins Cloudstack.org


On July 27, 2013, 3:05 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12996/
> ---
> 
> (Updated July 27, 2013, 3:05 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram 
> Ganesh.
> 
> 
> Bugs: 3877
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> =
> this issue is with the way we extract the hypevisor type from the sql 
> 
> 
> mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, 
> cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
> ++-+
> | hypervisor | hypervisor_type |
> ++-+
> | NULL | KVM |
> ++-+
> 
> 
> first column value will be not null if the storage pool is Zone wide else it 
> will be NULL. 
> but in the code always first column is considering to figure out the 
> hypervisor type which causing the hpervisor type to be NONE and hence failing 
> to resize the volume
> 
> 
> this issue is happening while determining the hypervisor type for a volume. 
> for ZWPS, it will return the hypervisor because, in storage pool we store the 
> hypervisor type if the pool is added of scoe ZONE. 
> if the pool is of scope Cluster hypervisor type will be NULL
> 
> we support volume resize when the volume is present on ZONE scope and Cluster 
> scope. 
> they way of hypervisor type extraction from the sql query result should be 
> change which will resolve this blocker.
> 
> 
> Fix:
> =
> 
> depending on the scope type of storage pool, the sql result is passed to 
> determined the hypervisor type.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 
> 
> Diff: https://reviews.apache.org/r/12996/diff/
> 
> 
> Testing
> ---
> 
> 1. Able to resize the volume successfully
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

[Wido den Hollander]

+1 (binding)

I've upgraded a couple of internal systems and even production systems 
to 4.1.1


We were facing a couple of bugs in production which lead me to deploy a 
homebrew version of 4.1.1 in our company. The only change is a very 
small change in the security groups script for something in our env, not 
applicable to any other setup.


So I've tested 4.1.1 on our production Ubuntu 12.04 clusters.

I have to note though that we run a patched version of libvirt due to 
this issue: https://bugzilla.redhat.com/show_bug.cgi?id=977706


Building goes fine on my systems and it runs without issues for us on a 
large scale KVM deployment.


Wido

On 07/25/2013 08:04 PM, Musayev, Ilya wrote:

Hi All,

I've created a 4.1.1 release, with the following artifacts up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
Commit: d2c646f0a434831bd5aef88b5692c108fe26e718

Release notes:

http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23/


Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.1/

PGP release keys (signed using B7B5E7FD):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

d2c646f0a434831bd5aef88b5692c108fe26e718

Re: Review Request 12658: Corrected typos in log messages

[Wido den Hollander]

On 07/26/2013 11:41 PM, Animesh Chaturvedi wrote:

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12658/


On July 18th, 2013, 9:48 a.m. UTC, *Wido den Hollander* wrote:

Ship It!

Wido did you commit the patch? If so this needs to be closed out




So how do I close it? I don't see an option for that. Could it be that I 
don't have the correct permissions to do so?


Wido


- Animesh


On July 18th, 2013, 4:07 p.m. UTC, Rene Diepstraten wrote:

Review request for cloudstack and Wido den Hollander.
By Rene Diepstraten.

/Updated July 18, 2013, 4:07 p.m./

*Repository: * cloudstack-git


  Description

Corrected typos in log messages


  Testing

These are only log messages and should not change how the code works.


  Diffs

  * scripts/vm/network/security_group.py (044747a)

View Diff 

Review Request 12999: [GSoC] Add mid-term report

[tuna]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12999/
---

Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.


Repository: cloudstack-git


Description
---

I add the mid-term report for my GSoC project


Diffs
-

  docs/en-US/gsoc-midsummer-nguyen.xml 96c2de1 
  docs/en-US/images/bean.png PRE-CREATION 
  docs/en-US/images/canhandle.png PRE-CREATION 
  docs/en-US/images/canhandledetail.png PRE-CREATION 
  docs/en-US/images/component.png PRE-CREATION 
  docs/en-US/images/configure_phase.png PRE-CREATION 
  docs/en-US/images/getlabel.png PRE-CREATION 
  docs/en-US/images/inject.png PRE-CREATION 
  docs/en-US/images/l3_services.png PRE-CREATION 
  docs/en-US/images/level.png PRE-CREATION 
  docs/en-US/images/network_service.png PRE-CREATION 
  docs/en-US/images/odl_structure.jpg PRE-CREATION 
  docs/en-US/images/starting_phase.png PRE-CREATION 

Diff: https://reviews.apache.org/r/12999/diff/


Testing
---

Built successfully with publican.


Thanks,

tuna

Re: Dev Help: How to create scheduled tasks in ACS

[Ian Duffy]

Hi Alex,

Will definitely look into it. These messages were just for research
purposes, not looking to implement it for another month.

Thanks,
Ian

On 27 July 2013 16:30, Alex Huang  wrote:
> Hi Ian,
>
> You might want to develop against vmsync branch for now, if you don't mind.  
> We intend to bring the job queue work there over to master.  I've been 
> bringing vmsync over piece meal to master but haven't gotten to the job part 
> yet.
>
> In the vmsync branch, what you'll find is that we've isolated the asyncjob 
> code into the framework-jobs project.  We also scrubbed the AsyncJobManager 
> interface so that we removed all traces of api commands from it.  Now you 
> basically create an asyncjobVO with a dispatcher and it gets scheduled.  When 
> the job runs, the dispatcher gets notified of the job and the job content is 
> sent to the dispatcher.  You can find two dispatchers already.  One is 
> ApiAysncJobDispatcher and the other is the VmWorkJobDispatcher.
>
> Take a look.  Let me know if I can help you out with anything.
>
> --Alex
>
>> -Original Message-
>> From: Ian Duffy [mailto:i...@ianduffy.ie]
>> Sent: Friday, July 26, 2013 2:48 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: Dev Help: How to create scheduled tasks in ACS
>>
>> > Are you looking for something in < 4.2?  Kelven did a great job abstracting
>> out the entire job framework in vmsync, which he'll merge into > master
>> soon.  I can give examples of both but it may be easier for Ian if it's in 
>> master.
>>
>> Hi Alex,
>>
>> Its for master :-)
>>
>> On 26 July 2013 22:34, Alex Huang  wrote:
>> > Ilya,
>> >
>> > Are you looking for something in < 4.2?  Kelven did a great job abstracting
>> out the entire job framework in vmsync, which he'll merge into master soon.
>> I can give examples of both but it may be easier for Ian if it's in master.
>> >
>> > --Alex
>> >
>> >> -Original Message-
>> >> From: Musayev, Ilya [mailto:imusa...@webmd.net]
>> >> Sent: Friday, July 26, 2013 1:48 PM
>> >> To: dev@cloudstack.apache.org
>> >> Subject: RE: Dev Help: How to create scheduled tasks in ACS
>> >>
>> >> Donal,
>> >>
>> >> My apology as I was not clear, we need inner Java example currently
>> >> used by ACS.
>> >>
>> >> External would be the very worst case, i would personally consider
>> >> least desired.
>> >>
>> >> Thanks
>> >> ilya
>> >>
>> >> > -Original Message-
>> >> > From: Ian Duffy [mailto:i...@ianduffy.ie]
>> >> > Sent: Friday, July 26, 2013 4:41 PM
>> >> > To: dev@cloudstack.apache.org
>> >> > Subject: Re: Dev Help: How to create scheduled tasks in ACS
>> >> >
>> >> > Hi Donal,
>> >> >
>> >> > Thats neat, not sure one would want to rely on a external task to
>> >> > kick it off though.
>> >> >
>> >> > Something that is integrated within the Cloudstack lifecycle would
>> >> > be preferred.
>> >> >
>> >> > Thanks.
>> >

RE: Review Request 12658: Corrected typos in log messages

[Animesh Chaturvedi]

The submitter should close it out once the patch is approved and checked-in. 
The reviewer cannot close the patch unless they have admin privileges. If you 
want admin privileges you can open a ticket with Infra.

> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Saturday, July 27, 2013 11:16 AM
> To: Animesh Chaturvedi
> Cc: cloudstack; Rene Diepstraten
> Subject: Re: Review Request 12658: Corrected typos in log messages
> 
> On 07/26/2013 11:41 PM, Animesh Chaturvedi wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/12658/
> >
> >
> > On July 18th, 2013, 9:48 a.m. UTC, *Wido den Hollander* wrote:
> >
> > Ship It!
> >
> > Wido did you commit the patch? If so this needs to be closed out
> >
> >
> 
> So how do I close it? I don't see an option for that. Could it be that I
> don't have the correct permissions to do so?
> 
> Wido
> 
> > - Animesh
> >
> >
> > On July 18th, 2013, 4:07 p.m. UTC, Rene Diepstraten wrote:
> >
> > Review request for cloudstack and Wido den Hollander.
> > By Rene Diepstraten.
> >
> > /Updated July 18, 2013, 4:07 p.m./
> >
> > *Repository: * cloudstack-git
> >
> >
> >   Description
> >
> > Corrected typos in log messages
> >
> >
> >   Testing
> >
> > These are only log messages and should not change how the code works.
> >
> >
> >   Diffs
> >
> >   * scripts/vm/network/security_group.py (044747a)
> >
> > View Diff 
> >

Re: [VOTE] Apache Cloudstack 4.1.1 (Second Round)

[Ove Ewerlid]

-1

Details;
   https://issues.apache.org/jira/browse/CLOUDSTACK-3880

RHEL6 specific; risk for database corruption if MGR is shutdown via 
anything that changes runlevel resulting in use of 
cloudstack-management, cloudstack-usage stop() targets (e.g., 
/sbin/shutdown, "telinit 1", ACPID initiated poweroff, etc).


/Ove


On 07/25/2013 08:04 PM, Musayev, Ilya wrote:

Hi All,

I've created a 4.1.1 release, with the following artifacts up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
Commit: d2c646f0a434831bd5aef88b5692c108fe26e718

Release notes:

http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23/


Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.1/

PGP release keys (signed using B7B5E7FD):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

d2c646f0a434831bd5aef88b5692c108fe26e718




--
Ove Everlid
System Administrator / Architect / SDN & Linux hacker
Mobile: +46706662363
Office: +4618656913 (note EMEA Time Zone)

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review24036
---



server/src/com/cloud/template/HypervisorTemplateAdapter.java


Min, I have created a new patch addressing all the concerns, also removed 
extra checks.


- Saksham Srivastava


On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 27, 2013, 6:58 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---+-+-+--+---+---+--+
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/
---

(Updated July 27, 2013, 6:58 p.m.)


Review request for cloudstack and Min Chen.


Changes
---

Updated diff rebased against latest.


Bugs: 3686


Repository: cloudstack-git


Description
---

Registering a template does not generate a usage event.
The process should generate a usage event when the template is 100% downloaded.
Added a new usage event that has virtual_size also as a parameter.


Diffs (updated)
-

  engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
  engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
  server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 

Diff: https://reviews.apache.org/r/12968/diff/


Testing
---

Now usage_event table is getting updated with the new usage_event.

 select * from usage_event where id = 23;
++-++-+-+-+---+-+-+--+---+---+--+
| id | type| account_id | created | zone_id | 
resource_id | resource_name | offering_id | template_id | size | 
resource_type | processed | virtual_size |
++-++-+-+-+---+-+-+--+---+---+--+
| 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
215 | r8|NULL |NULL | 1628 | NULL  |
 0 | 16777216 |
++-++-+-+-+---+-+-+--+---+---+--+


Build passed.
Patch applies cleanly.


Thanks,

Saksham Srivastava

Re: Review Request 12976: Remove duplicate row from guest_os table

[Amogh Vasekar]

> On July 26, 2013, 11:51 p.m., Alena Prokharchyk wrote:
> > We can't just remove the row w/o making sure its not being referenced by 
> > existing resources. So putting "DELETE IGNORE FROM `cloud`.`guest_os` where 
> > id=206" is not enough. You can go 2 ways:
> > 
> > #1 - don't insert the record to the DB if it already exists (if upgraded 
> > from 3.0.x) during 41-42 upgrade.
> > 
> > #2 - transfer all the records referencing guest os id=206, to use the 
> > guest_os inserted as a part of 41-42 upgrade.

Thanks Alena for reviewing.

The understanding was that the row with id=206 was not being referenced 
elsewhere. Nonetheless, I have added UPDATE statements for tables that might 
reference guest_os.id directly.

#1 wasnt feasible since the new row is being referenced directly with the new 
id in guest_os_hypervisor table.


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review23996
---


On July 26, 2013, 6:22 p.m., Amogh Vasekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12976/
> ---
> 
> (Updated July 26, 2013, 6:22 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
> Bhamidipati.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Remove duplicate row (id=206) from table guest_os.
> Decided to remove instead of checking for duplicates on insertion since :
> 1. The new row is referenced by id=166 elsewhere in the DB
> 2. Old row with id=206 is not referenced in DB 
> 
> 
> Diffs
> -
> 
>   setup/db/db/schema-410to420.sql 82ca403 
> 
> Diff: https://reviews.apache.org/r/12976/diff/
> 
> 
> Testing
> ---
> 
> Local environment
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>

Re: Review Request 12976: Remove duplicate row from guest_os table

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
---

(Updated July 27, 2013, 7:21 p.m.)


Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
Bhamidipati.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647


Repository: cloudstack-git


Description
---

Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB 


Diffs (updated)
-

  setup/db/db/schema-410to420.sql 82ca403 
  setup/db/db/schema-410to420.sql 82ca403 

Diff: https://reviews.apache.org/r/12976/diff/


Testing
---

Local environment


Thanks,

Amogh Vasekar

Re: Review Request 12976: Remove duplicate row from guest_os table

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
---

(Updated July 27, 2013, 7:22 p.m.)


Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
Bhamidipati.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647


Repository: cloudstack-git


Description
---

Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB 


Diffs
-

  setup/db/db/schema-410to420.sql 82ca403 
  setup/db/db/schema-410to420.sql 82ca403 

Diff: https://reviews.apache.org/r/12976/diff/


Testing
---

Local environment


Thanks,

Amogh Vasekar

Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---

Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Adding test cases for CPU limits from Limit Resources.
Marvin changes have to be picked up from Memory Limits patch 
(https://reviews.apache.org/r/11626/). Those are not included in this patch.


Diffs
-

  test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13001/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review24039
---


Review 13001 PASSED the build test
The url of build cloudstack-master-with-patch #62 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/62/

- Jenkins Cloudstack.org


On July 27, 2013, 7:49 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13001/
> ---
> 
> (Updated July 27, 2013, 7:49 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test cases for CPU limits from Limit Resources.
> Marvin changes have to be picked up from Memory Limits patch 
> (https://reviews.apache.org/r/11626/). Those are not included in this patch.
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION 
>   test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13001/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Review Request 13003: Adding packaging support for RHEL 5 and 6.2

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13003/
---

Review request for cloudstack, edison su, Frank Zhang, Hugo Trippaers, and Wido 
den Hollander.


Repository: cloudstack-git


Description
---

There are hard coded values for python version in cloud.spec;  it need to be 
generic to support RHEL 5, since RHEL 5  having Python 2.4 not 2.6


Packaging.sh updated to support RHEL 6.2 and 5,  

RPM  build failing rhel6.2 and 5, since -D_topdir pointing to 
/usr/src/redhat/SOURCES; fixed this also 


Diffs
-

  packaging/centos63/cloud.spec 61e00bd 
  packaging/centos63/package.sh c466f58 

Diff: https://reviews.apache.org/r/13003/diff/


Testing
---

Tested with RHEL 6.3 and RHEL 5.4


Thanks,

Rayees Namathponnan

RE: CloudStack 4.2 – Build and Packaging on RHEL 5.4

[Rayees Namathponnan]

Submitted patch to support RHEL 5 and 6.2 packaging; someone  please review 
this ? 

https://reviews.apache.org/r/13003/ 


Also I think we can change the packaging folder name form 
"cloudstack/packaging/centos63"  to "cloudstack/packaging/centos"; after the 
merge.


Regards,
Rayees 

-Original Message-
From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com] 
Sent: Friday, July 26, 2013 11:14 AM
To: dev@cloudstack.apache.org
Subject: RE: CloudStack 4.2 – Build and Packaging on RHEL 5.4

There are some hardcoded python version (Python2.6)  in cloud.spec file;  

it should be get from environment variable or get from build machines Python 
version; then only we can support RHEL 5 packaging, since RHEL 5 using Python 
2.4.

Regard,
Rayees 


-Original Message-
From: Hugo Trippaers [mailto:trip...@gmail.com]
Sent: Monday, July 22, 2013 10:09 PM
To: dev@cloudstack.apache.org
Subject: Re: CloudStack 4.2 – Build and Packaging on RHEL 5.4

If i remember correctly these directories are not automagically created on 
redhat 5.x systems.

You need to use the default location in the var directory probably so you need 
to make some changes to the package script to deal with that.

Cheers,

Hugo

Sent from my iPhone

On 23 jul. 2013, at 05:24, Rayees Namathponnan  
wrote:

> Hi All,
> 
> I am trying to create  4.2  build and  then package on RHEL 5.4, 
> initially  faced some issue with RPM “topdir”,  fixed those issue in 
> local machine (changes are below)
> 
> 
> mkdir -p $RPMDIR/SPECS
> +mkdir -p $RPMDIR/BUILD
> mkdir -p $RPMDIR/SOURCES/$PACK_PROJECT-$VERSION
> 
> (cd ../../; tar -c --exclude .git --exclude dist  .  | tar -C 
> $RPMDIR/SOURCES/$PACK_PROJECT-$VERSION -x ) @@ -55,7 +56,7 @@ mkdir -p 
> $RPMDIR/SOURCES/$PACK_PROJECT-$VERSION
> cp cloud.spec $RPMDIR/SPECS
> -(cd $RPMDIR; rpmbuild -ba SPECS/cloud.spec "-D_topdir $RPMDIR" 
> "$DEFVER" "$DEFREL" "$DEFPRE")
> +(cd $RPMDIR; rpmbuild --define "_topdir $RPMDIR" "$DEFVER" "$DEFREL" 
> +"$DEFPRE" -ba SPECS/cloud.spec)
> exit
> }
> 
> 
> After fixing this, I am able to start the build; unfortunately build 
> getting failed during packaging; observed below error
> 
> 
> Requires(interp): /bin/sh
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) 
> <= 3.0.3-1
> Requires(pre): /bin/sh
> Requires: /bin/bash /usr/bin/python cloudstack-management = 4.2.0
> Obsoletes: cloud-aws-api < 4.1.0
> Checking for unpackaged file(s): /usr/lib/rpm/check-files 
> /var/tmp/cloudstack-4.2.0-SNAPSHOT-SNAPSHOT.el5-build
> error: Could not open
> /root/jenkins/build/workspace/X-4.2-rhel5/XX/cloudstack/dist/r
> pmbuild/SRPMS/cloudstack-4.2.0-SNAPSHOT.el5.src.rpm: No such file or 
> directory
> cp: cannot stat
> `/root/jenkins/build/workspace/XX-4.2-rhel5/XX/cloudstack/dist
> /rpmbuild/RPMS/x86_64/*.rpm': No such file or directory
> 
> 
> Here build unable to find 
> “SRPMS/cloudstack-4.2.0-SNAPSHOT.el5.src.rpm”; I physically checked on 
> the build path;  I cannot the folder “RPMS and SRPMS” under … 
> cloudstack/dist/rpmbuild;
> 
> Any idea about this ?
> 
> 
> Regards,
> Rayees
> 

Re: Review Request 13003: Adding packaging support for RHEL 5 and 6.2

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13003/#review24047
---


Review 13003 PASSED the build test
The url of build cloudstack-master-with-patch #63 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/63/

- Jenkins Cloudstack.org


On July 28, 2013, 1:14 a.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13003/
> ---
> 
> (Updated July 28, 2013, 1:14 a.m.)
> 
> 
> Review request for cloudstack, edison su, Frank Zhang, Hugo Trippaers, and 
> Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> There are hard coded values for python version in cloud.spec;  it need to be 
> generic to support RHEL 5, since RHEL 5  having Python 2.4 not 2.6
> 
> 
> Packaging.sh updated to support RHEL 6.2 and 5,  
> 
> RPM  build failing rhel6.2 and 5, since -D_topdir pointing to 
> /usr/src/redhat/SOURCES; fixed this also 
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
>   packaging/centos63/package.sh c466f58 
> 
> Diff: https://reviews.apache.org/r/13003/diff/
> 
> 
> Testing
> ---
> 
> Tested with RHEL 6.3 and RHEL 5.4
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

[Min Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/#review24049
---



server/src/com/cloud/template/HypervisorTemplateAdapter.java


How can you guarantee that listSrcTmpltStore.get(0) is the entry you 
desire? You should find that exact (templateId, storeId) entry by passing both 
templateId and storeId, which should be able to be obtained from 
template.getDataStore().getId().



server/src/com/cloud/template/HypervisorTemplateAdapter.java


Why cannot you provide a method in UsageEventDao to search by template id 
and event type? This way, you don't need to find a bigger set and filter here 
by looping.



server/src/com/cloud/template/HypervisorTemplateAdapter.java


This is not right. For cross-zone template, in 
HypervisorTemplateAdapter.create(TemplateProfile) method, you will see that 
there is a for-loop to download the template to each image store for each zone. 
For each image store, this createTemplateAsyncCallback will be invoked. So in 
this callback, you should just generate usage event for this zone.


- Min Chen


On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12968/
> ---
> 
> (Updated July 27, 2013, 6:58 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Bugs: 3686
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Registering a template does not generate a usage event.
> The process should generate a usage event when the template is 100% 
> downloaded.
> Added a new usage event that has virtual_size also as a parameter.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 
> 
> Diff: https://reviews.apache.org/r/12968/diff/
> 
> 
> Testing
> ---
> 
> Now usage_event table is getting updated with the new usage_event.
> 
>  select * from usage_event where id = 23;
> ++-++-+-+-+---+-+-+--+---+---+--+
> | id | type| account_id | created | zone_id | 
> resource_id | resource_name | offering_id | template_id | size | 
> resource_type | processed | virtual_size |
> ++-++-+-+-+---+-+-+--+---+---+--+
> | 23 | TEMPLATE.CREATE |  2 | 2013-07-26 12:04:29 |   0 | 
> 215 | r8|NULL |NULL | 1628 | NULL  |  
>0 | 16777216 |
> ++-++-+-+-+---+-+-+--+---+---+--+
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method

[Marcus Sorensen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12972/
---

(Updated July 28, 2013, 4:39 a.m.)


Review request for cloudstack, Prasanna Santhanam and Sheng Yang.


Changes
---

Thanks so much for testing. Here's a new diff, this one should be ready to 
apply as an all-in-one that addresses some of your comments and cleans up the 
old vm_data stuff. 

Changes:

* Moved vmdata_kvm.py to vmdata.py, changed script name in 
VirtualRoutingResource and CitrixResourceBase accordingly
* Cleaned up vm_data from the vmops python scripts (I hope I did this correctly)
* Removed vm_data.sh again
* Removed references to vm_data.sh in xenserver patch scripts (I assume these 
copy the scripts to xenserver hosts)

I left the print statements alone for now, I'm not sure of the availability of 
utils.SMLog within the virtual router or compatibility with KVM.


Bugs: CLOUDSTACK-3163


Repository: cloudstack-git


Description
---

Update CitrixResourceBase to use new vmdata programming method, removing dozens 
of ssh/scp calls on router and vm startup. This will get rid of vm_data.sh.


Diffs (updated)
-

  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
e5f922d 
  patches/systemvm/debian/config/opt/cloud/bin/vmdata.py PRE-CREATION 
  patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py f508032 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 7f8bb3e 
  scripts/network/domr/vm_data.sh c861723 
  scripts/vm/hypervisor/xenserver/vmops 9a0ef44 
  scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 
  scripts/vm/hypervisor/xenserver/xcposs/vmops 52625e1 
  scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de 
  scripts/vm/hypervisor/xenserver/xenserver60/patch d7da374 

Diff: https://reviews.apache.org/r/12972/diff/


Testing
---

None, please test.


Thanks,

Marcus Sorensen

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[Abhinandan Prateek]

> On July 24, 2013, 10:56 p.m., Alena Prokharchyk wrote:
> > 1) Bharat, can you please check if your API allows you to set the vnet 
> > range with the multiple ranges. The command syntax should be like this - 
> > vnets should be specified and separated by comma:
> > 
> > http://localhost:8096/?command=updatePhysicalNetwork&id=200&vlan=2001-2010,2012-2013
> > 
> > 2) Also I find it very confusing that you are continuing to store the vnet 
> > field in physical_network table. Once the ranges were introduced, you 
> > should have moved them to the separate data structure as its very hard to 
> > update/validate the String representation as every single time you have to
> > 
> > * split the ranges
> > * validate each range against the new range you pass in

Alena,
  Yes that code was confusing earlier. Now with set operations it is much 
cleaner.


- Abhinandan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review23793
---


On July 26, 2013, 4:17 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 26, 2013, 4:17 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>