svn commit: r572565 - /ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml

[peterreilly]

Author: peterreilly
Date: Tue Sep  4 00:51:08 2007
New Revision: 572565

URL: http://svn.apache.org/viewvc?rev=572565&view=rev
Log:
opps

Modified:
ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml

Modified: ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml?rev=572565&r1=572564&r2=572565&view=diff
==
--- ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml 
(original)
+++ ant/core/trunk/src/etc/testcases/taskdefs/conditions/antversion.xml Tue Sep 
 4 00:51:08 2007
@@ -17,10 +17,10 @@



-   


Should be exactly 1.8.0
+


 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project dotnet-antlib-test (in module ant-antlibs) failed

[Gump Integration Build]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project dotnet-antlib-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 157 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- dotnet-antlib-test :  Task and Type Libraries for Apache Ant


Full details are available at:

http://vmgump.apache.org/gump/public/ant-antlibs/dotnet-antlib-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant-antlibs/dotnet-antlib-test/gump_work/build_ant-antlibs_dotnet-antlib-test.html
Work Name: build_ant-antlibs_dotnet-antlib-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Dant-testutil.jar=/srv/gump/public/workspace/ant/build/lib/ant-testutil.jar 
test 
[Working Directory: /srv/gump/public/workspace/ant-antlibs/dotnet]
CLASSPATH: 
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/ant-antlibs/dotnet/build/test-classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant-antlibs/antunit/build/ant-antunit-04092007.jar:/srv/gump/public/workspace/ant-antlibs/dotnet/build/ant-dotnet-04092007.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar
-
[au:antunit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.109 sec
[au:antunit] Target: test-passing took 0.005 sec
[au:antunit] Build File: 
/srv/gump/public/workspace/ant-antlibs/dotnet/src/tests/antunit/dir with 
spaces/wsdl-test.xml
[au:antunit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.958 sec
[au:antunit] Target: testWSDL took 0.926 sec
[au:antunit] Build File: 
/srv/gump/public/workspace/ant-antlibs/dotnet/src/tests/antunit/dotnetexec-test.xml
[au:antunit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.655 sec
[au:antunit] Target: testCSC took 0.608 sec
[au:antunit] Build File: 
/srv/gump/public/workspace/ant-antlibs/dotnet/src/tests/antunit/nunit/nunit-test.xml
[au:antunit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.224 sec
[au:antunit] Target: test-passing took 0.004 sec
[au:antunit] Target: test-failing took 0.006 sec
[au:antunit] Target: test-failing-errorproperty took 0.085 sec
[au:antunit] Target: test-failing-with-fail took 0.005 sec
[au:antunit] Target: test-no-assembly took 0.012 sec
[au:antunit] Build File: 
/srv/gump/public/workspace/ant-antlibs/dotnet/src/tests/antunit/old-core-test.xml
[au:antunit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 4.738 sec
[au:antunit] Target: testCSCintrinsicFileset took 0.723 sec
[au:antunit] Target: testCSCresponseFile took 0.528 sec
[au:antunit] Target: testILASM took 0.583 sec
[au:antunit] Target: testCSCdll took 0.576 sec
[au:antunit] Target: testILDASM took 0.609 sec
[au:antunit] Target: testILDASM_empty took 0.041 sec
[au:antunit] Target: testJsharp took 0.048 sec
[au:antunit] Target: testCSCResources took 0.583 sec
[au:antunit] Target: testCSC took 0.656 sec
[au:antunit] Build File: 
/srv/gump/public/workspace/ant-antlibs/dotnet/src/tests/antunit/wsdl2dotnet-test.xml
[au:antunit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 4.062 sec
[au:antunit] Target: testSchemaMustBeSet took 0.091 sec
[au:antunit] Target: testLocalWsdlVB took 0.029 sec
[au:antunit] Target: testInvalidExtraOps took 0.017 sec
[au:antunit] Target: testSrcIsMissing took 0.018 sec
[au:antunit] Target: testNoParams took 0.022 sec
[au:antunit] Target: testBothSrc took 0.014 sec
[au:antunit] Target: testSchemaFileMustHaveOneOptionOnly took 0.021 sec
[au:antunit] Target: testLocalWsdl took 1.349 sec
[au:antunit] Target: testSrcIsDir took 0.03 sec
[au:antunit] Target: testLocalWsdlServerVB took 0.014 sec
[au:antunit] Target: testLocalWsdlServer took 2.074 sec
[au:antunit] Target: testNoSrc took 0.105 sec
[au:antunit] Target: testSc

[EMAIL PROTECTED]: Project svn-antlib-test (in module ant-antlibs) failed

[Gump Integration Build]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project svn-antlib-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 157 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- svn-antlib-test :  Task and Type Libraries for Apache Ant


Full details are available at:
http://vmgump.apache.org/gump/public/ant-antlibs/svn-antlib-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant-testutil exists, no need to add for property 
ant-testutil.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant-antlibs/svn-antlib-test/gump_work/build_ant-antlibs_svn-antlib-test.html
Work Name: build_ant-antlibs_svn-antlib-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 4 mins 25 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Dant-testutil.jar=/srv/gump/public/workspace/ant/build/lib/ant-testutil.jar 
test 
[Working Directory: /srv/gump/public/workspace/ant-antlibs/svn]
CLASSPATH: 
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/ant-antlibs/svn/build/test-classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/build/lib/ant-testutil.jar:/srv/gump/public/workspace/junit/dist/junit-04092007.jar:/srv/gump/public/workspace/ant-antlibs/svn/build/ant-svn-04092007.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar
-
[junit] at junit.framework.TestSuite.run(TestSuite.java:227)
[junit] at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:80)
[junit] at 
junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:743)
[junit] 
[junit] Testcase: testDiffWithImplicitTrunk took 85.052 sec
[junit] FAILED
[junit] null
[junit] junit.framework.AssertionFailedError: null
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.assertTrue(Assert.java:20)
[junit] at junit.framework.Assert.assertTrue(Assert.java:27)
[junit] at 
org.apache.ant.svn.SvnTagDiffTest.assertModified(SvnTagDiffTest.java:110)
[junit] at 
org.apache.ant.svn.SvnTagDiffTest.assertDiffWithTrunk(SvnTagDiffTest.java:63)
[junit] at 
org.apache.ant.svn.SvnTagDiffTest.testDiffWithImplicitTrunk(SvnTagDiffTest.java:57)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[junit] at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[junit] at java.lang.reflect.Method.invoke(Method.java:585)
[junit] at junit.framework.TestCase.runTest(TestCase.java:168)
[junit] at junit.framework.TestCase.runBare(TestCase.java:134)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:110)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:128)
[junit] at junit.framework.TestResult.run(TestResult.java:113)
[junit] at junit.framework.TestCase.run(TestCase.java:124)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:232)
[junit] at junit.framework.TestSuite.run(TestSuite.java:227)
[junit] at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:80)
[junit] at 
junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTe

DO NOT REPLY [Bug 36955] - Path reference in a target, which is not executed, is set anyway.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36955


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 01:55 ---
Despite the claim to the contrary in file WHATSNEW, this bug is NOT fixed in
version 1.7.0.

This is what WHATSNEW says:

* Defer reference process. Bugzilla 36955, 34458, 37688.
  This may break build files in which a reference was set in a target which was
never executed. Historically, Ant would set the reference early on, during parse
time, so the datatype would be defined. Now it requires the reference to have
been in a bit of the build file which was actually executed. If you get an error
about an undefined reference, locate the reference and move it somewhere where
it is used, or fix the depends attribute of the target in question to depend on
the target which defines the reference/datatype.

---

Here is a test script to prove the point:















---

Here are the results from the test:

C:\work>ant -f test_build.xml
Buildfile: test_build.xml
 [echo] Apache Ant version 1.7.0 compiled on December 13 2006

test:
Warning: Reference test.path has not been set at runtime, but was found during
build file parsing, attempting to resolve. Future versions of Ant may support 
referencing ids defined in non-executed targets.
 [echo] test.path setting = true

BUILD SUCCESSFUL
Total time: 0 seconds
C:\work>

If the fix was in place I would expect "[echo] test.path setting = false".

---

Further info - comment in reply posted to '[EMAIL PROTECTED]':

I've just tested this with svn trunk compiled today (1.7.1alpha) and I get the
same behaviour - an 'unexecuted' target containing the ref and an executed
target using the ref and the ref set:

[EMAIL PROTECTED]:~/workspace/ant-core-trunk$ ant -f test-id.xml
Buildfile: test-id.xml
 [echo] Apache Ant version 1.7.1alpha compiled on August 30 2007

test:
Warning: Reference test.path has not been set at runtime, but was found during
build file parsing, attempting to resolve. Future versions of Ant may support 
referencing ids defined in non-executed targets.
 [echo] test.path setting = true

BUILD SUCCESSFUL
Total time: 0 seconds
[EMAIL PROTECTED]:~/workspace/ant-core-trunk$

---

Further info - another comment in reply posted to '[EMAIL PROTECTED]':

The behavior as described in the WHATSNEW is what was initially was done.
However this broke too many builds - with references to out-of-band ids. So the
code was modified to store all the out-of-band ids and if the reference could
not be found, to look up that and if found to use that reference and to output a
long message.

In ant 1.8.0, this out-of-band resolution will probably be removed. One could
change the  implementation to report false for out-of-band
references, but I do not think that is a good idea.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36955] - Path reference in a target, which is not executed, is set anyway.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36955


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED
   Target Milestone|1.7.0   |1.8.0




--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 02:03 ---
Hi, I have updated the WHATSNEW to specify
there is a out-of-band reference resolution in
ant 1.7.*.
When this was first put in, there were too many
ant build scripts written by ant developers that
used out-of-band reference resolution by accident
(including a number in the ant test set), so it
was felt that it would be too big a jump to make the
change in ant 1.7.*.

I have modifed ant 1.8.0alpha to disallow out-of-band
reference resolution.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36955] - Path reference in a target, which is not executed, is set anyway.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36955





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 02:26 ---
I worry that blocking OOB resolution, even in Ant1.8, will cause problems. It
stops you being able to build old build files, which makes it near-impossible to
check out and build old stuff. 

if it is to be done, then it has to be optional

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43301] New: - [Patch] Note about java.lang.OutOfMemoryError in junit

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43301

   Summary: [Patch] Note about java.lang.OutOfMemoryError in junit
   Product: Ant
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]


I encountered lots of 
Exception in thread "main" java.lang.OutOfMemoryError: Java heap space

when testing my junit test with ant.

The solution was to raise the maxmemory of the forked junit vm. The patch is
just a note about it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43301] - [Patch] Note about java.lang.OutOfMemoryError in junit

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43301





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 03:05 ---
Created an attachment (id=20763)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20763&action=view)
docu patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43004] - OutOfMemory caused by System.out when running simple JUnit test in .

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43004





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 03:06 ---
If you get java.lang.OutOfMemoryError: Java heap space  in some of your tests
then you need to raise the heaps size like maxmemory="128m".

Can you try?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36955] - Path reference in a target, which is not executed, is set anyway.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36955





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 03:16 ---
Perhaps we could have a command line option to enable oob reference
to allow old build scripts to work.

I would rather not enable this by default, one does get silly
results with OOB reference resolution.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r572616 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java

[peterreilly]

Author: peterreilly
Date: Tue Sep  4 04:06:15 2007
New Revision: 572616

URL: http://svn.apache.org/viewvc?rev=572616&view=rev
Log:
checkstyle

Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java?rev=572616&r1=572615&r2=572616&view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Touch.java Tue Sep  4 
04:06:15 2007
@@ -270,7 +270,7 @@
 
 /**
  * Execute the touch operation.
- * 
+ *
  * @throws BuildException
  * if an error occurs.
  */
@@ -344,7 +344,7 @@
 String[] mapped = fileNameMapper.mapFileName(r.getName());
 if (mapped != null && mapped.length > 0) {
 long modTime = defaultTimestamp;
-if (millis < 0 && r.isExists()){
+if (millis < 0 && r.isExists()) {
 modTime = r.getLastModified();
 }
 for (int i = 0; i < mapped.length; i++) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project test-ant (in module ant) failed

[Gump Integration Build]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project test-ant has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- test-ant :  Java based build tool


Full details are available at:
http://vmgump.apache.org/gump/public/ant/test-ant/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant/test-ant/gump_work/build_ant_test-ant.html
Work Name: build_ant_test-ant (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 mins 56 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dtest.haltonfailure=false 
-Dant.home=/srv/gump/public/workspace/ant/dist run-tests 
[Working Directory: /srv/gump/public/workspace/ant]
CLASSPATH: 
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/ant/build/testcases:/srv/gump/public/workspace/ant/src/tests/junit:/srv/gump/public/workspace/ant/src/etc/testcases:/srv/gump/public/workspace/ant/build/lib/ant-stylebook.jar:/srv/gump/public/workspace/ant/build/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/build/lib/ant-swing.jar:/srv/gump/public/workspace/ant/build/lib/ant-junit.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/build/lib/ant-javamail.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bcel.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-regexp.jar:/srv/gump/public/workspace/ant/build/lib/ant-trax.jar:/srv/gump/public/workspace/ant/build/lib/ant-commons-net.jar:/srv/gump/public/workspace/ant/build/lib/ant-jsch.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-log4j.jar:/srv/gump/public/workspace/ant/build/lib/ant-antlr.jar:/srv/gump/public/workspace/ant/build/li
 
b/ant-commons-logging.jar:/srv/gump/public/workspace/ant/build/lib/ant-jdepend.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bsf.jar:/srv/gump/public/workspace/ant/build/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/build/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-oro.jar:/srv/gump/public/workspace/ant/build/lib/ant.jar:/srv/gump/public/workspace/ant/build/lib/ant-jai.jar:/srv/gump/packages/antlr-2.7.6/antlr.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-04092007.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-04092007.jar:/srv/gump/public/workspace/apache-commons/net/dist/commons-net-04092007.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/jakarta-bcel/target/bcel-5.3-SNAPSHOT.jar:/srv/gump/public/workspace/jakarta-bsf/build/lib/bsf.jar:/srv/gump/public/workspace/logging-log4j-12/dist/lib/log4j-04092007.jar:/srv/gump/public/workspace/jakarta-
 
oro/jakarta-oro-04092007.jar:/srv/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-04092007.jar:/srv/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jdepend-2.6/lib/jdepend.jar:/srv/gump/packages/jsch/jsch-0.1.28.jar:/srv/gump/public/workspace/xml-stylebook/bin/stylebook-1.0-b3_xalan-2.jar:/srv/gump/public/workspace/ant-antlibs/antunit/build/ant-antunit-04092007.jar:/srv/gump/public/workspace/junit/dist/junit-04092007.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-compiler.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-runtime.jar:/srv/gump/public/workspace/xml-commons/java/build/which.jar:/srv/gump/public/workspace/rhino/build/rhino_04092007/js.jar:/srv/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/srv/gump/packages/bsh-
 
2.0b4/bsh-classpath-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/srv/gump/public/workspace/apache-commons/codec/dist/commons-codec-04092007.jar
-
[au:an

[EMAIL PROTECTED]: Project test-ant-no-xerces (in module ant) failed

[Gump Integration Build]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project test-ant-no-xerces has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- test-ant-no-xerces :  Java based build tool


Full details are available at:
http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/gump_work/build_ant_test-ant-no-xerces.html
Work Name: build_ant_test-ant-no-xerces (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 mins 44 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dtest.haltonfailure=false 
-Dant.home=/srv/gump/public/workspace/ant/dist run-tests 
[Working Directory: /srv/gump/public/workspace/ant]
CLASSPATH: 
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/ant/build/testcases:/srv/gump/public/workspace/ant/src/tests/junit:/srv/gump/public/workspace/ant/src/etc/testcases:/srv/gump/public/workspace/ant/build/lib/ant-stylebook.jar:/srv/gump/public/workspace/ant/build/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/build/lib/ant-swing.jar:/srv/gump/public/workspace/ant/build/lib/ant-junit.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/build/lib/ant-javamail.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bcel.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-regexp.jar:/srv/gump/public/workspace/ant/build/lib/ant-trax.jar:/srv/gump/public/workspace/ant/build/lib/ant-commons-net.jar:/srv/gump/public/workspace/ant/build/lib/ant-jsch.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-log4j.jar:/srv/gump/public/workspace/ant/build/lib/ant-antlr.jar:/srv/gump/public/workspace/ant/build/li
 
b/ant-commons-logging.jar:/srv/gump/public/workspace/ant/build/lib/ant-jdepend.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bsf.jar:/srv/gump/public/workspace/ant/build/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/build/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-oro.jar:/srv/gump/public/workspace/ant/build/lib/ant.jar:/srv/gump/public/workspace/ant/build/lib/ant-jai.jar:/srv/gump/packages/antlr-2.7.6/antlr.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-04092007.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-04092007.jar:/srv/gump/public/workspace/apache-commons/net/dist/commons-net-04092007.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/jakarta-bcel/target/bcel-5.3-SNAPSHOT.jar:/srv/gump/public/workspace/jakarta-bsf/build/lib/bsf.jar:/srv/gump/public/workspace/logging-log4j-12/dist/lib/log4j-04092007.jar:/srv/gump/public/workspace/jakarta-
 
oro/jakarta-oro-04092007.jar:/srv/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-04092007.jar:/srv/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jdepend-2.6/lib/jdepend.jar:/srv/gump/packages/jsch/jsch-0.1.28.jar:/srv/gump/public/workspace/xml-stylebook/bin/stylebook-1.0-b3_xalan-2.jar:/srv/gump/public/workspace/ant-antlibs/antunit/build/ant-antunit-04092007.jar:/srv/gump/public/workspace/junit/dist/junit-04092007.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-compiler.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-runtime.jar:/srv/gump/public/workspace/xml-commons/java/build/which.jar:/srv/gump/public/workspace/rhino/build/rhino_04092007/js.jar:/srv/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-core-2.0b4.ja
 
r:/srv/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/srv/gump/public/workspace/apache-commons/codec/dist/commons-codec-04092007.jar
-
[au:antunit] Target: testresource took 0.021 sec
[au:antunit] Target: testpath took 0.016 sec
[au:antunit] Target: testfilelist took 0.012 sec
[au:antunit] Target: testpropertyset took 0.016 sec
[au:antunit] Target: testintersect took 0.013 sec
[au:antunit] Target: testzipfileset took 0.033 se

DO NOT REPLY [Bug 40678] - [Patch] Allow macrodef to have arbitary xml elements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40678


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #18962|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 04:36 ---
Created an attachment (id=20766)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20766&action=view)
new patch - separate task fragmentdef

This is a new patch that adds a new task - fragmentdef.
It allows the definition of fairly arbitary element sequences
that can be placed in tasks or types. It does not have
the restriction of having a "-" in the name.
Usage:

  


  



   
 
   



   



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36955] - Path reference in a target, which is not executed, is set anyway.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36955





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 05:53 ---
-I'd be happy with a switch, either on the command line and/or as an ant
property that could be loaded up (though that's a funny about timing)



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40678] - [Patch] Allow macrodef to have arbitary xml elements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40678





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 05:54 ---
+1; much better re-use, but I'm not sure about the name. ? 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40678] - [Patch] Allow macrodef to have arbitary xml elements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40678





--- Additional Comments From [EMAIL PROTECTED]  2007-09-04 06:09 ---
names.
Another alternative is to allow macrodef to be used like
this. I am a little worried about this (changing macrodef)
as it may effect current scripts, but it is something to
consider.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Thanks for the warm welcome!

[Magesh Umasankar]

All:

Thank you for welcoming back into the ant-dev community.

Cheers,
Magesh

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Rev 568096 breaks ant-contrib

[Curt Arnold]

Ant-contrib-test has been started failing on Gump sometime between  
2007-08-21T00:00 and 2007-08-22T00L:00 (I believe Pacific DT, but  
could be wrong) with the following test failures:


run-test:
[junit] Testsuite: net.sf.antcontrib.design.VerifyDesignTest
[junit] Tests run: 41, Failures: 0, Errors: 0, Time elapsed:  
15.651 sec

[junit]
[junit] Testsuite: net.sf.antcontrib.logic.AntCallBackTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed:  
0.886 sec

[junit]
[junit] Testsuite: net.sf.antcontrib.logic.AssertTest
[junit] Tests run: 8, Failures: 0, Errors: 2, Time elapsed:  
0.317 sec

[junit]
[junit] Testcase: test4(net.sf.antcontrib.logic.AssertTest):	 
Caused an ERROR

[junit] both arg1 and arg2 are required in greater than
[junit] /srv/gump/public/workspace/ant-contrib/test/resources/ 
logic/asserttest.xml:34: both arg1 and arg2 are required in greater than
[junit] 	at net.sf.antcontrib.logic.condition.IsGreaterThan.eval 
(IsGreaterThan.java:64)

[junit] at net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
[junit] 	at net.sf.antcontrib.logic.AssertTest.test4 
(AssertTest.java:57)

[junit]
[junit]
[junit] Testcase: test5(net.sf.antcontrib.logic.AssertTest):	 
Caused an ERROR

[junit] both arg1 and arg2 are required in less than
[junit] /srv/gump/public/workspace/ant-contrib/test/resources/ 
logic/asserttest.xml:42: both arg1 and arg2 are required in less than
[junit] 	at net.sf.antcontrib.logic.condition.IsLessThan.eval 
(IsLessThan.java:64)

[junit] at net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
[junit] 	at net.sf.antcontrib.logic.AssertTest.test5 
(AssertTest.java:61)

[junit]
[junit]
[junit] Test net.sf.antcontrib.logic.AssertTest FAILED
[junit] Testsuite: net.sf.antcontrib.logic.ForTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed:  
0.076 sec


...
[junit]
[junit] Testsuite: net.sf.antcontrib.process.LimitTest
[junit] Tests run: 2, Failures: 0, Errors: 1, Time elapsed:  
2.072 sec

[junit]
[junit] Testcase: test2(net.sf.antcontrib.process.LimitTest):	 
Caused an ERROR

[junit] both arg1 and arg2 are required in less than
[junit] /srv/gump/public/workspace/ant-contrib/test/resources/ 
logic/limittest.xml:32: both arg1 and arg2 are required in less than
[junit] 	at net.sf.antcontrib.logic.condition.IsLessThan.eval 
(IsLessThan.java:64)

[junit] at net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
[junit] 	at net.sf.antcontrib.process.LimitTest.test2 
(LimitTest.java:35)

[junit]
[junit]
[junit] Test net.sf.antcontrib.process.LimitTest FAILED
[junit] Testsuite: net.sf.antcontrib.property.PathToFileSetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed:  
0.112 sec


...

and continues in that state see http://vmgump.apache.org/gump/public/ 
ant-contrib/ant-contrib-test/index.html.


There were no changes to ant-contrib during that time, but there were  
many changes to Ant.  I went through and ran the ant-contrib-tests  
against various revisions and it appears that ant-contrib would pass  
with rev 568091 and failed with 568096 and every later release I tried.


To run the test, check ant-contrib out from SVN:

$ svn co https://ant-contrib.svn.sourceforge.net/svnroot/ant-contrib/ 
ant-contrib/trunk ant-contrib

$ cd ant-contrib
'
'
' will run ant-contrib against Ant 1.6.5, but will also download  
dependencies.  Should pass.

$ mvn package
'
'  will pass or fail depending on whether a pre or post rev 568096  
ant is on the path

'
$ ant -Dno-ivy=true clean gump-safe-test -lib ~/.m2/repository/junit/ 
junit/3.8.1/junit-3.8.1.jar


The offending rev does deal with Introspection and seems that it  
could interfere with proper initialization of tasks, but I don't see  
any obvious error in the patch.  It doesn't have a related bug  
report, so I don't know what it is trying to fix.


Index: src/main/org/apache/tools/ant/IntrospectionHelper.java
===
--- src/main/org/apache/tools/ant/IntrospectionHelper.java	(revision  
568091)
+++ src/main/org/apache/tools/ant/IntrospectionHelper.java	(revision  
568096)

@@ -943,6 +943,17 @@
 final Class reflectedArg = PRIMITIVE_TYPE_MAP.containsKey(arg)
 ? (Class) PRIMITIVE_TYPE_MAP.get(arg) : arg;
+// Object.class - it gets handled differently by  
AttributeSetter

+if (java.lang.Object.class == reflectedArg) {
+return new AttributeSetter(m, arg) {
+public void set(Project p, Object parent, String value)
+throws InvocationTargetException,
+IllegalAccessException {
+throw new BuildException(
+"Internal ant problem - this should not get  
called");

+}
+};
+}
 // simple

Re: Rev 568096 breaks ant-contrib

[Matt Benson]

Thanks for the note.  One or more of us will be
looking into it.  :)

-Matt

--- Curt Arnold <[EMAIL PROTECTED]> wrote:

> Ant-contrib-test has been started failing on Gump
> sometime between  
> 2007-08-21T00:00 and 2007-08-22T00L:00 (I believe
> Pacific DT, but  
> could be wrong) with the following test failures:
> 
> run-test:
>  [junit] Testsuite:
> net.sf.antcontrib.design.VerifyDesignTest
>  [junit] Tests run: 41, Failures: 0, Errors: 0,
> Time elapsed:  
> 15.651 sec
>  [junit]
>  [junit] Testsuite:
> net.sf.antcontrib.logic.AntCallBackTest
>  [junit] Tests run: 5, Failures: 0, Errors: 0,
> Time elapsed:  
> 0.886 sec
>  [junit]
>  [junit] Testsuite:
> net.sf.antcontrib.logic.AssertTest
>  [junit] Tests run: 8, Failures: 0, Errors: 2,
> Time elapsed:  
> 0.317 sec
>  [junit]
>  [junit] Testcase:
> test4(net.sf.antcontrib.logic.AssertTest): 
> Caused an ERROR
>  [junit] both arg1 and arg2 are required in
> greater than
>  [junit]
>
/srv/gump/public/workspace/ant-contrib/test/resources/
> 
> logic/asserttest.xml:34: both arg1 and arg2 are
> required in greater than
>  [junit]  at
> net.sf.antcontrib.logic.condition.IsGreaterThan.eval
> 
> (IsGreaterThan.java:64)
>  [junit]  at
>
net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
>  [junit]  at
> net.sf.antcontrib.logic.AssertTest.test4 
> (AssertTest.java:57)
>  [junit]
>  [junit]
>  [junit] Testcase:
> test5(net.sf.antcontrib.logic.AssertTest): 
> Caused an ERROR
>  [junit] both arg1 and arg2 are required in less
> than
>  [junit]
>
/srv/gump/public/workspace/ant-contrib/test/resources/
> 
> logic/asserttest.xml:42: both arg1 and arg2 are
> required in less than
>  [junit]  at
> net.sf.antcontrib.logic.condition.IsLessThan.eval 
> (IsLessThan.java:64)
>  [junit]  at
>
net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
>  [junit]  at
> net.sf.antcontrib.logic.AssertTest.test5 
> (AssertTest.java:61)
>  [junit]
>  [junit]
>  [junit] Test net.sf.antcontrib.logic.AssertTest
> FAILED
>  [junit] Testsuite:
> net.sf.antcontrib.logic.ForTest
>  [junit] Tests run: 2, Failures: 0, Errors: 0,
> Time elapsed:  
> 0.076 sec
> 
> ...
>  [junit]
>  [junit] Testsuite:
> net.sf.antcontrib.process.LimitTest
>  [junit] Tests run: 2, Failures: 0, Errors: 1,
> Time elapsed:  
> 2.072 sec
>  [junit]
>  [junit] Testcase:
> test2(net.sf.antcontrib.process.LimitTest):
> Caused an ERROR
>  [junit] both arg1 and arg2 are required in less
> than
>  [junit]
>
/srv/gump/public/workspace/ant-contrib/test/resources/
> 
> logic/limittest.xml:32: both arg1 and arg2 are
> required in less than
>  [junit]  at
> net.sf.antcontrib.logic.condition.IsLessThan.eval 
> (IsLessThan.java:64)
>  [junit]  at
>
net.sf.antcontrib.logic.Assert.execute(Assert.java:102)
>  [junit]  at
> net.sf.antcontrib.process.LimitTest.test2 
> (LimitTest.java:35)
>  [junit]
>  [junit]
>  [junit] Test
> net.sf.antcontrib.process.LimitTest FAILED
>  [junit] Testsuite:
> net.sf.antcontrib.property.PathToFileSetTest
>  [junit] Tests run: 2, Failures: 0, Errors: 0,
> Time elapsed:  
> 0.112 sec
> 
> ...
> 
> and continues in that state see
> http://vmgump.apache.org/gump/public/ 
> ant-contrib/ant-contrib-test/index.html.
> 
> There were no changes to ant-contrib during that
> time, but there were  
> many changes to Ant.  I went through and ran the
> ant-contrib-tests  
> against various revisions and it appears that
> ant-contrib would pass  
> with rev 568091 and failed with 568096 and every
> later release I tried.
> 
> To run the test, check ant-contrib out from SVN:
> 
> $ svn co
>
https://ant-contrib.svn.sourceforge.net/svnroot/ant-contrib/
> 
> ant-contrib/trunk ant-contrib
> $ cd ant-contrib
> '
> '
> ' will run ant-contrib against Ant 1.6.5, but will
> also download  
> dependencies.  Should pass.
> $ mvn package
> '
> '  will pass or fail depending on whether a pre or
> post rev 568096  
> ant is on the path
> '
> $ ant -Dno-ivy=true clean gump-safe-test -lib
> ~/.m2/repository/junit/ 
> junit/3.8.1/junit-3.8.1.jar
> 
> The offending rev does deal with Introspection and
> seems that it  
> could interfere with proper initialization of tasks,
> but I don't see  
> any obvious error in the patch.  It doesn't have a
> related bug  
> report, so I don't know what it is trying to fix.
> 
> Index:
>
src/main/org/apache/tools/ant/IntrospectionHelper.java
>
===
> ---
>
src/main/org/apache/tools/ant/IntrospectionHelper.java
> (revision  
> 568091)
> +++
>
src/main/org/apache/tools/ant/IntrospectionHelper.java
> (revision  
> 568096)
> @@ -943,6 +943,17 @@
>   final Class reflectedArg =
> PRIMITIVE_TYPE_MAP.containsKey(arg)
>   ? (Class) PRIMITIVE_TYPE_MAP.get(arg)
> : arg;
> +// Object.class - it gets handled
> differently by  
> Attr

Re: Rev 568096 breaks ant-contrib

[Stefan Bodewig]

On Tue, 4 Sep 2007, Curt Arnold <[EMAIL PROTECTED]> wrote:

> The offending rev does deal with Introspection and seems that it
> could interfere with proper initialization of tasks, but I don't see
> any obvious error in the patch.  It doesn't have a related bug
> report, so I don't know what it is trying to fix.

IsGreaterThan extends Equals.  It has setters for arg1 and arg2 that
take String parameters which used to override the ones in Equals.
Equals now has changed the signature of the setters to take Object
arguments (rev 557097) so setArg1 in IsGreateThan no longer overrides
the one in Equals.

So IsGreaterThan ends up with to setters for arg1 and I the change in
IntrospectionHelper favors the Object version which means the
IsGreaterThan condition never gets its args.

Given that I haven't followed the PropertyHelper stuff close enough I
don't know whether simply moving up the String setters could work.

Also, we shouldn't change the setter signatures in existing tasks,
types, conditions and so on (at least for non-final methods) since
there may always be a subclass lurking somewhere.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Rev 568096 breaks ant-contrib

[Stefan Bodewig]

On Wed, 05 Sep 2007, Stefan Bodewig <[EMAIL PROTECTED]> wrote:

> Equals now has changed the signature of the setters to take Object
> arguments (rev 557097) so setArg1 in IsGreateThan no longer
> overrides the one in Equals.

I see the String setters haven't been removed.  In order to have
subclasses work as expected the deleagtion must be changed.

Instead of what we have in Equals it should probably be

public void setArg1(Object a) {
if (a instanceof String) {
setArg1((String) a);
} else {
somePrivateArg1Setter(a);
}
}

public void setArg1(String a) {
somePrivateArg1Setter(a);
}

I haven't changed the code yet, 'cause I'm waiting for feedback.  Also
Equals probably isn't the only place and I don't feel like searching
through the commit logs 8-)

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Rev 568096 breaks ant-contrib

[Matt Benson]

--- Stefan Bodewig <[EMAIL PROTECTED]> wrote:

> On Tue, 4 Sep 2007, Curt Arnold <[EMAIL PROTECTED]>
> wrote:
> 
> > The offending rev does deal with Introspection and
> seems that it
> > could interfere with proper initialization of
> tasks, but I don't see
> > any obvious error in the patch.  It doesn't have a
> related bug
> > report, so I don't know what it is trying to fix.
> 
> IsGreaterThan extends Equals.  It has setters for
> arg1 and arg2 that
> take String parameters which used to override the
> ones in Equals.
> Equals now has changed the signature of the setters
> to take Object
> arguments (rev 557097) so setArg1 in IsGreateThan no
> longer overrides
> the one in Equals.
> 
> So IsGreaterThan ends up with to setters for arg1
> and I the change in
> IntrospectionHelper favors the Object version which
> means the
> IsGreaterThan condition never gets its args.
> 
> Given that I haven't followed the PropertyHelper
> stuff close enough I
> don't know whether simply moving up the String
> setters could work.
> 
> Also, we shouldn't change the setter signatures in
> existing tasks,
> types, conditions and so on (at least for non-final
> methods) since
> there may always be a subclass lurking somewhere.
> 

Great diagnosis, Stefan.  I will revert the changes to
 tomorrow.  Does anyone object to a new
 task?

-Matt

> Stefan
> 
>
-
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
> 
> 



   

Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news, 
photos & more. 
http://mobile.yahoo.com/go?refer=1GNXIC

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]