--- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> On Tue, 4 Sep 2007, Curt Arnold <[EMAIL PROTECTED]>
> wrote:
>
> > The offending rev does deal with Introspection and
> seems that it
> > could interfere with proper initialization of
> tasks, but I don't see
> > any obvious error in the patch. It doesn't have a
> related bug
> > report, so I don't know what it is trying to fix.
>
> IsGreaterThan extends Equals. It has setters for
> arg1 and arg2 that
> take String parameters which used to override the
> ones in Equals.
> Equals now has changed the signature of the setters
> to take Object
> arguments (rev 557097) so setArg1 in IsGreateThan no
> longer overrides
> the one in Equals.
>
> So IsGreaterThan ends up with to setters for arg1
> and I the change in
> IntrospectionHelper favors the Object version which
> means the
> IsGreaterThan condition never gets its args.
>
> Given that I haven't followed the PropertyHelper
> stuff close enough I
> don't know whether simply moving up the String
> setters could work.
>
> Also, we shouldn't change the setter signatures in
> existing tasks,
> types, conditions and so on (at least for non-final
> methods) since
> there may always be a subclass lurking somewhere.
>
Great diagnosis, Stefan. I will revert the changes to
<equals> tomorrow. Does anyone object to a new
<objectsequal> task?
-Matt
> Stefan
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
>
>
____________________________________________________________________________________
Take the Internet to Go: Yahoo!Go puts the Internet in your pocket: mail, news,
photos & more.
http://mobile.yahoo.com/go?refer=1GNXIC
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
