Re: [PR] [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
Qinglong-Lee commented on code in PR #7712: URL: https://github.com/apache/rocketmq/pull/7712#discussion_r1439223009 ## common/src/main/java/org/apache/rocketmq/common/UtilAll.java: ## @@ -31,13 +31,7 @@ import java.text.NumberFormat; import java.text.ParseException; import java.text.SimpleDateFormat; -import java.util.Arrays; -import java.util.Calendar; -import java.util.Date; -import java.util.Enumeration; -import java.util.Iterator; -import java.util.List; -import java.util.Map; +import java.util.*; Review Comment: Btw, why can't I find the method org.apache.rocketmq.tools.admin.DefaultMQAdminExt#examineBrokerClusterAclConfig in the latest version? Does it migrated to other name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user Qinglong-Lee (triggered by yuz10). Head commit for run: 5a821428eaff857a103058f007bf9787bf2a9227 / liqinglong Handle blank string for UtilAll#split Report URL: https://github.com/apache/rocketmq/actions/runs/7383234152 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #660] Add namespace in java client [rocketmq-clients]
aaron-ai commented on code in PR #661:
URL: https://github.com/apache/rocketmq-clients/pull/661#discussion_r1439251278
##
java/client-apis/pom.xml:
##
@@ -34,5 +34,9 @@
com.google.guava
guava
+
+org.apache.commons
+commons-lang3
Review Comment:
Is it necessary to introduce the new dependence here? The shaded jar is fat
enough...
##
java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ConsumerImpl.java:
##
@@ -123,7 +123,10 @@ protected ListenableFuture
receiveMessage(ReceiveMessageRe
}
private AckMessageRequest wrapAckMessageRequest(MessageViewImpl
messageView) {
-final Resource topicResource =
Resource.newBuilder().setName(messageView.getTopic()).build();
+final Resource topicResource = Resource.newBuilder()
+.setResourceNamespace(clientConfiguration.getNamespace())
Review Comment:
Does `namespace` make sense for consumer group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Build" is working again!
The GitHub Actions job "Build" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by aaron-ai). Head commit for run: 22c0da88fac1f58c1f691304936a168fdd915dfd / qipingluo remove TokioRwLock name Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7371072916 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL [rocketmq]
RongtongJin merged PR #7712: URL: https://github.com/apache/rocketmq/pull/7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Deleting the last item problem of the ACL topic/group perms or the global white list caused by the UtilAll#split func flaw [rocketmq]
RongtongJin closed issue #7710: [Bug] Deleting the last item problem of the ACL topic/group perms or the global white list caused by the UtilAll#split func flaw URL: https://github.com/apache/rocketmq/issues/7710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 806454bc5e [ISSUE #7710] Handle blank string for UtilAll#split to fix
the bugs of ACL
806454bc5e is described below
commit 806454bc5e29d2f157cde99bdb082f94cdb377fa
Author: Qinglong-Lee
AuthorDate: Tue Jan 2 19:07:45 2024 +0800
[ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL
Co-authored-by: liqinglong
---
common/src/main/java/org/apache/rocketmq/common/UtilAll.java | 5 +
common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java | 9 +
2 files changed, 14 insertions(+)
diff --git a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
index 19efa9aa90..3629ae648b 100644
--- a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
+++ b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
@@ -43,6 +43,7 @@ import java.util.function.Supplier;
import java.util.zip.CRC32;
import java.util.zip.DeflaterOutputStream;
import java.util.zip.InflaterInputStream;
+import java.util.Collections;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.validator.routines.InetAddressValidator;
import org.apache.rocketmq.common.constant.LoggerName;
@@ -681,6 +682,10 @@ public class UtilAll {
return null;
}
+if (StringUtils.isBlank(str)) {
+return Collections.EMPTY_LIST;
+}
+
String[] addrArray = str.split(splitter);
return Arrays.asList(addrArray);
}
diff --git a/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
b/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
index 2d22d5254a..a2b498f077 100644
--- a/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
+++ b/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
@@ -142,6 +142,15 @@ public class UtilAllTest {
assertEquals("", UtilAll.join(objects, comma));
}
+@Test
+public void testSplit() {
+List list = Arrays.asList("groupA=DENY", "groupB=PUB|SUB",
"groupC=SUB");
+String comma = ",";
+assertEquals(list,
UtilAll.split("groupA=DENY,groupB=PUB|SUB,groupC=SUB", comma));
+assertEquals(null, UtilAll.split(null, comma));
+assertEquals(Collections.EMPTY_LIST, UtilAll.split("", comma));
+}
+
static class DemoConfig {
private int demoWidth = 0;
private int demoLength = 0;
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 806454bc5e29d2f157cde99bdb082f94cdb377fa / Qinglong-Lee [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL Co-authored-by: liqinglong Report URL: https://github.com/apache/rocketmq/actions/runs/7385077644 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 806454bc5e29d2f157cde99bdb082f94cdb377fa / Qinglong-Lee [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL Co-authored-by: liqinglong Report URL: https://github.com/apache/rocketmq/actions/runs/7385077652 With regards, GitHub Actions via GitBox
[I] [Bug] MQFaultStrategy will send to wrong broker even when it is not writable [rocketmq]
leizhiyuan opened a new issue, #7713:
URL: https://github.com/apache/rocketmq/issues/7713
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [X] I have searched the [GitHub
Issues](https://github.com/apache/rocketmq/issues) and [GitHub
Discussions](https://github.com/apache/rocketmq/discussions) of this
repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not
other repositories of RocketMQ.
### Runtime platform environment
review
### RocketMQ version
4.9.x
### JDK Version
_No response_
### Describe the Bug
MQFaultStrategy will send to wrong broker even when it is not writable
### Steps to Reproduce
MQFaultStrategy will send to wrong broker even when it is not writable
### What Did You Expect to See?
MQFaultStrategy will send to wrong broker even when it is not writable
### What Did You See Instead?
MQFaultStrategy will send to wrong broker even when it is not writable
### Additional Context
https://github.com/apache/rocketmq/assets/2684384/4565a392-c7ee-4c92-9648-7c8b5b135c41";>
```
public int getQueueIdByBroker(final String brokerName) {
for (int i = 0; i < topicRouteData.getQueueDatas().size(); i++) {
final QueueData queueData =
this.topicRouteData.getQueueDatas().get(i);
if (queueData.getBrokerName().equals(brokerName)) {
return queueData.getWriteQueueNums();
}
}
return -1;
}
```
如果一个topic存在两个broker集群，其中一个broker集群通过perm设置了禁止写入，这里会绕过，并且这里会改变messagequeue，这样，由于外部的topicroute没有变化，这个状态后续无法更新了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7699] Add namespace v2 in client [rocketmq]
lizhanhui commented on code in PR #7700: URL: https://github.com/apache/rocketmq/pull/7700#discussion_r1439427835 ## broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java: ## @@ -1377,7 +1377,7 @@ public CompletableFuture pullMessageFromSpecificBrokerAsync(String b requestHeader.setSubVersion(System.currentTimeMillis()); requestHeader.setMaxMsgBytes(Integer.MAX_VALUE); requestHeader.setExpressionType(ExpressionType.TAG); -requestHeader.setBname(brokerName); Review Comment: This shall result in a backward compatible issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Update Bazel toolchain to make continuous integration pipeline work [rocketmq]
bazelisky opened a new issue, #7715: URL: https://github.com/apache/rocketmq/issues/7715 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment NA ### RocketMQ version NA ### JDK Version NA ### Describe the Bug NA ### Steps to Reproduce CI pipeline fails ### What Did You Expect to See? NA ### What Did You See Instead? CI pipeline fails ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user bazelisky (triggered by lizhanhui). Head commit for run: b5947d1090bbdecb70a939ea047862d36693a1f0 / Bazelisky Update bazel toolchain Signed-off-by: Bazelisky Report URL: https://github.com/apache/rocketmq/actions/runs/7387231205 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user bazelisky (triggered by bazelisky). Head commit for run: 806454bc5e29d2f157cde99bdb082f94cdb377fa / Qinglong-Lee [ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL Co-authored-by: liqinglong Report URL: https://github.com/apache/rocketmq/actions/runs/7387311011 With regards, GitHub Actions via GitBox
[PR] WIP: [ISSUE #7713] MQFaultStrategy check queue if writable [rocketmq]
leizhiyuan opened a new pull request, #7716: URL: https://github.com/apache/rocketmq/pull/7716 ### Which Issue(s) This PR Fixes Fixes #7713 ### Brief Description fix: MQFaultStrategy check queue if writable, and do not change MessageQueue itself ### How Did You Test This Change? depends on these test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7713] MQFaultStrategy check queue if writable [rocketmq]
leizhiyuan commented on PR #7716: URL: https://github.com/apache/rocketmq/pull/7716#issuecomment-1874708111 cc @glcrazier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add addtional action to repository [rocketmq-operator]
caigy commented on issue #206: URL: https://github.com/apache/rocketmq-operator/issues/206#issuecomment-1874768299 @drivebyer It seems those limits are set by Apache. Similar problems are encountered in other communities: - https://github.com/apache/shardingsphere-on-cloud/issues/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7699] Add namespace v2 in client [rocketmq]
drpmma commented on code in PR #7700: URL: https://github.com/apache/rocketmq/pull/7700#discussion_r1440093921 ## broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java: ## @@ -1377,7 +1377,7 @@ public CompletableFuture pullMessageFromSpecificBrokerAsync(String b requestHeader.setSubVersion(System.currentTimeMillis()); requestHeader.setMaxMsgBytes(Integer.MAX_VALUE); requestHeader.setExpressionType(ExpressionType.TAG); -requestHeader.setBname(brokerName); Review Comment: Only the function signature has been modified here, without changes to the internal fields. The field name remains 'bname', so there should be no compatibility issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7699] Add namespace v2 in client [rocketmq]
drpmma commented on code in PR #7700: URL: https://github.com/apache/rocketmq/pull/7700#discussion_r1440094011 ## broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java: ## @@ -1377,7 +1377,7 @@ public CompletableFuture pullMessageFromSpecificBrokerAsync(String b requestHeader.setSubVersion(System.currentTimeMillis()); requestHeader.setMaxMsgBytes(Integer.MAX_VALUE); requestHeader.setExpressionType(ExpressionType.TAG); -requestHeader.setBname(brokerName); Review Comment: See https://github.com/apache/rocketmq/blob/710d3bcdb083d28f0cdb405adb749509150f0b25/remoting/src/main/java/org/apache/rocketmq/remoting/rpc/RpcRequestHeader.java#L43-L49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 订阅关系与订阅关系一致 [rocketmq]
blpwa opened a new issue, #7717: URL: https://github.com/apache/rocketmq/issues/7717 ### Search before creation - [X] I had searched in the [issues](https://github.com/apache/rocketmq/issues) and found no similar issues. ### Documentation Related 订阅关系  订阅关系一致  订阅关系中说的是"同一个消费者分组对于不同主题的订阅也相互独立"，订阅关系一致性中说的是"如果订阅关系（消费者分组名-Topic-Tag）不一致，会导致消费消息紊乱，甚至消息丢失"，请问哪种描述是正确的，若描述都正确的话，又如何理解两者之间的差异 ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] 使用的rocketmq-client客户端，在github action中不消费或消费慢 [rocketmq-clients]
daizhenyu opened a new issue, #664: URL: https://github.com/apache/rocketmq-clients/issues/664 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Programming Language of the Client Java ### Runtime Platform Environment ubuntu-latest ### RocketMQ Version of the Client/Server Server：5.1.4 client：4.8.0, 4.9.7, 5.0.0, 5.1.4 ### Run or Compiler Version Oracle JDK 8 ### Describe the Bug 1. 在github的action中运行集成测试，使用rocketmq服务端版本为5.1.4，客户端版本为4.8.0, 4.9.7, 5.0.0和5.1.4。其中消费者通过poll方式订阅消费，使用DefaultLitePullConsumer。通过github的版本矩阵方式，对客户端的四个版本分别进行消费测试，其中5.0.0版本一直不消费，时长超过70s。 2. 在github的action中运行集成测试，使用rocketmq服务端版本为4.8.0，客户端版本为4.8.0, 4.9.7, 5.0.0和5.1.4。其中消费者通过push方式订阅消费，使用DefaultMQPushConsumer。通过github的版本矩阵方式，对客户端的四个版本分别进行消费测试，其中4.8.0版本消费时长慢，消费时间需要50-70s，其他版本在50s内可以完成消费。 3. 以上场景，我在自己的本地（windows11）运行，可以正常消费，但是在github action里面消费慢甚至不消费。 ### Steps to Reproduce 参考Describe the Bug描述可以复现 1.生产者消费者demo 2.在github action中运行 ### What Did You Expect to See? 我无法定位出现该问题的原因，kafka在相同的环境中进行测试可以正常快速消费，但是rocketmq存在延时，希望可以定位找下原因。 ### What Did You See Instead? 暂无 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 使用的rocketmq-client客户端，在github action中不消费或消费慢 [rocketmq-clients]
aaron-ai commented on issue #664: URL: https://github.com/apache/rocketmq-clients/issues/664#issuecomment-1874957426 The client you mentioned does not belong to this repo, @daizhenyu move issue to https://github.com/apache/rocketmq/issues please... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] In RocketMQ, when the client producer is using a proxy proxy, the message will be sent with an exception error [rocketmq]
lijie123bes opened a new issue, #7718: URL: https://github.com/apache/rocketmq/issues/7718 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos 7 ### RocketMQ version 5.1.3 ### JDK Version 1.8 ### Describe the Bug Message sent when the client producer is using a proxy . ERROR Occur service exception: Failed to query message by Id: Error Occur Service Exception: Failed to query message by ID: 0108719066 ff9a489c04db99ca0003 "exception error. However, if the client producer does not point to the proxy, but sends the message directly to namesrv, in this case it is normal to view the consumption of the message. Why does this happen? ### Steps to Reproduce the client producer using a proxy send message ### What Did You Expect to See? send success ### What Did You See Instead? ERROR Occur ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
