aaron-ai commented on code in PR #661:
URL: https://github.com/apache/rocketmq-clients/pull/661#discussion_r1439251278
##########
java/client-apis/pom.xml:
##########
@@ -34,5 +34,9 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
Review Comment:
Is it necessary to introduce the new dependence here? The shaded jar is fat
enough...
##########
java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ConsumerImpl.java:
##########
@@ -123,7 +123,10 @@ protected ListenableFuture<ReceiveMessageResult>
receiveMessage(ReceiveMessageRe
}
private AckMessageRequest wrapAckMessageRequest(MessageViewImpl
messageView) {
- final Resource topicResource =
Resource.newBuilder().setName(messageView.getTopic()).build();
+ final Resource topicResource = Resource.newBuilder()
+ .setResourceNamespace(clientConfiguration.getNamespace())
Review Comment:
Does `namespace` make sense for consumer group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
