[I] cannot start consumer(route info not found & cannot subscribe topic since client either failed to start or has been shutdown ) [rocketmq-client-go]
chicc4923 opened a new issue, #1116: URL: https://github.com/apache/rocketmq-client-go/issues/1116 **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? **start consumer return errors** : 1. cannot subscribe topic since client either failed to start or has been shutdown 2. route info not found (dashboard has this info) - What is your RocketMQ version? `5.1.3` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Can not receive content in body field of response when using rpc request [rocketmq-client-go]
YarBor commented on issue #1046: URL: https://github.com/apache/rocketmq-client-go/issues/1046#issuecomment-1833310996 @francisoliverlee Is the bug still here? If so, I think I could give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7534] use high performance concurrent set to replace copyonwriteset [rocketmq]
RongtongJin commented on code in PR #7583:
URL: https://github.com/apache/rocketmq/pull/7583#discussion_r1410374838
##
namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java:
##
@@ -131,6 +134,25 @@ public void getAllTopicList() {
assertThat(topicList.getTopicList()).contains("TestTopic",
"TestTopic1", "TestTopic2");
}
+@Test
+public void hugeTopicListAddTest() {
+Set mapSet = ConcurrentHashMap.newKeySet();
+Set copyOnWriteArraySet = new CopyOnWriteArraySet<>();
+HashSet topics = new HashSet<>();
+
+for (int i = 0; i < 10; ++i) {
+topics.add("Topic" + i);
+}
+long startTime = System.currentTimeMillis();
+mapSet.addAll(topics);
+long endTime = System.currentTimeMillis();
+assertThat(endTime - startTime < 100).isTrue();
+startTime = System.currentTimeMillis();
+copyOnWriteArraySet.addAll(topics);
+endTime = System.currentTimeMillis();
+assertThat(endTime - startTime > 3000).isTrue();
+}
Review Comment:
It seems that this test is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 56e886bf70669befd7b9e7380e68751fe67f05b2 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct … (#7593) * [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct to direct buffer allocation * fix: consolidate UtilAll#cleanBuffer by checking if the given buffer is direct or not Signed-off-by: Li Zhanhui - Signed-off-by: Li Zhanhui Co-authored-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/7044472982 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 5901b4eb233e23868475d63bc705530a7018543e / RongtongJin Remove the useless unit test Report URL: https://github.com/apache/rocketmq/actions/runs/706551 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #103] Fix bug in newSource [rocketmq-flink]
lizhimins commented on PR #104: URL: https://github.com/apache/rocketmq-flink/pull/104#issuecomment-1833558998 Please set the target branch as main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #103] Fix bug in newSource [rocketmq-flink]
lizhimins commented on code in PR #104:
URL: https://github.com/apache/rocketmq-flink/pull/104#discussion_r1410526929
##
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##
@@ -240,7 +239,14 @@ public CompletableFuture
seekCommittedOffset(MessageQueue messageQueue) {
long offset =
consumer.getOffsetStore()
.readOffset(messageQueue,
ReadOffsetType.READ_FROM_STORE);
-LOG.error(
+if (offset == -1) {
+offset = adminExt.minOffset(messageQueue);
+LOG.info(
+"Consumer seek committed offset from
remote, offset=-1,mq={},use minOffset={}",
Review Comment:
这里可以添加下空格
##
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##
@@ -240,7 +239,14 @@ public CompletableFuture
seekCommittedOffset(MessageQueue messageQueue) {
long offset =
consumer.getOffsetStore()
.readOffset(messageQueue,
ReadOffsetType.READ_FROM_STORE);
-LOG.error(
+if (offset == -1) {
+offset = adminExt.minOffset(messageQueue);
+LOG.info(
+"Consumer seek committed offset from
remote, offset=-1,mq={},use minOffset={}",
Review Comment:
这里可以添加下空格
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7585] Support message filtering in rocketmq tiered storage [rocketmq]
lizhimins commented on PR #7594: URL: https://github.com/apache/rocketmq/pull/7594#issuecomment-1833565089 > hi, there are test failures~ https://private-user-images.githubusercontent.com/52153761/286829356-34cb1db6-f309-4349-8920-a47f62aad058.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEzNDM0NjYsIm5iZiI6MTcwMTM0MzE2NiwicGF0aCI6Ii81MjE1Mzc2MS8yODY4MjkzNTYtMzRjYjFkYjYtZjMwOS00MzQ5LTg5MjAtYTQ3ZjYyYWFkMDU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTMwVDExMTkyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3MjY3MzZjN2VmODg3MWY2ZTMwNTQxYTMzNzJkMzA5Y2ZhMzFiM2E3ZjBiYzBjM2ZjZTkwN2M0Y2IyODc1NDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YSi9AsI_LkT66mw1_W9KIT2J6WKe043TRSFAGuto7wU";> 这个测试是 cq in rocksdb 的提交引入的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #103] Fix bug in newSource [rocketmq-flink]
844028312 commented on code in PR #104:
URL: https://github.com/apache/rocketmq-flink/pull/104#discussion_r1410607779
##
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##
@@ -240,7 +239,14 @@ public CompletableFuture
seekCommittedOffset(MessageQueue messageQueue) {
long offset =
consumer.getOffsetStore()
.readOffset(messageQueue,
ReadOffsetType.READ_FROM_STORE);
-LOG.error(
+if (offset == -1) {
+offset = adminExt.minOffset(messageQueue);
+LOG.info(
+"Consumer seek committed offset from
remote, offset=-1,mq={},use minOffset={}",
Review Comment:
已修改
##
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##
@@ -240,7 +239,14 @@ public CompletableFuture
seekCommittedOffset(MessageQueue messageQueue) {
long offset =
consumer.getOffsetStore()
.readOffset(messageQueue,
ReadOffsetType.READ_FROM_STORE);
-LOG.error(
+if (offset == -1) {
+offset = adminExt.minOffset(messageQueue);
+LOG.info(
+"Consumer seek committed offset from
remote, offset=-1,mq={},use minOffset={}",
Review Comment:
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] eventBridge目标源，不支持http [rocketmq-eventbridge]
Jashinck commented on issue #155: URL: https://github.com/apache/rocketmq-eventbridge/issues/155#issuecomment-1833797675 支持HTTP目标的，Connector同RocketMQ Connector共建。快速开始文档参考：https://github.com/apache/rocketmq-eventbridge/blob/main/docs/cn/RocketMQEventBridgeQuickStart.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE 4622] Improve execution efficiency of integration tests, chang… [rocketmq]
yp969803 opened a new pull request, #7597: URL: https://github.com/apache/rocketmq/pull/7597 …e sleep to Awaitility.await ### Which Issue(s) This PR Fixes Fixes #4622 ### Brief Description Changed sleep in test modules to Awaitility.await ### How Did You Test This Change? using mvn test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 0b0aa80425d1851996f1268972a593d0b257fcdf / yash [ISSUE 4622] Improve execution efficiency of integration tests, change sleep to Awaitility.await Report URL: https://github.com/apache/rocketmq/actions/runs/7049673961 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 0b0aa80425d1851996f1268972a593d0b257fcdf / yash [ISSUE 4622] Improve execution efficiency of integration tests, change sleep to Awaitility.await Report URL: https://github.com/apache/rocketmq/actions/runs/7049673955 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE 4622] Improve execution efficiency of integration tests, chang… [rocketmq]
yp969803 commented on PR #7597: URL: https://github.com/apache/rocketmq/pull/7597#issuecomment-1834161422 @zhouxinyu can you review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 56e886bf70669befd7b9e7380e68751fe67f05b2 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct … (#7593) * [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct to direct buffer allocation * fix: consolidate UtilAll#cleanBuffer by checking if the given buffer is direct or not Signed-off-by: Li Zhanhui - Signed-off-by: Li Zhanhui Co-authored-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/7049681261 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 0b0aa80425d1851996f1268972a593d0b257fcdf / yash [ISSUE 4622] Improve execution efficiency of integration tests, change sleep to Awaitility.await Report URL: https://github.com/apache/rocketmq/actions/runs/7049673942 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 0b0aa80425d1851996f1268972a593d0b257fcdf / yash [ISSUE 4622] Improve execution efficiency of integration tests, change sleep to Awaitility.await Report URL: https://github.com/apache/rocketmq/actions/runs/7049673965 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 371235a19ca6a0da73cf6cfc291199d8b400b8be / yash [ISSUE 4622] Checkstyle configured Report URL: https://github.com/apache/rocketmq/actions/runs/7050421598 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 56e886bf70669befd7b9e7380e68751fe67f05b2 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct … (#7593) * [ISSUE #7592] testCleanBuffer unit test modifies, changed non-direct to direct buffer allocation * fix: consolidate UtilAll#cleanBuffer by checking if the given buffer is direct or not Signed-off-by: Li Zhanhui - Signed-off-by: Li Zhanhui Co-authored-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/7050435183 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 371235a19ca6a0da73cf6cfc291199d8b400b8be / yash [ISSUE 4622] Checkstyle configured Report URL: https://github.com/apache/rocketmq/actions/runs/7050421472 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 371235a19ca6a0da73cf6cfc291199d8b400b8be / yash [ISSUE 4622] Checkstyle configured Report URL: https://github.com/apache/rocketmq/actions/runs/7050421463 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yp969803 (triggered by yp969803). Head commit for run: 371235a19ca6a0da73cf6cfc291199d8b400b8be / yash [ISSUE 4622] Checkstyle configured Report URL: https://github.com/apache/rocketmq/actions/runs/7050421474 With regards, GitHub Actions via GitBox
Re: [I] Refactor the calculation of `bornhostLength` and `storeHostLength` [rocketmq]
github-actions[bot] commented on issue #5599: URL: https://github.com/apache/rocketmq/issues/5599#issuecomment-1834985549 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Refactor the calculation of `bornhostLength` and `storeHostLength` [rocketmq]
github-actions[bot] closed issue #5599: Refactor the calculation of `bornhostLength` and `storeHostLength` URL: https://github.com/apache/rocketmq/issues/5599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [OPTIMIZATION] Change the broker default value configuration of 'useS… [rocketmq]
github-actions[bot] commented on PR #5614: URL: https://github.com/apache/rocketmq/pull/5614#issuecomment-1834985315 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Golang] Allow user to disable TLS [rocketmq-clients]
github-actions[bot] commented on PR #632: URL: https://github.com/apache/rocketmq-clients/pull/632#issuecomment-1835052020 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Golang] Allow user to disable TLS [rocketmq-clients]
github-actions[bot] closed pull request #632: [Golang] Allow user to disable TLS URL: https://github.com/apache/rocketmq-clients/pull/632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7534] use high performance concurrent set to replace copyonwriteset [rocketmq]
RongtongJin merged PR #7583: URL: https://github.com/apache/rocketmq/pull/7583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] class Topiclist use CopyOnWriteArraySet will cause timeout [rocketmq]
RongtongJin closed issue #7534: [Bug] class Topiclist use CopyOnWriteArraySet will cause timeout URL: https://github.com/apache/rocketmq/issues/7534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 65faea22fd [ISSUE #7534] Use high performance concurrent set to
replace copyonwriteset (#7583)
65faea22fd is described below
commit 65faea22fd54fd9875f2ca9d3088b4dc46d31cce
Author: keranbingaa <397294...@qq.com>
AuthorDate: Fri Dec 1 10:05:16 2023 +0800
[ISSUE #7534] Use high performance concurrent set to replace copyonwriteset
(#7583)
* fix ISSUE #7534
* reformat code
* Remove the useless unit test
-
Co-authored-by: RongtongJin
---
.../apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java| 1 -
.../java/org/apache/rocketmq/remoting/protocol/body/TopicList.java| 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java
b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java
index 6002d1f5a4..b52cf50740 100644
---
a/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java
+++
b/namesrv/src/test/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManagerNewTest.java
@@ -130,7 +130,6 @@ public class RouteInfoManagerNewTest {
topicList = TopicList.decode(content, TopicList.class);
assertThat(topicList.getTopicList()).contains("TestTopic",
"TestTopic1", "TestTopic2");
}
-
@Test
public void registerBroker() {
// Register master broker
diff --git
a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/TopicList.java
b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/TopicList.java
index 30edfb5a98..0de0bae7e3 100644
---
a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/TopicList.java
+++
b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/TopicList.java
@@ -17,11 +17,11 @@
package org.apache.rocketmq.remoting.protocol.body;
import java.util.Set;
-import java.util.concurrent.CopyOnWriteArraySet;
+import java.util.concurrent.ConcurrentHashMap;
import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
public class TopicList extends RemotingSerializable {
-private Set topicList = new CopyOnWriteArraySet<>();
+private Set topicList = ConcurrentHashMap.newKeySet();
private String brokerAddr;
public Set getTopicList() {
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583) * fix ISSUE #7534 * reformat code * Remove the useless unit test - Co-authored-by: RongtongJin Report URL: https://github.com/apache/rocketmq/actions/runs/7054776802 With regards, GitHub Actions via GitBox
[PR] using Maps.newHashMapWithExpectedSize method [rocketmq]
shenjianeng opened a new pull request, #7598: URL: https://github.com/apache/rocketmq/pull/7598 ### Brief Description Creates a HashMap instance, with a high enough "initial capacity" that it should hold expectedSize elements without growth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] topicsOfInterest should pass a reference instead of a value [rocketmq-clients]
lizhanhui commented on issue #639: URL: https://github.com/apache/rocketmq-clients/issues/639#issuecomment-1835316095 @forgivemyheart I've created a pull request, you may have a review if you like -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583) * fix ISSUE #7534 * reformat code * Remove the useless unit test - Co-authored-by: RongtongJin Report URL: https://github.com/apache/rocketmq/actions/runs/7054776796 With regards, GitHub Actions via GitBox
Re: [PR] using Maps.newHashMapWithExpectedSize method [rocketmq]
shenjianeng closed pull request #7598: using Maps.newHashMapWithExpectedSize method URL: https://github.com/apache/rocketmq/pull/7598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583) * fix ISSUE #7534 * reformat code * Remove the useless unit test - Co-authored-by: RongtongJin Report URL: https://github.com/apache/rocketmq/actions/runs/7054776794 With regards, GitHub Actions via GitBox
Re: [I] [Bug] dledger集群消息丢失 [rocketmq]
cserwen commented on issue #7477: URL: https://github.com/apache/rocketmq/issues/7477#issuecomment-1835365707 Similar to this https://github.com/apache/rocketmq/issues/7355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583) * fix ISSUE #7534 * reformat code * Remove the useless unit test - Co-authored-by: RongtongJin Report URL: https://github.com/apache/rocketmq/actions/runs/7054776795 With regards, GitHub Actions via GitBox
Re: [PR] fix dledger recover abnormally may lost consume queue of tail [rocketmq]
bxfjb commented on PR #7599: URL: https://github.com/apache/rocketmq/pull/7599#issuecomment-1835389559 @cserwen I opened this pr for #7355 , could you please review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [RIP-68] RocketMQ ACL 2.0 [rocketmq]
dingshuangxi888 commented on issue #7560: URL: https://github.com/apache/rocketmq/issues/7560#issuecomment-1835391559 @echooymxq First, the NameServer is a stateless application that allows for flexible scaling and dynamic upscaling or downscaling without bearing the responsibilities related to data persistence storage. Second, at the architectural level, the NameServer does not handle metadata capabilities; instead, it serves the functions of service registration and routing discovery. Finally, as a stateful application, the Broker has the responsibility and capability for metadata storage at the data storage layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 5.+ edition rocketmq proxy and dashboard issue [rocketmq-dashboard]
xue2lang commented on issue #185: URL: https://github.com/apache/rocketmq-dashboard/issues/185#issuecomment-1835420238 me too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #185] Fix pod ready status reflect to cr [rocketmq-operator]
caigy commented on code in PR #186:
URL: https://github.com/apache/rocketmq-operator/pull/186#discussion_r1411613390
##
pkg/controller/broker/broker_controller.go:
##
@@ -398,6 +402,15 @@ func getBrokerName(broker *rocketmqv1alpha1.Broker,
brokerGroupIndex int) string
return broker.Name + "-" + strconv.Itoa(brokerGroupIndex)
}
+func isReady(po corev1.Pod) bool {
+ for _, cond := range po.Status.Conditions {
+ if cond.Type == corev1.PodReady {
Review Comment:
Should we check `PodReady` status at this stage? The brokers may be just
started and initializing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] PoP caused broker memory leak [rocketmq]
leizhiyuan commented on issue #7031: URL: https://github.com/apache/rocketmq/issues/7031#issuecomment-1835501719 Can I ask what the scenario is like? Is it caused by the client restart, and the ck map in the server memory not being cleared? Is it because of repeated additions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
cyao2q commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835548251 > maxDelayTimeMills in ProxyConfig  请问这2个配置都要配置吗 我看默认 proxy的启动日志是1天 `"maxDelayTimeMills":8640` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #639 fix semantics of topicOfInterest [rocketmq-clients]
aaron-ai commented on code in PR #642:
URL: https://github.com/apache/rocketmq-clients/pull/642#discussion_r1411673524
##
cpp/source/rocketmq/ProducerImpl.cpp:
##
@@ -575,9 +576,22 @@ void
ProducerImpl::onOrphanedTransactionalMessage(MessageConstSharedPtr message)
}
}
-void ProducerImpl::topicsOfInterest(std::vector topics) {
+void ProducerImpl::topicsOfInterest(std::vector &topics) {
absl::MutexLock lk(&topics_mtx_);
- topics_.swap(topics);
+ for (auto& topic : topics_) {
Review Comment:
Does `ProducerImpl#topicOfInterest` simply retrieve a copy of the topics for
sending messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] broker重启偶发topic perm权限被修改为4 [rocketmq]
LittleBoy18 opened a new issue, #7600: URL: https://github.com/apache/rocketmq/issues/7600 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment k8s ### RocketMQ version 5.1.0 ### JDK Version _No response_ ### Describe the Bug https://github.com/apache/rocketmq/assets/18388649/ab0105f0-617e-4f6e-9361-aae898fd8bc7";> namesrv日志有批量修改了topic perm为4 ### Steps to Reproduce 在k8s环境中，使用了远程存储不停的重启broker ### What Did You Expect to See? topic perm权限为6 ### What Did You See Instead? 偶发topic perm全部更改为了4 ### Additional Context https://github.com/apache/rocketmq/assets/18388649/7af9cf8f-4cd7-42e3-bbfd-6022167e7e4e";> namesrv注册broker代码中有看到Wipe write的逻辑，但是不太理解这个isPrimeSlave -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
manyhelp commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1835577408 我也遇到这个问题，一直打印这个日志 RocketmqRemoting - closeChannel: close the connection to remote address[x.x.x.x:xxx] result: true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #639 fix semantics of topicOfInterest [rocketmq-clients]
lizhanhui commented on code in PR #642:
URL: https://github.com/apache/rocketmq-clients/pull/642#discussion_r1411708765
##
cpp/source/rocketmq/ProducerImpl.cpp:
##
@@ -575,9 +576,22 @@ void
ProducerImpl::onOrphanedTransactionalMessage(MessageConstSharedPtr message)
}
}
-void ProducerImpl::topicsOfInterest(std::vector topics) {
+void ProducerImpl::topicsOfInterest(std::vector &topics) {
absl::MutexLock lk(&topics_mtx_);
- topics_.swap(topics);
+ for (auto& topic : topics_) {
Review Comment:
This function exposes topics that are in use to other internal components.
The newly added withTopics, similar to subscribe, allows application developers
to specify topics that will be used in future for the purpose of route info
prefetch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
lb-zy commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835608167 我只在broker.conf里配置了，就没报这个错： brokerClusterName = DefaultCluster brokerName = broker-a brokerId = 0 deleteWhen = 04 fileReservedTime = 720 timerMaxDelaySec = 2592000 brokerRole = ASYNC_MASTER flushDiskType = ASYNC_FLUSH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
cyao2q commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835617103 > 我只在broker.conf里配置了，就没报这个错： brokerClusterName = DefaultCluster brokerName = broker-a brokerId = 0 deleteWhen = 04 fileReservedTime = 720 timerMaxDelaySec = 2592000 brokerRole = ASYNC_MASTER flushDiskType = ASYNC_FLUSH 你这是30天？ fileReservedTime这个是什么意思啊 默认是 48 需要改吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
lb-zy commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835620739 > > 我只在broker.conf里配置了，就没报这个错： brokerClusterName = DefaultCluster brokerName = broker-a brokerId = 0 deleteWhen = 04 fileReservedTime = 720 timerMaxDelaySec = 2592000 brokerRole = ASYNC_MASTER flushDiskType = ASYNC_FLUSH > > 你这是30天？ > > fileReservedTime这个是什么意思啊 默认是 48 需要改吗 fileReservedTime是持久化消息保存周期（单位：小时），超过该周期将被清理，默认48小时，你要是改了最大延时时间，就得跟着改这个 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Slave thrown NPE and consumer receive duplicate messages when enable slaveActingMaster and remoteEscape [rocketmq]
gaoyf opened a new issue, #7601: URL: https://github.com/apache/rocketmq/issues/7601 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment OS: CentOS 6.9 ### RocketMQ version branch: (develop|tag 5.1.4) version: 5.1.4 ### JDK Version JDK: 1.8.0_202 ### Describe the Bug When I enable slaveActingMaster and remoteEscape，send some messages to master，then close it，slave throw exceptions as follows: ``` 2023-11-28 17:56:25 INFO TimerDequeuePutMessageService - Unknown error java.lang.NullPointerException: null at org.apache.rocketmq.store.timer.TimerMessageStore.doPut(TimerMessageStore.java:1088) at org.apache.rocketmq.store.timer.TimerMessageStore.access$1900(TimerMessageStore.java:71) at org.apache.rocketmq.store.timer.TimerMessageStore$TimerDequeuePutMessageService.run(TimerMessageStore.java:1487) at java.lang.Thread.run(Thread.java:748) 2023-11-28 17:56:25 INFO TimerDequeuePutMessageService - Unknown error java.lang.NumberFormatException: null at java.lang.Integer.parseInt(Integer.java:542) at java.lang.Integer.parseInt(Integer.java:615) at org.apache.rocketmq.store.timer.TimerMessageStore.convertMessage(TimerMessageStore.java:1142) at org.apache.rocketmq.store.timer.TimerMessageStore.convert(TimerMessageStore.java:1059) at org.apache.rocketmq.store.timer.TimerMessageStore.access$1800(TimerMessageStore.java:71) at org.apache.rocketmq.store.timer.TimerMessageStore$TimerDequeuePutMessageService.run(TimerMessageStore.java:1486) at java.lang.Thread.run(Thread.java:748) ``` I fixed the exception，and repeat previous steps，after I restarted master, the consumer received **repeated messages**。 ### Steps to Reproduce **The first problem reproduce steps:** 1. Enable such configs as follows: 1. NameServer: supportActingMaster=true 2. Broker: enableSlaveActingMaster=true enableRemoteEscape=true totalReplicas=2 2. Deploy one NameServer and tow group of brokers, such as: 1. master: broker-a，slave: broker-a-s 2. master: broker-b，slave: broker-b-s 3. Run consumer and send some timer messages，such as: ```message.setDeliverTimeMs(System.currentTimeMillis() + 5 * 60_000L);``` 4. Close the master, slave will throw NPE and NumberFormatException when timer message escape。 **The second problem reproduce steps:** 1. After I fix the exception and repeat previous steps。 2. Restart master, the consumer will receive **repeated messages**。 For example, the producer sent 10 messages and received 10 messages before the master restarted. After the master restarted, it repeatedly received the previously received messages. ### What Did You Expect to See? 1. Slave not throw exception。 2. Consumer not revieve repeated messages. ### What Did You See Instead? 1. Slave throw exception。 2. Consumer revieve repeated messages. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
lb-zy commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835628327 > > 我只在broker.conf里配置了，就没报这个错： brokerClusterName = DefaultCluster brokerName = broker-a brokerId = 0 deleteWhen = 04 fileReservedTime = 720 timerMaxDelaySec = 2592000 brokerRole = ASYNC_MASTER flushDiskType = ASYNC_FLUSH > > 你这是30天？ > > fileReservedTime这个是什么意思啊 默认是 48 需要改吗  其实这个参数，我也不确定，默认是48小时，如果延时消息超过48小时，会不会也被清理 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix slave acting master bug [rocketmq]
gaoyf opened a new pull request, #7603: URL: https://github.com/apache/rocketmq/pull/7603 ### Which Issue(s) This PR Fixes Fixes #7601 ### Brief Description Fix #7601's exception and master use slave's TimerCheckPoint。 ### How Did You Test This Change? Use #7601's reproduce step to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #639 fix semantics of topicOfInterest [rocketmq-clients]
lizhanhui merged PR #642: URL: https://github.com/apache/rocketmq-clients/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] topicsOfInterest should pass a reference instead of a value [rocketmq-clients]
lizhanhui closed issue #639: [Bug] topicsOfInterest should pass a reference instead of a value URL: https://github.com/apache/rocketmq-clients/issues/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-clients) branch master updated: fix #639 fix semantics of topicOfInterest (#642)
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new c38f7d55 fix #639 fix semantics of topicOfInterest (#642)
c38f7d55 is described below
commit c38f7d55cbceebb122c47f25a6cad72af210066c
Author: Zhanhui Li
AuthorDate: Fri Dec 1 15:48:59 2023 +0800
fix #639 fix semantics of topicOfInterest (#642)
Signed-off-by: Zhanhui Li
---
cpp/.gitignore | 1 +
cpp/source/rocketmq/Producer.cpp | 2 +-
cpp/source/rocketmq/ProducerImpl.cpp | 18 --
cpp/source/rocketmq/PushConsumerImpl.cpp | 2 +-
cpp/source/rocketmq/SimpleConsumerImpl.cpp | 2 +-
cpp/source/rocketmq/include/ClientImpl.h | 2 +-
cpp/source/rocketmq/include/ProducerImpl.h | 4 +++-
cpp/source/rocketmq/include/PushConsumerImpl.h | 2 +-
cpp/source/rocketmq/include/SimpleConsumerImpl.h | 2 +-
9 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/cpp/.gitignore b/cpp/.gitignore
index 23e0e933..b7f10c0f 100644
--- a/cpp/.gitignore
+++ b/cpp/.gitignore
@@ -18,3 +18,4 @@ bazel-rocketmq-client-cpp
/bazel-*
/compile_commands.json
/.cache/
+.clangd
diff --git a/cpp/source/rocketmq/Producer.cpp b/cpp/source/rocketmq/Producer.cpp
index 8620f681..78d812ed 100644
--- a/cpp/source/rocketmq/Producer.cpp
+++ b/cpp/source/rocketmq/Producer.cpp
@@ -88,7 +88,7 @@ ProducerBuilder&
ProducerBuilder::withConfiguration(Configuration configuration)
}
ProducerBuilder& ProducerBuilder::withTopics(const std::vector&
topics) {
- impl_->topicsOfInterest(topics);
+ impl_->withTopics(topics);
return *this;
}
diff --git a/cpp/source/rocketmq/ProducerImpl.cpp
b/cpp/source/rocketmq/ProducerImpl.cpp
index 32b2ecad..73130161 100644
--- a/cpp/source/rocketmq/ProducerImpl.cpp
+++ b/cpp/source/rocketmq/ProducerImpl.cpp
@@ -16,6 +16,7 @@
*/
#include "ProducerImpl.h"
+#include
#include
#include
@@ -575,9 +576,22 @@ void
ProducerImpl::onOrphanedTransactionalMessage(MessageConstSharedPtr message)
}
}
-void ProducerImpl::topicsOfInterest(std::vector topics) {
+void ProducerImpl::topicsOfInterest(std::vector &topics) {
absl::MutexLock lk(&topics_mtx_);
- topics_.swap(topics);
+ for (auto& topic : topics_) {
+if (std::find(topics.begin(), topics.end(), topic) == topics.end()) {
+ topics.push_back(topic);
+}
+ }
+}
+
+void ProducerImpl::withTopics(const std::vector &topics) {
+ absl::MutexLock lk(&topics_mtx_);
+ for (auto &topic: topics) {
+if (std::find(topics_.begin(), topics_.end(), topic) == topics_.end()) {
+ topics_.push_back(topic);
+}
+ }
}
void ProducerImpl::buildClientSettings(rmq::Settings& settings) {
diff --git a/cpp/source/rocketmq/PushConsumerImpl.cpp
b/cpp/source/rocketmq/PushConsumerImpl.cpp
index d73407b4..505854db 100644
--- a/cpp/source/rocketmq/PushConsumerImpl.cpp
+++ b/cpp/source/rocketmq/PushConsumerImpl.cpp
@@ -47,7 +47,7 @@ PushConsumerImpl::~PushConsumerImpl() {
shutdown();
}
-void PushConsumerImpl::topicsOfInterest(std::vector topics) {
+void PushConsumerImpl::topicsOfInterest(std::vector &topics) {
absl::MutexLock lk(&topic_filter_expression_table_mtx_);
for (const auto& entry : topic_filter_expression_table_) {
topics.push_back(entry.first);
diff --git a/cpp/source/rocketmq/SimpleConsumerImpl.cpp
b/cpp/source/rocketmq/SimpleConsumerImpl.cpp
index 09acb7ab..7a1b3edf 100644
--- a/cpp/source/rocketmq/SimpleConsumerImpl.cpp
+++ b/cpp/source/rocketmq/SimpleConsumerImpl.cpp
@@ -67,7 +67,7 @@ void SimpleConsumerImpl::buildClientSettings(rmq::Settings&
settings) {
}
}
-void SimpleConsumerImpl::topicsOfInterest(std::vector topics) {
+void SimpleConsumerImpl::topicsOfInterest(std::vector &topics) {
absl::MutexLock lk(&subscriptions_mtx_);
for (const auto& entry : subscriptions_) {
if (std::find(topics.begin(), topics.end(), entry.first) == topics.end()) {
diff --git a/cpp/source/rocketmq/include/ClientImpl.h
b/cpp/source/rocketmq/include/ClientImpl.h
index 70dc5382..c266047a 100644
--- a/cpp/source/rocketmq/include/ClientImpl.h
+++ b/cpp/source/rocketmq/include/ClientImpl.h
@@ -167,7 +167,7 @@ protected:
absl::flat_hash_map> session_map_
GUARDED_BY(session_map_mtx_);
absl::Mutex session_map_mtx_;
- virtual void topicsOfInterest(std::vector topics) {
+ virtual void topicsOfInterest(std::vector &topics) {
}
void updateRouteInfo() LOCKS_EXCLUDED(topic_route_table_mtx_);
diff --git a/cpp/source/rocketmq/include/ProducerImpl.h
b/cpp/source/rocketmq/include/ProducerImpl.h
index ad9b24d5..d7260a93 100644
--- a/cpp/source/rocketmq/include/ProducerImpl.h
+++ b/cpp/source/rocketmq/include/ProducerImpl.h
@@ -107,7 +107,9 @@ public:
void buildClientSettings(rmq::Settings& settings) override;
- void topicsOfI
Re: [I] 5.x启动Broker+Proxy 命令，希望有win版本的，另外任意时间精度的延时，最大延时时间的完整配置，没在文档中找到 [rocketmq]
cyao2q commented on issue #7459: URL: https://github.com/apache/rocketmq/issues/7459#issuecomment-1835632638 > > > 我只在broker.conf里配置了，就没报这个错： brokerClusterName = DefaultCluster brokerName = broker-a brokerId = 0 deleteWhen = 04 fileReservedTime = 720 timerMaxDelaySec = 2592000 brokerRole = ASYNC_MASTER flushDiskType = ASYNC_FLUSH > > > 你这是30天？ > > > fileReservedTime这个是什么意思啊 默认是 48 需要改吗 > >  其实这个参数，我也不确定，默认是48小时，如果延时消息超过48小时，会不会也被清理 我现在不清楚是否正常了 发的延时消息也看不到 我简单试试吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Node.js Coverage" failed!
The GitHub Actions job "Node.js Coverage" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: c38f7d55cbceebb122c47f25a6cad72af210066c / Zhanhui Li fix #639 fix semantics of topicOfInterest (#642) Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7057243888 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user gaoyf (triggered by gaoyf). Head commit for run: 350962115900b3c376395c354f8f4881c5fa205d / yongfeigao fix timerCheckPoint of the master is not updated, causing the timer message to be replayed after master is restarted Report URL: https://github.com/apache/rocketmq/actions/runs/7057248788 With regards, GitHub Actions via GitBox
