844028312 commented on code in PR #104:
URL: https://github.com/apache/rocketmq-flink/pull/104#discussion_r1410607779


##########
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##########
@@ -240,7 +239,14 @@ public CompletableFuture<Long> 
seekCommittedOffset(MessageQueue messageQueue) {
                         long offset =
                                 consumer.getOffsetStore()
                                         .readOffset(messageQueue, 
ReadOffsetType.READ_FROM_STORE);
-                        LOG.error(
+                        if (offset == -1) {
+                            offset = adminExt.minOffset(messageQueue);
+                            LOG.info(
+                                    "Consumer seek committed offset from 
remote, offset=-1,mq={},use minOffset={}",

Review Comment:
   已修改



##########
src/main/java/org/apache/flink/connector/rocketmq/source/InnerConsumerImpl.java:
##########
@@ -240,7 +239,14 @@ public CompletableFuture<Long> 
seekCommittedOffset(MessageQueue messageQueue) {
                         long offset =
                                 consumer.getOffsetStore()
                                         .readOffset(messageQueue, 
ReadOffsetType.READ_FROM_STORE);
-                        LOG.error(
+                        if (offset == -1) {
+                            offset = adminExt.minOffset(messageQueue);
+                            LOG.info(
+                                    "Consumer seek committed offset from 
remote, offset=-1,mq={},use minOffset={}",

Review Comment:
   已修改



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to