caigy commented on code in PR #186:
URL: https://github.com/apache/rocketmq-operator/pull/186#discussion_r1411613390
##########
pkg/controller/broker/broker_controller.go:
##########
@@ -398,6 +402,15 @@ func getBrokerName(broker *rocketmqv1alpha1.Broker,
brokerGroupIndex int) string
return broker.Name + "-" + strconv.Itoa(brokerGroupIndex)
}
+func isReady(po corev1.Pod) bool {
+ for _, cond := range po.Status.Conditions {
+ if cond.Type == corev1.PodReady {
Review Comment:
Should we check `PodReady` status at this stage? The brokers may be just
started and initializing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
