Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
tensory2022 commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1774618414 @joeCarf Thanks for your PR. Hope it will be merged soon. The code you require is at: org.apache.rocketmq.client.impl.factory.MQClientInstance.  And the scheduled time interval should be 5 seconds instead of 10 seconds I declared before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]
joeCarf commented on PR #7490: URL: https://github.com/apache/rocketmq/pull/7490#issuecomment-1774624815 @RongtongJin hi~ PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]
RongtongJin merged PR #7490: URL: https://github.com/apache/rocketmq/pull/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: [ISSUE #7489] Code comment enhancement in example (#7490)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 8f020b397a [ISSUE #7489] Code comment enhancement in example (#7490)
8f020b397a is described below
commit 8f020b397a3afdd75429ae91e3624812b8ffc9e1
Author: Ao Qiao
AuthorDate: Mon Oct 23 16:34:10 2023 +0800
[ISSUE #7489] Code comment enhancement in example (#7490)
* Doc: How to debug in Idea
* en
* enhance code comment
---
.../src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/example/src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java
b/example/src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java
index 5ac8d247d9..e1a02aa266 100644
--- a/example/src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java
+++ b/example/src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java
@@ -75,7 +75,7 @@ public class PullConsumer {
if (msgs != null &&
!msgs.isEmpty()) {
this.doSomething(msgs);
-//update offset to broker
+//update offset to local
memory, eventually to broker
consumer.updateConsumeOffset(messageQueue, pullResult.getNextBeginOffset());
//print pull tps
this.incPullTPS(topic,
pullResult.getMsgFoundList().size());
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
RongtongJin closed issue #7489: Code comments of updateConsumeOffset() should be corrected URL: https://github.com/apache/rocketmq/issues/7489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6610737703 With regards, GitHub Actions via GitBox
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
RongtongJin commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774711634 > Why delete this method? How to obtain ACL configuration through the interface after deletion Suggested to check on the corresponding broker machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6610737722 With regards, GitHub Actions via GitBox
[I] [Bug] controller metricsExporterType config not working [rocketmq]
iamgd67 opened a new issue, #7491: URL: https://github.com/apache/rocketmq/issues/7491 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos 7 ### RocketMQ version 5.1.3 ### JDK Version 1.8 ### Describe the Bug metricsExporterType=PROM, but no port listens appear ### Steps to Reproduce just set the config ### What Did You Expect to See? listen to 5557 ### What Did You See Instead? no port listen ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
iamgd67 opened a new pull request, #7492: URL: https://github.com/apache/rocketmq/pull/7492 ### Which Issue(s) This PR Fixes Fixes #7491 ### Brief Description config file using `MixAll.properties2Object` to load not support enum type. so add a `String` arg one ### How Did You Test This Change? after this change, metric port listen appear as expect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: https://github.com/apache/rocketmq/actions/runs/6611179090 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6610737707 With regards, GitHub Actions via GitBox
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774781573 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine Yes, this is indeed possible. But I want to know, what are the reasons for doing this? Why delete it? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774787858 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine > >> Yes, this is indeed possible. But I want to know, what are the reasons for doing this? Why delete it? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6611218659 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: https://github.com/apache/rocketmq/actions/runs/6611179087 With regards, GitHub Actions via GitBox
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
DongyuanPan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774804913 MQTT协议里面client和server角色是不严格区分的，是可以交换的。所以这个QOS我们理解是一个双方交互的一个协议规范，例如需不需要恢复ACK等。所以发送的时候由发送者在message里面设置qos，表示要和服务端以相应的qos进行交互。作为接收者的时候，通过subscribe 告诉服务器，接收者想要以何种qos进行交互，随后服务端给接收者推送消息，就会按照这个进行。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
DongyuanPan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774805595 也就是说，是独立的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774825413 emqx的实现 https://github.com/apache/rocketmq-mqtt/assets/2684384/784702dd-b89b-4354-9317-fd28d9a1d5a3";> 是取了消息和订阅者的min，实测也是这样的。 这块mqtt文档中，没有说的很明显。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774827367 mqtt的文档这里确实没有看到有这个说法，可以先保持这样倒也可以。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 5d0e456b472b57bfc8a5eee05924a57cb621f7a6 / 67 <6...@gd67.com> [ISSUE #7491] metricsExporterType enum config support Report URL: https://github.com/apache/rocketmq/actions/runs/6611179086 With regards, GitHub Actions via GitBox
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774908311 ![Uploading mmexport1698057384240.jpg…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] error Caused by: java.util.concurrent.CancellationException: Task was cancelled. [rocketmq]
x43125 commented on issue #7239: URL: https://github.com/apache/rocketmq/issues/7239#issuecomment-1774916919 I meet the same question When I followed the official quickstart steps, there was an error sending a message (https://rocketmq.apache.org/zh/docs/quickStart/01quickstart) server: aliyun centos7 rocketmq5.1.4 client: macos idea rocketmq-client-java:5.0.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 当生产者和消费者的Qos等级不同时，当前似乎没有实现降级 [rocketmq-mqtt]
leizhiyuan commented on issue #214: URL: https://github.com/apache/rocketmq-mqtt/issues/214#issuecomment-1774952495 https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/csd02/mqtt-v3.1.1-csd02.html https://github.com/apache/rocketmq-mqtt/assets/2684384/bb6c0dc4-a75a-4e0a-9152-69ec44c58b64";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 能否release一个 支持mac m2 的 构建后的包 非常感谢 [rocketmq-client-cpp]
lpflpf commented on issue #459: URL: https://github.com/apache/rocketmq-client-cpp/issues/459#issuecomment-1774961526 应该是ARM 版本的， darwin 是intel 芯片的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #539] Feat: support SpringBoot 3.x [rocketmq-spring]
xuxiaocong commented on PR #541: URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1775030643 入口类增加 @Import(RocketMQAutoConfiguration.class) 配置需要下面三个 rocketmq.name-server=xxx rocketmq.producer.group=xxx rocketmq.pull-consumer.group=xxx # 无法监听的增加这个配置就行了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863475 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6612888942 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863476 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]
codecov-commenter commented on PR #7494: URL: https://github.com/apache/rocketmq/pull/7494#issuecomment-1775075331 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7494](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d1922de) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.05%`. > Report is 3 commits behind head on develop. > The diff coverage is `22.22%`. ```diff @@ Coverage Diff @@ ## develop#7494 +/- ## = + Coverage 42.93% 42.99% +0.05% - Complexity 9660 9676 +16 = Files 1161 1161 Lines 8393083950 +20 Branches 1089810899 +1 = + Hits 3603836094 +56 + Misses 4341043385 -25 + Partials4482 4471 -11 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...apache/rocketmq/remoting/netty/NettyEventType.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5RXZlbnRUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `78.37% <0.00%> (ø)` | | | [...ketmq/broker/client/ClientHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NsaWVudEhvdXNla2VlcGluZ1NlcnZpY2UuamF2YQ==) | `30.30% <0.00%> (-0.95%)` | :arrow_down: | | [...rocketmq/controller/BrokerHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9Ccm9rZXJIb3VzZWtlZXBpbmdTZXJ2aWNlLmphdmE=) | `58.33% <0.00%> (-5.31%)` | :arrow_down: | | [...q/namesrv/routeinfo/BrokerHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQnJva2VySG91c2VrZWVwaW5nU2VydmljZS5qYXZh) | `63.63% <0.00%> (-6.37%)` | :arrow_down: | | [...etmq/proxy/remoting/ClientHousekeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL0NsaWVudEhvdXNla2VlcGluZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `56.80% <0.00%> (-0.34%)` | :arrow_down: | | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `40.55% <66.66%> (+0.25%)` | :arrow_up: | | [.../container/ContainerClientHouseKeepingService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7494?src=pr&el=tree&utm_medium=referral&utm_source=github&u
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863475 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863464 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863475 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863475 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863475 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d1922de132c1dea4b0bbba73292cae321dedcb2f / zhouxiang Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6612863464 With regards, GitHub Actions via GitBox
[PR] Java 4.x-fix [rocketmq-e2e]
Zintoki opened a new pull request, #54: URL: https://github.com/apache/rocketmq-e2e/pull/54 ## Brief changelog Reduce the number of topic creation times and increase the wait time appropriately to ensure that all tests pass under concurrent testing ## Checklist - [x] Reduce the number of topics created in tests such as retry and increase the message waiting time in tests such as batchproducer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] commented on PR #5360: URL: https://github.com/apache/rocketmq/pull/5360#issuecomment-1776247804 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] closed issue #5359: Optimize the heartbeat check pre-collection address URL: https://github.com/apache/rocketmq/issues/5359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error core-concept url in comment. [rocketmq]
github-actions[bot] commented on issue #5358: URL: https://github.com/apache/rocketmq/issues/5358#issuecomment-1776247867 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Resolve the unstable unit tests [rocketmq]
github-actions[bot] commented on issue #5331: URL: https://github.com/apache/rocketmq/issues/5331#issuecomment-1776247902 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] closed pull request #5360: [ISSUE#5359] Optimize the heartbeat check pre-collection address URL: https://github.com/apache/rocketmq/pull/5360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] commented on issue #5359: URL: https://github.com/apache/rocketmq/issues/5359#issuecomment-1776247832 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error core-concept url in comment. [rocketmq]
github-actions[bot] closed issue #5358: Error core-concept url in comment. URL: https://github.com/apache/rocketmq/issues/5358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Resolve the unstable unit tests [rocketmq]
github-actions[bot] closed issue #5331: Resolve the unstable unit tests URL: https://github.com/apache/rocketmq/issues/5331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] How to use Rocketmq Ledger cluster mode for spring boot？ [rocketmq]
github-actions[bot] commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1776247923 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] How to use Rocketmq Ledger cluster mode for spring boot？ [rocketmq]
github-actions[bot] closed issue #5330: How to use Rocketmq Ledger cluster mode for spring boot？ URL: https://github.com/apache/rocketmq/issues/5330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [NameServer启动失败] JDK17启动NameServer时失败 [rocketmq]
PottermoreIron opened a new issue, #7495: URL: https://github.com/apache/rocketmq/issues/7495 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Windows 10 JDK17 ### RocketMQ version 5.1.4 ### JDK Version Oracle JDK17 ### Describe the Bug 在bin目录下启动mqnamesrv.cmd时报错： Unrecognized VM option 'UseConcMarkSweepGC' Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ### Steps to Reproduce 在RocketMQ安装目录下启动mqnamesrv.cmd报错 ### What Did You Expect to See? NameServer启动成功，终端输出：The Name Server boot success. serializeType=JSON, address 0.0.0.0:9876 ### What Did You See Instead? Unrecognized VM option 'UseConcMarkSweepGC' Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit ### Additional Context 应该是JDK版本的问题，查询了网上的资料，发现由于GC相关机制的改变，RocketMQ脚本的配置没有配合JDK高版本。我找到了一篇博客http://www.fastrabbit.cn/articles/42. 根据博客修改了cmd，最后NameServer启动成功。但还是希望RocketMQ能支持JDK高版本，毕竟没法保证每个项目都使用JDK8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6620584380 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs/6621473722 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs/6621473725 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener [rocketmq]
drpmma closed issue #7493: [Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener URL: https://github.com/apache/rocketmq/issues/7493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494)
This is an automated email from the ASF dual-hosted git repository.
zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 2043dd5034 [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE
(#7494)
2043dd5034 is described below
commit 2043dd50341e0a4a2f254d72aa3109f4dfc97aac
Author: Zhouxiang Zhan
AuthorDate: Tue Oct 24 10:29:43 2023 +0800
[ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494)
* [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for
ChannelEventListener
* introduce a new event NettyEventType.ACTIVE,
* implement channelActive interface for
NettyRemotingClient#NettyConnectManageHandler
* add onChannelActive for ChannelEventListener interface.
* Move send heartbeat to onChannelActive
---
.../broker/client/ClientHousekeepingService.java | 5 +
.../client/impl/factory/MQClientInstance.java| 20
.../ContainerClientHouseKeepingService.java | 11 ++-
.../controller/BrokerHousekeepingService.java| 5 +
.../namesrv/routeinfo/BrokerHousekeepingService.java | 5 +
.../proxy/remoting/ClientHousekeepingService.java| 4
.../rocketmq/remoting/ChannelEventListener.java | 2 ++
.../rocketmq/remoting/netty/NettyEventType.java | 3 ++-
.../remoting/netty/NettyRemotingAbstract.java| 3 +++
.../rocketmq/remoting/netty/NettyRemotingClient.java | 11 +++
10 files changed, 59 insertions(+), 10 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/client/ClientHousekeepingService.java
b/broker/src/main/java/org/apache/rocketmq/broker/client/ClientHousekeepingService.java
index cbb81f632b..7878d0eec5 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/client/ClientHousekeepingService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/client/ClientHousekeepingService.java
@@ -87,4 +87,9 @@ public class ClientHousekeepingService implements
ChannelEventListener {
this.brokerController.getConsumerManager().doChannelCloseEvent(remoteAddr,
channel);
this.brokerController.getBrokerStatsManager().incChannelIdleNum();
}
+
+@Override
+public void onChannelActive(String remoteAddr, Channel channel) {
+
+}
}
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
index 09534a1768..ba72a6dce7 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
@@ -159,14 +159,6 @@ public class MQClientInstance {
private final ConcurrentMap>
brokerAddrTable = MQClientInstance.this.brokerAddrTable;
@Override
public void onChannelConnect(String remoteAddr, Channel
channel) {
-for (Map.Entry> addressEntry
: brokerAddrTable.entrySet()) {
-for (String address :
addressEntry.getValue().values()) {
-if (address.equals(remoteAddr)) {
-sendHeartbeatToAllBrokerWithLockV2(false);
-break;
-}
-}
-}
}
@Override
@@ -180,6 +172,18 @@ public class MQClientInstance {
@Override
public void onChannelIdle(String remoteAddr, Channel channel) {
}
+
+@Override
+public void onChannelActive(String remoteAddr, Channel
channel) {
+for (Map.Entry> addressEntry
: brokerAddrTable.entrySet()) {
+for (String address :
addressEntry.getValue().values()) {
+if (address.equals(remoteAddr)) {
+sendHeartbeatToAllBrokerWithLockV2(false);
+break;
+}
+}
+}
+}
};
} else {
channelEventListener = null;
diff --git
a/container/src/main/java/org/apache/rocketmq/container/ContainerClientHouseKeepingService.java
b/container/src/main/java/org/apache/rocketmq/container/ContainerClientHouseKeepingService.java
index 8bf4b4a33d..90c912247e 100644
---
a/container/src/main/java/org/apache/rocketmq/container/ContainerClientHouseKeepingService.java
+++
b/container/src/main/java/org/apache/rocketmq/container/ContainerClientHouseKeepingService.java
@@ -49,6 +49,11 @@ public class ContainerClientHouseKeepingService implements
ChannelEventListener
onChannelOperation(CallbackCode.IDLE, remoteAddr, channel);
Re: [PR] [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE [rocketmq]
drpmma merged PR #7494: URL: https://github.com/apache/rocketmq/pull/7494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8f020b397a3afdd75429ae91e3624812b8ffc9e1 / Ao Qiao [ISSUE #7489] Code comment enhancement in example (#7490) * Doc: How to debug in Idea * en * enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6621496876 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc641130b8e4c1d428b3216572d250f61f6578b / RongtongJin Add log Report URL: https://github.com/apache/rocketmq/actions/runs/6621473723 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6621603301 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6621603300 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6621603302 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
joeCarf commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369491571
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢
https://github.com/apache/rocketmq/assets/52153761/cd865865-03ad-4b27-b754-5d3cd54b7f9f";>
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢
https://github.com/apache/rocketmq/assets/52153761/cd865865-03ad-4b27-b754-5d3cd54b7f9f";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs/6621743246 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
iamgd67 commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
> 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
是设置配置时，通过MixAll.properties2Object 反射调用的
查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
> 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
是设置配置时，通过MixAll.properties2Object 反射调用的
查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
iamgd67 commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
> 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
是设置配置时，通过MixAll.properties2Object 反射调用的
查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式
by the way， 是 重载 不是 重写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
joeCarf commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369497349
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
配置时是使用的int类型吗
https://github.com/apache/rocketmq/assets/52153761/d5143092-6b2f-49ae-af64-8069b0c29ecb";>
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
配置时是使用的int类型吗
https://github.com/apache/rocketmq/assets/52153761/d5143092-6b2f-49ae-af64-8069b0c29ecb";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
iamgd67 commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369494853
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
> 当前代码中已经有类似的方法，你这里新写的方法是否会被调用到呢 https://user-images.githubusercontent.com/52153761/277535786-cd865865-03ad-4b27-b754-5d3cd54b7f9f.png";>
是设置配置时，通过MixAll.properties2Object 反射调用的
查看下issue，目前配置打开metric，因为类型不是string，设置不进来，配置不生效，，brokerConfig里是这样的处理方式
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6621757840 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
joeCarf commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369510016
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
sorry，之前看错了。Get it
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
sorry，之前看错了。Get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
joeCarf commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369513486
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
some test workflow failed, maybe you need to rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs/6621743244 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7480] Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]
codecov-commenter commented on PR #7488: URL: https://github.com/apache/rocketmq/pull/7488#issuecomment-1776447461 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7488](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ae2c2b1) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.04%`. > Report is 4 commits behind head on develop. > The diff coverage is `9.09%`. ```diff @@ Coverage Diff @@ ## develop#7488 +/- ## = + Coverage 42.93% 42.98% +0.04% - Complexity 9660 9677 +17 = Files 1161 1161 Lines 8393083959 +29 Branches 1089810901 +3 = + Hits 3603836087 +49 + Misses 4341043399 -11 + Partials4482 4473 -9 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `78.37% <0.00%> (ø)` | | | [...apache/rocketmq/store/timer/TimerMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | `53.47% <10.00%> (-0.37%)` | :arrow_down: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7488/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6621603295 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs/6621743247 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ae2c2b1ee719d32355c87e0ee77f138051de699c / RongtongJin Fix UTs Report URL: https://github.com/apache/rocketmq/actions/runs/6621743247 With regards, GitHub Actions via GitBox
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
caigy commented on code in PR #7486:
URL: https://github.com/apache/rocketmq/pull/7486#discussion_r1369630044
##
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RequestCode.java:
##
@@ -80,8 +80,6 @@ public class RequestCode {
public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG = 53;
-public static final int GET_BROKER_CLUSTER_ACL_CONFIG = 54;
Review Comment:
Should we reserve the request code to avoid duplication in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f77e4b64d546674c7f0a80013db332daf462 / RongtongJin Add @Deprecated annotation to GET_BROKER_CLUSTER_ACL_CONFIG request code Report URL: https://github.com/apache/rocketmq/actions/runs/6622916713 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6622931988 With regards, GitHub Actions via GitBox
Re: [I] [RIP-46] Observability improvement for RocketMQ [rocketmq]
GenerousMan commented on issue #5350: URL: https://github.com/apache/rocketmq/issues/5350#issuecomment-1776603191 Hello, I have completed some broker metrics related to timing and transaction messages. I will initiate a PR and link to this issue's task 3. I hope you can help review it if you have free time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7491] metricsExporterType enum config support [rocketmq]
iamgd67 commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1369689385
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+// support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
retriggered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 1d8c87453ccc79108a0f49c1089d8ca054d46cdb / 67 <6...@gd67.com> re-trigger tests Report URL: https://github.com/apache/rocketmq/actions/runs/6623281698 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 2043dd50341e0a4a2f254d72aa3109f4dfc97aac / Zhouxiang Zhan [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494) * [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener * introduce a new event NettyEventType.ACTIVE, * implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler * add onChannelActive for ChannelEventListener interface. * Move send heartbeat to onChannelActive Report URL: https://github.com/apache/rocketmq/actions/runs/6623304399 With regards, GitHub Actions via GitBox
