Re: [I] [Bug] Stream Load导入json文件失败 [doris]

2024-03-13 Thread via GitHub


liruixl commented on issue #31938:
URL: https://github.com/apache/doris/issues/31938#issuecomment-1993693787

   代码格式有点乱😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [typo](docs) fix typo in pipeline-execution-engine [doris]

2024-03-13 Thread via GitHub


caizj opened a new pull request, #32172:
URL: https://github.com/apache/doris/pull/32172

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [typo](docs) fix typo in pipeline-execution-engine [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32172:
URL: https://github.com/apache/doris/pull/32172#issuecomment-1993694556

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](nereids)unify outputTupleDesc and projection [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32128:
URL: https://github.com/apache/doris/pull/32128#issuecomment-1993697339

   TeamCity be ut coverage result:
Function Coverage: 35.01% (8576/24499) 
Line Coverage: 26.75% (69468/259664)
Region Coverage: 26.02% (36072/138637)
Branch Coverage: 22.97% (18418/80176)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/840552c8084ff590cb1127714ce2c8b50573c31b_840552c8084ff590cb1127714ce2c8b50573c31b/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [typo](docs) fix typo in pipeline-execution-engine [doris]

2024-03-13 Thread via GitHub


caizj commented on PR #32172:
URL: https://github.com/apache/doris/pull/32172#issuecomment-1993698462

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [behavior change](output) change float output format [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32049:
URL: https://github.com/apache/doris/pull/32049#issuecomment-1993699867

   
   
   TPC-H: Total hot run time: 36993 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit ff52d91798b93023dcf9217a24240b1a3552a5b0, 
data reload: false
   
   -- Round 1 --
   q1   19379   424841344134
   q2   2015158 147 147
   q3   10570   897 889 889
   q4   4657705 684 684
   q5   8486278727522752
   q6   196 124 126 124
   q7   1184841 825 825
   q8   9552209120622062
   q9   7481669965886588
   q10  8420265026692650
   q11  2094242 226 226
   q12  1942301 310 301
   q13  22267   307430353035
   q14  275 253 256 253
   q15  504 444 455 444
   q16  495 394 399 394
   q17  1034571 562 562
   q18  6604577757885777
   q19  1555135014481350
   q20  509 279 273 273
   q21  7429323932233223
   q22  781 300 314 300
   Total cold run time: 117429 ms
   Total hot run time: 36993 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4069407840764076
   q2   315 235 224 224
   q3   2998278528312785
   q4   1827153715471537
   q5   5209520152485201
   q6   197 115 114 114
   q7   2239180718121807
   q8   3157326032993260
   q9   8560854185608541
   q10  6155364736343634
   q11  520 447 445 445
   q12  703 550 548 548
   q13  15294   286528532853
   q14  272 238 258 238
   q15  490 450 439 439
   q16  457 399 414 399
   q17  1703146914771469
   q18  7655725570107010
   q19  6954150415461504
   q20  1913169416991694
   q21  4940459046304590
   q22  539 464 460 460
   Total cold run time: 76166 ms
   Total hot run time: 52828 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


924060929 opened a new pull request, #32173:
URL: https://github.com/apache/doris/pull/32173

   ## Proposed changes
   
   the `pom.xml` is commit in #31906 which revert by #32127
   this pr restore the change again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32173:
URL: https://github.com/apache/doris/pull/32173#issuecomment-1993700482

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] 查询报错failed to initialize storage reader [doris]

2024-03-13 Thread via GitHub


hnwkz commented on issue #31299:
URL: https://github.com/apache/doris/issues/31299#issuecomment-1993701516

   > Let me see.
   查到啥问题了没?随机出现这个问题,难搞


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [typo](docs) add additional explanation to the repeat function [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32158:
URL: https://github.com/apache/doris/pull/32158#issuecomment-1993702802

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](nereids)unify outputTupleDesc and projection [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32128:
URL: https://github.com/apache/doris/pull/32128#issuecomment-1993705286

   
   
   TPC-H: Total hot run time: 37018 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 840552c8084ff590cb1127714ce2c8b50573c31b, 
data reload: false
   
   -- Round 1 --
   q1   18255   418841304130
   q2   2015160 147 147
   q3   10573   911 902 902
   q4   4651742 674 674
   q5   7600279927742774
   q6   186 124 128 124
   q7   1192813 811 811
   q8   9468207320682068
   q9   7503661565876587
   q10  8212261326102610
   q11  406 216 212 212
   q12  781 299 298 298
   q13  17961   303029842984
   q14  272 253 249 249
   q15  492 447 460 447
   q16  474 390 408 390
   q17  954 539 580 539
   q18  6633582857685768
   q19  1559150014221422
   q20  567 291 281 281
   q21  7370333032983298
   q22  806 303 306 303
   Total cold run time: 107930 ms
   Total hot run time: 37018 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4181407440624062
   q2   327 223 237 223
   q3   3019288228062806
   q4   1841155315401540
   q5   5242531052815281
   q6   194 116 118 116
   q7   2255185718801857
   q8   3178329432813281
   q9   8680866586018601
   q10  6200378037703770
   q11  551 448 437 437
   q12  712 540 555 540
   q13  12680   287328402840
   q14  291 240 258 240
   q15  491 439 437 437
   q16  445 393 400 393
   q17  1744147514611461
   q18  7461723272187218
   q19  1606151115641511
   q20  1881169617401696
   q21  4864461146494611
   q22  530 460 442 442
   Total cold run time: 68373 ms
   Total hot run time: 53363 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


morrySnow commented on PR #32173:
URL: https://github.com/apache/doris/pull/32173#issuecomment-1993705841

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32173:
URL: https://github.com/apache/doris/pull/32173#issuecomment-1993706514

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32173:
URL: https://github.com/apache/doris/pull/32173#issuecomment-1993706552

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993707722

   
   
   TPC-H: Total hot run time: 36405 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 336d0fa5d664fa889abdd30808e886786693da4f, 
data reload: false
   
   -- Round 1 --
   q1   17666   421641064106
   q2   2019151 143 143
   q3   10577   914 893 893
   q4   4644655 721 655
   q5   7595272927672729
   q6   191 127 130 127
   q7   1189799 792 792
   q8   9463201520292015
   q9   7291646164906461
   q10  8163248525172485
   q11  421 219 212 212
   q12  790 300 283 283
   q13  17974   301729792979
   q14  271 251 259 251
   q15  493 464 446 446
   q16  481 394 393 393
   q17  935 513 529 513
   q18  6594577057945770
   q19  1562141114221411
   q20  544 274 274 274
   q21  7372318132543181
   q22  845 286 297 286
   Total cold run time: 107080 ms
   Total hot run time: 36405 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4065408740454045
   q2   325 220 232 220
   q3   2972283028552830
   q4   1850154215881542
   q5   5181524051835183
   q6   196 117 115 115
   q7   2255183218051805
   q8   3125328632533253
   q9   8529847385048473
   q10  6094371837023702
   q11  530 442 439 439
   q12  711 581 577 577
   q13  12792   287928392839
   q14  261 249 256 249
   q15  475 438 445 438
   q16  445 420 407 407
   q17  1707146514481448
   q18  7414721971177117
   q19  5217150114911491
   q20  1885169516901690
   q21  4871457247444572
   q22  518 414 460 414
   Total cold run time: 71418 ms
   Total hot run time: 52849 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] save code null aware in runtime filter [doris]

2024-03-13 Thread via GitHub


HappenLee commented on PR #32152:
URL: https://github.com/apache/doris/pull/32152#issuecomment-1993708906

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


eldenmoon opened a new pull request, #32174:
URL: https://github.com/apache/doris/pull/32174

   …o variant columns, and ensure `inherit_tablet_index` is called only once
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993709817

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


eldenmoon commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993710801

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression test) fix miss function getFeConfig [doris]

2024-03-13 Thread via GitHub


yujun777 commented on PR #32167:
URL: https://github.com/apache/doris/pull/32167#issuecomment-1993711574

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [behavior change](output) change float output format [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32049:
URL: https://github.com/apache/doris/pull/32049#issuecomment-1993712626

   
   
   TPC-DS: Total hot run time: 186516 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit ff52d91798b93023dcf9217a24240b1a3552a5b0, 
data reload: false
   
   query1   929 359 339 339
   query2   7456191619301916
   query3   6693211 203 203
   query4   31272   20690   20648   20648
   query5   4313407 526 407
   query6   260 171 180 171
   query7   4625284 296 284
   query8   227 179 172 172
   query9   9923227022472247
   query10  452 233 243 233
   query11  14643   14059   14153   14059
   query12  138 90  85  85
   query13  1630409 412 409
   query14  11586   10315   10440   10315
   query15  253 216 193 193
   query16  7945258 248 248
   query17  1942550 518 518
   query18  2048276 272 272
   query19  197 148 145 145
   query20  107 81  80  80
   query21  204 128 120 120
   query22  4636446144174417
   query23  31773   30963   30997   30963
   query24  11027   280227902790
   query25  551 358 376 358
   query26  759 158 171 158
   query27  2397352 341 341
   query28  6547184118721841
   query29  897 637 618 618
   query30  301 145 151 145
   query31  972 703 735 703
   query32  97  62  59  59
   query33  794 260 253 253
   query34  1057472 465 465
   query35  831 603 595 595
   query36  1015892 884 884
   query37  110 76  76  76
   query38  3266312731463127
   query39  1401138413751375
   query40  206 107 117 107
   query41  50  46  47  46
   query42  99  96  96  96
   query43  498 443 465 443
   query44  1368735 706 706
   query45  275 239 254 239
   query46  1098674 685 674
   query47  1678158315971583
   query48  433 364 355 355
   query49  1091353 343 343
   query50  767 367 376 367
   query51  6767675567406740
   query52  105 97  92  92
   query53  339 275 279 275
   query54  309 233 246 233
   query55  81  79  82  79
   query56  242 249 249 249
   query57  10761028982 982
   query58  225 198 225 198
   query59  2831259425962594
   query60  257 282 249 249
   query61  123 108 108 108
   query62  605 400 393 393
   query63  304 283 275 275
   query64  4947394739283928
   query65  3058299829982998
   query66  846 331 324 324
   query67  14855   14396   14736   14396
   query68  6443522 520 520
   query69  616 397 409 397
   query70  1306119011041104
   query71  481 289 299 289
   query72  6869267324612461
   query73  709 313 318 313
   query74  7518660365406540
   query75  9280801780548017
   query76  4298994 987 987
   query77  629 254 263 254
   query78  10391   963695629562
   query79  9342522 528 522
   query80  2019394 381 381
   query81  545 210 210 210
   query82  1575194 196 194
   query83  296 145 143 143
   query84  284 81  76  76
   query85  1455365 307 307
   query86  477 319 294 294
   query87  3458316532723165
   query88  4993230522842284
   query89  535 362 380 362
   query90  1942173 178 173
   query91  168 149 129 129
   query92  58  49  46  46
   query93  6872505 489 489
   query94  1200173 175 173
   query95  435 331 329 329
   query96  600 268 274 268
   query97  4415426643234266
   query98  228 205 211 205
   query99  1105775 752 752
   Total cold run time: 310349 ms
   Total hot run time: 186516 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th

Re: [PR] [feature](Nereids) support agg state type in create table [doris]

2024-03-13 Thread via GitHub


morrySnow commented on PR #32171:
URL: https://github.com/apache/doris/pull/32171#issuecomment-1993713524

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](top-n) do not update topn filter when sort node and scan node are not in the… [doris]

2024-03-13 Thread via GitHub


dataroaring merged PR #32159:
URL: https://github.com/apache/doris/pull/32159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (b4f471050a7 -> 99680e9ec13)

2024-03-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from b4f471050a7 [fix](merge-clod) fix file not found when load for mow 
table (#32144)
 add 99680e9ec13 [Bug](top-n) do not update topn filter when sort node and 
scan node are not in the… (#32159)

No new revisions were added by this update.

Summary of changes:
 be/src/olap/tablet_reader.cpp   |  2 --
 be/src/pipeline/exec/sort_sink_operator.cpp | 14 --
 be/src/runtime/runtime_predicate.h  | 10 --
 be/src/vec/exec/vsort_node.cpp  | 14 --
 4 files changed, 24 insertions(+), 16 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32169:
URL: https://github.com/apache/doris/pull/32169#issuecomment-1993722851

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993721084

   
   
   TPC-DS: Total hot run time: 187117 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 336d0fa5d664fa889abdd30808e886786693da4f, 
data reload: false
   
   query1   922 366 331 331
   query2   7624208919531953
   query3   6709220 213 213
   query4   30975   20561   20622   20561
   query5   4289422 402 402
   query6   260 174 184 174
   query7   4622296 295 295
   query8   226 167 168 167
   query9   9971227022482248
   query10  440 234 258 234
   query11  17202   14112   14377   14112
   query12  128 84  84  84
   query13  1638422 417 417
   query14  11671   11169   10801   10801
   query15  271 229 184 184
   query16  8084260 256 256
   query17  1936559 529 529
   query18  2095276 268 268
   query19  273 152 143 143
   query20  94  83  85  83
   query21  195 131 120 120
   query22  4614451344554455
   query23  31749   31033   3   31033
   query24  10802   287728552855
   query25  586 349 358 349
   query26  1214159 156 156
   query27  2500353 349 349
   query28  7760190118451845
   query29  863 626 600 600
   query30  306 144 147 144
   query31  989 697 734 697
   query32  88  58  58  58
   query33  754 249 248 248
   query34  1072474 481 474
   query35  845 617 588 588
   query36  967 891 895 891
   query37  116 76  79  76
   query38  3285314931573149
   query39  1406139713571357
   query40  205 125 112 112
   query41  48  46  47  46
   query42  98  99  100 99
   query43  500 463 449 449
   query44  1328705 707 705
   query45  270 269 263 263
   query46  1097713 695 695
   query47  1669157015921570
   query48  432 344 351 344
   query49  1115327 317 317
   query50  764 374 373 373
   query51  6764672767576727
   query52  106 89  89  89
   query53  342 266 274 266
   query54  295 232 232 232
   query55  89  78  77  77
   query56  232 216 223 216
   query57  1079992 1012992
   query58  224 191 196 191
   query59  2732258725732573
   query60  252 244 238 238
   query61  98  88  87  87
   query62  614 394 399 394
   query63  306 275 275 275
   query64  5550383239123832
   query65  3090300829812981
   query66  855 345 325 325
   query67  14872   14487   14297   14297
   query68  5299534 520 520
   query69  577 378 385 378
   query70  1161110511181105
   query71  440 273 282 273
   query72  6342275826152615
   query73  703 317 319 317
   query74  7092656566216565
   query75  8773803380788033
   query76  3533892 1047892
   query77  433 280 258 258
   query78  10290   962696219621
   query79  8290517 525 517
   query80  1569409 445 409
   query81  538 211 217 211
   query82  1132202 208 202
   query83  211 145 149 145
   query84  285 83  80  80
   query85  1571387 361 361
   query86  464 296 312 296
   query87  3458319732343197
   query88  5214230023232300
   query89  530 361 361 361
   query90  2044176 172 172
   query91  153 129 127 127
   query92  62  46  45  45
   query93  6401507 491 491
   query94  1140172 176 172
   query95  413 333 318 318
   query96  608 293 271 271
   query97  4396423642864236
   query98  224 219 213 213
   query99  1079753 752 752
   Total cold run time: 308992 ms
   Total hot run time: 187117 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the

Re: [PR] [fix](Nereids): slot set in condition can be empty [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32169:
URL: https://github.com/apache/doris/pull/32169#issuecomment-1993722807

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993725339

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993728069

   
   
   ClickBench: Total hot run time: 30.71 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 336d0fa5d664fa889abdd30808e886786693da4f, 
data reload: false
   
   query1   0.050.040.04
   query2   0.060.030.02
   query3   0.220.060.06
   query4   1.670.100.10
   query5   0.510.510.51
   query6   1.200.630.64
   query7   0.020.020.01
   query8   0.030.020.03
   query9   0.540.500.51
   query10  0.530.560.54
   query11  0.120.090.10
   query12  0.120.090.09
   query13  0.560.560.56
   query14  0.740.750.76
   query15  0.800.780.78
   query16  0.390.380.39
   query17  1.031.030.96
   query18  0.180.250.25
   query19  1.801.661.81
   query20  0.020.010.01
   query21  15.40   0.550.55
   query22  2.201.661.62
   query23  17.16   0.850.68
   query24  3.252.391.48
   query25  0.200.110.17
   query26  0.670.110.11
   query27  0.050.030.02
   query28  9.910.880.89
   query29  12.52   3.193.26
   query30  0.700.600.58
   query31  2.800.330.33
   query32  3.400.440.43
   query33  2.832.772.86
   query34  16.36   4.384.41
   query35  4.324.354.34
   query36  1.051.001.00
   query37  0.070.060.05
   query38  0.040.030.03
   query39  0.030.010.02
   query40  0.160.140.13
   query41  0.080.020.02
   query42  0.030.020.02
   query43  0.030.020.03
   Total cold run time: 103.85 s
   Total hot run time: 30.71 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty [doris]

2024-03-13 Thread via GitHub


jackwener merged PR #32169:
URL: https://github.com/apache/doris/pull/32169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (99680e9ec13 -> ca092139a00)

2024-03-13 Thread jakevin
This is an automated email from the ASF dual-hosted git repository.

jakevin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 99680e9ec13 [Bug](top-n) do not update topn filter when sort node and 
scan node are not in the… (#32159)
 add ca092139a00 [fix](Nereids): slot set in condition can be empty (#32169)

No new revisions were added by this update.

Summary of changes:
 .../doris/nereids/rules/exploration/join/InnerJoinLAsscom.java |  6 +++---
 .../nereids/rules/rewrite/TransposeSemiJoinLogicalJoin.java|  2 +-
 .../rules/rewrite/TransposeSemiJoinLogicalJoinProject.java | 10 +-
 3 files changed, 9 insertions(+), 9 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993732153

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 336d0fa5d664fa889abdd30808e886786693da4f with 
default session variables
   Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:  59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:   13.7 seconds inserted 1000 Rows, about 729K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993732602

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](nereids)support unnest subquery with group by and having clause [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32002:
URL: https://github.com/apache/doris/pull/32002#issuecomment-1993732638

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](routine-load)add rack tag into fe & kafka routine load(#31531) [doris]

2024-03-13 Thread via GitHub


flashmouse commented on PR #32098:
URL: https://github.com/apache/doris/pull/32098#issuecomment-1993735927

   @HHoflittlefish777  
   I have no permission to check the failure reason.
   cloud_p0 (Doris Cloud Regression) — TeamCity build failed 
   cloud_p1 (Doris Cloud Regression) — TeamCity build failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993738964

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) Add multi cloud cluster [doris]

2024-03-13 Thread via GitHub


dataroaring commented on PR #31749:
URL: https://github.com/apache/doris/pull/31749#issuecomment-1993738383

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


liaoxin01 commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993739222

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


liaoxin01 opened a new pull request, #32175:
URL: https://github.com/apache/doris/pull/32175

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993741525

   
   
   TPC-H: Total hot run time: 36392 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0aa123b40d66f49ae5160b4106d92b87686df14f, 
data reload: false
   
   -- Round 1 --
   q1   17658   411140734073
   q2   2021152 154 152
   q3   10567   903 897 897
   q4   4660740 684 684
   q5   7594272027622720
   q6   189 125 122 122
   q7   1188812 801 801
   q8   9484202520322025
   q9   7351644964646449
   q10  8179253224472447
   q11  425 219 212 212
   q12  794 295 297 295
   q13  17948   301829712971
   q14  284 249 254 249
   q15  494 452 461 452
   q16  471 388 402 388
   q17  923 575 500 500
   q18  6717580958405809
   q19  1560137414541374
   q20  539 284 283 283
   q21  7382319832833198
   q22  811 291 329 291
   Total cold run time: 107239 ms
   Total hot run time: 36392 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4086404741144047
   q2   319 226 224 224
   q3   2980281628462816
   q4   1811155315521552
   q5   5213521652295216
   q6   196 115 123 115
   q7   2240182818111811
   q8   3143328932863286
   q9   8577854785858547
   q10  6134367737153677
   q11  536 450 438 438
   q12  736 568 526 526
   q13  13735   283128522831
   q14  270 252 254 252
   q15  479 450 446 446
   q16  440 406 390 390
   q17  1713146414431443
   q18  7681720470357035
   q19  5392152315331523
   q20  1879169517161695
   q21  4755478746074607
   q22  531 448 468 448
   Total cold run time: 72846 ms
   Total hot run time: 52925 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve] Refactor block file cache and add more ut case [doris]

2024-03-13 Thread via GitHub


Lchangliang commented on code in PR #30039:
URL: https://github.com/apache/doris/pull/30039#discussion_r1522681904


##
be/src/io/fs/file_writer.h:
##
@@ -33,8 +33,8 @@ class FileSystem;
 struct FileWriterOptions {
 bool write_file_cache = false;
 bool is_cold_data = false;
-bool sync_file_data = true;// Whether flush data into storage 
system
-int64_t file_cache_expiration = 0; // Absolute time
+bool sync_file_data = true; // Whether flush data into storage 
system
+uint64_t file_cache_expiration = 0; // Absolute time

Review Comment:
   Because the table property `file_cache_ttl_seconds` is long in FE, it maybe 
set the LONG_MAX value. file_cache_expiration = cur_time + 
file_cache_ttl_seconds, it will overflow if not uint64_t



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) Add multi cloud cluster [doris]

2024-03-13 Thread via GitHub


yujun777 commented on PR #31749:
URL: https://github.com/apache/doris/pull/31749#issuecomment-1993743229

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993744675

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1 [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32162:
URL: https://github.com/apache/doris/pull/32162#issuecomment-1993748378

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993748139

   TeamCity be ut coverage result:
Function Coverage: 35.00% (8574/24498) 
Line Coverage: 26.75% (69444/259582)
Region Coverage: 26.02% (36060/138590)
Branch Coverage: 22.97% (18410/80142)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/0aa123b40d66f49ae5160b4106d92b87686df14f_0aa123b40d66f49ae5160b4106d92b87686df14f/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve] Refactor block file cache and add more ut case [doris]

2024-03-13 Thread via GitHub


Lchangliang commented on code in PR #30039:
URL: https://github.com/apache/doris/pull/30039#discussion_r1522689233


##
be/src/io/fs/local_file_reader.cpp:
##
@@ -40,11 +41,14 @@ namespace doris {
 namespace io {
 struct IOContext;
 
+bvar::Adder 
local_file_open_reading("doris_be_local_file_open_reading");
+bvar::Adder 
local_file_reader_total("doris_be_local_file_reader_total");

Review Comment:
   Redundant code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve] Refactor block file cache and add more ut case [doris]

2024-03-13 Thread via GitHub


Lchangliang commented on code in PR #30039:
URL: https://github.com/apache/doris/pull/30039#discussion_r1522689494


##
be/src/io/io_common.h:
##
@@ -57,7 +57,7 @@ struct IOContext {
 bool is_persistent = false;
 // stop reader when reading, used in some interrupted operations
 bool should_stop = false;
-int64_t expiration_time = 0;
+uint64_t expiration_time = 0;

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](mtmv) Remove useless code and add some doc [doris]

2024-03-13 Thread via GitHub


morrySnow merged PR #32047:
URL: https://github.com/apache/doris/pull/32047


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (ca092139a00 -> 9f628f3449b)

2024-03-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from ca092139a00 [fix](Nereids): slot set in condition can be empty (#32169)
 add 9f628f3449b [improvement](mtmv) Remove useless code and add some doc 
(#32047)

No new revisions were added by this update.

Summary of changes:
 .../Create/CREATE-ASYNC-MATERIALIZED-VIEW.md  |  2 ++
 .../Create/CREATE-ASYNC-MATERIALIZED-VIEW.md  |  1 +
 .../main/java/org/apache/doris/mtmv/MTMVCache.java| 19 ---
 3 files changed, 15 insertions(+), 7 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993752886

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mysql) Fix Connection Attributes Parsing Logic for Compatibility [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32177:
URL: https://github.com/apache/doris/pull/32177#issuecomment-1993753934

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

2024-03-13 Thread via GitHub


jackwener opened a new pull request, #32176:
URL: https://github.com/apache/doris/pull/32176

   ## Proposed changes
   
   (cherry picked from commit ca092139a007dca99006d8247d9926947b1490d3)
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](mysql) Fix Connection Attributes Parsing Logic for Compatibility [doris]

2024-03-13 Thread via GitHub


zy-kkk opened a new pull request, #32177:
URL: https://github.com/apache/doris/pull/32177

   ## Proposed changes
   
   Issue Number: close #31857
   
   This PR addresses compatibility issues with the latest version of the MySQL 
Python Connector. The previous implementation failed to correctly handle 
connection attributes (`conn_attrs`), leading to handshake failures. By 
adjusting the logic for reading connection attribute data to ensure we do not 
exceed the actual length of the attribute section when parsing key-value pairs, 
we have resolved the compatibility issue. This change allows our custom MySQL 
protocol implementation to correctly parse connection requests from the new 
version of the Connector.
   
   Thanks to @liujiwen-up for the help
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mysql) Fix Connection Attributes Parsing Logic for Compatibility [doris]

2024-03-13 Thread via GitHub


zy-kkk commented on PR #32177:
URL: https://github.com/apache/doris/pull/32177#issuecomment-1993753991

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](mtmv) Remove useless code and add some doc [doris]

2024-03-13 Thread via GitHub


morrySnow commented on code in PR #32047:
URL: https://github.com/apache/doris/pull/32047#discussion_r1522692477


##
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVCache.java:
##
@@ -54,18 +55,22 @@ public Plan getOriginalPlan() {
 
 public static MTMVCache from(MTMV mtmv, ConnectContext connectContext) {
 LogicalPlan unboundMvPlan = new 
NereidsParser().parseSingle(mtmv.getQuerySql());
-// this will be removed in the future when support join derivation
-
connectContext.getSessionVariable().setDisableNereidsRules("INFER_PREDICATES, 
ELIMINATE_OUTER_JOIN");
 StatementContext mvSqlStatementContext = new 
StatementContext(connectContext,
 new OriginStatement(mtmv.getQuerySql(), 0));
 NereidsPlanner planner = new NereidsPlanner(mvSqlStatementContext);
 if (mvSqlStatementContext.getConnectContext().getStatementContext() == 
null) {
 
mvSqlStatementContext.getConnectContext().setStatementContext(mvSqlStatementContext);
 }
-Plan mvRewrittenPlan = planner.plan(unboundMvPlan, 
PhysicalProperties.ANY, ExplainLevel.REWRITTEN_PLAN);
-// TODO: should use visitor or a new rule to remove result sink node
-Plan mvPlan = mvRewrittenPlan instanceof LogicalResultSink
-? (Plan) ((LogicalResultSink) mvRewrittenPlan).child() : 
mvRewrittenPlan;
-return new MTMVCache(mvPlan, mvRewrittenPlan);
+Plan originPlan = planner.plan(unboundMvPlan, PhysicalProperties.ANY, 
ExplainLevel.REWRITTEN_PLAN);
+Plan mvPlan = originPlan.accept(new DefaultPlanRewriter() {
+@Override
+public Plan visit(Plan plan, Object context) {
+if (plan instanceof LogicalResultSink) {
+return ((LogicalResultSink) plan).child();
+}
+return super.visit(plan, context);
+}
+}, null);

Review Comment:
   except result sink, file sink should keep order too. so maybe we need 
another abstract class for them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](mtmv) Remove useless code and add some doc [doris]

2024-03-13 Thread via GitHub


morrySnow commented on code in PR #32047:
URL: https://github.com/apache/doris/pull/32047#discussion_r1522692477


##
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVCache.java:
##
@@ -54,18 +55,22 @@ public Plan getOriginalPlan() {
 
 public static MTMVCache from(MTMV mtmv, ConnectContext connectContext) {
 LogicalPlan unboundMvPlan = new 
NereidsParser().parseSingle(mtmv.getQuerySql());
-// this will be removed in the future when support join derivation
-
connectContext.getSessionVariable().setDisableNereidsRules("INFER_PREDICATES, 
ELIMINATE_OUTER_JOIN");
 StatementContext mvSqlStatementContext = new 
StatementContext(connectContext,
 new OriginStatement(mtmv.getQuerySql(), 0));
 NereidsPlanner planner = new NereidsPlanner(mvSqlStatementContext);
 if (mvSqlStatementContext.getConnectContext().getStatementContext() == 
null) {
 
mvSqlStatementContext.getConnectContext().setStatementContext(mvSqlStatementContext);
 }
-Plan mvRewrittenPlan = planner.plan(unboundMvPlan, 
PhysicalProperties.ANY, ExplainLevel.REWRITTEN_PLAN);
-// TODO: should use visitor or a new rule to remove result sink node
-Plan mvPlan = mvRewrittenPlan instanceof LogicalResultSink
-? (Plan) ((LogicalResultSink) mvRewrittenPlan).child() : 
mvRewrittenPlan;
-return new MTMVCache(mvPlan, mvRewrittenPlan);
+Plan originPlan = planner.plan(unboundMvPlan, PhysicalProperties.ANY, 
ExplainLevel.REWRITTEN_PLAN);
+Plan mvPlan = originPlan.accept(new DefaultPlanRewriter() {
+@Override
+public Plan visit(Plan plan, Object context) {
+if (plan instanceof LogicalResultSink) {
+return ((LogicalResultSink) plan).child();
+}
+return super.visit(plan, context);
+}
+}, null);

Review Comment:
   except result sink, file sink should keep order too. so maybe we need 
another abstract class for them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Nereids) support agg state type in create table [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32171:
URL: https://github.com/apache/doris/pull/32171#issuecomment-1993754538

   
   
   TPC-H: Total hot run time: 37679 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4a0bb8059bb90980d9364f47fcf955b748426713, 
data reload: false
   
   -- Round 1 --
   q1   17632   450245064502
   q2   2014150 155 150
   q3   10562   888 888 888
   q4   4650665 667 665
   q5   7583285529792855
   q6   195 123 124 123
   q7   1251809 789 789
   q8   95092261
   q9   7525666466896664
   q10  8239250424882488
   q11  435 230 214 214
   q12  808 299 291 291
   q13  17973   295030062950
   q14  275 258 250 250
   q15  511 455 454 454
   q16  511 383 408 383
   q17  994 529 536 529
   q18  6565580057345734
   q19  1733152515931525
   q20  564 293 279 279
   q21  7450344634343434
   q22  806 290 291 290
   Total cold run time: 107785 ms
   Total hot run time: 37679 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4507447145064471
   q2   343 231 236 231
   q3   3086288129112881
   q4   1932156316031563
   q5   5336540453455345
   q6   209 120 120 120
   q7   2279187418261826
   q8   3392353935463539
   q9   8617861786368617
   q10  6222380137733773
   q11  548 430 436 430
   q12  742 577 548 548
   q13  13383   284528242824
   q14  283 246 245 245
   q15  501 456 454 454
   q16  454 400 408 400
   q17  1838154815371537
   q18  727169966996
   q19  5746164817111648
   q20  1965169316971693
   q21  5033478248894782
   q22  536 436 438 436
   Total cold run time: 74729 ms
   Total hot run time: 54359 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](merge-cloud) fix no cluster for common user [doris]

2024-03-13 Thread via GitHub


dataroaring merged PR #32097:
URL: https://github.com/apache/doris/pull/32097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (9f628f3449b -> 50b1aa6e3db)

2024-03-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 9f628f3449b [improvement](mtmv) Remove useless code and add some doc 
(#32047)
 add 50b1aa6e3db [fix](merge-cloud) fix no cluster for common user (#32097)

No new revisions were added by this update.

Summary of changes:
 .../tvf/test_insert_from_tvf_with_common_user.groovy  | 8 
 .../suites/load_p0/stream_load/test_stream_load.groovy| 8 
 2 files changed, 16 insertions(+)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](merge-cloud) fix no cluster for common user [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32097:
URL: https://github.com/apache/doris/pull/32097#issuecomment-1993755017

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

2024-03-13 Thread via GitHub


jackwener commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993755362

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993756634

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993757151

   
   
   TPC-DS: Total hot run time: 187446 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0aa123b40d66f49ae5160b4106d92b87686df14f, 
data reload: false
   
   query1   912 373 338 338
   query2   7386201019871987
   query3   6697214 213 213
   query4   31109   20709   20707   20707
   query5   6401457 406 406
   query6   275 201 181 181
   query7   4624304 287 287
   query8   221 168 175 168
   query9   9906226322322232
   query10  466 246 241 241
   query11  14758   14116   14175   14116
   query12  131 85  84  84
   query13  1625416 439 416
   query14  11244   10765   10511   10511
   query15  250 202 201 201
   query16  7998262 261 261
   query17  1941557 531 531
   query18  2051288 280 280
   query19  230 153 153 153
   query20  99  80  85  80
   query21  193 129 120 120
   query22  4619447544274427
   query23  31749   31388   31315   31315
   query24  10902   284728032803
   query25  608 367 379 367
   query26  1479150 158 150
   query27  3134340 341 340
   query28  8133184818551848
   query29  955 639 624 624
   query30  304 149 152 149
   query31  974 725 726 725
   query32  96  61  56  56
   query33  752 248 254 248
   query34  1091461 473 461
   query35  842 604 606 604
   query36  948 891 870 870
   query37  125 72  79  72
   query38  3323318631513151
   query39  1419136713941367
   query40  207 115 106 106
   query41  54  46  45  45
   query42  102 95  102 95
   query43  496 455 469 455
   query44  1137722 711 711
   query45  271 241 246 241
   query46  1059685 670 670
   query47  1646159716101597
   query48  426 348 377 348
   query49  1127331 334 331
   query50  755 376 375 375
   query51  6854676867726768
   query52  106 92  119 92
   query53  339 276 278 276
   query54  296 238 234 234
   query55  89  86  79  79
   query56  252 229 241 229
   query57  1081102110021002
   query58  224 201 205 201
   query59  2778265625692569
   query60  276 253 257 253
   query61  113 109 109 109
   query62  581 388 396 388
   query63  315 287 280 280
   query64  5727384138493841
   query65  3109304129862986
   query66  1427331 314 314
   query67  14669   14490   14423   14423
   query68  5272517 529 517
   query69  553 387 385 385
   query70  1224117612101176
   query71  413 273 284 273
   query72  6421277425962596
   query73  701 326 320 320
   query74  7644661765686568
   query75  8914798979837983
   query76  3448825 988 825
   query77  442 271 264 264
   query78  10574   960196739601
   query79  8091506 516 506
   query80  1706400 397 397
   query81  560 207 213 207
   query82  1591203 205 203
   query83  275 148 154 148
   query84  291 81  83  81
   query85  2007314 305 305
   query86  514 277 310 277
   query87  3409326832253225
   query88  5117231323152313
   query89  479 362 373 362
   query90  1988173 171 171
   query91  160 132 134 132
   query92  60  46  48  46
   query93  5790517 494 494
   query94  1277172 172 172
   query95  425 332 319 319
   query96  602 267 281 267
   query97  4400426643014266
   query98  223 213 209 209
   query99  1075730 730 730
   Total cold run time: 311132 ms
   Total hot run time: 187446 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t

Re: [PR] [improvement](Nereids) Support to remove sort which is under table sink [doris]

2024-03-13 Thread via GitHub


XieJiann commented on code in PR #31751:
URL: https://github.com/apache/doris/pull/31751#discussion_r1522695502


##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateSort.java:
##
@@ -57,21 +59,24 @@ public Plan visit(Plan plan, Boolean pruneSort) {
 @Override
 public Plan visitLogicalSort(LogicalSort sort, Boolean 
eliminateSort) {
 if (eliminateSort) {
-return visit(sort.child(), true);
+return visit(sort.child(), eliminateSort);
 }
-return visit(sort, true);
+return visit(sort, eliminateSort);
 }

Review Comment:
   why pass `eliminateSort` rather than true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]

2024-03-13 Thread via GitHub


ByteYue opened a new pull request, #32178:
URL: https://github.com/apache/doris/pull/32178

   ## Proposed changes
   
   Issue Number: close #xxx
   
   same as master #32079
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993758844

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

2024-03-13 Thread via GitHub


jackwener commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993762625

   
   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993763999

   
   
   ClickBench: Total hot run time: 30.2 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0aa123b40d66f49ae5160b4106d92b87686df14f, 
data reload: false
   
   query1   0.040.030.04
   query2   0.060.020.02
   query3   0.230.060.06
   query4   1.670.100.09
   query5   0.500.510.51
   query6   1.180.620.63
   query7   0.020.010.02
   query8   0.030.030.03
   query9   0.540.510.49
   query10  0.560.540.55
   query11  0.120.080.09
   query12  0.110.090.10
   query13  0.570.570.56
   query14  0.720.770.75
   query15  0.790.790.78
   query16  0.390.400.37
   query17  0.970.981.02
   query18  0.200.250.22
   query19  1.771.691.67
   query20  0.020.010.01
   query21  15.48   0.570.56
   query22  2.581.981.67
   query23  16.90   0.720.86
   query24  3.432.341.21
   query25  0.300.250.03
   query26  0.630.100.11
   query27  0.040.030.03
   query28  10.14   0.860.86
   query29  12.52   3.083.10
   query30  0.670.580.56
   query31  2.800.330.33
   query32  3.410.450.44
   query33  2.812.822.80
   query34  16.14   4.294.34
   query35  4.324.314.33
   query36  1.051.011.02
   query37  0.070.060.05
   query38  0.040.040.04
   query39  0.030.020.02
   query40  0.160.130.12
   query41  0.070.020.02
   query42  0.020.020.02
   query43  0.020.020.03
   Total cold run time: 104.12 s
   Total hot run time: 30.2 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993767220

   
   
   TPC-H: Total hot run time: 37162 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 5b798b4e176740c9efac33a27dece22c7a0a7886, 
data reload: false
   
   -- Round 1 --
   q1   17655   449842874287
   q2   2524158 155 155
   q3   12406   942 936 936
   q4   5050738 752 738
   q5   7644284329682843
   q6   185 125 127 125
   q7   1191845 841 841
   q8   9617205420812054
   q9   7300647664596459
   q10  8175255425402540
   q11  423 224 227 224
   q12  785 304 297 297
   q13  17967   301429742974
   q14  274 250 245 245
   q15  489 462 456 456
   q16  485 390 388 388
   q17  954 572 564 564
   q18  6694589858585858
   q19  1563148414251425
   q20  548 279 272 272
   q21  7474326331883188
   q22  820 293 309 293
   Total cold run time: 110223 ms
   Total hot run time: 37162 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4226414441374137
   q2   321 223 237 223
   q3   2976283628562836
   q4   1859151415181514
   q5   5195522052355220
   q6   200 115 115 115
   q7   2268185818481848
   q8   3150325532803255
   q9   8504856685938566
   q10  6175368636583658
   q11  534 443 448 443
   q12  717 545 548 545
   q13  7017287328662866
   q14  272 241 248 241
   q15  476 448 436 436
   q16  452 417 409 409
   q17  1726147014911470
   q18  7612724671237123
   q19  4654150215161502
   q20  1914168316941683
   q21  4981470946954695
   q22  532 448 445 445
   Total cold run time: 65761 ms
   Total hot run time: 53230 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993768038

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Optimization][Scanner] Skip `_init_variant_columns` when there are n… [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32174:
URL: https://github.com/apache/doris/pull/32174#issuecomment-1993768587

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0aa123b40d66f49ae5160b4106d92b87686df14f with 
default session variables
   Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:  58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:   13.8 seconds inserted 1000 Rows, about 724K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub


platoneko commented on PR #31853:
URL: https://github.com/apache/doris/pull/31853#issuecomment-1993768869

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mysql) Fix Connection Attributes Parsing Logic for Compatibility [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32177:
URL: https://github.com/apache/doris/pull/32177#issuecomment-1993770598

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Nereids) support agg state type in create table [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32171:
URL: https://github.com/apache/doris/pull/32171#issuecomment-1993771069

   
   
   TPC-DS: Total hot run time: 187448 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4a0bb8059bb90980d9364f47fcf955b748426713, 
data reload: false
   
   query1   917 353 347 347
   query2   7389214319861986
   query3   6698212 216 212
   query4   31358   20680   20856   20680
   query5   4385421 464 421
   query6   254 175 172 172
   query7   4624299 285 285
   query8   225 177 165 165
   query9   9935227922762276
   query10  444 222 258 222
   query11  14678   14221   14200   14200
   query12  134 87  78  78
   query13  1627426 421 421
   query14  11795   10723   11080   10723
   query15  288 206 189 189
   query16  8077257 259 257
   query17  1945563 556 556
   query18  2101282 283 282
   query19  279 160 153 153
   query20  89  93  87  87
   query21  202 127 123 123
   query22  4698454145144514
   query23  31779   31178   31048   31048
   query24  10668   283327932793
   query25  623 378 374 374
   query26  1218158 158 158
   query27  2560346 354 346
   query28  7758188818361836
   query29  892 629 614 614
   query30  326 147 147 147
   query31  971 706 725 706
   query32  95  60  56  56
   query33  767 256 249 249
   query34  1092471 489 471
   query35  833 617 601 601
   query36  1000873 871 871
   query37  128 77  76  76
   query38  3280308831933088
   query39  1432135613731356
   query40  217 117 111 111
   query41  51  46  44  44
   query42  100 101 96  96
   query43  472 442 444 442
   query44  1307716 727 716
   query45  286 250 260 250
   query46  1066693 706 693
   query47  1661158716031587
   query48  454 361 353 353
   query49  1142336 328 328
   query50  751 376 374 374
   query51  6797670567386705
   query52  104 88  94  88
   query53  340 314 278 278
   query54  304 258 252 252
   query55  86  78  80  78
   query56  271 226 246 226
   query57  1074101910241019
   query58  248 199 200 199
   query59  2715262227052622
   query60  275 259 248 248
   query61  112 105 109 105
   query62  605 408 408 408
   query63  306 273 282 273
   query64  5663384737973797
   query65  3038300730113007
   query66  833 324 324 324
   query67  15071   14429   14521   14429
   query68  7383524 539 524
   query69  622 373 375 373
   query70  1250117111561156
   query71  522 278 277 277
   query72  6422264925012501
   query73  733 313 316 313
   query74  7104659465666566
   query75  9745804882808048
   query76  4511882 936 882
   query77  669 256 274 256
   query78  10458   954596549545
   query79  8532539 528 528
   query80  1581388 373 373
   query81  527 211 215 211
   query82  864 210 195 195
   query83  203 142 142 142
   query84  285 79  76  76
   query85  1490310 301 301
   query86  468 315 286 286
   query87  3438323433493234
   query88  5058231922952295
   query89  540 365 359 359
   query90  1923175 183 175
   query91  152 125 128 125
   query92  66  45  50  45
   query93  7094503 484 484
   query94  1183174 172 172
   query95  424 331 333 331
   query96  597 280 270 270
   query97  4424427642804276
   query98  230 207 204 204
   query99  1132740 734 734
   Total cold run time: 312543 ms
   Total hot run time: 187448 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t

[PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet [doris]

2024-03-13 Thread via GitHub


deardeng opened a new pull request, #32179:
URL: https://github.com/apache/doris/pull/32179

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   修复升级到203之后遇到的be tablet 中 partition id为0
   
   1. 通过be report tablet 汇报到fe的tablet 中partition id 判断是否一致
   2. 若不一致产生一个update tablet task,让be修复,并打印相关warning log
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32179:
URL: https://github.com/apache/doris/pull/32179#issuecomment-1993775160

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] save code null aware in runtime filter [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32152:
URL: https://github.com/apache/doris/pull/32152#issuecomment-1993775100

   
   
   TPC-H: Total hot run time: 36652 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 08fb4441f5fb7552fb5147ec73d329badad8d53e, 
data reload: false
   
   -- Round 1 --
   q1   17654   453941584158
   q2   2024152 145 145
   q3   10650   906 904 904
   q4   4654703 696 696
   q5   7646277627932776
   q6   187 122 127 122
   q7   1255823 808 808
   q8   9572212320622062
   q9   7399649365156493
   q10  8212246324572457
   q11  435 228 218 218
   q12  790 283 306 283
   q13  17982   300930233009
   q14  267 254 254 254
   q15  493 461 463 461
   q16  509 396 397 396
   q17  982 518 594 518
   q18  6643587157305730
   q19  1574150114091409
   q20  542 292 278 278
   q21  7462332031773177
   q22  816 298 302 298
   Total cold run time: 107748 ms
   Total hot run time: 36652 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4177415141254125
   q2   321 233 235 233
   q3   3015285528472847
   q4   1870161815711571
   q5   5250527052905270
   q6   202 117 117 117
   q7   2274185418181818
   q8   3180328933493289
   q9   8589854085988540
   q10  6194369036473647
   q11  546 437 440 437
   q12  734 551 560 551
   q13  14158   284828492848
   q14  276 250 262 250
   q15  488 442 442 442
   q16  446 400 435 400
   q17  1740148014621462
   q18  7680717871087108
   q19  4543153715321532
   q20  1894173817161716
   q21  4901467846734673
   q22  545 476 457 457
   Total cold run time: 73023 ms
   Total hot run time: 5 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet [doris]

2024-03-13 Thread via GitHub


deardeng commented on PR #32179:
URL: https://github.com/apache/doris/pull/32179#issuecomment-1993776978

   3副本,mock了2副本中的tablet partition id 为0,修复后的效果
   https://github.com/apache/doris/assets/3887565/99e01205-6703-476f-9e25-411b0159f830";>
   https://github.com/apache/doris/assets/3887565/85ba317a-a631-4e7b-9608-ec3f24a4245f";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Nereids) support agg state type in create table [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32171:
URL: https://github.com/apache/doris/pull/32171#issuecomment-1993779064

   
   
   ClickBench: Total hot run time: 29.68 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 4a0bb8059bb90980d9364f47fcf955b748426713, 
data reload: false
   
   query1   0.040.040.03
   query2   0.060.020.02
   query3   0.230.060.06
   query4   1.680.100.09
   query5   0.530.510.53
   query6   1.190.630.62
   query7   0.010.010.01
   query8   0.040.030.03
   query9   0.570.480.52
   query10  0.530.530.54
   query11  0.110.090.10
   query12  0.110.100.09
   query13  0.570.580.55
   query14  0.760.770.75
   query15  0.800.780.78
   query16  0.400.390.41
   query17  1.051.060.94
   query18  0.190.270.22
   query19  1.721.751.70
   query20  0.020.010.01
   query21  15.41   0.550.54
   query22  2.261.831.76
   query23  17.40   0.720.92
   query24  3.041.800.47
   query25  0.160.200.09
   query26  0.600.110.12
   query27  0.030.030.03
   query28  11.42   0.890.84
   query29  12.57   3.233.19
   query30  0.650.580.60
   query31  2.800.340.33
   query32  3.400.440.44
   query33  2.752.832.80
   query34  16.10   4.294.29
   query35  4.284.284.29
   query36  1.071.011.01
   query37  0.060.050.06
   query38  0.050.030.03
   query39  0.030.020.02
   query40  0.170.140.14
   query41  0.080.020.02
   query42  0.030.020.02
   query43  0.020.030.02
   Total cold run time: 104.99 s
   Total hot run time: 29.68 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](partition) Fix be tablet partition id eq 0 By report tablet [doris]

2024-03-13 Thread via GitHub


github-actions[bot] commented on PR #32179:
URL: https://github.com/apache/doris/pull/32179#issuecomment-1993782199

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Nereids) support agg state type in create table [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32171:
URL: https://github.com/apache/doris/pull/32171#issuecomment-1993783528

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 4a0bb8059bb90980d9364f47fcf955b748426713 with 
default session variables
   Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:  59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:   13.8 seconds inserted 1000 Rows, about 724K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993785139

   
   
   TPC-DS: Total hot run time: 188247 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 5b798b4e176740c9efac33a27dece22c7a0a7886, 
data reload: false
   
   query1   922 357 346 346
   query2   7402200721392007
   query3   6707222 223 222
   query4   31316   20745   20784   20745
   query5   4383428 436 428
   query6   266 175 176 175
   query7   4632307 293 293
   query8   236 183 187 183
   query9   9745226822672267
   query10  468 250 246 246
   query11  17129   14167   14253   14167
   query12  140 94  86  86
   query13  1632423 425 423
   query14  11241   10917   11605   10917
   query15  263 206 191 191
   query16  8092266 248 248
   query17  1975552 540 540
   query18  2095290 267 267
   query19  283 156 159 156
   query20  97  82  86  82
   query21  194 126 126 126
   query22  4618442544714425
   query23  31696   31138   31226   31138
   query24  10741   283528072807
   query25  611 362 380 362
   query26  1611165 160 160
   query27  3041360 363 360
   query28  8090189118351835
   query29  964 637 625 625
   query30  308 151 151 151
   query31  948 728 733 728
   query32  93  58  59  58
   query33  774 273 257 257
   query34  1045477 516 477
   query35  826 601 622 601
   query36  1006884 879 879
   query37  128 80  76  76
   query38  3259312631443126
   query39  1399136913571357
   query40  294 113 115 113
   query41  50  49  50  49
   query42  103 98  99  98
   query43  496 449 456 449
   query44  1263738 738 738
   query45  281 256 258 256
   query46  1080717 694 694
   query47  1698159216131592
   query48  450 355 352 352
   query49  1188339 340 339
   query50  763 376 380 376
   query51  6861676367706763
   query52  117 94  100 94
   query53  343 274 282 274
   query54  314 245 244 244
   query55  89  83  84  83
   query56  265 236 241 236
   query57  1110104110011001
   query58  238 210 214 210
   query59  2839268625412541
   query60  282 254 253 253
   query61  113 114 115 114
   query62  619 413 406 406
   query63  307 279 283 279
   query64  6942397939673967
   query65  3139302330753023
   query66  1416345 334 334
   query67  15045   14428   14563   14428
   query68  8649544 543 543
   query69  638 393 394 393
   query70  1259118411311131
   query71  525 282 289 282
   query72  6600267824692469
   query73  766 310 320 310
   query74  7094664564866486
   query75  9896815380478047
   query76  5050924 908 908
   query77  641 257 281 257
   query78  10477   973996659665
   query79  10179   536 543 536
   query80  1571448 392 392
   query81  510 211 215 211
   query82  873 209 218 209
   query83  230 150 143 143
   query84  285 78  80  78
   query85  1440324 314 314
   query86  473 293 305 293
   query87  3433322932003200
   query88  4920234623652346
   query89  525 390 376 376
   query90  2031177 175 175
   query91  158 126 128 126
   query92  63  47  50  47
   query93  6940494 488 488
   query94  1214178 176 176
   query95  434 331 330 330
   query96  642 289 275 275
   query97  4374424742634247
   query98  231 206 207 206
   query99  1246745 750 745
   Total cold run time: 321448 ms
   Total hot run time: 188247 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t

Re: [PR] [feature](function) support hll functions hll_from_base64, hll_to_base64 [doris]

2024-03-13 Thread via GitHub


superdiaodiao commented on PR #32089:
URL: https://github.com/apache/doris/pull/32089#issuecomment-1993787077

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] save code null aware in runtime filter [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32152:
URL: https://github.com/apache/doris/pull/32152#issuecomment-1993793466

   
   
   TPC-DS: Total hot run time: 187165 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 08fb4441f5fb7552fb5147ec73d329badad8d53e, 
data reload: false
   
   query1   936 363 339 339
   query2   7426208519421942
   query3   6699222 214 214
   query4   31352   20825   20814   20814
   query5   4406428 409 409
   query6   276 175 188 175
   query7   4622318 293 293
   query8   239 165 161 161
   query9   9931222622252225
   query10  464 238 250 238
   query11  17153   14333   14417   14333
   query12  134 91  85  85
   query13  1633438 426 426
   query14  11714   10741   10422   10422
   query15  260 208 189 189
   query16  8085263 257 257
   query17  1961566 530 530
   query18  2098277 281 277
   query19  322 154 150 150
   query20  87  85  87  85
   query21  204 138 130 130
   query22  4585446644124412
   query23  31966   31207   31178   31178
   query24  10709   282328362823
   query25  604 385 376 376
   query26  1223160 170 160
   query27  2391353 357 353
   query28  7508186618641864
   query29  878 654 615 615
   query30  308 160 147 147
   query31  957 723 725 723
   query32  104 63  59  59
   query33  768 266 259 259
   query34  1073474 482 474
   query35  852 619 605 605
   query36  1038888 889 888
   query37  118 82  81  81
   query38  3258313231673132
   query39  1430139313931393
   query40  206 117 111 111
   query41  53  47  47  47
   query42  104 100 100 100
   query43  507 451 464 451
   query44  1327760 756 756
   query45  264 273 249 249
   query46  1092711 703 703
   query47  1670162315981598
   query48  455 387 358 358
   query49  1101358 330 330
   query50  772 382 388 382
   query51  6777669166106610
   query52  104 93  94  93
   query53  345 280 282 280
   query54  307 235 239 235
   query55  85  81  80  80
   query56  250 262 228 228
   query57  1077101910211019
   query58  251 207 207 207
   query59  2846273125812581
   query60  260 300 257 257
   query61  116 114 112 112
   query62  596 422 391 391
   query63  303 284 277 277
   query64  5747337839573378
   query65  3250308630483048
   query66  749 329 359 329
   query67  14964   14341   14624   14341
   query68  6651528 534 528
   query69  627 392 391 391
   query70  1297117111911171
   query71  512 281 296 281
   query72  6395267125222522
   query73  725 321 328 321
   query74  7003658365786578
   query75  93727981
   query76  4730951 1001951
   query77  654 264 249 249
   query78  10433   963896349634
   query79  8498546 551 546
   query80  1792390 399 390
   query81  529 207 214 207
   query82  1179207 220 207
   query83  221 146 144 144
   query84  283 75  79  75
   query85  1511325 317 317
   query86  482 305 320 305
   query87  3494322531723172
   query88  4999242023952395
   query89  530 367 387 367
   query90  1921181 176 176
   query91  161 128 130 128
   query92  59  49  50  49
   query93  6816509 502 502
   query94  1147177 178 177
   query95  442 327 333 327
   query96  612 271 279 271
   query97  4416425743014257
   query98  228 205 213 205
   query99  1112770 758 758
   Total cold run time: 314181 ms
   Total hot run time: 187165 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to 

Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993793502

   
   
   ClickBench: Total hot run time: 31.01 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 5b798b4e176740c9efac33a27dece22c7a0a7886, 
data reload: false
   
   query1   0.050.040.03
   query2   0.060.020.03
   query3   0.220.060.06
   query4   1.680.090.09
   query5   0.520.510.51
   query6   1.200.620.61
   query7   0.020.010.02
   query8   0.040.020.03
   query9   0.560.490.49
   query10  0.560.550.55
   query11  0.120.090.09
   query12  0.110.090.09
   query13  0.560.570.56
   query14  0.760.750.75
   query15  0.810.790.79
   query16  0.390.390.39
   query17  0.991.000.97
   query18  0.220.240.23
   query19  1.791.731.74
   query20  0.020.010.01
   query21  15.47   0.560.56
   query22  2.292.331.98
   query23  17.33   0.780.79
   query24  3.131.811.24
   query25  0.370.240.11
   query26  0.410.110.12
   query27  0.030.030.04
   query28  10.03   0.860.85
   query29  12.65   3.343.25
   query30  0.660.590.61
   query31  2.790.330.34
   query32  3.420.450.43
   query33  2.802.922.85
   query34  16.20   4.384.29
   query35  4.364.364.33
   query36  1.051.011.00
   query37  0.060.050.06
   query38  0.050.030.03
   query39  0.030.020.02
   query40  0.170.130.13
   query41  0.080.030.02
   query42  0.020.020.01
   query43  0.030.020.03
   Total cold run time: 104.11 s
   Total hot run time: 31.01 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993795614

   
   
   TPC-H: Total hot run time: 49995 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 334201ebe1964464d02f66ead0bef51a0777b571, 
data reload: false
   
   -- Round 1 --
   q1   17617   439243344334
   q2   2046151 137 137
   q3   10345   190219201902
   q4   10102   128513321285
   q5   8504393039423930
   q6   220 122 123 122
   q7   2041159515861586
   q8   9298272327212721
   q9   10592   10526   10403   10403
   q10  8624350735553507
   q11  424 247 231 231
   q12  454 298 307 298
   q13  18347   396140153961
   q14  346 336 324 324
   q15  510 457 456 456
   q16  704 586 592 586
   q17  1128973 932 932
   q18  7236688970066889
   q19  1677158615531553
   q20  546 306 298 298
   q21  4504413541364135
   q22  505 405 409 405
   Total cold run time: 115770 ms
   Total hot run time: 49995 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4353428642844284
   q2   315 220 225 220
   q3   4189416341274127
   q4   2768276427932764
   q5   7310719572217195
   q6   236 123 115 115
   q7   3252288029032880
   q8   4392454245804542
   q9   17222   17004   17012   17004
   q10  4249430642514251
   q11  772 703 673 673
   q12  1024866 851 851
   q13  7188370137393701
   q14  449 423 423 423
   q15  494 451 454 451
   q16  766 703 722 703
   q17  3882385539513855
   q18  8828879388808793
   q19  1709170816731673
   q20  2384211221132112
   q21  8569866784808480
   q22  1021956 925 925
   Total cold run time: 85372 ms
   Total hot run time: 80022 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [Improvement](runtime-filter) support sync join node build side's size to init bloom runtime filter [doris]

2024-03-13 Thread via GitHub


BiteThet opened a new pull request, #32180:
URL: https://github.com/apache/doris/pull/32180

   ## Proposed changes
   support sync join node build side's size to init bloom runtime filter
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Improvement](runtime-filter) support sync join node build side's size to init bloom runtime filter [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32180:
URL: https://github.com/apache/doris/pull/32180#issuecomment-1993795688

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Improvement](runtime-filter) support sync join node build side's size to init bloom runtime filter [doris]

2024-03-13 Thread via GitHub


BiteThet commented on PR #32180:
URL: https://github.com/apache/doris/pull/32180#issuecomment-1993795737

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1 [doris]

2024-03-13 Thread via GitHub


HappenLee merged PR #32162:
URL: https://github.com/apache/doris/pull/32162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated: [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1

2024-03-13 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository.

lihaopeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 954750b59a8  [Fix](smooth-upgrade) Fix incompatibility when upgrade 
from 2.0 to 2.1
954750b59a8 is described below

commit 954750b59a8c6d6eb0525c5daa6ed26d5351b839
Author: zclllyybb 
AuthorDate: Wed Mar 13 16:21:05 2024 +0800

 [Fix](smooth-upgrade) Fix incompatibility when upgrade from 2.0 to 2.1
---
 be/src/agent/be_exec_version_manager.h   |   9 ++---
 be/src/exprs/runtime_filter.cpp  |   3 ++-
 .../aggregate_functions/aggregate_function_bitmap.h  |  19 ++-
 .../aggregate_function_window_funnel.h   |   5 +++--
 be/src/vec/functions/simple_function_factory.h   |   4 ++--
 be/test/exec/test_data/wal_scanner/wal   | Bin 220 -> 180 bytes
 .../main/java/org/apache/doris/common/Config.java|   2 +-
 7 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/be/src/agent/be_exec_version_manager.h 
b/be/src/agent/be_exec_version_manager.h
index afe738684aa..0290e3bee32 100644
--- a/be/src/agent/be_exec_version_manager.h
+++ b/be/src/agent/be_exec_version_manager.h
@@ -58,8 +58,10 @@ private:
  *c. change the string hash method in runtime filter
  *d. elt function return type change to nullable(string)
  *e. add repeat_max_num in repeat function
- * 3: start from doris 2.1
+ * 3: start from doris 2.0 (by some mistakes)
  *a. aggregation function do not serialize bitmap to string.
+ * 4: start from doris 2.1
+ *a. support window funnel mode from 2.0
  *b. array contains/position/countequal function return nullable in less 
situations.
  *c. cleared old version of Version 2.
  *d. unix_timestamp function support timestamp with float for datetimev2, 
and change nullable mode.
@@ -67,10 +69,11 @@ private:
  *f. shrink some function's nullable mode.
  *g. do local merge of remote runtime filter
 */
-constexpr inline int BeExecVersionManager::max_be_exec_version = 3;
+constexpr inline int BeExecVersionManager::max_be_exec_version = 4;
 constexpr inline int BeExecVersionManager::min_be_exec_version = 0;
 
 /// functional
-constexpr inline int USE_NEW_SERDE = 3; // release on DORIS version 2.1
+constexpr inline int BITMAP_SERDE = 3;
+constexpr inline int USE_NEW_SERDE = 4; // release on DORIS version 2.1
 
 } // namespace doris
diff --git a/be/src/exprs/runtime_filter.cpp b/be/src/exprs/runtime_filter.cpp
index 6e4f57ef8e1..e8e169e8b9e 100644
--- a/be/src/exprs/runtime_filter.cpp
+++ b/be/src/exprs/runtime_filter.cpp
@@ -32,6 +32,7 @@
 #include 
 #include 
 
+#include "agent/be_exec_version_manager.h"
 #include "common/logging.h"
 #include "common/object_pool.h"
 #include "common/status.h"
@@ -993,7 +994,7 @@ Status IRuntimeFilter::publish(bool publish_local) {
 } else if (_has_local_target) {
 RETURN_IF_ERROR(send_to_local(_wrapper));
 } else if (!publish_local) {
-if (_is_broadcast_join || _state->be_exec_version < 3) {
+if (_is_broadcast_join || _state->be_exec_version < USE_NEW_SERDE) {
 RETURN_IF_ERROR(send_to_remote(this));
 } else {
 RETURN_IF_ERROR(do_local_merge());
diff --git a/be/src/vec/aggregate_functions/aggregate_function_bitmap.h 
b/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
index e9973377697..d3db5257b45 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
@@ -25,6 +25,7 @@
 #include 
 #include 
 
+#include "agent/be_exec_version_manager.h"
 #include "common/compiler_util.h" // IWYU pragma: keep
 #include "util/bitmap_value.h"
 #include "vec/aggregate_functions/aggregate_function.h"
@@ -159,7 +160,7 @@ public:
 
 void streaming_agg_serialize_to_column(const IColumn** columns, 
MutableColumnPtr& dst,
const size_t num_rows, Arena* 
arena) const override {
-if (version >= 3) {
+if (version >= BITMAP_SERDE) {
 auto& col = assert_cast(*dst);
 char place[sizeof(Data)];
 col.resize(num_rows);
@@ -177,7 +178,7 @@ public:
 
 void serialize_to_column(const std::vector& places, 
size_t offset,
  MutableColumnPtr& dst, const size_t num_rows) 
const override {
-if (version >= 3) {
+if (version >= BITMAP_SERDE) {
 auto& col = assert_cast(*dst);
 col.resize(num_rows);
 auto* data = col.get_data().data();
@@ -191,7 +192,7 @@ public:
 
 void deserialize_and_merge_from_column(AggregateDataPtr __restrict place, 
const IColumn& column,
Arena* arena) const override {
-if (version >= 3) {
+if (version >= BITMAP_SERDE) {
 auto& co

(doris) branch branch-2.1 updated (6d2924668e3 -> 2f4401189aa)

2024-03-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a change to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


from 6d2924668e3 [fix](audit-loader) fix invalid token check logic  (#32095)
 new 5539f85fec2 [fix](ui) fix database cannot be choosed bug (#32091)
 new 2f4401189aa [Bug](top-n) do not update topn filter when sort node and 
scan node are not in the… (#32159)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 be/src/olap/tablet_reader.cpp   |   2 -
 be/src/pipeline/exec/sort_sink_operator.cpp |  14 +--
 be/src/runtime/runtime_predicate.h  |  10 +-
 be/src/vec/exec/vsort_node.cpp  |  14 +--
 ui/src/pages/layout/index.tsx   | 108 -
 ui/src/pages/playground/tree/index.tsx  | 140 
 ui/src/router/renderRouter.tsx  |  37 
 ui/src/utils/utils.ts   |  10 +-
 8 files changed, 196 insertions(+), 139 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) 01/02: [fix](ui) fix database cannot be choosed bug (#32091)

2024-03-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 5539f85fec2ef8135bce956fbbc8d311d8a6912e
Author: Jeffrey 
AuthorDate: Tue Mar 12 22:56:59 2024 +0800

[fix](ui) fix database cannot be choosed bug (#32091)
---
 ui/src/pages/layout/index.tsx  | 108 +++--
 ui/src/pages/playground/tree/index.tsx | 140 +++--
 ui/src/router/renderRouter.tsx |  37 +
 ui/src/utils/utils.ts  |  10 ++-
 4 files changed, 172 insertions(+), 123 deletions(-)

diff --git a/ui/src/pages/layout/index.tsx b/ui/src/pages/layout/index.tsx
index 0ea4ba6257a..5feeb45a080 100644
--- a/ui/src/pages/layout/index.tsx
+++ b/ui/src/pages/layout/index.tsx
@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- * 
+ *
  *   http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -16,23 +16,23 @@
  * specific language governing permissions and limitations
  * under the License.
  */
- 
+
 /**
  * @file test cron
  * @author lpx
  * @since 2020/08/19
  */
-import React, {useState} from 'react';
-import {Layout, Menu, Dropdown, notification, Button} from 'antd';
-import { CaretDownOutlined, LogoutOutlined} from '@ant-design/icons';
-import {renderRoutes} from 'react-router-config';
-import {useHistory} from 'react-router-dom';
-import {useTranslation} from 'react-i18next';
+import React, { useState } from 'react';
+import { Layout, Menu, Dropdown, notification, Button } from 'antd';
+import { CaretDownOutlined, LogoutOutlined } from '@ant-design/icons';
+import { renderRoutes } from 'react-router-config';
+import { useHistory } from 'react-router-dom';
+import { useTranslation } from 'react-i18next';
 import routes from 'Src/router';
-import {logOut} from 'Src/api/api';
+import { logOut } from 'Src/api/api';
 import './index.css';
 import styles from './index.less';
-const {Header, Content, Footer} = Layout;
+const { Header, Content, Footer } = Layout;
 function Layouts(props: any) {
 let { t } = useTranslation();
 const [route, setRoute] = useState(props.route.routes);
@@ -48,7 +48,7 @@ function Layouts(props: any) {
 if (location.pathname === e.key) {
 location.reload();
 }
-if(location.pathname.includes('Playground')){
+if (location.pathname.includes('Playground')) {
 history.push(e.key);
 location.reload();
 }
@@ -59,52 +59,74 @@ function Layouts(props: any) {
 }
 function clearAllCookie() {
 var keys = document.cookie.match(/[^ =;]+(?=\=)/g);
-if(keys) {
-for(var i = keys.length; i--;)
-document.cookie = keys[i] + '=0;expires=' + new 
Date(0).toUTCString()
+if (keys) {
+for (var i = keys.length; i--; )
+document.cookie =
+keys[i] + '=0;expires=' + new Date(0).toUTCString();
 }
 }
-function onLogout(){
-logOut().then((res)=>{
-localStorage.setItem('username','');
+function onLogout() {
+logOut().then((res) => {
+localStorage.removeItem('username');
 clearAllCookie();
-notification.success({message: t('exitSuccessfully')})
+notification.success({ message: t('exitSuccessfully') });
 history.push('/login');
-})
+});
 }
-function changeLanguage(){
-if (localStorage.getItem('I18N_LANGUAGE') === 'zh-CN'){
-localStorage.setItem('I18N_LANGUAGE','en');
-location.reload()
+function changeLanguage() {
+if (localStorage.getItem('I18N_LANGUAGE') === 'zh-CN') {
+localStorage.setItem('I18N_LANGUAGE', 'en');
+location.reload();
 } else {
-localStorage.setItem('I18N_LANGUAGE','zh-CN');
-location.reload()
+localStorage.setItem('I18N_LANGUAGE', 'zh-CN');
+location.reload();
 }
 }
 const menu = (
 
 
-
+
 {t('signOut')}
 
 
 );
 return (
 
-
-{history.replace('/home');setCurrent('')}}>
-
-{localStorage.getItem('I18N_LANGUAGE') === 'zh-CN' ? 
'English' : '中文'}
+
+ {
+history.replace('/home');
+setCurrent('');
+}}
+>
+
+
+{localStorage.getIt

(doris) 02/02: [Bug](top-n) do not update topn filter when sort node and scan node are not in the… (#32159)

2024-03-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 2f4401189aa29efb171ff9cbb016109d89b9ab3f
Author: Pxl 
AuthorDate: Wed Mar 13 15:24:56 2024 +0800

[Bug](top-n) do not update topn filter when sort node and scan node are not 
in the… (#32159)
---
 be/src/olap/tablet_reader.cpp   |  2 --
 be/src/pipeline/exec/sort_sink_operator.cpp | 14 --
 be/src/runtime/runtime_predicate.h  | 10 --
 be/src/vec/exec/vsort_node.cpp  | 14 --
 4 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/be/src/olap/tablet_reader.cpp b/be/src/olap/tablet_reader.cpp
index 1cecd56a82a..f0229431b7b 100644
--- a/be/src/olap/tablet_reader.cpp
+++ b/be/src/olap/tablet_reader.cpp
@@ -578,8 +578,6 @@ void 
TabletReader::_init_conditions_param_except_leafnode_of_andnode(
 for (int id : read_params.topn_filter_source_node_ids) {
 auto& runtime_predicate =
 
read_params.runtime_state->get_query_ctx()->get_runtime_predicate(id);
-DCHECK(runtime_predicate.inited())
-<< "runtime predicate not inited, source_node_id=" << id;
 runtime_predicate.set_tablet_schema(_tablet_schema);
 }
 }
diff --git a/be/src/pipeline/exec/sort_sink_operator.cpp 
b/be/src/pipeline/exec/sort_sink_operator.cpp
index 657dd7d62d2..687332e1aec 100644
--- a/be/src/pipeline/exec/sort_sink_operator.cpp
+++ b/be/src/pipeline/exec/sort_sink_operator.cpp
@@ -154,13 +154,15 @@ Status SortSinkOperatorX::sink(doris::RuntimeState* 
state, vectorized::Block* in
 
local_state._mem_tracker->set_consumption(local_state._shared_state->sorter->data_size());
 RETURN_IF_CANCELLED(state);
 
-// update runtime predicate
 if (_use_topn_opt) {
-vectorized::Field new_top = 
local_state._shared_state->sorter->get_top_value();
-if (!new_top.is_null() && new_top != local_state.old_top) {
-auto* query_ctx = state->get_query_ctx();
-
RETURN_IF_ERROR(query_ctx->get_runtime_predicate(_node_id).update(new_top));
-local_state.old_top = std::move(new_top);
+auto& predicate = 
state->get_query_ctx()->get_runtime_predicate(_node_id);
+if (predicate.need_update()) {
+vectorized::Field new_top = 
local_state._shared_state->sorter->get_top_value();
+if (!new_top.is_null() && new_top != local_state.old_top) {
+auto* query_ctx = state->get_query_ctx();
+
RETURN_IF_ERROR(query_ctx->get_runtime_predicate(_node_id).update(new_top));
+local_state.old_top = std::move(new_top);
+}
 }
 }
 if (!_reuse_mem) {
diff --git a/be/src/runtime/runtime_predicate.h 
b/be/src/runtime/runtime_predicate.h
index fcfc9db7021..4975b037201 100644
--- a/be/src/runtime/runtime_predicate.h
+++ b/be/src/runtime/runtime_predicate.h
@@ -46,13 +46,19 @@ public:
 
 Status init(PrimitiveType type, bool nulls_first, bool is_asc, const 
std::string& col_name);
 
-bool inited() {
-std::unique_lock wlock(_rwlock);
+bool inited() const {
+std::shared_lock rlock(_rwlock);
 return _inited;
 }
 
+bool need_update() const {
+std::shared_lock rlock(_rwlock);
+return _inited && _tablet_schema;
+}
+
 void set_tablet_schema(TabletSchemaSPtr tablet_schema) {
 std::unique_lock wlock(_rwlock);
+// when sort node and scan node are not in the same backend, predicate 
will not be initialized
 if (_tablet_schema || !_inited) {
 return;
 }
diff --git a/be/src/vec/exec/vsort_node.cpp b/be/src/vec/exec/vsort_node.cpp
index b142f011697..160690f7737 100644
--- a/be/src/vec/exec/vsort_node.cpp
+++ b/be/src/vec/exec/vsort_node.cpp
@@ -141,13 +141,15 @@ Status VSortNode::sink(RuntimeState* state, 
vectorized::Block* input_block, bool
 RETURN_IF_ERROR(_sorter->append_block(input_block));
 RETURN_IF_CANCELLED(state);
 
-// update runtime predicate
 if (_use_topn_opt) {
-Field new_top = _sorter->get_top_value();
-if (!new_top.is_null() && new_top != old_top) {
-auto* query_ctx = state->get_query_ctx();
-
RETURN_IF_ERROR(query_ctx->get_runtime_predicate(_id).update(new_top));
-old_top = std::move(new_top);
+auto& predicate = 
state->get_query_ctx()->get_runtime_predicate(_id);
+if (predicate.need_update()) {
+vectorized::Field new_top = _sorter->get_top_value();
+if (!new_top.is_null() && new_top != old_top) {
+auto* query_ctx = state->get_query_ctx();
+
RETURN_IF_ERROR(query_ctx->get_runtime_predicate(_id).update

Re: [PR] [feature](merge-cloud) enable merge on write by default [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32175:
URL: https://github.com/apache/doris/pull/32175#issuecomment-1993798093

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 5b798b4e176740c9efac33a27dece22c7a0a7886 with 
default session variables
   Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:  59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:   13.5 seconds inserted 1000 Rows, about 740K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] save code null aware in runtime filter [doris]

2024-03-13 Thread via GitHub


doris-robot commented on PR #32152:
URL: https://github.com/apache/doris/pull/32152#issuecomment-1993801583

   
   
   ClickBench: Total hot run time: 31.2 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 08fb4441f5fb7552fb5147ec73d329badad8d53e, 
data reload: false
   
   query1   0.040.030.03
   query2   0.060.020.02
   query3   0.230.060.06
   query4   1.680.100.10
   query5   0.520.500.53
   query6   1.190.620.63
   query7   0.020.020.02
   query8   0.040.030.02
   query9   0.570.500.51
   query10  0.550.540.53
   query11  0.130.100.09
   query12  0.120.090.08
   query13  0.560.570.56
   query14  0.770.750.77
   query15  0.800.780.77
   query16  0.390.400.39
   query17  1.041.011.03
   query18  0.200.270.24
   query19  1.881.711.76
   query20  0.010.010.01
   query21  15.43   0.580.57
   query22  2.591.612.05
   query23  17.43   0.800.87
   query24  2.942.111.94
   query25  0.260.070.03
   query26  0.690.120.12
   query27  0.020.030.02
   query28  9.940.890.86
   query29  12.59   3.253.28
   query30  0.660.600.55
   query31  2.800.330.34
   query32  3.380.430.44
   query33  2.762.792.76
   query34  16.10   4.324.31
   query35  4.344.364.33
   query36  1.071.020.99
   query37  0.070.050.05
   query38  0.040.030.04
   query39  0.030.020.01
   query40  0.180.150.14
   query41  0.070.020.02
   query42  0.030.020.02
   query43  0.030.020.03
   Total cold run time: 104.25 s
   Total hot run time: 31.2 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub


platoneko commented on PR #31853:
URL: https://github.com/apache/doris/pull/31853#issuecomment-1993801944

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (954750b59a8 -> 31da1bb9e42)

2024-03-13 Thread huajianlan
This is an automated email from the ASF dual-hosted git repository.

huajianlan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 954750b59a8  [Fix](smooth-upgrade) Fix incompatibility when upgrade 
from 2.0 to 2.1
 add 31da1bb9e42 [fix](regression-test) upgrade groovy to 4.x and enable 
run test by jdk17/21 again

No new revisions were added by this update.

Summary of changes:
 regression-test/framework/pom.xml | 89 +--
 1 file changed, 29 insertions(+), 60 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](regression-test) upgrade groovy to 4.x and enable run test by jdk17/21 again [doris]

2024-03-13 Thread via GitHub


924060929 merged PR #32173:
URL: https://github.com/apache/doris/pull/32173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](merge-cloud) Add multi cloud cluster [doris]

2024-03-13 Thread via GitHub


yujun777 commented on PR #31749:
URL: https://github.com/apache/doris/pull/31749#issuecomment-1993807750

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   6   7   >