XieJiann commented on code in PR #31751:
URL: https://github.com/apache/doris/pull/31751#discussion_r1522695502
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateSort.java:
##########
@@ -57,21 +59,24 @@ public Plan visit(Plan plan, Boolean pruneSort) {
@Override
public Plan visitLogicalSort(LogicalSort<? extends Plan> sort, Boolean
eliminateSort) {
if (eliminateSort) {
- return visit(sort.child(), true);
+ return visit(sort.child(), eliminateSort);
}
- return visit(sort, true);
+ return visit(sort, eliminateSort);
}
Review Comment:
why pass `eliminateSort` rather than true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
