Lchangliang commented on code in PR #30039:
URL: https://github.com/apache/doris/pull/30039#discussion_r1522681904
##########
be/src/io/fs/file_writer.h:
##########
@@ -33,8 +33,8 @@ class FileSystem;
struct FileWriterOptions {
bool write_file_cache = false;
bool is_cold_data = false;
- bool sync_file_data = true; // Whether flush data into storage
system
- int64_t file_cache_expiration = 0; // Absolute time
+ bool sync_file_data = true; // Whether flush data into storage
system
+ uint64_t file_cache_expiration = 0; // Absolute time
Review Comment:
Because the table property `file_cache_ttl_seconds` is long in FE, it maybe
set the LONG_MAX value. file_cache_expiration = cur_time +
file_cache_ttl_seconds, it will overflow if not uint64_t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
