[GitHub] [doris] github-actions[bot] commented on pull request #22883: [Enhancement] submit Baidu test cases

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #22883:
URL: https://github.com/apache/doris/pull/22883#issuecomment-1700474249

    `sh-checker report`
   
   To get the full details, please check in the 
[job]("https://github.com/apache/doris/actions/runs/6034077823";) output.
   
   
   shellcheck errors
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   --
   
   In pytest/deploy/qe/init_data.sh line 23:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "DROP DATABASE IF EXISTS ${FE_DB}"
 ^^ SC2154 (warning): FE_HOST is referenced but not 
assigned.
^--^ SC2154 (warning): FE_QUERY_PORT is 
referenced but not assigned.
 ^^ SC2154 (warning): 
FE_USER is referenced but not assigned.
^^ 
SC2154 (warning): FE_PASSWORD is referenced but not assigned.

^--^ SC2154 (warning): FE_DB is referenced but 
not assigned.
   
   
   In pytest/deploy/qe/init_data.sh line 27:
   curl --location-trusted -T baseall.txt -u "${FE_USER}":"${FE_PASSWORD}" 
http://"${FE_HOST}":"${FE_WEB_PORT}"/api/"${FE_DB}"/baseall/_stream_load

^^ SC2154 (warning): FE_WEB_PORT is referenced but 
not assigned.
   
   
   In pytest/deploy/qe/init_data_broker.sh line 24:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "DROP DATABASE IF EXISTS ${FE_DB}"
 ^^ SC2154 (warning): FE_HOST is referenced but not 
assigned.
^--^ SC2154 (warning): FE_QUERY_PORT is 
referenced but not assigned.
 ^^ SC2154 (warning): 
FE_USER is referenced but not assigned.
^^ 
SC2154 (warning): FE_PASSWORD is referenced but not assigned.

^--^ SC2154 (warning): FE_DB is referenced but 
not assigned.
   
   
   In pytest/deploy/qe/init_data_broker.sh line 33:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "LOAD LABEL ${FE_DB}.label_1 (DATA 
INFILE('${hdfs_data_path}/qe/baseall.txt') INTO TABLE baseall COLUMNS 
TERMINATED BY '${separator}') ${broker_property}"

  ^---^ SC2154 
(warning): hdfs_data_path is referenced but not assigned.


  ^^ 
SC2154 (warning): broker_property is referenced but not assigned.
   
   
   In pytest/deploy/qe/init_data_duplicate.sh line 23:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "DROP DATABASE IF EXISTS ${FE_DB}"
 ^^ SC2154 (warning): FE_HOST is referenced but not 
assigned.
^--^ SC2154 (warning): FE_QUERY_PORT is 
referenced but not assigned.
 ^^ SC2154 (warning): 
FE_USER is referenced but not assigned.
^^ 
SC2154 (warning): FE_PASSWORD is referenced but not assigned.

^--^ SC2154 (warning): FE_DB is referenced but 
not assigned.
   
   
   In pytest/deploy/qe/init_data_duplicate.sh line 32:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "LOAD LABEL ${FE_DB}.label_1 (DATA 
INFILE('${hdfs_data_path}/qe/baseall.txt') INTO TABLE baseall COLUMNS 
TERMINATED BY '${separator}') ${broker_property}"

  ^---^ SC2154 
(warning): hdfs_data_path is referenced but not assigned.


  ^^ 
SC2154 (warning): broker_property is referenced but not assigned.
   
   
   In pytest/deploy/qe/init_data_list.sh line 23:
   mysql -h "${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${FE_USER}" -p"${FE_PASSWORD}" 
-e "DROP DATABAS

[GitHub] [doris] morrySnow commented on pull request #23632: [opt](Nereids) let keywords list same with legacy planner

2023-08-31 Thread via GitHub


morrySnow commented on PR #23632:
URL: https://github.com/apache/doris/pull/23632#issuecomment-1700476031

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zhangy5 commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-31 Thread via GitHub


zhangy5 commented on code in PR #22883:
URL: https://github.com/apache/doris/pull/22883#discussion_r1311182940


##
pytest/run_case.sh:
##
@@ -0,0 +1,325 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+export ROOT_PATH=$(pwd)
+export SYS_PATH=${ROOT_PATH}/sys
+export QE_PATH=${ROOT_PATH}/qe/palo2/src
+export QE_BUG_PATH=${ROOT_PATH}/qe/query_regression
+export REPORT_PATH=${ROOT_PATH}/result
+export ENV_PATH=${ROOT_PATH}/lib
+export 
PYTHONPATH=${PYTHONPATH}:${ROOT_PATH}:${ROOT_PATH}/sys:${ROOT_PATH}/qe/palo2/lib:${ROOT_PATH}/deploy
+rm -f ${ROOT_PATH}/*.xml | tee
+rm -f ${ROOT_PATH}/*.html | tee
+rm -rf ${REPORT_PATH}
+mkdir -p ${REPORT_PATH}
+
+cd ${SYS_PATH}
+
+if [[ -z ${testsuite} ]]; then
+testsuite=normal
+fi
+
+if [[ -z ${PROCESS_NUM} ]]; then
+PROCESS_NUM=30
+fi
+
+if [[ -z ${RESTART_BE_AUTO} ]]; then
+RESTART_BE_AUTO=false
+fi
+
+[[ -e /tmp/fd1 ]] || mkfifo /tmp/fd1
+exec 3<>/tmp/fd1
+rm -rf /tmp/fd1
+
+for ((i=1;i<=PROCESS_NUM;i++))
+do
+echo >&3
+done
+
+function check_cluster ()
+{
+# check if fe or be dead and start it
+cd ${ENV_PATH}
+python node_op.py -c '''
+import Node
+Node.check_cluster(fe_check=False)
+'''
+}
+
+function pytest_execute ()
+{
+case_file=$1
+ls ${case_file}
+pytest -sv --junit-xml="${REPORT_PATH}"/"${case_file%.py}".xml 
--html="${REPORT_PATH}"/"${case_file%.py}".html  "${case_file}" --tb=native 
2>&1 > "${case_file%.py}".log

Review Comment:
   done



##
pytest/run_case.sh:
##
@@ -0,0 +1,325 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+export ROOT_PATH=$(pwd)
+export SYS_PATH=${ROOT_PATH}/sys
+export QE_PATH=${ROOT_PATH}/qe/palo2/src
+export QE_BUG_PATH=${ROOT_PATH}/qe/query_regression
+export REPORT_PATH=${ROOT_PATH}/result
+export ENV_PATH=${ROOT_PATH}/lib
+export 
PYTHONPATH=${PYTHONPATH}:${ROOT_PATH}:${ROOT_PATH}/sys:${ROOT_PATH}/qe/palo2/lib:${ROOT_PATH}/deploy
+rm -f ${ROOT_PATH}/*.xml | tee
+rm -f ${ROOT_PATH}/*.html | tee
+rm -rf ${REPORT_PATH}
+mkdir -p ${REPORT_PATH}
+
+cd ${SYS_PATH}
+
+if [[ -z ${testsuite} ]]; then
+testsuite=normal
+fi
+
+if [[ -z ${PROCESS_NUM} ]]; then
+PROCESS_NUM=30
+fi
+
+if [[ -z ${RESTART_BE_AUTO} ]]; then
+RESTART_BE_AUTO=false
+fi
+
+[[ -e /tmp/fd1 ]] || mkfifo /tmp/fd1
+exec 3<>/tmp/fd1
+rm -rf /tmp/fd1
+
+for ((i=1;i<=PROCESS_NUM;i++))
+do
+echo >&3
+done
+
+function check_cluster ()
+{
+# check if fe or be dead and start it
+cd ${ENV_PATH}
+python node_op.py -c '''
+import Node
+Node.check_cluster(fe_check=False)
+'''
+}
+
+function pytest_execute ()
+{
+case_file=$1
+ls ${case_file}
+pytest -sv --junit-xml="${REPORT_PATH}"/"${case_file%.py}".xml 
--html="${REPORT_PATH}"/"${case_file%.py}".html  "${case_file}" --tb=native 
2>&1 > "${case_file%.py}".log
+sleep 1
+}
+
+function case_execute ()
+{
+for case_file in "$@"

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apach

[GitHub] [doris] Kikyou1997 commented on pull request #23622: [enhancement](nereids) Split period from auto collector

2023-08-31 Thread via GitHub


Kikyou1997 commented on PR #23622:
URL: https://github.com/apache/doris/pull/23622#issuecomment-1700486005

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] sohardforaname commented on pull request #23121: [Feature](Nereids)support insert into values for Nereids

2023-08-31 Thread via GitHub


sohardforaname commented on PR #23121:
URL: https://github.com/apache/doris/pull/23121#issuecomment-1700486266

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] sohardforaname commented on pull request #23384: [Feature](Nereids)support cte for update and delete statements of Nereids

2023-08-31 Thread via GitHub


sohardforaname commented on PR #23384:
URL: https://github.com/apache/doris/pull/23384#issuecomment-1700487816

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23582:
URL: https://github.com/apache/doris/pull/23582#issuecomment-1700496253

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.48 seconds
stream load tsv:  533 seconds loaded 74807831229 Bytes, about 133 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17162102199 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] starocean999 opened a new pull request, #23700: [fix](nereids)NormalizeAggregate may push redundant expr to child project node

2023-08-31 Thread via GitHub


starocean999 opened a new pull request, #23700:
URL: https://github.com/apache/doris/pull/23700

   NormalizeAggregate may push exprs to child project node. We need make sure 
there is no redundant expr in the pushed down expr list. This pr use 'Set' to 
make sure of that.
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] starocean999 commented on pull request #23700: [fix](nereids)NormalizeAggregate may push redundant expr to child project node

2023-08-31 Thread via GitHub


starocean999 commented on PR #23700:
URL: https://github.com/apache/doris/pull/23700#issuecomment-1700499444

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700514197

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] xiaokang opened a new pull request, #23701: [improvement][config] add a specific be config for segment_cache_capacity

2023-08-31 Thread via GitHub


xiaokang opened a new pull request, #23701:
URL: https://github.com/apache/doris/pull/23701

   ## Proposed changes
   
   Issue Number: close #xxx
   
   Currently, segment cache capacity is caculated by `fd limit * 2/5`. It's not 
flexible to change it since changing fd limit affects others.
   
   Add a specific be config for segment_cache_capacity. If the config >= `fd 
limit * 2/5`, set it back to `fd limit * 2/5` to avoid open too many files.
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] bobhan1 opened a new pull request, #23702: [Feature](config) allow update multiple be configs in one request

2023-08-31 Thread via GitHub


bobhan1 opened a new pull request, #23702:
URL: https://github.com/apache/doris/pull/23702

   ## Proposed changes
   
   currently, doris only support updating one config in a request. This PR 
allows updating multiple configs in one request. The updates are performed 
**one by one** and it's guaranteed these updates are atomic. The results of 
every update will be returned.
   
   Example:
   ```
   curl -X POST 
"http://127.0.0.1:8049/api/update_config?agent_task_trace_threshold_sec=2&enable_segcompaction=false&eable_time_lut=false";
   ```
   ```
   [
   {
   "config_name": "agent_task_trace_threshold_sec",
   "status": "OK",
   "msg": ""
   },
   {
   "config_name": "enable_segcompaction",
   "status": "BAD",
   "msg": "set enable_segcompaction=false failed, reason: 
[NOT_IMPLEMENTED_ERROR]'enable_segcompaction' is not support to modify."
   },
   {
   "config_name": "enable_time_lut",
   "status": "BAD",
   "msg": "set enable_time_lut=false failed, reason: 
[NOT_IMPLEMENTED_ERROR]'enable_time_lut' is not support to modify."
   }
   ]
   ```
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] bobhan1 commented on pull request #23702: [Feature](config) allow update multiple be configs in one request

2023-08-31 Thread via GitHub


bobhan1 commented on PR #23702:
URL: https://github.com/apache/doris/pull/23702#issuecomment-1700518558

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23701: [improvement][config] add a specific be config for segment_cache_capacity

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23701:
URL: https://github.com/apache/doris/pull/23701#issuecomment-1700524158

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zy-kkk commented on issue #23367: jdbc catalog postresql bit(1) types with bool type ,but query error

2023-08-31 Thread via GitHub


zy-kkk commented on issue #23367:
URL: https://github.com/apache/doris/issues/23367#issuecomment-1700524740

   > select k1, k2 from cat_postgresql1.doris_test.test1 where cast (k1 as int) 
= 1. also error ][INTERNAL_ERROR]UdfRuntimeException: JDBC executor sql has 
error: CAUSED BY: PSQLException: ERROR: operator does not exist: bit = integer 
Hint: No operator matches the given name and argument types. You might need to 
add explicit type casts. Position: 57
   
   You can add my wechat: zyk815574403, we look at this problem together?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23702: [Feature](config) allow update multiple be configs in one request

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23702:
URL: https://github.com/apache/doris/pull/23702#issuecomment-1700525281

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700525974

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Jibing-Li opened a new pull request, #23703: [Improvement](statistics)Show column stats even when error accured.

2023-08-31 Thread via GitHub


Jibing-Li opened a new pull request, #23703:
URL: https://github.com/apache/doris/pull/23703

   Before, show column stats will ignore column with error.
   In this pr, when min or max value failed to deserialize, show column stats 
will use N/A as value of min or max, and still show the rest stats. (count, 
null_count, ndv and so on).
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] dutyu commented on pull request #23391: [Feature](multi-catalog) Support sql cache for hms catalog

2023-08-31 Thread via GitHub


dutyu commented on PR #23391:
URL: https://github.com/apache/doris/pull/23391#issuecomment-1700529340

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on a diff in pull request #23613: [Fix](Planner) fix create table as select failed

2023-08-31 Thread via GitHub


morrySnow commented on code in PR #23613:
URL: https://github.com/apache/doris/pull/23613#discussion_r1311227406


##
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
 queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
 .setIsAllowNull(outputs.get(i).isNullable());
 }
+if (Config.disable_datev1 && 
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {

Review Comment:
   i think we should use `Config.enable_date_conversion`?



##
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
 queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
 .setIsAllowNull(outputs.get(i).isNullable());
 }
+if (Config.disable_datev1 && 
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {

Review Comment:
   process datetime and decimal too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] xiaokang commented on pull request #23701: [improvement](config) add a specific be config for segment_cache_capacity

2023-08-31 Thread via GitHub


xiaokang commented on PR #23701:
URL: https://github.com/apache/doris/pull/23701#issuecomment-1700531101

   run buildall 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yiguolei merged pull request #23691: [1.2](pick) Fix decimal type

2023-08-31 Thread via GitHub


yiguolei merged PR #23691:
URL: https://github.com/apache/doris/pull/23691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch branch-1.2-lts updated: [1.2](pick) Fix decimal type (#23691)

2023-08-31 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
 new 6f1216516f [1.2](pick) Fix decimal type (#23691)
6f1216516f is described below

commit 6f1216516f7ae9a12b307ce639d87634da979bb1
Author: Gabriel 
AuthorDate: Thu Aug 31 15:46:30 2023 +0800

[1.2](pick) Fix decimal type (#23691)
---
 .../src/main/java/org/apache/doris/catalog/ScalarType.java| 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java 
b/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
index 4fc74f3cb9..bad99d09fd 100644
--- a/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
+++ b/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
@@ -1020,8 +1020,12 @@ public class ScalarType extends Type {
 return t1.isDecimalV2() ? t1 : t2;
 }
 
-if ((t1.isDecimalV3() && t2.isFixedPointType()) || (t2.isDecimalV3() 
&& t1.isFixedPointType())) {
-return t1.isDecimalV3() ? t1 : t2;
+if (t1.isDecimalV3() || t2.isDecimalV3()) {
+if (t1.isFloatingPointType() || t2.isFloatingPointType()) {
+return t1.isFloatingPointType() ? t1 : t2;
+} else if (t1.isBoolean() || t2.isBoolean()) {
+return t1.isDecimalV3() ? t1 : t2;
+}
 }
 
 if (t1.isDecimalV3() && t2.isDecimalV3()) {


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on a diff in pull request #23692: [Fix](Nereids) fix infer predicate lost cast of source expression

2023-08-31 Thread via GitHub


morrySnow commented on code in PR #23692:
URL: https://github.com/apache/doris/pull/23692#discussion_r1311229754


##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java:
##
@@ -102,8 +102,14 @@ private Expression replaceSlot(Expression expr, DataType 
originDataType) {
 return expr.rewriteUp(e -> {
 if (isDataTypeValid(originDataType, 
leftSlotEqualToRightSlot)) {
 if (ExpressionUtils.isTwoExpressionEqualWithCast(e, 
leftSlotEqualToRightSlot.child(0))) {
+if 
(!leftSlotEqualToRightSlot.child(1).getDataType().equals(e.getDataType())) {

Review Comment:
   add some ut case please~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zhangstar333 commented on pull request #23539: [FE](fucntion) add date_floor/ceil in FE function

2023-08-31 Thread via GitHub


zhangstar333 commented on PR #23539:
URL: https://github.com/apache/doris/pull/23539#issuecomment-1700533765

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on pull request #23657: [Fix](Nereids) fix test leading random failed

2023-08-31 Thread via GitHub


morrySnow commented on PR #23657:
URL: https://github.com/apache/doris/pull/23657#issuecomment-1700536107

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700537680

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow merged pull request #23271: [feature](nereids)support subquery in select list

2023-08-31 Thread via GitHub


morrySnow merged PR #23271:
URL: https://github.com/apache/doris/pull/23271


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [feature](nereids) support subquery in select list (#23271)

2023-08-31 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 7379cdc995 [feature](nereids) support subquery in select list (#23271)
7379cdc995 is described below

commit 7379cdc9953f9ee16733ed67e5e12434cd38b263
Author: starocean999 <40539150+starocean...@users.noreply.github.com>
AuthorDate: Thu Aug 31 15:51:32 2023 +0800

[feature](nereids) support subquery in select list (#23271)

1. add scalar subquery's output to LogicalApply's output
2. for in and exists subquery's, add mark join slot into LogicalApply's 
output
3. forbid push down alias through join if the project list have any mark 
join slots.
4. move normalize aggregate rule to analysis phase
---
 .../doris/nereids/jobs/executor/Analyzer.java  |  11 +-
 .../doris/nereids/jobs/executor/Rewriter.java  |   9 +-
 .../EliminateGroupByConstant.java  |   3 +-
 .../{rewrite => analysis}/NormalizeAggregate.java  |   4 +-
 .../nereids/rules/analysis/SubqueryToApply.java|  92 +++---
 .../rules/implementation/AggregateStrategies.java  |   2 +-
 .../rules/rewrite/PushdownAliasThroughJoin.java|   5 +-
 .../doris/nereids/trees/expressions/CaseWhen.java  |   2 +-
 .../trees/expressions/literal/DoubleLiteral.java   |   5 +
 .../trees/expressions/literal/FloatLiteral.java|   9 +
 .../nereids/rules/analysis/AnalyzeCTETest.java |   2 +-
 .../rules/analysis/AnalyzeWhereSubqueryTest.java   |  70 ++--
 .../rules/analysis/BindSlotReferenceTest.java  |   7 +-
 .../EliminateGroupByConstantTest.java  |   3 +-
 .../rules/analysis/FillUpMissingSlotsTest.java | 354 +++--
 .../NormalizeAggregateTest.java|   2 +-
 .../rules/rewrite/AggregateStrategiesTest.java |   1 +
 .../nereids/rules/rewrite/ColumnPruningTest.java   |  17 +-
 .../ExtractAndNormalizeWindowExpressionTest.java   |   1 +
 .../rewrite/PushdownAliasThroughJoinTest.java  |  23 ++
 .../PushdownExpressionsInHashConditionTest.java|  34 +-
 .../rules/rewrite/mv/SelectRollupIndexTest.java|   4 +-
 .../subquery/test_subquery_in_project.out  |  50 +++
 .../nereids_tpcds_shape_sf100_p0/shape/query1.out  |  15 +-
 .../nereids_tpcds_shape_sf100_p0/shape/query30.out |  15 +-
 .../nereids_tpcds_shape_sf100_p0/shape/query51.out |  42 +--
 .../nereids_tpcds_shape_sf100_p0/shape/query81.out |  15 +-
 .../nereids_tpch_shape_sf1000_p0/shape/q20.out |  13 +-
 .../data/nereids_tpch_shape_sf500_p0/shape/q20.out |  13 +-
 .../subquery/test_subquery_in_project.groovy   | 120 +++
 30 files changed, 610 insertions(+), 333 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Analyzer.java 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Analyzer.java
index 1fb1d7eecd..ed67b44f1f 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Analyzer.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Analyzer.java
@@ -30,7 +30,9 @@ import org.apache.doris.nereids.rules.analysis.BindSink;
 import org.apache.doris.nereids.rules.analysis.CheckAnalysis;
 import org.apache.doris.nereids.rules.analysis.CheckBound;
 import org.apache.doris.nereids.rules.analysis.CheckPolicy;
+import org.apache.doris.nereids.rules.analysis.EliminateGroupByConstant;
 import org.apache.doris.nereids.rules.analysis.FillUpMissingSlots;
+import org.apache.doris.nereids.rules.analysis.NormalizeAggregate;
 import org.apache.doris.nereids.rules.analysis.NormalizeRepeat;
 import org.apache.doris.nereids.rules.analysis.ProjectToGlobalAggregate;
 import org.apache.doris.nereids.rules.analysis.ProjectWithDistinctToAggregate;
@@ -110,9 +112,14 @@ public class Analyzer extends AbstractBatchJobExecutor {
 // LogicalProject for normalize. This rule depends on 
FillUpMissingSlots to fill up slots.
 new NormalizeRepeat()
 ),
-bottomUp(new SubqueryToApply()),
 bottomUp(new AdjustAggregateNullableForEmptySet()),
-bottomUp(new CheckAnalysis())
+// run CheckAnalysis before EliminateGroupByConstant in order to 
report error message correctly like bellow
+// select SUM(lo_tax) FROM lineorder group by 1;
+// errCode = 2, detailMessage = GROUP BY expression must not 
contain aggregate functions: sum(lo_tax)
+bottomUp(new CheckAnalysis()),
+topDown(new EliminateGroupByConstant()),
+topDown(new NormalizeAggregate()),
+bottomUp(new SubqueryToApply())
 );
 }
 }
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
index ec2ea06eac..986947c262 100644
--- 
a/fe/fe-core/sr

[GitHub] [doris] zhannngchen merged pull request #23666: [Fix](meta lock) Should not acquire wlock twice

2023-08-31 Thread via GitHub


zhannngchen merged PR #23666:
URL: https://github.com/apache/doris/pull/23666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated (7379cdc995 -> cb2515b7c8)

2023-08-31 Thread zhangchen
This is an automated email from the ASF dual-hosted git repository.

zhangchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 7379cdc995 [feature](nereids) support subquery in select list (#23271)
 add cb2515b7c8 [Fix](meta lock) Should not acquire wlock twice (#23666)

No new revisions were added by this update.

Summary of changes:
 be/src/olap/tablet.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zhiqiang-hhhh opened a new issue, #23704: [Enhancement] A mechanism to cancel query when one of involved node (FE/BE) restarted or dead

2023-08-31 Thread via GitHub


zhiqiang- opened a new issue, #23704:
URL: https://github.com/apache/doris/issues/23704

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Description
   
   ### Problem background
   
   As the title suggests, in the current version (2.0), when a node (FE + BE) 
in the doris cluster restarts or hangs up, the query undertaken by that node 
cannot be cancelled in time within the cluster, and can only be cancelled after 
the query times out (30 minutes).
   
   ### Overall idea
   The essence of this problem is actually how BE/FE can perceive the changes 
in the node status in the cluster. Because once we can use some mechanism to 
correctly send the event of a FE/BE process restart/hang up to all nodes in the 
cluster, then the problem will become a memory computation problem, which is 
easy to solve:
   
   1. For FE
   Each FE memory records all queries initiated from the current FE, as well as 
which be each query's fragment is on. If FE observes that a BE in the cluster 
hangs up/restarts, it only needs to judge whether there is a query fragment 
that falls on the faulty be. If so, FE can actively initiate cancel_query(list 
of queryIds); if FE observes that a FE restarts, if it is master, it broadcasts 
an event FEx fault to all BEs, if it is follower, it can choose to wait for 
leader election/or other strategies.
   2. For BE
   There is currently no heartbeat mechanism between BE and BE, and as the 
execution carrier of the fragment, it does not know the distribution of a query 
in the cluster. Therefore, at present be can only do one thing actively: 
release the relevant resources in the current process according to the query id 
passed by FE. But this cannot handle the situation where a FE fails. This 
situation can be solved by adding a field in the query parameters sent by FE to 
BE: original fe ip:port + fe start uuid. Each fe starts and generates a fe 
start start id saved in memory. Once a fe restarts/fails, then other surviving 
fe broadcast an event to all be in the cluster, which records a field: 
breakdown fe ip:port + new start id. After receiving this event, be first 
judges whether there is a query with original fe ip:port == breakdown fe 
ip:port in the current execution, and if so, further judges whether a query 
needs to be cancelled by fe start uuid (to solve the problem of wrong 
cancellation of ne
 w queries due to fe restart time difference).
   
   In short, when we can implement the mechanism of broadcasting node status 
changes to all nodes in the cluster, subsequent query cancellation will 
actually become a memory computation problem.
   
   ### Implementation plan
    Current situation
   Simplified, the current doris overall control and data model are as follows:
   
   Control flow:
   FE (master) process memory saves the cluster's real-time full metadata. The 
master process starts and creates a HearbeatMgr thread, which sends heartbeat 
requests to all nodes in the cluster except itself, and then waits 
asynchronously for heartbeat results. For each heartbeat result obtained, judge 
whether the node has changed status. If the node status changes or fails to get 
heartbeat, then write this information as oplog into bdb. FE (follower) will 
asynchronously replay oplog after last checkpoint and replay oplog to its own 
memory.
    Modification
   Before proposing modifications, some assumptions need to be made:
   - Do not consider FE leader election failure related (no leader/multiple 
leaders) situations, because FE leader election failure is a serious level and 
solution priority far higher than BE resource not being released problem
   - Consider based on bdbje log synchronization mechanism relatively stable, 
can complete oplog synchronization within a reasonable time interval
   - Consider FE node from process shutdown to restart, and then to log print 
Qe service start this time interval long enough, will not appear within one 
heartbeat interval some FE node multiple restarts situation
   
   # Solve FE restart
   FE generates a UUID at startup stage, this UUID is used to identify a FE 
restart action. FE (folloer) and FE (master) heartbeat response will carry this 
UUID. And FE (master) sends heartbeat request to BE will contain all nodes' 
startup uuid in cluster.
   If there is some FE (follower) unable to return heartbeat response, then FE 
(master) needs to generate a temporary uuid for that FE and send this temporary 
uuid to BE.
   
   When BE receives the heartbeat request from FE (master), it needs to compare 
the current frontend_infos with the previous frontend_infos saved in memory. If 
it finds that the startup uuid of some fe has changed, it cancels all fragments 
related to that query locally.
   If the restart node is master, it needs to wait for leader election to 
succeed first. After leader election succeeds,

[GitHub] [doris] starocean999 commented on pull request #23700: [fix](nereids)NormalizeAggregate may push redundant expr to child project node

2023-08-31 Thread via GitHub


starocean999 commented on PR #23700:
URL: https://github.com/apache/doris/pull/23700#issuecomment-1700548566

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700562981

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23632: [opt](Nereids) let keywords list same with legacy planner

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23632:
URL: https://github.com/apache/doris/pull/23632#issuecomment-1700565910

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.46 seconds
stream load tsv:  546 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17162184363 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23580: [Bug](materialized-view) fix mv not match because cast and alias name

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23580:
URL: https://github.com/apache/doris/pull/23580#issuecomment-1700566087

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.92 seconds
stream load tsv:  545 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17162290740 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23384: [Feature](Nereids)support cte for update and delete statements of Nereids

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23384:
URL: https://github.com/apache/doris/pull/23384#issuecomment-1700566193

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.58 seconds
stream load tsv:  550 seconds loaded 74807831229 Bytes, about 129 
MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.1 seconds inserted 1000 Rows, about 
343K ops/s
storage size: 17162230759 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23580: [Bug](materialized-view) fix mv not match because cast and alias name

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23580:
URL: https://github.com/apache/doris/pull/23580#issuecomment-1700566241

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.51 seconds
stream load tsv:  548 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.3 seconds inserted 1000 Rows, about 
341K ops/s
storage size: 17162029527 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23622: [enhancement](nereids) Split period from auto collector

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23622:
URL: https://github.com/apache/doris/pull/23622#issuecomment-1700566014

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.39 seconds
stream load tsv:  546 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17162140776 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23121: [Feature](Nereids)support insert into values for Nereids

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23121:
URL: https://github.com/apache/doris/pull/23121#issuecomment-1700566253

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.06 seconds
stream load tsv:  546 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.2 seconds inserted 1000 Rows, about 
342K ops/s
storage size: 17162188181 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23700: [fix](nereids)NormalizeAggregate may push redundant expr to child project node

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23700:
URL: https://github.com/apache/doris/pull/23700#issuecomment-1700566825

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.87 seconds
stream load tsv:  546 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  30 seconds loaded 861443392 Bytes, about 27 
MB/s
insert into select:  29.2 seconds inserted 1000 Rows, about 
342K ops/s
storage size: 17162233469 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] bobhan1 opened a new pull request, #23705: [Docs](alter partition) Fix the docs of adding default partition

2023-08-31 Thread via GitHub


bobhan1 opened a new pull request, #23705:
URL: https://github.com/apache/doris/pull/23705

   ## Proposed changes
   
   according to https://github.com/apache/doris/pull/15509, add a default list 
partition don't need the keyword `DEFULT`
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] bobhan1 commented on pull request #23705: [Docs](alter partition) Fix the docs of adding default partition

2023-08-31 Thread via GitHub


bobhan1 commented on PR #23705:
URL: https://github.com/apache/doris/pull/23705#issuecomment-1700567971

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700570888

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on a diff in pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute

2023-08-31 Thread via GitHub


github-actions[bot] commented on code in PR #23631:
URL: https://github.com/apache/doris/pull/23631#discussion_r1311264415


##
be/test/util/date_func_test.cpp:
##
@@ -22,13 +22,29 @@
 
 #include "gtest/gtest_pred_impl.h"
 #include "olap/uint24.h"
+#include "vec/runtime/vdatetime_value.h"
 
 namespace doris {
 
 class DateFuncTest : public testing::Test {
 public:
 DateFuncTest() {}
+

Review Comment:
   warning: use '= default' to define a trivial destructor 
[modernize-use-equals-default]
   
   ```suggestion
   virtual ~DateFuncTest() = default;
   ```
   



##
be/test/util/date_func_test.cpp:
##
@@ -22,13 +22,29 @@
 
 #include "gtest/gtest_pred_impl.h"
 #include "olap/uint24.h"
+#include "vec/runtime/vdatetime_value.h"
 
 namespace doris {
 
 class DateFuncTest : public testing::Test {
 public:
 DateFuncTest() {}
+

Review Comment:
   warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' 
[modernize-use-override]
   
   ```suggestion
   ~DateFuncTest() override {}
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] shuke987 commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-31 Thread via GitHub


shuke987 commented on PR #23590:
URL: https://github.com/apache/doris/pull/23590#issuecomment-1700571809

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-31 Thread via GitHub


JNSimba commented on code in PR #187:
URL: 
https://github.com/apache/doris-flink-connector/pull/187#discussion_r1311267839


##
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java:
##
@@ -109,9 +125,12 @@ public Builder setJdbcUrl(String jdbcUrl) {
 public DorisOptions build() {
 checkNotNull(fenodes, "No fenodes supplied.");
 checkNotNull(tableIdentifier, "No tableIdentifier supplied.");
+if (StringUtils.isNotEmpty(beNodes)) {
+return new DorisOptions(fenodes, beNodes, username, password, 
tableIdentifier, jdbcUrl);
+}
 return new DorisOptions(fenodes, username, password, 
tableIdentifier, jdbcUrl);
+

Review Comment:
   maybe directly `new DorisOptions(fenodes, beNodes, username, password, 
tableIdentifier, jdbcUrl);` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22687: [Feature](inverted index) push count on index down to scan node

2023-08-31 Thread via GitHub


hello-stephen commented on PR #22687:
URL: https://github.com/apache/doris/pull/22687#issuecomment-1700578322

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.53 seconds
stream load tsv:  535 seconds loaded 74807831229 Bytes, about 133 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17161874631 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris-flink-connector] JNSimba commented on pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-31 Thread via GitHub


JNSimba commented on PR #187:
URL: 
https://github.com/apache/doris-flink-connector/pull/187#issuecomment-1700579187

   > By the way, add the options of flink table, thanks
   
   and also add options in databasesync , thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23590:
URL: https://github.com/apache/doris/pull/23590#issuecomment-1700583594

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zhannngchen merged pull request #23661: [fix](regression) try fix regression test no_await

2023-08-31 Thread via GitHub


zhannngchen merged PR #23661:
URL: https://github.com/apache/doris/pull/23661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] ixzc commented on issue #23013: [Bug] DEFAULT CURRENT_TIMESTAMP(3)有问题

2023-08-31 Thread via GitHub


ixzc commented on issue #23013:
URL: https://github.com/apache/doris/issues/23013#issuecomment-1700583035

   You can solve this problem by creating a table with the DateTimeV2 data type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23661: [fix](regression) try fix regression test no_await

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23661:
URL: https://github.com/apache/doris/pull/23661#issuecomment-1700584554

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated (cb2515b7c8 -> f214485733)

2023-08-31 Thread zhangchen
This is an automated email from the ASF dual-hosted git repository.

zhangchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from cb2515b7c8 [Fix](meta lock) Should not acquire wlock twice (#23666)
 add f214485733 [fix](regression) try fix regression test no_await (#23661)

No new revisions were added by this update.

Summary of changes:
 regression-test/suites/mv_p0/no_await/no_await.groovy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23702: [Feature](config) allow update multiple be configs in one request

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23702:
URL: https://github.com/apache/doris/pull/23702#issuecomment-1700586268

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.29 seconds
stream load tsv:  548 seconds loaded 74807831229 Bytes, about 130 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.8 seconds inserted 1000 Rows, about 
347K ops/s
storage size: 17162014499 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700589201

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yujun777 opened a new pull request, #23706: [feature](replica version) Add admin set replica version statement

2023-08-31 Thread via GitHub


yujun777 opened a new pull request, #23706:
URL: https://github.com/apache/doris/pull/23706

   ## Proposed changes
   
   Sometimes the replica's failed version was set > 0 by mistakes. It may cause 
the tablet couldn't read or write again.
   So we provide a sql comamnd to modify the replica's version、last success 
version and last failed version.
   Example usage:
   
   `admin set replica version properties ( "tablet_id" = "123", "backend_id" = 
"456",  "last_failed_version=-1")`
   
   `admin set replica version properties ( "tablet_id" = "123", "backend_id" = 
"456",  "version="60", "last_failed_version=100")`
   
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yujun777 commented on pull request #23706: [feature](replica version) Add admin set replica version statement

2023-08-31 Thread via GitHub


yujun777 commented on PR #23706:
URL: https://github.com/apache/doris/pull/23706#issuecomment-1700590232

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23391: [Feature](multi-catalog) Support sql cache for hms catalog

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23391:
URL: https://github.com/apache/doris/pull/23391#issuecomment-1700596156

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.8 seconds
stream load tsv:  538 seconds loaded 74807831229 Bytes, about 132 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.3 seconds inserted 1000 Rows, about 
341K ops/s
storage size: 17161932448 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23539: [FE](fucntion) add date_floor/ceil in FE function

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23539:
URL: https://github.com/apache/doris/pull/23539#issuecomment-1700598277

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.89 seconds
stream load tsv:  540 seconds loaded 74807831229 Bytes, about 132 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17161892621 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700598910

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] ByteYue commented on pull request #23665: [enhance](policy) Support to change table's storage policy if the two policy has same resource

2023-08-31 Thread via GitHub


ByteYue commented on PR #23665:
URL: https://github.com/apache/doris/pull/23665#issuecomment-1700610520

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Jibing-Li commented on pull request #23574: [Fix](statistics)Fix external table auto analyze bugs.

2023-08-31 Thread via GitHub


Jibing-Li commented on PR #23574:
URL: https://github.com/apache/doris/pull/23574#issuecomment-1700611581

   > Need test case
   
   Added test case for recursive load schema. Cases for auto analyze will be 
added in later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700614225

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23700: [fix](nereids)NormalizeAggregate may push redundant expr to child project node

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23700:
URL: https://github.com/apache/doris/pull/23700#issuecomment-1700616732

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.01 seconds
stream load tsv:  536 seconds loaded 74807831229 Bytes, about 133 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.1 seconds inserted 1000 Rows, about 
343K ops/s
storage size: 17162052221 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Jibing-Li commented on pull request #23703: [Improvement](statistics)Show column stats even when error accured.

2023-08-31 Thread via GitHub


Jibing-Li commented on PR #23703:
URL: https://github.com/apache/doris/pull/23703#issuecomment-1700623634

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #19312: [feature](nereids)prune runtime filter by ndv

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #19312:
URL: https://github.com/apache/doris/pull/19312#issuecomment-1700627543

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] BePPPower commented on pull request #23635: [fix](Export) Concatenation the outfile sql for Export

2023-08-31 Thread via GitHub


BePPPower commented on PR #23635:
URL: https://github.com/apache/doris/pull/23635#issuecomment-1700629487

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23706: [feature](replica version) Add admin set replica version statement

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23706:
URL: https://github.com/apache/doris/pull/23706#issuecomment-1700636280

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.74 seconds
stream load tsv:  538 seconds loaded 74807831229 Bytes, about 132 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17162066581 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] LiBinfeng-01 commented on a diff in pull request #23613: [Fix](Planner) fix create table as select failed

2023-08-31 Thread via GitHub


LiBinfeng-01 commented on code in PR #23613:
URL: https://github.com/apache/doris/pull/23613#discussion_r1311316205


##
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
 queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
 .setIsAllowNull(outputs.get(i).isNullable());
 }
+if (Config.disable_datev1 && 
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {

Review Comment:
   done



##
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java:
##
@@ -82,6 +84,10 @@ public void analyze(Analyzer analyzer) throws UserException {
 queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
 .setIsAllowNull(outputs.get(i).isNullable());
 }
+if (Config.disable_datev1 && 
queryStmt.getResultExprs().get(i).getType() == Type.DATE) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] LiBinfeng-01 commented on pull request #23613: [Fix](Planner) fix create table as select failed

2023-08-31 Thread via GitHub


LiBinfeng-01 commented on PR #23613:
URL: https://github.com/apache/doris/pull/23613#issuecomment-1700636493

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Jibing-Li commented on pull request #23574: [Fix](statistics)Fix external table auto analyze bugs.

2023-08-31 Thread via GitHub


Jibing-Li commented on PR #23574:
URL: https://github.com/apache/doris/pull/23574#issuecomment-1700637477

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman commented on a diff in pull request #23665: [enhance](policy) Support to change table's storage policy if the two policy has same resource

2023-08-31 Thread via GitHub


morningman commented on code in PR #23665:
URL: https://github.com/apache/doris/pull/23665#discussion_r1311322251


##
fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java:
##
@@ -189,7 +189,13 @@ private boolean processAlterOlapTable(AlterTableStmt stmt, 
OlapTable olapTable,
 boolean needProcessOutsideTableLock = false;
 if (currentAlterOps.checkTableStoragePolicy(alterClauses)) {
 String tableStoragePolicy = olapTable.getStoragePolicy();
-if (!tableStoragePolicy.isEmpty()) {
+String currentStoragePolicy = 
currentAlterOps.getTableStoragePolicy(alterClauses);
+
+// If the two policy has one same resource, then it's safe for the 
table to change policy
+// There would only be the cooldown ttl or cooldown time would be 
affected
+if (!Env.getCurrentEnv().getPolicyMgr()
+.checkStoragePolicyIfSameResource(tableStoragePolicy, 
currentStoragePolicy)
+&& !tableStoragePolicy.isEmpty()) {
 for (Partition partition : olapTable.getAllPartitions()) {

Review Comment:
   should use partitions's visible version to check if this table has data or 
not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700645029

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700648517

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] jyf111 commented on issue #23688: [Bug] The use of process substitution (<(...)) in the newly added code within env.sh causes sh build.sh to fail

2023-08-31 Thread via GitHub


jyf111 commented on issue #23688:
URL: https://github.com/apache/doris/issues/23688#issuecomment-1700649359

   Yes, but the docs state `sh build.sh`, and I think we should keep `sh 
build.sh` run successfully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] adonis0147 commented on issue #23688: [Bug] The use of process substitution (<(...)) in the newly added code within env.sh causes sh build.sh to fail

2023-08-31 Thread via GitHub


adonis0147 commented on issue #23688:
URL: https://github.com/apache/doris/issues/23688#issuecomment-1700653054

   > Yes, but the docs state `sh build.sh`, and I think we should keep `sh 
build.sh` run successfully.
   
   I think we should correct the typos in the documents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow opened a new pull request, #23708: [opt](fe-ui) support read hardware info from aarch64 MacOS

2023-08-31 Thread via GitHub


morrySnow opened a new pull request, #23708:
URL: https://github.com/apache/doris/pull/23708

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   update the version of oshi and jna to support read hardware info from 
aarch64 MacOS
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on pull request #23708: [opt](fe-ui) support read hardware info from aarch64 MacOS

2023-08-31 Thread via GitHub


morrySnow commented on PR #23708:
URL: https://github.com/apache/doris/pull/23708#issuecomment-1700653936

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700656552

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23708: [opt](fe-ui) support read hardware info from aarch64 MacOS

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23708:
URL: https://github.com/apache/doris/pull/23708#issuecomment-1700660445

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23708: [opt](fe-ui) support read hardware info from aarch64 MacOS

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23708:
URL: https://github.com/apache/doris/pull/23708#issuecomment-1700660516

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700660738

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23665: [enhance](policy) Support to change table's storage policy if the two policy has same resource

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23665:
URL: https://github.com/apache/doris/pull/23665#issuecomment-1700662441

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.46 seconds
stream load tsv:  536 seconds loaded 74807831229 Bytes, about 133 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.5 seconds inserted 1000 Rows, about 
338K ops/s
storage size: 17161988473 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700664722

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] jyf111 commented on issue #23688: [Bug] The use of process substitution (<(...)) in the newly added code within env.sh causes sh build.sh to fail

2023-08-31 Thread via GitHub


jyf111 commented on issue #23688:
URL: https://github.com/apache/doris/issues/23688#issuecomment-1700664893

   OK, but there are many `sh build.sh` in the docs, you fix it, or I submit a 
PR later?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman commented on pull request #23638: [fix](parquet) fix potential heap-use-after-free issue and cache issue

2023-08-31 Thread via GitHub


morningman commented on PR #23638:
URL: https://github.com/apache/doris/pull/23638#issuecomment-1700665320

   run clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23701: [improvement](config) add a specific be config for segment_cache_capacity

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23701:
URL: https://github.com/apache/doris/pull/23701#issuecomment-170077

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.92 seconds
stream load tsv:  534 seconds loaded 74807831229 Bytes, about 133 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.8 seconds inserted 1000 Rows, about 
347K ops/s
storage size: 17162061707 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] BiteTheDDDDt commented on pull request #23580: [Bug](materialized-view) fix mv not match because cast and alias name

2023-08-31 Thread via GitHub


BiteThet commented on PR #23580:
URL: https://github.com/apache/doris/pull/23580#issuecomment-1700667969

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] HHoflittlefish777 commented on pull request #23694: [Improvement](Slice) support mobile constructor and operator for Slice

2023-08-31 Thread via GitHub


HHoflittlefish777 commented on PR #23694:
URL: https://github.com/apache/doris/pull/23694#issuecomment-1700669946

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] adonis0147 commented on issue #23688: [Bug] The use of process substitution (<(...)) in the newly added code within env.sh causes sh build.sh to fail

2023-08-31 Thread via GitHub


adonis0147 commented on issue #23688:
URL: https://github.com/apache/doris/issues/23688#issuecomment-1700669993

   > OK, but there are many `sh build.sh` in the docs, you fix it, or I submit 
a PR later?
   
   I'm looking forward to your PRs. Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23590:
URL: https://github.com/apache/doris/pull/23590#issuecomment-1700670793

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.5 seconds
stream load tsv:  543 seconds loaded 74807831229 Bytes, about 131 
MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17162191280 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23580: [Bug](materialized-view) fix mv not match because cast and alias name

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23580:
URL: https://github.com/apache/doris/pull/23580#issuecomment-1700676354

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



svn commit: r63710 - in /dev/doris/1.2.7-rc03: ./ apache-doris-1.2.7-src.tar.gz apache-doris-1.2.7-src.tar.gz.asc apache-doris-1.2.7-src.tar.gz.sha512

2023-08-31 Thread morningman
Author: morningman
Date: Thu Aug 31 09:23:17 2023
New Revision: 63710

Log:
add doris 1.2.7-rc03 

Added:
dev/doris/1.2.7-rc03/
dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz   (with props)
dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.asc   (with props)
dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.sha512

Added: dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz
==
Binary file - no diff available.

Propchange: dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz
--
svn:mime-type = application/x-gzip

Added: dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.asc
==
Binary file - no diff available.

Propchange: dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.asc
--
svn:mime-type = application/pgp-signature

Added: dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.sha512
==
--- dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.sha512 (added)
+++ dev/doris/1.2.7-rc03/apache-doris-1.2.7-src.tar.gz.sha512 Thu Aug 31 
09:23:17 2023
@@ -0,0 +1 @@
+4f1d6c5f27689daed65839efa33ee4dd0013ec68a839b5b72224f4c8bd540761060e8e761d69774302124221b1dd805a33a176cba48f8d7c2ec908655f4963fb
  apache-doris-1.2.7-src.tar.gz



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700679664

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on pull request #23657: [Fix](Nereids) fix test leading random failed

2023-08-31 Thread via GitHub


morrySnow commented on PR #23657:
URL: https://github.com/apache/doris/pull/23657#issuecomment-1700680378

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #23703: [Improvement](statistics)Show column stats even when error accured.

2023-08-31 Thread via GitHub


hello-stephen commented on PR #23703:
URL: https://github.com/apache/doris/pull/23703#issuecomment-1700683560

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.14 seconds
stream load tsv:  537 seconds loaded 74807831229 Bytes, about 132 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17162062465 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23701: [improvement](config) add a specific be config for segment_cache_capacity

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23701:
URL: https://github.com/apache/doris/pull/23701#issuecomment-1700683569

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700688232

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #23631: [refactor](type system) remove special logic for datev2 and datetimev2 since they are same type in storage and compute layer

2023-08-31 Thread via GitHub


github-actions[bot] commented on PR #23631:
URL: https://github.com/apache/doris/pull/23631#issuecomment-1700692353

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   6   >