github-actions[bot] commented on code in PR #23631:
URL: https://github.com/apache/doris/pull/23631#discussion_r1311264415
##########
be/test/util/date_func_test.cpp:
##########
@@ -22,13 +22,29 @@
#include "gtest/gtest_pred_impl.h"
#include "olap/uint24.h"
+#include "vec/runtime/vdatetime_value.h"
namespace doris {
class DateFuncTest : public testing::Test {
public:
DateFuncTest() {}
+
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~DateFuncTest() = default;
```
##########
be/test/util/date_func_test.cpp:
##########
@@ -22,13 +22,29 @@
#include "gtest/gtest_pred_impl.h"
#include "olap/uint24.h"
+#include "vec/runtime/vdatetime_value.h"
namespace doris {
class DateFuncTest : public testing::Test {
public:
DateFuncTest() {}
+
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~DateFuncTest() override {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
