morningman commented on code in PR #23665:
URL: https://github.com/apache/doris/pull/23665#discussion_r1311322251
##########
fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java:
##########
@@ -189,7 +189,13 @@ private boolean processAlterOlapTable(AlterTableStmt stmt,
OlapTable olapTable,
boolean needProcessOutsideTableLock = false;
if (currentAlterOps.checkTableStoragePolicy(alterClauses)) {
String tableStoragePolicy = olapTable.getStoragePolicy();
- if (!tableStoragePolicy.isEmpty()) {
+ String currentStoragePolicy =
currentAlterOps.getTableStoragePolicy(alterClauses);
+
+ // If the two policy has one same resource, then it's safe for the
table to change policy
+ // There would only be the cooldown ttl or cooldown time would be
affected
+ if (!Env.getCurrentEnv().getPolicyMgr()
+ .checkStoragePolicyIfSameResource(tableStoragePolicy,
currentStoragePolicy)
+ && !tableStoragePolicy.isEmpty()) {
for (Partition partition : olapTable.getAllPartitions()) {
Review Comment:
should use partitions's visible version to check if this table has data or
not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
