[GitHub] [doris] 924060929 commented on pull request #17913: [fix](nereids)add a project node above sort node to eliminate unused order by keys
924060929 commented on PR #17913: URL: https://github.com/apache/doris/pull/17913#issuecomment-1475717300 the column pruning problem will complete fix by #17579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17956: [regression-test](merge-on-write) Optimize merge-on-write case execution time
github-actions[bot] commented on PR #17956: URL: https://github.com/apache/doris/pull/17956#issuecomment-1475727586 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17956: [regression-test](merge-on-write) Optimize merge-on-write case execution time
github-actions[bot] commented on PR #17956: URL: https://github.com/apache/doris/pull/17956#issuecomment-1475727642 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #17953: [Bug][Fix] regexp function core dump DCHECK failed and error result
HappenLee commented on PR #17953: URL: https://github.com/apache/doris/pull/17953#issuecomment-1475739670 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #17953: [Bug][Fix] regexp function core dump DCHECK failed and error result
HappenLee commented on PR #17953: URL: https://github.com/apache/doris/pull/17953#issuecomment-1475739707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #17953: [Bug][Fix] regexp function core dump DCHECK failed and error result
HappenLee commented on code in PR #17953:
URL: https://github.com/apache/doris/pull/17953#discussion_r1141712701
##
be/src/vec/functions/like.cpp:
##
@@ -372,10 +372,12 @@ Status FunctionLikeBase::execute_impl(FunctionContext*
context, Block& block,
const auto pattern_col = block.get_by_position(arguments[1]).column;
if (const auto* str_patterns =
check_and_get_column(pattern_col.get())) {
-DCHECK_EQ(str_patterns->size(), 1);
-const auto& pattern_val = str_patterns->get_data_at(0);
-RETURN_IF_ERROR(vector_const(*values, &pattern_val, vec_res,
state->function,
- &state->search_state));
+for (int i = 0; i < input_rows_count; i++) {
Review Comment:
I test mysql. mysql support the query non-const way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17953: [Bug][Fix] regexp function core dump DCHECK failed and error result
github-actions[bot] commented on PR #17953: URL: https://github.com/apache/doris/pull/17953#issuecomment-1475741895 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li opened a new pull request, #17958: [Improvement](TVF)Support file split for TableValueFunction.
Jibing-Li opened a new pull request, #17958: URL: https://github.com/apache/doris/pull/17958 Current getSplits for TVF is to create one split for each file. In this case, large file scan performance maybe bad. This pr is to implement the getSplits function in TVFSplitter to support split file to multiple blocks which may improve the performance for large files. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17927: [doc](auth)ranger doc
zddr commented on PR #17927: URL: https://github.com/apache/doris/pull/17927#issuecomment-1475743694 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liutang123 opened a new pull request, #17959: [fix](meta)Fix FE try to repair a tablet witch can not be repaired.
liutang123 opened a new pull request, #17959: URL: https://github.com/apache/doris/pull/17959 # Proposed changes Issue Number: close #xxx ## Problem summary To repair a tablet requires at least one `aliveAndVersionComplete` replica. If a tabelt has 3 replicas like follows: 1. BE is down 2. version miss 3. version miss FE will try to repair it. But, its status should be `UNRECOVERABLE`. ## Checklist(Required) * [x] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17958: [Improvement](TVF)Support file split for TableValueFunction.
github-actions[bot] commented on PR #17958: URL: https://github.com/apache/doris/pull/17958#issuecomment-1475745456 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liutang123 commented on pull request #17959: [fix](meta)Fix FE try to repair a tablet witch can not be repaired.
liutang123 commented on PR #17959: URL: https://github.com/apache/doris/pull/17959#issuecomment-1475745687 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17894: [fe](test)Add MicroBench module to make it easier for developers to write JMH Test
github-actions[bot] commented on PR #17894: URL: https://github.com/apache/doris/pull/17894#issuecomment-1475748450 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17894: [fe](test)Add MicroBench module to make it easier for developers to write JMH Test
github-actions[bot] commented on PR #17894: URL: https://github.com/apache/doris/pull/17894#issuecomment-1475748484 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17894: [fe](test)Add MicroBench module to make it easier for developers to write JMH Test
github-actions[bot] commented on PR #17894: URL: https://github.com/apache/doris/pull/17894#issuecomment-1475753125 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JackDrogon commented on a diff in pull request #16746: [docs](doc) Add autobucket doc
JackDrogon commented on code in PR #16746:
URL: https://github.com/apache/doris/pull/16746#discussion_r1141729518
##
docs/zh-CN/docs/advanced/autobucket.md:
##
@@ -0,0 +1,169 @@
+---
+{
+"title": "自动分桶",
+"language": "zh-CN"
+}
+---
+
+
+
+# 背景
+
+用户经常设置不合适的bucket，导致各种问题，这里提供一种方式，来自动设置分桶数。暂时而言只对olap表生效
Review Comment:
是指代类型是OLAP的表
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-thirdparty] adonis0147 opened a new pull request, #42: Remove deprecated templates
adonis0147 opened a new pull request, #42: URL: https://github.com/apache/doris-thirdparty/pull/42 `std::binary_function` was marked deprecated in C++ 11 and we should remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #17919: [feature](function)Add ST_Angle_Sphere function
LemonLiTree commented on PR #17919: URL: https://github.com/apache/doris/pull/17919#issuecomment-1475759344 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17542: [feature-wip](partial update) support MOW partial update in stream load
github-actions[bot] commented on code in PR #17542:
URL: https://github.com/apache/doris/pull/17542#discussion_r1141732677
##
be/src/olap/rowset/beta_rowset_writer.h:
##
@@ -133,11 +133,14 @@ class BetaRowsetWriter : public RowsetWriter {
const RowsetMetaSharedPtr&
spec_rowset_meta);
bool _is_segment_overlapping(const std::vector&
segments_encoded_key_bounds);
+void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
Review Comment:
warning: 'set_segment_start_id' overrides a member function but is not
marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
^
```
**be/src/olap/rowset/rowset_writer.h:90:** overridden virtual function is
here
```cpp
virtual void set_segment_start_id(int num_segment) { LOG(FATAL) << "not
supported!"; }
^
```
##
be/src/olap/rowset/beta_rowset_writer.h:
##
@@ -133,11 +133,14 @@
const RowsetMetaSharedPtr&
spec_rowset_meta);
bool _is_segment_overlapping(const std::vector&
segments_encoded_key_bounds);
+void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
void set_segment_start_id(int32_t start_id) override { _segment_start_id
= start_id; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17919: [feature](function)Add ST_Angle_Sphere function
github-actions[bot] commented on PR #17919: URL: https://github.com/apache/doris/pull/17919#issuecomment-1475762152 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower commented on pull request #17667: [feature](table-valued-function) add Backends table-valued-function
BePPPower commented on PR #17667: URL: https://github.com/apache/doris/pull/17667#issuecomment-1475765629 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #17931: [vectorized](function) support array_exists lambda function
ZhangYu0123 commented on PR #17931: URL: https://github.com/apache/doris/pull/17931#issuecomment-1475768318 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on pull request #17889: [fix](cooldown)Add ut for StoragePolicy
pengxiangyu commented on PR #17889: URL: https://github.com/apache/doris/pull/17889#issuecomment-1475779535 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #17958: [Improvement](TVF)Support file split for TableValueFunction.
Jibing-Li commented on PR #17958: URL: https://github.com/apache/doris/pull/17958#issuecomment-1475790106 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: 1.2.3 blog
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/master by this push:
new d6c04a83679 1.2.3 blog
d6c04a83679 is described below
commit d6c04a836795916a7bda7d3e0361f574ba8de6ff
Author: jiafeng.zhang
AuthorDate: Mon Mar 20 16:12:29 2023 +0800
1.2.3 blog
---
blog/release-1.2.3.md | 128 +++
.../release-1.2.3.md | 173 +
2 files changed, 301 insertions(+)
diff --git a/blog/release-1.2.3.md b/blog/release-1.2.3.md
new file mode 100644
index 000..d84e6220459
--- /dev/null
+++ b/blog/release-1.2.3.md
@@ -0,0 +1,128 @@
+---
+{
+'title': 'Apache Doris announced the official release of version 1.2.3',
+'summary': 'Dear community, we are excited to announce the release of
Apache Doris 1.2.3 on March 30, 2023. We have made over 200 enhancements and
bug fixes in this new version. Upgrade now and enjoy higher stability and ease
of use!',
+'date': '2023-03-20',
+'author': 'Apache Doris',
+'tags': ['Release Notes'],
+}
+---
+
+
+
+## Improvement
+
+- JDBC Catalog
+ - Support connecting to Doris clusters through JDBC Catalog.
+-
https://doris.apache.org/zh-CN/docs/dev/lakehouse/multi-catalog/jdbc#doris
+ - Support to synchronize only the specified database through the
`only_specified_database` attribute.
+ - Support synchronizing table names in the form of lowercase through
`lower_case_table_names` to solve the problem of case sensitivity of table
names.
+- https://doris.apache.org/zh-CN/docs/dev/lakehouse/multi-catalog/jdbc
+ - Optimize the read performance of JDBC Catalog.
+- Elasticsearch Catalog
+ - Support Array type mapping.
+ - Support whether to push down the `like` expression through the
`like_push_down` attribute to control the CPU overhead of the ES cluster.
+- https://doris.apache.org/zh-CN/docs/dev/lakehouse/multi-catalog/es
+- Hive Catalog
+ - Support Hive table default partition `__HIVE_DEFAULT_PARTITION__`.
+ - Hive Metastore metadata automatic synchronization supports notification
event in compressed format.
+- Dynamic partition supports specifying the `storage_medium` parameter to
control the storage medium of the newly added partition.
+ -
https://doris.apache.org/zh-CN/docs/dev/advanced/partition/dynamic-partition
+- Optimize BE's threading model to avoid stability problems caused by frequent
thread creation and destroy.
+
+## Bug Fixes
+
+- Fixed issues with Merge-On-Write Unique Key tables.
+- Fixed compaction related issues.
+- Fixed some delete statement issues causing data errors.
+- Fixed several query execution errors.
+- Fixed the problem of using JDBC catalog to cause BE crash on some operating
system.
+- Fixed Multi-Catalog issues.
+- Fixed memory statistics and optimization issues.
+- Fixed decimalV3 and date/datetimev2 related issues.
+- Fixed load transaction stability issues.
+- Fixed light-weight schema change issues.
+- Fixed the issue of using `datetime` type for batch partition creation.
+- Fixed the problem that a large number of failed broker loads would cause the
FE memory usage to be too high.
+- Fixed the problem that stream load cannot be canceled after dropping the
table.
+- Fixed querying `information_schema` timeout in some cases.
+- Fixed the problem of BE crash caused by concurrent data export using `select
outfile`.
+- Fixed transactional insert operation memory leak.
+- Fixed several query/load profile issues, and supports direct download of
profiles through FE web ui.
+- Fixed the problem that the BE tablet GC thread caused the IO util to be too
high.
+- Fixed the problem that the commit offset is inaccurate in Kafka routine load.
+
+## Big Thanks
+
+Thanks all who contribute to this release:
+
+[@zy-kkk](https://github.com/zy-kkk)
+[@zhannngchen](https://github.com/zhannngchen)
+[@ZhangYu0123](https://github.com/ZhangYu0123)
+[@zhangstar333](https://github.com/zhangstar333)
+[@zclllyybb](https://github.com/zclllyybb)
+[@yuxuan-luo](https://github.com/yuxuan-luo)
+[@yixiutt](https://github.com/yixiutt)
+[@yiguolei](https://github.com/yiguolei)
+[@yangzhg](https://github.com/yangzhg)
+[@xinyiZzz](https://github.com/xinyiZzz)
+[@XieJiann](https://github.com/XieJiann)
+[@xiaokang](https://github.com/xiaokang)
+[@WuWQ98](https://github.com/WuWQ98)
+[@WinkerDu](https://github.com/WinkerDu)
+[@wangbo](https://github.com/wangbo)
+[@TangSiyang2001](https://github.com/TangSiyang2001)
+[@SWJTU-ZhangLei](https://github.com/SWJTU-ZhangLei)
+[@starocean999](https://github.com/starocean999)
+[@stalary](https://github.com/stalary)
+[@sohardforaname](https://github.com/sohardforaname)
+[@SaintBacchus](https://github.com/SaintBacchus)
+[@qzsee](https://github.com/qzsee)
+[@qidaye](https://github.com/qidaye)
+[@platoneko](https://github.c
[GitHub] [doris] AshinGau opened a new pull request, #17960: [feature](jni) jni table scanner framework
AshinGau opened a new pull request, #17960: URL: https://github.com/apache/doris/pull/17960 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17945: [chore](macOS) Specify the version of LLVM for Homebrew to install it
adonis0147 commented on PR #17945: URL: https://github.com/apache/doris/pull/17945#issuecomment-1475795728 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #17949: [fix](test) print real and expect rows when fail in exception
dataroaring commented on PR #17949: URL: https://github.com/apache/doris/pull/17949#issuecomment-1475797801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17960: [feature](jni) jni table scanner framework
github-actions[bot] commented on code in PR #17960: URL: https://github.com/apache/doris/pull/17960#discussion_r1141761329 ## be/src/vec/exec/jni_connector.h: ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include Review Comment: warning: 'jni.h' file not found [clang-diagnostic-error] ```cpp #include ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17952: [fix](regression)fix glue regression
github-actions[bot] commented on PR #17952: URL: https://github.com/apache/doris/pull/17952#issuecomment-1475799132 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17952: [fix](regression)fix glue regression
github-actions[bot] commented on PR #17952: URL: https://github.com/apache/doris/pull/17952#issuecomment-1475799190 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17945: [chore](macOS) Specify the version of LLVM for Homebrew to install it
adonis0147 commented on PR #17945: URL: https://github.com/apache/doris/pull/17945#issuecomment-1475804239 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17901: [Bug](float) fix wrong value when enable fold constant by BE
github-actions[bot] commented on PR #17901: URL: https://github.com/apache/doris/pull/17901#issuecomment-1475805131 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17670: [refactor](date) unify DateTimeValue and VecDateTimeValue
yiguolei merged PR #17670: URL: https://github.com/apache/doris/pull/17670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17951: [improve](Nereids): check slot from children in validator.
jackwener commented on PR #17951: URL: https://github.com/apache/doris/pull/17951#issuecomment-1475820987 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17953: [Bug][Fix] regexp function core dump DCHECK failed and error result
hello-stephen commented on PR #17953: URL: https://github.com/apache/doris/pull/17953#issuecomment-1475823401 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.77 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320084132_clickbench_pr_117244.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow opened a new pull request, #17961: [fix](Nereids) should turn off parallel scan when do local finalize agg
morrySnow opened a new pull request, #17961: URL: https://github.com/apache/doris/pull/17961 # Proposed changes Issue Number: close #xxx ## Problem summary 1. when we assume data distributed by distributed keys and do local one stage agg, we should turn off parallel scan. 2. fix unstable case in testAggQueryOnAggMV2 ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17961: [fix](Nereids) should turn off parallel scan when do local finalize agg
morrySnow commented on PR #17961: URL: https://github.com/apache/doris/pull/17961#issuecomment-1475847537 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17944: [fix](agg) Avoid reusing a non-nullable column that has been converted to nullable within a block
hello-stephen commented on PR #17944: URL: https://github.com/apache/doris/pull/17944#issuecomment-1475854606 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.94 seconds stream load tsv: 465 seconds loaded 74807831229 Bytes, about 153 MB/s stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320090350_clickbench_pr_117255.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuanyuan8983 commented on issue #17950: [Bug] Failed to deserialize parquet page header
yuanyuan8983 commented on issue #17950: URL: https://github.com/apache/doris/issues/17950#issuecomment-1475855387 Doris 1.2.3 has been released today. You can try it with Doris 1.2.3, which fixes the problem of reading parquet files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] levy5307 commented on pull request #17909: [fix](fragment mgr) fix the bug that g_fragmentmgr_prepare_latency update uncorrectly
levy5307 commented on PR #17909: URL: https://github.com/apache/doris/pull/17909#issuecomment-1475861628 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #17904: [Fix](plan) fix bug that the case sensibility of column name may impact join method
GoGoWen commented on PR #17904: URL: https://github.com/apache/doris/pull/17904#issuecomment-1475875576 > Could you please add a regression test case for this? added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen opened a new pull request, #17962: [enhancement](load) add slow log for memtable flush
zhannngchen opened a new pull request, #17962: URL: https://github.com/apache/doris/pull/17962 # Proposed changes Issue Number: close #xxx ## Problem summary Some slow load is caused by close wait for too long time, we can print log if close wait too slow. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17962: [enhancement](load) add slow log for memtable flush
github-actions[bot] commented on PR #17962: URL: https://github.com/apache/doris/pull/17962#issuecomment-1475884953 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
HappenLee opened a new pull request, #17963: URL: https://github.com/apache/doris/pull/17963 # Proposed changes fix regression test failed in fuzzy mode:collect_set ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
HappenLee commented on PR #17963: URL: https://github.com/apache/doris/pull/17963#issuecomment-1475891854 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
HappenLee commented on PR #17963: URL: https://github.com/apache/doris/pull/17963#issuecomment-1475891894 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17955: [Bug](float) wrong result when compare two float type
hello-stephen commented on PR #17955: URL: https://github.com/apache/doris/pull/17955#issuecomment-1475892277 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.85 seconds stream load tsv: 466 seconds loaded 74807831229 Bytes, about 153 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320093029_clickbench_pr_117275.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
github-actions[bot] commented on PR #17963: URL: https://github.com/apache/doris/pull/17963#issuecomment-1475896202 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #17912: [Bug](planner) fix core dump when lateral view above union node and have predicate
BiteThet commented on PR #17912: URL: https://github.com/apache/doris/pull/17912#issuecomment-1475896800 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on pull request #17889: [fix](cooldown)Add ut for StoragePolicy
pengxiangyu commented on PR #17889: URL: https://github.com/apache/doris/pull/17889#issuecomment-1475899177 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17961: [fix](Nereids) should turn off parallel scan when do local finalize agg
hello-stephen commented on PR #17961: URL: https://github.com/apache/doris/pull/17961#issuecomment-1475922737 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.64 seconds stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320095402_clickbench_pr_117387.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #17893: [bug](txn) fix concurrent txns's status data race
morningman merged PR #17893: URL: https://github.com/apache/doris/pull/17893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (bd8e3e6405 -> b4634342aa)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from bd8e3e6405 [refactor](date) unify DateTimeValue and VecDateTimeValue (#17670) add b4634342aa [bug](txn) fix concurrent txns's status data race when aborting txn (#17893) No new revisions were added by this update. Summary of changes: be/src/agent/task_worker_pool.cpp | 2 ++ .../apache/doris/service/FrontendServiceImpl.java | 10 +-- .../doris/transaction/GlobalTransactionMgr.java| 34 ++ 3 files changed, 39 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lexluo09 opened a new pull request, #17964: [enhancement](UDF) The user defined functions support global ('show functions'/'show create') operation
lexluo09 opened a new pull request, #17964:
URL: https://github.com/apache/doris/pull/17964
# Proposed changes
The global udf support ('show functions'/'show create') operation, to show
the details of the global udf.
## Problem summary
Solution
1、 add the global keyword.
SHOW [GLOBAL] [FULL] [BUILTIN] FUNCTIONS [IN|FROM db] [LIKE
'function_pattern']
SHOW CREATE GLOBAL FUNCTION function_name(arg_type [, ...]) [FROM db_name]];
2、show the details of the global udf.
## Checklist(Required)
* [x] Does it affect the original behavior
* [√ ] Has unit tests been added
* [√] Has document been added or modified
* [x ] Does it need to update dependencies
* [√] Is this PR support rollback (If NO, please explain WHY)
## Further comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17874: [improvement](compaction)Support segcompaction for inverted index
hello-stephen commented on PR #17874: URL: https://github.com/apache/doris/pull/17874#issuecomment-1475945566 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.1 seconds stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320100759_clickbench_pr_117264.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #17931: [vectorized](function) support array_exists lambda function
ZhangYu0123 commented on PR #17931: URL: https://github.com/apache/doris/pull/17931#issuecomment-1475961275 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17957: [Fix](SAP Hana External Table) fix that SAP Hana external table can not insert batch values
hello-stephen commented on PR #17957: URL: https://github.com/apache/doris/pull/17957#issuecomment-1475980129 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.38 seconds stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320103100_clickbench_pr_117286.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17850: [Bug](materialized-view) fix select mv rollback fail on left join
github-actions[bot] commented on PR #17850: URL: https://github.com/apache/doris/pull/17850#issuecomment-1475992928 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17850: [Bug](materialized-view) fix select mv rollback fail on left join
github-actions[bot] commented on PR #17850: URL: https://github.com/apache/doris/pull/17850#issuecomment-1475993001 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #17919: [feature](function)Add ST_Angle_Sphere function
LemonLiTree commented on PR #17919: URL: https://github.com/apache/doris/pull/17919#issuecomment-1476001921 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hust-hhb opened a new pull request, #17965: [feature](log)check and log acquire/held lock time when it exceeds threshold
hust-hhb opened a new pull request, #17965: URL: https://github.com/apache/doris/pull/17965 Sometimes the competition of lock is fierce in DatabaseTransactionMgr, which may lead to publish time out, i think we should have a log to hint these lock competition. # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17919: [feature](function)Add ST_Angle_Sphere function
github-actions[bot] commented on PR #17919: URL: https://github.com/apache/doris/pull/17919#issuecomment-1476005942 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17959: [fix](meta)Fix FE try to repair a tablet witch can not be repaired.
hello-stephen commented on PR #17959: URL: https://github.com/apache/doris/pull/17959#issuecomment-1476009807 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.58 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320105408_clickbench_pr_117323.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17945: [chore](macOS) Specify the version of LLVM for Homebrew to install it
adonis0147 commented on PR #17945: URL: https://github.com/apache/doris/pull/17945#issuecomment-1476015152 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17871: [CI](docs)Use markdown-link-check check dead link
github-actions[bot] commented on PR #17871:
URL: https://github.com/apache/doris/pull/17871#issuecomment-1476032386
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4467500926";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ci/deadlink-check.sh line 20:
for file in $(find . -name "*.md"); do
^^ SC2044 (warning): For loops over find
output are fragile. Use find -exec or a while read loop.
In tools/ci/deadlink-check.sh line 21:
if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
if [[ ${file} == *"/test/resources"* ]] || [[ ${file} == *"/target"* ]];
In tools/ci/deadlink-check.sh line 23:
echo " skip $file"
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo " skip ${file}"
In tools/ci/deadlink-check.sh line 25:
markdown-link-check -c /tools/ci/.dlc.json -q "$file"
^---^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
markdown-link-check -c /tools/ci/.dlc.json -q "${file}"
For more information:
https://www.shellcheck.net/wiki/SC2044 -- For loops over find output are
fr...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- tools/ci/deadlink-check.sh.orig
+++ tools/ci/deadlink-check.sh
@@ -18,10 +18,9 @@
# print usage
for file in $(find . -name "*.md"); do
- if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
-then
- echo " skip $file"
-else
- markdown-link-check -c /tools/ci/.dlc.json -q "$file"
-fi
+if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
then
+echo " skip $file"
+else
+markdown-link-check -c /tools/ci/.dlc.json -q "$file"
+fi
done
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] levy5307 commented on pull request #17909: [fix](fragment mgr) fix the bug that g_fragmentmgr_prepare_latency update uncorrectly
levy5307 commented on PR #17909: URL: https://github.com/apache/doris/pull/17909#issuecomment-1476039850 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #17850: [Bug](materialized-view) fix select mv rollback fail on left join
BiteThet merged PR #17850: URL: https://github.com/apache/doris/pull/17850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Bug](materialized-view) fix select mv rollback fail on left join (#17850)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a92115f709 [Bug](materialized-view) fix select mv rollback fail on
left join (#17850)
a92115f709 is described below
commit a92115f709a12b51b70ccfd795524132e4fb5d68
Author: Pxl
AuthorDate: Mon Mar 20 19:14:17 2023 +0800
[Bug](materialized-view) fix select mv rollback fail on left join (#17850)
fix select mv rollback fail on left join
---
be/src/olap/reader.cpp | 7 +--
be/src/olap/reader.h | 2 +-
be/src/olap/tablet_schema.cpp | 10
be/src/olap/tablet_schema.h| 1 +
be/src/vec/exprs/vslot_ref.cpp | 10 ++--
.../main/java/org/apache/doris/analysis/Expr.java | 13 ++
.../apache/doris/analysis/ExprSubstitutionMap.java | 7 +--
.../java/org/apache/doris/analysis/QueryStmt.java | 6 +--
.../java/org/apache/doris/analysis/SelectStmt.java | 16 +--
.../java/org/apache/doris/analysis/SlotRef.java| 5 ++
.../doris/analysis/TupleIsNullPredicate.java | 5 ++
.../org/apache/doris/rewrite/ExprRewriter.java | 6 ++-
.../doris/rewrite/mvrewrite/ExprToSlotRefRule.java | 24 +++---
.../data/mv_p0/join/rollback1/rollback1.out| 51 +
.../testIncorrectMVRewriteInSubquery.out | 3 +-
.../suites/mv_p0/join/rollback1/rollback1.groovy | 53 ++
.../testIncorrectMVRewriteInSubquery.groovy| 2 +-
17 files changed, 189 insertions(+), 32 deletions(-)
diff --git a/be/src/olap/reader.cpp b/be/src/olap/reader.cpp
index dba7f222ac..0d5dbf9fee 100644
--- a/be/src/olap/reader.cpp
+++ b/be/src/olap/reader.cpp
@@ -242,7 +242,7 @@ Status TabletReader::_init_params(const ReaderParams&
read_params) {
_tablet_schema = read_params.tablet_schema;
_reader_context.runtime_state = read_params.runtime_state;
-_init_conditions_param(read_params);
+RETURN_IF_ERROR(_init_conditions_param(read_params));
_init_conditions_param_except_leafnode_of_andnode(read_params);
Status res = _init_delete_condition(read_params);
@@ -438,12 +438,12 @@ Status TabletReader::_init_orderby_keys_param(const
ReaderParams& read_params) {
return Status::OK();
}
-void TabletReader::_init_conditions_param(const ReaderParams& read_params) {
+Status TabletReader::_init_conditions_param(const ReaderParams& read_params) {
for (auto& condition : read_params.conditions) {
// These conditions is passed from OlapScannode, but not set column
unique id here, so that set it here because it
// is too complicated to modify related interface
TCondition tmp_cond = condition;
-
+RETURN_IF_ERROR(_tablet_schema->have_column(tmp_cond.column_name));
auto condition_col_uid =
_tablet_schema->column(tmp_cond.column_name).unique_id();
tmp_cond.__set_column_unique_id(condition_col_uid);
ColumnPredicate* predicate =
@@ -513,6 +513,7 @@ void TabletReader::_init_conditions_param(const
ReaderParams& read_params) {
}
}
}
+return Status::OK();
}
void TabletReader::_init_conditions_param_except_leafnode_of_andnode(
diff --git a/be/src/olap/reader.h b/be/src/olap/reader.h
index 813369fca9..d286bf42a6 100644
--- a/be/src/olap/reader.h
+++ b/be/src/olap/reader.h
@@ -201,7 +201,7 @@ protected:
Status _init_orderby_keys_param(const ReaderParams& read_params);
-void _init_conditions_param(const ReaderParams& read_params);
+Status _init_conditions_param(const ReaderParams& read_params);
void _init_conditions_param_except_leafnode_of_andnode(const ReaderParams&
read_params);
diff --git a/be/src/olap/tablet_schema.cpp b/be/src/olap/tablet_schema.cpp
index dcfac6ef7e..b08bc10f99 100644
--- a/be/src/olap/tablet_schema.cpp
+++ b/be/src/olap/tablet_schema.cpp
@@ -19,6 +19,7 @@
#include
+#include "common/status.h"
#include "exec/tablet_info.h"
#include "gen_cpp/descriptors.pb.h"
#include "olap/utils.h"
@@ -849,6 +850,15 @@ void TabletSchema::update_indexes_from_thrift(const
std::vector(
+"Not found field_name, field_name:{}, schema:{}", field_name,
+get_all_field_names());
+}
+return Status::OK();
+}
+
const TabletColumn& TabletSchema::column(const std::string& field_name) const {
DCHECK(_field_name_to_index.count(field_name) != 0)
<< ", field_name=" << field_name << ", field_name_to_index=" <<
get_all_field_names();
diff --git a/be/src/olap/tablet_schema.h b/be/src/olap/tablet_schema.h
index c298cc1e36..08654a4f09 100644
--- a/be/src/olap/tablet_schema.h
+++ b/be/src/olap/tablet_schema.h
@@ -186,6 +186,7 @@ public:
int32_t field_index(int32_t col_unique_id) const;
const TabletCol
[GitHub] [doris] freemandealer commented on pull request #17874: [improvement](compaction)Support segcompaction for inverted index
freemandealer commented on PR #17874: URL: https://github.com/apache/doris/pull/17874#issuecomment-1476043320 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17874: [improvement](compaction)Support segcompaction for inverted index
github-actions[bot] commented on PR #17874: URL: https://github.com/apache/doris/pull/17874#issuecomment-1476044884 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lexluo09 commented on issue #17947: [Feature] Support hive meta cache TTL
lexluo09 commented on issue #17947: URL: https://github.com/apache/doris/issues/17947#issuecomment-1476049747 I'm interested in this feature. Could you assign it to me? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #17965: [feature](log)check and log acquire/held lock time when it exceeds threshold
zhannngchen commented on code in PR #17965:
URL: https://github.com/apache/doris/pull/17965#discussion_r1141971425
##
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##
@@ -2070,5 +2070,11 @@ public class Config extends ConfigBase {
*/
@ConfField
public static String bdbje_file_logging_level = "ALL";
+
+/**
+ * When the acquire/held lock time exceeds the threshold, need to report
it.
+ */
+@ConfField
+public static long lock_reporting_threshold_ms = 500l;
Review Comment:
It's too large, I think 1000ms is big enough
##
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##
@@ -141,20 +143,30 @@ public class DatabaseTransactionMgr {
// not realtime usedQuota value to make a fast check for database data
quota
private volatile long usedQuotaDataBytes = -1;
+private long lockWriteStart;
+
+private long lockReportingThresholdMs = Config.lock_reporting_threshold_ms;
protected void readLock() {
+long waitReadStart = System.currentTimeMillis();
this.transactionLock.readLock().lock();
+checkAndLogWaitTime(waitReadStart, System.currentTimeMillis());
Review Comment:
It's not necessary to log readlock wait time, long wait time is always
caused by some thread holding writelock too long, and further more, if some
thread hold's writelock for a long time, after it unlocked, there's lots of
threads get the readlock, they all print such log, especially with stacktrace,
which is quite slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17803: [feature](multi-catalog) add specified_database_list PROPERTY for jdbc catalog
nextdreamblue commented on PR #17803: URL: https://github.com/apache/doris/pull/17803#issuecomment-1476051565 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17769: [fix](json) change int to bigint for json function
nextdreamblue commented on PR #17769: URL: https://github.com/apache/doris/pull/17769#issuecomment-1476053017 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] weizhengte opened a new pull request, #17966: [Improvement](statistics) Support for collecting statistics at the granularity of partitions.
weizhengte opened a new pull request, #17966: URL: https://github.com/apache/doris/pull/17966 # Proposed changes Issue Number: close #xxx ## Problem summary Due to a previous refactoring of the statistics code, this PR mainly enables partitioned-granularity collection of column statistics and column histograms. Also simplify some code. In addition, to support the subsequent automatic collection of statistics. Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] weizhengte commented on pull request #17966: [Improvement](statistics) Support for collecting statistics at the granularity of partitions.
weizhengte commented on PR #17966: URL: https://github.com/apache/doris/pull/17966#issuecomment-1476060269 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #17860: [ehancement](fe) Tune for stats framework
Kikyou1997 commented on PR #17860: URL: https://github.com/apache/doris/pull/17860#issuecomment-1476067457 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen commented on pull request #17962: [enhancement](load) add slow log for memtable flush
zhannngchen commented on PR #17962: URL: https://github.com/apache/doris/pull/17962#issuecomment-1476070974 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17542: [feature-wip](partial update) support MOW partial update in stream load
github-actions[bot] commented on code in PR #17542:
URL: https://github.com/apache/doris/pull/17542#discussion_r1141996344
##
be/src/olap/rowset/beta_rowset_writer.h:
##
@@ -132,12 +132,15 @@ class BetaRowsetWriter : public RowsetWriter {
Status _rename_compacted_segments(int64_t begin, int64_t end);
Status _rename_compacted_segment_plain(uint64_t seg_id);
+void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
Review Comment:
warning: 'set_segment_start_id' overrides a member function but is not
marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
^
```
**be/src/olap/rowset/rowset_writer.h:94:** overridden virtual function is
here
```cpp
virtual void set_segment_start_id(int num_segment) { LOG(FATAL) << "not
supported!"; }
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17945: [chore](macOS) Specify the version of LLVM for Homebrew to install it
adonis0147 commented on PR #17945: URL: https://github.com/apache/doris/pull/17945#issuecomment-1476087631 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on pull request #17889: [fix](cooldown)Add ut for StoragePolicy
pengxiangyu commented on PR #17889: URL: https://github.com/apache/doris/pull/17889#issuecomment-1476090773 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] levy5307 opened a new pull request, #17967: [fix](fragment mgr): check duplicated pipeline fragment instance correctly
levy5307 opened a new pull request, #17967: URL: https://github.com/apache/doris/pull/17967 # Proposed changes Issue Number: close #xxx ## Problem summary `_fragment_map` has no bussiness with the pipeline version of `exec_plan_fragment` function. So we can't use it to check whether a duplicated fragment instance is coming. ## Checklist(Required) * [ ] Does it affect the original behavior * [ x ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ x ] Is this PR support rollback (If NO, please explain WHY) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17967: [fix](fragment mgr) check duplicated pipeline fragment instance correctly
github-actions[bot] commented on PR #17967: URL: https://github.com/apache/doris/pull/17967#issuecomment-1476106591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17951: [improve](Nereids): check slot from children in validator.
hello-stephen commented on PR #17951: URL: https://github.com/apache/doris/pull/17951#issuecomment-1476107411 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.65 seconds stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s stream load orc: 76 seconds loaded 1101869774 Bytes, about 13 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320120651_clickbench_pr_117375.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17967: [fix](fragment mgr) check duplicated pipeline fragment instance correctly
github-actions[bot] commented on PR #17967: URL: https://github.com/apache/doris/pull/17967#issuecomment-1476116034 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] levy5307 commented on pull request #17909: [fix](fragment mgr) fix the bug that g_fragmentmgr_prepare_latency update uncorrectly
levy5307 commented on PR #17909: URL: https://github.com/apache/doris/pull/17909#issuecomment-1476119492 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17803: [feature](multi-catalog) add specified_database_list PROPERTY for jdbc catalog
nextdreamblue commented on PR #17803: URL: https://github.com/apache/doris/pull/17803#issuecomment-1476123095 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17769: [fix](json) change int to bigint for json function
nextdreamblue commented on PR #17769: URL: https://github.com/apache/doris/pull/17769#issuecomment-1476123517 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17667: [feature](table-valued-function) add Backends table-valued-function
hello-stephen commented on PR #17667: URL: https://github.com/apache/doris/pull/17667#issuecomment-1476129363 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.39 seconds stream load tsv: 457 seconds loaded 74807831229 Bytes, about 156 MB/s stream load json: 26 seconds loaded 2358488459 Bytes, about 86 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320122127_clickbench_pr_117337.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
hello-stephen commented on PR #17963: URL: https://github.com/apache/doris/pull/17963#issuecomment-1476141535 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.77 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 76 seconds loaded 1101869774 Bytes, about 13 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320123043_clickbench_pr_117405.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #17968: [Feature](Nereids)add rule to change scalar sub-query to window function
sohardforaname opened a new pull request, #17968: URL: https://github.com/apache/doris/pull/17968 # Proposed changes Issue Number: close #xxx ## Problem summary SQL like TPC-H Q2 and Q17, which contains a correlated sub-query with only one aggregation function output, we can eliminate the sub-query and transform it to window function. For example, TPC-H Q17 is select sum(l_extendedprice) / 7.0 as avg_yearly from lineitem, part where p_partkey = l_partkey and p_brand = 'Brand#23' and p_container = 'MED BOX' and l_quantity < ( select 0.2 * avg(l_quantity) from lineitem where l_partkey = p_partkey ); we change it to select sum(l_extendedprice) / 7.0 as avg_yearly from ( select l_extendedprice, l_quantity, 0.2 * avg(l_quantity) over(partition by l_partkey) avg_l_quantity from lineitem, part where p_partkey = l_partkey and p_brand = 'Brand#23' and p_container = 'MED BOX' ) where l_quantity < avg_l_quantity ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #17968: [Feature](Nereids)add rule to change scalar sub-query to window function
sohardforaname commented on PR #17968: URL: https://github.com/apache/doris/pull/17968#issuecomment-1476145486 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17909: [fix](fragment mgr) fix the bug that g_fragmentmgr_prepare_latency update uncorrectly
hello-stephen commented on PR #17909: URL: https://github.com/apache/doris/pull/17909#issuecomment-1476169308 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.77 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320124401_clickbench_pr_117392.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17961: [fix](Nereids) should turn off parallel scan when do local finalize agg
morrySnow commented on PR #17961: URL: https://github.com/apache/doris/pull/17961#issuecomment-1476180608 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (a92115f709 -> 3661ca4510)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a92115f709 [Bug](materialized-view) fix select mv rollback fail on left join (#17850) add 3661ca4510 [Bug](regression-test) Fix the collect_set/list size limit result failed (#17963) No new revisions were added by this update. Summary of changes: .../aggregate_function_collect.h | 27 -- 1 file changed, 25 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #17963: [Bug](regression-test) Fix the collect_set/list size limit result failed
morrySnow merged PR #17963: URL: https://github.com/apache/doris/pull/17963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #17860: [ehancement](fe) Tune for stats framework
Kikyou1997 commented on PR #17860: URL: https://github.com/apache/doris/pull/17860#issuecomment-1476195595 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17961: [fix](Nereids) should turn off parallel scan when do local finalize agg
morrySnow commented on PR #17961: URL: https://github.com/apache/doris/pull/17961#issuecomment-1476199886 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #17887: [revert](function) fix AES/SM3/SM4 encrypt/ decrypt algorithm initialization vector bug
xinyiZzz commented on PR #17887: URL: https://github.com/apache/doris/pull/17887#issuecomment-1476201532 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
