github-actions[bot] commented on PR #17871:
URL: https://github.com/apache/doris/pull/17871#issuecomment-1476032386
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4467500926";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/ci/deadlink-check.sh line 20:
for file in $(find . -name "*.md"); do
^--------------------^ SC2044 (warning): For loops over find
output are fragile. Use find -exec or a while read loop.
In tools/ci/deadlink-check.sh line 21:
if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
if [[ ${file} == *"/test/resources"* ]] || [[ ${file} == *"/target"* ]];
In tools/ci/deadlink-check.sh line 23:
echo " skip $file"
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo " skip ${file}"
In tools/ci/deadlink-check.sh line 25:
markdown-link-check -c /tools/ci/.dlc.json -q "$file"
^---^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
markdown-link-check -c /tools/ci/.dlc.json -q "${file}"
For more information:
https://www.shellcheck.net/wiki/SC2044 -- For loops over find output are
fr...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ci/deadlink-check.sh.orig
+++ tools/ci/deadlink-check.sh
@@ -18,10 +18,9 @@
# print usage
for file in $(find . -name "*.md"); do
- if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
- then
- echo " skip $file"
- else
- markdown-link-check -c /tools/ci/.dlc.json -q "$file"
- fi
+ if [[ $file == *"/test/resources"* ]] || [[ $file == *"/target"* ]];
then
+ echo " skip $file"
+ else
+ markdown-link-check -c /tools/ci/.dlc.json -q "$file"
+ fi
done
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
