github-actions[bot] commented on code in PR #17542:
URL: https://github.com/apache/doris/pull/17542#discussion_r1141732677
##########
be/src/olap/rowset/beta_rowset_writer.h:
##########
@@ -133,11 +133,14 @@ class BetaRowsetWriter : public RowsetWriter {
const RowsetMetaSharedPtr&
spec_rowset_meta);
bool _is_segment_overlapping(const std::vector<KeyBoundsPB>&
segments_encoded_key_bounds);
+ void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
Review Comment:
warning: 'set_segment_start_id' overrides a member function but is not
marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
^
```
**be/src/olap/rowset/rowset_writer.h:90:** overridden virtual function is
here
```cpp
virtual void set_segment_start_id(int num_segment) { LOG(FATAL) << "not
supported!"; }
^
```
##########
be/src/olap/rowset/beta_rowset_writer.h:
##########
@@ -133,11 +133,14 @@
const RowsetMetaSharedPtr&
spec_rowset_meta);
bool _is_segment_overlapping(const std::vector<KeyBoundsPB>&
segments_encoded_key_bounds);
+ void set_segment_start_id(int32_t start_id) { _segment_start_id =
start_id; }
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
void set_segment_start_id(int32_t start_id) override { _segment_start_id
= start_id; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
