[GitHub] [doris] platoneko commented on pull request #16780: [fix](cooldown)fix bug, rename remote compaction thread
platoneko commented on PR #16780: URL: https://github.com/apache/doris/pull/16780#issuecomment-1430909185 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #16761: [feature](nereids) WIP eliminate inner/semi/cross join when any child is EmptyRelation.
englefly commented on code in PR #16761:
URL: https://github.com/apache/doris/pull/16761#discussion_r1106751609
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateInnerJoinByEmptyRelation.java:
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.plans.GroupPlan;
+import org.apache.doris.nereids.trees.plans.JoinType;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalEmptyRelation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+
+/**
+ * before:
+ * inner-join
+ * / \
+ * NodeEmptyRelation
+ *
+ * after:
+ * EmptyRelation
+ */
+
+public class EliminateInnerJoinByEmptyRelation extends OneRewriteRuleFactory {
Review Comment:
good suggestions.
but
I think it would be better to have 2 separate files.
one for join, and another for other operations.
Different type of join has different process. For example, left outer join
and inner join are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16563: [fix](fold_constant) add defer in fold constant to close and open fuzzy
github-actions[bot] commented on PR #16563: URL: https://github.com/apache/doris/pull/16563#issuecomment-1430919618 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang opened a new pull request, #16781: [fix](doc) add essential property for hive catalog on Kerberosied hms
Yulei-Yang opened a new pull request, #16781: URL: https://github.com/apache/doris/pull/16781 # Proposed changes property `hive.metastore.kerberos.principal` is essential when the principal of hms you are connecting is not the default value: hive-metastore/_HOST@your_realms。otherwise, you will get error: Failure unspecified at GSS-API level (Mechanism level: Checksum failed) Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jenson97 opened a new pull request, #16782: Features wangtao01
Jenson97 opened a new pull request, #16782: URL: https://github.com/apache/doris/pull/16782 # Proposed changes ## Problem summary I fixed an error in the document, which helped improve the comprehensibility of the document. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [√] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #16776: [Feature](map-type) Support stream load and fix some bugs for map type
xy720 commented on code in PR #16776:
URL: https://github.com/apache/doris/pull/16776#discussion_r1106747039
##
be/src/vec/data_types/data_type_map.cpp:
##
@@ -21,13 +21,22 @@
#include "vec/columns/column_array.h"
#include "vec/columns/column_map.h"
#include "vec/common/assert_cast.h"
-#include "vec/data_types/data_type_factory.hpp"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_nullable.h"
namespace doris::vectorized {
DataTypeMap::DataTypeMap(const DataTypePtr& keys_, const DataTypePtr& values_)
{
-key_type = keys_;
-value_type = values_;
+if (!keys_->is_nullable()) {
Review Comment:
use make_nullable directly here
##
be/src/vec/data_types/data_type_factory.cpp:
##
@@ -170,8 +170,8 @@ DataTypePtr DataTypeFactory::create_data_type(const
TypeDescriptor& col_desc, bo
case TYPE_MAP:
DCHECK(col_desc.children.size() == 2);
nested = std::make_shared(
-create_data_type(col_desc.children[0],
col_desc.contains_nulls[0]),
-create_data_type(col_desc.children[1],
col_desc.contains_nulls[1]));
+create_data_type(col_desc.children[0], false),
Review Comment:
Why false? It seems should be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430943138 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16649: [doc](filecache) add file cache document
github-actions[bot] commented on PR #16649: URL: https://github.com/apache/doris/pull/16649#issuecomment-1430945552 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16649: [doc](filecache) add file cache document
github-actions[bot] commented on PR #16649: URL: https://github.com/apache/doris/pull/16649#issuecomment-1430945609 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430948931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #16776: [Feature](map-type) Support stream load and fix some bugs for map type
xy720 commented on code in PR #16776:
URL: https://github.com/apache/doris/pull/16776#discussion_r1106817125
##
be/src/vec/data_types/data_type_map.cpp:
##
@@ -91,57 +162,51 @@ Status DataTypeMap::from_string(ReadBuffer& rb, IColumn*
column) const {
*(rb.end() - 1));
}
-std::stringstream keyCharset;
-std::stringstream valCharset;
-
if (rb.count() == 2) {
// empty map {} , need to make empty array to add offset
-keyCharset << "[]";
-valCharset << "[]";
+map_column->insert_default();
} else {
-// {"aaa": 1, "bbb": 20}, need to handle key and value to make key
column arr and value arr
+// {"aaa": 1, "bbb": 20}, need to handle key slot and value slot to
make key column arr and value arr
// skip "{"
++rb.position();
-keyCharset << "[";
-valCharset << "[";
+auto& keys_arr =
reinterpret_cast(map_column->get_keys());
+ColumnArray::Offsets64& key_off = keys_arr.get_offsets();
+auto& values_arr =
reinterpret_cast(map_column->get_values());
+ColumnArray::Offsets64& val_off = values_arr.get_offsets();
+
+IColumn& nested_key_column = keys_arr.get_data();
+DCHECK(nested_key_column.is_nullable());
+IColumn& nested_val_column = values_arr.get_data();
+DCHECK(nested_val_column.is_nullable());
+
+size_t element_num = 0;
while (!rb.eof()) {
-size_t kv_len = 0;
-auto start = rb.position();
-while (!rb.eof() && *start != ',' && *start != '}') {
-kv_len++;
-start++;
+StringRef key_element(rb.position(), rb.count());
+if (!next_slot_from_string(rb, key_element)) {
+return Status::InvalidArgument("Cannot read map key from text
'{}'",
+ key_element.to_string());
}
-if (kv_len >= rb.count()) {
-return Status::InvalidArgument("Invalid Length");
+StringRef value_element(rb.position(), rb.count());
+if (!next_slot_from_string(rb, value_element)) {
+return Status::InvalidArgument("Cannot read map value from
text '{}'",
+ value_element.to_string());
}
-
-size_t k_len = 0;
-auto k_rb = rb.position();
-while (kv_len > 0 && *k_rb != ':') {
-k_len++;
-k_rb++;
+ReadBuffer krb(const_cast(key_element.data),
key_element.size);
Review Comment:
Add support for null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430955427 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 merged pull request #16613: [Feature](struct-type) Add implicitly cast for struct-type
xy720 merged PR #16613: URL: https://github.com/apache/doris/pull/16613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #16547: [Roadmap] Support Struct+Map Type
xy720 closed issue #16547: [Roadmap] Support Struct+Map Type URL: https://github.com/apache/doris/issues/16547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (f50edff59d -> 0c56a4622c)
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from f50edff59d [Chore](build) enable fallthrough check annd fix some fallthrough bug (#16748) add 0c56a4622c [Feature](struct-type) Add implicitly cast for struct-type (#16613) No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/catalog/StructField.java | 10 ++- .../java/org/apache/doris/catalog/StructType.java | 11 ++- .../data/query_p0/show/test_struct_show_create.out | 4 ++ .../query_p0/show/test_struct_show_create.groovy | 79 ++ 4 files changed, 100 insertions(+), 4 deletions(-) create mode 100644 regression-test/data/query_p0/show/test_struct_show_create.out create mode 100644 regression-test/suites/query_p0/show/test_struct_show_create.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430984055 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] isHuangXin commented on issue #16560: [Enhancement] Support microseconds in function `unix_timestamp`
isHuangXin commented on issue #16560: URL: https://github.com/apache/doris/issues/16560#issuecomment-1430989813 Plz, assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16750: [Feature](Materialized-View) change mv rewrite from bottom up to up bottom && Compatible with old …
github-actions[bot] commented on PR #16750: URL: https://github.com/apache/doris/pull/16750#issuecomment-1430997144 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16750: [Feature](Materialized-View) change mv rewrite from bottom up to up bottom && Compatible with old …
github-actions[bot] commented on PR #16750: URL: https://github.com/apache/doris/pull/16750#issuecomment-1430997228 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caiconghui commented on pull request #16619: Revert "[Performance] Optimize performance of like expr using strstr()"
caiconghui commented on PR #16619: URL: https://github.com/apache/doris/pull/16619#issuecomment-1431002660 cc @weizuo93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #16750: [Feature](Materialized-View) change mv rewrite from bottom up to up bottom && Compatible with old …
BiteThet merged PR #16750: URL: https://github.com/apache/doris/pull/16750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Feature](Materialized-View) change mv rewrite from bottom up to up bottom && Compatible with old … (#16750)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new f4ed52906a [Feature](Materialized-View) change mv rewrite from bottom
up to up bottom && Compatible with old … (#16750)
f4ed52906a is described below
commit f4ed52906ac5783858f22a5e10e318b4bea986f2
Author: Pxl
AuthorDate: Wed Feb 15 17:24:46 2023 +0800
[Feature](Materialized-View) change mv rewrite from bottom up to up bottom
&& Compatible with old … (#16750)
1.change mv rewrite from bottom up to up bottom
2.compatible with old version mv
3.restore some ut codes (but disable)
4. fix some ut introduced by [fix](planner)fix bug for missing slot #16601
and [Feature](Materialized-View) support multiple slot on one column in
materialized view #16378
---
.../doris/analysis/CreateMaterializedViewStmt.java | 17 ++
.../java/org/apache/doris/analysis/QueryStmt.java | 1 +
.../main/java/org/apache/doris/catalog/Column.java | 12 ++
.../doris/catalog/MaterializedIndexMeta.java | 52 +-
.../java/org/apache/doris/catalog/OlapTable.java | 6 +-
.../main/java/org/apache/doris/catalog/Table.java | 2 +-
.../apache/doris/planner/SingleNodePlanner.java| 4 +-
.../org/apache/doris/rewrite/ExprRewriter.java | 72 +++--
.../doris/rewrite/mvrewrite/ExprToSlotRefRule.java | 2 +-
.../planner/MaterializedViewFunctionTest.java | 3 +-
.../planner/MaterializedViewSelectorTest.java | 177 +
11 files changed, 322 insertions(+), 26 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
index 5fe8244019..76c86c62b3 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
@@ -496,6 +496,23 @@ public class CreateMaterializedViewStmt extends DdlStmt {
return name;
}
+public static String oldmvColumnBreaker(String name) {
+if (name.startsWith(MATERIALIZED_VIEW_NAME_PREFIX)) {
+// mv_count_k2 -> k2
+name = name.substring(MATERIALIZED_VIEW_NAME_PREFIX.length());
+for (String prefix : FN_NAME_TO_PATTERN.keySet()) {
+if (name.startsWith(prefix)) {
+return name.substring(prefix.length() + 1);
+}
+}
+}
+if (name.startsWith(MATERIALIZED_VIEW_NAME_PREFIX)) {
+// mv_k2 -> k2
+return
mvColumnBreaker(name.substring(MATERIALIZED_VIEW_NAME_PREFIX.length()));
+}
+return name;
+}
+
public static boolean isMVColumn(String name) {
return isMVColumnAggregate(name) || isMVColumnNormal(name);
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java
index 2181d30fd3..3564cb2927 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java
@@ -281,6 +281,7 @@ public abstract class QueryStmt extends StatementBase
implements Queriable {
ExprRewriter rewriter = analyzer.getMVExprRewriter();
rewriter.reset();
rewriter.setDisableTuplesMVRewriter(disableTuplesMVRewriter);
+rewriter.setUpBottom();
Expr result = rewriter.rewrite(expr, analyzer);
if (result != expr) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java
index 3c0da6dab2..2a1f5de023 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Column.java
@@ -111,6 +111,7 @@ public class Column implements Writable,
GsonPostProcessable {
// so the define expr in RollupJob must be analyzed.
// In other cases, such as define expr in `MaterializedIndexMeta`, it may
not be analyzed after being replayed.
private Expr defineExpr; // use to define column in materialize view
+private String defineName = null;
@SerializedName(value = "visible")
private boolean visible;
@SerializedName(value = "defaultValueExprDef")
@@ -236,6 +237,17 @@ public class Column implements Writable,
GsonPostProcessable {
this.children.add(column);
}
+public void setDefineName(String defineName) {
+this.defineName = defineName;
+}
+
+public String getDefineName() {
+if (defineName != null) {
+return defineName;
+}
+return name;
+}
+
public void setName(String newName) {
this.name = newName;
}
diff -
[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition
github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1431012126 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 opened a new pull request, #16783: [enhancement](nereids)add a session variable to control join reorder algorithm
starocean999 opened a new pull request, #16783: URL: https://github.com/apache/doris/pull/16783 # Proposed changes 1. disable join reorder in nereids if **disable_join_reorder** is true. 2. add a session variable **max_table_count_use_cascades_join_reorder** to control join reorder algorithm in nereids. if dp hyper is used only when **enable_dphyp_optimizer** is true and the joined table count more than **max_table_count_use_cascades_join_reorder**, which default value is 10. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16779: [pipeline](shuffle) Improve broadcast shuffle
github-actions[bot] commented on PR #16779: URL: https://github.com/apache/doris/pull/16779#issuecomment-1431021443 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue opened a new pull request, #16784: [enhancement](profile) add profile for json& csv file converting to doris column
ByteYue opened a new pull request, #16784: URL: https://github.com/apache/doris/pull/16784 # Proposed changes Issue Number: close #xxx Previously there are no profile to monitor the time consumption of data converting to doris column, this pr mainly adds profile for json file and csv file to do so. Plus, there was no good way for us to detect which json callback used in JsonReader, i add one log to print the information. And formerly the FileReadTime profile is repetitive, which would result in one larger time than actually used. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16784: [enhancement](profile) add profile for json& csv file converting to doris column
github-actions[bot] commented on PR #16784: URL: https://github.com/apache/doris/pull/16784#issuecomment-1431030752 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache
github-actions[bot] commented on PR #16758: URL: https://github.com/apache/doris/pull/16758#issuecomment-1431031705 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16784: [enhancement](profile) add profile for json& csv file converting to doris column
github-actions[bot] commented on PR #16784: URL: https://github.com/apache/doris/pull/16784#issuecomment-1431044597 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #16785: [Opt](exec) Refactor the code and logical functions to SIMD the code
HappenLee opened a new pull request, #16785: URL: https://github.com/apache/doris/pull/16785 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16777: [feature] Make VUnionNode support conjecture logic
hello-stephen commented on PR #16777: URL: https://github.com/apache/doris/pull/16777#issuecomment-1431078592 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.94 seconds stream load tsv: 479 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215101650_clickbench_pr_96846.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16785: [Opt](exec) Refactor the code and logical functions to SIMD the code
github-actions[bot] commented on PR #16785: URL: https://github.com/apache/doris/pull/16785#issuecomment-1431080738 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue opened a new pull request, #16786: [fix](subquery) fix bug of using constexpr and some agg func(like cou…
nextdreamblue opened a new pull request, #16786: URL: https://github.com/apache/doris/pull/16786 …nt,max) as subquery's output (#16579) # Proposed changes cherry-pick from #16579 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yorkexing commented on issue #16765: [Bug] construct-docker-image error
yorkexing commented on issue #16765: URL: https://github.com/apache/doris/issues/16765#issuecomment-1431117744 https://github.com/apache/doris/blob/master/docker/runtime/be/resource/init_be.sh 这个文件有问题 #!/bin/env bash 开始的 改为 #!/bin/bash 我是这么解决的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 opened a new pull request, #16787: [chore](tools) Support starting multiple FEs on single node
adonis0147 opened a new pull request, #16787: URL: https://github.com/apache/doris/pull/16787 # Proposed changes ~~Issue Number: close #xxx~~ ## Problem summary Introduce a tool to start multiple FEs on single node. ## Use case ```shell $ ./multi-fe ./multi-fe start|stop|clean [OPTIONS ...] start -n -l -p Start the FE cluster. -n The number of FEs. -l The FE library path (default: doris/output/fe/lib) -p The base port to generate all needed ports (default: 9030). stop Stop the FE cluster. cleanStop the data (rm -rf "$(pwd)"/fe*). ``` ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yorkexing opened a new issue, #16788: [Bug] 1.2.1版本 构建 doris borker sh脚本问题
yorkexing opened a new issue, #16788: URL: https://github.com/apache/doris/issues/16788 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.1 ### What's Wrong? https://github.com/apache/doris/blob/master/docker/runtime/broker/resource/init_broker.sh 按照教程，构建镜像后，启动失败 ### What You Expected? 构建后能够启动镜像并正常运行 ### How to Reproduce? 存在3个问题 1. 未正确从环境变量中获取参数 FE_SERVERS="" BROKER_ADDR="" 需改为 FE_SERVERS=$FE_SERVERS BROKER_ADDR=$BROKER_ADDR 以便于获取docker 启动时注入参数 2. 脚本执行完后就退出了，导致docker直接退出 3. 官方文档上写的 BROKER_ADDR格式有无 https://doris.apache.org/zh-CN/docs/dev/install/construct-docker/run-docker-cluster 官方文档写的：BROKER | BROKER_ADDR | BROKER 节点主要信息 | 172.20.80.6:8000 实际上从shell脚本看，应该是：broker_name:172.20.80.6:8000，如 borker1:172.20.80.6:8000 ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu merged pull request #16780: [fix](cooldown)fix bug, rename remote compaction thread
pengxiangyu merged PR #16780: URL: https://github.com/apache/doris/pull/16780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: fix bug, rename thread (#16780)
This is an automated email from the ASF dual-hosted git repository.
pengxiangyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new fe9b2fb803 fix bug, rename thread (#16780)
fe9b2fb803 is described below
commit fe9b2fb803a40057c10fc197d16f48c1d57810da
Author: pengxiangyu
AuthorDate: Wed Feb 15 18:51:22 2023 +0800
fix bug, rename thread (#16780)
---
be/src/olap/olap_server.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/olap/olap_server.cpp b/be/src/olap/olap_server.cpp
index 409abffc47..b3a5f9a332 100644
--- a/be/src/olap/olap_server.cpp
+++ b/be/src/olap/olap_server.cpp
@@ -168,9 +168,9 @@ Status StorageEngine::start_bg_threads() {
LOG(INFO) << "remove unused remote files thread started";
RETURN_IF_ERROR(Thread::create(
-"StorageEngine", "remove_unused_remote_files_thread",
+"StorageEngine", "cold_data_compaction_producer_thread",
[this]() { this->_cold_data_compaction_producer_callback(); },
-&_remove_unused_remote_files_thread));
+&_cold_data_compaction_producer_thread));
LOG(INFO) << "cold data compaction producer thread started";
RETURN_IF_ERROR(Thread::create(
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1431148225 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16767: [improvement](filecache) split file cache into sharding directories
github-actions[bot] commented on PR #16767: URL: https://github.com/apache/doris/pull/16767#issuecomment-1431150059 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16775: [enhance](util) Split PriorityWorkStealingThreadPool into impl cpp && modernize-pass-by-value blocking_put
github-actions[bot] commented on PR #16775: URL: https://github.com/apache/doris/pull/16775#issuecomment-1431150346 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16775: [enhance](util) Split PriorityWorkStealingThreadPool into impl cpp && modernize-pass-by-value blocking_put
github-actions[bot] commented on PR #16775: URL: https://github.com/apache/doris/pull/16775#issuecomment-1431150430 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #16571: [Enhancement](HttpServer) Add http interface authentication
yangzhg commented on code in PR #16571:
URL: https://github.com/apache/doris/pull/16571#discussion_r1106974240
##
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/BackendsAction.java:
##
@@ -70,9 +67,6 @@ public class BackendsAction extends RestBaseController {
@RequestMapping(path = "/api/backends", method = {RequestMethod.GET})
public Object getBackends(HttpServletRequest request, HttpServletResponse
response) {
executeCheckPassword(request, response);
-if (Config.enable_all_http_auth) {
Review Comment:
add some comments to explain why this api without auth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr opened a new pull request, #16789: [Enhance](ComputeNode) K8sDeployManager support computeNode
zddr opened a new pull request, #16789: URL: https://github.com/apache/doris/pull/16789 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. 1.allow have no ELECTABLE or BACKEND 2.add cn NodeType 3.delete deprecated code ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16779: [pipeline](shuffle) Improve broadcast shuffle
hello-stephen commented on PR #16779: URL: https://github.com/apache/doris/pull/16779#issuecomment-1431163283 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.1 seconds stream load tsv: 474 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 35 seconds loaded 2358488459 Bytes, about 64 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215110315_clickbench_pr_97002.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on issue #16741: [Bug] create table could create column with type 'ALL'
TangSiyang2001 commented on issue #16741: URL: https://github.com/apache/doris/issues/16741#issuecomment-1431178299 Job done, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 opened a new pull request, #16790: [regression](struct-type) add more regression tests for struct-type
xy720 opened a new pull request, #16790: URL: https://github.com/apache/doris/pull/16790 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [x] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16676: [feature](Nereids): add OuterJoinAssoc rule
github-actions[bot] commented on PR #16676: URL: https://github.com/apache/doris/pull/16676#issuecomment-1431193275 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16676: [feature](Nereids): add OuterJoinAssoc rule
github-actions[bot] commented on PR #16676: URL: https://github.com/apache/doris/pull/16676#issuecomment-1431193395 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 merged pull request #16676: [feature](Nereids): add OuterJoinAssoc rule
starocean999 merged PR #16676: URL: https://github.com/apache/doris/pull/16676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](Nereids): add OuterJoinAssoc rule (#16676)
This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ecadd4b392 [feature](Nereids): add OuterJoinAssoc rule (#16676)
ecadd4b392 is described below
commit ecadd4b39284da222990352330ac3b25037d4dd6
Author: jakevin
AuthorDate: Wed Feb 15 19:19:28 2023 +0800
[feature](Nereids): add OuterJoinAssoc rule (#16676)
* move isIntersecting.
* [feature](Nereids): add OuterJoinAssoc rule
* fix bug
* fix
---
.../org/apache/doris/nereids/rules/RuleType.java | 2 +
.../rules/exploration/join/InnerJoinLAsscom.java | 4 +-
.../exploration/join/InnerJoinLAsscomProject.java | 74 --
.../rules/exploration/join/JoinReorderHelper.java | 99 ++
.../rules/exploration/join/JoinReorderUtils.java | 44 +++-
.../{OuterJoinLAsscom.java => OuterJoinAssoc.java} | 89 -
.../exploration/join/OuterJoinAssocProject.java| 111 +
.../rules/exploration/join/OuterJoinLAsscom.java | 4 +-
.../exploration/join/OuterJoinLAsscomProject.java | 98 +-
.../join/SemiJoinLogicalJoinTranspose.java | 8 +-
.../join/SemiJoinLogicalJoinTransposeProject.java | 8 +-
.../nereids/rules/rewrite/logical/ReorderJoin.java | 5 +-
.../apache/doris/nereids/util/ExpressionUtils.java | 24 -
.../org/apache/doris/nereids/util/JoinUtils.java | 36 +--
.../java/org/apache/doris/nereids/util/Utils.java | 24 +
.../rules/exploration/join/OuterJoinAssocTest.java | 72 +
.../join/OuterJoinLAsscomProjectTest.java | 28 +++---
17 files changed, 460 insertions(+), 270 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java
index 543291af89..4dfbf928fc 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java
@@ -214,6 +214,8 @@ public enum RuleType {
LOGICAL_INNER_JOIN_LASSCOM_PROJECT(RuleTypeClass.EXPLORATION),
LOGICAL_OUTER_JOIN_LASSCOM(RuleTypeClass.EXPLORATION),
LOGICAL_OUTER_JOIN_LASSCOM_PROJECT(RuleTypeClass.EXPLORATION),
+LOGICAL_OUTER_JOIN_ASSOC(RuleTypeClass.EXPLORATION),
+LOGICAL_OUTER_JOIN_ASSOC_PROJECT(RuleTypeClass.EXPLORATION),
LOGICAL_SEMI_JOIN_LOGICAL_JOIN_TRANSPOSE(RuleTypeClass.EXPLORATION),
LOGICAL_SEMI_JOIN_LOGICAL_JOIN_TRANSPOSE_PROJECT(RuleTypeClass.EXPLORATION),
LOGICAL_SEMI_JOIN_SEMI_JOIN_TRANPOSE(RuleTypeClass.EXPLORATION),
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscom.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscom.java
index 459b5f2bdb..977ef42afa 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscom.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscom.java
@@ -27,7 +27,7 @@ import org.apache.doris.nereids.trees.plans.JoinHint;
import org.apache.doris.nereids.trees.plans.JoinType;
import org.apache.doris.nereids.trees.plans.Plan;
import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
-import org.apache.doris.nereids.util.ExpressionUtils;
+import org.apache.doris.nereids.util.Utils;
import com.google.common.base.Preconditions;
@@ -111,7 +111,7 @@ public class InnerJoinLAsscom extends
OneExplorationRuleFactory {
.collect(Collectors.partitioningBy(topHashOn -> {
Set usedExprIdSet =
topHashOn.getInputSlotExprIds();
Set bOutputExprIdSet =
bottomJoin.right().getOutputExprIdSet();
-return ExpressionUtils.isIntersecting(bOutputExprIdSet,
usedExprIdSet);
+return Utils.isIntersecting(bOutputExprIdSet,
usedExprIdSet);
}));
// * don't include B, just include (A C)
// we add it into newBottomJoin HashJoinConjuncts.
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java
index 8a3fe670b0..aac195cb3a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java
@@ -20,28 +20,23 @@ package org.apache.doris.nereids.rules.exploration.join;
import org.apache.doris.nereids.rules.Rule;
import org.apache.doris.nereids.rules.RuleType;
import org.apache.doris.nereids.rules.exploration.OneExplorationRuleFactory;
-import org.apache.doris.ner
[GitHub] [doris-flink-connector] GoGoWen opened a new pull request, #102: [Fix](flink-connector)fix stream load exit unnormally as concurrency issue
GoGoWen opened a new pull request, #102: URL: https://github.com/apache/doris-flink-connector/pull/102 # Proposed changes Issue Number: close #100 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16733: [feature](docker)Add Docker Broker Init Script
morningman commented on code in PR #16733:
URL: https://github.com/apache/doris/pull/16733#discussion_r1107000991
##
docker/runtime/broker/resource/init_broker.sh:
##
@@ -16,95 +16,178 @@
# specific language governing permissions and limitations
# under the License.
-FE_SERVERS=""
-BROKER_ADDR=""
+set -eo pipefail
+shopt -s nullglob
-ARGS=$(getopt -o -h: --long fe_servers:,broker_addr: -n "$0" -- "$@")
+DORIS_HOME="/opt/apache-doris"
-eval set -- "${ARGS}"
+# Obtain necessary and basic information to complete initialization
-while [[ -n "$1" ]]; do
-case "$1" in
---fe_servers)
-FE_SERVERS=$2
-shift
-;;
---broker_addr)
-BROKER_ADDR=$2
-shift
-;;
---) ;;
+# logging functions
+# usage: doris_[note|warn|error] $log_meg
+#ie: doris_warn "task may BROKER risky!"
+# out: 2023-01-08T19:08:16+08:00 [Warn] [Entrypoint]: task may BROKER risky!
+doris_log() {
+ local type="$1"
+ shift
+ # accept argument string or stdin
+ local text="$*"
+ if [ "$#" -eq 0 ]; then text="$(cat)"; fi
+ local dt="$(date -Iseconds)"
+ printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
+}
+doris_note() {
+ doris_log Note "$@"
+}
+doris_warn() {
+ doris_log Warn "$@" >&2
+}
+doris_error() {
+ doris_log ERROR "$@" >&2
+ exit 1
+}
-*)
-echo "Error option $1"
-break
-;;
-esac
-shift
-done
-
-#echo FE_SERVERS = $FE_SERVERS
-echo "DEBUG >> FE_SERVERS=[${FE_SERVERS}]"
-echo "DEBUG >> BROKER_ADDR=[${BROKER_ADDR}]"
+# check to see if this file is BROKERing run or sourced from another script
+_is_sourced() {
+ [ "${#FUNCNAME[@]}" -ge 2 ] &&
+[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
+[ "${FUNCNAME[1]}" = 'source' ]
+}
-feIpArray=()
-feEditLogPortArray=()
+# Check the variables required for startup
+docker_required_variables_env() {
+ if [[ $FE_SERVERS =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
+doris_warn "FE_SERVERS" $FE_SERVERS
+ else
+doris_error "FE_SERVERS rule error！example:
\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT[,\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT]..."
+ fi
+ if [[ $BROKER_ADDR =~
^[a-zA-Z0-9]+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}$
]]; then
+doris_warn "BROKER_ADDR" $BROKER_ADDR
+ else
+doris_error "BROKER_ADDR rule error！example:
\$BROKER_NAME:\$BROKER_HOST_IP:\$BROKER_IPC_PORT"
+ fi
+}
-IFS=","
-# shellcheck disable=SC2206
-feServerArray=(${FE_SERVERS})
-
-for i in "${!feServerArray[@]}"; do
-val=${feServerArray[i]}
+get_doris_broker_args() {
+ local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," "); print
$0}'))
+ for i in "${feServerArray[@]}"; do
+val=${i}
val=${val// /}
tmpFeId=$(echo "${val}" | awk -F ':' '{ sub(/fe/, ""); sub(/ /, "");
print$1}')
tmpFeIp=$(echo "${val}" | awk -F ':' '{ sub(/ /, ""); print$2}')
tmpFeEditLogPort=$(echo "${val}" | awk -F ':' '{ sub(/ /, ""); print$3}')
-feIpArray[tmpFeId]=${tmpFeIp}
-feEditLogPortArray[tmpFeId]=${tmpFeEditLogPort}
-done
+check_arg "tmpFeIp" $tmpFeIp
+feIpArray[$tmpFeId]=${tmpFeIp}
+check_arg "tmpFeEditLogPort" $tmpFeEditLogPort
+feEditLogPortArray[$tmpFeId]=${tmpFeEditLogPort}
+ done
-broker_name=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, ""); print$1}')
-broker_ip=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, ""); print$2}')
-broker_ipc_port=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, "");
print$3}')
+ declare -g MASTER_FE_IP BROKER_HOST_IP BROKER_IPC_PORT BROKER_NAME
+ MASTER_FE_IP=${feIpArray[1]}
+ check_arg "MASTER_FE_IP" $MASTER_FE_IP
+ BROKER_NAME=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, ""); print$1}')
+ check_arg "BROKER_NAME" $BROKER_NAME
+ BROKER_HOST_IP=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, "");
print$2}')
+ check_arg "BROKER_HOST_IP" $BROKER_HOST_IP
+ BROKER_IPC_PORT=$(echo "${BROKER_ADDR}" | awk -F ':' '{ sub(/ /, "");
print$3}')
+ check_arg "BROKER_IPC_PORT" $BROKER_IPC_PORT
-echo "DEBUG >> feIpArray = ${feIpArray[*]}"
-echo "DEBUG >> feEditLogPortArray = ${feEditLogPortArray[*]}"
-echo "DEBUG >> masterFe = ${feIpArray[1]}:${feEditLogPortArray[1]}"
-echo "DEBUG >> broker_addr = ${broker_ip}:${broker_ipc_port}"
+ doris_note "feIpArray = ${feIpArray[*]}"
+ doris_note "feEditLogPortArray = ${feEditLogPortArray[*]}"
+ doris_note "masterFe = ${feIpArray[1]}:${feEditLogPortArray[1]}"
+ doris_note "brokerAddr = ${BROKER_NAME}:${BROKER_HOST_IP}:${BROKER_IPC_PORT}"
+ # wait fe start
+ check_broker_status true
+}
-dropMySQL="/usr/bin/mysql -uroot -P9030 -h${feIpArray[1]} -e \"alter system
drop broker ${broker_name} '${broker_ip}:${broker_ipc_port}'\""
-echo "DEBUG >> dropMySQL = ${dropMySQL}"
-eval "${dropMySQL}" && echo "DEBUG >> dro
[GitHub] [doris] github-actions[bot] commented on pull request #16733: [feature](docker)Add Docker Broker Init Script
github-actions[bot] commented on PR #16733: URL: https://github.com/apache/doris/pull/16733#issuecomment-1431209183 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16733: [feature](docker)Add Docker Broker Init Script
github-actions[bot] commented on PR #16733: URL: https://github.com/apache/doris/pull/16733#issuecomment-1431209001 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (ecadd4b392 -> 611d9aca10)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ecadd4b392 [feature](Nereids): add OuterJoinAssoc rule (#16676) add 611d9aca10 [feature](docker)Add Docker Broker Init Script (#16733) No new revisions were added by this update. Summary of changes: docker/runtime/broker/resource/init_broker.sh | 229 ++ 1 file changed, 156 insertions(+), 73 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #16733: [feature](docker)Add Docker Broker Init Script
morningman merged PR #16733: URL: https://github.com/apache/doris/pull/16733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] FreeOnePlus opened a new pull request, #16791: [fix](docker)Fix Dockerfile logic
FreeOnePlus opened a new pull request, #16791: URL: https://github.com/apache/doris/pull/16791 # Proposed changes Error log logic fix. Remove Chinese annotations. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] JNSimba commented on issue #100: [Bug] (concurrency) Thread safety problem of loading data to Doris
JNSimba commented on issue #100: URL: https://github.com/apache/doris-flink-connector/issues/100#issuecomment-1431240428 > But method DorisStreamLoad.handlePreCommitResponse() may be invoked by exception checker thread before loading is set to true by main thread. In the **checkdone** method, when loading is false, it will be skipped directly, should this problem be avoided? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow opened a new pull request, #16792: Revert "[test](pipeline) Run nereids cases in p1/p2 (#16130)"
morrySnow opened a new pull request, #16792: URL: https://github.com/apache/doris/pull/16792 This reverts commit b480db2e119ac0516e8621ea3d53c40f250c1d24. remove nereids p1/p2 cases provisionally. add it back batch-wise # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16792: Revert "[test](pipeline) Run nereids cases in p1/p2 (#16130)"
github-actions[bot] commented on PR #16792: URL: https://github.com/apache/doris/pull/16792#issuecomment-1431253168 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16792: Revert "[test](pipeline) Run nereids cases in p1/p2 (#16130)"
github-actions[bot] commented on PR #16792: URL: https://github.com/apache/doris/pull/16792#issuecomment-1431253219 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] GoGoWen commented on issue #100: [Bug] (concurrency) Thread safety problem of loading data to Doris
GoGoWen commented on issue #100: URL: https://github.com/apache/doris-flink-connector/issues/100#issuecomment-1431256720 this should be an issue like https://github.com/apache/doris-flink-connector/pull/102. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16563: [fix](fold_constant) add defer in fold constant to close and open fuzzy
github-actions[bot] commented on PR #16563: URL: https://github.com/apache/doris/pull/16563#issuecomment-1431267879 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt opened a new pull request, #16793: [bugfix](reader) make segment_overlapping meta correct
yixiutt opened a new pull request, #16793: URL: https://github.com/apache/doris/pull/16793 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16793: [bugfix](reader) make segment_overlapping meta correct
github-actions[bot] commented on PR #16793: URL: https://github.com/apache/doris/pull/16793#issuecomment-1431278191 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16783: [enhancement](nereids)add a session variable to control join reorder algorithm
hello-stephen commented on PR #16783: URL: https://github.com/apache/doris/pull/16783#issuecomment-1431289438 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.87 seconds stream load tsv: 477 seconds loaded 74807831229 Bytes, about 149 MB/s stream load json: 36 seconds loaded 2358488459 Bytes, about 62 MB/s stream load orc: 70 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215122508_clickbench_pr_97009.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16734: [Opt](exec) opt aggreate function performance in nullable column
github-actions[bot] commented on PR #16734: URL: https://github.com/apache/doris/pull/16734#issuecomment-1431297833 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener opened a new pull request, #16794: [fix](Nereids): fix Master Bors problem.
jackwener opened a new pull request, #16794: URL: https://github.com/apache/doris/pull/16794 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [x] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [x] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin opened a new pull request, #16795: [fix](insert) fix be core dump due to using the wrong schema to create column writers
luozenglin opened a new pull request, #16795: URL: https://github.com/apache/doris/pull/16795 # Proposed changes Issue Number: close #16658 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luzhijing opened a new pull request, #16796: [comunity](team) add new PMC members and committers
luzhijing opened a new pull request, #16796: URL: https://github.com/apache/doris/pull/16796 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16779: [pipeline](shuffle) Improve broadcast shuffle
github-actions[bot] commented on PR #16779: URL: https://github.com/apache/doris/pull/16779#issuecomment-1431300374 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16779: [pipeline](shuffle) Improve broadcast shuffle
github-actions[bot] commented on PR #16779: URL: https://github.com/apache/doris/pull/16779#issuecomment-1431300434 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16795: [fix](insert) fix be core dump due to using the wrong schema to create column writers
github-actions[bot] commented on PR #16795: URL: https://github.com/apache/doris/pull/16795#issuecomment-1431303360 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16796: [comunity](team) add new PMC members and committers
github-actions[bot] commented on PR #16796: URL: https://github.com/apache/doris/pull/16796#issuecomment-1431304125 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16796: [comunity](team) add new PMC members and committers
github-actions[bot] commented on PR #16796: URL: https://github.com/apache/doris/pull/16796#issuecomment-1431304180 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary closed issue #16749: [Enhancement](Es) Support array inner type in fe
stalary closed issue #16749: [Enhancement](Es) Support array inner type in fe URL: https://github.com/apache/doris/issues/16749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16787: [chore](tools) Support starting multiple FEs on single node
hello-stephen commented on PR #16787: URL: https://github.com/apache/doris/pull/16787#issuecomment-1431315412 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.52 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 36 seconds loaded 2358488459 Bytes, about 62 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215124738_clickbench_pr_97055.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] DarvenDuan commented on issue #100: [Bug] (concurrency) Thread safety problem of loading data to Doris
DarvenDuan commented on issue #100: URL: https://github.com/apache/doris-flink-connector/issues/100#issuecomment-1431320283 > > But method DorisStreamLoad.handlePreCommitResponse() may be invoked by exception checker thread before loading is set to true by main thread. > > In the **checkdone** method, when loading is false, it will be skipped directly, should this problem be avoided? Thank you for your replay, I'm sorry that my description had something wrong, it should be "But method `DorisStreamLoad.handlePreCommitResponse()` may be invoked by exception checker thread before `loading` is set to `false` by main thread" , Exactly InterruptException may be cased by `dorisStreamLoad.getPendingLoadFuture()`. When doing checkpoint, method `dorisStreamLoad.startLoad()` will be invoked and changes `pendingLoadFuture`, but in `checkDone()` `dorisStreamLoad.getPendingLoadFuture()` may get old pendingLoadFuture. PR #102 may fix this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann opened a new pull request, #16797: [feature](Nereids): add rule split limit into two phase
XieJiann opened a new pull request, #16797: URL: https://github.com/apache/doris/pull/16797 # Proposed changes Add a rule split limit, like before: Limit(Origin) after: Limit(Global) -> Gather -> Limit(Local) And because this rule is always beneficial, we add a rule in rewrite lab ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #16767: [improvement](filecache) split file cache into sharding directories
platoneko commented on code in PR #16767:
URL: https://github.com/apache/doris/pull/16767#discussion_r1107093171
##
be/src/io/cache/block/block_file_cache.cpp:
##
@@ -32,6 +32,9 @@ namespace fs = std::filesystem;
namespace doris {
namespace io {
+const std::string IFileCache::FILE_CACHE_VERSION = "2.0";
+const int IFileCache::KEY_PREFIX_LENGTH = 3;
Review Comment:
`const` -> `constexpr` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16785: [Opt](exec) Refactor the code and logical functions to SIMD the code
hello-stephen commented on PR #16785: URL: https://github.com/apache/doris/pull/16785#issuecomment-1431333846 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.96 seconds stream load tsv: 484 seconds loaded 74807831229 Bytes, about 147 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215130148_clickbench_pr_97037.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1431334078 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt opened a new pull request, #16798: [doc](enhancement) fix some style
yixiutt opened a new pull request, #16798: URL: https://github.com/apache/doris/pull/16798 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16793: [bugfix](reader) make segment_overlapping meta correct
github-actions[bot] commented on PR #16793: URL: https://github.com/apache/doris/pull/16793#issuecomment-1431368841 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16793: [bugfix](reader) make segment_overlapping meta correct
github-actions[bot] commented on PR #16793: URL: https://github.com/apache/doris/pull/16793#issuecomment-1431368909 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liaoxin01 opened a new pull request, #16799: [enhancement](merge-on-write) do compaction with merge on read
liaoxin01 opened a new pull request, #16799: URL: https://github.com/apache/doris/pull/16799 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16799: [enhancement](merge-on-write) do compaction with merge on read
github-actions[bot] commented on PR #16799: URL: https://github.com/apache/doris/pull/16799#issuecomment-1431377043 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16789: [Enhance](ComputeNode) K8sDeployManager support computeNode
hello-stephen commented on PR #16789: URL: https://github.com/apache/doris/pull/16789#issuecomment-1431377602 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.9 seconds stream load tsv: 479 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215133325_clickbench_pr_97081.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache
github-actions[bot] commented on PR #16758: URL: https://github.com/apache/doris/pull/16758#issuecomment-1431387966 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16785: [Opt](exec) Refactor the code and logical functions to SIMD the code
github-actions[bot] commented on PR #16785: URL: https://github.com/apache/doris/pull/16785#issuecomment-1431406984 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16793: [bugfix](reader) make segment_overlapping meta correct
hello-stephen commented on PR #16793: URL: https://github.com/apache/doris/pull/16793#issuecomment-1431408276 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.88 seconds stream load tsv: 471 seconds loaded 74807831229 Bytes, about 151 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230215135550_clickbench_pr_97130.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift messages
HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107166746
##
be/src/exec/data_sink.cpp:
##
@@ -177,6 +177,146 @@ Status DataSink::create_data_sink(ObjectPool* pool, const
TDataSink& thrift_sink
return Status::OK();
}
+Status DataSink::create_data_sink(ObjectPool* pool, const TDataSink&
thrift_sink,
+ const std::vector& output_exprs,
+ const TPipelineParams& params, const size_t&
local_param_idx,
+ const RowDescriptor& row_desc, RuntimeState*
state,
+ std::unique_ptr* sink,
DescriptorTbl& desc_tbl) {
+DataSink* tmp_sink = nullptr;
+TPipelineLocalParams local_params = params.local_params[local_param_idx];
Review Comment:
here may be do copy？ use `const auto&`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #16779: [pipeline](shuffle) Improve broadcast shuffle
Gabriel39 merged PR #16779: URL: https://github.com/apache/doris/pull/16779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (611d9aca10 -> dd06cc7609)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 611d9aca10 [feature](docker)Add Docker Broker Init Script (#16733) add dd06cc7609 [pipeline](shuffle) Improve broadcast shuffle (#16779) No new revisions were added by this update. Summary of changes: be/src/vec/sink/vdata_stream_sender.cpp | 60 - be/src/vec/sink/vdata_stream_sender.h | 1 + 2 files changed, 31 insertions(+), 30 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift messages
HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107167131
##
be/src/pipeline/pipeline_fragment_context.cpp:
##
@@ -272,6 +273,139 @@ Status PipelineFragmentContext::prepare(const
doris::TExecPlanFragmentParams& re
return Status::OK();
}
+Status PipelineFragmentContext::prepare(const doris::TPipelineParams& request,
const size_t idx) {
+if (_prepared) {
+return Status::InternalError("Already prepared");
+}
+TPipelineLocalParams local_params = request.local_params[idx];
Review Comment:
same to up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift messages
HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107171484
##
gensrc/thrift/PaloInternalService.thrift:
##
@@ -553,3 +553,45 @@ struct TExportStatusResult {
2: required Types.TExportState state
3: optional list files
}
+
Review Comment:
Better name
`TPipelineLocalParams` -> `TPipelineInstanceParams`
`TPipelineParams ` -> `TPipelineQueryParams`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift messages
HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107171836
##
gensrc/thrift/PaloInternalService.thrift:
##
@@ -553,3 +553,45 @@ struct TExportStatusResult {
2: required Types.TExportState state
3: optional list files
}
+
Review Comment:
Better name
`TPipelineLocalParams` -> `TPipelineInstanceParams`
`TPipelineParams ` -> `TPipelineQueryParams`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift messages
HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107171836
##
gensrc/thrift/PaloInternalService.thrift:
##
@@ -553,3 +553,45 @@ struct TExportStatusResult {
2: required Types.TExportState state
3: optional list files
}
+
Review Comment:
Better name
`TPipelineLocalParams` -> `TPipelineInstanceParams`
`TPipelineParams ` -> `TPipelineFragmentParams`
`TPipelineParamsList` -> `TPipelineFragmentParamsList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition
github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1431430821 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
